',
+ 'before' => '
',
'after' => '
'
), 'get_reply_author_role' );
}}}
" netweb
3407 Docs: Fix typo in /core/functions.php inline DocBlock General trunk normal normal 2.7 defect (bug) new has-patch 2020-10-28T04:29:48Z 2022-03-08T20:45:41Z Fix inline documentation. dilipbheda
2798 Redirection loop to homepage after installing bbPress 2.6 (admin lockout) General trunk normal normal 2.7 defect (bug) new reporter-feedback 2015-05-05T08:09:23Z 2015-07-15T20:18:44Z "Hi,
After installing version alpha 2.6, I came accross the following bug.
At first, nothing was going on, as long as I kept logged in after the install. However, after I wanted to login in my admin panel after the initial installation 3 hours later, a problem emerged.
I found out that the bbPress 2.6 installation on my WP 4.2.1 platform results in a redirection loop to my homepage, locking myself (admin) continously out. The funny thing is that I am actually logged in. I can see that in the forum at the front end.
Platform details:
- WordPress Version:WP 4.2.1
- Web Server Info:Apache
- PHP Version:5.5.17
- WP Memory Limit:192 MB
- WP Max Upload Size:100 MB
- PHP Time Limit:120
- WP Debug Mode:Disabled
When I click on my backend tab in Chrome, which normally loads:
http://www.wordpress.spiritueleverlichting.nl/wp-login.php
I am redirected to the homepage, though I am actually logged in.
I have tried the following:
- deactivating all plugins, to no avail
- switching themes (to twenty-fifteen), to no avail
- asking support from Siteground, everything is set up correctly according to them
- clear all cache
Via FTP I change the bbPress folder name so I am able to access the backend. Once logged in, I change the folder name back to its original name.
What is interesting is that when I log out while bbPress activited, the following URL emerges after the log out:
http://www.wordpress.spiritueleverlichting.nl/wp-login.php?redirect_to=http%3A%2F%2Fwww.wordpress.spiritueleverlichting.nl%2Fwp-admin%2Findex.php%3Fpage%3Dbbp-about%26loggedout%3Dtrue&reauth=1
And in my error log, I found the following script:
mod_hive matched URI – normal admin URL – with match 2, referer: – admin URL with redirection
Hopefully you find this info valueable :-)
Best regards,
Bark" Bark
2581 Topic and forum favorite and subscription filters netweb General normal normal 2.7 defect (bug) new 2014-04-07T08:21:57Z 2015-02-05T22:48:38Z "
bbpress/includes/topics/template.php has errors
1. wrong parse call
function bbp_get_topic_subscription_link
......Parse the arguments......
'get_forum_subscribe_link' );
so the function is ‘get_topic_subscription’ but the parse argument reverts to ‘get_forum_subscribe‘
2. wrong parse call
this error is repeated for favorites in the same file
function bbp_get_topic_favorite_link
.......... 'get_forum_favorite_link' );
needs changing to ‘get_topic_favorite_link’`
3. parse in bbp_get_topic_subscription_link redundant
This function calls bbp_get_user_subscribe_link which immediately resets all these parameters. This parse in this function should be removed to prevent false filtering" Robin W
3503 bbp_get_reply_url() generates incorrect paginated urls for topics with hidden replies General 2.0 normal normal 2.6.10 defect (bug) new reporter-feedback 2022-12-02T00:07:31Z 2022-12-05T01:08:13Z "bbp_get_reply_url() is used within emails to link to a paged topic URL for a reply within a topic.
However, this function can generate the incorrect pagination URL for replies when a topic has hidden replies - because they're spammed, or in the case of WordPress.org/support 'archived'.
Take this example, where there's 2 replies per page displayed:
{{{
1. Thread post
2. Reply 1
3. Reply 2 <-- Spammed.
4. Reply 3
}}}
When a non-moderator views the above thread, they'll see a single-page of replies. Reply 1 and Reply 3. When a moderator views it, they'll see two-pages of replies with all three replies.
However, in both cases, `bbp_get_reply_url( $reply_3 )` will return `topic/page/2` and for the non-moderator following that link, will land on a page with no replies, as the ""correct"" link was `topic/`.
This leads to a lot of confusion.
I see several options:
- Have `bbp_get_reply_url()` actually count the replies visible, rather than using the cached reply_position value.
- Have `bbp_get_reply_url()` never return a pretty-url, and instead use a url such as `topic/?reply=123` and redirect to the appropriate paged url upon request
- Have `bbp_get_reply_position_raw()` not give a reply_position to hidden replies.
All of those have one thing in common: The URL to individual replies will constantly change, as the pagination location of the reply is never truely known.
Another option is that when displaying threads, hidden replies should be taken into account, so in the above example, with 2 replies per page, everyone would only see 1 reply on Page 1, and 1 reply on Page 2. Arguably a worse-experience.
This was reported as #meta6443" dd32
3195 bbp_get_topic_replies_link doesn't respect pagination for extra links johnjamesjacoby General high normal 2.7 defect (bug) new 2018-03-10T09:59:37Z 2018-03-26T15:54:45Z "When creating the extra links (for viewing hidden replies) the call to `bbp_get_topic_replies_link()` uses the primary permalink of the topic, and appends a `?view=all` to it.
This then drops any pagination from the string, so if you were on page 3, you would get sent back to page 1.
One reason for this might be that page 1 has hidden entries as well though, so this is likely a discussion point." Clorith
2204 bbpress OR wp_nav_menu fails to set current_page_parent for forum-index page and children hirarchy johnjamesjacoby General 2.2.3 normal normal 2.7 defect (bug) new has-patch 2013-02-09T13:59:25Z 2015-05-10T09:19:23Z "I am reporting this issue, as it seems a very many people are facing the issue, and although a ticket was generated in the past (I can't find it now) for the same topic 1-2 years back, It wasn't considered worth the effort then because the priorities were obviously on core functionalities. I guess now things are different.
I came across this problem in multiple current installation of wp 3.5, bp 1.6.4 and bbp 2.2, but the issue isn't version specific (as it was there 1-2 years back as well.)
The problem is essentially this. When a bbpress is installed (with or without buddypress). the user needs to create a page called forum to show the forums link in navigation menu, and to make the forum listing available to the users/subscribers. There are multiple ways to do this, including one way that does not create any new page but refers to the forums by adding a custom link in the menu referring to www.example.com/forum_base-slug (by default forums). In any of these ways, the forums functionality works fine, but the 'forums' menu item (in wp_nav_manu) doesn't get proper classes, that may highlight/differentiate that menu-item as current/active. The problem is encountered mostly, when the 'forums' link (even by any other name, say discussions) is a sub-item or a menu item like community > Forums. All the buddypress components work perfectly fine, highlighting the 'community' menu item, if the user is viewing any sub-item or sub-sub-sub item, so the problem is bbpress specific.
Inspecting the page source reveals that the current_page_parent class is attributed to some other page, however, that page is also not highlighted, as it seems it needs more than one classes to be attributed.
Further, the 'forums' menu is not highlighted when child items like an individual forum or topics are visited by the users current_page_ancestor also not attributed in such cases. this is the case with testbp.org, where ""discussions"" menu item is current/active only when you are viewing the forum index. any deeper, the highlight is lost.
Also, the problem is not there with 'support' menu item of buddypress.org or bbpress.org, where the 'support' menu item remains highlighted, irrespective of which forum page/topic the user is on. This is the correct behavior, which is broaken/needs repair in current version(s)." Mitesh Patel
3161 main query fires 404_template filter hook if a forum member has no posts johnjamesjacoby General normal normal 2.7 defect (bug) new 2017-09-07T18:32:05Z 2018-02-16T22:42:14Z "The WP main query fires the ''404_template'' filter hook if the member has not created any posts.
'''How to reproduce this issue:'''
Add the following code e.g. to functions.php of the Theme:
{{{
add_filter( '404_template', function() {
global $wp_query;
print_r( $wp_query );
die();
} );
}}}
Create a new forum user and access his profile page on front end. The ''404_template'' filter hook fires.
'''Problem Description:'''
bbPress adds several rewrite rules for ''bbp_user''. The ''bbp_parse_query()'' function sets ''posts_query->is_404'' to ''false'' but this is '''before''' the query is executed.
Adding bbp_user to the query results in a main query like the following:
{{{
SELECT SQL_CALC_FOUND_ROWS wp_posts.ID
FROM wp_posts
WHERE 1 = 1
AND ( wp_posts.post_author = 2 )
AND wp_posts.post_type = 'post'
AND ( wp_posts.post_status = 'publish'
OR wp_posts.post_status = 'closed'
OR wp_posts.post_status = 'private'
OR wp_posts.post_status = 'hidden'
)
ORDER BY wp_posts.post_date DESC LIMIT 0, 10
}}}
If the user with the ID 2 has no posts created the result of this query is empty. After executing the query ''$wp_query->is_404'' is ''true''. This causes ''wp-includes/template-loader.php'' to call the WP core function ''get_404_template()'' which calls ''get_query_template('404')'' - defined in ''wp-includes/template.php''. This fires the ''404_template'' hook.
This has no effect for the template loader because bbPress adds the ''bbp_template_include_theme_supports()'' function to the ''template_include'' filter hook. If ''$wp_query->bbp_is_single_user'' is set to ''true'' the single user template is loaded, before ''$wp_query->is_404'' ist tested.
But the ''404_template'' filter hook fires, which is not correct because there is nor 404 error! Every plugin that uses this filter - like mine - would have to check if ''$wp_query->bbp_is_single_user'' is set to ''true'' to avoid this. But this only bypasses the problem and does not really solve it.
'''Solution:'''
''$wp_query->is_404'' has to be reset to ''false'' in case of ''$wp_query->bbp_is_single_user'' is ''true'' straight after the query is executed before the template loader runs." petersplugins
2037 Help on Forum Settings missing items johnjamesjacoby General - Administration 2.2 low minor 2.7 defect (bug) new dev-feedback 2012-11-19T20:12:31Z 2015-07-02T05:26:34Z "On the help screen on the main forum settings page, it seems that a few of the newly added settings didn't make it.
Revisions, Default user role, and auto role are missing from the main settings help. Revisions might of been intentional since that is self explanatory, but I think default user role and auto role should have some good description for users looking to understand what exactly they do." jaredatch
3069 author metabox shows unfiltered IP address General - Administration trunk normal normal 2.7 defect (bug) new 2017-02-26T13:07:48Z 2017-11-09T20:18:09Z "This concerns the function bbp_author_metabox in src/includes/admin/metaboxes.php; in that function the 'bbp_get_author_ip' filter is not applied when fetching the author's ip address for display into the user interface:
https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/metaboxes.php#L636
I believe that the bbp_author_ip function should be used there, instead of a raw get_post_meta call, as bbp_author_ip applies the filter properly; see
https://bbpress.trac.wordpress.org/browser/trunk/src/includes/users/template.php#L587
The bbp_author_ip function also appears to be used a lot elsewhere in the code to display author's ip addresses.
A screenshot is attached showing an example of where the problem occurs, when editing replies via the admin interface. Actual IP address is blurred out for security reasons.
(I ran into this trying to hide IP addresses from the user interface via the 'bbp_get_author_ip' filter.)" mattiejas
2950 Duplicate reply detection can be fooled with a return General - Content Creation low minor 2.7 defect (bug) new 2016-05-08T13:01:24Z 2023-11-17T20:13:12Z "bbPress duplicate replies can be fooled by adding a return at the end of a post. bbPress strips this return in the final submission, but it's not considered at duplicate reply detection.
I tested it here:
https://bbpress.org/forums/topic/php7-compatibility/#post-174704
[[Image(http://i.imgur.com/I6Gxztg.png)]]" rmens
3389 First edit of a topic does not get added to revision history johnjamesjacoby General - Content Creation 2.0 high normal 2.7 defect (bug) assigned has-patch 2020-08-09T07:55:08Z 2021-02-07T16:16:48Z "When a moderator or higher goes to edit a topic, for whatever reason, the very first edit will not be added to the revisions.
Any subsequent edits are stored as intended, with that first edit being treated as the initial text.
This is likely due to how WordPress views a new post, where the post, and an automatic autosave are created first, and only the 3rd entry onward are treated as revisions.
Perhaps an automated autosave needs to be created alongside any new topic to resolve this (I've not tested if that's the definite cause, but it's something I notice when glancing over)." Clorith
3138 Only load core CSS+JS on bbPress pages johnjamesjacoby General - Performance normal normal 2.7 defect (bug) reopened 2017-08-03T09:30:53Z 2018-04-04T17:44:08Z "With BBP 2.6-rc3, bbPress is loading editor.min.js and bbpress.min.css on every screen on a wordpress site, even and especially those screens that have no bbPress content. It's easy to find examples in the wild, here's one: https://wordpress.org/support/
A simple change like this https://gist.github.com/anonymous/1287f6e5b925b13250e82f823513fa9b prevents those core assets being requested unnecessarily on every screen. With the shortcode support in is_bbpress() in 2.6, I've not found a problem yet doing this." DJPaul
3203 Performance issues when deleting a topic johnjamesjacoby General - Performance trunk normal normal 2.7 defect (bug) new dev-feedback 2018-06-13T06:15:13Z 2019-04-17T21:35:45Z "While deleting a topic in a very large database (like 4G or more) with a numerous of replies per topic. I've noticed that trashing topics will last for more than a minute or more.
With this, the server timeouts (in Nginx we got 504 gateway timeout). I've investigated this and found that when a topic is deleted, BBpress loops over replies and deletes one of them.
The issue is that when BBpress loops over replies and deletes it, it does repeated expensive queries to `get_posts()` or `WP_Query` without any object caching.
I fixed this by patching the slow lines in `includes/forums/functions.php` with WordPress Object Cache methods. This speeds up the deletion numerous times from more than 2 minutes in some cases down to only seconds.
I'm attaching the diff of the patch based from the latest trunk so you can review and hopefully incorporate this to the coming release of BBpress." codex-m
2931 Various conditional tags returning `true` when they should be `false` General - Performance 2.0 normal normal 2.7 defect (bug) new dev-feedback 2016-04-14T09:37:31Z 2017-04-16T02:11:54Z "Each of the cases below return `true` and should not:
Forum root: http://src.wordpress-develop.dev/forums/
• `bbp_is_forum_open()`
• `bbp_is_forum_public()`
• `bbp_is_reply_anonymous()`
• `bbp_is_topic_anonymous()`
• `bbp_is_reply_published()`
• `bbp_is_topic_published()`
• `bbp_is_group_forums_active()` <- This was `true` after deactivating BP
Single Forum: http://src.wordpress-develop.dev/forums/forum/bbp-public-forum/
• `bbp_is_reply_published()`
• `bbp_is_topic_published()`
• `bbp_is_group_forums_active()` <- This was `true` after deactivating BP
BuddyPress Group Single Forum: http://src.wordpress-develop.dev/groups/bp-public-group/forum/
• `bbp_is_reply_anonymous()`
• `bbp_is_topic_anonymous()`
• `bbp_is_reply_published()`
• `bbp_is_topic_published()`
• `bbp_is_group_forums_active()` <- This was `true` after deactivating BP
BuddyPress Group Single Topic: http://src.wordpress-develop.dev/groups/bp-public-group/forum/topic/test-topic/
• `bbp_is_reply_anonymous()`
• `bbp_is_reply_published()`
• `bbp_is_topic_published()`
• `bbp_is_group_forums_active()` <- This was `true` after deactivating BP
Single Topic: http://src.wordpress-develop.dev/forums/topic/bbp-public-topic/
• `bbp_is_reply_published()`
• `bbp_is_group_forums_active()` <- This was `true` after deactivating BP
Fun Fact: My entire dev site doesn't have any replies whatsoever" netweb
2876 freshness repair tool incorrect and conflation of ID and post_date General - Performance high normal 2.7 defect (bug) new has-patch 2015-10-12T11:05:35Z 2017-05-27T03:46:33Z "There are problems with the repair tools when the ID doesn't go as post_date (ie if ID = 2 has a post_date of today but ID = 3 has a post_date of yesterday) and I've come across this again in the ""Recalculate last activity in each topic and forum"" repair tool.
Attached is my fix as an example of what I mean -- it's off of 2.5.8, needs to be optimised and there's no backwards compatibility for bbp_get_public_child_ids (it was just a quick and dirty fix to get my sample data sorted correctly) so it's not a proper patch. I'm including it because it shows exactly what the issue is.
I can do a real patch for this but would appreciate any suggestions about how to make the queries more efficient or anything that I'm missing.
" tharsheblows
3492 """You may use these HTML tags and attributes:"" not escaped correctly" johnjamesjacoby General - UI/UX normal normal 2.6.10 defect (bug) assigned commit 2022-10-21T14:16:24Z 2022-10-24T08:52:48Z "In some places the ""You may use these HTML tags and attributes"" string is not escaped correctly and ends up escaping the `
` tag too.
This fixes that.
Before:
After:" naxoc
2976 Forum slug settings should be translatable johnjamesjacoby Locale - i18n/l10n high normal 2.7 defect (bug) new 2016-08-05T12:16:24Z 2019-11-19T17:09:40Z "All of the ""default"" slugs should be translatable so that a fresh install on a non US English install will include the localised slugs for in each of these sections:
* Forum Root Slug
* Single Forum Slugs
* Forum User Slugs
[[Image(https://cldup.com/Fad7rLynqR.png)]]
Watch out for `bbp_form_slug_conflict_check()` checks on each slug when patching this" netweb
2649 Repair tools should also repair/recount sub forum count meta Tools trunk normal major defect (bug) reopened 2014-07-04T08:13:08Z 2019-08-10T14:11:35Z "Currently the repair tools do not repair/recount `_bbp_forum_subforum_count` counts.
To ensure the accuracy/integrity of our forum meta we should do this.
The most common occurrence of forums not having this meta data is if the forums were imported.
" netweb
2648 Repairing BuddyPress Group Forum relationships only works if the forums were imported Tools high normal 2.7 defect (bug) new 2014-07-04T08:00:26Z 2014-09-09T20:10:10Z "The SQL query used in the repair tool ''""Repair BuddyPress Group Forum relationships""'' calculates the bbPress forum ID using `_bbp_old_forum_id`.
The meta key `_bbp_old_forum_id` only exists if the forums were imported, which in the majority of cases this would be the BuddyPress Legacy forums and works as intended in these cases.
An edge case is outlined here on [http://buddypress.org/support/topic/buddypress-incorrectly-redirects-to-bbpress-forum-within-group/#post-184795 buddypress.org] where a BuddyPress Group Forum is 'out of sync' and the repair tool does not work 'as expected'.
We should add support to repair the ''BuddyPress Group Forum Relationships'' in cases where the forum ID is out of sync and the forums were not legacy imported forums.
Related:
* #2533 Optimize Repair Tools SQL Queries
* #2647 Post meta key _bbp_forum_id is not created when creating new forums" netweb
3330 fix typos and docs standards in some files Tools - Code Improvements trunk normal normal 2.7 defect (bug) new dev-feedback 2020-01-31T05:29:22Z 2020-02-01T09:50:49Z fix typos and docs standards in some files fayazgabol
2305 Automatic Feed Links netweb API - Feeds 2.3 normal normal 2.7 enhancement new needs-docs 2013-04-15T09:22:24Z 2016-01-10T02:58:36Z "Another Idea for bbPress is to have an Automatic Feed Links such the WordPress feeds system.. So the forum/topic/user feed links displayed automaticly in the head tag.
In also the developer could remove those links easily, So introduce this feature as a theme feature will be a good idea
{{{
add_theme_support('bbp-automatic-feed-links');
}}}
" alex-ye
2605 bbPress 2.x Forum Import Template netweb API - Importers trunk normal normal 2.7 enhancement new 2014-05-29T03:32:28Z 2016-01-22T07:42:44Z "We have a wide array of importers but moving a bbPress 2.x forum from one WordPress site to another is not as easy as it should be. You can use the WordPress WXR Export/Import which works perfectly for Forums, Topics, Topic Tags and Replies.
The pitfall is users, currently you can only export user ID, user_login, user_email, display_name, user_first_name and user_last_name. With a bbPress 2.x to bbPress 2.x importer we can include all a users usermeta including bbPress roles and passwords.
WordPress Core improvements upstream eg #WP22435 are coming though support of user passwords and more general of what data should be able to be exported and imported has yet to be decided, these can be found in the [http://make.wordpress.org/core/components/export/ export] and [http://make.wordpress.org/core/components/import/ import] tickets." netweb
1988 Pending Moderation template notice API - Moderation 2.1 normal normal 2.7 enhancement new has-patch 2012-10-23T05:58:37Z 2017-03-07T19:34:33Z "On the WordPress settings->discussion tab you have a textfield where you can input a list of 'bad' words. I input a list of about 2,000 bad words into this field and it definitely works great.
There is a problem with bbPress though.
BbPress seems to check with the comments 'bad words' list when a user submits a new topic or reply. If there is a word in the list, it triggers the 'pending review' for the topic or reply, but the author is not notified in any way as to what happened.
How I found out:
I had a user send me a nasty email complaining about the new forum system 'bbPress' and how much they hated using it. They were telling me that basically anything they input into the box was not showing up when they clicked submit. Ultimately they ended up trying simple 1 word inputs and that worked.
As this is a LONG time moderator of mine who never complains, I went into the system to see what was happening. It turns out bbPress DOES have a 'Pending Review' status available and I found hundreds of topics and posts with this status. Obviously I have removed the 'bad words' from the moderation input.
Suggestion:
I don't want to loose the ability of filtering out 'bad' words, especially on a forum. I would suggest allowing the post to show up, but with a warning box letting the user know there is a problem with the post, and maybe highlighting the 'bad words/phrases'?
I had a vbulletin plugin that did this and it worked well. You could easily see what the problem was and fix it.
The way it is now, there is no warning. The post goes straight to awaiting review and does not say anything at all. Considering this was happening to my moderators who have virtual 'admin' access, this became even more confusing.
Not sure whether to call this a bug or a feature request. Leaving as a defect as it's horribly annoying.
screenshot:
[[Image(https://dl.dropbox.com/u/2045194/bbpress-trac/moderation-issues.png)]]" anointed
3020 Auto-role setting is applied even when unticked API - Roles/Capabilities 2.5.10 normal normal 2.7 enhancement new reporter-feedback 2016-11-10T14:21:52Z 2017-01-23T18:01:42Z "The ""'''Auto Role''' Automatically give registered visitors the XYZ forum role."" field is being applied even when the checkbox is un-ticked.
[[Image(http://i.imgur.com/wMk2cnA.jpg)]]
I was able to replicate this across dev/staging/production, the state of the checkbox was ignored in all 3 instances." gmsb
3262 Invalidate user cookies when blocked role is applied johnjamesjacoby API - Roles/Capabilities trunk high normal 2.7 enhancement assigned dev-feedback 2019-08-30T19:02:43Z 2019-11-19T16:56:10Z "As discussed in [https://meta.trac.wordpress.org/ticket/4691 #4691 on the WP Trac], assigning the 'blocked' role to a user should invalidate their cookies. In bbPress 1.2, this was done by [https://bbpress.trac.wordpress.org/browser/branches/1.2/bb-includes/functions.bb-pluggable.php#L537 appending '---' to the password hash].
Testing this method does not work in WordPress 5.3, and instead in the patch attached I've gone with prefixing an underscore to the hash. This produces an invalid hash when being compared with a plaintext password, and thus logins fail without error.
One thing to note is when default roles are being remapped, it will 'fix' the broken hashes if the user was previously blocked." pierlo
2989 Add topic tag subscriptions thebrandonallen API - Subscriptions trunk high normal 2.7 enhancement new 2016-09-04T04:15:20Z 2017-06-04T22:18:54Z "Topic tag subscriptions were added to w.org/support in meta:changeset:3719
Proposing we backport this change to bbPress itself
ToDo: Add topic-tag subscription management user profiles, eg. /users/%username%/subscriptions" netweb
3229 Email header improvements johnjamesjacoby API - Subscriptions 2.0 high normal 2.7 enhancement assigned dev-feedback 2018-11-15T04:47:06Z 2023-04-26T08:27:47Z "In recent years, a number of new email headers have emerged to help protect recipients from spam and abuse. We should add support for them in the emails that are sent to forum & topic subscribers.
* `Require-Recipient-Valid-Since: %user last active time%`
* `List-Unsubscribe: <%an unsubscribe url%>`
Supporting these two headers will require a(nother) not-insignificant rethink of how user data is queried for and looped through, as bbPress now takes a very minimal approach to keep it speedy.
The first header value should probably come from `user_registered`, since that's the only place available to us where we can be confident that a user last verified their email address – nothing gets stored in usermeta when a user email address is changed.
The second header value is a bit of a problem because the links to toggle subscriptions have nonces on them, meaning their useful life is currently too low to be very effective in an email older than 24 hours.
To make matters worse, bbPress switched to using a new function in 2.6 to query for user email addresses in batches of 100, to address frequent complaints about user queries taking a long time on installs with large numbers of users. See: `bbp_get_email_addresses_from_user_ids()` and r6725, #3068." johnjamesjacoby
2797 Proper subscription notifictations (WP Cron and other enhancements) API - Subscriptions trunk normal normal 2.7 enhancement new dev-feedback 2015-05-03T21:10:48Z 2018-03-09T22:29:03Z "So I had my issues with the current BCC implementation of subscription notification emails, as had others (see e.g. #2162).
I didn't want to mess with core, so I created my own code to work around the problems and put it in a plugin. I've published this plugin here: https://wordpress.org/plugins/asyncronous-bbpress-subscriptions/. @Robkk suggested I add this to core, so I've incorporated the plugin into BBPress and it's now a solid notification system in place of the old one. Here are the changes in short:
* Uses WP Cron to send subscription notifications instead of BCC lists
* Revised subject and message texts
* Makes one DB query for all recipients instead of one get_userdata() call per recipient
* Uses admin address as From address, so your users can actually reach you when something is wrong with these notifications
* Can set proper bounce address (Return-Path) via filter
* Recipients emails are of format ""Display Name "", i.e. they now contain the user's name
* Messages contain exactly 42 dashes in a row, in memory of Douglas Adams
'''filters added:'''
`'bbp_subscription_email_from'`
`'bbp_bounce_address'` ( sets `PHPMailer::$Sender` )
`'bbp_subscription_email_recipients'`
`'bbp_forum_subscription_email_subject'`
`'bbp_forum_subscription_email_message'`
`'bbp_topic_subscription_email_subject'`
`'bbp_topic_subscription_email_message'`
'''filters removed:'''
`'bbp_get_do_not_reply_address'`
`'bbp_subscription_mail_message'`
`'bbp_subscription_mail_title'`
`'bbp_subscription_from_email'`
`'bbp_subscription_mail_headers'`
`'bbp_subscription_to_email'`
`'bbp_forum_subscription_mail_message'`
`'bbp_forum_subscription_mail_title'`
`'bbp_subscription_from_email'`
'''changes signature of actions (now without parameters):'''
`'bbp_pre_notify_subscribers'`
`'bbp_post_notify_subscribers'`
I've tested the new subscription system in trunk and it works for me." mechter
3046 bbPress 2.5.12 is sending out emails to subscribed blocked users API - Subscriptions 2.5 normal normal 2.7 enhancement new needs-unit-tests 2017-01-23T21:35:47Z 2020-02-21T17:10:09Z "When users get the 'blocked' role, they do not get unsubscribed from forums (ok, could be fine because you don't want to resubscribe if they get reinstated), but they are still getting emails on new topics and that does not seem very logical.
I have added the following filter for now in my bbP Toolkit to avoid this issue, but I think it should be added to the basic functionalities.
{{{#!php
'
', 'show_role' => true ) ); ?>
}}}
will do the job:
{{{
Topics Started : "" ;
echo $topic_count ;
echo """" ;
// delete or comment out these lines to stop displaying replies count
$reply_count = bbp_get_user_reply_count_raw( bbp_get_reply_author_id( $reply_id )) ;
echo ""
Replies Created : "" ;
echo $reply_count ;
echo """" ;
?>
}}}
What's your thoughts? Is it a right place and way to post it?" hardeepasrani
2773 Email notifications for user @mentions Component - Users trunk normal normal 2.7 enhancement new 2015-03-15T08:57:09Z 2015-10-29T07:43:25Z "When mentioning a user in a topic or reply using `@username` bbPress currently turns this into a link to the users profile, we should also send the user an email to notify them that they were mentioned.
BuddyPress already includes a notifications component that performs this exact function, if used with bbPress then @mention notifications are emailed to the user, without BuddyPress though bbPress users are not notified they were mentioned.
Related: #2162, we should also look to updating how bbPress' sends email as part of this, see @r-a-y's [https://bbpress.trac.wordpress.org/ticket/2162#comment:30 comment:30]." netweb
3120 Post count in backend is zero for all imported users Component - Users 2.0 normal normal 2.7 enhancement new 2017-06-28T06:12:35Z 2017-06-28T16:29:38Z "bbpress 2.6 rc3
wordpress 4.7.5
Imported users and posts from Vbulletin 4.2.2
All imported users have zero posts when viewing userlist." sourfew
2708 Abstract the ability to create, edit, delete BP group forums Extend - BuddyPress normal normal 2.7 enhancement new 2014-10-18T13:02:01Z 2015-02-18T21:42:14Z "I've got a client project where I need to create and modify BP group forums programatically (such as with a one-button ""clone group"" tool). To make this work with bbPress, I've had to reproduce much the logic of `BBP_Forums_Group_Extension::create_screen_save()`, `new_forum()`, and `toggle_group_forum()` in a standalone function.
It would be nice if this stuff were abstracted out so it could be reused more easily. `toggle_group_forum()` and `new_forum()` could be marked as static. And I think all the logic could be wrapped in another static method or a straightforward procedural function like `bbp_create_bp_group_forum( $group_id )` or whatever.
Side note: Having this stuff broken out a bit more would also make it easier to write unit tests for it, though the mods that'd be necessary to your test suite to make it bootstrap BP are beyond the scope of this ticket." boonebgorges
2191 BuddyPress Group Subforums created in bbPress are incomplete johnjamesjacoby Extend - BuddyPress trunk high normal 2.7 enhancement new needs-unit-tests 2013-02-01T01:17:02Z 2024-03-12T06:47:14Z "Using latest trunk of both bbpresss/buddypress. Create a ""group1"" in buddypress, with corresponding forum. Then go into wp-admin and create subgroup of ""group1"" in bbpress admin, let's call it ""subgroup1"". Now go back to the front end and click on the group1 and look at the forums. Only content and listings from the subgroup1 appear, as if group1 disappeared completely. NOTE: Ticket originally posted on buddypress and requested to be moved here. orig. ticket: http://buddypress.trac.wordpress.org/ticket/4797" moebis
3105 Move titles out of display_forums() and into templates for easier styling mercime Extend - BuddyPress 2.5.12 normal normal 2.7 enhancement new dev-feedback 2017-05-13T15:11:04Z 2017-06-04T22:30:36Z "I’m working on simplifying the UI of a [http://commonsinabox.org| Commmons In A Box] site, which means I’m working with both BuddyPress and bbPress. While working on the group/forum page, I found that the forum title is hard coded (as a simple h3 with no other selectors) in display_forums() (see wp-content/plugins/bbpress/includes/extend/buddypress/groups.php at line 767). This is just before the content-single-forum template call.
In my case I wanted to remove that title and was able to do so with
{{{
#bbpress-forums > h3 {
display: none;
}
}}}
But that feels like a workaround and it was a long hunt to find this bit of the UI in what I would think of as core code.
In exploring around display_forums(), it looks like this a common pattern: The appropriate title is hard coded into display_forums() and then the rest of the displayed content is handled via a template call.
My request/suggestion is that all of these titles be moved from display_forums() and into their associated templates where they can be customized through the normal child theme process.
I'm happy to offer patches if that would be helpful." rgilman
2818 Redirect bbPress profile links to forum section of BuddyPress member profile Extend - BuddyPress normal normal 2.7 enhancement new has-patch 2015-06-11T09:44:24Z 2024-03-12T06:47:29Z "Based on https://buddypress.trac.wordpress.org/ticket/4357
When BuddyPress AND bbPress are both installed, bbPress redirects profile from `domain.com/forums/users/USERNAME/` to: `domain.com/members/USERNAME/`
The redirect should actually go to `domain.com/members/USERNAME/forums/`" sooskriszta
3284 """Replies"" are not informing the user about going in to moderation queue" General 2.6.1 high major 2.7 enhancement new reporter-feedback 2019-11-19T12:56:22Z 2021-10-15T14:28:53Z "I started this discussion here: https://bbpress.org/forums/topic/notify-user-when-a-reply-goes-into-moderation/
When a user creates a new topic, and bbPress decides it shoudl go to moderation, it provides the user with information by way of the status area at the top of the window:
This is from **template.php**:
{{{
// Get the topic status
switch ( $topic_status ) {
// Spam notice
case bbp_get_spam_status_id() :
$notice_text = esc_html__( 'This topic is marked as spam.', 'bbpress' );
break;
// Trashed notice
case bbp_get_trash_status_id() :
$notice_text = esc_html__( 'This topic is in the trash.', 'bbpress' );
break;
// Pending notice
case bbp_get_pending_status_id() :
$notice_text = esc_html__( 'This topic is pending moderation.', 'bbpress' );
break;
// Standard status
default :
$notice_text = '';
break;
}
}}}
As you can see, there is are several responses given to the user which is most beneficial. For example:
[[Image(https://www.publictalksoftware.co.uk/screenshots/moderation.jpg)]]
But, when we look at **replies** this whole concept has been overlooked. The author of the reply is told nothing. This needs to be improved and my suggestion is in two ways:
1. As a minimum the same feedback need to be provided to the user when a reply goes into moderation, just like it does for a new topic.
2. Ideally, the information should be posts just after the most recent entry in the discussion (just before the now empty editor). You see, if you are making a reply on page 3 you won't see the moderation message (unless the system takes you to the very start of the topic to ensure you can see it).
I have given this a high priority because bbPress should have consistent behaviour when authoring new topics and replies. Infact, your own support forum suffers this issue. We must show the feedback message to the author when a reply goes to moderation.
Side point: I have written messages on your forum that I know have gone to moderation and they have not been approved. I do not know how many other users there are who have written valid posts only to see them completely vanish and not show up again." ajtruckle
2269 Add rich microdata markup to breadcrumbs espellcaste General 2.2.3 normal minor 2.7 enhancement new 2013-03-20T07:22:37Z 2019-10-10T23:54:49Z "Introduce 'microdata' support for breadcrumbs.
Microdata is supported (and preferred over microformats) by the major search engines Bing, Google & Yahoo.
References: [http://dev.w3.org/html5/md/ HTML5 microdata spec] | [http://support.google.com/webmasters/bin/answer.py?hl=en&answer=185417 Google Microdata Breadcrumbs] & [http://www.bing.com/webmaster/help/markup-breadcrumbs-72419f3f Bing Microdata Breadcrumbs]" netweb
3406 Docs: Improve inline documentation in admin meta boxes General trunk normal normal 2.7 enhancement new has-patch 2020-10-27T05:04:00Z 2022-03-08T20:45:29Z "I updated as per WordPress. guidelines/standard
I have added a patch for the same." dilipbheda
3227 New topic and reply notifications not sent if topic or reply published from backend johnjamesjacoby General - Administration 2.5.14 normal normal 2.7 enhancement new 2018-11-14T10:18:08Z 2018-12-20T23:54:32Z "The bbPress Codex is quite clear that topics and replies may be published from both the front and back ends. https://codex.bbpress.org/getting-started/configuring-bbpress/creating-content/
However, I find that subscriber notifications are only sent if a topic/reply is published from the front end.
In other respects the back end does work - but no notifications are sent.
Tested with WP 4.9.8; theme twenty sixteen and only active plugins: bbPress, Stop Emails, Log emails & Reveal IDs" antipole
2689 Remove admin RTL specific CSS and use CSSJanus to generate RTL CSS General - Administration low minor 2.7 enhancement new 2014-09-20T08:56:38Z 2014-10-06T08:22:26Z "Various instances of RTL specific CSS exist in [https://bbpress.trac.wordpress.org/browser/trunk/src/includes/admin/css/admin.css /src/includes/admin/css/admin.css].
We should remove these and use our grunt task `grunt cssjanus:core` task to generate any needed RTL CSS styles." netweb
2498 Introduce optional replace WordPress comments with bbPress topics johnjamesjacoby General - Integration trunk normal normal 2.7 enhancement new 2013-12-28T07:12:15Z 2021-11-23T13:39:40Z Introduce optional replace WordPress comments with bbPress topics functionality. netweb
2875 BP group forum reply triggers recount for every group forum General - Performance 2.0 normal normal 2.7 enhancement reopened reporter-feedback 2015-10-12T03:14:17Z 2019-06-10T12:11:43Z "Posting a reply results in `bbp_update_reply()` being called (on the 'bbp_new_reply' action). This function then calls `bbp_update_reply_walker()`, which triggers a recalc of counts for the entire forum tree.
In the case of BuddyPress groups, where all forums share a common ""groups root"" forum, this means that a new reply triggers a recalculation of every count in every forum.
I had a client report that the slowdown became apparent recently. I'm not sure whether there was a change in bbPress that caused this behavior to surface, or whether it's the size of the installation that's causing the problem. (The number of group forums is in the hundreds - it's not enormous.)
As far as I can see, there is no reason why the group root needs to have up-to-date counts. So I've put a truly heinous workaround in place, which prevents bbPress from running `bbp_update_forum_reply_count()` on the group root. I have two suggestions for bbPress:
1. Bail out of `bbp_update_forum_reply_count()` if it's the group root.
2. Provide a way for developers to disable the default behavior. I'm resorting to a filter on `bbp_get_forum_id` that returns 0 when the forum ID is the group root and `bbp_update_forum_reply_count()` is in the backtrace. Obviously, this is terrible. Moving the walker or `bbp_update_forum_reply_count()` to `do_action()` callbacks, or creating 'pre_' hooks in the functions, would allow devs to disable them selectively." boonebgorges
3117 Make a more efficient update walker General - Performance 2.1 high normal 2.7 enhancement new 2017-06-18T17:16:27Z 2017-06-18T18:36:59Z "Over the years, the new/update forum/topic/reply code has accidentally become a mish-mash of approaches to address specific needs at the time. This has resulted in multiple approaches to walking & traversing the `post_parent` hierarchy, making it not a very straightforward process to understand or hook into.
A few things to consider:
* Our `handler` functions should be the only places where user input is checked
* Our `walker` function should be the only places where that branch of the tree is updated
* Our `extras` and `update` functions should be helpers, but not invoke a walk of the tree or handle user input
* Some functions require a recalculation of the tree, like spamming & unspamming a reply. In these cases, the walkers should know how to query for and update the relevant meta-data
* Caching should be scrutinized deeply to make sure we aren't triggering multiple recalculations per iteration of the walker" johnjamesjacoby
1925 Optimize `_bbp_last_active_time` to use `post_modified` instead General - Performance 2.1.2 normal normal 2.7 enhancement new early 2012-08-05T00:59:39Z 2016-08-09T04:04:42Z "Background ticket: http://bbpress.trac.wordpress.org/ticket/1885
Background Conversation:
Vibol: For the first query, last_active_time now looks to be the culprit. It's a postmeta lookup with a sort.
JJJ: Meta queries are always going to be a slow like this. There isn't an available index we can use here to avoid the meta query. We *could* hack in repurposing post_date as the freshness time, but we lose the actual date the topic was posted. It would take some rearchitecting to move the original post creation date to postmeta, to make the index available.
Problem: The _bbp_last_active_time query is doing a full table scan and sort against the postmeta table when retrieving forum index pages. The slowdown is linear with size of table scan. Here's an example slow query:
{{{
# Time: 120804 19:52:17
# Query_time: 21.460766 Lock_time: 0.000051 Rows_sent: 25 Rows_examined: 313770
SET timestamp=1344127937;
SELECT SQL_CALC_FOUND_ROWS wp_posts.* FROM wp_posts INNER JOIN wp_postmeta ON (wp_posts.ID = wp_postmeta.post_id) WHERE 1=1 AND wp_posts.post_parent = 17 AND wp_posts.post_type = 'topic' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'closed') AND (wp_postmeta.meta_key = '_bbp_last_active_time' ) GROUP BY wp_posts.ID ORDER BY wp_postmeta.meta_value DESC LIMIT 0, 25;
}}}
Expected behavior: Should be fast if the data is indexed, but the postmeta table does not have indexes against it.
Guidance: I'm looking for someone to fix this, or, I am happy to put in the time to fix it with guidance on desired approach. This is a non-trivial issue, so someone with more experience in WP/BBP is ideal." vibol
2711 Make bbPress Edit Profile Section more Responsive General - UI/UX 2.5.4 normal normal 2.7 enhancement new 2014-10-23T00:04:52Z 2017-01-12T10:51:00Z "The bbpress edit profile section should look a little better on smaller device widths.
The labels should be on top of the input boxes , right now they are just inline with the input boxes.
When they are inline on smaller device width they look all awkward because the words break up.
" Robkk
3058 Consider bundling WP-CLI commands with bbPress proper espellcaste Tools 2.1 high normal 2.7 enhancement new needs-unit-tests 2017-02-07T01:15:40Z 2023-06-16T16:28:12Z "I'm curious why bbPress' WP-CLI commands are being developed as a separate package, and not bundled with WP-CLI proper?
https://github.com/bbpress/wp-cli-bbpress" danielbachhuber
2533 Optimize Repair Tools SQL Queries netweb Tools 2.5 normal normal 2.7 enhancement new needs-unit-tests 2014-01-31T04:49:46Z 2017-03-07T23:53:10Z Optimize Repair Tools SQL Queries | bbPress -> Tools - Repair Tools netweb
2731 "refactor the menu_order tool (""Recalculate the position of each reply"")" Tools normal normal 2.7 enhancement new dev-feedback 2014-12-13T12:47:30Z 2017-06-28T16:35:27Z "This refers to #2654 and is about refactoring the menu_order tool here: https://bbpress.trac.wordpress.org/browser/branches/2.5/includes/admin/tools.php#L1144
I was working on this this morning and really just need a place to keep my results and (ideally) get feedback or told that I'm doing it all wrong which, honestly, would be super helpful as well.
Currently I have the following times from my last run:
-- the query with LIMIT 500 replies average time: 0.1032 s
-- bbp_update_reply_position( $reply->ID ) average time for each call: 0.01375 s <-- this of course varies with the number of replies to the topic, the std deviation is 0.004111s so quite large and I'm only doing a sample, not sure if I'm catching the really long topics
I am doing a max of 2500 replies (500 at a time) in total right now so the page doesn't time out, otherwise it does -- I haven't fine tuned this though, so I'm not exactly sure at what point it would. Definitely 10,000 replies is too much and 5,000 too, I think.
My first inclination would be to do this in chunks and have the page reload between each chunk, putting the offset in a POST variable and looking for it on the tool page load. Is there a better way? It should also be the case that if you choose to use that tool, that it's the *only* tool you can use but that's straightforward jQuery stuff.
It should be done so that the vast majority of the sites don't get the chunked version, I think that'd be around 1000 replies / around 15 seconds for me. I have no idea how different servers vary or if that's reasonable.
I also had a slightly different way of doing this and will see if I can get the update time down a little." tharsheblows
2886 Improve bbPress and BuddyPress unit test coexistance netweb* Tools - Build normal normal 2.7 enhancement accepted has-patch 2015-10-27T08:12:33Z 2019-11-17T10:14:11Z Currently loading the BuddyPress PHPUnit test suite to coexist with bbPress/WordPress is not ideal due primarily to defined or undefined constants causing various PHP warnings. netweb
3000 There should be a notice about running the remap existing users to default forum roles repair job johnjamesjacoby Tools - Code Improvements 2.2 lowest minor 2.7 enhancement new 2016-09-20T15:35:20Z 2023-11-17T20:12:02Z "There should be a notice/warning/description about running the remap existing users to default forum roles repair job.
Users would have to reassign any forum roles that they have granted to users again if they run it. If users do not entirely know that the repair job does that, it might be quite annoying for site Administrators with multiple Moderators.
" Robkk
2995 Consider reverting the quicktag link button to the original prompt instead of the modal with search API - Formatting trunk low minor 2.7 idea new dev-feedback 2016-09-09T05:42:48Z 2017-06-08T03:44:13Z "I don't know how useful the post search in the quicktag link modal for forums.
I think before an update in WordPress it was originally a simple prompt to include a link into.
The modal with post search usually inherits a themes css styles and could make it look like a mess.
In my opinion I prefer the simple and original functionality.
If anything we should at least remove the post search area or customize it to only include bbPress post types, and include some CSS to the bbpress stylesheet to fix any common theme inherited issues.
" Robkk
3156 Additional filter for the search function Component - Search low major 2.7 idea new 2017-08-28T17:04:36Z 2023-11-17T20:24:55Z "Right now search function is doing things like this:
{{{
# Query_time: 2.472832 Lock_time: 0.000098 Rows_sent: 15 Rows_examined: 631204
SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND
(((wp_posts.post_title LIKE '%junak%') OR (wp_posts.post_excerpt LIKE '%junak%')
OR (wp_posts.post_content LIKE '%junak%'))) AND wp_posts.post_type IN ('forum', 'topic', 'reply')
AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'closed'
OR wp_posts.post_status = 'reported' OR wp_posts.post_author = 5
AND wp_posts.post_status = 'private' OR wp_posts.post_author = 5
AND wp_posts.post_status = 'hidden') ORDER BY wp_posts.post_date DESC LIMIT 0, 15;
}}}
General rule for the efficient mysql query is not to use LIKE %% (because mysql will have to parse every single record), so I'm proposing a simple and rather painless way of dealing with this problem.
A new search filter. It could work somewhat like that:
{{{#!php
incorrectly.
Please wait for the `bp_parse_query` hook to be fired before using it. http:///?redirect_to=https:///2020/03/02/images-of-week-15-2019-20/20200302_161241/ require('wp-blog-header.php'), require_once('wp-load.php'), require_once('wp-config.php'), require_once('wp-settings.php'), do_action('init'), WP_Hook->do_action, WP_Hook->apply_filters, bbp_init, do_action('bbp_init'), WP_Hook->do_action, WP_Hook->apply_filters, bbp_register, do_action('bbp_register'), WP_Hook->do_action, WP_Hook->apply_filters, bbp_register_taxonomies, do_action('bbp_register_taxonomies'), WP_Hook->do_action, WP_Hook->apply_filters, bbPress::register_taxonomies, current_user_can, user_can, WP_User->has_cap, map_meta_cap, apply_filters('map_meta_cap'), WP_Hook->apply_filters, bbp_map_meta_caps, apply_filters('bbp_map_meta_caps'), WP_Hook->apply_filters, bbp_map_topic_tag_meta_caps, user_can, WP_User->has_cap, map_meta_cap, apply_filters('map_meta_cap'), WP_Hook->apply_filters, bbp_map_meta_caps, apply_filters('bbp_map_meta_caps'), WP_Hook->apply_filters, bbp_map_primary_meta_caps, bbp_is_user_inactive, bbp_is_user_active, bbp_get_user_id, apply_filters('bbp_get_user_id'), WP_Hook->apply_filters, bbp_filter_user_id, bp_displayed_user_id, apply_filters('bp_displayed_user_id'), WP_Hook->apply_filters, BP\Rewrites\bp_displayed_user_id, BP\Rewrites\_was_called_too_early Please see Debugging in WordPress for more information. (This message was added in version BP Rewrites.) in /wp-includes/functions.php on line 5775
}}}
As this is going to be merged into buddypress core at some stage I would suggest that getting the vtwo plugins to woirk togther asap would be very benficial as it will allow much more real world testing
" shawfactor
3294 Add PHPCS with custom bbPress ruleset netweb Tools - Build normal normal 2.7 task (blessed) reopened has-patch 2019-11-24T13:34:03Z 2020-06-30T02:29:43Z "Add PHPCS with custom bbPress ruleset
To run PHPCS, run `grunt phpcs`" netweb
3110 Add missing filter documentation Tools - Code Improvements 2.0 normal normal 2.7 task (blessed) new needs-docs 2017-05-27T17:09:32Z 2017-05-27T17:09:32Z "In r6438, I added an easy way to identify which filters are missing documentation blocks.
A search for:
{{{
// Filter & return
}}}
...currently yields 533 results, all of which represent filters in bbPress that are missing documentation about why someone might want to hook into them.
It would be ''simply wonderful'' for some enterprising soul to chug through these and document them. Then we can set bbPress up with one of those fancy auto-documenting filter tools like WordPress has." johnjamesjacoby