| [4558]
|
johnjamesjacoby
|
Breadcrumbs:
* Use is_singular() in bbp_get_breadcrumb().
* Fixes issue where single reply trail would be incorrect.
* Fixes #2086 (2.2 branch)
|
| [4557]
|
johnjamesjacoby
|
Breadcrumbs:
* Use is_singular() in bbp_get_breadcrumb().
* Fixes issue where single reply trail would be incorrect.
* Fixes #2086 (trunk)
|
| [3901]
|
johnjamesjacoby
|
Breadcrumbs:
* Wrap separator in a span if it exists.
* Shorten $breadcrumbs variable to $crumbs for improved readability.
* Fixes #1821 again.
* Props netweb for original patch.
|
| [7277]
|
johnjamesjacoby
|
Breadcrumbs: prevent duplicate root crumb on Forum Archive subpages
This change prevents the Forum Archive page from appearing a second time in the breadcrumb trail when using pages, shortcodes, and/or subpages for forum setup.
It does this by keeping track of a previous match of a page by path to the Forum Archive, and skipping that page ID in the subsequent ancestors loop.
In trunk, for 2.7.
|
| [3464]
|
johnjamesjacoby
|
Break single loop elements into separate template parts in bbp-twentyten for easier ajaxifying.
|
| [2902]
|
johnjamesjacoby
|
Breathing room
|
| [5444]
|
johnjamesjacoby
|
Breathing room for `!` usages in Search component.
|
| [5443]
|
johnjamesjacoby
|
Breathing room for `!` usages in Topics component.
|
| [5442]
|
johnjamesjacoby
|
Breathing room for `!` usages in Users component.
|
| [6250]
|
johnjamesjacoby
|
Breathing room for `!class_exists()` checks, and bump to 2.6-beta-2.
|
| [6196]
|
johnjamesjacoby
|
Breathing room for all `!is_` usages.
|
| [5649]
|
netweb
|
Bring Gruntfile.js tasks up to speed with BuddyPress
* Adds a `src` target for `jsvalidate` to validate JavaScript files in the `/src` folder
* WordPress JavaScript coding standards improvements
* See also r5614
Props netweb. Fixes #2766
|
| [5614]
|
johnjamesjacoby
|
Bring `Gruntfile.js` tasks up to speed with BuddyPress.
|
| [2576]
|
johnjamesjacoby
|
Bring back 1 reply text
|
| [2577]
|
johnjamesjacoby
|
Bring back 1 reply text.
|
| [4684]
|
johnjamesjacoby
|
Bring per RSS page settings back, using correct cap key.
|
| [4245]
|
johnjamesjacoby
|
BuddyPress Activity:
* Ensure activity stream items are updated when editing topics and replies.
* Delete activity stream items when deleting topics and replies.
* Props jmdodd.
* Fixes #1753.
|
| [4546]
|
johnjamesjacoby
|
BuddyPress Activity:
* When adding activity stream items, use raw values and trust !BuddyPress to properly texturize output.
* Fixes #2082 (2.2 branch)
|
| [4547]
|
johnjamesjacoby
|
BuddyPress Activity:
* When adding activity stream items, use raw values and trust !BuddyPress to properly texturize output.
* Fixes #2082 (trunk)
|
| [4540]
|
johnjamesjacoby
|
BuddyPress Activity:
* When creating activity stream items, utilize 'hide_sitewide' instead of not recording any activity at all.
* Hat-tip boonebgorges.
* Fixes #2081 (2.2 branch)
|
| [4538]
|
johnjamesjacoby
|
BuddyPress Activity:
* When creating activity stream items, utilize 'hide_sitewide' instead of not recording any activity at all.
* Hat-tip boonebgorges.
* Fixes #2081 (trunk)
|
| [4815]
|
johnjamesjacoby
|
BuddyPress Group Forum Enhancements:
* When deleting a Group, also remove the forum connection. Fixes #2261.
* When disabling a Group's Forum, also remove the forum connection. Fixes #2262.
* Allow editing of a Group's Forum via the Group Admin UI. Fixes #2263.
* Props imath.
|
| [3654]
|
johnjamesjacoby
|
BuddyPress Group Forum Integration:
* BuddyPress group/forum sync functions
* Add forum/topic row actions
* Group create/edit helper methods
* Forum create/edit handlers
* See #1669
|
| [3789]
|
johnjamesjacoby
|
BuddyPress Group Forum create page and handler. See #1669
|
| [4545]
|
johnjamesjacoby
|
BuddyPress Groups:
* Add moderator and admin checks to map_topic_meta_caps()
* Props lakrisgubben.
* Fixes #2084 (2.2 branch)
|
| [4544]
|
johnjamesjacoby
|
BuddyPress Groups:
* Add moderator and admin checks to map_topic_meta_caps()
* Props lakrisgubben.
* Fixes #2084 (trunk)
|
| [4536]
|
johnjamesjacoby
|
BuddyPress Groups:
* Fix issue causing paginated group forum requests to incorrectly fail.
* Hat-tip boonebgorges.
* Fixes #2080 (2.2 branch)
|
| [4537]
|
johnjamesjacoby
|
BuddyPress Groups:
* Fix issue causing paginated group forum requests to incorrectly fail.
* Hat-tip boonebgorges.
* Fixes #2080 (trunk)
|
| [4554]
|
johnjamesjacoby
|
BuddyPress Groups:
* If group does not have forums active, do not show forum tab.
* See #2083 (2.2 branch)
|
| [4553]
|
johnjamesjacoby
|
BuddyPress Groups:
* If group does not have forums active, do not show forum tab.
* See #2083 (trunk)
|
| [4602]
|
johnjamesjacoby
|
BuddyPress Groups:
* In maybe_unset_forum_menu(), also check for current groupmeta.
* Props r-a-y.
* Fixes #2094.
|
| [4769]
|
johnjamesjacoby
|
BuddyPress Groups:
* Simplify group forum display logic.
* Use bbp_has_ functions to preload posts. Reduces overhead of calling get_posts() and then creating new WP_Query() object later.
* Use bbPress's front-end nonce verification logic to avoid wp_die'ing theme-side.
* When editing a BuddyPress group's forum settings, allow network administrators to modify the group connection.
* Fixes #2201, #2202.
|
| [4555]
|
johnjamesjacoby
|
BuddyPress Groups:
* When enabling a group forum in an existing group, audit group forums, remove any strays, and maybe create a new forum if needed.
* Also fixes bugs in removing a value from group/forum ID arrays.
* Fixes #2083 (2.2 branch)
|
| [4556]
|
johnjamesjacoby
|
BuddyPress Groups:
* When enabling a group forum in an existing group, audit group forums, remove any strays, and maybe create a new forum if needed.
* Also fixes bugs in removing a value from group/forum ID arrays.
* Fixes #2083 (trunk)
|
| [5807]
|
johnjamesjacoby
|
BuddyPress Groups: Backport r5560 to 2.5 branch (for 2.5.8) for improved PHP5 compatibility and to avoid a debug notice.
Props boonebgorges.
|
| [7209]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3417.
|
| [7210]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3417.
|
| [4405]
|
johnjamesjacoby
|
BuddyPress Repair:
* Repair forum group ID meta so relationship is fully mapped.
* Update feedback message to include group and forum counts.
* Props jmdodd.
* Fixes #2025.
|
| [3799]
|
johnjamesjacoby
|
BuddyPress group forums:
* Fix new reply and topic redirects
* Remove first group forum topic and reply in lieu of more customization
* See #1669
* Fixes #1776
* Fixes #1778
* Fixes #1777
* Props boonebgorges
|
| [4435]
|
johnjamesjacoby
|
BuddyPress/Capabilities:
* Add supporting methods for handling group forum topic moderator functionality.
* Uses map_meta_cap filter to allow group moderators and admins to perform their duties.
* Also allows regular group members to view private/hidden forums if they are a group member.
* Fixes #2033.
|
| [4523]
|
johnjamesjacoby
|
BuddyPress:
* Add reply move support for BuddyPress group forums.
* See #1900, fixes #2064.
|
| [3908]
|
johnjamesjacoby
|
BuddyPress:
* Change BBP_Forums_Component methods to public.
* These should probably be made protected at some point.
|
| [3909]
|
johnjamesjacoby
|
BuddyPress:
* Change BBP_Forums_Groups_Component methods to public.
* These should be allowed to be protected by BuddyPress core later.
|
| [4213]
|
johnjamesjacoby
|
BuddyPress:
* Clean up logic in strip_mentions_on_edit() method.
|
| [4266]
|
johnjamesjacoby
|
BuddyPress:
* Remove advanced group forum admin UI; go with feature parity of existing bbPress 1.1 installations for a v1.
* Remove support for multiple forums/groups combinations. Assume the first item in the array is the only one.
* Adds some canonical redirection to group forum content.
* Maps forum content links to group forums when needed.
* Add support for editing of topics and replies within group forums.
* Some more to do here, but closing in on completeness.
* Huge props jmdodd,
* Fixes #1906.
* See #1669.
|
| [6836]
|
netweb
|
BuddyPress: Add a `for` attribute to the new forum form label improving accessibility
Props mercime.
Fixes #3208.
|
| [5849]
|
johnjamesjacoby
|
BuddyPress: Add all topic statuses to `bbp_filter_modify_page_title()`.
This changeset fixes a bug that only allowed published topics to be queried in group forums.
Props netweb. Fixes #2699.
|
| [6220]
|
johnjamesjacoby
|
BuddyPress: Additional conditionals for group forum topic checks.
Fixes #2974. Props r-a-y.
|
| [6383]
|
johnjamesjacoby
|
BuddyPress: Bail if in a feed.
Props r-a-y, netweb. Fixes #2745.
|
| [6492]
|
netweb
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y.
Fixes #2690.
Merges [5857] to the 2.5 branch.
|
| [5857]
|
johnjamesjacoby
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y. Fixes #2690.
|
| [6541]
|
johnjamesjacoby
|
BuddyPress: Continuation of r6538.
* Prefer data attributes
* Stop passing around localized nonces
Props r-a-y. Fixes #3114.
|
| [5847]
|
johnjamesjacoby
|
BuddyPress: Do not filter admin toolbar URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress is network activated and bbPress is active on the non-root blog.
Props imath. Fixes #2713.
|
| [5846]
|
johnjamesjacoby
|
BuddyPress: Do not filter profile URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress was network activated and bbPress was active on the non-root blog.
Props imath. See #2713.
|
| [6696]
|
johnjamesjacoby
|
BuddyPress: Do not record edit activity if revisions are off.
This change will prevent edits to topics & replies from creating new Activity Stream items, by obeying both the global setting and the post-type-supports properties of topics & replies. It also prevents activity stream items from being created when reply positions are recalculated on the fly.
|
| [6370]
|
johnjamesjacoby
|
BuddyPress: Dynamic activity for topics & replies, part 1.
* Functions for activity action filters
Props thebrandonallen. See #2794.
|
| [6372]
|
johnjamesjacoby
|
BuddyPress: Dynamic activity for topics & replies, part 2.
* Filters for activity action functions
* Tests for the new activity filters
Props thebrandonallen. See #2794.
|
| [6538]
|
johnjamesjacoby
|
BuddyPress: Favorites & Subscriptions AJAX improvements
* Pass a data attribute along with links
* Sanitize `action` key when passed into AJAX action hook
* Send a `200` response code
This commit allows favorite & subscription links to work with AJAX in BuddyPress group forums pages.
Props r-a-y. Fixes #3114
|
| [6367]
|
johnjamesjacoby
|
BuddyPress: Filter `bbp_is_single_forum` for group forums.
Props r-a-y. Fixes #2727. See #2974.
|
| [6240]
|
johnjamesjacoby
|
BuddyPress: In `functions.php`, prefer `bp_loggedin_user_id()` over `get_current_user_id()`.
This allows BuddyPress filters & functionality to drive the decision making process (rather than WordPress proper) to improve integration with third-party BuddyPress plugins & themes that may rely on BuddyPress in these instances.
|
| [5905]
|
johnjamesjacoby
|
BuddyPress: Introduce `BBP_Forums_Group_Extension::update_group_forum_visibility()` to keep group forum visibility in alignment with BuddyPress Group visibility.
This changeset ensures that when a BuddyPress Group's visibility changes, it's bbPress forum visibility changes along with it. This avoids a UX issue where Group visibility and Forum visibility could become misaligned when updating a Group.
Props boonebgorges. Fixes #2599.
|
| [7109]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In branches/2.6, for 2.6.6.
Fixes #3213.
|
| [7108]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In trunk, for 2.7.0.
Fixes #3378.
|
| [6392]
|
johnjamesjacoby
|
BuddyPress: Missed the skipping of groups tests. Proprs thebrandonallen. Fixes #3089.
|
| [6488]
|
johnjamesjacoby
|
BuddyPress: Only wrap titles in `h2` tags if they are not empty.
Allows easier overriding if titles are not desired at all.
See #3105.
|
| [5848]
|
johnjamesjacoby
|
BuddyPress: Pass the currently logged in user ID when creating toolbar links. See #2713.
|
| [6674]
|
johnjamesjacoby
|
BuddyPress: Prefer `bbp_redirect()` in `bbp_maybe_create_group_forum_root()`
This change uses the new internal function as it's intended, and removes an additional `die;` usage.
Trunk, for 2.6.
|
| [6229]
|
johnjamesjacoby
|
BuddyPress: Prevent reading/publishing if group member is banned.
Fixes #2905. Props thebrandonallen, r-a-y.
|
| [5906]
|
johnjamesjacoby
|
BuddyPress: Remove `@todo`s that are todone or todon'ts.
|
| [6550]
|
johnjamesjacoby
|
BuddyPress: Remove favs & subs from correct `bbp_get_request` action.
|
| [6485]
|
johnjamesjacoby
|
BuddyPress: Root group forum updates
* Include ability to create a new group root forum if none exists
* Update group-forum setting verbiage to accommodate above
* When a forum is deleted, check if it's the group root, and delete the setting accordingly
* Introduce `bbp_maybe_delete_group_forum_root()` and `bbp_maybe_create_group_forum_root()` functions to carry out the above functionalities
|
| [6391]
|
johnjamesjacoby
|
BuddyPress: Switch activity action back to `$this->component` and skip groups tests.
Proprs thebrandonallen. Fixes #3089.
|
| [6262]
|
johnjamesjacoby
|
BuddyPress: Update `bbp_format_buddypress_notifications()` with new parameters.
* Prefer `$component_action_name` over less reliable `$content`
* Parameters match BuddyPress 2.6.0 and higher signature
* Mild function clean-up
Fixes #3036.
|
| [6368]
|
johnjamesjacoby
|
BuddyPress: Update inline doc for group-forum filter. See #2974.
|
| [5822]
|
johnjamesjacoby
|
BuddyPress: Use `bbp_get_paged_slug()` instead of `$wp_rewrite->pagination_base` directly.
|
| [5653]
|
netweb
|
BuddyPress: Use `bbp_is_favorites_active()` and `bbp_is_subscriptions_active()` respectively to check if bbPress' favorites and/or subscriptions are enabled before displaying menu items in BuddyPress member profiles.
Props tharsheblows. Fixes #2594
|
| [6285]
|
johnjamesjacoby
|
BuddyPress: Use correct hook type for `bp_modify_page_title` filter.
Props thebrandonallen. Fixes #3057.
|
| [6808]
|
johnjamesjacoby
|
BuddyPress: add more `fully_loaded()` methods to component classes.
This will allow an entry point for plugins to alter these classes how they see fit.
Fixes #3192.
|
| [7184]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In branches/2.6 for 2.6.7. Fixes #3341.
Props konnektiv.
|
| [7183]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In trunk for 2.7.0. See #3341.
Props konnektiv.
|
| [6805]
|
johnjamesjacoby
|
BuddyPress: clean up new `get_profile_url()` method.
See r6804.
|
| [7058]
|
johnjamesjacoby
|
BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.6.14, branches/2.6
|
| [7057]
|
johnjamesjacoby
|
BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.7, trunk.
|
| [7059]
|
johnjamesjacoby
|
BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.6.14, branches/2.6
|
| [7060]
|
johnjamesjacoby
|
BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.7, trunk
|
| [6710]
|
johnjamesjacoby
|
BuddyPress: improve targeting of single forum/topic filters.
This change simplifies the logic used when attaching-to and checking-for the current BuddyPress Group Forum & Topic pages, by conditionally filtering behind a singular `bp_is_group()` check.
Fixes #3165. Props thebrandonallen.
|
| [6807]
|
johnjamesjacoby
|
BuddyPress: more efficient includes method.
Props r-a-y. Fixes #3193.
|
| [6810]
|
johnjamesjacoby
|
BuddyPress: prefer `empty()` check on `disable_blogforum_replies` setting.
This fixes a bug causing some activity to not appear in relative activity streams.
Fixes #3180.
|
| [7188]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In branches/2.6 for 2.6.7. Fixes #3367.
|
| [7187]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In trunk for 2.7.0. See #3367.
|
| [6982]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.6.2, branches/2.6.
|
| [6981]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.7, trunk.
|
| [6815]
|
johnjamesjacoby
|
BuddyPress: tweak notifications item IDs to provide a bit more context.
This change also fixes a bug with hierarchical reply notifications.
Props jpolakovic. Fixes #2834.
|
| [6804]
|
johnjamesjacoby
|
BuddyPress: updates to member profile URL filters:
* Introduce methods for known user profile pages
* Update public filter methods to use a private method
This change uses new intercept hooks to make sure bbPress profile URLs are turned into BuddyPress ones instead.
See #3814.
|
| [6845]
|
johnjamesjacoby
|
BuddyPress: use `$reply_id` instead of `$topic_id` so `bbp_get_reply_url()` works correctly.
This change ensures that notification links go directly to the reply, not the topic, and not a 404.
Fixes #3213. See #3214.
|
| [5995]
|
netweb
|
Build Tools: Add @stylelint for linting CSS to adhere to WordPress CSS Coding Standards
This changeset adds a new Grunt task `grunt postcss:lint` that runs stylelint on CSS & SCSS files to ensure bbPress' CSS adheres to WordPress CSS Coding Standards.
8 months in the making and is maintained by yours truly @netweb, with stylelint I'm learning JavaScript deeply.
See also:
* http://stylelint.io/
* https://github.com/stylelint/stylelint
* https://github.com/ntwb/stylelint-config-wordpress
* https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/
Hat-tip: David Clark and Richard Hallows for the ongoing help and support.
Props netweb.
Fixes #2924.
|
| [5994]
|
netweb
|
Build Tools: Add Autoprefixer for adding CSS vendor prefixes
This changeset adds a new Grunt task `grunt postcss:core` that runs Autoprefixer on CSS & SCSS files to add or remove any vendor prefixes required by browsers.
Browsers supported are the same as WordPress currently supports which are:
* Android >= 2.1
* Chrome >= 21
* Edge >= 12
* Explorer >= 7
* Firefox >= 17
* Opera >= 12.1
* Safari >= 6.0.
Vendor prefixes are are also added for `templates/default/css/bbpress.css` as this is the only file that requires them at this time.
Fixes #2923.
|
| [6655]
|
netweb
|
Build Tools: Add Composer packages to Travis CI cache
|
| [5996]
|
netweb
|
Build Tools: Add NPM package `postcss-scss` for styelelint SCSS compatibility
This changeset fixes an idiosyncratic NPM v3.x issue with "flat" folders and sharing dependencies that is not an issue when using NPM v2
See #2924
|
| [6073]
|
netweb
|
Build Tools: Add PHP 7.1 to Travis CI and "allow to fail"
This changeset adds explict PHP 7.1 for testing bbPress, see also #WP37625
See #2980.
|