| [3579]
|
johnjamesjacoby
|
Always set defaults in bbp_theme_compat_reset_post().
|
| [5231]
|
nacin
|
Ancient bbPress: Adjust error reporting to cope with PHP 5.4.
|
| [6737]
|
johnjamesjacoby
|
Anonymous Users: improve styling for anonymous topic/reply author boxes.
This change wraps anonymous author data in `span` elements where `a` elements would normally be used for registered users, and tweaks the default template-pack CSS to accomodate these new elements.
|
| [6399]
|
johnjamesjacoby
|
Anonymous: Clean-up `bbp_set_current_anonymous_user_data()`:
* Make sure cookies are secure when SSL
* Only call `time()` once to avoid potential delays
* Cast cookie lifetime to `int` after filtering
* Inline docs
|
| [6838]
|
johnjamesjacoby
|
Anonymous: Don't use `esc_html__()` in combination with HTML tags.
Props wpdennis. Fixes #3210.
|
| [6400]
|
johnjamesjacoby
|
Anonymous: Improve `$anonymous_data` implementation:
* Always treat it as an array, handling for `false` values was never used
* Introduce `_sanitize_` and `_update_` partner functions for the existing `_filter_` function
* Ensure that cookies and meta-data values are stripped of invalid characters in the same way that anonymous comments are, to prevent inconsistencies between anonymous forum and commenter cookie data
* Update surrounding documentation blocks
* Prefer strict type-casting and `is_array()` comparisons
|
| [6742]
|
johnjamesjacoby
|
Anonymous: cleanup from r6741.
|
| [6917]
|
johnjamesjacoby
|
Anonymous: delete meta key if value is empty.
This commit ensures that editing a non-anonymous topic via WordPress Admin does not erroneously add empty anonymous author keys to post meta.
|
| [6740]
|
johnjamesjacoby
|
Anonymous: remove `sanitize_comment_cookies()` call.
This was causing repeated comment cookie sanitization on each subsequent page load.
|
| [6741]
|
johnjamesjacoby
|
Anonymous: remove escaped placeholders from `$where` clause of duplicate check.
This change fixes a bug for versions of WordPress 4.8.3 and higher, that was causing the anonymous email comparison to use the placeholder text instead of the raw email address, but only when an email address contained a `%` character.
Also use the correct return variant, and make sure the output is escaped.
|
| [6214]
|
netweb
|
Appearance - Included Themes: Update admin base SCSS styles:
* Updated via upstream WordPress `_admin.scss` file via WP:changeset:38602, WP:changeset:38638, WP:changeset:38660, WP:changeset:39141, and WP:changeset:39249
See #2583
|
| [6818]
|
netweb
|
Appearance - Included Themes: Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:43019
* `_mixins.scss` via WP:changeset:41984
See #2583.
|
| [6910]
|
johnjamesjacoby
|
Appearance: Use right-to-left suffix in default template pack.
Fixes #3263. Props GDragoN.
|
| [7221]
|
johnjamesjacoby
|
Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In branches/2.6 for 2.6.8. Fixes #3443.
|
| [7220]
|
johnjamesjacoby
|
Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In trunk for 2.7. See #3443.
|
| [3203]
|
johnjamesjacoby
|
Apply editable_slug filter on form_options. Introduce bbp_form_option() functions to handle the output. Fixes #1526. Props ramly.
|
| [6738]
|
johnjamesjacoby
|
Args: pass default parameters into filters in `bbp_parse_args()`.
This change allows conditional filtering of parsed arguments based on the arguments originally passed in.
|
| [3455]
|
johnjamesjacoby
|
Ask and ye shall receive. Remove the logged in user avatar from the topic and reply forms in bbp-twentyten. Tweak the textarea's of those forms to fill the width of the bounding fieldsets.
|
| [6690]
|
johnjamesjacoby
|
Assets: Lint recent CSS & JS changes for password toggle.
This change makes the build process work again. :)
|
| [6261]
|
johnjamesjacoby
|
Assets: Remove `screen` restriction on default template pack styling.
Improves styling when printing and third-party plugins (like Autoptimize.)
Props thebrandonallen. Fixes #3012.
|
| [6608]
|
johnjamesjacoby
|
Assets: Update admin CSS/JS to match lint rules, and update packages.
|
| [3662]
|
johnjamesjacoby
|
Assorted forum template tag code improvements.
* Pass $forum_id in filters where possible
* Make sure echo functions pass all param's to return functions
* Pretty code tweaks
|
| [3663]
|
johnjamesjacoby
|
Assorted topic template tag code improvements.
* Pass $topic_id in filters where possible
* Make sure echo functions pass all param's to return functions
* Pretty code tweaks
|
| [2771]
|
johnjamesjacoby
|
Attempt to sort by menu_order rather than post_title.
|
| [5020]
|
johnjamesjacoby
|
Attributes are optional in the display_topic_form() shortcode. Suppresses debug notice when no attribute is passed, introduced in r5012. See #1649.
|
| [3267]
|
johnjamesjacoby
|
Audit checked() usage. Correct reversed logic, add usage to topic widget, and test all usages to ensure functionality.
|
| [3837]
|
johnjamesjacoby
|
Audit count functions and add number_format_i18n filter to them. See #1810.
|
| [3478]
|
johnjamesjacoby
|
Audit default usage value of '_bbp_forums_per_page'
|
| [6191]
|
johnjamesjacoby
|
Audit direct query and `prepare()` usages, and more tightly adhere to best practices.
* No quotes around directives
* Avoid concatenation, prefer variable parsing in double-quoted strings
* Covers converters, helper functions, and tools
|
| [4705]
|
johnjamesjacoby
|
Audit form field functions. Cast some $_POST values. Props Maty.
|
| [4708]
|
johnjamesjacoby
|
Audit form field functions. Cast some $_POST values. Props Maty. (2.2 branch)
|
| [4867]
|
johnjamesjacoby
|
Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (2.3 branch)
|
| [4866]
|
johnjamesjacoby
|
Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (trunk)
|
| [3651]
|
johnjamesjacoby
|
Audit the bbp-twentyten theme's actions, HTML, and CSS. See #1702.
|
| [3054]
|
johnjamesjacoby
|
Audit the usage of $wp_query global through out bbPress plugin and use core WP functions where possible instead.
|
| [3325]
|
johnjamesjacoby
|
Audit the usage of 'view=all' and create helper functions to handle frequent query arg checks and adjustments. Removes the need for passing $count_hidden between functions.
|
| [4948]
|
johnjamesjacoby
|
Audit title attributes, and remove instances where they would match template-tag contents. Fixes #2318.
|
| [4806]
|
johnjamesjacoby
|
Audit up widget code:
* Add missing UI for some options.
* Introduce methods for parsing widget arguments.
* General code clean up.
* Props alex-ye.
* Fixes #2250.
|
| [3344]
|
johnjamesjacoby
|
Audit usage of all _is_ functions. Introduce _is_single_ functions for post types, and use where applicable. Add query names to shortcodes. Fix improper favorite/subscribe links when used within a shortcode. Organize admin actions and filters in bbp-core-hooks.php.
|
| [3825]
|
johnjamesjacoby
|
Audit widgets for untranslated or incorrectly translated strings.
* Remove PHP4 compat from widgets
* Add missing translation to recent replies widget
* Add brackets to titles to better group widgets together
* Fixes #1797
|
| [6950]
|
johnjamesjacoby
|
Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.6.1, branches/2.6
|
| [6953]
|
johnjamesjacoby
|
Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.7, trunk.
|
| [6591]
|
johnjamesjacoby
|
Authors: Rejig author link functions.
* Allow for easier filtering of link sections
* Update default arguments to remove no-break space and `<br>`, and rely on styling instead
* Surrounding code clean-up
* Add escaping to display names in links
|
| [6565]
|
johnjamesjacoby
|
Authors: Use `bbp_get_fallback_display_name()` instead of "Anonymous".
This change uses the new function introduced in r6562 to allow the fallback display name to be filtered, and passes the relative topic or reply ID in for additional context.
|
| [3716]
|
johnjamesjacoby
|
Avoid inline variable assignments and cast appropriate retvals as int in bbp-forum-functions.php.
|
| [3715]
|
johnjamesjacoby
|
Avoid inline variable assignments in bbp-reply-functions.php.
|
| [5601]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.1 branch)
|
| [5603]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.2 branch)
|
| [5597]
|
nacin
|
Avoid notices in bbPress Akismet plugin-like hack thing.
|
| [5605]
|
johnjamesjacoby
|
Avoid notices in bbPress's Akismet plugin. For 1.2 branch. See r5597.
|
| [3660]
|
johnjamesjacoby
|
Avoid possible inline variable assignment in topics_column_data() method.
|
| [5643]
|
johnjamesjacoby
|
Backport `do_not_reply` email address code from trunk to 2.5 branch (for what will be 2.5.6.) See #2618, r5642.
|
| [2760]
|
johnjamesjacoby
|
Backport bb-login.php changes from trunk to 1.0 branch.
|
| [2791]
|
johnjamesjacoby
|
Backport clean_url fixes to 0.9 branch.
|
| [4759]
|
johnjamesjacoby
|
Backport roles improvements to 2.2 branch.
* bbp_add_forums_roles() now returns the modified roles global.
* Hardening around saving a user's role when editing their profile.
* Call bbp_add_forums_roles() in a few places to make sure roles are added before using add_role() or set_role().
|
| [4358]
|
johnjamesjacoby
|
Bail out of admin actions when deactivating bbPress. Prevents admin options and display actions from interfering with the deactivation process.
|
| [2978]
|
johnjamesjacoby
|
Bail out of bbp_pre_get_posts if suppress_filters argument is set.
|
| [3630]
|
johnjamesjacoby
|
Bail out of bbp_template_include_theme_compat() early if theme explicitly adds theme support for bbPress.
|
| [3631]
|
johnjamesjacoby
|
Bail out of bbp_template_include_theme_supports() early if theme does not support bbPress.
|
| [4770]
|
johnjamesjacoby
|
Bail out of converter if there is no request method. Fixes #2113.
|
| [2916]
|
johnjamesjacoby
|
Basic WordPress 3.0 compat in bbp_get_title for taxonomy
|
| [6583]
|
johnjamesjacoby
|
Better 404 handling:
* Introduce `bbp_is_404` query var, and set this in places where the default 404 condition needs to be overridden
* Introduce `bbp_set_200()` for cases where a default of 404 needs to be set to a 200
* Introduce `bbp_get_wp_query()` helper for getting the `$wp_query` global
* Update `bbp_set_404()` to accept a `$query` parameter to make passing the query around easier
* Update child-ids queries to use the `last_changed` cache to reduce the amount of cache churn when cleaning
Fixes #3047. See #1973.
|
| [5534]
|
johnjamesjacoby
|
Better ABSPATH check in `bbpress.php` stub loader.
|
| [4663]
|
johnjamesjacoby
|
Better CSS support for code tags nested in pre tags.
|
| [2731]
|
johnjamesjacoby
|
Better default permalink support
|
| [2788]
|
johnjamesjacoby
|
Better handling of title attributes. Props !GautamGupta via Google Code-in
|
| [2684]
|
johnjamesjacoby
|
Better latest reply handling for forums and topics
|
| [2654]
|
johnjamesjacoby
|
Better pagination verbiage
|
| [3007]
|
johnjamesjacoby
|
Better private forum support in single-forum.php and single-topic.php.
|
| [2584]
|
johnjamesjacoby
|
Better support for custom topic tag slug
|
| [3261]
|
johnjamesjacoby
|
Better support for forum categories in forum description template tag.
|
| [2776]
|
johnjamesjacoby
|
Better user edit and registration file inclusion checks.
|
| [6331]
|
johnjamesjacoby
|
Bootstrap: Split `setup_globals()` up into 2 methods:
* `setup_environment()` to handle directories, paths, urls, etc...
* `setup_variables()` to handle queries, rewrite rules, bbPress specific "globals", etc...
This will allow us to use included functions as default variables later.
|
| [3997]
|
johnjamesjacoby
|
Bozo Plugin (1.1 branch):
* Cast return value as array to suppress debug notice.
* Fixes #1646.
* Props !GautamGupta.
|
| [4175]
|
johnjamesjacoby
|
Bozo:
* Change post status to 'bozo' on creation/edit if user is a bozo.
* Modifies create/edit handlers for topics and replies.
|
| [4173]
|
johnjamesjacoby
|
Bozo:
* Map 'bozo' caps to disallow for moderators.
* Move inactive user check out of bbp_is_user_bozo() and into bbp_map_meta_caps().
|
| [4174]
|
johnjamesjacoby
|
Bozo:
* Use correct bbp_get_bozo_post_status() function when registering post status.
|
| [4169]
|
johnjamesjacoby
|
Bozons:
* Add bozo post_status and function helper.
* For 'bozo' capability.
|
| [4170]
|
johnjamesjacoby
|
Bozos:
* Add bbp_is_user_bozo() function to bbp-user-functions.php.
* Note that neither anonymous nor inactive users can be bozos, as they already either can or cannot post, and should not be allowed to post uncontrollably. This behavior differs from bbPress 1.x, where a bozo could also be a spam user.
|
| [4171]
|
johnjamesjacoby
|
Bozos:
* Add bozo post status to bbp_has_topics() and bbp_has_replies() if current user is a bozo.
|
| [5437]
|
johnjamesjacoby
|
Bracketize common component.
|
| [5438]
|
johnjamesjacoby
|
Bracketize core component.
|
| [5441]
|
johnjamesjacoby
|
Bracketize extensions, and missed a spot in the admin.
|
| [5435]
|
johnjamesjacoby
|
Bracketize forums component.
|
| [5431]
|
johnjamesjacoby
|
Bracketize replies component.
|
| [5433]
|
johnjamesjacoby
|
Bracketize search component.
|
| [5432]
|
johnjamesjacoby
|
Bracketize topics component.
|
| [5436]
|
johnjamesjacoby
|
Bracketize users component.
|
| [5440]
|
johnjamesjacoby
|
Brackets and code formatting improvements to admin component.
|
| [6160]
|
xknown
|
Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()` and PHP 5.x constructors.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
- Add PHP 5.x style constructors.
- Use `preg_match` instead of `eregi`
See #3033
|
| [6159]
|
xknown
|
Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6162]
|
xknown
|
Branch 0.9: Remove all the expressions that use the `preg_replace` function with the `e` modifier.
The `e`(val) modifier is not longer supported in PHP7, use `preg_replace_callback` instead.
See #3033
|
| [6161]
|
xknown
|
Branch 0.9: Use `preg_match` instead of `ereg`
See #3033
|
| [6158]
|
xknown
|
Branch 0.9: use a more recent version of add_query_arg which reduces the use of `func_get_arg`.
See #3033
|
| [6165]
|
xknown
|
Branch 1.2: Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument.
- Add also PHP 5.x style constructors.
See #3033
|
| [6167]
|
xknown
|
Branch 1.2: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6163]
|
xknown
|
Branch 1.2: Fix parse errors in PHP 7
The result of new can't be longer assigned by reference.
See #3033
|
| [4373]
|
johnjamesjacoby
|
Breadcrumb:
* Fix copy-pasta in bbp_get_breadcrumb().
* Regression from adding more arguments to HTML output.
* Fixes #2017.
|
| [4332]
|
johnjamesjacoby
|
Breadcrumb:
* More flexible HTML output for breadcrumb.
* Adds ability to modify HTML before/after separator, current, and each crumb.
* Hat-tip netweb for inital patch.
* Fixes #2009.
|
| [3898]
|
johnjamesjacoby
|
Breadcrumbs:
* Add classes to breadcrumb items that were missing them (forum|topic|reply|topic-tag)
* Fixes #1821.
* Props netweb for original patch.
|