| [3158]
|
johnjamesjacoby
|
Use esc_sql in place of esc_url_raw for now, as esc_url_raw doesn't work correctly for single slugs.
|
| [3353]
|
johnjamesjacoby
|
Use esc_url_raw() instead of sanitize_url() in bbp_get_topic_permalink()
|
| [4839]
|
johnjamesjacoby
|
Use feed_content_type() in feeds. See #2292.
|
| [3414]
|
johnjamesjacoby
|
Use get_current_blog_id() rather than $wpdb->blogid
|
| [3543]
|
johnjamesjacoby
|
Use get_post_class() to fix premature echo of forum/topic/reply post classes. Fixes #1650.
|
| [3571]
|
johnjamesjacoby
|
Use get_post_class() to fix premature echo of forum/topic/reply post classes. See #1650, r3543. (2.1)
|
| [2940]
|
johnjamesjacoby
|
Use get_posts() in bbp_has_topics() so stickies can try to hit the DB object cache. Also rejig the post_parent to use 'any' instead of '0' to avoid query conflicts, and set default $post_parent variable ahead of time.
|
| [3676]
|
johnjamesjacoby
|
Use get_the_author_meta() rather than the $post global in topic and reply forms.
|
| [3910]
|
johnjamesjacoby
|
Use get_users() in bbp_get_total_users() to avoid a direct database query. See #1826. Props tott.
|
| [4896]
|
johnjamesjacoby
|
Use implode() instead of join() through-out project. See #2331.
|
| [3628]
|
johnjamesjacoby
|
Use is_a() in bbp-twentyten/functions.php so class extension works correctly.
|
| [3644]
|
johnjamesjacoby
|
Use is_main_query() in bbp_pre_get_posts() (for 2.1 which will be for WordPress 3.3 and higher)
|
| [5237]
|
johnjamesjacoby
|
Use more explicit subscriptions functions for form output. Fixes #2493. (2.5 branch)
|
| [5236]
|
johnjamesjacoby
|
Use more explicit subscriptions functions for form output. Fixes #2493. (trunk)
|
| [5204]
|
johnjamesjacoby
|
Use more intelligent calculation of path to url for style and script enqueueing.
|
| [2876]
|
johnjamesjacoby
|
Use more strict post_type check in bbp_get_forum_id. More renaming of last_active functions to last_active_time in bbp-forum-template.php. Introduce last_active_id functions. Introduce single forum description function.
|
| [6124]
|
johnjamesjacoby
|
Use new `bbp_translate_role_name()` function in `bbp_get_dynamic_role_name()`. For 2.5 branch (2.5.11)
|
| [2794]
|
johnjamesjacoby
|
Use new action hooks for forum/topic/reply column headers
|
| [2793]
|
johnjamesjacoby
|
Use new action hooks for forum/topic/reply column headers
|
| [2875]
|
johnjamesjacoby
|
Use new bbp_author_link function in loop-bbp_forums.php, to show username and avatar of last forum post_id
|
| [3981]
|
johnjamesjacoby
|
Use non-echo template-tag for topics archive in bbp_has_topics. See: r3979.
|
| [4387]
|
johnjamesjacoby
|
Use options-general.php file in settings link in What's New and Credits pages. See #2018.
|
| [2683]
|
johnjamesjacoby
|
Use post_meta for topic freshness.
|
| [2543]
|
johnjamesjacoby
|
Use post_modified_time for now. Needs API.
|
| [3637]
|
johnjamesjacoby
|
Use pre-query-filters in shortcodes, and fix topic-tag query. Fixes #1687, props ptahdunbar for original patch.
|
| [3291]
|
johnjamesjacoby
|
Use pre_get_posts to filter out hidden forum content instead of using multiple calls to bbp_exclude_forum_ids().
This ensures that no hidden or private forum content leaks out into widgets, profiles, and views, and also limits the liability of future plugins from needing to exclude those forum_id's manually.
The behavior of bbp_exclude_forum_ids() has changed to handle the gathering of forum ID's to be excluded, with the optional parameter to return results in different formats.
|
| [4949]
|
johnjamesjacoby
|
Use printf() instead of echo'ing sprintf() in admin.php.
|
| [3751]
|
johnjamesjacoby
|
Use proper function in bbp_get_the_content(). Fixes #1731.
|
| [3813]
|
johnjamesjacoby
|
Use proper permalink in bbp_get_user_favorites_link(). Props jaredatch. Fixes #1790.
|
| [4981]
|
johnjamesjacoby
|
Use raw user-data values in bbp_edit_user_handler(). See #1999.
|
| [5134]
|
johnjamesjacoby
|
Use rewrite ID helper functions instead of hardcoded strings.
|
| [2480]
|
PeteMall
|
Use sprite image for top level admin menu icons.
|
| [5022]
|
johnjamesjacoby
|
Use strict comparisons in bbp_toggle_topic_handler(). See #2358.
|
| [4995]
|
johnjamesjacoby
|
Use strict comparisons where possible (excluding the converter code, as it needs dedicated testing.) See #2358.
|
| [5021]
|
johnjamesjacoby
|
Use string values when comparing against super globals. Regression introduced in r4995. See #2358.
|
| [5521]
|
netweb
|
Use tabs not spaces for indentation in `Kunena1.php`
|
| [5462]
|
johnjamesjacoby
|
Use the correct `EMPTY_TRASH_DAYS` const.
|
| [5005]
|
johnjamesjacoby
|
Use the correct array index string in bbp_get_breadcrumb() ( 'current_text' VS 'pre_current_text' ). Props mrcl. Fixes #2361.
|
| [5004]
|
johnjamesjacoby
|
Use the correct filter ID string in bbp_get_forum_pagination_count(). Props mrcl. Fixes #2362.
|
| [4763]
|
johnjamesjacoby
|
Use the correct variable name in bbp_add_template_stack_locations(). See r4762.
|
| [4978]
|
johnjamesjacoby
|
Use the forum content in search results, and not the_excerpt() to avoid recursed calls to 'the_content'. See #2343.
|
| [3208]
|
johnjamesjacoby
|
Use the raw_url on login redirect if one is passed. Otherwise check if $url both empty or is sending the user to admin_url(), and default to home_url() to prevent users from being bounced into the admin area unexpectedly. See #1530.
|
| [3921]
|
johnjamesjacoby
|
Use trailingslashit() in bbp_locate_template() to prevent double slashes.
|
| [4992]
|
johnjamesjacoby
|
Use wp_update_post() in bbp_update_reply_position(), instead of $wpdb->update(). Ensures that post caches are cleared when manually updating a reply position via its menu_order property. See #2351.
|
| [5131]
|
johnjamesjacoby
|
Use wrapper functions introduced in r5130 for custom post-types and taxonomy.
|
| [3918]
|
johnjamesjacoby
|
User Edit:
* Add missing bbp_is_user_home_edit() function and use where appropriate.
* Add bbp_is_user_home_edit() checks to is_bbpress() and body class.
|
| [4276]
|
johnjamesjacoby
|
User Edit:
* Hook bbp_user_edit_after() on to 'bbp_user_edit_after' action.
* Hat-tip jakemgold.
|
| [4274]
|
johnjamesjacoby
|
User Edit:
* Introduce bbp_user_edit_after() to handle additional core actions on profile edit.
* Hat-tip jakemgold for noticing they were missing.
|
| [4196]
|
johnjamesjacoby
|
User Edit:
* Load grant/revoke super admin functions if they are not available.
* Remove empty user role check, as all users will have default roles going forward.
* Tweak input/label CSS when editing a user profile.
|
| [3988]
|
johnjamesjacoby
|
User Edit:
* Rework bbp_check_user_edit() to redirect by default, and make users earn the ability to edit other users.
* Fix issue where non-admin users of multisite networks cannot edit their own profiles.
* Fixes #1855.
|
| [4275]
|
johnjamesjacoby
|
User Edit:
* Switch form-user-edit.php enctype to 'multipart/form-data'
* More easily enables plugins to interface with binary data, uploads, etc...
* Hat-tip jakemgold.
|
| [4197]
|
johnjamesjacoby
|
User Edit:
* Tweak capabilities CSS.
* Also include RTL styling.
|
| [4227]
|
johnjamesjacoby
|
User Edit:
* Use $name variable instead of literal 'name' text in form-user-edit.php.
* Fixes issue with displaying and saving extra user contact methods.
* Fixes #1955.
* Props piecheff.
|
| [3911]
|
johnjamesjacoby
|
User Options:
* Introduce bbp-user-options.php to handle all user option related code.
* Add $user_options array to main bbPress class to allow for easy, static, per-user option overrides.
* Tweak action order for option and user_option overrides in bbp-core-hooks.php.
* Replace all appropriate user_meta calls with user_option calls to automatically prefix keys with blog ID.
* Update favorites, subscriptions, and topic/reply count option keys to be per-blog in multisite configurations.
* Fixes #1826.
|
| [4195]
|
johnjamesjacoby
|
User Options:
* Update phpdoc for bbp_add_user_options()
* Pass $user_id into action when adding and removing options.
|
| [6359]
|
johnjamesjacoby
|
User Options: Clean-up favorites & subscriptions from options,
|
| [4229]
|
johnjamesjacoby
|
User Profile templates:
* Change "Topics Created" to "Topics Started" to not be confused with "Replies Created"
|
| [4233]
|
johnjamesjacoby
|
User Profiles:
* Fix padding on user profile avatar.
* Update RTL CSS for user profiles.
* Props jaredatch.
* Fixes #1960.
|
| [4256]
|
johnjamesjacoby
|
User Profiles:
* In theme compat, force the header status back to 200 if not deliberately set to 404.
* Fixes #1973.
|
| [2625]
|
johnjamesjacoby
|
User cap checks on reply and topic handlers.
|
| [6105]
|
johnjamesjacoby
|
User: Remove `_doing_it_wrong()` notice from `bbp_setup_current_user()`.
The current user is always bootstrapped early in WordPress 4.7, so this notice is no longer valid.
An update for bootstrapping dynamic roles is imminent.
See #2309.
|
| [4670]
|
johnjamesjacoby
|
Users on single-site installations can have all-numeric usernames, causing profile URLs like '/forums/users/55555/' to be parsed incorrectly.
In bbp_parse_query(), check the 'permalink_structure' option before checking if the 'bbp_user' WP query variable is not numeric.
This has the potentially negative side-effect of not being able to use the query-var with a numeric user ID when using pretty permalinks, but that was never intended behavior anyways.
Fixes #2136.
|
| [4188]
|
johnjamesjacoby
|
Users:
* Add options and functions for user favorites and subscriptions slugs.
|
| [4191]
|
johnjamesjacoby
|
Users:
* First pass at updating bbp-theme-compat for new favorites/subscriptions template behavior.
* Removes query name usage from templates.
|
| [4389]
|
johnjamesjacoby
|
Users:
* Fix incorrectly classed replies link in user profiles navigation.
* Props netweb.
* Fixes #2019.
|
| [4464]
|
johnjamesjacoby
|
Users:
* Fix misspelling and update doc in user-topics-created.php.
* Props netweb.
* Fixes #2048 (2.2 branch)
|
| [4465]
|
johnjamesjacoby
|
Users:
* Fix misspelling and update doc in user-topics-created.php.
* Props netweb.
* Fixes #2048 (trunk)
|
| [4242]
|
johnjamesjacoby
|
Users:
* In bbp_parse_query, bail if displayed user is not a member of current blog, or no longer active.
|
| [4467]
|
johnjamesjacoby
|
Users:
* Reference correct template part in single-user-edit.php.
* Fixes #2045 (2.2 branch)
|
| [4466]
|
johnjamesjacoby
|
Users:
* Reference correct template part in single-user-edit.php.
* Fixes #2045 (trunk)
|
| [4478]
|
johnjamesjacoby
|
Users:
* Remove old twentyten filter name in user-details.php. (2.2 branch)
|
| [4477]
|
johnjamesjacoby
|
Users:
* Remove old twentyten filter name in user-details.php. (trunk)
|
| [4370]
|
johnjamesjacoby
|
Users:
* Update _is_ functions for user_status (spam|deleted)
* Remove check of 'user_status' column value, since core only uses 'spam' and 'deleted' now.
* Fixes issue where a 'user_status' setting would produce a false positive.
|
| [4189]
|
johnjamesjacoby
|
Users:
* Update behavior of is functions for favorites and subscriptions to use parsed query variables.
* Introduce functions for getting the rewrite ID's.
|
| [4463]
|
johnjamesjacoby
|
Users:
* Update for profiles to support more theme widths.
* Update fields and description labels.
* Move favorite and subscription X's to before topic title, instead of creating another faux-column.
* Some HTML mark-up changes to support fixes.
* Merge styles into RTL and reverse as needed.
* Fixes #1964 (2.2 branch)
|
| [4462]
|
johnjamesjacoby
|
Users:
* Update for profiles to support more theme widths.
* Update fields and description labels.
* Move favorite and subscription X's to before topic title, instead of creating another faux-column.
* Some HTML mark-up changes to support fixes.
* Merge styles into RTL and reverse as needed.
* Fixes #1964 (trunk)
|
| [4190]
|
johnjamesjacoby
|
Users:
* Update main bbPress class and bbp_parse_query() for updated favorites and subscriptions behavior.
|
| [6216]
|
johnjamesjacoby
|
Users: Add `nopaging` to `WP_Query` usages.
Fixes bug with favs/subs being limited to 10 results by default. See #2959.
|
| [6592]
|
johnjamesjacoby
|
Users: Add `user_url`, `user_registered`, and last-active to profiles.
Also divide profile page up into 2 sections: Profile & Forums.
|
| [6502]
|
johnjamesjacoby
|
Users: Add a "View" link to list-table row-actions.
This connects `wp-admin` users to their theme-side forum profiles.
|
| [5806]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.5.8 (2.5 branch)
|
| [5805]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.6 (trunk)
|
| [6294]
|
netweb
|
Users: Add missing asterix from PHPDoc block in `bbp_make_spam_user()`
|
| [5666]
|
johnjamesjacoby
|
Users: Add missing textdomains to new strings. See #2780.
|
| [5902]
|
johnjamesjacoby
|
Users: Add tests for user permalink functions. Props thebrandonallen. See #2831.
|
| [6413]
|
johnjamesjacoby
|
Users: Admin sub-headings are now `h2` tags.
|
| [6562]
|
johnjamesjacoby
|
Users: Audit user template functions.
* Additional late escaping on meta-data return values where they are surrounded by HTML markup
* Introduce helper function for filtering & returning the 'Anonymous' fallback display name (we'll use this through-out the existing author name fallbacks)
* Use more internal helpers & handlers where they are available
|
| [6505]
|
johnjamesjacoby
|
Users: Bail if editing a user in wp-admin.
This is a theme-side only handler.
|
| [6617]
|
SergeyBiryukov
|
Users: Check `promote_user` capability instead of `edit_user` before displaying "User Role" section in `form-user-edit.php`, for consistency with `bbp_profile_update_role()`.
Fixes #3126.
|
| [6567]
|
johnjamesjacoby
|
Users: Check for ability to edit before falling back to `publish`.
This change prioritizes a user's ability to edit a forum/topic/reply over the fallback to the ability to publish, allowing per-forum moderators the ability to access the relative theme-side forms.
|
| [5664]
|
johnjamesjacoby
|
Users: Clean up email message string replacements in `bbp_edit_user_email_send_notification()`. See #2780.
|
| [6431]
|
johnjamesjacoby
|
Users: Connect `bbp_allow_forums_of_user` filter to `bbp_get_excluded_forum_ids` filter.
This prevents excluding private or hidden forums that the currently logged in user can explicitly moderate.
Fixes #2593.
|
| [7104]
|
johnjamesjacoby
|
Users: Correctly calculate offset in User Profile > Last Activity.
Previous to this, Last Activity was being saved with `time()` but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.
Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.
In branches/2.6, for 2.6.6.
See #3378.
|
| [7105]
|
johnjamesjacoby
|
Users: Correctly calculate offset in User Profile > Last Activity.
Previous to this, Last Activity was being saved with `time()` but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.
Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.
In trunk, for 2.7.0.
Fixes #3378.
|
| [5663]
|
johnjamesjacoby
|
Users: Email address change improvements:
* Introduce function for handling sending notification email
* Clean up code required to update, save, confirm, & dismiss pending email address changes
* Fixes bug in previous implementation making it impossible to interact with pending email address changes on multisite installations
Fixes #2780.
|
| [5662]
|
johnjamesjacoby
|
Users: Extract `$_GET` conditions out of `bbp_edit_user_handler()` and into their own function, hooked to `bbp_get_request` action.
This fixes functionality that was only half ported from `edit_user()` & WordPress multisite which allows a user to confirm or dismiss pending email address changes to their account from within their bbPress profile edit page.
See #2780.
|
| [6623]
|
johnjamesjacoby
|
Users: First-pass search forms in profile content pages.
This commit makes it possible to search user profiles for specific topics & replies (styling still needed.)
|
| [7189]
|
johnjamesjacoby
|
Users: Improve UX of form-user-passwords.php template part.
This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.
It also includes the following related improvements:
* Introduce `bbp_doing_script_debug()` and `bbp_doing_autosave()` helpers, and use them where needed
* Introduce `bbp_asset_version()` and `bbp_get_asset_version()` to bust asset cache when debugging
* Update `forum-user-passwords.php` template part to swap out body class and add missing element ID
* Update password form styling in `bbpress.css` default theme compat CSS
In branches/2.6 for 2.6.7. See #3421.
|
| [7190]
|
johnjamesjacoby
|
Users: Improve UX of form-user-passwords.php template part.
This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.
It also includes the following related improvements:
* Introduce `bbp_doing_script_debug()` and `bbp_doing_autosave()` helpers, and use them where needed
* Introduce `bbp_asset_version()` and `bbp_get_asset_version()` to bust asset cache when debugging
* Update `forum-user-passwords.php` template part to swap out body class and add missing element ID
* Update password form styling in `bbpress.css` default theme compat CSS
In trunk for 2.7.0. Fixes #3421.
|
| [5949]
|
netweb
|
Users: In `BBP_Default::enqueue_scripts` remove rogue script dependency for single user edits
This changeset removes the `user-query` dependency that was accidentally introduced in r5183
Props tharsheblows
Fixes #2877
|