| [6897]
|
johnjamesjacoby
|
Upgrades: append upgrade count to "Tools" if there are pending upgrades
* Add function and method to tweak the `$menu` global
* Add styling for count in `nav-tab-wrapper` UI
This change adds a `span.awaiting-mod` wrapper around the pending upgrade count in a few strategic locations around the WordPress Admin UI.
See #3244.
|
| [6896]
|
johnjamesjacoby
|
Upgrades: change skipped upgrades to pending upgrade
* Add functions for managing pending upgrades
* Use IDs instead of strings for active tools tab
* Add classes and `hr` for related H1's
* Update registered option key name
* Add skipped upgrades to pending upgrades array
* Add `span` to allowed tags in notices
These changes are necessary to bring adimn pages up to speed with WordPress Admin UI mark-up, in relation to the database upgrade notice.
See #3244.
|
| [6891]
|
johnjamesjacoby
|
Upgrades: remove duplicate `wp_cache_flush()` call.
From `bbp_admin_repair_reply_menu_order()`, since repair tools flush the caches anyways, this is not necessary here.
Found during work on #3244.
|
| [4930]
|
johnjamesjacoby
|
Use !WordPress core rewrite API to add rewrite tags, rules, and permalink structures. Replaces the need to merge rewrite rules directly into the $wp_rewrite array on permalink flush. In the future, much of this complexity can be turned into easier to use functions to add new profile pages, etc... Fixes #2336. See #2337.
|
| [5471]
|
johnjamesjacoby
|
Use "Unfavorite" in `bbp_get_user_favorites_link()`. Fixes #2604.
|
| [3598]
|
johnjamesjacoby
|
Use $plugin variable in bbp_is_activation()
|
| [4571]
|
jmdodd
|
Use $r['topic_id'] to set initial $topic_id value.
* Fixes #2098.
|
| [2939]
|
johnjamesjacoby
|
Use 'any' for post_parent in bbp-widgets.php to avoid conflict with '0' value.
|
| [5312]
|
johnjamesjacoby
|
Use 'array_diff()` rather than `array_intersect()` in `bbp_pre_get_posts_normalize_forum_visibility()` to allow custom `post_type` queries (that still include forums/topics/replies) to pass through without hidden/private forum `meta_data` assistance. Fixes #2471.
|
| [3288]
|
johnjamesjacoby
|
Use 'bbp_admin_init' instead of 'admin_init' in BBP_Admin::_setup_actions()
|
| [2807]
|
johnjamesjacoby
|
Use 'code' CSS class for slug settings
|
| [4519]
|
johnjamesjacoby
|
Use 'post_parent' instead of 'child_of' in bbp_get_dropdown() usages. See #2061.
|
| [2848]
|
johnjamesjacoby
|
Use API functions for forum topic/reply recounts. By doing this we're sacrificing performance to get more accurate counts specifically for subforum situations. This will probably need to be revisited in the future when a proper Walker can be used.
|
| [5972]
|
netweb
|
Use HTTPS for w.org links
|
| [3732]
|
johnjamesjacoby
|
Use _n() for plural topic and reply counts. Fixes #1605. Props pavelevap for initial patch.
|
| [4658]
|
johnjamesjacoby
|
Use _wp_specialchars() instead of deprecated wp_specialchars().
|
| [5464]
|
netweb
|
Use `Topic Tag` term for singular topic tag context in 'at a glance' dashboard metabox. Fixes #2544
|
| [5325]
|
johnjamesjacoby
|
Use `basename` instead of `file` in plugin action links. Props DJPaul. Fixes #2567.
|
| [6336]
|
johnjamesjacoby
|
Use `bbp_rel_nofollow()` in `bbp_make_mentions_clickable_callback()`. See #3067.
|
| [6337]
|
johnjamesjacoby
|
Use `bbp_rel_nofollow()` in deprecated `bbp_mention_filter()` for the sake of parity & coverage. See #3067.
|
| [5262]
|
johnjamesjacoby
|
Use `content_url()` rather than `WP_CONTENT_URL` for style and script enqueue functions, fixing insecure content warnings when using SSL theme-side. Props tonyrix. Fixes #2518. (2.5 branch)
|
| [5261]
|
johnjamesjacoby
|
Use `content_url()` rather than `WP_CONTENT_URL` for style and script enqueue functions, fixing insecure content warnings when using SSL theme-side. Props tonyrix. Fixes #2518. (trunk)
|
| [5475]
|
johnjamesjacoby
|
Use `exclude` instead of post__not_in, in `bbp_get_forums_for_current_user()`.
|
| [5628]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (2.5 branch)
|
| [5625]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (trunk)
|
| [5306]
|
netweb
|
Use `height: auto;` alongside `max-width: 100%;` in `bbpress.css` to maintain image aspect ratio. Props robin-w. Fixes #2553
|
| [6068]
|
johnjamesjacoby
|
Use `length-zero-no-unit` over `number-zero-length-no-unit` in `.stylelintrc`.
Deprecated in 7.0 of stylelint.
|
| [5639]
|
netweb
|
Use `preg_replace` over incorrect `ltrim` usage in `bbp_get_do_not_reply_address()` causing undeliverable or invalid subscription emails in certain situations because the "from" address was incorrect.
Props DJPaul. See #2618 (2.5 Branch)
|
| [5640]
|
netweb
|
Use `preg_replace` over incorrect `ltrim` usage in `bbp_get_do_not_reply_address()` causing undeliverable or invalid subscription emails in certain situations because the "from" address was incorrect.
Props DJPaul. See #2618 (trunk)
|
| [5588]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_get_form_reply_status_dropdown()` to ensure value is within expected boundaries. See #2742.
|
| [5587]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_post_request()` and `bbp_get_request()`, improving the predictability of possible actions. See #2742.
|
| [5591]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_profile_update_role()` to ensure role value is within expected boundaries. See #2742.
|
| [5592]
|
johnjamesjacoby
|
Use `sanitize_key()` in `forums/template.php` to ensure values are within expected boundaries. See #2742.
|
| [5589]
|
johnjamesjacoby
|
Use `sanitize_key()` in `topics/functions.php` to ensure values are within expected boundaries. See #2742.
|
| [5590]
|
johnjamesjacoby
|
Use `sanitize_user()` in `bbp_user_maybe_convert_pass()` to ensure user login is within expected boundaries. See #2742.
|
| [5472]
|
johnjamesjacoby
|
Use `wp_get_user_contact_methods()` in `bbp_get_user_contact_methods()`. See #2570.
|
| [4957]
|
johnjamesjacoby
|
Use array_keys() in user option filter functions when looping through default user options.
|
| [4994]
|
johnjamesjacoby
|
Use bbPress functions for getting the reply and topic author ID instead of using get_the_author_meta( 'ID' ). Allows for strict comparisons and uses bbPress's filters for the related functions.
|
| [5075]
|
johnjamesjacoby
|
Use bbp_forum_content() instead of bbp_the_content() in loop-search-forum.php. Fixes missing forum description in search results. Props netweb. Fixes #2387.
|
| [3489]
|
johnjamesjacoby
|
Use bbp_get_all_child_ids() instead of bbp_get_public_child_ids() in bbp_move_topic_handler(). Fixes #1627.
|
| [3411]
|
johnjamesjacoby
|
Use bbp_get_displayed_user_id() where applicable. Address issue where editing a user profile page would cause global error messages.
|
| [3694]
|
johnjamesjacoby
|
Use bbp_get_forum_visibility() instead of bbp_get_forum_status() in bbp_template_include_theme_compat(). Fixes #1731.
|
| [4921]
|
johnjamesjacoby
|
Use bbp_get_search_url() in bbp_get_breadcrumb() so that it works without pretty permalinks. See #2337.
|
| [5078]
|
johnjamesjacoby
|
Use bbp_get_topic_types() rather than compare to hardcoded array. Also switch from isset() to !empty() checks, and add an empty() check for 'sub_action' when toggling a topic.
|
| [3761]
|
johnjamesjacoby
|
Use bbp_get_view_slug() in bbp_get_view_url(). See #1760.
|
| [3748]
|
johnjamesjacoby
|
Use bbp_redirect_to_field() in form_fields() functions. See #1669.
|
| [3683]
|
johnjamesjacoby
|
Use bbp_save_forum_extras() in forum metabox and cast 'parent_id' POST value as int. Also fix possible accidental assignments in bbp-forum.php.
|
| [3209]
|
johnjamesjacoby
|
Use bbp_update_forum() in bbp_recount_rewalk() admin recount function. See #1534.
|
| [3775]
|
johnjamesjacoby
|
Use bbpress() function and avoid creating a one-time variable in bbp_parse_request()
|
| [4516]
|
johnjamesjacoby
|
Use bloginfo_rss() instead of get_option().
|
| [2515]
|
johnjamesjacoby
|
Use classes the right way, at least until php 5 support comes around
|
| [4797]
|
johnjamesjacoby
|
Use correct $_user_id variable in user_can() check in bbp_is_user_keymaster(). Props imath. Fixes #2256.
|
| [3935]
|
johnjamesjacoby
|
Use correct $default_post_status variable for sticky topics.
|
| [2869]
|
johnjamesjacoby
|
Use correct $parent_id variable name in bbp_get_public functions
|
| [4010]
|
johnjamesjacoby
|
Use correct $the_post variable in bbp_is_custom_post_type(). See r4009.
|
| [3578]
|
johnjamesjacoby
|
Use correct $user->ID variable and bbp_get_current_user_id() function in bbp_pre_get_posts().
|
| [5108]
|
johnjamesjacoby
|
Use correct '_bbp_post_id' meta_key in converter callback_reply_to. Fixes incorrect mapping of converted hierarchical replies. Props netweb. Fixes #2439. (2.4.1)
|
| [5107]
|
johnjamesjacoby
|
Use correct '_bbp_post_id' meta_key in converter callback_reply_to. Fixes incorrect mapping of converted hierarchical replies. Props netweb. Fixes #2439. (2.5)
|
| [4617]
|
johnjamesjacoby
|
Use correct 'is-subscribed' class instead of 'is_subscribed' for subscriptions link.
|
| [5342]
|
netweb
|
Use correct PHPUnit configuration file `phpunit.xml.dist` for Grunt task `grunt phpunit`
* Props netweb. See #2542
|
| [3272]
|
johnjamesjacoby
|
Use correct _get_ function in reply post rows. Fig a bug introduced in r3260.
|
| [2919]
|
johnjamesjacoby
|
Use correct _last_active_time function. Props @wonderboymusic via Twitter.
|
| [2854]
|
johnjamesjacoby
|
Use correct _topic_ function to check user subscription status in form-bbp_reply.php in bbp-twentyten
|
| [5351]
|
johnjamesjacoby
|
Use correct `word-wrap` CSS property in `templates/default/bbpress.css`. Fixes problem with long author-names not wrapping correctly.
|
| [5185]
|
johnjamesjacoby
|
Use correct anonymous post data array indexes in `akismet.php`. See #2476.
|
| [4776]
|
johnjamesjacoby
|
Use correct array key in BBP_Forums_Group_Extension::display_forums(). Props thebrandonallen. Fixes #2215.
|
| [5187]
|
johnjamesjacoby
|
Use correct array variable name in `bbp_get_current_anonymous_user_data()`. Fixes #2476. Props netweb.
|
| [2856]
|
johnjamesjacoby
|
Use correct author name function in replies widget
|
| [4756]
|
johnjamesjacoby
|
Use correct bbPress version number in doing_it_wrong() usage in bbp_setup_current_user().
|
| [4955]
|
johnjamesjacoby
|
Use correct bbp_get_displayed_user_id() function in bbp_make_ham_user().
|
| [4587]
|
johnjamesjacoby
|
Use correct bbp_get_time_since() function in _post_date() template tags for topics and replies. Fixes #2114.
|
| [4702]
|
johnjamesjacoby
|
Use correct bbp_group_is_banned() function. Props r-a-y. Fixes #2150.
|
| [3793]
|
johnjamesjacoby
|
Use correct bbp_is_group_forums_active() function for BuddyPress Group Forum check.
|
| [2839]
|
johnjamesjacoby
|
Use correct bbp_user_profile_link function in login widget
|
| [4862]
|
johnjamesjacoby
|
Use correct cache group in bbp_clean_post_cache(). Props wpdennis. Fixes #2312 (2.3 branch)
|
| [4863]
|
johnjamesjacoby
|
Use correct cache group in bbp_clean_post_cache(). Props wpdennis. Fixes #2312 (trunk)
|
| [4399]
|
johnjamesjacoby
|
Use correct component, item_id, and secondary_item_id in group-forum activity. Props r-a-y. Fixes #2023.
|
| [3560]
|
johnjamesjacoby
|
Use correct current_action() function in BuddyPress extension user_profile_url() method. Fixes incorrect URL's for Forum sub-actions.
|
| [4398]
|
johnjamesjacoby
|
Use correct database name/prefix in group-forum relationship tool. Props r-a-y. Fixes #2022.
|
| [6736]
|
johnjamesjacoby
|
Use correct filter key in `bbp_get_author_link()`. See r6735.
|
| [5304]
|
johnjamesjacoby
|
Use correct filter name in `bbp_get_forum_slug()`. Props netweb. Fixes #2525.
|
| [4865]
|
johnjamesjacoby
|
Use correct filter names in bbp_is_user_deleted() and bbp_is_user_spammer(). Props alex-ye. Antiprops johnjamesjacoby. (2.3 branch)
|
| [4864]
|
johnjamesjacoby
|
Use correct filter names in bbp_is_user_deleted() and bbp_is_user_spammer(). Props alex-ye. Antiprops johnjamesjacoby. (trunk)
|
| [3747]
|
johnjamesjacoby
|
Use correct parent field attributes in bbp_forum_form_fields()
|
| [3164]
|
johnjamesjacoby
|
Use correct return value in bbp_suppress_private_forum_meta()
|
| [3163]
|
johnjamesjacoby
|
Use correct return variable in bbp_suppress_private_author_link()
|
| [5238]
|
johnjamesjacoby
|
Use correct scheme strings in `bbp_verify_nonce_request()`. Fixes false negative bbPress-specific nonce checks in functions and methods that do not use WordPress's traditional nonce/die pairing. Fixes #2492. Props MZAWeb. (2.5 branch)
|
| [5239]
|
johnjamesjacoby
|
Use correct scheme strings in `bbp_verify_nonce_request()`. Fixes false negative bbPress-specific nonce checks in functions and methods that do not use WordPress's traditional nonce/die pairing. Fixes #2492. Props MZAWeb. (trunk)
|
| [4386]
|
johnjamesjacoby
|
Use correct settings page link in What's New and Credits pages. See #2018.
|
| [2800]
|
johnjamesjacoby
|
Use correct table column when deleting terms. See #1353
|
| [5311]
|
johnjamesjacoby
|
Use correct uppercase type hinting for forum meta queries.
|
| [3514]
|
johnjamesjacoby
|
Use correct while loop format in single-reply-edit.php and single-topic-edit.php in bbp-twentyten. Props jghazally.
|
| [3459]
|
johnjamesjacoby
|
Use disabled() in topic and reply forms. Remove duplicate breadcrumbs on single reply edits. Fixes #1608. Props !GautamGupta.
|
| [5112]
|
johnjamesjacoby
|
Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.4.1)
|
| [5111]
|
johnjamesjacoby
|
Use empty() instead of strict 'on' comparison in topics widget. Props alex-ye. Fixes #2319. (2.5)
|
| [3824]
|
johnjamesjacoby
|
Use esc_attr__ where appropriate. See #1798.
|
| [4768]
|
johnjamesjacoby
|
Use esc_attr_e() in form-search.php. Props paulgibbs. Fixes #2212.
|
| [4953]
|
johnjamesjacoby
|
Use esc_html__() instead of esc_attr__() is two common template functions.
|
| [4959]
|
johnjamesjacoby
|
Use esc_html_e() in extensions. See #1999.
|
| [4958]
|
johnjamesjacoby
|
Use esc_html_e() in user template functions. See #1999.
|