| [6862]
|
johnjamesjacoby
|
Theme Compat: introduce `bbp_locate_enqueueable()` and `bbp_urlize_enqueueable()`.
These functions are used to help make locating enqueueable assets easier, and use `bbp_locate_template()` interntally, now accepting an array of files.
In addition, `bbp_locate_enqueueable()` also internally juggles minimized file variations, and stacks them according to the `SCRIPT_DEBUG` constant. This ensures that both minimized and unminimized file variants are in the array in the preferred order.
This fixes a regression between bbPress 2.5 and 2.6 caused by the bundling of minimized assets in theme compatibility, and ensures that sites with their own `bbpress.css` files in their own locations will continue to get loaded, regardless of the `SCRIPT_DEBUG` setting.
Fixes #3218.
|
| [6986]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
|
| [6987]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
For 2.6.3, branches/2.6.
|
| [7168]
|
johnjamesjacoby
|
Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`.
This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes.
In branches/2.6 for 2.6.6. Fixes #3415.
Props lyndseyh.
|
| [7167]
|
johnjamesjacoby
|
Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`.
This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes.
In trunk for 2.7.0. See #3415.
Props lyndseyh.
|
| [7328]
|
johnjamesjacoby
|
Theme Compat: remove reference to non-existent function.
This change removes a function call to `display_reply_index()` which does not exist, and replaces it with an empty string.
This condition will not fire under normal circumstances as the Reply post type does not support archives by default. The chances of this fatal error happening are near zero, but we can easily avoid it fully by returning an empty string instead.
Props sirlouen.
In branches/2.6, for 2.6.14.
Fixes #3616.
|
| [7329]
|
johnjamesjacoby
|
Theme Compat: remove reference to non-existent function.
This change removes a function call to `display_reply_index()` which does not exist, and replaces it with an empty string.
This condition will not fire under normal circumstances as the Reply post type does not support archives by default. The chances of this fatal error happening are near zero, but we can easily avoid it fully by returning an empty string instead.
Props sirlouen.
In trunk, for 2.7.
Fixes #3616.
|
| [6951]
|
johnjamesjacoby
|
Theme Compat: resolve a number of issues brought up after 2.6 was released.
This commit does the following:
* Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty
* Restores text-underline styling for topic & reply content for Twenty Seventeen
* Removes text-underline for revisions
* Fixes padding & margins on small screens across all themes
See #3281. For 2.6.1, branches/2.6.
|
| [6952]
|
johnjamesjacoby
|
Theme Compat: resolve a number of issues brought up after 2.6 was released.
This commit does the following:
* Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty
* Restores text-underline styling for topic & reply content for Twenty Seventeen
* Removes text-underline for revisions
* Fixes padding & margins on small screens across all themes
See #3281. For 2.7, trunk.
|
| [3634]
|
johnjamesjacoby
|
Theme Compatibility Updates:
* Tableless layout, fixes #1586, props mercime
* Introduce content-single-reply and content-topic-tag-edit templates
* Update shortcodes to use content templates
* Update theme compatibility to include single reply shortcode
* @todo CSS audit, RTL audit, shortcode audit
|
| [4975]
|
johnjamesjacoby
|
Theme Compatibility improvements:
* Introduce helper functions to set and check a located root template, to aid in turning off theme-compat.
* Introduce bbp_do_theme_compat() which checks if we're in the main loop, and the $post global has been primed with theme-compat dummy data.
* Use WP_Post in bbp_theme_compat_reset_post(), and clean up this function a bit.
* Set theme_compat active to false after bbp_replace_the_content() has started, to avoid recursing through nested 'the_content' filter usages.
* Refactor output buffering used in bbp_replace_the_content() to clean up shortcode usages.
* See #2343.
|
| [3985]
|
johnjamesjacoby
|
Theme Compatibility:
* Add feedback template part for when there are no replies in the specific view.
|
| [3943]
|
johnjamesjacoby
|
Theme Compatibility:
* Add support for plugin-bbpress.php and generic.php in the root template hierarchy.
* See: http://core.trac.wordpress.org/ticket/20509
|
| [3971]
|
johnjamesjacoby
|
Theme Compatibility:
* Allow root level templates to bypass the_content overriding if child/parent templates are found.
* Introduces two functions and new theme_compat functionality, that modifies bbp_get_query_template() to tell bbp_locate_template() to not override the_content.
* Reverts r3969.
* Fixes #1854 correctly.
|
| [3928]
|
johnjamesjacoby
|
Theme Compatibility:
* Clean up bbpress-functions.php for Twenty Ten and Default theme packages.
* Simplify bbp_register_theme_package() to accept an array or a BBP_Theme_Compat object.
* Update bbPress::register_theme_packages() to use new style above.
|
| [3942]
|
johnjamesjacoby
|
Theme Compatibility:
* Fix issues with 'the_content' and bbp_replace_the_content() causing infinite loops, duplicate filters, no filters, etc...
* Add 'the_content' adds/removes to BBP_Shortcode where needed.
* Remove unneeded calls to do_shortcode().
* Fixes #1844.
|
| [3924]
|
johnjamesjacoby
|
Theme Compatibility:
* Improvements to head script and RTL/LTR css enqueuing.
* Backwards compat for get_current_theme().
* Fixes #1832.
|
| [3927]
|
johnjamesjacoby
|
Theme Compatibility:
* Introduce bbp_is_theme_compat_original_template() and bbp_set_theme_compat_original_template() functions, to allow the template loader to properly use custom post type templates.
* Refactor BBP_Theme_Compat to use magic methods.
* Reorder bbp_template_include_theme_supports() to put _edit() checks before single/archive checks, to prevent them from being stomped.
* Clean up BBP_Theme_Compat usage to work with refactored approach.
* Fixes #1833.
|
| [3969]
|
johnjamesjacoby
|
Theme Compatibility:
* Invert bbp_is_theme_compat_original_template() check in bbp_template_include_theme_compat().
* Fixes issue with root template files being skipped over.
* Fixes #1854.
|
| [3983]
|
johnjamesjacoby
|
Theme Compatibility:
* Move root-level templates into an /extras folder in bbp-theme-compat.
* Revert extra logic introduced in r3971.
* Theme compat can still allow for theme packs with root template files this way.
* Replace reverted logic with 1 variable check, if a bbPress template file was found in the loader process.
* See: #1854
|
| [3923]
|
johnjamesjacoby
|
Theme Compatibility:
* Only run bbp_template_include_theme_compat() on main loop.
|
| [3984]
|
johnjamesjacoby
|
Theme Compatibility:
* Revert bbp_get_query_template() logic introduced in r3971.
* See: #1854.
|
| [3925]
|
johnjamesjacoby
|
Theme Compatibility:
* Skip extra enqueue_scripts logic for multiple _is_ checks.
* Clean up get_current_theme() check.
* See #1832.
|
| [3970]
|
johnjamesjacoby
|
Theme Compatibility:
* Uncomment post_author for forum edits in bbp_template_include_theme_compat().
|
| [3972]
|
johnjamesjacoby
|
Theme Compatibility:
* Update lead-topic footer text to match header text.
|
| [4762]
|
johnjamesjacoby
|
Theme Compatibility:
* When locating template files, filter 'bbp_get_template_stack' rather than 'bbp_get_template_part'
* Fixes bug where using bbp_locate_template() directly would result in missing subdirectory locations.
|
| [5950]
|
netweb
|
Theme Compatibility: Add support for `singular.php` in the root template hierarchy.
This changeset adds upport for the `singular.php` fallback template introduced in [WP22314]
Props mercime
Fixes #2868
|
| [7100]
|
johnjamesjacoby
|
Theme Compatibility: Avoid compatibility issues between MySQL versions.
This commit introduces a new function - `bbp_get_empty_datetime()` - which returns a valid, filterable, "empty" MySQL formatted datetime value.
This new function is used inside the theme compatibility API to ensure that global `WP_Post` datetime values are not "0" to better support MySQL 8 and higher, which is dropping support for `NO_ZERO_DATES`.
Props GDragoN.
In branches/2.6, for 2.6.6.
Fixes #3354.
|
| [7099]
|
johnjamesjacoby
|
Theme Compatibility: Avoid compatibility issues between MySQL versions.
This commit introduces a new function - `bbp_get_empty_datetime()` - which returns a valid, filterable, "empty" MySQL formatted datetime value.
This new function is used inside the theme compatibility API to ensure that global `WP_Post` datetime values are not "0" to better support MySQL 8 and higher, which is dropping support for `NO_ZERO_DATES`.
Props GDragoN.
In trunk, for 2.7.0.
See #3354.
|
| [7363]
|
johnjamesjacoby
|
Theme Compatibility: Make sure topic archive titles use the WordPress Page title, if one exists.
This commit modifies `bbp_template_include_theme_compat()` to use the existing `$new_title` variable logic instead of the hard-coded Topic Archive title, allowing for the Page title to take its place.
Props rollybueno.
In trunk, for 2.7.
Fixes #3604.
|
| [6112]
|
netweb
|
Theme Compatibility: Parameter `$in_footer` in `bbp_enqueue_script()` should be boolean.
This changeset updates copy-pasta introduced in [5181], `bbp_enqueue_script()` is a wrapper for `wp_enqueue_script()`, `$in_footer` boolean parameter introduced in wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior.
Props thebrandonallen.
Fixes #3013.
|
| [7176]
|
johnjamesjacoby
|
Theme Compatibility: improve handling of shortcodes in some template functions.
This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages.
In branches/2.6 for 2.6.7. Fixes #3358.
|
| [7175]
|
johnjamesjacoby
|
Theme Compatibility: improve handling of shortcodes in some template functions.
This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages.
In trunk for 2.7.0. See #3358.
|
| [3959]
|
johnjamesjacoby
|
Theme Compatilibilty:
* Add theme hierachy check for default bbPress styling.
* Use file_exists() checks in child & parent themes before enqueuing from theme compatibility.
* Fixes #1849.
|
| [3960]
|
johnjamesjacoby
|
Theme Compatilibilty:
* Use trailingslashit() in default styling enqueue.
* See #1849.
|
| [3178]
|
johnjamesjacoby
|
Theme compat CSS tweaks for forms, fieldsets, legends, labels, and inputs.
|
| [3281]
|
johnjamesjacoby
|
Theme compat adjustments for user profile edit fieldsets and labels.
|
| [2550]
|
johnjamesjacoby
|
Theme updates. Introduce template parts. Rename forum front template.
|
| [6578]
|
johnjamesjacoby
|
Theme: Put back vendor prefixes in default template pack styling.
|
| [4225]
|
johnjamesjacoby
|
Themes Compat:
* Move /bbp-theme-compat/ to /bbp-themes/bbp-default/
* Update paths and uri's.
|
| [4224]
|
johnjamesjacoby
|
Themes Compat:
* Move /bbp-theme-compat/ to /bbp-themes/bbp-default/
* Update paths and uri's.
|
| [4223]
|
johnjamesjacoby
|
Themes:
* Sunset bbPress (Twenty Ten) theme as included theme.
* Remove code associated with register theme directory.
* Still available in the official theme repository.
* See: http://wordpress.org/extend/themes/bbpress-twenty-ten/
|
| [5770]
|
johnjamesjacoby
|
Tidy up SVN properties.
* This first steps removes `svn:eol-style`, `svn:executable`, `svn:mime-type` on all files.
* The `svn:ignore` and `svn:global-ignores` properties have been tidied up to match WordPress core.
* A subsequent commit will re-instate `svn:mime-type` via `svn:auto-props`.
Hat-tip DJPaul. See #2802.
|
| [3776]
|
johnjamesjacoby
|
Tidy up the auto-embed options, and fix issue with setting not saving. Fixes #1752.
|
| [4682]
|
johnjamesjacoby
|
Tighten up whitespace on bulk user dropdown to better match WordPress core. Fixes #2145.
|
| [4513]
|
johnjamesjacoby
|
TinyMCE:
* Fix tabbing from topic title.
* Hat-tip MZAWeb.
* Fixes #1917.
|
| [4512]
|
johnjamesjacoby
|
TinyMCE:
* Revert textarea output variable, changed during excerpt() sweep.
|
| [4240]
|
johnjamesjacoby
|
TinyMCE:
* Use teeny-weeny editor to prevent extra buttons from appearing.
* Fixes #1870.
* Props jaredatch.
|
| [6881]
|
johnjamesjacoby
|
Titles: add comment about `8bit` mode usage of `mb_strlen()` to provide extra context.
(After looking at this again, I wasn't confident it was correct. It seems to be, given how it's being used.)
See #3189.
|
| [6784]
|
johnjamesjacoby
|
Titles: error if forum/topic/reply title is too long.
This change introduces `bbp_is_title_too_long()` and adds error messages to related forms if titles are too long.
Fixes #3189.
|
| [2537]
|
mdawaffe
|
To prevent meta duplication from race conditions, replication lag, etc.,
support sites that that choose to add a UNIQUE key to their meta table.
We still need to support sites with the default keys, so
don't get rid of the current if ( get ) { update } else { insert }
just replace it with if ( get ) { update } else { insert on duplicate key update }
|
| [7352]
|
johnjamesjacoby
|
Tools - Build: Clean-up PHPCS, and enforce Yoda conditionals.
This commit includes changes to various PHP files, Composer requirements, and PHPCS config, to confirm that the `WordPress.PHP.YodaConditions` code sniff passes.
Props sirlouen.
In trunk, for 2.7.
Fixes #3613.
|
| [6351]
|
netweb
|
Tools - Build: Disable Xdebug on stable builds of PHP when testing on Travis CI.
Hat tip johnbillion.
Fixes #3075.
|
| [7355]
|
johnjamesjacoby
|
Tools - Build: Ignore `.phpunit.result.cache`
In trunk, for 2.7.
See r7353.
|
| [7354]
|
johnjamesjacoby
|
Tools - Build: Update package-lock.json.
In trunk, for 2.7.
See r7353. Fixes #3610.
|
| [7353]
|
johnjamesjacoby
|
Tools - Build: Upgrade Composer, npm, and add wp-env for PHPUnit.
This commit modernizes the dev environment, bringing it up-to-speed with BuddyPress and others.
Props sirlouen.
In trunk, for 2.7.
Fixes #3610.
|
| [7357]
|
johnjamesjacoby
|
Tools - Code Improvement:
This commit modifies several PHP files to strictly adhere to the following PHPCS rules:
* WordPress.WP.I18n.NonSingularStringLiteralText
* WordPress.WP.PostsPerPage.posts_per_page_posts_per_page
* WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceAfterOpenParenthesis
* WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceBeforeCloseParenthesis
* WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterOpenParenthesis
* WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeCloseParenthesis
* WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter
* WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore
* WordPress.WhiteSpace.OperatorSpacing.SpacingAfter
* WordPress.WhiteSpace.OperatorSpacing.SpacingBefore
This commit does not include changes to the phpcs.xml.dist config file to add these rules yet - this will happen in a separate commit.
Props sirlouen.
In trunk, for 2.7.
See #3614.
|
| [7361]
|
johnjamesjacoby
|
Tools - Code Improvement: Document some filters.
This commit improves the code documentation of several filters across the codebase.
Props johnjamesjacoby, narenin, sirlouen.
In trunk, for 2.7.
See #3110.
|
| [7358]
|
johnjamesjacoby
|
Tools - Code Improvement: Updates to the `phpcs.xml.dist` config file.
Props sirlouen.
In trunk, for 2.7.
See #3614.
|
| [7360]
|
johnjamesjacoby
|
Tools - Code Improvement: Updates to the `phpcs.xml.dist` config file.
This commit implements the `WordPress.WP.I18n.MissingTranslatorsComment` code sniff, fixes a bunch of whitespace regressions from #3614 and #3613.
Props johnjamesjacoby, sirlouen.
In trunk, for 2.7.
Fixes #3615.
|
| [7359]
|
johnjamesjacoby
|
Tools - Code Improvement: Updates to the `phpcs.xml.dist` config file.
This commit reverts r7358, includes a few new exclusions, and ensures PHPCS has fully passes.
Props johnjamesjacoby, sirlouen.
In trunk, for 2.7.
Fixes #3614.
|
| [7371]
|
johnjamesjacoby
|
Tools - Code Improvement: bump PHP & WP versions.
This change bumps the requirements for WordPress to 6.0 and PHP to 7.2, including inside of the PHPCS matrix.
|
| [7380]
|
johnjamesjacoby
|
Tools - Code Improvement: docs & code formatting improvements.
Props johnjamesjacoby, noruzzaman.
Fixes #3659.
|
| [7372]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed` sniff.
This change replaces inline tabs with spaces from a bunch of files where they have crept in over the years.
|
| [7373]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `Universal.WhiteSpace.PrecisionAlignment.Found` sniff.
This change removes any precision alignment that used spaces instead of tabs.
|
| [7374]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine` sniff.
This commit ensures that all arrays with multiple keys & values are not on single lines.
|
| [7376]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring more PHPCS sniffs.
* Universal.WhiteSpace.CommaSpacing.TooMuchSpaceAfter
* WordPress.Arrays.ArrayIndentation.ItemNotAligned
* WordPress.Arrays.ArrayIndentation.MultiLineArrayItemNotAligned
* WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys
* WordPress.Arrays.ArrayKeySpacingRestrictions.SpacesAroundArrayKeys
* WordPress.Arrays.MultipleStatementAlignment.MultilineItemSpaceBeforeDoubleArrow
* WordPress.Arrays.MultipleStatementAlignment.SpaceBeforeDoubleArrow
This commit includes code formatting changes to pass the above PHPCS checks.
See #3658.
|
| [7377]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring more PHPCS sniffs.
* WordPress.WP.AlternativeFunctions.rand_mt_rand
This commit prefers `wp_rand()` over `mt_rand()` in the Akismet extension.
See #3658.
|
| [7375]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring some MySQL prepare sniffs.
This commit ensures that all SQL is correctly prepared, and that specific queries are tagged to be ignored by PHPCS due to them not using the literal `$wpdb` global as required by the sniffs.
See #3658.
|
| [7378]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring these PHPCS sniffs:
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
* Generic.CodeAnalysis.EmptyStatement.DetectedElseif
* Generic.CodeAnalysis.EmptyStatement.DetectedIf
* Generic.CodeAnalysis.UselessOverridingMethod.Found
* Generic.ControlStructures.InlineControlStructure.NotAllowed
* Generic.Files.LineEndings.InvalidEOLChar
* Generic.Formatting.DisallowMultipleStatements.SameLine
* Generic.Formatting.SpaceAfterCast.TooMuchSpace
* Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace
* Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerMultiLine
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
* NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLineCloserSameLine
* PEAR.Functions.FunctionCallSignature.CloseBracketLine
* PEAR.Functions.FunctionCallSignature.EmptyLine
* PEAR.Functions.FunctionCallSignature.Indent
* PEAR.Functions.FunctionCallSignature.MultipleArguments
* PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
* PHPCompatibility.Syntax.RemovedCurlyBraceArrayAccess.Found
* PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
* PSR2.Classes.PropertyDeclaration.ScopeMissing
* PSR2.Classes.PropertyDeclaration.Underscore
* PSR2.Classes.PropertyDeclaration.VarUsed
* PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
* PSR2.ControlStructures.SwitchDeclaration.BreakIndent
* PSR2.Methods.MethodDeclaration.Underscore
* Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace
* Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterOpen
* Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose
* Squiz.Functions.MultiLineFunctionDeclaration.ContentAfterBrace
* Squiz.PHP.DisallowSizeFunctionsInLoops.Found
* Squiz.Scope.MethodScope.Missing
* Squiz.WhiteSpace.SuperfluousWhitespace.EndLine
* Universal.NamingConventions.NoReservedKeywordParameterNames.arrayFound
* Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
* Universal.NamingConventions.NoReservedKeywordParameterNames.parentFound
* Universal.Operators.DisallowStandalonePostIncrementDecrement.PostDecrementFound
* Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
* Universal.Operators.StrictComparisons.LooseEqual
* Universal.Operators.StrictComparisons.LooseNotEqual
* WordPress.Arrays.ArrayKeySpacingRestrictions.TooMuchSpaceAfterKey
* WordPress.DateTime.CurrentTimeTimestamp.Requested
* WordPress.DateTime.RestrictedFunctions.date_date
* WordPress.Files.FileName.NotHyphenatedLowercase
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
* WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
* WordPress.PHP.IniSet.Risky
* WordPress.PHP.PregQuoteDelimiter.Missing
* WordPress.PHP.StrictInArray.MissingTrueStrict
* WordPress.WP.AlternativeFunctions.parse_url_parse_url
* WordPress.WP.AlternativeFunctions.rand_mt_rand
* WordPress.WP.AlternativeFunctions.strip_tags_strip_tag
* WordPress.WP.AlternativeFunctions.strip_tags_strip_tags
* WordPress.WP.Capabilities.Unknown
* WordPress.WP.DeprecatedParameters.Get_termsParam2Found
* WordPress.WP.DeprecatedParameters.Wp_count_termsParam2Found
* WordPress.WP.DiscouragedFunctions.query_posts_query_posts
* WordPress.WP.DiscouragedFunctions.wp_reset_query_wp_reset_query
* WordPress.WP.EnqueuedResourceParameters.NotInFooter
* WordPress.WP.GlobalVariablesOverride.Prohibited
* WordPress.WP.I18n.LowLevelTranslationFunction
This commit includes code formatting changes for the above sniffs.
See #3658.
|
| [7379]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring these PHPCS sniffs:
* PEAR.Files.IncludingFile.UseRequire
* PSR2.ControlStructures.SwitchDeclaration.BodyOnNextLineDEFAULT
* PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
* Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
* Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
* Squiz.PHP.EmbeddedPhp.MultipleStatements
* Squiz.PHP.NonExecutableCode.Unreachable
* Universal.Arrays.DuplicateArrayKey.Found
* Universal.ControlStructures.DisallowLonelyIf.Found
* WordPress.PHP.NoSilencedErrors.Discouraged
This commit includes code formatting changes for the above sniffs.
See #3658.
|
| [7381]
|
johnjamesjacoby
|
Tools - Code Improvement: un-indent last remaining `_get_` functions.
|
| [7365]
|
johnjamesjacoby
|
Tools - Unit Tests: Fix some failing tests.
This commit tweaks the expected values of some tests so that they pass as intended, mostly surrounding int/string type numerics and total/single counts.
|
| [6060]
|
netweb
|
Tools - Unit Tests: Use `get_sites()` for muiltisite PHPUnit testcase in `BBP_UnitTestCase::tearDown`
WordPress 4.6 deprecated `wp_get_sites()`, switch to the replacement `get_sites()` via #WP36994 / [wp:changeset:37653]
Fixes #2962.
|
| [7368]
|
johnjamesjacoby
|
Tools - Unit Tests: allow mentions after '[' and '(' chars.
This commit fixes the suite of user-mentions unit tests, so that they no longer require an empty "class" attribute, and also so that mentions inside of common wrappers (`()`, `[]` ) are allowed.
See #3657.
|
| [7367]
|
johnjamesjacoby
|
Tools - Unit Tests: plan for `seems_utf8()` to be deprecated.
This commit updates 3 author-link unit tests to avoid WordPress Deprecation notices.
See #3657.
|
| [7366]
|
johnjamesjacoby
|
Tools - Unit Tests: prevent double-spaces in span attributes.
This commit prevents the `<span>` that wraps author link parts from having 2 spaces immediately after the opening tag.
|
| [7369]
|
johnjamesjacoby
|
Tools - Unit Tests: update `bbp_get_forum_permalink()` to better support hierarchical URIs.
This commit ensures that the `test_bbp_get_forum_permalink()` test passes, and that hierarchical Forum post-type links are correctly formatted when using unpretty/plain permalinks.
See #3657.
|
| [7370]
|
johnjamesjacoby
|
Tools - Unit Tests: update `test_bbp_spam_topic()` with more accurate before/after tests.
This commit ensures that the `test_bbp_spam_topic()` tests pass, and that the various counts, and last IDs and times before & after spamming a topic, are operating as intended.
See #3657.
|
| [7334]
|
johnjamesjacoby
|
Tools - Warnings/Notices: begin phasing out of `utf8_encode()` for PHP 8.2 and higher.
This change moves the existing `utf8_encode()` usages into a new common formatting function: `bbp_format_user_display_name()`, and uses this new function to abstract & encapsulate checking that mbstring equivalents are loaded & supported.
Props philipjohn.
In branches/2.6, for 2.6.14.
Fixes #3585.
|
| [7335]
|
johnjamesjacoby
|
Tools - Warnings/Notices: begin phasing out of `utf8_encode()` for PHP 8.2 and higher.
This change moves the existing `utf8_encode()` usages into a new common formatting function: `bbp_format_user_display_name()`, and uses this new function to abstract & encapsulate checking that mbstring equivalents are loaded & supported.
Props philipjohn.
In trunk, for 2.7.
Fixes #3585.
|
| [6909]
|
johnjamesjacoby
|
Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`.
This commit allows the freshness repair tool to correctly query for the maximum topic ID.
Fixes #3261.
Props GDragoN.
For 2.5.x.
|
| [6908]
|
johnjamesjacoby
|
Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`.
This commit allows the freshness repair tool to correctly query for the maximum topic ID.
Fixes #3261.
Props GDragoN.
For 2.6 (trunk.)
|
| [6906]
|
johnjamesjacoby
|
Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`.
This commit allows the favorites repair tool to correctly query for chunked results.
Fixes #3259.
Props GDragoN.
For 2.5.x.
|
| [6905]
|
johnjamesjacoby
|
Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`.
This commit allows the favorites repair tool to correctly query for chunked results.
See #3259.
Props GDragoN.
For 2.6/trunk.
|
| [7263]
|
johnjamesjacoby
|
Tools/Repair: audit post statuses in repair queries.
This change ensures that all of the relevant repair tools are including the expected public post statuses for their related post types.
These changes specifically address possibly missing Closed Topics in the repair tools, while also ensuring that anything filtering the results of the `_public_statuses()` functions to add their own custom statuses (I.E. archives on WordPress.org) are taken into consideration.
Fixes #3591.
Props GDragoN.
In branches/2.6, for 2.6.10.
|
| [4452]
|
johnjamesjacoby
|
Tools/Roles:
* In user-map repair tool, use default role if role-map entry does not exist.
* See #2042 (2.2 branch)
|
| [4451]
|
johnjamesjacoby
|
Tools/Roles:
* In user-map repair tool, use default role if role-map entry does not exist.
* See #2042 (trunk)
|
| [4344]
|
johnjamesjacoby
|
Tools:
* Break bbp_admin_repair_user_roles() loop into 1000 user chunks.
* Fixes issue where we were querying and returning too many rows at a time.
|
| [4343]
|
johnjamesjacoby
|
Tools:
* Cleanup repeat variable assignments.
* Unset variables in costly loops to free up some resources.
* Remove one-time-use variables.
|
| [4345]
|
johnjamesjacoby
|
Tools:
* Remove empty( $users ) check in bbp_admin_repair_user_roles().
* Handled by while() loop.
* Tweak inline doc in bbp_admin_repair_user_roles().
|
| [6438]
|
johnjamesjacoby
|
Tools: Add `//Filter & return` note for future discovery of missing filter documentation.
Also adjust some type-casting on filtered results.
|
| [5892]
|
johnjamesjacoby
|
Tools: Add `id` attribute to "Run" link. Props tharsheblows. See #2841.
|
| [6193]
|
netweb
|
Tools: Add an upgrade tool for forum subscriptions.
* Adds `bbp_admin_upgrade_user_forum_subscriptions()`
* Renames `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()`
* Updated inline docs
Previously in r6174 upgrade tools were added for favorites and subscriptions, support for migrating forums subscriptions meta `_bbp_forum_subscriptions` wasn't included, rather than adding extra overhead to the existing topic subscriptions upgrade tool another upgrade tool was added for forum subscriptions.
See #2959.
|
| [6173]
|
johnjamesjacoby
|
Tools: Add classes & data attributes to improve responsiveness.
|
| [6275]
|
johnjamesjacoby
|
Tools: Add phpdoc for `bbp_get_admin_repair_tool_registered_components()`.
|
| [5964]
|
netweb
|
Tools: Add the `grunt-check-dependencies` npm module.
This changeset adds the Grunt task `checkDependencies` via https://www.npmjs.com/package/grunt-check-dependencies to check the currently npm installed modules against the required modules semantic version listed in `package.json`, if the check fails a prompt to update installed npm modules is displayed and is required before other Grunt tasks can be run.
Run `npm install` after updating your repo to install the module and task.
Props netweb.
Fixes #2893.
|
| [6256]
|
johnjamesjacoby
|
Tools: Add tool to recount topics in each topic-tag.
* Add callback function for the recount itself
* Add translation for component list
* Update a few tool titles to better represent what they do
* Update tool-orders to fit new tool in the middle
See #3043.
|
| [6523]
|
johnjamesjacoby
|
Tools: Audit repair & upgrade tools.
* Use escaped gettext variant functions where applicable
* Use Query/Prepared/Results paradigm for direct database queries for easier step-through debugging
* Fix a few small bugs in the engagements upgrade functions (none that affect 2.5 or beta/RC users)
* General code formatting improvements and typo fixes
|
| [6188]
|
johnjamesjacoby
|
Tools: Avoid duplicate entries for favorites & subscriptions.
This fixes a bug in the 2.6.0 upgrade routine where running the tool multiple times could add duplicate metadata.
See #2959.
|