| [6275]
|
johnjamesjacoby
|
Tools: Add phpdoc for `bbp_get_admin_repair_tool_registered_components()`.
|
| [5964]
|
netweb
|
Tools: Add the `grunt-check-dependencies` npm module.
This changeset adds the Grunt task `checkDependencies` via https://www.npmjs.com/package/grunt-check-dependencies to check the currently npm installed modules against the required modules semantic version listed in `package.json`, if the check fails a prompt to update installed npm modules is displayed and is required before other Grunt tasks can be run.
Run `npm install` after updating your repo to install the module and task.
Props netweb.
Fixes #2893.
|
| [6256]
|
johnjamesjacoby
|
Tools: Add tool to recount topics in each topic-tag.
* Add callback function for the recount itself
* Add translation for component list
* Update a few tool titles to better represent what they do
* Update tool-orders to fit new tool in the middle
See #3043.
|
| [6523]
|
johnjamesjacoby
|
Tools: Audit repair & upgrade tools.
* Use escaped gettext variant functions where applicable
* Use Query/Prepared/Results paradigm for direct database queries for easier step-through debugging
* Fix a few small bugs in the engagements upgrade functions (none that affect 2.5 or beta/RC users)
* General code formatting improvements and typo fixes
|
| [6188]
|
johnjamesjacoby
|
Tools: Avoid duplicate entries for favorites & subscriptions.
This fixes a bug in the 2.6.0 upgrade routine where running the tool multiple times could add duplicate metadata.
See #2959.
|
| [6282]
|
johnjamesjacoby
|
Tools: Break `tools.php` up into separate files. See #3052.
|
| [6496]
|
johnjamesjacoby
|
Tools: Change BuddyPress group forum repair into an upgrade routine.
This is only intended as a migration path from bbPress 1.x to 2.x, not to be rerun multiple times to force-recount the meta values & private/hidden options.
See #2829.
|
| [6257]
|
johnjamesjacoby
|
Tools: Correct revision for topic-tag recount tool. See #3043.
|
| [6977]
|
netweb
|
Tools: Correct string in repair topic reply count tool.
Props felipeloureirosantos.
See #3288. For 2.6.2, branches/2.6.
|
| [6976]
|
netweb
|
Tools: Correct string in repair topic reply count tool.
Props felipeloureirosantos.
See #3288. For 2.7, trunk.
in bbp_admin_repair_topic_reply_count
|
| [6182]
|
johnjamesjacoby
|
Tools: Explicitly pass `false` into `add_post_meta()`'s `$unique` parameter.
Though it's the default, we can't make any mistake that meta-key's to be non-unique for this to function correctly.
See #2959.
|
| [6174]
|
johnjamesjacoby
|
Tools: First pass at upgrade tools for favorites & subscriptions.
* Registers 2 new repair tools
* Includes basic looping patterns for user-meta to post-meta
Needs testing and scrutiny.
See #2959.
|
| [6135]
|
johnjamesjacoby
|
Tools: Fix undeclared variables and incorrect variable types, for improved PHP 7.1 compatibility.
This will quiet down most of our continuous integration noise.
Props hellofromTonya. Fixes #3031.
|
| [5783]
|
netweb
|
Tools: Forums should not include forum meta key `_bbp_forum_id`, forums with this meta key were due to either:
1) Incorrectly added by the `bbp_admin_repair_forum_meta()` repair tool
2) Incorrectly added by an old version of one of the included bbPress importers, these were fixed in r5526
Props netweb. Fixes #2669
|
| [6537]
|
johnjamesjacoby
|
Tools: Improvements to repair, upgrade, and converter tools.
* Use escaped gettext equivalent functions where appropriate
* Rename `description` to `title` so that more descriptive descriptions can be used per-tool in a future version
* Register all scripts, and properly enqueue them only a needed
* Reorder & re-title some tools to better match each other
|
| [5960]
|
netweb
|
Tools: Include `forum-mod` taxonomy code in `bbp_admin_reset_handler()`
This changeset adds support for deleting the forum moderator taxonomy when running the bbPress "Reset Forums" tool.
Props netweb.
Fixes #2898.
|
| [5916]
|
netweb
|
Tools: Include pending replies in the count when running the "Count pending, spammed, & trashed replies in each topic" repair tool
This changeset ensures that pending replies are included in the topic meta `_bbp_reply_count_hidden` count after running the repair tool `bbp_admin_repair_topic_hidden_reply_count()`, includes unit tests.
Props netweb. Fixes #2849
|
| [5668]
|
netweb
|
Tools: Introduce "Repair closed topics tool" `bbp_admin_repair_closed_topics()`
See #2653
|
| [6481]
|
johnjamesjacoby
|
Tools: Introduce `bbp_get_unique_array_values()` helper function.
Use this when parsing private/hidden forum IDs for saving.
|
| [6279]
|
johnjamesjacoby
|
Tools: Introduce new "Upgrade Forums" tools section.
* Uses some awesome trickery to reuse as much of the "Repair Forums" API as possible
* Introduces a few new functions to handle the output of the new screen
* Removes hard-coded referencs to `bbp-repair` page, to allow usage on any relevant page (including new `bbp-upgrade`)
* Makes components & overhead lists smarter, and only includes items relevant to the current view
Fixes #3052.
|
| [6925]
|
johnjamesjacoby
|
Tools: Make a few columns sortable.
This commit adds a small UX improvement to the Repair and Upgrade tools pages, allowing for these lengthy lists to be sorted.
See #3244.
|
| [6280]
|
johnjamesjacoby
|
Tools: Map `bbp_tools_upgrade_page` capability to minimum admin capability. See #3052.
|
| [6176]
|
johnjamesjacoby
|
Tools: Massize clean-up
* Add missing function documentation blocks
* Rename `_migrate_` function to `_upgrade_`
* More typo fixes
* Make `overhead` values clickable in list table rows
* Refactor `overhead` to work more like `components`, using keys instead of literal strings
See #2959.
|
| [6283]
|
johnjamesjacoby
|
Tools: Move tools tab functions into `tools.php`.
|
| [6215]
|
johnjamesjacoby
|
Tools: Order fav/sub upgrade by `user_id`.
This makes it easier to `LIMIT` later if you need to manually chunk this. See #2959.
|
| [5911]
|
netweb
|
Tools: RTL CSS generation: Switch from CSSJanus to RTLCSS
* If you have used `grunt cssjanus` before, use `grunt rtlcss` now.
* Requires `npm install` to update dependancies
Props netweb. Fixes #2848, see #WP31332 and wp:changeset:31573
|
| [5912]
|
netweb
|
Tools: Remove banners added to minified CSS files and simplified JS banner
This changeset removes the banners that were previously added to minified CSS files as `grunt-contrib-cssmin` deprecated this in v0.11.0.
The banner added to minified JS files has also been simplified by removing the time/date so that unnecessarily merges/updates do not trigger unneeded changes when using version control. The banner added to minified JS files is now static without the date/time, this fixes an issue where the minified file would always change because of the compiled date/time even when there were no code changes, this was causing unneeded changes when merging/updating when using version control external to bbPress.
Props netweb. Fixes #2738
|
| [6715]
|
johnjamesjacoby
|
Tools: Remove quotes from prepared query statements.
Also use the same `esc_like()` result in 2 matched queries.
Props jrf. Fixes #3168.
|
| [6277]
|
johnjamesjacoby
|
Tools: Rename page functions with `_page()` suffix.
Previous function names were more ambiguous than intended, and because these functions are only called internally, there is no harm in renaming them.
|
| [6002]
|
netweb
|
Tools: Return unique message strings in `bbp_admin_reset_handler()` when deleting imported users and user meta vs non-imported user meta.
Fixes #2928.
|
| [6091]
|
netweb
|
Tools: Running the "Reset Forums" tool now deletes bbPress' custom post type revisions from the database.
This changeset adds support for deleting forum, topic, and reply post types revisions to `bbp_admin_reset_handler()`.
Fixes #2945.
|
| [6281]
|
johnjamesjacoby
|
Tools: Separate `wp_usermeta` clean-up from database upgrade routines.
Clean-up should be run after upgrades, not during. This way all results can be verified by the admin.
See #3052.
|
| [6005]
|
netweb
|
Tools: Travis CI The Matrix Reloaded
'''The Architect''': ''The first matrix I designed was quite naturally perfect. It was a work of art. Flawless. Sublime. A triumph only equaled by its monumental failure.''
|
| [5959]
|
netweb
|
Tools: Travis CI: Only test PHP 7 against WordPress 4.3 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7 compatability, which was only added in version 4.3 so lets not let those errors in versions before 4.3 bother us ;)
See #2895.
|
| [5958]
|
netweb
|
Tools: Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds
PHP 7 was released today, congratulations to everyone involved in the release :)
Props netweb.
Fixes #2895.
|
| [6274]
|
johnjamesjacoby
|
Tools: Unify the tab/link experience:
* Introduce function to get tools pages
* Trust capability checks in core WordPress functions, and remove our own bespoke pre-checks
* Add tool-box to `wp-admin/tools.php` linking to tools the user has access to
This change promotes exposure to bbPress's tools pages, and makes adding third-party tools pages easier.
See: #2959.
|
| [5885]
|
johnjamesjacoby
|
Tools: Update "Repair Tools" to use a list-table UI:
* Includes helper functions for: search, filtering, and bulk actions
* Improves tool registration by including strings and feedback into an array stored in `bbpress()->admin->tools`
* Introduces "Overhead" property for alerting Key Masters to the performance impact running each tool
* Introduces "Components" properties for identifying which counts what tools are intersecting
* Todo: use a `WP_List_Table` subclass (which bbPress has avoided needing until now)
See #2841.
|
| [6796]
|
johnjamesjacoby
|
Tools: Update Editor Configuration.
This change removes some file-types and stops trimming whitespace from markdown files.
Fixes #3197. Props netweb.
|
| [6473]
|
johnjamesjacoby
|
Tools: Update `Gruntfile.js` with new admin assets directory.
|
| [5913]
|
netweb
|
Tools: Update `grunt-contrib-cssmin` to v0.13.0
Changelog: https://github.com/gruntjs/grunt-contrib-cssmin/compare/v0.11.0...v0.13.0
Testing `grunt cssmin` and related bbPress Grunt tasks show no issues with `grunt-contrib-cssmin`
Note: Requires `npm install` to update dependencies
See #2738
|
| [6286]
|
johnjamesjacoby
|
Tools: Update file paths for tools unit tests.
Props thebrandonallen. Fixes #3056.
|
| [6178]
|
johnjamesjacoby
|
Tools: Update forum/topic/reply admin classes to avoid screens without `post_type` parameters.
Fixes edge-case debug notices when tools pages for third-party plugins are doing advanced things.
See #2959.
|
| [6278]
|
johnjamesjacoby
|
Tools: Update some reset text in `bbp_admin_reset_page()`.
|
| [5963]
|
netweb
|
Tools: Update the `priority` array values of individual repair tools in `bbp_register_default_repair_tools()`
This changeset fixes an issue where the `bbp_admin_repair_topic_meta()` repair tool was not included in the list table.
Props netweb, thebrandonallen.
Fixes #2859.
|
| [6177]
|
johnjamesjacoby
|
Tools: Update tools text to include favorites & subscriptions.
See #2959.
|
| [6175]
|
johnjamesjacoby
|
Tools: Use `$total` count in `bbp_admin_migrate_user_favorites()`.
Also update revision number in function docs.
See #2959.
|
| [5899]
|
johnjamesjacoby
|
Tools: Use `_admin_search_query()`. See #2841.
|
| [6593]
|
johnjamesjacoby
|
Tools: Use `delete_metadata()` to remove favs & subs without a `foreach` loop.
|
| [6181]
|
johnjamesjacoby
|
Tools: Use `explode()` instead of `maybe_unserialize()`.
User-meta values were strings to enable `FIND_IN_SET()` usages.
See #2959.
|
| [6189]
|
johnjamesjacoby
|
Tools: Use `get_results()`, and don't delete usermeta.
(Maybe we should have a separate clean-up tool once it's confirmed to be OK.)
See #2959.
|
| [6513]
|
johnjamesjacoby
|
Tools: Use escaping gettext functions in admin area Reset Tool.
|
| [6276]
|
johnjamesjacoby
|
Tools: Use new `bbp_get_tools_admin_pages()` function when removing mock admin-pages.
Fixes bug where third-party tools pages would not get removed.
|
| [5988]
|
netweb
|
Tools: Use updated meta key `_bbp_old_user_id` to determine imported users in `bbp_admin_reset_handler()`
This changeset updates the meta key used to determine an imported user for handling the deletion of imported users in the reset forums tool, this should have originally been included in r5530 but was missed.
See #2650
|
| [6393]
|
johnjamesjacoby
|
Tools: User `and` over `&` for easier translation.
Props casiepa. Fixes #3096.
|
| [6664]
|
johnjamesjacoby
|
Tools: add optional `description` text to upgrade & repair tools.
This change hopefully adds some real-world context to otherwise mysterious functionality, in an attempt to better explain why any specific routine should be run vs. any others.
Trunk, for 2.6. See #3149.
|
| [6934]
|
johnjamesjacoby
|
Tools: allow repairs to also be pending.
This commit makes Repairs work like Upgrades, allowing for repair tools to also be pending. It adds a $type parameter to a few functions to allow grouping or separating, depending on the count context.
See #3052.
|
| [7216]
|
johnjamesjacoby
|
Tools: bring .gitignore up to speed.
This change merges similar ignore patterns from BuddyPress and WordPress.
|
| [6851]
|
johnjamesjacoby
|
Tools: bump package-lock.json.
|
| [6668]
|
johnjamesjacoby
|
Tools: include users with "unexpected" roles in `bbp_admin_repair_user_roles()`
This change makes sure that if a user has an unexpectedly missing or predictably broken role entry, they are still mapped to the `$default_role` for the current site, and fixes a problem with the role repair tool where users with the most broken roles were still never actually repaired.
Trunk, for 2.6.
|
| [6935]
|
johnjamesjacoby
|
Tools: reduce the number of calls to `bbp_is_large_install()`.
This commit refactors the update code to only call `bbp_is_large_install()` once, a function which ironically enough is costly to call on very large installations, so calling it 3 times defeats the purpose, but calling it one time is the minimum requirement to defer upgrades & repairs for keymaster interaction.
See #3052.
|
| [6882]
|
johnjamesjacoby
|
Tools: update npm package dependencies.
|
| [7283]
|
johnjamesjacoby
|
Tools: update npm packages for Grunt tasks.
This change:
* swaps in `terser` & `@wordpress/stylelint-config`
* updates stylelint to 15.11.0 (with `scss` support)
* adds separate stylelint config files for both CSS and SCSS (and deletes the original auto-loaded `.stylelintrc` file)
This is just enough to get Grunt unclogged and working again without complaining too much.
----
To make this work:
* Recommend to install NVM to make using npm 18 easier
* `nvm use 18`
* `npm install --legacy-peer-deps --save-dev`
Once complete, the various `grunt` CLI commands should work again without any problems (for now!)
|
| [6927]
|
johnjamesjacoby
|
Tools: wrap routine descriptions in a description paragraph tag.
This commit ensures that the descriptive text used to highlight what a specific tool does does not blend in with the title above it.
Fixes #3277. Props JarretC.
|
| [4114]
|
johnjamesjacoby
|
Topic Actions:
* Remove bbp_has_replies() from topic trash and topic delete functions.
* Use WP_Query's instead.
* Fixes #1913.
* For 2.1 branch.
|
| [4115]
|
johnjamesjacoby
|
Topic Actions:
* Remove bbp_has_replies() from topic trash and topic delete functions.
* Use WP_Query's instead.
* Fixes #1913.
* For 2.2 branch.
|
| [4116]
|
johnjamesjacoby
|
Topic Actions:
* Remove old bbpress() call in bbp_trash_topic() from r4114.
* See #1913.
* For 2.1 branch.
|
| [4084]
|
johnjamesjacoby
|
Topic Forms:
* Fix topic textarea label in theme-compat and twenty-ten.
* For 2.1.1
|
| [4362]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic off into an existing topic, use the same kludge from topic-merge, and rejig the post_date by 1 second.
* This keeps topics and replies in the correct order after splitting part of a topic, into another topic.
* Props jmdodd.
* Fixes #2015.
|
| [4096]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, calculate new reply positions.
* Set last active ID to last reply ID.
* Update last reply and active ID/time of source topic.
* Fixes #1898.
* For 2.1 branch.
|
| [4097]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, calculate new reply positions.
* Set last active ID to last reply ID.
* Update last reply and active ID/time of source topic.
* Fixes #1898.
* For 2.2 branch.
|
| [4103]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, make sure the new topic has menu_position 1.
|
| [4460]
|
johnjamesjacoby
|
Topic Suggest:
* Only output topic suggest JS if on reply new/edit page.
* Fixes #1990 (2.2 branch)
|
| [4461]
|
johnjamesjacoby
|
Topic Suggest:
* Only output topic suggest JS if on reply new/edit page.
* Fixes #1990 (trunk)
|
| [4217]
|
johnjamesjacoby
|
Topic Tags:
* Change shortcode ID for single topic tags.
* Update topic tag theme compat code to ensure topic-tag edit form works where needed.
|
| [4098]
|
johnjamesjacoby
|
Topic Tags:
* First pass to allow topic tags to be globally disabled.
* Handles toggling the UI in template parts and admin area.
* Props jaredatch.
* Fixes #1806.
|
| [4099]
|
johnjamesjacoby
|
Topic Tags:
* Use correct setting key in settings field registration array.
* See #1806.
|
| [4166]
|
johnjamesjacoby
|
Topic Tags:
* When posting a topic or reply, check that user can assign tags to topics.
* If user cannot assign tags, and topic-tag value is not set, use existing topic tags.
|
| [6720]
|
johnjamesjacoby
|
Topic Tags: Check for post ID when checking `assign_topic_tags`.
This change adds a fallback value for the standard `assign_terms` capability check, and fixes a few test errors introduced in r6714.
|
| [6254]
|
johnjamesjacoby
|
Topic Tags: Introduce `bbp_update_topic_tag_count()` and include public/closed statuses in counts.
Fixes #3043.
|
| [6450]
|
johnjamesjacoby
|
Topic Tags: When deleting a topic tag, redirect to the forum root.
`home_url()` was a bit too jarring; no one expects to get kicked out of the forums entirely.
|
| [6884]
|
johnjamesjacoby
|
Topic Tags: remove extraneous `span` tag from topic-tag titles when theme-compat is employed.
This change removes a `span` tag that was originally required before support for topic-tag-edit templates was added.
Props mechter. Fixes #3236.
|
| [6453]
|
johnjamesjacoby
|
Topic Tags: set `is_archive` to `true` when viewing a topic tag archive.
Fixes #3071.
|
| [3950]
|
johnjamesjacoby
|
Topic Views:
* Prevent possible byref object errors in bbp_register_view().
|
| [7211]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In branches/2.6, for 2.6.7.
See #3438.
|
| [7212]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In trunk, for 2.7.
Fixes #3438.
|
| [6930]
|
johnjamesjacoby
|
Topic Views: pass view ID into body class.
This commit does a quick audit of Topic View API functions, and ensures their return values are as documented. This allows for safely adding the Topic View ID as a class to the body element of the page when viewing a single Topic View.
Fixes #3278. Props Clorith.
|
| [4255]
|
johnjamesjacoby
|
Topic and Reply Editing:
* Fix issue with "Edit" admin links having 'view=all' argument incorrectly positioned.
* Fix issue with post_status being set back to public when editing.
* Conditionally set post_status to pending if needs moderation.
* Fixes #1977.
|
| [4124]
|
johnjamesjacoby
|
Topic and Reply Widgets:
* Add 'show_user' option, to toggle display of user and Avatar.
* Update reply widget to use time_since.
* Fixes #1903.
* Props jaredatch.
|
| [4970]
|
johnjamesjacoby
|
Topic and reply admin links don't work correctly from search results pages yet, so remove the output and logic from default template parts.
|
| [3348]
|
johnjamesjacoby
|
Topic tag audit. Split topic tag edit form into its own template file. Rename the topic_tag_id global to topic_tag_tax_id. Add missing topic tag template tags and functions.
|
| [3101]
|
johnjamesjacoby
|
Topic tags are now self policing. Previously any member could add topic tags but only moderators could remove them. Also save reply form values if error occurs while posting a reply. Fixes #1466. Props cnorris23 for original patch.
|
| [4562]
|
johnjamesjacoby
|
Topic/Reply admin links:
* Add filters to links arrays.
* Props mordauk.
* Fixes #2090.
|
| [7255]
|
johnjamesjacoby
|
Topic/Reply: improvements to status updates.
This change includes 2 fixes:
* Prefer `$topic_id` over `$topic->ID`, and use it (instead of `$forum_id`) when checking for moderation capability
* Add missing logic in `bbp_edit_reply_handler()` that was preventing statuses from saving as intended
See #2644.
In branches/2.6, for 2.6.10.
|
| [6290]
|
johnjamesjacoby
|
Topic: update phpdoc for `bbp_get_topic_last_reply_id()` and `bbp_get_topic_last_active_time()`.
Props SergeyBiryukov. Fixes #3060.
|
| [2834]
|
johnjamesjacoby
|
Topics widget should not show stickies out of order.
|
| [6931]
|
johnjamesjacoby
|
Topics/Replies: improved support for replies without topics.
This commit removes an assumptive call to `bbp_get_topic()` and avoids a debug notice when a reply is orphaned.
See #3226.
|
| [4531]
|
johnjamesjacoby
|
Topics:
* Use correct filter in bbp_current_user_can_publish_topics().
* Props netweb.
* Fixes #2072 (2.2 branch)
|
| [4532]
|
johnjamesjacoby
|
Topics:
* Use correct filter in bbp_current_user_can_publish_topics().
* Props netweb.
* Fixes #2072 (trunk)
|
| [5901]
|
johnjamesjacoby
|
Topics: Add `edit_reply` capability check to "Edit" row-action link. See #2842.
|
| [6362]
|
netweb
|
Topics: Allow `pending` topics to be edited on the front end.
This changeset in `bbp_get_topic_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending topics always have ugly permalinks.
Props SergeyBiryukov.
See #3054.
|