| [2602]
|
johnjamesjacoby
|
Rename bbp-templatetags to bbp-template
|
| [2722]
|
johnjamesjacoby
|
Rename bbp_get_modified_date function to bbp_convert_date since we no longer use the modified_date for freshness.
|
| [2494]
|
PeteMall
|
Rename bbp_get_topic_forum_ID to bbp_get_topic_forum_id for consistency.
|
| [4808]
|
johnjamesjacoby
|
Rename bbp_pre_get_posts_exclude_forums() to bbp_pre_get_posts_normalize_forum_visibility(), to better describe what it does.
bbp_pre_get_posts_normalize_forum_visibility() is a dual purpose function, responsible for normalizing the post_status and post_parent scopes of bbPress related forum queries, against the current users capabilities. This means it must include forums for capable users, and exclude them for incapable users.
See #2221.
|
| [3726]
|
johnjamesjacoby
|
Rename bbp_reset_post_data() to bbp_theme_compat_reset_post_data() to properly separate it from other functions.
|
| [2485]
|
johnjamesjacoby
|
Rename files and directories from bb- to bbp-. Add topics loop functions. Fix forum/topic post row columns. Add functions and filters files.
|
| [3223]
|
johnjamesjacoby
|
Rename just-in-time filters for editing topics and replies. Copy pasta. See r3222.
|
| [5071]
|
johnjamesjacoby
|
Rename link class to match function and output, and remove some duplicate escapings. See #2090.
|
| [2626]
|
johnjamesjacoby
|
Rename private functions and fix themes url.
|
| [3376]
|
johnjamesjacoby
|
Rename remaining functions prefixed with an underscore.
|
| [2558]
|
johnjamesjacoby
|
Rename single topic_reply template file to match new post_type ID
|
| [2704]
|
johnjamesjacoby
|
Rename sticky option keys
|
| [2935]
|
johnjamesjacoby
|
Rename the 'ignore_sticky_topics' flag to 'show_stickies' and reverse logic to default to true instead of false. This is more natural behavior in the logic that we are turning something off with the word 'false' rather than ignoring stickies with the word 'true'
|
| [2858]
|
johnjamesjacoby
|
Rename topic_id, forum_id, and reply_id global vars to _post_type to more accurately describe what they are. Include template functions to retrieve those values, and use them through-out the project. Normalize component updater functions and remove surplus calculations from them. Temporarily unhook filters from split/join/deletion actions until new routines can be created to handle forum and topic recounts.
|
| [4740]
|
johnjamesjacoby
|
Reorder topic and reply content code filters to fix entity issue inside code blocks.
|
| [7135]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In branches/2.6, for 2.6.6.
See #3310.
|
| [7134]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In trunk, for 2.7.
See #3310.
|
| [6933]
|
johnjamesjacoby
|
Repair Tools: rename forum reply hidden count function, and fix default sort order.
This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
|
| [6428]
|
johnjamesjacoby
|
Repair: In `bbp_repair_forum_visibility()`, don't bail if an error occurs.
Instead, skip the erroneous results and update the valid ones.
|
| [6495]
|
johnjamesjacoby
|
Repairs: Prefer `empty()` over `! isset()` in `bbp_admin_repair_group_forum_relationship()`
The `meta_value` key will always be set, because of the way the forum query is written.
See #2829.
|
| [2648]
|
johnjamesjacoby
|
Replace $_GET['post_type'] references with $typenow global in admin. Props nacin
|
| [3475]
|
johnjamesjacoby
|
Replace 'bp_forums_strip_mentions_on_post_edit' filters with custom class method to prevent load order issues with BuddyPress forums component.
|
| [2557]
|
johnjamesjacoby
|
Replace 'topic_reply' references with 'reply' (this includes the post_type ID)
|
| [5356]
|
johnjamesjacoby
|
Replace `function_exists()` checks with `is_callable()` in template stack functions. Props boonebgorges. See: http://buddypress.trac.wordpress.org/ticket/5671
|
| [4833]
|
johnjamesjacoby
|
Replace body class 'bbPress' with 'bbpress' -- CSS classes are case insensitive, but we should stick to common conventions to avoid confusion. Props ethitter/boonebgorges.
|
| [2596]
|
johnjamesjacoby
|
Replace constants with $bbp global. Rename 'post type' references to 'content type.' Various human readability fixes.
|
| [4581]
|
jmdodd
|
Replace esc_attr() with urlencode() when adding search terms query args.
* Fixes #2110.
|
| [6959]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa (for trunk)
|
| [6958]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa.
|
| [4996]
|
johnjamesjacoby
|
Replace generic stdClass usages with correct object types.
Fixes debug notices with bbp_get_displayed_user_field() when requesting non-existing fields or when there is no displayed user, by allowing the magic __get() methods of the WP_User class to bail if the field is not set.
Also prevents similar issues with main query loops. Fixes #2359.
|
| [3627]
|
johnjamesjacoby
|
Replace get_class() calls with is_a() where applicable.
|
| [3116]
|
johnjamesjacoby
|
Replace incorrect query args ('post_author' with correct 'author'.) Fixes #1511. Props cnorris23.
|
| [4369]
|
johnjamesjacoby
|
Replace instances of 'bbPress' string output with 'Forums' in admin settings.
|
| [4783]
|
johnjamesjacoby
|
Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.
|
| [4974]
|
johnjamesjacoby
|
Replace the_content() with bbp_forum_content() where appropriate. Fixes recursion issues introduced in r4792, as part of http://buddypress.trac.wordpress.org/ticket/5021
|
| [3010]
|
johnjamesjacoby
|
Replace underscores in admin dashboard widget ID with hyphens. Move clearing br outside of update_plugins cap check to prevent display issues for normal users.
|
| [5118]
|
johnjamesjacoby
|
Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.4.1)
|
| [5119]
|
johnjamesjacoby
|
Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.5)
|
| [5349]
|
netweb
|
Replies now use the reply ID for the the post name/slug via r5117.
bbPress' importers should also reflect that change with the removal of 'Reply Title' (post_title), 'Reply Slug' (post_name) and `callback_reply_title` from all importers. Props netweb. Fixes #2585
|
| [7488]
|
johnjamesjacoby
|
Replies/Topics: Stop writes after failed move and split checks.
Prevent the front-end reply-move and topic-split handlers from changing content after validation errors have accumulated. Preserve the existing shared error handling while stopping move and conversion writes before they occur.
Add regression coverage for unauthorized participant actions, accumulated errors, and successful moderator moves and conversions.
In branches/2.6, for 2.6.16.
Props phanphanhailong.
|
| [7487]
|
johnjamesjacoby
|
Replies/Topics: Stop writes after failed move and split checks.
Prevent the front-end reply-move and topic-split handlers from changing content after validation errors have accumulated. Preserve the existing shared error handling while stopping move and conversion writes before they occur.
Add regression coverage for unauthorized participant actions, accumulated errors, and successful moderator moves and conversions.
In trunk, for 2.7.
Props phanphanhailong.
|
| [4522]
|
johnjamesjacoby
|
Replies:
* Add ability to move a reply into a new topic, or into an existing topic.
* Includes new template part, new extra page template, and functions for handling the data move and template output.
* Props jmdodd.
* Fixes #1900.
|
| [4062]
|
johnjamesjacoby
|
Replies:
* Add table prefix to _bbp_has_replies_where().
* See: #1885.
|
| [4163]
|
johnjamesjacoby
|
Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.1 branch.
|
| [4162]
|
johnjamesjacoby
|
Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.2 branch.
|
| [4063]
|
johnjamesjacoby
|
Replies:
* Missed a 'wp_posts' reference in _bbp_has_replies_where().
* See: #1885.
|
| [3999]
|
johnjamesjacoby
|
Replies:
* Update bbp_get_reply_position_raw() to protect against debug notices from a totally missing reply position.
|
| [4530]
|
johnjamesjacoby
|
Replies:
* When editing a reply, do not append "Reply To:"
* Hat-tip netweb.
* Fixes #2066 (2.2 branch)
|
| [4529]
|
johnjamesjacoby
|
Replies:
* When editing a reply, do not append "Reply To:"
* Hat-tip netweb.
* Fixes #2066 (trunk)
|
| [6245]
|
johnjamesjacoby
|
Replies: Add `@since` and link to ticket from r6244.
See #3039.
|
| [6388]
|
johnjamesjacoby
|
Replies: Add `role="button"` to reply-to links.
Also normalize surrounding "Reply" text escaping.
Fixes #3092. Props alexstine.
|
| [6546]
|
johnjamesjacoby
|
Replies: Add `single_row()` method to replies list table when editing a topic.
This lets us use `get_post_class()` on the table rows, so statuses like `pending` or `spam` can be properly in the list for users who have the capability to see them.
See #2587.
|
| [6363]
|
netweb
|
Replies: Allow `pending` replies to be edited on the front end.
This changeset in `bbp_get_reply_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending replies always have ugly permalinks.
Props SergeyBiryukov.
Fixes #3054.
|
| [7157]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In branches/2.6, for 2.6.6. See #3309.
Props dd32, man4toman.
|
| [7158]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In trunk, for 2.7. Fixes #3309.
Props dd32, man4toman.
|
| [7483]
|
johnjamesjacoby
|
Replies: Authorize the topic's forum.
Always derive the forum used for reply creation and capability checks from the submitted topic. Continue validating the form's forum ID, but do not allow it to replace the topic's canonical forum.
Add regression coverage for participants and anonymous posters targeting private, hidden, and inherited restricted forums.
In trunk, for 2.7.
Props vvh1te3zz.
|
| [7484]
|
johnjamesjacoby
|
Replies: Authorize the topic's forum.
Backport the reply forum authorization fix from trunk. Always derive the forum used for reply creation and capability checks from the submitted topic, and call `read_forum` for every forum so inherited restrictions are enforced.
Add regression coverage for normal replies and participant attempts to target hidden and inherited restricted forums.
Merges r7483 to 2.6.
In branches/2.6, for 2.6.16.
Props vvh1te3zz.
|
| [7808]
|
johnjamesjacoby
|
Replies: Backport ancestry and position fixes.
Stop reply ancestry before appending an invalid zero ID, and avoid position updates when the stored menu order is unchanged. Add focused PHPUnit regressions for both behaviors.
In branches/2.6, for 2.6.20.
Fixes #3698.
Fixes #3699.
|
| [6316]
|
johnjamesjacoby
|
Replies: Check for reply hierarchy before assuming topic-title in reply-to.
Fixes a bug causing malformed output when creating a reply via `wp-admin`.
Props tharsheblows . Fixes #2617. See #2844.
|
| [5894]
|
netweb
|
Replies: Clarify inline doc surrounding `bbp_show_lead_topic()` in `bbp_get_reply_position()`
This changest clarify's the docs on how `bbp_show_lead_topic()` affects a reply's menu order in a topics reply loop and determining the correct pagination of reply URL's.
Includes unit tests for `bbp_reply_position()` and `bbp_get_reply_url()`
Fixes #2845
|
| [7665]
|
johnjamesjacoby
|
Replies: Correct @since provenance.
Backport the verified first-shipped version and Subversion revision corrections for replies annotations.
In branches/2.6, for 2.6.19.
|
| [7656]
|
johnjamesjacoby
|
Replies: Correct @since provenance.
Correct first-shipped versions and Subversion revisions for replies annotations verified against source history and release tags.
In trunk, for 2.7.
|
| [7807]
|
johnjamesjacoby
|
Replies: Correct ancestry and position comparisons.
Stop threaded reply ancestry at the root instead of appending a zero ID, and compare normalized integer positions so unchanged replies do not trigger redundant writes. Add regression coverage for both cases.
In trunk, for 2.7.
See #3698.
See #3699.
See #3695.
|
| [7095]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In branches/2.6, for 2.6.6.
See #3376.
|
| [7096]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In trunk, for 2.7.0.
Fixes #3376.
|
| [7625]
|
johnjamesjacoby
|
Replies: Correct positions for unrelated topics.
Backport trunk's strict reply-position lookup and return zero when the requested reply is absent from a topic. Use WordPress URL parsing, correct array spacing, and document intentional lint exceptions while preserving the public parameter name.
In branches/2.6, for 2.6.19.
|
| [6553]
|
johnjamesjacoby
|
Replies: Do not update term cache in `bbp_has_replies()`.
This change removes 2 unnecessary database queries from single topic pages. In situations where the leading topic is gathered as part of the `bbp_has_replies()` loop, this still functions as anticipated, and the original topic loop query will handle updating the term cache appropriately.
|
| [6317]
|
johnjamesjacoby
|
Replies: Ensure hierarchical replies are correctly wrapped & concatenated into their output buffers in the correct order.
This updates the walker class to not immediately echo it's contents, and wraps it in an `ul` element.
Fixes #2757. See #2830.
|
| [6037]
|
netweb
|
Replies: Fix `@param` PHPDoc in `bbp_insert_topic_update_counts()`
See #1799
|
| [7292]
|
johnjamesjacoby
|
Replies: Fix a bug that causes replies to not appear in some topics.
In WordPress 6.8, `WP_Query` now enforces a consistent alphabetical order for array values. This change breaks the `_bbp_has_replies_where()` function, which previously relied on a strict comparison against `post_type`.
See: https://core.trac.wordpress.org/ticket/59516
This commit replaces the strict comparison with an `array_diff()` check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to `$query->get()`.
Props @vortfu.
Committed to the 2.6 branch for 2.6.13.
See #3631.
|
| [7293]
|
johnjamesjacoby
|
Replies: Fix a bug that causes replies to not appear in some topics.
In WordPress 6.8, `WP_Query` now enforces a consistent alphabetical order for array values. This change breaks the `_bbp_has_replies_where()` function, which previously relied on a strict comparison against `post_type`.
See: https://core.trac.wordpress.org/ticket/59516
This commit replaces the strict comparison with an `array_diff()` check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to `$query->get()`.
Props vortfu, arl1nd.
Committed to trunk for 2.7.
Fixes #3631.
|
| [5924]
|
netweb
|
Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5880]
|
netweb
|
Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
|
| [5889]
|
netweb
|
Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
|
| [6396]
|
johnjamesjacoby
|
Replies: Invert the `$show_none` comparison, to fix the default drop-down text.
Props SergeyBiryukov. Fixes #2617.
|
| [6621]
|
johnjamesjacoby
|
Replies: Normalize `bbp_has_replies()` default search with `bbp_has_topics()`.
This brings parity to how these two functions handle default search parameters.
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [7458]
|
johnjamesjacoby
|
Replies: Prevent replies to unreadable topics.
Backport the relevant parent-topic capability check from [7350] so Participants cannot submit replies to topics they cannot read. Add regression coverage for private topics.
Props hoangkien1020.
See #3650.
|
| [5891]
|
netweb
|
Replies: Remove previous `menu_order` default from `bbp_insert_reply()` missed in r5889
Antiprops netweb. See #2843.
|
| [7139]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In branches/2.6, for 2.6.6. See #3379.
|
| [7138]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In trunk, for 2.7. See #3379.
|
| [6979]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6.
|
| [6980]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk.
|
| [7457]
|
johnjamesjacoby
|
Replies: Test parent-topic reply permissions.
Add regression coverage to ensure Participants cannot submit replies to topics they cannot read.
Props hoangkien1020.
See #3650.
|
| [6246]
|
johnjamesjacoby
|
Replies: Update `bbp_thread_replies()` to skip user profile pages.
* Move from core/options to replies/functions, since this isn't directly an option
* Add `! bbp_is_single_user_replies()` check to force `false` if so
* Update threaded replies pagination to re-include verbiage.
Fixes #3002.
|
| [6721]
|
johnjamesjacoby
|
Replies: Update tests for `test_bbp_get_reply_position()`.
This change makes sure that updating a reply position to zero is still possible, also ensuring that tests continue to pass as expected.
|
| [7842]
|
johnjamesjacoby
|
Replies: Use the reply topic for position classes.
Pass the reply's topic ID when calculating an unstored reply position for its CSS class. This avoids falling back to an unrelated current topic, preserves the correct class, and allows the calculated position to be saved.
In branches/2.6, for 2.6.20.
Props chefranov.
Fixes #3710.
|
| [7841]
|
johnjamesjacoby
|
Replies: Use the reply topic for position classes.
Pass the reply's topic ID when calculating an unstored reply position for its CSS class. This avoids falling back to an unrelated current topic, preserves the correct class, and allows the calculated position to be saved.
In trunk, for 2.7.
Props chefranov.
See #3710.
|
| [7728]
|
johnjamesjacoby
|
Replies: Validate hierarchical reply parents.
Keep parent relationships within a topic and pass the validated parent ID to integrations. This preserves valid same-topic replies.
In branches/2.6, for 2.6.19.
|
| [7727]
|
johnjamesjacoby
|
Replies: Validate hierarchical reply parents.
Keep parent relationships within a topic and pass the validated parent ID to integrations. This preserves valid same-topic replies.
In trunk, for 2.7.
|
| [7178]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In branches/2.6 for 2.6.7. See #3366.
Props immeet94.
|
| [7177]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In trunk for 2.7.0. See #3366.
Props immeet94.
|
| [7448]
|
johnjamesjacoby
|
Replies: allow trashed replies to be marked as spam.
Keep the front-end Spam action available for trashed replies so moderators can classify replies beneath a spam topic without restoring them first. Continue hiding Trash for replies already marked as spam.
In trunk, for 2.7.
Props rollybueno.
Fixes #3411.
From https://github.com/bbpress/bbPress/pull/36.
|
| [7450]
|
johnjamesjacoby
|
Replies: allow trashed replies to be marked as spam.
Keep the front-end Spam action available for trashed replies so moderators can classify replies beneath a spam topic without restoring them first. Continue hiding Trash for replies already marked as spam.
Merges r7448 to 2.6.
In 2.6, for 2.6.16.
See #3411.
|
| [7180]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In branches/2.6 for 2.6.7. Fixes #3386.
|
| [7179]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In trunk for 2.7.0. See #3386.
|
| [7409]
|
johnjamesjacoby
|
Replies: avoid bool-increment deprecation in `bbp_get_reply_position_raw()`
Fixes the PHP 8.3+ `Increment on type bool has no effect` warning, guarding the increment behind a `false !== $reply_position` check, and explicitly resetting to `0` if not-found.
In trunk, for 2.7.
Props dd32.
Fixes: #3672.
From: https://github.com/bbpress/bbPress/pull/41
|
| [7011]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6.
|
| [7010]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.7, trunk.
|
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
