| [6564]
|
johnjamesjacoby
|
Settings: Use `$this->minimum_capability` in options page filter method.
This change keeps the filter inline with the mapped meta caps, should the minimum capability be renamed or changed.
|
| [6483]
|
johnjamesjacoby
|
Settings: cast `map_meta_caps` return value to an array.
|
| [6420]
|
johnjamesjacoby
|
Settings: remove directory path from option text.
|
| [6955]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6.
|
| [6954]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.7, trunk.
|
| [3779]
|
johnjamesjacoby
|
Setup default theme compatibility in bbPress::setup_theme()
* Sets early on bbp_setup_theme so functions and files can be included
* Still allows plugins to override earlier
* See #1766
|
| [3452]
|
johnjamesjacoby
|
Setup option filters earlier on bbp_init so plugins don't need to worry about load order. See r3451.
|
| [3445]
|
johnjamesjacoby
|
She seems to have an invisible touch, yeah. Fixes #1603. Props cnorris23.
|
| [6125]
|
johnjamesjacoby
|
Shh... I meant `bbp_translate_user_role()`.
See r6121.
|
| [5069]
|
johnjamesjacoby
|
Shift output escaping around in admin links to allow for filtering and passing additional HTML into them. Hat tip mourdak. Fixes #2090.
|
| [4586]
|
jmdodd
|
Shortcode iteration for search introduced in #1575.
* Fix bbp-search shortcode.
* Introduce bbp-search-form shortcode.
* Fixes #2107.
|
| [4295]
|
johnjamesjacoby
|
Shortcodes:
* Fix incorrect post_type reference in shortcodes inline doc.
* Fixes #2003.
|
| [4296]
|
johnjamesjacoby
|
Shortcodes:
* Fix incorrect post_type reference in widgets inline doc.
* Fixes #2007.
|
| [4212]
|
johnjamesjacoby
|
Shortcodes:
* Move shortcode registration into bbPress class to mirror other internal dependencies.
* Introduce bbp_register_shortcode() function, hooked to 'bbp_register'
|
| [5957]
|
netweb
|
Shortcodes: Fix `@return` type shring/string typo in `display_stats()`
|
| [5956]
|
netweb
|
Shortcodes: Remove superfluous `@param` PHPDoc instances from various shortcode functions
Props casiepa.
|
| [2484]
|
PeteMall
|
Show forum title, description and topic count on forums admin page.
|
| [3231]
|
johnjamesjacoby
|
Show hidden forums in the admin all list.
|
| [2888]
|
johnjamesjacoby
|
Show the forum of super sticky topics when outside of the forum the sticky belongs in.
|
| [7087]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In branches/2.6, for 2.6.5.
See #3157.
|
| [7086]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In trunk, for 2.7.0.
See #3157.
|
| [5466]
|
johnjamesjacoby
|
Simpify `ABSPATH` checks to pass coding standard sniffers that look for brackets on comparisons.
|
| [5547]
|
netweb
|
SimplePress 5:
* Fix regression introduced in r5349 where topics were imported a second time as part of the reply section import.
* Fix reply parent forum ID mini cache callback to use `callback_forumid`
* Add topic author IP address to topics import section
|
| [5151]
|
netweb
|
SimplePress Importer Improvements. Props netweb. Fixes #2194
* Add reply slug field mapping
* Add custom regex for non-break spaces in HTML
|
| [4615]
|
johnjamesjacoby
|
Simplify favorites link logic and output, to match subscriptions link functionality. Fixes #2118.
|
| [2595]
|
johnjamesjacoby
|
Simplify load sequence.
|
| [4226]
|
johnjamesjacoby
|
Simplify password reset hint text.
|
| [5513]
|
johnjamesjacoby
|
Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.
|
| [4999]
|
johnjamesjacoby
|
Since search requests get existing data, and do not post new data, revert part of r4997 and switch request method back to "get".
Add hidden 'action' field to form-search.php template-part, and move 'bbp_search_results_redirect' action from 'bbp_post_request' to 'bbp_get_request'.
Fixes issue with request not redirecting properly, and uses more accurate form method. See #2337.
|
| [4216]
|
johnjamesjacoby
|
Single topics:
* Force is_home to false in bbp_has_replies()
* Maybe set is_single to true if viewing a single topic.
* Fixes bug where WP_Query::parse_query() incorrectly assumes is_home() when multiple post_types are queried.
* Fixes #1947.
|
| [2468]
|
johnjamesjacoby
|
Singular slugs and add reply slug
|
| [3161]
|
johnjamesjacoby
|
Singular/Plural fixes on forum and topic descriptions. Fixes #1515. Props !GautamGupta.
|
| [2469]
|
johnjamesjacoby
|
Singular/plural filter fixes (see r2468)
|
| [3649]
|
johnjamesjacoby
|
Slight performance improvements to author display_name. See #1704.
|
| [5512]
|
johnjamesjacoby
|
Slightly refactor `bbp_format_buddypress_notifications()`:
* Return original `$action` if not `bbp_new_reply`.
* Reduce indentation to accommodate new `$action` check.
This fixes a bug where checking for new reply notifications could cause future notification filter checks to fail.
Props Faison. Fixes #2665.
|
| [2467]
|
johnjamesjacoby
|
Slug fixes
|
| [6966]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.6.2, branches/2.6.
|
| [6967]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.7, trunk.
|
| [2681]
|
johnjamesjacoby
|
Smart redirect on new reply in the event new reply creates new topic page
|
| [5394]
|
johnjamesjacoby
|
Smarter ancestor detection in `BBP_Walker_Reply_Dropdown`. See #2617.
|
| [5286]
|
johnjamesjacoby
|
Smarter build/src toggling for the stub plugin. See #2542.
|
| [5908]
|
johnjamesjacoby
|
Sniffer: Whitespace around variables in arrays.
|
| [5514]
|
netweb
|
So `.gitignore` is whitespace sensitive. If you include trailing whitespace, git won't recognize your files.
|
| [2883]
|
johnjamesjacoby
|
Some adjustments to bbp-topic-template.php. Allow capable users to view trashed or private topics on request. Use new author_link function in topic revisions. Do not return a no-break space in bbp_get_topic_admin_links.
|
| [2772]
|
johnjamesjacoby
|
Sort by menu_order on forums widget
|
| [3790]
|
johnjamesjacoby
|
Sort forum ID's based on last active time when querying subforum ID's.
* Prevents last active meta data from becoming poisoned when recounting
* See #1534
* Props GargajCNS for initial patch
|
| [3933]
|
johnjamesjacoby
|
Space.
|
| [3444]
|
johnjamesjacoby
|
Speeling and phpdoc fixes. Fixes #1602. Props cnorris23.
|
| [2865]
|
johnjamesjacoby
|
Speeling fixes
|
| [4048]
|
johnjamesjacoby
|
Spelling Police:
* First pass.
* Fixes #1881, #1880.
* Props netweb.
|
| [5518]
|
netweb
|
Spelling typo in `bbp_toggle_reply_handler()`, in between words we use spaces.
|
| [4092]
|
johnjamesjacoby
|
Spelling:
* 'i' before 'e', unless you are me.
* I cannot spell, which gives users a headache.
* For 2.1.1.
|
| [4093]
|
johnjamesjacoby
|
Spelling:
* 'i' before 'e', unless you are me.
* I cannot spell, which gives users a headache.
* For 2.2.
|
| [3252]
|
johnjamesjacoby
|
Spit shine the breadcrumb code to play nicely with root forum archive pages.
|
| [4968]
|
johnjamesjacoby
|
Split "Main" settings up into "User" and "Features" - also tweak fancy editor verbiage to add more context.
|
| [3811]
|
johnjamesjacoby
|
Split admin tools Recount into two functions to handle form submission without duplicate admin notices. Fixes #1788.
|
| [2790]
|
johnjamesjacoby
|
Split apart bbp-functions.php into smaller, more manageable files. Also fix missing global on subscription removal. Props !GautamGupta via Google Code-in
|
| [3095]
|
johnjamesjacoby
|
Split bbp-admin.php up into smaller, more manageable parts for forums, topics, replies, users, and metaboxes. Add checks for ABSPATH to each file so that they cannot be accessed outside of WordPress. Adjust the location of the admin menu separator based on use caps and visible menus.
|
| [3755]
|
johnjamesjacoby
|
Split bbp-core-hooks.php into two files:
* bbp-core-actions.php
* bbp-core-filters.php
* Update bbpress.php to load new files
* Update phpdoc
|
| [5406]
|
johnjamesjacoby
|
Split secondary topic spam/trash/unspam/untrash actions into separate functions to be used during topic status transition. See #2494.
|
| [3106]
|
johnjamesjacoby
|
Split user template files up into parts for shortcode usage.
|
| [4176]
|
johnjamesjacoby
|
Stand tall, little T.
|
| [5951]
|
netweb
|
Standardize `@since` PHPDoc tags style and format
* e.g. `@since 2.6.0 bbPress (r5951) YOLO`
* See http://phpdoc.org/docs/latest/references/phpdoc/tags/since.html
This changeset updates the style and formatting of all of our `@since` instances for compatibility with phpDocumentor 2 and WP-Parser as we move toward implementing the bbPress developer code reference.
Props thebrandonallen
Fixes #2879
|
| [4510]
|
johnjamesjacoby
|
Statistics:
* Add widget and shortcode for forum statistics.
* Props MZAWeb.
* Fixes #2052.
|
| [6543]
|
johnjamesjacoby
|
Statistics: Define the `$statistics` array.
This change prevents debug notices, particularly in higher PHP versions (+7.0)
See #2770.
|
| [6542]
|
johnjamesjacoby
|
Statistics: Improvements to "At a Glance" integration.
* Prefer `bbp_get_total_users()` over `count_users()` to speed up loading
* Don't include empty array values
* Don't link to areas the current user cannot access
* Skip if current user cannot at least spectate (blocked or no access)
Fixes #2770.
|
| [7237]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In branches/2.6 for 2.6.10. Fixes #3428.
|
| [7236]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In trunk for 2.7.0. Fixes #3428.
|
| [6786]
|
johnjamesjacoby
|
Stats: Whitespace adjustments to some statistics functions.
See #3196.
|
| [6026]
|
johnjamesjacoby
|
Statuses, Types, Visibilities: Pass the forum, topic, or reply ID into helper functions.
These ID's pass additional context into respective filters, useful for fine-grained control over UI elements.
This commit normalizes the way these functions work across all of bbPress where applicable, by ensuring all similar functions accept an ID and assume `0` by default. Note that there are currently 2 locations where no ID exists to pass context into, which is by design.
Fixes #2954.
|
| [6027]
|
johnjamesjacoby
|
Statuses, Types, Visibilities: `bbp_get_topic_types()` usages were missed in r6026.
See #2954.
|
| [6547]
|
johnjamesjacoby
|
Statuses: Update `Closed` status arguments in `register_post_status()` call.
This makes sure posts with a closed status appear in the status and all listings.
|
| [6922]
|
johnjamesjacoby
|
Statuses: normalize status related functions across post types.
This commit adds 2 missing functions for forum statuses, and relocates all of them to the correct functions.php files for their post types.
|
| [4126]
|
johnjamesjacoby
|
Stickies:
* Make sure stickies always appear according to freshness date.
* For 2.1 branch.
|
| [4125]
|
johnjamesjacoby
|
Stickies:
* Make sure stickies always appear according to freshness date.
* For 2.2.
|
| [4444]
|
johnjamesjacoby
|
Stickies:
* Prevent revisions from being saved as stickies when editing in wp-admin.
* Also cleans up existing stickies when adding a new sticky topic.
* Fixes #2034 (2.2 branch)
|
| [4443]
|
johnjamesjacoby
|
Stickies:
* Prevent revisions from being saved as stickies when editing in wp-admin.
* Also cleans up existing stickies when adding a new sticky topic.
* Fixes #2034 (trunk)
|
| [6402]
|
johnjamesjacoby
|
Stickies: Improved algorithm for merging stickies to queried posts
* Separate into overloadable function
* Tighter, less wasteful loops through existing query
* Improved sort-ordering of topics by their most recent post activity
* Also separate pagination base URL into new function, out of `bbp_has_topics()`
|
| [6401]
|
johnjamesjacoby
|
Stickies: Update forum/topic meta early in `bbp_update_topic()`
* Makes meta-data available earlier for downstream functions
* Removes ineffective assumption of forum-topic-id when empty
This fixes a situation where trying to stick a new topic to a forum would look for the `_bbp_forum_id` meta-data before it was updated.
Fixes #3103.
|
| [6915]
|
johnjamesjacoby
|
Stickies: make sure unapproved topics are unstuck also.
This commit removes a hard coded call to `bbp_unstick_topic()` and hooks into the neighboring `bbp_stick_topic` action, while also hooking into the `bbp_unapprove_topic` action.
A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code.
Fixes #3246.
|
| [2825]
|
johnjamesjacoby
|
Sticky styling is not just for the front page.
|
| [2819]
|
johnjamesjacoby
|
Stop XMLRPC from complaining when bbPress is activated. Remove needless isset() checks in bbp_get_user_id(). Fixes #1458
|
| [3153]
|
johnjamesjacoby
|
Stop including the old updater script, in preparation for file removal before adding into WP extend.
|
| [6140]
|
johnjamesjacoby
|
Stop shouting at everyone!
|
| [3375]
|
johnjamesjacoby
|
String consistency. Fixes #1584. Props ramiy.
|
| [5073]
|
johnjamesjacoby
|
String match 'to front' from changes to #2090.
|
| [4287]
|
johnjamesjacoby
|
Strings:
* Add tips for topic stickiness in admin.
* Props netweb.
* See #2004.
|
| [4286]
|
johnjamesjacoby
|
Strings:
* Fix "forum" references that should be "topic."
* Fixes #2004.
|
| [6199]
|
johnjamesjacoby
|
Strings: Add `view_items` text for forums, topics, replies, and topic-tags.
This adds support for a label that is new to WordPress 4.7.
|
| [5867]
|
johnjamesjacoby
|
Strings: Switch from "Freshness" to "Last Post" in the `default` theme-compatibility templates.
This changeset updates the column header text used to describe the last activity of a forum/category or topic in bbPress's `default` theme-compatibility (which includes details beyond just the timestamp) making "Last Post" more contextually accurate compared to "Freshness" which still makes sense within the dashboard (which currently only shows the timestamp.)
Fixes #2031.
|
| [6047]
|
netweb
|
Strings: Switch from "Freshness" to "Last Post" in the admin screens.
This changeset follows on from [5867] where these couple of strings were missed in the original commit.
Props Robkk, thebrandonallen
Fixes #2031
|
| [7036]
|
johnjamesjacoby
|
Strings: improve consistency of "ERROR" messaging.
This commit moves a few colons from within their respective `<strong>` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.6.4, branches2.6.
|
| [7037]
|
johnjamesjacoby
|
Strings: improve consistency of "ERROR" messaging.
This commit moves a few colons from within their respective `<strong>` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.7, trunk.
|
| [5868]
|
johnjamesjacoby
|
Strings: prefer `—` over parenthesis when wrapping "No" style results.
This changeset normalizes the strings used to pick the parent of a forum, topic, and reply. The `—` may be changed later to improve localization, but for now this provides a good balance of visual separation and familiar UX.
|
| [6735]
|
johnjamesjacoby
|
Strings: remove escaped single quotes from profile/website link attributes.
Also normalize the approach used in these 3 similar functions.
|
| [6255]
|
johnjamesjacoby
|
StyleLint: Prefer shorthand CSS Colors.
|
| [6743]
|
johnjamesjacoby
|
Styling tweaks for improved Twenty Seventeen theme support.
|
| [6589]
|
johnjamesjacoby
|
Styling: Bump assets version & remove prefixes from default.css.
Prefixes are put back during build.
|
| [6588]
|
johnjamesjacoby
|
Styling: Clean-up default styling to pass style linting rules.
|
| [6587]
|
johnjamesjacoby
|
Styling: Flatten the editor buttons, and force fieldset legend width & border.
This improves default theme compatibility.
|