| [6568]
|
johnjamesjacoby
|
Revert part of r6567, and instead skip the page condition completely.
This makes sure that forms are made available to moderators regardless of the page condition, and fixes a situation where per-forum moderators couldn't publish to forums or topics that were closed.
|
| [2961]
|
johnjamesjacoby
|
Revert previous admin menu separator sanity checks until it can be researched further.
|
| [3258]
|
johnjamesjacoby
|
Revert r3257 for something more elegant.
|
| [3377]
|
johnjamesjacoby
|
Revert r3369.
|
| [3408]
|
johnjamesjacoby
|
Revert r3407 and r3405 and move overflow styling into correct locations.
|
| [3472]
|
johnjamesjacoby
|
Revert r3471 as it introduced added layer of complexity and potentially confusing function names.
|
| [4637]
|
johnjamesjacoby
|
Revert r4625, as it could cause spam topics to become published. Will need to rethink/revisit this in 2.4. See #2125.
|
| [5273]
|
johnjamesjacoby
|
Revert r5270, r5271. Let's try to get our history back. Antiprops johnjamesjacoby.
|
| [6854]
|
johnjamesjacoby
|
Revert r6853. This breaks pages with matching slug paths.
Will revisit this more thoroughly in a future version.
|
| [2597]
|
johnjamesjacoby
|
Revert to colloquial barbarisms (content type/post type)
|
| [4428]
|
johnjamesjacoby
|
Revisions:
* In bbp_get_reply_revision_log(), check the post type, and maybe return bbp_get_topic_revision_log() if post is a topic in the replies loop.
* This happens when bbp_show_lead_topic() is set to false, which is the default.
* See #2029.
|
| [4426]
|
johnjamesjacoby
|
Revisions:
* Since we do our own revision handling, turn off revisions for the initial call to wp_update_post() in topics and replies.
* We check if the post type supports revisions, and toggle them off and back on to avoid duplicate revisions from specifically saving it later in the edit process.
* Fixes #2029.
|
| [4427]
|
johnjamesjacoby
|
Revisions:
* Use correct post type in replies.
* See #2029.
|
| [6079]
|
netweb
|
Rewrite Rules: Update search permastruct in `bbPress::add_permastructs()` to `$search_id`
This changeset fixes copy pasta introduced in r4930, and updates the search rewrite to use the `$search_id` and not the `$user_id` as the permalink structure name.
Props offereins.
Fixes #2984.
|
| [4321]
|
johnjamesjacoby
|
Rewrites:
* Introduce unique rewrite tags and rules for user topics and replies.
* Fixes conflict with topic and reply post type rules.
* Fixes bug where user topics and replies pages were not working on some installations.
|
| [6889]
|
johnjamesjacoby
|
Rewrites: use `property_exists()` on `$wp_rewrite` global touches.
This makes sure that bbPress defaults are preferred, and avoids fatal errors if class properties are unset.
Also relocate `bbp_use_pretty_urls()` to better group it together with other `bbp_rewrite()` wrappers.
|
| [4448]
|
johnjamesjacoby
|
Roles:
* Remove unused Visitor role.
* Map non-WordPress roles to default role.
* Hat-tip nerrad for confirmation/testing.
* Fixes #2042 (2.2 branch)
|
| [4447]
|
johnjamesjacoby
|
Roles:
* Remove unused Visitor role.
* Map non-WordPress roles to default role.
* Hat-tip nerrad for confirmation/testing.
* Fixes #2042 (trunk)
|
| [4528]
|
johnjamesjacoby
|
Roles:
* When updating bbPress and normalizing user roles, remove the old moderator and participant roles from the database.
* Move !BuddyPress role removal into groups repair tool.
* See #2065 (2.2 branch)
|
| [4527]
|
johnjamesjacoby
|
Roles:
* When updating bbPress and normalizing user roles, remove the old moderator and participant roles from the database.
* Props jmdodd.
* Fixes #2065.
|
| [4449]
|
johnjamesjacoby
|
Roles:
* get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role().
* See #2042 (2.2 branch)
|
| [4450]
|
johnjamesjacoby
|
Roles:
* get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role().
* See #2042 (trunk)
|
| [6118]
|
johnjamesjacoby
|
Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate "role names" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `roles` variable to main bbPress class, and store loaded roles there
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. For trunk (2.6)
|
| [6120]
|
johnjamesjacoby
|
Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate "role names" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. 2.5 branch (for 2.5.11)
|
| [6108]
|
johnjamesjacoby
|
Roles: Improve performance of `bbp_get_dynamic_roles()` with a local static variable.
Previously, it rebuilt the multidimensional array of role keys & strings each time it was called, which may be several depending on the page being loaded.
See: #2452.
|
| [6106]
|
johnjamesjacoby
|
Roles: Introduce `bbp_roles_init` subaction, and use this for future dynamic roles initialization.
See: #2452;
|
| [6107]
|
johnjamesjacoby
|
Roles: Modify `bbp_add_forums_roles()` to accept a `WP_Roles` object as a parameter.
This allows dynamic roles to be initialized on each call to `wp_roles_init` (for WordPress 4.7) rather than relying on the guesswork of blog-switching, option-sniffing, or user init'ing (none of which have ever been good indicators of roles being initialized.)
See: #2452.
|
| [6147]
|
johnjamesjacoby
|
Roles: Port `bbp_roles_init()` from trunk to 2.5 branch. See: #3028.
|
| [6116]
|
johnjamesjacoby
|
Roles: Remove overzealous usages of `bbp_add_forums_roles()`.
Now that the `wp_roles_init` action exists, we can rely on bbPress roles being registered an available, and no longer need to re-reinitalize them before trying to interact with them.
See: #2959.
|
| [6667]
|
johnjamesjacoby
|
Roles: account for empty role in `bbp_set_current_user_default_role()`
This change makes sure that if a user's role does not match any known role, they still receive the default role for the site.
Trunk, for 2.6.
|
| [7257]
|
johnjamesjacoby
|
Roles: prevent notices when calling `bbp_add_forums_roles()`
This change adds sanity checks around the `$wp_roles` parameter of the `bbp_add_forums_roles()` function.
It will now attempt to initialize the `WP_Roles` class just-in-time, but only if not already doing the `wp_roles_init` action (to prevent recursion).
If after all of that `$wp_roles` is still not what it needs to be, this function will now silently bail instead of proceeding (to prevent debug notices & errors).
Fixes #3493.
Props naxoc.
In branches/2.6, for 2.6.10.
|
| [3308]
|
johnjamesjacoby
|
Round 2 of Akismet updates. Fixes #1553. Props cnorris23.
|
| [2809]
|
johnjamesjacoby
|
Run strip_tags and trim on topic and reply excerpts. Fixes #1448.
|
| [5332]
|
netweb
|
SMF Importer BBCode regex expressions
* Fix copy pasta `<br>`/`<tt>` regex
* Add non-break space ` ` to space ` ` rexex
Props mspecht. Fixes @2558
|
| [5576]
|
netweb
|
SMF importer: Include Subscribed Forums and Subscribed Topics
Props netweb. See #2668
|
| [2906]
|
johnjamesjacoby
|
SVN add bbp-update.php from previous revision
|
| [3986]
|
johnjamesjacoby
|
SVN properties:
* Add EOL native to new feedback-no-replies.php template part.
* Fixes #1851.
|
| [5690]
|
netweb
|
SVN: Remove invalid SVN property `sv:eol-style` from image files in `/branches/2.0` and `/tags/2.0.x`
|
| [7042]
|
netweb
|
SVN: Set `svn:mime-type` to `text/xml` for *.xml.dist files
|
| [3423]
|
johnjamesjacoby
|
Sanity check $wp_roles and set if not already set.
|
| [3426]
|
johnjamesjacoby
|
Sanity check nickname in bbp_edit_user_display_name() to prevent potential debug notice. Fixes #1597. Props !GautamGupta.
|
| [3227]
|
johnjamesjacoby
|
Sanity check on user roles to prevent error if user does not have a role assigned to them.
|
| [2817]
|
johnjamesjacoby
|
Sanity checks on logout redirection global variables
|
| [4203]
|
johnjamesjacoby
|
Scripts:
* Create empty .min files where warranted.
* Rejig green admin scheme CSS files to use .min.
|
| [6641]
|
johnjamesjacoby
|
Scripts: Do not enqueue if not `is_bbpress()`.
This reduces the number of external scripts that are enqueued on non-bbPress pages. Put another way, it makes sure that bbPress styles & scripts are only loaded on pages where bbPress content is known to exist.
Fibes #3138. Props DJPaul.
|
| [4618]
|
johnjamesjacoby
|
Search Tweaks:
* Add support for search root page.
* Add search root page to breadcrumb.
* Tweak search form CSS.
* See #1575.
|
| [7077]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
Fixes #3357. 2.6 branch, for 2.6.5.
|
| [7076]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
See #3357. Trunk, for 2.7.0.
|
| [7297]
|
johnjamesjacoby
|
Search: Avoid PHP warnings if search terms are a nested array.
This commit modifies the `bbp_sanitize_search_request()` function to filter out all non-scalar values from the requested values, ensuring that unsupported formats (arrays of arrays specifically) are ignored.
Props dd32.
In the 2.6 branch, for 2.6.14.
See #3634.
|
| [7298]
|
johnjamesjacoby
|
Search: Avoid PHP warnings if search terms are a nested array.
This commit modifies the `bbp_sanitize_search_request()` function to filter out all non-scalar values from the requested values, ensuring that unsupported formats (arrays of arrays specifically) are ignored.
Props dd32.
In trunk, for 2.7.
Fixes #3634.
|
| [6620]
|
johnjamesjacoby
|
Search: Escape output of `bbp_search_terms()` and wire-up to `ts` and `rs`.
|
| [6629]
|
johnjamesjacoby
|
Search: Use correct `rs` request key.
Fixes a debug notice when searching replies inside of topics.
|
| [6903]
|
johnjamesjacoby
|
Search: add support for `fs` query-arg to search forums list:
* Introduces `bbp_sanitize_search_request()` to encapsulate duplicate code across forums/topics/replies
* Introduces `bbp_get_search_type_ids()` to stub out future enhancements (tags, users, etc...)
* Use these new functions where intended
* Update `bbp_get_search_terms()` to loop through known search-type IDs
This commit also fixes debug notices that would happen when these query arguments were not explicitly strings.
Fixes #3245.
|
| [6630]
|
johnjamesjacoby
|
Search: move `bbp_allow_search()` checks into form template parts.
This allows the inclusion of those forms without needing to wrap each inclusion statement in its own feature check, making search a more atomic and isolated feature within bbPress.
It also should conclude the development of the user content search functionality.
Because this involves some template-part changes to the "Default" template pack, users who have opted to override these parts in their own themes will not receive these updates (nor should they.) This is a known consequence of including template parts in themes, so while still not an ideal system, will not result in any breakage for existing sites.
|
| [7262]
|
johnjamesjacoby
|
Search: prevent hidden forums from appearing in results.
This change includes the following changes:
* Removes `readable` perm check from `bbp_has_search_results()` and replaces it with public topic statuses by default, while conditionally adding private & hidden statuses if user is capable
* Tweaks the logic inside of `bbp_pre_get_posts_normalize_forum_visibility()` to always handle both of its internal conditions (forum query, or any query that includes forums/topics/replies connected via meta data)
* Tweaks output of `content-search.php` template part to not show the "Oh bother" error when visiting a search page for the first time
* Adds a string `feedback-no-search.php` template part to address both "no results" and "no terms" conditions
These changes address some faulty search logic that was allowing hidden forums to appear in global search results to users who should not have been able to see them, while also improving the search page experience itself.
Fixes #3473.
Props wpsolr, robin-w.
In branches/2.6, for 2.6.10.
|
| [7280]
|
johnjamesjacoby
|
Search: remove `array_keys()` from
This change ensures that the correct public statuses are used by default inside of the `bbp_has_search_results()` function, and it does this by using the values from `bbp_get_public_topic_statuses()` and not the keys.
This fixes a regression causing search results to omit public statuses as part of their default arguments.
Props GDragoN.
Fixes #3607.
|
| [6824]
|
johnjamesjacoby
|
Search: update `bbp_get_search_terms()` to only accept a string.
This change prevents non-string payloads from being encoded & trimmed.
|
| [7332]
|
johnjamesjacoby
|
Search: use correct sanitization function inside of `bbp_sanitize_search_request()`.
This change fixes a bug causing forum/topic/reply specific searches to fail when searching for more than 1 word, by swapping out `sanitize_title()` with `sanitize_text_field()`.
Props dd32, aezazshekh.
In branches/2.6, for 2.6.14.
Fixes #3516.
|
| [7333]
|
johnjamesjacoby
|
Search: use correct sanitization function inside of `bbp_sanitize_search_request()`.
This change fixes a bug causing forum/topic/reply specific searches to fail when searching for more than 1 word, by swapping out `sanitize_title()` with `sanitize_text_field()`.
Props dd32, aezazshekh.
In trunk, for 2.7.
Fixes #3516.
|
| [3225]
|
johnjamesjacoby
|
Second round of bbPress standalone importer updates. Props !GautamGupta. See #1523.
|
| [3179]
|
johnjamesjacoby
|
Security sweep and code clean-up through bbp-reply-functions.php. See #1514.
|
| [3399]
|
johnjamesjacoby
|
Separate actions and filters in BBP_BuddyPress class. Introduce activity_can_comment() and activity_get_permalink() filters to force bbPress's activity stream items to behave exactly like they do currently with group forums.
|
| [3717]
|
johnjamesjacoby
|
Separate bbp-core-compatibility.php into smaller, less-confusing parts:
* bbp-theme-compatibility.php - the API that makes existing themes compatible
* bbp-template-functions.php - functions used to find and load bbPress templates
* bbp-template-loader.php - similar to the WordPress template loader, it handles the logic of what template to display
* Move commonly used functions into bbp-common-functions.php
* Update bbpress.php to require() new files
|
| [5080]
|
johnjamesjacoby
|
Separate content replacement from title replacement in forum and topic archives, allowing pages with matching slugs but empty post_content to replace the_content as expected. Fixes situation where a user creates a "Forums" page and leaves the content empty, expecting bbPress to replace it.
Also use the $page->ID to help "Edit" links to point to the correct post ID.
|
| [6628]
|
johnjamesjacoby
|
Separators: Normalize the `sep` arguments between functions.
This change also switches `bbp_list_forums()` to `implode()` links rather than concatenate the same `$output` string with an increasing number of items. This has the positive side-effect of moving the forum separator (a comma by default) out of individual links.
Props milindmore22. Fixes #2900.
|
| [3379]
|
johnjamesjacoby
|
Set $bbp->current_user as byref of $current_user.
|
| [3539]
|
johnjamesjacoby
|
Set $the_core_slugs static to empty array in bbp_form_slug_conflict_check()
|
| [5315]
|
johnjamesjacoby
|
Set `is_tax` to true when calling `bbp_theme_compaty_reset_post()` when viewing/editing a topic-tag. Fixes #2444.
|
| [5771]
|
johnjamesjacoby
|
Set `svn-autoprops`.
This was introduced in Subversion 1.8 specifically to allow common properties for all present and future files in the project, and avoids setting individual properties on most files and prevents errors from skipping properties when new files are introduced.
Hat-tip DJPaul. See r5770, #2802.
|
| [4683]
|
johnjamesjacoby
|
Set correct '_bbp_allow_global_access' default in settings template tag. Fixes issues with it being off on new installs.
|
| [4517]
|
johnjamesjacoby
|
Set defaults to suppress debug notices in bbp_get_forum_freshness_link(). Props jmdodd. Fixes #2058.
|
| [5066]
|
johnjamesjacoby
|
Set max-width on .form-allowed-tags to 100%. Improves theme compat, and fixes issues with allowed tags breaking theme output. Props kobenland.
|
| [3405]
|
johnjamesjacoby
|
Set overflow to auto on .bbp-topic-content and .bbp-reply-content.
|
| [2938]
|
johnjamesjacoby
|
Set query names on forums and replies widgets to prevent conflicts with user profile pages.
|
| [7021]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7020]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [3362]
|
johnjamesjacoby
|
Set the post_type to topic in bbp_pre_get_posts() when viewing a topic tag. Fixes issue where topics of tag were not visible in some installations. Fixes #1547. Props cnorris23.
|
| [4817]
|
johnjamesjacoby
|
Set the super_sticky text to an empty string rather than unset it, since it's currently expected to exist, and empty values will be filtered out anyways.
|
| [2490]
|
PeteMall
|
Set width for new columns and consolidate row_action functions.
|
| [3586]
|
johnjamesjacoby
|
Settings, functions, CSS, and template-tags necessary to use wp_editor() function, introduced in WordPress 3.3. See #1673.
|
| [4315]
|
johnjamesjacoby
|
Settings:
* Hide theme compat package selection setting if only 1 package is registered.
|
| [4018]
|
johnjamesjacoby
|
Settings:
* Register settings to page, not section ID.
* Fixes bug causing settings not save.
* Fixes #1862.
|
| [4016]
|
johnjamesjacoby
|
Settings:
* Remove duplicate 'page' array item from fields, and use 'page' from section parent.
* See #1862.
|
| [4100]
|
johnjamesjacoby
|
Settings:
* Remove redundant "Allow" verbiage.
* Fix punctuation.
|
| [4235]
|
johnjamesjacoby
|
Settings:
* Simplify role translation in bbp_admin_setting_callback_global_access().
* Prevents repeatedly reassigning new value to existing $default_role variable.
* See: r4234.
|
| [4058]
|
johnjamesjacoby
|
Settings:
* Smarter boundaries on new 'number' input types.
* See r4057.
|
| [4234]
|
johnjamesjacoby
|
Settings:
* Tweak verbiage to make it more clean what each setting does.
* Fixes confusion with "Global Access" and how it works.
* Fixes #1904.
|
| [4057]
|
johnjamesjacoby
|
Settings:
* Use 'number' input type where appropriate.
|
| [4020]
|
johnjamesjacoby
|
Settings:
* Use esc_sql to sanitize __bbp_topic_archive_slug setting.
|
| [4019]
|
johnjamesjacoby
|
Settings:
* Use esc_sql to sanitize _bbp_theme_package_id setting.
* Fixes #1862.
* Hat tip michelwppi.
|
| [4067]
|
johnjamesjacoby
|
Settings:
* Use integers in bbp_get_default_options() and friends, to avoid boolean conflict in get_option().
* See r4065.
|
| [4065]
|
johnjamesjacoby
|
Settings:
* Use isset() instead of !empty() in bbp_pre_get_option()
* Fix issue where settings would not properly override, due to get_option()'s pre filter looking for false, and not null.
|
| [6442]
|
johnjamesjacoby
|
Settings: Add `_allow_` settings for editing & flooding, and revise the verbiage.
This allows for flood checking & editing to be:
* Completely disabled
* Overridden via filters
* Editing allowed forever
* A bit more descriptive with additional context provided
|
| [6435]
|
johnjamesjacoby
|
Settings: Add a note to the `_bbp_show_on_root` setting if a forum archive template is found in the template stack.
Fixes confusion that would arise when using the `archive-forum.php` found in the `/extras/` directory.
Fixes #3081.
|
| [6070]
|
netweb
|
Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
|
| [6419]
|
johnjamesjacoby
|
Settings: General improvements:
* Use escaped equivalent for gettext output
* Update settings-integration away from `bool` to allow future flexibility
* Stash settings fields in a static variable to speed up registration
|
| [7089]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In branches/2.6, for 2.6.5.
|
| [7088]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In trunk, for 2.7.0.
|
| [6443]
|
johnjamesjacoby
|
Settings: Update Engagements setting description to better match others.
|
| [6444]
|
johnjamesjacoby
|
Settings: Update `int` handling of `bbp_past_edit_lock()`.
|