| [3227]
|
johnjamesjacoby
|
Sanity check on user roles to prevent error if user does not have a role assigned to them.
|
| [2817]
|
johnjamesjacoby
|
Sanity checks on logout redirection global variables
|
| [4203]
|
johnjamesjacoby
|
Scripts:
* Create empty .min files where warranted.
* Rejig green admin scheme CSS files to use .min.
|
| [6641]
|
johnjamesjacoby
|
Scripts: Do not enqueue if not `is_bbpress()`.
This reduces the number of external scripts that are enqueued on non-bbPress pages. Put another way, it makes sure that bbPress styles & scripts are only loaded on pages where bbPress content is known to exist.
Fibes #3138. Props DJPaul.
|
| [4618]
|
johnjamesjacoby
|
Search Tweaks:
* Add support for search root page.
* Add search root page to breadcrumb.
* Tweak search form CSS.
* See #1575.
|
| [7077]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
Fixes #3357. 2.6 branch, for 2.6.5.
|
| [7076]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
See #3357. Trunk, for 2.7.0.
|
| [6620]
|
johnjamesjacoby
|
Search: Escape output of `bbp_search_terms()` and wire-up to `ts` and `rs`.
|
| [6629]
|
johnjamesjacoby
|
Search: Use correct `rs` request key.
Fixes a debug notice when searching replies inside of topics.
|
| [6903]
|
johnjamesjacoby
|
Search: add support for `fs` query-arg to search forums list:
* Introduces `bbp_sanitize_search_request()` to encapsulate duplicate code across forums/topics/replies
* Introduces `bbp_get_search_type_ids()` to stub out future enhancements (tags, users, etc...)
* Use these new functions where intended
* Update `bbp_get_search_terms()` to loop through known search-type IDs
This commit also fixes debug notices that would happen when these query arguments were not explicitly strings.
Fixes #3245.
|
| [6630]
|
johnjamesjacoby
|
Search: move `bbp_allow_search()` checks into form template parts.
This allows the inclusion of those forms without needing to wrap each inclusion statement in its own feature check, making search a more atomic and isolated feature within bbPress.
It also should conclude the development of the user content search functionality.
Because this involves some template-part changes to the "Default" template pack, users who have opted to override these parts in their own themes will not receive these updates (nor should they.) This is a known consequence of including template parts in themes, so while still not an ideal system, will not result in any breakage for existing sites.
|
| [7262]
|
johnjamesjacoby
|
Search: prevent hidden forums from appearing in results.
This change includes the following changes:
* Removes `readable` perm check from `bbp_has_search_results()` and replaces it with public topic statuses by default, while conditionally adding private & hidden statuses if user is capable
* Tweaks the logic inside of `bbp_pre_get_posts_normalize_forum_visibility()` to always handle both of its internal conditions (forum query, or any query that includes forums/topics/replies connected via meta data)
* Tweaks output of `content-search.php` template part to not show the "Oh bother" error when visiting a search page for the first time
* Adds a string `feedback-no-search.php` template part to address both "no results" and "no terms" conditions
These changes address some faulty search logic that was allowing hidden forums to appear in global search results to users who should not have been able to see them, while also improving the search page experience itself.
Fixes #3473.
Props wpsolr, robin-w.
In branches/2.6, for 2.6.10.
|
| [7280]
|
johnjamesjacoby
|
Search: remove `array_keys()` from
This change ensures that the correct public statuses are used by default inside of the `bbp_has_search_results()` function, and it does this by using the values from `bbp_get_public_topic_statuses()` and not the keys.
This fixes a regression causing search results to omit public statuses as part of their default arguments.
Props GDragoN.
Fixes #3607.
|
| [6824]
|
johnjamesjacoby
|
Search: update `bbp_get_search_terms()` to only accept a string.
This change prevents non-string payloads from being encoded & trimmed.
|
| [3225]
|
johnjamesjacoby
|
Second round of bbPress standalone importer updates. Props !GautamGupta. See #1523.
|
| [3179]
|
johnjamesjacoby
|
Security sweep and code clean-up through bbp-reply-functions.php. See #1514.
|
| [3399]
|
johnjamesjacoby
|
Separate actions and filters in BBP_BuddyPress class. Introduce activity_can_comment() and activity_get_permalink() filters to force bbPress's activity stream items to behave exactly like they do currently with group forums.
|
| [3717]
|
johnjamesjacoby
|
Separate bbp-core-compatibility.php into smaller, less-confusing parts:
* bbp-theme-compatibility.php - the API that makes existing themes compatible
* bbp-template-functions.php - functions used to find and load bbPress templates
* bbp-template-loader.php - similar to the WordPress template loader, it handles the logic of what template to display
* Move commonly used functions into bbp-common-functions.php
* Update bbpress.php to require() new files
|
| [5080]
|
johnjamesjacoby
|
Separate content replacement from title replacement in forum and topic archives, allowing pages with matching slugs but empty post_content to replace the_content as expected. Fixes situation where a user creates a "Forums" page and leaves the content empty, expecting bbPress to replace it.
Also use the $page->ID to help "Edit" links to point to the correct post ID.
|
| [6628]
|
johnjamesjacoby
|
Separators: Normalize the `sep` arguments between functions.
This change also switches `bbp_list_forums()` to `implode()` links rather than concatenate the same `$output` string with an increasing number of items. This has the positive side-effect of moving the forum separator (a comma by default) out of individual links.
Props milindmore22. Fixes #2900.
|
| [3379]
|
johnjamesjacoby
|
Set $bbp->current_user as byref of $current_user.
|
| [3539]
|
johnjamesjacoby
|
Set $the_core_slugs static to empty array in bbp_form_slug_conflict_check()
|
| [5315]
|
johnjamesjacoby
|
Set `is_tax` to true when calling `bbp_theme_compaty_reset_post()` when viewing/editing a topic-tag. Fixes #2444.
|
| [5771]
|
johnjamesjacoby
|
Set `svn-autoprops`.
This was introduced in Subversion 1.8 specifically to allow common properties for all present and future files in the project, and avoids setting individual properties on most files and prevents errors from skipping properties when new files are introduced.
Hat-tip DJPaul. See r5770, #2802.
|
| [4683]
|
johnjamesjacoby
|
Set correct '_bbp_allow_global_access' default in settings template tag. Fixes issues with it being off on new installs.
|
| [4517]
|
johnjamesjacoby
|
Set defaults to suppress debug notices in bbp_get_forum_freshness_link(). Props jmdodd. Fixes #2058.
|
| [5066]
|
johnjamesjacoby
|
Set max-width on .form-allowed-tags to 100%. Improves theme compat, and fixes issues with allowed tags breaking theme output. Props kobenland.
|
| [3405]
|
johnjamesjacoby
|
Set overflow to auto on .bbp-topic-content and .bbp-reply-content.
|
| [2938]
|
johnjamesjacoby
|
Set query names on forums and replies widgets to prevent conflicts with user profile pages.
|
| [7021]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7020]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [3362]
|
johnjamesjacoby
|
Set the post_type to topic in bbp_pre_get_posts() when viewing a topic tag. Fixes issue where topics of tag were not visible in some installations. Fixes #1547. Props cnorris23.
|
| [4817]
|
johnjamesjacoby
|
Set the super_sticky text to an empty string rather than unset it, since it's currently expected to exist, and empty values will be filtered out anyways.
|
| [2490]
|
PeteMall
|
Set width for new columns and consolidate row_action functions.
|
| [3586]
|
johnjamesjacoby
|
Settings, functions, CSS, and template-tags necessary to use wp_editor() function, introduced in WordPress 3.3. See #1673.
|
| [4315]
|
johnjamesjacoby
|
Settings:
* Hide theme compat package selection setting if only 1 package is registered.
|
| [4018]
|
johnjamesjacoby
|
Settings:
* Register settings to page, not section ID.
* Fixes bug causing settings not save.
* Fixes #1862.
|
| [4016]
|
johnjamesjacoby
|
Settings:
* Remove duplicate 'page' array item from fields, and use 'page' from section parent.
* See #1862.
|
| [4100]
|
johnjamesjacoby
|
Settings:
* Remove redundant "Allow" verbiage.
* Fix punctuation.
|
| [4235]
|
johnjamesjacoby
|
Settings:
* Simplify role translation in bbp_admin_setting_callback_global_access().
* Prevents repeatedly reassigning new value to existing $default_role variable.
* See: r4234.
|
| [4058]
|
johnjamesjacoby
|
Settings:
* Smarter boundaries on new 'number' input types.
* See r4057.
|
| [4234]
|
johnjamesjacoby
|
Settings:
* Tweak verbiage to make it more clean what each setting does.
* Fixes confusion with "Global Access" and how it works.
* Fixes #1904.
|
| [4057]
|
johnjamesjacoby
|
Settings:
* Use 'number' input type where appropriate.
|
| [4020]
|
johnjamesjacoby
|
Settings:
* Use esc_sql to sanitize __bbp_topic_archive_slug setting.
|
| [4019]
|
johnjamesjacoby
|
Settings:
* Use esc_sql to sanitize _bbp_theme_package_id setting.
* Fixes #1862.
* Hat tip michelwppi.
|
| [4067]
|
johnjamesjacoby
|
Settings:
* Use integers in bbp_get_default_options() and friends, to avoid boolean conflict in get_option().
* See r4065.
|
| [4065]
|
johnjamesjacoby
|
Settings:
* Use isset() instead of !empty() in bbp_pre_get_option()
* Fix issue where settings would not properly override, due to get_option()'s pre filter looking for false, and not null.
|
| [6442]
|
johnjamesjacoby
|
Settings: Add `_allow_` settings for editing & flooding, and revise the verbiage.
This allows for flood checking & editing to be:
* Completely disabled
* Overridden via filters
* Editing allowed forever
* A bit more descriptive with additional context provided
|
| [6435]
|
johnjamesjacoby
|
Settings: Add a note to the `_bbp_show_on_root` setting if a forum archive template is found in the template stack.
Fixes confusion that would arise when using the `archive-forum.php` found in the `/extras/` directory.
Fixes #3081.
|
| [6070]
|
netweb
|
Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
|
| [6419]
|
johnjamesjacoby
|
Settings: General improvements:
* Use escaped equivalent for gettext output
* Update settings-integration away from `bool` to allow future flexibility
* Stash settings fields in a static variable to speed up registration
|
| [7089]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In branches/2.6, for 2.6.5.
|
| [7088]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In trunk, for 2.7.0.
|
| [6443]
|
johnjamesjacoby
|
Settings: Update Engagements setting description to better match others.
|
| [6444]
|
johnjamesjacoby
|
Settings: Update `int` handling of `bbp_past_edit_lock()`.
|
| [6564]
|
johnjamesjacoby
|
Settings: Use `$this->minimum_capability` in options page filter method.
This change keeps the filter inline with the mapped meta caps, should the minimum capability be renamed or changed.
|
| [6483]
|
johnjamesjacoby
|
Settings: cast `map_meta_caps` return value to an array.
|
| [6420]
|
johnjamesjacoby
|
Settings: remove directory path from option text.
|
| [6955]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6.
|
| [6954]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.7, trunk.
|
| [3779]
|
johnjamesjacoby
|
Setup default theme compatibility in bbPress::setup_theme()
* Sets early on bbp_setup_theme so functions and files can be included
* Still allows plugins to override earlier
* See #1766
|
| [3452]
|
johnjamesjacoby
|
Setup option filters earlier on bbp_init so plugins don't need to worry about load order. See r3451.
|
| [3445]
|
johnjamesjacoby
|
She seems to have an invisible touch, yeah. Fixes #1603. Props cnorris23.
|
| [6125]
|
johnjamesjacoby
|
Shh... I meant `bbp_translate_user_role()`.
See r6121.
|
| [5069]
|
johnjamesjacoby
|
Shift output escaping around in admin links to allow for filtering and passing additional HTML into them. Hat tip mourdak. Fixes #2090.
|
| [4586]
|
jmdodd
|
Shortcode iteration for search introduced in #1575.
* Fix bbp-search shortcode.
* Introduce bbp-search-form shortcode.
* Fixes #2107.
|
| [4295]
|
johnjamesjacoby
|
Shortcodes:
* Fix incorrect post_type reference in shortcodes inline doc.
* Fixes #2003.
|
| [4296]
|
johnjamesjacoby
|
Shortcodes:
* Fix incorrect post_type reference in widgets inline doc.
* Fixes #2007.
|
| [4212]
|
johnjamesjacoby
|
Shortcodes:
* Move shortcode registration into bbPress class to mirror other internal dependencies.
* Introduce bbp_register_shortcode() function, hooked to 'bbp_register'
|
| [5957]
|
netweb
|
Shortcodes: Fix `@return` type shring/string typo in `display_stats()`
|
| [5956]
|
netweb
|
Shortcodes: Remove superfluous `@param` PHPDoc instances from various shortcode functions
Props casiepa.
|
| [2484]
|
PeteMall
|
Show forum title, description and topic count on forums admin page.
|
| [3231]
|
johnjamesjacoby
|
Show hidden forums in the admin all list.
|
| [2888]
|
johnjamesjacoby
|
Show the forum of super sticky topics when outside of the forum the sticky belongs in.
|
| [7087]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In branches/2.6, for 2.6.5.
See #3157.
|
| [7086]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In trunk, for 2.7.0.
See #3157.
|
| [5466]
|
johnjamesjacoby
|
Simpify `ABSPATH` checks to pass coding standard sniffers that look for brackets on comparisons.
|
| [5547]
|
netweb
|
SimplePress 5:
* Fix regression introduced in r5349 where topics were imported a second time as part of the reply section import.
* Fix reply parent forum ID mini cache callback to use `callback_forumid`
* Add topic author IP address to topics import section
|
| [5151]
|
netweb
|
SimplePress Importer Improvements. Props netweb. Fixes #2194
* Add reply slug field mapping
* Add custom regex for non-break spaces in HTML
|
| [4615]
|
johnjamesjacoby
|
Simplify favorites link logic and output, to match subscriptions link functionality. Fixes #2118.
|
| [2595]
|
johnjamesjacoby
|
Simplify load sequence.
|
| [4226]
|
johnjamesjacoby
|
Simplify password reset hint text.
|
| [5513]
|
johnjamesjacoby
|
Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.
|
| [4999]
|
johnjamesjacoby
|
Since search requests get existing data, and do not post new data, revert part of r4997 and switch request method back to "get".
Add hidden 'action' field to form-search.php template-part, and move 'bbp_search_results_redirect' action from 'bbp_post_request' to 'bbp_get_request'.
Fixes issue with request not redirecting properly, and uses more accurate form method. See #2337.
|
| [4216]
|
johnjamesjacoby
|
Single topics:
* Force is_home to false in bbp_has_replies()
* Maybe set is_single to true if viewing a single topic.
* Fixes bug where WP_Query::parse_query() incorrectly assumes is_home() when multiple post_types are queried.
* Fixes #1947.
|
| [2468]
|
johnjamesjacoby
|
Singular slugs and add reply slug
|
| [3161]
|
johnjamesjacoby
|
Singular/Plural fixes on forum and topic descriptions. Fixes #1515. Props !GautamGupta.
|
| [2469]
|
johnjamesjacoby
|
Singular/plural filter fixes (see r2468)
|
| [3649]
|
johnjamesjacoby
|
Slight performance improvements to author display_name. See #1704.
|
| [5512]
|
johnjamesjacoby
|
Slightly refactor `bbp_format_buddypress_notifications()`:
* Return original `$action` if not `bbp_new_reply`.
* Reduce indentation to accommodate new `$action` check.
This fixes a bug where checking for new reply notifications could cause future notification filter checks to fail.
Props Faison. Fixes #2665.
|
| [2467]
|
johnjamesjacoby
|
Slug fixes
|
| [6966]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.6.2, branches/2.6.
|
| [6967]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.7, trunk.
|
| [2681]
|
johnjamesjacoby
|
Smart redirect on new reply in the event new reply creates new topic page
|
| [5394]
|
johnjamesjacoby
|
Smarter ancestor detection in `BBP_Walker_Reply_Dropdown`. See #2617.
|
| [5286]
|
johnjamesjacoby
|
Smarter build/src toggling for the stub plugin. See #2542.
|
| [5908]
|
johnjamesjacoby
|
Sniffer: Whitespace around variables in arrays.
|
| [5514]
|
netweb
|
So `.gitignore` is whitespace sensitive. If you include trailing whitespace, git won't recognize your files.
|
| [2883]
|
johnjamesjacoby
|
Some adjustments to bbp-topic-template.php. Allow capable users to view trashed or private topics on request. Use new author_link function in topic revisions. Do not return a no-break space in bbp_get_topic_admin_links.
|
| [2772]
|
johnjamesjacoby
|
Sort by menu_order on forums widget
|