| [7292]
|
johnjamesjacoby
|
Replies: Fix a bug that causes replies to not appear in some topics.
In WordPress 6.8, `WP_Query` now enforces a consistent alphabetical order for array values. This change breaks the `_bbp_has_replies_where()` function, which previously relied on a strict comparison against `post_type`.
See: https://core.trac.wordpress.org/ticket/59516
This commit replaces the strict comparison with an `array_diff()` check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to `$query->get()`.
Props @vortfu.
Committed to the 2.6 branch for 2.6.13.
See #3631.
|
| [7293]
|
johnjamesjacoby
|
Replies: Fix a bug that causes replies to not appear in some topics.
In WordPress 6.8, `WP_Query` now enforces a consistent alphabetical order for array values. This change breaks the `_bbp_has_replies_where()` function, which previously relied on a strict comparison against `post_type`.
See: https://core.trac.wordpress.org/ticket/59516
This commit replaces the strict comparison with an `array_diff()` check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to `$query->get()`.
Props vortfu, arl1nd.
Committed to trunk for 2.7.
Fixes #3631.
|
| [5924]
|
netweb
|
Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5880]
|
netweb
|
Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
|
| [5889]
|
netweb
|
Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
|
| [6396]
|
johnjamesjacoby
|
Replies: Invert the `$show_none` comparison, to fix the default drop-down text.
Props SergeyBiryukov. Fixes #2617.
|
| [6621]
|
johnjamesjacoby
|
Replies: Normalize `bbp_has_replies()` default search with `bbp_has_topics()`.
This brings parity to how these two functions handle default search parameters.
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [5891]
|
netweb
|
Replies: Remove previous `menu_order` default from `bbp_insert_reply()` missed in r5889
Antiprops netweb. See #2843.
|
| [7139]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In branches/2.6, for 2.6.6. See #3379.
|
| [7138]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In trunk, for 2.7. See #3379.
|
| [6979]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6.
|
| [6980]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk.
|
| [6246]
|
johnjamesjacoby
|
Replies: Update `bbp_thread_replies()` to skip user profile pages.
* Move from core/options to replies/functions, since this isn't directly an option
* Add `! bbp_is_single_user_replies()` check to force `false` if so
* Update threaded replies pagination to re-include verbiage.
Fixes #3002.
|
| [6721]
|
johnjamesjacoby
|
Replies: Update tests for `test_bbp_get_reply_position()`.
This change makes sure that updating a reply position to zero is still possible, also ensuring that tests continue to pass as expected.
|
| [7178]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In branches/2.6 for 2.6.7. See #3366.
Props immeet94.
|
| [7177]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In trunk for 2.7.0. See #3366.
Props immeet94.
|
| [7180]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In branches/2.6 for 2.6.7. Fixes #3386.
|
| [7179]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In trunk for 2.7.0. See #3386.
|
| [7011]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6.
|
| [7010]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.7, trunk.
|
| [6965]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.6.2, branches/2.6.
|
| [6964]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.7, trunk.
|
| [5859]
|
johnjamesjacoby
|
Replies: fallback on `post_parent` in `bbp_update_reply_walker()`.
This changeset fixes a bug where topic reply counts were not updated when replies were permanently deleted, causing hidden reply counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [7147]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In branches/2.6, for 2.6.6. See #3385.
|
| [7148]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In trunk, for 2.7. Fixes #3385.
|
| [7174]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In branches/2.6 for 2.6.7. Fixes #3327.
Props mjonesnerdery.
|
| [7173]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In trunk for 2.7.0. See #3327.
Props mjonesnerdery.
|
| [6427]
|
johnjamesjacoby
|
Replies: fix incorrect inline doc in `bbp_current_user_can_access_create_reply_form()`.
|
| [6706]
|
johnjamesjacoby
|
Replies: introduce `bbp_get_public_reply_statuses()` to speed-up reply queries.
This change removes the `closed` post status from several reply-only queries, ensuring that query indexes are used effectively. It also brings parity to the Replies component that exists in both Forums & Topics.
|
| [6717]
|
johnjamesjacoby
|
Replies: performance optimization to `bbp_update_reply_position()`.
This change uses `wpdb::update()` instead of `wp_update_post()` and juggles the `bbp_clean_post_cache()` filter, retaining object caches of related posts and queries, and also removes other unintended `edit_post` action interference.
Fixes #3169.
|
| [7140]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In branches/2.6, for 2.6.6. See #3409.
|
| [7142]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In trunk, for 2.7. Fixes #3409.
|
| [7131]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In branches/2.6, for 2.6.6.
See #3385.
|
| [7130]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In trunk, for 2.7.
See #3385.
|
| [7141]
|
johnjamesjacoby
|
Replies: remove unintended duplicate array_filter() call from r7140.
|
| [6096]
|
johnjamesjacoby
|
Replies: use `appendChild` vs. `insertBefore` for inline JS replies.
Fixes #2971. Props r-a-y.
|
| [7323]
|
johnjamesjacoby
|
Replies: use `bbp_get_reply_url()` instead of `bbp_get_reply_to_link()`.
This change ensures that reply-to links work outside of the single-topic context (user profiles, search pages, etc...)
Props gdragon.
In branches/2.6, for 2.6.14.
Fixes #3595.
|
| [7322]
|
johnjamesjacoby
|
Replies: use `bbp_get_reply_url()` instead of `bbp_get_reply_to_link()`.
This change ensures that reply-to links work outside of the single-topic context (user profiles, search pages, etc...)
Props gdragon.
In trunk, for 2.7.
Fixes #3609.
|
| [7242]
|
johnjamesjacoby
|
Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In branches/2.6, for 2.6.10.
Props mdjwel via GitHub pull request.
|
| [7241]
|
johnjamesjacoby
|
Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In trunk, for 2.7.0.
Props mdjwel via GitHub pull request.
|
| [6826]
|
johnjamesjacoby
|
Replies: use existing `reply_to` value if none is passed.
This change fixes a bug that would cause the reply hierarchy to be broken when non-moderator users would edit their existing replies within the allotted editing period.
Props wpdennis. Fixes #3205.
|
| [3274]
|
johnjamesjacoby
|
Reply "View" action link should link to reply URL and not the permalink for the reply, since not all themes will support single reply views. Unset the "View" link if user is viewing trash and does not have proper caps.
|
| [3934]
|
johnjamesjacoby
|
Reply Position Improvements:
* Add _update_ and _raw functions for reply positioning.
* Use these functions through-out the codebase as needed.
* Maintains the existing bbp_get_reply_position() behavior, so it's backwards compatible.
* Fixes #1840.
|
| [3941]
|
johnjamesjacoby
|
Reply Position/URL:
* Always cast the return value of bbp_get_reply_position() as an integer.
* See #1842.
|
| [3940]
|
johnjamesjacoby
|
Reply Position/URL:
* Updates to bbp_get_reply_url() to simplify some logic.
* Move $wp_rewrite global to only where it's needed.
* Move reply position bump to bbp_get_reply_position().
* Fixes #1842. Props WCMKE.
|
| [3938]
|
johnjamesjacoby
|
Reply Position:
* Fix issue with new reply_position logic when posting a rew reply.
* Bump the position by one if lead topic is in the replies loop.
* Fixes #1841.
|
| [4277]
|
johnjamesjacoby
|
Reply Titles:
* Attribute 'maxlength' not allowed on hidden fields.
* See #1996.
|
| [4748]
|
johnjamesjacoby
|
Reprioritize autoembeds to before make_clickable(), to fix broken autoembeds. Fixes #2192.
|
| [4656]
|
johnjamesjacoby
|
Reprioritize revision log appending filters to 99, to avoid possibly escaping the full HTML output. Fixes #2131.
|
| [7016]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.6.3, branches/2.6.
|
| [7017]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.7, trunk.
|
| [3089]
|
johnjamesjacoby
|
Reset the img.avatar float to none for theme compat
|
| [3394]
|
johnjamesjacoby
|
Reset the post data at the end of each have_posts loop.
|
| [3087]
|
johnjamesjacoby
|
Reset the post data in the _unset_globals() shortcode function
|
| [6759]
|
johnjamesjacoby
|
Reset: DRY out the `bbp_admin_reset_database()` logic.
This change introduces a helper function for running queries and producing user feedback based on those results. It also introduces a `Skipped` result if the query is invalid or empty. Ultimately, this results in fewer repeated lines of code, fewer reused local variables, and an easier to understand code flow.
An old, leftover routine for removing `forum-mod` taxonomy terms was also removed, as that approach was abandoned during the 2.6 development cycle but was missed when other refactoring was done.
|
| [2818]
|
johnjamesjacoby
|
Resetting EOL style to native through-out plugin branch.
|
| [3083]
|
johnjamesjacoby
|
Resort rules in bbPress::generate_rewrite_rules()
|
| [5013]
|
johnjamesjacoby
|
Responsive styling to default templates. Huge props mercime. Fixes #1933.
|
| [5617]
|
netweb
|
Restore PHP 5.2 to Travis CI
* Travis restored PHP 5.2 support late last week.
Fixes #2753
|
| [3535]
|
johnjamesjacoby
|
Retagging 0.9.0.7 (See r3435)
|
| [3532]
|
johnjamesjacoby
|
Retagging 1.1 (See r3529)
|
| [6936]
|
johnjamesjacoby
|
Retro TV styling for contributor avatars. 📺
|
| [3700]
|
johnjamesjacoby
|
Return passed value if not applicable in bbp_admin_custom_menu_order()
|
| [4736]
|
johnjamesjacoby
|
Reverse single/double quote usage in bbp_mention_filter(); also use sprintf() to place variable data. See #2185.
|
| [2533]
|
johnjamesjacoby
|
Reverse tabindexes on login form for rememberme and submit.
|
| [3470]
|
johnjamesjacoby
|
Reverse the admin.css and admin-2.css relative image depth.
|
| [2761]
|
johnjamesjacoby
|
Revert r2759 and correct path in r2755. Props westi
|
| [3206]
|
johnjamesjacoby
|
Revert 3139. Move .pot file back into bbp-languages folder for improved GlotPress integration. Props vanillalounge, westi.
|
| [4780]
|
johnjamesjacoby
|
Revert WordPress 3.6 slash-compat. See r4771, #WP21767.
|
| [2855]
|
mdawaffe
|
Revert a piece of [2800]. bbPress (unlike WordPress), uses term taxonomy IDs as tag IDs instead of term IDs.
I cannot reproduce the reported destroy tag bug, but I would not be surprised if there are still some bugs around this term taxonomy ID v. term ID mess.
See #1353
|
| [5062]
|
johnjamesjacoby
|
Revert accidental change to bbp_remove_roles() from r5060.
|
| [5063]
|
johnjamesjacoby
|
Revert accidental change to forum query 'orderby' args from r5060.
|
| [5602]
|
johnjamesjacoby
|
Revert accidental line-change from r5601, #2747.
|
| [5061]
|
johnjamesjacoby
|
Revert accidental removal of threaded replies dropdown pre-option disabled check from r5060.
|
| [4980]
|
johnjamesjacoby
|
Revert accidental test field change from r4979. See #1999.
|
| [2605]
|
johnjamesjacoby
|
Revert accidentally deleted uninstall procedure from r2604
|
| [4492]
|
johnjamesjacoby
|
Revert back to compact() in statistics.
|
| [3820]
|
johnjamesjacoby
|
Revert bbp-twentyten back to table based layout:
* bbp-theme-compat retains tableless layout, and is canonical backup for missing template files
* Avoid back-compat issues with installs that have modified bbPress 2.0 CSS
* Fixes #1796
|
| [4476]
|
johnjamesjacoby
|
Revert clear removal on topic and reply lists. Force none in profiles. Fixes #1964 (2.2 branch)
|
| [4475]
|
johnjamesjacoby
|
Revert clear removal on topic and reply lists. Force none in profiles. Fixes #1964 (trunk)
|
| [3615]
|
johnjamesjacoby
|
Revert cruft from bbp_get_forum_edit_template() from r3614.
|
| [4130]
|
johnjamesjacoby
|
Revert debug cruft from r4127.
|
| [4129]
|
johnjamesjacoby
|
Revert debug cruft from r4128.
|
| [2748]
|
johnjamesjacoby
|
Revert extra voice-counts in single-bbp_topic.php that reappeared in r2746
|
| [5360]
|
johnjamesjacoby
|
Revert indentation change in r5357. Props netweb. See: http://yaml.org/spec/1.2/spec.html#id2777534
|
| [2474]
|
chrishajer
|
Revert mistakenly changed db-version. Props !GautamGupta
|
| [3085]
|
johnjamesjacoby
|
Revert most of r3054. $wp_query needs to be explicitly checked to guarantee we are not checking the $post global from a different internal loop.
Change from post_meta based _bbp_visibility to custom forum post status for private and hidden forums. This allows for easier exclusion without the need for slower meta queries. Add wp_reset_postdata() through-out loop and template files where the post global might have been altered by an external plugin. Add bbp_exclude_forum_ids() function, to explicitly exclude forums based on user capabilities.
|
| [2573]
|
johnjamesjacoby
|
Revert part of 2572.
|
| [2941]
|
johnjamesjacoby
|
Revert part of r2940 and instead use bbp_is_forum() to check if 'any' or bbp_get_forum_id() should be used in default post_parent in bbp_has_topics()
|
| [3299]
|
johnjamesjacoby
|
Revert part of r3195. Fixes #1532. Props GautamGupta.
|
| [3497]
|
johnjamesjacoby
|
Revert part of r3487 and use post_parent for Akisment permalink parameter.
|
| [3601]
|
johnjamesjacoby
|
Revert part of r3600 and change logic. See #1678. (2.1)
|
| [3725]
|
johnjamesjacoby
|
Revert part of r3703 as it was causing comment forms and page edit links to reappear in some themes. Instead, introduce bbp_reset_post_data() and use it when the_content has been replaced and the $post global has been unset.
|
| [3937]
|
johnjamesjacoby
|
Revert part of r3936 and use correct parent class for reply permalinks.
|
| [4599]
|
johnjamesjacoby
|
Revert part of r4594, and move #post ID to bbp-reply-header element. Fixes regression with not being taken to #post-ID on reply publish and edit.
|
| [5000]
|
johnjamesjacoby
|
Revert part of r4995 that introduced strict comparisons in bbp_get_time_since() against return values of floor(), which returns a float. See #2358.
|
| [5124]
|
johnjamesjacoby
|
Revert part of r5060. Fixes issues with setting forum statuses. Props netweb. (2.4.1)
|
| [5165]
|
johnjamesjacoby
|
Revert part of r5164 that moved the `$r` array within a `bbp_is_forum_category()` check in `bbp_get_forum_subscription_link()`, as it caused debug notices from `$r` not being defined. See #2475.
|