[4023]
|
johnjamesjacoby
|
Nonces:
* Introduce bbp_verify_nonce_request() to check nonces on theme-side requests.
* See #1863.
|
[4024]
|
johnjamesjacoby
|
Nonces:
* Use bbp_verify_nonce_request() to prevent the awkward wp_die() experience in forums.
* Add nonce checks to subscriptions and favorites.
* More aggressive returns on edit/new forum/topic/reply nonce and capability checks. Prevents surplus processing when we already know nothing more should happen.
* Bail early if bbp_has_errors() rather than wrapping around it.
* Fixes #1863.
|
[5403]
|
johnjamesjacoby
|
Normalize Favorite and Subscribe links for Forums and Topics so they are visually linear to the breadcrumb. Hat-tip netweb. Fixes #2575.
|
[2905]
|
johnjamesjacoby
|
Normalize all post_meta values by removing the _forum, _topic, and _reply prefixes off of them where appropriate. There is no point in having them be unique to the post type as it only duplicates the code needed to perform requests. Future trimming to follow.
Introduce bbp-update.php file, which is used to update existing installations to the new meta_key names from this revision.
|
[3312]
|
johnjamesjacoby
|
Normalize archive pages and include content-archive template parts for topics and forums.
|
[2812]
|
johnjamesjacoby
|
Normalize bbp-includes directory. Mostly documentation fixes. Introduce bbp-shortcodes placeholder.
|
[2810]
|
johnjamesjacoby
|
Normalize bbp-twentyten theme files. Introduce bbp_tab_index functions for forms. Rename some page- files to action- since they are not page templates. Introduce bbp_login and bbp_register place-holders in bbp-twentyten theme.
|
[5060]
|
johnjamesjacoby
|
Normalize forum, topic, and reply dropdown form fields and associated functions. Includes several new functions with _get_ equivalents to replace incorrectly named _select() functions.
First pass at adding custom topic status handling. Props jkudish. See #2187.
Also replaces $wpdb->update() calls with wp_update_post() in associated functions. Fixes #2351.
|
[5399]
|
johnjamesjacoby
|
Normalize metabox UI across Forums, Topics, & Replies. Hat-tip netweb. Fixes #2463.
|
[4733]
|
johnjamesjacoby
|
Normalize svn props for .php files, and add missing index.php to /includes/search/ directory.
|
[2863]
|
johnjamesjacoby
|
Normalize tag management files. Use bb_die() where applicable. Swap out destroy_tag verbiage to comply with boolean delete_term results.
|
[3233]
|
johnjamesjacoby
|
Normalize the user template files. Add wrapper around user.php template content.
|
[4991]
|
johnjamesjacoby
|
Normalize topic and reply admin method names. Some of them were still prefixed from back when all admin methods were in 1 mega-class.
|
[7186]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In branches/2.6 for 2.6.7. Fixes #3414.
Props dilipbheda, isabel104.
|
[7185]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In trunk for 2.7.0. See #3414.
Props dilipbheda, isabel104.
|
[3996]
|
johnjamesjacoby
|
Notifications (1.1 branch):
* Check post_status before notifying subscribers, in bb_notify_subscribers().
* Fixes #1479.
* Props jkudish.
|
[4739]
|
johnjamesjacoby
|
Now that mentions are in bbPress core, remove the extra mention code in the BuddyPress activity extension. Fixes #2185.
|
[4258]
|
johnjamesjacoby
|
Number Formatting:
* Introduce $integer parameter to template-tags to switch filter for integer usage.
* Use absint() where appropriate when getting counts.
* Smarter int type casting.
* Fixes bug where calculations were being done against formatted strings.
* Fixes #1974.
|
[3858]
|
johnjamesjacoby
|
Number format fixes:
* Introduce bbp_number_format_i18n
* Clean up number format filters
* Allow empty $number values to be passed safely
|
[3447]
|
johnjamesjacoby
|
Obey the blacklisted keys in discussion settings when creating or editing topics or replies. Introduces bbp_check_for_blacklist() function in bbp-common-functions.php, and bbp_current_user_ua() in bbp-user-functions.php.
|
[4723]
|
johnjamesjacoby
|
On single forum view, do not check for forum count when trying to query sub forums. Fixes #2085.
|
[5468]
|
johnjamesjacoby
|
Only add the `s` argument to global forum search queries if search-terms exist.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804].
|
[5467]
|
johnjamesjacoby
|
Only add the `s` argument to queries if `rs` or `ts` are set in their respective topics & replies queries.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804].
|
[5510]
|
johnjamesjacoby
|
Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.
This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270.
|
[5081]
|
johnjamesjacoby
|
Only allow topics to have an archive when the forums archive is showing forums (not topics). Fixes SEO concern where it was possible to have duplicate forum-archives at two different URL's.
|
[3881]
|
johnjamesjacoby
|
Only allow users that can edit other users to change a users role, and do not allow them to change their own role.
|
[3880]
|
johnjamesjacoby
|
Only allow users that can edit other users to change a users role.
|
[3879]
|
johnjamesjacoby
|
Only apply borders to top of elements in theme compat, for consistency sake.
|
[3597]
|
johnjamesjacoby
|
Only bail if forums are installed correctly.
|
[3849]
|
johnjamesjacoby
|
Only enqueue parent theme CSS if parent theme is twentyten.
|
[3806]
|
johnjamesjacoby
|
Only exclude private/hidden forum content in feeds when not viewing a single forum. Fixes #1782.
|
[3930]
|
johnjamesjacoby
|
Only filter shortcode queries if query is not already set. Also, use correct filter names.
|
[5132]
|
johnjamesjacoby
|
Only filter the `bbpress` textdomain with the `bbpress_locale` filter.
Clean up surrounding phpdoc.
|
[3381]
|
johnjamesjacoby
|
Only overload global access caps if user does not have existing caps.
|
[4879]
|
johnjamesjacoby
|
Only remove filters if bbp_use_wp_editor() is true. See #2317. (2.3 branch)
|
[4880]
|
johnjamesjacoby
|
Only remove filters if bbp_use_wp_editor() is true. See #2317. (trunk)
|
[4681]
|
johnjamesjacoby
|
Only show BuddyPress Group settings section when viewing bbPress settings for a BuddyPress root blog. Note that using bp_is_root_blog() includes support for BuddyPress's Multiblog mode.
|
[4960]
|
johnjamesjacoby
|
Only show allowed tags when not using the fancy editor or user does not have unfiltered_html cap. Also remove function_exists() check for wp_editor().
|
[6095]
|
johnjamesjacoby
|
Only show reply-to drop-down when editing an existing reply.
|
[2616]
|
johnjamesjacoby
|
Only show topic admin links if user has caps
|
[3476]
|
johnjamesjacoby
|
Only use at_name filters when BuddyPress activity component is active.
|
[3949]
|
johnjamesjacoby
|
Options:
* Pinking shears on bbp_get_default_options().
* Remove db_version duplicate description.
|
[4193]
|
johnjamesjacoby
|
Options:
* Visually section off user slugs in bp_get_options().
|
[4208]
|
johnjamesjacoby
|
Options:
* Wrap some options loops in array_keys() to prevent making unnecessary $value variables.
|
[6072]
|
netweb
|
Options: Fix `bbp_show_on_root()` copy pasta PHPDoc description
|
[6078]
|
netweb
|
Options: Set the default value of `bbp_get_user_slug()` to `users`
This changeset updates the default single user slug from `user` to `users`. The `bbp_get_default_options()` function defines the default as `users` and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug `user` rather than `users`.
Props ocean90.
Fixes #2983
|
[6761]
|
johnjamesjacoby
|
Options: Use new `$intercept` value in place of old `$strategy` value.
This change fixes an undefined variable debug notice introduced in r6751.
|
[6762]
|
johnjamesjacoby
|
Options: allow default option cache strategy to be filtered, without causing an intercept.
This change brings filter behavior back that was unintentionally removed in r6751.
|
[6695]
|
johnjamesjacoby
|
Options: break `Features` out from `Settings` section.
This change makes it easier to discern which options are features, and which are settings for those features.
Also updates the inline descriptions for several array items.
|
[6694]
|
johnjamesjacoby
|
Options: set default database version to `0`.
This change avoids race conditions with the updater when no version exists in the database. This would cause the database version to not be bumped, resulting in rewrite rules being needlessly flushed on each visit to `wp-admin`.
(Also tweak some nearby array values to make them easier to read.)
|
[2496]
|
johnjamesjacoby
|
Output value, not array
|
[4871]
|
johnjamesjacoby
|
Overload the code tag in the fancy editor, and use backticks instead. Props mzaweb. (2.3 branch)
|
[4872]
|
johnjamesjacoby
|
Overload the code tag in the fancy editor, and use backticks instead. Props mzaweb. (trunk)
|
[3429]
|
johnjamesjacoby
|
Override canonical redirect when editing topics and replies. Fixes #1594.
|
[6451]
|
johnjamesjacoby
|
Où mettre!
|
[5048]
|
johnjamesjacoby
|
PHP 5.4 compat and related sanity checks and clean-up. Props boonebgorges. Fixes #2731.
|
[5089]
|
johnjamesjacoby
|
PHP 5.4+ E_STRICT improvement to BuddyPress Groups display_forums() method. See #BP5108.
|
[7115]
|
xknown
|
PHP 7.4 Compat: Don't use curly braces for array/string access
|
[7114]
|
xknown
|
PHP 7.4 Compat: Remove deprecated functions.
|
[7111]
|
xknown
|
PHP 7.4 Compat: Remove the create_function calls.
They are deprecated, and they seem to be removed in PHP 8.0.
|
[7116]
|
xknown
|
PHP 7.4 Compat: Replace the deprecated create_function calls with anonymous functions.
|
[7110]
|
xknown
|
PHP 7.4 Compat: Use square brackets and remove create_function calls.
|
[7113]
|
xknown
|
PHP 7.4 Compat: remove deprecated functions.
|
[7112]
|
xknown
|
PHP 7.4 compat: Replace the deprecated each call
|
[3829]
|
johnjamesjacoby
|
PHP5'ize bbp-core-classes.php.
|
[7253]
|
johnjamesjacoby
|
PHP8: define dependency injected components in BBP_Admin
This change prevents debug warnings in modern versions of PHP (8.0 and higher).
In branches/2.6, for 2.6.10.
|
[7049]
|
netweb
|
PHPCS: Pinking shears.
Props jrf.
See #3294.
For branches/2.6.
|
[7048]
|
netweb
|
PHPCS: Pinking shears.
Props jrf.
See #3294.
For trunk.
|
[7047]
|
netweb
|
PHPCS: Use Parenthesis when instantiating a new object.
Props jrf.
See #3294.
For branches/2.6.
|
[7046]
|
netweb
|
PHPCS: Use Parenthesis when instantiating a new object.
Props jrf.
See #3294.
For trunk.
|
[7254]
|
johnjamesjacoby
|
PHPCS: correct return var types in Revisions functions
This change fixes PHPCS/Intelephense warnings.
In branches/2.6, for 2.6.10.
|
[5515]
|
netweb
|
PHPDdoc corrections for topic and reply pending status approve and unapprove functions. See #2645
|
[4322]
|
johnjamesjacoby
|
Pagination:
* Fix bug where topics started, favorites, and subscriptions pagination would link to the root of a users profile.\
* Fixes incorrect filters on topics and replies URL's.
|
[6228]
|
johnjamesjacoby
|
Pagination: Use `preg_replace` to find & remove `page=1` query arguments.
Fixes #2702. Props thebrandonallen, tharsheblows.
|
[6680]
|
johnjamesjacoby
|
Pagination: abstract and normalize common functionality.
This change introduces a few new helper functions, and audits the links generated where loops of forums, topics, and replies are made visible. It addresses a number of edge-cases in the pagination code, including:
* `view=all` state not carrying over
* Total-page boundary maybe using the wrong value to calculate the total number of available pages
* Inconsistent output of values across post types and shortcodes
* Inability to filter pagination arguments in certain use cases
* Reduces code repetition and increases general happiness
Trunk, for 2.6.
|
[6300]
|
johnjamesjacoby
|
Pagination: prefer `intval()` for numeric values, and always format numbers used for display.
|
[6398]
|
johnjamesjacoby
|
Parenthesis clean-up.
|
[6887]
|
johnjamesjacoby
|
Parser: Fix PHP 7.3 warning ("continue" in "switch" is equal to "break")
Fixes #3242.
|
[6418]
|
netweb
|
Parser: PHP 7.1 compatibility fixes to `parser.php`
Props xknown.
See #2973, #2987.
Merges [6212] to the 2.5 branch.
|
[6212]
|
johnjamesjacoby
|
Parser: PHP 7.1 compatibility fixes to `parser.php`
Props xknown. Fixes #2973. See #2987.
|
[6888]
|
johnjamesjacoby
|
Parser: revert error control operator change from r6887.
See also r6633 for original change.
|
[4775]
|
johnjamesjacoby
|
Pass $r instead of $args in ending filters. Ensures correct array of arguments is available to filters. These were skipped as part of #2056. Props alex-ye. Fixes #2218.
|
[3548]
|
johnjamesjacoby
|
Pass $reply_id correctly into bbp_get_reply_id() in bbp_notify_subscribers()
|
[5391]
|
johnjamesjacoby
|
Pass `$reply_id` into calls to `bbp_validate_reply_to()` and remove `reply_query` references in `BBP_Walker_Reply_Dropdown`. Fixes invalid `bbp_reply_id` value output in `form-reply.php`. See #2617.
|
[5486]
|
johnjamesjacoby
|
Pass `$topic_id` and `$forum_id` to relevant favorites and subscriptions filters. Hat tip DJPaul. Fixes #2651.
|
[6552]
|
johnjamesjacoby
|
Pass `$type` into favs & subs link arguments. Missed in r6551.
|
[4915]
|
johnjamesjacoby
|
Pass an empty array into bbp_parse_args() in bbp_search_query().
|
[4789]
|
johnjamesjacoby
|
Pass complete content into activity stream items. Create excerpt on output rather than input. Fixes #2237.
|
[4515]
|
johnjamesjacoby
|
Pass more variables into freshness link filters. Props jbobich. Fixes #1983.
|
[3781]
|
johnjamesjacoby
|
Pass param to bbp_get_template_locations() to allow locations to be filtered based on templates being queried. See #1766.
|
[3011]
|
johnjamesjacoby
|
Pass the forums current visibility through to the functions responsible for changing them. This prevents querying post_meta and object cache for current visibility state, helpful for removing from private and hidden forum site meta.
|
[3113]
|
johnjamesjacoby
|
Pass topic-tag as array for compliance with shortcode attributes. Add topic-tag tax check to bbp_has_topics() before resetting post data.
|
[6558]
|
johnjamesjacoby
|
Passwords: Upgrade the user-edit experience to use the new'ish password generator.
* Introduces new `form-user-passwords.php` template part to encapsulate the more-elaborate password mark-up
* Removes `user.js` from the default scripts, and enqueues `user-profiles` instead
* Requires tweaks to the default template pack styling to accommodate the password generator being theme-side
This change will also allow bbPress to more easily keep-up with changes to the password generator code that comes with WordPress going forward. Huzzah!
|
[4262]
|
johnjamesjacoby
|
Paths:
* Remove "bbp-" prefixes on root level directories.
* Rename 'themes' to 'templates' to discourage clever people from putting "themes" in there.
* Update paths and URLs in bbpress.php.
|
[3431]
|
johnjamesjacoby
|
Perform correct cap check in bbp_forum_enforce_private(). See #1576 and r3430.
|
[4059]
|
johnjamesjacoby
|
Performance:
* Add 'numeric' to applicable meta-queries to avoid casting as char.
* Remove meta-queries, and use post_parent where possible.
* Introduce _bbp_has_replies_where() filter, attached to 'posts_where' which is responsible for adding the lead topic to the results. This avoids having to use a costly meta-query, potentially resulting in full table scans.
* Audit meta-queries, and tweak where needed.
* Fixes #1885.
* Props vibol for investigation.
|
[4061]
|
johnjamesjacoby
|
Performance:
* Filter 'posts_request' to allow use of FORCE INDEX when replies are queried that should include the topic post also.
* See: #1885, r4059.
|
[6544]
|
johnjamesjacoby
|
Performance: Last pass at 2.6 performance tuning.
* Keep a local cache of non-options that aren't in the database, to avoid multiple database misses for options we know aren't in the database after `wp_load_alloptions()` is called
* Stop getting all favorite IDs and subscription IDs when checking if a user has favorited or subscribed to something, because these queries are expensive joins that are difficult to cache & invalidate
* Consolidate forum/topic favorites & subscriptions logic back into central routers, to make it easier to handle taxonomy term subscriptions in the future, and remove nested filter calls that make the call-stack confusing
* Informally deprecate some forum & topic specific fav/sub functions
* Rename one of the engagements remove functions to better match existing naming pattern
* Typo fixes & general code quality improvements
* Bump slow tests threshold up to `500` for now, and we can bring back down later (my 12" MacBook runs this pretty slowly, so I'd like to play with this more)
* Unit tests are all passing, and more quickly, maybe surprisingly
This should result in around 20 fewer database hits on non-persistent-cache sites, on average. When viewing single topics & replies, this will result in more than 25 fewer database hits.
|
[5954]
|
netweb
|
Performance: Replace direct SQL queries with `WP_Query()` objects in the following functions:
* `bbp_update_forum_topic_count()`
* `bbp_update_forum_topic_count_hidden()`
* `bbp_update_forum_reply_count()`
* `bbp_get_public_child_last_id()`
* `bbp_get_public_child_count()`
* `bbp_get_public_child_ids()`
Props johnjamesjacoby.
See #1799.
|
[6853]
|
johnjamesjacoby
|
Permalinks: merge root-slug usage into whichever is shown on root.
This change removes the double-archive juggle of having both forums and topics available as archives at the same time, which is traditionally not desirable.
|