[6835]
|
johnjamesjacoby
|
Login: Do not prematurely escape `$redirect_to` in `bbp_logout_url()`.
This change fixes a bug causing the redirect URL to be escaped before it's encoded.
Props nevis2us. Fixes #3199.
|
[6863]
|
johnjamesjacoby
|
Login: Updates to `bbp_logout_url()`:
* Removes Apache-only `REDIRECT_URL` usage
* Defaults to the Referer (for smart redirects)
* Adds a filter to the redirect_to string
* Validates the redirect_to after being filtered
* Falls back to `bbp_get_root_url()` if invalid
* Ensures that custom `$redirect_to` values are preserved
Fixes #2188.
|
[2621]
|
johnjamesjacoby
|
Look in 'bbpress' subfolder of WP_LANG_DIR for global language files
|
[2503]
|
chrishajer
|
Loop correctly through term objects; pass objects by reference. Fixes #1313. Props to bobrick
|
[3917]
|
johnjamesjacoby
|
Main Class:
* Mark main bbPress class as final, and some methods as static.
|
[4659]
|
johnjamesjacoby
|
Make .bbp-author-name elements display inline-block, to allow them to properly center in the available space.
|
[7034]
|
johnjamesjacoby
|
Make CSS linter happy again.
|
[7033]
|
johnjamesjacoby
|
Make CSS linter happy again.
|
[5821]
|
johnjamesjacoby
|
Make a statement without saying a word. (!)
|
[2524]
|
johnjamesjacoby
|
Make admin theme links a little brighter green.
|
[2538]
|
johnjamesjacoby
|
Make bbPress admin area style links less minty.
|
[4753]
|
johnjamesjacoby
|
Make bbp_add_forums_roles() return the $wp_roles global, for future use when looking for the WP_Roles object later.
|
[2656]
|
johnjamesjacoby
|
Make error message ambiguous since it is also used in non-forum contexts
|
[2660]
|
johnjamesjacoby
|
Make favorites work without needing AJAX. Add Topics Created to author page. Adjust some CSS. Rename favorite links to permalinks. Clean up author.php.
|
[3170]
|
johnjamesjacoby
|
Make forums settings section descriptions more verbose. Separate root slug section from single slugs. Add section for future RSS feed topics/replies per page.
|
[4997]
|
johnjamesjacoby
|
Make search results page use pretty permalinks if they are enabled:
* Change search form method from "get" to "post"
* Move 'bbp_search_request_redirect' action to 'bbp_post_request' to avoid recursion.
* Tweak bbp_search_request_redirect() to check for pretty permalinks, and remove now superfluous recursion checks.
* See #2337.
|
[3786]
|
johnjamesjacoby
|
Make sure _is_*_edit_ template tags work in wp-admin
* Fixes issue with saving topic sticky value from wp-admin
* Fixes issue saving forum and reply metabox values on some installs
|
[3804]
|
johnjamesjacoby
|
Make sure all (3) parameters are passed through to new_reply_redirect_to filter.
|
[4860]
|
johnjamesjacoby
|
Make sure moderators have the 'view_trash' capability. Fixes bug where moderators would hit a 404 after trashing a topic. Fixes #2307 (2.3 branch)
|
[4859]
|
johnjamesjacoby
|
Make sure moderators have the 'view_trash' capability. Fixes bug where moderators would hit a 404 after trashing a topic. Fixes #2307 (trunk)
|
[3801]
|
johnjamesjacoby
|
Make sure that group ID and forum ID are cross-saved when creating the base group forum.
* Fixes #1779
* Props boonebgorges for initial patch
|
[5006]
|
johnjamesjacoby
|
Make sure that topics and replies in private/hidden forums are excluded from the "insert links" dialogue window. Hat tip jaredatch. See #2334.
|
[3896]
|
westi
|
Make sure the redirect url is a string before we try and handle it.
|
[3802]
|
johnjamesjacoby
|
Make sure to only return a single value in bbp_get_forum_group_ids()
* Fixes #1780
* Props boonebgorges
|
[3810]
|
johnjamesjacoby
|
Make sure topic tags appear on single topics and replies. Props jaredatch. Fixes #1791.
|
[4560]
|
johnjamesjacoby
|
Make sure topic/reply titles are always set in statistics shortcode and dashboard metabox. Fixes #2087.
|
[3090]
|
johnjamesjacoby
|
Make the img.avatar CSS a little more specific so not to conflict with most blog posts, comments, widgets, etc...
|
[2946]
|
johnjamesjacoby
|
Make the updater check for version numbers greater than what is set in the DB. Alligator open to the left John; to the left.
|
[2545]
|
johnjamesjacoby
|
Make times play nicely with each other.
|
[4716]
|
johnjamesjacoby
|
Map group forum meta caps directly to 'bbp_map_meta_caps' filter to avoid recursion. Also remove BuddyPress 'topic' action check, to allow single group-forum capability map to work correctly. Fixes #2140.
|
[2783]
|
johnjamesjacoby
|
Map read_ caps for forums/topics/replies. Also revert r2779 since we remove the moderator role completely. Props !GautamGupta via Google Code-in
|
[3392]
|
johnjamesjacoby
|
Map to 'do_not_allow' cap if user is marked as spam or deleted. Fixes #1568. Props sorich87.
|
[5175]
|
johnjamesjacoby
|
Mass hysteria. See #1889.
|
[5560]
|
johnjamesjacoby
|
Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.
|
[4408]
|
johnjamesjacoby
|
Member's Forums:
* Update "Topics Replied To" to "Replies Created."
* Reference correct template to mirror bbPress functionality in !BuddyPress profiles.
|
[4323]
|
johnjamesjacoby
|
Mentions:
* Add username @-mention filters.
* Automatically links to profiles when @username is used in a topic or reply content area.
|
[6346]
|
johnjamesjacoby
|
Mentions: Add classes and basic styling to mention clickable callback.
Fixes #3074. See #meta-2542.
|
[6382]
|
johnjamesjacoby
|
Mentions: Add tests for square and round brackets.
See #2963.
|
[6380]
|
johnjamesjacoby
|
Mentions: Balance tags before making things clickable.
Then, make mentions clickable without "requiring" prepending whitespace. This allows other types of characters to be immediately before the `@` control character.
See #2963.
|
[6381]
|
johnjamesjacoby
|
Mentions: Move topic/reply content filters into the same section of `filters.php`.
Also add `wp_make_content_images_responsive` filter, to match core content areas.
See #2963.
|
[6014]
|
johnjamesjacoby
|
Mentions: Refactor the way user mentions are discovered and linked.
* Adds a filter to `bbp_make_clickable`
* Adds filters for for previously hard-coded clickables
* Adds new filter for at-mention clickable
* Deprecates previous functions for finding & linking at-mentions
For 2.6 (trunk). Hat-tip to Daniel Cid.
|
[6015]
|
johnjamesjacoby
|
Mentions: Refactor the way user mentions are discovered and linked.
This is a port of r6014 (without unit tests) for the 2.5 branch.
* Adds a filter to bbp_make_clickable
* Adds filters for for previously hard-coded clickables
* Adds new filter for at-mention clickable
* Deprecates previous functions for finding & linking at-mentions
For 2.5.9 (2.5 branch). Hat-tip to Daniel Cid.
|
[7275]
|
johnjamesjacoby
|
Merge 2.6 improvements into trunk.
From 2.6.11.
|
[7268]
|
johnjamesjacoby
|
Merge r7250 through r7267 from branches/2.6.
In trunk, for 2.7.
|
[4786]
|
johnjamesjacoby
|
Merge topic/reply author with attributes metabox save action. Fixes bug causing freshness time to be incorrectly updated from within the dashboard. Props alex-ye. Fixes #2229.
|
[4423]
|
johnjamesjacoby
|
Merge updated bbpress.pot file into trunk for 2.2.
|
[6949]
|
johnjamesjacoby
|
Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.6.1, branches/2.6.
|
[6948]
|
johnjamesjacoby
|
Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.7, trunk.
|
[6296]
|
johnjamesjacoby
|
Meta: Filter `_count_int` and enforce integer values.
Also use convenience functions for forum post counts, to ensure proper filters are ran against all meta values.
See #3059.
|
[6297]
|
johnjamesjacoby
|
Meta: Missed `bbp_get_user_topic_count_int` in r6296.
Props @thebrandonallen. See #3059.
|
[7149]
|
johnjamesjacoby
|
Meta: always query meta_value by string, not by integer.
This commit swaps "%d" for "%s" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In branches/2.6, for 2.6.6. See #3408.
|
[7150]
|
johnjamesjacoby
|
Meta: always query meta_value by string, not by integer.
This commit swaps "%d" for "%s" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In trunk, for 2.7. Fixes #3408.
|
[6197]
|
johnjamesjacoby
|
Metaboxes: Add metaboxes for viewing favorites & subscriptions of topics & replies.
* New functions for outputting avatars of users who have favved or subbed
* Use the `$post` parameter that's passed in, rather than using `get_the_ID()` again
* Use `require_once` as a language construct vs. `include_once()` as a function
* Pass `$post` object through to metabox subsequent filters vs just the ID
See #2959.
|
[6200]
|
netweb
|
Metaboxes: Update `@since` revisions for functions introduced in r6197.
See #2959.
|
[6769]
|
johnjamesjacoby
|
Metaboxes: parse arguments passed into `BBP_Topic_Replies_List_Table()` constructor.
This allows conditional filtering & overloading of what the Replies list table displays.
|
[6770]
|
johnjamesjacoby
|
Metaboxes: show non-public replies in topic-replies meta/list box.
This shows trashed/spam replies to capable users when editing a topic via WordPress admin, because if you're moderating a topic from here, chances are high you want to see everything - not just public replies.
|
[3292]
|
johnjamesjacoby
|
Mind any existing meta queries. Fix regression introduced in r3291.
|
[4857]
|
johnjamesjacoby
|
Minify default CSS files (2.3 branch)
|
[5492]
|
johnjamesjacoby
|
Missed a 'Reply To' reply title update. See r5490.
|
[2522]
|
johnjamesjacoby
|
Missed a few spots...
|
[3102]
|
johnjamesjacoby
|
Missed a spot from r3098. Fixes possible empty reply_content error when editing a reply.
|
[5361]
|
johnjamesjacoby
|
Missed a spot.
|
[2767]
|
johnjamesjacoby
|
Missed a spot. See r2765.
|
[3577]
|
johnjamesjacoby
|
Missed a spot. Swap @public for @var. See r3576
|
[5562]
|
johnjamesjacoby
|
Missed removing a tabindex usage. See #2714.
|
[3965]
|
johnjamesjacoby
|
Missed two EOF ?> in index.php files. See r3964; #1850.
|
[6139]
|
johnjamesjacoby
|
Moderation: /s/exists/missing
See #3032.
|
[6138]
|
johnjamesjacoby
|
Moderation: Add error message if reply could not be found or no longer exists.
See #3032.
|
[6050]
|
netweb
|
Moderation: Add new `bbp_moderation_keys` and `bbp_blacklist_keys` filters
This changeset allows external plugins to filter the list of moderation and blacklist keyword terms, IP, URLs, words, etc.
Also cleans up `bbp_check_for_moderation()` to bails early if there are no moderation keys inline with `bbp_check_for_blacklist()`
Props thebrandonallen, satollo.
Fixes #2861.
|
[6146]
|
netweb
|
Moderation: Add some missing PHPDoc `@since` revisions
See #3032.
|
[6384]
|
johnjamesjacoby
|
Moderation: Allow per-forum moderators to edit topics & replies inside of forums they have moderation control over.
This feature require the following changes:
* Prefer `read_forum` capability check over `read_private_forums` or `read_hidden_forums`, and include a `$forum_id` parameter to assist `map_meta_cap` filters
* Prefer `edit_others_topics|replies` over `moderate` where appropriate, to ensure capability mappings work as intended
* Introduce `bbp_get_public_topic_statuses()` to replace several duplicate occurrences of the same array usage (also allow these to be filtered)
* Introduce `bbp_is_topic_public()` (not to be confused with `bbp_is_topic_published()`) to provide parity with `bbp_is_forum_public()` and also utilize `bbp_get_public_topic_statuses()` from above
* Add local caching to `bbp_exclude_forum_ids()` as a performance optimization to reduce the depth of `current_user_can()` calls when private & hidden forums are in use
* Add `user_can( 'moderate' )` capability checks to various mappings, to ensure forum moderators can read/edit/delete content inside of the individual forums they are moderators of
* Use `bbp_get_user_id()` where appropriate, rather than casting as `int`
* Various surrounding code clean-ups
See #2593.
|
[6349]
|
netweb
|
Moderation: Autoprefixer follow up to [6348] and [6344]
See #3073.
|
[6348]
|
netweb
|
Moderation: CSS coding standards fixes follow up after [6344]
See #3073.
|
[6342]
|
johnjamesjacoby
|
Moderation: Clean-up from r6341. Props netweb.
|
[6133]
|
johnjamesjacoby
|
Moderation: First pass at improved reply toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums & Topics @todo)
|
[6142]
|
johnjamesjacoby
|
Moderation: First pass at improved topic toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums @todo)
|
[5841]
|
johnjamesjacoby
|
Moderation: Fix some copy-pasta and make sure form terms are formatted correctly. See #459.
|
[6344]
|
johnjamesjacoby
|
Moderation: Implement theme-side edit-lock interface.
* Edits to defaut theme javascript to interact with alert UI
* Add `alert-topic-lock.php` template part
* Add topic functions relating to edit-lock functionality
* Modify single-topic and topic-edit template parts to include the alert part
* Add CSS to Default template pack to stylize edit-lock alert like a modal (could be pretty much anything)
Props pippin for inspiration. See #3074.
|
[6085]
|
netweb
|
Moderation: Include topic and reply post content with and without HTML in `moderation_keys` and `blacklist_keys` checks.
This changeset ensures users cannot bypass the moderation word checks by wrapping parts of the word or term in HTML, e.g. `bannedword` could previously be bypassed using `<em>banned</em>word`
Fixes #2986.
|
[6312]
|
johnjamesjacoby
|
Moderation: Maybe add `view=all` query-arguments to view links in row actions.
Fixes #2938.
|
[6136]
|
johnjamesjacoby
|
Moderation: Move `sub_action` query var into a passable argument, so all actions can have reliable sub-action usage.
See #3032.
|
[6137]
|
johnjamesjacoby
|
Moderation: Pass `$reply_id` into `bbp_get_reply_toggles()` so the exacty reply ID can be referenced directly at the time of the filter.
See #3032.
|
[6134]
|
johnjamesjacoby
|
Moderation: Rename function to `bbp_get_reply_toggles()` to better match existing naming scheme.
See #3032.
|
[6087]
|
johnjamesjacoby
|
Moderation: Skip moderator query if per-forum moderation is not enabled.
Props jmdodd. Fixes #2988.
|
[6341]
|
johnjamesjacoby
|
Moderation: Use the appropriate `_edit_` post meta when editing a forum/topic/reply.
This first pass does not introduce any theme-side edit-locking interface, but it will warn any user within `wp-admin` if another user is editing something theme-side.
See #3073.
|
[6858]
|
johnjamesjacoby
|
Moderation: add author-specific keymaster & moderation checks.
This fixes a regression where Moderators were allowed to skip strict moderation rules. Moderators are held to the same standard that regular users in the forums are.
See #3215.
|
[6857]
|
johnjamesjacoby
|
Moderation: allow custom keys to be passed in via the `$strict` parameter.
See #3215.
|
[6974]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
[6973]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
[6921]
|
johnjamesjacoby
|
Moderation: make sure pending topics (for moderation reasons) are accessible to authors.
This commit updates the logic inside of the topic & reply map-meta-cap implementations, restricting edit-lock checks to actual "Edit" screens, and using the "edit_others_posts" capability in non-"Edit" screens, ensuring that both scenarios are covered.
It also adds an explicit condition for Pending Topics to both the Topic Description and Topic Notices, alerting users as to why they are seeing what they are seeing.
Fixes #3253 (again!) See also #3164 for other related discussion & details.
|
[6754]
|
johnjamesjacoby
|
Moderation: pass `$content` into `comment_max_links_url` filter.
This changes brings parity to changes made in WordPress 4.7.0.
Fixes #3141.
|
[5853]
|
johnjamesjacoby
|
Moderation: reduce moderation restriction from `keep-gate` to `moderate` in `bbp_check_for_moderation()`.
This changeset ensures that moderators are able to bypass the forum moderation, seeing as how they can self-approve topics & replies anyways.
Props netweb. Fixes #2726.
|
[6855]
|
johnjamesjacoby
|
Moderation: remove references to blacklist/whitelist verbiage.
This change combines 2 functions into 1, merging `_blacklist()` checks into `_moderation()` checks. A new `$strict` parameter is added, when set to `true` will continue to check against the WordPress `blacklist_keys` option name.
* Tests updated
* `bbp_check_for_blacklist()` deprecated
* Error response keys renamed (non breaking - nothing relies on them)
* Some docs updates
Fixes #3215. For 2.6.
|
[7234]
|
johnjamesjacoby
|
Moderation: use the correct `post_status` when untrashing a topic/reply.
This change fixes a bug/regression (since WordPress 5.6.0) that was causing untrashed topics & replies to use an unintended `post_status` value.
It fixes it by adding a new function ('bbp_fix_untrash_post_status()') and hooking it to the `wp_untrash_post_status` filter in WordPress, and overriding the results as needed.
Props r-a-y.
In branches/2.6 for 2.6.10. Fixes #3433.
|
[7235]
|
johnjamesjacoby
|
Moderation: use the correct `post_status` when untrashing a topic/reply.
This change fixes a bug/regression (since WordPress 5.6.0) that was causing untrashed topics & replies to use an unintended `post_status` value.
It fixes it by adding a new function ('bbp_fix_untrash_post_status()') and hooking it to the `wp_untrash_post_status` filter in WordPress, and overriding the results as needed.
Props r-a-y.
In trunk for 2.7.0. Fixes #3433.
|
[7123]
|
johnjamesjacoby
|
Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In branches/2.6, for 2.6.6.
Props SergeyBiryukov.
See #3133.
|
[7122]
|
johnjamesjacoby
|
Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In trunk, for 2.7.
Props SergeyBiryukov.
See #3133.
|
[6519]
|
johnjamesjacoby
|
Moderators: Add an `$object_type` parameter to add/remove/delete functions.
In a future release, this will more easily allow objects like taxonomy-terms to have their own moderators, and is also necessary for future enhancements to the WordPress.org support forums where custom taxonomies are used for prevalently than in bbPress core currently.
See #3068, #459.
|
[5836]
|
johnjamesjacoby
|
Moderators: Add forum moderators field to `form-forum.php` template part. See #459.
|
[5862]
|
netweb
|
Moderators: Add missing @since PHPDoc missed in `bbp_map_forum_mod_meta_caps()` via r5834
|