| [6357]
|
netweb
|
Forums: Add missing `@since` PHPDoc to `bbp_list_forums()`
|
| [5683]
|
johnjamesjacoby
|
Forums: Audit `template.php`:
* General code formatting improvements
* Pass `$args` into more filters
* Escape more gettext output
* Un-nest a few complex-looking lines
|
| [6414]
|
johnjamesjacoby
|
Forums: Audit private/hidden forum ID exclusion:
* improve performance of `bbp_exclude_forum_ids()`
* Use `bbp_exclude_forum_ids()` where duplicate code existed
* Make sure `$forum_ids` are passed into `bbp_exclude_forum_ids` filter
* Prefer arrays over imploded strings (also with post statuses)
|
| [7052]
|
johnjamesjacoby
|
Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.6.4, branches/2.6.
|
| [7051]
|
johnjamesjacoby
|
Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.7, trunk.
|
| [7085]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In branches/2.6, for 2.6.5.
See #3374.
|
| [7084]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In trunk, for 2.7.0.
See #3374.
|
| [5855]
|
johnjamesjacoby
|
Forums: Fix copy-pasta filter names.
This changeset corrects filters used in 2 `apply_filters()` calls to properly match their function names.
Props netweb. Fixes #2688.
|
| [5655]
|
netweb
|
Forums: Fix missing meta data during new forum creation
* Call `bbp_open_forum()` if the forum is "open" to add the forum `_bbp_status` = `open` meta
* Call `bbp_normalize_forum()` if the forum is a "forum" to add the forum `_bbp_forum_type` = `forum` meta
Props netweb. Fixes #2647
|
| [7320]
|
johnjamesjacoby
|
Forums: Improve targeting of `bbp_pre_get_posts_normalize_forum_visibility` filter.
This change ensures that forum (post) IDs are only excluded from queries where intended, and specifically not when querying for attachments on draft posts & pages.
Props shawfactor, sirlouen.
In branches/2.6, for 2.6.14.
Fixes #3609.
|
| [7321]
|
johnjamesjacoby
|
Forums: Improve targeting of `bbp_pre_get_posts_normalize_forum_visibility` filter.
This change ensures that forum (post) IDs are only excluded from queries where intended, and specifically not when querying for attachments on draft posts & pages.
Props shawfactor, sirlouen.
In trunk, for 2.7.
Fixes #3609.
|
| [5923]
|
netweb
|
Forums: Improve type-casting in forum functions.
Props thebrandonallen. See #2801.
|
| [6315]
|
johnjamesjacoby
|
Forums: Introduce `bbp_list_forums_subforum_classes` filter, to allow filtering of sub-forum links.
Props gordielachance. Fixes #2760.
|
| [5856]
|
johnjamesjacoby
|
Forums: Introduce `bbp_update_forum_visibility` action in `bbp_save_forum_extras()`
This changeset provides custom visibilites with an execution point to perform their own actions.
Fixes #2740.
|
| [5731]
|
johnjamesjacoby
|
Forums: Normalize type-casting in some count functions. More to do here.
Props thebrandonallen, netweb. See #2801.
|
| [6020]
|
netweb
|
Forums: Overzealous type coercion caused `bbp_forum_query_last_reply_id()` to skip the database query in every instance (since 0 is never === false). As such, the resetting of `_bbp_last_reply_id` got short-circuted in some cases.
This fix is for the 2.5 branch, `/trunk` fixed this inadvertantly in [5954]
Props boonebgorges, mauteri.
Fixes #2414.
|
| [5734]
|
johnjamesjacoby
|
Forums: Type-cast improvements to `bbp_forum_query_last_reply_id()`.
Fixes bug where strict `false` comparison would cache cache condition to never occur.
Props thebrandonallen, netweb. See #2801.
|
| [6733]
|
netweb
|
Forums: Update `bbp_untrash_forum_topics()` PHPDoc description.
Props espellcaste.
Fixes #3175.
|
| [5918]
|
netweb
|
Forums: Updated PHPDocs and unit tests for `bbp_update_forum_last_*()` functions.
Props thebrandonallen. Fixes #2811
|
| [6024]
|
johnjamesjacoby
|
Forums: Updates to `bbp_list_forums()`:
* Always run filter, even over empty output
* Only wrap output if not empty
* Ensure that `$count` related variables are accurately reset during each loop iteration
* Surrounding code clean-up
Fixes #2951.
|
| [6576]
|
johnjamesjacoby
|
Forums: Use `bbp_get_forum_subforum_count()` in `bbp_forum_get_subforums()`.
This performance optimization will result in 1 less query per forum in the forums list that does not have subforums, by checking the subforum meta-data before trying to query for subforums that do not exist anyways.
This is less of an issue with a persistent object cache, but those without that luxury can now save those database queries for when they really matter.
|
| [6559]
|
johnjamesjacoby
|
Forums: Use `edit_forum` instead of `keep_gate` in the admin toggle/row methods.
This change trusts the `edit_forum` meta capability to serve it's intended purpose. It also allows more flexibility with things like BuddyPress Group Forums or custom forum-ownership style extensions.
|
| [6545]
|
johnjamesjacoby
|
Forums: Use `no_found_rows` by default in `bbp_has_forums()`
Forums do not currently support pagination, so the total number of rows is not traditionally useful for this loop. In cases where it is, it can be explicitly overloaded in the `$args` array.
This results in 1 less database query per page where a forums list is shown, and a speed improvement overall.
|
| [7272]
|
johnjamesjacoby
|
Forums: bail out of `pre_get_posts` if empty `post_type` parameter
This change addresses a regression inside of `bbp_pre_get_posts_normalize_forum_visibility` that was unintentionally targeting posts queries that were not sourced from the ones built into bbPress (forum/topic/reply), causing the majority of non-bbPress queries to return empty results.
Fixes #3601.
In branches/2.6, for 2.6.11.
|
| [6480]
|
johnjamesjacoby
|
Forums: be strict in `array_search()` calls.
|
| [7300]
|
johnjamesjacoby
|
Forums: cast return value of `post__not_in` as array.
This change avoids a potentially fatal PHP error if that query variable is a string.
Props rollybueno.
In branches/2.6, for 2.6.14.
Fixes #3636.
|
| [7299]
|
johnjamesjacoby
|
Forums: cast return value of `post__not_in` as array.
This change avoids a potentially fatal PHP error if that query variable is a string.
Props rollybueno.
In trunk, for 2.7.
Fixes #3636.
|
| [7331]
|
johnjamesjacoby
|
Forums: fix meta-key typo in `bbp_get_forum_topic_count_hidden()`
This change replaces `_bbp_topic_reply_count_hidden` with `_bbp_total_topic_count_hidden` which is the intended name of the meta-key.
Props sirlouen.
In branches/2.6, for 2.6.14.
Fixes #3611.
|
| [7330]
|
johnjamesjacoby
|
Forums: fix meta-key typo in `bbp_get_forum_topic_count_hidden()`
This change replaces `_bbp_topic_reply_count_hidden` with `_bbp_total_topic_count_hidden` which is the intended name of the meta-key.
Props sirlouen.
In trunk, for 2.7.
Fixes #3611.
|
| [6718]
|
johnjamesjacoby
|
Forums: make sure topic & reply counts are proper integers for `_n()` usage.
This change fixes a bug where formatted strings would cause an incorrect singular and plural string assignment, in forums that had over 1k posts.
|
| [7342]
|
johnjamesjacoby
|
Forums: prevent PHP warnings on singular bbPress pages when post ID's are not set.
This change adds checks for empty `$wp_query->post->ID` before using it inside of `bbp_forum_enforce_private()` and `bbp_forum_enforce_hidden()`.
In branches/2.6, for 2.6.15.
Fixes #3644.
|
| [7341]
|
johnjamesjacoby
|
Forums: prevent PHP warnings on singular bbPress pages when post ID's are not set.
This change adds checks for empty `$wp_query->post->ID` before using it inside of `bbp_forum_enforce_private()` and `bbp_forum_enforce_hidden()`.
In trunk, for 2.7.
Fixes #3644.
|
| [6875]
|
johnjamesjacoby
|
Forums: protect against a missing/malformed `forum_id` value when listing subforums.
Fixes #3232.
|
| [6860]
|
johnjamesjacoby
|
Forums: revert default mark-up back to div's and span's in `bbp_list_forums()`.
This fixes potentially invalid mark-up from attempting to use list elements instead of spans.
Also includes changes to CSS selectors to make them more flexible with different child elements.
See #3217.
|
| [6872]
|
johnjamesjacoby
|
Forums: revert part of r6860.
Go back to `ul` and `li` to avoid breaking CSS for existing installs, and use a CSS separator instead to address the original invalid markup issues.
This might show an extra separator in circumstances where filters or template-overrides are targeting very specific things, but that's better than breaking mark-up changes.
See #3217.
|
| [7008]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.6.3, branches/2.6.
|
| [7009]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.7, trunk.
|
| [7346]
|
johnjamesjacoby
|
Forums: swap out `bbp_is_user_keymaster()` check for `moderate` capability when checking the `edit_forums` and `edit_others_forums` mapped forum caps.
This commit fixes a bug that was causing the top-level admin-area "Forums" menu to not appear for logged in users who were assigned the "Moderator" role.
Moderators are intended to be like Editors, capable of moderating all forum-specific content. Sometimes that includes editing forum titles, descriptions, slugs, or creating a new forum and moving a bunch of existing topics into it.
Note: this change is largely a visual one, as Moderators have had the ability to edit forums since bbPress 2.2 when BuddyPress Group Forum support was added, if they already had the edit URL.
In trunk, for 2.7.
Fixes #3646.
|
| [2974]
|
johnjamesjacoby
|
Full audit of user/topic/reply/view permalinks. Use $wp_rewrite->using_permalinks() method in place of $wp_rewrite->permalink_structure. See r2973
|
| [6102]
|
netweb
|
General - Administration: Add i18n text domain missed in [6101]
See #2246.
|
| [6055]
|
netweb
|
General - Administration: Add pending status topic and reply statistics to `bbp_get_statistics()`
Following the introduction of "pending" status topics and replies in bbPress 2.6, `bbp_get_statistics()` now includes these count statistics in the hidden topic and reply statistics.
Fixes #2958.
|
| [6101]
|
netweb
|
General - Administration: Introduce bulk actions to spam and unspam topics and replies in wp-admin
This Friday #yolo changeset comes care of the upcoming WordPress 4.7 release via #WP16031 / wp:changeset:38647
Props jmdodd.
See #2246.
|
| [6061]
|
netweb
|
General - Administration: Update "change forum role" dropdown
This changeset resolves an issue introduced in WordPress 4.4 ( [WP:changeset:34636] / #WP27743 ) which caused bbPress "change forum role" dropdown to only work using the "bottom" user list table dropdown, for WordPress versions < 4.6 the "change forum role" dropdown is now only shown at the "top" of the user list table.
This changeset also adds a new parameter `$which` to `user_role_bulk_dropdown()` which was added in WordPress 4.6 ( [WP:changeset:37422] / #WP35307 ) to pass the location of the extra table nav markup for the "top" or "bottom" "change role" dropdown, and in turn fixes bbPress' "change forum role" dropdown to once again work at the "top" and "bottom" of the user list table.
Props ocean90.
Fixes #2906.
|
| [7382]
|
johnjamesjacoby
|
General - Administration: add "loaded" hooks to admin classes.
This change allows third-party plugins access to various class objects after they are loaded, specifically their `$this` references in their related `setup_actions()` methods.
In trunk, for 2.7.
Fixes #3660.
|
| [6036]
|
netweb
|
General Performance: Introduce increase/decrease helper count functions
Previously when a new topic or reply was created, a bunch of queries to recalculate the topic and reply counts for topics and forums were ran. Now these have been replaced with more efficient increase/decrease helper functions to get the current value and just "bump" the count based on the action (new topic-reply/split-topic/move-topic/spam-trash-topic/etc...)
Props thebrandonallen, tharsheblows, netweb
See #1799
|
| [6046]
|
netweb
|
General: Add debug trace to `bbp_setup_current_user()` notice.
Previously, the `bbp_setup_current_user was called incorrectly` notice would not output any useful info for developers.
This commit adds a debug trace so developers are able to determine
whereabouts in the codebase this notice is originating from.
Props r-a-y
Fixes #2932
|
| [6499]
|
johnjamesjacoby
|
General: Audit `wp_insert_post()` usages.
Return a `WP_Error` object in some instances, and explicitly do not in others.
Where possible, use the error message in the user feedback response.
Fixes #2817.
|
| [6839]
|
johnjamesjacoby
|
General: Bump to RC6, and related unimpactful changes
* Docs & whitespace
* Update packages
* Update stable tag
* Add changelog section for 2.6 (TBD)
|
| [6371]
|
netweb
|
General: Following [6366] use a single blank line for end-of-file extras templates.
See #3078.
|
| [6361]
|
netweb
|
General: Improve verbiage for closed forum and closed topic template notices.
This changeset also adds a template notice to the reply form noting that the forum you're posting to is closed to new content.
Props @SergeyBiryukov.
Fixes #3076.
See also #2353-meta.
|
| [6554]
|
johnjamesjacoby
|
General: Introduce `bbp_pre_handle_404()` to handle 404 overrides.
This only introduces the function for now. I'll go through and check all of the conditions next.
See #3047.
|
| [6627]
|
johnjamesjacoby
|
General: Make sure object `_get_` functions reach intended filters.
This retains existing behavior of bailing early and returning `null` if there is a `post_type` mismatch. Other similar functions would pass the `null` value through to the filter. These may do that eventually, but let's get these filters working first.
Fixes #3130.
|
| [6284]
|
johnjamesjacoby
|
General: Remove `()` around `require` construct calls, and breathing room around some `!` usages.
|
| [6366]
|
johnjamesjacoby
|
General: Remove end-of-file `?>` tags from extra templates.
These templates are theme drop-ins, and apparently were missed in previous clean-up efforts.
Props milindmore22. Fixes #3078.
|
| [6113]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
Fixes #2987.
|
| [6417]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
See #2987.
Merges [6113] to the 2.5 branch.
|
| [6437]
|
johnjamesjacoby
|
General: Tidying from looking into #2876.
|
| [6691]
|
netweb
|
General: Update changelog date format in `readme.txt`
This changeset is a follow up to [6689].
See https://wordpress.slack.com/archives/C02RQBYSJ/p1505079124000051
|
| [5684]
|
johnjamesjacoby
|
General: Use `sanitize_text_field()` in lieu of old-bbPress style pre-escaping technique.
|
| [7054]
|
johnjamesjacoby
|
General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.6.4, branches/2.6.
|
| [7055]
|
johnjamesjacoby
|
General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.7, trunk.
|
| [7053]
|
johnjamesjacoby
|
General: fix a few typos.
Props ankitmaru, mukesh27. Fixes #3312, #3313, #3315. For 2.7, trunk.
|
| [7056]
|
netweb
|
General: fix a few typos.
Props passoniate, wpamitkumar, sharaz.
Fixes #3308, #3316, #3317, #3319, #3323.
|
| [6272]
|
johnjamesjacoby
|
General: hyphenate "meta-box" in documentation to sooth spell-checkers.
|
| [6684]
|
johnjamesjacoby
|
General: more PHP7.1 array fixes.
See #3031. 2.5 branch, for 2.5.14.
|
| [6866]
|
johnjamesjacoby
|
General: unslash IP and user agent strings.
These are only used in ways where slashed values are undesirable.
|
| [6864]
|
johnjamesjacoby
|
General: update `bbp_get_post_types()` to accept arguments to parse before calling `get_post_types()`.
This avoids other manual calls to `get_post_types()` in other places. See #3221.
|
| [6777]
|
johnjamesjacoby
|
General: user escaped GetText variant where no HTML is ever allowed in strings.
This change brings a few dozen strings up to par with the others, and ensures that strings are escaped on their way into the runtime environment.
|
| [2546]
|
johnjamesjacoby
|
Get some twentyten child theme files in. Some are placeholders, some are started.
|
| [2612]
|
johnjamesjacoby
|
Give some color to the table heads and foots
|
| [3714]
|
johnjamesjacoby
|
Global $post usage clean-up:
* Use bbp_get_global_post_field() where appropriate, core WP functions otherwise
* Replace local $post variables with $post to avoid stomping the global
* Audit usage of bbp_get_global_post_field() and make sure we are providing the correct context
* Fixes #1733.
|
| [6582]
|
johnjamesjacoby
|
Globals: Use `bbp_get_global_object()` instead of touching `$wp_query` directly in template functions.
|
| [5171]
|
johnjamesjacoby
|
Go back to direct DB queries when changing forum visibilities. Fixes issues with visibility not saving correctly, at least for now. Fixes #2408, hat-tip netweb.
|
| [3666]
|
johnjamesjacoby
|
Go live with bbp_query_post_parent__in() filter.
|
| [2899]
|
johnjamesjacoby
|
Grammar fixes in warning messages in bbp-twentyten. Props scribu.
|
| [4139]
|
johnjamesjacoby
|
Green Scheme:
* Remove duplicate stylesheets for dealing with wp-content directory depth.
* Move image styling into admin_head method and get the admin URL in PHP.
* Remove referencs to content_depth variable.
* This will make it more difficult to merge admin styling in later, but easier to maintain and result in a smaller package.
|
| [4140]
|
johnjamesjacoby
|
Green Scheme:
* Remove duplicate stylesheets for dealing with wp-content directory depth.
* Move image styling into admin_head method and get the admin URL in PHP.
* Remove referencs to content_depth variable.
* This will make it more difficult to merge admin styling in later, but easier to maintain and result in a smaller package.
* For 2.1 branch. Backported from 2.2-bleeding as a bonus.
|
| [4372]
|
johnjamesjacoby
|
Green Scheme:
* Tweak the green scheme so it's less broken in !WordPress 3.5.
* Since admin CSS is not final, this may change, or need more tweaks.
|
| [3904]
|
johnjamesjacoby
|
Group Forums:
* PHP5ize the classes.
* Rearrange some methods.
* Allow BBP_BuddyPress class to be modified after load.
* Code formatting fixes.
|
| [5346]
|
netweb
|
Grunt is deprecating the Grunt.Util.* api, adding `grunt-legacy-util` will allow us to continue using `grunt.util.spawn` to spawn the multiple `phpunit` Grunt tasks.
* Adds `grunt-legacy-util` to `package.json`
* Requires fresh `npm install` to update dependencies
* Props netweb. Fixes #2576
|
| [5271]
|
johnjamesjacoby
|
Gruntify bbPress trunk (part 2):
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542.
|
| [5270]
|
johnjamesjacoby
|
Gruntify bbPress trunk:
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542.
|
| [2733]
|
johnjamesjacoby
|
Handle situation where all topics have replies when viewing the bbp_no_replies page.
|
| [7233]
|
johnjamesjacoby
|
Headers: update plugin headers, in branches/2.6 for 2.6.10.
|
| [7232]
|
johnjamesjacoby
|
Headers: update plugin headers, in trunk for 2.7.0.
|
| [6821]
|
johnjamesjacoby
|
Help: Update Forums & Topics help text.
* Tweak action order
* Grammar improvements
* Add "Close" action to forums
|
| [6441]
|
johnjamesjacoby
|
Help: Update help text, and include a bit about the "Theme Packages" section.
|
| [4051]
|
johnjamesjacoby
|
HiDPI:
* Add 2x icons for icon32's.
* Fixes #1839.
|
| [4052]
|
johnjamesjacoby
|
HiDPI:
* Tweak CSS for 2x icon32's.
* See #1839.
|
| [3047]
|
johnjamesjacoby
|
Hidden forums are always hidden.
|
| [6303]
|
johnjamesjacoby
|
Hidden: Remove "+ " string portion from output from hidden content.
This is a carry-over from bbPress 0.x, is superfluous in the given context, and previously could have presented misleading results if a negative value was presented.
Fixes #3059.
|
| [6354]
|
johnjamesjacoby
|
Hidden: Revert part of r6303, and improve some surrounding code:
* Tiny function-call optimizations
* Use integers for `_n()` and formatted strings for output
* Type casting, phpdoc, and code formatting improvements
Fixes #3077.
|
| [3485]
|
johnjamesjacoby
|
Hide favorites link(s) if favorites are not active.
|
| [3425]
|
johnjamesjacoby
|
Hide potential variable not defined debug notice. Fixes #1560. Props !GautamGupta.
|
| [3191]
|
johnjamesjacoby
|
Hide recount tool menu behind admin class variable, as forum recounts are hugely costly when done site wide and should not be so readily available.
|
| [4809]
|
johnjamesjacoby
|
Hide super sticky related output from group forums. Props imath. Fixes #2227.
|
| [2822]
|
johnjamesjacoby
|
Hide the revision log in admin topics and replies. Fixes #1451 props !GautamGupta
|
| [2563]
|
johnjamesjacoby
|
Hierarchical false on replies for now
|
| [4944]
|
johnjamesjacoby
|
Hierarchical replies:
* Introduce setting, option, functions, JS, CSS, and Walker class to support hierarchical replies.
* Tweak functions where saving the additional reply_to meta data is necessary.
* Add meta data field in dashboard to show the reply_to ID.
* There will likely be more tweaking necessary, as we test this further and get more eyes on the code.
* Fixes #2036.
* Props jmdodd for this huge effort.
|
| [6528]
|
johnjamesjacoby
|
Hierarchy: Use `post_parent` when not empty, and fallback to meta-data.
This fixes a few weird inconsistencies with how deleting content works, because `delete_` hooks fire after meta & terms have already been deleted from the database, `deleted_` hooks fire after the post itself is deleted from the database, but the post object cache has not yet been cleaned (even though term & meta caches have.)
We also call a few functions like `bbp_is_reply()` on the deleted `$postid`, and even though the state of the object-cache should not be relied on, it has not been purged yet.
Relatedly, updates to forum & topic descriptions can more reliably identify their state, so this commit adjusts some logic there also.
|