| [6366]
|
johnjamesjacoby
|
General: Remove end-of-file `?>` tags from extra templates.
These templates are theme drop-ins, and apparently were missed in previous clean-up efforts.
Props milindmore22. Fixes #3078.
|
| [6113]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
Fixes #2987.
|
| [6417]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
See #2987.
Merges [6113] to the 2.5 branch.
|
| [6437]
|
johnjamesjacoby
|
General: Tidying from looking into #2876.
|
| [6691]
|
netweb
|
General: Update changelog date format in `readme.txt`
This changeset is a follow up to [6689].
See https://wordpress.slack.com/archives/C02RQBYSJ/p1505079124000051
|
| [5684]
|
johnjamesjacoby
|
General: Use `sanitize_text_field()` in lieu of old-bbPress style pre-escaping technique.
|
| [7054]
|
johnjamesjacoby
|
General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.6.4, branches/2.6.
|
| [7055]
|
johnjamesjacoby
|
General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.7, trunk.
|
| [7053]
|
johnjamesjacoby
|
General: fix a few typos.
Props ankitmaru, mukesh27. Fixes #3312, #3313, #3315. For 2.7, trunk.
|
| [7056]
|
netweb
|
General: fix a few typos.
Props passoniate, wpamitkumar, sharaz.
Fixes #3308, #3316, #3317, #3319, #3323.
|
| [6272]
|
johnjamesjacoby
|
General: hyphenate "meta-box" in documentation to sooth spell-checkers.
|
| [6684]
|
johnjamesjacoby
|
General: more PHP7.1 array fixes.
See #3031. 2.5 branch, for 2.5.14.
|
| [6866]
|
johnjamesjacoby
|
General: unslash IP and user agent strings.
These are only used in ways where slashed values are undesirable.
|
| [6864]
|
johnjamesjacoby
|
General: update `bbp_get_post_types()` to accept arguments to parse before calling `get_post_types()`.
This avoids other manual calls to `get_post_types()` in other places. See #3221.
|
| [6777]
|
johnjamesjacoby
|
General: user escaped GetText variant where no HTML is ever allowed in strings.
This change brings a few dozen strings up to par with the others, and ensures that strings are escaped on their way into the runtime environment.
|
| [2546]
|
johnjamesjacoby
|
Get some twentyten child theme files in. Some are placeholders, some are started.
|
| [2612]
|
johnjamesjacoby
|
Give some color to the table heads and foots
|
| [3714]
|
johnjamesjacoby
|
Global $post usage clean-up:
* Use bbp_get_global_post_field() where appropriate, core WP functions otherwise
* Replace local $post variables with $post to avoid stomping the global
* Audit usage of bbp_get_global_post_field() and make sure we are providing the correct context
* Fixes #1733.
|
| [6582]
|
johnjamesjacoby
|
Globals: Use `bbp_get_global_object()` instead of touching `$wp_query` directly in template functions.
|
| [5171]
|
johnjamesjacoby
|
Go back to direct DB queries when changing forum visibilities. Fixes issues with visibility not saving correctly, at least for now. Fixes #2408, hat-tip netweb.
|
| [3666]
|
johnjamesjacoby
|
Go live with bbp_query_post_parent__in() filter.
|
| [2899]
|
johnjamesjacoby
|
Grammar fixes in warning messages in bbp-twentyten. Props scribu.
|
| [4139]
|
johnjamesjacoby
|
Green Scheme:
* Remove duplicate stylesheets for dealing with wp-content directory depth.
* Move image styling into admin_head method and get the admin URL in PHP.
* Remove referencs to content_depth variable.
* This will make it more difficult to merge admin styling in later, but easier to maintain and result in a smaller package.
|
| [4140]
|
johnjamesjacoby
|
Green Scheme:
* Remove duplicate stylesheets for dealing with wp-content directory depth.
* Move image styling into admin_head method and get the admin URL in PHP.
* Remove referencs to content_depth variable.
* This will make it more difficult to merge admin styling in later, but easier to maintain and result in a smaller package.
* For 2.1 branch. Backported from 2.2-bleeding as a bonus.
|
| [4372]
|
johnjamesjacoby
|
Green Scheme:
* Tweak the green scheme so it's less broken in !WordPress 3.5.
* Since admin CSS is not final, this may change, or need more tweaks.
|
| [3904]
|
johnjamesjacoby
|
Group Forums:
* PHP5ize the classes.
* Rearrange some methods.
* Allow BBP_BuddyPress class to be modified after load.
* Code formatting fixes.
|
| [5346]
|
netweb
|
Grunt is deprecating the Grunt.Util.* api, adding `grunt-legacy-util` will allow us to continue using `grunt.util.spawn` to spawn the multiple `phpunit` Grunt tasks.
* Adds `grunt-legacy-util` to `package.json`
* Requires fresh `npm install` to update dependencies
* Props netweb. Fixes #2576
|
| [5271]
|
johnjamesjacoby
|
Gruntify bbPress trunk (part 2):
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542.
|
| [5270]
|
johnjamesjacoby
|
Gruntify bbPress trunk:
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542.
|
| [2733]
|
johnjamesjacoby
|
Handle situation where all topics have replies when viewing the bbp_no_replies page.
|
| [7233]
|
johnjamesjacoby
|
Headers: update plugin headers, in branches/2.6 for 2.6.10.
|
| [7232]
|
johnjamesjacoby
|
Headers: update plugin headers, in trunk for 2.7.0.
|
| [6821]
|
johnjamesjacoby
|
Help: Update Forums & Topics help text.
* Tweak action order
* Grammar improvements
* Add "Close" action to forums
|
| [6441]
|
johnjamesjacoby
|
Help: Update help text, and include a bit about the "Theme Packages" section.
|
| [4051]
|
johnjamesjacoby
|
HiDPI:
* Add 2x icons for icon32's.
* Fixes #1839.
|
| [4052]
|
johnjamesjacoby
|
HiDPI:
* Tweak CSS for 2x icon32's.
* See #1839.
|
| [3047]
|
johnjamesjacoby
|
Hidden forums are always hidden.
|
| [6303]
|
johnjamesjacoby
|
Hidden: Remove "+ " string portion from output from hidden content.
This is a carry-over from bbPress 0.x, is superfluous in the given context, and previously could have presented misleading results if a negative value was presented.
Fixes #3059.
|
| [6354]
|
johnjamesjacoby
|
Hidden: Revert part of r6303, and improve some surrounding code:
* Tiny function-call optimizations
* Use integers for `_n()` and formatted strings for output
* Type casting, phpdoc, and code formatting improvements
Fixes #3077.
|
| [3485]
|
johnjamesjacoby
|
Hide favorites link(s) if favorites are not active.
|
| [3425]
|
johnjamesjacoby
|
Hide potential variable not defined debug notice. Fixes #1560. Props !GautamGupta.
|
| [3191]
|
johnjamesjacoby
|
Hide recount tool menu behind admin class variable, as forum recounts are hugely costly when done site wide and should not be so readily available.
|
| [4809]
|
johnjamesjacoby
|
Hide super sticky related output from group forums. Props imath. Fixes #2227.
|
| [2822]
|
johnjamesjacoby
|
Hide the revision log in admin topics and replies. Fixes #1451 props !GautamGupta
|
| [2563]
|
johnjamesjacoby
|
Hierarchical false on replies for now
|
| [4944]
|
johnjamesjacoby
|
Hierarchical replies:
* Introduce setting, option, functions, JS, CSS, and Walker class to support hierarchical replies.
* Tweak functions where saving the additional reply_to meta data is necessary.
* Add meta data field in dashboard to show the reply_to ID.
* There will likely be more tweaking necessary, as we test this further and get more eyes on the code.
* Fixes #2036.
* Props jmdodd for this huge effort.
|
| [6528]
|
johnjamesjacoby
|
Hierarchy: Use `post_parent` when not empty, and fallback to meta-data.
This fixes a few weird inconsistencies with how deleting content works, because `delete_` hooks fire after meta & terms have already been deleted from the database, `deleted_` hooks fire after the post itself is deleted from the database, but the post object cache has not yet been cleaned (even though term & meta caches have.)
We also call a few functions like `bbp_is_reply()` on the deleted `$postid`, and even though the state of the object-cache should not be relied on, it has not been purged yet.
Relatedly, updates to forum & topic descriptions can more reliably identify their state, so this commit adjusts some logic there also.
|
| [3687]
|
johnjamesjacoby
|
Hook missing forum contextual help in. See #1699.
|
| [3652]
|
johnjamesjacoby
|
Hook topic and reply trash actions onto new wp_trash_post hook introduced in WordPress 3.3. Fix #1707.
|
| [3311]
|
johnjamesjacoby
|
Huge theme compatibility audit. This normalizes all of the function names, template files, actions, and globals surrounding theme compatibility.
|
| [4381]
|
johnjamesjacoby
|
Humans:
* Add jmdodd to thanks list.
|
| [6579]
|
netweb
|
Humans: I like tacos 🌮
|
| [4668]
|
johnjamesjacoby
|
I don't see nothing wrong, with a little bump and grind.
|
| [5829]
|
johnjamesjacoby
|
I think this building should be condemned. There's serious metal fatigue in all the load-bearing members, the wiring is substandard, it's completely inadequate for our power needs, and the neighborhood is like a demilitarized zone.
|
| [5842]
|
johnjamesjacoby
|
IDs: Some reply functions still default to their topics if no replies are present. This functionality has slowly been removed over time and built into respective functions. In this changeset, we remove those leftover assignments and update a few phpdoc descriptions as needed.
Hat-tip netweb. See #2806.
|
| [5397]
|
johnjamesjacoby
|
If a reply is a reply to another reply, display the parent reply information in the form legend with the topic title. Props netweb. Fixes #2509.
|
| [5174]
|
johnjamesjacoby
|
If not deleting users, delete the imported user meta-data instead. See #1889. Props netweb.
|
| [5059]
|
johnjamesjacoby
|
If pre-option exists for threaded replies depth, make sure it's correctly disabled.
|
| [3218]
|
johnjamesjacoby
|
If settings fields are empty, automatically revert them to their defaults. This adds an additional parameter to bbp_form_option() function to pass the default value.
|
| [3808]
|
johnjamesjacoby
|
If there is no topic or reply, bail early out of respective _update_ functions to avoid a ton of errors and bad things from happening.
|
| [2830]
|
johnjamesjacoby
|
If topic is being permanently deleted, redirect back to forum.
|
| [3210]
|
johnjamesjacoby
|
If user has unfiltered_html capability, add notice to the top of topic and reply forms and hide the form-allowed-tags section.
|
| [7165]
|
johnjamesjacoby
|
Ignore pnpm-lock.yaml in Subversion. See r7164.
|
| [7164]
|
johnjamesjacoby
|
Ignore pnpm-lock.yaml.
pnpm is an optional alternative to npm, allowing for global sharing of dependencies, which is particularly useful for WordPress plugins.
|
| [3659]
|
johnjamesjacoby
|
Implement topic view feeds. Fixes #1716.
|
| [5526]
|
netweb
|
Importer templates updates to coincide with r5525 changeset to differentiating original forum, topic and reply meta ID's from new bbPress post meta keys.
* Renames `_bbp_forum_id` to `_bbp_old_forum_id`
* Renames `_bbp_topic_id` to `_bbp_old_topic_id`
* Renames `_bbp_post_id` to `_bbp_old_reply_id`
See #2650
|
| [6928]
|
johnjamesjacoby
|
Importer: make inside meta-box contents a bit more squared.
This change fixes a padding issue with the inner meta-box content, causing there to be more space on the bottom than on the top.
|
| [6929]
|
johnjamesjacoby
|
Importer: remove byref usade in parser.php.
This commit removes an old byref in the bbCode parser. It wasn't really necessary, and was causing problems with certain PHP versions.
Fixes #3257. Props webmaigcz.
|
| [5989]
|
netweb
|
Importers: Add support for anonymous topic and reply import support in XenForo (XenForo.php) importer
This changeset adds support for importing topics and replies where the original XenForo author was deleted, this keeps the original author name as the now topic or reply anonymous author name.
Props netweb.
Fixes #2922, See aslo #2347.
|
| [6041]
|
netweb
|
Importers: In `BBP_Converter_Base::convert_table()` method use `isset()` rather than `! is_null`
Props Offereins
Fixes #2733
|
| [5795]
|
netweb
|
Importers: Update phpbB importer to support phpBB 3.1.x database schema changes
* Note: Importing from phpBB 3.0.x is no longer supported, please update to phpBB 3.1.x before importing
Props netweb. Fixes #2716
|
| [5800]
|
netweb
|
Importers: Updated AIM, YIM, and Jabber user meta key prefixes importer user profile fields for AEF, FluxBB, Kunena3, MyBB, PunBB, SMF, XMB, vBulletin and vBulletin3 importers
Props netweb. Fixes #2815
|
| [6767]
|
johnjamesjacoby
|
Importers: `setup_globals()` is a public method.
This change fixes a bug with the vBulletin importer causing it not to run.
See r6766 for the vBulletin3 equivalent.
|
| [6766]
|
johnjamesjacoby
|
Importers: `setup_globals()` is a public method.
This change fixes a bug with the vBulletin3 importer causing it not to run.
|
| [4856]
|
johnjamesjacoby
|
Improve CSS for pre/code blocks, to allow code to scroll horizontally within a pre tag.
|
| [4858]
|
johnjamesjacoby
|
Improve CSS for pre/code blocks, to allow code to scroll horizontally within a pre tag; includes minification. (trunk)
|
| [5497]
|
johnjamesjacoby
|
Improve ID and classification in `form-topic.php` when forum is closed or user cannot create new topics. Props netweb. Fixes #2574.
|
| [3220]
|
johnjamesjacoby
|
Improve RTL support in Right Now dashboard widget. Fixes #1536.
|
| [3657]
|
johnjamesjacoby
|
Improve bbp_is_activation() and bbp_is_deactivation() to include bulk actions. Props duck_. Fixes #1660.
|
| [2808]
|
johnjamesjacoby
|
Improve bbp_list_subforums function with additional formatting args
|
| [2703]
|
johnjamesjacoby
|
Improve current_user_id and displayed_user_id functions. Also remove Page Template ability from User templates.
|
| [4623]
|
johnjamesjacoby
|
Improve default pagination styling (includes RTL). Hat-tip corsonr. Fixes #2124.
|
| [2735]
|
johnjamesjacoby
|
Improve fieldset reply notice when topic is closed but user can still reply.
|
| [5558]
|
johnjamesjacoby
|
Improve form field output sanitization when posting theme-side forum/topic/reply content. Thanks planetzuda. See #2719.
|
| [3855]
|
johnjamesjacoby
|
Improve forum and topic description texts to include empty cases.
|
| [5121]
|
johnjamesjacoby
|
Improve function locations introduced in r5120. Ensures template and helper functions are in template.php. See #2426.
|
| [2992]
|
johnjamesjacoby
|
Improve inline documentation in bbp_update_forum_last_reply_id() and remove unneeded empty variable check. Also cast some variables as integers when comparing their values to be safe.
|
| [2972]
|
johnjamesjacoby
|
Improve logic behind setting the current_forum/topic/reply_id global variables
|
| [4818]
|
johnjamesjacoby
|
Improve logic in topics loop, so that super-stickies are always above forum-stickies. Props alex-ye. Fixes #2260.
|
| [4666]
|
johnjamesjacoby
|
Improve margins on TinyMCE quicktags. Includes RTL.
|
| [4900]
|
johnjamesjacoby
|
Improve micro-performance of favorites and subscriptions by moving function calls after sanity checks. Also typecast the return value of respective get_topic_ids functions. See #2331.
|
| [5269]
|
johnjamesjacoby
|
Improve naming of new "At a Glance" metabox filter, and lower priority to increase odds of hugging more closely to WordPress core items. See #2544.
|
| [5334]
|
johnjamesjacoby
|
Improve output of `grunt jshint` task. See #2578.
|
| [2587]
|
johnjamesjacoby
|
Improve page-bbp_front.php
|
| [2696]
|
johnjamesjacoby
|
Improve query count in bbp_get_reply_url
|
| [3186]
|
johnjamesjacoby
|
Improve support for forum and topic archives pages, and improve explanations on forums settings slugs section. Remove archive-reply.php from bbp-twentyten.
|
| [3260]
|
johnjamesjacoby
|
Improve support for orphaned topics and replies in admin post rows by displaying "No Forum" and "No Topic" if parents have been deleted.
|
| [3162]
|
johnjamesjacoby
|
Improve support of suppressing private forum meta data. Fixes #1522. Props !GautamGupta.
|
| [3265]
|
johnjamesjacoby
|
Improve the current title area of breadcrumbs.
Improve behavior of redirect field.
Allow single topic shortcodes to use pagination, and properly redirect on new replies.
Use wp_safe_redirect() in places where redirect_to fields are used.
Move theme compatibility setup function out of main bbPress class and into bbp-core-compatibility.php.
Move bbp_setup_theme_compat action off of after_setup_theme and into bbp_init.
Add supplemental functions to get and set if theme compatibility is currently helping load pieces of the current page.
|
| [5018]
|
johnjamesjacoby
|
Improve the flexibility of bbp_title() by allowing all data to be filtered. Props alex-ye. Fixes #1764.
|