| [2993]
|
johnjamesjacoby
|
Fixes #1496. Documentation clean-up. Fix incorrect references to split/merge. Fix incorrect post_field usage where post_parent was used rather than post_type. Fix incorrect function usage for querying topic id's from a forum. Props !GautamGupta
|
| [5287]
|
johnjamesjacoby
|
Fixes PHPUnit Multisite tests and sets up grunt build-realease to run all PHPUnit tests when building release package (Single & Multisite.) Props netweb. See #2542.
|
| [3304]
|
johnjamesjacoby
|
Fixes to forum and topic archive links. Always set has_archive to archive slug settings. Use get_post_type_archive_link() where appropriate instead of relying on home_url( $slug ). Add bbp_get_page_by_path() function to theme compat, to check for pretty permalinks first. Introduce default 'page_for' options, which will provide a more straight-forward method of assigning WordPress pages to bbPress functionalities.
|
| [2497]
|
johnjamesjacoby
|
Fixes wrong post type count. props Nightgunner5.
|
| [3159]
|
johnjamesjacoby
|
Flesh out current-user topic-form access functions with more appropriate hierarchy of checks. Fix #1516.
|
| [3074]
|
johnjamesjacoby
|
Flush rewrite rules when the admin settings page is saved
|
| [3073]
|
johnjamesjacoby
|
Flush the rewrite rules when bbPress is activated and deactivated
|
| [5573]
|
netweb
|
FluxBB importer: Include Subscribed Forums and Subscribed Topics
Props netweb. See #2668
|
| [2646]
|
johnjamesjacoby
|
Follow my own rules in BBP_Admin
|
| [5037]
|
johnjamesjacoby
|
For all template functions that output URL's, always echo an escaped value using esc_url(). See #2367.
|
| [5001]
|
johnjamesjacoby
|
For inline code blocks in topics and replies, ensure they are vertically positioned in the middle of their respective lines of text. Fixes issue where code snippets were top-aligned based on paragraph line-height. See #2350.
|
| [5243]
|
johnjamesjacoby
|
For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (2.5 branch)
|
| [5242]
|
johnjamesjacoby
|
For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (trunk)
|
| [5227]
|
johnjamesjacoby
|
Force `colors-fresh` dependency to act as a foundation for `Mint` and `Evergreen` color schemes. Fixes #2462.
|
| [4418]
|
johnjamesjacoby
|
Force a max-width on forum drop-down in default templates.
|
| [3589]
|
johnjamesjacoby
|
Force comment_status to 'closed' for forums, topics, and replies. Fixes #1676.
|
| [2499]
|
johnjamesjacoby
|
Force counts to pick up all descendants of proper post type.
|
| [3103]
|
johnjamesjacoby
|
Force forums, topics, and replies tables to clear the pagination floating above it, for theme compat.
|
| [5392]
|
johnjamesjacoby
|
Force integer value in `bbp_has_topics()` for reply position. Fixes bug when there are more than 1,000 replies. Props DrPepper75. Fixes #2615.
|
| [2472]
|
chrishajer
|
Forgot to add in new functions.php files for kakumei and kakumei-blue. Fixes #1268. Props !GautamGupta
|
| [4278]
|
johnjamesjacoby
|
Form Actions:
* Use the_permalink() as a form action in forum/topic/reply forms.
* See #1996.
|
| [6094]
|
johnjamesjacoby
|
Format `bbp_get_reply_title()` like `bbp_get_topic_title()`.
|
| [3903]
|
johnjamesjacoby
|
Formatting:
* 'elseif' not 'else if' in bbp-template-functions.php
* Ignore my OCD.
|
| [4642]
|
johnjamesjacoby
|
Formatting:
* Rename kses.php to formatting.php.
* Port bbPress 1.1 code and pre tag handling. Comes with filters and callbacks to allow code wrapped in pre & code elements, and backticks.
* Revert r4641, r4640,
* See #1967.
|
| [6378]
|
johnjamesjacoby
|
Formatting: Add rel-nofollow to tests. See #2963.
|
| [6347]
|
johnjamesjacoby
|
Formatting: Filter out mention classes in unit tests, and remove `rel="nofollow"` on mention URLs.
Also improve array handling of `bbp_make_mentions_clickable_classes` filter, in the event something weird gets filtered through it.
See #3074.
|
| [6377]
|
johnjamesjacoby
|
Formatting: More tests for at-mentions.
Props netweb. See #2963.
|
| [6722]
|
johnjamesjacoby
|
Formatting: Use `mb_substr()` where appropriate.
This change ensures that strings which are known to contain or allow for multibyte characters are allowed to do so (in excerpts and a few server globals.)
Fixes #3170. Props it4life.
|
| [7159]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In branches/2.6, for 2.6.6. See #3398.
|
| [7160]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In trunk, for 2.7. Fixes #3398.
|
| [7120]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In branches/2.6, for 2.6.6.
Props peterkueger.
|
| [7121]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In trunk, for 2.7.
Props peterkueger.
Fixes #3390.
|
| [7082]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In 2.6 branch, for 2.6.5.
See #3371.
|
| [7083]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In trunk, for 2.7.0.
See #3371.
|
| [6861]
|
johnjamesjacoby
|
Formatting: update `bbp_get_time_since()` to accept MySQL formatted string in older & newer dates.
Also cast values to int using `intval()` to ensure math always works, without notices or errors.
This change adds a bit more validation on potentially untrusted values.
See #3216.
|
| [6885]
|
johnjamesjacoby
|
Formatting: update `bbp_make_clickable()` to better handle spaces in `href` attributes.
This change updates the included regular expression to avoid returning broken (or at least unexpected) HTML and allows spaces in `href` attributes to be encoded as expected.
Props dd32. Fixes #3237.
|
| [6555]
|
johnjamesjacoby
|
Forms: Add `autocomplete` attribute to user related form fields.
`autocomplete="new-password"` is new, and browser support is gaining, but it's also not any worse than `autocomplete="off"` (where most browsers & password managers have a hard time respecting the etiquitte anyways.)
|
| [6557]
|
johnjamesjacoby
|
Forms: Add `maxlength` attribute to the appropriate form fields.
Fields like `user_login`, `user_url`, and `user_email` have upper boundaries that cannot be extended via meta-data or other means, so let's make sure users aren't (easily) able to go over them.
For the anonymous user fields, set them up to match comment field lengths (even though they are stored in `postmeta`.)
|
| [6248]
|
johnjamesjacoby
|
Forms: Audit & normalize form-field sanitization.
* Make sure they all work the same
* Use filters in `core/filters.php` where appropriate
* Add `absint` filters for numeric values
* Add filters for per-forum moderator text field
* Remove any accidental duplicate escaping
|
| [6433]
|
johnjamesjacoby
|
Forms: Introduce `bbp_tab_index_attribute()` helpers to handle `tabindex` attribute output.
Note that these functions are used but normally their output is suppressed, because overriding the browser's natural `tabindex` order is impolite, and may introduce more issues than it actually fixes.
(Also includes some surrounding code clean-up.)
|
| [6556]
|
johnjamesjacoby
|
Forms: formally update password change text.
It was accidentally partially changed in r6555.
|
| [6837]
|
johnjamesjacoby
|
Forms: include forum/topic ID in nonce checks.
This change adds in missing object IDs, fixing a bug causing form content to be lost when an error had occurred.
Props wpdennis. Fixes #3209.
|
| [4118]
|
johnjamesjacoby
|
Forum Actions:
* Remove bbp_has_topics() from forum trash and topic delete functions.
* Use WP_Query's instead.
* Remove phpdoc references to bbp_has_topics() where it's no longer used.
* Fixes #1914.
* For 2.1 branch.
|
| [4117]
|
johnjamesjacoby
|
Forum Actions:
* Remove bbp_has_topics() from forum trash and topic delete functions.
* Use WP_Query's instead.
* Remove phpdoc references to bbp_has_topics() where it's no longer used.
* Fixes #1914.
* For 2.2 branch.
|
| [5156]
|
johnjamesjacoby
|
Forum Subscriptions - Allow users to subscribe to new topics in specific forums.
* Code largely lifted from existing Topics Subscriptions, and is based largely on `forum-subscriptions.2.diff` from mordauk, with edits for code consistency across bbPress components.
* Refactor existing ambiguous function names into base functions for both forum and topic subscriptions.
* Include new functions for getting and outputting subscriptions.
* Modify `user-subscriptions.php` to show subscribed forums. This includes a modification to `content-single-forum.php` to include the "Unsubscribe" link if looking at a user profile page.
* Modify `templates/default/bbpress-functions.php` to enqueue new JS file to handle forum subscription ajax.
* Rename HTML element classes from `bbp-topic-action` to `bbp-row-actions` to better accommodate forum subscriptions (and any future actions.)
* BuddyPress tested, JJJ approved.
* See #2299. Props mordauk, netweb for the considerable effort.
* More to do here, largely from `forum-subscriptions.3.diff`
|
| [5157]
|
johnjamesjacoby
|
Forum Subscriptions:
* Update `@since` and `@deprecated` to r5156.
* Introduce tool for removing trashed and deleted forums from user subscriptions.
* See #2299. Props netweb.
|
| [4104]
|
johnjamesjacoby
|
Forum Visibility:
* Prevent forum metaboxes from saving forum revisions as private/hidden.
* Add repair function for private/hidden forums to Tools.
* Add updater for 2.1.1, and run the visibility repair function.
* Fixes #1891.
* For 2.1 branch.
|
| [4105]
|
johnjamesjacoby
|
Forum Visibility:
* Prevent forum metaboxes from saving forum revisions as private/hidden.
* Add repair function for private/hidden forums to Tools.
* Add updater for 2.1.1, and run the visibility repair function.
* Fixes #1891.
* For 2.2 branch.
|
| [4416]
|
johnjamesjacoby
|
Forums Admin:
* More aggressive CSS for forum parent.
|
| [4414]
|
johnjamesjacoby
|
Forums Admin:
* Revert usage of Suggest for choosing a forum parent via auto-complete.
* Revert parts of r4260 and r4261.
* See #1910, #2014.
|
| [4415]
|
johnjamesjacoby
|
Forums Admin:
* Set max-width to 170px for forum parent ID.
|
| [4417]
|
johnjamesjacoby
|
Forums Admin:
* Update 'order' and 'orderby' for get_posts() usage to sort by 'title' and not 'post_title'.
|
| [4071]
|
johnjamesjacoby
|
Forums:
* Do not add forum-exclude meta-query to single reply queries.
|
| [4438]
|
johnjamesjacoby
|
Forums:
* Do not disable categories on forum parent drop downs in wp-admin.
* Disable forum parents in topic and reply edits if user cannot edit forums.
* This is to prevent innocent users from accidentally putting content in a forum category.
|
| [4167]
|
johnjamesjacoby
|
Forums:
* Remove superfluous is_super_admin() login in bbp_has_forums().
* Capes always pass current_user_can() checks unless specifically not allowed, which is the intended behavior here.
|
| [6273]
|
johnjamesjacoby
|
Forums: Add `howto` text to `bbp_moderator_assignment_metabox()`.
See #459.
|
| [6478]
|
johnjamesjacoby
|
Forums: Add forum-type & status to allowed meta keys.
|
| [6357]
|
netweb
|
Forums: Add missing `@since` PHPDoc to `bbp_list_forums()`
|
| [5683]
|
johnjamesjacoby
|
Forums: Audit `template.php`:
* General code formatting improvements
* Pass `$args` into more filters
* Escape more gettext output
* Un-nest a few complex-looking lines
|
| [6414]
|
johnjamesjacoby
|
Forums: Audit private/hidden forum ID exclusion:
* improve performance of `bbp_exclude_forum_ids()`
* Use `bbp_exclude_forum_ids()` where duplicate code existed
* Make sure `$forum_ids` are passed into `bbp_exclude_forum_ids` filter
* Prefer arrays over imploded strings (also with post statuses)
|
| [7052]
|
johnjamesjacoby
|
Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.6.4, branches/2.6.
|
| [7051]
|
johnjamesjacoby
|
Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.7, trunk.
|
| [7085]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In branches/2.6, for 2.6.5.
See #3374.
|
| [7084]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In trunk, for 2.7.0.
See #3374.
|
| [5855]
|
johnjamesjacoby
|
Forums: Fix copy-pasta filter names.
This changeset corrects filters used in 2 `apply_filters()` calls to properly match their function names.
Props netweb. Fixes #2688.
|
| [5655]
|
netweb
|
Forums: Fix missing meta data during new forum creation
* Call `bbp_open_forum()` if the forum is "open" to add the forum `_bbp_status` = `open` meta
* Call `bbp_normalize_forum()` if the forum is a "forum" to add the forum `_bbp_forum_type` = `forum` meta
Props netweb. Fixes #2647
|
| [5923]
|
netweb
|
Forums: Improve type-casting in forum functions.
Props thebrandonallen. See #2801.
|
| [6315]
|
johnjamesjacoby
|
Forums: Introduce `bbp_list_forums_subforum_classes` filter, to allow filtering of sub-forum links.
Props gordielachance. Fixes #2760.
|
| [5856]
|
johnjamesjacoby
|
Forums: Introduce `bbp_update_forum_visibility` action in `bbp_save_forum_extras()`
This changeset provides custom visibilites with an execution point to perform their own actions.
Fixes #2740.
|
| [5731]
|
johnjamesjacoby
|
Forums: Normalize type-casting in some count functions. More to do here.
Props thebrandonallen, netweb. See #2801.
|
| [6020]
|
netweb
|
Forums: Overzealous type coercion caused `bbp_forum_query_last_reply_id()` to skip the database query in every instance (since 0 is never === false). As such, the resetting of `_bbp_last_reply_id` got short-circuted in some cases.
This fix is for the 2.5 branch, `/trunk` fixed this inadvertantly in [5954]
Props boonebgorges, mauteri.
Fixes #2414.
|
| [5734]
|
johnjamesjacoby
|
Forums: Type-cast improvements to `bbp_forum_query_last_reply_id()`.
Fixes bug where strict `false` comparison would cache cache condition to never occur.
Props thebrandonallen, netweb. See #2801.
|
| [6733]
|
netweb
|
Forums: Update `bbp_untrash_forum_topics()` PHPDoc description.
Props espellcaste.
Fixes #3175.
|
| [5918]
|
netweb
|
Forums: Updated PHPDocs and unit tests for `bbp_update_forum_last_*()` functions.
Props thebrandonallen. Fixes #2811
|
| [6024]
|
johnjamesjacoby
|
Forums: Updates to `bbp_list_forums()`:
* Always run filter, even over empty output
* Only wrap output if not empty
* Ensure that `$count` related variables are accurately reset during each loop iteration
* Surrounding code clean-up
Fixes #2951.
|
| [6576]
|
johnjamesjacoby
|
Forums: Use `bbp_get_forum_subforum_count()` in `bbp_forum_get_subforums()`.
This performance optimization will result in 1 less query per forum in the forums list that does not have subforums, by checking the subforum meta-data before trying to query for subforums that do not exist anyways.
This is less of an issue with a persistent object cache, but those without that luxury can now save those database queries for when they really matter.
|
| [6559]
|
johnjamesjacoby
|
Forums: Use `edit_forum` instead of `keep_gate` in the admin toggle/row methods.
This change trusts the `edit_forum` meta capability to serve it's intended purpose. It also allows more flexibility with things like BuddyPress Group Forums or custom forum-ownership style extensions.
|
| [6545]
|
johnjamesjacoby
|
Forums: Use `no_found_rows` by default in `bbp_has_forums()`
Forums do not currently support pagination, so the total number of rows is not traditionally useful for this loop. In cases where it is, it can be explicitly overloaded in the `$args` array.
This results in 1 less database query per page where a forums list is shown, and a speed improvement overall.
|
| [7272]
|
johnjamesjacoby
|
Forums: bail out of `pre_get_posts` if empty `post_type` parameter
This change addresses a regression inside of `bbp_pre_get_posts_normalize_forum_visibility` that was unintentionally targeting posts queries that were not sourced from the ones built into bbPress (forum/topic/reply), causing the majority of non-bbPress queries to return empty results.
Fixes #3601.
In branches/2.6, for 2.6.11.
|
| [6480]
|
johnjamesjacoby
|
Forums: be strict in `array_search()` calls.
|
| [6718]
|
johnjamesjacoby
|
Forums: make sure topic & reply counts are proper integers for `_n()` usage.
This change fixes a bug where formatted strings would cause an incorrect singular and plural string assignment, in forums that had over 1k posts.
|
| [6875]
|
johnjamesjacoby
|
Forums: protect against a missing/malformed `forum_id` value when listing subforums.
Fixes #3232.
|
| [6860]
|
johnjamesjacoby
|
Forums: revert default mark-up back to div's and span's in `bbp_list_forums()`.
This fixes potentially invalid mark-up from attempting to use list elements instead of spans.
Also includes changes to CSS selectors to make them more flexible with different child elements.
See #3217.
|
| [6872]
|
johnjamesjacoby
|
Forums: revert part of r6860.
Go back to `ul` and `li` to avoid breaking CSS for existing installs, and use a CSS separator instead to address the original invalid markup issues.
This might show an extra separator in circumstances where filters or template-overrides are targeting very specific things, but that's better than breaking mark-up changes.
See #3217.
|
| [7008]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.6.3, branches/2.6.
|
| [7009]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.7, trunk.
|
| [2974]
|
johnjamesjacoby
|
Full audit of user/topic/reply/view permalinks. Use $wp_rewrite->using_permalinks() method in place of $wp_rewrite->permalink_structure. See r2973
|
| [6102]
|
netweb
|
General - Administration: Add i18n text domain missed in [6101]
See #2246.
|
| [6055]
|
netweb
|
General - Administration: Add pending status topic and reply statistics to `bbp_get_statistics()`
Following the introduction of "pending" status topics and replies in bbPress 2.6, `bbp_get_statistics()` now includes these count statistics in the hidden topic and reply statistics.
Fixes #2958.
|
| [6101]
|
netweb
|
General - Administration: Introduce bulk actions to spam and unspam topics and replies in wp-admin
This Friday #yolo changeset comes care of the upcoming WordPress 4.7 release via #WP16031 / wp:changeset:38647
Props jmdodd.
See #2246.
|
| [6061]
|
netweb
|
General - Administration: Update "change forum role" dropdown
This changeset resolves an issue introduced in WordPress 4.4 ( [WP:changeset:34636] / #WP27743 ) which caused bbPress "change forum role" dropdown to only work using the "bottom" user list table dropdown, for WordPress versions < 4.6 the "change forum role" dropdown is now only shown at the "top" of the user list table.
This changeset also adds a new parameter `$which` to `user_role_bulk_dropdown()` which was added in WordPress 4.6 ( [WP:changeset:37422] / #WP35307 ) to pass the location of the extra table nav markup for the "top" or "bottom" "change role" dropdown, and in turn fixes bbPress' "change forum role" dropdown to once again work at the "top" and "bottom" of the user list table.
Props ocean90.
Fixes #2906.
|
| [6036]
|
netweb
|
General Performance: Introduce increase/decrease helper count functions
Previously when a new topic or reply was created, a bunch of queries to recalculate the topic and reply counts for topics and forums were ran. Now these have been replaced with more efficient increase/decrease helper functions to get the current value and just "bump" the count based on the action (new topic-reply/split-topic/move-topic/spam-trash-topic/etc...)
Props thebrandonallen, tharsheblows, netweb
See #1799
|
| [6046]
|
netweb
|
General: Add debug trace to `bbp_setup_current_user()` notice.
Previously, the `bbp_setup_current_user was called incorrectly` notice would not output any useful info for developers.
This commit adds a debug trace so developers are able to determine
whereabouts in the codebase this notice is originating from.
Props r-a-y
Fixes #2932
|
| [6499]
|
johnjamesjacoby
|
General: Audit `wp_insert_post()` usages.
Return a `WP_Error` object in some instances, and explicitly do not in others.
Where possible, use the error message in the user feedback response.
Fixes #2817.
|
| [6839]
|
johnjamesjacoby
|
General: Bump to RC6, and related unimpactful changes
* Docs & whitespace
* Update packages
* Update stable tag
* Add changelog section for 2.6 (TBD)
|
| [6371]
|
netweb
|
General: Following [6366] use a single blank line for end-of-file extras templates.
See #3078.
|
| [6361]
|
netweb
|
General: Improve verbiage for closed forum and closed topic template notices.
This changeset also adds a template notice to the reply form noting that the forum you're posting to is closed to new content.
Props @SergeyBiryukov.
Fixes #3076.
See also #2353-meta.
|
| [6554]
|
johnjamesjacoby
|
General: Introduce `bbp_pre_handle_404()` to handle 404 overrides.
This only introduces the function for now. I'll go through and check all of the conditions next.
See #3047.
|
| [6627]
|
johnjamesjacoby
|
General: Make sure object `_get_` functions reach intended filters.
This retains existing behavior of bailing early and returning `null` if there is a `post_type` mismatch. Other similar functions would pass the `null` value through to the filter. These may do that eventually, but let's get these filters working first.
Fixes #3130.
|
| [6284]
|
johnjamesjacoby
|
General: Remove `()` around `require` construct calls, and breathing room around some `!` usages.
|