| [6482]
|
johnjamesjacoby
|
Fix typo in phpdoc.
|
| [2706]
|
johnjamesjacoby
|
Fix typo in r2705
|
| [4798]
|
johnjamesjacoby
|
Fix typo in reply nonce error message. Props loki_racer. Fixes #2257.
|
| [5072]
|
johnjamesjacoby
|
Fix typo. See #2090.
|
| [6270]
|
johnjamesjacoby
|
Fix typos in core options documentation.
|
| [3322]
|
johnjamesjacoby
|
Fix typos in forum archive and front page templates pointing to content-archive-forums.php instead of content-archive-forum.php.
|
| [6249]
|
johnjamesjacoby
|
Fix typos in more documentation.
|
| [6648]
|
johnjamesjacoby
|
Fix undeclared array in forum template functions for PHP 7.1 compatibility.
Props hellofromTonya. See #3031. (2.5 branch)
|
| [6647]
|
johnjamesjacoby
|
Fix undeclared arrays for PHP 7.1 compatibility.
Props hellofromTonya. See #3031. (2.5 branch)
|
| [3372]
|
johnjamesjacoby
|
Fix uninstantiated $bbp global in bbp_theme_compat_set_theme(). Props nacin.
|
| [3154]
|
johnjamesjacoby
|
Fix user profile styling conflicts when bbp-twentyten is the active theme.
|
| [5244]
|
johnjamesjacoby
|
Fix variable variable in `bbp_get_reply_author_link()` causing incorrect title attribute. Fixes #2505. (2.5 branch)
|
| [5245]
|
johnjamesjacoby
|
Fix variable variable in `bbp_get_reply_author_link()` causing incorrect title attribute. Fixes #2505. (trunk)
|
| [2887]
|
johnjamesjacoby
|
Fix verbiage in comment from r2886
|
| [3466]
|
johnjamesjacoby
|
Fix verbiage in comment in bbp-languages/index.php.
|
| [6702]
|
johnjamesjacoby
|
Fix weird indentation in `bbp_get_admin_repair_tool_run_url()`.
|
| [2466]
|
johnjamesjacoby
|
Fix wrong topics slug
|
| [5427]
|
netweb
|
Fixed topic sticky status importing method for compatibility when `wp_bbconverter_translator` database sync_table exists.
* Topic stickies and super stickies are correctly stuck with or without sync_table
* Renamed sticky meta key `_bbp_old_sticky_status` to `_bbp_old_sticky_status_id` for importers that support stickies
See #2650
|
| [2489]
|
johnjamesjacoby
|
Fixes #1312 props GautamGupta
|
| [2553]
|
johnjamesjacoby
|
Fixes #1315. Introduce topic reply template tags. Props !GautamGupta
|
| [2535]
|
johnjamesjacoby
|
Fixes #1319.
|
| [2555]
|
johnjamesjacoby
|
Fixes #1321 props markmcwilliams
|
| [2586]
|
johnjamesjacoby
|
Fixes #1321. Also add checks to topic_id and forum_id functions.
|
| [2540]
|
johnjamesjacoby
|
Fixes #1326 props mr_pelle
|
| [2603]
|
johnjamesjacoby
|
Fixes #1329
|
| [2566]
|
johnjamesjacoby
|
Fixes #1333 props anthonycole
|
| [2604]
|
johnjamesjacoby
|
Fixes #1357 by rearranging the activation and deactivation procedures.
|
| [2741]
|
johnjamesjacoby
|
Fixes #1361. Introduce 'Forum Moderator' role. Props !GautamGupta via Google Code-in
|
| [2671]
|
johnjamesjacoby
|
Fixes #1372 props markmcwilliams
|
| [2672]
|
johnjamesjacoby
|
Fixes #1374
|
| [2734]
|
johnjamesjacoby
|
Fixes #1377, #1390, #1412, #1378. Error handling on form submission, and better anonymous user handling. Props !GautamGupta via Google Code-in.
|
| [2702]
|
johnjamesjacoby
|
Fixes #1383 again. Native eol-style on new files. Props westi for svn autoprops.
|
| [2679]
|
johnjamesjacoby
|
Fixes #1383 props westi
|
| [2687]
|
johnjamesjacoby
|
Fixes #1387
|
| [2705]
|
johnjamesjacoby
|
Fixes #1391 props elfin
|
| [2721]
|
johnjamesjacoby
|
Fixes #1397
|
| [2711]
|
johnjamesjacoby
|
Fixes #1399 props !GautamGupta
|
| [2712]
|
johnjamesjacoby
|
Fixes #1400 props !GautamGupta
|
| [2713]
|
johnjamesjacoby
|
Fixes #1401 props !GautamGupta
|
| [2716]
|
johnjamesjacoby
|
Fixes #1402 props !GautamGupta
|
| [2714]
|
johnjamesjacoby
|
Fixes #1403 props !GautamGupta
|
| [2764]
|
johnjamesjacoby
|
Fixes #1423. Props !GautamGupta via Google Code-in
|
| [2749]
|
johnjamesjacoby
|
Fixes #1435 props !GautamGupta
|
| [2993]
|
johnjamesjacoby
|
Fixes #1496. Documentation clean-up. Fix incorrect references to split/merge. Fix incorrect post_field usage where post_parent was used rather than post_type. Fix incorrect function usage for querying topic id's from a forum. Props !GautamGupta
|
| [5287]
|
johnjamesjacoby
|
Fixes PHPUnit Multisite tests and sets up grunt build-realease to run all PHPUnit tests when building release package (Single & Multisite.) Props netweb. See #2542.
|
| [3304]
|
johnjamesjacoby
|
Fixes to forum and topic archive links. Always set has_archive to archive slug settings. Use get_post_type_archive_link() where appropriate instead of relying on home_url( $slug ). Add bbp_get_page_by_path() function to theme compat, to check for pretty permalinks first. Introduce default 'page_for' options, which will provide a more straight-forward method of assigning WordPress pages to bbPress functionalities.
|
| [2497]
|
johnjamesjacoby
|
Fixes wrong post type count. props Nightgunner5.
|
| [3159]
|
johnjamesjacoby
|
Flesh out current-user topic-form access functions with more appropriate hierarchy of checks. Fix #1516.
|
| [3074]
|
johnjamesjacoby
|
Flush rewrite rules when the admin settings page is saved
|
| [3073]
|
johnjamesjacoby
|
Flush the rewrite rules when bbPress is activated and deactivated
|
| [5573]
|
netweb
|
FluxBB importer: Include Subscribed Forums and Subscribed Topics
Props netweb. See #2668
|
| [2646]
|
johnjamesjacoby
|
Follow my own rules in BBP_Admin
|
| [5037]
|
johnjamesjacoby
|
For all template functions that output URL's, always echo an escaped value using esc_url(). See #2367.
|
| [5001]
|
johnjamesjacoby
|
For inline code blocks in topics and replies, ensure they are vertically positioned in the middle of their respective lines of text. Fixes issue where code snippets were top-aligned based on paragraph line-height. See #2350.
|
| [5243]
|
johnjamesjacoby
|
For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (2.5 branch)
|
| [5242]
|
johnjamesjacoby
|
For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (trunk)
|
| [5227]
|
johnjamesjacoby
|
Force `colors-fresh` dependency to act as a foundation for `Mint` and `Evergreen` color schemes. Fixes #2462.
|
| [4418]
|
johnjamesjacoby
|
Force a max-width on forum drop-down in default templates.
|
| [3589]
|
johnjamesjacoby
|
Force comment_status to 'closed' for forums, topics, and replies. Fixes #1676.
|
| [2499]
|
johnjamesjacoby
|
Force counts to pick up all descendants of proper post type.
|
| [3103]
|
johnjamesjacoby
|
Force forums, topics, and replies tables to clear the pagination floating above it, for theme compat.
|
| [5392]
|
johnjamesjacoby
|
Force integer value in `bbp_has_topics()` for reply position. Fixes bug when there are more than 1,000 replies. Props DrPepper75. Fixes #2615.
|
| [2472]
|
chrishajer
|
Forgot to add in new functions.php files for kakumei and kakumei-blue. Fixes #1268. Props !GautamGupta
|
| [4278]
|
johnjamesjacoby
|
Form Actions:
* Use the_permalink() as a form action in forum/topic/reply forms.
* See #1996.
|
| [6094]
|
johnjamesjacoby
|
Format `bbp_get_reply_title()` like `bbp_get_topic_title()`.
|
| [3903]
|
johnjamesjacoby
|
Formatting:
* 'elseif' not 'else if' in bbp-template-functions.php
* Ignore my OCD.
|
| [4642]
|
johnjamesjacoby
|
Formatting:
* Rename kses.php to formatting.php.
* Port bbPress 1.1 code and pre tag handling. Comes with filters and callbacks to allow code wrapped in pre & code elements, and backticks.
* Revert r4641, r4640,
* See #1967.
|
| [6378]
|
johnjamesjacoby
|
Formatting: Add rel-nofollow to tests. See #2963.
|
| [6347]
|
johnjamesjacoby
|
Formatting: Filter out mention classes in unit tests, and remove `rel="nofollow"` on mention URLs.
Also improve array handling of `bbp_make_mentions_clickable_classes` filter, in the event something weird gets filtered through it.
See #3074.
|
| [6377]
|
johnjamesjacoby
|
Formatting: More tests for at-mentions.
Props netweb. See #2963.
|
| [6722]
|
johnjamesjacoby
|
Formatting: Use `mb_substr()` where appropriate.
This change ensures that strings which are known to contain or allow for multibyte characters are allowed to do so (in excerpts and a few server globals.)
Fixes #3170. Props it4life.
|
| [7159]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In branches/2.6, for 2.6.6. See #3398.
|
| [7160]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In trunk, for 2.7. Fixes #3398.
|
| [7120]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In branches/2.6, for 2.6.6.
Props peterkueger.
|
| [7121]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In trunk, for 2.7.
Props peterkueger.
Fixes #3390.
|
| [7082]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In 2.6 branch, for 2.6.5.
See #3371.
|
| [7083]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In trunk, for 2.7.0.
See #3371.
|
| [6861]
|
johnjamesjacoby
|
Formatting: update `bbp_get_time_since()` to accept MySQL formatted string in older & newer dates.
Also cast values to int using `intval()` to ensure math always works, without notices or errors.
This change adds a bit more validation on potentially untrusted values.
See #3216.
|
| [6885]
|
johnjamesjacoby
|
Formatting: update `bbp_make_clickable()` to better handle spaces in `href` attributes.
This change updates the included regular expression to avoid returning broken (or at least unexpected) HTML and allows spaces in `href` attributes to be encoded as expected.
Props dd32. Fixes #3237.
|
| [6555]
|
johnjamesjacoby
|
Forms: Add `autocomplete` attribute to user related form fields.
`autocomplete="new-password"` is new, and browser support is gaining, but it's also not any worse than `autocomplete="off"` (where most browsers & password managers have a hard time respecting the etiquitte anyways.)
|
| [6557]
|
johnjamesjacoby
|
Forms: Add `maxlength` attribute to the appropriate form fields.
Fields like `user_login`, `user_url`, and `user_email` have upper boundaries that cannot be extended via meta-data or other means, so let's make sure users aren't (easily) able to go over them.
For the anonymous user fields, set them up to match comment field lengths (even though they are stored in `postmeta`.)
|
| [6248]
|
johnjamesjacoby
|
Forms: Audit & normalize form-field sanitization.
* Make sure they all work the same
* Use filters in `core/filters.php` where appropriate
* Add `absint` filters for numeric values
* Add filters for per-forum moderator text field
* Remove any accidental duplicate escaping
|
| [6433]
|
johnjamesjacoby
|
Forms: Introduce `bbp_tab_index_attribute()` helpers to handle `tabindex` attribute output.
Note that these functions are used but normally their output is suppressed, because overriding the browser's natural `tabindex` order is impolite, and may introduce more issues than it actually fixes.
(Also includes some surrounding code clean-up.)
|
| [6556]
|
johnjamesjacoby
|
Forms: formally update password change text.
It was accidentally partially changed in r6555.
|
| [6837]
|
johnjamesjacoby
|
Forms: include forum/topic ID in nonce checks.
This change adds in missing object IDs, fixing a bug causing form content to be lost when an error had occurred.
Props wpdennis. Fixes #3209.
|
| [4118]
|
johnjamesjacoby
|
Forum Actions:
* Remove bbp_has_topics() from forum trash and topic delete functions.
* Use WP_Query's instead.
* Remove phpdoc references to bbp_has_topics() where it's no longer used.
* Fixes #1914.
* For 2.1 branch.
|
| [4117]
|
johnjamesjacoby
|
Forum Actions:
* Remove bbp_has_topics() from forum trash and topic delete functions.
* Use WP_Query's instead.
* Remove phpdoc references to bbp_has_topics() where it's no longer used.
* Fixes #1914.
* For 2.2 branch.
|
| [5156]
|
johnjamesjacoby
|
Forum Subscriptions - Allow users to subscribe to new topics in specific forums.
* Code largely lifted from existing Topics Subscriptions, and is based largely on `forum-subscriptions.2.diff` from mordauk, with edits for code consistency across bbPress components.
* Refactor existing ambiguous function names into base functions for both forum and topic subscriptions.
* Include new functions for getting and outputting subscriptions.
* Modify `user-subscriptions.php` to show subscribed forums. This includes a modification to `content-single-forum.php` to include the "Unsubscribe" link if looking at a user profile page.
* Modify `templates/default/bbpress-functions.php` to enqueue new JS file to handle forum subscription ajax.
* Rename HTML element classes from `bbp-topic-action` to `bbp-row-actions` to better accommodate forum subscriptions (and any future actions.)
* BuddyPress tested, JJJ approved.
* See #2299. Props mordauk, netweb for the considerable effort.
* More to do here, largely from `forum-subscriptions.3.diff`
|
| [5157]
|
johnjamesjacoby
|
Forum Subscriptions:
* Update `@since` and `@deprecated` to r5156.
* Introduce tool for removing trashed and deleted forums from user subscriptions.
* See #2299. Props netweb.
|
| [4104]
|
johnjamesjacoby
|
Forum Visibility:
* Prevent forum metaboxes from saving forum revisions as private/hidden.
* Add repair function for private/hidden forums to Tools.
* Add updater for 2.1.1, and run the visibility repair function.
* Fixes #1891.
* For 2.1 branch.
|
| [4105]
|
johnjamesjacoby
|
Forum Visibility:
* Prevent forum metaboxes from saving forum revisions as private/hidden.
* Add repair function for private/hidden forums to Tools.
* Add updater for 2.1.1, and run the visibility repair function.
* Fixes #1891.
* For 2.2 branch.
|
| [4416]
|
johnjamesjacoby
|
Forums Admin:
* More aggressive CSS for forum parent.
|
| [4414]
|
johnjamesjacoby
|
Forums Admin:
* Revert usage of Suggest for choosing a forum parent via auto-complete.
* Revert parts of r4260 and r4261.
* See #1910, #2014.
|
| [4415]
|
johnjamesjacoby
|
Forums Admin:
* Set max-width to 170px for forum parent ID.
|
| [4417]
|
johnjamesjacoby
|
Forums Admin:
* Update 'order' and 'orderby' for get_posts() usage to sort by 'title' and not 'post_title'.
|
| [7350]
|
johnjamesjacoby
|
Forums/Topics/Replies: Add capability checks for parent object IDs when users are creating & editing content theme-side.
This change introduces a series of matching capability checks to the new/edit handler functions, that ensure the currently logged in user can read the proposed parent location for their content.
This change includes checks for anonymous users (when enabled) mapping "read" checks for public forums/topics/replies to `exist` so they can continue to post the same as before.
It also removes a few private/hidden error messages and replaces them with more generic phasing, to minimize leakage about content that is not publicly accessible.
The intent with these changes is to account for and trap any mismatches between where content handler functions are listening vs. what the user has access to create new content inside of – if they cannot read it, they cannot create new content in it, and will now see errors letting them know.
In trunk, for 2.7.
Fixes #3650.
|
| [4071]
|
johnjamesjacoby
|
Forums:
* Do not add forum-exclude meta-query to single reply queries.
|
| [4438]
|
johnjamesjacoby
|
Forums:
* Do not disable categories on forum parent drop downs in wp-admin.
* Disable forum parents in topic and reply edits if user cannot edit forums.
* This is to prevent innocent users from accidentally putting content in a forum category.
|
| [4167]
|
johnjamesjacoby
|
Forums:
* Remove superfluous is_super_admin() login in bbp_has_forums().
* Capes always pass current_user_can() checks unless specifically not allowed, which is the intended behavior here.
|
| [6273]
|
johnjamesjacoby
|
Forums: Add `howto` text to `bbp_moderator_assignment_metabox()`.
See #459.
|