Skip to:
Content

bbPress.org

{33} Commit Messages, Current Release (4934 matches)

Report designed to help manage the list of contributors.

Note: If you'd like a RSS feed of the changesets a they happen, Please use the timeline rss feed instead.

Results (1701 - 1800 of 4934)

Changeset Author Message
[7151] johnjamesjacoby Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`. This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges. In branches/2.6, for 2.6.6. Fixes #3405. Props muratgu.
[7152] johnjamesjacoby Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`. This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges. In trunk, for 2.7. Fixes #3405. Props muratgu.
[5496] johnjamesjacoby Embetter Orwellian Newspeak used to describe sticky topics in `admin/topics.php`. Props netweb. Fixes #2622.
[5499] johnjamesjacoby Enable forum status and visibility functions to check ancestry by extracting existing logic into new helper functions. Props alex-ye, netweb. Fixes #2303.
[5168] johnjamesjacoby Enable pingbacks for CPT's when creating in wp-admin. Fixes #2297.
[5169] johnjamesjacoby Enable pingbacks for forum CPT when creating in wp-admin. See #2297.
[6327] johnjamesjacoby Engagements/BuddyPress: Add `@since` for changes in 2.6.0, and a bit more clean-up. See #3068.
[6326] johnjamesjacoby Engagements/BuddyPress: Finish integration, and clean-up favorites & subscriptions support. See #3068.
[6322] johnjamesjacoby Engagements: Add `bbp_is_engagements_active` to default options array. See #3068.
[6768] johnjamesjacoby Engagements: Add relationship key and type to `bbp_user_engagements_interface()`. This allows for per-feature overloading of the engagement relationship type – useful if you want to store some data as a taxonomy, some data as meta, and other data in custom storage.
[6321] johnjamesjacoby Engagements: Allow engagements to be toggled on/off, for forums that have not run the upgrade routine yet. Also missed a spot in the BuddyPress integration. See #3068.
[6332] johnjamesjacoby Engagements: First pass at a `user_query`, which will be used for looping through users. * Introduces `BBP_User_Query` which extends `WP_User_Query` * Includes functions for use within template parts See #3068.
[6311] johnjamesjacoby Engagements: First pass at engagement user functions. Also update favorite/subscription documentation where inaccurate. See #3068.
[6320] johnjamesjacoby Engagements: First pass at: * User profile section * Template parts changes * Rewrite rules support * Repair & upgrade tools * BuddyPress support * `engagement` slug setting See #3068.
[6323] johnjamesjacoby Engagements: Fix copy/paste error in r6322. See #3068.
[6340] johnjamesjacoby Engagements: Improve efficiency of upgrade & repair tools. Props thebrandonallen. See #3068.
[6334] johnjamesjacoby Engagements: Integrate the `user_query` into favorites, subscriptions, and engagements. * Add to admin metabox avatar loops * Fix a few bugs in `BBP_User_Query`, and include a custom constructor to set the loop counter See #3068.
[6522] johnjamesjacoby Engagements: Introduce 2 new functions for recalculating engagements. * `bbp_get_topic_engagements_raw()` to efficiently query for users who have engaged in a topic * `bbp_recalculate_topic_engagements()` to update all of the related meta-data See #3068.
[6517] johnjamesjacoby Engagements: Introduce `bbp_remove_user_from_all_objects()`. This is useful for when a user is permanently deleted, or when all of their relationship(s) (of a certain type) need to be removed. See #3068.
[6529] johnjamesjacoby Engagements: Keep topic engagement counts up-to-date. This changes the way the old 'voice count' works with the new engagements API in the following ways: * Introduce new function to update voice count meta when necessary * Modify recalculation function with a `$force` parameter, and only recalculate the counts when the engagements have changed by default * Hook the above functions in where appropriate, largely when deleting replies (this is a unique case where a fully deleted reply needs to check if the author of the current reply has a previously public reply in that same topic already, which should not trigger a recalculation.) * We are silently moving the `bbp_delete_` actions onto the `before_delete_post` hook, so that all term & meta-data is available to them (which helps with race conditions mentioned in r6528) Engagements are now hooked in and listening in the most efficient way possible, at least until a common & shared walker is introduced for the entire tree. See: #3068.
[6369] johnjamesjacoby Engagements: Move engagement count updates to action hooks. Props thebrandonallen. Fixes #3068.
[6446] johnjamesjacoby Engagements: Performance optimizations to `bbp_update_topic_voice_count()`. * Use a `UNION` query strategy (only on the `wp_posts` table) * Compare old count to new count before deleting & updating engagements Fixes #3083. Props januzi_pl.
[6324] johnjamesjacoby Engagements: Prefer `bbp_admin_upgrade_user_engagements()` over the old repair tool. See #3068.
[6439] johnjamesjacoby Engagements: Remove `bbp_get_topic()` checks from engagements. See #3083.
[6515] johnjamesjacoby Engagements: Remove duplicate type castings from return values. This removes `(bool)` usages where there is no way the return value would ever not be a boolean.
[6534] johnjamesjacoby Engagements: Revert part of r6525, and adjust some actions. * Engagements will need to be "public only" for 2.6, and we can reconsider what private/hidden engagements look like later * Make sure that engagements are saved before voice counts are done * Use new `is_public` style wrapper function for topics & replies where appropriate * Remove a few `current_filter()` checks that should no longer be necessary with current action hook implementation * There may be more clean-up necessary here, but this is required to bring all unit-tests back to passing as they've been written, specifically things hooked to the `bbp_insert_topic` and `bbp_insert_reply` hooks See #3068. Hat-tip netweb.
[6389] johnjamesjacoby Engagements: Simplify `bbp_is_user_engaged()`. * Remove `$engagements` gathering & return in filter * Remove topic verification dance (no reason to re-get or guess at the topic) * Add `$user_id` validation Props thebrandonallen. FIxes #3090.
[6525] johnjamesjacoby Engagements: Tracking is not just for public or closed topics. This commit updates the engagement upgrade tool and recalculation helper functions to not be limited to public & closed post statuses. Engagements can happen on private or hidden topics also, including trash, spam, and so on. The non-visible topics that a user is engaged in should be filtered out as needed when queried based on `post_status` or other various meta-data. See #3068.
[6518] johnjamesjacoby Engagements: Update `bbp_add_user_object()`. * New phpdoc description * Add `$unique` parameter and default to `true` (this differs from the normal `false` default of `add_metadata()` because, by default, this API assumes no 1 user can have multiple relationships with the same object) * Pass `$unique` into `apply_filters()` See #3068.
[6516] johnjamesjacoby Engagements: Update `bbp_update_topic_voice_count()` to only count the number of existing engagements. Recalculating the entire engagement tree for each topic is costly, should be done in its own dedicated function, and then only hooked in or executed when absolutely necessary. This is easier to do with the engagements API that's new in 2.6. Recalculation function imminent. See #3068.
[6521] johnjamesjacoby Engagements: Update phpdoc for `bbp_add_user_to_object()`. * Replace `add_post_meta()` with `add_metadata()` See #3068.
[6530] johnjamesjacoby Engagements: Update topic engagements when they are manually inserted. This brings the `_insert_` functions up to date with the `_new_` equivalents. See: #3068. Props netweb & unit-tests for catching this.
[6330] johnjamesjacoby Engagements: Updates existing functions & unit tests: * Correct tests so that `post_author` of 0 does not get included in the overall count * Add user IDs to all topics & replies where voice counts are being tested * Update voice-count update function to use the new user-relationships API * Clean-up topic merge code to more efficiently migrate favorites, subscriptions, and engagements See #3068.
[6520] johnjamesjacoby Engagements: Updates to phpdoc & helper functions. * New function to remove all users from an object * New function to remove all users from all objects * Remove references to taxonomy term storage (from original implementation) * Update phpdoc with more accurate descriptions of intended parameter usages See #3068.
[6723] johnjamesjacoby Engagements: abstract meta strategy into an overload'able class. This change introduces a class and wrapper function to allow the `meta` strategy of the new user engagements API to be hot-swapped. This might be helpful on large installations where a dedicated database table makes more sense, or for integrations where features like "Favorites" or "Subscriptions" might already be delegated to other third-party membership plugins. Now, the caller class can be filtered to one that includes custom methods. See #3068.
[6992] johnjamesjacoby Engagements: add caching to User strategy, for 2.5 compatibility. This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s). Props johnjamesjacoby, netweb. Fixes #3292. For 2.6.3, branches/2.6.
[6993] johnjamesjacoby Engagements: add caching to User strategy, for 2.5 compatibility. This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s). Props johnjamesjacoby, netweb. Fixes #3292. For 2.7, trunk.
[6914] johnjamesjacoby Engagements: always show user avatars in subscription/favorite metaboxes. This commit introduces a helper function (to reduce code duplication) responsible for looping through queried users and outputting avatars and profile links. A developers note is included in the function docs discouraging third-party plugin developers from using it, as future iterations of bbPress may modify its output without notice. Fixes #3272.
[6877] johnjamesjacoby Engagements: demystify strategy sanitization. This change ensures that invalid/unavailable strategies are never used, and also allows for custom strategies to exist (custom table, etc...) without requiring strategy registration. See #3211.
[6843] johnjamesjacoby Engagements: documentation improvements to various strategy classes. See #3211.
[6828] johnjamesjacoby Engagements: enforce `absint()` on function parameters in engagements API. Also fixes a bug causing an `array_search()` to erroneously fail. See #3206.
[7003] johnjamesjacoby Engagements: explicitly query for `-1` posts if no objects are known to exist. This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
[7002] johnjamesjacoby Engagements: explicitly query for `-1` posts if no objects are known to exist. This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
[7005] johnjamesjacoby Engagements: explicitly query for `-1` posts if no objects are known to exist. This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them. Revert r7002 and use a different syntax to avoid debug notices.
[7004] johnjamesjacoby Engagements: explicitly query for `-1` posts if no objects are known to exist. This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them. Revert r7003 and use a different syntax to avoid debug notices.
[6844] johnjamesjacoby Engagements: first pass at back-compat for pre-2.6 subscriptions and favorites Introduces a `BBP_User_Engagements_Back_Compat` class with the necessary inverted methods to add/remove engagement relationships. Needs testing, and `get_query()` left todo. See #3211.
[7023] johnjamesjacoby Engagements: fix bugs with caching implementation in User strategy. This commit adds the `$object_id` to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit `true` comparisons because internal calls to `update_meta()` up the stack may return an integer. See #3292. For 2.6.4, branches/2.6.
[7024] johnjamesjacoby Engagements: fix bugs with caching implementation in User strategy. This commit adds the `$object_id` to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit `true` comparisons because internal calls to `update_meta()` up the stack may return an integer. See #3292. For 2.7, trunk.
[6739] johnjamesjacoby Engagements: include `BBP_User_Engagements_Term` class, as term storage example. This change includes an alternative storage mechanism for engagements. Meta is used by default, but using Taxonomies and Terms for storage instead may be more appealing to certain installation types. A few related functions were updated to use newer abstractions. See #459.
[6842] johnjamesjacoby Engagements: move common classes out of abstraction.php. See #3211.
[6876] johnjamesjacoby Engagements: next pass at back-compat for pre-2.6 `user` strategy. * Renames `BBP_User_Engagements_Back_Compat` to `BBP_User_Engagements_User` so the approach is more clear. * Fill in `get_query()` method, left todo from r6844. * Move active strategy into a preloaded option, default to `meta` * Set active strategy to `user` on failed auto-upgrade to 2.6 to maintain backwards compatibility * Introduces sub-actions to assist with abstracting the engagement strategy setup Fixes #3211.
[7012] johnjamesjacoby Engagements: stop shouting. This commit removes the last remaining exclamation mark from some engagements feedback. Props casiepa. Fixes #3293. For 2.6.3, branches/2.6.
[7013] johnjamesjacoby Engagements: stop shouting. This commit removes the last remaining exclamation mark from some engagements feedback. Props casiepa. Fixes #3293. For 2.7, trunk.
[7026] johnjamesjacoby Engagements: update cache groups in User strategy. This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly. See #3292. For 2.6.4, branches/2.6.
[7025] johnjamesjacoby Engagements: update cache groups in User strategy. This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly. See #3292. For 2.7, trunk.
[3494] johnjamesjacoby Enhancements to core slug conflict checker. Add context to item args te better hint where conflict is.
[4671] johnjamesjacoby Enqueue jQuery in default templates, to fix issue with head scripts not having jQuery available in shortcodes, or places where TinyMCE might be pulled into the theme.
[3084] johnjamesjacoby Enqueue the default style.css for twentyten parent template now that bbp-twentyten is a child theme again.
[3335] johnjamesjacoby Ensure $bbp global is in $GLOBALS
[4777] johnjamesjacoby Ensure network admins can always view group forum forms. Props thebrandonallen. Fixes #2214.
[4825] johnjamesjacoby Ensure textarea content shows correct return $_POST value by adding stripslashes() to bbp_get_form_*_content() functions.
[3189] johnjamesjacoby Ensure that author avatars appear at the top of the reply area, for theme compat.
[3420] johnjamesjacoby Ensure that default role exists, and default to 'read' cap if it does not.
[6062] johnjamesjacoby Escape `display_name` field usages in `bbp_get_author_link()`.
[6063] johnjamesjacoby Escape `display_name` field usages in `bbp_get_author_link()`. (2.5 branch)
[4952] johnjamesjacoby Escape output of translation strings where appropriate. Refresh some escaping approaches. See #1999.
[6141] johnjamesjacoby Even less shouting, plus a grammar sweep. * Remove contractions * Update weird sounding English phrases (like "the permissions" to "permission") * Simplify some phrases to be less wordy * Update "permission" error codes to all use "permission" instead of also "permissions" * Add comma to "Oh bother!". See: https://www.youtube.com/watch?v=Fhl4oKvxphs
[5799] netweb Example importer: Change AIM, YIM, and Jabber profile fields to generic examples with meta key prefixes Props netweb. See #2815
[5580] netweb Example importer: Include Subscribed Forums, Subscribed Topics and Favourite Topics Props netweb. See #2668
[5672] netweb Exclude BuddyPress tests when running `phpunit` BuddyPress unit testing will conflict with stand alone bbPress user testing, when BuddyPress is active the core members component cannot be deactivated thus testing users with BuddyPress at `/member/username` vs bbPress only `/user/username` and custom rewrites `/custom-user-slug/username` will cause conflicts in user PHPUnit tests. A new Grunt sub task `grunt phpunit:buddypress` has been added to test BuddyPress integration with bbPress without compromising bbPress standalone PHPUnit testing. Props netweb. See #2782
[3247] johnjamesjacoby Exclude forums, topics, and replies from site wide post and page search. We have our own search queries for each post type, and it's not currently possible to adjust the look of individual search results on the fly via theme compatibility.
[5290] johnjamesjacoby Experiment with `grunt-pot`: * Add `grunt-pot` to `package.json` * Adds grunt task `pot` to `grunt build` and `grunt build-release` * Creates `bbpress.pot` in `/build` & removes `bbpress.pot` from `/src` * Checks for the following keywords: `__`, `_e`, `_x`, `_n`, `_ex`, `_nx`, `esc_attr__`, `esc_attr_e`, `esc_attr_x`, `esc_html__`, `esc_html_e`, `esc_html_x`, `_nx_noop` * Props netweb. See #2542.
[7324] johnjamesjacoby Extend - Akismet: avoid timeouts in the `delete_orphaned_spam_meta()` method. This change modifies the SQL used to query for Akismet post-meta keys, such that it will only retrieve rows where `meta_key` is like `akismet_`. This results in a less-optimized database query, but circumvents a bug where unnecessary rows were being looped through in a way that would never finish. Props terresquall. In branches/2.6, for 2.6.14. Fixes #3580.
[7325] johnjamesjacoby Extend - Akismet: avoid timeouts in the `delete_orphaned_spam_meta()` method. This change modifies the SQL used to query for Akismet post-meta keys, such that it will only retrieve rows where `meta_key` is like `akismet_`. This results in a less-optimized database query, but circumvents a bug where unnecessary rows were being looped through in a way that would never finish. Props terresquall. In trunk, for 2.7. Fixes #3580.
[7310] johnjamesjacoby Extend - BuddyPress - Members: correct a deprecated function usage. This change adds a private method to encapsulate support for `bp_core_get_user_domain()` if it is still explicitly included, and using `bp_members_get_user_url()` otherwise. Props davidbaumwaid, sirlouen. In branches/2.6, for 2.6.14. Fixes #3617.
[7309] johnjamesjacoby Extend - BuddyPress - Members: correct a deprecated function usage. This change adds a private method to encapsulate support for `bp_core_get_user_domain()` if it is still explicitly included, and using `bp_members_get_user_url()` otherwise. Props davidbaumwaid, sirlouen. In trunk, for 2.7. Fixes #3617.
[7311] johnjamesjacoby Extend - BuddyPress - Members: correct default value from r7309. Change from string to array, to avoid a potential PHP warning. See #3617.
[7307] johnjamesjacoby Extend - BuddyPress - Notifications: redirect to reply when clicking a notification. This change ensures that members are redirected to the appropriate reply URL rather than the parent topic URL. It also now marks replies before marking the topic, and combines the updated rows together. Props cjerrells. In branches/2.6, for 2.6.14. Fixes #3638.
[7308] johnjamesjacoby Extend - BuddyPress - Notifications: redirect to reply when clicking a notification. This change ensures that members are redirected to the appropriate reply URL rather than the parent topic URL. It also now marks replies before marking the topic, and combines the updated rows together. Props cjerrells. In trunk, for 2.7. Fixes #3638.
[7317] johnjamesjacoby Extend - BuddyPress: Improve support for BuddyPress 12.0 and higher. This change fixes fatal errors when BuddyPress Group/Member functions (deprecated in 12.0) are not included. (Note that this commit differs from the proposed patch in that it does not modify the action-order of existing integrations, hence it does not rely on BuddyPress versions greater than 12.0 being in-use, and is safe for use with older BuddyPress versions.) Props boonebgorges, imath, robin-w. In branches/2.6, for 2.6.14. Fixes #3576.
[7316] johnjamesjacoby Extend - BuddyPress: Improve support for BuddyPress 12.0 and higher. This change fixes fatal errors when BuddyPress Group/Member functions (deprecated in 12.0) are not included. (Note that this commit differs from the proposed patch in that it does not modify the action-order of existing integrations, hence it does not rely on BuddyPress versions greater than 12.0 being in-use, and is safe for use with older BuddyPress versions.) Props boonebgorges, imath, robin-w. In trunk, for 2.7. Fixes #3576.
[7337] johnjamesjacoby Extend - BuddyPress: remove unused variables. This change deletes 2 lines of code (in `maybe_map_permalink_to_group()`) that are no longer being used. Props upadalavipul. In branches/2.6, for 2.6.14. Fixes #3555.
[7336] johnjamesjacoby Extend - BuddyPress: remove unused variables. This change deletes 2 lines of code (in `maybe_map_permalink_to_group()`) that are no longer being used. Props upadalavipul. In trunk, for 2.7. Fixes #3555.
[7306] johnjamesjacoby Extend - BuddyPress: reserve space for Members/Activity components. This change prevents PHP deprecation notices from dynamic properties being invoked without being previously declared. In branches/2.6, for 2.6.14.
[7305] johnjamesjacoby Extend - BuddyPress: reserve space for Members/Activity components. This change prevents PHP deprecation notices from dynamic properties being invoked without being previously declared. In trunk, for 2.7.
[6180] johnjamesjacoby Extend: Consolidate some BuddyPress hooks to the top of each file.
[6172] johnjamesjacoby Extend: Fix a typo in docs.
[4395] johnjamesjacoby Extensions: * Introduce core/extend.php to assist in loading extentions in a more common way. * Move some !BuddyPress code around, into the files it makes the most sense for it to be in. * Remove some redundant !BuddyPress loader code.
[4489] johnjamesjacoby Extract: * Brackets in bbp_update_forum_reply_count().
[4508] johnjamesjacoby Extract: * Clean up bbp_parse_args() usages and inline documents. * Fixes #2056.
[4480] johnjamesjacoby Extract: * Remove extract() calls from some statistics functions. * See #2056.
[4499] johnjamesjacoby Extract: * Remove extract() from bbp_check_for_duplicate(). * Improve code in bbp_check_for_duplicate() to support this. * See #2056.
[4487] johnjamesjacoby Extract: * Remove extract() from bbp_create_initial_content(). * See #2056.
[4481] johnjamesjacoby Extract: * Remove extract() from bbp_filter_anonymous_post_data(). * See #2056.
[4483] johnjamesjacoby Extract: * Remove extract() from bbp_get_breadcrumb(). * Other general code cleanup. * See #2056.
[4485] johnjamesjacoby Extract: * Remove extract() from bbp_get_dropdown(). * Other general code cleanup. * See #2056.
[4502] johnjamesjacoby Extract: * Remove extract() from bbp_get_single_forum_description(). * See #2056.
[4484] johnjamesjacoby Extract: * Remove extract() from bbp_get_the_content(). * Other general code cleanup. * See #2056.
[4503] johnjamesjacoby Extract: * Remove extract() from bbp_list_forums(). * See #2056.
[4488] johnjamesjacoby Extract: * Remove extract() from bbp_update_forum(). * See #2056.
Note: See TracReports for help on using and creating reports.