| [6490]
|
johnjamesjacoby
|
Converter: Use the port number in the server address if available.
Fixes #3022.
|
| [6788]
|
johnjamesjacoby
|
Converter: add filter to `bbp_new_converter()`.
This change makes it possible to include a custom converter class for the platform being converted from, especially useful if you've changed password storage schemas or want to handle data migration in a way that is specific to your needs.
See #3191.
|
| [6763]
|
johnjamesjacoby
|
Converter: add inline documentation for `wp_insert_user()`.
This change adds an inline reminder about what `wp_insert_user()` does internally, so our future selves know at a glance why else a user might be skipped.
|
| [6662]
|
johnjamesjacoby
|
Converter: bind number-of-rows attribute to between 1 and 5000.
This change adds validation to ensure no unexpected number of database rows are queried, and also back-ports sanitization to database connection values from trunk.
2.5 branch, for 2.5.14. Props jrf. Fixes #3148.
|
| [6661]
|
johnjamesjacoby
|
Converter: bind number-of-rows attribute to between 1 and 5000.
This change adds validation to ensure no unexpected number of database rows are queried.
Trunk, for 2.6. Props jrf. See #3148.
|
| [6663]
|
johnjamesjacoby
|
Converter: ensure UI state variables are correctly localized.
This change combines the new UI state variables into an array, so they retain their type-casting through the localization API. It also inverts the logic in 1 comparison to make sure the correct user feedback is displayed in its intended location.
Trunk, for 2.6. Props jrf. Fixes #3146.
|
| [7246]
|
johnjamesjacoby
|
Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In branches/2.6, for 2.6.10.
See #3419.
|
| [7245]
|
johnjamesjacoby
|
Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In trunk, for 2.7.0.
See #3419.
|
| [6832]
|
johnjamesjacoby
|
Converter: make a few `private` properties `protected` so subclasses can reach them.
This change fixes a bug causing the e107v1 converter to fail.
Props wpdennis. Fixes #3207.
|
| [6670]
|
johnjamesjacoby
|
Converter: more OOP, specifically for the BBCode parser.
This change introduces a `bbcode_parser_properties` array to the base converter, allowing custom BBCode parser properties to be passed into the parent method via the child, minimizing the amount of code in each individual forum converter.
Trunk, for 2.6.
|
| [6681]
|
johnjamesjacoby
|
Converter: progress bars and percentages.
This change incorporates 2 horizontal bars in the importer header area. One indicates how far the current step has progressed, and the other indicates total progress. Pretty sweet.
Trunk, for 2.6.
|
| [6666]
|
johnjamesjacoby
|
Converter: reduce `meta_key` and `meta_value` length to `75`.
This change lowers the maximum allowed string length from `191` (which was used based on what's in WordPress core.) After further review, `75` is a reasonable maximum to try for now, though it could likely be tuned further if needed.
Trunk, for 2.6. Fixes #3145.
|
| [6785]
|
johnjamesjacoby
|
Converter: remove `WP_SETUP_CONFIG` constant setting from converter process.
This introduces a helper database class to avoid directly connecting to the external database. Instead, we'll attempt to control that connection, and provide feedback to the user in the event a connection cannot be made. The `WP_SETUP_CONFIG` was causing calls to the options API to fail, resulting in broken calculations and invalid offsets.
This commit includes some general load order clean-up, which also fixes a regression causing fatal errors when attempting to upgrade converted user passwords from the old platform. It also fixes the condition where boundaries being converted would display beyond their maximums.
Fixes #3191.
|
| [7256]
|
johnjamesjacoby
|
Converter: remove `__destruct()` registration
This change removes the need for `wpdb` extensions (like in the Converter) to register their own shutdown methods.
This is necessary because the `__destruct()` method was removed in the parent `wpdb` class, so attempting to add it in the subclass will generate PHP errors.
See #WP21402.
Fixes #3508.
Props GDragoN, dd32.
In branches/2.6, for 2.6.10.
|
| [7243]
|
johnjamesjacoby
|
Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In branches/2.6, for 2.6.10.
Props sirlouen. Fixes #3419.
|
| [7244]
|
johnjamesjacoby
|
Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In trunk, for 2.7.0.
Props sirlouen. Fixes #3419.
|
| [6820]
|
johnjamesjacoby
|
Converter: remove `safe_mode` check from `BBP_Converter::maybe_set_memory()`.
This was deprecated in PHP 5.3.0 and removed in 5.4.0. Instead, this change employs the following:
* Moves keys and values into a filterable array
* Looks for disabled functions and avoids them
* Adds error control operators as needed
|
| [6671]
|
johnjamesjacoby
|
Converter: softer verbiage on the importer buttons.
This changes "Stop" to "Pause" and "Continue" to "Resume". This more accurately represents the actions these buttons perform, while also inspiring a bit more confidence that the converter can be halted and resumed at anytime.
Trunk, for 2.6.
|
| [6809]
|
johnjamesjacoby
|
Converter: update phpBB importer to use `user_form_salt`.
Props jrf. Fixes #3192.
|
| [6665]
|
johnjamesjacoby
|
Converter: use `esc_like()` to avoid debug notice when cleaning users.
This change runs the `_bbp_` `meta_key` prefix through `esc_like()`, ensuring that the subsequent `prepare()` call has a value passed into it.
Trunk, for 2.6.
|
| [4119]
|
johnjamesjacoby
|
Converters:
* Classes are case sensitive when being loaded by the main converter.
* Fixes #1886.
* For 2.1 branch.
* Props netweb.
|
| [4101]
|
johnjamesjacoby
|
Converters:
* Classes are case sensitive when being loaded by the main converter.
* Fixes #1886.
* Props netweb.
|
| [4102]
|
johnjamesjacoby
|
Converters:
* Revert whitespace changes in r4101.
* See #1886.
* Antiprops netweb.
|
| [6293]
|
netweb
|
Converters: Fix PHPDoc indentation in `Invision.php`
|
| [6449]
|
johnjamesjacoby
|
Converters: Fix formatting on several converter methods.
|
| [7014]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.6.3, branches/2.6.
|
| [7015]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.7, trunk.
|
| [6476]
|
johnjamesjacoby
|
Converters: Port r5332 to 2.5 branch.
See #2558, #3112.
|
| [4201]
|
johnjamesjacoby
|
Copy /branches/plugin/ to /trunk/
|
| [2470]
|
johnjamesjacoby
|
Copy paste owns me.
|
| [7348]
|
johnjamesjacoby
|
Core - Canonical: Convert `bbp_redirect_canonical()` into a sub-action.
This change abstracts the existing internal canonical redirect logic into new dedicated functions so that they can be individually improved or customized in the future.
Pagination and Editing theme-side require intercepting and preventing the core redirection when requesting certain URLs, and there are likely to be new conditions in the future.
In trunk, for 2.7.
Fixes #3648.
|
| [7394]
|
johnjamesjacoby
|
Core - Theme Compat: add Block Theme support.
This commit includes the following changes:
* Deprecates `bbp_get_theme_compat_templates()` for a singular version
* Introduces `bbp_get_theme_canvas_template()` to retrieve a filtered path to `theme-canvas.php`
* Introduces `bbp_get_template_include_templates()` to retrieve a filtered array of checker & getter functions
* Simplifies `bbp_template_include_theme_supports()` into a foreach loop
* Simplifies `bbp_is_template_included()` usage inside of `bbp_template_include_theme_compat()` by removing the later check now that `404`'s are handled elsewhere
Props mikachan, robin-w, arafatjamil01, johnjamesjacoby.
Fixes #3487.
In trunk, for 2.7.
|
| [4209]
|
johnjamesjacoby
|
Core Functions:
* Simplify logic in bbp_has_errors().
|
| [3899]
|
johnjamesjacoby
|
Core:
* Add new bbp-core-functions.php file to bbp-includes.
* Move functions out of bbp-common-functions.php and into bbp-core-functions.php and bbp-topic-template.php.
* Paves way for bbPress function map API.
|
| [6672]
|
johnjamesjacoby
|
Core: Add `source` parameter to API registrations.
This change makes it easier to target bbPress-specific post types & statuses, and taxonomies. `source` may not be the final key, but thankfully all of these APIs accept additional keys, and if support is added to core eventually, we can easily migrate over to it without problems.
Trunk, for 2.6. See: https://core.trac.wordpress.org/ticket/41739
|
| [6329]
|
johnjamesjacoby
|
Core: Allow custom post authors for initial content (forum/topic/reply).
|
| [5736]
|
johnjamesjacoby
|
Core: Correct phpdoc to `_update_` functions. Also introduce `bbp_update_reply_to_id()` to help with saving of hierarchical reply metadata. (Will be used in a future commit.)
|
| [5733]
|
johnjamesjacoby
|
Core: Force-clear post caches on several common moderation actions.
Fixes inconsistencies around cached objects related to counts, which are currently stored in metadata.
Props thebrandonallen, netweb. See #2801.
|
| [6353]
|
johnjamesjacoby
|
Core: General core function clean-up.
Mostly odds & ends, formatting, type-casting, etc...
|
| [6531]
|
johnjamesjacoby
|
Core: Register, then enqueue, both scripts and styles.
This commit makes sure that theme compatibility styles & scripts are properly registered & enqueued.
Props r-a-y. Fixes #3115.
|
| [5945]
|
netweb
|
Core: Restore empty `$wp_filter[ $tag ]` check and update PHPDoc in `bbp_get_template_stack()`
See #2871
|
| [5735]
|
johnjamesjacoby
|
Core: Return the filtered results of ID's in core `_update_` functions.
This helps with various type-casting improvements going into #2801.
|
| [6058]
|
johnjamesjacoby
|
Core: Revert accidental removal of r6054 from r6056.
|
| [5944]
|
netweb
|
Core: Support for `WP_Hook` in `bbp_get_template_stack()`
The proposed `WP_Hook` #WP17817 breaks backward compatibility for plugins that
attempt to manipulate `$wp_filter` in certain ways. For bbPress, it means
that we cannot directly modify the callbacks that are currently registered as
an array at `$wp_filter[ $tag ]`, in `bbp_get_template_stack()`. Instead, when
`WP_Hook` is not available, we assign the callbacks to a variable (leveraging
`WP_Hook`'s `ArrayAccess`) and manipulate the variable.
Props jbrinley. Fixes #2871
|
| [6183]
|
johnjamesjacoby
|
Core: Upgrade routine for favorites & subscriptions in 2.6.0.
* Use the new upgrade tools
* Bump the DB version to `260`
* Improve inline docs in upgrade tool functions
See #2959.
|
| [6039]
|
johnjamesjacoby
|
Core: pass the original text into `bbp_make_clickable` filter.
|
| [7282]
|
johnjamesjacoby
|
Core: remove reference to bbPress::setup_globals()
This method was removed long ago, and replaced by the `bbp_setup_globals` sub-action.
|
| [7281]
|
johnjamesjacoby
|
Core: small updates to bbPress()->data
This change tweaks the code commentary a bit, and adds a default value of an empty array.
This is largely for the sake of code cleanliness, but also removes the potential for debug notices or errors inside of the magic methods from `data` not being initialized as an array when they are first called.
|
| [4802]
|
johnjamesjacoby
|
Correct /users/template-tags.php inline doc typo. Props netweb. Fixes #2251.
|
| [2738]
|
johnjamesjacoby
|
Correct @since docs
|
| [2554]
|
johnjamesjacoby
|
Correct @since's
|
| [5410]
|
johnjamesjacoby
|
Correct `bbp_stuck_topic` phpdoc. See #2494.
|
| [2797]
|
johnjamesjacoby
|
Correct cap on Add User admin menu, and add cap check to submenus. Fixes #1368
|
| [4801]
|
johnjamesjacoby
|
Correct closing HTML tag helper doc in content-single-topic-lead.php Props netweb. Fixes #2252.
|
| [3616]
|
johnjamesjacoby
|
Correct core languages path in bbp-languages/index.php
|
| [4794]
|
johnjamesjacoby
|
Correct file description in content-statistics.php. Props alexvorn2. Fixes #2247.
|
| [2475]
|
chrishajer
|
Correct function name and add information to cookies for anonymous posting. Fixes #1311. Props !GautamGupta
|
| [5474]
|
johnjamesjacoby
|
Correct inline doc in `bbp_forum_get_subforums()`.
|
| [4907]
|
johnjamesjacoby
|
Correct the error ID's used when posting a new reply if the forum is closed, private, or hidden, and the user does not have proper capabilities. (2.3 branch)
|
| [4904]
|
johnjamesjacoby
|
Correct the error ID's used when posting a new topic if the forum is closed, private, or hidden, and the user does not have proper capabilities. (2.3 branch)
|
| [4903]
|
johnjamesjacoby
|
Correct the error ID's used when posting a new topic if the forum is closed, private, or hidden, and the user does not have proper capabilities. (trunk)
|
| [4936]
|
johnjamesjacoby
|
Correct typo that snuck in after testing. See #1500.
|
| [6319]
|
johnjamesjacoby
|
Correct typos in User Template phpdoc blocks.
|
| [2803]
|
johnjamesjacoby
|
Correctly check for WP_Error and correctly load anonymous user cookie data/avatar. Fixes #1452. Props !GautamGupta
|
| [5404]
|
johnjamesjacoby
|
Correctly compare source & destination topic `post_date` values in `bbp_merge_topic_handler()`. Fixes issue where incorrect post would be updated when merging older topics into newer ones.
Also update the reply position for all newly relocated replies. Hat-tip netweb. Fixes #2528.
|
| [3844]
|
johnjamesjacoby
|
Correctly show sticky topics when viewing a topic archive or using a topic archive shortcode.
|
| [6923]
|
johnjamesjacoby
|
Counts (meta-data): full audit of forum/topic/reply, public/non-public counts.
This commit is the result of a full count audit, exposing multiple inconsistencies and voids in relation to how public and non-public counts are (re)calculated.
For instance, hidden forum replies are not counted at all, until now. By introducing a new Repair tool, hidden forum reply counts are now counted.
In addition, there were multiple bugs with topic & reply moderation, where the act of approving or unapproving topics or replies would cause the numbers to be inaccurate, or where topics & replies being caught in moderation were still increasing public counts.
It was also possible to, as a Key Master, publicly reply to unapproved topics, which was a completely unanticipated side-effect of allowing Key Masters to do pretty much anything. Going forward, the default reply status is the topic status, but is still beholden to all existing moderation settings and user role capabilities. This results in a more sane user experience, and prevents the unusual circumstance of there being "0 topics and 30 replies" in public-facing forums.
Certain count increase/decrease actions have been reprioritized to avoid collisions and race conditions, proving once again that ya gotta get up to get down.
See #2838. Fixes #1799.
|
| [6610]
|
SergeyBiryukov
|
Counts: Fix typo in DB query in `bbp_get_user_reply_count_raw()`.
See #3124.
|
| [6827]
|
johnjamesjacoby
|
Counts: Introduce a cacheable parent/type/status wrapper, filter helpers.
This change introduces a common query function for totalling up all counts by type & status, and caching the results for later usages. By doing this, we can avoid running multiple queries for the same public or non-public counts.
Also uses `bbp_number_not_negative()` in a few places where negative counts are never allowed.
|
| [6609]
|
johnjamesjacoby
|
Counts: Remove `count_user_posts()` usages, and always return an `int`.
User topic & reply counts haven't included `closed` status for topics, and these wrappers should include support for things like `view=all` later.
Fixes #3124.
|
| [6792]
|
johnjamesjacoby
|
Counts: introduce sub-action for post status transitions.
We'll use this for micro-managing child post counts on a per-type, per-status basis.
See #1799.
|
| [4520]
|
johnjamesjacoby
|
Create 1.2 branch:
* Uses correct BackPress/pomo externals
* See #1857.
|
| [3537]
|
johnjamesjacoby
|
Create 2.0 branch
|
| [4076]
|
johnjamesjacoby
|
Create 2.1 branch.
|
| [4442]
|
johnjamesjacoby
|
Create 2.2 branch.
|
| [4850]
|
johnjamesjacoby
|
Create 2.3 branch.
|
| [5098]
|
johnjamesjacoby
|
Create 2.4 branch from trunk.
|
| [5202]
|
johnjamesjacoby
|
Create 2.5 branch.
|
| [6939]
|
johnjamesjacoby
|
Create 2.6 branch (from trunk)
|
| [3526]
|
johnjamesjacoby
|
Create bbPress 1.1 Branch.
|
| [5818]
|
netweb
|
Create tag 2.5.8.
|
| [4385]
|
johnjamesjacoby
|
Credits:
* Clean up copy pasta.
* Props jmdodd.
* See #2018.
|
| [4384]
|
johnjamesjacoby
|
Credits:
* Hardcode some credits for a first pass for 2.2.
* Will want to use api.wordpress.org eventually.
* Fixes #2018.
|
| [4459]
|
johnjamesjacoby
|
Credits:
* Update incorrect link.
* Fixes #2044 (2.2 branch)
|
| [4458]
|
johnjamesjacoby
|
Credits:
* Update incorrect link.
* Fixes #2044 (trunk)
|
| [6395]
|
johnjamesjacoby
|
Credits: Add "Project Emeriti" section, and add Sergey & Brandon as Contributing Developers.
Also update the tagline.
|
| [6394]
|
johnjamesjacoby
|
Credits: Remove superfluous `alt` text for project leaders and contributors.
Props mercime. Fixes #3099.
|
| [5952]
|
netweb
|
Credits: Update H4 to H3
This changeset improves accessibility and brings bbPress' credits area headers up to par with WordPress 4.4.
Fixes #2890. See #WP34263.
|
| [5452]
|
netweb
|
DB schema change for `wp_bbconverter_translator` converter sync table
* Increase `meta_key` maximum characters from 25 o 255 to allow for longer meta keys during import
See #2650
|
| [5543]
|
netweb
|
DB schema change for `wp_bbconverter_translator` converter sync table
* Increase `meta_value` maximum characters from 25 o 255 to allow for longer meta values during import
See #2650
|
| [5401]
|
johnjamesjacoby
|
De-deprecate `bbp_remove_roles()` and use it in: `bbp_admin_reset_handler()`, bbp_do_uninstall()`, and `bbp_version_updater()`. Fixes bug where old bbPress role data could still exist in `wp_user_roles`. See #2065. Fixes #2580.
|
| [5057]
|
johnjamesjacoby
|
De-deprecate bbp_remove_roles() so database role removal is still supported.
|
| [4154]
|
johnjamesjacoby
|
Deactivation:
* Introduce bbp-core-dependency.php and move plugin dependency actions and filters into it.
* Switch load order to remove possible debug notices on deactivation.
* Only load -core- files on deactivation; the others are not needed at that time.
|
| [3797]
|
johnjamesjacoby
|
Decode $post_content for wp_editor in bbp_get_the_content(). Fixes #1770. Props alexvorn2, props jaredatch.
|
| [4697]
|
johnjamesjacoby
|
Decode blogname in notification emails. Props netweb. Fixes #2172.
|
| [2792]
|
johnjamesjacoby
|
Decode special characters when editing topics/posts [0.9 branch]
|
| [3390]
|
johnjamesjacoby
|
Decomplicate bbPress includes procedure. Fixes #1570. Props andy.
|
| [2914]
|
johnjamesjacoby
|
Decouple bbp_is_ functionality from bbp_get_{post_type}_id functionality, and use correctly through-out. Add ability to show all forums regardless of post_parent, and fix forums widget to use this functionality correctly.
|
| [5487]
|
johnjamesjacoby
|
Dedicated filters to allow manipulating of users who will receive subscription emails. Hat tip roysmyth. Fixes #2627.
|
| [2826]
|
johnjamesjacoby
|
Deemphasize the admin links when viewing a single topic.
|