| [4563]
|
johnjamesjacoby
|
Code Improvement:
* Add some brackets to improve readability.
|
| [3956]
|
johnjamesjacoby
|
Code Improvement:
* Clean up bbPress::register_post_statuses() to not create variables.
|
| [3966]
|
johnjamesjacoby
|
Code Improvement:
* First pass at updating subversion properties.
* Remove text/x-php mime types.
* Remove text/css mime types.
* Remove invalid sv:mime-type property.
* See #1851.
|
| [3953]
|
johnjamesjacoby
|
Code Improvement:
* Fix incorrect @since phpdoc (rxxxx placeholders)
|
| [3964]
|
johnjamesjacoby
|
Code Improvement:
* Lose EOF ?>.
* Clean up EOF newlines.
* Fixes #1850.
|
| [4281]
|
johnjamesjacoby
|
Code Improvement:
* More politely cast arrays in settings sections and fields.
* Use esc_html__() on some admin strings. See #1999.
* Clean up bbp_converter_setting_callback_platform().
|
| [4248]
|
johnjamesjacoby
|
Code Improvement:
* Move bbp-admin into bbp-includes/admin.
* Introduce includes_dir and includes_url bbpress() vars.
* Adjust BBP_Admin include paths.
* See: #1975.
|
| [4249]
|
johnjamesjacoby
|
Code Improvement:
* Move bbp-includes files into respective subdirectories.
* Adjust include paths.
* Remove superfluous inline file descriptions.
* See: #1975.
|
| [3951]
|
johnjamesjacoby
|
Code Improvement:
* Move preset bbPress class variables into bbPress::setup_globals() action.
* Introduce magic get/set methods to handle main bbPress class variables.
* Keeps by-reference bbPress->current_user outside of bbPress->data.
* Reduces code duplication in bbPress class.
* Fixes #1847.
|
| [4566]
|
johnjamesjacoby
|
Code Improvement:
* Remove 1 time use variable from version bump.
|
| [4250]
|
johnjamesjacoby
|
Code Improvement:
* Remove bbp- prefixes from admin files.
* Adjust include paths.
* See #1975.
|
| [4331]
|
johnjamesjacoby
|
Code Improvement:
* Revert part of r4258.
* Cast as int instead of using absint()
* Fixes regression that broke existing bbPress plugin (hierarchical replies.)
* Fixes #2008.
|
| [3954]
|
johnjamesjacoby
|
Code Improvement:
* Revert r3950 and move bbPress class arrays back into their own variables to prevent by-reference errors.
|
| [4280]
|
johnjamesjacoby
|
Code Improvement:
* Straighten the teeth in template-tags.php.
* Add braces to all of the things.
* Hat-tip westi the dentist.
|
| [3955]
|
johnjamesjacoby
|
Code Improvement:
* Turn bbPress::extend into an stdClass in setup_globals.
* Add phpdoc to bbPress::data variable with verbose explanation of how it works.
|
| [4279]
|
johnjamesjacoby
|
Code Improvement:
* Use esc_attr_e() in place of _e() is some obvious places.
* See #1999.
|
| [5641]
|
johnjamesjacoby
|
Code Improvement:
* Add `$Id$` Subversion keyword property to `/src/bbpress.php`.
* Hat tip netweb. See #1851.
|
| [3702]
|
johnjamesjacoby
|
Code clean-up in bbp-common-functions.php:
* Avoid accidental inline assignments
* Add bbp_get_global_post_field() function, for use in forms and editing
|
| [3710]
|
johnjamesjacoby
|
Code clean-up in bbp-forum-template.php.
|
| [3701]
|
johnjamesjacoby
|
Code clean-up in bbp-functions.php:
* Remove unused $bbp globals
* Add defaults to optional bbp_filter_sample_permalink() params
* Avoid accidental inline assignments
|
| [3709]
|
johnjamesjacoby
|
Code clean-up in bbp-reply-template.php.
|
| [3708]
|
johnjamesjacoby
|
Code clean-up in bbp-topic-template.php.
|
| [3707]
|
johnjamesjacoby
|
Code clean-up to template tags. Add more helpful classes to loop rows. Cast some more retvals. Fixes #1727.
|
| [3315]
|
johnjamesjacoby
|
Code cleanup from r3313.
|
| [3516]
|
johnjamesjacoby
|
Code formatting improvements to 'pre_get_posts' actions. Remove unused $bbp globals.
|
| [3545]
|
johnjamesjacoby
|
Code formatting improvements to bbp-topic-functions.php and prevent possible debug notices.
|
| [3574]
|
johnjamesjacoby
|
Code formatting improvements to bbp-topic-functions.php and prevent possible debug notices. See r3445. (2.1)
|
| [3699]
|
johnjamesjacoby
|
Code formatting improvements to bbp-user-template.php.
|
| [3544]
|
johnjamesjacoby
|
Code formatting improvements to bbp_toggle_reply_handler() and prevent possible debug notice on $failure.
|
| [3573]
|
johnjamesjacoby
|
Code formatting improvements to bbp_toggle_reply_handler() and prevent possible debug notice on $failure. See r3544. (2.1)
|
| [6907]
|
netweb
|
Coding Standards: Add missing trailing semi-colon from [6893]
|
| [3031]
|
johnjamesjacoby
|
Commit bomb of changes to bbp-twentyten to further abstract out template parts for improved shortcode usage and theme_compat for themes that do not explicitly support bbPress.
|
| [3250]
|
johnjamesjacoby
|
Commit bomb of improvements to the breadcrumb.
Checking for topic views, forum and topic archives, and do not check if the root slug is included in the URL.
Add breadcrumb to forum archive and topic archive, since they exist one level deeper than the "Home" page.
Add template tags to handle the forum/topic archive titles, which use a corresponding page title if one exists, and fallback to the post type label 'name' if not.
|
| [3241]
|
johnjamesjacoby
|
Commit bomb of updates to breadcrumb logic:
Switch from parameters to a parse args array.
Switch from template part to function.
Add before/after HTML arguments.
Add missing breadcrumb to reply-edit, view, and topic-tag templates.
Add home link logic.
Add filters on breadcrumb items.
Add quick-bail filter at the beginning of breadcrumb function.
|
| [3032]
|
johnjamesjacoby
|
Commit bomb, round 2. Similar to r3031, this includes a host of new functions for handling theme compatability for themes that do not explicitly support bbPress. Also introduces BBP_Shortcode class as handler for all shortcodes going forward.
|
| [7251]
|
johnjamesjacoby
|
Common Functions: fix dashboard errors from undefined variables.
Introduced in r7237, in `bbp_get_statistics()`.
This corrects an unintended regression that was causing replies not to be counted correctly.
In branches/2.6, for 2.6.10.
|
| [6013]
|
johnjamesjacoby
|
Common group.
|
| [3902]
|
johnjamesjacoby
|
Common:
* Audit _is_ functions and make sure they return and filter correctly.
* Add descriptions to phpdoc headers of common files.
|
| [5788]
|
netweb
|
Common: Include `bbp_get_pending_status_id()` post status for topic and reply post type cases in `bbp_get_all_child_ids()` and PHPDoc fixes including addition of missing `@since` revision
Props netweb. Fixes #2810
|
| [5730]
|
johnjamesjacoby
|
Common: Additional type-casting in query functions.
Ensures direct query results return a consistent, testable value.
Props thebrandonallen, netweb. See #2801.
|
| [6097]
|
johnjamesjacoby
|
Common: Improve title output strings for friendlier i18n.
Props @SergeyBiryukov. Fixes #2852.
|
| [5739]
|
johnjamesjacoby
|
Common: Improve type-casting return values in query functions.
Props thebrandonallen, netweb. See #2801.
|
| [6302]
|
johnjamesjacoby
|
Common: Introduce `bbp_number_not_negative()` and use it in the following ways:
* Register the relevant meta-data keys for posts & users, so updated values can never be invalid
* Filter return values for existing database values that might be invalid on existing installs
* Use in place of `intval()` or `(int)` casts where negative values should not exist
This has the added benefit of introducing the `bbp_register_meta` hook, for future meta-data registrations (of which bbPress has much of.) We'll concentrate on counts for 2.6, and integrate IDs and timestamps in future releases.
See #3059.
|
| [5685]
|
johnjamesjacoby
|
Common: Login actions:
* Extract functionality from `bbp_wp_login_action()` into a getter: `bbp_get_wp_login_action()`
* Update arguments in`bbp_get_wp_login_action()` to include optional `url` override
* Pass original `$args` into login action filter
* Also improve support for empty separator in breadcrumbs
|
| [6298]
|
johnjamesjacoby
|
Common: Move formatting functions into `formatting.php`.
|
| [6328]
|
johnjamesjacoby
|
Common: Remove `nofollow` from tests. See #3067.
|
| [6301]
|
johnjamesjacoby
|
Common: Switch from `absint()` to `intval()` to avoid integer inaccuracies.
See #3059.
|
| [6313]
|
johnjamesjacoby
|
Common: Update `bbp_rel_nofollow_callback()` to match latest approach in WordPress.
bbPress continues to have its own version to support this on output vs. pre-save.
Fixes #3067.
|
| [5790]
|
netweb
|
Common: Updated PHPDocs for `bbp_get_public_child_ids()`
|
| [6016]
|
johnjamesjacoby
|
Common: Use `bbp_make_clickable()` in `bbp_make_clickable()`.
In r6014, changes to support faster, better @-mentions mistakenly continued to use `make_clickable()`. This fixes that regression, and allows for smaller chunks of large topics & replies to continue to use bbPress's internally optimized clickable API.
|
| [5711]
|
johnjamesjacoby
|
Common: Use `esc_url()` in `bbp_redirect_to_field()` and late escape for clarity.
|
| [6711]
|
johnjamesjacoby
|
Common: add some sanity checks to cache priming helpers.
This change adds more checks to avoid caching post & post author data that may have been deleted since the IDs were last sourced from the database.
We also remove a call to `get_post_field()` to reference the local object directly. This adds an `empty()` but removes a more complex function call when we already have the post in local scope anyways.
Fixes #3166. Props thebrandonallen.
|
| [6700]
|
johnjamesjacoby
|
Common: also prime post author caches.
This change introduces another performance tweak to `bbp_has_topics()`, `bbp_has_forums()`, `bbp_has_search()`, and `bbp_has_replies()`, by pre-cache'ing the post author objects for what is known to be their imminent usage in the current template loops.
This change also renames the function & parameter introduced in r6698 to better fit existing naming conventions in WordPress.
See #3163.
|
| [6782]
|
johnjamesjacoby
|
Common: avoid debug notices in `bbp_past_edit_lock()`.
Props SergeyBiryukov. Fixes #3188.
|
| [5907]
|
johnjamesjacoby
|
Common: bring `bbp_verify_nonce_request()` up to speed with improvments in BuddyPress.
See #buddypress6528. Props r-a-y.
|
| [6673]
|
johnjamesjacoby
|
Common: cast return value to `array` in `bbp_pre_get_posts_normalize_forum_visibility()`.
Trunk, for 2.6. See #3031.
|
| [6814]
|
johnjamesjacoby
|
Common: introduce `bbp_get_post_types()` and use where appropriate.
Fixes #2769.
|
| [6760]
|
johnjamesjacoby
|
Common: introduce `bbp_get_url_scheme()` to simplify 'https' vs 'http' scheme concatenation.
This change improves code flow and reduces complexity by eliminating the number of inline `is_ssl()` checks necessary when URLs are being generated.
|
| [6440]
|
johnjamesjacoby
|
Common: introduce `bbp_has_shortcode()` to check if some text contains a bbPress shortcode.
If a shortcode was found in the global post content, a few extra things will happen:
* The `bbp-shortcode` class is added to the `body` tag
* `is_bbpress()` will now return `true`, to help enqueue additional styles & scripts on those pages in themes that want to support bbPress natively
Fixes #2996.
|
| [7279]
|
johnjamesjacoby
|
Common: prefer `bbp_get_topic_permalink()` over `get_permalink()`
This change ensures that features like Subscriptions & Pagination (inside of topics list loops) have: an opportunity to use the anticipated function path, and access to the right filters when including links back to them.
This fixes a potential bug where filtering a topic permalink would not happen inside of emails or pagination in the loop-topic template part.
See #3603.
|
| [6299]
|
johnjamesjacoby
|
Common: prefer `intval()` over `absint()` for reply IDs in form fields.
|
| [6698]
|
johnjamesjacoby
|
Common: prime last-active post caches.
This change introduces a performance tweak to `bbp_has_topics()`, `bbp_has_forums()`, and `bbp_has_search()`, pre-cache'ing the last-active post objects for what is known to be their imminent usage in the current template loops.
See #3163.
|
| [6719]
|
johnjamesjacoby
|
Common: remove redundant calls to `bbp_number_not_negative()`.
This change decreases the filter priority of out-of-range prevention from `10` to `8`, and also adds filters to pre-formatted values in lieu of hard-coding this function into each individual count getter. This allows plugins to unplug this check more easily, and makes sure each value is only checked once for each call instead of occasionally twice in a row.
|
| [7270]
|
johnjamesjacoby
|
Common: update `blacklist_keys` to `disallow_keys`
This change prevents a deprecated option notice in WordPress versions greater than 5.5.
See: #3601
In branches/2.6, for 2.6.11.
|
| [7271]
|
johnjamesjacoby
|
Common: update `blacklist_keys` to `disallow_keys` in PHPUnit tests
See: #3601
In branches/2.6, for 2.6.11.
|
| [6765]
|
netweb
|
Composer: add an end-of-file new line to `composer.json`
|
| [4204]
|
bumpbot
|
Compress scripts/styles: -2.1.2-4204.
|
| [4357]
|
bumpbot
|
Compress scripts/styles: 2.2-beta1-4357.
|
| [4383]
|
bumpbot
|
Compress scripts/styles: 2.2-beta2-4383.
|
| [4421]
|
bumpbot
|
Compress scripts/styles: 2.2-rc2-4421.
|
| [4468]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4468.
|
| [4479]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4479.
|
| [4514]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4514.
|
| [4580]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4580.
|
| [4585]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4585.
|
| [4612]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4612.
|
| [4624]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4624.
|
| [4635]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4635.
|
| [4650]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4650.
|
| [4662]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4662.
|
| [4669]
|
bumpbot
|
Compress scripts/styles: 2.3-bleeding-4669.
|
| [4993]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-4993.
|
| [5003]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-5003.
|
| [5008]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-5008.
|
| [4945]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-r4900-4945.
|
| [5026]
|
bumpbot
|
Compress scripts/styles: 2.4-beta1-5026.
|
| [5033]
|
bumpbot
|
Compress scripts/styles: 2.4-beta1-5033.
|
| [3671]
|
johnjamesjacoby
|
Consolidate 'template_redirect' actions onto 'bbp_template_redirect' and add a more detailed note about them. Also rename tag 'manage' function to 'edit' to match other components.
|
| [4967]
|
johnjamesjacoby
|
Consolidate global-access and default role into 1 line-item in forum settings.
|
| [3169]
|
johnjamesjacoby
|
Consolidate theme compat functions and add more verbose phpdoc where appropriate. Use template_include filter instead of template_redirect action, and add support for incorrect usage of add_theme_support( 'bbpress' ). See #1524.
|
| [3236]
|
johnjamesjacoby
|
Consolidate topic form access checks.
|
| [5002]
|
johnjamesjacoby
|
Constans album spatium. Consistent whitespace handling of foreach usages.
|
| [6676]
|
johnjamesjacoby
|
Content: Use correct `tabindex` array key vs. `tab`.
This change corrects a debug notice when the TinyMCE toolbar setting is toggled off.
Trunk, for 2.6. See r6424. Props vinod-dalvi.
|
| [7208]
|
johnjamesjacoby
|
Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In branches/2.6, for 2.6.7.
Fixes #3418.
|
| [7207]
|
johnjamesjacoby
|
Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In trunk, for 2.7.0.
See #3418.
|
| [7124]
|
johnjamesjacoby
|
Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In branches/2.6, for 2.6.6.
See #3384.
|
| [7125]
|
johnjamesjacoby
|
Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In trunk, for 2.7.
See #3384.
|
| [3583]
|
johnjamesjacoby
|
Contextual help fixes. Fixes #1657. Props duck_
|
| [3075]
|
johnjamesjacoby
|
Convert bbp-twentyten into a child theme for twentyten, reducing the size of the plugin file by almost half, eliminating code duplication, and avoiding inadvertently forking the twentyten theme only to support bbPress.
|
| [5563]
|
johnjamesjacoby
|
Convert template notices from paragraph tags to unordered lists.
Improves accessibility by hinting there may be several notices on the page.
Props Karl Groves, netweb. FIxes #2637.
|