_relm,_id,Changeset,author,message
changeset,0000005585,[5585],netweb,
changeset,0000007007,[7007],netweb," Build Tools: Follow to PHPCS changes in [7006]
- Fixes an erronous change in Invision converter
- Tweaks a readability issue in `bbp_update_reply()`
See #3294.
"
changeset,0000004407,[4407],johnjamesjacoby,"!BuddyPress Group Forums:
* Suppress hierarchical group forums for now, for feature parity with existing !BuddyPress forums.
* See #1669."
changeset,0000004409,[4409],johnjamesjacoby,"!BuddyPress:
* Add note to the top of !BuddyPress loader.php.
* See #1669."
changeset,0000004393,[4393],johnjamesjacoby,"!BuddyPress:
* First pass attempt at repairing !BuddyPress group forum relationships.
* Includes new tool for looping through converted forums and updating group meta.
* See #1669."
changeset,0000004402,[4402],johnjamesjacoby,"!BuddyPress:
* Only rename 'Default Forum' if name matches old bbPress default forum title.
* See #2025, #1669."
changeset,0000004397,[4397],johnjamesjacoby,"!BuddyPress:
* Remove component.php, and consolidate into loader.php.
* Introduce members.php, for modifying bbPress profile links.
* Rename loading class and references where appropriate.
* See #2020."
changeset,0000004394,[4394],johnjamesjacoby,"!BuddyPress:
* Split buddypress.php up into more manageable parts.
* Props jmdodd.
* Fixes #2020."
changeset,0000004410,[4410],johnjamesjacoby,"!BuddyPress:
* Update BBP_BuddyPress::setup_title() to use more verbose and filtered !BuddyPress functions.
* Use bp_is_user() check to only set title for displayed users.
* Props paulgibbs.
* Fixes #2027."
changeset,0000004401,[4401],johnjamesjacoby,"!BuddyPress:
* Update group-repair tool to update the group forums root.
* Also rename the 'Default Forum' to 'Group Forums' since it's part of the sitewide forums now.
* See #2025, #1669."
changeset,0000004396,[4396],johnjamesjacoby,"!BuddyPress:
* Use !BuddyPress singleton wrapper where applicable.
* Include helper buddypress() function if using versions prior to 1.7."
changeset,0000002758,[2758],johnjamesjacoby,"""...pursuing a career in the custodial arts."" phpDoc fixes and code clean-up. Props !GautamGupta via Google Code-in"
changeset,0000003243,[3243],johnjamesjacoby,"""Exit"" if accessed directly, not ""Redirect"" - all included php files"
changeset,0000004270,[4270],johnjamesjacoby,"""topic"" instead of ""forum"" in admin helper text. Props !DanielJuhl. Fixes #1995."
changeset,0000003428,[3428],johnjamesjacoby,'Right Now' metabox tweaks for WordPress 3.2 dashboard styling. Fixes #1599. Props !GautamGupta.
changeset,0000003646,[3646],johnjamesjacoby,"'suppress_filters' audit:
* Revert part of r3645
* Rename bbp_pre_get_posts() to bbp_parse_query() and hook to 'parse_query'
* Move forum post_type check out of bbp_pre_get_posts() and into bbp_pre_get_posts_exclude_forums() where it makes more sense
* Update documentation for above changes
* See #1698"
changeset,0000005450,[5450],netweb,"* Alphabetize grunt tasks and tweak inline docs in `Gruntfile.js`
* Automatically reload the `grunt watch` task when changes are made to `Gruntfile.js`"
changeset,0000004073,[4073],johnjamesjacoby,"2.1:
* Update readme.txt
* Update versions in bbpress.php and bbp-twentyten."
changeset,0000006586,[6586],johnjamesjacoby,"404: Use `! empty()` over `isset()` to only account for `true` values in `bbp_is_404`.
This fixes broken `/edit/` theme-side URLs, that will redirect otherwise."
changeset,0000002580,[2580],mdawaffe,"[2502] breaks post ordering for non-trivial ORDER BY statements.
Fix by reordering according to the returned value from the query or cache.
Fixes #1301.
"
changeset,0000002725,[2725],mdawaffe,_bb_get_cached_data() was using the wrong callback
changeset,0000005604,[5604],johnjamesjacoby,"`Call bb_get_user()` from `bb_get_user_by_nicename()`. For 1.2 branch. See r5595.
"
changeset,0000006415,[6415],johnjamesjacoby,"`in_array()`: be strict whenever possible.
Use `wp_parse_id_list()` on certain array values to ensure proper results."
changeset,0000006033,[6033],johnjamesjacoby,"`WP_Screen::post_type` is always set since WordPress 3.3.0, so remove superfluous checks in `bail()` methods."
changeset,0000004729,[4729],johnjamesjacoby,A picture is worth a thousand words. Hat tip netweb. See #2183.
changeset,0000004622,[4622],johnjamesjacoby,Aaaaand use array_reverse() correctly. See #2124.
changeset,0000005133,[5133],johnjamesjacoby,"About Page:
* On activation, check that current user can access About page before redirecting to it.
* Once activated, only add About & Settings links if current user can access those pages.
* Before making the current user a Keymaster, make sure they do not have a previous forum role, preventing role escalation if the current user was previously demoted.
* Fixes #2443."
changeset,0000004391,[4391],johnjamesjacoby,"About:
* Add ""Codex Rockstars"" section.
* Fix Gravatar URL and duplicate ID.
* See #2018."
changeset,0000004388,[4388],johnjamesjacoby,"About:
* Add missing mapped cap to BBP_Admin::map_settings_meta_caps().
* See: #2018."
changeset,0000004382,[4382],johnjamesjacoby,"About:
* First pass at ""What's New"" text.
* Props jmdodd.
* See #2018."
changeset,0000004469,[4469],johnjamesjacoby,"About:
* RTL styling for bbp-badge.
* Fixes #2049 (2.2 branch)"
changeset,0000004470,[4470],johnjamesjacoby,"About:
* RTL styling for bbp-badge.
* Fixes #2049 (trunk)"
changeset,0000006345,[6345],netweb,"About: Fix Gravatar URL
"
changeset,0000003563,[3563],johnjamesjacoby,Abstract Forum metabox dropdown builders into template tags to be used in front-end editor.
changeset,0000002907,[2907],johnjamesjacoby,"Abstract forum updating code out of bbp_update_topic_walker and into bbp_update_forum. Use that new function in the new bbp_move_topic_handler function, which handles the moving of a topic from one forum to another and makes sure the forum counts stay accurate."
changeset,0000005408,[5408],johnjamesjacoby,Abstract new topic-transition reply helper-functions onto action hooks for easier testing and replacement/extension by third party plugins. See #2494.
changeset,0000006734,[6734],johnjamesjacoby,"Abstraction: abstract site switching functions to include an `is_mulitsite()` check.
This allows functions that are traditionally hook-only to be called directly, regardless of the installation type, and without littering the codebase with several `is_multisite()` switches.
Fixes #3179."
changeset,0000005827,[5827],johnjamesjacoby,"Abstraction: Use `bbp_db()`, `bbp_rewrite()` & friends, introduced in r5823 & r5826.
This commit improves the stability of bbPress in the WordPress environment by reducing global variable exposure. It also comes with minimal opcode improvements in some circumstances where `$GLOBALS` is preferred over defining via `global` statements.
Some additional surrounding cleanup directly related to functions & methods being altered is also being performed here.
Fixes #2786."
changeset,0000002994,[2994],johnjamesjacoby,Abstracts the add/remove capability functions to remove duplication. Removes 'edit_users' capability from Forum Moderator role as it's reserved for admin/super admin respectively. Fixes #1488. Props !GautamGupta for initial patch.
changeset,0000006352,[6352],netweb,"Accessibility: Add accessible hidden headings and text for Forums, Topics, Topic Tags, and Replies list table views.
Props mercime, netweb.
Fixes #2899.
"
changeset,0000006868,[6868],johnjamesjacoby,"Accessibility: Avoid back-to-back author links.
This change ensures that avatar and display-name links are wrapped in a shared anchor, instead of each with their own.
Includes a few test changes to better suit our intentions of verifying valid & accessible HTML output.
Fixes #3220. Props dcavins.
"
changeset,0000006202,[6202],netweb,"Accessibility: Bump headings for BuddyPress group forums.
Props mercime.
Fixes #2968.
"
changeset,0000006932,[6932],johnjamesjacoby,"Accessibility: improve contrast of admin/moderation links.
This commit darkens the text used by the links in topics & replies, making them easier to see.
Fixes #3003. Props mercime, thebrandonallen."
changeset,0000005948,[5948],netweb,"Accessibility: Include input labels for field titles in bbPress settings
This changeset aligns bbPress input label fields with current WordPress standard for improved accessibility
Props ankit-k-gupta, thebrandonallen
Fixes #2866
"
changeset,0000007097,[7097],johnjamesjacoby,"Accessibility: Text Changes: Use sentence case for the word ""Error"" in various error messages, instead of all caps.
Using all caps should be avoided for better readability, and because screen readers may pronounce all-caps words as abbreviations.
Related to [WP47156], #WP47656, #WP43037, #WP42945.
Props casiepa, man4toman, mmeet94, SergeyBiryukov, afercia, ryokuhi, sabernhardt, garrett-eclipse.
In branches/2.6, for 2.6.6.
See #3333, #3377."
changeset,0000007098,[7098],johnjamesjacoby,"Accessibility: Text Changes: Use sentence case for the word ""Error"" in various error messages, instead of all caps.
Using all caps should be avoided for better readability, and because screen readers may pronounce all-caps words as abbreviations.
Related to [WP47156], #WP47656, #WP43037, #WP42945.
Props casiepa, man4toman, mmeet94, SergeyBiryukov, afercia, ryokuhi, sabernhardt, garrett-eclipse.
In trunk, for 2.7.0.
Fixes #3333, #3377."
changeset,0000006732,[6732],netweb,"Accessibility: Update the `screen-reader-text` CSS class via wp:changeset:41622
This changeset merges the latest #a11y updates from WordPress Core for screen readers.
Props ashokrd2013.
Fixes #3172.
"
changeset,0000004095,[4095],johnjamesjacoby,"Actions/Filters:
* Add filter to bbp_get_displayed_user_field().
* Fixes #1910.
* For 2.1 branch.
* Props iamzippy."
changeset,0000004094,[4094],johnjamesjacoby,"Actions/Filters:
* Add filter to bbp_get_displayed_user_field().
* Fixes #1910.
* For 2.2 branch.
* Props iamzippy."
changeset,0000006779,[6779],johnjamesjacoby,Actions: consolidate `bbp_template_notices` actions into a group.
changeset,0000003421,[3421],johnjamesjacoby,"Activation Fixes:
* Remove activation/deactivation hooks in favor of more robust updater logic
* Introduce functions for catching activation/deactivation from the plugins screen(s), bumping the DB version, and detecting the version change
* Add more verbose explanation of plugin dependant hooks in bbp-core-hooks.php
* Remove extra call to flush_rewrite_rules() in bbp-settings.php
* Bump DB version to 155
* Bump plugin version to RC 3"
changeset,0000004390,[4390],johnjamesjacoby,"Activation:
* When activating bbPress, redirect to the ""What's New"" page.
* Replaces incomplete code in /admin/functions.php with update action and activation hook helper.
* See #2018."
changeset,0000006823,[6823],johnjamesjacoby,"Activation: avoid creating initial content more than once.
This change adds an `_bbp_flag_initial_content` option key to check against, to avoid creating the starter content more than one time. It also stores `bbp_get_default_options()` in a local static variable to avoid recreating the same array multiple times.
Because of the way plugin activation and site creation work, `is_multisite()` checks are used to avoid fatal errors.
"
changeset,0000006780,[6780],johnjamesjacoby,"Activation: improvements to activation procedure.
* Replace transient usage with a user setting. This removes 1 additional query from through-out WordPress admin.
* Use `bbp_admin()` helper function when referring to `bbpress()->admin` to take advantage of magic loading
* Move activation redirection off of general `bbp_admin_init` hook and onto the relative `activate_` hook, which reduces some useless processing - we only ever want to redirect in from a predictable user flow
* Move some admin-only functions back into the core component, to ensure they are available when bbPress is activated for the very first time
* Introduce wrapper for `bbp_create_initial_content()` to avoid action argument pollution
* Juggle some action-hook orders to make initial content creation work again
* Add more checks to current user when automatically changing or assigning roles, including keymasters on fresh installations
Overall, this results in a more predictable activation experience, and makes things easier to unhook or extend later."
changeset,0000006781,[6781],johnjamesjacoby,"Activation: Use a user-option instead of user-setting or transient.
User settings won't trigger without a proper page redirect, which plugin activation does not do (yet.)
Also update docs to be less about the API and more about the intention of the code."
changeset,0000002486,[2486],johnjamesjacoby,Actually add files mentioned in r2485
changeset,0000003024,[3024],johnjamesjacoby,Add !is_user_logged_in() check to bbp_allow_anonymous() check in form-topic.php
changeset,0000003318,[3318],johnjamesjacoby,"Add ""Empty Spam"" buttons to admin area topics and replies list tables."
changeset,0000003079,[3079],johnjamesjacoby,"Add ""Hidden"" post status for future use with forums."
changeset,0000004979,[4979],johnjamesjacoby,Add $filter parameter and supporting phpdoc to bbp_displayed_user_field() && bbp_get_displayed_user_field() to allow more accurate sanitization of displayed user field values. Remove superfluous isset() check. Use 'edit' parameter in form-user-edit.php. See #1999.
changeset,0000002867,[2867],johnjamesjacoby,Add $post_id param to bbp_is_ checks in bbp-general-template.php
changeset,0000003004,[3004],johnjamesjacoby,Add '_bbp_private_forums' and '_bbp_hidden_forums' to list of autoloaded site metas. These will be used later to assist in visibility based topic and reply queries.
changeset,0000003692,[3692],johnjamesjacoby,Add 'bbp_after_setup_actions' action to bbPress::setup_actions() to allow class actions to be manipulated. Fixes #1730.
changeset,0000003733,[3733],johnjamesjacoby,Add 'bbp_after_setup_theme' piggy back hook to bbp-core-hooks.php.
changeset,0000003759,[3759],johnjamesjacoby,"Add 'bbp_request' piggy-back filter to WordPress's 'request' filter.
* Maybe exclude private and hidden forums from forum post feed
* Fixes #1758
* Props scribu"
changeset,0000003684,[3684],johnjamesjacoby,Add 'bbp_save_forum_extras' action to 'bbp_forum_attributes_metabox_save' action. See r3683.
changeset,0000003681,[3681],johnjamesjacoby,Add 'bbp_save_forum_extras' action to new/edit forum extras. See #1669.
changeset,0000003754,[3754],johnjamesjacoby,Add 'bbp_setup_theme' piggy-back action to !WordPress's 'setup_theme' action.
changeset,0000003826,[3826],johnjamesjacoby,"Add 'bump' functions for forum, topic, reply, and voice counts.
* Functions not used yet
* See #1799"
changeset,0000003018,[3018],johnjamesjacoby,Add 'orphan' post status. See #1469.
changeset,0000003492,[3492],johnjamesjacoby,Add 'sep' argument to topic and reply author links. Pass line breaks in loops. Fixes #1610.
changeset,0000005084,[5084],johnjamesjacoby,Add 'show_none' to forum ID dropdown in form-topic.php template part. Fixes UX problem where a new-topic page would automatically select the first option in the list for topics to go in. Also escape output of 'show_none' in bbp_get_dropdown(). Fixes #2390.
changeset,0000003328,[3328],johnjamesjacoby,Add 'view_item' to Topic Tag taxonomy. Props cnorris23. Fixes #1556.
changeset,0000005362,[5362],netweb,"Add .editorconfig file, see http://editorconfig.org/.
""EditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs.""
Props netweb. Fixes #2598"
changeset,0000004422,[4422],johnjamesjacoby,Add 2.2 to readme.txt changelog.
changeset,0000002805,[2805],johnjamesjacoby,"Add @todo messages to admin forum/topic recounts, and minor tweaks to recount queries"
changeset,0000002904,[2904],johnjamesjacoby,"Add _bbp_db_version to autoloaded options, as we will need a method for future database updates."
changeset,0000002909,[2909],johnjamesjacoby,Add _bbp_forums_per_page option to autoloaded settings resulting in 1 less query per page load.
changeset,0000002903,[2903],johnjamesjacoby,"Add _bbp_super_sticky_topics to bbp_add_options so it is autoloaded, reducing query count by 1 on each page load."
changeset,0000004755,[4755],johnjamesjacoby,"Add _doing_it_wrong() feedback to bbp_setup_current_user(), to help debug role and capability issues when the current user is prematurely loaded."
changeset,0000003349,[3349],johnjamesjacoby,"Add _insert_ functions for forums, topics, and replies. Audit (forum/topic/hidden) meta key and updater function names and and normalize them where needed.
(Existing installs will need to run recounts, or let them adjust themselves naturally as new topics and replies come in.)"
changeset,0000005564,[5564],johnjamesjacoby,Add `'suggest'` to `common` script prerequisites.
changeset,0000005565,[5565],johnjamesjacoby,Add `'suggest'` to `replies` script prerequisites.
changeset,0000005772,[5772],johnjamesjacoby,"Add `.htaccess`, `.DS_Store`, and `.gitignore` to `.gitignore`, taking influence from WordPress core.
Hat-tip netweb. See #2802."
changeset,0000005909,[5909],johnjamesjacoby,Add `@package` and `@subpackage` to file headers where missing; rename if inconsistent; move to bottom of PHPDoc blocks where appropriate. See #WP27262.
changeset,0000005793,[5793],netweb,"Add `autocomplete=""off""` to password field on login widget, user login form, and converter form.
Props pareshradadiya. Fixes #2772
"
changeset,0000006338,[6338],johnjamesjacoby,"Add `bbp_rel_nofollow()` to `bbp_get_cancel_reply_to_link` filter.
Also clean-up `bbp_get_cancel_reply_to_link()` a bit.
See #3067."
changeset,0000005727,[5727],netweb,"Add `bbp_rel_nofollow` and `wp_unslash` filters to `bbp_get_topic_reply_link` and `bbp_get_reply_to_link` topic reply links.
Props netweb. Fixes #2515
"
changeset,0000005282,[5282],johnjamesjacoby,"Add `build` directory to `svn:ignore`. Props netweb. See #2542.
"
changeset,0000005586,[5586],netweb,"Add `grunt-banner` to replace deprecated banners in `cssmin`
"
changeset,0000005301,[5301],johnjamesjacoby,Add `meta_type` hinting to `bbp_move_reply_handler()`. See #2554.
changeset,0000005299,[5299],johnjamesjacoby,Add `meta_type` hinting to `bbp_update_forum_last_topic_id()`. See #2554.
changeset,0000005300,[5300],johnjamesjacoby,Add `meta_type` hinting to admin queries. See #2554.
changeset,0000005298,[5298],johnjamesjacoby,Add `meta_type` hinting to topics queries. See #2554.
changeset,0000005297,[5297],johnjamesjacoby,Add `meta_type` hinting to widget queries. See #2554.
changeset,0000005302,[5302],johnjamesjacoby,Add `meta_type` to extra page template: `page-topics-no-replies.php`. See #2554.
changeset,0000005322,[5322],johnjamesjacoby,Add `NUMERIC` type hinting to view queries. Props netweb. Fixes #2554.
changeset,0000005337,[5337],johnjamesjacoby,"Add `overflow-x: auto` styling to `code` and `pre` tags, to allow very long single lines of code to wrap without breaking outside of the bounding box."
changeset,0000005329,[5329],johnjamesjacoby,Add `separate_items_with_commas` string in `bbp_get_topic_tag_tax_labels()`.
changeset,0000005446,[5446],netweb,"Add a full stop to bbPress' short description, improves plugin cards readability see #WP28785 Comment:40"
changeset,0000003273,[3273],johnjamesjacoby,"Add a global plugins variable to main bbPress global class. bbPress plugins can use this to store global information, rather than instantiating their own separate globals."
changeset,0000005531,[5531],netweb,Add a leading slash to `phpunit.xml` in `.gitignore` to only ignore `phpunit.xml` in the root folder
changeset,0000006970,[6970],johnjamesjacoby,Add a new line where there should be one.
changeset,0000004749,[4749],johnjamesjacoby,Add a note about bbcodes and smilies to welcome screen. Props netweb. Fixes #2192.
changeset,0000002627,[2627],johnjamesjacoby,"Add a ton of template tags for last topic, last reply, and associated authors"
changeset,0000002860,[2860],johnjamesjacoby,Add ability for capable users to edit anonymous topic/post user data. Fixes #1463.
changeset,0000002991,[2991],johnjamesjacoby,Add ability to filter topics and replies on a per forum basis to match stand alone functionality.
changeset,0000005833,[5833],johnjamesjacoby,Add ability to use icons as column headers ala Comment bubbles (off by default.)
changeset,0000005303,[5303],johnjamesjacoby,Add actions before & after register template part fieldset fields. Fixes #2534.
changeset,0000003417,[3417],johnjamesjacoby,"Add actions to bbp-twentyten template files for forums, topics, and replies. See #1538."
changeset,0000003807,[3807],johnjamesjacoby,Add actions to user- template parts in bbp-theme-compat. Fixes #1786. Props jaredatch for original patch.
changeset,0000002833,[2833],johnjamesjacoby,Add actions to user-edit.php in bbp-twentyten to allow customizing of the edit profile page. Fixes #1410.
changeset,0000003474,[3474],johnjamesjacoby,Add activity stream at-name mentions to BuddyPress extension when editing topics and replies. See r3473.
changeset,0000003473,[3473],johnjamesjacoby,Add activity stream at-name mentions to BuddyPress extension.
changeset,0000004609,[4609],johnjamesjacoby,"Add additional form permissions to BuddyPress group forums, to prevent banned and non-members from posting to groups they are not part of. Props r-a-y. Fixes #2095."
changeset,0000004592,[4592],johnjamesjacoby,Add additional phpdoc note to _bbp_reinit_dynamic_roles(). See #2103.
changeset,0000003438,[3438],johnjamesjacoby,"Add admin_dir var to $bbp->admin global, and use it in BBP_Admin class. Add filter to importer path to allow override. Fixes #1598. Props !GautamGupta for original patch."
changeset,0000003818,[3818],johnjamesjacoby,Add Akismet response to bb_ksd_pre_post_status(). Props westi. (branches/1.1)
changeset,0000003817,[3817],johnjamesjacoby,Add Akismet response to bb_ksd_pre_post_status(). Props westi. (trunk)
changeset,0000002840,[2840],johnjamesjacoby,Add an extra 20px of width to the content area.
changeset,0000003245,[3245],johnjamesjacoby,"Add an index.php file to every folder, with a note not to modify core files. In the languages and themes folders, include additional reminder that custom files will be lost during bbPress updates and where custom files should be located."
changeset,0000002923,[2923],johnjamesjacoby,Add ancestor walkers to update_reply functions for topic and forum
changeset,0000002686,[2686],johnjamesjacoby,Add anonymous posting option to forum settings
changeset,0000002828,[2828],johnjamesjacoby,Add anonymous user data editing ability to topics and replies. Fixes #1409. Props !GautamGupta
changeset,0000003620,[3620],johnjamesjacoby,Add another missing textdomain in topics widget. See #1661.
changeset,0000003182,[3182],johnjamesjacoby,Add archive pages to bbp-twentyten theme
changeset,0000003183,[3183],johnjamesjacoby,Add archive slug options to bbp-core-options.php
changeset,0000003688,[3688],johnjamesjacoby,Add attributes to forum/topic/reply contextual help. Props Mamaduka. Fixes #1699.
changeset,0000002641,[2641],johnjamesjacoby,Add author URI to bbpress.php
changeset,0000004902,[4902],johnjamesjacoby,Add authordata to topic/reply metabox. Props mzaweb. Fixes #2224.
changeset,0000003753,[3753],johnjamesjacoby,"Add autoembed to topics and replies.
* Includes admin setting to toggle on/off (default on)
* Introduce option function to get the setting globally
* Hooked into bbp_init so can be overridden as needed
* Fixes #1752
* Props jaredatch for original patch"
changeset,0000002881,[2881],johnjamesjacoby,Add avatar styling to topic revision log
changeset,0000002931,[2931],johnjamesjacoby,Add BackPress svn:external to 1.0.3 tag
changeset,0000003484,[3484],johnjamesjacoby,Add backwards compat for BuddyPress members component to strip_mentions_on_edit()
changeset,0000003766,[3766],johnjamesjacoby,"Add bbp-actions.php to admin files to handle admin actions not in the BBP_Admin class.
* Move admin actions out of bbp-core-actions.php
* Include in bbPress class when needed
* Add admin sub-actions for dependent plugins
* Move Recount specific functions into bbp-tools.php"
changeset,0000002582,[2582],johnjamesjacoby,Add bbp-admin folder and placeholders for settings and tools related code.
changeset,0000003207,[3207],johnjamesjacoby,"Add bbp-form class to bbp-twentyten fieldsets, and simplify CSS for fieldsets and their elements. For theme compat."
changeset,0000002786,[2786],johnjamesjacoby,"Add bbp-options.php to project for options specific code. Improve admin settings area, adding slugs, posts per page, and enable/disable favorites, subscriptions, and anonymous posting. Props !GautamGupta via Google Code-in"
changeset,0000002505,[2505],johnjamesjacoby,Add bbp-themes folder.
changeset,0000003382,[3382],johnjamesjacoby,"Add bbp_add_error() and bbp_has_error() functions to handle error adding and checking, and use through-out project. Rejig functions with early GET and POST checks to bail early rather than wrap routine in an if statement. Fixes issue where removing favorites and subscriptions from user profile pages would redirect incorrectly. Fixes issue where spamming and trashing topics and replies would not force view=all in some cases."
changeset,0000003744,[3744],johnjamesjacoby,"Add bbp_add_template_locations() filter to bbp_get_template_part() to allow parts to filtered too, and update bbp-theme-compat theme to use this. See r3739."
changeset,0000004835,[4835],johnjamesjacoby,"Add BBP_Admin::show_separator variable, rather than doing repeated capability checks. Block access to admin areas for users without moderator capability. Until now, only the UI was hidden, but the URL was still accessible unless a third party plugin was used."
changeset,0000002600,[2600],johnjamesjacoby,Add bbp_forum_dropdown to New Topic form when not viewing a specific forum.
changeset,0000002891,[2891],johnjamesjacoby,Add bbp_get_public_child_ids function to retrieve an array of post_id's from any other post_id. Add 'bbpress' cache group to wp_cache_get calls so that cached values are actually returned.
changeset,0000003254,[3254],johnjamesjacoby,Add bbp_is_forum_archive() check to bbp_has_topics() to prevent $in_forum from being set.
changeset,0000003765,[3765],johnjamesjacoby,Add bbp_is_install() function which checks if raw DB version exists. Update bbp_is_install() logic to not create variables.
changeset,0000004574,[4574],johnjamesjacoby,"Add bbp_is_reply_edit() check to bbp_get_topic_id().
* Addresses bug where topic subscription status would show incorrect value.
* Props ethitter.
* Fixes #2093."
changeset,0000002892,[2892],johnjamesjacoby,"Add bbp_is_reply_trash function. Use bbp_is_topic_trash function in bbp_get_reply_admin_links to prevent manipulating replies from within a trashed topic, which greatly increases the risk of skewing topic and reply counts."
changeset,0000004973,[4973],johnjamesjacoby,"Add bbp_is_single_topic() check to topic pagination count, before using threaded count output. Fixes issue where threaded output would incorrectly appear on user profile replies. See #2340."
changeset,0000003384,[3384],johnjamesjacoby,Add bbp_is_topic_tag() to is_bbpress() check. Fixes #1581. Props sorich87.
changeset,0000002893,[2893],johnjamesjacoby,Add bbp_is_topic_trash function. Clean up sticky sql query in bbp_has_topics.
changeset,0000002695,[2695],johnjamesjacoby,Add bbp_no_replies template page to list topics without replies
changeset,0000002618,[2618],johnjamesjacoby,Add bbp_ready action to bbp-loader.php
changeset,0000003051,[3051],johnjamesjacoby,Add bbp_set_404() function to bbp-general-functions.php for future use with theme compatability
changeset,0000004939,[4939],johnjamesjacoby,Add bbp_settings_user_slugs section to mapped capabilities method. See #1500.
changeset,0000002491,[2491],PeteMall,Add bbp_topic_forum_ID and bbp_get_topic_forum_ID template tags.
changeset,0000002676,[2676],johnjamesjacoby,Add bbPress logo to bbp-twentyten screenshot to help it stand out in the crowd
changeset,0000002638,[2638],johnjamesjacoby,"Add bbpress tag to theme, along with tags from Twenty Ten"
changeset,0000002518,[2518],chrishajer,"Add binary favicon.ico, not the HTML for the page (oops.) Fixes #1303
"
changeset,0000003763,[3763],johnjamesjacoby,Add body.rtl styling to bbp-admin.php inline CSS instead of brearking in and out of PHP to use is_rtl().
changeset,0000003140,[3140],johnjamesjacoby,Add body.single to fieldset clear for theme compat
changeset,0000004649,[4649],johnjamesjacoby,Add br tags to allowed array in bbp_encode_bad() function. Prevents existing line breaks from being encoded if ported from bbPress 1.1.
changeset,0000005485,[5485],johnjamesjacoby,Add brackets to comparison in `bbp_is_single_forum()`.
changeset,0000005216,[5216],johnjamesjacoby,Add brackets to improve code readability in `bbPress` class.
changeset,0000003493,[3493],johnjamesjacoby,Add BuddyPress 1.5 root slugs to settings slug conflict checker.
changeset,0000003400,[3400],johnjamesjacoby,"Add BuddyPress activity stream styling to bbp-twentyten theme, and bump script version in functions.php."
changeset,0000003809,[3809],johnjamesjacoby,Add caching to topic subscription queries. Props MZAWeb. Fixes #1794.
changeset,0000005630,[5630],johnjamesjacoby,"Add capability checks to admin-area ajax methods, and port nonce checks & js from trunk. Props jdgrimes. (2.5 branch)"
changeset,0000005627,[5627],johnjamesjacoby,Add capability checks to admin-area ajax methods. Props jdgrimes. (trunk)
changeset,0000003048,[3048],johnjamesjacoby,Add caps for hidden forums. Add read_private_forums and read_hidden_forums caps to moderator role.
changeset,0000003670,[3670],johnjamesjacoby,Add checks to bbp_pre_get_posts_exclude_forums() to prevent accidental override of wp-admin post_rows. Fixes #1719.
changeset,0000002933,[2933],johnjamesjacoby,Add checks to supplemental topic and reply actions to make sure those actions are only called on those kinds of objects. Also perform sanity check on $args['post_parent'] before attempting to unset it in bbp_has_topics()
changeset,0000003932,[3932],johnjamesjacoby,Add class to loop-single-topic.php template for single topic links to make themm easier to style independently. (bbp-twentyten/bbp-theme-compat)
changeset,0000002473,[2473],chrishajer,"Add class to super sticky posts. Fixes #1309. Props mr_pelle
"
changeset,0000003609,[3609],johnjamesjacoby,Add class_exists check to BBP_Forums_Group_Extension to prevent errors if BuddyPress Groups component is deactivated.
changeset,0000003831,[3831],johnjamesjacoby,"Add classes to bbp_get_forum_class():
* Add 'bbp-has-subforums' if forum has subforums
* Add 'loop-item-%' for each item in the loop
* Split code up into easier to grok chunks
* Fixes #1803"
changeset,0000005935,[5935],johnjamesjacoby,Add Composer support. Fixes #2712.
changeset,0000002506,[2506],johnjamesjacoby,Add constants for themes dir and url
changeset,0000003823,[3823],johnjamesjacoby,Add context to 'Open' and 'Close' strings. Props daveshine. Fixes #1798.
changeset,0000002531,[2531],johnjamesjacoby,"Add contexts to localized strings, fix verbiage, and fix missing fieldset close tag. Fixes #1324."
changeset,0000005314,[5314],johnjamesjacoby,Add contextual help for admin Tools. Props netweb. Fixes #1920.
changeset,0000004883,[4883],johnjamesjacoby,Add contextual help to admin edit screens. Props mamaduka. Fixes #2324 (2.3 branch)
changeset,0000004884,[4884],johnjamesjacoby,Add contextual help to admin edit screens. Props mamaduka. Fixes #2324 (trunk)
changeset,0000003119,[3119],johnjamesjacoby,"Add contextual help to forums, topics, replies, and settings. Fixes #1510. Props ryanimel for original patch."
changeset,0000002620,[2620],johnjamesjacoby,Add current_ variables to $bbp global
changeset,0000003097,[3097],johnjamesjacoby,"Add custom admin post messages to forums, topics and replies. Fixes #1507. Props ryanimel for original patches, cnorris23 for refresh."
changeset,0000002482,[2482],PeteMall,Add custom screen icons.
changeset,0000005508,[5508],johnjamesjacoby,Add default theme compat styling for pending topics and replies. Props netweb. See #2645.
changeset,0000005417,[5417],johnjamesjacoby,Add default value for `$user_id` to prevent debug notice when sending subscription notifications. Props mordauk. Fixes #2620.
changeset,0000003961,[3961],johnjamesjacoby,"Add deprecated filters back in, to new section at the bottom of bbp-core-filters.php."
changeset,0000003718,[3718],johnjamesjacoby,"Add description to Group Forums Parent setting. Remove check for forums not being active, as this will be handled by migration later. See #1699."
changeset,0000002504,[2504],chrishajer,"Add do_action to _bb_delete_post(). Fixes #1317. Props r-a-y
"
changeset,0000005023,[5023],johnjamesjacoby,Add dynamic actions to bbp_get_request() and bbp_post_request(). We'll likely move to using them in 2.5.
changeset,0000002493,[2493],PeteMall,Add edit and view row_actions on topics admin page.
changeset,0000005396,[5396],johnjamesjacoby,Add editable reply-to field in `form-reply.php` for moderators when editing replies. See #2617.
changeset,0000004691,[4691],johnjamesjacoby,"Add elseif's to bbp_body_class() to avoid running each function when it's not necessary. Also, some code clean-up. Fixes #2168."
changeset,0000003727,[3727],johnjamesjacoby,Add error handling to bbp_new_forum_handler() if forum parent is completely missing from POST request.
changeset,0000004861,[4861],johnjamesjacoby,Add ethitter to credits screen. (2.3 branch)
changeset,0000003293,[3293],johnjamesjacoby,"Add extra 'bbpress' class to special bbPress admin menu separator, so it does not get trimmed off when WordPress 3.2 cleans up trailing separators."
changeset,0000005158,[5158],johnjamesjacoby,"Add extra conditions to `bbp_current_user_can_access_create_topic_form()`. This addresses `You cannot create new topics` issues eluded to in the forums, of certain users being unable to create new topics even when their capabilities allow."
changeset,0000002516,[2516],chrishajer,"Add favicon to bb-admin. Fixes #1303. Props mr_pelle
"
changeset,0000003285,[3285],johnjamesjacoby,Add filter that allows breadcrumb to be manipulated immediately before extraction.
changeset,0000002944,[2944],johnjamesjacoby,"Add filter to 'allowed_themes' to force the 'bbp-twentyten' theme to appear, even if not explicitly enabled via the network theme interface."
changeset,0000004912,[4912],johnjamesjacoby,Add filter to bbp_get_search_terms().
changeset,0000004913,[4913],johnjamesjacoby,Add filter to bbp_get_search_title().
changeset,0000004361,[4361],johnjamesjacoby,Add filter to bbp_verify_nonce_request() to allow hot-swapping of the request match.
changeset,0000003553,[3553],johnjamesjacoby,Add filters to _is_ functions. Add forum form field function. Use bbp_get_user_id() in bbp_title().
changeset,0000003636,[3636],johnjamesjacoby,Add filters to default query loop arguments to allow them to be manipulated before being parsed.
changeset,0000002581,[2581],johnjamesjacoby,Add folder for bbp-default theme
changeset,0000003289,[3289],johnjamesjacoby,Add forum and topic archive body classes to bbp_body_class()
changeset,0000003290,[3290],johnjamesjacoby,Add forum and topic archive titles to bbp_title() filter. Rearrange logic to match existing order in other functions.
changeset,0000003678,[3678],johnjamesjacoby,"Add forum author functions, and rename bbp_get_forum_parent() to bbp_get_forum_parent_id(). See #1669."
changeset,0000003117,[3117],johnjamesjacoby,Add forum post type back to nav menus. Props christopher-jon.
changeset,0000003130,[3130],johnjamesjacoby,Add forum root to breadcrumb if root slug is equal to the path of an existing page. Update field CSS styling to play more nicely with theme compatibility. Replace breadcrumb titles with breadcrumb template part.
changeset,0000004698,[4698],johnjamesjacoby,Add forum search to body class. Props alex-ye. Fixes #2165.
changeset,0000004699,[4699],johnjamesjacoby,Add forum search to is_bbpress(). See #2165.
changeset,0000004604,[4604],johnjamesjacoby,Add forum specific kses allowed tags to common component. Tweak topic and reply content filters to use these new kses functions.
changeset,0000003040,[3040],johnjamesjacoby,Add forum/topic last activity sync function to recount tool. Fixes #1503. Props Nightgunner5.
changeset,0000002918,[2918],johnjamesjacoby,Add function for updating the anonymous reply count of a topic. Uncomment new topic redirection.
changeset,0000003575,[3575],johnjamesjacoby,Add functions and settings for BuddyPress group forums and Akismet extensions. Add checks to these settings to only show them when relevant. Do not load new Forums component if BuddyPress forums are already active. See #1669.
changeset,0000003468,[3468],johnjamesjacoby,Add functions for versions to bbp-common-functions.php and use them through-out. Update PHPDoc and remove globals accordingly.
changeset,0000003355,[3355],johnjamesjacoby,"Add functions to check user status, if spammer or deleted."
changeset,0000005832,[5832],johnjamesjacoby,Add future support for forum/topic/reply dashicon column headers to `admin.css`.
changeset,0000003181,[3181],johnjamesjacoby,Add general post meta functions to bbp-general-functions.php. More consolidation to do here later.
changeset,0000003185,[3185],johnjamesjacoby,Add generic forum root slug to breadcrumb if WordPress page does not exist
changeset,0000002556,[2556],johnjamesjacoby,Add get_sidebar to template files
changeset,0000003859,[3859],johnjamesjacoby,Add GPL licensing and link to readme.txt.
changeset,0000002963,[2963],johnjamesjacoby,Add has_archive and show_in_nav_menus support for post types in bbpress.php. Also adjust the menu_position to include proper numeric values rather than ineffective strings.
changeset,0000003009,[3009],johnjamesjacoby,Add hooks to page-forum-statistics.php to allow it to be extended. Fixes #1499. Props !Nightgunner5 for original patch.
changeset,0000003269,[3269],johnjamesjacoby,Add humans.txt to bbPress 2.0
changeset,0000003592,[3592],johnjamesjacoby,Add id's to BuddyPress toolbar items for WordPress 3.3.
changeset,0000004924,[4924],johnjamesjacoby,Add ignore_sticky_posts to bbp_has_forums() and bbp_has_replies() queries.
changeset,0000003109,[3109],johnjamesjacoby,"Add improved breadcrumb support to bbp-twentyten, shortcodes, and theme compat. Add improved topic-tag support for theme compat. Add missing topic-tag template tags."
changeset,0000003112,[3112],johnjamesjacoby,Add in missing support for topic-tag shortcode query.
changeset,0000004252,[4252],johnjamesjacoby,Add index.php warning files in new bbp-includes folders. Fixes #1975.
changeset,0000005076,[5076],johnjamesjacoby,Add is_admin() and $pagenow checks to bbp_is_deactivation() and bbp_is_activation(). Hat tip alex-ye. Fixes #2386.
changeset,0000003567,[3567],johnjamesjacoby,Add is_forum_edit() check to breadcrumb function to correctly load the ancestors. See #1669.
changeset,0000003554,[3554],johnjamesjacoby,"Add is_user_logged_in() check to bbp_is_user_home(). Fixes #1655, props valendesigns. (plugin)"
changeset,0000004626,[4626],johnjamesjacoby,"Add jmdodd to humans.txt team, and readme.txt contributors."
changeset,0000003255,[3255],johnjamesjacoby,Add just in time filtering to topic terms when saving and editing a reply.
changeset,0000005345,[5345],johnjamesjacoby,Add license definition to plugin headers.
changeset,0000002637,[2637],johnjamesjacoby,Add license to bbp-twentyten theme
changeset,0000002640,[2640],johnjamesjacoby,Add license.txt to plugin root
changeset,0000004589,[4589],johnjamesjacoby,Add list-item styling inside topic and reply content. Props netweb. Fixes #2113.
changeset,0000002541,[2541],johnjamesjacoby,Add logic for forum and topic ID's
changeset,0000004253,[4253],johnjamesjacoby,"Add magic ""__call"" method to bbPress class, to prevent fatal errors when invalid bbpress() methods are used."
changeset,0000004629,[4629],johnjamesjacoby,Add magic unset method to main bbPress class.
changeset,0000003249,[3249],johnjamesjacoby,"Add menu_name and all_items labels to custom post type registrations, for WordPress 3.2 compat."
changeset,0000003015,[3015],johnjamesjacoby,Add meta_query's to bbp_get_user_topics_started() to exclude hidden forums. See #1470.
changeset,0000003014,[3014],johnjamesjacoby,Add meta_query's to topic and reply widget queries. See #1470.
changeset,0000004686,[4686],johnjamesjacoby,Add missing $. Props r-a-y. Fixes #2148.
changeset,0000003680,[3680],johnjamesjacoby,Add missing '_post_extras' actions to new topic/reply handlers. See #1669.
changeset,0000003336,[3336],johnjamesjacoby,Add missing 'bbpress' textdomain. Fixes #1562. Props cnorris23.
changeset,0000003693,[3693],johnjamesjacoby,Add missing .bbp-topic-author and .bbp-topic-content CSS for when bbp_show_lead_topic is true. Fixes #1728.
changeset,0000003005,[3005],johnjamesjacoby,Add missing
close tag to loop-forums.php
changeset,0000005718,[5718],netweb,"Add missing @since phpdoc to `bbp_get_public_child_count()` and `bbp_get_public_child_ids()` functions
"
changeset,0000002927,[2927],johnjamesjacoby,Add missing @since phpdoc to bbp_body_class function
changeset,0000005416,[5416],netweb,Add missing @since phpdoc to BBP_Forums_Group_Extension class
changeset,0000005422,[5422],netweb,Add missing @uses phpdoc to `bbp_get_reply_to_dropdown()`. See #2617
changeset,0000005324,[5324],johnjamesjacoby,Add missing `forum.js`. Props SGr33n. Fixes #2568.
changeset,0000006335,[6335],johnjamesjacoby,"Add missing `sep` argument to `bbp_get_author_link()` function, to match topic & reply equivalents."
changeset,0000004947,[4947],johnjamesjacoby,Add missing allow_revisions setting in bbp_get_default_options().
changeset,0000003401,[3401],johnjamesjacoby,Add missing assignment of 'bbp_forum_create' action in BBP_BuddyPress class.
changeset,0000003422,[3422],johnjamesjacoby,Add missing bbp_get_topic_tag_template() function.
changeset,0000005445,[5445],johnjamesjacoby,Add missing brackets to core functions.
changeset,0000003131,[3131],johnjamesjacoby,Add missing breadcrumb template part references in shortcode and single-forum.php
changeset,0000004651,[4651],johnjamesjacoby,Add missing col class to welcome screen. Fixes #2132.
changeset,0000003305,[3305],johnjamesjacoby,Add missing default tag/topic-tag slug change from bbp-settings.php
changeset,0000003805,[3805],johnjamesjacoby,"Add missing filters to some topic template tags.
* Remove inline logic from within some apply_filters() calls
* Props MZAWeb for initial patch
* Fixes #1787"
changeset,0000003262,[3262],johnjamesjacoby,Add missing forum_id's to category checks in forum description
changeset,0000003695,[3695],johnjamesjacoby,Add missing globals to bbp_edit_user_handler()
changeset,0000004251,[4251],johnjamesjacoby,Add missing HTML closing tag helper doc. Fixes #1921. Props jaredatch.
changeset,0000003037,[3037],johnjamesjacoby,Add missing new topic template part to single forum shortcode output
changeset,0000005070,[5070],johnjamesjacoby,"Add missing output escaping in admin edit links, and add unique classes to all admin links. See #2090."
changeset,0000003248,[3248],johnjamesjacoby,"Add missing pagination to view.php. Also swap out ""Oh no!"" text with no-topics template part in view.php."
changeset,0000003612,[3612],johnjamesjacoby,"Add missing parenthesis in bbp_close_topic(). Fixes #1689, props thebrent. (2.0)"
changeset,0000003611,[3611],johnjamesjacoby,"Add missing parenthesis in bbp_close_topic(). See #1689, props thebrent. (2.1)"
changeset,0000002811,[2811],johnjamesjacoby,Add missing phpDoc from r2810. Assign a default tab_index value to try to avoid conflicts.
changeset,0000003339,[3339],johnjamesjacoby,Add missing semi-colon in bbpress-rtl.css.
changeset,0000003834,[3834],johnjamesjacoby,Add missing styling to bbp-forum-content in theme compat. See #1800.
changeset,0000002673,[2673],johnjamesjacoby,Add missing subscribed forum topics template part code.
changeset,0000003491,[3491],johnjamesjacoby,Add missing tabindex's to edit profile page. Add missing button classes to buttons and button'esque links.
changeset,0000002607,[2607],johnjamesjacoby,Add missing table row tags to loop-bbp_replies.php
changeset,0000002606,[2606],johnjamesjacoby,Add missing table row tags to single-bbp_topic.php
changeset,0000003050,[3050],johnjamesjacoby,Add missing tag list and description back into single topic shortcode display
changeset,0000003619,[3619],johnjamesjacoby,Add missing textdomain in topics widget. Fixes #1661. Props Mamaduka.
changeset,0000004760,[4760],johnjamesjacoby,Add missing textdomain's for admin component. Props daveshine. Fixes #2197.
changeset,0000004764,[4764],johnjamesjacoby,Add missing textdomains to _nx_noop() in bbpress.php. Props alex-ye. Fixes #2200.
changeset,0000004704,[4704],johnjamesjacoby,Add missing topic-tag code in bbp_admin_reset_handler(). Props netweb. Fixes #2096.
changeset,0000004634,[4634],johnjamesjacoby,Add missing type in @return phpdoc tags for current user group status checks. See #2119.
changeset,0000003232,[3232],johnjamesjacoby,Add missing variable definition for $meta_query in bbp_exclude_forum_ids().
changeset,0000003397,[3397],johnjamesjacoby,"Add missing word ""forum"" in new topic activity stream action text."
changeset,0000002871,[2871],johnjamesjacoby,Add more strict post_type check to bbp_get_reply_id. Add avatar to revision log. Add more fancy reply_author_link function to include avatar and/or name.
changeset,0000002872,[2872],johnjamesjacoby,"Add more strict post_type check to bbp_get_topic_id. Add avatar to revision log. Add more fancy topic_author_link function to include avatar and/or name. Add single topic description function. More renames from last_active to last_active_time, and introduction of last_active_id functions"
changeset,0000003673,[3673],johnjamesjacoby,Add more verbose note about sanitization in bbp_filter_anonymous_post_data().
changeset,0000005198,[5198],johnjamesjacoby,Add netweb to contributors.
changeset,0000002685,[2685],johnjamesjacoby,"Add new topic form to forum index. Fixes #1379 props dudd, markmcwilliams"
changeset,0000003035,[3035],johnjamesjacoby,Add no topics/forums template parts to shortcode output
changeset,0000004923,[4923],johnjamesjacoby,Add no_found_rows and ignore_sticky_posts to widget queries.
changeset,0000005566,[5566],johnjamesjacoby,Add nonce checks to admin area topic & author suggest usages.
changeset,0000005629,[5629],johnjamesjacoby,Add nonce to bulk-user dropdown. Props jdgrimes. (2.5 branch)
changeset,0000005626,[5626],johnjamesjacoby,Add nonce to bulk-user dropdown. Props jdgrimes. (trunk)
changeset,0000003814,[3814],johnjamesjacoby,"Add nonces to admin area metabox saves, to avoid accidentally running save routines."
changeset,0000005192,[5192],johnjamesjacoby,Add nonces to BuddyPress notifications and improve single notification output.
changeset,0000005207,[5207],johnjamesjacoby,Add note about forums to subscriptions setting. Props mordauk. Fixes #2479. (2.5)
changeset,0000005208,[5208],johnjamesjacoby,Add note about forums to subscriptions setting. Props mordauk. Fixes #2479. (trunk)
changeset,0000005423,[5423],johnjamesjacoby,Add object references to `bbpress()` and `bbPress` document blocks.
changeset,0000003416,[3416],johnjamesjacoby,Add option for toggling topic revision logging on and off.
changeset,0000002517,[2517],chrishajer,"Add optional $user_id for subscriptions (useful for plugins). Further fixes #1268. Props dimadin
"
changeset,0000003324,[3324],johnjamesjacoby,"Add optional topic_id param to bbp_get_reply_position(), and use it where appropriate."
changeset,0000006386,[6386],johnjamesjacoby,Add original function parameters to `bbp_get_global_post_field` filter.
changeset,0000002575,[2575],johnjamesjacoby,Add pagination for forum
changeset,0000004643,[4643],johnjamesjacoby,Add paragraph tags to $allowed tags array in bbp_encode_bad() so they are not accidentally encoded from bbPress 1.1 migrations.
changeset,0000003661,[3661],johnjamesjacoby,Add param phpdoc to bbp_get_topic_tag_description(). Props tmoorewp.
changeset,0000005505,[5505],johnjamesjacoby,Add pending status to search results for capable users wishing to view all results. Props netweb. See #2645.
changeset,0000005502,[5502],johnjamesjacoby,Add pending topics to forum hidden topic counts. Props netweb. See #2645.
changeset,0000006157,[6157],xknown,"Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
"
changeset,0000006153,[6153],xknown,"Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
"
changeset,0000006164,[6164],xknown,"Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
"
changeset,0000003338,[3338],johnjamesjacoby,Add php5 visibilities to bbPress admin class.
changeset,0000003334,[3334],johnjamesjacoby,Add php5 visibilities to main bbPress class.
changeset,0000003832,[3832],johnjamesjacoby,Add phpdoc description to bbPress::register_theme_packages() warning about hardcoded theme package registrations.
changeset,0000004800,[4800],johnjamesjacoby,Add phpdoc file description block to form-user-roles.php. Props netweb. Fixes #2253.
changeset,0000005407,[5407],johnjamesjacoby,Add phpdoc to `bbp_trash_topic_replies()` from r5406. See #2494.
changeset,0000003358,[3358],johnjamesjacoby,Add plugin basename to $bbp global
changeset,0000003160,[3160],johnjamesjacoby,"Add preliminary password protected support to single forums and single topics, including theme compatibility."
changeset,0000003052,[3052],johnjamesjacoby,Add private and hidden forum handlers for shortcodes when user does not have proper caps
changeset,0000003698,[3698],johnjamesjacoby,"Add publish_* caps to bbp_map_meta_caps() and remove from associated _user_can functions. Also and add inline doc, and some code clean-up to bbp-core-caps.php."
changeset,0000002639,[2639],johnjamesjacoby,Add readme.txt and make adjustments to plugin meta at top of bbpress.php
changeset,0000003440,[3440],johnjamesjacoby,Add register and lost password link options to the login widget. Fixes #1587.
changeset,0000003082,[3082],johnjamesjacoby,Add remaining references to hidden post status in bbpress.php
changeset,0000003036,[3036],johnjamesjacoby,Add reply form and single topic template parts to shortcode output
changeset,0000003042,[3042],johnjamesjacoby,"Add reply form shortcode. Adjustments to shortcode strings, and remove topic form from forum and topic indexes, as it's possible to use both/all shortcodes on one page."
changeset,0000003268,[3268],johnjamesjacoby,Add reply ID to topic term filters. Props cnorris23.
changeset,0000005495,[5495],johnjamesjacoby,Add reply status section to `form-reply.php`. Props netweb. Fixes #2644.
changeset,0000002667,[2667],johnjamesjacoby,Add reply_author functions. Improvements to bbp-twentyten theme.
changeset,0000002751,[2751],johnjamesjacoby,Add reply_excerpt code from r2750. Props !GautamGupta via Google Code-in
changeset,0000005093,[5093],johnjamesjacoby,Add reply_to capability to main converter class. Props netweb. Fixes #2400.
changeset,0000002864,[2864],johnjamesjacoby,Add Retro Gravatar option. Fixes #1468. Props !JohnConners.
changeset,0000004582,[4582],jmdodd,"Add RTL CSS support for search introduced in #1575.
* Props netweb.
* Fixes #2109.
"
changeset,0000003647,[3647],johnjamesjacoby,Add RTL styling to bbp-twentyten tableless layout. Fixes #1703.
changeset,0000003205,[3205],johnjamesjacoby,"Add RTL support to bbp-twentyten. See #1528. Props ramly.
Also do not enqueue theme compat CSS when in admin area."
changeset,0000003204,[3204],johnjamesjacoby,Add RTL support to breadcrumbs. See #1528.
changeset,0000003487,[3487],johnjamesjacoby,Add sanity checks and code clean-up on Akismet extension to prevent debug notices or malformed results. Also fix issue where post_parent was always being reported for topics in check_post().
changeset,0000002929,[2929],johnjamesjacoby,Add sanity checks to _forum_id and _topic_id functions in bbp-reply-template.php. Add filter to bbp_is_reply_trash().
changeset,0000002636,[2636],johnjamesjacoby,Add screenshot to bbp-twentyten child theme (hat tip original Twenty Ten theme)
changeset,0000005318,[5318],johnjamesjacoby,Add screenshots to `readme.txt`. Props netweb. See #2555.
changeset,0000004774,[4774],johnjamesjacoby,Add Search title to current_text in bbp_get_breadcrumb(). Props alex-ye. Fixes #2218.
changeset,0000003167,[3167],johnjamesjacoby,"Add single view shortcode, and add single views to theme compatibility. Fix issue with theme compat where error could occur if output buffer content was somehow empty."
changeset,0000002549,[2549],johnjamesjacoby,"Add some _is_ logic, and better post_type and ID checks."
changeset,0000004334,[4334],johnjamesjacoby,Add some brackets to improve code readibility in update.php.
changeset,0000004611,[4611],johnjamesjacoby,Add some brackets to improve readability in /topics/functions.php. See #1799.
changeset,0000003332,[3332],johnjamesjacoby,Add some brackets to improve readability in bbp-reply-template.php
changeset,0000004644,[4644],johnjamesjacoby,Add some CSS to inline code elements. Tweak the pre/code CSS also. (Includes RTL)
changeset,0000003777,[3777],johnjamesjacoby,Add some extra logic to the default bbpress-functions.php to make copying into a new theme easier.
changeset,0000002956,[2956],johnjamesjacoby,Add some flair to the .form-allowed-tags in new topic and new reply forms.
changeset,0000005412,[5412],johnjamesjacoby,Add some missing brackets. See #2494.
changeset,0000003230,[3230],johnjamesjacoby,"Add some post status checks to the bbp_get_dropdown() function, and properly use the bbp_exclude_forum_ids() function only with non-forum queries."
changeset,0000002662,[2662],johnjamesjacoby,Add some primitive styling to favorites links
changeset,0000003275,[3275],johnjamesjacoby,"Add spam checks to new topic and reply handlers. If topic/reply is spam to start, add the proper meta_status in the event it was a false positive."
changeset,0000002740,[2740],johnjamesjacoby,Add spam/trash actions for replies + theme support for spam/trash replies for admins. Improve spam/trash actions for topics. Admin column CSS clean-up. Props !GautamGupta via Google Code-in
changeset,0000002926,[2926],johnjamesjacoby,Add specific classes to body_class. Fixes #1478.
changeset,0000002868,[2868],johnjamesjacoby,Add squiggly brackets around variables in query in bbp_check_for_duplicate. Add query functions for getting child count and last_id from any parent_id.
changeset,0000002677,[2677],johnjamesjacoby,Add style.css to bbp-default to hide broken theme notice.
changeset,0000004918,[4918],johnjamesjacoby,Add sub-actions for rewrite rules and permastructs. See #2336.
changeset,0000005553,[5553],johnjamesjacoby,"Add support for `ins` HTML tag, to supplement existing `del` tag support. Props danielbachhuber."
changeset,0000002968,[2968],johnjamesjacoby,Add support for bbp_show_load_topic() in bbp_get_topic_pagination() and adjust mid_size and end_size default values
changeset,0000005673,[5673],netweb,"Add support for BuddyPress PHPUnit test integration
* Bootstrap and load `/src/bbpress.php` when loading the test environment
* Detect and load BuddyPress when running the BuddyPress PHPUnit tests
* Setup `BP_UnitTest_Factory` in `BBP_UnitTestCase` during new BuddyPress PHPUnit test integration
* Bootstrap and load new factory class `BBP_UnitTest_Factory_For_Forum` for creating forums
Props boonebgorges. See #2782"
changeset,0000005155,[5155],johnjamesjacoby,"Add support for new BuddyPress notifications component, alerting members when their topics have been replied to. Requires BuddyPress 1.9."
changeset,0000004564,[4564],johnjamesjacoby,Add support for private post statuses in topics and replies loops. Fixes #2088.
changeset,0000003111,[3111],johnjamesjacoby,Add support for topic tags to theme compat.
changeset,0000005571,[5571],netweb,"Add support to `converter.php` to allow importing Subscribed Forums, Subscribed Topics and Favourite Topics
Props netweb. See #2668
"
changeset,0000005350,[5350],netweb,"Add support to vBulletin importer for 'YouTube Share' BBCode
Props netweb. Fixes #2601"
changeset,0000005206,[5206],johnjamesjacoby,Add target to anchor in `bbp_kses_allowed_tags()`. Props wpdennis. Fixes #2483. (2.5)
changeset,0000005205,[5205],johnjamesjacoby,Add target to anchor in `bbp_kses_allowed_tags()`. Props wpdennis. Fixes #2483. (trunk)
changeset,0000003860,[3860],johnjamesjacoby,Add template tags and supporting functions to display user role in topics and replies. Fixes #1815. Props cnorris23 for original patch.
changeset,0000003172,[3172],johnjamesjacoby,Add template tags for forum RSS links. See #1422.
changeset,0000003508,[3508],johnjamesjacoby,Add TextDomain and DomainPath to plugin header. Props !Viper007Bond for the reminder.
changeset,0000002476,[2476],johnjamesjacoby,"Add textdomain loader, language folder, and .pot placeholder."
changeset,0000004757,[4757],johnjamesjacoby,Add textdomain to _doing_it_wrong() feedback in bbp_setup_current_user().
changeset,0000003108,[3108],johnjamesjacoby,"Add theme compat for user profiles, profile editing, topic and reply editing, and other topic moderation functions."
changeset,0000003184,[3184],johnjamesjacoby,Add theme compatibility for forum and topic archives.
changeset,0000003023,[3023],johnjamesjacoby,Add theme support for bbPress in bbp-twentyten
changeset,0000003029,[3029],johnjamesjacoby,Add theme_compat() function to main $bbp object to load the topic.js and bbpress.css from bbp-twentyten if the currently active theme does not explicitly add theme support for bbPress.
changeset,0000003187,[3187],johnjamesjacoby,Add topic archive pagination support to bbp_has_topics()
changeset,0000002519,[2519],johnjamesjacoby,Add topic pagination
changeset,0000003226,[3226],johnjamesjacoby,"Add topic pagination support for pages or any single post, for improved shortcode support. Fixes #1533."
changeset,0000004966,[4966],johnjamesjacoby,Add topic reply link template functions. See #2340.
changeset,0000003624,[3624],johnjamesjacoby,Add topic sticky dropdown to wp-admin metabox. Fixes #1625. Props !GautamGupta.
changeset,0000002668,[2668],johnjamesjacoby,Add topic subscription ability. Fixes #1366 props !GautamGupta va Google Code-in
changeset,0000003643,[3643],johnjamesjacoby,Add topic-tag checks to bbp_body_class(). Fixes #1696. Props sorich87.
changeset,0000003613,[3613],johnjamesjacoby,Add topic-tag slug to array of available templates in both bbp_get_topic_tag_template() and bbp_get_topic_tag_edit_template(). Fixes #1685. Props ptahdunbar.
changeset,0000003279,[3279],johnjamesjacoby,Add topic-tag support to breadcrumbs
changeset,0000004803,[4803],johnjamesjacoby,"Add topic-view for popular topics, and use it in page-forum-statistics.php rather than hardcoded query."
changeset,0000002590,[2590],johnjamesjacoby,Add topic_author template tags. Improve admin rows.
changeset,0000003617,[3617],johnjamesjacoby,Add traditional WordPress 'plugin_locale' filter to load_textdoman() method. See #1647.
changeset,0000003306,[3306],johnjamesjacoby,Add UI feedback for possible slug and post type collisions.
changeset,0000005844,[5844],johnjamesjacoby,Add unit test for last topic & reply ID's for topics & forums. Fixes #2806. Props netweb.
changeset,0000005015,[5015],johnjamesjacoby,Add user Suggest support for post author overrides for topics and replies. Props alex-ye. Fixes #2224.
changeset,0000003610,[3610],johnjamesjacoby,Add user_nicename to single_user template hierarchy.
changeset,0000003280,[3280],johnjamesjacoby,Add values to global bbPress object vars. Adjust bbp_is_user_home() function to work with empty() rather than isset()
changeset,0000004887,[4887],johnjamesjacoby,"Add width: 100%; styling to reply divs, to prevent comment theme styles from bleeding over into forum topics. Fixes #2320 (2.3 branch)"
changeset,0000004888,[4888],johnjamesjacoby,"Add width: 100%; styling to reply divs, to prevent comment theme styles from bleeding over into forum topics. Fixes #2320 (trunk)"
changeset,0000002886,[2886],johnjamesjacoby,Add wp_cache_add_global_groups() to _setup_globals action to cache future custom queries.
changeset,0000005288,[5288],johnjamesjacoby,"Add XML output logging for PHPUnit tests. Props netweb. See #2542.
"
changeset,0000003756,[3756],johnjamesjacoby,"Addend '-update' to admin menu ID's
* Prevents ""Dashboard"" from being open when viewing bbPress settings
* Avoids namespace collisions elsewhere in UI"
changeset,0000005007,[5007],johnjamesjacoby,Additional CSS resets to improve theme compatibility for search and list items. Props jaredatch. Fixes #2283.
changeset,0000002832,[2832],johnjamesjacoby,Additional empty forum check to delete last active and last topic_id meta.
changeset,0000003434,[3434],johnjamesjacoby,"Additional sanity check in bbp_pre_get_posts() for forum queries, to hide forums the user is not capable of seeing. See #1576."
changeset,0000005137,[5137],netweb,Adds a link to bbPress about page to the admin bar. Props MZAWeb. Fixes #2035
changeset,0000003098,[3098],johnjamesjacoby,Adds missing $bbp global to bbp_recount_topic_hidden_replies() function. Fixes $#1508. Props cnorris23.
changeset,0000006566,[6566],johnjamesjacoby,Adimn: Fix some formatting in PHPDoc blocks.
changeset,0000002568,[2568],johnjamesjacoby,Adjust @since phpdoc for previous Voices commit.
changeset,0000002663,[2663],johnjamesjacoby,Adjust author.php and associated CSS
changeset,0000002759,[2759],johnjamesjacoby,Adjust BackPress includes paths in 1.0 branch.
changeset,0000002813,[2813],johnjamesjacoby,Adjust bbp_register template file to use template part in preparation for shortcode usage.
changeset,0000002589,[2589],johnjamesjacoby,Adjust breadcrumb template tag functions for future use.
changeset,0000003022,[3022],johnjamesjacoby,Adjust capability checks on forum queries to show private forums but still prevent non-capable users from posting to them.
changeset,0000003003,[3003],johnjamesjacoby,Adjust forum visibility dropdown to work with new 'hidden' option. Pass $post->ID through metabox do_actions. Remove CSS comments in bbp-admin.php to prevent syntax highlighting errors in certain IDE's and web based syntax highlighting scripts.
changeset,0000002838,[2838],johnjamesjacoby,Adjust message styling in bbp_topic_tag.php to use new .info class
changeset,0000002877,[2877],johnjamesjacoby,Adjust order by and direction of bbp_get_public_child_last_id
changeset,0000002778,[2778],johnjamesjacoby,"Adjust padding on content areas, and restrict image widths from breaking layout. Fixes #1441."
changeset,0000002532,[2532],johnjamesjacoby,Adjust tabindexes on login and post/edit forms.
changeset,0000003367,[3367],johnjamesjacoby,Adjust the bbPress Theme Compatibility admin nag to make more sense to less advanced users.
changeset,0000003354,[3354],johnjamesjacoby,"Adjust the check-order of pagination permalinks in bbp_has_topics(), allowing shortcode usage pagination to work. Fixes #1567."
changeset,0000002847,[2847],johnjamesjacoby,Adjust the horizontal padding of numeric table cells.
changeset,0000003064,[3064],johnjamesjacoby,Adjust the theme compat admin nag to only appear when viewing Appearance -> Themes
changeset,0000002806,[2806],johnjamesjacoby,Adjust topic and reply counts up the subforum tree. Fixes #1320. Props !GautamGupta
changeset,0000003297,[3297],johnjamesjacoby,Adjust topic exists check on topic_attributes_metabox_save() and update inline doc in both topic and reply metabox save functions. See r3295.
changeset,0000002651,[2651],johnjamesjacoby,Adjustments to admin area CSS for icons32 and WP 3.1
changeset,0000002878,[2878],johnjamesjacoby,Adjustments to bbp-twentyten to use new functions and include updated styling for them.
changeset,0000002564,[2564],johnjamesjacoby,Adjustments to get replies running. More to do here.
changeset,0000002970,[2970],johnjamesjacoby,"Adjustments to login and register forms to improve behavior and functionality.
Various documentation fixes.
Rename _bbp_topic_status meta to _bbp_status, and add migration routine to updater.
Sanity checks on $wp_query in bbp_pre_get_posts.
Fixes #1476, #1493. Props !GautamGupta for original diff."
changeset,0000002520,[2520],johnjamesjacoby,Admin area code clean-up
changeset,0000004127,[4127],johnjamesjacoby,"Admin Help:
* Repair admin help copy-pasta from r3686.
* For 2.1 branch.
* Props janeforshort."
changeset,0000004128,[4128],johnjamesjacoby,"Admin Help:
* Repair admin help copy-pasta from r3686.
* For 2.2 branch.
* Props janeforshort."
changeset,0000003991,[3991],johnjamesjacoby,"Admin Images
* Add 2x support for admin menu icons.
* Props chexee.
* See: #1839."
changeset,0000003992,[3992],johnjamesjacoby,"Admin Images
* Update admin CSS to WordPress core standard.
* See #1839."
changeset,0000003994,[3994],johnjamesjacoby,"Admin Images:
* Better align menu icons.
* Add version to images using bbp_get_version()
* See #1839."
changeset,0000003993,[3993],johnjamesjacoby,"Admin Images:
* Fix background size, so images scale correctly.
* See #1839."
changeset,0000003995,[3995],johnjamesjacoby,"Admin Images:
* Revert accidental CSS menu position tweaks.
* See #1839."
changeset,0000004046,[4046],johnjamesjacoby,"Admin Menus:
* Fix issue where bbPress top-level admin-menu positions could conflict with other plugins.
* Set menu_position on post-types to 555555.
* Refactor bbp_admin_menu_order() to reposition all available custom menus above the second separator.
* Fixes #1876."
changeset,0000002643,[2643],johnjamesjacoby,Admin nag notice about theme. Add skeleton for settings page. Move tools menu creation into main admin class.
changeset,0000006771,[6771],johnjamesjacoby,"Admin Notices: remove `create_function()` usage from tools feedback.
This change removes the last remaining deprecated function call for full PHP 7.2 support, while also making admin area notices a bit more flexible in the process.
Notices are now stored in an `bbpress()->admin->notices` array, and are output to the page via the `bbp_admin_notices` sub-action. This ensures that they'll only be made visible when bbPress is active, and keeps them contained to places where bbPress is already hooked in.
It was also previously possible for any user to dismiss the database upgrade notice, even if they were not capable of seeing it, so this is now fixed as well."
changeset,0000004348,[4348],johnjamesjacoby,"Admin Settings:
* If a setting is manually overridden, disable it.
* Introduces bbp_maybe_admin_setting_disabled() helper function.
* Update bbp_dropdown with 'disabled' parameter to allow disabling based on option."
changeset,0000004002,[4002],johnjamesjacoby,"Admin Settings:
* Move sections and settings into procedural functions in bbp-settings.php.
* Allows filtering of sections and fields without checking for faux-capabilities.
* Enables easier settings section and field manipulations, as well as adding or editing of future settings."
changeset,0000003998,[3998],johnjamesjacoby,"Admin Settings:
* Turn settings sections into multidimensional array, keyed by ID.
* Allows sections to be filtered, changed, rearranged, etc..."
changeset,0000006601,[6601],johnjamesjacoby,"Admin/Converter: Lazy load admin & converter as needed.
* Move admin class into its own file
* Remove `admin.php`
* Introduce `_setup_` functions to make loading them on the fly easier
* Simplify converter logic for smoother starting/stopping
* Improved UI for timer/status updates
* Remove double-duty variables from `BBP_Converter` and response data
* Switch from text-only response value to JSON object for improved flexibility
This allows the converter to return more data, and makes it easier to work with that data.
Todo:
* Error responses
* Check that starts are bumping correctly inside of steps
* Better utilize JSON responses"
changeset,0000003915,[3915],johnjamesjacoby,"Admin:
* Add missing quotes to icon URL css in BBP_Admin::admin_head()."
changeset,0000004053,[4053],johnjamesjacoby,"Admin:
* Add nonce checks and additional sanity checks to converter, to prevent it being loaded or accessed outside of the converter screen.
* Use 'load-' actions to conditionally load admin components on their respective screens.
* Remove post_type checks that are no longer needed as a result of conditionally loading each component.
* Use get_current_screen() to fill in any extra post_type checks.
* Sweep through converter, make output more clean, add output method, and store last query in the DB in case of failure."
changeset,0000004077,[4077],johnjamesjacoby,"Admin:
* Additional sanity checks on bail() methods, if get_current_screen() is not set."
changeset,0000003897,[3897],johnjamesjacoby,"Admin:
* Allow admin screens to be overridden by switch or capability.
* Always allow for is_super_admin().
* Fixes #1822."
changeset,0000004159,[4159],johnjamesjacoby,"Admin:
* First pass at WordPress core style about and credits UI."
changeset,0000003962,[3962],johnjamesjacoby,"Admin:
* Fix duplicate separator when user cannot see forum content.
* Fixes #1848."
changeset,0000004054,[4054],johnjamesjacoby,"Admin:
* Fix inverted $typenow check for replies.
* See r4053."
changeset,0000004070,[4070],johnjamesjacoby,"Admin:
* Introduce bail() method to forum/topic/reply components.
* Bail out of other methods if post_type doesn't match.
* Fixes issue where meta-box and styling were not always available on all appropriate screens.
* Also reverts some perfomance improvements implimented in r4053."
changeset,0000003916,[3916],johnjamesjacoby,"Admin:
* Mark some methods as static where appropriate in BBP_Admin class."
changeset,0000003963,[3963],johnjamesjacoby,"Admin:
* Move global declaration beyond cap checks in bbp_admin_separator()."
changeset,0000004068,[4068],johnjamesjacoby,"Admin:
* Remove 'manage_options' cap check from bbp_admin_separateror()
* This is now handled by bbp_admin_menu_order(), and can cause no separator to exist in certain situations."
changeset,0000004069,[4069],johnjamesjacoby,"Admin:
* Revert r4068, pending a better way to manipulate the menus."
changeset,0000004079,[4079],johnjamesjacoby,"Admin:
* Additional sanity checks on bail() methods, if get_current_screen() is not set. (2.1 branch)"
changeset,0000005850,[5850],johnjamesjacoby,"Admin: Add `hidden_post_status` field back to topic & reply metaboxes, and use `draft` or current post status as value.
This changeset fixes a bug that caused topics & replies to be marked as edited when moderated via `wp-admin`.
Hat-tip tharsheblows. Fixes #2741."
changeset,0000006705,[6705],johnjamesjacoby,"Admin: add an admin notice if database upgrade was skipped.
This change adds a persistent admin notice (who doesn't love those?) in the event that the forums are part of a large WordPress installation that prevented the automatic database upgrade routine from running.
Two links are provided: one to ""Go Upgrade"" and another to ""Hide Forever"". The first will take the user (with adequate capability) to the `Tools > Forums > Upgrade` screen; the second will delete the notice nag key from `wp_options`.
This includes some admin area CSS tweaks, so the asset version gets a bump as well."
changeset,0000006187,[6187],johnjamesjacoby,Admin: Add missing `@param`'s from r6186.
changeset,0000006190,[6190],netweb,"Admin: Add missing `@since` revisions from r6186.
"
changeset,0000006704,[6704],johnjamesjacoby,Admin: allow feedback dismissal to be optional in `bbp_admin_tools_feedback()`.
changeset,0000006252,[6252],johnjamesjacoby,"Admin: Alternate row styling for list tables.
* Remove `admin_head` methods in forums/topics/replies classes
* Move styling into `admin.css`
* Bump asset version"
changeset,0000006350,[6350],johnjamesjacoby,"Admin: Avatar margins on user relationship meta-boxes.
"
changeset,0000006603,[6603],johnjamesjacoby,Admin: buzz & swoop.
changeset,0000005851,[5851],johnjamesjacoby,"Admin: Check that the user can view the About page before adding the toolbar item.
This changeset ensures that only capable users will see the link to bbPress's admin-area ""About"" page.
Props ocean90. Fixes #2836."
changeset,0000006474,[6474],johnjamesjacoby,"Admin: Clean-up admin assets according to specifications.
"
changeset,0000006913,[6913],johnjamesjacoby,"Admin: Correctly register scripts & styles before enqueing them.
This commit moves style/script registration to dedicated admin-area actions, separating them from their relative enqueing actions.
It also deprecates the singular (incorrectly named) ""bbp_register_admin_style"" action and replaces it with the correctly named plural ""bbp_register_admin_styles"".
"
changeset,0000005903,[5903],johnjamesjacoby,"Admin: Do not register color schemes when running from source.
This changeset prevents the color picker UI from appearing (and not working) when running WordPress from it's `/src` directory.
See #2847."
changeset,0000006772,[6772],johnjamesjacoby,"Admin: enforce row-action order for forums, topics, and replies.
This change introduces a known (and filterable) sort-order to row-action keys, allowing for a more logical flow to better match Posts, Pages, and other WordPress core objects.
With slight variations, the flow is: Edit, Stick(to front), Un/approve, Open/Close, Delete/Trash, Spam, View.
Previous to this change, these `row_actions()` filters were only appending or overwriting keys, which introduced an unnecessary administration variation with no real benefit."
changeset,0000006040,[6040],netweb,"Admin: Escape `$file` variable for importer filenames in `bbp_converter_setting_callback_platform()`
Props xknown
Fixes #2792
"
changeset,0000006730,[6730],johnjamesjacoby,Admin: fix filter load order for PHP 7.1 compat.
changeset,0000006263,[6263],johnjamesjacoby,"Admin: Fix restoring/trashing topics & replies.
Fixes #2734. Props tharsheblows, thebrandonallen, netweb."
changeset,0000006186,[6186],johnjamesjacoby,"Admin: Implement new loading sequence for major admin components.
* Introduce new `bbp_current_screen` sub-action
* Hook forums/topics/replies into `bbp_current_screen`
* Remove various `bail()` methods, which were fragile and terrible anyways
* Revert r6178, thanks to order-of-operation issues with `get_current_screen()`
* Remove Comments & Discussion metaboxes if `comments` is not explicitly supported
See #2959."
changeset,0000006790,[6790],johnjamesjacoby,"Admin: improve topic/reply row-action UX.
This change includes a few improvements to how topics and replies are toggled from an admin area list-table:
* Make approve & not-spam links green to match comments UI
* More specifically target admin area links to avoid conflicts with other post types
* Make ""Approve"" a blanket ""publish"" action, meaning it will always publish a topic/reply even from spam or trash
* Make sure ""Not Spam"" will restore to ""pending"" if it was previously not published
* Bump CSS version
See #1799."
changeset,0000006791,[6791],johnjamesjacoby,"Admin: improve topic/reply row-action UX.
This change includes more improvements to how topics and replies are toggled from an admin area list-table:
* Move ""Empty Spam"" buttons to their own actions div
* Allow spam/trash/approve/unapprove from any other status, so topics/replies can be more freely moved around
* Add public/non-public functions for replies to match topics
See #1799."
changeset,0000006424,[6424],johnjamesjacoby,"Admin: in list-tables, if no parent forum/topic, show `—` instead.
Also make sure a few strings are escaped, and dropdowns are using correct parent text."
changeset,0000006475,[6475],johnjamesjacoby,"Admin: More admin mark-up updates
* Add `hr` after `h1`s on custom screens
* More accurate meta-box wrapper mark-up"
changeset,0000006697,[6697],johnjamesjacoby,Admin: prefer `implode()` over `join()`.
changeset,0000006852,[6852],johnjamesjacoby,"Admin: rearrange admin sub-action registrations.
Also fix a bug causing `custom_menu_order` to not be filtered, resulting in hidden admin menus for some users."
changeset,0000005904,[5904],johnjamesjacoby,Admin: Register color schemes based on bbPress plugin path vs. WordPress source. Fixes #2847.
changeset,0000005808,[5808],johnjamesjacoby,"Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.5.8 (2.5 branch)"
changeset,0000005809,[5809],johnjamesjacoby,"Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.6.0 (trunk)"
changeset,0000006800,[6800],netweb,"Admin: Remove deprecated `screen_icon()` calls.
See #2538. Fixes #3198. (2.5 branch).
"
changeset,0000006703,[6703],johnjamesjacoby,Admin: Remove duplicate dismiss button from `bbp_admin_tools_feedback()`.
changeset,0000006602,[6602],johnjamesjacoby,"Admin: Remove obscure 'About bbPress' admin-bar link.
Nobody ever really used it, and less is more in this case."
changeset,0000006500,[6500],johnjamesjacoby,"Admin: Rename `upgrades.php` to `upgrade.php` to match the other files.
"
changeset,0000006271,[6271],johnjamesjacoby,Admin: Rename list-table file for future autoloading of classes.
changeset,0000006709,[6709],johnjamesjacoby,"Admin: run `admin.css` through `grunt commit` routine.
This adds a missing Webkit CSS shim for how the bbPress logo is vertically aligned in the new database upgrade notice."
changeset,0000006750,[6750],johnjamesjacoby,"Admin: split reset handler into 2 functions (handler and logic)
This change improves compatibility with future WP CLI initiatives, specifically allowing removing all bbPress data.
Fixes #3173. Props espellcaste."
changeset,0000005932,[5932],johnjamesjacoby,"Admin: Swap `%d` for `%s` in `bbp_filter_dashboard_glance_items()`.
This changeset fixes a bug causing numbers to be truncated at the first non-numeric character.
Fixes #2857."
changeset,0000006776,[6776],johnjamesjacoby,Admin: update `esc_notice()` usage to map `WP_Error` content. See r6775.
changeset,0000005884,[5884],johnjamesjacoby,"Admin: Update `h2` to `h1` and remove `icon32` compatibility.
This changeset improves accessibility and brings bbPress's admin area headers up to par with WordPress 4.3.
Fixes #2840. See #WP31650."
changeset,0000006775,[6775],johnjamesjacoby,"Admin: update forum/topic/reply toggle notices to use `bbp_admin()->add_notice()`.
This changes the source hooks so notices are created earlier (and not just-in-time as toggles occur.) It also introduces an `esc_notice()` method to restrict the allowed HTML tags in notice messages down to a very finite set (completely avoiding all types of hi-jacks at a lower level.)"
changeset,0000006397,[6397],johnjamesjacoby,"Admin: Update row action toggle methods to be a bit more flexible.
This should improve support for custom toggle actions in `wp-admin`."
changeset,0000006773,[6773],johnjamesjacoby,Admin: update some inline docs from r6772.
changeset,0000005810,[5810],netweb,"Admin: Updated Topic and Reply contextual help
Props robkk. Fixes #2824
"
changeset,0000006604,[6604],johnjamesjacoby,"Admin: Use some JavaScript to spruce up the badge-animation.
@todo Update the ""What's New"" page contents."
changeset,0000007172,[7172],johnjamesjacoby,"Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In branches/2.6 for 2.6.7. Fixes #3311."
changeset,0000007171,[7171],johnjamesjacoby,"Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In trunk for 2.7.0. See #3311."
changeset,0000006233,[6233],netweb,"Administration: Initial pass updating contributors and props list for 2.6 release.
"
changeset,0000006052,[6052],netweb,"Administration: Only display bbPress users role in bbPress' ""Forum Role"" list
Since WordPress 4.4 users with multiple roles are displayed in WordPress' ""Site Role"" list, this changeset ensures bbPress' roles are only displayed under the ""Forum Role"" list and not duplicated in the ""Site Role"" list of the users list table.
Props johnbillion, tharsheblows for initial patches
Fixes #2874
"
changeset,0000006235,[6235],netweb,"Administration: Remove duplicate props entry for 2.6 release.
"
changeset,0000006234,[6234],netweb,"Administration: Second pass updating contributors and props list for 2.6 release.
"
changeset,0000005583,[5583],johnjamesjacoby,"Administrative support for for un/approving topics.
Props netweb, thebrandonallen. Fixes #2645."
changeset,0000005509,[5509],johnjamesjacoby,Administrative support for un/approving replies. Props netweb. See #2645.
changeset,0000004549,[4549],johnjamesjacoby,"AJAX:
* Add 'bbp_do_ajax' action to 'bbp_template_redirect' action.
* Update AJAX in theme compat to use new AJAX handler hooks."
changeset,0000004548,[4548],johnjamesjacoby,"AJAX:
* Introduce common/ajax.php, along with new AJAX handlers and helpers.
* Move bbp_ajax_response() into it.
* Include new file in bbpress.php."
changeset,0000004511,[4511],johnjamesjacoby,"Ajax:
* Remove call to wpList.process().
* Fixes duplicate ajax requests on topic subscriptions and favorites.
* Props MZAWeb.
* Fixes #1905 for !WordPress 3.4."
changeset,0000006871,[6871],johnjamesjacoby,"AJAX: always use `defined()` before setting an environmental constant.
This avoids a notice/warning if something has already set the the `DOING_AJAX` constant.
"
changeset,0000006581,[6581],johnjamesjacoby,Ajax: in `bbp_do_ajax()` use `wp_die()` instead of `die()` so any custom handlers are used.
changeset,0000006758,[6758],johnjamesjacoby,"Ajax: introduce `bbp_ajax_headers()` abstracted from `bbp_do_ajax()`.
This change makes it possible to send the proper & expected headers in custom theme-side AJAX implementations."
changeset,0000006755,[6755],johnjamesjacoby,"Ajax: send a proper `400` response when nothing happens.
This change adds nocache and noindex headers to theme-side AJAX handling, adds support for pre-sanitized `$action` parameters, and checks that the action-hook actually has actions hooked to it before attempting to execute it.
Similar to `admin-ajax.php` a `400` response is now returned when an AJAX request is attempted that does not have a handler."
changeset,0000003939,[3939],johnjamesjacoby,"Akismet
* Allow $post_data to be manipulated in BBP_Akismet::check_post().
* This opens the door to overriding the Akismet result based on any other criteria later (for third party plugins.)"
changeset,0000004091,[4091],johnjamesjacoby,"Akismet:
* Check response before assigning value.
* Fix bug with Akismet request faliing."
changeset,0000004813,[4813],johnjamesjacoby,"Akismet:
* Introduce and use improved BBP_Akismet::get_user_roles() method.
* Includes proper type-casting, cleaner logic, and allows for easier dynamic role debugging."
changeset,0000004042,[4042],johnjamesjacoby,"Akismet:
* Pass additional post information on topic/reply edit, to prevent Akismet from nooping it.
* Revert part of r4041; put actions back before bbp_is_error() calls.
* Replace some missing revision numbers.
* Fixes #1869."
changeset,0000004017,[4017],johnjamesjacoby,"Akismet:
* Run topic and reply edits through Akismet, to thwart editing spam during the edit window.
* Fixes #1860."
changeset,0000004243,[4243],johnjamesjacoby,"Akismet:
* Set a default message if there is no response from Akismet servers.
* Prevents debug notices and polluted Akismet results in post meta."
changeset,0000007127,[7127],johnjamesjacoby,"Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In branches/2.6, for 2.6.6.
Props Otto42.
See #2853."
changeset,0000007126,[7126],johnjamesjacoby,"Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In trunk, for 2.7.
Props Otto42.
See #2853."
changeset,0000006874,[6874],johnjamesjacoby,"Akismet: allow ""trusted"" users to bypass spam `post_status` enforcement.
* Adds `bbp_bypass_check_for_spam` filter ahead of the HTTP request
* Adds `bbp_bypass_spam_enforcement` filter ahead of `post_status` switch
* Adds `current_user_can( 'moderate' )` check to bypass spam enforcement
* Adds `parse_response()` method to `BBP_Akismet` class for future abstraction
This allows for 2 different ways to short-circuit Akismet:
* Before the HTTP request happens
* After the HTTP request, but before the status change
bbPress will now trust users that pass the `moderator` capability check (including per-forum moderators) even if Akismet thinks the content is spammy. The Akismet history will still reflect the catch; the status will just not be enforced.
This addresses issues we've seen on WordPress.org, BuddyPress.org, and bbPress.org, where trusted moderator posts would be caught in the spam queue, even when they have privileges to enter the queue and unspam their own posts.
Fixes #2917. Props tharsheblows for the original patch!
"
changeset,0000005828,[5828],johnjamesjacoby,"Akismet: Clean up potential accidental inline assignment in `BBP_Akismet::check_post()`.
This commit moves a variable assignment out of a comparison to improve code clarity."
changeset,0000007128,[7128],johnjamesjacoby,"Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In branches/2.6, for 2.6.6.
Props procifer.
See #3368."
changeset,0000007129,[7129],johnjamesjacoby,"Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In trunk, for 2.7.
Props procifer.
See #3368."
changeset,0000007205,[7205],johnjamesjacoby,"Akismet: hook clean-up methods from r7203 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In branches/2.6, for 2.6.7.
See #3395."
changeset,0000007206,[7206],johnjamesjacoby,"Akismet: hook clean-up methods from r7204 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In trunk, for 2.7.0.
See #3395."
changeset,0000006227,[6227],johnjamesjacoby,"Akismet: Improve pluralization of statistics strings.
Fixes #2960. Props thebrandonallen, netweb."
changeset,0000006226,[6226],johnjamesjacoby,"Akismet: Improve translatability of ""(+ %d hidden)"" strings.
Fixes #3009. Props SergeyBiryukov."
changeset,0000006225,[6225],johnjamesjacoby,"Akismet: Improve translatability of update-history strings.
Fixes #3011. Props SergeyBiryukov."
changeset,0000007227,[7227],johnjamesjacoby,"Akismet: improvements to clean-up routines, based on user feedback.
* Use correct `ID` column for the `posts` database table
* Use correct `post_id` column for the `postmeta` database table
* Reduce row limit to `1000` from `100000` to avoid lengthy table locks in active forums
* Remove usage of constant, that may be phased out eventually
* Update related code docs
* Introduce helper methods for applying dynamically named filters
In branches/2.6 for 2.6.9. Fixes #3395."
changeset,0000007226,[7226],johnjamesjacoby,"Akismet: improvements to clean-up routines, based on user feedback.
* Use correct `ID` column for the `posts` database table
* Use correct `post_id` column for the `postmeta` database table
* Reduce row limit to `1000` from `100000` to avoid lengthy table locks in active forums
* Remove usage of constant, that may be phased out eventually
* Update related code docs
* Introduce helper methods for applying dynamically named filters
In trunk for 2.7. See #3395."
changeset,0000005933,[5933],johnjamesjacoby,Akismet: include title with content. Props cfinke. Fixes #2858.
changeset,0000007203,[7203],johnjamesjacoby,"Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3395."
changeset,0000007204,[7204],johnjamesjacoby,"Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3395."
changeset,0000005654,[5654],netweb,"Akismet: Pass additional user and post information to Aksimet helping identify suspicious new posts
* `comment_total`: Total user posts via `bbp_get_user_post_count()`
* `comment_last_active_gmt`: Topic last active time via `bbp_get_topic_last_reply_id()`
* `comment_account_registered_gmt`: User registered via `$userdata->user_registered`
Props eoigal. Fixes #2591
"
changeset,0000007195,[7195],johnjamesjacoby,"Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In branches/2.6 for 2.6.7. See #3410."
changeset,0000007196,[7196],johnjamesjacoby,"Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In trunk for 2.7.0. See #3410."
changeset,0000007155,[7155],johnjamesjacoby,"Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In branches/2.6, for 2.6.6. See #3400.
Props cfinke."
changeset,0000007156,[7156],johnjamesjacoby,"Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In trunk, for 2.7. Fixes #3400.
Props cfinke."
changeset,0000007194,[7194],johnjamesjacoby,"Akismet: Remove ""publish"" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In branches/2.6 for 2.6.7. Fixes #3410."
changeset,0000007193,[7193],johnjamesjacoby,"Akismet: Remove ""publish"" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In trunk for 2.7.0. See #3410."
changeset,0000006867,[6867],johnjamesjacoby,"Akismet: send sanitized string values for referer and user-agent.
Avoids issues with huge/invalid strings. and ensures that `_wp_http_referer` is used.
"
changeset,0000007198,[7198],johnjamesjacoby,"Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In branches/2.6 for 2.6.7. Fixes #2853."
changeset,0000007197,[7197],johnjamesjacoby,"Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In trunk for 2.7.0. See #2853."
changeset,0000003340,[3340],johnjamesjacoby,"Alas, poor mdawaffe! I knew him, 1.0..."
changeset,0000003463,[3463],johnjamesjacoby,Align the topic edit input fields with their labels. Rename duplicate tag-name form field to tag-existing-name. Fixes #1612.
changeset,0000005692,[5692],johnjamesjacoby,"All: ensure all URLs are escaped (2.5 branch)
"
changeset,0000005691,[5691],johnjamesjacoby,"All: ensure all URLs are escaped (trunk) and cleanup some phpdoc
Also introduce `bbp_dropdown` class for dropdowns."
changeset,0000005693,[5693],johnjamesjacoby,All: ensure all URLs are escaped part 2 (2.5 branch)
changeset,0000005676,[5676],johnjamesjacoby,"All: Update default values for `$args` parameters from empty strings to empty arrays.
This is a micro-optimization to avoid unnecessary calls to `wp_parse_str()` inside `bbp_parse_args()`."
changeset,0000003068,[3068],johnjamesjacoby,Allow $none_found custom message in bbp_get_dropdown()
changeset,0000005162,[5162],johnjamesjacoby,Allow 'bbp_has_search_results' filter to still run even if no search terms were passed. This brings it inline with other component queries. Fixes #2356.
changeset,0000005493,[5493],johnjamesjacoby,Allow `class` attribute for `pre` tags in `bbp_kses_allowed_tags()`. Props netweb. Fixes #2657.
changeset,0000006728,[6728],johnjamesjacoby,"Allow a custom redirect destination in the reply form.
(Specifically for shortcode or third-party plugin usage.)
See r3450."
changeset,0000003674,[3674],johnjamesjacoby,Allow additional anonymous data to be automatically saved on reply and topic update any prevent any possible debug notices with missing core values in the process.
changeset,0000004790,[4790],johnjamesjacoby,Allow additional post-type CSS classes to be passed as a second parameter. Fixes #2242.
changeset,0000003369,[3369],johnjamesjacoby,Allow Akismet global key to be set. (trunk)
changeset,0000003798,[3798],johnjamesjacoby,Allow bbp_create_initial_content() to be filtered or provided an array of defaults.
changeset,0000004951,[4951],johnjamesjacoby,Allow both get and post requests in bbp_is_ajax().
changeset,0000003270,[3270],johnjamesjacoby,Allow breadcrumb separator to be translated. Remove spaces from separator and use str_pad instead.
changeset,0000003402,[3402],johnjamesjacoby,Allow BuddyPress profile URLs to override bbPress profile URLs in an inexpensive way.
changeset,0000002691,[2691],johnjamesjacoby,Allow capable admins to view other users' topic subscriptions.
changeset,0000002784,[2784],johnjamesjacoby,Allow capable users to mark topics as sticky/super sticky on creation/edit. Props !GautamGupta via Google Code-in
changeset,0000005313,[5313],johnjamesjacoby,Allow closed topics to be split and merged into. Props netweb. Fixes #1714.
changeset,0000003450,[3450],johnjamesjacoby,"Allow custom redirects in login, register, and lost pass forms."
changeset,0000003451,[3451],johnjamesjacoby,Allow default options to be overloaded from within the $bbp->options array ala bbPress 1.x.
changeset,0000003188,[3188],johnjamesjacoby,Allow existing pages to override forum and topic archive slugs.
changeset,0000003621,[3621],johnjamesjacoby,Allow forum/topic/reply row classes to be filtered. Fixes #1664.
changeset,0000003066,[3066],johnjamesjacoby,Allow just-in-time filtering of forums/topics/replies queries
changeset,0000003222,[3222],johnjamesjacoby,Allow just-in-time manipulation of topic and reply data before creating or editing them. See #1477.
changeset,0000003371,[3371],johnjamesjacoby,Allow manually setting the offset and number of topics to retrieve. Props boonebgorges.
changeset,0000004701,[4701],johnjamesjacoby,Allow moderation and blacklist to be bypassed based on function parameters. Props tlovett1. Fixes #2154.
changeset,0000004934,[4934],johnjamesjacoby,Allow partial global/local .mo file loading in bbPress::load_textdomain(). Props strangerstudios.
changeset,0000003387,[3387],johnjamesjacoby,Allow previously set $redirect_to override in bbp_logout_url(). Fixes #1580.
changeset,0000004961,[4961],johnjamesjacoby,Allow registering of settings that don't need callbacks or titles. See #2340.
changeset,0000003215,[3215],johnjamesjacoby,Allow site options to pass a default value if none exists.
changeset,0000004632,[4632],johnjamesjacoby,Allow tabbing into and out of TinyMCE. Fixes #1917.
changeset,0000004971,[4971],johnjamesjacoby,Allow the search feature to be toggled on and off. Introduces new setting and supporting function to get and override the option easily in third party plugins. Fixes #2342.
changeset,0000003507,[3507],johnjamesjacoby,"Allow theme compatibility to be extended more completely. Move contents of bbp-twenty-ten's functions.php into a class, which extends the new BBP_Theme_Compat class."
changeset,0000005012,[5012],johnjamesjacoby,"Allow topic form shortcode to accept a forum_id attribute. Props netweb, GautamGupta. Fixes #1649."
changeset,0000003221,[3221],johnjamesjacoby,Allow Topic Form shortcode to work on pages or any other single template. Fixes #1535.
changeset,0000005310,[5310],johnjamesjacoby,Allow topic-tag descriptions to be edited theme-side. Props netweb. Fixes #1613.
changeset,0000004935,[4935],johnjamesjacoby,"Allow topics to replace the forum archive:
* Add condition to bbp_parse_args() and add a specific query variable early, and use this variable in bbp_is_forum_archive().
* Add condition to display_forum_archive() shortcode, to output topics if set.
* Add forum archive check to bbp_has_topics(), to ensure pagination links are correct.
* See #1500."
changeset,0000003856,[3856],johnjamesjacoby,Allow user favorites and subscriptions to work per site on multisite installations. Props isaacchapman. Fixes #1818.
changeset,0000003251,[3251],johnjamesjacoby,"Allow WordPress pages to overload forum and topic archive pages.
Introduce bbp_reset_all_filters() and bbp_restore_all_filters() functions to handle specific bypassing of the_content filter for theme compat. Introduce bbp_is_topic_archive() and bbp_is_forum_archive() functions to help with bypassing archive pages."
changeset,0000005358,[5358],johnjamesjacoby,Alphabetize grunt packages and update keywords in `package.json`.
changeset,0000005802,[5802],johnjamesjacoby,"Always predefine `$args` as an array, for code consistency across all components."
changeset,0000003579,[3579],johnjamesjacoby,Always set defaults in bbp_theme_compat_reset_post().
changeset,0000005231,[5231],nacin,"Ancient bbPress: Adjust error reporting to cope with PHP 5.4.
"
changeset,0000006737,[6737],johnjamesjacoby,"Anonymous Users: improve styling for anonymous topic/reply author boxes.
This change wraps anonymous author data in `span` elements where `a` elements would normally be used for registered users, and tweaks the default template-pack CSS to accomodate these new elements."
changeset,0000006399,[6399],johnjamesjacoby,"Anonymous: Clean-up `bbp_set_current_anonymous_user_data()`:
* Make sure cookies are secure when SSL
* Only call `time()` once to avoid potential delays
* Cast cookie lifetime to `int` after filtering
* Inline docs"
changeset,0000006742,[6742],johnjamesjacoby,Anonymous: cleanup from r6741.
changeset,0000006917,[6917],johnjamesjacoby,"Anonymous: delete meta key if value is empty.
This commit ensures that editing a non-anonymous topic via WordPress Admin does not erroneously add empty anonymous author keys to post meta."
changeset,0000006838,[6838],johnjamesjacoby,"Anonymous: Don't use `esc_html__()` in combination with HTML tags.
Props wpdennis. Fixes #3210.
"
changeset,0000006400,[6400],johnjamesjacoby,"Anonymous: Improve `$anonymous_data` implementation:
* Always treat it as an array, handling for `false` values was never used
* Introduce `_sanitize_` and `_update_` partner functions for the existing `_filter_` function
* Ensure that cookies and meta-data values are stripped of invalid characters in the same way that anonymous comments are, to prevent inconsistencies between anonymous forum and commenter cookie data
* Update surrounding documentation blocks
* Prefer strict type-casting and `is_array()` comparisons"
changeset,0000006740,[6740],johnjamesjacoby,"Anonymous: remove `sanitize_comment_cookies()` call.
This was causing repeated comment cookie sanitization on each subsequent page load."
changeset,0000006741,[6741],johnjamesjacoby,"Anonymous: remove escaped placeholders from `$where` clause of duplicate check.
This change fixes a bug for versions of WordPress 4.8.3 and higher, that was causing the anonymous email comparison to use the placeholder text instead of the raw email address, but only when an email address contained a `%` character.
Also use the correct return variant, and make sure the output is escaped."
changeset,0000006021,[6021],netweb,"API - Feeds: Use `feed_content_type( 'rss2' )` for RSS feeds.
This changeset updates the RSS 2 native mime type `application/rss+xml`, previously `rss-http` used `text/xml` which was removed from WordPress in [WP36230] and [WP32468].
(2.5 branch)
Props thebrandonallen.
Fixes #2901.
"
changeset,0000005969,[5969],netweb,"API - Feeds: Use `feed_content_type( 'rss2' )` for RSS feeds.
This changeset updates the RSS 2 native mime type `application/rss+xml`, previously `rss-http` used `text/xml` which was removed from WordPress in [WP36230] and [WP32468].
Props thebrandonallen.
Fixes #2901.
"
changeset,0000006749,[6749],netweb,"API - Importers: WordPress capital_P_dangit for Xenforo importer.
Props @1naveengiri.
Fixes #3183.
"
changeset,0000006001,[6001],netweb,"API - Importers: Xenforo:
* Adds support for ""soft deleted"" topics and replies imported as ""pending"" status
* Add support for YouTube, Vimeo, and Daily Motion BBCode conversion
* Add quotes BBCode conversion
Fixes #2927
"
changeset,0000006333,[6333],netweb,"API - Installation/Upgrade: Fix copy pasta inline doc in `bbp_admin_upgrade_user_engagements()`
"
changeset,0000003505,[3505],johnjamesjacoby,"API adjustments:
* Refactor _status_ vars into callable functions.
* Audit usage of $bbp global.
* Perform get_class() checks on extensions to avoid errors if global $bbp is overloaded.
* Bump DB version to 175."
changeset,0000006059,[6059],netweb,"API Feeds: RSS `` element in `bbp_display_topics_feed_rss2()` shouldn't be translated.
This changeset brings this RSS `` element inline with other instances in bbPress feeds.
Props thebrandonallen.
Fixes 2961.
"
changeset,0000005659,[5659],johnjamesjacoby,API: Add more context to`bbp_redirect()` documentation. See #2778.
changeset,0000005658,[5658],johnjamesjacoby,"API: Introduce `bbp_redirect()`
* Wraps `wp_safe_redirect()` & `exit()` calls
* Prevents errors from potentially empty `wp_get_referrer()` results
* Replace `wp_safe_redirect()` usages with `bbp_redirect()`
Fixes #2778."
changeset,0000006214,[6214],netweb,"Appearance - Included Themes: Update admin base SCSS styles:
* Updated via upstream WordPress `_admin.scss` file via WP:changeset:38602, WP:changeset:38638, WP:changeset:38660, WP:changeset:39141, and WP:changeset:39249
See #2583
"
changeset,0000006818,[6818],netweb,"Appearance - Included Themes: Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:43019
* `_mixins.scss` via WP:changeset:41984
See #2583.
"
changeset,0000007221,[7221],johnjamesjacoby,"Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In branches/2.6 for 2.6.8. Fixes #3443."
changeset,0000007220,[7220],johnjamesjacoby,"Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In trunk for 2.7. See #3443."
changeset,0000006910,[6910],johnjamesjacoby,"Appearance: Use right-to-left suffix in default template pack.
Fixes #3263. Props GDragoN.
"
changeset,0000003203,[3203],johnjamesjacoby,Apply editable_slug filter on form_options. Introduce bbp_form_option() functions to handle the output. Fixes #1526. Props ramly.
changeset,0000006738,[6738],johnjamesjacoby,"Args: pass default parameters into filters in `bbp_parse_args()`.
This change allows conditional filtering of parsed arguments based on the arguments originally passed in."
changeset,0000003455,[3455],johnjamesjacoby,Ask and ye shall receive. Remove the logged in user avatar from the topic and reply forms in bbp-twentyten. Tweak the textarea's of those forms to fill the width of the bounding fieldsets.
changeset,0000006690,[6690],johnjamesjacoby,"Assets: Lint recent CSS & JS changes for password toggle.
This change makes the build process work again. :)"
changeset,0000006261,[6261],johnjamesjacoby,"Assets: Remove `screen` restriction on default template pack styling.
Improves styling when printing and third-party plugins (like Autoptimize.)
Props thebrandonallen. Fixes #3012."
changeset,0000006608,[6608],johnjamesjacoby,"Assets: Update admin CSS/JS to match lint rules, and update packages.
"
changeset,0000003662,[3662],johnjamesjacoby,"Assorted forum template tag code improvements.
* Pass $forum_id in filters where possible
* Make sure echo functions pass all param's to return functions
* Pretty code tweaks"
changeset,0000003663,[3663],johnjamesjacoby,"Assorted topic template tag code improvements.
* Pass $topic_id in filters where possible
* Make sure echo functions pass all param's to return functions
* Pretty code tweaks"
changeset,0000002771,[2771],johnjamesjacoby,Attempt to sort by menu_order rather than post_title.
changeset,0000005020,[5020],johnjamesjacoby,"Attributes are optional in the display_topic_form() shortcode. Suppresses debug notice when no attribute is passed, introduced in r5012. See #1649."
changeset,0000003267,[3267],johnjamesjacoby,"Audit checked() usage. Correct reversed logic, add usage to topic widget, and test all usages to ensure functionality."
changeset,0000003837,[3837],johnjamesjacoby,Audit count functions and add number_format_i18n filter to them. See #1810.
changeset,0000003478,[3478],johnjamesjacoby,Audit default usage value of '_bbp_forums_per_page'
changeset,0000006191,[6191],johnjamesjacoby,"Audit direct query and `prepare()` usages, and more tightly adhere to best practices.
* No quotes around directives
* Avoid concatenation, prefer variable parsing in double-quoted strings
* Covers converters, helper functions, and tools"
changeset,0000004705,[4705],johnjamesjacoby,Audit form field functions. Cast some $_POST values. Props Maty.
changeset,0000004708,[4708],johnjamesjacoby,Audit form field functions. Cast some $_POST values. Props Maty. (2.2 branch)
changeset,0000004867,[4867],johnjamesjacoby,"Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (2.3 branch)"
changeset,0000004866,[4866],johnjamesjacoby,"Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (trunk)"
changeset,0000003651,[3651],johnjamesjacoby,"Audit the bbp-twentyten theme's actions, HTML, and CSS. See #1702."
changeset,0000003054,[3054],johnjamesjacoby,Audit the usage of $wp_query global through out bbPress plugin and use core WP functions where possible instead.
changeset,0000003325,[3325],johnjamesjacoby,Audit the usage of 'view=all' and create helper functions to handle frequent query arg checks and adjustments. Removes the need for passing $count_hidden between functions.
changeset,0000004948,[4948],johnjamesjacoby,"Audit title attributes, and remove instances where they would match template-tag contents. Fixes #2318."
changeset,0000004806,[4806],johnjamesjacoby,"Audit up widget code:
* Add missing UI for some options.
* Introduce methods for parsing widget arguments.
* General code clean up.
* Props alex-ye.
* Fixes #2250."
changeset,0000003344,[3344],johnjamesjacoby,"Audit usage of all _is_ functions. Introduce _is_single_ functions for post types, and use where applicable. Add query names to shortcodes. Fix improper favorite/subscribe links when used within a shortcode. Organize admin actions and filters in bbp-core-hooks.php."
changeset,0000003825,[3825],johnjamesjacoby,"Audit widgets for untranslated or incorrectly translated strings.
* Remove PHP4 compat from widgets
* Add missing translation to recent replies widget
* Add brackets to titles to better group widgets together
* Fixes #1797"
changeset,0000006950,[6950],johnjamesjacoby,"Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.6.1, branches/2.6"
changeset,0000006953,[6953],johnjamesjacoby,"Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.7, trunk."
changeset,0000006591,[6591],johnjamesjacoby,"Authors: Rejig author link functions.
* Allow for easier filtering of link sections
* Update default arguments to remove no-break space and `
`, and rely on styling instead
* Surrounding code clean-up
* Add escaping to display names in links
"
changeset,0000006565,[6565],johnjamesjacoby,"Authors: Use `bbp_get_fallback_display_name()` instead of ""Anonymous"".
This change uses the new function introduced in r6562 to allow the fallback display name to be filtered, and passes the relative topic or reply ID in for additional context."
changeset,0000003716,[3716],johnjamesjacoby,Avoid inline variable assignments and cast appropriate retvals as int in bbp-forum-functions.php.
changeset,0000003715,[3715],johnjamesjacoby,Avoid inline variable assignments in bbp-reply-functions.php.
changeset,0000005601,[5601],johnjamesjacoby,"Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.1 branch)
"
changeset,0000005603,[5603],johnjamesjacoby,"Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.2 branch)
"
changeset,0000005597,[5597],nacin,"Avoid notices in bbPress Akismet plugin-like hack thing.
"
changeset,0000005605,[5605],johnjamesjacoby,"Avoid notices in bbPress's Akismet plugin. For 1.2 branch. See r5597.
"
changeset,0000003660,[3660],johnjamesjacoby,Avoid possible inline variable assignment in topics_column_data() method.
changeset,0000005643,[5643],johnjamesjacoby,"Backport `do_not_reply` email address code from trunk to 2.5 branch (for what will be 2.5.6.) See #2618, r5642.
"
changeset,0000002760,[2760],johnjamesjacoby,Backport bb-login.php changes from trunk to 1.0 branch.
changeset,0000002791,[2791],johnjamesjacoby,Backport clean_url fixes to 0.9 branch.
changeset,0000004759,[4759],johnjamesjacoby,"Backport roles improvements to 2.2 branch.
* bbp_add_forums_roles() now returns the modified roles global.
* Hardening around saving a user's role when editing their profile.
* Call bbp_add_forums_roles() in a few places to make sure roles are added before using add_role() or set_role()."
changeset,0000004358,[4358],johnjamesjacoby,Bail out of admin actions when deactivating bbPress. Prevents admin options and display actions from interfering with the deactivation process.
changeset,0000002978,[2978],johnjamesjacoby,Bail out of bbp_pre_get_posts if suppress_filters argument is set.
changeset,0000003630,[3630],johnjamesjacoby,Bail out of bbp_template_include_theme_compat() early if theme explicitly adds theme support for bbPress.
changeset,0000003631,[3631],johnjamesjacoby,Bail out of bbp_template_include_theme_supports() early if theme does not support bbPress.
changeset,0000004770,[4770],johnjamesjacoby,Bail out of converter if there is no request method. Fixes #2113.
changeset,0000002916,[2916],johnjamesjacoby,Basic WordPress 3.0 compat in bbp_get_title for taxonomy
changeset,0000002610,[2610],johnjamesjacoby,"bbp-twentyten improvements: Normalize classes, show pagination on topics, show forum per topic when viewing recent, center some column contents"
changeset,0000004819,[4819],johnjamesjacoby,bbp_add_error() phpdoc updates. Props netweb. Fixes #2271.
changeset,0000004573,[4573],johnjamesjacoby,"bbp_get_dropdown():
* Use get_pages() instead of get_posts().
* Pass walker and disabled_categories array items into get_pages().
* Fixes #2102."
changeset,0000004254,[4254],johnjamesjacoby,"bbp_get_total_users():
* Use count_users() instead of get_users().
* Fixes #1982, #1984."
changeset,0000003926,[3926],johnjamesjacoby,"bbp_has_topics():
* Smarter defaults for topic-search and stickies, and both params together.
* Rearrange default arguments to improve readability."
changeset,0000002508,[2508],johnjamesjacoby,"bbp_loader.php cleanup (docs, whitespace, etc)"
changeset,0000003846,[3846],nacin,"bbPress 1.1 branch: Fix issue with author of post_id 1 appearing as topic last poster when first post is created by a bozo'ed user. props johnjamesjacoby.
Backports [3796] to the 1.1 branch.
"
changeset,0000004001,[4001],johnjamesjacoby,"bbPress 1.1 Converter:
* Test removing post_position = 1 check from topics, which is preventing spam/trashed topics from being converted.
* Add reply position to replies.
* Inline doc clean-up."
changeset,0000004006,[4006],johnjamesjacoby,"bbPress 1.x Converter:
* Add poster IP address to topic meta.
* Inline doc tweaks."
changeset,0000004004,[4004],johnjamesjacoby,"bbPress 1.x Converter:
* More phpdoc.
* Optimize post_position field mappings for topics and replies, to now properly convert trashed topics with no replies.
* Pinking shears."
changeset,0000004005,[4005],johnjamesjacoby,"bbPress 1.x Converter:
* Remove commented out post_position code."
changeset,0000005572,[5572],netweb,"bbPress 1.x importer: Include Subscribed Topics and Favourite Topics
Props netweb. See #2668
"
changeset,0000005570,[5570],netweb,bbPress 1.x importer: Only import bbPress 1.x topic tag taxonomy `bb_topic_tag` so that the `tags` import does not also import topic subscriptions.
changeset,0000005305,[5305],nacin,"bbPress 1.x: Allow log-in attempt even if we think the user is already logged in.
If your session cookie's internal expiration time has passed, we give you a grace period of one hour for POST and XHR requests. If within that hour you're trying to log in again, the grace period goes into effect for the POST. Then bb-login.php kicks you out because it thinks you're already logged in, instead of setting a new cookie for you.
So long, heisenbug.
"
changeset,0000005595,[5595],nacin,"bbPress 1.x: Call bb_get_user() from bb_get_user_by_nicename().
This ensures that this gem runs from bb_get_user() on profile pages: ""Re calculate the user's meta in case we're pulling from a value cached on another site"". So far, we know this has manifested itself as causing incorrect pagination for activity on profile pages, based on which site did the initial caching.
In an ideal world, these ""short"" keys would use a magic getter on BP_User, but user objects in bbPress 1.x are mostly stdClass objects in practice. Fun times.
"
changeset,0000005552,[5552],nacin,"bbPress 1.x: Clear user activation keys after password changes.
The code previously cleared activation keys after they were used to reset a password, but not if a user logs in to change the password on their own (say, if they remember it). Also, actually remove the DB row, rather than emptying it.
"
changeset,0000005615,[5615],nacin,"bbPress 1.x: Use the same user cache group names as WordPress.
See also https://backpress.trac.wordpress.org/changeset/360.
"
changeset,0000006149,[6149],johnjamesjacoby,"bbPress 2.5.12 requires WordPress 4.7, as will bbPress 2.6 and higher."
changeset,0000002501,[2501],mdawaffe,"bbPress uses term_taxonomy_id as the tag's ID. BackPress uses term_id as the tag's ID.
When removing a tag, the two ids were getting confused resulting in set_object_terms() being called with the incorrect IDs.
That incorrect call to set_object_terms() resulted in 'random' tags being applied to a topic after deleting a tag.
"
changeset,0000005136,[5136],netweb,"bbPress1.php converter improvements. Props netweb. Fixes #2460
* Add forum category conversion support
* Add _bbp_total_reply_count
* Fix Topic slug field mapping
* Add Reply slug field mapping
* Improved inline docs
"
changeset,0000004138,[4138],johnjamesjacoby,"bbPress:
* Tag 2.1.2
"
changeset,0000005970,[5970],netweb,"bbPress: Bumb readme.txt tested-up-to tags to 4.4.
"
changeset,0000005990,[5990],netweb,"bbPress: Bumb readme.txt tested-up-to tags to 4.5.
"
changeset,0000003905,[3905],johnjamesjacoby,"bbPress::setup_globals()
* Add filters to: basename, plugin_dir, plugin_url, themes_dir, themes_url, and lang_dir.
* Props tott.
* Fixes #1824."
changeset,0000006583,[6583],johnjamesjacoby,"Better 404 handling:
* Introduce `bbp_is_404` query var, and set this in places where the default 404 condition needs to be overridden
* Introduce `bbp_set_200()` for cases where a default of 404 needs to be set to a 200
* Introduce `bbp_get_wp_query()` helper for getting the `$wp_query` global
* Update `bbp_set_404()` to accept a `$query` parameter to make passing the query around easier
* Update child-ids queries to use the `last_changed` cache to reduce the amount of cache churn when cleaning
Fixes #3047. See #1973."
changeset,0000005534,[5534],johnjamesjacoby,Better ABSPATH check in `bbpress.php` stub loader.
changeset,0000004663,[4663],johnjamesjacoby,Better CSS support for code tags nested in pre tags.
changeset,0000002731,[2731],johnjamesjacoby,Better default permalink support
changeset,0000002788,[2788],johnjamesjacoby,Better handling of title attributes. Props !GautamGupta via Google Code-in
changeset,0000002684,[2684],johnjamesjacoby,Better latest reply handling for forums and topics
changeset,0000002654,[2654],johnjamesjacoby,Better pagination verbiage
changeset,0000003007,[3007],johnjamesjacoby,Better private forum support in single-forum.php and single-topic.php.
changeset,0000002584,[2584],johnjamesjacoby,Better support for custom topic tag slug
changeset,0000003261,[3261],johnjamesjacoby,Better support for forum categories in forum description template tag.
changeset,0000002776,[2776],johnjamesjacoby,Better user edit and registration file inclusion checks.
changeset,0000006331,[6331],johnjamesjacoby,"Bootstrap: Split `setup_globals()` up into 2 methods:
* `setup_environment()` to handle directories, paths, urls, etc...
* `setup_variables()` to handle queries, rewrite rules, bbPress specific ""globals"", etc...
This will allow us to use included functions as default variables later."
changeset,0000003997,[3997],johnjamesjacoby,"Bozo Plugin (1.1 branch):
* Cast return value as array to suppress debug notice.
* Fixes #1646.
* Props !GautamGupta."
changeset,0000004175,[4175],johnjamesjacoby,"Bozo:
* Change post status to 'bozo' on creation/edit if user is a bozo.
* Modifies create/edit handlers for topics and replies."
changeset,0000004173,[4173],johnjamesjacoby,"Bozo:
* Map 'bozo' caps to disallow for moderators.
* Move inactive user check out of bbp_is_user_bozo() and into bbp_map_meta_caps()."
changeset,0000004174,[4174],johnjamesjacoby,"Bozo:
* Use correct bbp_get_bozo_post_status() function when registering post status."
changeset,0000004169,[4169],johnjamesjacoby,"Bozons:
* Add bozo post_status and function helper.
* For 'bozo' capability."
changeset,0000004170,[4170],johnjamesjacoby,"Bozos:
* Add bbp_is_user_bozo() function to bbp-user-functions.php.
* Note that neither anonymous nor inactive users can be bozos, as they already either can or cannot post, and should not be allowed to post uncontrollably. This behavior differs from bbPress 1.x, where a bozo could also be a spam user."
changeset,0000004171,[4171],johnjamesjacoby,"Bozos:
* Add bozo post status to bbp_has_topics() and bbp_has_replies() if current user is a bozo."
changeset,0000002529,[2529],mdawaffe,"bp_bbpress_cron_check get's loaded all the time anyway, so just load it up front"
changeset,0000005437,[5437],johnjamesjacoby,Bracketize common component.
changeset,0000005438,[5438],johnjamesjacoby,Bracketize core component.
changeset,0000005441,[5441],johnjamesjacoby,"Bracketize extensions, and missed a spot in the admin."
changeset,0000005435,[5435],johnjamesjacoby,Bracketize forums component.
changeset,0000005431,[5431],johnjamesjacoby,Bracketize replies component.
changeset,0000005433,[5433],johnjamesjacoby,Bracketize search component.
changeset,0000005432,[5432],johnjamesjacoby,Bracketize topics component.
changeset,0000005436,[5436],johnjamesjacoby,Bracketize users component.
changeset,0000005440,[5440],johnjamesjacoby,Brackets and code formatting improvements to admin component.
changeset,0000006160,[6160],xknown,"Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()` and PHP 5.x constructors.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
- Add PHP 5.x style constructors.
- Use `preg_match` instead of `eregi`
See #3033
"
changeset,0000006159,[6159],xknown,"Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
"
changeset,0000006206,[6206],xknown,"branch 0.9: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
"
changeset,0000006162,[6162],xknown,"Branch 0.9: Remove all the expressions that use the `preg_replace` function with the `e` modifier.
The `e`(val) modifier is not longer supported in PHP7, use `preg_replace_callback` instead.
See #3033
"
changeset,0000006171,[6171],xknown,"branch 0.9: Silence signature mismatch notices.
In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict
See #3033
"
changeset,0000006170,[6170],xknown,"branch 0.9: Silence signature mismatch notices.
In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict
See #3033
"
changeset,0000006161,[6161],xknown,"Branch 0.9: Use `preg_match` instead of `ereg`
See #3033
"
changeset,0000006158,[6158],xknown,"Branch 0.9: use a more recent version of add_query_arg which reduces the use of `func_get_arg`.
See #3033
"
changeset,0000006208,[6208],xknown,"branch 1.1: Avoid infinite recursion loop when creating a new WP_User instance.
See #3303
"
changeset,0000006205,[6205],xknown,"branch 1.1: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
"
changeset,0000006260,[6260],xknown,"branch 1.2: Fix infinite loop in `xmlrpc.php`
"
changeset,0000006209,[6209],xknown,"branch 1.2: Fix infinite loop when create a new WP_User instance.
See #3033
"
changeset,0000006163,[6163],xknown,"Branch 1.2: Fix parse errors in PHP 7
The result of new can't be longer assigned by reference.
See #3033
"
changeset,0000006165,[6165],xknown,"Branch 1.2: Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument.
- Add also PHP 5.x style constructors.
See #3033
"
changeset,0000006167,[6167],xknown,"Branch 1.2: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
"
changeset,0000006207,[6207],xknown,"branch 1.2: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
"
changeset,0000004373,[4373],johnjamesjacoby,"Breadcrumb:
* Fix copy-pasta in bbp_get_breadcrumb().
* Regression from adding more arguments to HTML output.
* Fixes #2017."
changeset,0000004332,[4332],johnjamesjacoby,"Breadcrumb:
* More flexible HTML output for breadcrumb.
* Adds ability to modify HTML before/after separator, current, and each crumb.
* Hat-tip netweb for inital patch.
* Fixes #2009."
changeset,0000003898,[3898],johnjamesjacoby,"Breadcrumbs:
* Add classes to breadcrumb items that were missing them (forum|topic|reply|topic-tag)
* Fixes #1821.
* Props netweb for original patch."
changeset,0000004558,[4558],johnjamesjacoby,"Breadcrumbs:
* Use is_singular() in bbp_get_breadcrumb().
* Fixes issue where single reply trail would be incorrect.
* Fixes #2086 (2.2 branch)"
changeset,0000004557,[4557],johnjamesjacoby,"Breadcrumbs:
* Use is_singular() in bbp_get_breadcrumb().
* Fixes issue where single reply trail would be incorrect.
* Fixes #2086 (trunk)"
changeset,0000003901,[3901],johnjamesjacoby,"Breadcrumbs:
* Wrap separator in a span if it exists.
* Shorten $breadcrumbs variable to $crumbs for improved readability.
* Fixes #1821 again.
* Props netweb for original patch."
changeset,0000003464,[3464],johnjamesjacoby,Break single loop elements into separate template parts in bbp-twentyten for easier ajaxifying.
changeset,0000002902,[2902],johnjamesjacoby,Breathing room
changeset,0000005444,[5444],johnjamesjacoby,Breathing room for `!` usages in Search component.
changeset,0000005443,[5443],johnjamesjacoby,Breathing room for `!` usages in Topics component.
changeset,0000005442,[5442],johnjamesjacoby,Breathing room for `!` usages in Users component.
changeset,0000006250,[6250],johnjamesjacoby,"Breathing room for `!class_exists()` checks, and bump to 2.6-beta-2."
changeset,0000006196,[6196],johnjamesjacoby,Breathing room for all `!is_` usages.
changeset,0000005614,[5614],johnjamesjacoby,Bring `Gruntfile.js` tasks up to speed with BuddyPress.
changeset,0000002576,[2576],johnjamesjacoby,Bring back 1 reply text
changeset,0000002577,[2577],johnjamesjacoby,Bring back 1 reply text.
changeset,0000002527,[2527],mdawaffe,bring back ghetto $tagged_topic_count used by tag_pages()
changeset,0000005649,[5649],netweb,"Bring Gruntfile.js tasks up to speed with BuddyPress
* Adds a `src` target for `jsvalidate` to validate JavaScript files in the `/src` folder
* WordPress JavaScript coding standards improvements
* See also r5614
Props netweb. Fixes #2766
"
changeset,0000004684,[4684],johnjamesjacoby,"Bring per RSS page settings back, using correct cap key."
changeset,0000004245,[4245],johnjamesjacoby,"BuddyPress Activity:
* Ensure activity stream items are updated when editing topics and replies.
* Delete activity stream items when deleting topics and replies.
* Props jmdodd.
* Fixes #1753."
changeset,0000004546,[4546],johnjamesjacoby,"BuddyPress Activity:
* When adding activity stream items, use raw values and trust !BuddyPress to properly texturize output.
* Fixes #2082 (2.2 branch)"
changeset,0000004547,[4547],johnjamesjacoby,"BuddyPress Activity:
* When adding activity stream items, use raw values and trust !BuddyPress to properly texturize output.
* Fixes #2082 (trunk)"
changeset,0000004540,[4540],johnjamesjacoby,"BuddyPress Activity:
* When creating activity stream items, utilize 'hide_sitewide' instead of not recording any activity at all.
* Hat-tip boonebgorges.
* Fixes #2081 (2.2 branch)"
changeset,0000004538,[4538],johnjamesjacoby,"BuddyPress Activity:
* When creating activity stream items, utilize 'hide_sitewide' instead of not recording any activity at all.
* Hat-tip boonebgorges.
* Fixes #2081 (trunk)"
changeset,0000003789,[3789],johnjamesjacoby,BuddyPress Group Forum create page and handler. See #1669
changeset,0000004815,[4815],johnjamesjacoby,"BuddyPress Group Forum Enhancements:
* When deleting a Group, also remove the forum connection. Fixes #2261.
* When disabling a Group's Forum, also remove the forum connection. Fixes #2262.
* Allow editing of a Group's Forum via the Group Admin UI. Fixes #2263.
* Props imath."
changeset,0000003654,[3654],johnjamesjacoby,"BuddyPress Group Forum Integration:
* BuddyPress group/forum sync functions
* Add forum/topic row actions
* Group create/edit helper methods
* Forum create/edit handlers
* See #1669"
changeset,0000003799,[3799],johnjamesjacoby,"BuddyPress group forums:
* Fix new reply and topic redirects
* Remove first group forum topic and reply in lieu of more customization
* See #1669
* Fixes #1776
* Fixes #1778
* Fixes #1777
* Props boonebgorges"
changeset,0000004545,[4545],johnjamesjacoby,"BuddyPress Groups:
* Add moderator and admin checks to map_topic_meta_caps()
* Props lakrisgubben.
* Fixes #2084 (2.2 branch)"
changeset,0000004544,[4544],johnjamesjacoby,"BuddyPress Groups:
* Add moderator and admin checks to map_topic_meta_caps()
* Props lakrisgubben.
* Fixes #2084 (trunk)"
changeset,0000004536,[4536],johnjamesjacoby,"BuddyPress Groups:
* Fix issue causing paginated group forum requests to incorrectly fail.
* Hat-tip boonebgorges.
* Fixes #2080 (2.2 branch)"
changeset,0000004537,[4537],johnjamesjacoby,"BuddyPress Groups:
* Fix issue causing paginated group forum requests to incorrectly fail.
* Hat-tip boonebgorges.
* Fixes #2080 (trunk)"
changeset,0000004554,[4554],johnjamesjacoby,"BuddyPress Groups:
* If group does not have forums active, do not show forum tab.
* See #2083 (2.2 branch)"
changeset,0000004553,[4553],johnjamesjacoby,"BuddyPress Groups:
* If group does not have forums active, do not show forum tab.
* See #2083 (trunk)"
changeset,0000004602,[4602],johnjamesjacoby,"BuddyPress Groups:
* In maybe_unset_forum_menu(), also check for current groupmeta.
* Props r-a-y.
* Fixes #2094."
changeset,0000004769,[4769],johnjamesjacoby,"BuddyPress Groups:
* Simplify group forum display logic.
* Use bbp_has_ functions to preload posts. Reduces overhead of calling get_posts() and then creating new WP_Query() object later.
* Use bbPress's front-end nonce verification logic to avoid wp_die'ing theme-side.
* When editing a BuddyPress group's forum settings, allow network administrators to modify the group connection.
* Fixes #2201, #2202."
changeset,0000004555,[4555],johnjamesjacoby,"BuddyPress Groups:
* When enabling a group forum in an existing group, audit group forums, remove any strays, and maybe create a new forum if needed.
* Also fixes bugs in removing a value from group/forum ID arrays.
* Fixes #2083 (2.2 branch)"
changeset,0000004556,[4556],johnjamesjacoby,"BuddyPress Groups:
* When enabling a group forum in an existing group, audit group forums, remove any strays, and maybe create a new forum if needed.
* Also fixes bugs in removing a value from group/forum ID arrays.
* Fixes #2083 (trunk)"
changeset,0000005807,[5807],johnjamesjacoby,"BuddyPress Groups: Backport r5560 to 2.5 branch (for 2.5.8) for improved PHP5 compatibility and to avoid a debug notice.
Props boonebgorges."
changeset,0000007209,[7209],johnjamesjacoby,"BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3417."
changeset,0000007210,[7210],johnjamesjacoby,"BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3417."
changeset,0000004405,[4405],johnjamesjacoby,"BuddyPress Repair:
* Repair forum group ID meta so relationship is fully mapped.
* Update feedback message to include group and forum counts.
* Props jmdodd.
* Fixes #2025."
changeset,0000004435,[4435],johnjamesjacoby,"BuddyPress/Capabilities:
* Add supporting methods for handling group forum topic moderator functionality.
* Uses map_meta_cap filter to allow group moderators and admins to perform their duties.
* Also allows regular group members to view private/hidden forums if they are a group member.
* Fixes #2033."
changeset,0000004523,[4523],johnjamesjacoby,"BuddyPress:
* Add reply move support for BuddyPress group forums.
* See #1900, fixes #2064."
changeset,0000003908,[3908],johnjamesjacoby,"BuddyPress:
* Change BBP_Forums_Component methods to public.
* These should probably be made protected at some point."
changeset,0000003909,[3909],johnjamesjacoby,"BuddyPress:
* Change BBP_Forums_Groups_Component methods to public.
* These should be allowed to be protected by BuddyPress core later."
changeset,0000004213,[4213],johnjamesjacoby,"BuddyPress:
* Clean up logic in strip_mentions_on_edit() method."
changeset,0000004266,[4266],johnjamesjacoby,"BuddyPress:
* Remove advanced group forum admin UI; go with feature parity of existing bbPress 1.1 installations for a v1.
* Remove support for multiple forums/groups combinations. Assume the first item in the array is the only one.
* Adds some canonical redirection to group forum content.
* Maps forum content links to group forums when needed.
* Add support for editing of topics and replies within group forums.
* Some more to do here, but closing in on completeness.
* Huge props jmdodd,
* Fixes #1906.
* See #1669."
changeset,0000006836,[6836],netweb,"BuddyPress: Add a `for` attribute to the new forum form label improving accessibility
Props mercime.
Fixes #3208.
"
changeset,0000005849,[5849],johnjamesjacoby,"BuddyPress: Add all topic statuses to `bbp_filter_modify_page_title()`.
This changeset fixes a bug that only allowed published topics to be queried in group forums.
Props netweb. Fixes #2699."
changeset,0000006808,[6808],johnjamesjacoby,"BuddyPress: add more `fully_loaded()` methods to component classes.
This will allow an entry point for plugins to alter these classes how they see fit.
Fixes #3192."
changeset,0000007184,[7184],johnjamesjacoby,"BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In branches/2.6 for 2.6.7. Fixes #3341.
Props konnektiv."
changeset,0000007183,[7183],johnjamesjacoby,"BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In trunk for 2.7.0. See #3341.
Props konnektiv."
changeset,0000006220,[6220],johnjamesjacoby,"BuddyPress: Additional conditionals for group forum topic checks.
Fixes #2974. Props r-a-y."
changeset,0000006383,[6383],johnjamesjacoby,"BuddyPress: Bail if in a feed.
Props r-a-y, netweb. Fixes #2745."
changeset,0000006492,[6492],netweb,"BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y.
Fixes #2690.
Merges [5857] to the 2.5 branch.
"
changeset,0000005857,[5857],johnjamesjacoby,"BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y. Fixes #2690."
changeset,0000006805,[6805],johnjamesjacoby,"BuddyPress: clean up new `get_profile_url()` method.
See r6804."
changeset,0000006541,[6541],johnjamesjacoby,"BuddyPress: Continuation of r6538.
* Prefer data attributes
* Stop passing around localized nonces
Props r-a-y. Fixes #3114.
"
changeset,0000005847,[5847],johnjamesjacoby,"BuddyPress: Do not filter admin toolbar URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress is network activated and bbPress is active on the non-root blog.
Props imath. Fixes #2713."
changeset,0000005846,[5846],johnjamesjacoby,"BuddyPress: Do not filter profile URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress was network activated and bbPress was active on the non-root blog.
Props imath. See #2713."
changeset,0000006696,[6696],johnjamesjacoby,"BuddyPress: Do not record edit activity if revisions are off.
This change will prevent edits to topics & replies from creating new Activity Stream items, by obeying both the global setting and the post-type-supports properties of topics & replies. It also prevents activity stream items from being created when reply positions are recalculated on the fly."
changeset,0000006370,[6370],johnjamesjacoby,"BuddyPress: Dynamic activity for topics & replies, part 1.
* Functions for activity action filters
Props thebrandonallen. See #2794."
changeset,0000006372,[6372],johnjamesjacoby,"BuddyPress: Dynamic activity for topics & replies, part 2.
* Filters for activity action functions
* Tests for the new activity filters
Props thebrandonallen. See #2794."
changeset,0000007058,[7058],johnjamesjacoby,"BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.6.14, branches/2.6"
changeset,0000007057,[7057],johnjamesjacoby,"BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.7, trunk."
changeset,0000007059,[7059],johnjamesjacoby,"BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.6.14, branches/2.6"
changeset,0000007060,[7060],johnjamesjacoby,"BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.7, trunk"
changeset,0000006538,[6538],johnjamesjacoby,"BuddyPress: Favorites & Subscriptions AJAX improvements
* Pass a data attribute along with links
* Sanitize `action` key when passed into AJAX action hook
* Send a `200` response code
This commit allows favorite & subscription links to work with AJAX in BuddyPress group forums pages.
Props r-a-y. Fixes #3114"
changeset,0000006367,[6367],johnjamesjacoby,"BuddyPress: Filter `bbp_is_single_forum` for group forums.
Props r-a-y. Fixes #2727. See #2974."
changeset,0000006710,[6710],johnjamesjacoby,"BuddyPress: improve targeting of single forum/topic filters.
This change simplifies the logic used when attaching-to and checking-for the current BuddyPress Group Forum & Topic pages, by conditionally filtering behind a singular `bp_is_group()` check.
Fixes #3165. Props thebrandonallen."
changeset,0000006240,[6240],johnjamesjacoby,"BuddyPress: In `functions.php`, prefer `bp_loggedin_user_id()` over `get_current_user_id()`.
This allows BuddyPress filters & functionality to drive the decision making process (rather than WordPress proper) to improve integration with third-party BuddyPress plugins & themes that may rely on BuddyPress in these instances."
changeset,0000005905,[5905],johnjamesjacoby,"BuddyPress: Introduce `BBP_Forums_Group_Extension::update_group_forum_visibility()` to keep group forum visibility in alignment with BuddyPress Group visibility.
This changeset ensures that when a BuddyPress Group's visibility changes, it's bbPress forum visibility changes along with it. This avoids a UX issue where Group visibility and Forum visibility could become misaligned when updating a Group.
Props boonebgorges. Fixes #2599."
changeset,0000007109,[7109],johnjamesjacoby,"BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In branches/2.6, for 2.6.6.
Fixes #3213."
changeset,0000007108,[7108],johnjamesjacoby,"BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In trunk, for 2.7.0.
Fixes #3378."
changeset,0000006392,[6392],johnjamesjacoby,BuddyPress: Missed the skipping of groups tests. Proprs thebrandonallen. Fixes #3089.
changeset,0000006807,[6807],johnjamesjacoby,"BuddyPress: more efficient includes method.
Props r-a-y. Fixes #3193."
changeset,0000006488,[6488],johnjamesjacoby,"BuddyPress: Only wrap titles in `h2` tags if they are not empty.
Allows easier overriding if titles are not desired at all.
See #3105."
changeset,0000005848,[5848],johnjamesjacoby,BuddyPress: Pass the currently logged in user ID when creating toolbar links. See #2713.
changeset,0000006674,[6674],johnjamesjacoby,"BuddyPress: Prefer `bbp_redirect()` in `bbp_maybe_create_group_forum_root()`
This change uses the new internal function as it's intended, and removes an additional `die;` usage.
Trunk, for 2.6."
changeset,0000006810,[6810],johnjamesjacoby,"BuddyPress: prefer `empty()` check on `disable_blogforum_replies` setting.
This fixes a bug causing some activity to not appear in relative activity streams.
Fixes #3180."
changeset,0000007188,[7188],johnjamesjacoby,"BuddyPress: prevent possible duplicate ""Topics"" & ""Replies"" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In branches/2.6 for 2.6.7. Fixes #3367."
changeset,0000007187,[7187],johnjamesjacoby,"BuddyPress: prevent possible duplicate ""Topics"" & ""Replies"" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In trunk for 2.7.0. See #3367."
changeset,0000006229,[6229],johnjamesjacoby,"BuddyPress: Prevent reading/publishing if group member is banned.
Fixes #2905. Props thebrandonallen, r-a-y."
changeset,0000005906,[5906],johnjamesjacoby,BuddyPress: Remove `@todo`s that are todone or todon'ts.
changeset,0000006550,[6550],johnjamesjacoby,BuddyPress: Remove favs & subs from correct `bbp_get_request` action.
changeset,0000006982,[6982],johnjamesjacoby,"BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.6.2, branches/2.6."
changeset,0000006981,[6981],johnjamesjacoby,"BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.7, trunk."
changeset,0000006485,[6485],johnjamesjacoby,"BuddyPress: Root group forum updates
* Include ability to create a new group root forum if none exists
* Update group-forum setting verbiage to accommodate above
* When a forum is deleted, check if it's the group root, and delete the setting accordingly
* Introduce `bbp_maybe_delete_group_forum_root()` and `bbp_maybe_create_group_forum_root()` functions to carry out the above functionalities"
changeset,0000006391,[6391],johnjamesjacoby,"BuddyPress: Switch activity action back to `$this->component` and skip groups tests.
Proprs thebrandonallen. Fixes #3089."
changeset,0000006815,[6815],johnjamesjacoby,"BuddyPress: tweak notifications item IDs to provide a bit more context.
This change also fixes a bug with hierarchical reply notifications.
Props jpolakovic. Fixes #2834."
changeset,0000006262,[6262],johnjamesjacoby,"BuddyPress: Update `bbp_format_buddypress_notifications()` with new parameters.
* Prefer `$component_action_name` over less reliable `$content`
* Parameters match BuddyPress 2.6.0 and higher signature
* Mild function clean-up
Fixes #3036."
changeset,0000006368,[6368],johnjamesjacoby,BuddyPress: Update inline doc for group-forum filter. See #2974.
changeset,0000006804,[6804],johnjamesjacoby,"BuddyPress: updates to member profile URL filters:
* Introduce methods for known user profile pages
* Update public filter methods to use a private method
This change uses new intercept hooks to make sure bbPress profile URLs are turned into BuddyPress ones instead.
See #3814."
changeset,0000006845,[6845],johnjamesjacoby,"BuddyPress: use `$reply_id` instead of `$topic_id` so `bbp_get_reply_url()` works correctly.
This change ensures that notification links go directly to the reply, not the topic, and not a 404.
Fixes #3213. See #3214."
changeset,0000005822,[5822],johnjamesjacoby,BuddyPress: Use `bbp_get_paged_slug()` instead of `$wp_rewrite->pagination_base` directly.
changeset,0000005653,[5653],netweb,"BuddyPress: Use `bbp_is_favorites_active()` and `bbp_is_subscriptions_active()` respectively to check if bbPress' favorites and/or subscriptions are enabled before displaying menu items in BuddyPress member profiles.
Props tharsheblows. Fixes #2594
"
changeset,0000006285,[6285],johnjamesjacoby,"BuddyPress: Use correct hook type for `bp_modify_page_title` filter.
Props thebrandonallen. Fixes #3057."
changeset,0000006179,[6179],netweb,"Build Tools: `.jshintrc` is a JSON file, indentation should use spaces, not tabs, and lastly have `.editorconfig` treat `jshintrc` as a JSON file.
"
changeset,0000005995,[5995],netweb,"Build Tools: Add @stylelint for linting CSS to adhere to WordPress CSS Coding Standards
This changeset adds a new Grunt task `grunt postcss:lint` that runs stylelint on CSS & SCSS files to ensure bbPress' CSS adheres to WordPress CSS Coding Standards.
8 months in the making and is maintained by yours truly @netweb, with stylelint I'm learning JavaScript deeply.
See also:
* http://stylelint.io/
* https://github.com/stylelint/stylelint
* https://github.com/ntwb/stylelint-config-wordpress
* https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/
Hat-tip: David Clark and Richard Hallows for the ongoing help and support.
Props netweb.
Fixes #2924.
"
changeset,0000006840,[6840],netweb,"Build Tools: Add a `.npmrc` file, and move `node-sass` to `devDependencies`
The `.npmrc` file configures NPM to save exact versions
"
changeset,0000005994,[5994],netweb,"Build Tools: Add Autoprefixer for adding CSS vendor prefixes
This changeset adds a new Grunt task `grunt postcss:core` that runs Autoprefixer on CSS & SCSS files to add or remove any vendor prefixes required by browsers.
Browsers supported are the same as WordPress currently supports which are:
* Android >= 2.1
* Chrome >= 21
* Edge >= 12
* Explorer >= 7
* Firefox >= 17
* Opera >= 12.1
* Safari >= 6.0.
Vendor prefixes are are also added for `templates/default/css/bbpress.css` as this is the only file that requires them at this time.
Fixes #2923.
"
changeset,0000006655,[6655],netweb,"Build Tools: Add Composer packages to Travis CI cache
"
changeset,0000006651,[6651],netweb,"Build Tools: Add debug echo for `TRAVIS_PHP_VERSION`
"
changeset,0000005984,[5984],netweb,"Build Tools: Add minimum NodeJS 4.2.x LTS version
This changeset sets the minimum required NodeJS version supported. This is required as various NPM modules now require a minimum version greater than the default v0.10.x currently in use.
See #2920.
"
changeset,0000006494,[6494],netweb,"Build Tools: Add npm `package-lock.json` for npm v5.x
This changeset adds support for npm 5 which include significant performance improvements, these are primarily due updated caching, offline caching and the addition of a `package-lock.json` to leverage the new caching.
To install and use npm 5 with your existing install of Node.js 6 or 7 run `npm i npm@5 -g`. Node.js 8 support will be added in a follow up ticket.
Installing npm modules for bbPress is now ~6x faster with npm 5 🏎
Fixes #3113.
"
changeset,0000005996,[5996],netweb,"Build Tools: Add NPM package `postcss-scss` for styelelint SCSS compatibility
This changeset fixes an idiosyncratic NPM v3.x issue with ""flat"" folders and sharing dependencies that is not an issue when using NPM v2
See #2924
"
changeset,0000006132,[6132],netweb,"Build Tools: Add PHP 7.1 to the Travis CI job matrix and remove from `allow_failures` list
"
changeset,0000006073,[6073],netweb,"Build Tools: Add PHP 7.1 to Travis CI and ""allow to fail""
This changeset adds explict PHP 7.1 for testing bbPress, see also #WP37625
See #2980.
"
changeset,0000006637,[6637],netweb,"Build Tools: Add PHP 7.2 to Travis CI.
Fixes #3136.
"
changeset,0000007006,[7006],netweb,"Build Tools: Add PHPCS with custom bbPress ruleset
- This changeset adds an initial bbPress PHPCS ruleset
- Future iteration of the rules in the ruleset can follow later
- To run the PHPCS check run `grunt phpcs
Fixes #3294.
"
changeset,0000007039,[7039],netweb,"Build Tools: Add project root `composer.json` file.
This commit adds the following Composer package developer dependencies:
• `phpcompatibility/phpcompatibility-wp`
• `wp-coding-standards/wpcs`
• `dealerdirect/phpcodesniffer-composer-installer`
This also adds two composer scripts:
• `composer lint` to ""lint"" the PHP files using PHPCS
• `composer format` to ""format"" the PHP files using PHPCBF
Props jrf.
See #3294.
"
changeset,0000006203,[6203],netweb,"Build Tools: Add Travis CI cache for installed apt packages.
See #2980.
"
changeset,0000005961,[5961],netweb,"Build Tools: Add WordPress 4.4 to the Travis CI build matrix
"
changeset,0000006003,[6003],netweb,"Build Tools: Add WordPress 4.5 to Travis CI build matrix
"
changeset,0000006081,[6081],netweb,"Build Tools: Add WordPress 4.6 to Travis CI build matrix
"
changeset,0000006131,[6131],netweb,"Build Tools: Add WordPress 4.7 to Travis CI build matrix
"
changeset,0000006462,[6462],netweb,"Build Tools: Build Tools: Update `grunt-contrib-clean` from 1.0.0 to 1.1.0
* https://github.com/gruntjs/grunt-contrib-clean/compare/v1.0.0...v1.1.0
This changeset reverts the incorrect change in [6461] to `grunt-contrib-copy` instead of `grunt-contrib-clean`
Antiprops netweb.
"
changeset,0000006548,[6548],netweb,"Build Tools: Bump slow tests threshold for multisite to 250 for now, and we can continue to bring this value down as test performance is improved.
"
changeset,0000006962,[6962],netweb,"Build Tools: Cache `node_modules` folder in Travis CI
Fixes #2885.
"
changeset,0000006652,[6652],netweb,"Build Tools: Check for existence `xdebug.ini` using `phpenv` for Travis CI
"
changeset,0000005985,[5985],netweb,"Build Tools: Define TRAVIS_NODE_VERSION as a global variable for Travis CI
See #2920
"
changeset,0000006946,[6946],netweb,"Build Tools: Disable PHPUnit Speed Tester
"
changeset,0000006376,[6376],netweb,"Build tools: Don't attempt to report PHP's extensions when running HHVM jobs on Travis. It doesn't work.
Props johnbillion.
See #3085.
"
changeset,0000006656,[6656],netweb,"Build Tools: Exclude Travis CI PHP 7.2 builds for WP 4.7 & 4.8, PHP 7.2 compat will WP 4.9.
"
changeset,0000006076,[6076],netweb,"Build Tools: Fix `BBP_UnitTestCase::go_to()` for `WP_Network`.
This changeset is via buddypress:changeset:10125
Props boonebgorges.
Fixes #2981
"
changeset,0000006654,[6654],netweb,"Build Tools: Fix copy pasta added in [6652]
"
changeset,0000006404,[6404],netweb,"Build Tools: Fix copy pasta of `;` instead of `,` added in [6403].
WordPress Coding Standards requires one variable declaration.
See #2924.
"
changeset,0000007050,[7050],netweb,"Build Tools: Improve PHPCS setup.
Props jrf.
See #3294.
For trunk.
"
changeset,0000005619,[5619],netweb,"Build Tools: Include PHP-7 ""nightly"" builds with failures allowed in Travis-CI"
changeset,0000005986,[5986],netweb,"Build Tools: Install NodeJS 4.x.x using NVM in Travis CI
See #2920
"
changeset,0000006075,[6075],netweb,"Build Tools: More targeted cleanup for multisite unit tests.
This changeset is a subset of buddypress:changeset:9980 and removes a previous heavy-handed workaround for deleting the first multisite user. This also resolves a fatal error `Object does not implement ArrayAccess` when running the tests on HHVM.
See #2962, #2981
"
changeset,0000006625,[6625],netweb,"Build Tools: Move PHP 5.2 and 5.3 Travis CI jobs from the `php` section to the `matrix` section.
This changeset is a follow up to [6624] where the ""build matrix"" was broken, my bad.
See #3127.
"
changeset,0000006267,[6267],netweb,"Build Tools: NPM modules in `package.json` should only use semantic versioning `~` ''minor'' versions, rather than `^` ''major'' versions.
This changeset will help avoid the pitfalls of upstream NPM modules breaking our build due to a release of a new major version for which bbPress has not yet tested against.
"
changeset,0000006405,[6405],netweb,"Build Tools: Remove HHVM from the test infrastructure on Travis.
Fixes #3104.
"
changeset,0000006201,[6201],netweb,"Build Tools: Remove unsupported WordPress versions from Travis CI build job matrix.
This changeset removes all WordPress versions previous to 4.7 as this is now bbPress' minimum required version.
"
changeset,0000005983,[5983],netweb,"Build Tools: Renamed `grunt-rtlcss` option `options.config` to RTLCSS v2.x `options.opts` option
See #2918
"
changeset,0000006799,[6799],netweb,"Build Tools: Replace Browserslist configuration in `Gruntfile.js` with `@wordpress/browserslist-config`
This change simplifies bbPress' Browserslist configuration maintainence by depending on WordPress' shared Browserslist configuration package:
* https://github.com/WordPress/packages/tree/master/packages/browserslist-config
* https://github.com/WordPress/packages/
"
changeset,0000006000,[6000],netweb,"Build Tools: Revert [5999] `grunt-legacy-util` update, from 0.2.0 to 1.0.0
This changeset reverts the above change as I missed the `1.0.0` recommended [https://github.com/gruntjs/grunt-legacy-util/blob/master/README.md change] to use `require('child_process').spawn` over `grunt.util.spawn`. Per NodeJS docs [https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options here] and [https://nodejs.org/dist/latest-v4.x/docs/api/child_process.html#child_process_child_process_spawn_command_args_options here] for NodeJS versions 5.x and 4.x respectively this needs some more testing and changes to the Grunt phpunit task and multi task.
Another option per [https://github.com/gruntjs/grunt-legacy-util/issues/10 grunt-legacy-util #10] is to switch to [https://www.npmjs.com/package/cross-spawn-async cross-spawn-async]
Both above options will require *nix and Windows testing.
''6000 is the natural number following 5999 and preceding 6001.''
See #2918
"
changeset,0000005987,[5987],netweb,"Build Tools: Revert Travis CI TRAVIS_NODE_VERSION environment variable changes from r5984/r5985, installing NodeJS 4.x.x via NVM is sufficient per r5986.
Fixes #2920.
"
changeset,0000006653,[6653],netweb,"Build Tools: Run Travis-CI unit tests against WordPress 4.8.
"
changeset,0000006748,[6748],netweb,"Build Tools: Run Travis-CI unit tests on WordPress 4.9.
"
changeset,0000006025,[6025],netweb,"Build Tools: Set a whitelist for PHPUnit code coverage
This chageset adds a PHPUnit whitelist of files for use with code coverage tests analsyis tools.
Hat tip jorbin.
Fixes #2953.
"
changeset,0000006100,[6100],netweb,"Build Tools: Switch stylelint Grunt task from `grunt postcss:lint` to `grunt stylelint`
This changeset switches the stylelint task from using the `grunt-postcss` to `grunt-stylelint` NPM module. This new Grunt module supports stylelint's native formatters and allows for improved task error reporting. This change also splits the CSS and SCSS lint tasks in preparation for a future `stylelint-config-wordpress` SCSS update.
See also: https://github.com/wikimedia/grunt-stylelint
Props netweb.
See #2924.
"
changeset,0000006624,[6624],netweb,"Build Tools: Switch to Ubuntu Trusty as the the default linux distro for Travis CI.
* This changeset also explicitly adds `dist: precise` to the PHP 5.2 and 5.3 build jobs.
* Travis CI will discontinue support of PHP 5.2 & 5.3 in September 2017 and a further follow up will be required.
Fixes #3127.
"
changeset,0000006145,[6145],netweb,"Build Tools: Travis CI: Only test PHP 7.1 against WordPress 4.7 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7.1 compatability, which was only added in version 4.7.
"
changeset,0000006466,[6466],netweb,"Build Tools: Update `autoprefixer` from 6.7.1 to 7.1.1
• https://github.com/postcss/autoprefixer/compare/6.7.1...7.1.1
"
changeset,0000006104,[6104],netweb,"Build Tools: Update `autoprefixer` to v6.5.1
See https://github.com/postcss/autoprefixer/compare/6.3.3...6.5.1
"
changeset,0000005979,[5979],netweb,"Build Tools: Update `grunt-check-dependencies` from `0.11.2` to `0.12.0`
See #2918
"
changeset,0000006103,[6103],netweb,"Build Tools: Update `grunt-check-dependencies` to v1.0.0
See https://github.com/mgol/grunt-check-dependencies/compare/0.12.0...1.0.0
"
changeset,0000006461,[6461],netweb,"Build Tools: Update `grunt-contrib-copy` from 1.0.0 to 1.1.0
* https://github.com/gruntjs/grunt-contrib-clean/compare/v1.0.0...v1.1.0
"
changeset,0000005975,[5975],netweb,"Build Tools: Update `grunt-contrib-copy` from `0.8.0` to `1.0.0`
See #2918
"
changeset,0000005976,[5976],netweb,"Build Tools: Update `grunt-contrib-copy` from `0.8.0` to `1.0.0`
This changeset fixes the ""my bad"" r5975 commit where the version was accidentally committed as `0.1.0` instead of `1.0.0`
See #2918
"
changeset,0000006468,[6468],netweb,"Build Tools: Update `grunt-contrib-cssmin` from 1.0.0 to 2.2.0
* See https://github.com/gruntjs/grunt-contrib-cssmin/compare/v1.0.0...v2.2.0
* Updates `clean-css` to v4.1.1
"
changeset,0000005973,[5973],netweb,"Build Tools: Update `grunt-contrib-cssmin` from `0.13.0` to `1.0.0`
See #2918
"
changeset,0000005974,[5974],netweb,"Build Tools: Update `grunt-contrib-cssmin` from `0.6.0` to `1.0.0`
See #2918
"
changeset,0000005977,[5977],netweb,"Build Tools: Update `grunt-contrib-jshint` from `0.11.2` to `1.0.0`
See #2918
"
changeset,0000006238,[6238],netweb,"Build Tools: Update `grunt-contrib-jshint` from v1.0.0 to v1.1.0
* See https://github.com/gruntjs/grunt-contrib-jshint/compare/v1.0.0...v1.1.0
"
changeset,0000006467,[6467],netweb,"Build Tools: Update `grunt-contrib-uglify` from 2.0.0 to 3.0.1
* See https://github.com/gruntjs/grunt-contrib-uglify/compare/v2.0.0...v3.0.1
* Bumps `uglify-js` to 3.0.4
"
changeset,0000005978,[5978],netweb,"Build Tools: Update `grunt-contrib-uglify` from `0.9.2` to `1.0.0`
See #2918
"
changeset,0000005927,[5927],netweb,"Build Tools: Update `grunt-contrib-uglify` to `v0.9.2`
This changeset includes an update to the parent dependency UglifyJS v2.4.24 which fixes a bug that can cause logic bugs to be introduced into minified JS.
Hat-tip pento. Fixes #2856.
"
changeset,0000006117,[6117],netweb,"Build Tools: Update `grunt-contrib-uglify`.
Update uglify-js to v2.7.0. `screwIE8` is enabled by default.
See https://github.com/gruntjs/grunt-contrib-uglify/compare/v1.0.2...v2.0.0
"
changeset,0000006464,[6464],netweb,"Build Tools: Update `grunt-exec` from 1.0.1 to 2.0.0
* See https://github.com/jharding/grunt-exec/compare/v1.0.1...e1ef5d9
"
changeset,0000005999,[5999],netweb,"Build Tools: Update `grunt-legacy-util` from 0.2.0 to 1.0.0
See also: https://github.com/gruntjs/grunt-legacy-util/compare/v0.2.0...v1.0.0
See #2918
"
changeset,0000006049,[6049],netweb,"Build Tools: Update `grunt-patch-wordpress` to 0.4.0
This update adds two main features for your WordPress development happiness.
1) GitHub URL support. You can now use `grunt patch:https://github.com/bbpress/bbPress/pull/3` with any copy of bbPress on GitHub. No longer will you need to download the patch manually.
2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. `grunt upload_patch:20000` will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug committers). You still need to manually add the `has patch` keyword.
Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.3.0...0.4.0
Props jorbin, ericlewis, michaelbeil, netweb
"
changeset,0000005982,[5982],netweb,"Build Tools: Update `grunt-rtlcss` from `1.6.0` to `2.0.1`
Fixes #2918
"
changeset,0000005981,[5981],netweb,"Build Tools: Update `grunt-sass` from `1.0.0` to `1.1.0`
See #2918
"
changeset,0000006239,[6239],netweb,"Build Tools: Update `grunt-sass` from v1.2.0 to v2.0.0
* See https://github.com/sindresorhus/grunt-sass/compare/v1.2.0...v2.0.0
* Bumps `node-sass` from v3.7.0 to v4.0.0
* See https://github.com/sass/node-sass/compare/v3.7.0...v4.0.0
"
changeset,0000006029,[6029],netweb,"Build Tools: Update `grunt-sass` to v1.2.0 with `node-sass` > v3.7.x support
See https://github.com/sindresorhus/grunt-sass/compare/v1.1.0...v1.2.0
"
changeset,0000006465,[6465],netweb,"Build Tools: Update `grunt-stylelint` from 0.7.0 to 0.8.0
• See https://github.com/wikimedia/grunt-stylelint/compare/v0.7.0...v0.8.0
"
changeset,0000006469,[6469],netweb,"Build Tools: Update `grunt-wp-i18n` from 0.5.4 to 1.0.0
* See https://github.com/cedaro/grunt-wp-i18n/compare/v0.5.4...v1.0.0
"
changeset,0000005980,[5980],netweb,"Build Tools: Update `matchdep` from `0.3.0` to `1.0.1`
See #2918
"
changeset,0000006626,[6626],netweb,"Build Tools: Update `package.json` dependencies and `package-lock.json`
This changeset primarily updates the `package-lock.json` file to support the latest npm 5.1 and 5.2 releases.
• The format of the `package-lock.json` changed slightly with npm 5.1 to better support `devDependencies` dependencies.
• Explicitly update all dependencies to the latest available version.
• Updates `postcss-scss` to use semantic version _patch_ `~` in line with the other npm modules used.
See #3113.
"
changeset,0000006470,[6470],netweb,"Build Tools: Update `package.json` to define a minimum Node.js version `6.9.1`
This changeset updates the recommended Node.js version to the latest 6.x.x Node.js LTS version. The Node.js 4.x.x LTS branch is now in maintenance mode and brings bbPress' build tool version requirements in line with WordPress' and the broader WordPress plugin community.
"
changeset,0000006463,[6463],netweb,"Build Tools: Update `postcss-scss` from 0.4.0 to 1.0.0
* See https://github.com/postcss/postcss-scss/compare/0.4.0...1.0.0
"
changeset,0000006035,[6035],netweb,"Build Tools: Update `stylelint` to v6.5.1 and bump `.stylelintrc` to `stylelint-config-wordpress` v7.1.1
See #2924
"
changeset,0000007038,[7038],netweb,"Build Tools: Update `svn:ignore` and `.gitignore`
Props jrf.
See #3294.
"
changeset,0000007045,[7045],netweb,"Build Tools: Update `svn:ignore` and `.gitignore`
• This commit is a follow up to [7038] to also ignore `.phpcs.xml`
Props jrf.
See #3294.
"
changeset,0000006798,[6798],netweb,"Build Tools: Update autoprefixer from 7.1.2 to 8.2.0
• https://github.com/postcss/autoprefixer/compare/7.1.2...8.2.0
"
changeset,0000006577,[6577],netweb,"Build Tools: Update Autoprefixer supported browser matrix.
Following WordPress' implementation this new version hard codes IE 11 as a minimum, otherwise specifies either last 2 or last 1 based on https://make.wordpress.org/design/handbook/design-guide/browser-support/
"
changeset,0000006222,[6222],netweb,"Build Tools: Update Grunt and companion packages to the latest version.
This changeset updates `grunt`, `grunt-exec`, and `grunt-legacy-utils` to the latest version.
Run `npm install` in your terminal to install the updates above.
"
changeset,0000005992,[5992],netweb,"Build Tools: Update grunt-contrib-watch from 0.6.1 to 1.0.0
See #2918
"
changeset,0000007107,[7107],netweb,"Build Tools: Update Node.js and npm required versions
"
changeset,0000007106,[7106],netweb,"Build Tools: Update PHPCS
"
changeset,0000006236,[6236],netweb,"Build Tools: Update PostCSS Autoprefixer from v6.5.1 to v6.6.1
* See https://github.com/postcss/autoprefixer/compare/6.5.1...6.6.1
"
changeset,0000006268,[6268],netweb,"Build Tools: Update PostCSS Autoprefixer from v6.6.1 to v6.7.0
"
changeset,0000006237,[6237],netweb,"Build Tools: Update PostCSS SCSS from v0.3.0 to v0.4.0
* See https://github.com/postcss/postcss-scss/compare/0.3.0...0.4.0
"
changeset,0000006945,[6945],netweb,"Build Tools: Update SASS Node.js modules
"
changeset,0000007041,[7041],netweb,"Build Tools: Update SPDX License in `composer.json` to adhere to SPDX v3.0 specification.
"
changeset,0000007040,[7040],netweb,"Build Tools: Update SPDX License in `composer.json` to adhere to SPDX v3.0 specification.
"
changeset,0000006764,[6764],netweb,"Build Tools: Update SPDX License in `package.json` to adhere to SPDX v3.0 specification.
See also:
• https://spdx.org/news/news/2018/01/license-list-30-released
• https://spdx.org/licenses/
• WordPress Ticket #WP43032
"
changeset,0000005998,[5998],netweb,"Build Tools: Update styelelint to `5.3.0`
See #2924
"
changeset,0000006403,[6403],netweb,"Build Tools: Update stylelint
* Update `stylelint` to v7.10.1
* Update `grunt-stylelint` to v0.7.0
* Switch from `.stylelintrc` format to stylelint shared config `stylelint-config-wordpress`
* Add SCSS linting support that's now included in `stylelint-config-wordpress`
See #2924.
"
changeset,0000006028,[6028],netweb,"Build Tools: Update stylelint to 6.4.2
See #2924
"
changeset,0000006408,[6408],netweb,"Build Tools: Update stylelint to `11.0.0` and use unitless values for `line-height`
This changeset updates stylelint to the latest version and removes `%` and `em` from `line-height` values per the WordPress CSS coding standards.
Fixes #3106.
"
changeset,0000006093,[6093],netweb,"Build Tools: Update stylelint to v7.2.0 and bump `.stylelintrc` to `stylelint-config-wordpress` v9.0.0
"
changeset,0000006266,[6266],netweb,"Build Tools: Update stylelint to v7.7.1 and `.stylelintrc` to stylelint-config-wordpress v9.1.1
"
changeset,0000006731,[6731],netweb,"Build Tools: Update the Grunt `commit` task to run Autoprefixer
This changeset ensures that browser vendor prefixes are updated and included when committing SCSS and CSS changes in the `src/` folder.
"
changeset,0000007044,[7044],netweb,"Build Tools: Update Travis CI config.
• Drop `apt: true` key
• Drop PHP 5.3 & 5.4 jobs
• Add PHP 7.3 & 7.4 jobs
• Drop WordPress 4.7, 4.8, & 4.9
• Add WordPress 5.2 & 5.3
• Ensure MySQL is available
• Exclude WP 5.2 from PHP 7.4 jobs
• Remove #bbpress-dev IRC notifications
• Remove deprecated `sudu: false` key
• Run BuddyPress Tests on all jobs
• Simplify PHPUnit Travis Grunt task
• Swap `dist: trusty` key to `os: linux` key
For branches/2.6.
"
changeset,0000007043,[7043],netweb,"Build Tools: Update Travis CI config.
• Drop `apt: true` key
• Drop PHP 5.3 & 5.4 jobs
• Add PHP 7.3 & 7.4 jobs
• Drop WordPress 4.7, 4.8, & 4.9
• Add WordPress 5.2 & 5.3
• Ensure MySQL is available
• Exclude WP 5.2 from PHP 7.4 jobs
• Remove #bbpress-dev IRC notifications
• Remove deprecated `sudu: false` key
• Run BuddyPress Tests on all jobs
• Simplify PHPUnit Travis Grunt task
• Swap `dist: trusty` key to `os: linux` key
For trunk.
"
changeset,0000006074,[6074],netweb,"Build Tools: Upgrade to the latest HHVM version with Travis CI using Ubuntu Trusty
Fixes #2980.
"
changeset,0000006947,[6947],netweb,"Build Tools: Use Node.js 8.x
"
changeset,0000006657,[6657],netweb,"Build Tools: Use PHPUnit 6.x branch for Travis CI PHP 7.x jobs
"
changeset,0000006797,[6797],netweb,"Build Tools: Use tabs for indentaion, follow up to [*6796]
See #3197.
"
changeset,0000006375,[6375],netweb,"Build/Test Tools: Fix YAML indentation in `.travis.yml` following yolo'd [6373].
See #3085.
"
changeset,0000006374,[6374],netweb,"Build/Test Tools: Revert unintended unit test change included in commit [6373]
Antiprops netweb.
See #3085, #2963.
"
changeset,0000006373,[6373],netweb,"Build/Test Tools: Update `.travis.yml` to explicitly use PHPUnit 5.7 for the PHP 7 builds on Travis.
* Add some more debugging to Travis.
* Clean up indentation.
Fixes #3085.
"
changeset,0000007200,[7200],johnjamesjacoby,"Build: bump npm dependencies.
"
changeset,0000007199,[7199],johnjamesjacoby,"Build: bump npm dependencies.
"
changeset,0000006831,[6831],johnjamesjacoby,Build: update various out-of-date packages.
changeset,0000007062,[7062],johnjamesjacoby,"Bump /src/bbpress.php plugin header to 2.6.4.
"
changeset,0000003517,[3517],johnjamesjacoby,Bump 0.9 branch version to 0.9.0.7.
changeset,0000003520,[3520],johnjamesjacoby,Bump 1.0 branch version to 1.0.4.
changeset,0000004147,[4147],johnjamesjacoby,Bump 2.1 branch
changeset,0000004110,[4110],johnjamesjacoby,Bump 2.1 branch to 2.1.1.
changeset,0000004378,[4378],johnjamesjacoby,Bump 2.1 branch to 2.1.3.
changeset,0000004131,[4131],johnjamesjacoby,Bump 2.1 branch version to 2.1.2.
changeset,0000004471,[4471],johnjamesjacoby,Bump 2.2 branch to 2.2.2.
changeset,0000004567,[4567],johnjamesjacoby,Bump 2.2 branch to 2.2.3.
changeset,0000004711,[4711],johnjamesjacoby,Bump 2.2 branch version to 2.2.4. Includes readme.txt changes.
changeset,0000004868,[4868],johnjamesjacoby,Bump 2.3 branch to 2.3.1.
changeset,0000004891,[4891],johnjamesjacoby,Bump 2.3 branch to 2.3.2.
changeset,0000004893,[4893],johnjamesjacoby,Bump 2.3 branch to 2.3.3-alpha.
changeset,0000004855,[4855],johnjamesjacoby,Bump 2.3 branch version to 2.3.1-bleeding.
changeset,0000005127,[5127],johnjamesjacoby,Bump 2.4 branch version to 2.4.1. Also add 2.4.1 section to readme.txt.
changeset,0000005217,[5217],johnjamesjacoby,Bump 2.5 branch to 2.5.1.
changeset,0000006122,[6122],johnjamesjacoby,"Bump 2.5 branch to 2.5.11.
Also add changelog to readme.txt.
"
changeset,0000006411,[6411],johnjamesjacoby,"Bump 2.5 branch to 2.5.13.
"
changeset,0000006686,[6686],johnjamesjacoby,Bump 2.5 branch to 2.5.14.
changeset,0000005234,[5234],johnjamesjacoby,Bump 2.5 branch to 2.5.2.
changeset,0000005249,[5249],johnjamesjacoby,"Bump 2.5 branch to 2.5.3, and update `readme.txt`."
changeset,0000005380,[5380],johnjamesjacoby,Bump 2.5 branch to 2.5.4.
changeset,0000005631,[5631],johnjamesjacoby,"Bump 2.5 branch to 2.5.5.
"
changeset,0000005694,[5694],johnjamesjacoby,Bump 2.5 branch to 2.5.7
changeset,0000005816,[5816],netweb,Bump 2.5 branch to 2.5.8.
changeset,0000006018,[6018],johnjamesjacoby,"Bump 2.5 branch to 2.5.9.
"
changeset,0000005644,[5644],johnjamesjacoby,"Bump 2.5 branch version to `2.5.6`. Include `2.5.6` changelog entry in `readme.txt`.
"
changeset,0000006943,[6943],johnjamesjacoby,"Bump 2.6 branch to 2.6.1.
"
changeset,0000006995,[6995],johnjamesjacoby,"Bump 2.6 branch to 2.6.3-alpha.
"
changeset,0000007022,[7022],johnjamesjacoby,"Bump 2.6 branch to 2.6.4-alpha-1.
"
changeset,0000007061,[7061],johnjamesjacoby,"Bump 2.6 branch to 2.6.4.
"
changeset,0000007064,[7064],johnjamesjacoby,"Bump 2.6 branch to 2.6.5-alpha-1.
"
changeset,0000007094,[7094],johnjamesjacoby,"Bump 2.6 branch to 2.6.6-alpha-1.
Includes readme.txt updates merged from trunk in r7093.
"
changeset,0000007161,[7161],johnjamesjacoby,Bump 2.6 branch to 2.6.6.
changeset,0000007090,[7090],johnjamesjacoby,"Bump 2.6 branch versions to 2.6.5.
"
changeset,0000006065,[6065],johnjamesjacoby,Bump `bbpress.pot` in 2.5 branch.
changeset,0000005567,[5567],johnjamesjacoby,Bump alpha version in bbpress.php to latest revision.
changeset,0000006092,[6092],netweb,"Bump alpha version in bbpress.php to latest revision.
"
changeset,0000003319,[3319],johnjamesjacoby,Bump bbp-twentyten version to 1.2.
changeset,0000003320,[3320],johnjamesjacoby,Bump bbPress 2.0 version to Beta 3.
changeset,0000006064,[6064],johnjamesjacoby,Bump bbPress 2.5 branch version to 2.5.10.
changeset,0000004829,[4829],johnjamesjacoby,"Bump bbpress.pot to match RC1, since our potbot has gone rogue again."
changeset,0000005200,[5200],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005095,[5095],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005074,[5074],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005067,[5067],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005052,[5052],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005046,[5046],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005041,[5041],johnjamesjacoby,Bump bbpress.pot.
changeset,0000005028,[5028],johnjamesjacoby,Bump bbpress.pot.
changeset,0000004841,[4841],johnjamesjacoby,Bump bbpress.pot.
changeset,0000004812,[4812],johnjamesjacoby,Bump bbpress.pot.
changeset,0000004796,[4796],johnjamesjacoby,Bump bbpress.pot.
changeset,0000003603,[3603],johnjamesjacoby,Bump branch to 2.0.1. Update readme.txt and remove hard-coded version reference from bbp-extend-akismet.php.
changeset,0000003641,[3641],johnjamesjacoby,Bump branch to 2.0.2.
changeset,0000003957,[3957],johnjamesjacoby,Bump branch to 2.0.3.
changeset,0000004455,[4455],johnjamesjacoby,Bump branch to 2.2.1.
changeset,0000007222,[7222],johnjamesjacoby,"Bump branches/2.6 to 2.6.8.
"
changeset,0000007225,[7225],johnjamesjacoby,"Bump build packages.
"
changeset,0000003764,[3764],johnjamesjacoby,Bump default db_version and add functions to get DB version raw from the database.
changeset,0000006911,[6911],johnjamesjacoby,"Bump dev dependencies.
"
changeset,0000006938,[6938],johnjamesjacoby,"Bump everything, including the version (to 2.6.0!)
"
changeset,0000005991,[5991],netweb,"Bump minimum WordPress requirement to 4.0.
Fixes #2902.
"
changeset,0000002842,[2842],johnjamesjacoby,Bump new reply avatar size up to match new topic avatar size.
changeset,0000005328,[5328],netweb,"Bump NPM package versions in `package.json`
""grunt-contrib-cssmin"": ""~0.7.0"" -> ""~0.9.0"" http://npmjs.org/package/grunt-contrib-cssmin
""grunt-contrib-uglify"": ""~0.3.0"" -> ""~0.4.0"" http://npmjs.org/package/grunt-contrib-uglify
""grunt-contrib-watch"": ""~0.5.3"" -> ""~0.6.1"" http://npmjs.org/package/grunt-contrib-watch
""grunt-contrib-jshint"": ""~0.8.0"" -> ""~0.9.2"" http://npmjs.org/package/grunt-contrib-jshint
""grunt-sass"": ""~0.10.0"" -> ""~0.12.0"" http://npmjs.org/package/grunt-sass
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542"
changeset,0000005339,[5339],netweb,"Bump NPM package versions in `package.json`
""grunt-contrib-jshint"": ""~0.9.2 -> ""~0.10.0"" http://npmjs.org/package/grunt-contrib-jshint
""grunt-sass"": ""~0.12.0"" -> ""~0.12.1"" http://npmjs.org/package/grunt-sass
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542"
changeset,0000005451,[5451],netweb,"Bump NPM package versions in `package.json`
* ""grunt-contrib-clean"": ""~0.5.0 -> ""~0.6.0""
* Requires `npm install` to update packages and dependencies
"
changeset,0000005448,[5448],netweb,"Bump NPM package versions in `package.json`
* ""grunt-contrib-uglify"": ""~0.5.0 -> ""~0.5.1""
* ""grunt-exec"": ""~0.4.5"" -> ""~0.4.6""
* ""grunt-wp-i18n"": ""~0.4.5"" -> ""~0.4.6""
* Requires `npm install` to update packages and dependencies
"
changeset,0000005463,[5463],netweb,"Bump NPM package versions in `package.json`
* ""grunt-sass"": ""~0.14.0 -> ""~0.14.1""
* ""grunt-wp-i18n"": ""~0.4.7 -> ""~0.4.8""
* Requires `npm install` to update packages and dependencies
"
changeset,0000005455,[5455],netweb,"Bump NPM package versions in `package.json`
* ""grunt-wp-i18n"": ""~0.4.6 -> ""~0.4.7""
* Requires `npm install` to update packages and dependencies
"
changeset,0000005296,[5296],netweb,"Bump NPM package versions in `package.json`
* `grunt-contrib-cssmin` to v0.8.0 https://www.npmjs.org/package/grunt-contrib-cssmin
* `grunt-sass` to v~0.11.0 https://www.npmjs.org/package/grunt-sass
* `grunt-phpunit` to v0.3.3 https://www.npmjs.org/package/grunt-phpunit
* `grunt-exec` to v0.4.5 https://www.npmjs.org/package/grunt-exec
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542"
changeset,0000005327,[5327],netweb,"Bump NPM package versions in `package.json`
* `grunt-wp-i18n` to v0.4.3 https://www.npmjs.org/package/grunt-wp-i18n
* Fixes numerous PHP error notices
* Add's support for custom headers in bbpress.pot
* ['report-msgid-bugs-to'] = 'https://bbpress.trac.wordpress.org';;
* ['last-translator'] = 'JOHN JAMES JACOBY ';
* ['language-team'] = 'ENGLISH ';
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542"
changeset,0000005532,[5532],netweb,"Bump NPM package versions in package.json
""grunt-contrib-copy"": ""~0.5.0"" -> ""~0.6.0""
""grunt-contrib-uglify"": ""~0.5.1"" -> ""~0.6.0""
Requires npm install to update packages and dependencies"
changeset,0000005555,[5555],netweb,"Bump NPM package versions in package.json
""grunt-contrib-copy"": ""~0.6.0"" -> ""~0.7.0""
""grunt-sass"": ""~0.14.1"" -> ""~0.16.0""
""grunt-wp-i18n"": ""~0.4.8"" -> ""~0.4.9""
Requires npm install to update packages and dependencies"
changeset,0000005556,[5556],netweb,"Bump NPM package versions in package.json
""grunt-sass"": ""~0.16.0"" -> ""~0.16.1""
Requires npm install to update packages and dependencies"
changeset,0000007103,[7103],johnjamesjacoby,"Bump out-of-date dependencies.
"
changeset,0000007035,[7035],johnjamesjacoby,"Bump package version.
"
changeset,0000006994,[6994],johnjamesjacoby,"Bump packages.
"
changeset,0000004013,[4013],johnjamesjacoby,Bump plugin branch to release candidate 1.
changeset,0000003546,[3546],johnjamesjacoby,Bump plugin branch version to 2.1-bleeding.
changeset,0000003536,[3536],johnjamesjacoby,Bump plugin version to 2.0
changeset,0000003989,[3989],johnjamesjacoby,Bump plugin version to 2.1-beta-1. Update readme.txt.
changeset,0000005179,[5179],johnjamesjacoby,"Bump priority from 1 to 2, to give some wiggle room for third party developers. See #2291."
changeset,0000003244,[3244],johnjamesjacoby,Bump readme.txt and add Beta 2 to changelog.
changeset,0000004828,[4828],johnjamesjacoby,Bump readme.txt and add missing revision to bbPress class.
changeset,0000004870,[4870],johnjamesjacoby,Bump readme.txt and version in trunk.
changeset,0000004113,[4113],johnjamesjacoby,Bump readme.txt in 2.2 branch.
changeset,0000005097,[5097],johnjamesjacoby,Bump readme.txt stable tag and version.
changeset,0000005228,[5228],netweb,Bump readme.txt Tested version. Fixes #2490
changeset,0000005229,[5229],netweb,Bump readme.txt Tested version. Fixes #2490 (2.5 branch)
changeset,0000003510,[3510],johnjamesjacoby,Bump readme.txt to 2.0 RC 5 and add 2.0-rc-5 section.
changeset,0000006688,[6688],johnjamesjacoby,"Bump readme.txt versions and changelog.
"
changeset,0000005381,[5381],johnjamesjacoby,Bump remaining 2.5.3 references in 2.5 branch.
changeset,0000003406,[3406],johnjamesjacoby,Bump script versions in bbp-twentyten.
changeset,0000005379,[5379],johnjamesjacoby,Bump stable tag and add 2.5.4 section to `readme.txt` (trunk)
changeset,0000006017,[6017],johnjamesjacoby,"Bump stable tag in `trunk` to 2.5.9.
"
changeset,0000007065,[7065],johnjamesjacoby,"Bump stable tag in trunk 2.6.4, and also update an node dependency.
"
changeset,0000004894,[4894],johnjamesjacoby,Bump stable tag to 2.3.2 and add 2.3.2 to changelog.
changeset,0000006067,[6067],johnjamesjacoby,Bump stable tag to 2.5.10.
changeset,0000007163,[7163],johnjamesjacoby,"Bump stable tag to 2.6.6 in trunk.
"
changeset,0000007224,[7224],johnjamesjacoby,"Bump stable tag to 2.6.8.
"
changeset,0000005201,[5201],johnjamesjacoby,Bump stable tag.
changeset,0000005341,[5341],johnjamesjacoby,Bump tested-up-to version to 3.9. (2.5 branch)
changeset,0000005340,[5340],johnjamesjacoby,Bump tested-up-to version to 3.9. (trunk)
changeset,0000005461,[5461],netweb,Bump tested-up-to version to 4.0. (2.5 branch)
changeset,0000005460,[5460],netweb,Bump tested-up-to version to 4.0. (trunk)
changeset,0000005830,[5830],netweb,Bump tested-up-to version to 4.2. (trunk)
changeset,0000005937,[5937],netweb,"Bump tested-up-to version to 4.3. (2.5 branch)
"
changeset,0000005936,[5936],netweb,"Bump tested-up-to version to 4.3. (trunk)
"
changeset,0000006595,[6595],johnjamesjacoby,"Bump the asset version to latest revision.
"
changeset,0000003404,[3404],johnjamesjacoby,Bump the bbpress.pot file to RC 2
changeset,0000003046,[3046],johnjamesjacoby,Bump the install DB version to 110
changeset,0000003271,[3271],johnjamesjacoby,"Bump the numberposts limit in bbp_reply_metabox to 250, but allow the args to be filtered so large forums have a way to adjust the query. Fixes #1512."
changeset,0000003509,[3509],johnjamesjacoby,Bump to 2.0 RC 5
changeset,0000003481,[3481],johnjamesjacoby,Bump to 2.0-rc-4.
changeset,0000004043,[4043],johnjamesjacoby,Bump to 2.1-rc4.
changeset,0000004751,[4751],johnjamesjacoby,Bump to 2.3 Beta 2.
changeset,0000005199,[5199],johnjamesjacoby,Bump to 2.5.
changeset,0000006148,[6148],johnjamesjacoby,Bump to 2.5.12.
changeset,0000006596,[6596],johnjamesjacoby,"Bump to 2.6 RC 4.
"
changeset,0000007217,[7217],johnjamesjacoby,"Bump to 2.6.7.
(Reorders to package.json to be a bit easier for humans to modify.)
"
changeset,0000007215,[7215],johnjamesjacoby,"Bump to 2.7.0-alpha-2.
"
changeset,0000004368,[4368],johnjamesjacoby,Bump to beta 2.
changeset,0000004392,[4392],johnjamesjacoby,Bump to RC 1.
changeset,0000003403,[3403],johnjamesjacoby,Bump to RC2
changeset,0000004420,[4420],johnjamesjacoby,Bump to RC2.
changeset,0000004713,[4713],johnjamesjacoby,Bump trunk stable tag in readme.txt and add 2.2.4 changes. Bump DB version to match 2.2.4.
changeset,0000004439,[4439],johnjamesjacoby,Bump trunk to 2.2.
changeset,0000004811,[4811],johnjamesjacoby,Bump trunk to 2.3 RC 1.
changeset,0000004732,[4732],johnjamesjacoby,Bump trunk to 2.3-beta1.
changeset,0000004849,[4849],johnjamesjacoby,Bump trunk to 2.3.
changeset,0000004852,[4852],johnjamesjacoby,Bump trunk to 2.4-bleeding.
changeset,0000005096,[5096],johnjamesjacoby,Bump trunk to 2.4.
changeset,0000005100,[5100],johnjamesjacoby,Bump trunk to 2.5-alpha.
changeset,0000006213,[6213],johnjamesjacoby,Bump trunk to 2.6 Beta 1.
changeset,0000006509,[6509],johnjamesjacoby,"Bump trunk to 2.6 Release Candidate 1! 🐝
"
changeset,0000006535,[6535],johnjamesjacoby,Bump trunk to 2.6 Release Candidate 3.
changeset,0000005214,[5214],johnjamesjacoby,Bump trunk to 2.6-alpha.
changeset,0000006878,[6878],johnjamesjacoby,"Bump trunk to 2.6-rc7.
"
changeset,0000006339,[6339],johnjamesjacoby,Bump trunk to 2.6.0 beta 3
changeset,0000006699,[6699],johnjamesjacoby,Bump trunk to 2.6.0 RC 5.
changeset,0000006944,[6944],johnjamesjacoby,"Bump trunk to 2.7.0-alpha-1.
"
changeset,0000005025,[5025],johnjamesjacoby,"Bump trunk to bbPress 2.4 beta 1.
"
changeset,0000005068,[5068],johnjamesjacoby,Bump trunk to RC1.
changeset,0000004457,[4457],johnjamesjacoby,Bump trunk.
changeset,0000003527,[3527],johnjamesjacoby,Bump version in trunk to 1.1 until 1.2 clean-up begins.
changeset,0000003774,[3774],johnjamesjacoby,Bump version number to current revision.
changeset,0000004178,[4178],johnjamesjacoby,"Bump version numbers to 2.1, when singleton and magic methods were introduced."
changeset,0000002932,[2932],johnjamesjacoby,Bump version to 1.0.3 in 1.0.3 tag
changeset,0000003197,[3197],johnjamesjacoby,"Bump version to 2.0-beta-1, and add stable tag to readme.txt"
changeset,0000003822,[3822],johnjamesjacoby,Bump version to 2.1-r3822
changeset,0000003920,[3920],johnjamesjacoby,Bump version to 2.1-r3920.
changeset,0000003952,[3952],johnjamesjacoby,Bump version to 2.1-r3952.
changeset,0000004021,[4021],johnjamesjacoby,Bump version to 2.1-rc2.
changeset,0000004078,[4078],johnjamesjacoby,Bump version to 2.2-bleeding.
changeset,0000005190,[5190],johnjamesjacoby,Bump version to 2.5-beta.
changeset,0000004318,[4318],johnjamesjacoby,Bump version.
changeset,0000004237,[4237],johnjamesjacoby,Bump version.
changeset,0000004584,[4584],jmdodd,"Bump version.
"
changeset,0000004027,[4027],johnjamesjacoby,Bump versions to 2.1-rc3
changeset,0000006978,[6978],johnjamesjacoby,"Bump versions to 2.6.2.
"
changeset,0000007228,[7228],johnjamesjacoby,"Bump versions to 2.6.9.
"
changeset,0000004901,[4901],johnjamesjacoby,Bump.
changeset,0000004474,[4474],johnjamesjacoby,Bump.
changeset,0000004403,[4403],johnjamesjacoby,Bump.
changeset,0000004356,[4356],johnjamesjacoby,Bump.
changeset,0000004230,[4230],johnjamesjacoby,Bump.
changeset,0000005888,[5888],netweb,"Bumps: Normalize type-casting in `bbp_bump_user_reply_count()` missed in r5732
See #2801
"
changeset,0000005732,[5732],johnjamesjacoby,"Bumps: Normalize type-casting in bump functions.
Props thebrandonallen, netweb. See #2801."
changeset,0000005638,[5638],johnjamesjacoby,Bye. Props djpaul. See #2771 (2.5 branch)
changeset,0000005636,[5636],johnjamesjacoby,Bye. Props djpaul. See #2771 (trunk)
changeset,0000004898,[4898],johnjamesjacoby,"Cache clean-up:
* Perform strict comparisons on wp_cache_get() results.
* Add caching to bbp_get_topic_favoriters().
* Use wp_parse_id_list() where appropriate in touched functions.
* See #2331."
changeset,0000004210,[4210],johnjamesjacoby,"Cache:
* Update bbp_clean_post_cache() to use $_post instead of $post.
* Clean up post parent cache cleaning logic"
changeset,0000004012,[4012],johnjamesjacoby,"Cache:
* Update phpdoc for BBP_Skip_Children::pre_post_update()
* See #1859."
changeset,0000004011,[4011],johnjamesjacoby,"Cache:
* When updating bbPress post content, prevent cache invalidation of its children.
* Fixes #1859.
* Hat tip wonderboymusic."
changeset,0000006054,[6054],netweb,"Cache: Allow a second parameter to be passed to `bbp_clean_post_cache()`
Following [5774] WP's `clean_post_cache` hook can pass both post ID and the post object, this changeset allows that second parmeter to be passed to `bbp_clean_post_cache()` and updates our `add_action` call to send both parameters.
Props thebrandonallen.
Fixes #2813.
"
changeset,0000006585,[6585],johnjamesjacoby,"Cache: make `bbp_clean_post_cache()` an action-only function.
Instead of calling `bbp_clean_post_cache()` directly, we'll call `clean_post_cache()` as per normal and hook `bbp_clean_post_cache()` to the end of it. This reduces a bunch of superfluous cache invalidation from occurring back-to-back.
We'll also only ever update the `last_changed` cache key when we've reached the forum-root. This makes sure that subsequent recursive calls up the `post_parent` tree are dealing with the same `last_changed` value until the end.
This change will reduce the number of cache invalidation calls by a large amount, improving functional performance for database writes to the post & postmeta tables."
changeset,0000005774,[5774],johnjamesjacoby,"Cache: Much more sane cache invalidation.
This change improves hierarchical forum/topic/reply cache invalidations by not requiring each call to be strategically placed between actions to avoid race conditions.
Props thebrandonallen. Fixes #2800."
changeset,0000004041,[4041],johnjamesjacoby,"Caches:
* Introduce bbp_clean_post_cache() to handle cleaning custom queries and post ancestors.
* Audit use of _pre_ and _post_ forum/topic/reply actions and locations. Reposition and pass parents as needed.
* Add 'bbp_clean_post_cache' action to necessary _pre_ and _post_ actions.
* Fixes #1861."
changeset,0000003945,[3945],johnjamesjacoby,"Capabilities & Settings:
* Introduce bbp_admin_show_ui() function to handle fine-grained control of available settings screens and sections.
* Fixes #1846.
* See #1826."
changeset,0000003946,[3946],johnjamesjacoby,"Capabilities & Settings:
* Rename bbp_admin_show_ui() to bbp_current_user_can_see().
* Add detailed support for hiding admin settings sections.
* Remove BBP_Admin UI override flags in lieu of new method.
* See #1846."
changeset,0000004338,[4338],johnjamesjacoby,"Capabilities:
* Add ""Forum Role"" column to single-site users list.
* Fixes issue where there was no immediate way to see what users had what forums role at a glance.
* Props jmdodd.
* Fixes #2012."
changeset,0000004313,[4313],johnjamesjacoby,"Capabilities:
* Add 'blocked' capability for Blocked role.
* See #1939."
changeset,0000004179,[4179],johnjamesjacoby,"Capabilities:
* Add 'participate' capability to admin role defaults.
* Rearrange bbp_global_access_role_mask() to check logged in and member of blog before inactive.
* Default to WordPress Subscriber role in bbp_global_access_role_mask().
* Addresses issue where users don't get proper default caps masked to them."
changeset,0000003944,[3944],johnjamesjacoby,"Capabilities:
* Add 'read_private_forums' capability to all registered user roles.
* This can still be conditionally modified by other plugins (namely BuddyPress for Private Group Forums.)
* Fixes #1845."
changeset,0000004309,[4309],johnjamesjacoby,"Capabilities:
* Add label to admin user role UI, to match !WordPress core convention.
* See #1939."
changeset,0000004406,[4406],johnjamesjacoby,"Capabilities:
* Add sanity check in bbp_set_current_user_default_role() to check that setup_current_user action has already fired.
* If not, bail early, since there is no user to attach a role to yet.
* This should not happen under normal circumstances, only when doing advanced tricks or otherwise _doing_it_wrong().
* This bit is subject to change, based on testing."
changeset,0000004299,[4299],johnjamesjacoby,"Capabilities:
* Add setting callback for default_role.
* Update verbiage for auto-role/global-access.
* See #1939."
changeset,0000004290,[4290],johnjamesjacoby,"Capabilities:
* Add support for forum specific roles in core/capabilities.php.
* See #1939."
changeset,0000004341,[4341],johnjamesjacoby,"Capabilities:
* Add tool for remapping site users to the expected forums role.
* Does not remove existing !WordPress core roles.
* See #1939, #2010."
changeset,0000004678,[4678],johnjamesjacoby,"Capabilities:
* Allow keymaster role to use Forums tools and save Forums settings.
* Fixes #2139."
changeset,0000004453,[4453],johnjamesjacoby,"Capabilities:
* Allow moderators to view hidden forums too."
changeset,0000004454,[4454],johnjamesjacoby,"Capabilities:
* Allow moderators to view hidden forums too.
* For trunk."
changeset,0000004307,[4307],johnjamesjacoby,"Capabilities:
* Always show roles UI; only show capabilities if switch is on.
* See #1939."
changeset,0000004182,[4182],johnjamesjacoby,"Capabilities:
* Bail if in network admin.
* Prevent modifying blog caps in network admin area."
changeset,0000004184,[4184],johnjamesjacoby,"Capabilities:
* Bring back bbp_add_caps() and bbp_remove_caps().
* Remove role mask, and more aggressively add registered user to site with default role when user visits the site for the first time.
* See #1942."
changeset,0000004300,[4300],johnjamesjacoby,"Capabilities:
* Do no call bbp_add_caps() on activation anymore.
* This is handled by new forums roles.
* See #1939."
changeset,0000004316,[4316],johnjamesjacoby,"Capabilities:
* Enforce blocked logged in users by showing them a 404 if they cannot spectate.
* See #1939."
changeset,0000004192,[4192],johnjamesjacoby,"Capabilities:
* Enforce negative capabilities in user_profile_update() by using add_cap( $cap, false );
* Remove new-role dance from capability reset, as bbPress capabilities are still added to each individual role as needed."
changeset,0000004304,[4304],johnjamesjacoby,"Capabilities:
* Filter out bbPress roles from editable_roles array.
* Introduce bbp_filter_blog_editable_roles() and hook to 'editable_roles'.
* See #1939."
changeset,0000004351,[4351],johnjamesjacoby,"Capabilities:
* Get correct capabilities for anonymous role in bbp_get_editable_roles().
* These are currently the same, though will change in future versions."
changeset,0000004350,[4350],johnjamesjacoby,"Capabilities:
* Hook bbp_add_forums_roles() to 'bbp_setup_theme' since it's before user init.
* Add anonymous role to dynamic role loader.
* Fixes issues with roles not being mapped correctly on new installations."
changeset,0000004371,[4371],johnjamesjacoby,"Capabilities:
* Hook bbp_set_current_user_default_role() to 'switch_blog'
* Fixes bug where mapped forums role was lost on multisite when WP_Admin_Bar::initialize() would switch to a blog that a user is a member of, if the user was viewing a forum on a site they do not have a role on.
* See #1939."
changeset,0000004303,[4303],johnjamesjacoby,"Capabilities:
* Introduce 'bbp_profile_update' sub-action.
* Use in place of piggy-backed admin user profile actions.
* See #1939."
changeset,0000004288,[4288],johnjamesjacoby,"Capabilities:
* Introduce bbp_edit_user_forums_role() and rename bbp_edit_user_role() to bbp_edit_user_blog_role().
* See #1939."
changeset,0000004294,[4294],johnjamesjacoby,"Capabilities:
* Introduce bbp_get_default_role() in core/options.php and set default option value.
* See #1939."
changeset,0000004335,[4335],johnjamesjacoby,"Capabilities:
* Introduce bbp_get_user_role_map() to more intelligently map !WordPress roles to bbPress roles.
* Use bbp_get_user_role_map() in bbp_set_current_user_default_role().
* See #1939.
* Fixes #2010."
changeset,0000004293,[4293],johnjamesjacoby,"Capabilities:
* Introduce bbp_get_wp_roles() and use in place of $wp_roles global.
* See #1939."
changeset,0000004289,[4289],johnjamesjacoby,"Capabilities:
* Introduce bbp_set_user_role() and add $context parameter to bbp_get_user_role().
* See #1939."
changeset,0000004363,[4363],johnjamesjacoby,"Capabilities:
* Introduce bbp_user_has_profile() function in /users/capabilities.php.
* Use this function to suppress links to a profile of a user with no role on the site.
* Replaces some logic in bbp_parse_query() for setting user profile query variables.
* See #1939."
changeset,0000004305,[4305],johnjamesjacoby,"Capabilities:
* Introduce bbp_user_register() and bbp_profile_update() sub-actions.
* See #1939."
changeset,0000004365,[4365],johnjamesjacoby,"Capabilities:
* Introduce functionality for bulk-edit of user forums roles.
* Uses new 'keep_gate' capability to prevent granting keymaster role from a non-keymaster.
* For !WordPress 3.5 and higher.
* Props jmdodd.
* See #1939.
* Fixes #2016."
changeset,0000004236,[4236],johnjamesjacoby,"Capabilities:
* Introduce sub-action for saving a users profile.
* Hook capability saving functions to this new action.
* Remove duplicate admin routine from /bbp-admin/bbp-users.php.
* Remove hardcoded capability saving from bbp_edit_user_handler().
* Add edit_user capability checks to cap save and reset functions.
* Fixes bug when caps would be lost when a user saves their own profile.
* Fixes #1963."
changeset,0000004364,[4364],johnjamesjacoby,"Capabilities:
* Introduce two helper functions: bbp_filter_user_roles_option() and _bbp_reinit_dynamic_roles()
* Fixes bug where switching to a new blog would wipe out dynamically loaded roles.
* Filter the *_user_roles option, and add bbPress's roles to it.
* See #1939."
changeset,0000004445,[4445],johnjamesjacoby,"Capabilities:
* Map caps to read_private_posts in forum/topic/reply read_ checks.
* Fixes debug notices and possible mapped caps from an unset object variable.
* Fixes #2039 (2.2 branch)"
changeset,0000004446,[4446],johnjamesjacoby,"Capabilities:
* Map caps to read_private_posts in forum/topic/reply read_ checks.
* Fixes debug notices and possible mapped caps from an unset object variable.
* Fixes #2039 (trunk)"
changeset,0000004419,[4419],johnjamesjacoby,"Capabilities:
* Moderators cannot see forums in wp-admin."
changeset,0000004346,[4346],johnjamesjacoby,"Capabilities:
* Move status and role user functions out of users/functions.php and into users/capabilities.php.
* See #1939."
changeset,0000004413,[4413],johnjamesjacoby,"Capabilities:
* Only loop through array keys in bbp_filter_blog_editable_roles().
* Prevents unused value variables from being created."
changeset,0000004360,[4360],johnjamesjacoby,"Capabilities:
* Only setup the default current user role when the current user has been byref copied into bbPress's instance.
* Fixes issue where some core actions are suppressed during the deactivation process, causing an action order conflict with current_user.
* Fixes #1939."
changeset,0000004431,[4431],johnjamesjacoby,"Capabilities:
* Only try to add the new role if there's a new role to add."
changeset,0000004339,[4339],johnjamesjacoby,"Capabilities:
* PHP5'ize list table BBP_Users_Admin methods.
* See #2012."
changeset,0000004165,[4165],johnjamesjacoby,"Capabilities:
* Reference correct function in bbp_add_caps()
* See #1939"
changeset,0000004375,[4375],johnjamesjacoby,"Capabilities:
* Rehook bbp_set_current_user_default_role() back to 'bbp_setup_current_user'.
* Now that deactivation check has moved, it's safe to hook this directly again.
* Remove from bbPress::setup_current_user().
* See #1939."
changeset,0000004064,[4064],johnjamesjacoby,"Capabilities:
* Remap 'read' capability to moderator and lesser roles, since it will be needed by bbPress to read most things.
* Fixes #1887."
changeset,0000004330,[4330],johnjamesjacoby,"Capabilities:
* Remove advanced capabilities code, template part, and UI helpers.
* This has been replaced by the forums roles selection.
* See #1939."
changeset,0000004320,[4320],johnjamesjacoby,"Capabilities:
* Remove all previous forums roles in bbp_set_user_role().
* Use direct array intersection instead of bbp_get_user_role().
* Fixes issue where users can have more than 1 forum role.
* See #1939."
changeset,0000004180,[4180],johnjamesjacoby,"Capabilities:
* Remove bbp_masked capability when setting the user role.
* Do not set a fake role in bbp_global_access_role_mask().
* Rename variable in bbp_global_access_role_mask() to be more literal.
* Add note to phpdoc of bbp_global_access_role_mask()."
changeset,0000004412,[4412],johnjamesjacoby,"Capabilities:
* Remove call to array_diff_assoc() in bbp_filter_blog_editable_roles().
* Use two foreach() loops instead.
* Randomly stopped working; no time before 2.2 to investigate."
changeset,0000004319,[4319],johnjamesjacoby,"Capabilities:
* Remove caps before setting new role in bbp_profile_update_capabilities().
* See #1939."
changeset,0000004222,[4222],johnjamesjacoby,"Capabilities:
* Remove experimental Bozo functionality. We can use the 'participate' to prevent forum participation without creating topics or replies.
* Introduce functions to reset, save, and remove user capabilities.
* Use these functions in both theme-side and admin-side profiles.
* Add capabilities to bbp-twentyten theme. This will be moved into the stand-alone bbp-twentyten theme soon'ish."
changeset,0000004083,[4083],johnjamesjacoby,"Capabilities:
* Remove is_multisite() checks from role masking, to allow single-site installs with shared user tables to still mask roles.
* See #1894 (2.2 branch)"
changeset,0000004080,[4080],johnjamesjacoby,"Capabilities:
* Remove is_multisite() checks from role masking, to allow single-site installs with shared user tables to still mask roles.
* See #1894."
changeset,0000004349,[4349],johnjamesjacoby,"Capabilities:
* Remove most capability mappings to 'participate' cap.
* Update bbp_set_current_user_default_role() to dynamically map a logged in user if global access is turned off.
* Provides alternative to users being granted a database role without taking any action.
* This makes bbPress work similarly to comments, though a decision needs to be made regarding profile pages for these ""anonymous"" users."
changeset,0000004168,[4168],johnjamesjacoby,"Capabilities:
* Remove negative 'blocked' cap and use positive 'participate' cap instead.
* Replaces old 'bbp_participant' role nicely."
changeset,0000004164,[4164],johnjamesjacoby,"Capabilities:
* Remove roles and move everything to mapped capabilities.
* First pass at admin-side forum capability manager.
* Deprecate moderator, anonymous, and participant roles and associated functions.
* Deprecate add/remove role/cap functions.
* More cap mapping needed for users that are not explicitly blocked.
* Adds cap check to forms for topic-tag adding/editing.
* See #1939"
changeset,0000004292,[4292],johnjamesjacoby,"Capabilities:
* Remove trailing whitespace in core/capabilities.php.
* See #1939."
changeset,0000004354,[4354],johnjamesjacoby,"Capabilities:
* Rename 'anonymous' role to 'visitor' to avoid confusion with logged-out anonymity.
* Renames functions, keys, filters, et all.
* See #1939."
changeset,0000004352,[4352],johnjamesjacoby,"Capabilities:
* Rename bbp_get_editable_roles() to bbp_get_dynamic_roles().
* This new function name better represents bbPress's approach to secondary user roles, in that these roles are no longer intentionally saved to the database.
* See #1939."
changeset,0000004185,[4185],johnjamesjacoby,"Capabilities:
* Rename global role masking to bbp_set_current_user_default_role().
* Update phpdoc and action usages.
* See #1942."
changeset,0000004367,[4367],johnjamesjacoby,"Capabilities:
* Reverse logic in bbp_user_has_profile().
* Assume all users have profiles, and they must be explicitly disabled.
* This is a more natural default behavior, as rarely will a site need to restrict a user's profile to a specific central site.
* See #1939."
changeset,0000004066,[4066],johnjamesjacoby,"Capabilities:
* Revert r4064, as the 'read' capability is used to check for participant role mask.
* See #1887."
changeset,0000004314,[4314],johnjamesjacoby,"Capabilities:
* Revert r4313.
* Remove negative 'blocked' capability; use not 'spectate' instead.
* See #1939."
changeset,0000004244,[4244],johnjamesjacoby,"Capabilities:
* Separate capabilities into files for their respective components.
* Add minimum capability to topic views. (Assume no cap is public.)
* Make bbp_map_meta_caps a subaction, and move it to bbp-core-dependency.php.
* Introduce component meta map functions in each -caps.php file.
* Update bbp_current_user_can_see() to use capabilities instead of being a boolean switch.
* Working towards removing the need to add/remove caps to existing roles, allowing them to be strictly per user as needed."
changeset,0000004433,[4433],johnjamesjacoby,"Capabilities:
* Set default param values in all map_meta_cap filters, incase none are passed or type cast correctly."
changeset,0000004374,[4374],johnjamesjacoby,"Capabilities:
* Since bbp_set_current_user_default_role() is directly hooked to switch_blog, add deactivation check to prevent php warnings.
* See #1939."
changeset,0000004336,[4336],johnjamesjacoby,"Capabilities:
* Switch default value of global access to 1.
* Fixes confusion about why users are not automatically added to forums.
* See #1939."
changeset,0000004172,[4172],johnjamesjacoby,"Capabilities:
* Tweak CSS for capability UI to fix layout issues with varying height divs."
changeset,0000004291,[4291],johnjamesjacoby,"Capabilities:
* Tweak phpdoc and cast type on return of bbp_use_advanced_capability_editor().
* See #1939."
changeset,0000004306,[4306],johnjamesjacoby,"Capabilities:
* Update bbp-default templates to support new roles UI.
* See #1939."
changeset,0000004302,[4302],johnjamesjacoby,"Capabilities:
* Update bbp_edit_user_blog_role() and bbp_edit_user_forums_role() to use appropriate functions to get role arrays.
* See #1939."
changeset,0000004207,[4207],johnjamesjacoby,"Capabilities:
* Update bbp_get_user_display_role() to use special capabilities."
changeset,0000004311,[4311],johnjamesjacoby,"Capabilities:
* Update bbp_map_primary_meta_caps() to block for inactive users, and check cap for active users.
* See #1939."
changeset,0000004308,[4308],johnjamesjacoby,"Capabilities:
* Update bbp_profile_update_capabilities() to include saving forums roles.
* When saving a role, remove any individual forums capabilities that were set.
* Add some legacy caps to primary group, so they are correctly removed.
* See #1939."
changeset,0000004297,[4297],johnjamesjacoby,"Capabilities:
* Update bbp_set_user_role() and bbp_get_user_role() to only work with bbPress forums roles.
* See #1939."
changeset,0000004301,[4301],johnjamesjacoby,"Capabilities:
* Update BBP_User_Admin to use roles UI instead of capabilities.
* Leave capabilities in for now, but hidden behind a switch function.
* See #1939."
changeset,0000004353,[4353],johnjamesjacoby,"Capabilities:
* Update inline doc for 'spectate' VS 'participate'.
* See #1939."
changeset,0000004282,[4282],johnjamesjacoby,"Capabilities:
* Update mapped caps in map_settings_meta_caps().
* Fixes missing !BuddyPress and Akismet settings on single-site installations.
* Fixes #2000."
changeset,0000004366,[4366],johnjamesjacoby,"Capabilities:
* Update notices in deprecated add/remove roles functions.
* See #1939."
changeset,0000004186,[4186],johnjamesjacoby,"Capabilities:
* Update phpdoc for bbp_set_current_user_default_role().
* See #1942."
changeset,0000004312,[4312],johnjamesjacoby,"Capabilities:
* Use bbp_get_current_user_id() in bbp_set_current_user_default_role().
* See #1939."
changeset,0000004337,[4337],johnjamesjacoby,"Capabilities:
* Use bbp_get_default_role() in bbp_get_user_role_map().
* See #1939."
changeset,0000004340,[4340],johnjamesjacoby,"Capabilities:
* Use bbp_get_user_role() to get the user's forums role.
* Update bbp_set_user_role() to return false if trying to set a role the user already has.
* Remove foreach loop to remove existing roles, since there's no way to naturally have more than one.
* See #1939."
changeset,0000004298,[4298],johnjamesjacoby,"Capabilities:
* Use correct $roles variable in bbp_get_user_role().
* See #1939."
changeset,0000004317,[4317],johnjamesjacoby,"Capabilities:
* Use correct 'bbp_set_user_role' filter name.
* Reset user caps when setting auto-role.
* See #1939."
changeset,0000004206,[4206],johnjamesjacoby,"Capabilities:
* Use current_user_can( 'read' ) instead of is_user_member_of_blog() in bbp_set_current_user_default_role().
* Fixes issue where auto-role would not apply on single site, or multisite if user had orphaned caps."
changeset,0000004541,[4541],johnjamesjacoby,"Capabilities:
* Verbiage change for forums role selector.
* Fixes #2079 (2.2 branch)"
changeset,0000004542,[4542],johnjamesjacoby,"Capabilities:
* Verbiage change for forums role selector.
* Fixes #2079 (trunk)"
changeset,0000004355,[4355],johnjamesjacoby,"Capabilities:
* When transitioning a user role, avoid giving them the visitor role unless explicitly intended.
* See #1939."
changeset,0000005852,[5852],johnjamesjacoby,"Capabilities: add `delete_posts` mappings to `delete` topic & reply checks.
This changeset ensures that capable users can delete their own topics & replies, when these capabilities are explicitly allowed already.
Props netweb, gusrb84. Fixes #2685."
changeset,0000006975,[6975],johnjamesjacoby,"Capabilities: break instead of return.
This commit ensures that the relative _meta_caps filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return $caps without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.7, trunk."
changeset,0000006972,[6972],johnjamesjacoby,"Capabilities: break instead of return;
This commit ensures that the relative `_meta_caps` filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return `$caps` without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.6.2.
"
changeset,0000006714,[6714],johnjamesjacoby,"Capabilities: first pass at single topic-tag cap mappings.
This change adds IDs where appropriate, and introduces single term cap checks with intelligent comparisons that match the approach used by forums, topics, and replies.
* Inactive users cannot assign, manage, edit, or delete
* Moderators can assign, manage, edit, and delete
* Participants can assign
* Spectators & Blocked users still cannot manipulate topic tags in any way
This prepares bbPress for third-party plugins to leverage topic-tags in ways it otherwise wasn't prepared to do.
See #3167."
changeset,0000006265,[6265],netweb,"Capabilities: Fix inline docs copy pasta introduced in [5852]
See #2685
"
changeset,0000006571,[6571],johnjamesjacoby,"Capabilities: Logic improvements to help with per-forum moderation.
* Introduce `moderate_forum` capability check, used to check if a user has the ability to moderate a specific forum
* Limit number of direct `keep_gate` checks, and use `bbp_is_user_keymaster()` where possible
* Make `bbp_is_user_forum_moderator()` check the new `moderate_forum` mapped capability
* Have the `moderate` mapped capability check `moderate_forum` if the `$args[0]` can be bubbled up to being a forum ID
* Map admin post-type areas to their appropriate `edit_` capabilities – they are now properly handled via other mapped conditions
This change (along with r6567 & r6569) allows private & hidden forums to appear in forums queries for users who can moderate them."
changeset,0000006713,[6713],johnjamesjacoby,"Capabilities: prevent edits when past the edit-lock time.
This change increases the priority of the `moderator` check, so that moderators are not subjected to edit-lock restrictions, and maps to `do_not_allow` for topic/reply authors who normally can edit but are now beyond the allotted time period.
Fixes #3164. Props SergeyBiryukov."
changeset,0000006561,[6561],johnjamesjacoby,"Capabilities: Skip double checks in `bbp_is_user_inactive()`, and use `bbp_get_user_id()` in `bbp_is_user_keymaster()`.
This change cleans up a few user capability functions, to use internal handlers and allow filters (like `bbp_get_user_id`) to be applied as expected in the given context."
changeset,0000002866,[2866],johnjamesjacoby,Capital P... Dangit! Props westi.
changeset,0000005215,[5215],johnjamesjacoby,Capitalize `bbpress::instance();` to `bbPress::instance()` to avoid class/function confusion.
changeset,0000004219,[4219],johnjamesjacoby,"Caps:
* Prevent users from seeing their own caps if allowed in wp-admin."
changeset,0000006783,[6783],johnjamesjacoby,"Caps: Check for `$args[0]` and bail if empty.
This change avoids debug notices when single forum/topic/reply capability checks are done without having passed in a post ID.
Props espellcaste, chriscct7. Fixes #3190."
changeset,0000002957,[2957],johnjamesjacoby,"Carry over the view=all query arguments into other appropriate forum/topic/reply links on the forum pages. This eliminates the inconsistent user experience of asking to view trashed/spammed topics or replies, and being taken to pages where you cannot see those topics/replies."
changeset,0000002851,[2851],johnjamesjacoby,"Cast return values as (int) where appropriate. Adjust _last_ functions to be more friendly with anonymous user data. Test some logic with _last_ forum/topic/reply where if reply_id does not exist, fall back to topic_id. Remove various strict empty string checks as they should no longer be needed."
changeset,0000003133,[3133],johnjamesjacoby,Cast return values of bbp_get_hidden_form_ids() and bbp_get_private_forum_ids() to prevent debug notices when both of these values exist but are single values or empty strings.
changeset,0000005593,[5593],johnjamesjacoby,"Cast value as `(int)` in `bbp_get_form_forum_parent()`, ensuring it is numerical for the remaining call stack. See #2742."
changeset,0000002986,[2986],johnjamesjacoby,Center vertical alignment of revision logs in topics and replies.
changeset,0000002943,[2943],johnjamesjacoby,"Change 'bbp-twentyten' theme from child to parent and include all of the standard twentyten theme files. Also wrap function_exists() checks around all functions in bbp-twentyten to allow them to be overloaded.
Remove the 'bbp_' prefix form/topic/reply post types and include a routine in the database updater to handle this. The new post_type's are 'forum', 'topic', and 'reply' respectively.
Rename 'bbp_topic_tag' taxonomy ID to 'topic-tag' and include a routine in the database updater to handle this.
Change underscores in theme files to hyphens and remove 'bbp' prefix where applicable to comply with WordPress file standards.
Update possible template file location options in bbp-general-functions.php for all standard template files. Include option for 'bbpress' or 'forums' subfolders inside the theme directory. This takes advantage of a known anomaly in the get_template_part() function that allows a subfolder to be passed."
changeset,0000002925,[2925],johnjamesjacoby,Change 'Forums' to 'Forum' in forums loop template file.
changeset,0000002894,[2894],johnjamesjacoby,"Change @sinces on bbp_author_link functions, and include additional code to support getting the author link and avatar when the post_type is unknown."
changeset,0000003383,[3383],johnjamesjacoby,Change bbp-forum-info class to bbp-forum-content in same places. Fixes #1590. Props sorich87.
changeset,0000002723,[2723],johnjamesjacoby,Change bbp_convert_date description
changeset,0000005488,[5488],johnjamesjacoby,Change behavior of `bbp_check_for_moderation()` so empty `moderation_keys` no longer skips `max_links` check. Props netweb. See #2546.
changeset,0000003462,[3462],johnjamesjacoby,"Change behavior of bbp_is_topic_tag() to not include when editing a tag. Improvements to topic tag edit logic, and display Edit link in breadcrumb."
changeset,0000003458,[3458],johnjamesjacoby,Change dashboard metabox header descriptions. Fixes #1599.
changeset,0000003432,[3432],johnjamesjacoby,"Change hidden post status from protected to private, as we are now handling forum privacy scope manually. Fixes #1576."
changeset,0000002645,[2645],johnjamesjacoby,Change phpDoc and rearrange functions in the order they are called
changeset,0000003360,[3360],johnjamesjacoby,"Change size of metabox input boxes from 38 to 25, to prevent them from being wider than the parent element."
changeset,0000002911,[2911],johnjamesjacoby,Change subscription checkbox text if the post is the current users or someone else's. Fixes #1462.
changeset,0000003650,[3650],johnjamesjacoby,Change the default class in bbp_list_forums() so it does not conflict with non-list forums.
changeset,0000003155,[3155],johnjamesjacoby,"Change the filter used on _bbp_root_slug from sanitize_title to esc_url_raw, to allow for a page path with slashes."
changeset,0000004737,[4737],johnjamesjacoby,Change topic and reply content filter order to move 'bbp_mention_filter' just behind 'make_clickable' since mentions are an extention of it. See #2185.
changeset,0000003839,[3839],johnjamesjacoby,Check $anonymous_data variable before assuming array index exists in bbp_check_for_duplicate()
changeset,0000003326,[3326],johnjamesjacoby,Check appropriate cap in bbp_get_forum_topics_link(). See r3325.
changeset,0000002622,[2622],johnjamesjacoby,Check caps on new topic and new reply forms
changeset,0000005611,[5611],johnjamesjacoby,"Check for `IXR_Value` class before including BackPress's version.
Avoids collisions when deeply integrated with WordPress.
For 1.1 & 1.2 branches.
"
changeset,0000003562,[3562],johnjamesjacoby,Check for active BuddyPress Group component before registering Forum extension.
changeset,0000002969,[2969],johnjamesjacoby,"Check for bbp_show_lead_topic() and adjust verbiage from ""Replies"" to ""Posts"" and show favorites/subscription links if set to false"
changeset,0000003827,[3827],johnjamesjacoby,Check for BBPRESS_LATE_LOAD constant to enable bbPress to be loaded on plugins_loaded action instead of inline.
changeset,0000004940,[4940],johnjamesjacoby,Check for both forum/topic archives when setting 'bbp_show_topics_on_root' query arg. Fixes paged 404's in configurations where a !WordPress page is used in place of the normal Forum archive. See #1500.
changeset,0000003148,[3148],johnjamesjacoby,Check for different _get_meta_sql function names (since we are using it prematurely in WP 3.1)
changeset,0000003199,[3199],johnjamesjacoby,Check for subforum count in bbp_list_forums() before running expensive IN queries on each forum.
changeset,0000002853,[2853],johnjamesjacoby,Check for valid topic and reply ID's on topic_author functions.
changeset,0000002765,[2765],johnjamesjacoby,Check proper 'moderate' cap on topic/reply admin actions. Fixes #1432.
changeset,0000003541,[3541],johnjamesjacoby,Check query name in bbp_is_single_view(). Fixes #1651. Props !GautamGupta for original patch.
changeset,0000003569,[3569],johnjamesjacoby,"Check query name in bbp_is_single_view(). See #1651, r3541. (2.1)"
changeset,0000003045,[3045],johnjamesjacoby,Check that $post global exists to prevent errors and debug notices on genuine 404 pages.
changeset,0000005077,[5077],johnjamesjacoby,"Check that 'bbp_topic_status' is set before comparing to available topic statuses. Also, use bbp_get_topic_statuses() instead of hardcoded array."
changeset,0000005596,[5596],johnjamesjacoby,Check that `user_url` exists before attempting to allow it in max-links.
changeset,0000005189,[5189],johnjamesjacoby,Check the `$author_id` before passing it into `bbp_is_user_keymaster()` in blacklist and moderation functions. Prevents accidental role escalation if `$author_id` is empty. See #2393.
changeset,0000005186,[5186],johnjamesjacoby,Check the `$located` variable to avoid trying to enqueue a style or script that was not found.
changeset,0000005024,[5024],johnjamesjacoby,"Check the action in bbp_search_results_redirect(), and bail early if it's not a search request. Fixes regression causing topic merge/split/move actions to redirect to search page introduced in r4928."
changeset,0000003584,[3584],johnjamesjacoby,Check the post_content instead of post_title in forum & topic content form functions.
changeset,0000002960,[2960],johnjamesjacoby,Check the previous item for separation rather than the current item
changeset,0000002796,[2796],johnjamesjacoby,Check the topic_id and reply_id when appending revision logs
changeset,0000002912,[2912],johnjamesjacoby,"Clarify subscription notification email text. Props designsimply, hanni, westi. Fixes #1472."
changeset,0000004211,[4211],johnjamesjacoby,"Classes:
* Clean up BBP_Walker_Dropdown::start_el()"
changeset,0000006692,[6692],johnjamesjacoby,"Classes: add more author & moderator related CSS classes to helper functions.
This change adds classes to forums, topics, and replies where the respective author is also a moderator of the nearest parent forum.
See #459."
changeset,0000002922,[2922],johnjamesjacoby,Clean up @todo's
changeset,0000003026,[3026],johnjamesjacoby,Clean up _includes() and add 'shortcodes' to the list of included files.
changeset,0000005376,[5376],johnjamesjacoby,Clean up `bbp_get_reply_to()` to improve code readability. (2.5 branch)
changeset,0000005167,[5167],johnjamesjacoby,Clean up `bbp_get_user_blog_role()` to avoid creating an unused variable.
changeset,0000002479,[2479],johnjamesjacoby,Clean up admin area code. Move actions outside of init. Add phpdoc to admin area. Rename a few functions for consistency sake.
changeset,0000003343,[3343],johnjamesjacoby,Clean up admin components and loader code.
changeset,0000002724,[2724],johnjamesjacoby,Clean up admin forum/topic/reply columns.
changeset,0000005083,[5083],johnjamesjacoby,"Clean up admin settings fields attribute order: name, ID, type, value, others... See #2388."
changeset,0000002742,[2742],johnjamesjacoby,Clean up bb-login.php to prevent potential redirection exploit.
changeset,0000003096,[3096],johnjamesjacoby,Clean up bbp-admin.php and bbp-users.php after recent separation
changeset,0000003480,[3480],johnjamesjacoby,Clean up bbp-twentyten/functions.php
changeset,0000003828,[3828],johnjamesjacoby,Clean up BBP_Component class methods. Pass $wp_rewrite in sub aciton.
changeset,0000004238,[4238],johnjamesjacoby,Clean up bbp_current_author_ua().
changeset,0000004983,[4983],johnjamesjacoby,Clean up bbp_get_displayed_user_field(). See #1999.
changeset,0000002985,[2985],johnjamesjacoby,Clean up bbp_get_reply_url() and fix issue where trashed replies and view=all would cause malformed URLs.
changeset,0000004504,[4504],johnjamesjacoby,Clean up bbp_has_forums() and remove 1-time-use variable.
changeset,0000004239,[4239],johnjamesjacoby,Clean up bbp_make_ham_user() and bbp_make_spam_user().
changeset,0000002950,[2950],johnjamesjacoby,Clean up bbp_topic_notices() and add ability for custom notices to be filtered.
changeset,0000003770,[3770],johnjamesjacoby,Clean up bbpress.php phpdoc
changeset,0000003359,[3359],johnjamesjacoby,Clean up bbPress::setup_actions()
changeset,0000005500,[5500],johnjamesjacoby,Clean up core `actions.php`. Props netweb. See #2645.
changeset,0000002694,[2694],johnjamesjacoby,Clean up favorites and subscription adding code
changeset,0000002996,[2996],johnjamesjacoby,Clean up forum type setting functions. Add function to support hidden forum visibility type. Remove unneeded $bbp global references. Fix incorrect variable name in bbp_update_forum_last_active_id().
changeset,0000002998,[2998],johnjamesjacoby,"Clean up forum visibility template tags. Include functions for checking each visibility state, as well as retrieving the raw value."
changeset,0000003448,[3448],johnjamesjacoby,Clean up forum widget UI. Fixes #1521.
changeset,0000003152,[3152],johnjamesjacoby,Clean up functions.php of bbp-twentyten
changeset,0000002802,[2802],johnjamesjacoby,Clean up index.php. Number format friendliness. Add some comments. Fixes #1370 props !JohnConners
changeset,0000003845,[3845],johnjamesjacoby,Clean up inline doc for array elements in _has_functions to be more human readable.
changeset,0000002655,[2655],johnjamesjacoby,Clean up loop-bbp_topics code from adding favorites feature
changeset,0000002837,[2837],johnjamesjacoby,Clean up merge and split template files. Only show certain options if other topics exist within the current forum. Add bbp-template-notice.info class for general informational messages.
changeset,0000004925,[4925],johnjamesjacoby,Clean up overlapping default arguments in user_topics/replies_created functions.
changeset,0000003460,[3460],johnjamesjacoby,Clean up pagination count code and add notes for translators. See #1605.
changeset,0000004605,[4605],johnjamesjacoby,Clean up phpdoc block for bbp_kses_allowed_tags().
changeset,0000004610,[4610],johnjamesjacoby,Clean up phpdoc for bbp_get_total_users(). See #1799.
changeset,0000003329,[3329],johnjamesjacoby,Clean up plugins_url global and usages. Props cnorris23. Fixes #1557.
changeset,0000002744,[2744],johnjamesjacoby,Clean up post type registration code. Allow capable users to view trashed/spammed topics. Fixes #1346. Props !GautamGupta via Google Code-in.
changeset,0000002697,[2697],johnjamesjacoby,Clean up setting of current_user variable
changeset,0000003144,[3144],johnjamesjacoby,Clean up shortcode class phpDoc
changeset,0000002949,[2949],johnjamesjacoby,Clean up some @todo's and add some missing inline documentation to bbp-topic-functions.php.
changeset,0000002701,[2701],johnjamesjacoby,Clean up some old phpDoc
changeset,0000002934,[2934],johnjamesjacoby,Clean up the default topic status code in bbp_has_topics()
changeset,0000003071,[3071],johnjamesjacoby,Clean up the main bbPress and BBP_Admin classes. Add php5 constructors for future compatibility.
changeset,0000003080,[3080],johnjamesjacoby,Clean up the shortcode output buffer methods.
changeset,0000003193,[3193],johnjamesjacoby,Clean up whitespace and comment out Green admin UI styling since it will need a refresh when WordPress 3.1 ships anyways.
changeset,0000003743,[3743],johnjamesjacoby,Clean up whitespace and formatting in template loader functions. See r3739.
changeset,0000003740,[3740],johnjamesjacoby,Clean up whitespace and remove some cruft from r3739.
changeset,0000006390,[6390],johnjamesjacoby,Clean-up `bbp_current_author_ua()`.
changeset,0000005016,[5016],johnjamesjacoby,Clean-up admin ajax JS for Suggest methods. Fixes #2224.
changeset,0000003704,[3704],johnjamesjacoby,"Clean-up bbp-common-template.php:
* Remove unused globals
* Use bbp_get_global_post_field()
* Avoid accidental inline assignments"
changeset,0000004496,[4496],johnjamesjacoby,Clean-up bbp_get_dropdown() so unsetting variables for get_posts() usage is not necessary.
changeset,0000005014,[5014],johnjamesjacoby,Clean-up to Example.php converter. Props netweb. Fixes #2134.
changeset,0000002565,[2565],johnjamesjacoby,"Cleanup wp_debug errors. Fixes #1335, #1336, #1338, #1339, and #1340."
changeset,0000004333,[4333],johnjamesjacoby,"Cleanup:
* Move a few files out of /core and into /common.
* Includes: widgets, shortcodes, classes.
* Update bbpress.php to use new paths."
changeset,0000004603,[4603],johnjamesjacoby,Clear float for #bbp-topic-hot-tags in default CSS. Fixes #2062.
changeset,0000005032,[5032],johnjamesjacoby,Clearing CSS hack. Fixes content display issues related to hierarchical replies. Props mordauk. Fixes #2345.
changeset,0000003702,[3702],johnjamesjacoby,"Code clean-up in bbp-common-functions.php:
* Avoid accidental inline assignments
* Add bbp_get_global_post_field() function, for use in forms and editing"
changeset,0000003710,[3710],johnjamesjacoby,Code clean-up in bbp-forum-template.php.
changeset,0000003701,[3701],johnjamesjacoby,"Code clean-up in bbp-functions.php:
* Remove unused $bbp globals
* Add defaults to optional bbp_filter_sample_permalink() params
* Avoid accidental inline assignments"
changeset,0000003709,[3709],johnjamesjacoby,Code clean-up in bbp-reply-template.php.
changeset,0000003708,[3708],johnjamesjacoby,Code clean-up in bbp-topic-template.php.
changeset,0000003707,[3707],johnjamesjacoby,Code clean-up to template tags. Add more helpful classes to loop rows. Cast some more retvals. Fixes #1727.
changeset,0000003315,[3315],johnjamesjacoby,Code cleanup from r3313.
changeset,0000003516,[3516],johnjamesjacoby,Code formatting improvements to 'pre_get_posts' actions. Remove unused $bbp globals.
changeset,0000003545,[3545],johnjamesjacoby,Code formatting improvements to bbp-topic-functions.php and prevent possible debug notices.
changeset,0000003574,[3574],johnjamesjacoby,Code formatting improvements to bbp-topic-functions.php and prevent possible debug notices. See r3445. (2.1)
changeset,0000003699,[3699],johnjamesjacoby,Code formatting improvements to bbp-user-template.php.
changeset,0000003544,[3544],johnjamesjacoby,Code formatting improvements to bbp_toggle_reply_handler() and prevent possible debug notice on $failure.
changeset,0000003573,[3573],johnjamesjacoby,Code formatting improvements to bbp_toggle_reply_handler() and prevent possible debug notice on $failure. See r3544. (2.1)
changeset,0000003967,[3967],johnjamesjacoby,"Code Improvement:
* Add $Id$ Subversion keyword to bbpress.php.
* See #1851."
changeset,0000004505,[4505],johnjamesjacoby,"Code Improvement:
* Add brackets to /forums/template-tags.php.
* Remove duplicate variable assignments."
changeset,0000004565,[4565],johnjamesjacoby,"Code Improvement:
* Add brackets to some updater functions."
changeset,0000004563,[4563],johnjamesjacoby,"Code Improvement:
* Add some brackets to improve readability."
changeset,0000003956,[3956],johnjamesjacoby,"Code Improvement:
* Clean up bbPress::register_post_statuses() to not create variables."
changeset,0000003966,[3966],johnjamesjacoby,"Code Improvement:
* First pass at updating subversion properties.
* Remove text/x-php mime types.
* Remove text/css mime types.
* Remove invalid sv:mime-type property.
* See #1851."
changeset,0000003953,[3953],johnjamesjacoby,"Code Improvement:
* Fix incorrect @since phpdoc (rxxxx placeholders)"
changeset,0000003964,[3964],johnjamesjacoby,"Code Improvement:
* Lose EOF ?>.
* Clean up EOF newlines.
* Fixes #1850."
changeset,0000004281,[4281],johnjamesjacoby,"Code Improvement:
* More politely cast arrays in settings sections and fields.
* Use esc_html__() on some admin strings. See #1999.
* Clean up bbp_converter_setting_callback_platform()."
changeset,0000004248,[4248],johnjamesjacoby,"Code Improvement:
* Move bbp-admin into bbp-includes/admin.
* Introduce includes_dir and includes_url bbpress() vars.
* Adjust BBP_Admin include paths.
* See: #1975."
changeset,0000004249,[4249],johnjamesjacoby,"Code Improvement:
* Move bbp-includes files into respective subdirectories.
* Adjust include paths.
* Remove superfluous inline file descriptions.
* See: #1975."
changeset,0000003951,[3951],johnjamesjacoby,"Code Improvement:
* Move preset bbPress class variables into bbPress::setup_globals() action.
* Introduce magic get/set methods to handle main bbPress class variables.
* Keeps by-reference bbPress->current_user outside of bbPress->data.
* Reduces code duplication in bbPress class.
* Fixes #1847."
changeset,0000004566,[4566],johnjamesjacoby,"Code Improvement:
* Remove 1 time use variable from version bump."
changeset,0000004250,[4250],johnjamesjacoby,"Code Improvement:
* Remove bbp- prefixes from admin files.
* Adjust include paths.
* See #1975."
changeset,0000004331,[4331],johnjamesjacoby,"Code Improvement:
* Revert part of r4258.
* Cast as int instead of using absint()
* Fixes regression that broke existing bbPress plugin (hierarchical replies.)
* Fixes #2008."
changeset,0000003954,[3954],johnjamesjacoby,"Code Improvement:
* Revert r3950 and move bbPress class arrays back into their own variables to prevent by-reference errors."
changeset,0000004280,[4280],johnjamesjacoby,"Code Improvement:
* Straighten the teeth in template-tags.php.
* Add braces to all of the things.
* Hat-tip westi the dentist."
changeset,0000003955,[3955],johnjamesjacoby,"Code Improvement:
* Turn bbPress::extend into an stdClass in setup_globals.
* Add phpdoc to bbPress::data variable with verbose explanation of how it works."
changeset,0000004279,[4279],johnjamesjacoby,"Code Improvement:
* Use esc_attr_e() in place of _e() is some obvious places.
* See #1999."
changeset,0000005641,[5641],johnjamesjacoby,"Code Improvement:
* Add `$Id$` Subversion keyword property to `/src/bbpress.php`.
* Hat tip netweb. See #1851."
changeset,0000006907,[6907],netweb,"Coding Standards: Add missing trailing semi-colon from [6893]
"
changeset,0000003031,[3031],johnjamesjacoby,Commit bomb of changes to bbp-twentyten to further abstract out template parts for improved shortcode usage and theme_compat for themes that do not explicitly support bbPress.
changeset,0000003250,[3250],johnjamesjacoby,"Commit bomb of improvements to the breadcrumb.
Checking for topic views, forum and topic archives, and do not check if the root slug is included in the URL.
Add breadcrumb to forum archive and topic archive, since they exist one level deeper than the ""Home"" page.
Add template tags to handle the forum/topic archive titles, which use a corresponding page title if one exists, and fallback to the post type label 'name' if not."
changeset,0000003241,[3241],johnjamesjacoby,"Commit bomb of updates to breadcrumb logic:
Switch from parameters to a parse args array.
Switch from template part to function.
Add before/after HTML arguments.
Add missing breadcrumb to reply-edit, view, and topic-tag templates.
Add home link logic.
Add filters on breadcrumb items.
Add quick-bail filter at the beginning of breadcrumb function."
changeset,0000003032,[3032],johnjamesjacoby,"Commit bomb, round 2. Similar to r3031, this includes a host of new functions for handling theme compatability for themes that do not explicitly support bbPress. Also introduces BBP_Shortcode class as handler for all shortcodes going forward."
changeset,0000007251,[7251],johnjamesjacoby,"Common Functions: fix dashboard errors from undefined variables.
Introduced in r7237, in `bbp_get_statistics()`.
This corrects an unintended regression that was causing replies not to be counted correctly.
In branches/2.6, for 2.6.10."
changeset,0000006013,[6013],johnjamesjacoby,Common group.
changeset,0000003902,[3902],johnjamesjacoby,"Common:
* Audit _is_ functions and make sure they return and filter correctly.
* Add descriptions to phpdoc headers of common files."
changeset,0000005788,[5788],netweb,"Common: Include `bbp_get_pending_status_id()` post status for topic and reply post type cases in `bbp_get_all_child_ids()` and PHPDoc fixes including addition of missing `@since` revision
Props netweb. Fixes #2810
"
changeset,0000006711,[6711],johnjamesjacoby,"Common: add some sanity checks to cache priming helpers.
This change adds more checks to avoid caching post & post author data that may have been deleted since the IDs were last sourced from the database.
We also remove a call to `get_post_field()` to reference the local object directly. This adds an `empty()` but removes a more complex function call when we already have the post in local scope anyways.
Fixes #3166. Props thebrandonallen."
changeset,0000005730,[5730],johnjamesjacoby,"Common: Additional type-casting in query functions.
Ensures direct query results return a consistent, testable value.
Props thebrandonallen, netweb. See #2801."
changeset,0000006700,[6700],johnjamesjacoby,"Common: also prime post author caches.
This change introduces another performance tweak to `bbp_has_topics()`, `bbp_has_forums()`, `bbp_has_search()`, and `bbp_has_replies()`, by pre-cache'ing the post author objects for what is known to be their imminent usage in the current template loops.
This change also renames the function & parameter introduced in r6698 to better fit existing naming conventions in WordPress.
See #3163."
changeset,0000006782,[6782],johnjamesjacoby,"Common: avoid debug notices in `bbp_past_edit_lock()`.
Props SergeyBiryukov. Fixes #3188."
changeset,0000005907,[5907],johnjamesjacoby,"Common: bring `bbp_verify_nonce_request()` up to speed with improvments in BuddyPress.
See #buddypress6528. Props r-a-y."
changeset,0000006673,[6673],johnjamesjacoby,"Common: cast return value to `array` in `bbp_pre_get_posts_normalize_forum_visibility()`.
Trunk, for 2.6. See #3031."
changeset,0000006097,[6097],johnjamesjacoby,"Common: Improve title output strings for friendlier i18n.
Props @SergeyBiryukov. Fixes #2852."
changeset,0000005739,[5739],johnjamesjacoby,"Common: Improve type-casting return values in query functions.
Props thebrandonallen, netweb. See #2801."
changeset,0000006814,[6814],johnjamesjacoby,"Common: introduce `bbp_get_post_types()` and use where appropriate.
Fixes #2769."
changeset,0000006760,[6760],johnjamesjacoby,"Common: introduce `bbp_get_url_scheme()` to simplify 'https' vs 'http' scheme concatenation.
This change improves code flow and reduces complexity by eliminating the number of inline `is_ssl()` checks necessary when URLs are being generated."
changeset,0000006440,[6440],johnjamesjacoby,"Common: introduce `bbp_has_shortcode()` to check if some text contains a bbPress shortcode.
If a shortcode was found in the global post content, a few extra things will happen:
* The `bbp-shortcode` class is added to the `body` tag
* `is_bbpress()` will now return `true`, to help enqueue additional styles & scripts on those pages in themes that want to support bbPress natively
Fixes #2996."
changeset,0000006302,[6302],johnjamesjacoby,"Common: Introduce `bbp_number_not_negative()` and use it in the following ways:
* Register the relevant meta-data keys for posts & users, so updated values can never be invalid
* Filter return values for existing database values that might be invalid on existing installs
* Use in place of `intval()` or `(int)` casts where negative values should not exist
This has the added benefit of introducing the `bbp_register_meta` hook, for future meta-data registrations (of which bbPress has much of.) We'll concentrate on counts for 2.6, and integrate IDs and timestamps in future releases.
See #3059."
changeset,0000005685,[5685],johnjamesjacoby,"Common: Login actions:
* Extract functionality from `bbp_wp_login_action()` into a getter: `bbp_get_wp_login_action()`
* Update arguments in`bbp_get_wp_login_action()` to include optional `url` override
* Pass original `$args` into login action filter
* Also improve support for empty separator in breadcrumbs"
changeset,0000006298,[6298],johnjamesjacoby,Common: Move formatting functions into `formatting.php`.
changeset,0000006299,[6299],johnjamesjacoby,Common: prefer `intval()` over `absint()` for reply IDs in form fields.
changeset,0000006698,[6698],johnjamesjacoby,"Common: prime last-active post caches.
This change introduces a performance tweak to `bbp_has_topics()`, `bbp_has_forums()`, and `bbp_has_search()`, pre-cache'ing the last-active post objects for what is known to be their imminent usage in the current template loops.
See #3163."
changeset,0000006328,[6328],johnjamesjacoby,Common: Remove `nofollow` from tests. See #3067.
changeset,0000006719,[6719],johnjamesjacoby,"Common: remove redundant calls to `bbp_number_not_negative()`.
This change decreases the filter priority of out-of-range prevention from `10` to `8`, and also adds filters to pre-formatted values in lieu of hard-coding this function into each individual count getter. This allows plugins to unplug this check more easily, and makes sure each value is only checked once for each call instead of occasionally twice in a row."
changeset,0000006301,[6301],johnjamesjacoby,"Common: Switch from `absint()` to `intval()` to avoid integer inaccuracies.
See #3059."
changeset,0000006313,[6313],johnjamesjacoby,"Common: Update `bbp_rel_nofollow_callback()` to match latest approach in WordPress.
bbPress continues to have its own version to support this on output vs. pre-save.
Fixes #3067."
changeset,0000005790,[5790],netweb,"Common: Updated PHPDocs for `bbp_get_public_child_ids()`
"
changeset,0000006016,[6016],johnjamesjacoby,"Common: Use `bbp_make_clickable()` in `bbp_make_clickable()`.
In r6014, changes to support faster, better @-mentions mistakenly continued to use `make_clickable()`. This fixes that regression, and allows for smaller chunks of large topics & replies to continue to use bbPress's internally optimized clickable API.
"
changeset,0000005711,[5711],johnjamesjacoby,Common: Use `esc_url()` in `bbp_redirect_to_field()` and late escape for clarity.
changeset,0000006765,[6765],netweb,"Composer: add an end-of-file new line to `composer.json`
"
changeset,0000004204,[4204],bumpbot,Compress scripts/styles: -2.1.2-4204.
changeset,0000004357,[4357],bumpbot,Compress scripts/styles: 2.2-beta1-4357.
changeset,0000004383,[4383],bumpbot,Compress scripts/styles: 2.2-beta2-4383.
changeset,0000004421,[4421],bumpbot,Compress scripts/styles: 2.2-rc2-4421.
changeset,0000004468,[4468],bumpbot,Compress scripts/styles: 2.3-bleeding-4468.
changeset,0000004479,[4479],bumpbot,Compress scripts/styles: 2.3-bleeding-4479.
changeset,0000004514,[4514],bumpbot,Compress scripts/styles: 2.3-bleeding-4514.
changeset,0000004580,[4580],bumpbot,Compress scripts/styles: 2.3-bleeding-4580.
changeset,0000004585,[4585],bumpbot,Compress scripts/styles: 2.3-bleeding-4585.
changeset,0000004612,[4612],bumpbot,Compress scripts/styles: 2.3-bleeding-4612.
changeset,0000004624,[4624],bumpbot,Compress scripts/styles: 2.3-bleeding-4624.
changeset,0000004635,[4635],bumpbot,Compress scripts/styles: 2.3-bleeding-4635.
changeset,0000004650,[4650],bumpbot,Compress scripts/styles: 2.3-bleeding-4650.
changeset,0000004662,[4662],bumpbot,Compress scripts/styles: 2.3-bleeding-4662.
changeset,0000004669,[4669],bumpbot,Compress scripts/styles: 2.3-bleeding-4669.
changeset,0000004993,[4993],bumpbot,Compress scripts/styles: 2.4-alpha-4993.
changeset,0000005003,[5003],bumpbot,Compress scripts/styles: 2.4-alpha-5003.
changeset,0000005008,[5008],bumpbot,Compress scripts/styles: 2.4-alpha-5008.
changeset,0000004945,[4945],bumpbot,Compress scripts/styles: 2.4-alpha-r4900-4945.
changeset,0000005026,[5026],bumpbot,Compress scripts/styles: 2.4-beta1-5026.
changeset,0000005033,[5033],bumpbot,Compress scripts/styles: 2.4-beta1-5033.
changeset,0000003671,[3671],johnjamesjacoby,Consolidate 'template_redirect' actions onto 'bbp_template_redirect' and add a more detailed note about them. Also rename tag 'manage' function to 'edit' to match other components.
changeset,0000004967,[4967],johnjamesjacoby,Consolidate global-access and default role into 1 line-item in forum settings.
changeset,0000003169,[3169],johnjamesjacoby,"Consolidate theme compat functions and add more verbose phpdoc where appropriate. Use template_include filter instead of template_redirect action, and add support for incorrect usage of add_theme_support( 'bbpress' ). See #1524."
changeset,0000003236,[3236],johnjamesjacoby,Consolidate topic form access checks.
changeset,0000005002,[5002],johnjamesjacoby,Constans album spatium. Consistent whitespace handling of foreach usages.
changeset,0000007208,[7208],johnjamesjacoby,"Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of ""duplicate content"" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In branches/2.6, for 2.6.7.
Fixes #3418."
changeset,0000007207,[7207],johnjamesjacoby,"Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of ""duplicate content"" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In trunk, for 2.7.0.
See #3418."
changeset,0000007124,[7124],johnjamesjacoby,"Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In branches/2.6, for 2.6.6.
See #3384."
changeset,0000007125,[7125],johnjamesjacoby,"Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In trunk, for 2.7.
See #3384."
changeset,0000006676,[6676],johnjamesjacoby,"Content: Use correct `tabindex` array key vs. `tab`.
This change corrects a debug notice when the TinyMCE toolbar setting is toggled off.
Trunk, for 2.6. See r6424. Props vinod-dalvi."
changeset,0000003583,[3583],johnjamesjacoby,Contextual help fixes. Fixes #1657. Props duck_
changeset,0000003075,[3075],johnjamesjacoby,"Convert bbp-twentyten into a child theme for twentyten, reducing the size of the plugin file by almost half, eliminating code duplication, and avoiding inadvertently forking the twentyten theme only to support bbPress."
changeset,0000005563,[5563],johnjamesjacoby,"Convert template notices from paragraph tags to unordered lists.
Improves accessibility by hinting there may be several notices on the page.
Props Karl Groves, netweb. FIxes #2637."
changeset,0000005525,[5525],netweb,"Converter import meta data improvements and fixes:
* Original 'old' forum, topic or reply meta data is now explicitly defined using a common `_bbp_old` prefix in the post meta keys that clearly differentiates the new bbPress post meta from the original 'old' forum meta.
* Fixes the ""Purge Previous Import"" optional removal of previously imported forums, topics and replies when using the database sync_table. Meta keys ending with `_id` are now copied to the database sync_table.
See #2650"
changeset,0000005527,[5527],netweb,"Converter import meta data improvements and fixes:
* Original 'old' hierarchical/threaded replies meta key is now defined using `_bbp_old_reply_to_id`
* Fixes the ""Purge Previous Import"" optional removal of previously imported hierarchical/threaded replies when using the database sync_table.
* Updates `Drupal7.php` importer compatibility for the above changes
See #2650"
changeset,0000005530,[5530],netweb,"Converter import user meta data improvements and fixes:
* Original 'old' user meta key is now defined using `_bbp_old_user_id`
* Fixes the ""Purge Previous Import"" optional removal of previously imported users when using the database sync_table.
* Updates all included importers with the above changes including the custom callback in `e107v1.php`
See #2650"
changeset,0000004400,[4400],johnjamesjacoby,"Converter:
* Add '_bbp_old_forum_id' in converter so forums can be easily referenced.
* Update groups-repair to use new 'old forum ID' key.
* Props jmdodd.
* Fixes #2024."
changeset,0000003868,[3868],johnjamesjacoby,"Converter:
* Add counts to bbPress 1.x forum and topic conversions
* Run reply content through callback_html
* See #1820"
changeset,0000003889,[3889],johnjamesjacoby,"Converter:
* Add last active time to topics based on topic_time
* See #1820"
changeset,0000003885,[3885],johnjamesjacoby,"Converter:
* Add total topic and reply counts to bbPress 1.x forum converter
* Fixes issue with forum counts in non-hierarchical forum setups
* See #1820"
changeset,0000003865,[3865],johnjamesjacoby,"Converter:
* Add translate_status method to bbPress 1.x
* Map topic and reply statuses to bbPress 2.x schema
* Passes correct post status so spam/trashed posts are not alive again
* See #1820"
changeset,0000003891,[3891],johnjamesjacoby,"Converter:
* Add user_nicename, user_status, and user_display_name to bbPress 1.x importer
* See #1820"
changeset,0000003890,[3890],johnjamesjacoby,"Converter:
* Add user_topic_count repair function
* Fix incorrect meta key in user_reply_count repair function
* See #1820"
changeset,0000003888,[3888],johnjamesjacoby,"Converter:
* Add wpspin gif to top most conversion feedback
* See #1820"
changeset,0000004007,[4007],johnjamesjacoby,"Converter:
* Call bbconverter_run() inside bbconverter_start() to avoid code duplication."
changeset,0000004141,[4141],johnjamesjacoby,"Converter:
* Call bbp_admin() to create the admin object when converting passwords."
changeset,0000003867,[3867],johnjamesjacoby,"Converter:
* Clean up phpBB field maps
* See #1820"
changeset,0000003869,[3869],johnjamesjacoby,"Converter:
* Decode HTML entities in callback_html method
* Fixes issues with bbPress 0.9 (and any legacy software that stored HTML pre-encoded)
* See #1820"
changeset,0000003894,[3894],johnjamesjacoby,"Converter:
* Filter admin menu for tabbed Tools navigation
* See #1820"
changeset,0000003887,[3887],johnjamesjacoby,"Converter:
* Fix incorrect callback to 'bbp_admin_repair_freshness'
* See #1820"
changeset,0000004086,[4086],johnjamesjacoby,"Converter:
* Fix issue with Invision converter causing replies not to be converted correctly.
* Props netweb.
* Fixes #1892 (2.1 branch)"
changeset,0000004085,[4085],johnjamesjacoby,"Converter:
* Fix issue with Invision converter causing replies not to be converted correctly.
* Props netweb.
* Fixes #1892 (2.2 branch)"
changeset,0000003884,[3884],johnjamesjacoby,"Converter:
* Fix issue with reply titles in bbPress 1.x
* Fix issue with reply topic in bbPress 1.x
* Rename ""Recount"" to ""Repair"" through wp-admin
* Introduce ""Reset Forum"" tool
* See #1820"
changeset,0000003875,[3875],johnjamesjacoby,"Converter:
* Group Forum tools into h2 tabs
* See #1820"
changeset,0000004072,[4072],johnjamesjacoby,"Converter:
* Move convert_pass method into global scope, so passwords are converted anywhere.
* Fixes #1886."
changeset,0000004003,[4003],johnjamesjacoby,"Converter:
* Pinking shears.
* Run $field_list through array_unique() to remove duplicate fields.
* Properly internationalize converter output strings."
changeset,0000004430,[4430],johnjamesjacoby,"Converter:
* Platform options is a string, not an array."
changeset,0000003866,[3866],johnjamesjacoby,"Converter:
* Remane 'translate' methods to 'callback' to avoid confusion with i18n functions
* Improve maps of bbPress 1 converter
* Fix incorrectly named keys in other converters
* Whitespace and phpdoc fixes
* See #1820"
changeset,0000004342,[4342],johnjamesjacoby,"Converter:
* Remove 'bbp-' prefix from parser.php include.
* Props nexia.
* Fixes #2013."
changeset,0000003864,[3864],johnjamesjacoby,"Converter:
* Remove _converter_ from metakey names
* Clean up code in base converter classes
* Converter now partially functional
* See #1820"
changeset,0000003893,[3893],johnjamesjacoby,"Converter:
* Remove commented cruft from bbPress 1.x converter
* Improvements to ajax and spinner
* See #1820"
changeset,0000003886,[3886],johnjamesjacoby,"Converter:
* Remove extra ""Found"" text from converter process
* See #1820"
changeset,0000004000,[4000],johnjamesjacoby,"Converter:
* Remove need for eval() call.
* Code clean-up.
* Type cast POST rows to integer."
changeset,0000003873,[3873],johnjamesjacoby,"Converter:
* Set topic ID for topics
* Add inline doc to convert_table() method
* Tweak bbPress 1.x field mapping
* See #1820"
changeset,0000004047,[4047],johnjamesjacoby,"Converter:
* Stop pre-loading database information in converter.
* Originally to ease testing during 2.1 development.
* Fixes #1879.
* Props Omicron7."
changeset,0000003872,[3872],johnjamesjacoby,"Converter:
* Tabulate the recount and converter menu items
* See #1820"
changeset,0000004090,[4090],johnjamesjacoby,"Converter:
* Tweak bbp_user_maybe_convert_pass() with correct meta key.
* Include missing BBP_Admin() class
* Fixes #1886 (2.1 branch).
* Props netweb, xiosen."
changeset,0000004089,[4089],johnjamesjacoby,"Converter:
* Tweak bbp_user_maybe_convert_password() with correct meta key.
* Include missing BBP_Admin() class
* Fixes #1886 (2.2 branch).
* Props netweb, xiosen."
changeset,0000003876,[3876],johnjamesjacoby,"Converter:
* Tweaks to converter process
* Rename ""Recount"" to ""Repair"" and point everything to it as needed
* Add two new repair tools to recalculate the forum ID and topic ID for each post, based on the post_parent values
* See #1820"
changeset,0000004055,[4055],johnjamesjacoby,"Converter:
* Update verbiage of clean and restart checkboxes.
* Audit usage of sync_table(), and make sure table is created correctly.
* When deleting posts, check correct array items."
changeset,0000003874,[3874],johnjamesjacoby,"Converter:
* Use $_POST rows in process_callback() method so math matches
* See #1820"
changeset,0000004160,[4160],johnjamesjacoby,"Converter:
* Use sanitize_title() instead of sanitize_title_with_slashes().
* Fix issue with character encoding.
* Fixes #1929 for 2.1 branch."
changeset,0000004161,[4161],johnjamesjacoby,"Converter:
* Use sanitize_title() instead of sanitize_title_with_slashes().
* Fix issue with character encoding.
* Fixes #1929 for 2.2 branch."
changeset,0000004008,[4008],johnjamesjacoby,"Converter:
* Use type ""password"" on DB password input field.
* Fixes #1858."
changeset,0000003863,[3863],johnjamesjacoby,"Converter:
* Whitespace fixes to bbPress1 converter
* Fix incorrect fieldname
* See #1820"
changeset,0000006669,[6669],johnjamesjacoby,"Converter: use WordPress smiley URL & path in default `callback_html()` method.
This change makes sure that smiley paths and URLs are correctly converted inside of post content areas. Previous to this, the default `smiley/img.gif` path would be used, resulting in broken smiley images, even after conversion.
Trunk, for 2.6."
changeset,0000006600,[6600],johnjamesjacoby,"Converter: Add `halt` setting for stopping the importer when an error occurs.
Next: implement in Converter."
changeset,0000006788,[6788],johnjamesjacoby,"Converter: add filter to `bbp_new_converter()`.
This change makes it possible to include a custom converter class for the platform being converted from, especially useful if you've changed password storage schemas or want to handle data migration in a way that is specific to your needs.
See #3191."
changeset,0000006763,[6763],johnjamesjacoby,"Converter: add inline documentation for `wp_insert_user()`.
This change adds an inline reminder about what `wp_insert_user()` does internally, so our future selves know at a glance why else a user might be skipped."
changeset,0000006631,[6631],johnjamesjacoby,"Converter: Add missing `_bbp_converter_convert_users` option key.
Prevents debug notices when also converting user accounts from other platforms."
changeset,0000006677,[6677],johnjamesjacoby,"Converter: Add toggle to show/hide the database password contents.
This change provides a relatively sane middle-ground for insecure content warnings in the converter, by providing a button to toggle the `password` field back and forth to a `text` field. Ideally, in the future, there will be a legitimate way to do this.
Trunk, for 2.6. See #3153."
changeset,0000006662,[6662],johnjamesjacoby,"Converter: bind number-of-rows attribute to between 1 and 5000.
This change adds validation to ensure no unexpected number of database rows are queried, and also back-ports sanitization to database connection values from trunk.
2.5 branch, for 2.5.14. Props jrf. Fixes #3148."
changeset,0000006661,[6661],johnjamesjacoby,"Converter: bind number-of-rows attribute to between 1 and 5000.
This change adds validation to ensure no unexpected number of database rows are queried.
Trunk, for 2.6. Props jrf. See #3148."
changeset,0000006789,[6789],johnjamesjacoby,"Converter: Call `bbp_setup_converter()` inside of `bbp_user_maybe_convert_pass()`.
This change makes sure the admin-area converter files are included and instantiated from anywhere a user might be logging in from. This fixes a potential fatal error when trying to convert user passwords from old platforms to WordPress after a successful forum conversion has completed.
Fixes #3191."
changeset,0000006658,[6658],SergeyBiryukov,"Converter: Clarify `status_counting` label in Import Monitor.
Props jrf.
Fixes #3147."
changeset,0000006632,[6632],johnjamesjacoby,"Converter: Clean user cache when converting a user's password field.
This makes sure the user object is pristine on the subsequent request to it, fixing possible race conditions with authentication errors."
changeset,0000006460,[6460],johnjamesjacoby,"Converter: Code improvements
* Add ""Skip"" text for steps that are being skipped
* Allow bypassing of importer halting on error
* Update a few strings
* Break some code from `process_callback()` method out into separate private methods"
changeset,0000006184,[6184],johnjamesjacoby,"Converter: Convert favorites & subscriptions to `postmeta` vs. `usermeta`.
* Update table names
* Support for comma-separated string values
* Use strict comparisons where it makes sense to
See #2959, #2668."
changeset,0000006599,[6599],johnjamesjacoby,Converter: Default values to `0` so converter starts correctly.
changeset,0000006635,[6635],johnjamesjacoby,"Converter: Don't use `delete_option()` on converter options.
Default option filters are breaking `update_option()` return values when options do not exist, so remove this optimization and save it for when a conversion is completed.
This needs more looking into."
changeset,0000006663,[6663],johnjamesjacoby,"Converter: ensure UI state variables are correctly localized.
This change combines the new UI state variables into an array, so they retain their type-casting through the localization API. It also inverts the logic in 1 comparison to make sure the correct user feedback is displayed in its intended location.
Trunk, for 2.6. Props jrf. Fixes #3146."
changeset,0000006650,[6650],SergeyBiryukov,"Converter: Fix typo and improve wording of Database Settings section labels.
Props jrf.
Fixes #3143."
changeset,0000006195,[6195],netweb,"Converter: Give `!` usages some breathing room.
"
changeset,0000006679,[6679],johnjamesjacoby,"Converter: Improve `clean` logic when checking for deleted activity.
This change fixes a condition where meta-data is out-of-sync with posts or users, resulting in a false assignment of `true` when there actually is no data to delete, and no data has been deleted. Now when this happens, the converter will proceed as intended.
Trunk, for 2.6."
changeset,0000006458,[6458],johnjamesjacoby,Converter: Improve error responses and UX when converter halts.
changeset,0000007246,[7246],johnjamesjacoby,"Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In branches/2.6, for 2.6.10.
See #3419."
changeset,0000007245,[7245],johnjamesjacoby,"Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In trunk, for 2.7.0.
See #3419."
changeset,0000006448,[6448],johnjamesjacoby,"Converter: Introduce `bbp_get_converters()` to DRY the directory crawling code.
Also allows converters to be filtered, should someone want to include their own in a plugin.
See #3095."
changeset,0000006638,[6638],johnjamesjacoby,"Converter: Introduce `update_query()` method, to help with updating the last query option.
This abstracts the `update_option()` approach for future scrutiny."
changeset,0000006832,[6832],johnjamesjacoby,"Converter: make a few `private` properties `protected` so subclasses can reach them.
This change fixes a bug causing the e107v1 converter to fail.
Props wpdennis. Fixes #3207."
changeset,0000006640,[6640],johnjamesjacoby,"Converter: Make it all work again!
* Send a response when a step is complete (to trigger the subsequent step)
* Remove `min` class variable, and use `start` everywhere instead
* Move giant step switch into a `steps` array instead (a lot more can be done here later)
* Break apart a few private methods to make the call stack easier to follow
* Store the `platform` for use in inherited objects later
This commit makes the converter work again, tested against a few large database dumps from several platforms to confirm."
changeset,0000006457,[6457],johnjamesjacoby,"Converter: Make sure the sync-table has a chance to be made on first run when not cleaning.
Also default `$start` values to `1` in the event some empty value is erroneously passed through."
changeset,0000006670,[6670],johnjamesjacoby,"Converter: more OOP, specifically for the BBCode parser.
This change introduces a `bbcode_parser_properties` array to the base converter, allowing custom BBCode parser properties to be passed into the parent method via the child, minimizing the amount of code in each individual forum converter.
Trunk, for 2.6."
changeset,0000006459,[6459],johnjamesjacoby,"Converter: More stylistic improvements
* Use ""Import Monitor"" metabox vs. old ugly plain yellow `div`
* Improve messaging around existing/incomplete import status/query/steps
* `17` total steps is kind-of a bad guess, but better than nothing
* Likely more can be done here in 2.7 as this matures in the public eye"
changeset,0000006456,[6456],johnjamesjacoby,"Converter: Multiple converter improvements
* Move classes into their own files
* Move `converter.php` into `/admin/tools/`
* Escape output of translated strings where possible
* Introduce `bbp_converter_db_connection_failed` error handler, in the event the origin database connection cannot be established
* Sets `WP_SETUP_CONFIG` constant to `true` to control `$wpdb->db_connect()` bail from using `db-error.php`
* Use `sanitize_text_field()` on database connection values
* Invisibly default to `DB_` constants if database connection values are empty
* introduce `convert_users` class parameter to limit direct touches to `$_POST` value
* Smarter defaults for converter options"
changeset,0000006514,[6514],johnjamesjacoby,"Converter: Port changes proposed for 2.7 in for 2.6:
* Add a timer UI to show the count down until the next step
* Move converter settings into the normal options & settings arrays
* Update fields, sections, & pages as needed
* Update `converter.js` version to use `bbp_get_version()`
* Make connection & options persistent across requests whenever possible, and trust the settings if settings change
* Split steps up into private methods, out of the massive `do_steps()` method"
changeset,0000006681,[6681],johnjamesjacoby,"Converter: progress bars and percentages.
This change incorporates 2 horizontal bars in the importer header area. One indicates how far the current step has progressed, and the other indicates total progress. Pretty sweet.
Trunk, for 2.6."
changeset,0000006666,[6666],johnjamesjacoby,"Converter: reduce `meta_key` and `meta_value` length to `75`.
This change lowers the maximum allowed string length from `191` (which was used based on what's in WordPress core.) After further review, `75` is a reasonable maximum to try for now, though it could likely be tuned further if needed.
Trunk, for 2.6. Fixes #3145."
changeset,0000006447,[6447],johnjamesjacoby,"Converter: Refresh to registered settings
* `ksort()` the Platform list, and exclude ""Example"" since it's not usable
* Turn some `text` fields into `number` fields, with reasonable boundaries
* Add `code` classes to database fields
* Update some labels & descriptions
Fixes #3095."
changeset,0000007243,[7243],johnjamesjacoby,"Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In branches/2.6, for 2.6.10.
Props sirlouen. Fixes #3419."
changeset,0000007244,[7244],johnjamesjacoby,"Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In trunk, for 2.7.0.
Props sirlouen. Fixes #3419."
changeset,0000006820,[6820],johnjamesjacoby,"Converter: remove `safe_mode` check from `BBP_Converter::maybe_set_memory()`.
This was deprecated in PHP 5.3.0 and removed in 5.4.0. Instead, this change employs the following:
* Moves keys and values into a filterable array
* Looks for disabled functions and avoids them
* Adds error control operators as needed
"
changeset,0000006785,[6785],johnjamesjacoby,"Converter: remove `WP_SETUP_CONFIG` constant setting from converter process.
This introduces a helper database class to avoid directly connecting to the external database. Instead, we'll attempt to control that connection, and provide feedback to the user in the event a connection cannot be made. The `WP_SETUP_CONFIG` was causing calls to the options API to fail, resulting in broken calculations and invalid offsets.
This commit includes some general load order clean-up, which also fixes a regression causing fatal errors when attempting to upgrade converted user passwords from the old platform. It also fixes the condition where boundaries being converted would display beyond their maximums.
Fixes #3191."
changeset,0000006716,[6716],johnjamesjacoby,Converter: Remove duplicate `class` attribute on DB password field.
changeset,0000006833,[6833],johnjamesjacoby,"Converter: Remove unused argument in `clean()` method usage.
See #3207."
changeset,0000006130,[6130],johnjamesjacoby,"Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (2.5 branch, for 2.5.12)"
changeset,0000006129,[6129],johnjamesjacoby,"Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (Trunk, for 2.6)"
changeset,0000006671,[6671],johnjamesjacoby,"Converter: softer verbiage on the importer buttons.
This changes ""Stop"" to ""Pause"" and ""Continue"" to ""Resume"". This more accurately represents the actions these buttons perform, while also inspiring a bit more confidence that the converter can be halted and resumed at anytime.
Trunk, for 2.6."
changeset,0000006472,[6472],johnjamesjacoby,"Converter: Styling updates
* Move all admin CSS & JS into `/admin/assets/`
* Introduce `converter.js` and refactor code out of `admin_head()` method
* Move converter styling into `common.css`
* Update some surrounding styling, verbiage, and mark-up to better handle errors and user feedback"
changeset,0000006471,[6471],johnjamesjacoby,"Converter: Styling updates
* Move all admin CSS & JS into `/admin/assets/`
* Introduce `converter.js` and refactor code out of `admin_head()` method
* Move converter styling into `common.css`
* Update some surrounding styling, verbiage, and mark-up to better handle errors and user feedback"
changeset,0000006634,[6634],johnjamesjacoby,Converter: Tweak description of `restart` setting to better hint at what it does.
changeset,0000006636,[6636],johnjamesjacoby,"Converter: Update `bbp_converter_status()` to use current step.
When actually converting data, this step is only bumped when moving between major events, not minors."
changeset,0000006809,[6809],johnjamesjacoby,"Converter: update phpBB importer to use `user_form_salt`.
Props jrf. Fixes #3192."
changeset,0000006491,[6491],johnjamesjacoby,"Converter: Update some strings for improved clarity.
When a conversion is stopped, and later resumed, make sure the steps and verbiage are clear.
Also switch from ""Completed"" to ""Finished"" since it's likely some repair steps are still necessary, and the conversion isn't technically ""complete"" until those are done too."
changeset,0000006678,[6678],johnjamesjacoby,"Converter: Update the options labels and descriptions.
This change should bring increased clarity to what the converter options are for.
Trunk, for 2.6."
changeset,0000006665,[6665],johnjamesjacoby,"Converter: use `esc_like()` to avoid debug notice when cleaning users.
This change runs the `_bbp_` `meta_key` prefix through `esc_like()`, ensuring that the subsequent `prepare()` call has a value passed into it.
Trunk, for 2.6."
changeset,0000006639,[6639],johnjamesjacoby,"Converter: Use `false` as the default value for some options.
This ensures that `default_option_` values are still overloadable when converting."
changeset,0000006633,[6633],johnjamesjacoby,"Converter: Use error control operator on `Internal_UpdateParamsForMissingEndTag()`
Avoids polluting the php error logs if position is not byref."
changeset,0000006490,[6490],johnjamesjacoby,"Converter: Use the port number in the server address if available.
Fixes #3022."
changeset,0000006834,[6834],johnjamesjacoby,"Converter: UX improvements to import experience:
* Move Monitor to upper-right
* Move actions into Monitor
* Make database fields read-only when importer is running
* Add a spinner
See #3207 for inspiration.
"
changeset,0000004119,[4119],johnjamesjacoby,"Converters:
* Classes are case sensitive when being loaded by the main converter.
* Fixes #1886.
* For 2.1 branch.
* Props netweb."
changeset,0000004101,[4101],johnjamesjacoby,"Converters:
* Classes are case sensitive when being loaded by the main converter.
* Fixes #1886.
* Props netweb."
changeset,0000004102,[4102],johnjamesjacoby,"Converters:
* Revert whitespace changes in r4101.
* See #1886.
* Antiprops netweb."
changeset,0000006449,[6449],johnjamesjacoby,Converters: Fix formatting on several converter methods.
changeset,0000006293,[6293],netweb,"Converters: Fix PHPDoc indentation in `Invision.php`
"
changeset,0000007014,[7014],johnjamesjacoby,"Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.6.3, branches/2.6."
changeset,0000007015,[7015],johnjamesjacoby,"Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.7, trunk."
changeset,0000006476,[6476],johnjamesjacoby,"Converters: Port r5332 to 2.5 branch.
See #2558, #3112."
changeset,0000004201,[4201],johnjamesjacoby,"Copy /branches/plugin/ to /trunk/
"
changeset,0000002470,[2470],johnjamesjacoby,Copy paste owns me.
changeset,0000004209,[4209],johnjamesjacoby,"Core Functions:
* Simplify logic in bbp_has_errors()."
changeset,0000003899,[3899],johnjamesjacoby,"Core:
* Add new bbp-core-functions.php file to bbp-includes.
* Move functions out of bbp-common-functions.php and into bbp-core-functions.php and bbp-topic-template.php.
* Paves way for bbPress function map API."
changeset,0000006672,[6672],johnjamesjacoby,"Core: Add `source` parameter to API registrations.
This change makes it easier to target bbPress-specific post types & statuses, and taxonomies. `source` may not be the final key, but thankfully all of these APIs accept additional keys, and if support is added to core eventually, we can easily migrate over to it without problems.
Trunk, for 2.6. See: https://core.trac.wordpress.org/ticket/41739"
changeset,0000006329,[6329],johnjamesjacoby,Core: Allow custom post authors for initial content (forum/topic/reply).
changeset,0000005736,[5736],johnjamesjacoby,Core: Correct phpdoc to `_update_` functions. Also introduce `bbp_update_reply_to_id()` to help with saving of hierarchical reply metadata. (Will be used in a future commit.)
changeset,0000005733,[5733],johnjamesjacoby,"Core: Force-clear post caches on several common moderation actions.
Fixes inconsistencies around cached objects related to counts, which are currently stored in metadata.
Props thebrandonallen, netweb. See #2801."
changeset,0000006353,[6353],johnjamesjacoby,"Core: General core function clean-up.
Mostly odds & ends, formatting, type-casting, etc...
"
changeset,0000006039,[6039],johnjamesjacoby,Core: pass the original text into `bbp_make_clickable` filter.
changeset,0000006531,[6531],johnjamesjacoby,"Core: Register, then enqueue, both scripts and styles.
This commit makes sure that theme compatibility styles & scripts are properly registered & enqueued.
Props r-a-y. Fixes #3115."
changeset,0000005945,[5945],netweb,"Core: Restore empty `$wp_filter[ $tag ]` check and update PHPDoc in `bbp_get_template_stack()`
See #2871
"
changeset,0000005735,[5735],johnjamesjacoby,"Core: Return the filtered results of ID's in core `_update_` functions.
This helps with various type-casting improvements going into #2801."
changeset,0000006058,[6058],johnjamesjacoby,Core: Revert accidental removal of r6054 from r6056.
changeset,0000005944,[5944],netweb,"Core: Support for `WP_Hook` in `bbp_get_template_stack()`
The proposed `WP_Hook` #WP17817 breaks backward compatibility for plugins that
attempt to manipulate `$wp_filter` in certain ways. For bbPress, it means
that we cannot directly modify the callbacks that are currently registered as
an array at `$wp_filter[ $tag ]`, in `bbp_get_template_stack()`. Instead, when
`WP_Hook` is not available, we assign the callbacks to a variable (leveraging
`WP_Hook`'s `ArrayAccess`) and manipulate the variable.
Props jbrinley. Fixes #2871
"
changeset,0000006183,[6183],johnjamesjacoby,"Core: Upgrade routine for favorites & subscriptions in 2.6.0.
* Use the new upgrade tools
* Bump the DB version to `260`
* Improve inline docs in upgrade tool functions
See #2959."
changeset,0000004802,[4802],johnjamesjacoby,Correct /users/template-tags.php inline doc typo. Props netweb. Fixes #2251.
changeset,0000002738,[2738],johnjamesjacoby,Correct @since docs
changeset,0000002554,[2554],johnjamesjacoby,Correct @since's
changeset,0000005410,[5410],johnjamesjacoby,Correct `bbp_stuck_topic` phpdoc. See #2494.
changeset,0000002797,[2797],johnjamesjacoby,"Correct cap on Add User admin menu, and add cap check to submenus. Fixes #1368"
changeset,0000004801,[4801],johnjamesjacoby,Correct closing HTML tag helper doc in content-single-topic-lead.php Props netweb. Fixes #2252.
changeset,0000003616,[3616],johnjamesjacoby,Correct core languages path in bbp-languages/index.php
changeset,0000004794,[4794],johnjamesjacoby,Correct file description in content-statistics.php. Props alexvorn2. Fixes #2247.
changeset,0000002475,[2475],chrishajer,"Correct function name and add information to cookies for anonymous posting. Fixes #1311. Props !GautamGupta
"
changeset,0000005474,[5474],johnjamesjacoby,Correct inline doc in `bbp_forum_get_subforums()`.
changeset,0000004907,[4907],johnjamesjacoby,"Correct the error ID's used when posting a new reply if the forum is closed, private, or hidden, and the user does not have proper capabilities. (2.3 branch)"
changeset,0000004904,[4904],johnjamesjacoby,"Correct the error ID's used when posting a new topic if the forum is closed, private, or hidden, and the user does not have proper capabilities. (2.3 branch)"
changeset,0000004903,[4903],johnjamesjacoby,"Correct the error ID's used when posting a new topic if the forum is closed, private, or hidden, and the user does not have proper capabilities. (trunk)"
changeset,0000004936,[4936],johnjamesjacoby,Correct typo that snuck in after testing. See #1500.
changeset,0000006319,[6319],johnjamesjacoby,Correct typos in User Template phpdoc blocks.
changeset,0000002803,[2803],johnjamesjacoby,Correctly check for WP_Error and correctly load anonymous user cookie data/avatar. Fixes #1452. Props !GautamGupta
changeset,0000005404,[5404],johnjamesjacoby,"Correctly compare source & destination topic `post_date` values in `bbp_merge_topic_handler()`. Fixes issue where incorrect post would be updated when merging older topics into newer ones.
Also update the reply position for all newly relocated replies. Hat-tip netweb. Fixes #2528."
changeset,0000003844,[3844],johnjamesjacoby,Correctly show sticky topics when viewing a topic archive or using a topic archive shortcode.
changeset,0000006923,[6923],johnjamesjacoby,"Counts (meta-data): full audit of forum/topic/reply, public/non-public counts.
This commit is the result of a full count audit, exposing multiple inconsistencies and voids in relation to how public and non-public counts are (re)calculated.
For instance, hidden forum replies are not counted at all, until now. By introducing a new Repair tool, hidden forum reply counts are now counted.
In addition, there were multiple bugs with topic & reply moderation, where the act of approving or unapproving topics or replies would cause the numbers to be inaccurate, or where topics & replies being caught in moderation were still increasing public counts.
It was also possible to, as a Key Master, publicly reply to unapproved topics, which was a completely unanticipated side-effect of allowing Key Masters to do pretty much anything. Going forward, the default reply status is the topic status, but is still beholden to all existing moderation settings and user role capabilities. This results in a more sane user experience, and prevents the unusual circumstance of there being ""0 topics and 30 replies"" in public-facing forums.
Certain count increase/decrease actions have been reprioritized to avoid collisions and race conditions, proving once again that ya gotta get up to get down.
See #2838. Fixes #1799.
"
changeset,0000006610,[6610],SergeyBiryukov,"Counts: Fix typo in DB query in `bbp_get_user_reply_count_raw()`.
See #3124."
changeset,0000006827,[6827],johnjamesjacoby,"Counts: Introduce a cacheable parent/type/status wrapper, filter helpers.
This change introduces a common query function for totalling up all counts by type & status, and caching the results for later usages. By doing this, we can avoid running multiple queries for the same public or non-public counts.
Also uses `bbp_number_not_negative()` in a few places where negative counts are never allowed.
"
changeset,0000006792,[6792],johnjamesjacoby,"Counts: introduce sub-action for post status transitions.
We'll use this for micro-managing child post counts on a per-type, per-status basis.
See #1799."
changeset,0000006609,[6609],johnjamesjacoby,"Counts: Remove `count_user_posts()` usages, and always return an `int`.
User topic & reply counts haven't included `closed` status for topics, and these wrappers should include support for things like `view=all` later.
Fixes #3124.
"
changeset,0000004520,[4520],johnjamesjacoby,"Create 1.2 branch:
* Uses correct BackPress/pomo externals
* See #1857.
"
changeset,0000003537,[3537],johnjamesjacoby,Create 2.0 branch
changeset,0000004076,[4076],johnjamesjacoby,Create 2.1 branch.
changeset,0000004442,[4442],johnjamesjacoby,Create 2.2 branch.
changeset,0000004850,[4850],johnjamesjacoby,Create 2.3 branch.
changeset,0000005098,[5098],johnjamesjacoby,Create 2.4 branch from trunk.
changeset,0000005202,[5202],johnjamesjacoby,Create 2.5 branch.
changeset,0000006939,[6939],johnjamesjacoby,"Create 2.6 branch (from trunk)
"
changeset,0000003526,[3526],johnjamesjacoby,Create bbPress 1.1 Branch.
changeset,0000005818,[5818],netweb,Create tag 2.5.8.
changeset,0000004385,[4385],johnjamesjacoby,"Credits:
* Clean up copy pasta.
* Props jmdodd.
* See #2018."
changeset,0000004384,[4384],johnjamesjacoby,"Credits:
* Hardcode some credits for a first pass for 2.2.
* Will want to use api.wordpress.org eventually.
* Fixes #2018."
changeset,0000004459,[4459],johnjamesjacoby,"Credits:
* Update incorrect link.
* Fixes #2044 (2.2 branch)"
changeset,0000004458,[4458],johnjamesjacoby,"Credits:
* Update incorrect link.
* Fixes #2044 (trunk)"
changeset,0000006395,[6395],johnjamesjacoby,"Credits: Add ""Project Emeriti"" section, and add Sergey & Brandon as Contributing Developers.
Also update the tagline."
changeset,0000006394,[6394],johnjamesjacoby,"Credits: Remove superfluous `alt` text for project leaders and contributors.
Props mercime. Fixes #3099."
changeset,0000005952,[5952],netweb,"Credits: Update H4 to H3
This changeset improves accessibility and brings bbPress' credits area headers up to par with WordPress 4.4.
Fixes #2890. See #WP34263.
"
changeset,0000003785,[3785],johnjamesjacoby,"CSS class changes
* Add user-id and topic-author to reply class
* Add user-id to topic class
* Run reply classes through array_filter()
* Fixes #1763
* Props jaredatch"
changeset,0000006744,[6744],johnjamesjacoby,CSS cleanup from r6743.
changeset,0000003635,[3635],johnjamesjacoby,CSS tweaks after moving to tableless layout.
changeset,0000005652,[5652],netweb,"CSS: Include relevant topic and search CSS classes alongside existing reply responsive media queries for mobile search results.
Props netweb. Fixes #2486
"
changeset,0000005452,[5452],netweb,"DB schema change for `wp_bbconverter_translator` converter sync table
* Increase `meta_key` maximum characters from 25 o 255 to allow for longer meta keys during import
See #2650"
changeset,0000005543,[5543],netweb,"DB schema change for `wp_bbconverter_translator` converter sync table
* Increase `meta_value` maximum characters from 25 o 255 to allow for longer meta values during import
See #2650"
changeset,0000005401,[5401],johnjamesjacoby,"De-deprecate `bbp_remove_roles()` and use it in: `bbp_admin_reset_handler()`, bbp_do_uninstall()`, and `bbp_version_updater()`. Fixes bug where old bbPress role data could still exist in `wp_user_roles`. See #2065. Fixes #2580."
changeset,0000005057,[5057],johnjamesjacoby,De-deprecate bbp_remove_roles() so database role removal is still supported.
changeset,0000004154,[4154],johnjamesjacoby,"Deactivation:
* Introduce bbp-core-dependency.php and move plugin dependency actions and filters into it.
* Switch load order to remove possible debug notices on deactivation.
* Only load -core- files on deactivation; the others are not needed at that time."
changeset,0000003797,[3797],johnjamesjacoby,"Decode $post_content for wp_editor in bbp_get_the_content(). Fixes #1770. Props alexvorn2, props jaredatch."
changeset,0000004697,[4697],johnjamesjacoby,Decode blogname in notification emails. Props netweb. Fixes #2172.
changeset,0000002792,[2792],johnjamesjacoby,Decode special characters when editing topics/posts [0.9 branch]
changeset,0000003390,[3390],johnjamesjacoby,Decomplicate bbPress includes procedure. Fixes #1570. Props andy.
changeset,0000002914,[2914],johnjamesjacoby,"Decouple bbp_is_ functionality from bbp_get_{post_type}_id functionality, and use correctly through-out. Add ability to show all forums regardless of post_parent, and fix forums widget to use this functionality correctly."
changeset,0000005487,[5487],johnjamesjacoby,Dedicated filters to allow manipulating of users who will receive subscription emails. Hat tip roysmyth. Fixes #2627.
changeset,0000002826,[2826],johnjamesjacoby,Deemphasize the admin links when viewing a single topic.
changeset,0000002910,[2910],johnjamesjacoby,Default $meta_value to null in bb_delete_usermeta() to play nicely with BackPress WP_User::delete_meta(). Props mdawaffe.
changeset,0000003947,[3947],johnjamesjacoby,"Default Options:
* Clean up bbp_get_default_options() to make it easier to read."
changeset,0000003861,[3861],johnjamesjacoby,"Default show_role to false, and override to true when needed, for backwards compatibility. See #1815."
changeset,0000006969,[6969],johnjamesjacoby,"Default Styling: Optionally support an RTL variant of bbpress.css.
This commit allows for either/or `bbpress.css` or `bbpress-rtl.css` to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.
This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.
Props scmsteve for persistence. Fixes #3218. For 2.6.2, branches/2.6."
changeset,0000006968,[6968],johnjamesjacoby,"Default Styling: Optionally support an RTL variant of bbpress.css.
This commit allows for either/or `bbpress.css` or `bbpress-rtl.css` to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.
This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.
Props scmsteve for persistence. Fixes #3218. For 2.7, trunk."
changeset,0000002542,[2542],johnjamesjacoby,Default to current forum. Cast return ID's as integers.
changeset,0000003412,[3412],johnjamesjacoby,Default to the current user ID in bbp_is_user_deleted()
changeset,0000003594,[3594],johnjamesjacoby,Define local variables in bbpress.php to prevent strict notices.
changeset,0000006825,[6825],xknown,"Define the `BB_URI_CONTEXT_BB_INSTALLER` constant to avoid PHP warnings.
"
changeset,0000003639,[3639],johnjamesjacoby,Delete '_bbp_last_active_time' key from postmeta when doing freshness recalculation. (2.1)
changeset,0000003640,[3640],johnjamesjacoby,Delete '_bbp_last_active_time' key from postmeta when doing freshness recalculation. Props lillelykke. (2.0 branch)
changeset,0000004200,[4200],johnjamesjacoby,"Delete /trunk so /branches/plugin/ can be copied into it.
"
changeset,0000003534,[3534],johnjamesjacoby,Delete 0.9.0.7 tag (added instead of copied)
changeset,0000003529,[3529],johnjamesjacoby,Delete 1.1 branch (added instead of copied)
changeset,0000003528,[3528],johnjamesjacoby,Delete 1.1 tag (added instead of copied)
changeset,0000004897,[4897],johnjamesjacoby,Delete the correct 'bbpress_users' cache group for subscriptions and favorites. See #2331.
changeset,0000005411,[5411],johnjamesjacoby,Delete trashed and spam topic-meta when performing untrash or unspam actions. Hat tip netweb. See #2494.
changeset,0000004524,[4524],johnjamesjacoby,"Deleting:
* When deleting a forum or topic, make sure all child content is deleted also.
* Also add some inline doc, and unset query variables, and clean up messy inline comparisons.
* Props MZAWeb.
* Fixes #2059."
changeset,0000007075,[7075],johnjamesjacoby,"Dependencies: routine updating of node dependency tree.
"
changeset,0000007074,[7074],johnjamesjacoby,"Dependencies: routine updating of node dependency tree.
"
changeset,0000005413,[5413],johnjamesjacoby,"Deprecate `bbp_notify_subscribers()` for new `bbp_notify_topic_subscribers()` function, to better match `bbp_notify_forum_subscribers()` introduced in 2.5."
changeset,0000005561,[5561],johnjamesjacoby,Deprecate `tabindex` functions and their usages. Props joedolson. Fixes #2714.
changeset,0000005268,[5268],johnjamesjacoby,"Deprecate dashboard metabox, and append forum statistics to existing ""At a Glance"" metabox instead. Fixes #2544."
changeset,0000004874,[4874],johnjamesjacoby,Deprecate the 'bbp_get_the_body_class' filter in bbp_body_class(). Fixes #2316 (2.3 branch)
changeset,0000004873,[4873],johnjamesjacoby,Deprecate the 'bbp_get_the_body_class' filter in bbp_body_class(). Fixes #2316 (trunk)
changeset,0000002804,[2804],johnjamesjacoby,Disallow uncapable users from creating topics in closed forums. Fixes #1452. Props !GautamGupta
changeset,0000004679,[4679],johnjamesjacoby,"Display Names:
* Add seems_utf8() checks to topic and reply display names.
* Improve handling of display name link title text. This is a regression from removing extract() usages.
* Fixes #2141."
changeset,0000004846,[4846],johnjamesjacoby,"Do a reverse unslashing juke-move when checking topics and replies for duplicates. Even though wp_magic_quotes() may have slashed some things for us, this allows us to properly prepare the query and it's parts with accurately unslashed data. This is mostly to compensate for plugins that may intercept globals or filter query parameters on the fly (like BuddyPress @ mentions.)
See #2185, [WP23973]"
changeset,0000005079,[5079],johnjamesjacoby,Do not allow forum/topic/reply author to edit their own replies via wp-admin. Fixes #2389.
changeset,0000002745,[2745],johnjamesjacoby,Do not allow trash-to-spam or spam-to-trash status changes; prevents issues with rogue topics/replies.
changeset,0000002801,[2801],johnjamesjacoby,Do not attempt to translate an empty string. Fixes #1420
changeset,0000003711,[3711],johnjamesjacoby,"Do not bail early in bbp_is_user_subscribed() or bbp_is_user_favorite(), thus allowing them to be properly filtered."
changeset,0000003557,[3557],johnjamesjacoby,Do not check is_rtl() for breadcrumb separator direction. See #1653.
changeset,0000003396,[3396],johnjamesjacoby,Do not create BuddyPress activity stream entries for public or hidden forums.
changeset,0000004661,[4661],johnjamesjacoby,"Do not directly call BBP_Forums_Component::setup_nav(), as it causes the current_user to be loaded prematurely due to is_user_logged_in() calls."
changeset,0000005034,[5034],johnjamesjacoby,Do not echo _get_ functions. Output clean-up for future work on #2367.
changeset,0000003093,[3093],johnjamesjacoby,Do not enqueue topic.js for theme compat as it requires jQuery be loaded for all themes (topic subscriptions and favorites degrade gracefully)
changeset,0000002973,[2973],johnjamesjacoby,Do not include $wp_rewrite->front in user profile url. Fixes #1489.
changeset,0000002534,[2534],johnjamesjacoby,Do not link anonymous posters in admin posts area.
changeset,0000002913,[2913],johnjamesjacoby,Do not load forums-loop template part if there are no subforums to show.
changeset,0000002539,[2539],mdawaffe,Do not localize times in feeds: restore [2132]. Fixes #1092. See #1280.
changeset,0000004832,[4832],johnjamesjacoby,Do not prepare() query in bbp_check_for_duplicate() -- 'post_content' is already slashed/escaped in wp_magic_quotes(). Refixes #2185 for trunk/2.3.
changeset,0000003556,[3556],johnjamesjacoby,Do not reverse the breadcrumb order when RTL. Fixes #1653.
changeset,0000003477,[3477],johnjamesjacoby,Do not setup BuddyPress if in maintenance mode. Fixes #1619.
changeset,0000003342,[3342],johnjamesjacoby,Do not show lead topic twice if no replies are found in single topic shortcode.
changeset,0000002773,[2773],johnjamesjacoby,Do not show title or widget HTML if there is nothing to display.
changeset,0000004842,[4842],johnjamesjacoby,Do not show topic tags in navigation menus.
changeset,0000003656,[3656],johnjamesjacoby,Do not stomp the $redirect_to variable in bbp_redirect_to_field(). Props mesayre. Fixes #1709.
changeset,0000003703,[3703],johnjamesjacoby,"Do not unset $post global in bbp_replace_the_content(). This is no longer needed, and has the potential to cause more harm than good, as many plugins and themes expect the $post global to exist after the loop has completed, even on ""fake"" paged like bbPress's."
changeset,0000004577,[4577],johnjamesjacoby,Do not use hashes in tabfocus_elements array values. See #1917.
changeset,0000006924,[6924],johnjamesjacoby,"Docs: add missing project names after recently added @since's.
"
changeset,0000006971,[6971],johnjamesjacoby,Docs: add note to `bbp_get_excluded_forum_ids()` about per-forum moderators.
changeset,0000007169,[7169],johnjamesjacoby,"Docs: correct ""arrap"" to ""array"".
In branches/2.6 for 2.6.6. See #3389."
changeset,0000007170,[7170],johnjamesjacoby,"Docs: correct ""arrap"" to ""array"".
In trunk for 2.7.0. See #3389."
changeset,0000006899,[6899],SergeyBiryukov,Docs: Correct description for `_bbp_topics_per_page` setting.
changeset,0000006900,[6900],netweb,"Docs: Correct descriptions for various admin settings.
"
changeset,0000006291,[6291],netweb,"Docs: Fix typo in `bbPress::*_query::have_posts()` PHPDoc `@uses` references.
Props SergeyBiryukov.
Fixes #3061.
"
changeset,0000006856,[6856],johnjamesjacoby,"Docs: fix typo, and update function reference for `_blacklist()` deprecation.
See r6855, #3215.
"
changeset,0000007238,[7238],johnjamesjacoby,"Docs: remove some PHP docs that don't make sense.
For 2.6.10.
"
changeset,0000007240,[7240],johnjamesjacoby,"Docs: remove some PHP docs that don't make sense.
For 2.7.
"
changeset,0000007239,[7239],johnjamesjacoby,"Docs: remove some PHP docs that don't make sense.
For 2.7.
"
changeset,0000006560,[6560],johnjamesjacoby,"Docs: Update inline documentation of `bbp_get_global_object()`.
The conditions in this function do not result in an early return, so remove ""Bail"" references."
changeset,0000006642,[6642],johnjamesjacoby,"Docs: update the description of `bbp_get_default_role()`.
Fixes #3131."
changeset,0000004040,[4040],johnjamesjacoby,"Documentation
* Fix out of date phpdoc for bbp_get_reply_position()."
changeset,0000002836,[2836],johnjamesjacoby,Documentation for new sticky topic code.
changeset,0000006498,[6498],johnjamesjacoby,"Documentation: Don't hyphenate ""bbPress's""
It's cute, and I tend to say it in person to be cute, but in writing it doesn't look very classy."
changeset,0000006526,[6526],johnjamesjacoby,"Documentation: Don't use `reply's`, because it looks weird and is poor English grammar.
Prefer more descriptive documentation instead."
changeset,0000006774,[6774],johnjamesjacoby,Documentation: fix a bunch of random ambiguous or incomplete phpdoc.
changeset,0000006497,[6497],johnjamesjacoby,"Documentation: Prefer ""database"" over ""sql"" to avoid some jargon.
This also makes it language/platform agnostic."
changeset,0000006573,[6573],johnjamesjacoby,"Documentation: Remove all `@uses` usages.
Per the WordPress inline documentation standards:
> the @uses tag is not recommended to be used to indicate a used-by relationship, as this information can be derived through other means. These tags also are very likely to become out-of-date as our functions change over time."
changeset,0000006580,[6580],johnjamesjacoby,Documentation: Typo fixes in users functions.
changeset,0000004177,[4177],johnjamesjacoby,"Doing it wrong:
* Protect users from the effects of incorrectly manipulating the bbPress instance.
* Uses _doing_it_wrong() in place of wp_die(), in bbPress::__clone() and bbPress::__wakeup() magic methods."
changeset,0000003836,[3836],johnjamesjacoby,Don't after-filter return count values as int to allow number-formatting filters to work correctly. Fixes #1810. Props wonderboymusic.
changeset,0000005317,[5317],johnjamesjacoby,Don't allow `build` or `src` in `basename` in `bbPress:setup_globals()`. Fixes problems with activation hooks. Fixes #2559. Props DJPaul.
changeset,0000004843,[4843],johnjamesjacoby,"Don't allow replies to closed topics, unless user can moderate. Props mzaweb. Fixes #2281."
changeset,0000003156,[3156],johnjamesjacoby,Don't build a meta query if there are no forums to exclude.
changeset,0000005308,[5308],johnjamesjacoby,Don't copy Sass files (or any other excluded files) into `/build` directory. Props netweb. See #2542.
changeset,0000003287,[3287],johnjamesjacoby,"Don't create post revisions when changing a topic/reply status (open/close/spam/unspam).
Update phpdoc in forum open/close."
changeset,0000005656,[5656],netweb,"Don't create post revisions when opening topics in `bbp_open_topic()` or closing topics in `bbp_close_topic()` as post content does not change.
Props netweb. See #2653
"
changeset,0000005651,[5651],netweb,"Don't create post revisions when updating replies menu order in `bbp_update_reply_position()` as there's no post content changed.
Props netweb. Fixes #2656
"
changeset,0000005272,[5272],johnjamesjacoby,"Don't ignore Travis or JSHint configuration files, and add them to root. See #2542.
"
changeset,0000002669,[2669],johnjamesjacoby,Don't load CSS in admin
changeset,0000002715,[2715],johnjamesjacoby,Don't output topic admin links if not actually in a topic. Props !GautamGupta
changeset,0000004638,[4638],johnjamesjacoby,Don't parse smilies in bbPress 1.x converter. Props netweb for testing. Fixes #1874.
changeset,0000003317,[3317],johnjamesjacoby,Don't show Sticky links in wp-admin if topic is spam or trash.
changeset,0000005194,[5194],johnjamesjacoby,"Don't use `esc_html_e()` on Importer page, as it includes a `` tag that's worth keeping around."
changeset,0000004665,[4665],johnjamesjacoby,Don't wrap nested pre/code tags in additional new-lines.
changeset,0000004518,[4518],johnjamesjacoby,"Dropdown:
* Use 'post_parent' instead of 'child_of' in bbp_get_dropdown().
* Add 'exclude' to array of default arguments.
* Fixes bug with not excluding post ID's, and not using the correct post parent ID.
* Props jmdodd.
* Fixes #2061."
changeset,0000004259,[4259],johnjamesjacoby,"Dropdowns:
* Revert back to text inputs for topic and forum ID's in metaboxes.
* Fixes memory issues when loading thousands of posts.
* Fixes #1878.
* See #1901."
changeset,0000005540,[5540],netweb,Drupal7: Add support for importing Drupal v7.x pending topics and replies. See #2645
changeset,0000005536,[5536],netweb,Drupal7: Don't import Drupal 7's guest user
changeset,0000006753,[6753],johnjamesjacoby,"Duplicates: check `post_author` argument instead of current user.
This change brings duplicate checking up to speed with flood and blacklist checks by preferring `user_can()` over `current_user_can()`, and plays a bit more friendly with anonymous author IDs.
Props r-a-y. Fixes #3186."
changeset,0000006869,[6869],johnjamesjacoby,"Edit Locking Improvements:
* Refactor to avoid doing unnecessary computations
* Invert default return value from false to true, requiring time to pass validation as opposed to assuming
* Improve obviousness of math computations for easier debuggability
* Update variables passed into the end return filter
* Add 6 unit tests for before/on/after, plus support for ""0"" as infinite
* Fix bug causing ""0"" values to return the opposite value
* Ensure only gmt/utc values are compared
* Add optional flag to use WordPress time instead
* Improve inline and function documentation
Fixes #3222. Props wpdennis.
"
changeset,0000006920,[6920],johnjamesjacoby,"Edit Locking: Remove redundant $minutes check in `bbp_past_edit_lock()`.
This commit is just a small bit of cleanup from researching #3164.
See #3222."
changeset,0000004025,[4025],johnjamesjacoby,"Editing:
* Bail early if forum/topic/reply ID is missing.
* Put message back that was accidentally removed in r4024."
changeset,0000004241,[4241],johnjamesjacoby,"Editor:
* Additional output escaping on textarea attributes.
* Revert accidental indentation change from r4240.
* See #1870."
changeset,0000006919,[6919],johnjamesjacoby,"Emails: chunk notification emails into 40 Bcc'd recipients.
This commit introduces the `bbp_mail` subfilter, used to target bbPress specific emails in conjunction with `bbp_get_email_header()` to help identify emails that came specifically from bbPress actions.
The purpose of this change is to help forum owners avoid their outbound emails being marked as spam, due to the high number of users that can be subscribed to any given forum or topic.
This change (combined with r6725) goes a long way towards improving the success of subscription emails reaching their intended recipients.
Fixes #3260. Props danielbachhuber."
changeset,0000007151,[7151],johnjamesjacoby,"Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`.
This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges.
In branches/2.6, for 2.6.6. Fixes #3405.
Props muratgu."
changeset,0000007152,[7152],johnjamesjacoby,"Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`.
This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges.
In trunk, for 2.7. Fixes #3405.
Props muratgu."
changeset,0000005496,[5496],johnjamesjacoby,Embetter Orwellian Newspeak used to describe sticky topics in `admin/topics.php`. Props netweb. Fixes #2622.
changeset,0000005499,[5499],johnjamesjacoby,"Enable forum status and visibility functions to check ancestry by extracting existing logic into new helper functions. Props alex-ye, netweb. Fixes #2303."
changeset,0000005168,[5168],johnjamesjacoby,Enable pingbacks for CPT's when creating in wp-admin. Fixes #2297.
changeset,0000005169,[5169],johnjamesjacoby,Enable pingbacks for forum CPT when creating in wp-admin. See #2297.
changeset,0000006327,[6327],johnjamesjacoby,"Engagements/BuddyPress: Add `@since` for changes in 2.6.0, and a bit more clean-up.
See #3068."
changeset,0000006326,[6326],johnjamesjacoby,"Engagements/BuddyPress: Finish integration, and clean-up favorites & subscriptions support.
See #3068."
changeset,0000006723,[6723],johnjamesjacoby,"Engagements: abstract meta strategy into an overload'able class.
This change introduces a class and wrapper function to allow the `meta` strategy of the new user engagements API to be hot-swapped. This might be helpful on large installations where a dedicated database table makes more sense, or for integrations where features like ""Favorites"" or ""Subscriptions"" might already be delegated to other third-party membership plugins. Now, the caller class can be filtered to one that includes custom methods.
See #3068."
changeset,0000006322,[6322],johnjamesjacoby,"Engagements: Add `bbp_is_engagements_active` to default options array.
See #3068."
changeset,0000006992,[6992],johnjamesjacoby,"Engagements: add caching to User strategy, for 2.5 compatibility.
This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).
Props johnjamesjacoby, netweb. Fixes #3292. For 2.6.3, branches/2.6."
changeset,0000006993,[6993],johnjamesjacoby,"Engagements: add caching to User strategy, for 2.5 compatibility.
This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).
Props johnjamesjacoby, netweb. Fixes #3292. For 2.7, trunk."
changeset,0000006768,[6768],johnjamesjacoby,"Engagements: Add relationship key and type to `bbp_user_engagements_interface()`.
This allows for per-feature overloading of the engagement relationship type – useful if you want to store some data as a taxonomy, some data as meta, and other data in custom storage."
changeset,0000006321,[6321],johnjamesjacoby,"Engagements: Allow engagements to be toggled on/off, for forums that have not run the upgrade routine yet.
Also missed a spot in the BuddyPress integration.
See #3068."
changeset,0000006914,[6914],johnjamesjacoby,"Engagements: always show user avatars in subscription/favorite metaboxes.
This commit introduces a helper function (to reduce code duplication) responsible for looping through queried users and outputting avatars and profile links.
A developers note is included in the function docs discouraging third-party plugin developers from using it, as future iterations of bbPress may modify its output without notice.
Fixes #3272."
changeset,0000006877,[6877],johnjamesjacoby,"Engagements: demystify strategy sanitization.
This change ensures that invalid/unavailable strategies are never used, and also allows for custom strategies to exist (custom table, etc...) without requiring strategy registration.
See #3211.
"
changeset,0000006843,[6843],johnjamesjacoby,"Engagements: documentation improvements to various strategy classes.
See #3211."
changeset,0000006828,[6828],johnjamesjacoby,"Engagements: enforce `absint()` on function parameters in engagements API.
Also fixes a bug causing an `array_search()` to erroneously fail.
See #3206."
changeset,0000007003,[7003],johnjamesjacoby,"Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them."
changeset,0000007002,[7002],johnjamesjacoby,"Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them."
changeset,0000007005,[7005],johnjamesjacoby,"Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
Revert r7002 and use a different syntax to avoid debug notices."
changeset,0000007004,[7004],johnjamesjacoby,"Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
Revert r7003 and use a different syntax to avoid debug notices."
changeset,0000006332,[6332],johnjamesjacoby,"Engagements: First pass at a `user_query`, which will be used for looping through users.
* Introduces `BBP_User_Query` which extends `WP_User_Query`
* Includes functions for use within template parts
See #3068."
changeset,0000006844,[6844],johnjamesjacoby,"Engagements: first pass at back-compat for pre-2.6 subscriptions and favorites
Introduces a `BBP_User_Engagements_Back_Compat` class with the necessary inverted methods to add/remove engagement relationships.
Needs testing, and `get_query()` left todo.
See #3211."
changeset,0000006311,[6311],johnjamesjacoby,"Engagements: First pass at engagement user functions.
Also update favorite/subscription documentation where inaccurate.
See #3068."
changeset,0000006320,[6320],johnjamesjacoby,"Engagements: First pass at:
* User profile section
* Template parts changes
* Rewrite rules support
* Repair & upgrade tools
* BuddyPress support
* `engagement` slug setting
See #3068."
changeset,0000007023,[7023],johnjamesjacoby,"Engagements: fix bugs with caching implementation in User strategy.
This commit adds the `$object_id` to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit `true` comparisons because internal calls to `update_meta()` up the stack may return an integer.
See #3292. For 2.6.4, branches/2.6."
changeset,0000007024,[7024],johnjamesjacoby,"Engagements: fix bugs with caching implementation in User strategy.
This commit adds the `$object_id` to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit `true` comparisons because internal calls to `update_meta()` up the stack may return an integer.
See #3292. For 2.7, trunk."
changeset,0000006323,[6323],johnjamesjacoby,"Engagements: Fix copy/paste error in r6322.
See #3068."
changeset,0000006340,[6340],johnjamesjacoby,"Engagements: Improve efficiency of upgrade & repair tools.
Props thebrandonallen. See #3068."
changeset,0000006739,[6739],johnjamesjacoby,"Engagements: include `BBP_User_Engagements_Term` class, as term storage example.
This change includes an alternative storage mechanism for engagements. Meta is used by default, but using Taxonomies and Terms for storage instead may be more appealing to certain installation types.
A few related functions were updated to use newer abstractions. See #459."
changeset,0000006334,[6334],johnjamesjacoby,"Engagements: Integrate the `user_query` into favorites, subscriptions, and engagements.
* Add to admin metabox avatar loops
* Fix a few bugs in `BBP_User_Query`, and include a custom constructor to set the loop counter
See #3068."
changeset,0000006522,[6522],johnjamesjacoby,"Engagements: Introduce 2 new functions for recalculating engagements.
* `bbp_get_topic_engagements_raw()` to efficiently query for users who have engaged in a topic
* `bbp_recalculate_topic_engagements()` to update all of the related meta-data
See #3068."
changeset,0000006517,[6517],johnjamesjacoby,"Engagements: Introduce `bbp_remove_user_from_all_objects()`.
This is useful for when a user is permanently deleted, or when all of their relationship(s) (of a certain type) need to be removed.
See #3068."
changeset,0000006529,[6529],johnjamesjacoby,"Engagements: Keep topic engagement counts up-to-date.
This changes the way the old 'voice count' works with the new engagements API in the following ways:
* Introduce new function to update voice count meta when necessary
* Modify recalculation function with a `$force` parameter, and only recalculate the counts when the engagements have changed by default
* Hook the above functions in where appropriate, largely when deleting replies (this is a unique case where a fully deleted reply needs to check if the author of the current reply has a previously public reply in that same topic already, which should not trigger a recalculation.)
* We are silently moving the `bbp_delete_` actions onto the `before_delete_post` hook, so that all term & meta-data is available to them (which helps with race conditions mentioned in r6528)
Engagements are now hooked in and listening in the most efficient way possible, at least until a common & shared walker is introduced for the entire tree.
See: #3068."
changeset,0000006842,[6842],johnjamesjacoby,"Engagements: move common classes out of abstraction.php.
See #3211.
"
changeset,0000006369,[6369],johnjamesjacoby,"Engagements: Move engagement count updates to action hooks.
Props thebrandonallen. Fixes #3068."
changeset,0000006876,[6876],johnjamesjacoby,"Engagements: next pass at back-compat for pre-2.6 `user` strategy.
* Renames `BBP_User_Engagements_Back_Compat` to `BBP_User_Engagements_User` so the approach is more clear.
* Fill in `get_query()` method, left todo from r6844.
* Move active strategy into a preloaded option, default to `meta`
* Set active strategy to `user` on failed auto-upgrade to 2.6 to maintain backwards compatibility
* Introduces sub-actions to assist with abstracting the engagement strategy setup
Fixes #3211.
"
changeset,0000006446,[6446],johnjamesjacoby,"Engagements: Performance optimizations to `bbp_update_topic_voice_count()`.
* Use a `UNION` query strategy (only on the `wp_posts` table)
* Compare old count to new count before deleting & updating engagements
Fixes #3083. Props januzi_pl."
changeset,0000006324,[6324],johnjamesjacoby,"Engagements: Prefer `bbp_admin_upgrade_user_engagements()` over the old repair tool.
See #3068."
changeset,0000006439,[6439],johnjamesjacoby,"Engagements: Remove `bbp_get_topic()` checks from engagements.
See #3083."
changeset,0000006515,[6515],johnjamesjacoby,"Engagements: Remove duplicate type castings from return values.
This removes `(bool)` usages where there is no way the return value would ever not be a boolean."
changeset,0000006534,[6534],johnjamesjacoby,"Engagements: Revert part of r6525, and adjust some actions.
* Engagements will need to be ""public only"" for 2.6, and we can reconsider what private/hidden engagements look like later
* Make sure that engagements are saved before voice counts are done
* Use new `is_public` style wrapper function for topics & replies where appropriate
* Remove a few `current_filter()` checks that should no longer be necessary with current action hook implementation
* There may be more clean-up necessary here, but this is required to bring all unit-tests back to passing as they've been written, specifically things hooked to the `bbp_insert_topic` and `bbp_insert_reply` hooks
See #3068. Hat-tip netweb."
changeset,0000006389,[6389],johnjamesjacoby,"Engagements: Simplify `bbp_is_user_engaged()`.
* Remove `$engagements` gathering & return in filter
* Remove topic verification dance (no reason to re-get or guess at the topic)
* Add `$user_id` validation
Props thebrandonallen. FIxes #3090."
changeset,0000007012,[7012],johnjamesjacoby,"Engagements: stop shouting.
This commit removes the last remaining exclamation mark from some engagements feedback.
Props casiepa. Fixes #3293. For 2.6.3, branches/2.6."
changeset,0000007013,[7013],johnjamesjacoby,"Engagements: stop shouting.
This commit removes the last remaining exclamation mark from some engagements feedback.
Props casiepa. Fixes #3293. For 2.7, trunk."
changeset,0000006525,[6525],johnjamesjacoby,"Engagements: Tracking is not just for public or closed topics.
This commit updates the engagement upgrade tool and recalculation helper functions to not be limited to public & closed post statuses. Engagements can happen on private or hidden topics also, including trash, spam, and so on.
The non-visible topics that a user is engaged in should be filtered out as needed when queried based on `post_status` or other various meta-data.
See #3068."
changeset,0000006518,[6518],johnjamesjacoby,"Engagements: Update `bbp_add_user_object()`.
* New phpdoc description
* Add `$unique` parameter and default to `true` (this differs from the normal `false` default of `add_metadata()` because, by default, this API assumes no 1 user can have multiple relationships with the same object)
* Pass `$unique` into `apply_filters()`
See #3068."
changeset,0000006516,[6516],johnjamesjacoby,"Engagements: Update `bbp_update_topic_voice_count()` to only count the number of existing engagements.
Recalculating the entire engagement tree for each topic is costly, should be done in its own dedicated function, and then only hooked in or executed when absolutely necessary.
This is easier to do with the engagements API that's new in 2.6. Recalculation function imminent.
See #3068."
changeset,0000007026,[7026],johnjamesjacoby,"Engagements: update cache groups in User strategy.
This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.
See #3292. For 2.6.4, branches/2.6."
changeset,0000007025,[7025],johnjamesjacoby,"Engagements: update cache groups in User strategy.
This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.
See #3292. For 2.7, trunk."
changeset,0000006521,[6521],johnjamesjacoby,"Engagements: Update phpdoc for `bbp_add_user_to_object()`.
* Replace `add_post_meta()` with `add_metadata()`
See #3068."
changeset,0000006530,[6530],johnjamesjacoby,"Engagements: Update topic engagements when they are manually inserted.
This brings the `_insert_` functions up to date with the `_new_` equivalents.
See: #3068. Props netweb & unit-tests for catching this."
changeset,0000006330,[6330],johnjamesjacoby,"Engagements: Updates existing functions & unit tests:
* Correct tests so that `post_author` of 0 does not get included in the overall count
* Add user IDs to all topics & replies where voice counts are being tested
* Update voice-count update function to use the new user-relationships API
* Clean-up topic merge code to more efficiently migrate favorites, subscriptions, and engagements
See #3068."
changeset,0000006520,[6520],johnjamesjacoby,"Engagements: Updates to phpdoc & helper functions.
* New function to remove all users from an object
* New function to remove all users from all objects
* Remove references to taxonomy term storage (from original implementation)
* Update phpdoc with more accurate descriptions of intended parameter usages
See #3068."
changeset,0000003494,[3494],johnjamesjacoby,Enhancements to core slug conflict checker. Add context to item args te better hint where conflict is.
changeset,0000004671,[4671],johnjamesjacoby,"Enqueue jQuery in default templates, to fix issue with head scripts not having jQuery available in shortcodes, or places where TinyMCE might be pulled into the theme."
changeset,0000003084,[3084],johnjamesjacoby,Enqueue the default style.css for twentyten parent template now that bbp-twentyten is a child theme again.
changeset,0000003335,[3335],johnjamesjacoby,Ensure $bbp global is in $GLOBALS
changeset,0000004777,[4777],johnjamesjacoby,Ensure network admins can always view group forum forms. Props thebrandonallen. Fixes #2214.
changeset,0000004825,[4825],johnjamesjacoby,Ensure textarea content shows correct return $_POST value by adding stripslashes() to bbp_get_form_*_content() functions.
changeset,0000003189,[3189],johnjamesjacoby,"Ensure that author avatars appear at the top of the reply area, for theme compat."
changeset,0000003420,[3420],johnjamesjacoby,"Ensure that default role exists, and default to 'read' cap if it does not."
changeset,0000006062,[6062],johnjamesjacoby,Escape `display_name` field usages in `bbp_get_author_link()`.
changeset,0000006063,[6063],johnjamesjacoby,Escape `display_name` field usages in `bbp_get_author_link()`. (2.5 branch)
changeset,0000004952,[4952],johnjamesjacoby,Escape output of translation strings where appropriate. Refresh some escaping approaches. See #1999.
changeset,0000006141,[6141],johnjamesjacoby,"Even less shouting, plus a grammar sweep.
* Remove contractions
* Update weird sounding English phrases (like ""the permissions"" to ""permission"")
* Simplify some phrases to be less wordy
* Update ""permission"" error codes to all use ""permission"" instead of also ""permissions""
* Add comma to ""Oh bother!"". See: https://www.youtube.com/watch?v=Fhl4oKvxphs"
changeset,0000005799,[5799],netweb,"Example importer: Change AIM, YIM, and Jabber profile fields to generic examples with meta key prefixes
Props netweb. See #2815
"
changeset,0000005580,[5580],netweb,"Example importer: Include Subscribed Forums, Subscribed Topics and Favourite Topics
Props netweb. See #2668
"
changeset,0000005672,[5672],netweb,"Exclude BuddyPress tests when running `phpunit`
BuddyPress unit testing will conflict with stand alone bbPress user testing, when BuddyPress is active the core members component cannot be deactivated thus testing users with BuddyPress at `/member/username` vs bbPress only `/user/username` and custom rewrites `/custom-user-slug/username` will cause conflicts in user PHPUnit tests.
A new Grunt sub task `grunt phpunit:buddypress` has been added to test BuddyPress integration with bbPress without compromising bbPress standalone PHPUnit testing.
Props netweb. See #2782 "
changeset,0000003247,[3247],johnjamesjacoby,"Exclude forums, topics, and replies from site wide post and page search.
We have our own search queries for each post type, and it's not currently possible to adjust the look of individual search results on the fly via theme compatibility."
changeset,0000005290,[5290],johnjamesjacoby,"Experiment with `grunt-pot`:
* Add `grunt-pot` to `package.json`
* Adds grunt task `pot` to `grunt build` and `grunt build-release`
* Creates `bbpress.pot` in `/build` & removes `bbpress.pot` from `/src`
* Checks for the following keywords: `__`, `_e`, `_x`, `_n`, `_ex`, `_nx`, `esc_attr__`, `esc_attr_e`, `esc_attr_x`, `esc_html__`, `esc_html_e`, `esc_html_x`, `_nx_noop`
* Props netweb. See #2542."
changeset,0000006180,[6180],johnjamesjacoby,Extend: Consolidate some BuddyPress hooks to the top of each file.
changeset,0000006172,[6172],johnjamesjacoby,Extend: Fix a typo in docs.
changeset,0000004395,[4395],johnjamesjacoby,"Extensions:
* Introduce core/extend.php to assist in loading extentions in a more common way.
* Move some !BuddyPress code around, into the files it makes the most sense for it to be in.
* Remove some redundant !BuddyPress loader code."
changeset,0000004489,[4489],johnjamesjacoby,"Extract:
* Brackets in bbp_update_forum_reply_count()."
changeset,0000004508,[4508],johnjamesjacoby,"Extract:
* Clean up bbp_parse_args() usages and inline documents.
* Fixes #2056."
changeset,0000004480,[4480],johnjamesjacoby,"Extract:
* Remove extract() calls from some statistics functions.
* See #2056."
changeset,0000004499,[4499],johnjamesjacoby,"Extract:
* Remove extract() from bbp_check_for_duplicate().
* Improve code in bbp_check_for_duplicate() to support this.
* See #2056."
changeset,0000004487,[4487],johnjamesjacoby,"Extract:
* Remove extract() from bbp_create_initial_content().
* See #2056."
changeset,0000004481,[4481],johnjamesjacoby,"Extract:
* Remove extract() from bbp_filter_anonymous_post_data().
* See #2056."
changeset,0000004483,[4483],johnjamesjacoby,"Extract:
* Remove extract() from bbp_get_breadcrumb().
* Other general code cleanup.
* See #2056."
changeset,0000004485,[4485],johnjamesjacoby,"Extract:
* Remove extract() from bbp_get_dropdown().
* Other general code cleanup.
* See #2056."
changeset,0000004502,[4502],johnjamesjacoby,"Extract:
* Remove extract() from bbp_get_single_forum_description().
* See #2056."
changeset,0000004484,[4484],johnjamesjacoby,"Extract:
* Remove extract() from bbp_get_the_content().
* Other general code cleanup.
* See #2056."
changeset,0000004503,[4503],johnjamesjacoby,"Extract:
* Remove extract() from bbp_list_forums().
* See #2056."
changeset,0000004488,[4488],johnjamesjacoby,"Extract:
* Remove extract() from bbp_update_forum().
* See #2056."
changeset,0000004486,[4486],johnjamesjacoby,"Extract:
* Remove extract() from bbp_update_reply_revision_log().
* Other general code cleanup.
* See #2056."
changeset,0000004490,[4490],johnjamesjacoby,"Extract:
* Remove extract() from bbp_update_topic_revision_log().
* See #2056."
changeset,0000004482,[4482],johnjamesjacoby,"Extract:
* Remove extract() from bbp_wp_login_action().
* See #2056."
changeset,0000004497,[4497],johnjamesjacoby,"Extract:
* Remove extract() from extra statistics page template.
* See #2056."
changeset,0000004493,[4493],johnjamesjacoby,"Extract:
* Remove extract() from widgets.
* See #2056."
changeset,0000004507,[4507],johnjamesjacoby,"Extract:
* Remove extract() usages from /replies/template-tags.php.
* See #2056."
changeset,0000004506,[4506],johnjamesjacoby,"Extract:
* Remove extract() usages from /topics/template-tags.php.
* See #2056."
changeset,0000004498,[4498],johnjamesjacoby,"Extract:
* Remove extract() usages from /users/template-tag.php.
* See #2056."
changeset,0000004501,[4501],johnjamesjacoby,"Extract:
* Remove unused BBP_Forum_Walker class, and bbp_walk_forum function, that use extract().
* See #2056."
changeset,0000003415,[3415],johnjamesjacoby,Extrea duplicate admin menu separator prevention.
changeset,0000003648,[3648],johnjamesjacoby,"Fall back on user_login, and lastly ""Anonymous"" if no name is found anywhere. Fixes #1704."
changeset,0000005054,[5054],johnjamesjacoby,Fallback to 'title' sorting in bbp_list_forums() for subforum sorting. Hat tip mordauk. Fixes #2373.
changeset,0000005058,[5058],johnjamesjacoby,Fallback to title sorting in bbp_has_forums() if no menu_order is present. Props netweb. Fixes #2373.
changeset,0000006493,[6493],johnjamesjacoby,"Favorites/Subscriptions improvements:
* Remove superfluous checks against current current user fav/sub status
* Always return `$success`
* Prefer `bbp_get_` functions over generic `intval()` to validate `$_GET` ID's"
changeset,0000006109,[6109],johnjamesjacoby,"Favorites/Subscriptions/Moderators: Introduce metadata API for linking multiple users to multiple forums/topics.
Previous to this, connections were stored in `usermeta`. We knew this would not scale, but bbPress 1 had a friendlier database schema & we expected WordPress's taxonomy/relationship roadmap would be farther along by now.
By storing user ID's in `postmeta` instead, we gain an ability to query for connections from both directions without custom MySQL, while also leveraging persistent caching in a more sane way.
This commit includes several new helper functions for low-level relationship management, as well as modifications to existing functions to allow them to continue to work as they always have.
See: #2959."
changeset,0000006307,[6307],johnjamesjacoby,"Favorites/Subscriptions: Add `redirect_to` parameters to links if viewing relevant user profile pages.
See #3065."
changeset,0000006308,[6308],johnjamesjacoby,"Favorites/Subscriptions: Add paged data to permalinks when in the loop.
Also add`redirect_to` parameters to links if passed in.
Fixes #3065."
changeset,0000006305,[6305],johnjamesjacoby,"Favorites/Subscriptions: Look for a `redirect_to` destination in handlers.
See #3065."
changeset,0000006309,[6309],johnjamesjacoby,"Favorites/Subscriptions: Pagination & `redirect_to` clean-up.
* PHPDoc & inline doc
* Prefer `urlencode()` over `esc_url()` for `redirect_to` query argument
* Corrections to forum & topic subscription loop logic, since they're both listed on the same page
See #3065.
"
changeset,0000005926,[5926],johnjamesjacoby,"Favorites: Purge cache when adding/removing a favorite.
This changeset fixes a bug where cache was not busted, causing incorrect results to be returned & displayed.
Props thebrandonallen. See #2855."
changeset,0000003978,[3978],johnjamesjacoby,"Favorities:
* Add $topic_id param to bbp_user_favorites_link() to allow overriding link.
* Check reply post-type, and use topic ID if link is displayed there."
changeset,0000003435,[3435],johnjamesjacoby,"Feed me 2.0! Improvements to feeds, allowing to filter by topic, reply, and defaulting to all. Works with single forums, topics, and their related content."
changeset,0000003974,[3974],johnjamesjacoby,"Feeds:
* Add 'feed' query-var to bbp_request_feed_trap() queries.
"
changeset,0000003975,[3975],johnjamesjacoby,"Feeds:
* Do not append topic and reply revision information to feeds."
changeset,0000004267,[4267],johnjamesjacoby,"Feeds:
* Fix feed generation time for topics and replies.
* Fixes #1993.
* Props SteveAtty."
changeset,0000003976,[3976],johnjamesjacoby,"Feeds:
* Never separate the lead topic when viewing a feed.
* Add is_feed() check to bbp_show_lead_topic()."
changeset,0000003973,[3973],johnjamesjacoby,"Feeds:
* Use query_posts() in bbp_request_feed_trap().
* Provides example on potential use-case in bbPress core.
* Removes need to reference $wp_query global directly."
changeset,0000006304,[6304],johnjamesjacoby,"Feeds: Allow feed titles to be filtered (using the WordPress filter name.)
Also removes redundant conditional in replies feed.
Props SergeyBiryukov. Fixes #3064."
changeset,0000006224,[6224],johnjamesjacoby,"Feeds: Avoid duplicate site name in replies feed title.
Fixes #2998. Props SergeyBiryukov."
changeset,0000006794,[6794],johnjamesjacoby,Feeds: bring back accidentally deleted semi-colon from r6793.
changeset,0000006306,[6306],johnjamesjacoby,"Feeds: Call `get_wp_title_rss()` in replies feeds.
See #3064. Missed in r6304."
changeset,0000006318,[6318],johnjamesjacoby,"Feeds: Run for it, Marty!
Props thebrandonallen. Fixes #3066."
changeset,0000006793,[6793],johnjamesjacoby,"Feeds: use `esc_url_raw()` in topics & replies generator URLs.
This brings generator tag handling up to par with recent WordPress changes."
changeset,0000002560,[2560],johnjamesjacoby,Fill in single-bbp_reply template file
changeset,0000002559,[2559],johnjamesjacoby,Fill in some blanks on taxonomy-bbp_topic_tag template file
changeset,0000003803,[3803],johnjamesjacoby,"Filter forum/topic/reply URLs and canonicalize to group forum URL if applicable:
* Fixes #1781
* Props boonebgorges"
changeset,0000003721,[3721],johnjamesjacoby,"Filter links to user subscriptions and favorites, and return them to their BuddyPress profile equivalents. See #1669."
changeset,0000004606,[4606],johnjamesjacoby,Filter the TeenyMCE buttons to remove buttons that users cannot use. Maybe allow images; commented out for now.
changeset,0000004607,[4607],johnjamesjacoby,Filter the TinyMCE quicktags buttons to remove buttons that users cannot use.
changeset,0000004689,[4689],johnjamesjacoby,Filter topic and reply content code trick and encoding before priority 10. Fixes third party plugin compat when filtering content. Hattip mordauk.
changeset,0000006484,[6484],johnjamesjacoby,Filters: cast return values & update phpdoc.
changeset,0000006487,[6487],johnjamesjacoby,"Filters: Pass original `$args` array into various filters.
These were all unintentionally omitted when these filters were introduced."
changeset,0000002525,[2525],mdawaffe,finally fix 3 year old note: use join instead of IN(...) for tagged topics/posts in BB_Query
changeset,0000002548,[2548],johnjamesjacoby,Finish tfoot in forum and front
changeset,0000003194,[3194],johnjamesjacoby,First pass at a stand-alone to plugin converter. Props !GautamGupta and Nightgunner5. See #1523.
changeset,0000003395,[3395],johnjamesjacoby,First pass at adding BuddyPress activity stream awareness to new topic and new reply creation. Rename $bbp->plugins to $bbp->extend for clarity. Rename bbp-core-akismet.php to bbp-extend-akismet.php to match new nomenclature. Fix debug notices with loop queries where they were set to arrays rather than stdClass.
changeset,0000002947,[2947],johnjamesjacoby,"First pass at allowing topics and replies to be created via their respective ""New"" screens in wp-admin.
@todo - metaboxes to match new core functionalities"
changeset,0000002670,[2670],johnjamesjacoby,First pass at anonymous posting. Fixes #1363 props !Kaspace from Google Code-in
changeset,0000003768,[3768],johnjamesjacoby,"First pass at creating forum content on first installation.
* Move bbp_activation and bbp_deactivation action hooks into admin actions so they are not run by site visitors
* Introduce bbp_create_initial_content() function to handle insertion of initial forum, topic, and reply
* Fixes #1701"
changeset,0000003669,[3669],johnjamesjacoby,First pass at forum trash/untrash/delete actions and functions for BuddyPress group forums. See #1669.
changeset,0000002895,[2895],johnjamesjacoby,"First pass at forum, topic, and reply count routines. In this first iteration, counts are purposely overly sensitive resulting in more hits to the database than ultimately will be necessary in the final iteration. The process of recounting and realigning last_active_id and last_active_time is made difficult by being restricted to using the post_parent column for post relationships. Future versions may use syncopated taxonomies, mptt, or some other method to lighten this load. This first pass also relies heavily on the WordPress API wherever possible, and only uses custom queries in an attempt to limit memory usage. There me additional benefits from sub-queries and/or self joins. Would love to have more eyes on this specifically."
changeset,0000002578,[2578],johnjamesjacoby,First pass at improved admin interface. Adds ability to add and edit user from within admin.
changeset,0000004228,[4228],johnjamesjacoby,"First pass at improving user profiles:
* Sections: topics created, replies created, favorites, subscriptions, and edit.
* Include template-parts, template-tags, functions, rewrite rules/tags, and primitive API's for new profile sections.
* Tweak CSS for new functionalities.
* See: #1939"
changeset,0000003731,[3731],johnjamesjacoby,First pass at network updater. See #1725.
changeset,0000005226,[5226],johnjamesjacoby,"First pass at replacing `Green` admin color scheme with `Mint` and `Evergreen` for WordPress 3.8. More to do here. Props melchoyce, ryelle. See #2462."
changeset,0000003171,[3171],johnjamesjacoby,First pass at RSS feeds. See #1422.
changeset,0000004932,[4932],johnjamesjacoby,"First pass at settings and options redux:
* Introduce toggle to break forum settings up into existing !WordPress settings pages. Off by default, this allows us to migrate easier later, should we decide to go this route. See #1500.
* Introduce setting to handle the forum-root toggle. This eliminates the possible forum/topic archive slug conflict, if using topics archive as forum root. More to integrate here, including changing the main query and template part output.
* Break user slugs into their own section, and allow favorites and subscriptions slugs to be edited.
* Turn Forum Root into it's own section, and move topic/reply archive slugs into the new user section."
changeset,0000002727,[2727],johnjamesjacoby,"First pass at topic moderation links for Trash, Open/Closed, and Spam. Props !GautamGupta via Google Code-in"
changeset,0000002615,[2615],johnjamesjacoby,"First pass at topic, reply, and voice counts. In this first pass, forum replies and forum voices are not working. Also forum counts will be skewed if there are subforums, and reply counts will be skewed if hacking threaded replies. @todo: Use walker and children/ancestors"
changeset,0000005266,[5266],johnjamesjacoby,First pass at unit test suite. Props netweb. See #2542.
changeset,0000002652,[2652],johnjamesjacoby,First pass at user favorites. Props !GautamGupta via Google Code In
changeset,0000002688,[2688],johnjamesjacoby,First pass at user profiles and front-end user editing. Fixes #1364 props !GautamGupta via Google Code-in. Split bbp-template.php into smaller files. Rename 'profile-' pages to 'user-'. (This is the Ultra Magnus of changesets.)
changeset,0000002737,[2737],johnjamesjacoby,First pass at using WordPress Settings API for admin settings. Props !GautamGupta via Google Code-in
changeset,0000003623,[3623],johnjamesjacoby,"First pass at v2 theme compatibility:
* Remove references to current_theme_supports()
* Introduce bbp_locate_template() to include theme compat path
* Use bbp_locate_template() through-out project
* See #1691"
changeset,0000002567,[2567],johnjamesjacoby,First pass at Voices. Fixes #1330. Props !GautamGupta
changeset,0000002653,[2653],johnjamesjacoby,First pass at widgets. Props Jason K via Google Code In
changeset,0000003816,[3816],johnjamesjacoby,"First pass: replace bbPress 1.1 importer with bbConverter by Adam Ellis.
* Handles large bbPress installations much better than original importer
* Better potential for new converters in future
* Breathes life into abandoned bbConverter project
* See 1592
* Props Adam Ellis for bbConverter
* @todo: Settings/UI/code clean-up, shake vigorously, lather, rinse, repeat"
changeset,0000003815,[3815],johnjamesjacoby,"First pass: replace bbPress 1.1 importer with bbConverter by Adam Ellis.
* Handles large bbPress installations much better than original importer
* Better potential for new converters in future
* Breathes life into abandoned bbConverter project
* See 1592
* Props Adam Ellis for bbConverter
* @todo: Settings/UI/code clean-up, shake vigorously, lather, rinse, repeat"
changeset,0000003552,[3552],johnjamesjacoby,"First round of BuddyPress Groups integration:
* Moves BuddyPress extension activation to bp_include action
* Adds form-forum.php template part"
changeset,0000003135,[3135],johnjamesjacoby,"First round of security sweeps and final code clean-up. Includes new/edit topic functions, topic merge, and some strtoupper() checks on REQUEST_METHOD. See #1514."
changeset,0000004495,[4495],johnjamesjacoby,Fix $args collision in topic views widget.
changeset,0000003658,[3658],johnjamesjacoby,Fix 'deactivate' copy-pasta from r3657. See #1660.
changeset,0000004583,[4583],jmdodd,"Fix .bbp-search-content CSS copy pasta typo.
* Props netweb.
* Fixes #2111.
"
changeset,0000005383,[5383],netweb,"Fix .editorconfig file, file should be a file not a diff.
Props thebrandonallen. Fixes #2612"
changeset,0000004929,[4929],johnjamesjacoby,Fix @deprecated tag for bbp_generate_rewrite_rules(). See #2336.
changeset,0000002908,[2908],johnjamesjacoby,Fix @since and @param or bbp_update_forum
changeset,0000005353,[5353],netweb,Fix @since PHPDoc for `toggle_forum` and `toggle_forum_notice` in /includes/admin/forums.php
changeset,0000002829,[2829],johnjamesjacoby,Fix @since revision numbers
changeset,0000002747,[2747],johnjamesjacoby,Fix @since's from r2746. Use correct 'read_private_forums' cap where appropriate.
changeset,0000005182,[5182],johnjamesjacoby,Fix @since.
changeset,0000002757,[2757],johnjamesjacoby,Fix @sinces from r2756
changeset,0000002530,[2530],mdawaffe,fix _bb_make_tag_compat() to work on array input. Make sure tt_id is always an (int). WS.
changeset,0000006365,[6365],netweb,"Fix `@return` docs typo in `bbp_title`
Props SergeyBiryukov.
Fixes #3080.
"
changeset,0000005263,[5263],johnjamesjacoby,Fix `@since` PHPDoc for Drupal7 converter. Props netweb. Fixes #2521. (2.5 branch)
changeset,0000005264,[5264],johnjamesjacoby,Fix `@since` PHPDoc for Drupal7 converter. Props netweb. Fixes #2521. (trunk)
changeset,0000003696,[3696],johnjamesjacoby,Fix a bunch of possible accidental inline assignments in bbp-user-functions.php.
changeset,0000004886,[4886],johnjamesjacoby,Fix a few widget fields that were not saving correctly. Props alex-ye. Fixes #2319 (2.3 branch)
changeset,0000004885,[4885],johnjamesjacoby,Fix a few widget fields that were not saving correctly. Props alex-ye. Fixes #2319 (trunk)
changeset,0000006532,[6532],johnjamesjacoby,Fix accidentally inverted inline doc from r6531.
changeset,0000003027,[3027],johnjamesjacoby,Fix activation notice to use current_theme_supports() and include a method to bypass the theme nag.
changeset,0000005421,[5421],netweb,Fix additional references to topics in phpdoc for reply status dropdown functions. See #2463.
changeset,0000002799,[2799],johnjamesjacoby,Fix ajax tag adding/removing. Fixes #1327
changeset,0000002720,[2720],johnjamesjacoby,Fix anonymous user links. Fix single reply template. Abstract out user profile/website links. Fixes #1408. Props !GautamGupta via Google Code-in
changeset,0000004690,[4690],jmdodd,"Fix array title copypasta in bbp_admin_repair_list().
* Props netweb.
* Fixes #2152.
"
changeset,0000006364,[6364],netweb,"Fix basename filter in `bbPress:setup_globals()`.
This changeset if for `/branches/2.5`, previously [5316] for `/trunk`
Props alexvorn2.
Fixes #3079.
"
changeset,0000005316,[5316],johnjamesjacoby,Fix basename filter in `bbPress:setup_globals()`. Props DJPaul.
changeset,0000003486,[3486],johnjamesjacoby,Fix bb_get_option() when requesting 'url' Props _ck_. Fixes #1624. (0.9 branch)
changeset,0000002743,[2743],johnjamesjacoby,Fix bb_get_user to prevent 'Invalid argument' errors.
changeset,0000004827,[4827],johnjamesjacoby,Fix bbp_forum_row_actions() phpdoc description. Props netweb. Fixes #2282.
changeset,0000003300,[3300],johnjamesjacoby,Fix bbp_recount_topic_replies() to include topics with 0 replies.
changeset,0000002730,[2730],johnjamesjacoby,Fix broken favorites and subscriptions (from previous commit)
changeset,0000004631,[4631],johnjamesjacoby,Fix broken markup in loop-search-forum.php template part.
changeset,0000004694,[4694],johnjamesjacoby,Fix broken single forum feeds by avoiding get_page_by_path(). Props alex-ye. Fixes #2167.
changeset,0000003294,[3294],johnjamesjacoby,Fix bug allowing trashed topics and replies in wp-admin to be visible to users without proper caps.
changeset,0000004657,[4657],johnjamesjacoby,"Fix bug causing reply revisions not to save correctly. Also tweak default revision CSS to be more aggressive, so it does not get nooped by content OL/UL/LI styling."
changeset,0000003033,[3033],johnjamesjacoby,Fix bug from r3032 where new topic form did not display forum drop down when using forum-index shortcode.
changeset,0000004844,[4844],johnjamesjacoby,Fix bug in bbp_get_reply_excerpt() that was causing it to always fail. Reverse the parameters of get_post_field() to be in the correct order. Props paulgibbs. Fixes #2300.
changeset,0000004834,[4834],johnjamesjacoby,Fix bug in bbp_get_single_topic_description() causing some conditions to never be executed. Use bbp_get_topic_last_reply_id() instead of bbp_get_topic_last_active_id() since the $topic_id is used as the last active ID if no replies exist. Fixes #2289.
changeset,0000004845,[4845],johnjamesjacoby,Fix bug in bbp_get_topic_excerpt() that was causing it to always fail. Reverse the parameters of get_post_field() to be in the correct order. See #2300.
changeset,0000002951,[2951],johnjamesjacoby,Fix bug in bbp_update_forum_hidden_topic_count() where trashed topics would not update the hidden topic count.
changeset,0000003201,[3201],johnjamesjacoby,"Fix bug in theme compatibility where $forum_id could get wiped out.
Also add more default template options, to allow custom forum catch-alls without modifying existing templates or elaborate hooks and filters."
changeset,0000003124,[3124],johnjamesjacoby,Fix bug in topic/reply revisions where log was 1 revision behind.
changeset,0000003044,[3044],johnjamesjacoby,Fix bug in topics widget where topics in hidden forums could peek through if post_parent was set to 'any'
changeset,0000003453,[3453],johnjamesjacoby,Fix bug in user_status checks allowing spam/deleted users to create topics and replies.
changeset,0000004742,[4742],johnjamesjacoby,Fix bug preventing nested forums from being available when creating topics/replies from wp-admin. Props alex-ye. Fixes #2186.
changeset,0000002962,[2962],johnjamesjacoby,Fix bug where closed topics and replies were excluded from queries. Also add grey color to text of closed topics in forum view.
changeset,0000005120,[5120],johnjamesjacoby,"Fix bug where nested ternary comparisons in `form-anonymous.php` were causing duplicated, sometimes conflicting, output.
Introduce convenience template functions for better handling and output of anonymous user form field data. Wrap complex `form-anonymous.php` template-part access logic in a helper function (similar to other template parts.) Deprecate ambiguous `bbp_topic/reply_author()` functions, in favor of `author_display_name()` equivalents.
Fixes #2426."
changeset,0000003313,[3313],johnjamesjacoby,Fix bug where old stick-to-front topics might get pushed past first page.
changeset,0000003149,[3149],johnjamesjacoby,Fix bug where reply revision author would incorrectly show the original reply author.
changeset,0000002965,[2965],johnjamesjacoby,"Fix bug where sub forums would not be visible when created, as they lack the required postmeta values for topics/replies, and parent forums would not have updated subforum counts."
changeset,0000003025,[3025],johnjamesjacoby,Fix bug where switching visibilities could cause a misalignment of hidden/private site values.
changeset,0000003055,[3055],johnjamesjacoby,Fix bug with get_post_type() usage in bbp_forum_visibility check. Also tweak the white listed set of user caps.
changeset,0000002478,[2478],johnjamesjacoby,Fix casing on function names and phpdoc
changeset,0000003705,[3705],johnjamesjacoby,Fix check in bbp_get_view_query_args() and add filter at the end.
changeset,0000003266,[3266],johnjamesjacoby,Fix checked status of topic subscription form checkbox.
changeset,0000004628,[4628],johnjamesjacoby,Fix content display issues in .bbp-user-section container (includes RTL). Props jaredatch. Fixes #2067.
changeset,0000004680,[4680],johnjamesjacoby,Fix copy pasta from topic display name fix. See #2141.
changeset,0000005159,[5159],netweb,Fix copy pasta in user profile subscriptions template. See #2299
changeset,0000004676,[4676],johnjamesjacoby,Fix copy pasta inline doc from r4675.
changeset,0000005728,[5728],netweb,"Fix copy pasta placeholder argument in `loop-single-topic.php` template
Props netweb. Fixes #2799
"
changeset,0000003724,[3724],johnjamesjacoby,"Fix current_*_id globals so they are used instead of set. Also fix issue with _edit permalinks still using home_url() instead of normal _permalink() functions, and cleanup some whitespace. Fixes #1734."
changeset,0000003599,[3599],johnjamesjacoby,Fix debug notice in BuddyPress user ID filter when anonymous posting is enabled.
changeset,0000003456,[3456],johnjamesjacoby,Fix debug warning when topic has no tags. Fixes #1607. Props !GautamGupta.
changeset,0000003337,[3337],johnjamesjacoby,Fix display of non-english characters in sample permalink. Fixes #1559. Props cnorris23.
changeset,0000006712,[6712],johnjamesjacoby,Fix documentation typos.
changeset,0000005319,[5319],netweb,"Fix duplicate action name in form-forum.php. Props netweb. Fixes #2560
"
changeset,0000003483,[3483],johnjamesjacoby,Fix duplicate action name in form-topic.php.
changeset,0000003502,[3502],johnjamesjacoby,Fix duplicate BuddyPress activity stream component actions for replies.
changeset,0000003195,[3195],johnjamesjacoby,Fix duplicate notice issue in admin recount screen.
changeset,0000003006,[3006],johnjamesjacoby,Fix duplicate referer field in topic/reply fieldsets if user has unfiltered_html capability.
changeset,0000002657,[2657],johnjamesjacoby,Fix error that can happen when attempting to view a single reply
changeset,0000002824,[2824],johnjamesjacoby,Fix excerpt length counts and use … instead of '...' Fixes #1456. Props !GautamGupta
changeset,0000003608,[3608],johnjamesjacoby,Fix extra php closing bracket in content-single-user.php. Props ptahdunbar.
changeset,0000004614,[4614],johnjamesjacoby,Fix favorite/subscription links when viewing a group forum. Use bbPress _is_ functions instead. Props jmdodd. Fixes #2120.
changeset,0000003512,[3512],johnjamesjacoby,Fix formatting in plugin header for Text Domain and Domain Path. Props !Viper007Bond.
changeset,0000006192,[6192],johnjamesjacoby,"Fix formatting of query in `bbp_get_user_closed_topic_count()`, introduced in r6191."
changeset,0000002632,[2632],johnjamesjacoby,Fix forum reply recount and remove old code
changeset,0000002614,[2614],johnjamesjacoby,Fix function name
changeset,0000002574,[2574],johnjamesjacoby,Fix function names. First pass at reply and topic forms. Variable type cast fixes. Introduce current_user functions. Rename bbp_post template part to bbp_reply. Rename pagination functions to fit context. Lots of other tweaks.
changeset,0000002966,[2966],johnjamesjacoby,"Fix hard coded post_type in bbp_admin_menu_order, and prepate separator skip routine for possible multiple separators."
changeset,0000002674,[2674],johnjamesjacoby,Fix html doc
changeset,0000005670,[5670],netweb,"Fix i18n `_n()` plurals placeholders missed in r5668 in `bbp_admin_repair_closed_topics()`
"
changeset,0000003157,[3157],johnjamesjacoby,Fix incomplete inline doc
changeset,0000002624,[2624],johnjamesjacoby,Fix incorrect $_POST reference; props ryangannon
changeset,0000005291,[5291],netweb,Fix incorrect `bbbpress` text domain used `bbp_get_topic_pagination_count`. Props netweb. Fixes #2549.
changeset,0000002629,[2629],johnjamesjacoby,Fix incorrect cap check
changeset,0000003441,[3441],johnjamesjacoby,Fix incorrect class on lostpass link in login widget.
changeset,0000002642,[2642],johnjamesjacoby,Fix incorrect doc
changeset,0000002936,[2936],johnjamesjacoby,Fix incorrect field name in form-bbp_user_register.php in bbp-twentyten. Props Nightgunner5.
changeset,0000004984,[4984],johnjamesjacoby,Fix incorrect filter name in bbp_get_user_profile_edit_link().
changeset,0000002849,[2849],johnjamesjacoby,Fix incorrect filter name on bbp_get_subscriptions_permalink
changeset,0000002498,[2498],johnjamesjacoby,Fix incorrect filter names. props GautamGupta
changeset,0000002953,[2953],johnjamesjacoby,Fix incorrect inline documentation in bbp_new_reply_admin_handler()
changeset,0000003257,[3257],johnjamesjacoby,Fix incorrect parameters in bbp_query_post_parent__in(). Props mouratidis.
changeset,0000005331,[5331],johnjamesjacoby,Fix incorrect phpdoc in users functions.
changeset,0000003196,[3196],johnjamesjacoby,Fix incorrect reference in last active recount walker
changeset,0000002562,[2562],johnjamesjacoby,Fix incorrect return value
changeset,0000003385,[3385],johnjamesjacoby,Fix incorrect sanity check in bbp_edit_user_handler()
changeset,0000002483,[2483],PeteMall,Fix incorrect screen_icons on default post_type pages.
changeset,0000002551,[2551],johnjamesjacoby,Fix incorrect template comment
changeset,0000003524,[3524],johnjamesjacoby,Fix incorrect text in subscription label when editing a post. Fixes #1462. Props dimadin. (trunk)
changeset,0000003128,[3128],johnjamesjacoby,"Fix incorrect topic voice count routine, causing all topics to only show 1 voice. This will auto correct existing topics as new replies are created in them."
changeset,0000003176,[3176],johnjamesjacoby,Fix incorrect variable check on reply post_content when editing a reply
changeset,0000003276,[3276],johnjamesjacoby,"Fix incorrect variable declaration, causing anonymous replies to fail."
changeset,0000005557,[5557],netweb,"Fix incorrect variable name in `SMF.php` callback `callback_html()`
* This caused the regular expression for BBCode `[list]` and `[list type=decimal]` to not be included in the `callback_html()` callback.
Props netweb. Fixes #2715"
changeset,0000003062,[3062],johnjamesjacoby,Fix incorrect variable reference in bbp_load_template()
changeset,0000003175,[3175],johnjamesjacoby,Fix incorrect variable reference in bbp_template_include() when editing a topic and theme supports bbPress.
changeset,0000002979,[2979],johnjamesjacoby,"Fix incorrect variable returned in bbp_has_topics() filter, and improve inline documentation."
changeset,0000003237,[3237],johnjamesjacoby,Fix incorrect variable usage in topic merge portion of bbp_replace_the_content()
changeset,0000003457,[3457],johnjamesjacoby,Fix incorrect variable usage in topics widget. Also clean up code so it's easier to understand. Fixes #1606. Props !GautamGupta for original patch.
changeset,0000002988,[2988],johnjamesjacoby,Fix incorrect variable used in bbp_update_reply_forum_id() causing _bbp_forum_id meta value to be set to incorrect value in certain conditions.
changeset,0000004620,[4620],johnjamesjacoby,Fix incorrectly floated topic tags page content. See #2062.
changeset,0000003110,[3110],johnjamesjacoby,Fix incorrectly located forum description in single forum shortcode.
changeset,0000003234,[3234],johnjamesjacoby,Fix incorrectly located reply-form template part in single-topic.php.
changeset,0000003235,[3235],johnjamesjacoby,Fix incorrectly located topic tag list and single topic description in single topic shortcode.
changeset,0000006259,[6259],xknown,"Fix infinite loop on xmlrpc.
"
changeset,0000002465,[2465],johnjamesjacoby,Fix inline docs
changeset,0000003278,[3278],johnjamesjacoby,"Fix issue causing admin post row nonce checks to fail due to incorrect load order. Add Akismet support to core, which will take advantage of the Akismet plugin for WordPress if it is activated. Props Nightgunner5 for original Aksimet concept."
changeset,0000003587,[3587],johnjamesjacoby,Fix issue causing sub-forum lists not to appear. Fixes #1674.
changeset,0000003347,[3347],johnjamesjacoby,Fix issue in form-topic-tag.php where tag slug was appearing in name field.
changeset,0000003168,[3168],johnjamesjacoby,Fix issue in single-forum.php where the forum_id was incorrectly retrieved in certain situations.
changeset,0000003501,[3501],johnjamesjacoby,"Fix issue when topics and replies are flagged as spam/trash where they would still update last active data for ancestors. Fixes #1631.
Fix issue when trashing and deleting a topic, replies may not be properly queried and updated. Fixes #1629."
changeset,0000002693,[2693],johnjamesjacoby,Fix issue where adding as favorites or subscribing would error if user did not have existing favorite or subscription
changeset,0000003843,[3843],johnjamesjacoby,"Fix issue where bbp_get_time_since() can show ""5 months, 0 days ago"""
changeset,0000003323,[3323],johnjamesjacoby,"Fix issue where bbp_is_user_home() would always return true, due to improper type casting."
changeset,0000003374,[3374],johnjamesjacoby,Fix issue where bbpress.css styling could bleed into pages it does not belong in. Introduces 'bbp_enqueue_scripts' hook as needed for dependencies.
changeset,0000003503,[3503],johnjamesjacoby,Fix issue where BuddyPress activity stream items could still be created for non-public forums when using sub-forums. Fixes #1630.
changeset,0000003366,[3366],johnjamesjacoby,Fix issue where closed forums and topics still allowed new replies to be created in certain situations.
changeset,0000003365,[3365],johnjamesjacoby,Fix issue where closed forums still allowed new topics to be created in certain situations.
changeset,0000003063,[3063],johnjamesjacoby,Fix issue where jQuery dependency was not loaded properly when enqueueing theme compat topic.js
changeset,0000002572,[2572],johnjamesjacoby,Fix issue where loop content could poison parent forum/topic function return values.
changeset,0000002983,[2983],johnjamesjacoby,Fix issue where new replies were not updating '_bbp_last_reply_id' meta under certain circumstances.
changeset,0000003386,[3386],johnjamesjacoby,Fix issue where pagination on topic tag page was not working. This uncovered underlying issues with how posts and globals were reset as part of theme compatibility. Fixes #1589.
changeset,0000002976,[2976],johnjamesjacoby,Fix issue where post form values would disappear when editing or creating a new topic. Addresses topic portion of #1466.
changeset,0000002917,[2917],johnjamesjacoby,Fix issue where profiles of user_login's with spaces or periods could not be viewed. Fixes #1475. Props Nightgunner5.
changeset,0000003141,[3141],johnjamesjacoby,Fix issue where splitting a topic in half would result in the new lead topic post to be missing in some circumstances.
changeset,0000002835,[2835],johnjamesjacoby,Fix issue where stickies and super stickies were overwriting the position of normal posts in the loop.
changeset,0000002890,[2890],johnjamesjacoby,Fix issue where subforums were limited to 5
changeset,0000003515,[3515],johnjamesjacoby,Fix issue where subscription emails were not being sent in some circumstances.
changeset,0000002579,[2579],johnjamesjacoby,Fix issue where the_content would display on incorrect post_type's
changeset,0000003443,[3443],johnjamesjacoby,Fix issue where topic pagination was not linking to topic when permalinks were unpretty. Fixes #1604.
changeset,0000003346,[3346],johnjamesjacoby,Fix issue where topic tags could not be renamed or reslugged.
changeset,0000002937,[2937],johnjamesjacoby,Fix issue where topics widget would only show topics created by the author when viewing that users profile.
changeset,0000003368,[3368],johnjamesjacoby,Fix issue where wide pre tags would skew width of topic tables.
changeset,0000003795,[3795],johnjamesjacoby,Fix issue with 'Anonymous' appearing as username when first post is created by a bozo'ed user. (trunk/1.1)
changeset,0000003796,[3796],johnjamesjacoby,Fix issue with author of post_id 1 appearing as topic last poster when first post is created by a bozo'ed user. (trunk/1.1)
changeset,0000003056,[3056],johnjamesjacoby,Fix issue with editing replies via the admin area.
changeset,0000004741,[4741],johnjamesjacoby,Fix issue with user profile replies pagination. Props r-a-y. Fixes #2190.
changeset,0000003794,[3794],johnjamesjacoby,"Fix issue with voices showing ""Array"" when user that posted topic is spammed or bozo'ed. (trunk/1.1)"
changeset,0000003295,[3295],johnjamesjacoby,Fix issues with creating/editing topics and replies from within wp-admin. Fixes #1544.
changeset,0000002675,[2675],johnjamesjacoby,Fix list of topics when viewing a topic tag
changeset,0000002823,[2823],johnjamesjacoby,"Fix login smart redirect. Fixes #1460, #1459. Props !GautamGupta"
changeset,0000003126,[3126],johnjamesjacoby,Fix lost password page template and related functions. Fix duplicate template notices on theme forms. Fixes #1491.
changeset,0000005424,[5424],netweb,Fix missing @since phpdoc in `converter.php`
changeset,0000005686,[5686],netweb,"Fix missing @since revision in `bbp_is_forum_visibility()`
"
changeset,0000003256,[3256],johnjamesjacoby,"Fix missing @since revision, update phpdoc, and variable clean-up for bbp_author_metabox(). Props eagle-eyed duck_"
changeset,0000002588,[2588],johnjamesjacoby,Fix missing global
changeset,0000003177,[3177],johnjamesjacoby,Fix missing hidden reply title field in bbp_reply_form_fields()
changeset,0000003373,[3373],johnjamesjacoby,Fix missing quotes in bbp_get_paged(). Fixes #1582. Props sorich87.
changeset,0000004575,[4575],johnjamesjacoby,Fix missing tab-index on topic-type select element.
changeset,0000003364,[3364],johnjamesjacoby,Fix missing textdomains in bbp-admin/bbp-replies.php. Fixes #1577. Props dimadin.
changeset,0000003519,[3519],johnjamesjacoby,Fix mixed line endings in interface.js. (1.0 branch)
changeset,0000003479,[3479],johnjamesjacoby,Fix mixed line endings in interface.js. (trunk)
changeset,0000003697,[3697],johnjamesjacoby,Fix more accidental inline assignments in bbp-user-functions.php (see r3696). Also use $wbdb in bbp_make_ham_user() and use array_keys() since we do not use any blog details here.
changeset,0000002511,[2511],chrishajer,"Fix multiple anonymous posting issues. Fixes #1310. Props !GautamGupta
"
changeset,0000003370,[3370],johnjamesjacoby,Fix MySQL installation error with table type MYISAM in 5.5 and above. Props !DJPaul. Fixes #1486. (trunk)
changeset,0000002921,[2921],johnjamesjacoby,Fix nested span on bbp_reply_admin_links() in loop-bbp_replies.php. Fixes #1455.
changeset,0000005598,[5598],nacin,"Fix notice in bozo plugin.
"
changeset,0000005606,[5606],johnjamesjacoby,"Fix notice in bozo plugin. For 1.2 branch. See r5598.
"
changeset,0000004273,[4273],johnjamesjacoby,Fix old bbp-includes references in phpdoc.
changeset,0000002502,[2502],chrishajer,"Fix order of posts and remove duplicates, using a regex. Fixes #1301. Props Nightgunner5
"
changeset,0000003361,[3361],johnjamesjacoby,"Fix pagination issues when using topics shortcode on front page. Also use pagination_base instead of 'page'.
Fixes #1567, #1573. Props scribu."
changeset,0000006247,[6247],johnjamesjacoby,Fix pagination typo.
changeset,0000006152,[6152],xknown,"Fix parse errors in PHP 7
The result of `new` can't be longer assigned by reference.
"
changeset,0000005053,[5053],johnjamesjacoby,Fix PHP 5.4 by reference E_STRICT warning in bbp_get_user_role(). See #2372.
changeset,0000006154,[6154],xknown,"Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code is compatible with older PHP versions.
- Add also PHP 5.x style constructors.
See #3033
"
changeset,0000006156,[6156],xknown,"Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
"
changeset,0000007118,[7118],xknown,"Fix PHP warnings.
"
changeset,0000006166,[6166],xknown,"Fix PHP7 parse error.
The result of `new` can't be longer assigned by reference.
See #3033
"
changeset,0000006155,[6155],xknown,"Fix PHP7 parse error.
The result of `new` can't be longer assigned by reference.
See #3033
"
changeset,0000003606,[3606],johnjamesjacoby,Fix phpdoc @uses in bbp_check_user_edit(). See #1664. (2.0)
changeset,0000003351,[3351],johnjamesjacoby,Fix phpDoc and rogue whitespace. Props cnorris23. Fixes #1563.
changeset,0000002513,[2513],johnjamesjacoby,Fix phpdoc error
changeset,0000002487,[2487],johnjamesjacoby,Fix phpDoc from r2485. Fix unclean arg type for option values.
changeset,0000002857,[2857],johnjamesjacoby,Fix phpDoc in bbp_get_forum_voice_count
changeset,0000003591,[3591],johnjamesjacoby,Fix phpdoc indentation to bbp_get_time_since()
changeset,0000003736,[3736],johnjamesjacoby,Fix possible accidental assignments in bbp-theme-compat/bbpress-functions.php
changeset,0000003166,[3166],johnjamesjacoby,Fix possible errors when no counts are available or requested.
changeset,0000003737,[3737],johnjamesjacoby,Fix possible recursion issue in bbp_get_forum_ancestors() by casting post_parent as int.
changeset,0000002666,[2666],johnjamesjacoby,Fix previous topic pagination adjustments for author favorites
changeset,0000003437,[3437],johnjamesjacoby,Fix primary button background image location in green admin color scheme.
changeset,0000002682,[2682],johnjamesjacoby,Fix redirect bug when posting new reply from middle of paginated topic
changeset,0000005400,[5400],johnjamesjacoby,Fix references to topics in phpdoc for reply status dropdown functions. See #2463.
changeset,0000002699,[2699],johnjamesjacoby,Fix references to user slug
changeset,0000004630,[4630],johnjamesjacoby,Fix regression causing search query_var to break 404 handling in bbp_parse_query. See r4618.
changeset,0000005533,[5533],netweb,Fix regression in `bbPress1.php` importer introduced in r5349 where topics were imported a second time as part of the reply section import.
changeset,0000003712,[3712],johnjamesjacoby,Fix regression in bbp_is_user_favorite() from r3711.
changeset,0000003165,[3165],johnjamesjacoby,Fix regression introduced in r3159 causing topic and reply widgets to output type cast errors. Also remove ability for private or hidden topics/replies to peek through on widgets when viewing your own profile as a registered non-admin. See#1516.
changeset,0000003568,[3568],johnjamesjacoby,Fix regression introduced in r3553 causing Home breadcrumb text to be the current title.
changeset,0000005267,[5267],johnjamesjacoby,Fix relative path to unit test bootstrap. See #2542.
changeset,0000002561,[2561],johnjamesjacoby,Fix reply order. Fix missing globals.
changeset,0000002547,[2547],johnjamesjacoby,Fix reversed forum order.
changeset,0000004792,[4792],johnjamesjacoby,Fix reversed post request check. See r4791.
changeset,0000006211,[6211],netweb,"Fix s/convertion/conversion typo in changelog introduced in r4422 (2.5 branch)
"
changeset,0000006210,[6210],netweb,"Fix s/convertion/conversion typo in changelog introduced in r6127
"
changeset,0000006937,[6937],johnjamesjacoby,Fix Sergey's avatar. <3
changeset,0000003132,[3132],johnjamesjacoby,Fix shortcodes for single topics and forums. Add shortcode for topic tag cloud. Rename single topic tag shortcode function to more accurately describe what it does.
changeset,0000002859,[2859],johnjamesjacoby,Fix some find/replace errors from r2858
changeset,0000003229,[3229],johnjamesjacoby,Fix sort order in bbp_get_dropdown(). Props anointed.
changeset,0000005456,[5456],netweb,Fix speeling error in settings.php
changeset,0000005106,[5106],johnjamesjacoby,Fix speeling error in settings.php. Props netweb. Fixes #2438.
changeset,0000004766,[4766],johnjamesjacoby,Fix speeling of replationships in admin tools. Props netweb. Fixes #2209.
changeset,0000004026,[4026],johnjamesjacoby,Fix spelling error in bbp_new_forum_handler(). Props cnorris23.
changeset,0000002846,[2846],johnjamesjacoby,Fix spelling error in loop-bbp_topics. s/replie/reply
changeset,0000002728,[2728],johnjamesjacoby,Fix spelling error on bbp_edit_profile
changeset,0000003626,[3626],johnjamesjacoby,Fix subfolder redirect issue on login/logout. Fixes #1645. Props !Mamaduka.
changeset,0000003622,[3622],johnjamesjacoby,Fix subforum ordering in bbp_forum_get_subforums(). Fixes #1671. Props ericlewis.
changeset,0000003228,[3228],johnjamesjacoby,Fix subforum sort ordering. Props anointed.
changeset,0000006069,[6069],netweb,"Fix Subscriptions slug setting field PHPDoc block copy pasta
"
changeset,0000006358,[6358],johnjamesjacoby,Fix teh typohs.
changeset,0000003461,[3461],johnjamesjacoby,Fix the usage of bbp_is_user_home(). Fixes #1609.
changeset,0000004946,[4946],johnjamesjacoby,Fix the version.
changeset,0000005113,[5113],johnjamesjacoby,Fix theme-side forum editing debug notices. See #2408. (2.4.1)
changeset,0000005114,[5114],johnjamesjacoby,Fix theme-side forum editing debug notices. See #2408. (2.5)
changeset,0000002481,[2481],PeteMall,Fix top level admin menu icons.
changeset,0000003134,[3134],johnjamesjacoby,Fix topic and reply edit locking. Props christopher-jon.
changeset,0000004647,[4647],johnjamesjacoby,Fix topic and reply time since to use the correct parameters for get_post_time().
changeset,0000003000,[3000],johnjamesjacoby,Fix topic pagination on non single-forum and non-user pages by setting post_parent back to 0 after being set to 'any'.
changeset,0000002512,[2512],johnjamesjacoby,Fix topic/reply counts. Still more to do here.
changeset,0000006482,[6482],johnjamesjacoby,Fix typo in phpdoc.
changeset,0000002706,[2706],johnjamesjacoby,Fix typo in r2705
changeset,0000004798,[4798],johnjamesjacoby,Fix typo in reply nonce error message. Props loki_racer. Fixes #2257.
changeset,0000002816,[2816],johnjamesjacoby,Fix typo in Subscriptions phpDoc header. Props markmcwilliams
changeset,0000005072,[5072],johnjamesjacoby,Fix typo. See #2090.
changeset,0000006270,[6270],johnjamesjacoby,Fix typos in core options documentation.
changeset,0000003322,[3322],johnjamesjacoby,Fix typos in forum archive and front page templates pointing to content-archive-forums.php instead of content-archive-forum.php.
changeset,0000006249,[6249],johnjamesjacoby,Fix typos in more documentation.
changeset,0000006648,[6648],johnjamesjacoby,"Fix undeclared array in forum template functions for PHP 7.1 compatibility.
Props hellofromTonya. See #3031. (2.5 branch)"
changeset,0000006647,[6647],johnjamesjacoby,"Fix undeclared arrays for PHP 7.1 compatibility.
Props hellofromTonya. See #3031. (2.5 branch)"
changeset,0000003372,[3372],johnjamesjacoby,Fix uninstantiated $bbp global in bbp_theme_compat_set_theme(). Props nacin.
changeset,0000003154,[3154],johnjamesjacoby,Fix user profile styling conflicts when bbp-twentyten is the active theme.
changeset,0000005244,[5244],johnjamesjacoby,Fix variable variable in `bbp_get_reply_author_link()` causing incorrect title attribute. Fixes #2505. (2.5 branch)
changeset,0000005245,[5245],johnjamesjacoby,Fix variable variable in `bbp_get_reply_author_link()` causing incorrect title attribute. Fixes #2505. (trunk)
changeset,0000002887,[2887],johnjamesjacoby,Fix verbiage in comment from r2886
changeset,0000003466,[3466],johnjamesjacoby,Fix verbiage in comment in bbp-languages/index.php.
changeset,0000006702,[6702],johnjamesjacoby,Fix weird indentation in `bbp_get_admin_repair_tool_run_url()`.
changeset,0000002466,[2466],johnjamesjacoby,Fix wrong topics slug
changeset,0000005427,[5427],netweb,"Fixed topic sticky status importing method for compatibility when `wp_bbconverter_translator` database sync_table exists.
* Topic stickies and super stickies are correctly stuck with or without sync_table
* Renamed sticky meta key `_bbp_old_sticky_status` to `_bbp_old_sticky_status_id` for importers that support stickies
See #2650"
changeset,0000002489,[2489],johnjamesjacoby,Fixes #1312 props GautamGupta
changeset,0000002553,[2553],johnjamesjacoby,Fixes #1315. Introduce topic reply template tags. Props !GautamGupta
changeset,0000002535,[2535],johnjamesjacoby,Fixes #1319.
changeset,0000002555,[2555],johnjamesjacoby,Fixes #1321 props markmcwilliams
changeset,0000002586,[2586],johnjamesjacoby,Fixes #1321. Also add checks to topic_id and forum_id functions.
changeset,0000002540,[2540],johnjamesjacoby,Fixes #1326 props mr_pelle
changeset,0000002603,[2603],johnjamesjacoby,Fixes #1329
changeset,0000002566,[2566],johnjamesjacoby,Fixes #1333 props anthonycole
changeset,0000002604,[2604],johnjamesjacoby,Fixes #1357 by rearranging the activation and deactivation procedures.
changeset,0000002741,[2741],johnjamesjacoby,Fixes #1361. Introduce 'Forum Moderator' role. Props !GautamGupta via Google Code-in
changeset,0000002671,[2671],johnjamesjacoby,Fixes #1372 props markmcwilliams
changeset,0000002672,[2672],johnjamesjacoby,Fixes #1374
changeset,0000002734,[2734],johnjamesjacoby,"Fixes #1377, #1390, #1412, #1378. Error handling on form submission, and better anonymous user handling. Props !GautamGupta via Google Code-in."
changeset,0000002702,[2702],johnjamesjacoby,Fixes #1383 again. Native eol-style on new files. Props westi for svn autoprops.
changeset,0000002679,[2679],johnjamesjacoby,Fixes #1383 props westi
changeset,0000002687,[2687],johnjamesjacoby,Fixes #1387
changeset,0000002705,[2705],johnjamesjacoby,Fixes #1391 props elfin
changeset,0000002721,[2721],johnjamesjacoby,Fixes #1397
changeset,0000002711,[2711],johnjamesjacoby,Fixes #1399 props !GautamGupta
changeset,0000002712,[2712],johnjamesjacoby,Fixes #1400 props !GautamGupta
changeset,0000002713,[2713],johnjamesjacoby,Fixes #1401 props !GautamGupta
changeset,0000002716,[2716],johnjamesjacoby,Fixes #1402 props !GautamGupta
changeset,0000002714,[2714],johnjamesjacoby,Fixes #1403 props !GautamGupta
changeset,0000002764,[2764],johnjamesjacoby,Fixes #1423. Props !GautamGupta via Google Code-in
changeset,0000002749,[2749],johnjamesjacoby,Fixes #1435 props !GautamGupta
changeset,0000002993,[2993],johnjamesjacoby,Fixes #1496. Documentation clean-up. Fix incorrect references to split/merge. Fix incorrect post_field usage where post_parent was used rather than post_type. Fix incorrect function usage for querying topic id's from a forum. Props !GautamGupta
changeset,0000005287,[5287],johnjamesjacoby,Fixes PHPUnit Multisite tests and sets up grunt build-realease to run all PHPUnit tests when building release package (Single & Multisite.) Props netweb. See #2542.
changeset,0000003304,[3304],johnjamesjacoby,"Fixes to forum and topic archive links. Always set has_archive to archive slug settings. Use get_post_type_archive_link() where appropriate instead of relying on home_url( $slug ). Add bbp_get_page_by_path() function to theme compat, to check for pretty permalinks first. Introduce default 'page_for' options, which will provide a more straight-forward method of assigning WordPress pages to bbPress functionalities."
changeset,0000002497,[2497],johnjamesjacoby,Fixes wrong post type count. props Nightgunner5.
changeset,0000003159,[3159],johnjamesjacoby,Flesh out current-user topic-form access functions with more appropriate hierarchy of checks. Fix #1516.
changeset,0000003074,[3074],johnjamesjacoby,Flush rewrite rules when the admin settings page is saved
changeset,0000003073,[3073],johnjamesjacoby,Flush the rewrite rules when bbPress is activated and deactivated
changeset,0000005573,[5573],netweb,"FluxBB importer: Include Subscribed Forums and Subscribed Topics
Props netweb. See #2668
"
changeset,0000002646,[2646],johnjamesjacoby,Follow my own rules in BBP_Admin
changeset,0000005037,[5037],johnjamesjacoby,"For all template functions that output URL's, always echo an escaped value using esc_url(). See #2367."
changeset,0000005001,[5001],johnjamesjacoby,"For inline code blocks in topics and replies, ensure they are vertically positioned in the middle of their respective lines of text. Fixes issue where code snippets were top-aligned based on paragraph line-height. See #2350."
changeset,0000005243,[5243],johnjamesjacoby,"For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (2.5 branch)"
changeset,0000005242,[5242],johnjamesjacoby,"For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (trunk)"
changeset,0000005227,[5227],johnjamesjacoby,Force `colors-fresh` dependency to act as a foundation for `Mint` and `Evergreen` color schemes. Fixes #2462.
changeset,0000004418,[4418],johnjamesjacoby,Force a max-width on forum drop-down in default templates.
changeset,0000003589,[3589],johnjamesjacoby,"Force comment_status to 'closed' for forums, topics, and replies. Fixes #1676."
changeset,0000002499,[2499],johnjamesjacoby,Force counts to pick up all descendants of proper post type.
changeset,0000003103,[3103],johnjamesjacoby,"Force forums, topics, and replies tables to clear the pagination floating above it, for theme compat."
changeset,0000005392,[5392],johnjamesjacoby,"Force integer value in `bbp_has_topics()` for reply position. Fixes bug when there are more than 1,000 replies. Props DrPepper75. Fixes #2615."
changeset,0000002472,[2472],chrishajer,"Forgot to add in new functions.php files for kakumei and kakumei-blue. Fixes #1268. Props !GautamGupta
"
changeset,0000004278,[4278],johnjamesjacoby,"Form Actions:
* Use the_permalink() as a form action in forum/topic/reply forms.
* See #1996."
changeset,0000006094,[6094],johnjamesjacoby,Format `bbp_get_reply_title()` like `bbp_get_topic_title()`.
changeset,0000003903,[3903],johnjamesjacoby,"Formatting:
* 'elseif' not 'else if' in bbp-template-functions.php
* Ignore my OCD."
changeset,0000004642,[4642],johnjamesjacoby,"Formatting:
* Rename kses.php to formatting.php.
* Port bbPress 1.1 code and pre tag handling. Comes with filters and callbacks to allow code wrapped in pre & code elements, and backticks.
* Revert r4641, r4640,
* See #1967."
changeset,0000006378,[6378],johnjamesjacoby,Formatting: Add rel-nofollow to tests. See #2963.
changeset,0000006347,[6347],johnjamesjacoby,"Formatting: Filter out mention classes in unit tests, and remove `rel=""nofollow""` on mention URLs.
Also improve array handling of `bbp_make_mentions_clickable_classes` filter, in the event something weird gets filtered through it.
See #3074.
"
changeset,0000007159,[7159],johnjamesjacoby,"Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the ""right now"" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - ""0, 0"" will now correctly fallback to ""right now"".
In branches/2.6, for 2.6.6. See #3398."
changeset,0000007160,[7160],johnjamesjacoby,"Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the ""right now"" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - ""0, 0"" will now correctly fallback to ""right now"".
In trunk, for 2.7. Fixes #3398."
changeset,0000006377,[6377],johnjamesjacoby,"Formatting: More tests for at-mentions.
Props netweb. See #2963."
changeset,0000007120,[7120],johnjamesjacoby,"Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In branches/2.6, for 2.6.6.
Props peterkueger."
changeset,0000007121,[7121],johnjamesjacoby,"Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In trunk, for 2.7.
Props peterkueger.
Fixes #3390."
changeset,0000007082,[7082],johnjamesjacoby,"Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In 2.6 branch, for 2.6.5.
See #3371.
"
changeset,0000007083,[7083],johnjamesjacoby,"Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In trunk, for 2.7.0.
See #3371.
"
changeset,0000006861,[6861],johnjamesjacoby,"Formatting: update `bbp_get_time_since()` to accept MySQL formatted string in older & newer dates.
Also cast values to int using `intval()` to ensure math always works, without notices or errors.
This change adds a bit more validation on potentially untrusted values.
See #3216.
"
changeset,0000006885,[6885],johnjamesjacoby,"Formatting: update `bbp_make_clickable()` to better handle spaces in `href` attributes.
This change updates the included regular expression to avoid returning broken (or at least unexpected) HTML and allows spaces in `href` attributes to be encoded as expected.
Props dd32. Fixes #3237."
changeset,0000006722,[6722],johnjamesjacoby,"Formatting: Use `mb_substr()` where appropriate.
This change ensures that strings which are known to contain or allow for multibyte characters are allowed to do so (in excerpts and a few server globals.)
Fixes #3170. Props it4life.
"
changeset,0000006555,[6555],johnjamesjacoby,"Forms: Add `autocomplete` attribute to user related form fields.
`autocomplete=""new-password""` is new, and browser support is gaining, but it's also not any worse than `autocomplete=""off""` (where most browsers & password managers have a hard time respecting the etiquitte anyways.)"
changeset,0000006557,[6557],johnjamesjacoby,"Forms: Add `maxlength` attribute to the appropriate form fields.
Fields like `user_login`, `user_url`, and `user_email` have upper boundaries that cannot be extended via meta-data or other means, so let's make sure users aren't (easily) able to go over them.
For the anonymous user fields, set them up to match comment field lengths (even though they are stored in `postmeta`.)"
changeset,0000006248,[6248],johnjamesjacoby,"Forms: Audit & normalize form-field sanitization.
* Make sure they all work the same
* Use filters in `core/filters.php` where appropriate
* Add `absint` filters for numeric values
* Add filters for per-forum moderator text field
* Remove any accidental duplicate escaping"
changeset,0000006556,[6556],johnjamesjacoby,"Forms: formally update password change text.
It was accidentally partially changed in r6555."
changeset,0000006837,[6837],johnjamesjacoby,"Forms: include forum/topic ID in nonce checks.
This change adds in missing object IDs, fixing a bug causing form content to be lost when an error had occurred.
Props wpdennis. Fixes #3209.
"
changeset,0000006433,[6433],johnjamesjacoby,"Forms: Introduce `bbp_tab_index_attribute()` helpers to handle `tabindex` attribute output.
Note that these functions are used but normally their output is suppressed, because overriding the browser's natural `tabindex` order is impolite, and may introduce more issues than it actually fixes.
(Also includes some surrounding code clean-up.)"
changeset,0000004118,[4118],johnjamesjacoby,"Forum Actions:
* Remove bbp_has_topics() from forum trash and topic delete functions.
* Use WP_Query's instead.
* Remove phpdoc references to bbp_has_topics() where it's no longer used.
* Fixes #1914.
* For 2.1 branch."
changeset,0000004117,[4117],johnjamesjacoby,"Forum Actions:
* Remove bbp_has_topics() from forum trash and topic delete functions.
* Use WP_Query's instead.
* Remove phpdoc references to bbp_has_topics() where it's no longer used.
* Fixes #1914.
* For 2.2 branch."
changeset,0000005156,[5156],johnjamesjacoby,"Forum Subscriptions - Allow users to subscribe to new topics in specific forums.
* Code largely lifted from existing Topics Subscriptions, and is based largely on `forum-subscriptions.2.diff` from mordauk, with edits for code consistency across bbPress components.
* Refactor existing ambiguous function names into base functions for both forum and topic subscriptions.
* Include new functions for getting and outputting subscriptions.
* Modify `user-subscriptions.php` to show subscribed forums. This includes a modification to `content-single-forum.php` to include the ""Unsubscribe"" link if looking at a user profile page.
* Modify `templates/default/bbpress-functions.php` to enqueue new JS file to handle forum subscription ajax.
* Rename HTML element classes from `bbp-topic-action` to `bbp-row-actions` to better accommodate forum subscriptions (and any future actions.)
* BuddyPress tested, JJJ approved.
* See #2299. Props mordauk, netweb for the considerable effort.
* More to do here, largely from `forum-subscriptions.3.diff`"
changeset,0000005157,[5157],johnjamesjacoby,"Forum Subscriptions:
* Update `@since` and `@deprecated` to r5156.
* Introduce tool for removing trashed and deleted forums from user subscriptions.
* See #2299. Props netweb."
changeset,0000004104,[4104],johnjamesjacoby,"Forum Visibility:
* Prevent forum metaboxes from saving forum revisions as private/hidden.
* Add repair function for private/hidden forums to Tools.
* Add updater for 2.1.1, and run the visibility repair function.
* Fixes #1891.
* For 2.1 branch."
changeset,0000004105,[4105],johnjamesjacoby,"Forum Visibility:
* Prevent forum metaboxes from saving forum revisions as private/hidden.
* Add repair function for private/hidden forums to Tools.
* Add updater for 2.1.1, and run the visibility repair function.
* Fixes #1891.
* For 2.2 branch."
changeset,0000004416,[4416],johnjamesjacoby,"Forums Admin:
* More aggressive CSS for forum parent."
changeset,0000004414,[4414],johnjamesjacoby,"Forums Admin:
* Revert usage of Suggest for choosing a forum parent via auto-complete.
* Revert parts of r4260 and r4261.
* See #1910, #2014."
changeset,0000004415,[4415],johnjamesjacoby,"Forums Admin:
* Set max-width to 170px for forum parent ID."
changeset,0000004417,[4417],johnjamesjacoby,"Forums Admin:
* Update 'order' and 'orderby' for get_posts() usage to sort by 'title' and not 'post_title'."
changeset,0000004071,[4071],johnjamesjacoby,"Forums:
* Do not add forum-exclude meta-query to single reply queries."
changeset,0000004438,[4438],johnjamesjacoby,"Forums:
* Do not disable categories on forum parent drop downs in wp-admin.
* Disable forum parents in topic and reply edits if user cannot edit forums.
* This is to prevent innocent users from accidentally putting content in a forum category."
changeset,0000004167,[4167],johnjamesjacoby,"Forums:
* Remove superfluous is_super_admin() login in bbp_has_forums().
* Capes always pass current_user_can() checks unless specifically not allowed, which is the intended behavior here."
changeset,0000006273,[6273],johnjamesjacoby,"Forums: Add `howto` text to `bbp_moderator_assignment_metabox()`.
See #459."
changeset,0000006478,[6478],johnjamesjacoby,Forums: Add forum-type & status to allowed meta keys.
changeset,0000006357,[6357],netweb,"Forums: Add missing `@since` PHPDoc to `bbp_list_forums()`
"
changeset,0000005683,[5683],johnjamesjacoby,"Forums: Audit `template.php`:
* General code formatting improvements
* Pass `$args` into more filters
* Escape more gettext output
* Un-nest a few complex-looking lines"
changeset,0000006414,[6414],johnjamesjacoby,"Forums: Audit private/hidden forum ID exclusion:
* improve performance of `bbp_exclude_forum_ids()`
* Use `bbp_exclude_forum_ids()` where duplicate code existed
* Make sure `$forum_ids` are passed into `bbp_exclude_forum_ids` filter
* Prefer arrays over imploded strings (also with post statuses)"
changeset,0000006480,[6480],johnjamesjacoby,Forums: be strict in `array_search()` calls.
changeset,0000007052,[7052],johnjamesjacoby,"Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.6.4, branches/2.6."
changeset,0000007051,[7051],johnjamesjacoby,"Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.7, trunk."
changeset,0000007085,[7085],johnjamesjacoby,"Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In branches/2.6, for 2.6.5.
See #3374.
"
changeset,0000007084,[7084],johnjamesjacoby,"Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In trunk, for 2.7.0.
See #3374.
"
changeset,0000005855,[5855],johnjamesjacoby,"Forums: Fix copy-pasta filter names.
This changeset corrects filters used in 2 `apply_filters()` calls to properly match their function names.
Props netweb. Fixes #2688."
changeset,0000005655,[5655],netweb,"Forums: Fix missing meta data during new forum creation
* Call `bbp_open_forum()` if the forum is ""open"" to add the forum `_bbp_status` = `open` meta
* Call `bbp_normalize_forum()` if the forum is a ""forum"" to add the forum `_bbp_forum_type` = `forum` meta
Props netweb. Fixes #2647
"
changeset,0000005923,[5923],netweb,"Forums: Improve type-casting in forum functions.
Props thebrandonallen. See #2801.
"
changeset,0000006315,[6315],johnjamesjacoby,"Forums: Introduce `bbp_list_forums_subforum_classes` filter, to allow filtering of sub-forum links.
Props gordielachance. Fixes #2760."
changeset,0000005856,[5856],johnjamesjacoby,"Forums: Introduce `bbp_update_forum_visibility` action in `bbp_save_forum_extras()`
This changeset provides custom visibilites with an execution point to perform their own actions.
Fixes #2740."
changeset,0000006718,[6718],johnjamesjacoby,"Forums: make sure topic & reply counts are proper integers for `_n()` usage.
This change fixes a bug where formatted strings would cause an incorrect singular and plural string assignment, in forums that had over 1k posts."
changeset,0000005731,[5731],johnjamesjacoby,"Forums: Normalize type-casting in some count functions. More to do here.
Props thebrandonallen, netweb. See #2801."
changeset,0000006020,[6020],netweb,"Forums: Overzealous type coercion caused `bbp_forum_query_last_reply_id()` to skip the database query in every instance (since 0 is never === false). As such, the resetting of `_bbp_last_reply_id` got short-circuted in some cases.
This fix is for the 2.5 branch, `/trunk` fixed this inadvertantly in [5954]
Props boonebgorges, mauteri.
Fixes #2414.
"
changeset,0000006875,[6875],johnjamesjacoby,"Forums: protect against a missing/malformed `forum_id` value when listing subforums.
Fixes #3232."
changeset,0000006860,[6860],johnjamesjacoby,"Forums: revert default mark-up back to div's and span's in `bbp_list_forums()`.
This fixes potentially invalid mark-up from attempting to use list elements instead of spans.
Also includes changes to CSS selectors to make them more flexible with different child elements.
See #3217.
"
changeset,0000006872,[6872],johnjamesjacoby,"Forums: revert part of r6860.
Go back to `ul` and `li` to avoid breaking CSS for existing installs, and use a CSS separator instead to address the original invalid markup issues.
This might show an extra separator in circumstances where filters or template-overrides are targeting very specific things, but that's better than breaking mark-up changes.
See #3217.
"
changeset,0000007008,[7008],johnjamesjacoby,"Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.6.3, branches/2.6."
changeset,0000007009,[7009],johnjamesjacoby,"Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.7, trunk."
changeset,0000005734,[5734],johnjamesjacoby,"Forums: Type-cast improvements to `bbp_forum_query_last_reply_id()`.
Fixes bug where strict `false` comparison would cache cache condition to never occur.
Props thebrandonallen, netweb. See #2801."
changeset,0000006733,[6733],netweb,"Forums: Update `bbp_untrash_forum_topics()` PHPDoc description.
Props espellcaste.
Fixes #3175.
"
changeset,0000005918,[5918],netweb,"Forums: Updated PHPDocs and unit tests for `bbp_update_forum_last_*()` functions.
Props thebrandonallen. Fixes #2811
"
changeset,0000006024,[6024],johnjamesjacoby,"Forums: Updates to `bbp_list_forums()`:
* Always run filter, even over empty output
* Only wrap output if not empty
* Ensure that `$count` related variables are accurately reset during each loop iteration
* Surrounding code clean-up
Fixes #2951."
changeset,0000006576,[6576],johnjamesjacoby,"Forums: Use `bbp_get_forum_subforum_count()` in `bbp_forum_get_subforums()`.
This performance optimization will result in 1 less query per forum in the forums list that does not have subforums, by checking the subforum meta-data before trying to query for subforums that do not exist anyways.
This is less of an issue with a persistent object cache, but those without that luxury can now save those database queries for when they really matter."
changeset,0000006559,[6559],johnjamesjacoby,"Forums: Use `edit_forum` instead of `keep_gate` in the admin toggle/row methods.
This change trusts the `edit_forum` meta capability to serve it's intended purpose. It also allows more flexibility with things like BuddyPress Group Forums or custom forum-ownership style extensions."
changeset,0000006545,[6545],johnjamesjacoby,"Forums: Use `no_found_rows` by default in `bbp_has_forums()`
Forums do not currently support pagination, so the total number of rows is not traditionally useful for this loop. In cases where it is, it can be explicitly overloaded in the `$args` array.
This results in 1 less database query per page where a forums list is shown, and a speed improvement overall."
changeset,0000002974,[2974],johnjamesjacoby,Full audit of user/topic/reply/view permalinks. Use $wp_rewrite->using_permalinks() method in place of $wp_rewrite->permalink_structure. See r2973
changeset,0000006102,[6102],netweb,"General - Administration: Add i18n text domain missed in [6101]
See #2246.
"
changeset,0000006055,[6055],netweb,"General - Administration: Add pending status topic and reply statistics to `bbp_get_statistics()`
Following the introduction of ""pending"" status topics and replies in bbPress 2.6, `bbp_get_statistics()` now includes these count statistics in the hidden topic and reply statistics.
Fixes #2958.
"
changeset,0000006101,[6101],netweb,"General - Administration: Introduce bulk actions to spam and unspam topics and replies in wp-admin
This Friday #yolo changeset comes care of the upcoming WordPress 4.7 release via #WP16031 / wp:changeset:38647
Props jmdodd.
See #2246.
"
changeset,0000006061,[6061],netweb,"General - Administration: Update ""change forum role"" dropdown
This changeset resolves an issue introduced in WordPress 4.4 ( [WP:changeset:34636] / #WP27743 ) which caused bbPress ""change forum role"" dropdown to only work using the ""bottom"" user list table dropdown, for WordPress versions < 4.6 the ""change forum role"" dropdown is now only shown at the ""top"" of the user list table.
This changeset also adds a new parameter `$which` to `user_role_bulk_dropdown()` which was added in WordPress 4.6 ( [WP:changeset:37422] / #WP35307 ) to pass the location of the extra table nav markup for the ""top"" or ""bottom"" ""change role"" dropdown, and in turn fixes bbPress' ""change forum role"" dropdown to once again work at the ""top"" and ""bottom"" of the user list table.
Props ocean90.
Fixes #2906.
"
changeset,0000006036,[6036],netweb,"General Performance: Introduce increase/decrease helper count functions
Previously when a new topic or reply was created, a bunch of queries to recalculate the topic and reply counts for topics and forums were ran. Now these have been replaced with more efficient increase/decrease helper functions to get the current value and just ""bump"" the count based on the action (new topic-reply/split-topic/move-topic/spam-trash-topic/etc...)
Props thebrandonallen, tharsheblows, netweb
See #1799
"
changeset,0000006046,[6046],netweb,"General: Add debug trace to `bbp_setup_current_user()` notice.
Previously, the `bbp_setup_current_user was called incorrectly` notice would not output any useful info for developers.
This commit adds a debug trace so developers are able to determine
whereabouts in the codebase this notice is originating from.
Props r-a-y
Fixes #2932
"
changeset,0000007054,[7054],johnjamesjacoby,"General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.6.4, branches/2.6."
changeset,0000007055,[7055],johnjamesjacoby,"General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.7, trunk."
changeset,0000006499,[6499],johnjamesjacoby,"General: Audit `wp_insert_post()` usages.
Return a `WP_Error` object in some instances, and explicitly do not in others.
Where possible, use the error message in the user feedback response.
Fixes #2817."
changeset,0000006839,[6839],johnjamesjacoby,"General: Bump to RC6, and related unimpactful changes
* Docs & whitespace
* Update packages
* Update stable tag
* Add changelog section for 2.6 (TBD)
"
changeset,0000007053,[7053],johnjamesjacoby,"General: fix a few typos.
Props ankitmaru, mukesh27. Fixes #3312, #3313, #3315. For 2.7, trunk."
changeset,0000007056,[7056],netweb,"General: fix a few typos.
Props passoniate, wpamitkumar, sharaz.
Fixes #3308, #3316, #3317, #3319, #3323.
"
changeset,0000006371,[6371],netweb,"General: Following [6366] use a single blank line for end-of-file extras templates.
See #3078.
"
changeset,0000006272,[6272],johnjamesjacoby,"General: hyphenate ""meta-box"" in documentation to sooth spell-checkers."
changeset,0000006361,[6361],netweb,"General: Improve verbiage for closed forum and closed topic template notices.
This changeset also adds a template notice to the reply form noting that the forum you're posting to is closed to new content.
Props @SergeyBiryukov.
Fixes #3076.
See also #2353-meta.
"
changeset,0000006554,[6554],johnjamesjacoby,"General: Introduce `bbp_pre_handle_404()` to handle 404 overrides.
This only introduces the function for now. I'll go through and check all of the conditions next.
See #3047.
"
changeset,0000006627,[6627],johnjamesjacoby,"General: Make sure object `_get_` functions reach intended filters.
This retains existing behavior of bailing early and returning `null` if there is a `post_type` mismatch. Other similar functions would pass the `null` value through to the filter. These may do that eventually, but let's get these filters working first.
Fixes #3130."
changeset,0000006684,[6684],johnjamesjacoby,"General: more PHP7.1 array fixes.
See #3031. 2.5 branch, for 2.5.14."
changeset,0000006284,[6284],johnjamesjacoby,"General: Remove `()` around `require` construct calls, and breathing room around some `!` usages."
changeset,0000006366,[6366],johnjamesjacoby,"General: Remove end-of-file `?>` tags from extra templates.
These templates are theme drop-ins, and apparently were missed in previous clean-up efforts.
Props milindmore22. Fixes #3078.
"
changeset,0000006113,[6113],netweb,"General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
Fixes #2987.
"
changeset,0000006417,[6417],netweb,"General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
See #2987.
Merges [6113] to the 2.5 branch.
"
changeset,0000006437,[6437],johnjamesjacoby,General: Tidying from looking into #2876.
changeset,0000006866,[6866],johnjamesjacoby,"General: unslash IP and user agent strings.
These are only used in ways where slashed values are undesirable.
"
changeset,0000006864,[6864],johnjamesjacoby,"General: update `bbp_get_post_types()` to accept arguments to parse before calling `get_post_types()`.
This avoids other manual calls to `get_post_types()` in other places. See #3221."
changeset,0000006691,[6691],netweb,"General: Update changelog date format in `readme.txt`
This changeset is a follow up to [6689].
See https://wordpress.slack.com/archives/C02RQBYSJ/p1505079124000051
"
changeset,0000005684,[5684],johnjamesjacoby,General: Use `sanitize_text_field()` in lieu of old-bbPress style pre-escaping technique.
changeset,0000006777,[6777],johnjamesjacoby,"General: user escaped GetText variant where no HTML is ever allowed in strings.
This change brings a few dozen strings up to par with the others, and ensures that strings are escaped on their way into the runtime environment."
changeset,0000002546,[2546],johnjamesjacoby,"Get some twentyten child theme files in. Some are placeholders, some are started."
changeset,0000002726,[2726],mdawaffe,get_forum() is deprecated. use bb_get_forum()
changeset,0000002719,[2719],mdawaffe,"get_recent_user_replies() was returning the first post in each topic, not the last.
I'm not sure how this ever worked: http://dev.mysql.com/doc/refman/5.0/en/example-maximum-column-group-row.html
Switch to MAX( post_id ) and ignore post_time for now.
"
changeset,0000002612,[2612],johnjamesjacoby,Give some color to the table heads and foots
changeset,0000003714,[3714],johnjamesjacoby,"Global $post usage clean-up:
* Use bbp_get_global_post_field() where appropriate, core WP functions otherwise
* Replace local $post variables with $post to avoid stomping the global
* Audit usage of bbp_get_global_post_field() and make sure we are providing the correct context
* Fixes #1733."
changeset,0000006582,[6582],johnjamesjacoby,Globals: Use `bbp_get_global_object()` instead of touching `$wp_query` directly in template functions.
changeset,0000005171,[5171],johnjamesjacoby,"Go back to direct DB queries when changing forum visibilities. Fixes issues with visibility not saving correctly, at least for now. Fixes #2408, hat-tip netweb."
changeset,0000003666,[3666],johnjamesjacoby,Go live with bbp_query_post_parent__in() filter.
changeset,0000002899,[2899],johnjamesjacoby,Grammar fixes in warning messages in bbp-twentyten. Props scribu.
changeset,0000004139,[4139],johnjamesjacoby,"Green Scheme:
* Remove duplicate stylesheets for dealing with wp-content directory depth.
* Move image styling into admin_head method and get the admin URL in PHP.
* Remove referencs to content_depth variable.
* This will make it more difficult to merge admin styling in later, but easier to maintain and result in a smaller package."
changeset,0000004140,[4140],johnjamesjacoby,"Green Scheme:
* Remove duplicate stylesheets for dealing with wp-content directory depth.
* Move image styling into admin_head method and get the admin URL in PHP.
* Remove referencs to content_depth variable.
* This will make it more difficult to merge admin styling in later, but easier to maintain and result in a smaller package.
* For 2.1 branch. Backported from 2.2-bleeding as a bonus."
changeset,0000004372,[4372],johnjamesjacoby,"Green Scheme:
* Tweak the green scheme so it's less broken in !WordPress 3.5.
* Since admin CSS is not final, this may change, or need more tweaks."
changeset,0000003904,[3904],johnjamesjacoby,"Group Forums:
* PHP5ize the classes.
* Rearrange some methods.
* Allow BBP_BuddyPress class to be modified after load.
* Code formatting fixes."
changeset,0000005346,[5346],netweb,"Grunt is deprecating the Grunt.Util.* api, adding `grunt-legacy-util` will allow us to continue using `grunt.util.spawn` to spawn the multiple `phpunit` Grunt tasks.
* Adds `grunt-legacy-util` to `package.json`
* Requires fresh `npm install` to update dependencies
* Props netweb. Fixes #2576
"
changeset,0000005271,[5271],johnjamesjacoby,"Gruntify bbPress trunk (part 2):
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542."
changeset,0000005270,[5270],johnjamesjacoby,"Gruntify bbPress trunk:
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542."
changeset,0000002733,[2733],johnjamesjacoby,Handle situation where all topics have replies when viewing the bbp_no_replies page.
changeset,0000007233,[7233],johnjamesjacoby,"Headers: update plugin headers, in branches/2.6 for 2.6.10.
"
changeset,0000007232,[7232],johnjamesjacoby,"Headers: update plugin headers, in trunk for 2.7.0.
"
changeset,0000006821,[6821],johnjamesjacoby,"Help: Update Forums & Topics help text.
* Tweak action order
* Grammar improvements
* Add ""Close"" action to forums
"
changeset,0000006441,[6441],johnjamesjacoby,"Help: Update help text, and include a bit about the ""Theme Packages"" section."
changeset,0000003047,[3047],johnjamesjacoby,Hidden forums are always hidden.
changeset,0000006303,[6303],johnjamesjacoby,"Hidden: Remove ""+ "" string portion from output from hidden content.
This is a carry-over from bbPress 0.x, is superfluous in the given context, and previously could have presented misleading results if a negative value was presented.
Fixes #3059."
changeset,0000006354,[6354],johnjamesjacoby,"Hidden: Revert part of r6303, and improve some surrounding code:
* Tiny function-call optimizations
* Use integers for `_n()` and formatted strings for output
* Type casting, phpdoc, and code formatting improvements
Fixes #3077.
"
changeset,0000003485,[3485],johnjamesjacoby,Hide favorites link(s) if favorites are not active.
changeset,0000003425,[3425],johnjamesjacoby,Hide potential variable not defined debug notice. Fixes #1560. Props !GautamGupta.
changeset,0000003191,[3191],johnjamesjacoby,"Hide recount tool menu behind admin class variable, as forum recounts are hugely costly when done site wide and should not be so readily available."
changeset,0000004809,[4809],johnjamesjacoby,Hide super sticky related output from group forums. Props imath. Fixes #2227.
changeset,0000002822,[2822],johnjamesjacoby,Hide the revision log in admin topics and replies. Fixes #1451 props !GautamGupta
changeset,0000004051,[4051],johnjamesjacoby,"HiDPI:
* Add 2x icons for icon32's.
* Fixes #1839."
changeset,0000004052,[4052],johnjamesjacoby,"HiDPI:
* Tweak CSS for 2x icon32's.
* See #1839."
changeset,0000002563,[2563],johnjamesjacoby,Hierarchical false on replies for now
changeset,0000004944,[4944],johnjamesjacoby,"Hierarchical replies:
* Introduce setting, option, functions, JS, CSS, and Walker class to support hierarchical replies.
* Tweak functions where saving the additional reply_to meta data is necessary.
* Add meta data field in dashboard to show the reply_to ID.
* There will likely be more tweaking necessary, as we test this further and get more eyes on the code.
* Fixes #2036.
* Props jmdodd for this huge effort."
changeset,0000006528,[6528],johnjamesjacoby,"Hierarchy: Use `post_parent` when not empty, and fallback to meta-data.
This fixes a few weird inconsistencies with how deleting content works, because `delete_` hooks fire after meta & terms have already been deleted from the database, `deleted_` hooks fire after the post itself is deleted from the database, but the post object cache has not yet been cleaned (even though term & meta caches have.)
We also call a few functions like `bbp_is_reply()` on the deleted `$postid`, and even though the state of the object-cache should not be relied on, it has not been purged yet.
Relatedly, updates to forum & topic descriptions can more reliably identify their state, so this commit adjusts some logic there also."
changeset,0000003687,[3687],johnjamesjacoby,Hook missing forum contextual help in. See #1699.
changeset,0000003652,[3652],johnjamesjacoby,Hook topic and reply trash actions onto new wp_trash_post hook introduced in WordPress 3.3. Fix #1707.
changeset,0000003311,[3311],johnjamesjacoby,"Huge theme compatibility audit. This normalizes all of the function names, template files, actions, and globals surrounding theme compatibility."
changeset,0000004381,[4381],johnjamesjacoby,"Humans:
* Add jmdodd to thanks list."
changeset,0000006579,[6579],netweb,"Humans: I like tacos 🌮
"
changeset,0000004668,[4668],johnjamesjacoby,"I don't see nothing wrong, with a little bump and grind."
changeset,0000005829,[5829],johnjamesjacoby,"I think this building should be condemned. There's serious metal fatigue in all the load-bearing members, the wiring is substandard, it's completely inadequate for our power needs, and the neighborhood is like a demilitarized zone."
changeset,0000004215,[4215],johnjamesjacoby,"i10n:
* Add domain property in setup_globals().
* Cleanup bbPress::load_textdomain()."
changeset,0000004214,[4214],johnjamesjacoby,"i10n:
* Deprecate 'bbpress_locale' filter.
* Rearrange mofile loading priority, to include global file location before plugin directory one."
changeset,0000006042,[6042],netweb,"i18n: Avoid using HTML tags in translation strings
Props ramiy, thebrandonallen
Fixes #2881
"
changeset,0000006043,[6043],netweb,"i18n: Avoid using HTML tags in translation strings (includes/admin/forums.php)
Props ramiy, thebrandonallen
Fixes #2910
"
changeset,0000006045,[6045],netweb,"i18n: Avoid using HTML tags in translation strings (includes/admin/replies.php)
Props ramiy, thebrandonallen
Fixes #2912
"
changeset,0000006044,[6044],netweb,"i18n: Avoid using HTML tags in translation strings (includes/admin/topics.php)
Props ramiy, thebrandonallen
Fixes #2911
"
changeset,0000006646,[6646],SergeyBiryukov,"i18n: Fix typo in text domain used for `_n()` in `bbp_get_time_since()`.
See #3139."
changeset,0000006645,[6645],johnjamesjacoby,"i18n: Improvements to `bbp_get_time_since()`.
Use `_n_noop()` to register year/month/week/day/hour/minute/second strings in advance and `_n()` to actually translate them.
Fixes #3139. Props SergeyBiryukov."
changeset,0000005940,[5940],netweb,"i18n: Merge similar translation strings
This changset brings consistency to failed warning strings in our repair tools and removes extra whitespace in two strings. This reduces the number of strings that our translation volunteers need to translate.
Props ramiy. Fixes #2880
"
changeset,0000006649,[6649],SergeyBiryukov,"i18n: Simplify [6645] with `translate_nooped_plural()`.
See #3139."
changeset,0000006356,[6356],netweb,"i18n: Update translation context for open/close strings in `bbp_get_topic_close_link()` and approve/unapprove stringsin `bbp_get_topic_approve_link()`
Props fiskhandlarn.
Fixes #3023.
"
changeset,0000005842,[5842],johnjamesjacoby,"IDs: Some reply functions still default to their topics if no replies are present. This functionality has slowly been removed over time and built into respective functions. In this changeset, we remove those leftover assignments and update a few phpdoc descriptions as needed.
Hat-tip netweb. See #2806."
changeset,0000005397,[5397],johnjamesjacoby,"If a reply is a reply to another reply, display the parent reply information in the form legend with the topic title. Props netweb. Fixes #2509."
changeset,0000005174,[5174],johnjamesjacoby,"If not deleting users, delete the imported user meta-data instead. See #1889. Props netweb."
changeset,0000005059,[5059],johnjamesjacoby,"If pre-option exists for threaded replies depth, make sure it's correctly disabled."
changeset,0000003218,[3218],johnjamesjacoby,"If settings fields are empty, automatically revert them to their defaults. This adds an additional parameter to bbp_form_option() function to pass the default value."
changeset,0000003808,[3808],johnjamesjacoby,"If there is no topic or reply, bail early out of respective _update_ functions to avoid a ton of errors and bad things from happening."
changeset,0000002830,[2830],johnjamesjacoby,"If topic is being permanently deleted, redirect back to forum."
changeset,0000003210,[3210],johnjamesjacoby,"If user has unfiltered_html capability, add notice to the top of topic and reply forms and hide the form-allowed-tags section."
changeset,0000007165,[7165],johnjamesjacoby,"Ignore pnpm-lock.yaml in Subversion. See r7164.
"
changeset,0000007164,[7164],johnjamesjacoby,"Ignore pnpm-lock.yaml.
pnpm is an optional alternative to npm, allowing for global sharing of dependencies, which is particularly useful for WordPress plugins.
"
changeset,0000003659,[3659],johnjamesjacoby,Implement topic view feeds. Fixes #1716.
changeset,0000005526,[5526],netweb,"Importer templates updates to coincide with r5525 changeset to differentiating original forum, topic and reply meta ID's from new bbPress post meta keys.
* Renames `_bbp_forum_id` to `_bbp_old_forum_id`
* Renames `_bbp_topic_id` to `_bbp_old_topic_id`
* Renames `_bbp_post_id` to `_bbp_old_reply_id`
See #2650"
changeset,0000006928,[6928],johnjamesjacoby,"Importer: make inside meta-box contents a bit more squared.
This change fixes a padding issue with the inner meta-box content, causing there to be more space on the bottom than on the top."
changeset,0000006929,[6929],johnjamesjacoby,"Importer: remove byref usade in parser.php.
This commit removes an old byref in the bbCode parser. It wasn't really necessary, and was causing problems with certain PHP versions.
Fixes #3257. Props webmaigcz."
changeset,0000006767,[6767],johnjamesjacoby,"Importers: `setup_globals()` is a public method.
This change fixes a bug with the vBulletin importer causing it not to run.
See r6766 for the vBulletin3 equivalent."
changeset,0000006766,[6766],johnjamesjacoby,"Importers: `setup_globals()` is a public method.
This change fixes a bug with the vBulletin3 importer causing it not to run."
changeset,0000005989,[5989],netweb,"Importers: Add support for anonymous topic and reply import support in XenForo (XenForo.php) importer
This changeset adds support for importing topics and replies where the original XenForo author was deleted, this keeps the original author name as the now topic or reply anonymous author name.
Props netweb.
Fixes #2922, See aslo #2347.
"
changeset,0000006041,[6041],netweb,"Importers: In `BBP_Converter_Base::convert_table()` method use `isset()` rather than `! is_null`
Props Offereins
Fixes #2733
"
changeset,0000005795,[5795],netweb,"Importers: Update phpbB importer to support phpBB 3.1.x database schema changes
* Note: Importing from phpBB 3.0.x is no longer supported, please update to phpBB 3.1.x before importing
Props netweb. Fixes #2716
"
changeset,0000005800,[5800],netweb,"Importers: Updated AIM, YIM, and Jabber user meta key prefixes importer user profile fields for AEF, FluxBB, Kunena3, MyBB, PunBB, SMF, XMB, vBulletin and vBulletin3 importers
Props netweb. Fixes #2815
"
changeset,0000003657,[3657],johnjamesjacoby,Improve bbp_is_activation() and bbp_is_deactivation() to include bulk actions. Props duck_. Fixes #1660.
changeset,0000002808,[2808],johnjamesjacoby,Improve bbp_list_subforums function with additional formatting args
changeset,0000004856,[4856],johnjamesjacoby,"Improve CSS for pre/code blocks, to allow code to scroll horizontally within a pre tag."
changeset,0000004858,[4858],johnjamesjacoby,"Improve CSS for pre/code blocks, to allow code to scroll horizontally within a pre tag; includes minification. (trunk)"
changeset,0000002703,[2703],johnjamesjacoby,Improve current_user_id and displayed_user_id functions. Also remove Page Template ability from User templates.
changeset,0000004623,[4623],johnjamesjacoby,Improve default pagination styling (includes RTL). Hat-tip corsonr. Fixes #2124.
changeset,0000002735,[2735],johnjamesjacoby,Improve fieldset reply notice when topic is closed but user can still reply.
changeset,0000005558,[5558],johnjamesjacoby,Improve form field output sanitization when posting theme-side forum/topic/reply content. Thanks planetzuda. See #2719.
changeset,0000003855,[3855],johnjamesjacoby,Improve forum and topic description texts to include empty cases.
changeset,0000005121,[5121],johnjamesjacoby,Improve function locations introduced in r5120. Ensures template and helper functions are in template.php. See #2426.
changeset,0000005497,[5497],johnjamesjacoby,Improve ID and classification in `form-topic.php` when forum is closed or user cannot create new topics. Props netweb. Fixes #2574.
changeset,0000002992,[2992],johnjamesjacoby,Improve inline documentation in bbp_update_forum_last_reply_id() and remove unneeded empty variable check. Also cast some variables as integers when comparing their values to be safe.
changeset,0000002972,[2972],johnjamesjacoby,Improve logic behind setting the current_forum/topic/reply_id global variables
changeset,0000004818,[4818],johnjamesjacoby,"Improve logic in topics loop, so that super-stickies are always above forum-stickies. Props alex-ye. Fixes #2260."
changeset,0000004666,[4666],johnjamesjacoby,Improve margins on TinyMCE quicktags. Includes RTL.
changeset,0000004900,[4900],johnjamesjacoby,Improve micro-performance of favorites and subscriptions by moving function calls after sanity checks. Also typecast the return value of respective get_topic_ids functions. See #2331.
changeset,0000005269,[5269],johnjamesjacoby,"Improve naming of new ""At a Glance"" metabox filter, and lower priority to increase odds of hugging more closely to WordPress core items. See #2544."
changeset,0000005334,[5334],johnjamesjacoby,Improve output of `grunt jshint` task. See #2578.
changeset,0000002587,[2587],johnjamesjacoby,Improve page-bbp_front.php
changeset,0000002696,[2696],johnjamesjacoby,Improve query count in bbp_get_reply_url
changeset,0000003220,[3220],johnjamesjacoby,Improve RTL support in Right Now dashboard widget. Fixes #1536.
changeset,0000003186,[3186],johnjamesjacoby,"Improve support for forum and topic archives pages, and improve explanations on forums settings slugs section. Remove archive-reply.php from bbp-twentyten. "
changeset,0000003260,[3260],johnjamesjacoby,"Improve support for orphaned topics and replies in admin post rows by displaying ""No Forum"" and ""No Topic"" if parents have been deleted."
changeset,0000003162,[3162],johnjamesjacoby,Improve support of suppressing private forum meta data. Fixes #1522. Props !GautamGupta.
changeset,0000003265,[3265],johnjamesjacoby,"Improve the current title area of breadcrumbs.
Improve behavior of redirect field.
Allow single topic shortcodes to use pagination, and properly redirect on new replies.
Use wp_safe_redirect() in places where redirect_to fields are used.
Move theme compatibility setup function out of main bbPress class and into bbp-core-compatibility.php.
Move bbp_setup_theme_compat action off of after_setup_theme and into bbp_init.
Add supplemental functions to get and set if theme compatibility is currently helping load pieces of the current page."
changeset,0000005018,[5018],johnjamesjacoby,Improve the flexibility of bbp_title() by allowing all data to be filtered. Props alex-ye. Fixes #1764.
changeset,0000003495,[3495],johnjamesjacoby,Improve the forum prefix settings description.
changeset,0000004640,[4640],johnjamesjacoby,Improve the output of code between pre and code HTML tags. Fixes #1967.
changeset,0000003086,[3086],johnjamesjacoby,Improve theme compat CSS for topic/reply fieldsets
changeset,0000003034,[3034],johnjamesjacoby,"Improve theme compatability by using the active themes page.php template file to display the contents of a forum, topic, or reply."
changeset,0000002698,[2698],johnjamesjacoby,Improve topic and reply pagination verbiage
changeset,0000004714,[4714],johnjamesjacoby,Improve usage of make_clickable filter on topic and reply content. Fixes #2149.
changeset,0000004931,[4931],johnjamesjacoby,"Improve user logic in bbp_parse_query(), so that numeric user slugs display correctly even when pretty permalinks are enabled. Also eliminates duplicate get_userdata() call, and renames some variables to prevent accidental stomping."
changeset,0000003059,[3059],johnjamesjacoby,Improve user/forum visibility check and add some inline php documentation.
changeset,0000002736,[2736],johnjamesjacoby,Improve widget code. Add topic/reply ordering. Props !GautamGupta
changeset,0000002750,[2750],johnjamesjacoby,Improve widgets. Props !GautamGupta via Google Code-in
changeset,0000005519,[5519],netweb,"Improved `Drupal7.php` importer performance by leaning on our helper functions.
* Use `callback_topicid_to_forumid()` to convert the topic ID to forum ID eliminating an extra MySQL join."
changeset,0000002623,[2623],johnjamesjacoby,Improved error messages for users that are not logged in.
changeset,0000005483,[5483],netweb,Improved inline docs readability for Grunt task `jshint`.
changeset,0000004660,[4660],johnjamesjacoby,Improved margins for author and content of single topic views. Also fixes single topic RTL margins.
changeset,0000005160,[5160],netweb,Improved SQL join expression for topics 'post_content' in Mingle.php importer. Props netweb. Fixes #2472
changeset,0000004598,[4598],johnjamesjacoby,"Improved styling for inner topic and reply content elements, merged with recent changes and includes RTL. Props jaredatch. Fixes #2054."
changeset,0000002708,[2708],johnjamesjacoby,Improved sub-forum lists inside bbp_forums loop.
changeset,0000003224,[3224],johnjamesjacoby,Improved support for forum archive template. Fix issue in forum archive where post loop was processed rather than the actual bbPress forum loop.
changeset,0000005354,[5354],netweb,"Improved topic merge verbiage in `form-topic-merge.php` template.
Props gautamgupta. Fixes #2539"
changeset,0000005482,[5482],netweb,"Improved topic merge verbiage in form-topic-merge.php template.
Props johnjamesjacoby. Fixes #2539"
changeset,0000003240,[3240],johnjamesjacoby,"Improved trash support for new topics/replies.
If the parent of a new topic/reply is in the trash, automatically trash the new topic/reply. In the case of new trash replies, add that reply to the _bbp_pre_trashed_replies array, so that it is restored when the topic is restored. This bug comes about because capable users can reply to trashed topics.
Also handle view=all redirect when posting new topics/replies."
changeset,0000005454,[5454],netweb,Improved verbiage when importer has no topic tags to import.
changeset,0000005105,[5105],johnjamesjacoby,Improvements to bbp_title() to include user topics/replies/favorites/subscriptions. Fixes #2340.
changeset,0000004743,[4743],johnjamesjacoby,Improvements to bbPress 1.x converter inline documentation. Props netweb. fixes #2189.
changeset,0000003720,[3720],johnjamesjacoby,Improvements to BuddyPress User Forums styling. See #1669.
changeset,0000003008,[3008],johnjamesjacoby,"Improvements to forum visibility checking, template tags, and ensuring that template tag filters also pass the $forum_id for proper enhancement."
changeset,0000002583,[2583],johnjamesjacoby,Improvements to post form handling and bbp-twentyten theme.
changeset,0000004693,[4693],johnjamesjacoby,Improvements to SimplePress5 importer. Props netweb. Fixes #2164.
changeset,0000004727,[4727],johnjamesjacoby,Improvements to the Mingle converter. Props netweb. See #2182.
changeset,0000004726,[4726],johnjamesjacoby,Improvements to the phpBB converter. Props netweb. Fixes #2182.
changeset,0000004728,[4728],johnjamesjacoby,Improvements to the SimplePress5 converter. Props netweb. See #2182.
changeset,0000002591,[2591],johnjamesjacoby,Improvements to twentyten child theme. Abstract out some topic_author functions.
changeset,0000004730,[4730],johnjamesjacoby,Improvements to vBulletin importer. Props netweb. Fixes #1991.
changeset,0000003413,[3413],johnjamesjacoby,Improves multisite user role and capability masking for global forums.
changeset,0000005336,[5336],netweb,"In `.jshintrc` ignore undefined variables so `grunt jshint` task completes without error.
(reference variables created by WordPress dependencies or API's)
* Props netweb. Fixes #2578
"
changeset,0000005476,[5476],johnjamesjacoby,In `_bbp_has_replies_where()` remove the `post__not_in` check and add extra search/replace arguments for more complex queries. Improves support for popular privacy plugins that frequently use `post__not_in`. Props mikelopez. Fixes #2609.
changeset,0000005473,[5473],johnjamesjacoby,In `bbp_admin_repair_forum_topic_count()` include hidden topics in repair tool. Props thebrandonallen. Fixes #2680.
changeset,0000005840,[5840],johnjamesjacoby,In `BBP_Akismet::filter_post_terms()` use `bbp_get_topic_tag_names()` to use cached function instead of querying for object terms.
changeset,0000005609,[5609],johnjamesjacoby,"In `bbp_current_author_ip()` check `$_SERVER['REMOTE_ADDR']` before attempting to parse it.
If it is empty (more likely for unit tests, but could be other oddities) we set it to '0.0.0.0' to do two things:
* Indicate to keymasters that something is amiss
* Allow `bbp_current_author_ip()` to proceed normally for the end-user
Fixes #2750."
changeset,0000005465,[5465],johnjamesjacoby,In `bbp_do_ajax()` use `get_option( 'html_type' )`.
changeset,0000005164,[5164],johnjamesjacoby,"In `bbp_get_forum_subscription_link()` do not return a link if viewing a forum category. This is a temporary stop-gap until forums can be subscribed to in a hierarchical manner. Fixes #2475, hat-tip netweb."
changeset,0000005211,[5211],johnjamesjacoby,In `bbp_has_forums()` do some `post_parent` routing to make sure all forums are available on subscription pages. Fixes #2480. (2.5 branch)
changeset,0000005212,[5212],johnjamesjacoby,In `bbp_has_forums()` do some `post_parent` routing to make sure all forums are available on subscription pages. Fixes #2480. (trunk)
changeset,0000005477,[5477],johnjamesjacoby,In `bbp_has_topics()` bring back `$default_topic_search` variable to prevent debug notices.
changeset,0000005220,[5220],johnjamesjacoby,In `bbp_kses_allowed_tags()` use `true` instead of empty `array()` for individual tag attributes. Props netweb. See #2483.
changeset,0000005283,[5283],johnjamesjacoby,In `bbp_locate_template()` check for `WP_USE_THEMES` before calling `load_template()` to avoid warnings when running phpunit tests. See #2542.
changeset,0000005489,[5489],johnjamesjacoby,"In `bbp_merge_topic_handler()` delete last and count metas, and update the reply position after call to `wp_update_post()`. Fixes bug where merging two topics with odd timestamps could result in orphaned or incorrect meta data and hierarchy positioning. Props netweb. Fixes #2528."
changeset,0000005613,[5613],johnjamesjacoby,"In `bbp_notify_forum_subscribers()` remove incorrect array assignment. Fixes bug where `$headers` would be a multidimensional array, causing `wp_mail()` to complain."
changeset,0000005491,[5491],johnjamesjacoby,"In `bbp_split_topic_handler()` remove `$reply_position` cheater code, and rely on `bbp_update_reply_position()` to recalculate the correct position in the hierarchy after `wp_update_post()` has finished. Props netweb. Fixes #2624."
changeset,0000005470,[5470],johnjamesjacoby,In `bbp_theme_compat_reset_post()` also set `is_singular` to value of `is_single`. Improves query compatibility with themes and other plugins. Props Mat Lipe. Fixes #2545.
changeset,0000005247,[5247],johnjamesjacoby,"In `bbp_title()`, improve user profile logic to avoid ""Your's"" title text. Fixes #2503. (2.5 branch)"
changeset,0000005246,[5246],johnjamesjacoby,"In `bbp_title()`, improve user profile logic to avoid ""Your's"" title text. Fixes #2503. (trunk)"
changeset,0000005221,[5221],johnjamesjacoby,"In `bbp_update_reply()`, send the reply `post_date` - rather than `current_time()` - into the update walker. Fixes possibility of inconsistent times between reply `post_date` and forum/topic last active times. Props netweb. See #1925."
changeset,0000005222,[5222],johnjamesjacoby,"In `bbp_update_topic()`, send the topic `post_date` - rather than `current_time()` - into the update walker. Fixes possibility of inconsistent times between topic `post_date` and forum last active times. Props netweb. See #1925."
changeset,0000005223,[5223],johnjamesjacoby,In `bbp_update_topic_walker()` pass `$last_active_time` into `bbp_update_forum()` to avoid expensive recalculation of the forum's last active time. Props netweb. See #1925.
changeset,0000005188,[5188],johnjamesjacoby,In `bbp_user_can_view_forum()` check the `$user_id` before passing it into `bbp_is_user_keymaster()`. Prevents accidental role escalation if `$user_id` is empty. See #2393.
changeset,0000005607,[5607],johnjamesjacoby,In `bbp_version_updater()` only run update routines if a previous installation exists to update. Fixes #2748.
changeset,0000005520,[5520],netweb,In `Example.php` importer use the correct `callback_forumid` callback for reply forum ID's.
changeset,0000005522,[5522],netweb,In `Phorum.php` importer use the correct `callback_forumid` callback for reply forum ID's.
changeset,0000005524,[5524],netweb,In `phpBB.php` importer use the correct `callback_forumid` callback for reply forum ID's.
changeset,0000004950,[4950],johnjamesjacoby,"In admin, escape output of translated text where appropriate. Also review and refresh existing escaping approaches. See #1999."
changeset,0000003854,[3854],nacin,"In bb_create_tag(), avoid calling list() on the insert_term() method of the taxonomy object, as this method may return WP_Error.
Calling list() on a WP_Error object would result in a fatal error. Instead, check for WP_Error before breaking up the return value.
props otto42. for bbPress 1.1.
"
changeset,0000003853,[3853],nacin,"In bb_create_tag(), avoid calling list() on the insert_term() method of the taxonomy object, as this method may return WP_Error.
Calling list() on a WP_Error object would result in a fatal error. Instead, check for WP_Error before breaking up the return value.
props otto42. for bbPress standalone trunk.
"
changeset,0000003780,[3780],johnjamesjacoby,"In bbp-twentyten:
* Rename functions.php to bbpress-functions.php to avoid overloading
* Load JS in footer
* Smarter default global vars
* Do not create a global variable
* See #1766"
changeset,0000004601,[4601],johnjamesjacoby,"In bbp_add_forums_roles(), use $role_id instead of literal translated role name. Fixes #2105."
changeset,0000004595,[4595],johnjamesjacoby,"In bbp_admin_reset_handler(), use correct bbp_remove_caps() function. Props netweb. Fixes #2097."
changeset,0000004847,[4847],johnjamesjacoby,"In bbp_check_for_duplicate(), run wp_unslash() or stripslashes_deep() on the entire $r array. Remove unslashing on results of get_meta_sql() to allow any previously slashed values to remain slashed. See #2185."
changeset,0000005010,[5010],johnjamesjacoby,"In bbp_get_dropdown(), remove the hard-coded post_status checker, and trust bbp_pre_get_posts_normalize_forum_visibility() to do its job. We still pass 'post_status' as null, so that get_posts() gets passed the results of bbp_parse_args(). Also, remove 'sort_column' array key from when this used get_pages(), and rely on 'orderby' for get_posts() instead.
In bbp_pre_get_posts_normalize_forum_visibility(), remove empties and duplicates from the $post_stati array.
Fixes #2354."
changeset,0000004688,[4688],jmdodd,"In bbp_get_dropdown(), set default post_parent to null, not 0.
* Fixes #2153.
"
changeset,0000004754,[4754],johnjamesjacoby,"In bbp_get_user_blog_role(), use bbp_add_forums_roles() instead of accessing WP_Roles directly. Fixes issue where WP_Roles could be loaded without bbPress's roles correctly added in time, causing default role to be added without correct allcaps for user."
changeset,0000004831,[4831],johnjamesjacoby,"In bbp_get_user_id(), do not fallback to 'bbp_user_id' query variable, to prevent accidentally confusing a Guest (anonymous) user with the displayed user, in situations where empty bbp_get_user_id() checks are made. Fixes #2284."
changeset,0000004677,[4677],johnjamesjacoby,"In bbp_get_user_replies_created(), only query for the reply post type. Fixes issue with topics appearing commingled in the replies created profile page."
changeset,0000004920,[4920],johnjamesjacoby,"In bbp_is_search_results(), use $wp_query->bbp_search_terms instead of new bbp_is_search_results query-var. See #2337."
changeset,0000004597,[4597],johnjamesjacoby,"In bbp_list_forums(), remove check for subforums meta, and trust the subforums query to do the work.
In the subforums query, avoid using get_posts() and use a new WP_Query object instead. Also fix some return value type-casting.
Fixes #2085."
changeset,0000004816,[4816],johnjamesjacoby,"In bbp_move_topic_handler(), when moving a topic from one forum to another, recalculate sticky topics for each forum, and update them accordingly. Also modify the logic used to update ancestor forums, to avoid running update routine multiple times on the same forum. Props alex-ye. Fixes #2259."
changeset,0000005019,[5019],johnjamesjacoby,"In bbp_new_topic_handler() and bbp_edit_topic_handler(), restrict sticky topic actions to users with 'moderate' capability. Fixes #2366."
changeset,0000004914,[4914],johnjamesjacoby,"In bbp_parse_args(), switch $defaults default from '' to array(), and add some brackets to improve readability."
changeset,0000004916,[4916],johnjamesjacoby,"In bbp_parse_args(), switch $defaults default from string to array, and add some brackets to improve readability. Also, only perform an array_merge() if the array to merge with is not empty."
changeset,0000004807,[4807],johnjamesjacoby,"In bbp_pre_get_posts_exclude_forums(), switch logic to remove statuses from existing queries rather than recalculating them completely. Hat tip alex-ye. Fixes #2221."
changeset,0000004922,[4922],johnjamesjacoby,"In bbp_pre_get_posts_normalize_forum_visibility(), run $post_types array through implode() and do an explicit comparison. Fixes issue with multi-type queries getting incorrect post-status query-vars."
changeset,0000004758,[4758],johnjamesjacoby,"In bbp_profile_update_role(), add additional checks to prevent accidental role changes."
changeset,0000005123,[5123],johnjamesjacoby,"In bbp_request_feed_trap(), check that post type being requested is a bbPress post type before proceeding. Improves compatibility with other custom feed handlers. Props alex-ye. Fixes #2308. (2.4.1)"
changeset,0000005122,[5122],johnjamesjacoby,"In bbp_request_feed_trap(), check that post type being requested is a bbPress post type before proceeding. Improves compatibility with other custom feed handlers. Props alex-ye. Fixes #2308. (2.5)"
changeset,0000004608,[4608],johnjamesjacoby,"In bbp_template_include_theme_compat(), bail early if is_buddypress(). Fixes #2104."
changeset,0000005109,[5109],johnjamesjacoby,"In bbp_template_include_theme_compat(), bail out early when a root template has already been previously located. Fixes issues with recursive calls to the 'the_content' filter. Fixes #2429. (2.4.1)"
changeset,0000005110,[5110],johnjamesjacoby,"In bbp_template_include_theme_compat(), bail out early when a root template has already been previously located. Fixes issues with recursive calls to the 'the_content' filter. Fixes #2429. (2.5)"
changeset,0000004588,[4588],johnjamesjacoby,"In bbp_time_since(), do not noop $newer_date variable when passed to bbp_get_time_since(). Fixes #2115."
changeset,0000004965,[4965],johnjamesjacoby,"In bbp_update_reply_to(), allow $reply_to to be 0 and delete if it's being set to empty. See #2340."
changeset,0000004964,[4964],johnjamesjacoby,"In bbp_update_reply_to(), allow $reply_to to be 0 and delete if it's being set to empty. See #2340."
changeset,0000005087,[5087],johnjamesjacoby,"In bbp_user_can_view_forum(), pass the $user_id into bbp_is_user_keymaster().
Fixes issue where bbp_user_can_view_forum() may return incorrect results for users with the Keymaster role.
Props alex-ye. Fixes #2393."
changeset,0000005029,[5029],johnjamesjacoby,"In bbp_verify_nonce_request(), add support for local installations that include a port in home_url(). Fixes #2196."
changeset,0000004552,[4552],johnjamesjacoby,"In bbp_verify_nonce_request(), parse home_url() to remove any strange characters or query-strings that plugins might append to it. Fixes #2070."
changeset,0000005517,[5517],netweb,"In bbPress 1.x converter add support for closed topics via improved method in r5425.
Props netweb. Fixes #2125."
changeset,0000004625,[4625],johnjamesjacoby,"In bbPress 1.x converter, use topic_open to make sure topics stay closed after conversion. Props netweb. Fixed #2125."
changeset,0000002999,[2999],johnjamesjacoby,"In bp_has_topics(), check that $sticky_posts exist before attempting to loop through them."
changeset,0000004787,[4787],johnjamesjacoby,"In breadcrumb, skip crumb if parent is empty or an error."
changeset,0000003723,[3723],johnjamesjacoby,"In BuddyPress group forum extension, use raw forum slug option to avoid including the forum prefix. See #1669."
changeset,0000004720,[4720],johnjamesjacoby,"In BuddyPress's loader, setup components in priority 7, to get them in before activity actions are registered. Props r-a-y. Fixes #2176."
changeset,0000004715,[4715],johnjamesjacoby,"In favorite/subscription handlers, default redirect to get_permalink( $topic_id ) if no other match is found. Fixes #2160."
changeset,0000004594,[4594],johnjamesjacoby,"In loop-single-reply/topic templates, replace ""post-ID"" with correct post type for query. Fixes issues with duplicate element ID's. Fixes #1980."
changeset,0000005511,[5511],johnjamesjacoby,"In our BuddyPress Groups `display_forums` method, `break` out of switch statement rather than `return`. This prevents malformed markup caused by not allowing the method to continue on. Hat-tip boonebgorges, netweb. Fixes #2595."
changeset,0000004627,[4627],johnjamesjacoby,"In phpBB converter, use topic_status to make sure topics stay closed after conversion. Props netweb. Fixes #2123."
changeset,0000005355,[5355],johnjamesjacoby,"In template stack functions, wrap `function_exists()` checks with `is_array()` check. Allows class methods to be used as template stack locations. See: https://buddypress.trac.wordpress.org/ticket/5671"
changeset,0000004990,[4990],johnjamesjacoby,"In the _insert_ and _handler_ functions, do some one-time-use variable clean-up, and add some brackets for improved readability."
changeset,0000005478,[5478],johnjamesjacoby,"In the `form-topic.php` template part, check for 'bbp_get_forum_title()` before outputting an empty title. Props jreeve. Fixes #2625."
changeset,0000003214,[3214],johnjamesjacoby,"In the beginning, there was cold, white, empty, space... in bbp-admin.php."
changeset,0000004882,[4882],johnjamesjacoby,"In the BuddyPress Activity extension, move _update() methods from 'wp_insert_post' onto 'edit_post' action to prevent running them on topic/reply creation accidentally. Fixes bug causing hide_sitewide to incorrectly be set to true on some installations. Also some code clean-up and additional type-casting where appropriate. Fixes #2327 (2.3 branch)"
changeset,0000004881,[4881],johnjamesjacoby,"In the BuddyPress Activity extension, move _update() methods from 'wp_insert_post' onto 'edit_post' action to prevent running them on topic/reply creation accidentally. Fixes bug causing hide_sitewide to incorrectly be set to true on some installations. Also some code clean-up and additional type-casting where appropriate. Fixes #2327 (trunk)"
changeset,0000004941,[4941],johnjamesjacoby,"In the BuddyPress extension, use slug helper functions to define navigational elements. This will allow customization of slugs in profiles to integrate with BuddyPress 1.8 rewrite rules. Also use the BP_Component slug rather than hardcoded 'forums' in the event this slug becomes customizable in the future."
changeset,0000003137,[3137],johnjamesjacoby,"In the single topics loop, wrap topic meta items in spans for easier styling for theme compat."
changeset,0000004778,[4778],johnjamesjacoby,"In topic new/edit handlers, don't check unnecessary error conditions. Props alex-ye. Fixes #2220."
changeset,0000005516,[5516],netweb,"Include 'default' forum status and forum type meta keys in importers for databases that do not support these values.
* Forum status: `_bbp_status` = `open` meta
* Forum type: `_bbp_forum_type` = `forum`
Props netweb. See #2647"
changeset,0000005418,[5418],netweb,Include 'Forum Type' - `_bbp_forum_type` and 'Forum Status' `_bbp_forum_status` in Example.php importer
changeset,0000005170,[5170],netweb,"Include 'sticky' and 'super sticky' import capabilities for the following forum importers:
* AEF, Drupal7, Example, FluxBB, Invision, Mingle, MyBB, phpBB, PHPFox, PunBB, SimplePress, vBulletin v4.x, vBulletin v3.x, Xenforo and XMB forum importers"
changeset,0000005278,[5278],netweb,Include .gitignore file for Git based repo. See #2542
changeset,0000005819,[5819],netweb,Include 2.5.8 in readme.txt changelog (for trunk) and bump stable tag
changeset,0000005645,[5645],johnjamesjacoby,Include `2.5.6` changelog entry in `readme.txt`. (trunk)
changeset,0000005696,[5696],johnjamesjacoby,Include `2.5.7` in `readme.txt` changelog (for trunk) and bump stable tag
changeset,0000005230,[5230],netweb,Include `bbp_is_replies_created` in bbPress CSS body classes and include `bbp_is_replies_created` in `is_bbpress()` function. Props netweb. Fixes #2489
changeset,0000005554,[5554],netweb,"Include anonymous reply author name in `Drupal7.php` importer.
Props netweb. See #2347"
changeset,0000005541,[5541],netweb,"Include anonymous topic and reply import support in `Drupal7.php` importer
Props netweb. See #2347"
changeset,0000005539,[5539],netweb,"Include anonymous topic and reply import support in `phpBB.php` and `SMF.php` importers
Props netweb. See #2347"
changeset,0000005551,[5551],netweb,"Include anonymous topic and reply import support in Phorum (`Phorum.php`) importer
Props netweb. Fixes #2703"
changeset,0000005548,[5548],netweb,"Include anonymous topic and reply import support in SimplePress 5 (`SimplePress5.php`) importer
Props netweb. See #2347"
changeset,0000005546,[5546],netweb,"Include anonymous topic and reply import support in vBulletin 3 (`vBulletin3.php`) and vBulletin 4 (`vBulletin.php`) importers
Props netweb. See #2347"
changeset,0000005550,[5550],netweb,"Include anonymous topic and reply import support in XMB 1.x (`XMB.php`) and PunBB (`PunBB.php`) importers
Props netweb. See #2347"
changeset,0000005254,[5254],netweb,Include backend admin open and close forum row actions. Props netweb. Fixes #2491.
changeset,0000005176,[5176],netweb,"Include support for custom topic tag slugs and descriptions during import. Props netweb. Fixes #2399
* Support included for bbPress v1.x , Drupal, Example, PHPFox, vBulletin v3.x & v4.x "
changeset,0000005569,[5569],netweb,"Include topic-tag descriptions in bbPress 1.x importer
* Props thebrandonallen for initial patch
* Fixes #2710"
changeset,0000005599,[5599],netweb,Include WordPress v4.1 in Travis CI tests
changeset,0000004434,[4434],johnjamesjacoby,Increase default textarea rows from 6 to 12. Feels like a better balance between normal and fancy editors.
changeset,0000005357,[5357],johnjamesjacoby,Indent with tabs in `package.json`
changeset,0000005371,[5371],johnjamesjacoby,Indentation clean-up and assignment clarifycation in `bbp_get_reply_to()`. See #2588.
changeset,0000006115,[6115],netweb,"Indentation fixes, tabs, not spaces.
"
changeset,0000003309,[3309],johnjamesjacoby,"Inline doc fixes, whitespace clean-up."
changeset,0000006756,[6756],johnjamesjacoby,Inline documentation improvements from r6755.
changeset,0000006477,[6477],johnjamesjacoby,Inserts: Only prefix meta keys if not already prefixed when inserting forum/topic/reply.
changeset,0000005775,[5775],johnjamesjacoby,"Inserts: When inserting a forum/topic/reply, immediately update the new object so hierarchy is refreshed.
This commit addresses the last active post ID being incorrect after inserting topics and replies to a forum, and fixes a failing test (in `BBP_Tests_Core_Update::test_bbp_create_initial_content`).
See #2805."
changeset,0000005712,[5712],netweb,"Install/Update: Don't add reply titles in sample forum content `bbp_create_initial_content()`, reply title requirements were removed in r5177.
Props netweb. Fixes #2795
"
changeset,0000005883,[5883],netweb,"Installation: When creating initial content, use different times for forum, topic, and reply post times.
This changeset builds on r5843 to allow improved tests in `test_bbp_create_initial_content()` of forum and topic last active times.
"
changeset,0000005843,[5843],johnjamesjacoby,"Installation: When creating initial content, use the same `current_time( 'mysql' )` for all new posts.
This changeset prevents the related unit test from incorrectly failing by ensuring that no initial content is created 1 second after any other."
changeset,0000006751,[6751],johnjamesjacoby,"Intercept: first pass intercept API.
This change introduces 3 new functions for generating a default intercept value and comparing against it in specific places. If the return value differs from the default intercept value, we know that function call was intercepted by a filter, and that value will become the new return value without executing the remaining part of the function.
See #3184."
changeset,0000006752,[6752],johnjamesjacoby,"Intercept: invert comparison in `bbp_is_intercepted()`.
I was testing it to make sure it worked correctly, and forgot to switch it back before r6751.
See #3184."
changeset,0000006816,[6816],johnjamesjacoby,"Intercept: return default value if an invalid number of args is parsed.
Also pass a `$user_id` into favorites & subscriptions links functions.
These changes together will prevent notices & errors in certain intercept conditions."
changeset,0000006803,[6803],johnjamesjacoby,"Intercept: updates to `bbp_maybe_intercept()`:
* Use `bbp_parse_args()` internally
* Compare against known default return value
* Use `call_user_func_array()` to avoid using `extract()`
This change allows the intercept API to work a bit more smoothly with filters that have multiple arguments passed into them. Previous to this, those filters may have dropped their arguments, or otherwise not passed the proper arguments into their filter call.
This fixes a regression related to BuddyPress profile URL overrides.
See #3814."
changeset,0000004820,[4820],johnjamesjacoby,"Introduce 'bbp_locate_template' action to bbp_locate_template(), with inline documentation for intended usage. Fixes #2277."
changeset,0000002780,[2780],johnjamesjacoby,"Introduce _content functions for topics and replies. Introduce our own allowed_tags for handling HTML. Add nofollow to links in content. Properly sanitize topic and reply slugs. Fixes #1426, #1389, #1411. Props !GautamGupta via Google Code-in"
changeset,0000002787,[2787],johnjamesjacoby,"Introduce _get_ functions for forums, topics, and replies. Fixes #1415. Props !GautamGupta via Google Code-in"
changeset,0000005409,[5409],johnjamesjacoby,"Introduce `bbp_get_do_not_reply_address()` function, and use in subscription notification functions. Also add filters to make changing these values easier for advanced setups. Fixes #2618."
changeset,0000005826,[5826],johnjamesjacoby,Introduce `bbp_get_global_object()` to help with verifying & retrieving global variables before interacting with them. See #2786.
changeset,0000006051,[6051],netweb,"Introduce `bbp_get_major_wp_version()` function to help checking against WordPress versions
See #2874
"
changeset,0000005390,[5390],johnjamesjacoby,Introduce `bbp_get_reply_ancestors()` function to help with reply hierarchy dropdown. Also conveniently wraps logic incase we ever move to a real hierarchical post type. See #2617.
changeset,0000005370,[5370],johnjamesjacoby,"Introduce `bbp_sanitize_displayed_user_field()` function to handle the sanitizing of displayed user data, and add it to the `bbp_get_displayed_user_field` filter. Props mazengamal. See #2610 (2.5 branch)."
changeset,0000005369,[5369],johnjamesjacoby,"Introduce `bbp_sanitize_displayed_user_field()` function to handle the sanitizing of displayed user data, and add it to the `bbp_get_displayed_user_field` filter. Props mazengamal. See #2610 (trunk)."
changeset,0000005366,[5366],johnjamesjacoby,"Introduce `bbp_sanitize_slug()` function for sanitizing permalink slugs, and use it as the callback for any slug settings. Props mazengamal. See #2496 (2.5 branch)."
changeset,0000005365,[5365],johnjamesjacoby,"Introduce `bbp_sanitize_slug()` function for sanitizing permalink slugs, and use it as the callback for any slug settings. Props mazengamal. See #2496 (trunk)."
changeset,0000005377,[5377],johnjamesjacoby,"Introduce `bbp_validate_reply_to()` function, used to:
* Validate a parent reply is actually a reply post_type.
* A reply is not accidentally assigning itself as its own parent.
* An integer is returned.
Fixes hiesenbug where calls to `bbp_get_reply_id()` were unexpectedly and occasionally returning the current reply ID rather than 0.
See #2588. (2.5 branch)"
changeset,0000005378,[5378],johnjamesjacoby,"Introduce `bbp_validate_reply_to()` function, used to:
* Validate a parent reply is actually a reply post_type.
* A reply is not accidentally assigning itself as its own parent.
* An integer is returned.
Fixes hiesenbug where calls to `bbp_get_reply_id()` were unexpectedly and occasionally returning the current reply ID rather than 0.
See #2588. (trunk)"
changeset,0000005389,[5389],johnjamesjacoby,Introduce `BBP_Walker_Reply_Dropdown` to help with reply hierarchy dropdown. Also update other Walker class extensions and associated documentation to be a bit more accurate and reliable. See #2617.
changeset,0000005823,[5823],johnjamesjacoby,"Introduce `core/abstraction.php` to provide a layer of protection against touching common WordPress global variables directly.
This commit introduces a few new helper functions to protect sensitive global variables, and also introduces the ability to filter and override them explicitly within the scope of the bbPress plugin. These functions will be used in place of existing global touches in future commits.
See #2786."
changeset,0000005163,[5163],johnjamesjacoby,Introduce `current_view_id` to bbPress class variables. Used when calling a topic view shortcode via `bbp-single-view` so subsequent calls to `bbp_view_query` are able to retrieve the `$view_id` via `bbp_get_view_id()` the same way `bbp_get_topic_id()` works. Fixes #2457.
changeset,0000005009,[5009],johnjamesjacoby,Introduce additional forum/topic ID validation when posting new topics and replies. Prevents empty/negative/non-existent post_parent. Fixes #2363.
changeset,0000005140,[5140],netweb,Introduce Advanced Electron Forum v1.x bbPress importer. Props netweb. Fixes #2384
changeset,0000002617,[2617],johnjamesjacoby,Introduce bbp_allow_anonymous function
changeset,0000003581,[3581],johnjamesjacoby,"Introduce bbp_check_for_moderation() to check moderation_keys and comment_max_links before publishing topics and replies. Also introduces function for getting the pending post status, and adds missing status vars to bbPress class. See #1672."
changeset,0000002700,[2700],johnjamesjacoby,Introduce BBP_Component class. Change alternate class to even/odd.
changeset,0000004653,[4653],johnjamesjacoby,"Introduce bbp_deregister_template_stack(), to allow plugins to manipulate the template stack in real-time."
changeset,0000004998,[4998],johnjamesjacoby,Introduce bbp_find_mentions_pattern() function to make it easier to change the pattern to match usernames against. Helpful for non-latin characters. Also add additional filter to bbp_find_mentions() to allow for late filtering of results. Props aliso. Fixes #2226.
changeset,0000003791,[3791],johnjamesjacoby,Introduce bbp_get_config_location() function to look for previous BuddyPress integration. See #1669.
changeset,0000004793,[4793],johnjamesjacoby,Introduce bbp_get_dynamic_role_name() to handle getting a translated role name from the dynamic roles array. Use this to return a more accurate display role in bbp_get_user_display_role(). Hat tip alex-ye. Fixes #2248.
changeset,0000003629,[3629],johnjamesjacoby,Introduce bbp_get_query_template() function to handle the template assignment for the extra bbPress root level template files.
changeset,0000004655,[4655],johnjamesjacoby,Introduce bbp_get_redirect_to() to handle getting the request variable. Use this new function where appropriate.
changeset,0000003380,[3380],johnjamesjacoby,Introduce bbp_global_access_role_mask() to assign the default_role and meta-caps to the current user when viewing a global forum in a multisite installation. Say that three times fast.
changeset,0000003585,[3585],johnjamesjacoby,Introduce bbp_is_edit global posts_query var to indicate that bbPress editing is occurring.
changeset,0000002980,[2980],johnjamesjacoby,"Introduce bbp_is_query_name() function to make checking the '_bbp_query_name' query variable easier, and use this function through-out.
Fix bug where topic and reply widgets would selfishly listen to pagination query vars.
Fix bug when viewing a single topic, replies widget would only show replies from that topic."
changeset,0000004919,[4919],johnjamesjacoby,Introduce bbp_is_search_results() and use it in is_bbpress() and bbp_body_class(). See #2337.
changeset,0000003398,[3398],johnjamesjacoby,"Introduce bbp_is_site_public() function, and use it to prevent BuddyPress activity stream additions for new topics and replies if entire site is private."
changeset,0000003504,[3504],johnjamesjacoby,Introduce bbp_is_user_active() and bbp_is_user_inactive() to help with spammed and deleted user checks. See #1630 and r3503.
changeset,0000004943,[4943],johnjamesjacoby,Introduce bbp_make_clickable() and use it in place of make_clickable() filter. Fixes issues with making links clickable inside pre and code blocks. Fixes #2335 (2.3 branch)
changeset,0000004942,[4942],johnjamesjacoby,Introduce bbp_make_clickable() and use it in place of make_clickable() filter. Fixes issues with making links clickable inside pre and code blocks. See #2335 (trunk)
changeset,0000003410,[3410],johnjamesjacoby,Introduce bbp_make_spam_user() and bbp_make_ham_user() functions to loop through the sites of a user and spam/unspam their topics and replies as needed. (BuddyPress 1.5 compatible)
changeset,0000003840,[3840],johnjamesjacoby,"Introduce bbp_parse_args() and pass filter keys into its usages.
* Parsed args to be passively or aggressively filtered
* Allows functions that normally require passing parsed $args to instead filter or override results"
changeset,0000004551,[4551],johnjamesjacoby,"Introduce bbp_post_request() and bbp_get_request() sub-actions:
* Update actions and sub-actions to use these new handlers.
* Update new/edit forum/topic/reply handlers to use these.
* Update phpdoc as needed.
* Remove duplicate 'bp_actions' request hooks from BuddyPress group forums.
* Does not include admin-side requests."
changeset,0000002997,[2997],johnjamesjacoby,Introduce bbp_query_post_parent__in() function for future use with private and hidden forums. Props nacin.
changeset,0000004181,[4181],johnjamesjacoby,"Introduce bbp_register subaction:
* Switch bbp_init priority to init 0.
* Hook bbp_register to bbp_init, prority 0.
* Hook _register_ actions onto bbp_register.
* Registers post types, taxonomies, post statuses, shortcodes, and topic views early, so they are available ahead of 'init' action.
* Fixes plugin dependency issue with bbPress objects not being registered when they are needed."
changeset,0000005017,[5017],johnjamesjacoby,"Introduce bbp_repair_forum_visibility() and use it:
* when creating a new BuddyPress Group Forum
* in the bbp_admin_repair_forum_visibility() tool
Fixes issues with new group forums not bumping the private/hidden forum ID's. Props r-a-y. Fixes #2349."
changeset,0000002552,[2552],johnjamesjacoby,Introduce bbp_replies template part. Fill in bbp_topic template emptiness.
changeset,0000002984,[2984],johnjamesjacoby,Introduce bbp_reply_position() functions to help calculate reply permalinks and topic freshness links. Fixes #1495.
changeset,0000004928,[4928],johnjamesjacoby,"Introduce bbp_search_results_url(), bbp_get_search_results_url(), and bbp_search_template_redirect(), to handle the new search results page routing. See #2337."
changeset,0000003028,[3028],johnjamesjacoby,"Introduce bbp_setup_theme_compat() function and action, which provide skeletal theme support for themes that do not explicitly support bbPress."
changeset,0000002954,[2954],johnjamesjacoby,"Introduce bbp_show_lead_topic() function in bbp-general-functions.php, the purpose of which is to act as a switch between traditional and new single topic display layouts."
changeset,0000003607,[3607],johnjamesjacoby,"Introduce bbp_template_redirect() and use for checking various edit screens:
* Introduce bbp_check_forum_edit() to check for forum edit
* Introduce bbp_check_topic_edit() to check for topic edit
* Introduce bbp_check_reply_edit() to check for reply edit
* Introduce bbp_check_topic_tag_edit() to check for topic tag edit
* Introduce bbp_check_user_edit() to check for user edit
* Remove these checks from bbp_pre_get_posts() and only use it to setup query vars
* Fixes #1684, r3605
* For 2.1 (plugin) branch"
changeset,0000003605,[3605],johnjamesjacoby,"Introduce bbp_template_redirect() and use for checking various edit screens:
* Introduce bbp_check_topic_edit() to check for topic edit
* Introduce bbp_check_reply_edit() to check for reply edit
* Introduce bbp_check_topic_tag_edit() to check for topic tag edit
* Introduce bbp_check_user_edit() to check for user edit
* Remove these checks from bbp_pre_get_posts() and only use it to setup query vars
* See #1684
* For 2.0 branch"
changeset,0000003419,[3419],johnjamesjacoby,"Introduce BBP_Updater class to more accurately handle conditions where activation hooks might not fire on multisite installations, and to flush rewrite rules at the appropriate time on updates. Fixes #1569."
changeset,0000002814,[2814],johnjamesjacoby,Introduce bbp_user_register template part placeholder
changeset,0000003471,[3471],johnjamesjacoby,Introduce convenience functions for global $wp_rewrite usage.
changeset,0000004579,[4579],jmdodd,"Introduce dedicated forum search.
* Search forums, topics, and replies.
* Add new search functions, including bbp_has_search_results().
* Provide templates for search results.
* Fixes #1575.
"
changeset,0000005138,[5138],netweb,Introduce Drupal v7.x bbPress importer. Props netweb. Fixes #2375
changeset,0000002763,[2763],johnjamesjacoby,Introduce duplicate topic/reply detection. Props !GautamGupta via Google Code-in
changeset,0000005352,[5352],netweb,"Introduce e107 v1.x importer
Props netweb. Fixes #2421"
changeset,0000005139,[5139],netweb,Introduce FluxBB bbPress importer. Props netweb. Fixes #2383
changeset,0000002770,[2770],johnjamesjacoby,Introduce forum statistics dashboard widget. Fixes #1438. Props !GautamGupta via Google Code-in
changeset,0000002769,[2769],johnjamesjacoby,Introduce forum statistics; fixes #1427. Introduce method to limit number of pages in topics query. Props !GautamGupta via Google Code-in
changeset,0000002746,[2746],johnjamesjacoby,Introduce forum type/status/visibility using post_meta. This hides the built in WordPress equivalents as a temporary hack until custom WP post statuses are more flexible. Props !GautamGupta via Google Code-in.
changeset,0000004572,[4572],jmdodd,"Introduce function bbp_is_forum_group_forum().
* Fixes #2100.
"
changeset,0000003679,[3679],johnjamesjacoby,"Introduce functions and code to help create new forums from within the theme:
* Turn on forum-form shortcode
* Add supplemental actions for saving forum extras on new/edit
* bbp_save_forum_extras() function to handle forum metadata saving
* See #1669"
changeset,0000004633,[4633],johnjamesjacoby,"Introduce functions for getting and caching the current users current group status. Use these new functions in the Group Forum extension, to remove dependency on $groups_template global. Fixes bugs where regular users could not create content in private/hidden groups. Hat-tip boonebgorges. Fixes #2119."
changeset,0000002729,[2729],johnjamesjacoby,"Introduce functions for getting and validating a user_id, and use them through-out project."
changeset,0000003762,[3762],johnjamesjacoby,"Introduce functions for getting the unique rewrite ID's for user/view/edit.
* Use new functions where needed
* Clean up variable usages in bbPress class
* See #1760"
changeset,0000002544,[2544],johnjamesjacoby,Introduce functions for handling time since
changeset,0000003540,[3540],johnjamesjacoby,"Introduce functions for topic/reply per-page settings, to prevent divide by zero errors if setting is saved as '0' string."
changeset,0000003572,[3572],johnjamesjacoby,"Introduce functions for topic/reply per-page settings, to prevent divide by zero errors if setting is saved as '0' string. See r3540. (2.1)"
changeset,0000005181,[5181],johnjamesjacoby,Introduce functions to enqueue scripts and styles according to the template stack. See #2478.
changeset,0000003446,[3446],johnjamesjacoby,"Introduce functions to get the topic/reply author email address, and use on anonymous post form."
changeset,0000002967,[2967],johnjamesjacoby,"Introduce functions, styling, and theme support for pagination links within individual topics while displaying the forum loop."
changeset,0000002874,[2874],johnjamesjacoby,Introduce general author avatar functions for use with last_active_id in forums and topics.
changeset,0000003496,[3496],johnjamesjacoby,"Introduce Genesis theme framework compatibility class.
* Fixes error messages thrown by bbPress theme compatibility when using Genesis.
* Moves extension loading onto 'bbp_ready' action in bbp-core-hooks.php to ensure bbPress has initialized.
* Adds missing post data to bbp_theme_compat_reset_post() to prevent debug notices.
* Fixes table width when in theme compatibility mode.
See #1622. Props jaredatch for original patch."
changeset,0000005027,[5027],johnjamesjacoby,Introduce group_settings_hidden_field() method to prevent the settings page from accidentally disabling the group forum. Props r-a-y. Fixes #2339.
changeset,0000005233,[5233],johnjamesjacoby,"Introduce helper function for getting the BuddyPress component name, and filter new BuddyPress function to include it in registered components. Fixes #2495. Hat-tip imath. (2.5 branch)"
changeset,0000005232,[5232],johnjamesjacoby,"Introduce helper function for getting the BuddyPress component name, and filter new BuddyPress function to include it in registered components. Fixes #2495. Hat-tip imath. (trunk)"
changeset,0000004791,[4791],johnjamesjacoby,"Introduce helper functions for determining the REQUEST_METHOD, and replace occurrences with these new functions. Cleans up inconsistent handling of requests through-out the project."
changeset,0000003739,[3739],johnjamesjacoby,Introduce helper functions to allow the root directory for bbPress templates to be filtered. Props !MrMaz for idea.
changeset,0000002889,[2889],johnjamesjacoby,Introduce hidden topic functions for viewing trashed topics inside the current forum. Add this ability to the forum description area.
changeset,0000005145,[5145],netweb,"Introduce Kunena Forums for Joomla bbPress importers. Props netweb. Fixes #2402
* Kunena1.php for Kunena v1.x Forums
* Kunena2.php for Kunena v2.x Forums
* Kunena3.php for Kunena v3.x Forums
"
changeset,0000002815,[2815],johnjamesjacoby,"Introduce lost password page. Introduce user_login and user_lost_pass template parts. Introduce supporting login and smart login redirect functions. Normalize submit containers across template forms. (@todo: register, activation, and lost password pages)"
changeset,0000003246,[3246],johnjamesjacoby,Introduce max length attribute on topic and reply titles. This includes a hidden setting (default 80) that can be filtered or adjusted.
changeset,0000003469,[3469],johnjamesjacoby,Introduce method to set the wp-admin path depth difference. Fixes #1617.
changeset,0000004692,[4692],johnjamesjacoby,Introduce Mingle converter. Props netweb. Fixes #2163.
changeset,0000005141,[5141],netweb,Introduce MyBB bbPress importer. Props netweb. Fixes #2378
changeset,0000002601,[2601],johnjamesjacoby,"Introduce page-bbp_topics, and rename New Topic template to Create Topic"
changeset,0000004927,[4927],johnjamesjacoby,Introduce paged rewrite ID and slug helper functions. See #2336.
changeset,0000005142,[5142],netweb,Introduce Phorum bbPress importer. Props netweb. Fixes #2382
changeset,0000005147,[5147],netweb,Introduce PHPFox bbPress importer. Props netweb. Fixes #2415
changeset,0000005143,[5143],netweb,Introduce PHPWind bbPress importer. Props netweb. Fixes #2395
changeset,0000005154,[5154],netweb,Introduce PunBB v1.4.x bbPress importer. Props netweb. Fixes #2379
changeset,0000003633,[3633],johnjamesjacoby,Introduce raw functions for getting user topic and reply post counts directly from the posts table. See #1694.
changeset,0000004926,[4926],johnjamesjacoby,Introduce reply archive slug option. See #2336.
changeset,0000003566,[3566],johnjamesjacoby,"Introduce shortcode, rewrite rule, template file, and theme-compatibility code for front-end Forum editing. See #1669."
changeset,0000004639,[4639],johnjamesjacoby,Introduce SimplePress 5 importer. Props netweb. Fixes #2074.
changeset,0000005191,[5191],netweb,Introduce SMF v2.x bbPress importer. Props netweb. Fixes #2380
changeset,0000002592,[2592],johnjamesjacoby,Introduce sticky and super sticky functions for future use.
changeset,0000002754,[2754],johnjamesjacoby,Introduce sticky/super-sticky topics. Props !GautamGupta via Google Code-in
changeset,0000005538,[5538],netweb,"Introduce support for importing anonymous topics and replies in `converter.php`
* Adds two new steps to the import conversion process:
* ""Convert anonymous topic authors"" and ""Convert anonymous reply authors""
* Utilizes existing bbPress support for anonymous user topics and replies
* Adds post meta key `_bbp_anonymous_name` to imported anonymous topic and replies
* Depending on the forum being imported these may be referenced as anonymous, guest or deleted topics or replies
* Imported topics and replies are assigned post meta key `_bbp_old_topic_author_name_id` or `_bbp_old_reply_author_name_id` respectively that is then compared using the returned `true` or `false` in the callback function `callback_check_anonymous()` of each of importers that are are supported.
Props netweb. See #2347"
changeset,0000002955,[2955],johnjamesjacoby,Introduce supporting topic and reply functions for new bbp_show_lead_topic() functionality. Also use this new functionality in the bbp-twentyten theme.
changeset,0000002768,[2768],johnjamesjacoby,Introduce tag management utilities. Fixes #1424. Props !GautamGupta via Google Code-in
changeset,0000003632,[3632],johnjamesjacoby,"Introduce template tags for getting user topic, reply, and total post counts. See #1694."
changeset,0000005064,[5064],johnjamesjacoby,"Introduce the bbp_get_blog_roles() helper function, to match bbp_get_dynamic_roles(). This function gets the roles of a blog with bbPress's dynamic roles filtered out (if they previously exist.)
Use bbp_get_blog_roles() where applicable to match bbp_get_dynamic_roles() usages.
Removes dependence on get_editable_roles() admin-only function."
changeset,0000003830,[3830],johnjamesjacoby,"Introduce theme packages API for bbPress 2.1
* Allow multiple theme packages to be registered (primarily as plugins)
* Allow switching between theme packages on the fly
* Register bbp-theme-compat and bbp-twentyten as available theme packages
* Introduce new 'bbp_register_theme_packages' action, and supplemental functions
* Introduce new option for saving the current theme package
* Code and variable clean-up in related files
* Fixes #1801
* Fixes #1802"
changeset,0000004613,[4613],johnjamesjacoby,Introduce toggle_group_forum() method to handle saving of enable_forum group setting. Fixes issue with setting not being saved when creating a new group. Props boonebgorges. Fixes #2122.
changeset,0000004695,[4695],johnjamesjacoby,Introduce tool for repairing each forum's sticky topic ID's. Props gawain. Fixes #2157.
changeset,0000005309,[5309],johnjamesjacoby,"Introduce topic & reply counts for users:
* New functions for updating user options.
* New action hooks for bumping existing counts on CRUD actions.
* Uses existing `_raw` functions when no counts are previously found to incrementally update missing meta values.
* Tool for updating topic & reply counts already exists.
* Props netweb, MZAWeb, anointed.
* Fixes #1694."
changeset,0000002782,[2782],johnjamesjacoby,"Introduce topic and reply revisions, complete with optional logging and reason for editing. Props !GautamGupta via Google Code-in"
changeset,0000002756,[2756],johnjamesjacoby,Introduce topic split/merge functionality. Props !GautamGupta via Google Code-in
changeset,0000003378,[3378],johnjamesjacoby,Introduce UI for 'Allow Global Access' setting for multisite installations. Functionality to follow.
changeset,0000004718,[4718],johnjamesjacoby,Introduce Vanilla converter tool. Props netweb. Fixes #2179.
changeset,0000005152,[5152],netweb,Introduce vBulletin v3.x bbPress importer. Props netweb. Fixes #2147
changeset,0000002789,[2789],johnjamesjacoby,Introduce views API into plugin. Allows for creating specific topic views with code rather than with templates. The 'no-replies' view is included as default. Props !GautamGupta via Google Code-in
changeset,0000003020,[3020],johnjamesjacoby,Introduce views widget to show list of registered views in sidebar. Props !GautamGupta.
changeset,0000002514,[2514],johnjamesjacoby,Introduce Walker class (from WP page Walker) plus main class cleanup
changeset,0000005130,[5130],johnjamesjacoby,"Introduce wrapper functions for custom post-type and taxonomy labels, rewrite settings, and supports options."
changeset,0000005146,[5146],netweb,Introduce XenForo bbPress importer. Props netweb. Fixes #2403
changeset,0000005144,[5144],netweb,Introduce XMB bbPress importer. Props netweb. Fixes #2404
changeset,0000005044,[5044],johnjamesjacoby,Invert the explicit tinymce comparison in bbp_get_the_content() to look for !== false instead of === true. Fixes bug causing textarea output to be incorrectly escaped when using a custom tinymce stylesheet. Fixes #2369.
changeset,0000004539,[4539],johnjamesjacoby,Invert the public forum check (see #2081)
changeset,0000003239,[3239],johnjamesjacoby,"Invert the topic order in stand alone importer, so that new post ID's are in the correct order. Props danieljuhl. See #1534."
changeset,0000005148,[5148],netweb,"Invision bbPress importer improvements. Props netweb. Fixes #2465
* Full compatibility with Invision Power Board v3.1x, v3.2x, v3.3x & v3.4x versions
* Removed conflicting extra user profile fields
* Added forum type if forum is a Forum or Category
* Fixed Forum slug field mapping
* Improved inline docs"
changeset,0000004725,[4725],johnjamesjacoby,Invision converter improvements. Props netweb. Fixes #2181.
changeset,0000003895,[3895],nacin,"Issue a Last-Modified header in rss.php in the proper HTTP-date format per RFC 1123.
The parameter documentation of bb_send_304() requires an HTTP-date, so only fixing the caller.
Incorrect: 2012-05-10 00:49:56
Correct: Tue, 15 Nov 1994 08:12:31 GMT
"
changeset,0000004576,[4576],johnjamesjacoby,"Iterate on #1917.
* Remove fullscreen editor from teeny editor buttons.
* Introduce tabfocus plugin, with some approximate values.
* Props ethitter.
* Note: theme-side tinymce tabfocus still not working as intended."
changeset,0000006185,[6185],johnjamesjacoby,"Labels: Prefer ""Add New"" over ""New Thing""."
changeset,0000006729,[6729],johnjamesjacoby,"Labels: Update post type & taxonomy labels to latest keys.
This change updates forum, topic, topic-tag, and reply labels to include all of the most recent additions to their `labels` registration arguments. It also switches to the escaped gettext variant functions to match existing standards."
changeset,0000004034,[4034],johnjamesjacoby,"Languages:
* Add missing textdomains.
* Fixes #1866.
* Props daveshine."
changeset,0000004035,[4035],johnjamesjacoby,"Languages:
* Move 'bbp_load_textdomain' action to 'bbp_loaded' from 'bbp_init.'
* Loads early to allow widget titles to be translated.
* Fixes #1797.
* Props daveshine, cnorris23."
changeset,0000004030,[4030],johnjamesjacoby,"Languages:
* Switch 'buddypress' textdomains to 'bbpress'
* See #1866."
changeset,0000004060,[4060],johnjamesjacoby,"Languages:
* Update bbpress.pot file."
changeset,0000004132,[4132],johnjamesjacoby,"Languages:
* Update bbpress.pot for 2.1.2."
changeset,0000004044,[4044],johnjamesjacoby,"Languages:
* Update bbpress.pot."
changeset,0000004028,[4028],johnjamesjacoby,"Languages:
* Update bbpress.pot."
changeset,0000004014,[4014],johnjamesjacoby,"Languages:
* Update bbpress.pot."
changeset,0000004111,[4111],johnjamesjacoby,"Languages:
* Update bbpress.pot.
* For 2.1 branch."
changeset,0000003990,[3990],johnjamesjacoby,"Languages:
* Update bbpress.pot. (plugin branch)
"
changeset,0000006507,[6507],johnjamesjacoby,"Languages: Deprecate custom bbPress `/languages/bbpress/` directory.
* It's still supported if it exists, otherwise it's skipped.
* Introduce new `base` property to the `bbPress` class to help with targeting the global directory.
This results in 1 fewer call to `load_textdomain()` and 2 fewer if the old directory is not in place."
changeset,0000006489,[6489],johnjamesjacoby,"Languages: Introduce UI for updating account language.
Includes helper functions for theme-side user editing, to wrap around `wp_dropdown_languages()`.
Fixes #3010."
changeset,0000002844,[2844],johnjamesjacoby,"Let there be life! Show avatars for 'started by' post meta, and show last poster avatar and profile link in freshness columns. Swap out is_int checks for is_numeric in places where the value passed is numeric, but may be cast as a string from previous routines. Also introduce admin.dev.css file for further development of the green admin style."
changeset,0000002942,[2942],johnjamesjacoby,"Lighten the mood when editing a user, and use the light-blue .info styling instead of the yellow .message styling."
changeset,0000003363,[3363],johnjamesjacoby,Limit length of forum and topic slugs to 200 chars in 1.x importer. Fixes #1564. Props cnorris23.
changeset,0000002987,[2987],johnjamesjacoby,"Limit single forum topic pagination end_size to 3, and add inline comment to $total bump."
changeset,0000002948,[2948],johnjamesjacoby,"Limit topic drop down to most recent 50 topics when attempting to post a reply from within wp-admin, as this will not be the primary method of replying and loading all topics will very quickly lead to memory issues."
changeset,0000003314,[3314],johnjamesjacoby,Link to reply URL and not single reply permalink in topic subscription emails.
changeset,0000006787,[6787],johnjamesjacoby,Links: Add `$cap` to `bbp_get_view_all` filter. See #3195.
changeset,0000004772,[4772],johnjamesjacoby,Load bbp_login_notices() on 'bbp_head' so text is properly translated. Props alex-ye. Fixes #2217.
changeset,0000004559,[4559],johnjamesjacoby,Load the textdomain before bbp_register. Fixes #2073.
changeset,0000006089,[6089],netweb,"Locale - i18n/l10n: Differentiate the noun and verb ""Reply"" string.
""Reply"" can be used as both a verb and a noun, this changeset adds this context to instances of the ""Reply"" string thus allowing the different contexts to be translated accurately.
Props ocean90.
Fixes #2977.
"
changeset,0000006988,[6988],johnjamesjacoby,"Locale: fix an encoding typo.
This commit fixes a hard-to-see character encoding bug causing a right-quote to be incomplete in an admin-area Help Tab.
Props casiepa. Fixes #3291. For 2.6.3, branches/2.6."
changeset,0000006989,[6989],johnjamesjacoby,"Locale: fix an encoding typo.
This commit fixes a hard-to-see character encoding bug causing a right-quote to be incomplete in an admin-area Help Tab.
Props casiepa. Fixes #3291. For 2.7, trunk."
changeset,0000006902,[6902],johnjamesjacoby,"Locale: update post type labels to include recent additions to WordPress.
This commit adds several new label keys to the arrays for the Forum/Topic/Reply post types. It also removes some duplicated keys that have slipped in over time.
Props GDragoN. Fixes #3250.
"
changeset,0000006991,[6991],johnjamesjacoby,"Locale: use correct singular versions, and format numeric results.
This commit fixes 2 typos causing plural versions of strings to appear where singulars should, and also makes sure that related numeric upgrade routine results are formatted.
Props webaware. Fixes #3290. For 2.6.3, branches/2.6."
changeset,0000006990,[6990],johnjamesjacoby,"Locale: use correct singular versions, and format numeric results.
This commit fixes 2 typos causing plural versions of strings to appear where singulars should, and also makes sure that related numeric upgrade routine results are formatted.
Props webaware. Fixes #3290. For 2.7, trunk."
changeset,0000002827,[2827],johnjamesjacoby,"Login widget, and various supporting styles and functions for a smarter redirect. Fixes #1464, #1465. Props !GautamGupta for original patches."
changeset,0000006835,[6835],johnjamesjacoby,"Login: Do not prematurely escape `$redirect_to` in `bbp_logout_url()`.
This change fixes a bug causing the redirect URL to be escaped before it's encoded.
Props nevis2us. Fixes #3199."
changeset,0000006863,[6863],johnjamesjacoby,"Login: Updates to `bbp_logout_url()`:
* Removes Apache-only `REDIRECT_URL` usage
* Defaults to the Referer (for smart redirects)
* Adds a filter to the redirect_to string
* Validates the redirect_to after being filtered
* Falls back to `bbp_get_root_url()` if invalid
* Ensures that custom `$redirect_to` values are preserved
Fixes #2188."
changeset,0000002621,[2621],johnjamesjacoby,Look in 'bbpress' subfolder of WP_LANG_DIR for global language files
changeset,0000002503,[2503],chrishajer,"Loop correctly through term objects; pass objects by reference. Fixes #1313. Props to bobrick
"
changeset,0000003917,[3917],johnjamesjacoby,"Main Class:
* Mark main bbPress class as final, and some methods as static."
changeset,0000004659,[4659],johnjamesjacoby,"Make .bbp-author-name elements display inline-block, to allow them to properly center in the available space."
changeset,0000005821,[5821],johnjamesjacoby,Make a statement without saying a word. (!)
changeset,0000002524,[2524],johnjamesjacoby,Make admin theme links a little brighter green.
changeset,0000004753,[4753],johnjamesjacoby,"Make bbp_add_forums_roles() return the $wp_roles global, for future use when looking for the WP_Roles object later."
changeset,0000002538,[2538],johnjamesjacoby,Make bbPress admin area style links less minty.
changeset,0000007034,[7034],johnjamesjacoby,Make CSS linter happy again.
changeset,0000007033,[7033],johnjamesjacoby,Make CSS linter happy again.
changeset,0000002656,[2656],johnjamesjacoby,Make error message ambiguous since it is also used in non-forum contexts
changeset,0000002660,[2660],johnjamesjacoby,Make favorites work without needing AJAX. Add Topics Created to author page. Adjust some CSS. Rename favorite links to permalinks. Clean up author.php.
changeset,0000003170,[3170],johnjamesjacoby,Make forums settings section descriptions more verbose. Separate root slug section from single slugs. Add section for future RSS feed topics/replies per page.
changeset,0000004997,[4997],johnjamesjacoby,"Make search results page use pretty permalinks if they are enabled:
* Change search form method from ""get"" to ""post""
* Move 'bbp_search_request_redirect' action to 'bbp_post_request' to avoid recursion.
* Tweak bbp_search_request_redirect() to check for pretty permalinks, and remove now superfluous recursion checks.
* See #2337."
changeset,0000003786,[3786],johnjamesjacoby,"Make sure _is_*_edit_ template tags work in wp-admin
* Fixes issue with saving topic sticky value from wp-admin
* Fixes issue saving forum and reply metabox values on some installs"
changeset,0000003804,[3804],johnjamesjacoby,Make sure all (3) parameters are passed through to new_reply_redirect_to filter.
changeset,0000004860,[4860],johnjamesjacoby,Make sure moderators have the 'view_trash' capability. Fixes bug where moderators would hit a 404 after trashing a topic. Fixes #2307 (2.3 branch)
changeset,0000004859,[4859],johnjamesjacoby,Make sure moderators have the 'view_trash' capability. Fixes bug where moderators would hit a 404 after trashing a topic. Fixes #2307 (trunk)
changeset,0000003801,[3801],johnjamesjacoby,"Make sure that group ID and forum ID are cross-saved when creating the base group forum.
* Fixes #1779
* Props boonebgorges for initial patch"
changeset,0000005006,[5006],johnjamesjacoby,"Make sure that topics and replies in private/hidden forums are excluded from the ""insert links"" dialogue window. Hat tip jaredatch. See #2334."
changeset,0000003896,[3896],westi,"Make sure the redirect url is a string before we try and handle it.
"
changeset,0000003802,[3802],johnjamesjacoby,"Make sure to only return a single value in bbp_get_forum_group_ids()
* Fixes #1780
* Props boonebgorges"
changeset,0000003810,[3810],johnjamesjacoby,Make sure topic tags appear on single topics and replies. Props jaredatch. Fixes #1791.
changeset,0000004560,[4560],johnjamesjacoby,Make sure topic/reply titles are always set in statistics shortcode and dashboard metabox. Fixes #2087.
changeset,0000002717,[2717],mdawaffe,make sure we're always reading from the correct user meta key
changeset,0000003090,[3090],johnjamesjacoby,"Make the img.avatar CSS a little more specific so not to conflict with most blog posts, comments, widgets, etc..."
changeset,0000002946,[2946],johnjamesjacoby,Make the updater check for version numbers greater than what is set in the DB. Alligator open to the left John; to the left.
changeset,0000002545,[2545],johnjamesjacoby,Make times play nicely with each other.
changeset,0000004716,[4716],johnjamesjacoby,"Map group forum meta caps directly to 'bbp_map_meta_caps' filter to avoid recursion. Also remove BuddyPress 'topic' action check, to allow single group-forum capability map to work correctly. Fixes #2140."
changeset,0000002783,[2783],johnjamesjacoby,Map read_ caps for forums/topics/replies. Also revert r2779 since we remove the moderator role completely. Props !GautamGupta via Google Code-in
changeset,0000003392,[3392],johnjamesjacoby,Map to 'do_not_allow' cap if user is marked as spam or deleted. Fixes #1568. Props sorich87.
changeset,0000005175,[5175],johnjamesjacoby,Mass hysteria. See #1889.
changeset,0000005560,[5560],johnjamesjacoby,Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.
changeset,0000004408,[4408],johnjamesjacoby,"Member's Forums:
* Update ""Topics Replied To"" to ""Replies Created.""
* Reference correct template to mirror bbPress functionality in !BuddyPress profiles."
changeset,0000004323,[4323],johnjamesjacoby,"Mentions:
* Add username @-mention filters.
* Automatically links to profiles when @username is used in a topic or reply content area."
changeset,0000006346,[6346],johnjamesjacoby,"Mentions: Add classes and basic styling to mention clickable callback.
Fixes #3074. See #meta-2542.
"
changeset,0000006382,[6382],johnjamesjacoby,"Mentions: Add tests for square and round brackets.
See #2963."
changeset,0000006380,[6380],johnjamesjacoby,"Mentions: Balance tags before making things clickable.
Then, make mentions clickable without ""requiring"" prepending whitespace. This allows other types of characters to be immediately before the `@` control character.
See #2963."
changeset,0000006381,[6381],johnjamesjacoby,"Mentions: Move topic/reply content filters into the same section of `filters.php`.
Also add `wp_make_content_images_responsive` filter, to match core content areas.
See #2963."
changeset,0000006014,[6014],johnjamesjacoby,"Mentions: Refactor the way user mentions are discovered and linked.
* Adds a filter to `bbp_make_clickable`
* Adds filters for for previously hard-coded clickables
* Adds new filter for at-mention clickable
* Deprecates previous functions for finding & linking at-mentions
For 2.6 (trunk). Hat-tip to Daniel Cid.
"
changeset,0000006015,[6015],johnjamesjacoby,"Mentions: Refactor the way user mentions are discovered and linked.
This is a port of r6014 (without unit tests) for the 2.5 branch.
* Adds a filter to bbp_make_clickable
* Adds filters for for previously hard-coded clickables
* Adds new filter for at-mention clickable
* Deprecates previous functions for finding & linking at-mentions
For 2.5.9 (2.5 branch). Hat-tip to Daniel Cid.
"
changeset,0000004786,[4786],johnjamesjacoby,Merge topic/reply author with attributes metabox save action. Fixes bug causing freshness time to be incorrectly updated from within the dashboard. Props alex-ye. Fixes #2229.
changeset,0000004423,[4423],johnjamesjacoby,Merge updated bbpress.pot file into trunk for 2.2.
changeset,0000006949,[6949],johnjamesjacoby,"Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.6.1, branches/2.6."
changeset,0000006948,[6948],johnjamesjacoby,"Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.7, trunk."
changeset,0000007149,[7149],johnjamesjacoby,"Meta: always query meta_value by string, not by integer.
This commit swaps ""%d"" for ""%s"" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In branches/2.6, for 2.6.6. See #3408."
changeset,0000007150,[7150],johnjamesjacoby,"Meta: always query meta_value by string, not by integer.
This commit swaps ""%d"" for ""%s"" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In trunk, for 2.7. Fixes #3408."
changeset,0000006296,[6296],johnjamesjacoby,"Meta: Filter `_count_int` and enforce integer values.
Also use convenience functions for forum post counts, to ensure proper filters are ran against all meta values.
See #3059."
changeset,0000006297,[6297],johnjamesjacoby,"Meta: Missed `bbp_get_user_topic_count_int` in r6296.
Props @thebrandonallen. See #3059."
changeset,0000006197,[6197],johnjamesjacoby,"Metaboxes: Add metaboxes for viewing favorites & subscriptions of topics & replies.
* New functions for outputting avatars of users who have favved or subbed
* Use the `$post` parameter that's passed in, rather than using `get_the_ID()` again
* Use `require_once` as a language construct vs. `include_once()` as a function
* Pass `$post` object through to metabox subsequent filters vs just the ID
See #2959."
changeset,0000006769,[6769],johnjamesjacoby,"Metaboxes: parse arguments passed into `BBP_Topic_Replies_List_Table()` constructor.
This allows conditional filtering & overloading of what the Replies list table displays."
changeset,0000006770,[6770],johnjamesjacoby,"Metaboxes: show non-public replies in topic-replies meta/list box.
This shows trashed/spam replies to capable users when editing a topic via WordPress admin, because if you're moderating a topic from here, chances are high you want to see everything - not just public replies."
changeset,0000006200,[6200],netweb,"Metaboxes: Update `@since` revisions for functions introduced in r6197.
See #2959.
"
changeset,0000003292,[3292],johnjamesjacoby,Mind any existing meta queries. Fix regression introduced in r3291.
changeset,0000004857,[4857],johnjamesjacoby,Minify default CSS files (2.3 branch)
changeset,0000005492,[5492],johnjamesjacoby,Missed a 'Reply To' reply title update. See r5490.
changeset,0000002522,[2522],johnjamesjacoby,Missed a few spots...
changeset,0000003102,[3102],johnjamesjacoby,Missed a spot from r3098. Fixes possible empty reply_content error when editing a reply.
changeset,0000005361,[5361],johnjamesjacoby,Missed a spot.
changeset,0000002767,[2767],johnjamesjacoby,Missed a spot. See r2765.
changeset,0000003577,[3577],johnjamesjacoby,Missed a spot. Swap @public for @var. See r3576
changeset,0000005562,[5562],johnjamesjacoby,Missed removing a tabindex usage. See #2714.
changeset,0000003965,[3965],johnjamesjacoby,Missed two EOF ?> in index.php files. See r3964; #1850.
changeset,0000006139,[6139],johnjamesjacoby,"Moderation: /s/exists/missing
See #3032."
changeset,0000006858,[6858],johnjamesjacoby,"Moderation: add author-specific keymaster & moderation checks.
This fixes a regression where Moderators were allowed to skip strict moderation rules. Moderators are held to the same standard that regular users in the forums are.
See #3215.
"
changeset,0000006138,[6138],johnjamesjacoby,"Moderation: Add error message if reply could not be found or no longer exists.
See #3032."
changeset,0000006050,[6050],netweb,"Moderation: Add new `bbp_moderation_keys` and `bbp_blacklist_keys` filters
This changeset allows external plugins to filter the list of moderation and blacklist keyword terms, IP, URLs, words, etc.
Also cleans up `bbp_check_for_moderation()` to bails early if there are no moderation keys inline with `bbp_check_for_blacklist()`
Props thebrandonallen, satollo.
Fixes #2861.
"
changeset,0000006146,[6146],netweb,"Moderation: Add some missing PHPDoc `@since` revisions
See #3032.
"
changeset,0000006857,[6857],johnjamesjacoby,"Moderation: allow custom keys to be passed in via the `$strict` parameter.
See #3215.
"
changeset,0000006384,[6384],johnjamesjacoby,"Moderation: Allow per-forum moderators to edit topics & replies inside of forums they have moderation control over.
This feature require the following changes:
* Prefer `read_forum` capability check over `read_private_forums` or `read_hidden_forums`, and include a `$forum_id` parameter to assist `map_meta_cap` filters
* Prefer `edit_others_topics|replies` over `moderate` where appropriate, to ensure capability mappings work as intended
* Introduce `bbp_get_public_topic_statuses()` to replace several duplicate occurrences of the same array usage (also allow these to be filtered)
* Introduce `bbp_is_topic_public()` (not to be confused with `bbp_is_topic_published()`) to provide parity with `bbp_is_forum_public()` and also utilize `bbp_get_public_topic_statuses()` from above
* Add local caching to `bbp_exclude_forum_ids()` as a performance optimization to reduce the depth of `current_user_can()` calls when private & hidden forums are in use
* Add `user_can( 'moderate' )` capability checks to various mappings, to ensure forum moderators can read/edit/delete content inside of the individual forums they are moderators of
* Use `bbp_get_user_id()` where appropriate, rather than casting as `int`
* Various surrounding code clean-ups
See #2593."
changeset,0000006349,[6349],netweb,"Moderation: Autoprefixer follow up to [6348] and [6344]
See #3073.
"
changeset,0000006342,[6342],johnjamesjacoby,"Moderation: Clean-up from r6341. Props netweb.
"
changeset,0000006348,[6348],netweb,"Moderation: CSS coding standards fixes follow up after [6344]
See #3073.
"
changeset,0000006133,[6133],johnjamesjacoby,"Moderation: First pass at improved reply toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums & Topics @todo)"
changeset,0000006142,[6142],johnjamesjacoby,"Moderation: First pass at improved topic toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums @todo)"
changeset,0000005841,[5841],johnjamesjacoby,Moderation: Fix some copy-pasta and make sure form terms are formatted correctly. See #459.
changeset,0000006974,[6974],johnjamesjacoby,"Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values."
changeset,0000006973,[6973],johnjamesjacoby,"Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values."
changeset,0000006344,[6344],johnjamesjacoby,"Moderation: Implement theme-side edit-lock interface.
* Edits to defaut theme javascript to interact with alert UI
* Add `alert-topic-lock.php` template part
* Add topic functions relating to edit-lock functionality
* Modify single-topic and topic-edit template parts to include the alert part
* Add CSS to Default template pack to stylize edit-lock alert like a modal (could be pretty much anything)
Props pippin for inspiration. See #3074.
"
changeset,0000006085,[6085],netweb,"Moderation: Include topic and reply post content with and without HTML in `moderation_keys` and `blacklist_keys` checks.
This changeset ensures users cannot bypass the moderation word checks by wrapping parts of the word or term in HTML, e.g. `bannedword` could previously be bypassed using `bannedword`
Fixes #2986.
"
changeset,0000006921,[6921],johnjamesjacoby,"Moderation: make sure pending topics (for moderation reasons) are accessible to authors.
This commit updates the logic inside of the topic & reply map-meta-cap implementations, restricting edit-lock checks to actual ""Edit"" screens, and using the ""edit_others_posts"" capability in non-""Edit"" screens, ensuring that both scenarios are covered.
It also adds an explicit condition for Pending Topics to both the Topic Description and Topic Notices, alerting users as to why they are seeing what they are seeing.
Fixes #3253 (again!) See also #3164 for other related discussion & details.
"
changeset,0000006312,[6312],johnjamesjacoby,"Moderation: Maybe add `view=all` query-arguments to view links in row actions.
Fixes #2938."
changeset,0000006136,[6136],johnjamesjacoby,"Moderation: Move `sub_action` query var into a passable argument, so all actions can have reliable sub-action usage.
See #3032."
changeset,0000006754,[6754],johnjamesjacoby,"Moderation: pass `$content` into `comment_max_links_url` filter.
This changes brings parity to changes made in WordPress 4.7.0.
Fixes #3141."
changeset,0000006137,[6137],johnjamesjacoby,"Moderation: Pass `$reply_id` into `bbp_get_reply_toggles()` so the exacty reply ID can be referenced directly at the time of the filter.
See #3032."
changeset,0000005853,[5853],johnjamesjacoby,"Moderation: reduce moderation restriction from `keep-gate` to `moderate` in `bbp_check_for_moderation()`.
This changeset ensures that moderators are able to bypass the forum moderation, seeing as how they can self-approve topics & replies anyways.
Props netweb. Fixes #2726."
changeset,0000006855,[6855],johnjamesjacoby,"Moderation: remove references to blacklist/whitelist verbiage.
This change combines 2 functions into 1, merging `_blacklist()` checks into `_moderation()` checks. A new `$strict` parameter is added, when set to `true` will continue to check against the WordPress `blacklist_keys` option name.
* Tests updated
* `bbp_check_for_blacklist()` deprecated
* Error response keys renamed (non breaking - nothing relies on them)
* Some docs updates
Fixes #3215. For 2.6.
"
changeset,0000006134,[6134],johnjamesjacoby,"Moderation: Rename function to `bbp_get_reply_toggles()` to better match existing naming scheme.
See #3032."
changeset,0000006087,[6087],johnjamesjacoby,"Moderation: Skip moderator query if per-forum moderation is not enabled.
Props jmdodd. Fixes #2988."
changeset,0000006341,[6341],johnjamesjacoby,"Moderation: Use the appropriate `_edit_` post meta when editing a forum/topic/reply.
This first pass does not introduce any theme-side edit-locking interface, but it will warn any user within `wp-admin` if another user is editing something theme-side.
See #3073.
"
changeset,0000007234,[7234],johnjamesjacoby,"Moderation: use the correct `post_status` when untrashing a topic/reply.
This change fixes a bug/regression (since WordPress 5.6.0) that was causing untrashed topics & replies to use an unintended `post_status` value.
It fixes it by adding a new function ('bbp_fix_untrash_post_status()') and hooking it to the `wp_untrash_post_status` filter in WordPress, and overriding the results as needed.
Props r-a-y.
In branches/2.6 for 2.6.10. Fixes #3433."
changeset,0000007235,[7235],johnjamesjacoby,"Moderation: use the correct `post_status` when untrashing a topic/reply.
This change fixes a bug/regression (since WordPress 5.6.0) that was causing untrashed topics & replies to use an unintended `post_status` value.
It fixes it by adding a new function ('bbp_fix_untrash_post_status()') and hooking it to the `wp_untrash_post_status` filter in WordPress, and overriding the results as needed.
Props r-a-y.
In trunk for 2.7.0. Fixes #3433."
changeset,0000007123,[7123],johnjamesjacoby,"Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In branches/2.6, for 2.6.6.
Props SergeyBiryukov.
See #3133."
changeset,0000007122,[7122],johnjamesjacoby,"Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In trunk, for 2.7.
Props SergeyBiryukov.
See #3133."
changeset,0000006519,[6519],johnjamesjacoby,"Moderators: Add an `$object_type` parameter to add/remove/delete functions.
In a future release, this will more easily allow objects like taxonomy-terms to have their own moderators, and is also necessary for future enhancements to the WordPress.org support forums where custom taxonomies are used for prevalently than in bbPress core currently.
See #3068, #459."
changeset,0000005836,[5836],johnjamesjacoby,Moderators: Add forum moderators field to `form-forum.php` template part. See #459.
changeset,0000005862,[5862],netweb,"Moderators: Add missing @since PHPDoc missed in `bbp_map_forum_mod_meta_caps()` via r5834
"
changeset,0000006223,[6223],johnjamesjacoby,"Moderators: Allow moderators to see topic/reply author IP addresses.
Fixes #2975."
changeset,0000006407,[6407],johnjamesjacoby,"Moderators: Another performance optimization in `bbp_is_user_forum_moderator()`.
Use `bbp_is_object_of_user()` directly, and clean-up local variable reassignments."
changeset,0000005834,[5834],johnjamesjacoby,"Moderators: First pass at per-forum moderators.
This commit introduces a powerful feature commonly found in other popular forum software that has been on our wishlist for nearly 9 years. It includes the following changes:
* Custom `forum-mod` taxonomy for assigning user nicenames to forum IDs
* Associated functions for defining capabilities, labels, etc...
* New capability filters for ensuring forum moderators have the ability to moderate forums even without the `moderator` role assignment
* New option for toggling the entire feature on/off (on by default)
Props jmdodd, netweb. See #459."
changeset,0000006563,[6563],johnjamesjacoby,"Moderators: Introduce ""Super Moderators"" setting.
This change introduces the option (and default off value), admin setting and UI for toggling it on and off.
A ""Super Moderator"" is a moderator with the ability to also edit users, a commonly requested and popular feature in other forum software. The use-case is that user accounts may be spammers and need to be moderated beyond just their topics & replies, but the `edit_users` capability is reserved for Administrators (or Super Admins in multisite.) This setting will act as the global on/off to the deeper implementation of this feature."
changeset,0000005835,[5835],johnjamesjacoby,"Moderators: Introduce `none` argument for topic-tags & forum-mods list functions.
This change allows for passing text or HTML to output if no taxonomy terms are found, and uses this new functionality in `wp-admin` to show per-forum moderators in the list-table column, also reducing code duplication.
See #459."
changeset,0000005838,[5838],johnjamesjacoby,Moderators: Introduce functions for theme-side setting & getting of forum mods for `form-forum.php`. See #459.
changeset,0000006032,[6032],johnjamesjacoby,"Moderators: pass current forum/topic/reply ID into `moderate` capability checks, providing additional context about what's being moderated so more targeted decisions can be made.
See #459."
changeset,0000006406,[6406],johnjamesjacoby,"Moderators: Performance optimization in `bbp_is_user_forum_moderator()`.
Rather than query for all forums a user can moderate, query for the users that can moderate the forum. This data is likely already hot in the meta-data cache from forums being loaded previously, and eliminates the need to query for forum IDs that are unrelated to the one being checked."
changeset,0000006455,[6455],johnjamesjacoby,Moderators: Prefer `sanitize_title` over `trim`. See #3097.
changeset,0000006056,[6056],johnjamesjacoby,"Moderators: Refactor per-forum moderators to use meta-data instead of mocked taxonomy terms.
If the future of Forums is a taxonomy (vs. a custom post-type) then a per-forum Moderator taxonomy for a Forum taxonomy won't work very well, for a few reasons:
* Scalability
* Taxonomies for taxonomies is a bit more inception than should be required for this simple feature
* Forum moderators do not require much of what taxonomy objects provide (permalinks, visibility, metadata, etc...)
* User taxonomy terms matching nicenames works okay for something like Automattic's P2 theme, but bbPress requires a user ID based solution to avoid data synchronization issues between nicenames & term slugs
So... the future of per-forum per-user capability mappings is in meta-data using `map_meta_cap`.
This commit:
* Removes the `forum_mod` taxonomy and surrounding code additions introduced in the first pass in r5834
* Renames `forum_mod` functions to `forum_moderator` to be more explicit
* Adds CRUD wrapper functions for per-forum moderator meta data
* Adds administrative interfaces for assigning moderators to forums for `wp-admin` and forum `edit` pages
* Adds helper functions for getting user nicenames & IDs
Note that this feature has now been refactored to no longer be forum specific (I.E. object agnostic) -- it's possible for any user access to be mapped based on the object type using any meta-data key. While this is currently useful for per-forum moderators, it may be user for per-topic blocking, per-topic-tag moderation, etc...
See #459."
changeset,0000005839,[5839],johnjamesjacoby,Moderators: Rename `bbp_get_forum_mod_ids()` to `bbp_get_forum_moderator_ids()` to better match unabbreviated forum equivalent. Also update phpdoc & refactor some logic to use cached functions. See #459.
changeset,0000006454,[6454],johnjamesjacoby,"Moderators: Trim usernames after they're exploded.
Resolves an issue where spaces in the comma separated usernames field would result in skipping that user.
Fixes #3097."
changeset,0000006221,[6221],johnjamesjacoby,"Moderators: Update `bbp_get_moderator_forum_ids()` to use same approach as favs/subs.
See #459, #2959, #2972."
changeset,0000003057,[3057],johnjamesjacoby,"More adjustments for theme compatability layer. Rejigs the bbp_load_template function to also have theme compatability. Introduces bbp_user_can_view_forum() function as a method to check the scope of a users ability to view private/hidden forums, topics, and replies."
changeset,0000003100,[3100],johnjamesjacoby,More aggressive CSS on topic/reply revision log for theme compat
changeset,0000003851,[3851],johnjamesjacoby,More aggressively check private and hidden forums when changing forum status. (2.0 branch)
changeset,0000003852,[3852],johnjamesjacoby,More aggressively check private and hidden forums when changing forum status. (plugin branch)
changeset,0000002509,[2509],johnjamesjacoby,More bbp_loader.php cleanup. Move activation/deactivation/uninstall sequence functions into loader class.
changeset,0000002971,[2971],johnjamesjacoby,More clean-up to bbp_pre_get_posts. Fixes #1450.
changeset,0000005040,[5040],johnjamesjacoby,"More esc_url() improvements, and practice late-escaping where we were otherwise passing around escaped URL variables. See #2367."
changeset,0000006387,[6387],johnjamesjacoby,More graceful handling of the `$post` global in `bbp_get_global_post_field()`.
changeset,0000005285,[5285],johnjamesjacoby,"More Grunt improvements:
* Fixes CSS & JS admin folder path for `BBP_RTL_CSS`, `BBP_LTR_CSS` & `BBP_JS` in Gruntfile.js
* Removes Mint & Evergreen CSS (including RTL) to use Mint & Evergreen SCSS
* Adds `_admin.scss`, `_mixins.scss`, `_variables.scss` via ([https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/colors /trunk/src/wp-admin/css/colors]) to build our Mint & Evergreen admin themes
* Adds `/includes/admin/styles/evergreen/colors.scss` & `/includes/admin/styles/mint/colors.scss` via [https://github.com/ryelle/admin-color-schemes/tree/2288dcd5b57c9a9045de62d1cfa72722d5163cfc 2288dcd5b5 MP6 GitHub Repo Changset]
* Adds support in Gruntfile.js to build minified and RTL Mint & Evergreen CSS
* Adds `grunt-sass` `~0.10.0` to `package.json` to build Mint & Evergreen CSS from SCSS source
* Reinstates minified and `SCRIPT_DEBUG` support for minified Mint & Evergreen CSS
* Adds minified and `SCRIPT_DEBUG` support for admin javascript & frontend javascript
Props netweb. See #2542."
changeset,0000005344,[5344],netweb,"More Grunt updates
* Adds `uglify:dynamic` to `grunt uglify` so that `grunt watch` -> `watch:js` tasks can dynamicly minify Javascript files with the `grunt watch` task.
* Improved inline documentation for grunt jshint task.
* Props netweb. See #2542
"
changeset,0000005294,[5294],netweb,"More Grunt updates, fixes `grunt watch` task not RTL'ing or minifying CSS files.
* Use explicit CSS file names, avoids ambiguous LTR CSS (avoids LTR = `*.css` including `bbpress-rtl.css`)
* Remove `cssmin:colors` and include Mint and Evergreen CSS minification in `cssmin:core`
* Remove `cssjanus:colors` and include Mint and Evergreen RTL CSS in `cssjanus:core`
* Use `BUILD_DIR` (not `SOURCE_DIR`) to compile RTL CSS `cssjanus`
* Use `BUILD_DIR` (not `SOURCE_DIR`) to compile and LTR & RTL minified CSS with `cssmin`
* Add Grunt tasks `cssjanus:core`, `cssmin:ltr` and `cssmin:rtl` to `grunt watch` -> `watch:colors` task
* Add Grunt tasks `cssmin:ltr` and `cssmin:rtl` to `grunt watch` -> `watch:rtl` task
* Reorders `grunt build` and `grunt build-release` tasks to firstly copy `bbpress.css`, and `admin.css`, then create Mint and Evergreen CSS using `colors` , then RTL all the CSS with `cssjanus:core`, then minify all the CSS with `cssmin:ltr` and `cssmin:rtl`
* Props netweb. See #2542"
changeset,0000005293,[5293],johnjamesjacoby,"More Grunt updates:
* Add `_n_noop` to `grunt-pot` keyword check
* Remove grunt task `test` as PHPUnit tests are covered by grunt task `phpunit`
* Add grunt task `jstest` to run javascript tasks
* Add `grunt-checktextdomain` to `package.json` to check for missing or incorrect text-domain in gettext functions. See https://www.npmjs.org/package/grunt-checktextdomain
* Adds grunt task `checktextdomain` to `grunt build-release`
* Checks for the following keywords: `__:1,2d`, `_e:1,2d`, `_x:1,2c,3d`, `_n:1,2,4d`, `_ex:1,2c,3d`, `_nx:1,2,4c,5d`, `esc_attr__:1,2d`, `esc_attr_e:1,2d`, `esc_attr_x:1,2c,3d`, `esc_html__:1,2d`, `esc_html_e:1,2d`, `esc_html_x:1,2c,3d`, `_n_noop:1,2,3d`, `_nx_noop:1,2,3c,4d`
* Props netweb. See #2542."
changeset,0000005289,[5289],johnjamesjacoby,"More grunt updates:
* Add RTL, minified and `SCRIPT_DEBUG` support for bbPress admin CSS.
* Add RTL, minified and `SCRIPT_DEBUG` support for bbPress default theme-compat CSS.
* RTL bbPress CSS is now compiled with cssjanus. (`bbpress-rtl.css` file removed)
* Props netweb. See #2542."
changeset,0000005326,[5326],netweb,"More grunt updates:
* Add `grunt-patch-wordpress` to `package.json`
* Adds grunt task `grunt patch` to `grunt build` and `grunt build-release`
* Requires fresh `npm install` to update dependencies
* Full instructions https://github.com/aaronjorbin/grunt-patch-wordpress#patching-from-the-command-line
* Props jorbin. See #2542
"
changeset,0000005333,[5333],netweb,"More grunt updates:
* Include bbPress version via `package.json` in the 'banner' of minified CSS & JS files
* Include current date and time (UTC) in the 'banner' of minified CSS & JS files
* Props netweb. See #2542
"
changeset,0000005295,[5295],netweb,"More Grunt: Switch from `grunt-pot` to `grunt-wp-i18n`
* Remove `grunt-pot` from `package.json`
* Add `grunt-wp-i18n` to `package.json`
* Adds grunt task `grunt makebot` to `grunt build` and `grunt build-release`
* Creates `bbpress.pot` in `/build`
* Requires fresh `npm install` to update dependencies
* Props netweb. See #2542
"
changeset,0000005031,[5031],johnjamesjacoby,More improvements to responsive CSS. Props mercime. Fixes #1933.
changeset,0000004590,[4590],johnjamesjacoby,More precise list-item CSS. See #2113.
changeset,0000002885,[2885],johnjamesjacoby,"More renaming of last_active to last_active_time, this time in bbp-admin.php"
changeset,0000002879,[2879],johnjamesjacoby,"More renaming of last_active to last_active_time, this time in bbp-wdigets. Also use enhanced bbp_reply_author_link function to include user gravatar."
changeset,0000003180,[3180],johnjamesjacoby,More security sweep and code clean-up through bbp-topic-functions.php. Also fix incorrect variable usage in bbp_update_topic_reply_count() and bbp_update_topic_last_active_time(). See #1514.
changeset,0000003136,[3136],johnjamesjacoby,More security sweep and final code clean-up on bbp-topic-functions.php. See #1514.
changeset,0000005335,[5335],johnjamesjacoby,"More specific CSS selector on closed topics to only target lists of topics, not single topic views. See r2962."
changeset,0000004641,[4641],johnjamesjacoby,More thorough regex for pre and code tags and HTML entities. Props Corey Worrell. See #1967.
changeset,0000003091,[3091],johnjamesjacoby,"More tweaks to avatar styling. Revert r3089/r3090 in favor of something specific to bbPress templates and widgets that guess at container ID's, since some themes are very specific about their avatar positioning."
changeset,0000003147,[3147],johnjamesjacoby,More tweaks to the readme.txt
changeset,0000005091,[5091],johnjamesjacoby,"More updated ""About"" text for 2.4."
changeset,0000003424,[3424],johnjamesjacoby,More useful phpDoc for bbp_sanitize_val() and bbp_get_sanitize_val()
changeset,0000003672,[3672],johnjamesjacoby,More verbose descriptions and whitespace clean-up in bbp-core-hooks.php.
changeset,0000004988,[4988],johnjamesjacoby,Move $postarr arrays into their respective calls to wp_update_post().
changeset,0000003012,[3012],johnjamesjacoby,Move 'bbp_register_textdomain' to priority 2 on 'bbp_init' action. Fixes #1497. Props !GautamGupta for original patch.
changeset,0000003689,[3689],johnjamesjacoby,Move 'bbp_setup_current_user' action off of 'bbp_init' and onto 'set_current_user.' See #1722.
changeset,0000003427,[3427],johnjamesjacoby,Move 'bbp_setup_updater' action off of 'bbp_init' and late onto 'bbp_ready' to ensure alterations to the permastruct have settled. Fixes issue where a bbPress update would flush the rewrite rules too early on bbPress update. See #1569.
changeset,0000003439,[3439],johnjamesjacoby,Move 'bbp_setup_updater' action to 'bbp_admin_init' so update only runs when accessing wp-admin. See #1569. Props nacin.
changeset,0000004826,[4826],johnjamesjacoby,"Move 'bbp_template_redirect' action to priority 8, giving bbPress precedence over network activated plugins hooked to 'template_redirect' at priority 10 (like BuddyPress). Fixes #2225."
changeset,0000003282,[3282],johnjamesjacoby,"Move 'bbp_user' and 'bbp_view' into bbPress global vars, so they can be referenced by external plugins more easily and require less maintenance to change if needed later."
changeset,0000003217,[3217],johnjamesjacoby,"Move _bbp_include_root option into single slug area, to more accurately mirror the order of the settings page. Include more detailed description of what it does."
changeset,0000004570,[4570],jmdodd,"Move `bbp_notify_subscribers` to priority 11.
* Fixes #2038.
"
changeset,0000005274,[5274],johnjamesjacoby,"Move `includes` and `templates` back into `/src` directory. See #2452.
"
changeset,0000003192,[3192],johnjamesjacoby,Move a few theme compatibility helper functions out of bbp-general-functions.php and into bbp-core-compatibility.php
changeset,0000003812,[3812],johnjamesjacoby,Move admin action setup lower in file. See r3811.
changeset,0000005225,[5225],johnjamesjacoby,"Move admin CSS and JS out of `admin_head` and into proper enqueues. New `admin.css` replaces top level icons with Dashicons, introduced in WordPress 3.8. Fixes #2396. See #2463."
changeset,0000002659,[2659],johnjamesjacoby,Move ajax handling of favorites into theme. Clean up other favorites related code. More to do.
changeset,0000002658,[2658],johnjamesjacoby,Move ajax handling of favorites into theme. Clean up other favorites related code. More to do.
changeset,0000003104,[3104],johnjamesjacoby,Move all theme compat functions to the bottom of bbp-general-template.php
changeset,0000002613,[2613],johnjamesjacoby,"Move bbp-admin.php into /bbp-admin/ directory. Also introduce bbp-tools page for performing recounts, and bbp-functions.php to stash admin specific functions in."
changeset,0000003078,[3078],johnjamesjacoby,"Move bbp-css and bbp-images into bbp-admin folder, since they only contain an admin style and the admin icons."
changeset,0000003077,[3077],johnjamesjacoby,"Move bbp-css and bbp-images into bbp-admin folder, since they only contain an admin style and the admin icons."
changeset,0000003389,[3389],johnjamesjacoby,Move bbp-twentyten JS and ajax into proper hook. Make topic.js aware that favorites can be disabled.
changeset,0000004773,[4773],johnjamesjacoby,Move bbp_add_forums_roles() to 'bbp_after_setup_theme' action. Fixes issues with role names not being translated in some areas. Fixes #2219.
changeset,0000004404,[4404],johnjamesjacoby,Move bbp_load_textdomain() onto 'bbp_init' - was loading too early on 'bbp_loaded' -> 'plugins_loaded'.
changeset,0000002594,[2594],johnjamesjacoby,Move bbp_loader.php into includes. Rename run-file to bbpress.php. Remove references to 1.2 version and replace with 'plugin'
changeset,0000003433,[3433],johnjamesjacoby,Move bbp_pre_get_posts_exclude_forums() to bbp-forum-functions.php.
changeset,0000003559,[3559],johnjamesjacoby,Move BuddyPress extension loader to bbp-core-hooks.php.
changeset,0000005544,[5544],netweb,"Move callback `callback_check_anonymous` from individual importers to `BBP_Converter_Base` in `converter.php`.
* Allows us to lean on `callback_userid` to determine multiple anonymous or guest topic and reply authors during import and reduces code duplication
Props netweb. See #2347"
changeset,0000002608,[2608],johnjamesjacoby,Move capability add/remove into bbp-caps.php
changeset,0000002752,[2752],johnjamesjacoby,Move excerpt functions under reply_content functions.
changeset,0000003561,[3561],johnjamesjacoby,Move favorites and subscriptions handlers off of template_loader action and on to bp_actions in BuddyPress extension.
changeset,0000005178,[5178],johnjamesjacoby,Move filter adding higher up in `filters.php.` See #2291.
changeset,0000002690,[2690],johnjamesjacoby,Move hidden form fields on edit user page into bbp_edit_user_form_fields()
changeset,0000002644,[2644],johnjamesjacoby,Move hooks and actions into _setup_actions
changeset,0000002593,[2593],johnjamesjacoby,Move included files into bbp-includes. First pass at meta caps (hat tip greenshady)
changeset,0000003728,[3728],johnjamesjacoby,Move is_super_admin() checks to allow return values to be filtered in bbp-user-template.php.
changeset,0000003284,[3284],johnjamesjacoby,"Move loader functions into bbp-core-hooks. Add bbp_new_site action, which is used to create roles, caps, and options when a new site is created on a multisite installation. Remove is_site_admin() check from bbp_allowed_themes() to ensure bbp-twentyten is available for all sites."
changeset,0000002599,[2599],johnjamesjacoby,"Move loader functions out of needless class, and whitespace fixes."
changeset,0000004782,[4782],johnjamesjacoby,"Move new topic sticky-check after 'bbp_new_topic' action, to ensure forum ID meta is saved via bbp_update_topic(). Also move sticky-check in edit-topic handler, so correct forum ID is used when moving a sticky topic. Props imath. Fixes #2230."
changeset,0000003713,[3713],johnjamesjacoby,Move return values into variables for easier debugging in bbp-user-template.php.
changeset,0000002952,[2952],johnjamesjacoby,"Move revision log updaters from -template files to -function files with other updaters. Update phpDoc in functions that previously ran sanity updates if fields did not exist. Mark @todo's in places where sanity meta updates still exist, and mark for investigation for eventual removal."
changeset,0000004593,[4593],johnjamesjacoby,Move root template check to below reset_post blocks. Fixes incorrect 404 and corrects header statuses when using root templates. See #1478.
changeset,0000003143,[3143],johnjamesjacoby,"Move shortcodes into object variable, and add php5 constructor. This allows bbPress plugins to filter existing shortcodes, and/or add new ones."
changeset,0000002692,[2692],johnjamesjacoby,Move special query_vars into dedicated functions
changeset,0000003345,[3345],johnjamesjacoby,"Move the topic tag form template part out of bbp_has_topics() check, and rely normal 404 handling if tag does not exist."
changeset,0000003065,[3065],johnjamesjacoby,Move theme compat message into dashboard widget
changeset,0000003734,[3734],johnjamesjacoby,Move theme compat template files out of bbp-themes and into bbp-theme-compat folder. This avoids confusion with complete bundled theme also acting as the fallback.
changeset,0000003190,[3190],johnjamesjacoby,"Move theme compatibility code out of bbp-general-template.php and into bbp-core-compatibility.php.
Swap out require_once() usages for require() through out project where appropriate."
changeset,0000003653,[3653],johnjamesjacoby,Move trash status background color to wrapper div.
changeset,0000004933,[4933],johnjamesjacoby,Move user base setting into new Users section. Tweak some verbiage to be more succinct. See #1500.
changeset,0000004784,[4784],johnjamesjacoby,Multibyte support for excerpts and breadcrumbs. Hat-tip alex-ye. Fixes #2232.
changeset,0000002471,[2471],chrishajer,"Multiple fixes for email subscriptions. Note the template changes in kakumei. Probably fixes #1268. Big props to dimadin and !GautamGupta
"
changeset,0000005385,[5385],netweb,"Multiple strings in .editorconfig sections should be wrapped in curly brackets
Props treyhunner. Fixes #2614"
changeset,0000002523,[2523],johnjamesjacoby,Mute the wphead border just a bit
changeset,0000003936,[3936],johnjamesjacoby,Narrow the scope of .bbp-topic-permalink styling in bbp-theme-compat.
changeset,0000005043,[5043],johnjamesjacoby,"New approach to content replacement for theme compatability. Rather than juggle the post global and post content around in two procedures, set post_content via bbp_theme_compat_reset_post().
This reduces some complexity, avoids nested shortcodes, and fixes shortcode and the_content filter conflicts. See #2343."
changeset,0000003746,[3746],johnjamesjacoby,"Next pass at BuddyPress Group Fourms integration:
* Filter forms to prevent fields from appearing
* Output new field data where needed on above forms
* Better integration with group create and edit screens
* Tweak forum/group ID functions to return arrays when needed
* Flesh out display_forums() method
* See #1669"
changeset,0000004672,[4672],johnjamesjacoby,"Nicename Usage:
* Introduce template tags for getting and displaying a user nicenames. Helpful for themes that want easier access to @mentions data.
* Improve mention filters to use 'slug' instead of 'login.' Fixes possible mismatches when login and nicename are different."
changeset,0000002845,[2845],johnjamesjacoby,"No follow on all user links, and follow up with stripslashes for good measure."
changeset,0000004050,[4050],johnjamesjacoby,Non Scriptio Continua.
changeset,0000006012,[6012],johnjamesjacoby,Nonce functions are part of the `common` component.
changeset,0000004023,[4023],johnjamesjacoby,"Nonces:
* Introduce bbp_verify_nonce_request() to check nonces on theme-side requests.
* See #1863."
changeset,0000004024,[4024],johnjamesjacoby,"Nonces:
* Use bbp_verify_nonce_request() to prevent the awkward wp_die() experience in forums.
* Add nonce checks to subscriptions and favorites.
* More aggressive returns on edit/new forum/topic/reply nonce and capability checks. Prevents surplus processing when we already know nothing more should happen.
* Bail early if bbp_has_errors() rather than wrapping around it.
* Fixes #1863."
changeset,0000002905,[2905],johnjamesjacoby,"Normalize all post_meta values by removing the _forum, _topic, and _reply prefixes off of them where appropriate. There is no point in having them be unique to the post type as it only duplicates the code needed to perform requests. Future trimming to follow.
Introduce bbp-update.php file, which is used to update existing installations to the new meta_key names from this revision."
changeset,0000003312,[3312],johnjamesjacoby,Normalize archive pages and include content-archive template parts for topics and forums.
changeset,0000002812,[2812],johnjamesjacoby,Normalize bbp-includes directory. Mostly documentation fixes. Introduce bbp-shortcodes placeholder.
changeset,0000002810,[2810],johnjamesjacoby,Normalize bbp-twentyten theme files. Introduce bbp_tab_index functions for forms. Rename some page- files to action- since they are not page templates. Introduce bbp_login and bbp_register place-holders in bbp-twentyten theme.
changeset,0000005403,[5403],johnjamesjacoby,Normalize Favorite and Subscribe links for Forums and Topics so they are visually linear to the breadcrumb. Hat-tip netweb. Fixes #2575.
changeset,0000005060,[5060],johnjamesjacoby,"Normalize forum, topic, and reply dropdown form fields and associated functions. Includes several new functions with _get_ equivalents to replace incorrectly named _select() functions.
First pass at adding custom topic status handling. Props jkudish. See #2187.
Also replaces $wpdb->update() calls with wp_update_post() in associated functions. Fixes #2351."
changeset,0000005399,[5399],johnjamesjacoby,"Normalize metabox UI across Forums, Topics, & Replies. Hat-tip netweb. Fixes #2463."
changeset,0000004733,[4733],johnjamesjacoby,"Normalize svn props for .php files, and add missing index.php to /includes/search/ directory."
changeset,0000002863,[2863],johnjamesjacoby,Normalize tag management files. Use bb_die() where applicable. Swap out destroy_tag verbiage to comply with boolean delete_term results.
changeset,0000003233,[3233],johnjamesjacoby,Normalize the user template files. Add wrapper around user.php template content.
changeset,0000004991,[4991],johnjamesjacoby,Normalize topic and reply admin method names. Some of them were still prefixed from back when all admin methods were in 1 mega-class.
changeset,0000007186,[7186],johnjamesjacoby,"Notices: correct string type checking of ""loggedout"" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the ""You are now logged out."" notice to correctly appear as intended.
In branches/2.6 for 2.6.7. Fixes #3414.
Props dilipbheda, isabel104."
changeset,0000007185,[7185],johnjamesjacoby,"Notices: correct string type checking of ""loggedout"" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the ""You are now logged out."" notice to correctly appear as intended.
In trunk for 2.7.0. See #3414.
Props dilipbheda, isabel104."
changeset,0000003996,[3996],johnjamesjacoby,"Notifications (1.1 branch):
* Check post_status before notifying subscribers, in bb_notify_subscribers().
* Fixes #1479.
* Props jkudish."
changeset,0000004739,[4739],johnjamesjacoby,"Now that mentions are in bbPress core, remove the extra mention code in the BuddyPress activity extension. Fixes #2185."
changeset,0000003858,[3858],johnjamesjacoby,"Number format fixes:
* Introduce bbp_number_format_i18n
* Clean up number format filters
* Allow empty $number values to be passed safely"
changeset,0000004258,[4258],johnjamesjacoby,"Number Formatting:
* Introduce $integer parameter to template-tags to switch filter for integer usage.
* Use absint() where appropriate when getting counts.
* Smarter int type casting.
* Fixes bug where calculations were being done against formatted strings.
* Fixes #1974."
changeset,0000003447,[3447],johnjamesjacoby,"Obey the blacklisted keys in discussion settings when creating or editing topics or replies. Introduces bbp_check_for_blacklist() function in bbp-common-functions.php, and bbp_current_user_ua() in bbp-user-functions.php."
changeset,0000004723,[4723],johnjamesjacoby,"On single forum view, do not check for forum count when trying to query sub forums. Fixes #2085."
changeset,0000005468,[5468],johnjamesjacoby,"Only add the `s` argument to global forum search queries if search-terms exist.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804]."
changeset,0000005467,[5467],johnjamesjacoby,"Only add the `s` argument to queries if `rs` or `ts` are set in their respective topics & replies queries.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804]."
changeset,0000005510,[5510],johnjamesjacoby,"Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.
This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270."
changeset,0000005081,[5081],johnjamesjacoby,Only allow topics to have an archive when the forums archive is showing forums (not topics). Fixes SEO concern where it was possible to have duplicate forum-archives at two different URL's.
changeset,0000003881,[3881],johnjamesjacoby,"Only allow users that can edit other users to change a users role, and do not allow them to change their own role."
changeset,0000003880,[3880],johnjamesjacoby,Only allow users that can edit other users to change a users role.
changeset,0000003879,[3879],johnjamesjacoby,"Only apply borders to top of elements in theme compat, for consistency sake."
changeset,0000003597,[3597],johnjamesjacoby,Only bail if forums are installed correctly.
changeset,0000003849,[3849],johnjamesjacoby,Only enqueue parent theme CSS if parent theme is twentyten.
changeset,0000003806,[3806],johnjamesjacoby,Only exclude private/hidden forum content in feeds when not viewing a single forum. Fixes #1782.
changeset,0000003930,[3930],johnjamesjacoby,"Only filter shortcode queries if query is not already set. Also, use correct filter names."
changeset,0000005132,[5132],johnjamesjacoby,"Only filter the `bbpress` textdomain with the `bbpress_locale` filter.
Clean up surrounding phpdoc. "
changeset,0000003381,[3381],johnjamesjacoby,Only overload global access caps if user does not have existing caps.
changeset,0000004879,[4879],johnjamesjacoby,Only remove filters if bbp_use_wp_editor() is true. See #2317. (2.3 branch)
changeset,0000004880,[4880],johnjamesjacoby,Only remove filters if bbp_use_wp_editor() is true. See #2317. (trunk)
changeset,0000004960,[4960],johnjamesjacoby,Only show allowed tags when not using the fancy editor or user does not have unfiltered_html cap. Also remove function_exists() check for wp_editor().
changeset,0000004681,[4681],johnjamesjacoby,Only show BuddyPress Group settings section when viewing bbPress settings for a BuddyPress root blog. Note that using bp_is_root_blog() includes support for BuddyPress's Multiblog mode.
changeset,0000006095,[6095],johnjamesjacoby,Only show reply-to drop-down when editing an existing reply.
changeset,0000002616,[2616],johnjamesjacoby,Only show topic admin links if user has caps
changeset,0000003476,[3476],johnjamesjacoby,Only use at_name filters when BuddyPress activity component is active.
changeset,0000003949,[3949],johnjamesjacoby,"Options:
* Pinking shears on bbp_get_default_options().
* Remove db_version duplicate description."
changeset,0000004193,[4193],johnjamesjacoby,"Options:
* Visually section off user slugs in bp_get_options()."
changeset,0000004208,[4208],johnjamesjacoby,"Options:
* Wrap some options loops in array_keys() to prevent making unnecessary $value variables."
changeset,0000006762,[6762],johnjamesjacoby,"Options: allow default option cache strategy to be filtered, without causing an intercept.
This change brings filter behavior back that was unintentionally removed in r6751."
changeset,0000006695,[6695],johnjamesjacoby,"Options: break `Features` out from `Settings` section.
This change makes it easier to discern which options are features, and which are settings for those features.
Also updates the inline descriptions for several array items."
changeset,0000006072,[6072],netweb,"Options: Fix `bbp_show_on_root()` copy pasta PHPDoc description
"
changeset,0000006694,[6694],johnjamesjacoby,"Options: set default database version to `0`.
This change avoids race conditions with the updater when no version exists in the database. This would cause the database version to not be bumped, resulting in rewrite rules being needlessly flushed on each visit to `wp-admin`.
(Also tweak some nearby array values to make them easier to read.)"
changeset,0000006078,[6078],netweb,"Options: Set the default value of `bbp_get_user_slug()` to `users`
This changeset updates the default single user slug from `user` to `users`. The `bbp_get_default_options()` function defines the default as `users` and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug `user` rather than `users`.
Props ocean90.
Fixes #2983
"
changeset,0000006761,[6761],johnjamesjacoby,"Options: Use new `$intercept` value in place of old `$strategy` value.
This change fixes an undefined variable debug notice introduced in r6751."
changeset,0000002496,[2496],johnjamesjacoby,"Output value, not array"
changeset,0000004871,[4871],johnjamesjacoby,"Overload the code tag in the fancy editor, and use backticks instead. Props mzaweb. (2.3 branch)"
changeset,0000004872,[4872],johnjamesjacoby,"Overload the code tag in the fancy editor, and use backticks instead. Props mzaweb. (trunk)"
changeset,0000003429,[3429],johnjamesjacoby,Override canonical redirect when editing topics and replies. Fixes #1594.
changeset,0000006451,[6451],johnjamesjacoby,Où mettre!
changeset,0000004322,[4322],johnjamesjacoby,"Pagination:
* Fix bug where topics started, favorites, and subscriptions pagination would link to the root of a users profile.\
* Fixes incorrect filters on topics and replies URL's."
changeset,0000006680,[6680],johnjamesjacoby,"Pagination: abstract and normalize common functionality.
This change introduces a few new helper functions, and audits the links generated where loops of forums, topics, and replies are made visible. It addresses a number of edge-cases in the pagination code, including:
* `view=all` state not carrying over
* Total-page boundary maybe using the wrong value to calculate the total number of available pages
* Inconsistent output of values across post types and shortcodes
* Inability to filter pagination arguments in certain use cases
* Reduces code repetition and increases general happiness
Trunk, for 2.6."
changeset,0000006300,[6300],johnjamesjacoby,"Pagination: prefer `intval()` for numeric values, and always format numbers used for display."
changeset,0000006228,[6228],johnjamesjacoby,"Pagination: Use `preg_replace` to find & remove `page=1` query arguments.
Fixes #2702. Props thebrandonallen, tharsheblows."
changeset,0000006398,[6398],johnjamesjacoby,Parenthesis clean-up.
changeset,0000006887,[6887],johnjamesjacoby,"Parser: Fix PHP 7.3 warning (""continue"" in ""switch"" is equal to ""break"")
Fixes #3242.
"
changeset,0000006418,[6418],netweb,"Parser: PHP 7.1 compatibility fixes to `parser.php`
Props xknown.
See #2973, #2987.
Merges [6212] to the 2.5 branch.
"
changeset,0000006212,[6212],johnjamesjacoby,"Parser: PHP 7.1 compatibility fixes to `parser.php`
Props xknown. Fixes #2973. See #2987."
changeset,0000006888,[6888],johnjamesjacoby,"Parser: revert error control operator change from r6887.
See also r6633 for original change.
"
changeset,0000004775,[4775],johnjamesjacoby,Pass $r instead of $args in ending filters. Ensures correct array of arguments is available to filters. These were skipped as part of #2056. Props alex-ye. Fixes #2218.
changeset,0000003548,[3548],johnjamesjacoby,Pass $reply_id correctly into bbp_get_reply_id() in bbp_notify_subscribers()
changeset,0000005391,[5391],johnjamesjacoby,Pass `$reply_id` into calls to `bbp_validate_reply_to()` and remove `reply_query` references in `BBP_Walker_Reply_Dropdown`. Fixes invalid `bbp_reply_id` value output in `form-reply.php`. See #2617.
changeset,0000005486,[5486],johnjamesjacoby,Pass `$topic_id` and `$forum_id` to relevant favorites and subscriptions filters. Hat tip DJPaul. Fixes #2651.
changeset,0000006552,[6552],johnjamesjacoby,Pass `$type` into favs & subs link arguments. Missed in r6551.
changeset,0000004915,[4915],johnjamesjacoby,Pass an empty array into bbp_parse_args() in bbp_search_query().
changeset,0000004789,[4789],johnjamesjacoby,Pass complete content into activity stream items. Create excerpt on output rather than input. Fixes #2237.
changeset,0000004515,[4515],johnjamesjacoby,Pass more variables into freshness link filters. Props jbobich. Fixes #1983.
changeset,0000003781,[3781],johnjamesjacoby,Pass param to bbp_get_template_locations() to allow locations to be filtered based on templates being queried. See #1766.
changeset,0000003011,[3011],johnjamesjacoby,"Pass the forums current visibility through to the functions responsible for changing them. This prevents querying post_meta and object cache for current visibility state, helpful for removing from private and hidden forum site meta."
changeset,0000003113,[3113],johnjamesjacoby,Pass topic-tag as array for compliance with shortcode attributes. Add topic-tag tax check to bbp_has_topics() before resetting post data.
changeset,0000006558,[6558],johnjamesjacoby,"Passwords: Upgrade the user-edit experience to use the new'ish password generator.
* Introduces new `form-user-passwords.php` template part to encapsulate the more-elaborate password mark-up
* Removes `user.js` from the default scripts, and enqueues `user-profiles` instead
* Requires tweaks to the default template pack styling to accommodate the password generator being theme-side
This change will also allow bbPress to more easily keep-up with changes to the password generator code that comes with WordPress going forward. Huzzah!"
changeset,0000004262,[4262],johnjamesjacoby,"Paths:
* Remove ""bbp-"" prefixes on root level directories.
* Rename 'themes' to 'templates' to discourage clever people from putting ""themes"" in there.
* Update paths and URLs in bbpress.php.
"
changeset,0000003431,[3431],johnjamesjacoby,Perform correct cap check in bbp_forum_enforce_private(). See #1576 and r3430.
changeset,0000004059,[4059],johnjamesjacoby,"Performance:
* Add 'numeric' to applicable meta-queries to avoid casting as char.
* Remove meta-queries, and use post_parent where possible.
* Introduce _bbp_has_replies_where() filter, attached to 'posts_where' which is responsible for adding the lead topic to the results. This avoids having to use a costly meta-query, potentially resulting in full table scans.
* Audit meta-queries, and tweak where needed.
* Fixes #1885.
* Props vibol for investigation."
changeset,0000004061,[4061],johnjamesjacoby,"Performance:
* Filter 'posts_request' to allow use of FORCE INDEX when replies are queried that should include the topic post also.
* See: #1885, r4059."
changeset,0000006544,[6544],johnjamesjacoby,"Performance: Last pass at 2.6 performance tuning.
* Keep a local cache of non-options that aren't in the database, to avoid multiple database misses for options we know aren't in the database after `wp_load_alloptions()` is called
* Stop getting all favorite IDs and subscription IDs when checking if a user has favorited or subscribed to something, because these queries are expensive joins that are difficult to cache & invalidate
* Consolidate forum/topic favorites & subscriptions logic back into central routers, to make it easier to handle taxonomy term subscriptions in the future, and remove nested filter calls that make the call-stack confusing
* Informally deprecate some forum & topic specific fav/sub functions
* Rename one of the engagements remove functions to better match existing naming pattern
* Typo fixes & general code quality improvements
* Bump slow tests threshold up to `500` for now, and we can bring back down later (my 12"" MacBook runs this pretty slowly, so I'd like to play with this more)
* Unit tests are all passing, and more quickly, maybe surprisingly
This should result in around 20 fewer database hits on non-persistent-cache sites, on average. When viewing single topics & replies, this will result in more than 25 fewer database hits."
changeset,0000005954,[5954],netweb,"Performance: Replace direct SQL queries with `WP_Query()` objects in the following functions:
* `bbp_update_forum_topic_count()`
* `bbp_update_forum_topic_count_hidden()`
* `bbp_update_forum_reply_count()`
* `bbp_get_public_child_last_id()`
* `bbp_get_public_child_count()`
* `bbp_get_public_child_ids()`
Props johnjamesjacoby.
See #1799.
"
changeset,0000006853,[6853],johnjamesjacoby,"Permalinks: merge root-slug usage into whichever is shown on root.
This change removes the double-archive juggle of having both forums and topics available as archives at the same time, which is traditionally not desirable.
"
changeset,0000005574,[5574],netweb,"Phorum importer: Include Subscribed Topics
Props netweb. See #2668
"
changeset,0000005048,[5048],johnjamesjacoby,PHP 5.4 compat and related sanity checks and clean-up. Props boonebgorges. Fixes #2731.
changeset,0000005089,[5089],johnjamesjacoby,PHP 5.4+ E_STRICT improvement to BuddyPress Groups display_forums() method. See #BP5108.
changeset,0000007115,[7115],xknown,"PHP 7.4 Compat: Don't use curly braces for array/string access
"
changeset,0000007114,[7114],xknown,"PHP 7.4 Compat: Remove deprecated functions.
"
changeset,0000007113,[7113],xknown,"PHP 7.4 Compat: remove deprecated functions.
"
changeset,0000007111,[7111],xknown,"PHP 7.4 Compat: Remove the create_function calls.
They are deprecated, and they seem to be removed in PHP 8.0.
"
changeset,0000007116,[7116],xknown,"PHP 7.4 Compat: Replace the deprecated create_function calls with anonymous functions.
"
changeset,0000007112,[7112],xknown,"PHP 7.4 compat: Replace the deprecated each call
"
changeset,0000007110,[7110],xknown,"PHP 7.4 Compat: Use square brackets and remove create_function calls.
"
changeset,0000003829,[3829],johnjamesjacoby,PHP5'ize bbp-core-classes.php.
changeset,0000005150,[5150],netweb,"phpBB Importer Improvements. Props netweb. Fixes #2467
* Added forum type callback for if forum is a Forum or Category
* Added reply title callback for clean reply titles
* Improved inline docs"
changeset,0000005796,[5796],netweb,"phpBB importer: Include Subscribed Forums, Subscribed Topics and Favourite Topics
Props netweb. See #2668
"
changeset,0000005798,[5798],netweb,"phpBB Importer: Missed forum total topic and total reply count schema change
See #2716"
changeset,0000005797,[5797],netweb,"phpBB importer: Updated AIM, YIM, and Jabber user meta key prefixes
Props netweb. See #2815
"
changeset,0000005528,[5528],netweb,"phpBB: Don't import phpBB search engine bot/crawler user accounts, e.g Google Bot, Bing Bot"
changeset,0000007049,[7049],netweb,"PHPCS: Pinking shears.
Props jrf.
See #3294.
For branches/2.6.
"
changeset,0000007048,[7048],netweb,"PHPCS: Pinking shears.
Props jrf.
See #3294.
For trunk.
"
changeset,0000007047,[7047],netweb,"PHPCS: Use Parenthesis when instantiating a new object.
Props jrf.
See #3294.
For branches/2.6.
"
changeset,0000007046,[7046],netweb,"PHPCS: Use Parenthesis when instantiating a new object.
Props jrf.
See #3294.
For trunk.
"
changeset,0000005515,[5515],netweb,PHPDdoc corrections for topic and reply pending status approve and unapprove functions. See #2645
changeset,0000005434,[5434],johnjamesjacoby,Phpdoc corrections to topic dropdown functions.
changeset,0000003216,[3216],johnjamesjacoby,phpDoc in bbp-core-options.php for changes made in r3215
changeset,0000004836,[4836],johnjamesjacoby,"phpdoc normalizing and speeling corrections. Props djpaul, netweb. Fixes #2286, #2288."
changeset,0000003800,[3800],johnjamesjacoby,Pinking shears on bbp-extend-buddypress.php. See #1669.
changeset,0000003833,[3833],johnjamesjacoby,Pinking shears on bbpress.php.
changeset,0000004969,[4969],johnjamesjacoby,Pluralize user settings ID to match existing naming conventions.
changeset,0000003847,[3847],nacin,"Port [3794], [3795] from trunk to branches/1.1.
"
changeset,0000005248,[5248],johnjamesjacoby,"Port Dashicons support from trunk to 2.5 branch, for 2.5.3. Includes updated color schemes."
changeset,0000005610,[5610],johnjamesjacoby,"Port PHPUnit testing setup from BuddyPress. More to clean up here later.
Also adds 1 test to check for `bbpress()` function availability.
See #2542.
"
changeset,0000003850,[3850],johnjamesjacoby,"Port r3737 and part r3750 into 2.0 branch.
* Cast parent as integer in bbp_get_forum_ancestors()
* Remove forum ID from hidden/private arrays when setting to public"
changeset,0000004265,[4265],johnjamesjacoby,"Post Ancestors:
* Cast return value of get_post_ancestors() as an array.
* Check if results of get_post_ancestors() are empty before attempting to iterate through them.
* Fixes issues with looping through orphaned forum content. A rare, but possible occurrence."
changeset,0000007192,[7192],johnjamesjacoby,"Post Statuses: Audit forum/topic/reply, new/edit handlers.
This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.
It also adds a capability check to the `bbp_topic_status` condition, so that it is not engaged when the UI was not exposed in the posted form.
Props dd32.
In branches/2.6 for 2.6.7. Fixes #3420."
changeset,0000007191,[7191],johnjamesjacoby,"Post Statuses: Audit forum/topic/reply, new/edit handlers.
This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.
It also adds a capability check to the `bbp_topic_status` condition, so that it is not engaged when the UI was not exposed in the posted form.
Props dd32.
In trunk for 2.7.0. See #3420."
changeset,0000004156,[4156],johnjamesjacoby,"Post Time:
* Introduce template tags for topic and reply post time.
* Includes param for auto-humanizing.
* Fixes theme-compat issues with core date/time template-tags by always supplying a trusted post ID. If one is not available, something has gone horribly wrong now."
changeset,0000004157,[4157],johnjamesjacoby,"Post Time:
* Use new post-time template-tags in appropriate bbp-theme-compat templates."
changeset,0000004158,[4158],johnjamesjacoby,"Post Time:
* Use new post-time template-tags in appropriate bbp-twentyten templates."
changeset,0000006850,[6850],johnjamesjacoby,"Post Types: replace literal post type strings with functional wrappers.
This fills in a few gaps where filtered post type names would not be used.
"
changeset,0000004509,[4509],johnjamesjacoby,"Posting:
* Fix bug causing forum/topic/reply content not to be retained when an error occurs.
* Fixes #2057."
changeset,0000004989,[4989],johnjamesjacoby,Practice late escaping in bbp_get_dropdown() to make it more clear that attributes are escaped.
changeset,0000005866,[5866],johnjamesjacoby,Prefer `current_filter()` over `current_action()` to maintain compatibility with WordPress versions older than 3.9. Fixes #2529.
changeset,0000006819,[6819],johnjamesjacoby,"Prefer `sanitize_html_class()` over `esc_attr()`.
This change uses the correct formatting function in places where potentially untrusted class strings are ran through `array_map()`.
"
changeset,0000002630,[2630],johnjamesjacoby,Prefix core meta with underscore inside recount functions
changeset,0000003123,[3123],johnjamesjacoby,Prefix topic and reply author classes with #content for theme compatibility.
changeset,0000003145,[3145],johnjamesjacoby,Prefix various files in bbp-includes folder with 'core' to identify them as required core files. Update bbpress.php to point to these new filenames.
changeset,0000004664,[4664],johnjamesjacoby,Preformatted blocks do not need top margin; it's trumped by the preceding paragraph tag.
changeset,0000005506,[5506],johnjamesjacoby,Preliminary function support for un/approving replies. Props netweb. See #2645.
changeset,0000005503,[5503],johnjamesjacoby,Preliminary function support for un/approving topics. Props netweb. See #2645.
changeset,0000004771,[4771],johnjamesjacoby,Preliminary support for WordPress 3.6 slash approach. (For easier on-going development.)
changeset,0000005507,[5507],johnjamesjacoby,Preliminary template support for un/approving replies. Props netweb. See #2645.
changeset,0000005504,[5504],johnjamesjacoby,Preliminary template support for un/approving topics. Props netweb. See #2645.
changeset,0000004706,[4706],johnjamesjacoby,Prepare $username in bbp_user_maybe_convert_pass(). Props Maty.
changeset,0000004709,[4709],johnjamesjacoby,Prepare $username in bbp_user_maybe_convert_pass(). Props Maty. (2.2 branch)
changeset,0000004735,[4735],johnjamesjacoby,Prepare query in bbp_check_for_duplicate(). See #2185.
changeset,0000004707,[4707],johnjamesjacoby,Prepare query variables in converter callbacks. Also add some brackets for readability. Props Maty.
changeset,0000004710,[4710],johnjamesjacoby,Prepare query variables in converter callbacks. Also add some brackets for readability. Props Maty. (2.2 branch)
changeset,0000002680,[2680],johnjamesjacoby,Prepare walker class. Improved paginated reply url links. Rename bbp_reply_topic function to bbp_reply_topic_title.
changeset,0000003127,[3127],johnjamesjacoby,"Prevent ""create topic"" form from showing if current user cannot create topics or there are no public forums to create topics in. Fixes #1443."
changeset,0000003038,[3038],johnjamesjacoby,Prevent comment form from appearing on intercepted theme compat template pages.
changeset,0000004246,[4246],johnjamesjacoby,"Prevent double escaping of $post_content when editing topics and replies, and add phpdoc block to remind everyone not to put it back again."
changeset,0000002959,[2959],johnjamesjacoby,Prevent double separators in certain conditions where other plugins may also be attempting to add them.
changeset,0000005393,[5393],johnjamesjacoby,Prevent empty array value in `bbp_get_reply_ancestors()`. See #2617.
changeset,0000002915,[2915],johnjamesjacoby,Prevent fatal error on WordPress 3.0 installs from $wp_query not being setup before this loop is created.
changeset,0000003125,[3125],johnjamesjacoby,Prevent forum and topic ID's from being poisoned by functions that attempt to make calculations out of turn. Also prevent incorrect assignment of parent topic and forum ID's when posting from admin area. Fixes #1433.
changeset,0000003259,[3259],johnjamesjacoby,Prevent forum root in breadcrumb if viewing a page in place of the forum archive.
changeset,0000003602,[3602],johnjamesjacoby,Prevent guest users from editing topics and replies if anonymous posting is active. See #1678. (2.0)
changeset,0000003600,[3600],johnjamesjacoby,Prevent guest users from editing topics and replies if anonymous posting is active. See #1678. (2.1)
changeset,0000003070,[3070],johnjamesjacoby,Prevent hr styling from applying to admin area
changeset,0000003076,[3076],johnjamesjacoby,Prevent login from hi-jacking wp-login.php
changeset,0000005042,[5042],johnjamesjacoby,Prevent nested shortcodes if used inside bbPress post_content. Reverts r4976. See #2343.
changeset,0000005608,[5608],johnjamesjacoby,Prevent notices and warnings when template stack is empty. Fixes #2749.
changeset,0000003286,[3286],johnjamesjacoby,Prevent poisoning of forum/topic/reply data when marking posts as trash/spam. Fixes issue where anonymous user data would get purged when post status was changed from an admin area post-row.
changeset,0000003580,[3580],johnjamesjacoby,Prevent possible debug notice in bbp_get_breadcrumb()
changeset,0000002820,[2820],johnjamesjacoby,Prevent possible variable not set notice (branch)
changeset,0000002821,[2821],johnjamesjacoby,Prevent possible variable not set notice (trunk)
changeset,0000003665,[3665],johnjamesjacoby,Prevent shortcodes from stomping globals too early. Fixes #1717.
changeset,0000007182,[7182],johnjamesjacoby,"Profiles: fix incorrect target for ""locale"" label.
This commit fixes a copy & paste error, where the ""locale"" label was targeting the ""url"" input instead of the language select.
In branches/2.6 for 2.6.7. Fixes #3387."
changeset,0000007181,[7181],johnjamesjacoby,"Profiles: fix incorrect target for ""locale"" label.
This commit fixes a copy & paste error, where the ""locale"" label was targeting the ""url"" input instead of the language select.
In trunk for 2.7.0. See #3387."
changeset,0000003307,[3307],johnjamesjacoby,Proper singular/plural bases for capability_type in forum/topic/reply CPT's.
changeset,0000002774,[2774],johnjamesjacoby,Proper version compare check.
changeset,0000002739,[2739],johnjamesjacoby,Properly prepare bb_get_forum. Fixes #1414. Props nbachiyski.
changeset,0000002536,[2536],chrishajer,"Properly update version in functions.bb-meta.php
"
changeset,0000005180,[5180],netweb,Protect topic and reply author link calls from non-existant users. Props jondavidjohn. Fixes #2381
changeset,0000005575,[5575],netweb,"PunBB importer: Include Subscribed Forums and Subscribed Topics
Props netweb. See #2668
"
changeset,0000005529,[5529],netweb,punBB: Don't import punBB's guest user
changeset,0000004652,[4652],johnjamesjacoby,Put a more positive spin on our usage of magic methods in the bbPress class.
changeset,0000005275,[5275],johnjamesjacoby,"Put back root files from previous reorg revert. See #2542.
"
changeset,0000003333,[3333],johnjamesjacoby,Put main actions into a loop. Fix incorrect filter on bbp_edit ID. Rename main register_textdomain function back to load_textdomain to match existing conventions.
changeset,0000004031,[4031],johnjamesjacoby,"Queries:
* Allow bbp_is_query_name() to accept empty values, similar to get_query_var().
* See #1865."
changeset,0000004183,[4183],johnjamesjacoby,"Queries:
* Remove query name settings from BBP_Shortcodes.
* No longer used."
changeset,0000004194,[4194],johnjamesjacoby,"Queries:
* Revert r4183 as it's still needed for shortcodes and _is_ functions.
* Fix incorrect ob_start() method in display_breadcrumb()."
changeset,0000006607,[6607],johnjamesjacoby,"Queries: `nopaging` audit.
* In r6506 the `nopaging` query argument was added to various queries to avoid paginating results when it wasn't necessary. This resulted in a few queries (widgets mainly) not obeying their specific settings.
* In #3123, other inconsistencies in our query arguments were uncovered, triggering the need to audit our query usages and equalize them once again.
This change brings all queries back to par with one another, specifically in regards to `posts_per_page => -1` style queries, and queries where filters can be suppressed and meta/term caches should not be primed.
It also groups together the `get_user_object_ids` functions. These are now unused in bbPress proper, though were previously useful before the engagements API was in place. These queries are considered too inefficient to rely upon in large-scale applications, but are included to provide filterable wrappers should someone need them, or should we need to bring them back later.
Props thebrandonallen. Fixes #3123.
"
changeset,0000005858,[5858],johnjamesjacoby,"Queries: Clean up post status concatenation in 2 queries.
This changeset moves array of ""hidden"" type post-statuses into their own variable to better match existing usages.
Fixes #2826."
changeset,0000006410,[6410],johnjamesjacoby,"Queries: Deprecate `bbp_query_post_parent__in()` in the 2.5 branch.
4.7 is the minimum WordPress version, so we can support `post_parent__not_in` directly.
See #2832.
"
changeset,0000006503,[6503],johnjamesjacoby,"Queries: Remove `author_name` query variable setting when viewing profiles.
This is a relic from the days when profiles included blog posts (2010 era.)
This should be safe to remove, based on the following assessments:
* Blog posts are no longer included in profiles
* Setting `author_name` or `author` query-vars will cause `is_author()` to be set to `true`
* `is_author()` should not return true in the context of bbPress profile pages
* The `author_name` query-var is not used again later in bbPress - the `displayed_user` variable is instead
See https://github.com/woocommerce/woocommerce/issues/15508 for additional context."
changeset,0000005820,[5820],johnjamesjacoby,"Queries: Remove `post_parent__in` query-parameter filter.
This commit removes the `bbp_query_post_parent__in()` filter that was introduced in r2996, and uses WordPress core's built in query parameters introduced in #WP11056.
Fixes #2832."
changeset,0000006289,[6289],johnjamesjacoby,"Queries: Return empty array if no parent ID or no post-type are passed.
See #3059.
"
changeset,0000006434,[6434],johnjamesjacoby,"Queries: Update `orderby` clauses of last-id queries to ensure more accurate results, specifically for imported forums and posts where IDs and `post_date` columns might be inverted.
Also update a few tests to be less cranky with exact array results.
Props thebrandonallen. Fixes #3108."
changeset,0000006219,[6219],johnjamesjacoby,"Queries: Use `no_found_rows` where relevant.
This prevents `SQL_CALC_FOUND_ROWS` usages in places where it is not used.
Fixes #2972."
changeset,0000006612,[6612],johnjamesjacoby,"Queries: Use new `object_type` over old `post_type`.
When `bbp_get_user_object_ids()` was introduced, some helpers did not get updated to use the new argument key. This change fixes that, and fixes failing tests in the process.
Note that these tests are testing new & unused helper functions for 2.6, so it's unlikely any noticable problems occurred from these being broken.
"
changeset,0000004899,[4899],johnjamesjacoby,"Query clean-up:
* Move implode() calls out of queries and replace with variables.
* Audit IN queries and implode/explode for wp_parse_id_list() usages.
* See #2331."
changeset,0000006643,[6643],johnjamesjacoby,"Query: use `NOT IN` strategy in `bbp_get_all_child_ids()`
This ensures that only specific post-statuses are explicitly excluded from ""all child IDs"" type queries, where previously post-statuses needed to be specifically defined.
See #3128."
changeset,0000006685,[6685],johnjamesjacoby,"Query: use `NOT IN` strategy in `bbp_get_all_child_ids()`
This ensures that only specific post-statuses are explicitly excluded from ""all child IDs"" type queries, where previously post-statuses needed to be specifically defined.
See #3128. Fixes #3140. 2.5 branch, for 2.5.14."
changeset,0000002898,[2898],johnjamesjacoby,Quick post_id sanity check in anonymous_metabox.
changeset,0000006510,[6510],johnjamesjacoby,"RC 1, not 3. See r6509.
"
changeset,0000005359,[5359],johnjamesjacoby,Re-alphabetize grunt packages and update keywords in `package.json`.
changeset,0000005425,[5425],netweb,Re-factor importing closed topics to import the closed status and update the closed topic post and post meta status using `bbp_close_topic()`. See #2577
changeset,0000006689,[6689],johnjamesjacoby,"Read-me & Humans updates:
* Add Sergey & Pippin
* Add dates to changelog
* Consolidate 2.0.0 betas into one release
* Update plugin descriptions"
changeset,0000007202,[7202],johnjamesjacoby,"Readme: Bump ""tested up to"" to 5.8.
"
changeset,0000007201,[7201],johnjamesjacoby,"Readme: Bump ""tested up to"" to 5.8.
"
changeset,0000007093,[7093],johnjamesjacoby,"Readme: Bump stable tag and group ""Requires"" headers together.
In trunk, for 2.7.0.
"
changeset,0000007219,[7219],johnjamesjacoby,"Readme: Bump stable tag, and add missing header meta.
(Also updates build tool dependencies.)
"
changeset,0000004500,[4500],johnjamesjacoby,Rearrange $wpdb global usage in bbp_check_for_duplicate().
changeset,0000002571,[2571],johnjamesjacoby,Rearrange _id logic to account for sub-forums and hierarchical replies.
changeset,0000003752,[3752],johnjamesjacoby,Rearrange filtering of $forum_parent_id in bbp_new_forum_handler(). See #1669.
changeset,0000002633,[2633],johnjamesjacoby,"Rearrange recount items to be top-down forums, topics, replies"
changeset,0000003212,[3212],johnjamesjacoby,Rearrange settings in bbp_add_options() into more accurate sections.
changeset,0000003784,[3784],johnjamesjacoby,Rearrange sub-actions for improved readability in bbp-core-actions.php.
changeset,0000002841,[2841],johnjamesjacoby,Rearrange the reply and new topic elements in bbp-twentyten. Adjust the fieldset top padding and fieldset message styling.
changeset,0000004721,[4721],johnjamesjacoby,Rearrange the way map_group_forum_meta_caps() is used. See #2089.
changeset,0000002635,[2635],johnjamesjacoby,Rearrange time and date
changeset,0000003530,[3530],johnjamesjacoby,Rebranching 1.1
changeset,0000002718,[2718],mdawaffe,recalculate a user's meta in case we're pulling from a value cache on another site
changeset,0000004533,[4533],johnjamesjacoby,"Redirect:
* Rethink the way bbp_redirect_to_field() works.
* Removes apache specific global checks.
* Fixes incorrect usage of wp_get_referer().
* Props MZAWeb.
* fixes #1835."
changeset,0000003919,[3919],johnjamesjacoby,"Redirects:
* Always use wp_safe_redirect() in bbPress.
* Nothing should/will redirect off-site."
changeset,0000003913,[3913],johnjamesjacoby,"Redirects:
* Remove redirect_to fields from edit form field functions, and trust handler logic to do its job.
* See #1829."
changeset,0000003912,[3912],johnjamesjacoby,"Redirects:
* Tweak topic and reply form fields to include redirect_to field.
* Fix redirect logic in single items after editing.
* Remove forum_id from new reply hidden fields, and calculate on handler based off of topic ID (to prevent mismatches.)
* Fixes #1829.
"
changeset,0000006961,[6961],johnjamesjacoby,Reduce number of tags in readme.txt.
changeset,0000006960,[6960],johnjamesjacoby,Reduce number of tags in readme.txt.
changeset,0000003061,[3061],johnjamesjacoby,Reduce the width of topic/reply textareas for improved theme compatibility.
changeset,0000005395,[5395],johnjamesjacoby,"Reduce unnecessary complexity and flexibility in `bbp_get_reply_to_dropdown()`. Since this is a purpose built form field, explicit filtering of arguments is not necessary. See #2617."
changeset,0000002611,[2611],johnjamesjacoby,Reduce width of author area and center contents
changeset,0000003685,[3685],johnjamesjacoby,Refactor bbp_admin_settings_help() to use add_help_tab() and set_help_sidebar(). See #1699.
changeset,0000003686,[3686],johnjamesjacoby,"Refactor forum/topic/reply contextual help, shamelessly sampled from the !WordPress 'post' content type. See #1699."
changeset,0000005258,[5258],johnjamesjacoby,"Refactor subscription notifications functions to send 1 email with all subscribers BCC'd rather than 1 email per subscriber. This speeds up posting significantly in forums or topics where there are any number of subscribers, particularly on configurations with slow email servers or when using external email services.
(Subscription notifications could be improved further in a future iteration by moving the actual sending into a `wp_cron` process, but this improvement is easy and significant enough where it will be sufficient for the widest audience.)
Hat tip netweb, rossagrant. Fixes #2162."
changeset,0000005260,[5260],johnjamesjacoby,"Refactor subscription notifications functions to send 1 email with all subscribers BCC'd rather than 1 email per subscriber. This speeds up posting significantly in forums or topics where there are any number of subscribers, particularly on configurations with slow email servers or when using external email services.
(Subscription notifications could be improved further in a future iteration by moving the actual sending into a `wp_cron` process, but this improvement is easy and significant enough where it will be sufficient for the widest audience.)
Hat tip netweb, rossagrant. Fixes #2162. (trunk)"
changeset,0000006121,[6121],johnjamesjacoby,"Reference correct hook name in docs. Props netweb. See r5945.
"
changeset,0000004687,[4687],jmdodd,"Refine bbp_get_dropdown().
* Don't assume post_parent = 0 as a default.
* Fixes #2153.
"
changeset,0000002507,[2507],johnjamesjacoby,Register our own theme directory in WP
changeset,0000004673,[4673],johnjamesjacoby,Rejig the post_status logic in bbp_has_topics() and bbp_has_replies() to use the 'perm' query variable when appropriate. This allows unfamiliar topic and reply statuses to work as intended. Also allows post authors to view their own private content. Fixes #2088.
changeset,0000002945,[2945],johnjamesjacoby,Rejig the updater
changeset,0000002528,[2528],mdawaffe,Relearn the ropes: bump version
changeset,0000005240,[5240],netweb,Relocate `login_form` action hook outside `bbp-submit-wrapper` form submit wrapper in `form-user-login.php` and `form-user-lost-pass.php` templates. Props icu0755. Fixes #2500 (2.5 branch)
changeset,0000005241,[5241],netweb,Relocate `login_form` action hook outside `bbp-submit-wrapper` form submit wrapper in `form-user-login.php` and `form-user-lost-pass.php` templates. Props icu0755. Fixes #2500 (trunk)
changeset,0000003060,[3060],johnjamesjacoby,Remember to exit after loading a found template file in bbp_load_template() when using theme compatability.
changeset,0000004738,[4738],johnjamesjacoby,"Remove ""bbp-mention-link"" class from bbp_mention_filter() links. Fixes bug where copy/pasting previous post content into TinyMCE causes duplicate topic/reply check to not match correctly. See #2185."
changeset,0000003675,[3675],johnjamesjacoby,Remove $terms copy-pasta from bbp_edit_forum_handler()
changeset,0000004750,[4750],johnjamesjacoby,Remove 'bbp_encode_bad' filter on topic/reply content. Fixes issues with double encoding.
changeset,0000004837,[4837],johnjamesjacoby,Remove 'bbp_filter_kses' filter instead of 'wp_filter_kses' - Fixes unfiltered HTML issues introduced with bbp_filter_kses(). Props alex-ye. Fixes #2290.
changeset,0000003821,[3821],johnjamesjacoby,"Remove 'bbpress/' from template part calls in bbp-twentyten.
* Sub folders are handled automatically by bbp_get_template_part()
* See #1796"
changeset,0000005116,[5116],johnjamesjacoby,Remove 'none_found' from metaboxes. Will be deprecating as part of #2445.
changeset,0000005115,[5115],johnjamesjacoby,Remove 'none_found' strings from forms. Will be deprecating as part of #2445.
changeset,0000003722,[3722],johnjamesjacoby,"Remove 'Remove' list-item from loop-topics.php template, as it causes issues with tableless layout."
changeset,0000004591,[4591],johnjamesjacoby,Remove 'switch_blog' hook for bbp_set_current_user_default_role(). Causing issues with multisite creation. Fixes #2103.
changeset,0000002619,[2619],johnjamesjacoby,Remove @todo
changeset,0000005481,[5481],netweb,"Remove @ToDo 'Implement Feeds' PHPDoc reference in `bbp_register_view()`, feeds were added for views in r3171 and r3172. Fixes #2631"
changeset,0000003356,[3356],johnjamesjacoby,Remove _core_ prefix from function names introduced in r3355.
changeset,0000005321,[5321],johnjamesjacoby,Remove `akismet_microtime()` usage as it's been removed from Akismet's development branch.
changeset,0000005320,[5320],johnjamesjacoby,Remove `akismet_test_mode()` usage as it's been removed from Akismet's development branch.
changeset,0000005671,[5671],netweb,"Remove `BBP_UnitTestCase::knownBBPBug` PHPUnit tests support for bbPress unclosed Trac tickets.
See #WP30284 and #BuddyPress6223"
changeset,0000005292,[5292],johnjamesjacoby,Remove `colors-fresh` dependency for admin color schemes. !WordPress 3.9's CSS cleanup initiatives have rendered this code unnecessary. Hat tip helen.
changeset,0000005213,[5213],johnjamesjacoby,Remove `get_post_type_object()` phpdoc reference in `BBP_Admin::map_settings_meta_caps()`.
changeset,0000005415,[5415],netweb,"Remove `grunt-phpunit` support in NPM `package.json`
* We have never used PHPUnit as part of a Grunt task and use the native Pear PHPUnit package.
"
changeset,0000005256,[5256],johnjamesjacoby,"Remove `languages` folder, and move `bbpress.pot` back into the root plugin directory.
The existence of the `languages` folder only currently sets up a confusing experience for a growing subset of users that also cannot easily get support in their language. By deleting the directory, it's less likely users will put their translations in a folder that does not already exist, which prevents them being deleted on bbPress plugin updates.
Because we have no plans of packaging translations directly with bbPress itself, and because wp.org will manage the downloading and installation of translations for us (and all plugins) based on the language of the WordPress installation, deleting the `languages` folder will provide a better experience for our non-English users going forward."
changeset,0000005622,[5622],netweb,"Remove `onevar` from `.jshintrc`, as of JSHint v2.5 `onevar` is no longer an option.
See #2746"
changeset,0000005257,[5257],netweb,Remove `pre_get_posts` action `bbp_pre_get_posts_normalize_forum_visibility` from forum visibility repair tool to prevent hidden and private post status injected into WP_Query. Props thebrandonallen. Fixes #2512
changeset,0000005284,[5284],netweb,Remove `tests/phpunit/data/.trac-ticket-cache*` from .gitignore (only required in WP develop repo). See #2542
changeset,0000005195,[5195],johnjamesjacoby,Remove `topic.min.js` from default theme compat.
changeset,0000005600,[5600],netweb,"Remove `trailing` option from `.jshintrc`, as of JSHint v2.5 `trailing` is no longer an option.
See https://github.com/jshint/jshint/pull/1554
Fixes #2746"
changeset,0000004494,[4494],johnjamesjacoby,Remove accidental variable variable in widget output.
changeset,0000003730,[3730],johnjamesjacoby,Remove accidental whitespace from r3729. Antiprops johnjamesjacoby.
changeset,0000002777,[2777],johnjamesjacoby,Remove admin notice. Fixes #1440.
changeset,0000007018,[7018],johnjamesjacoby,"Remove alpha designation from 2.6 branch, for 2.6.3."
changeset,0000004696,[4696],johnjamesjacoby,"Remove array_reverse() usage in breadcrumb output. Props alex-ye. Fixes #2124, #2166."
changeset,0000003174,[3174],johnjamesjacoby,"Remove bbp-core-update.php from project, as it is no longer used."
changeset,0000002598,[2598],johnjamesjacoby,Remove bbp-custom code.
changeset,0000003139,[3139],johnjamesjacoby,Remove bbp-languages folder since language packs will get wiped out when automated plugin updates come through. Move bbpress.pot file into the root project folder to help it get slurped when it hits WP extend.
changeset,0000003341,[3341],johnjamesjacoby,Remove BBP_VERSION global constant. Update readme.txt. Bump plugin branch to RC 1.
changeset,0000004205,[4205],johnjamesjacoby,"Remove branches/plugin.
* Copied to /trunk in r4201
"
changeset,0000003667,[3667],johnjamesjacoby,Remove BuddyPress group forum styling from bbp-twentyten theme. We'll be relying on default styling for 2.1. See #1669.
changeset,0000005056,[5056],johnjamesjacoby,Remove byref usage in BuddyPress Groups admin box method.
changeset,0000004667,[4667],johnjamesjacoby,"Remove call to bbp_topic_admin_links() from form-reply.php. These links are a bit out of context here now, and are duplicated from the lead topic post."
changeset,0000004985,[4985],johnjamesjacoby,Remove capability pre-check from admin links functions. Remove duplicate trash-removal logic that's done inside the respective trash-link generating functions. Fixes inconsistent nested capability checks within admin link functions. See #2348.
changeset,0000003550,[3550],johnjamesjacoby,Remove clever code from bbp-core-compatibility.php. Add query var for editing forums from within the theme to bbp_pre_get_posts().
changeset,0000003551,[3551],johnjamesjacoby,Remove clever code from bbp-forum-template.php. Add first round of forum form template functions.
changeset,0000003558,[3558],johnjamesjacoby,Remove clever code from bbp-topic-template.php. Tweak text in bbp_get_single_topic_description()
changeset,0000003549,[3549],johnjamesjacoby,Remove clever code from bbp-user-template.php. Introduce helper functions for accessing forum creation form. Pass user_nicename in profile URL functions. Fixes #1659 (plugin)
changeset,0000003350,[3350],johnjamesjacoby,Remove completed @todo's and fix incorrect filters on core ID's
changeset,0000003772,[3772],johnjamesjacoby,Remove copy-pasta phpdoc in bbPress class.
changeset,0000003391,[3391],johnjamesjacoby,Remove create_function() usage from widgets. Introduce bbp_widget_init piggy-back action to allow dependent plugins to add widgets only if bbPress is active. Fixes #1579.
changeset,0000002526,[2526],mdawaffe,remove debug code that slipped into [2525]
changeset,0000002766,[2766],johnjamesjacoby,Remove debug code.
changeset,0000004648,[4648],johnjamesjacoby,Remove debug cruft from bbp_get_reply_post_date().
changeset,0000003498,[3498],johnjamesjacoby,Remove debug cruft from r3497.
changeset,0000006429,[6429],johnjamesjacoby,Remove debug cruft.
changeset,0000003614,[3614],johnjamesjacoby,Remove deprecated (and excessive) file-system checks for single-action templates from _edit_ theme-compat functions. These are pre 2.0 and future updates will not support them going forward.
changeset,0000003327,[3327],johnjamesjacoby,Remove deprecated reference to $count_hidden in bbp_toggle_reply_handler(). See r3325.
changeset,0000005265,[5265],netweb,Remove deprecated screen_icon() calls. Props netweb. Fixes #2538
changeset,0000004746,[4746],johnjamesjacoby,"Remove deprecated subforum prevention code. Though it's not directly supported, preventing it isn't necessary either. See #2191."
changeset,0000002689,[2689],johnjamesjacoby,Remove deprecated template file.
changeset,0000002781,[2781],johnjamesjacoby,Remove diff that was accidentally added to project.
changeset,0000003330,[3330],johnjamesjacoby,Remove double breadcrumb from create topic page template.
changeset,0000004956,[4956],johnjamesjacoby,"Remove double escaping for bbp_get_displayed_user_field() usages, and update phpdoc for spam/ham user functions."
changeset,0000004954,[4954],johnjamesjacoby,Remove double escaping of user display name for theme compat reset post.
changeset,0000003277,[3277],johnjamesjacoby,"Remove duplicate ""replies"" in forum description. Props Fartlek."
changeset,0000002649,[2649],johnjamesjacoby,Remove duplicate action reference
changeset,0000004982,[4982],johnjamesjacoby,"Remove duplicate escaping from user-details.php, now that fields are automatically sanitized for display. See #1999."
changeset,0000005082,[5082],johnjamesjacoby,Remove duplicate id attributes from some admin settings fields. Props alex-ye. Fixes #2388.
changeset,0000005276,[5276],johnjamesjacoby,"Remove duplicate testcases directory from previous merge. See #2542.
"
changeset,0000003107,[3107],johnjamesjacoby,Remove duplicate user template notice
changeset,0000003792,[3792],johnjamesjacoby,"Remove duplicate wp_editor code from bbp_get_default_options()
* Props dimadin
* See r3753
* Fixes #1771"
changeset,0000003094,[3094],johnjamesjacoby,Remove empty bbp-default theme
changeset,0000003771,[3771],johnjamesjacoby,Remove empty lines in phpdoc in bbPress class
changeset,0000003219,[3219],johnjamesjacoby,"Remove empty spaces at the end of topic and reply count statistic strings, for i18n. Also properly explode them instead of hard coding pipes."
changeset,0000004977,[4977],johnjamesjacoby,"Remove esc_attr() from bbp_get_displayed_user_field(), and practice late escaping where appropriate instead. See #4959."
changeset,0000005277,[5277],netweb,"Remove existing minified CSS, Grunt build process now takes care of this. See #2542."
changeset,0000002981,[2981],johnjamesjacoby,Remove existing references to forum_voice_count functions. Fixes #1494.
changeset,0000005449,[5449],netweb,Remove extra URL forward slash in 'reset tools' help codex link. Props extendwings. Fixes #2666
changeset,0000005135,[5135],johnjamesjacoby,Remove extraneous closing tag in custom walker start_el() method. Props netweb. Fixes #2455.
changeset,0000005373,[5373],johnjamesjacoby,"Remove extraneous validation in `bbp_get_form_reply_to()`. Fixes bug causing `_bbp_reply_to` field to be incorrectly set as the current `$reply_id` when editing a reply with no reply_to, which can lead to hierarchy issues. See #2586, #2588. (2.5 branch)"
changeset,0000005372,[5372],johnjamesjacoby,"Remove extraneous validation in `bbp_get_form_reply_to()`. Fixes bug causing `_bbp_reply_to` field to be incorrectly set as the current `$reply_id` when editing a reply with no reply_to, which can lead to hierarchy issues. See #2586, #2588. (trunk)"
changeset,0000003769,[3769],johnjamesjacoby,"Remove filters and tags from subscription emails.
* Remove all filters and strip tags
* Move needless processing from within the foreach loop
* Prevents HTML entities from being added
* Fixes #1700"
changeset,0000003150,[3150],johnjamesjacoby,"Remove flush_rewrite_rules actions in bbp-core-hooks.php, as they are being called too early in the stack causing the rules to be flushed before the custom rules are added."
changeset,0000003331,[3331],johnjamesjacoby,Remove garbage 'native' text at top of content- and single- files. Props schrepel.
changeset,0000003691,[3691],johnjamesjacoby,Remove Genesis compatability. Fixes #1729.
changeset,0000003500,[3500],johnjamesjacoby,Remove Genesis navigation after the post loop has finished. See #1622. Props jaredatch.
changeset,0000003002,[3002],johnjamesjacoby,Remove get_pages() usage from bbp_get_dropdown() and stick to using get_posts() regardless of post_type.
changeset,0000005253,[5253],netweb,Remove hard coded post type references in repair tools. Props thebrandonallen. Fixes #2510
changeset,0000003745,[3745],johnjamesjacoby,Remove hard coded template part directories from shortcodes and theme compatibility. See r3739.
changeset,0000005030,[5030],johnjamesjacoby,"Remove hard-coded negative capabilities from bbp_get_caps_for_role() for all roles expect 'Blocked'. Prevents over-aggressively and explicitly disallowing role based capabilities, and allows role manager plugins to more effectively manipulate bbPress user capabilities.
Fixes bug where negative user capabilities could not be overridden if negative caps were saved to all_caps array. See #1939."
changeset,0000005125,[5125],johnjamesjacoby,Remove hardcoded references to 'topics' and 'replies' in user profile URL's; use archive slug functions instead. Props imath. Fixes #2448. (2.4.1)
changeset,0000005126,[5126],johnjamesjacoby,Remove hardcoded references to 'topics' and 'replies' in user profile URL's; use archive slug functions instead. Props imath. Fixes #2448. (2.5)
changeset,0000004908,[4908],johnjamesjacoby,Remove help documentation for unsupported core WordPress post features. See #2332 (2.3 branch)
changeset,0000004909,[4909],johnjamesjacoby,Remove help documentation for unsupported core WordPress post features. See #2332 (trunk)
changeset,0000002665,[2665],johnjamesjacoby,Remove help message from author favorites.
changeset,0000003430,[3430],johnjamesjacoby,Remove hierarchical check against private/hidden forum types. Fixes issue where a user needed to be able to view private forums in order to view hidden forums. See #1576.
changeset,0000002975,[2975],johnjamesjacoby,Remove incomplete bbp_insert_topic() function
changeset,0000002775,[2775],johnjamesjacoby,Remove incorrect 'else' check.
changeset,0000005088,[5088],johnjamesjacoby,Remove incorrect @uses bbp_is_user_keymaster() phpdoc reference.
changeset,0000005824,[5824],johnjamesjacoby,Remove incorrect `@global` tag in `BBP_Akismet::submit_post()`.
changeset,0000003253,[3253],johnjamesjacoby,Remove incorrect is_home from wp_query when viewing a single topic view.
changeset,0000003900,[3900],johnjamesjacoby,Remove indentation from bbp_get_user_favorites_topic_ids().
changeset,0000004561,[4561],johnjamesjacoby,Remove inline doc references to extract().
changeset,0000004747,[4747],johnjamesjacoby,Remove invalid @uses for subforum count. See #2191.
changeset,0000003352,[3352],johnjamesjacoby,Remove is_super_admin checks from edit topic/reply link functions. Fixes #1566.
changeset,0000004875,[4875],johnjamesjacoby,Remove kses filters with the correct priorities if user has 'unfiltered_html' capability. Props alx-ye. Fixes #2315 (2.3 branch)
changeset,0000004876,[4876],johnjamesjacoby,Remove kses filters with the correct priorities if user has 'unfiltered_html' capability. Props alx-ye. Fixes #2315 (trunk)
changeset,0000003303,[3303],johnjamesjacoby,Remove legacy behavior for profile topics queries. Add filters to _is_ profile functions to allow profile queries to be customized.
changeset,0000003105,[3105],johnjamesjacoby,Remove links to topic tags from topic form.
changeset,0000002798,[2798],johnjamesjacoby,Remove logged_in and anonymous posting checks to prevent conflicts when anonymous posting is toggled after posts have been entered by anonymous users. Fixes #1367
changeset,0000004805,[4805],johnjamesjacoby,"Remove meta query check from _bbp_has_replies_where(), add some brackets to improve readability. Addresses regression introduced in r4795. See #2221"
changeset,0000002779,[2779],johnjamesjacoby,Remove moderator caps on deactivation. Fixes #1445. Props cnorris23
changeset,0000006430,[6430],johnjamesjacoby,Remove more debug cruft.
changeset,0000002852,[2852],johnjamesjacoby,Remove needless (int) cast in bbp_get_forum_subforum_count
changeset,0000003067,[3067],johnjamesjacoby,Remove nested ternary operator in bbp_get_dropdown()
changeset,0000003115,[3115],johnjamesjacoby,Remove new topic form from forums index page template. Also add some actions to the front page templates to allow the form to be hooked back in. Fixes #1509.
changeset,0000003838,[3838],johnjamesjacoby,Remove number_format_i18n phpdoc references. See #1810.
changeset,0000003263,[3263],johnjamesjacoby,Remove old phpdoc comment
changeset,0000005049,[5049],johnjamesjacoby,Remove out of date wp_referer_field() phpdoc references.
changeset,0000004830,[4830],johnjamesjacoby,Remove outdated bbp_get_user_id() phpdoc references. See #2284.
changeset,0000004804,[4804],johnjamesjacoby,Remove outdated bbp_is_query_name() phpdoc references.
changeset,0000002732,[2732],johnjamesjacoby,Remove paged=1 from pagination links when default permalinks are set
changeset,0000003638,[3638],johnjamesjacoby,Remove query restriction from content-single-topic.php.
changeset,0000002495,[2495],PeteMall,"Remove quick edit, add freshness column and utilize excerpt view on topics page."
changeset,0000003200,[3200],johnjamesjacoby,Remove read_forum meta cap check from bbp_user_can_view_forum(). Fixes bug where users with no role in a multisite installation could not read public forum content.
changeset,0000003118,[3118],johnjamesjacoby,Remove reference to $post global in bbp_replace_the_content()
changeset,0000003081,[3081],johnjamesjacoby,Remove reference to bbp_login_url() function
changeset,0000002795,[2795],johnjamesjacoby,Remove references to 'the loop' in phpDoc in functions where the loop isn't required
changeset,0000003151,[3151],johnjamesjacoby,Remove references to deprecated bbp_anonymous_ip meta key as IP address is now saved for all users topics/replies. Fixes #1505. Props Coolkevman.
changeset,0000004247,[4247],johnjamesjacoby,"Remove references to post_category in theme compat.
* Fixes #1952."
changeset,0000005490,[5490],johnjamesjacoby,"Remove remaining 'Reply To' references in reply `post_title`'s.
(Now that posts can have empty titles, this is no longer necessary. It also yielded undesired single reply slugs, though they are only exposed to moderators and keymasters.)
Hat tip netweb."
changeset,0000002884,[2884],johnjamesjacoby,Remove reply and voice count from single-bbp_topic.php. It will be moved into the topic description.
changeset,0000002709,[2709],johnjamesjacoby,Remove rogue extra space
changeset,0000003058,[3058],johnjamesjacoby,Remove rogue inline php documentation.
changeset,0000005439,[5439],johnjamesjacoby,Remove rogue semicolon.
changeset,0000003069,[3069],johnjamesjacoby,"Remove search_form() from no-topics, no-forums, and view templates, as it was causing conflicts in some themes."
changeset,0000005224,[5224],johnjamesjacoby,"Remove second, unused subscription parameters."
changeset,0000002897,[2897],johnjamesjacoby,Remove selected code from bbp_get_dropdown as it's no longer needed.
changeset,0000003757,[3757],johnjamesjacoby,"Remove single-site 'Update Forum' menu, as single sites are updated automatically.
* @todo - Automate multisite installs per site if needed"
changeset,0000003742,[3742],johnjamesjacoby,"Remove slashes from bbp_get_template_locations(), update doc for bbp_add_template_locations(). See r3739."
changeset,0000003760,[3760],johnjamesjacoby,"Remove slug variables from bbPress class and rely on options and object cache going forward.
* Net performance and memory usage win
* Removes class variables that are already in object cache
* Reduces code duplication
* Fixes #1760"
changeset,0000003907,[3907],johnjamesjacoby,Remove some overly descriptive inline doc from bbpress.php.
changeset,0000003542,[3542],johnjamesjacoby,Remove stray quote from login widget. Fixes #1644. Props markmcwilliams.
changeset,0000003570,[3570],johnjamesjacoby,"Remove stray quote from login widget. See #1644, r3542. (2.1)"
changeset,0000005330,[5330],johnjamesjacoby,Remove stray semi-colon.
changeset,0000003202,[3202],johnjamesjacoby,Remove superfluous h2 tags. Props ramly. Fixes #1529.
changeset,0000003645,[3645],johnjamesjacoby,Remove suppress_filters check and update inline doc in bbp_pre_get_posts()
changeset,0000003121,[3121],johnjamesjacoby,Remove table cell padding from r3120 as it conflicts with theme compatibility.
changeset,0000003092,[3092],johnjamesjacoby,Remove table td styling for theme compat
changeset,0000003122,[3122],johnjamesjacoby,Remove td specific class fix from r3120 so styles also apply to th's.
changeset,0000003729,[3729],johnjamesjacoby,Remove tertiaries in gettexts in revision_log template tags. Fixes #1735. Props jmdodd.
changeset,0000005364,[5364],johnjamesjacoby,"Remove text-zoom override from default responsive theme-compat styling (themes should have this covered.)
"
changeset,0000003301,[3301],johnjamesjacoby,Remove the create topic form from view shortcodes.
changeset,0000004848,[4848],johnjamesjacoby,"Remove the global cache group, and update existing cache group keys to be more descriptive. Fixes issues with cached queries stomping each other on multisite installations. Fixes #2294."
changeset,0000005307,[5307],johnjamesjacoby,Remove the now-empty `includes/admin/images` directory. Props netweb. See #2542.
changeset,0000003596,[3596],johnjamesjacoby,Remove the PHP4 constructor helper in main bbPress class. (2.1)
changeset,0000003072,[3072],johnjamesjacoby,Remove the tr:hover style as it conflicts with certain themes and theme compatibility.
changeset,0000003783,[3783],johnjamesjacoby,"Remove theme setup action from bbp-core-actions.php, as it's now in the bbPress class.
* Tweak inline doc for bbp_load_theme_functions action
* Trust bbp_setup_theme_compat() to set the theme compat regardless of what's there
* See #1766"
changeset,0000005172,[5172],johnjamesjacoby,Remove theme-compat `head_scripts` and move JS into separate files for each condition. Fixes #2454.
changeset,0000002995,[2995],johnjamesjacoby,"Remove thumbnail and excerpt from custom post type supports arrays, and add revisions to forums. Topic/reply thumbnails and excerpts will make great plugins for themes that support this in the future."
changeset,0000003749,[3749],johnjamesjacoby,Remove topic_ prefix from topics admin methods.
changeset,0000003039,[3039],johnjamesjacoby,Remove tr:hover styling from moderation links as it doesn't play nicely with all themes in compatability mode.
changeset,0000002647,[2647],johnjamesjacoby,Remove typo from r2646 props nacin
changeset,0000004799,[4799],johnjamesjacoby,Remove unnecessary capability check for post-status trash fix. Props alex-ye. Fixes #2255.
changeset,0000003593,[3593],johnjamesjacoby,Remove unused $bp global in bbp_filter_user_id()
changeset,0000003555,[3555],johnjamesjacoby,"Remove unused $is_edit param in anonymous user data function, and clean up some whitespace."
changeset,0000005255,[5255],johnjamesjacoby,"Remove unused admin area binary assets, including about page badges, top level menu icons, and retired icon32's. This is all handled by Dashicons going forward. Fixes #2513."
changeset,0000003296,[3296],johnjamesjacoby,Remove unused admin topic save handler function. See r3295
changeset,0000003211,[3211],johnjamesjacoby,Remove unused archive slugs from bbp_add_options()
changeset,0000003310,[3310],johnjamesjacoby,"Remove unused bbp_new_forum_admin_handler() function, and move $parent_id check into metabox_save(). Fixes #1555. Props DJPaul for original catch."
changeset,0000003393,[3393],johnjamesjacoby,Remove unused user-posts.php template file from bbp-twentyten.
changeset,0000003819,[3819],johnjamesjacoby,Remove whitespace before get_header() calls in bbp-theme-compat root files.
changeset,0000002982,[2982],johnjamesjacoby,"Rename ""#reply"" ID to ""#post' for easy backwards compatibility with stand-alone permalinks."
changeset,0000003302,[3302],johnjamesjacoby,"Rename ""no"" template parts to ""feedback"" and add new ""Already Logged In"" feedback part.
Add login, register, and lost password shortcodes.
Rename single tag shortcode to prevent conflict with all-tags shortcode."
changeset,0000002977,[2977],johnjamesjacoby,"Rename $wp_query param in bbp_pre_get_posts to $posts_query to avoid conflict with $wp_query global.
Use $posts_query->get() in place of get_query_arg() to prevent errors in rare cases where $wp_query global is not set.
Fixes #1493 again."
changeset,0000003283,[3283],johnjamesjacoby,Rename 'general' component and related files to 'common'
changeset,0000005045,[5045],johnjamesjacoby,Rename 'template-tags' files to 'template' to match core conventions. Also rename BuddyPress Groups extension from 'group' to 'groups'.
changeset,0000003049,[3049],johnjamesjacoby,"Rename _unset_queries to _unset_globals in BPP_Shortcodes, and ensure shortcodes that use custom queries are unset before and after they run."
changeset,0000006508,[6508],johnjamesjacoby,Rename `base_dir` to `basepath` for consistency.
changeset,0000002753,[2753],johnjamesjacoby,"Rename bbp-filters.php to bbp-hooks.php, and move a majority of actions/filters into it. Introduce ability to edit topics/posts from front-end of theme, and consequently introduce page-bbp_edit.php. Also includes various phpDoc clean-up. Props !GautamGupta via Google Code-in"
changeset,0000002602,[2602],johnjamesjacoby,Rename bbp-templatetags to bbp-template
changeset,0000002722,[2722],johnjamesjacoby,Rename bbp_get_modified_date function to bbp_convert_date since we no longer use the modified_date for freshness.
changeset,0000002494,[2494],PeteMall,Rename bbp_get_topic_forum_ID to bbp_get_topic_forum_id for consistency.
changeset,0000004808,[4808],johnjamesjacoby,"Rename bbp_pre_get_posts_exclude_forums() to bbp_pre_get_posts_normalize_forum_visibility(), to better describe what it does.
bbp_pre_get_posts_normalize_forum_visibility() is a dual purpose function, responsible for normalizing the post_status and post_parent scopes of bbPress related forum queries, against the current users capabilities. This means it must include forums for capable users, and exclude them for incapable users.
See #2221. "
changeset,0000003726,[3726],johnjamesjacoby,Rename bbp_reset_post_data() to bbp_theme_compat_reset_post_data() to properly separate it from other functions.
changeset,0000002485,[2485],johnjamesjacoby,Rename files and directories from bb- to bbp-. Add topics loop functions. Fix forum/topic post row columns. Add functions and filters files.
changeset,0000003223,[3223],johnjamesjacoby,Rename just-in-time filters for editing topics and replies. Copy pasta. See r3222.
changeset,0000005071,[5071],johnjamesjacoby,"Rename link class to match function and output, and remove some duplicate escapings. See #2090."
changeset,0000005323,[5323],netweb,"Rename PHPUnit config file from phpunit.xml to phpunit.xml.dist
* PHPUnit supports config files with both these names, but will use phpunit.xml over the .dist version.
* Renaming our file lets users add/edit their own phpunit.xml without editing a bbPress core file.
* Hattip djpaul via [BuddyPress:r8098]
* Props netweb. See #2542"
changeset,0000002626,[2626],johnjamesjacoby,Rename private functions and fix themes url.
changeset,0000003376,[3376],johnjamesjacoby,Rename remaining functions prefixed with an underscore.
changeset,0000002558,[2558],johnjamesjacoby,Rename single topic_reply template file to match new post_type ID
changeset,0000002704,[2704],johnjamesjacoby,Rename sticky option keys
changeset,0000002935,[2935],johnjamesjacoby,Rename the 'ignore_sticky_topics' flag to 'show_stickies' and reverse logic to default to true instead of false. This is more natural behavior in the logic that we are turning something off with the word 'false' rather than ignoring stickies with the word 'true'
changeset,0000002858,[2858],johnjamesjacoby,"Rename topic_id, forum_id, and reply_id global vars to _post_type to more accurately describe what they are. Include template functions to retrieve those values, and use them through-out the project. Normalize component updater functions and remove surplus calculations from them. Temporarily unhook filters from split/join/deletion actions until new routines can be created to handle forum and topic recounts."
changeset,0000005065,[5065],johnjamesjacoby,Rename Walker class parameters to prevent PHP5.4 E_STRICT warnings.
changeset,0000004740,[4740],johnjamesjacoby,Reorder topic and reply content code filters to fix entity issue inside code blocks.
changeset,0000007135,[7135],johnjamesjacoby,"Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In branches/2.6, for 2.6.6.
See #3310."
changeset,0000007134,[7134],johnjamesjacoby,"Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In trunk, for 2.7.
See #3310."
changeset,0000006933,[6933],johnjamesjacoby,"Repair Tools: rename forum reply hidden count function, and fix default sort order.
This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
"
changeset,0000006428,[6428],johnjamesjacoby,"Repair: In `bbp_repair_forum_visibility()`, don't bail if an error occurs.
Instead, skip the erroneous results and update the valid ones."
changeset,0000006495,[6495],johnjamesjacoby,"Repairs: Prefer `empty()` over `! isset()` in `bbp_admin_repair_group_forum_relationship()`
The `meta_value` key will always be set, because of the way the forum query is written.
See #2829."
changeset,0000002648,[2648],johnjamesjacoby,Replace $_GET['post_type'] references with $typenow global in admin. Props nacin
changeset,0000003475,[3475],johnjamesjacoby,Replace 'bp_forums_strip_mentions_on_post_edit' filters with custom class method to prevent load order issues with BuddyPress forums component.
changeset,0000002557,[2557],johnjamesjacoby,Replace 'topic_reply' references with 'reply' (this includes the post_type ID)
changeset,0000005356,[5356],johnjamesjacoby,Replace `function_exists()` checks with `is_callable()` in template stack functions. Props boonebgorges. See: http://buddypress.trac.wordpress.org/ticket/5671
changeset,0000004833,[4833],johnjamesjacoby,"Replace body class 'bbPress' with 'bbpress' -- CSS classes are case insensitive, but we should stick to common conventions to avoid confusion. Props ethitter/boonebgorges."
changeset,0000002596,[2596],johnjamesjacoby,Replace constants with $bbp global. Rename 'post type' references to 'content type.' Various human readability fixes.
changeset,0000004581,[4581],jmdodd,"Replace esc_attr() with urlencode() when adding search terms query args.
* Fixes #2110.
"
changeset,0000006959,[6959],johnjamesjacoby,"Replace extensive changelog with a single link to the Codex.
Props casiepa (for trunk)
"
changeset,0000006958,[6958],johnjamesjacoby,"Replace extensive changelog with a single link to the Codex.
Props casiepa.
"
changeset,0000004996,[4996],johnjamesjacoby,"Replace generic stdClass usages with correct object types.
Fixes debug notices with bbp_get_displayed_user_field() when requesting non-existing fields or when there is no displayed user, by allowing the magic __get() methods of the WP_User class to bail if the field is not set.
Also prevents similar issues with main query loops. Fixes #2359."
changeset,0000003627,[3627],johnjamesjacoby,Replace get_class() calls with is_a() where applicable.
changeset,0000003116,[3116],johnjamesjacoby,Replace incorrect query args ('post_author' with correct 'author'.) Fixes #1511. Props cnorris23.
changeset,0000004369,[4369],johnjamesjacoby,Replace instances of 'bbPress' string output with 'Forums' in admin settings.
changeset,0000004783,[4783],johnjamesjacoby,Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.
changeset,0000004974,[4974],johnjamesjacoby,"Replace the_content() with bbp_forum_content() where appropriate. Fixes recursion issues introduced in r4792, as part of http://buddypress.trac.wordpress.org/ticket/5021"
changeset,0000003010,[3010],johnjamesjacoby,Replace underscores in admin dashboard widget ID with hyphens. Move clearing br outside of update_plugins cap check to prevent display issues for normal users.
changeset,0000005118,[5118],johnjamesjacoby,Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.4.1)
changeset,0000005119,[5119],johnjamesjacoby,Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.5)
changeset,0000005349,[5349],netweb,"Replies now use the reply ID for the the post name/slug via r5117.
bbPress' importers should also reflect that change with the removal of 'Reply Title' (post_title), 'Reply Slug' (post_name) and `callback_reply_title` from all importers. Props netweb. Fixes #2585"
changeset,0000004522,[4522],johnjamesjacoby,"Replies:
* Add ability to move a reply into a new topic, or into an existing topic.
* Includes new template part, new extra page template, and functions for handling the data move and template output.
* Props jmdodd.
* Fixes #1900."
changeset,0000004062,[4062],johnjamesjacoby,"Replies:
* Add table prefix to _bbp_has_replies_where().
* See: #1885."
changeset,0000004163,[4163],johnjamesjacoby,"Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.1 branch."
changeset,0000004162,[4162],johnjamesjacoby,"Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.2 branch."
changeset,0000004063,[4063],johnjamesjacoby,"Replies:
* Missed a 'wp_posts' reference in _bbp_has_replies_where().
* See: #1885."
changeset,0000003999,[3999],johnjamesjacoby,"Replies:
* Update bbp_get_reply_position_raw() to protect against debug notices from a totally missing reply position."
changeset,0000004530,[4530],johnjamesjacoby,"Replies:
* When editing a reply, do not append ""Reply To:""
* Hat-tip netweb.
* Fixes #2066 (2.2 branch)"
changeset,0000004529,[4529],johnjamesjacoby,"Replies:
* When editing a reply, do not append ""Reply To:""
* Hat-tip netweb.
* Fixes #2066 (trunk)"
changeset,0000006245,[6245],johnjamesjacoby,"Replies: Add `@since` and link to ticket from r6244.
See #3039."
changeset,0000006388,[6388],johnjamesjacoby,"Replies: Add `role=""button""` to reply-to links.
Also normalize surrounding ""Reply"" text escaping.
Fixes #3092. Props alexstine."
changeset,0000006546,[6546],johnjamesjacoby,"Replies: Add `single_row()` method to replies list table when editing a topic.
This lets us use `get_post_class()` on the table rows, so statuses like `pending` or `spam` can be properly in the list for users who have the capability to see them.
See #2587."
changeset,0000007178,[7178],johnjamesjacoby,"Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In branches/2.6 for 2.6.7. See #3366.
Props immeet94."
changeset,0000007177,[7177],johnjamesjacoby,"Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In trunk for 2.7.0. See #3366.
Props immeet94."
changeset,0000006363,[6363],netweb,"Replies: Allow `pending` replies to be edited on the front end.
This changeset in `bbp_get_reply_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending replies always have ugly permalinks.
Props SergeyBiryukov.
Fixes #3054.
"
changeset,0000007157,[7157],johnjamesjacoby,"Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In branches/2.6, for 2.6.6. See #3309.
Props dd32, man4toman."
changeset,0000007158,[7158],johnjamesjacoby,"Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In trunk, for 2.7. Fixes #3309.
Props dd32, man4toman."
changeset,0000007180,[7180],johnjamesjacoby,"Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a ""0"" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In branches/2.6 for 2.6.7. Fixes #3386."
changeset,0000007179,[7179],johnjamesjacoby,"Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a ""0"" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In trunk for 2.7.0. See #3386."
changeset,0000007011,[7011],johnjamesjacoby,"Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6."
changeset,0000007010,[7010],johnjamesjacoby,"Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.7, trunk."
changeset,0000006316,[6316],johnjamesjacoby,"Replies: Check for reply hierarchy before assuming topic-title in reply-to.
Fixes a bug causing malformed output when creating a reply via `wp-admin`.
Props tharsheblows . Fixes #2617. See #2844."
changeset,0000005894,[5894],netweb,"Replies: Clarify inline doc surrounding `bbp_show_lead_topic()` in `bbp_get_reply_position()`
This changest clarify's the docs on how `bbp_show_lead_topic()` affects a reply's menu order in a topics reply loop and determining the correct pagination of reply URL's.
Includes unit tests for `bbp_reply_position()` and `bbp_get_reply_url()`
Fixes #2845
"
changeset,0000007095,[7095],johnjamesjacoby,"Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In branches/2.6, for 2.6.6.
See #3376."
changeset,0000007096,[7096],johnjamesjacoby,"Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In trunk, for 2.7.0.
Fixes #3376."
changeset,0000006553,[6553],johnjamesjacoby,"Replies: Do not update term cache in `bbp_has_replies()`.
This change removes 2 unnecessary database queries from single topic pages. In situations where the leading topic is gathered as part of the `bbp_has_replies()` loop, this still functions as anticipated, and the original topic loop query will handle updating the term cache appropriately."
changeset,0000006317,[6317],johnjamesjacoby,"Replies: Ensure hierarchical replies are correctly wrapped & concatenated into their output buffers in the correct order.
This updates the walker class to not immediately echo it's contents, and wraps it in an `ul` element.
Fixes #2757. See #2830."
changeset,0000006965,[6965],johnjamesjacoby,"Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking ""Reply"" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.6.2, branches/2.6.
"
changeset,0000006964,[6964],johnjamesjacoby,"Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking ""Reply"" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.7, trunk.
"
changeset,0000005859,[5859],johnjamesjacoby,"Replies: fallback on `post_parent` in `bbp_update_reply_walker()`.
This changeset fixes a bug where topic reply counts were not updated when replies were permanently deleted, causing hidden reply counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529."
changeset,0000006037,[6037],netweb,"Replies: Fix `@param` PHPDoc in `bbp_insert_topic_update_counts()`
See #1799
"
changeset,0000007147,[7147],johnjamesjacoby,"Replies: fix clicking ""Reply"" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking ""Reply"" from the lead topic now behaves similarly to clicking ""Reply"" from a reply. This includes support for hierarchical replies being on or off.
In branches/2.6, for 2.6.6. See #3385."
changeset,0000007148,[7148],johnjamesjacoby,"Replies: fix clicking ""Reply"" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking ""Reply"" from the lead topic now behaves similarly to clicking ""Reply"" from a reply. This includes support for hierarchical replies being on or off.
In trunk, for 2.7. Fixes #3385."
changeset,0000007174,[7174],johnjamesjacoby,"Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In branches/2.6 for 2.6.7. Fixes #3327.
Props mjonesnerdery."
changeset,0000007173,[7173],johnjamesjacoby,"Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In trunk for 2.7.0. See #3327.
Props mjonesnerdery."
changeset,0000006427,[6427],johnjamesjacoby,Replies: fix incorrect inline doc in `bbp_current_user_can_access_create_reply_form()`.
changeset,0000005924,[5924],netweb,"Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
"
changeset,0000005737,[5737],johnjamesjacoby,"Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801."
changeset,0000005880,[5880],netweb,"Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
"
changeset,0000005889,[5889],netweb,"Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
"
changeset,0000006706,[6706],johnjamesjacoby,"Replies: introduce `bbp_get_public_reply_statuses()` to speed-up reply queries.
This change removes the `closed` post status from several reply-only queries, ensuring that query indexes are used effectively. It also brings parity to the Replies component that exists in both Forums & Topics."
changeset,0000006396,[6396],johnjamesjacoby,"Replies: Invert the `$show_none` comparison, to fix the default drop-down text.
Props SergeyBiryukov. Fixes #2617."
changeset,0000006621,[6621],johnjamesjacoby,"Replies: Normalize `bbp_has_replies()` default search with `bbp_has_topics()`.
This brings parity to how these two functions handle default search parameters."
changeset,0000005675,[5675],johnjamesjacoby,"Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators"
changeset,0000006717,[6717],johnjamesjacoby,"Replies: performance optimization to `bbp_update_reply_position()`.
This change uses `wpdb::update()` instead of `wp_update_post()` and juggles the `bbp_clean_post_cache()` filter, retaining object caches of related posts and queries, and also removes other unintended `edit_post` action interference.
Fixes #3169."
changeset,0000007140,[7140],johnjamesjacoby,"Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In branches/2.6, for 2.6.6. See #3409."
changeset,0000007142,[7142],johnjamesjacoby,"Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In trunk, for 2.7. Fixes #3409."
changeset,0000007131,[7131],johnjamesjacoby,"Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In branches/2.6, for 2.6.6.
See #3385."
changeset,0000007130,[7130],johnjamesjacoby,"Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In trunk, for 2.7.
See #3385."
changeset,0000005891,[5891],netweb,"Replies: Remove previous `menu_order` default from `bbp_insert_reply()` missed in r5889
Antiprops netweb. See #2843.
"
changeset,0000007141,[7141],johnjamesjacoby,"Replies: remove unintended duplicate array_filter() call from r7140.
"
changeset,0000007139,[7139],johnjamesjacoby,"Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In branches/2.6, for 2.6.6. See #3379."
changeset,0000007138,[7138],johnjamesjacoby,"Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In trunk, for 2.7. See #3379."
changeset,0000006979,[6979],johnjamesjacoby,"Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6."
changeset,0000006980,[6980],johnjamesjacoby,"Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk."
changeset,0000006246,[6246],johnjamesjacoby,"Replies: Update `bbp_thread_replies()` to skip user profile pages.
* Move from core/options to replies/functions, since this isn't directly an option
* Add `! bbp_is_single_user_replies()` check to force `false` if so
* Update threaded replies pagination to re-include verbiage.
Fixes #3002."
changeset,0000006721,[6721],johnjamesjacoby,"Replies: Update tests for `test_bbp_get_reply_position()`.
This change makes sure that updating a reply position to zero is still possible, also ensuring that tests continue to pass as expected."
changeset,0000006096,[6096],johnjamesjacoby,"Replies: use `appendChild` vs. `insertBefore` for inline JS replies.
Fixes #2971. Props r-a-y."
changeset,0000007242,[7242],johnjamesjacoby,"Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In branches/2.6, for 2.6.10.
Props mdjwel via GitHub pull request."
changeset,0000007241,[7241],johnjamesjacoby,"Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In trunk, for 2.7.0.
Props mdjwel via GitHub pull request."
changeset,0000006826,[6826],johnjamesjacoby,"Replies: use existing `reply_to` value if none is passed.
This change fixes a bug that would cause the reply hierarchy to be broken when non-moderator users would edit their existing replies within the allotted editing period.
Props wpdennis. Fixes #3205."
changeset,0000003274,[3274],johnjamesjacoby,"Reply ""View"" action link should link to reply URL and not the permalink for the reply, since not all themes will support single reply views. Unset the ""View"" link if user is viewing trash and does not have proper caps."
changeset,0000003934,[3934],johnjamesjacoby,"Reply Position Improvements:
* Add _update_ and _raw functions for reply positioning.
* Use these functions through-out the codebase as needed.
* Maintains the existing bbp_get_reply_position() behavior, so it's backwards compatible.
* Fixes #1840."
changeset,0000003941,[3941],johnjamesjacoby,"Reply Position/URL:
* Always cast the return value of bbp_get_reply_position() as an integer.
* See #1842."
changeset,0000003940,[3940],johnjamesjacoby,"Reply Position/URL:
* Updates to bbp_get_reply_url() to simplify some logic.
* Move $wp_rewrite global to only where it's needed.
* Move reply position bump to bbp_get_reply_position().
* Fixes #1842. Props WCMKE."
changeset,0000003938,[3938],johnjamesjacoby,"Reply Position:
* Fix issue with new reply_position logic when posting a rew reply.
* Bump the position by one if lead topic is in the replies loop.
* Fixes #1841."
changeset,0000004277,[4277],johnjamesjacoby,"Reply Titles:
* Attribute 'maxlength' not allowed on hidden fields.
* See #1996."
changeset,0000004748,[4748],johnjamesjacoby,"Reprioritize autoembeds to before make_clickable(), to fix broken autoembeds. Fixes #2192."
changeset,0000004656,[4656],johnjamesjacoby,"Reprioritize revision log appending filters to 99, to avoid possibly escaping the full HTML output. Fixes #2131."
changeset,0000007016,[7016],johnjamesjacoby,"Requirements: bump PHP version to 5.6.20.
This commit adds support for the ""Requires PHP"" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.6.3, branches/2.6."
changeset,0000007017,[7017],johnjamesjacoby,"Requirements: bump PHP version to 5.6.20.
This commit adds support for the ""Requires PHP"" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.7, trunk."
changeset,0000003089,[3089],johnjamesjacoby,Reset the img.avatar float to none for theme compat
changeset,0000003394,[3394],johnjamesjacoby,Reset the post data at the end of each have_posts loop.
changeset,0000003087,[3087],johnjamesjacoby,Reset the post data in the _unset_globals() shortcode function
changeset,0000006759,[6759],johnjamesjacoby,"Reset: DRY out the `bbp_admin_reset_database()` logic.
This change introduces a helper function for running queries and producing user feedback based on those results. It also introduces a `Skipped` result if the query is invalid or empty. Ultimately, this results in fewer repeated lines of code, fewer reused local variables, and an easier to understand code flow.
An old, leftover routine for removing `forum-mod` taxonomy terms was also removed, as that approach was abandoned during the 2.6 development cycle but was missed when other refactoring was done."
changeset,0000002818,[2818],johnjamesjacoby,Resetting EOL style to native through-out plugin branch.
changeset,0000003083,[3083],johnjamesjacoby,Resort rules in bbPress::generate_rewrite_rules()
changeset,0000005013,[5013],johnjamesjacoby,Responsive styling to default templates. Huge props mercime. Fixes #1933.
changeset,0000005617,[5617],netweb,"Restore PHP 5.2 to Travis CI
* Travis restored PHP 5.2 support late last week.
Fixes #2753
"
changeset,0000003535,[3535],johnjamesjacoby,Retagging 0.9.0.7 (See r3435)
changeset,0000003532,[3532],johnjamesjacoby,Retagging 1.1 (See r3529)
changeset,0000006936,[6936],johnjamesjacoby,"Retro TV styling for contributor avatars. 📺
"
changeset,0000003700,[3700],johnjamesjacoby,Return passed value if not applicable in bbp_admin_custom_menu_order()
changeset,0000004736,[4736],johnjamesjacoby,Reverse single/double quote usage in bbp_mention_filter(); also use sprintf() to place variable data. See #2185.
changeset,0000002533,[2533],johnjamesjacoby,Reverse tabindexes on login form for rememberme and submit.
changeset,0000003470,[3470],johnjamesjacoby,Reverse the admin.css and admin-2.css relative image depth.
changeset,0000002761,[2761],johnjamesjacoby,Revert r2759 and correct path in r2755. Props westi
changeset,0000003206,[3206],johnjamesjacoby,"Revert 3139. Move .pot file back into bbp-languages folder for improved GlotPress integration. Props vanillalounge, westi."
changeset,0000002855,[2855],mdawaffe,"Revert a piece of [2800]. bbPress (unlike WordPress), uses term taxonomy IDs as tag IDs instead of term IDs.
I cannot reproduce the reported destroy tag bug, but I would not be surprised if there are still some bugs around this term taxonomy ID v. term ID mess.
See #1353
"
changeset,0000005062,[5062],johnjamesjacoby,Revert accidental change to bbp_remove_roles() from r5060.
changeset,0000005063,[5063],johnjamesjacoby,Revert accidental change to forum query 'orderby' args from r5060.
changeset,0000005602,[5602],johnjamesjacoby,"Revert accidental line-change from r5601, #2747.
"
changeset,0000005061,[5061],johnjamesjacoby,Revert accidental removal of threaded replies dropdown pre-option disabled check from r5060.
changeset,0000004980,[4980],johnjamesjacoby,Revert accidental test field change from r4979. See #1999.
changeset,0000002605,[2605],johnjamesjacoby,Revert accidentally deleted uninstall procedure from r2604
changeset,0000004492,[4492],johnjamesjacoby,Revert back to compact() in statistics.
changeset,0000003820,[3820],johnjamesjacoby,"Revert bbp-twentyten back to table based layout:
* bbp-theme-compat retains tableless layout, and is canonical backup for missing template files
* Avoid back-compat issues with installs that have modified bbPress 2.0 CSS
* Fixes #1796"
changeset,0000004476,[4476],johnjamesjacoby,Revert clear removal on topic and reply lists. Force none in profiles. Fixes #1964 (2.2 branch)
changeset,0000004475,[4475],johnjamesjacoby,Revert clear removal on topic and reply lists. Force none in profiles. Fixes #1964 (trunk)
changeset,0000003615,[3615],johnjamesjacoby,Revert cruft from bbp_get_forum_edit_template() from r3614.
changeset,0000004130,[4130],johnjamesjacoby,Revert debug cruft from r4127.
changeset,0000004129,[4129],johnjamesjacoby,Revert debug cruft from r4128.
changeset,0000002748,[2748],johnjamesjacoby,Revert extra voice-counts in single-bbp_topic.php that reappeared in r2746
changeset,0000005360,[5360],johnjamesjacoby,Revert indentation change in r5357. Props netweb. See: http://yaml.org/spec/1.2/spec.html#id2777534
changeset,0000002474,[2474],chrishajer,"Revert mistakenly changed db-version. Props !GautamGupta
"
changeset,0000003085,[3085],johnjamesjacoby,"Revert most of r3054. $wp_query needs to be explicitly checked to guarantee we are not checking the $post global from a different internal loop.
Change from post_meta based _bbp_visibility to custom forum post status for private and hidden forums. This allows for easier exclusion without the need for slower meta queries. Add wp_reset_postdata() through-out loop and template files where the post global might have been altered by an external plugin. Add bbp_exclude_forum_ids() function, to explicitly exclude forums based on user capabilities."
changeset,0000002573,[2573],johnjamesjacoby,Revert part of 2572.
changeset,0000002941,[2941],johnjamesjacoby,Revert part of r2940 and instead use bbp_is_forum() to check if 'any' or bbp_get_forum_id() should be used in default post_parent in bbp_has_topics()
changeset,0000003299,[3299],johnjamesjacoby,Revert part of r3195. Fixes #1532. Props GautamGupta.
changeset,0000003497,[3497],johnjamesjacoby,Revert part of r3487 and use post_parent for Akisment permalink parameter.
changeset,0000003601,[3601],johnjamesjacoby,Revert part of r3600 and change logic. See #1678. (2.1)
changeset,0000003725,[3725],johnjamesjacoby,"Revert part of r3703 as it was causing comment forms and page edit links to reappear in some themes. Instead, introduce bbp_reset_post_data() and use it when the_content has been replaced and the $post global has been unset."
changeset,0000003937,[3937],johnjamesjacoby,Revert part of r3936 and use correct parent class for reply permalinks.
changeset,0000004599,[4599],johnjamesjacoby,"Revert part of r4594, and move #post ID to bbp-reply-header element. Fixes regression with not being taken to #post-ID on reply publish and edit."
changeset,0000005000,[5000],johnjamesjacoby,"Revert part of r4995 that introduced strict comparisons in bbp_get_time_since() against return values of floor(), which returns a float. See #2358."
changeset,0000005124,[5124],johnjamesjacoby,Revert part of r5060. Fixes issues with setting forum statuses. Props netweb. (2.4.1)
changeset,0000005165,[5165],johnjamesjacoby,"Revert part of r5164 that moved the `$r` array within a `bbp_is_forum_category()` check in `bbp_get_forum_subscription_link()`, as it caused debug notices from `$r` not being defined. See #2475."
changeset,0000006568,[6568],johnjamesjacoby,"Revert part of r6567, and instead skip the page condition completely.
This makes sure that forms are made available to moderators regardless of the page condition, and fixes a situation where per-forum moderators couldn't publish to forums or topics that were closed."
changeset,0000002961,[2961],johnjamesjacoby,Revert previous admin menu separator sanity checks until it can be researched further.
changeset,0000003258,[3258],johnjamesjacoby,Revert r3257 for something more elegant.
changeset,0000003377,[3377],johnjamesjacoby,Revert r3369.
changeset,0000003408,[3408],johnjamesjacoby,Revert r3407 and r3405 and move overflow styling into correct locations.
changeset,0000003472,[3472],johnjamesjacoby,Revert r3471 as it introduced added layer of complexity and potentially confusing function names.
changeset,0000004637,[4637],johnjamesjacoby,"Revert r4625, as it could cause spam topics to become published. Will need to rethink/revisit this in 2.4. See #2125."
changeset,0000005273,[5273],johnjamesjacoby,"Revert r5270, r5271. Let's try to get our history back. Antiprops johnjamesjacoby.
"
changeset,0000006854,[6854],johnjamesjacoby,"Revert r6853. This breaks pages with matching slug paths.
Will revisit this more thoroughly in a future version."
changeset,0000002597,[2597],johnjamesjacoby,Revert to colloquial barbarisms (content type/post type)
changeset,0000004780,[4780],johnjamesjacoby,"Revert WordPress 3.6 slash-compat. See r4771, #WP21767."
changeset,0000004428,[4428],johnjamesjacoby,"Revisions:
* In bbp_get_reply_revision_log(), check the post type, and maybe return bbp_get_topic_revision_log() if post is a topic in the replies loop.
* This happens when bbp_show_lead_topic() is set to false, which is the default.
* See #2029."
changeset,0000004426,[4426],johnjamesjacoby,"Revisions:
* Since we do our own revision handling, turn off revisions for the initial call to wp_update_post() in topics and replies.
* We check if the post type supports revisions, and toggle them off and back on to avoid duplicate revisions from specifically saving it later in the edit process.
* Fixes #2029."
changeset,0000004427,[4427],johnjamesjacoby,"Revisions:
* Use correct post type in replies.
* See #2029."
changeset,0000006079,[6079],netweb,"Rewrite Rules: Update search permastruct in `bbPress::add_permastructs()` to `$search_id`
This changeset fixes copy pasta introduced in r4930, and updates the search rewrite to use the `$search_id` and not the `$user_id` as the permalink structure name.
Props offereins.
Fixes #2984.
"
changeset,0000004321,[4321],johnjamesjacoby,"Rewrites:
* Introduce unique rewrite tags and rules for user topics and replies.
* Fixes conflict with topic and reply post type rules.
* Fixes bug where user topics and replies pages were not working on some installations."
changeset,0000006889,[6889],johnjamesjacoby,"Rewrites: use `property_exists()` on `$wp_rewrite` global touches.
This makes sure that bbPress defaults are preferred, and avoids fatal errors if class properties are unset.
Also relocate `bbp_use_pretty_urls()` to better group it together with other `bbp_rewrite()` wrappers."
changeset,0000004449,[4449],johnjamesjacoby,"Roles:
* get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role().
* See #2042 (2.2 branch)"
changeset,0000004450,[4450],johnjamesjacoby,"Roles:
* get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role().
* See #2042 (trunk)"
changeset,0000004448,[4448],johnjamesjacoby,"Roles:
* Remove unused Visitor role.
* Map non-WordPress roles to default role.
* Hat-tip nerrad for confirmation/testing.
* Fixes #2042 (2.2 branch)"
changeset,0000004447,[4447],johnjamesjacoby,"Roles:
* Remove unused Visitor role.
* Map non-WordPress roles to default role.
* Hat-tip nerrad for confirmation/testing.
* Fixes #2042 (trunk)"
changeset,0000004528,[4528],johnjamesjacoby,"Roles:
* When updating bbPress and normalizing user roles, remove the old moderator and participant roles from the database.
* Move !BuddyPress role removal into groups repair tool.
* See #2065 (2.2 branch)"
changeset,0000004527,[4527],johnjamesjacoby,"Roles:
* When updating bbPress and normalizing user roles, remove the old moderator and participant roles from the database.
* Props jmdodd.
* Fixes #2065."
changeset,0000006667,[6667],johnjamesjacoby,"Roles: account for empty role in `bbp_set_current_user_default_role()`
This change makes sure that if a user's role does not match any known role, they still receive the default role for the site.
Trunk, for 2.6."
changeset,0000006118,[6118],johnjamesjacoby,"Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate ""role names"" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `roles` variable to main bbPress class, and store loaded roles there
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. For trunk (2.6)"
changeset,0000006120,[6120],johnjamesjacoby,"Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate ""role names"" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. 2.5 branch (for 2.5.11)
"
changeset,0000006108,[6108],johnjamesjacoby,"Roles: Improve performance of `bbp_get_dynamic_roles()` with a local static variable.
Previously, it rebuilt the multidimensional array of role keys & strings each time it was called, which may be several depending on the page being loaded.
See: #2452."
changeset,0000006106,[6106],johnjamesjacoby,"Roles: Introduce `bbp_roles_init` subaction, and use this for future dynamic roles initialization.
See: #2452;"
changeset,0000006107,[6107],johnjamesjacoby,"Roles: Modify `bbp_add_forums_roles()` to accept a `WP_Roles` object as a parameter.
This allows dynamic roles to be initialized on each call to `wp_roles_init` (for WordPress 4.7) rather than relying on the guesswork of blog-switching, option-sniffing, or user init'ing (none of which have ever been good indicators of roles being initialized.)
See: #2452."
changeset,0000006147,[6147],johnjamesjacoby,Roles: Port `bbp_roles_init()` from trunk to 2.5 branch. See: #3028.
changeset,0000006116,[6116],johnjamesjacoby,"Roles: Remove overzealous usages of `bbp_add_forums_roles()`.
Now that the `wp_roles_init` action exists, we can rely on bbPress roles being registered an available, and no longer need to re-reinitalize them before trying to interact with them.
See: #2959."
changeset,0000003308,[3308],johnjamesjacoby,Round 2 of Akismet updates. Fixes #1553. Props cnorris23.
changeset,0000003588,[3588],johnjamesjacoby,RTL CSS fixes. Props ramiy. Fixes #1654.
changeset,0000004619,[4619],johnjamesjacoby,RTL CSS tweaks for search. See #1575.
changeset,0000004621,[4621],johnjamesjacoby,RTL improvements for pagination arrows and breadcrumb order. See #2124.
changeset,0000005166,[5166],johnjamesjacoby,"RTLove. Props netweb, alex-ye. Fixes #2385."
changeset,0000002809,[2809],johnjamesjacoby,Run strip_tags and trim on topic and reply excerpts. Fixes #1448.
changeset,0000004938,[4938],johnjamesjacoby,s/Base/Root. See #1500.
changeset,0000004600,[4600],johnjamesjacoby,s/compatability/compatibility - Fixes #2108. Props xibe.
changeset,0000005103,[5103],johnjamesjacoby,s/conerts/converts. Props netweb. Fixes #2406. (2.4 branch)
changeset,0000005104,[5104],johnjamesjacoby,s/conerts/converts. Props netweb. Fixes #2406. (trunk)
changeset,0000005594,[5594],johnjamesjacoby,s/POST/GET/ from r5587. See #2742.
changeset,0000004824,[4824],johnjamesjacoby,s/wordpress/WordPress. Props fanquake. Fixes #2265.
changeset,0000003423,[3423],johnjamesjacoby,Sanity check $wp_roles and set if not already set.
changeset,0000003426,[3426],johnjamesjacoby,Sanity check nickname in bbp_edit_user_display_name() to prevent potential debug notice. Fixes #1597. Props !GautamGupta.
changeset,0000003227,[3227],johnjamesjacoby,Sanity check on user roles to prevent error if user does not have a role assigned to them.
changeset,0000002817,[2817],johnjamesjacoby,Sanity checks on logout redirection global variables
changeset,0000004203,[4203],johnjamesjacoby,"Scripts:
* Create empty .min files where warranted.
* Rejig green admin scheme CSS files to use .min."
changeset,0000006641,[6641],johnjamesjacoby,"Scripts: Do not enqueue if not `is_bbpress()`.
This reduces the number of external scripts that are enqueued on non-bbPress pages. Put another way, it makes sure that bbPress styles & scripts are only loaded on pages where bbPress content is known to exist.
Fibes #3138. Props DJPaul."
changeset,0000004618,[4618],johnjamesjacoby,"Search Tweaks:
* Add support for search root page.
* Add search root page to breadcrumb.
* Tweak search form CSS.
* See #1575."
changeset,0000007077,[7077],johnjamesjacoby,"Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
Fixes #3357. 2.6 branch, for 2.6.5.
"
changeset,0000007076,[7076],johnjamesjacoby,"Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
See #3357. Trunk, for 2.7.0.
"
changeset,0000006903,[6903],johnjamesjacoby,"Search: add support for `fs` query-arg to search forums list:
* Introduces `bbp_sanitize_search_request()` to encapsulate duplicate code across forums/topics/replies
* Introduces `bbp_get_search_type_ids()` to stub out future enhancements (tags, users, etc...)
* Use these new functions where intended
* Update `bbp_get_search_terms()` to loop through known search-type IDs
This commit also fixes debug notices that would happen when these query arguments were not explicitly strings.
Fixes #3245.
"
changeset,0000006620,[6620],johnjamesjacoby,Search: Escape output of `bbp_search_terms()` and wire-up to `ts` and `rs`.
changeset,0000006630,[6630],johnjamesjacoby,"Search: move `bbp_allow_search()` checks into form template parts.
This allows the inclusion of those forms without needing to wrap each inclusion statement in its own feature check, making search a more atomic and isolated feature within bbPress.
It also should conclude the development of the user content search functionality.
Because this involves some template-part changes to the ""Default"" template pack, users who have opted to override these parts in their own themes will not receive these updates (nor should they.) This is a known consequence of including template parts in themes, so while still not an ideal system, will not result in any breakage for existing sites."
changeset,0000006824,[6824],johnjamesjacoby,"Search: update `bbp_get_search_terms()` to only accept a string.
This change prevents non-string payloads from being encoded & trimmed."
changeset,0000006629,[6629],johnjamesjacoby,"Search: Use correct `rs` request key.
Fixes a debug notice when searching replies inside of topics."
changeset,0000003225,[3225],johnjamesjacoby,Second round of bbPress standalone importer updates. Props !GautamGupta. See #1523.
changeset,0000003179,[3179],johnjamesjacoby,Security sweep and code clean-up through bbp-reply-functions.php. See #1514.
changeset,0000003399,[3399],johnjamesjacoby,Separate actions and filters in BBP_BuddyPress class. Introduce activity_can_comment() and activity_get_permalink() filters to force bbPress's activity stream items to behave exactly like they do currently with group forums.
changeset,0000003717,[3717],johnjamesjacoby,"Separate bbp-core-compatibility.php into smaller, less-confusing parts:
* bbp-theme-compatibility.php - the API that makes existing themes compatible
* bbp-template-functions.php - functions used to find and load bbPress templates
* bbp-template-loader.php - similar to the WordPress template loader, it handles the logic of what template to display
* Move commonly used functions into bbp-common-functions.php
* Update bbpress.php to require() new files"
changeset,0000005080,[5080],johnjamesjacoby,"Separate content replacement from title replacement in forum and topic archives, allowing pages with matching slugs but empty post_content to replace the_content as expected. Fixes situation where a user creates a ""Forums"" page and leaves the content empty, expecting bbPress to replace it.
Also use the $page->ID to help ""Edit"" links to point to the correct post ID."
changeset,0000006628,[6628],johnjamesjacoby,"Separators: Normalize the `sep` arguments between functions.
This change also switches `bbp_list_forums()` to `implode()` links rather than concatenate the same `$output` string with an increasing number of items. This has the positive side-effect of moving the forum separator (a comma by default) out of individual links.
Props milindmore22. Fixes #2900."
changeset,0000003379,[3379],johnjamesjacoby,Set $bbp->current_user as byref of $current_user.
changeset,0000003539,[3539],johnjamesjacoby,Set $the_core_slugs static to empty array in bbp_form_slug_conflict_check()
changeset,0000005315,[5315],johnjamesjacoby,Set `is_tax` to true when calling `bbp_theme_compaty_reset_post()` when viewing/editing a topic-tag. Fixes #2444.
changeset,0000005771,[5771],johnjamesjacoby,"Set `svn-autoprops`.
This was introduced in Subversion 1.8 specifically to allow common properties for all present and future files in the project, and avoids setting individual properties on most files and prevents errors from skipping properties when new files are introduced.
Hat-tip DJPaul. See r5770, #2802.
"
changeset,0000004683,[4683],johnjamesjacoby,Set correct '_bbp_allow_global_access' default in settings template tag. Fixes issues with it being off on new installs.
changeset,0000004517,[4517],johnjamesjacoby,Set defaults to suppress debug notices in bbp_get_forum_freshness_link(). Props jmdodd. Fixes #2058.
changeset,0000005066,[5066],johnjamesjacoby,"Set max-width on .form-allowed-tags to 100%. Improves theme compat, and fixes issues with allowed tags breaking theme output. Props kobenland."
changeset,0000003405,[3405],johnjamesjacoby,Set overflow to auto on .bbp-topic-content and .bbp-reply-content.
changeset,0000002938,[2938],johnjamesjacoby,Set query names on forums and replies widgets to prevent conflicts with user profile pages.
changeset,0000007021,[7021],johnjamesjacoby,Set stable tag in readme.txt to 2.6.3.
changeset,0000007020,[7020],johnjamesjacoby,Set stable tag in readme.txt to 2.6.3.
changeset,0000003362,[3362],johnjamesjacoby,Set the post_type to topic in bbp_pre_get_posts() when viewing a topic tag. Fixes issue where topics of tag were not visible in some installations. Fixes #1547. Props cnorris23.
changeset,0000004817,[4817],johnjamesjacoby,"Set the super_sticky text to an empty string rather than unset it, since it's currently expected to exist, and empty values will be filtered out anyways."
changeset,0000002490,[2490],PeteMall,Set width for new columns and consolidate row_action functions.
changeset,0000003586,[3586],johnjamesjacoby,"Settings, functions, CSS, and template-tags necessary to use wp_editor() function, introduced in WordPress 3.3. See #1673."
changeset,0000004315,[4315],johnjamesjacoby,"Settings:
* Hide theme compat package selection setting if only 1 package is registered."
changeset,0000004018,[4018],johnjamesjacoby,"Settings:
* Register settings to page, not section ID.
* Fixes bug causing settings not save.
* Fixes #1862."
changeset,0000004016,[4016],johnjamesjacoby,"Settings:
* Remove duplicate 'page' array item from fields, and use 'page' from section parent.
* See #1862."
changeset,0000004100,[4100],johnjamesjacoby,"Settings:
* Remove redundant ""Allow"" verbiage.
* Fix punctuation."
changeset,0000004235,[4235],johnjamesjacoby,"Settings:
* Simplify role translation in bbp_admin_setting_callback_global_access().
* Prevents repeatedly reassigning new value to existing $default_role variable.
* See: r4234."
changeset,0000004058,[4058],johnjamesjacoby,"Settings:
* Smarter boundaries on new 'number' input types.
* See r4057."
changeset,0000004234,[4234],johnjamesjacoby,"Settings:
* Tweak verbiage to make it more clean what each setting does.
* Fixes confusion with ""Global Access"" and how it works.
* Fixes #1904."
changeset,0000004057,[4057],johnjamesjacoby,"Settings:
* Use 'number' input type where appropriate."
changeset,0000004020,[4020],johnjamesjacoby,"Settings:
* Use esc_sql to sanitize __bbp_topic_archive_slug setting."
changeset,0000004019,[4019],johnjamesjacoby,"Settings:
* Use esc_sql to sanitize _bbp_theme_package_id setting.
* Fixes #1862.
* Hat tip michelwppi."
changeset,0000004067,[4067],johnjamesjacoby,"Settings:
* Use integers in bbp_get_default_options() and friends, to avoid boolean conflict in get_option().
* See r4065."
changeset,0000004065,[4065],johnjamesjacoby,"Settings:
* Use isset() instead of !empty() in bbp_pre_get_option()
* Fix issue where settings would not properly override, due to get_option()'s pre filter looking for false, and not null."
changeset,0000006442,[6442],johnjamesjacoby,"Settings: Add `_allow_` settings for editing & flooding, and revise the verbiage.
This allows for flood checking & editing to be:
* Completely disabled
* Overridden via filters
* Editing allowed forever
* A bit more descriptive with additional context provided"
changeset,0000006435,[6435],johnjamesjacoby,"Settings: Add a note to the `_bbp_show_on_root` setting if a forum archive template is found in the template stack.
Fixes confusion that would arise when using the `archive-forum.php` found in the `/extras/` directory.
Fixes #3081."
changeset,0000006483,[6483],johnjamesjacoby,Settings: cast `map_meta_caps` return value to an array.
changeset,0000006070,[6070],netweb,"Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
"
changeset,0000006419,[6419],johnjamesjacoby,"Settings: General improvements:
* Use escaped equivalent for gettext output
* Update settings-integration away from `bool` to allow future flexibility
* Stash settings fields in a static variable to speed up registration"
changeset,0000007089,[7089],johnjamesjacoby,"Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the ""Super Moderators"" and ""Forum Moderators"" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In branches/2.6, for 2.6.5.
"
changeset,0000007088,[7088],johnjamesjacoby,"Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the ""Super Moderators"" and ""Forum Moderators"" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In trunk, for 2.7.0.
"
changeset,0000006420,[6420],johnjamesjacoby,Settings: remove directory path from option text.
changeset,0000006955,[6955],johnjamesjacoby,"Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6."
changeset,0000006954,[6954],johnjamesjacoby,"Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.7, trunk."
changeset,0000006444,[6444],johnjamesjacoby,Settings: Update `int` handling of `bbp_past_edit_lock()`.
changeset,0000006443,[6443],johnjamesjacoby,Settings: Update Engagements setting description to better match others.
changeset,0000006564,[6564],johnjamesjacoby,"Settings: Use `$this->minimum_capability` in options page filter method.
This change keeps the filter inline with the mapped meta caps, should the minimum capability be renamed or changed."
changeset,0000003779,[3779],johnjamesjacoby,"Setup default theme compatibility in bbPress::setup_theme()
* Sets early on bbp_setup_theme so functions and files can be included
* Still allows plugins to override earlier
* See #1766"
changeset,0000003452,[3452],johnjamesjacoby,Setup option filters earlier on bbp_init so plugins don't need to worry about load order. See r3451.
changeset,0000003445,[3445],johnjamesjacoby,"She seems to have an invisible touch, yeah. Fixes #1603. Props cnorris23."
changeset,0000006125,[6125],johnjamesjacoby,"Shh... I meant `bbp_translate_user_role()`.
See r6121.
"
changeset,0000005069,[5069],johnjamesjacoby,Shift output escaping around in admin links to allow for filtering and passing additional HTML into them. Hat tip mourdak. Fixes #2090.
changeset,0000004586,[4586],jmdodd,"Shortcode iteration for search introduced in #1575.
* Fix bbp-search shortcode.
* Introduce bbp-search-form shortcode.
* Fixes #2107.
"
changeset,0000004295,[4295],johnjamesjacoby,"Shortcodes:
* Fix incorrect post_type reference in shortcodes inline doc.
* Fixes #2003."
changeset,0000004296,[4296],johnjamesjacoby,"Shortcodes:
* Fix incorrect post_type reference in widgets inline doc.
* Fixes #2007."
changeset,0000004212,[4212],johnjamesjacoby,"Shortcodes:
* Move shortcode registration into bbPress class to mirror other internal dependencies.
* Introduce bbp_register_shortcode() function, hooked to 'bbp_register'"
changeset,0000005957,[5957],netweb,"Shortcodes: Fix `@return` type shring/string typo in `display_stats()`
"
changeset,0000005956,[5956],netweb,"Shortcodes: Remove superfluous `@param` PHPDoc instances from various shortcode functions
Props casiepa.
"
changeset,0000002484,[2484],PeteMall,"Show forum title, description and topic count on forums admin page."
changeset,0000003231,[3231],johnjamesjacoby,Show hidden forums in the admin all list.
changeset,0000002888,[2888],johnjamesjacoby,Show the forum of super sticky topics when outside of the forum the sticky belongs in.
changeset,0000007087,[7087],johnjamesjacoby,"Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In branches/2.6, for 2.6.5.
See #3157.
"
changeset,0000007086,[7086],johnjamesjacoby,"Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In trunk, for 2.7.0.
See #3157.
"
changeset,0000005466,[5466],johnjamesjacoby,Simpify `ABSPATH` checks to pass coding standard sniffers that look for brackets on comparisons.
changeset,0000005547,[5547],netweb,"SimplePress 5:
* Fix regression introduced in r5349 where topics were imported a second time as part of the reply section import.
* Fix reply parent forum ID mini cache callback to use `callback_forumid`
* Add topic author IP address to topics import section"
changeset,0000005151,[5151],netweb,"SimplePress Importer Improvements. Props netweb. Fixes #2194
* Add reply slug field mapping
* Add custom regex for non-break spaces in HTML"
changeset,0000004615,[4615],johnjamesjacoby,"Simplify favorites link logic and output, to match subscriptions link functionality. Fixes #2118."
changeset,0000002595,[2595],johnjamesjacoby,Simplify load sequence.
changeset,0000004226,[4226],johnjamesjacoby,Simplify password reset hint text.
changeset,0000005513,[5513],johnjamesjacoby,"Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557."
changeset,0000004999,[4999],johnjamesjacoby,"Since search requests get existing data, and do not post new data, revert part of r4997 and switch request method back to ""get"".
Add hidden 'action' field to form-search.php template-part, and move 'bbp_search_results_redirect' action from 'bbp_post_request' to 'bbp_get_request'.
Fixes issue with request not redirecting properly, and uses more accurate form method. See #2337."
changeset,0000004216,[4216],johnjamesjacoby,"Single topics:
* Force is_home to false in bbp_has_replies()
* Maybe set is_single to true if viewing a single topic.
* Fixes bug where WP_Query::parse_query() incorrectly assumes is_home() when multiple post_types are queried.
* Fixes #1947."
changeset,0000002468,[2468],johnjamesjacoby,Singular slugs and add reply slug
changeset,0000002469,[2469],johnjamesjacoby,Singular/plural filter fixes (see r2468)
changeset,0000003161,[3161],johnjamesjacoby,Singular/Plural fixes on forum and topic descriptions. Fixes #1515. Props !GautamGupta.
changeset,0000003649,[3649],johnjamesjacoby,Slight performance improvements to author display_name. See #1704.
changeset,0000005512,[5512],johnjamesjacoby,"Slightly refactor `bbp_format_buddypress_notifications()`:
* Return original `$action` if not `bbp_new_reply`.
* Reduce indentation to accommodate new `$action` check.
This fixes a bug where checking for new reply notifications could cause future notification filter checks to fail.
Props Faison. Fixes #2665."
changeset,0000002467,[2467],johnjamesjacoby,Slug fixes
changeset,0000006966,[6966],johnjamesjacoby,"Slugs: add support for configuring the ""Edit"" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.6.2, branches/2.6."
changeset,0000006967,[6967],johnjamesjacoby,"Slugs: add support for configuring the ""Edit"" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.7, trunk."
changeset,0000002681,[2681],johnjamesjacoby,Smart redirect on new reply in the event new reply creates new topic page
changeset,0000005394,[5394],johnjamesjacoby,Smarter ancestor detection in `BBP_Walker_Reply_Dropdown`. See #2617.
changeset,0000005286,[5286],johnjamesjacoby,Smarter build/src toggling for the stub plugin. See #2542.
changeset,0000005332,[5332],netweb,"SMF Importer BBCode regex expressions
* Fix copy pasta `
`/`` regex
* Add non-break space ` ` to space ` ` rexex
Props mspecht. Fixes @2558
"
changeset,0000005576,[5576],netweb,"SMF importer: Include Subscribed Forums and Subscribed Topics
Props netweb. See #2668
"
changeset,0000005908,[5908],johnjamesjacoby,Sniffer: Whitespace around variables in arrays.
changeset,0000005514,[5514],netweb,"So `.gitignore` is whitespace sensitive. If you include trailing whitespace, git won't recognize your files."
changeset,0000002883,[2883],johnjamesjacoby,Some adjustments to bbp-topic-template.php. Allow capable users to view trashed or private topics on request. Use new author_link function in topic revisions. Do not return a no-break space in bbp_get_topic_admin_links.
changeset,0000002772,[2772],johnjamesjacoby,Sort by menu_order on forums widget
changeset,0000003790,[3790],johnjamesjacoby,"Sort forum ID's based on last active time when querying subforum ID's.
* Prevents last active meta data from becoming poisoned when recounting
* See #1534
* Props GargajCNS for initial patch"
changeset,0000003933,[3933],johnjamesjacoby,Space.
changeset,0000003444,[3444],johnjamesjacoby,Speeling and phpdoc fixes. Fixes #1602. Props cnorris23.
changeset,0000002865,[2865],johnjamesjacoby,Speeling fixes
changeset,0000004048,[4048],johnjamesjacoby,"Spelling Police:
* First pass.
* Fixes #1881, #1880.
* Props netweb."
changeset,0000005518,[5518],netweb,"Spelling typo in `bbp_toggle_reply_handler()`, in between words we use spaces."
changeset,0000004092,[4092],johnjamesjacoby,"Spelling:
* 'i' before 'e', unless you are me.
* I cannot spell, which gives users a headache.
* For 2.1.1."
changeset,0000004093,[4093],johnjamesjacoby,"Spelling:
* 'i' before 'e', unless you are me.
* I cannot spell, which gives users a headache.
* For 2.2."
changeset,0000003252,[3252],johnjamesjacoby,Spit shine the breadcrumb code to play nicely with root forum archive pages.
changeset,0000004968,[4968],johnjamesjacoby,"Split ""Main"" settings up into ""User"" and ""Features"" - also tweak fancy editor verbiage to add more context."
changeset,0000003811,[3811],johnjamesjacoby,Split admin tools Recount into two functions to handle form submission without duplicate admin notices. Fixes #1788.
changeset,0000002790,[2790],johnjamesjacoby,"Split apart bbp-functions.php into smaller, more manageable files. Also fix missing global on subscription removal. Props !GautamGupta via Google Code-in"
changeset,0000003095,[3095],johnjamesjacoby,"Split bbp-admin.php up into smaller, more manageable parts for forums, topics, replies, users, and metaboxes. Add checks for ABSPATH to each file so that they cannot be accessed outside of WordPress. Adjust the location of the admin menu separator based on use caps and visible menus."
changeset,0000003755,[3755],johnjamesjacoby,"Split bbp-core-hooks.php into two files:
* bbp-core-actions.php
* bbp-core-filters.php
* Update bbpress.php to load new files
* Update phpdoc"
changeset,0000005406,[5406],johnjamesjacoby,Split secondary topic spam/trash/unspam/untrash actions into separate functions to be used during topic status transition. See #2494.
changeset,0000003106,[3106],johnjamesjacoby,Split user template files up into parts for shortcode usage.
changeset,0000004176,[4176],johnjamesjacoby,"Stand tall, little T."
changeset,0000005951,[5951],netweb,"Standardize `@since` PHPDoc tags style and format
* e.g. `@since 2.6.0 bbPress (r5951) YOLO`
* See http://phpdoc.org/docs/latest/references/phpdoc/tags/since.html
This changeset updates the style and formatting of all of our `@since` instances for compatibility with phpDocumentor 2 and WP-Parser as we move toward implementing the bbPress developer code reference.
Props thebrandonallen
Fixes #2879
"
changeset,0000004510,[4510],johnjamesjacoby,"Statistics:
* Add widget and shortcode for forum statistics.
* Props MZAWeb.
* Fixes #2052."
changeset,0000006543,[6543],johnjamesjacoby,"Statistics: Define the `$statistics` array.
This change prevents debug notices, particularly in higher PHP versions (+7.0)
See #2770."
changeset,0000006542,[6542],johnjamesjacoby,"Statistics: Improvements to ""At a Glance"" integration.
* Prefer `bbp_get_total_users()` over `count_users()` to speed up loading
* Don't include empty array values
* Don't link to areas the current user cannot access
* Skip if current user cannot at least spectate (blocked or no access)
Fixes #2770."
changeset,0000007237,[7237],johnjamesjacoby,"Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename ""trashed"" & ""spammed"" keys to ""trash"" & ""spam"" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for ""hidden"" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In branches/2.6 for 2.6.10. Fixes #3428."
changeset,0000007236,[7236],johnjamesjacoby,"Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename ""trashed"" & ""spammed"" keys to ""trash"" & ""spam"" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for ""hidden"" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In trunk for 2.7.0. Fixes #3428."
changeset,0000006786,[6786],johnjamesjacoby,"Stats: Whitespace adjustments to some statistics functions.
See #3196."
changeset,0000006027,[6027],johnjamesjacoby,"Statuses, Types, Visibilities: `bbp_get_topic_types()` usages were missed in r6026.
See #2954."
changeset,0000006026,[6026],johnjamesjacoby,"Statuses, Types, Visibilities: Pass the forum, topic, or reply ID into helper functions.
These ID's pass additional context into respective filters, useful for fine-grained control over UI elements.
This commit normalizes the way these functions work across all of bbPress where applicable, by ensuring all similar functions accept an ID and assume `0` by default. Note that there are currently 2 locations where no ID exists to pass context into, which is by design.
Fixes #2954."
changeset,0000006922,[6922],johnjamesjacoby,"Statuses: normalize status related functions across post types.
This commit adds 2 missing functions for forum statuses, and relocates all of them to the correct functions.php files for their post types.
"
changeset,0000006547,[6547],johnjamesjacoby,"Statuses: Update `Closed` status arguments in `register_post_status()` call.
This makes sure posts with a closed status appear in the status and all listings."
changeset,0000004126,[4126],johnjamesjacoby,"Stickies:
* Make sure stickies always appear according to freshness date.
* For 2.1 branch."
changeset,0000004125,[4125],johnjamesjacoby,"Stickies:
* Make sure stickies always appear according to freshness date.
* For 2.2."
changeset,0000004444,[4444],johnjamesjacoby,"Stickies:
* Prevent revisions from being saved as stickies when editing in wp-admin.
* Also cleans up existing stickies when adding a new sticky topic.
* Fixes #2034 (2.2 branch)"
changeset,0000004443,[4443],johnjamesjacoby,"Stickies:
* Prevent revisions from being saved as stickies when editing in wp-admin.
* Also cleans up existing stickies when adding a new sticky topic.
* Fixes #2034 (trunk)"
changeset,0000006402,[6402],johnjamesjacoby,"Stickies: Improved algorithm for merging stickies to queried posts
* Separate into overloadable function
* Tighter, less wasteful loops through existing query
* Improved sort-ordering of topics by their most recent post activity
* Also separate pagination base URL into new function, out of `bbp_has_topics()`"
changeset,0000006915,[6915],johnjamesjacoby,"Stickies: make sure unapproved topics are unstuck also.
This commit removes a hard coded call to `bbp_unstick_topic()` and hooks into the neighboring `bbp_stick_topic` action, while also hooking into the `bbp_unapprove_topic` action.
A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code.
Fixes #3246."
changeset,0000006401,[6401],johnjamesjacoby,"Stickies: Update forum/topic meta early in `bbp_update_topic()`
* Makes meta-data available earlier for downstream functions
* Removes ineffective assumption of forum-topic-id when empty
This fixes a situation where trying to stick a new topic to a forum would look for the `_bbp_forum_id` meta-data before it was updated.
Fixes #3103."
changeset,0000002825,[2825],johnjamesjacoby,Sticky styling is not just for the front page.
changeset,0000003153,[3153],johnjamesjacoby,"Stop including the old updater script, in preparation for file removal before adding into WP extend."
changeset,0000006140,[6140],johnjamesjacoby,Stop shouting at everyone!
changeset,0000002819,[2819],johnjamesjacoby,Stop XMLRPC from complaining when bbPress is activated. Remove needless isset() checks in bbp_get_user_id(). Fixes #1458
changeset,0000003375,[3375],johnjamesjacoby,String consistency. Fixes #1584. Props ramiy.
changeset,0000005073,[5073],johnjamesjacoby,String match 'to front' from changes to #2090.
changeset,0000004287,[4287],johnjamesjacoby,"Strings:
* Add tips for topic stickiness in admin.
* Props netweb.
* See #2004."
changeset,0000004286,[4286],johnjamesjacoby,"Strings:
* Fix ""forum"" references that should be ""topic.""
* Fixes #2004."
changeset,0000006199,[6199],johnjamesjacoby,"Strings: Add `view_items` text for forums, topics, replies, and topic-tags.
This adds support for a label that is new to WordPress 4.7."
changeset,0000007036,[7036],johnjamesjacoby,"Strings: improve consistency of ""ERROR"" messaging.
This commit moves a few colons from within their respective `` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.6.4, branches2.6."
changeset,0000007037,[7037],johnjamesjacoby,"Strings: improve consistency of ""ERROR"" messaging.
This commit moves a few colons from within their respective `` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.7, trunk."
changeset,0000005868,[5868],johnjamesjacoby,"Strings: prefer `—` over parenthesis when wrapping ""No"" style results.
This changeset normalizes the strings used to pick the parent of a forum, topic, and reply. The `—` may be changed later to improve localization, but for now this provides a good balance of visual separation and familiar UX."
changeset,0000006735,[6735],johnjamesjacoby,"Strings: remove escaped single quotes from profile/website link attributes.
Also normalize the approach used in these 3 similar functions."
changeset,0000005867,[5867],johnjamesjacoby,"Strings: Switch from ""Freshness"" to ""Last Post"" in the `default` theme-compatibility templates.
This changeset updates the column header text used to describe the last activity of a forum/category or topic in bbPress's `default` theme-compatibility (which includes details beyond just the timestamp) making ""Last Post"" more contextually accurate compared to ""Freshness"" which still makes sense within the dashboard (which currently only shows the timestamp.)
Fixes #2031."
changeset,0000006047,[6047],netweb,"Strings: Switch from ""Freshness"" to ""Last Post"" in the admin screens.
This changeset follows on from [5867] where these couple of strings were missed in the original commit.
Props Robkk, thebrandonallen
Fixes #2031
"
changeset,0000006255,[6255],johnjamesjacoby,StyleLint: Prefer shorthand CSS Colors.
changeset,0000006743,[6743],johnjamesjacoby,Styling tweaks for improved Twenty Seventeen theme support.
changeset,0000006589,[6589],johnjamesjacoby,"Styling: Bump assets version & remove prefixes from default.css.
Prefixes are put back during build.
"
changeset,0000006588,[6588],johnjamesjacoby,Styling: Clean-up default styling to pass style linting rules.
changeset,0000006587,[6587],johnjamesjacoby,"Styling: Flatten the editor buttons, and force fieldset legend width & border.
This improves default theme compatibility."
changeset,0000006527,[6527],johnjamesjacoby,"Styling: Improve theme compatibility of avatars & content areas in default themes.
This makes sure that avatars in forum & topic descriptions are always horizontally centered, are not accidentally turned into block-elements by parent-theme `img` styling, and that content areas always occupy the full width of their parent element."
changeset,0000006605,[6605],johnjamesjacoby,"Styling: More aggressively remove borders on anchor elements.
Some themes very stubbornly insist on having shadows & lines around them."
changeset,0000006598,[6598],johnjamesjacoby,"Styling: No border on forums links.
An increasing number of themes are putting borders on links by default to simulate an underline, which causes every link in the forums to be styled in unanticipated ways.
This changeset ensures that links in the entry-content section in forums do not have faux-underlines or excessive attention drawn to them."
changeset,0000006590,[6590],johnjamesjacoby,Styling: No text shadow on editor buttons.
changeset,0000006883,[6883],johnjamesjacoby,"Styling: Remove unused `row-actions` CSS.
This used to be necessary for BuddyPress theme compatibility, but is no longer.
See #3238, for trunk (2.6)
"
changeset,0000006912,[6912],netweb,"Styling: Updade styles and stylelint config per latest coding standards
"
changeset,0000006873,[6873],netweb,"Styling: Use double quotes
Fixes #3228.
Props jrf.
"
changeset,0000007081,[7081],johnjamesjacoby,"Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In branches/2.6, for 2.6.5.)
Fixes #3373.
"
changeset,0000007080,[7080],johnjamesjacoby,"Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In trunk, for 2.7.0.)
Fixes #3373.
"
changeset,0000006757,[6757],johnjamesjacoby,"Sub-actions: bail on completely invalid/empty get/post requests.
This change ensures that non-empty actions (sanitized via `sanitize_key()`) will not make their way into the get/post request actions.
This is in addition to similar checks added to AJAX requests in r6755."
changeset,0000006479,[6479],johnjamesjacoby,Sub-actions: Cast a few return values and add `@return` phpdoc.
changeset,0000006942,[6942],johnjamesjacoby,"Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.6.1, branches/2.6."
changeset,0000006941,[6941],johnjamesjacoby,"Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.7, trunk."
changeset,0000005650,[5650],netweb,"Subscriptions are both forums and topics, remove ""Topic"" from single slug setting description.
Props netweb. Fixes #2709
"
changeset,0000005259,[5259],johnjamesjacoby,"Subscriptions clean-up, from r5258. Props netweb. See #2162. (2.5 branch)"
changeset,0000004543,[4543],johnjamesjacoby,"Subscriptions/Favorites:
* Improvements to AJAX handling.
* Introduces bbp_ajax_response() function in common/functions.php, to handle JSON output.
* Adds AJAX failure responses.
* Props MZAWeb.
* Fixes #1905."
changeset,0000004268,[4268],johnjamesjacoby,"Subscriptions:
* Allow for custom headers in subscription emails.
* Fixes #1992.
* Props gawain."
changeset,0000006727,[6727],johnjamesjacoby,"Subscriptions: Avoid empty `include` statement in `bbp_get_email_addresses_from_user_ids()` call.
This change ensures that if no user IDs are gathered as part of the limited chunk, the loop will continue and avoid a costly `get_users()` call.
See r6725."
changeset,0000006829,[6829],johnjamesjacoby,"Subscriptions: cast function results to `(int)` so strict comparisons pass.
This change fixes a bug where subscription checkboxes and UI elements could show/use incorrect values.
Props wpdennis. Fixes #3206.
"
changeset,0000006918,[6918],johnjamesjacoby,"Subscriptions: clean up code comparisons and documentation.
This commit adds some inline documentation to provide a bit more clarity around what subnscriptions checks and actions are being taken, and adds parenthesis to nested comparisons to improve code readability.
See #3235.
"
changeset,0000006984,[6984],johnjamesjacoby,"Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.6.3, branches/2.6."
changeset,0000006985,[6985],johnjamesjacoby,"Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.7, trunk."
changeset,0000006886,[6886],johnjamesjacoby,"Subscriptions: Do not add or remove subscriptions when editing via WordPress admin.
This change passes the current post ID through to `bbp_is_user_subscribed()`, ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status.
Fixes #3235.
"
changeset,0000006264,[6264],johnjamesjacoby,"Subscriptions: Do not send emails when `$user_ids` is empty.
Also reorder some logic to optimize the users loop.
Fixes #2863. Props thebrandonallen."
changeset,0000006898,[6898],johnjamesjacoby,"Subscriptions: do not send subscription emails during WordPress imports.
This change adds checks to the `WP_IMPORTING` global constant inside of forum & topic subscription notification functions, to prevent sending emails during the import process.
Because hooks still fire during imports, this sanity check avoids a potentially hugely annoying situation for users during forum migrations by any import tool that obeys the use of this core constant.
Fixes #3248. Props danielbachhuber."
changeset,0000006904,[6904],johnjamesjacoby,"Subscriptions: ensure special characters in author names are encoded properly.
This commit copies the approach used on the content, and applies `wp_specialchars_decode()` and `strip_tags()` to author names in subscription emails.
(HTML tags are not usually allowed in usernames, but we strip them anyways in the event a filter allowed them. Better to keep emails legible than include unintended tags?)
Fixes #3256."
changeset,0000006616,[6616],johnjamesjacoby,"Subscriptions: Include `closed` status in subscription triggers.
This change allows activity in closed topics to trigger subscription emails. It also fully implements `bbp_get_subscribers()` completing the deprecation of topic/forum specific handlers.
Fixes #2729.
"
changeset,0000006725,[6725],johnjamesjacoby,"Subscriptions: Introduce `bbp_get_email_addresses_from_user_ids()` to chunk `get_users()` calls.
This changes the strategy used when querying for subscribed users so that not of them are queried at the same time, which could cause timeouts or out-of-memory issues when there are many users subscribed to a forum or topic.
By default, users are now queried in `100` user increments, and each 100 user chunk of email addresses gets merged into 1 large array and returned. The `100` default also has a filter, so it's somewhat configurable. Duplicate email addresses are strictly avoided, and user ID filters were moved to after the current user ID is removed from the array, which allows for third party plugins to add them back in if they'd like to include them.
See #3068."
changeset,0000006916,[6916],johnjamesjacoby,"Subscriptions: pass additional IDs into user ID filters.
This commit adds forum, topic, and reply IDs to the filters commonly used to filter the user IDs that emails are being sent to, providing a quick opportunity to peek at them easily and make decisions based on what they are at the time.
Fixes #3249. Props satollo."
changeset,0000006811,[6811],johnjamesjacoby,"Subscriptions: prevent admin area topic updates from unsubscribing users.
Fixes #3185."
changeset,0000006445,[6445],johnjamesjacoby,"Subscriptions: Remove `array_filter( array_map() )` bit from `$user_ids`.
This now is handled upstream inside of `bbp_get_forum_subscribers()` and friends."
changeset,0000006880,[6880],johnjamesjacoby,"Subscriptions: replace hard-coded, single-use strings with `no-forums` template part."
changeset,0000006830,[6830],johnjamesjacoby,"Subscriptions: simplify edit logic for getting `checked()` value.
Props wpdennis. See #3206.
"
changeset,0000006613,[6613],johnjamesjacoby,"Subscriptions: Strip & decode email titles.
Props thebrandonallen. Fixes #2865.
"
changeset,0000006034,[6034],netweb,"Subscriptions: Update `bbp_new_reply` action to to use `bbp_notify_topic_subscribers` over deprecated `bbp_notify_subscribers`.
Previously in [5643] this was added to the 2.5 branch but was overlooked for `/trunk`, this changeset fixes that.
Props thebrandonallen
Fixes #2946, see also #2618
"
changeset,0000006232,[6232],netweb,"Subscriptions: Update the forum and topic subscriptions 2.6 database update routine.
Previously in r6193 the topic subscription update tool was renamed from `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()` to facilitate the addition of the forum subscription update tool `bbp_admin_upgrade_user_forum_subscriptions()`.
This changeset updates the `bbp_version_updater()` 2.6 database update to run both the above upgrade tools.
Props barry.hughes.
Fixes 3038.
+ bbp_admin_upgrade_user_forum_subscriptions();
"
changeset,0000006614,[6614],johnjamesjacoby,"Subscriptions: Use `bbp_remove_all_filters()` with restore option.
This change uses the bbPress version of `remove_all_filters()` which allows those filters to be restored. We need to restore filters after emails are sent so that template titles & content render correctly within their respective templates.
See #6613.
"
changeset,0000007250,[7250],johnjamesjacoby,"Subscriptions: use topic title in Subject, instead of site name.
This change adds helpful context to email subjects and eliminates duplication between From & Subject mail headers.
Props dd32.
In branches/2.6, for 2.6.10.
Fixes #3446."
changeset,0000007249,[7249],johnjamesjacoby,"Subscriptions: use topic title in Subject, instead of site name.
This change adds helpful context to email subjects and eliminates duplication between From & Subject mail headers.
Props dd32.
In trunk, for 2.7.0.
Fixes #3446."
changeset,0000004359,[4359],johnjamesjacoby,"Suggest:
* Add hidden and private status's to forum suggestions.
* Sanity checks on suggestion results and improve readability.
* Refixes #1901."
changeset,0000004261,[4261],johnjamesjacoby,"Suggest:
* Combine admin/ajax.php into admin/admin.php.
* Tweak metabox output and CSS.
* Adds phpdoc and inline doc.
* Fixes #1901"
changeset,0000004260,[4260],johnjamesjacoby,"Suggest:
* First pass at adding autocomplete to forum and topic ID's.
* Adds ajax.php to bbp-includes/admin/.
* Updates metabox inputs back to type 'text'.
* @todo phpdoc and inline doc, and nonce checks.
* See #1901."
changeset,0000007071,[7071],johnjamesjacoby,"Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.6.15, branches/2.6."
changeset,0000007070,[7070],johnjamesjacoby,"Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.7, trunk."
changeset,0000006574,[6574],johnjamesjacoby,"Super Moderators: Compare the user ID to `$args[0]` instead.
This change makes sure the proper user IDs are compared, and also prevents super moderators from editing Keymasters (demotions can't come from users with a less capable role than their own.)"
changeset,0000006572,[6572],johnjamesjacoby,"Super Moderators: First pass at mapping the meta-capabilities.
This change hooks-up the ability for moderators to edit other users if the super moderator ability is allowed. <3"
changeset,0000006575,[6575],johnjamesjacoby,"Super Moderators: prefer `edit_user` with an ID over `edit_users` without one.
This change makes sure we know exactly which user ID the user is trying to edit. In cases where there is no ID available, we'll try to guess at the displayed user ID, and if that's empty too, we'll do nothing.
This allows the ""User Role"" template part to load properly for Super Moderators."
changeset,0000004717,[4717],johnjamesjacoby,Supplemental removal of group forum capability mapping after group forum is displayed. See #2140.
changeset,0000004525,[4525],johnjamesjacoby,Supplemental update to bbp_trash_forum_topics(). See #2059.
changeset,0000002634,[2634],johnjamesjacoby,Support for pretty pagination links
changeset,0000003001,[3001],johnjamesjacoby,Suppress super stickies from no-replies template page.
changeset,0000002521,[2521],johnjamesjacoby,Surprise! bbPress colors in your WordPress admin! (traditional wp-content dir required for now...)
changeset,0000002906,[2906],johnjamesjacoby,SVN add bbp-update.php from previous revision
changeset,0000003986,[3986],johnjamesjacoby,"SVN properties:
* Add EOL native to new feedback-no-replies.php template part.
* Fixes #1851."
changeset,0000005690,[5690],netweb,"SVN: Remove invalid SVN property `sv:eol-style` from image files in `/branches/2.0` and `/tags/2.0.x`
"
changeset,0000007042,[7042],netweb,SVN: Set `svn:mime-type` to `text/xml` for *.xml.dist files
changeset,0000003576,[3576],johnjamesjacoby,Swap out @public's for @var's in bbpress.php. Props duck_.
changeset,0000002873,[2873],johnjamesjacoby,"Swap voices and replies columns in loop-bbp_topics.php. Add more fancy author links with avatars and names, and use new bbp_author_link function"
changeset,0000002924,[2924],johnjamesjacoby,Switch $topic_id to $forum_id in bbp_update_reply_forum_id()
changeset,0000003120,[3120],johnjamesjacoby,"Switch author IP address from anonymous only to a meta value on every topic and reply. Includes additional template tags, theme compat adjustments, and admin meta box adjustments. Fixes #1505."
changeset,0000003533,[3533],johnjamesjacoby,Switch BackPress external from 1.1 branch to 1.1 tag
changeset,0000002901,[2901],johnjamesjacoby,Switch bbp_get_breadcrumb to use get_post_ancestors() potentially saving a few queries in certain situations.
changeset,0000003173,[3173],johnjamesjacoby,"Switch bbp_template_include action into a filter, and move it down into the filters section of bbp-core-hooks.php. Also add more verbose descriptions to bbp_template_include and bbp_request_feed_trap filters. Fixes #1524. Props greenshady."
changeset,0000002661,[2661],johnjamesjacoby,Switch destination links
changeset,0000005047,[5047],johnjamesjacoby,"Switch main bbPress singleton pointer from a private static to a local static inside the instance() method, preventing recursive $instance references. Fixes #2370."
changeset,0000003088,[3088],johnjamesjacoby,Switch meta font size from em to px for theme compat
changeset,0000002882,[2882],johnjamesjacoby,Switch position of template_notices in user-edit.php in bbp-twentyten theme
changeset,0000005055,[5055],johnjamesjacoby,"Switch some wp_insert_post() usages to wp_update_post(). Use bbp_get_forum(), bbp_get_topic(), and bbp_get_reply() where appropriate, and use objects instead of arrays to avoid escaping issues with wp_update_post()."
changeset,0000005584,[5584],netweb,"Switch to container-based infrastructure on Travis CI.
The container-based infrastructure has more memory and more cores. It also is designed to startup faster. We give up the ability to use sudo, but we aren't using that right now so we should be good.
Props tw2113, netweb
Fixes #2736"
changeset,0000002570,[2570],johnjamesjacoby,Switch to get_the_author_meta to remove deprecated notice.
changeset,0000004878,[4878],johnjamesjacoby,"Switch to using esc_textarea() for filtering form post content values. When using TinyMCE, remove that textarea escaping, and trust tinymce to do its thing. See #2317. (2.3 branch)"
changeset,0000004877,[4877],johnjamesjacoby,"Switch to using esc_textarea() for filtering form post content values. When using TinyMCE, remove that textarea escaping, and trust tinymce to do its thing. See #2317. (trunk)"
changeset,0000003138,[3138],johnjamesjacoby,"Switch topic-meta nowrap off of container and onto new individual spans, for theme compat."
changeset,0000005457,[5457],netweb,"Sync ignore properties of SVN and Git
* Git - More robust `.gitignore` file
* SVN - Ignore `npm-debug.log`"
changeset,0000007119,[7119],xknown,"Sync the _wp_filter_build_unique_id function to rWP38282
"
changeset,0000003642,[3642],johnjamesjacoby,Tag 2.0.2
changeset,0000004022,[4022],johnjamesjacoby,Tag 2.1-rc 2
changeset,0000004015,[4015],johnjamesjacoby,Tag 2.1-rc1
changeset,0000004029,[4029],johnjamesjacoby,Tag 2.1-rc3
changeset,0000004045,[4045],johnjamesjacoby,Tag 2.1-rc4
changeset,0000004075,[4075],johnjamesjacoby,Tag 2.1.
changeset,0000004112,[4112],johnjamesjacoby,"Tag 2.1.1
"
changeset,0000004441,[4441],johnjamesjacoby,Tag 2.2.
changeset,0000004456,[4456],johnjamesjacoby,Tag 2.2.1.
changeset,0000004472,[4472],johnjamesjacoby,Tag 2.2.2.
changeset,0000004568,[4568],johnjamesjacoby,Tag 2.2.3.
changeset,0000004712,[4712],johnjamesjacoby,Tag 2.2.4.
changeset,0000004851,[4851],johnjamesjacoby,Tag 2.3.
changeset,0000004869,[4869],johnjamesjacoby,Tag 2.3.1.
changeset,0000004892,[4892],johnjamesjacoby,Tag 2.3.2.
changeset,0000005099,[5099],johnjamesjacoby,Tag 2.4.
changeset,0000005128,[5128],johnjamesjacoby,Tag 2.4.1.
changeset,0000005203,[5203],johnjamesjacoby,Tag 2.5.
changeset,0000005218,[5218],johnjamesjacoby,Tag 2.5.1.
changeset,0000006150,[6150],johnjamesjacoby,"Tag 2.5.12.
"
changeset,0000006412,[6412],johnjamesjacoby,"Tag 2.5.13.
"
changeset,0000006687,[6687],johnjamesjacoby,"Tag 2.5.14.
"
changeset,0000005251,[5251],johnjamesjacoby,Tag 2.5.3.
changeset,0000005382,[5382],johnjamesjacoby,Tag 2.5.4.
changeset,0000005634,[5634],netweb,Tag 2.5.5.
changeset,0000005647,[5647],johnjamesjacoby,Tag 2.5.6 (from 2.5 branch)
changeset,0000005697,[5697],johnjamesjacoby,"Tag 2.5.7 from 2.5 branch.
"
changeset,0000006511,[6511],johnjamesjacoby,"Tag 2.6 RC 1.
"
changeset,0000006536,[6536],johnjamesjacoby,"Tag 2.6 RC 3. (RC 2 is a private/internal pre-release)
"
changeset,0000006597,[6597],johnjamesjacoby,"Tag 2.6 RC 4.
"
changeset,0000006879,[6879],johnjamesjacoby,Tag 2.6 RC 7.
changeset,0000006251,[6251],johnjamesjacoby,"Tag 2.6-beta-2.
"
changeset,0000006940,[6940],johnjamesjacoby,"Tag 2.6.0.
"
changeset,0000006957,[6957],johnjamesjacoby,"Tag 2.6.1.
"
changeset,0000006983,[6983],johnjamesjacoby,"Tag 2.6.2.
"
changeset,0000007019,[7019],johnjamesjacoby,"Tag 2.6.3.
"
changeset,0000007063,[7063],johnjamesjacoby,"Tag 2.6.4 from 2.6 branch.
"
changeset,0000007091,[7091],johnjamesjacoby,"Tag 2.6.5.
"
changeset,0000007218,[7218],johnjamesjacoby,"Tag 2.6.7.
"
changeset,0000007223,[7223],johnjamesjacoby,"Tag 2.6.8.
"
changeset,0000007229,[7229],johnjamesjacoby,"Tag 2.6.9.
"
changeset,0000003518,[3518],johnjamesjacoby,Tag bbPress 0.9.0.7.
changeset,0000002930,[2930],johnjamesjacoby,Tag bbPress 1.0.3 from 1.0 branch
changeset,0000003523,[3523],johnjamesjacoby,Tag bbPress 1.0.4.
changeset,0000003525,[3525],johnjamesjacoby,Tag bbPress 1.1.
changeset,0000004521,[4521],johnjamesjacoby,"Tag bbPress 1.2.
* Fixes #1857.
"
changeset,0000006169,[6169],johnjamesjacoby,Tag bbPress 1.2.1 which adds some basic PHP7 compatibility. See #3033
changeset,0000003538,[3538],johnjamesjacoby,Tag bbPress 2.0
changeset,0000003604,[3604],johnjamesjacoby,Tag bbPress 2.0.1
changeset,0000003958,[3958],johnjamesjacoby,Tag bbPress 2.0.3.
changeset,0000004379,[4379],johnjamesjacoby,Tag bbPress 2.1.3.
changeset,0000006066,[6066],johnjamesjacoby,"Tag bbPress 2.5.10.
"
changeset,0000006126,[6126],johnjamesjacoby,"Tag bbPress 2.5.11.
"
changeset,0000006023,[6023],johnjamesjacoby,"Tag bbPress 2.5.9.
"
changeset,0000006230,[6230],johnjamesjacoby,"Tag bbPress 2.6-beta-1.
"
changeset,0000007162,[7162],johnjamesjacoby,"Tagging 2.6.6.
"
changeset,0000002964,[2964],johnjamesjacoby,Take extra precautions to ensure admin menus are positions directly above 'Appearance' and set the menu_position of each post_type
changeset,0000002464,[2464],johnjamesjacoby,Tap tap tap... Is this thing on?
changeset,0000003922,[3922],johnjamesjacoby,"Template Loader:
* Add missing single and archive functions.
* Add checks for these templates to loader filter."
changeset,0000004283,[4283],johnjamesjacoby,"Template Locations:
* Revert part of r4264.
* Fix regression where bbPress was pulling in files from unexpected locations.
* Fixes #1994."
changeset,0000004284,[4284],johnjamesjacoby,"Template Locations:
* Revert part of r4283.
* Keep filter on bbp_get_template_part, remove from bbp_locate_template.
* Refixes #1994."
changeset,0000004232,[4232],johnjamesjacoby,"Template Locator:
* Move parent/child/fallback out of loop
* Fix parent/child loader issue, where child theme templates still loaded the parent.
* Updates made to bbp_locate_template() only.
* Regression from earlier 2.2 changes."
changeset,0000006778,[6778],johnjamesjacoby,"Template Notices: unbreak these.
This change adjusts the `bbp_template_notices` action hooks and priority to ensure user, login, and topic notices continue to appear. It also removes the unstyled and unique `updated` class on one of them, which Twenty Seventeen uses as a way to hide elements."
changeset,0000006615,[6615],johnjamesjacoby,"Template Packs: In default theme, only enqueue `editor.js` when `in_bbpress()`.
This results in 1 fewer external asset being enqueued on non-bbPress pages.
Fixes #2930.
"
changeset,0000004325,[4325],johnjamesjacoby,"Template Tags:
* Check for edit when calling _is_ single forum/topic/reply.
* See #1968."
changeset,0000003980,[3980],johnjamesjacoby,"Template Tags:
* Clean up function order and phpdoc from r3979."
changeset,0000003979,[3979],johnjamesjacoby,"Template Tags:
* Introduce functions for getting the forums and topics archive URL's.
* Use functions where appropriate."
changeset,0000006822,[6822],johnjamesjacoby,"Template: add `is_multisite()` check to `bbp_is_site_public()`.
This change avoids a potential fatal error if this core function is used directly."
changeset,0000006682,[6682],johnjamesjacoby,"Template: adjust escaping of pagination count strings.
This change fixes a regression (in trunk only) that caused the filtered results of pagination counts to always be late escaped, but the intention was really only to escape the output of `_n()` which does not have an escaped equivalent function in the Gettext API.
I also tweaked the logic in `bbp_get_topic_pagination_count()` to not bail early. This brings it inline with `bbp_get_forum_pagination_count()` and allows the filter to run even when the text string is empty. Flexibility is the goal, so skipping the filter was also unintentional, and is now fixed.
Fixes #3162."
changeset,0000006486,[6486],johnjamesjacoby,"Template: Pass original `$args` array into `bbp_get_dropdown` filter.
Also update some inline docs & code formatting."
changeset,0000006683,[6683],johnjamesjacoby,"Template: rework post class assignments.
This change avoids multiple reassignments to the same `$classes` variable name, and instead tries to name variables logically and merge them together when necessary. The performance difference is nil, as 'array_merge()` will perform similarly to how each array was reshaped when new classes would be added, but the human difference is only positive, from having clearer and easier to understand logic."
changeset,0000004424,[4424],johnjamesjacoby,"Templates:
* Remove 'bbp-' prefix from default templates directory name.
* Update paths where appropriate.
"
changeset,0000006258,[6258],johnjamesjacoby,"Templates: Add `ABSPATH` checks to default template parts.
This helps avoid leaking error messages on certain server configurations, and ensures that if these individual PHP files are somehow accessed directly (without first loading WordPress) nothing unexpected will happen.
See r5465."
changeset,0000005854,[5854],johnjamesjacoby,"Templates: Add before & after hooks to user templates parts.
This changeset makes it easier to add custom text & HTML before & after user details.
Props netweb. Fixes #2537."
changeset,0000006622,[6622],johnjamesjacoby,"Templates: Add form template parts for searching specifically for topics & replies.
These have been in-use on BuddyPress.org/bbPress.org for years, and will be useful in user-profiles soon.
Also use `bbp_search_terms()` in `form-search.php` now that it's properly escaping output."
changeset,0000007068,[7068],johnjamesjacoby,"Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.6.15, branches/2.6."
changeset,0000007069,[7069],johnjamesjacoby,"Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.7, trunk."
changeset,0000007067,[7067],johnjamesjacoby,"Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.6.15, branches/2.6."
changeset,0000007066,[7066],johnjamesjacoby,"Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.7, trunk."
changeset,0000006865,[6865],johnjamesjacoby,"Templates: call `bbp_get_post_types()` when parsing query args and setting template args.
Fixes #3221. Props scmsteve."
changeset,0000005688,[5688],johnjamesjacoby,Templates: Escape all gettext output in `default` template parts. See #1999.
changeset,0000006343,[6343],johnjamesjacoby,"Templates: Localize topic ID and forum ID.
"
changeset,0000005689,[5689],johnjamesjacoby,"Templates: Micro-optimizations:
* Remove trailing `?>` tag in some template parts
* Remove preceding `?> post_excerpt warnings."
changeset,0000004377,[4377],johnjamesjacoby,"Theme Compat:
* Set post_excerpt when setting the dummy post.
* Fixes issue with unset $post->post_excerpt warnings.
* For 2.1 branch."
changeset,0000003968,[3968],johnjamesjacoby,"Theme Compat:
* Trim off left-slash from template name to prevent duplicate slashes."
changeset,0000004220,[4220],johnjamesjacoby,"Theme Compat:
* Use theme directory functions instead of constants in bbp_locate_template().
* Fixes #1950.
* Props mordauk."
changeset,0000006288,[6288],johnjamesjacoby,"Theme Compat: Add `is_` parameters to various query-reset procedures.
This ensures the state of the `wp_query` global is what someone can safely expect for it to be. It also is used through-out WordPress as a way to auto-assign body classes and various other environmental tweaks.
Fixes #3055. Props sergeybiryukov.
"
changeset,0000006997,[6997],johnjamesjacoby,"Theme Compat: Add back original `ul` styling.
This commit fixes an unintentional styling change. The original rule should not have been removed.
See r6986."
changeset,0000006996,[6996],johnjamesjacoby,"Theme Compat: Add back original `ul` styling.
This commit fixes an unintentional styling change. The original rule should not have been removed.
See r6987."
changeset,0000007073,[7073],johnjamesjacoby,"Theme Compat: conditionally unhook adjacent posts.
This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value.
Props r-a-y. For 2.6.15, branches/2.6."
changeset,0000007072,[7072],johnjamesjacoby,"Theme Compat: conditionally unhook adjacent posts.
This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value.
Props r-a-y. For 2.6.15, branches/2.6."
changeset,0000006999,[6999],johnjamesjacoby,"Theme Compat: Don't override elements that are explicitly using `.dashicons`.
This commit prevents styling conflicts with third party plugins that are using Dashicons in elements.
See r6986."
changeset,0000006998,[6998],johnjamesjacoby,"Theme Compat: Don't override elements that are explicitly using `.dashicons`.
This commit prevents styling conflicts with third party plugins that are using Dashicons in elements.
See r6987."
changeset,0000006956,[6956],johnjamesjacoby,"Theme Compat: Fix CSS overlapping border-radius from r6951.
Also bump package-lock.json.
"
changeset,0000007230,[7230],johnjamesjacoby,"Theme Compat: improve ""no-js"" body class swapping.
This change introduces a new helper function (`bbp_swap_no_js_body_class()`) which is used to output the `