| [6274]
|
johnjamesjacoby
|
Tools: Unify the tab/link experience:
* Introduce function to get tools pages
* Trust capability checks in core WordPress functions, and remove our own bespoke pre-checks
* Add tool-box to `wp-admin/tools.php` linking to tools the user has access to
This change promotes exposure to bbPress's tools pages, and makes adding third-party tools pages easier.
See: #2959.
|
| [5958]
|
netweb
|
Tools: Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds
PHP 7 was released today, congratulations to everyone involved in the release :)
Props netweb.
Fixes #2895.
|
| [5959]
|
netweb
|
Tools: Travis CI: Only test PHP 7 against WordPress 4.3 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7 compatability, which was only added in version 4.3 so lets not let those errors in versions before 4.3 bother us ;)
See #2895.
|
| [6005]
|
netweb
|
Tools: Travis CI The Matrix Reloaded
'''The Architect''': ''The first matrix I designed was quite naturally perfect. It was a work of art. Flawless. Sublime. A triumph only equaled by its monumental failure.''
|
| [6281]
|
johnjamesjacoby
|
Tools: Separate `wp_usermeta` clean-up from database upgrade routines.
Clean-up should be run after upgrades, not during. This way all results can be verified by the admin.
See #3052.
|
| [6091]
|
netweb
|
Tools: Running the "Reset Forums" tool now deletes bbPress' custom post type revisions from the database.
This changeset adds support for deleting forum, topic, and reply post types revisions to `bbp_admin_reset_handler()`.
Fixes #2945.
|
| [6002]
|
netweb
|
Tools: Return unique message strings in `bbp_admin_reset_handler()` when deleting imported users and user meta vs non-imported user meta.
Fixes #2928.
|
| [6277]
|
johnjamesjacoby
|
Tools: Rename page functions with `_page()` suffix.
Previous function names were more ambiguous than intended, and because these functions are only called internally, there is no harm in renaming them.
|
| [6715]
|
johnjamesjacoby
|
Tools: Remove quotes from prepared query statements.
Also use the same `esc_like()` result in 2 matched queries.
Props jrf. Fixes #3168.
|
| [5912]
|
netweb
|
Tools: Remove banners added to minified CSS files and simplified JS banner
This changeset removes the banners that were previously added to minified CSS files as `grunt-contrib-cssmin` deprecated this in v0.11.0.
The banner added to minified JS files has also been simplified by removing the time/date so that unnecessarily merges/updates do not trigger unneeded changes when using version control. The banner added to minified JS files is now static without the date/time, this fixes an issue where the minified file would always change because of the compiled date/time even when there were no code changes, this was causing unneeded changes when merging/updating when using version control external to bbPress.
Props netweb. Fixes #2738
|
| [7395]
|
johnjamesjacoby
|
Tools: Remove JSValidate and use ESLint.
Also update CSS & JS assets based on new tooling.
Includes some improvements to admin area styling, specifically block previews.
In trunk, for 2.7.
|
| [5911]
|
netweb
|
Tools: RTL CSS generation: Switch from CSSJanus to RTLCSS
* If you have used `grunt cssjanus` before, use `grunt rtlcss` now.
* Requires `npm install` to update dependancies
Props netweb. Fixes #2848, see #WP31332 and wp:changeset:31573
|
| [7396]
|
johnjamesjacoby
|
Tools: PHPCS improvements from recent commits.
In trunk, for 2.7.
|
| [6215]
|
johnjamesjacoby
|
Tools: Order fav/sub upgrade by `user_id`.
This makes it easier to `LIMIT` later if you need to manually chunk this. See #2959.
|
| [6283]
|
johnjamesjacoby
|
Tools: Move tools tab functions into `tools.php`.
|
| [6176]
|
johnjamesjacoby
|
Tools: Massize clean-up
* Add missing function documentation blocks
* Rename `_migrate_` function to `_upgrade_`
* More typo fixes
* Make `overhead` values clickable in list table rows
* Refactor `overhead` to work more like `components`, using keys instead of literal strings
See #2959.
|
| [6280]
|
johnjamesjacoby
|
Tools: Map `bbp_tools_upgrade_page` capability to minimum admin capability. See #3052.
|
| [6925]
|
johnjamesjacoby
|
Tools: Make a few columns sortable.
This commit adds a small UX improvement to the Repair and Upgrade tools pages, allowing for these lengthy lists to be sorted.
See #3244.
|
| [6279]
|
johnjamesjacoby
|
Tools: Introduce new "Upgrade Forums" tools section.
* Uses some awesome trickery to reuse as much of the "Repair Forums" API as possible
* Introduces a few new functions to handle the output of the new screen
* Removes hard-coded referencs to `bbp-repair` page, to allow usage on any relevant page (including new `bbp-upgrade`)
* Makes components & overhead lists smarter, and only includes items relevant to the current view
Fixes #3052.
|
| [6481]
|
johnjamesjacoby
|
Tools: Introduce `bbp_get_unique_array_values()` helper function.
Use this when parsing private/hidden forum IDs for saving.
|
| [5668]
|
netweb
|
Tools: Introduce "Repair closed topics tool" `bbp_admin_repair_closed_topics()`
See #2653
|
| [5916]
|
netweb
|
Tools: Include pending replies in the count when running the "Count pending, spammed, & trashed replies in each topic" repair tool
This changeset ensures that pending replies are included in the topic meta `_bbp_reply_count_hidden` count after running the repair tool `bbp_admin_repair_topic_hidden_reply_count()`, includes unit tests.
Props netweb. Fixes #2849
|
| [5960]
|
netweb
|
Tools: Include `forum-mod` taxonomy code in `bbp_admin_reset_handler()`
This changeset adds support for deleting the forum moderator taxonomy when running the bbPress "Reset Forums" tool.
Props netweb.
Fixes #2898.
|
| [6537]
|
johnjamesjacoby
|
Tools: Improvements to repair, upgrade, and converter tools.
* Use escaped gettext equivalent functions where appropriate
* Rename `description` to `title` so that more descriptive descriptions can be used per-tool in a future version
* Register all scripts, and properly enqueue them only a needed
* Reorder & re-title some tools to better match each other
|
| [5783]
|
netweb
|
Tools: Forums should not include forum meta key `_bbp_forum_id`, forums with this meta key were due to either:
1) Incorrectly added by the `bbp_admin_repair_forum_meta()` repair tool
2) Incorrectly added by an old version of one of the included bbPress importers, these were fixed in r5526
Props netweb. Fixes #2669
|
| [6135]
|
johnjamesjacoby
|
Tools: Fix undeclared variables and incorrect variable types, for improved PHP 7.1 compatibility.
This will quiet down most of our continuous integration noise.
Props hellofromTonya. Fixes #3031.
|
| [6174]
|
johnjamesjacoby
|
Tools: First pass at upgrade tools for favorites & subscriptions.
* Registers 2 new repair tools
* Includes basic looping patterns for user-meta to post-meta
Needs testing and scrutiny.
See #2959.
|
| [6182]
|
johnjamesjacoby
|
Tools: Explicitly pass `false` into `add_post_meta()`'s `$unique` parameter.
Though it's the default, we can't make any mistake that meta-key's to be non-unique for this to function correctly.
See #2959.
|
| [6976]
|
netweb
|
Tools: Correct string in repair topic reply count tool.
Props felipeloureirosantos.
See #3288. For 2.7, trunk.
in bbp_admin_repair_topic_reply_count
|
| [6977]
|
netweb
|
Tools: Correct string in repair topic reply count tool.
Props felipeloureirosantos.
See #3288. For 2.6.2, branches/2.6.
|
| [6257]
|
johnjamesjacoby
|
Tools: Correct revision for topic-tag recount tool. See #3043.
|
| [6496]
|
johnjamesjacoby
|
Tools: Change BuddyPress group forum repair into an upgrade routine.
This is only intended as a migration path from bbPress 1.x to 2.x, not to be rerun multiple times to force-recount the meta values & private/hidden options.
See #2829.
|
| [6282]
|
johnjamesjacoby
|
Tools: Break `tools.php` up into separate files. See #3052.
|
| [6188]
|
johnjamesjacoby
|
Tools: Avoid duplicate entries for favorites & subscriptions.
This fixes a bug in the 2.6.0 upgrade routine where running the tool multiple times could add duplicate metadata.
See #2959.
|
| [6523]
|
johnjamesjacoby
|
Tools: Audit repair & upgrade tools.
* Use escaped gettext variant functions where applicable
* Use Query/Prepared/Results paradigm for direct database queries for easier step-through debugging
* Fix a few small bugs in the engagements upgrade functions (none that affect 2.5 or beta/RC users)
* General code formatting improvements and typo fixes
|
| [6256]
|
johnjamesjacoby
|
Tools: Add tool to recount topics in each topic-tag.
* Add callback function for the recount itself
* Add translation for component list
* Update a few tool titles to better represent what they do
* Update tool-orders to fit new tool in the middle
See #3043.
|
| [5964]
|
netweb
|
Tools: Add the `grunt-check-dependencies` npm module.
This changeset adds the Grunt task `checkDependencies` via https://www.npmjs.com/package/grunt-check-dependencies to check the currently npm installed modules against the required modules semantic version listed in `package.json`, if the check fails a prompt to update installed npm modules is displayed and is required before other Grunt tasks can be run.
Run `npm install` after updating your repo to install the module and task.
Props netweb.
Fixes #2893.
|
| [6275]
|
johnjamesjacoby
|
Tools: Add phpdoc for `bbp_get_admin_repair_tool_registered_components()`.
|
| [6173]
|
johnjamesjacoby
|
Tools: Add classes & data attributes to improve responsiveness.
|
| [6193]
|
netweb
|
Tools: Add an upgrade tool for forum subscriptions.
* Adds `bbp_admin_upgrade_user_forum_subscriptions()`
* Renames `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()`
* Updated inline docs
Previously in r6174 upgrade tools were added for favorites and subscriptions, support for migrating forums subscriptions meta `_bbp_forum_subscriptions` wasn't included, rather than adding extra overhead to the existing topic subscriptions upgrade tool another upgrade tool was added for forum subscriptions.
See #2959.
|
| [5892]
|
johnjamesjacoby
|
Tools: Add `id` attribute to "Run" link. Props tharsheblows. See #2841.
|
| [6438]
|
johnjamesjacoby
|
Tools: Add `//Filter & return` note for future discovery of missing filter documentation.
Also adjust some type-casting on filtered results.
|
| [4345]
|
johnjamesjacoby
|
Tools:
* Remove empty( $users ) check in bbp_admin_repair_user_roles().
* Handled by while() loop.
* Tweak inline doc in bbp_admin_repair_user_roles().
|
| [4343]
|
johnjamesjacoby
|
Tools:
* Cleanup repeat variable assignments.
* Unset variables in costly loops to free up some resources.
* Remove one-time-use variables.
|
| [4344]
|
johnjamesjacoby
|
Tools:
* Break bbp_admin_repair_user_roles() loop into 1000 user chunks.
* Fixes issue where we were querying and returning too many rows at a time.
|
| [4451]
|
johnjamesjacoby
|
Tools/Roles:
* In user-map repair tool, use default role if role-map entry does not exist.
* See #2042 (trunk)
|
| [4452]
|
johnjamesjacoby
|
Tools/Roles:
* In user-map repair tool, use default role if role-map entry does not exist.
* See #2042 (2.2 branch)
|
| [7263]
|
johnjamesjacoby
|
Tools/Repair: audit post statuses in repair queries.
This change ensures that all of the relevant repair tools are including the expected public post statuses for their related post types.
These changes specifically address possibly missing Closed Topics in the repair tools, while also ensuring that anything filtering the results of the `_public_statuses()` functions to add their own custom statuses (I.E. archives on WordPress.org) are taken into consideration.
Fixes #3591.
Props GDragoN.
In branches/2.6, for 2.6.10.
|
| [6905]
|
johnjamesjacoby
|
Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`.
This commit allows the favorites repair tool to correctly query for chunked results.
See #3259.
Props GDragoN.
For 2.6/trunk.
|
| [6906]
|
johnjamesjacoby
|
Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`.
This commit allows the favorites repair tool to correctly query for chunked results.
Fixes #3259.
Props GDragoN.
For 2.5.x.
|
| [6908]
|
johnjamesjacoby
|
Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`.
This commit allows the freshness repair tool to correctly query for the maximum topic ID.
Fixes #3261.
Props GDragoN.
For 2.6 (trunk.)
|
| [6909]
|
johnjamesjacoby
|
Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`.
This commit allows the freshness repair tool to correctly query for the maximum topic ID.
Fixes #3261.
Props GDragoN.
For 2.5.x.
|
| [7335]
|
johnjamesjacoby
|
Tools - Warnings/Notices: begin phasing out of `utf8_encode()` for PHP 8.2 and higher.
This change moves the existing `utf8_encode()` usages into a new common formatting function: `bbp_format_user_display_name()`, and uses this new function to abstract & encapsulate checking that mbstring equivalents are loaded & supported.
Props philipjohn.
In trunk, for 2.7.
Fixes #3585.
|
| [7334]
|
johnjamesjacoby
|
Tools - Warnings/Notices: begin phasing out of `utf8_encode()` for PHP 8.2 and higher.
This change moves the existing `utf8_encode()` usages into a new common formatting function: `bbp_format_user_display_name()`, and uses this new function to abstract & encapsulate checking that mbstring equivalents are loaded & supported.
Props philipjohn.
In branches/2.6, for 2.6.14.
Fixes #3585.
|
| [7370]
|
johnjamesjacoby
|
Tools - Unit Tests: update `test_bbp_spam_topic()` with more accurate before/after tests.
This commit ensures that the `test_bbp_spam_topic()` tests pass, and that the various counts, and last IDs and times before & after spamming a topic, are operating as intended.
See #3657.
|
| [7369]
|
johnjamesjacoby
|
Tools - Unit Tests: update `bbp_get_forum_permalink()` to better support hierarchical URIs.
This commit ensures that the `test_bbp_get_forum_permalink()` test passes, and that hierarchical Forum post-type links are correctly formatted when using unpretty/plain permalinks.
See #3657.
|
| [7366]
|
johnjamesjacoby
|
Tools - Unit Tests: prevent double-spaces in span attributes.
This commit prevents the `<span>` that wraps author link parts from having 2 spaces immediately after the opening tag.
|
| [7367]
|
johnjamesjacoby
|
Tools - Unit Tests: plan for `seems_utf8()` to be deprecated.
This commit updates 3 author-link unit tests to avoid WordPress Deprecation notices.
See #3657.
|
| [7368]
|
johnjamesjacoby
|
Tools - Unit Tests: allow mentions after '[' and '(' chars.
This commit fixes the suite of user-mentions unit tests, so that they no longer require an empty "class" attribute, and also so that mentions inside of common wrappers (`()`, `[]` ) are allowed.
See #3657.
|
| [6060]
|
netweb
|
Tools - Unit Tests: Use `get_sites()` for muiltisite PHPUnit testcase in `BBP_UnitTestCase::tearDown`
WordPress 4.6 deprecated `wp_get_sites()`, switch to the replacement `get_sites()` via #WP36994 / [wp:changeset:37653]
Fixes #2962.
|
| [7365]
|
johnjamesjacoby
|
Tools - Unit Tests: Fix some failing tests.
This commit tweaks the expected values of some tests so that they pass as intended, mostly surrounding int/string type numerics and total/single counts.
|
| [7381]
|
johnjamesjacoby
|
Tools - Code Improvement: un-indent last remaining `_get_` functions.
|
| [7379]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring these PHPCS sniffs:
* PEAR.Files.IncludingFile.UseRequire
* PSR2.ControlStructures.SwitchDeclaration.BodyOnNextLineDEFAULT
* PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
* Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
* Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
* Squiz.PHP.EmbeddedPhp.MultipleStatements
* Squiz.PHP.NonExecutableCode.Unreachable
* Universal.Arrays.DuplicateArrayKey.Found
* Universal.ControlStructures.DisallowLonelyIf.Found
* WordPress.PHP.NoSilencedErrors.Discouraged
This commit includes code formatting changes for the above sniffs.
See #3658.
|
| [7378]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring these PHPCS sniffs:
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
* Generic.CodeAnalysis.EmptyStatement.DetectedElseif
* Generic.CodeAnalysis.EmptyStatement.DetectedIf
* Generic.CodeAnalysis.UselessOverridingMethod.Found
* Generic.ControlStructures.InlineControlStructure.NotAllowed
* Generic.Files.LineEndings.InvalidEOLChar
* Generic.Formatting.DisallowMultipleStatements.SameLine
* Generic.Formatting.SpaceAfterCast.TooMuchSpace
* Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace
* Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerMultiLine
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
* NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLineCloserSameLine
* PEAR.Functions.FunctionCallSignature.CloseBracketLine
* PEAR.Functions.FunctionCallSignature.EmptyLine
* PEAR.Functions.FunctionCallSignature.Indent
* PEAR.Functions.FunctionCallSignature.MultipleArguments
* PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
* PHPCompatibility.Syntax.RemovedCurlyBraceArrayAccess.Found
* PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
* PSR2.Classes.PropertyDeclaration.ScopeMissing
* PSR2.Classes.PropertyDeclaration.Underscore
* PSR2.Classes.PropertyDeclaration.VarUsed
* PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
* PSR2.ControlStructures.SwitchDeclaration.BreakIndent
* PSR2.Methods.MethodDeclaration.Underscore
* Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace
* Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterOpen
* Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose
* Squiz.Functions.MultiLineFunctionDeclaration.ContentAfterBrace
* Squiz.PHP.DisallowSizeFunctionsInLoops.Found
* Squiz.Scope.MethodScope.Missing
* Squiz.WhiteSpace.SuperfluousWhitespace.EndLine
* Universal.NamingConventions.NoReservedKeywordParameterNames.arrayFound
* Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
* Universal.NamingConventions.NoReservedKeywordParameterNames.parentFound
* Universal.Operators.DisallowStandalonePostIncrementDecrement.PostDecrementFound
* Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
* Universal.Operators.StrictComparisons.LooseEqual
* Universal.Operators.StrictComparisons.LooseNotEqual
* WordPress.Arrays.ArrayKeySpacingRestrictions.TooMuchSpaceAfterKey
* WordPress.DateTime.CurrentTimeTimestamp.Requested
* WordPress.DateTime.RestrictedFunctions.date_date
* WordPress.Files.FileName.NotHyphenatedLowercase
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
* WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
* WordPress.PHP.IniSet.Risky
* WordPress.PHP.PregQuoteDelimiter.Missing
* WordPress.PHP.StrictInArray.MissingTrueStrict
* WordPress.WP.AlternativeFunctions.parse_url_parse_url
* WordPress.WP.AlternativeFunctions.rand_mt_rand
* WordPress.WP.AlternativeFunctions.strip_tags_strip_tag
* WordPress.WP.AlternativeFunctions.strip_tags_strip_tags
* WordPress.WP.Capabilities.Unknown
* WordPress.WP.DeprecatedParameters.Get_termsParam2Found
* WordPress.WP.DeprecatedParameters.Wp_count_termsParam2Found
* WordPress.WP.DiscouragedFunctions.query_posts_query_posts
* WordPress.WP.DiscouragedFunctions.wp_reset_query_wp_reset_query
* WordPress.WP.EnqueuedResourceParameters.NotInFooter
* WordPress.WP.GlobalVariablesOverride.Prohibited
* WordPress.WP.I18n.LowLevelTranslationFunction
This commit includes code formatting changes for the above sniffs.
See #3658.
|
| [7375]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring some MySQL prepare sniffs.
This commit ensures that all SQL is correctly prepared, and that specific queries are tagged to be ignored by PHPCS due to them not using the literal `$wpdb` global as required by the sniffs.
See #3658.
|
| [7377]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring more PHPCS sniffs.
* WordPress.WP.AlternativeFunctions.rand_mt_rand
This commit prefers `wp_rand()` over `mt_rand()` in the Akismet extension.
See #3658.
|
| [7376]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring more PHPCS sniffs.
* Universal.WhiteSpace.CommaSpacing.TooMuchSpaceAfter
* WordPress.Arrays.ArrayIndentation.ItemNotAligned
* WordPress.Arrays.ArrayIndentation.MultiLineArrayItemNotAligned
* WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys
* WordPress.Arrays.ArrayKeySpacingRestrictions.SpacesAroundArrayKeys
* WordPress.Arrays.MultipleStatementAlignment.MultilineItemSpaceBeforeDoubleArrow
* WordPress.Arrays.MultipleStatementAlignment.SpaceBeforeDoubleArrow
This commit includes code formatting changes to pass the above PHPCS checks.
See #3658.
|
| [7374]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine` sniff.
This commit ensures that all arrays with multiple keys & values are not on single lines.
|
| [7373]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `Universal.WhiteSpace.PrecisionAlignment.Found` sniff.
This change removes any precision alignment that used spaces instead of tabs.
|
| [7372]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed` sniff.
This change replaces inline tabs with spaces from a bunch of files where they have crept in over the years.
|
| [7380]
|
johnjamesjacoby
|
Tools - Code Improvement: docs & code formatting improvements.
Props johnjamesjacoby, noruzzaman.
Fixes #3659.
|
| [7371]
|
johnjamesjacoby
|
Tools - Code Improvement: bump PHP & WP versions.
This change bumps the requirements for WordPress to 6.0 and PHP to 7.2, including inside of the PHPCS matrix.
|
| [7359]
|
johnjamesjacoby
|
Tools - Code Improvement: Updates to the `phpcs.xml.dist` config file.
This commit reverts r7358, includes a few new exclusions, and ensures PHPCS has fully passes.
Props johnjamesjacoby, sirlouen.
In trunk, for 2.7.
Fixes #3614.
|
| [7360]
|
johnjamesjacoby
|
Tools - Code Improvement: Updates to the `phpcs.xml.dist` config file.
This commit implements the `WordPress.WP.I18n.MissingTranslatorsComment` code sniff, fixes a bunch of whitespace regressions from #3614 and #3613.
Props johnjamesjacoby, sirlouen.
In trunk, for 2.7.
Fixes #3615.
|
| [7358]
|
johnjamesjacoby
|
Tools - Code Improvement: Updates to the `phpcs.xml.dist` config file.
Props sirlouen.
In trunk, for 2.7.
See #3614.
|
| [7361]
|
johnjamesjacoby
|
Tools - Code Improvement: Document some filters.
This commit improves the code documentation of several filters across the codebase.
Props johnjamesjacoby, narenin, sirlouen.
In trunk, for 2.7.
See #3110.
|
| [7357]
|
johnjamesjacoby
|
Tools - Code Improvement:
This commit modifies several PHP files to strictly adhere to the following PHPCS rules:
* WordPress.WP.I18n.NonSingularStringLiteralText
* WordPress.WP.PostsPerPage.posts_per_page_posts_per_page
* WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceAfterOpenParenthesis
* WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceBeforeCloseParenthesis
* WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterOpenParenthesis
* WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeCloseParenthesis
* WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter
* WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore
* WordPress.WhiteSpace.OperatorSpacing.SpacingAfter
* WordPress.WhiteSpace.OperatorSpacing.SpacingBefore
This commit does not include changes to the phpcs.xml.dist config file to add these rules yet - this will happen in a separate commit.
Props sirlouen.
In trunk, for 2.7.
See #3614.
|
| [7353]
|
johnjamesjacoby
|
Tools - Build: Upgrade Composer, npm, and add wp-env for PHPUnit.
This commit modernizes the dev environment, bringing it up-to-speed with BuddyPress and others.
Props sirlouen.
In trunk, for 2.7.
Fixes #3610.
|
| [7354]
|
johnjamesjacoby
|
Tools - Build: Update package-lock.json.
In trunk, for 2.7.
See r7353. Fixes #3610.
|
| [7355]
|
johnjamesjacoby
|
Tools - Build: Ignore `.phpunit.result.cache`
In trunk, for 2.7.
See r7353.
|
| [6351]
|
netweb
|
Tools - Build: Disable Xdebug on stable builds of PHP when testing on Travis CI.
Hat tip johnbillion.
Fixes #3075.
|
| [7352]
|
johnjamesjacoby
|
Tools - Build: Clean-up PHPCS, and enforce Yoda conditionals.
This commit includes changes to various PHP files, Composer requirements, and PHPCS config, to confirm that the `WordPress.PHP.YodaConditions` code sniff passes.
Props sirlouen.
In trunk, for 2.7.
Fixes #3613.
|
| [2537]
|
mdawaffe
|
To prevent meta duplication from race conditions, replication lag, etc.,
support sites that that choose to add a UNIQUE key to their meta table.
We still need to support sites with the default keys, so
don't get rid of the current if ( get ) { update } else { insert }
just replace it with if ( get ) { update } else { insert on duplicate key update }
|
| [6784]
|
johnjamesjacoby
|
Titles: error if forum/topic/reply title is too long.
This change introduces `bbp_is_title_too_long()` and adds error messages to related forms if titles are too long.
Fixes #3189.
|
| [6881]
|
johnjamesjacoby
|
Titles: add comment about `8bit` mode usage of `mb_strlen()` to provide extra context.
(After looking at this again, I wasn't confident it was correct. It seems to be, given how it's being used.)
See #3189.
|
| [4240]
|
johnjamesjacoby
|
TinyMCE:
* Use teeny-weeny editor to prevent extra buttons from appearing.
* Fixes #1870.
* Props jaredatch.
|
| [4512]
|
johnjamesjacoby
|
TinyMCE:
* Revert textarea output variable, changed during excerpt() sweep.
|
| [4513]
|
johnjamesjacoby
|
TinyMCE:
* Fix tabbing from topic title.
* Hat-tip MZAWeb.
* Fixes #1917.
|
| [4682]
|
johnjamesjacoby
|
Tighten up whitespace on bulk user dropdown to better match WordPress core. Fixes #2145.
|
| [3776]
|
johnjamesjacoby
|
Tidy up the auto-embed options, and fix issue with setting not saving. Fixes #1752.
|
| [5770]
|
johnjamesjacoby
|
Tidy up SVN properties.
* This first steps removes `svn:eol-style`, `svn:executable`, `svn:mime-type` on all files.
* The `svn:ignore` and `svn:global-ignores` properties have been tidied up to match WordPress core.
* A subsequent commit will re-instate `svn:mime-type` via `svn:auto-props`.
Hat-tip DJPaul. See #2802.
|
| [4223]
|
johnjamesjacoby
|
Themes:
* Sunset bbPress (Twenty Ten) theme as included theme.
* Remove code associated with register theme directory.
* Still available in the official theme repository.
* See: http://wordpress.org/extend/themes/bbpress-twenty-ten/
|
| [4225]
|
johnjamesjacoby
|
Themes Compat:
* Move /bbp-theme-compat/ to /bbp-themes/bbp-default/
* Update paths and uri's.
|
| [4224]
|
johnjamesjacoby
|
Themes Compat:
* Move /bbp-theme-compat/ to /bbp-themes/bbp-default/
* Update paths and uri's.
|
| [6578]
|
johnjamesjacoby
|
Theme: Put back vendor prefixes in default template pack styling.
|
| [2550]
|
johnjamesjacoby
|
Theme updates. Introduce template parts. Rename forum front template.
|
| [3281]
|
johnjamesjacoby
|
Theme compat adjustments for user profile edit fieldsets and labels.
|
| [3178]
|
johnjamesjacoby
|
Theme compat CSS tweaks for forms, fieldsets, legends, labels, and inputs.
|
| [3960]
|
johnjamesjacoby
|
Theme Compatilibilty:
* Use trailingslashit() in default styling enqueue.
* See #1849.
|
| [3959]
|
johnjamesjacoby
|
Theme Compatilibilty:
* Add theme hierachy check for default bbPress styling.
* Use file_exists() checks in child & parent themes before enqueuing from theme compatibility.
* Fixes #1849.
|