| [5869]
|
netweb
|
Travis-CI: Include WordPress v4.2 in test matrix
|
| [5402]
|
johnjamesjacoby
|
Travis Updates:
* Switch to a 'shallow' Git clone of the official WordPress Git repo for faster WordPress upstream checkout.
* The addition of the fast_finish: true flag in the build matrix will mark the build passed or errored as soon as a single build job has failed. Previously the build status was not reported until ALL tests had completed regardless of status.
* Moves the 'build configuration' to before_install allowing non-bbPress test configuration to report as errored (MySQL database creation, and WordPress Git checkout etc). When a failure occurs in this section the build is marked as errored which is a more accurate description in that the environment we are setting up has failed and not the actual bbPress tests we are testing.
* Introduces PHP 5.6 and HHVM testing into the build matrix, both of these are allowed to fail in that they will not be included in the overall build job failed, errored, or passed build status. This allows bbPress testing to play nice with these alpha/beta version of PHP/HHVM until stable and officially released.
Props netweb. See #2542.
|
| [6432]
|
johnjamesjacoby
|
Trash: Introduce `bbp_get_trash_days()` helper function.
This will allow the trashability of an object type to be short-circuited, around the `EMPTY_TRASH_DAYS` constant.
|
| [6360]
|
johnjamesjacoby
|
Trash: Cast `_pre_` post-meta values to an array.
Prevents notices & warnings in the event 0 or 1 replies exist.
Props SergeyBiryukov. Fixes #3053.
|
| [6416]
|
netweb
|
Trash: Cast _pre_ post-meta values to an array.
Prevents notices & warnings in the event 0 or 1 replies exist.
Props SergeyBiryukov.
See #3053.
Merges [6360] to the 2.5 branch.
|
| [3388]
|
johnjamesjacoby
|
Translation tweak to form-reply.php. Fixes #1584. Props ramiy.
|
| [2510]
|
chrishajer
|
Translate plugin names and descriptions properly before activation. Fixes #1318. Props Nightgunner5
|
| [4781]
|
johnjamesjacoby
|
Translate get_post_time() when used without humanization. Props alex-ye. Fixes #2222.
|
| [4347]
|
johnjamesjacoby
|
Trailing whitespace clean-up in: includes/admin/
|
| [5930]
|
johnjamesjacoby
|
Topics: sanity check `$_REQUEST` and introduce list-table methods for reply table-navigation.
This changeset fixes a potential debug notice introduced in r5886, and removes unused functionality inherited from `WP_List_Table`.
Fixes #2842. See #2587.
|
| [7479]
|
johnjamesjacoby
|
Topics: preserve forum context during walker refreshes.
Retain the resolved forum ID during a full topic walker refresh so forum freshness and last-post metadata continue to update after topic moderation and user spam or ham transitions.
Merges [7476] to 2.6.
In 2.6, for 2.6.16.
See #3679.
|
| [7476]
|
johnjamesjacoby
|
Topics: preserve forum context during walker refreshes.
Retain the resolved forum ID during a full topic walker refresh so forum freshness and last-post metadata continue to update after topic moderation and user spam or ham transitions.
In trunk, for 2.7.
See #3679.
|
| [6618]
|
johnjamesjacoby
|
Topics: prefer "started" over "created" for default theme verbiage.
|
| [7401]
|
johnjamesjacoby
|
Topics: improve split & merge capability checks.
This commit adjusts topic capability mapping so elevated moderation workflows continue to require moderation privileges, while still allowing forum moderators to perform those actions where appropriate.
In trunk, for 2.7.
Fixes #3667.
|
| [7400]
|
johnjamesjacoby
|
Topics: improve split & merge capability checks.
This commit adjusts topic capability mapping so elevated moderation workflows continue to require moderation privileges, while still allowing forum moderators to perform those actions where appropriate.
In branches/2.6, for 2.6.15.
See #3667.
|
| [6269]
|
johnjamesjacoby
|
Topics: get a fresh value for `redirect_to` when trashing/untrashing/deleting.
Fixes a bug where trashing a topic theme-side would redirect to the prefetched topic URL and 404.
(In the case of trashed topics, since WordPress 4.7, the slug receives a `__trashed` suffix, changing the topic link.)
Fixes #3051.
|
| [7154]
|
johnjamesjacoby
|
Topics: fix not being able to unsticky in certain circumstances.
This commit adds a `bbp_unstick_topic()` call inside of `bbp_update_topic()` where it has been missing since forever.
In trunk, for 2.7. Fixes #3396.
|
| [7153]
|
johnjamesjacoby
|
Topics: fix not being able to unsticky in certain circumstances.
This commit adds a `bbp_unstick_topic()` call inside of `bbp_update_topic()` where it has been missing since forever.
In branches/2.6, for 2.6.6. See #3396.
|
| [5860]
|
johnjamesjacoby
|
Topics: fallback on `post_parent` in `bbp_update_topic_walker()`.
This changeset fixes a bug where forum topic counts were not updated when topics were permanently deleted, causing hidden topic counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [6086]
|
netweb
|
Topics: `@uses` not `@yses` PHPDoc in `bbp_update_topic()`
|
| [5778]
|
netweb
|
Topics: When moving a topic update the topics post parent in `bbp_move_topic_handler()`, includes unit test `test_bbp_move_topic_handler()`
Props netweb. See #2322
|
| [7512]
|
johnjamesjacoby
|
Topics: Validate converted topic titles.
Apply the standard topic-title filter and validation before converting replies into topics through reply moves or topic splits.
This keeps these alternate creation paths consistent with the normal new-topic handler.
This is a backport of [7511] to the 2.6 branch.
In branches/2.6, for 2.6.16.
Props rafiem.
|
| [7511]
|
johnjamesjacoby
|
Topics: Validate converted topic titles.
Apply the standard topic-title filter and validation before converting replies into topics through reply moves or topic splits.
This keeps these alternate creation paths consistent with the normal new-topic handler.
In trunk, for 2.7.
Props rafiem.
|
| [7137]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In trunk, for 2.7.
|
| [7136]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In branches/2.6, for 2.6.6.
|
| [5681]
|
johnjamesjacoby
|
Topics: Use `sanitize_key()` on `select_id` in dropdown helpers.
|
| [5667]
|
netweb
|
Topics: Update `bbp_open_topic()` and `bbp_close_topic()` `@uses` documentation missed in r5656
See #2653
|
| [6099]
|
netweb
|
Topics: Revert [6098]
This doesn't work, on many levels, when testing a patch make sure the patch your testing matches the same site you're testing with.
Antiprops netweb.
See #2587.
|
| [5917]
|
netweb
|
Topics: Return `string` in `bbp_update_forum_last_active_time()`
Includes updated PHPdocs and unit tests for `bbp_update_topic_last_*()` functions.
Props thebrandonallen. See #2811
|
| [6611]
|
johnjamesjacoby
|
Topics: Remove `bbp_get_user_closed_topic_count()`.
This was introduced in the 2.6 cycle to circumvent a problem from using `count_user_posts()`. Now that we're doing a direct query again, this function is no longer used.
See #6610.
|
| [6504]
|
johnjamesjacoby
|
Topics: Redirect to forum when trashing a topic and the user cannot view trash.
Fixes #3111. Props mattrabe.
|
| [5776]
|
netweb
|
Topics: Pass correct array value `post_author` to `bbp_update_topic()` in `bbp_insert_topic()` added in r5775
See #2805
|
| [5674]
|
johnjamesjacoby
|
Topics: Normalize admin links:
* Remove superfluous `(int)` type cast
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
|
| [5682]
|
johnjamesjacoby
|
Topics: Move `is_sticky` functions to above open/closed functions
|
| [6644]
|
johnjamesjacoby
|
Topics: Introduce `bbp_get_non_public_topic_statuses()`
This new function returns the inverse post-statuses of `bbp_get_public_topic_statuses()` with a filter to help target them more specifically in places where it was not previously possible to do so.
See #3128.
|
| [5729]
|
johnjamesjacoby
|
Topics: In `bbp_move_topic_handler()`, clean both old and new forum caches before updating forum hierarchies.
Fixes issue where moving a topic would result in incorrect counts for both forums, due to out-of-date cache values.
Props thebrandonallen. Fixes #2322.
|
| [5738]
|
johnjamesjacoby
|
Topics: Improve type-casting in topic functions.
Props thebrandonallen, netweb. See #2801.
|
| [6385]
|
johnjamesjacoby
|
Topics: Fix recursive call from find/replace. See r6384.
|
| [6244]
|
netweb
|
Topics: Fix misspelled `bbp_get_topic_last_reply_*` filters.
* Update `bbp_get_topic_last_reply_title()` to use `bbp_get_topic_last_reply_title`
* Includes a fallback for any plugins or themes that use `bbp_get_topic_last_topic_title`
* Fix PHPDocs `@uses` PHPDocs for `bbp_get_topic_last_reply_permalink` and `bbp_get_topic_last_reply_url`
Props SergeyBiryukov.
Fixes #3039.
|
| [5669]
|
netweb
|
Topics: Fix missing meta data during new closed topic creation
* In `bbp_new_topic_handler()` check if the post status is `closed` and close using `bbp_close_topic()`
* In `bbp_close_topic()` allow topics to be properly closed if `_bbp_status` is missing from topic meta
Props netweb. Fixes #2653
|
| [6287]
|
johnjamesjacoby
|
Topics: Fix list-table arguments.
* `singular/plural` are not labels
* Set `ajax` to `false` since this does not use ajax
Props mordauk.
|
| [5893]
|
netweb
|
Topics: Fix incorrect PHPDoc references to `bbp_show_lead_topic()` in `bbp_display_topics_feed_rss2()` and `bbp_display_replies_feed_rss2()`
|
| [5811]
|
netweb
|
Topics: Fix `bbp_get_topic_post_date()` default GMT date format copy pasta introduced in r4647, includes unit tests.
Props tobyhawkins. Fixes #2697
|
| [5886]
|
johnjamesjacoby
|
Topics: First pass at metabox for replies in single-topic edit
* Includes `topic-replies` list-table class
* Includes helper functions for hooking things in
* Todo: cap checks or row-actions, maybe bulk-actions, formatting clean-up
See #2842.
|
| [5714]
|
netweb
|
Topics: Filter `bbp_get_topic_reply_count_hidden` to format the output, to match other count functions.
|
| [5709]
|
johnjamesjacoby
|
Topics: Filter `bbp_get_forum_topic_count_hidden` to format the output, to match other count functions.
|
| [5768]
|
netweb
|
Topics: Correct PHPDoc in `bbp_bump_topic_reply_count()` and `bbp_bump_topic_reply_count_hidden()` functions
|
| [5705]
|
johnjamesjacoby
|
Topics: Check for correct `$integer` request value, so the correct filter is applied. Fixes #2791.
|
| [6098]
|
netweb
|
Topics: Call `bbp_move_topic_handler()` when moving a topic to a new forum in the back end.
This changeset ensures that both the source and destination forums meta is updated when a topic is moved.
Fixes #2587.
|
| [6143]
|
johnjamesjacoby
|
Topics: Break apart some lengthy inline conditions. See #3032.
|
| [5680]
|
johnjamesjacoby
|
Topics: Audit `template.php`:
* Add filters to `is_sticky` functions
* Pass `$args` into more filters
* Escape more gettext output
* Fix a few `bbp_parse_args` filter names copied from forums component
* Un-nest a few complex-looking lines
|
| [6362]
|
netweb
|
Topics: Allow `pending` topics to be edited on the front end.
This changeset in `bbp_get_topic_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending topics always have ugly permalinks.
Props SergeyBiryukov.
See #3054.
|
| [5901]
|
johnjamesjacoby
|
Topics: Add `edit_reply` capability check to "Edit" row-action link. See #2842.
|
| [4532]
|
johnjamesjacoby
|
Topics:
* Use correct filter in bbp_current_user_can_publish_topics().
* Props netweb.
* Fixes #2072 (trunk)
|
| [4531]
|
johnjamesjacoby
|
Topics:
* Use correct filter in bbp_current_user_can_publish_topics().
* Props netweb.
* Fixes #2072 (2.2 branch)
|
| [7410]
|
johnjamesjacoby
|
Topics/Replies: prevent anonymous users from editing existing content.
This commit ensures that unauthenticated users cannot edit existing topics or replies, including anonymously authored content. It applies edit capability checks consistently in front-end handlers, and prevents user ID `0` from being treated as a matching post author.
Includes regression tests for capability mapping and direct edit submissions.
In trunk, for 2.7.
|
| [7411]
|
johnjamesjacoby
|
Topics/Replies: prevent anonymous users from editing existing content.
This commit ensures that unauthenticated users cannot edit existing topics or replies, including anonymously authored content. It applies edit capability checks consistently in front-end handlers, and prevents user ID `0` from being treated as a matching post author.
Includes regression tests for capability mapping and direct edit submissions.
In branches/2.6, for 2.6.15.
|
| [6931]
|
johnjamesjacoby
|
Topics/Replies: improved support for replies without topics.
This commit removes an assumptive call to `bbp_get_topic()` and avoids a debug notice when a reply is orphaned.
See #3226.
|
| [7362]
|
johnjamesjacoby
|
Topics/Replies: Add CSS class for user roles in topics/replies.
This commit improves the ability target specific author roles anywhere single topic or reply author meta is shown.
Props douglsmith, mikachan, netweb, robinwpdeveloper, rudlinkon, sirlouen.
In trunk, for 2.7.
Fixes #2692.
|
| [2834]
|
johnjamesjacoby
|
Topics widget should not show stickies out of order.
|
| [7349]
|
johnjamesjacoby
|
Topics - Template: Add missing output condition where voice count is 0 but last-activity exists.
This change fixes a bug where topics created by anonymous users would show the "This topic is empty" fallback text in the topic description, when the topic was obviously not empty.
In trunk, for 2.7.
Fixes #3652.
|
| [6290]
|
johnjamesjacoby
|
Topic: update phpdoc for `bbp_get_topic_last_reply_id()` and `bbp_get_topic_last_active_time()`.
Props SergeyBiryukov. Fixes #3060.
|
| [7255]
|
johnjamesjacoby
|
Topic/Reply: improvements to status updates.
This change includes 2 fixes:
* Prefer `$topic_id` over `$topic->ID`, and use it (instead of `$forum_id`) when checking for moderation capability
* Add missing logic in `bbp_edit_reply_handler()` that was preventing statuses from saving as intended
See #2644.
In branches/2.6, for 2.6.10.
|
| [4562]
|
johnjamesjacoby
|
Topic/Reply admin links:
* Add filters to links arrays.
* Props mordauk.
* Fixes #2090.
|
| [3101]
|
johnjamesjacoby
|
Topic tags are now self policing. Previously any member could add topic tags but only moderators could remove them. Also save reply form values if error occurs while posting a reply. Fixes #1466. Props cnorris23 for original patch.
|
| [3348]
|
johnjamesjacoby
|
Topic tag audit. Split topic tag edit form into its own template file. Rename the topic_tag_id global to topic_tag_tax_id. Add missing topic tag template tags and functions.
|
| [4970]
|
johnjamesjacoby
|
Topic and reply admin links don't work correctly from search results pages yet, so remove the output and logic from default template parts.
|
| [4124]
|
johnjamesjacoby
|
Topic and Reply Widgets:
* Add 'show_user' option, to toggle display of user and Avatar.
* Update reply widget to use time_since.
* Fixes #1903.
* Props jaredatch.
|
| [4255]
|
johnjamesjacoby
|
Topic and Reply Editing:
* Fix issue with "Edit" admin links having 'view=all' argument incorrectly positioned.
* Fix issue with post_status being set back to public when editing.
* Conditionally set post_status to pending if needs moderation.
* Fixes #1977.
|
| [6930]
|
johnjamesjacoby
|
Topic Views: pass view ID into body class.
This commit does a quick audit of Topic View API functions, and ensures their return values are as documented. This allows for safely adding the Topic View ID as a class to the body element of the page when viewing a single Topic View.
Fixes #3278. Props Clorith.
|
| [7212]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In trunk, for 2.7.
Fixes #3438.
|
| [7211]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In branches/2.6, for 2.6.7.
See #3438.
|
| [3950]
|
johnjamesjacoby
|
Topic Views:
* Prevent possible byref object errors in bbp_register_view().
|
| [6453]
|
johnjamesjacoby
|
Topic Tags: set `is_archive` to `true` when viewing a topic tag archive.
Fixes #3071.
|
| [6884]
|
johnjamesjacoby
|
Topic Tags: remove extraneous `span` tag from topic-tag titles when theme-compat is employed.
This change removes a `span` tag that was originally required before support for topic-tag-edit templates was added.
Props mechter. Fixes #3236.
|
| [6450]
|
johnjamesjacoby
|
Topic Tags: When deleting a topic tag, redirect to the forum root.
`home_url()` was a bit too jarring; no one expects to get kicked out of the forums entirely.
|
| [7510]
|
johnjamesjacoby
|
Topic Tags: Prevent unauthorized tag removal.
Introduce a per-topic, per-tag `remove_topic_tag` meta capability and preserve topic tags a user cannot remove when processing topic and reply forms. This prevents anonymous submissions from clearing existing tags while preserving current behavior for participants and moderators.
This backport also restores anonymous read capability mapping for public forum content so enabled guest posting continues through the current reply handler checks.
In branches/2.6, for 2.6.16.
Props nomadsyndiode.
|
| [7509]
|
johnjamesjacoby
|
Topic Tags: Prevent unauthorized tag removal.
Introduce a per-topic, per-tag `remove_topic_tag` meta capability and preserve topic tags a user cannot remove when processing topic and reply forms. This prevents anonymous submissions from clearing existing tags while preserving current behavior for participants and moderators.
In trunk, for 2.7.
Props nomadsyndiode.
|
| [6254]
|
johnjamesjacoby
|
Topic Tags: Introduce `bbp_update_topic_tag_count()` and include public/closed statuses in counts.
Fixes #3043.
|
| [7465]
|
johnjamesjacoby
|
Topic Tags: Escape names before template output.
This change hardens all current topic-tag name presentation contexts, including copied template overrides, by applying HTML escaping through the existing getter filter. It preserves extension behavior at the standard filter priority and avoids double-encoding stored entities.
In trunk, for 2.7.
Props faran66.
|
| [7466]
|
johnjamesjacoby
|
Topic Tags: Escape names before template output.
This change hardens all current topic-tag name presentation contexts, including copied template overrides, by applying HTML escaping through the existing getter filter. It preserves extension behavior at the standard filter priority and avoids double-encoding stored entities.
In 2.6, for 2.6.16.
Props faran66.
|
| [6720]
|
johnjamesjacoby
|
Topic Tags: Check for post ID when checking `assign_topic_tags`.
This change adds a fallback value for the standard `assign_terms` capability check, and fixes a few test errors introduced in r6714.
|
| [4166]
|
johnjamesjacoby
|
Topic Tags:
* When posting a topic or reply, check that user can assign tags to topics.
* If user cannot assign tags, and topic-tag value is not set, use existing topic tags.
|
| [4099]
|
johnjamesjacoby
|
Topic Tags:
* Use correct setting key in settings field registration array.
* See #1806.
|
| [4098]
|
johnjamesjacoby
|
Topic Tags:
* First pass to allow topic tags to be globally disabled.
* Handles toggling the UI in template parts and admin area.
* Props jaredatch.
* Fixes #1806.
|
| [4217]
|
johnjamesjacoby
|
Topic Tags:
* Change shortcode ID for single topic tags.
* Update topic tag theme compat code to ensure topic-tag edit form works where needed.
|
| [4461]
|
johnjamesjacoby
|
Topic Suggest:
* Only output topic suggest JS if on reply new/edit page.
* Fixes #1990 (trunk)
|
| [4460]
|
johnjamesjacoby
|
Topic Suggest:
* Only output topic suggest JS if on reply new/edit page.
* Fixes #1990 (2.2 branch)
|
| [4103]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, make sure the new topic has menu_position 1.
|
| [4097]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, calculate new reply positions.
* Set last active ID to last reply ID.
* Update last reply and active ID/time of source topic.
* Fixes #1898.
* For 2.2 branch.
|
| [4096]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, calculate new reply positions.
* Set last active ID to last reply ID.
* Update last reply and active ID/time of source topic.
* Fixes #1898.
* For 2.1 branch.
|
| [4362]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic off into an existing topic, use the same kludge from topic-merge, and rejig the post_date by 1 second.
* This keeps topics and replies in the correct order after splitting part of a topic, into another topic.
* Props jmdodd.
* Fixes #2015.
|
| [4084]
|
johnjamesjacoby
|
Topic Forms:
* Fix topic textarea label in theme-compat and twenty-ten.
* For 2.1.1
|
| [4116]
|
johnjamesjacoby
|
Topic Actions:
* Remove old bbpress() call in bbp_trash_topic() from r4114.
* See #1913.
* For 2.1 branch.
|
| [4115]
|
johnjamesjacoby
|
Topic Actions:
* Remove bbp_has_replies() from topic trash and topic delete functions.
* Use WP_Query's instead.
* Fixes #1913.
* For 2.2 branch.
|
| [4114]
|
johnjamesjacoby
|
Topic Actions:
* Remove bbp_has_replies() from topic trash and topic delete functions.
* Use WP_Query's instead.
* Fixes #1913.
* For 2.1 branch.
|
| [6927]
|
johnjamesjacoby
|
Tools: wrap routine descriptions in a description paragraph tag.
This commit ensures that the descriptive text used to highlight what a specific tool does does not blend in with the title above it.
Fixes #3277. Props JarretC.
|
| [7283]
|
johnjamesjacoby
|
Tools: update npm packages for Grunt tasks.
This change:
* swaps in `terser` & `@wordpress/stylelint-config`
* updates stylelint to 15.11.0 (with `scss` support)
* adds separate stylelint config files for both CSS and SCSS (and deletes the original auto-loaded `.stylelintrc` file)
This is just enough to get Grunt unclogged and working again without complaining too much.
----
To make this work:
* Recommend to install NVM to make using npm 18 easier
* `nvm use 18`
* `npm install --legacy-peer-deps --save-dev`
Once complete, the various `grunt` CLI commands should work again without any problems (for now!)
|
| [6882]
|
johnjamesjacoby
|
Tools: update npm package dependencies.
|
| [7431]
|
johnjamesjacoby
|
Tools: update 2.6 builds and contributor guidance.
Replace node-sass with Dart Sass, recommend Node 24, and add version checks and an installed-ZIP smoke test for 2.6. Preserve existing browser prefixes and hexadecimal admin colors. Add contributor and repository guidance that matches the 2.6 setup.
Keep dependency updates and deployment automation on trunk. These changes do not alter bbPress runtime requirements or existing release tags.
In 2.6, for 2.6.16.
|
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
