| [7137]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In trunk, for 2.7.
|
| [7136]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In branches/2.6, for 2.6.6.
|
| [5681]
|
johnjamesjacoby
|
Topics: Use `sanitize_key()` on `select_id` in dropdown helpers.
|
| [5667]
|
netweb
|
Topics: Update `bbp_open_topic()` and `bbp_close_topic()` `@uses` documentation missed in r5656
See #2653
|
| [6099]
|
netweb
|
Topics: Revert [6098]
This doesn't work, on many levels, when testing a patch make sure the patch your testing matches the same site you're testing with.
Antiprops netweb.
See #2587.
|
| [5917]
|
netweb
|
Topics: Return `string` in `bbp_update_forum_last_active_time()`
Includes updated PHPdocs and unit tests for `bbp_update_topic_last_*()` functions.
Props thebrandonallen. See #2811
|
| [6611]
|
johnjamesjacoby
|
Topics: Remove `bbp_get_user_closed_topic_count()`.
This was introduced in the 2.6 cycle to circumvent a problem from using `count_user_posts()`. Now that we're doing a direct query again, this function is no longer used.
See #6610.
|
| [6504]
|
johnjamesjacoby
|
Topics: Redirect to forum when trashing a topic and the user cannot view trash.
Fixes #3111. Props mattrabe.
|
| [5776]
|
netweb
|
Topics: Pass correct array value `post_author` to `bbp_update_topic()` in `bbp_insert_topic()` added in r5775
See #2805
|
| [5674]
|
johnjamesjacoby
|
Topics: Normalize admin links:
* Remove superfluous `(int)` type cast
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
|
| [5682]
|
johnjamesjacoby
|
Topics: Move `is_sticky` functions to above open/closed functions
|
| [6644]
|
johnjamesjacoby
|
Topics: Introduce `bbp_get_non_public_topic_statuses()`
This new function returns the inverse post-statuses of `bbp_get_public_topic_statuses()` with a filter to help target them more specifically in places where it was not previously possible to do so.
See #3128.
|
| [5729]
|
johnjamesjacoby
|
Topics: In `bbp_move_topic_handler()`, clean both old and new forum caches before updating forum hierarchies.
Fixes issue where moving a topic would result in incorrect counts for both forums, due to out-of-date cache values.
Props thebrandonallen. Fixes #2322.
|
| [5738]
|
johnjamesjacoby
|
Topics: Improve type-casting in topic functions.
Props thebrandonallen, netweb. See #2801.
|
| [6385]
|
johnjamesjacoby
|
Topics: Fix recursive call from find/replace. See r6384.
|
| [6244]
|
netweb
|
Topics: Fix misspelled `bbp_get_topic_last_reply_*` filters.
* Update `bbp_get_topic_last_reply_title()` to use `bbp_get_topic_last_reply_title`
* Includes a fallback for any plugins or themes that use `bbp_get_topic_last_topic_title`
* Fix PHPDocs `@uses` PHPDocs for `bbp_get_topic_last_reply_permalink` and `bbp_get_topic_last_reply_url`
Props SergeyBiryukov.
Fixes #3039.
|
| [5669]
|
netweb
|
Topics: Fix missing meta data during new closed topic creation
* In `bbp_new_topic_handler()` check if the post status is `closed` and close using `bbp_close_topic()`
* In `bbp_close_topic()` allow topics to be properly closed if `_bbp_status` is missing from topic meta
Props netweb. Fixes #2653
|
| [6287]
|
johnjamesjacoby
|
Topics: Fix list-table arguments.
* `singular/plural` are not labels
* Set `ajax` to `false` since this does not use ajax
Props mordauk.
|
| [5893]
|
netweb
|
Topics: Fix incorrect PHPDoc references to `bbp_show_lead_topic()` in `bbp_display_topics_feed_rss2()` and `bbp_display_replies_feed_rss2()`
|
| [5811]
|
netweb
|
Topics: Fix `bbp_get_topic_post_date()` default GMT date format copy pasta introduced in r4647, includes unit tests.
Props tobyhawkins. Fixes #2697
|
| [5886]
|
johnjamesjacoby
|
Topics: First pass at metabox for replies in single-topic edit
* Includes `topic-replies` list-table class
* Includes helper functions for hooking things in
* Todo: cap checks or row-actions, maybe bulk-actions, formatting clean-up
See #2842.
|
| [5714]
|
netweb
|
Topics: Filter `bbp_get_topic_reply_count_hidden` to format the output, to match other count functions.
|
| [5709]
|
johnjamesjacoby
|
Topics: Filter `bbp_get_forum_topic_count_hidden` to format the output, to match other count functions.
|
| [5768]
|
netweb
|
Topics: Correct PHPDoc in `bbp_bump_topic_reply_count()` and `bbp_bump_topic_reply_count_hidden()` functions
|
| [5705]
|
johnjamesjacoby
|
Topics: Check for correct `$integer` request value, so the correct filter is applied. Fixes #2791.
|
| [6098]
|
netweb
|
Topics: Call `bbp_move_topic_handler()` when moving a topic to a new forum in the back end.
This changeset ensures that both the source and destination forums meta is updated when a topic is moved.
Fixes #2587.
|
| [6143]
|
johnjamesjacoby
|
Topics: Break apart some lengthy inline conditions. See #3032.
|
| [5680]
|
johnjamesjacoby
|
Topics: Audit `template.php`:
* Add filters to `is_sticky` functions
* Pass `$args` into more filters
* Escape more gettext output
* Fix a few `bbp_parse_args` filter names copied from forums component
* Un-nest a few complex-looking lines
|
| [6362]
|
netweb
|
Topics: Allow `pending` topics to be edited on the front end.
This changeset in `bbp_get_topic_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending topics always have ugly permalinks.
Props SergeyBiryukov.
See #3054.
|
| [5901]
|
johnjamesjacoby
|
Topics: Add `edit_reply` capability check to "Edit" row-action link. See #2842.
|
| [4532]
|
johnjamesjacoby
|
Topics:
* Use correct filter in bbp_current_user_can_publish_topics().
* Props netweb.
* Fixes #2072 (trunk)
|
| [4531]
|
johnjamesjacoby
|
Topics:
* Use correct filter in bbp_current_user_can_publish_topics().
* Props netweb.
* Fixes #2072 (2.2 branch)
|
| [6931]
|
johnjamesjacoby
|
Topics/Replies: improved support for replies without topics.
This commit removes an assumptive call to `bbp_get_topic()` and avoids a debug notice when a reply is orphaned.
See #3226.
|
| [2834]
|
johnjamesjacoby
|
Topics widget should not show stickies out of order.
|
| [6290]
|
johnjamesjacoby
|
Topic: update phpdoc for `bbp_get_topic_last_reply_id()` and `bbp_get_topic_last_active_time()`.
Props SergeyBiryukov. Fixes #3060.
|
| [7255]
|
johnjamesjacoby
|
Topic/Reply: improvements to status updates.
This change includes 2 fixes:
* Prefer `$topic_id` over `$topic->ID`, and use it (instead of `$forum_id`) when checking for moderation capability
* Add missing logic in `bbp_edit_reply_handler()` that was preventing statuses from saving as intended
See #2644.
In branches/2.6, for 2.6.10.
|
| [4562]
|
johnjamesjacoby
|
Topic/Reply admin links:
* Add filters to links arrays.
* Props mordauk.
* Fixes #2090.
|
| [3101]
|
johnjamesjacoby
|
Topic tags are now self policing. Previously any member could add topic tags but only moderators could remove them. Also save reply form values if error occurs while posting a reply. Fixes #1466. Props cnorris23 for original patch.
|
| [3348]
|
johnjamesjacoby
|
Topic tag audit. Split topic tag edit form into its own template file. Rename the topic_tag_id global to topic_tag_tax_id. Add missing topic tag template tags and functions.
|
| [4970]
|
johnjamesjacoby
|
Topic and reply admin links don't work correctly from search results pages yet, so remove the output and logic from default template parts.
|
| [4124]
|
johnjamesjacoby
|
Topic and Reply Widgets:
* Add 'show_user' option, to toggle display of user and Avatar.
* Update reply widget to use time_since.
* Fixes #1903.
* Props jaredatch.
|
| [4255]
|
johnjamesjacoby
|
Topic and Reply Editing:
* Fix issue with "Edit" admin links having 'view=all' argument incorrectly positioned.
* Fix issue with post_status being set back to public when editing.
* Conditionally set post_status to pending if needs moderation.
* Fixes #1977.
|
| [6930]
|
johnjamesjacoby
|
Topic Views: pass view ID into body class.
This commit does a quick audit of Topic View API functions, and ensures their return values are as documented. This allows for safely adding the Topic View ID as a class to the body element of the page when viewing a single Topic View.
Fixes #3278. Props Clorith.
|
| [7212]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In trunk, for 2.7.
Fixes #3438.
|
| [7211]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In branches/2.6, for 2.6.7.
See #3438.
|
| [3950]
|
johnjamesjacoby
|
Topic Views:
* Prevent possible byref object errors in bbp_register_view().
|
| [6453]
|
johnjamesjacoby
|
Topic Tags: set `is_archive` to `true` when viewing a topic tag archive.
Fixes #3071.
|
| [6884]
|
johnjamesjacoby
|
Topic Tags: remove extraneous `span` tag from topic-tag titles when theme-compat is employed.
This change removes a `span` tag that was originally required before support for topic-tag-edit templates was added.
Props mechter. Fixes #3236.
|
| [6450]
|
johnjamesjacoby
|
Topic Tags: When deleting a topic tag, redirect to the forum root.
`home_url()` was a bit too jarring; no one expects to get kicked out of the forums entirely.
|
| [6254]
|
johnjamesjacoby
|
Topic Tags: Introduce `bbp_update_topic_tag_count()` and include public/closed statuses in counts.
Fixes #3043.
|
| [6720]
|
johnjamesjacoby
|
Topic Tags: Check for post ID when checking `assign_topic_tags`.
This change adds a fallback value for the standard `assign_terms` capability check, and fixes a few test errors introduced in r6714.
|
| [4166]
|
johnjamesjacoby
|
Topic Tags:
* When posting a topic or reply, check that user can assign tags to topics.
* If user cannot assign tags, and topic-tag value is not set, use existing topic tags.
|
| [4099]
|
johnjamesjacoby
|
Topic Tags:
* Use correct setting key in settings field registration array.
* See #1806.
|
| [4098]
|
johnjamesjacoby
|
Topic Tags:
* First pass to allow topic tags to be globally disabled.
* Handles toggling the UI in template parts and admin area.
* Props jaredatch.
* Fixes #1806.
|
| [4217]
|
johnjamesjacoby
|
Topic Tags:
* Change shortcode ID for single topic tags.
* Update topic tag theme compat code to ensure topic-tag edit form works where needed.
|
| [4461]
|
johnjamesjacoby
|
Topic Suggest:
* Only output topic suggest JS if on reply new/edit page.
* Fixes #1990 (trunk)
|
| [4460]
|
johnjamesjacoby
|
Topic Suggest:
* Only output topic suggest JS if on reply new/edit page.
* Fixes #1990 (2.2 branch)
|
| [4103]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, make sure the new topic has menu_position 1.
|
| [4097]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, calculate new reply positions.
* Set last active ID to last reply ID.
* Update last reply and active ID/time of source topic.
* Fixes #1898.
* For 2.2 branch.
|
| [4096]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic, calculate new reply positions.
* Set last active ID to last reply ID.
* Update last reply and active ID/time of source topic.
* Fixes #1898.
* For 2.1 branch.
|
| [4362]
|
johnjamesjacoby
|
Topic Split:
* When splitting a topic off into an existing topic, use the same kludge from topic-merge, and rejig the post_date by 1 second.
* This keeps topics and replies in the correct order after splitting part of a topic, into another topic.
* Props jmdodd.
* Fixes #2015.
|
| [4084]
|
johnjamesjacoby
|
Topic Forms:
* Fix topic textarea label in theme-compat and twenty-ten.
* For 2.1.1
|
| [4116]
|
johnjamesjacoby
|
Topic Actions:
* Remove old bbpress() call in bbp_trash_topic() from r4114.
* See #1913.
* For 2.1 branch.
|
| [4115]
|
johnjamesjacoby
|
Topic Actions:
* Remove bbp_has_replies() from topic trash and topic delete functions.
* Use WP_Query's instead.
* Fixes #1913.
* For 2.2 branch.
|
| [4114]
|
johnjamesjacoby
|
Topic Actions:
* Remove bbp_has_replies() from topic trash and topic delete functions.
* Use WP_Query's instead.
* Fixes #1913.
* For 2.1 branch.
|
| [6927]
|
johnjamesjacoby
|
Tools: wrap routine descriptions in a description paragraph tag.
This commit ensures that the descriptive text used to highlight what a specific tool does does not blend in with the title above it.
Fixes #3277. Props JarretC.
|
| [7283]
|
johnjamesjacoby
|
Tools: update npm packages for Grunt tasks.
This change:
* swaps in `terser` & `@wordpress/stylelint-config`
* updates stylelint to 15.11.0 (with `scss` support)
* adds separate stylelint config files for both CSS and SCSS (and deletes the original auto-loaded `.stylelintrc` file)
This is just enough to get Grunt unclogged and working again without complaining too much.
----
To make this work:
* Recommend to install NVM to make using npm 18 easier
* `nvm use 18`
* `npm install --legacy-peer-deps --save-dev`
Once complete, the various `grunt` CLI commands should work again without any problems (for now!)
|
| [6882]
|
johnjamesjacoby
|
Tools: update npm package dependencies.
|
| [6935]
|
johnjamesjacoby
|
Tools: reduce the number of calls to `bbp_is_large_install()`.
This commit refactors the update code to only call `bbp_is_large_install()` once, a function which ironically enough is costly to call on very large installations, so calling it 3 times defeats the purpose, but calling it one time is the minimum requirement to defer upgrades & repairs for keymaster interaction.
See #3052.
|
| [6668]
|
johnjamesjacoby
|
Tools: include users with "unexpected" roles in `bbp_admin_repair_user_roles()`
This change makes sure that if a user has an unexpectedly missing or predictably broken role entry, they are still mapped to the `$default_role` for the current site, and fixes a problem with the role repair tool where users with the most broken roles were still never actually repaired.
Trunk, for 2.6.
|
| [6851]
|
johnjamesjacoby
|
Tools: bump package-lock.json.
|
| [7216]
|
johnjamesjacoby
|
Tools: bring .gitignore up to speed.
This change merges similar ignore patterns from BuddyPress and WordPress.
|
| [6934]
|
johnjamesjacoby
|
Tools: allow repairs to also be pending.
This commit makes Repairs work like Upgrades, allowing for repair tools to also be pending. It adds a $type parameter to a few functions to allow grouping or separating, depending on the count context.
See #3052.
|
| [6664]
|
johnjamesjacoby
|
Tools: add optional `description` text to upgrade & repair tools.
This change hopefully adds some real-world context to otherwise mysterious functionality, in an attempt to better explain why any specific routine should be run vs. any others.
Trunk, for 2.6. See #3149.
|
| [6393]
|
johnjamesjacoby
|
Tools: User `and` over `&` for easier translation.
Props casiepa. Fixes #3096.
|
| [5988]
|
netweb
|
Tools: Use updated meta key `_bbp_old_user_id` to determine imported users in `bbp_admin_reset_handler()`
This changeset updates the meta key used to determine an imported user for handling the deletion of imported users in the reset forums tool, this should have originally been included in r5530 but was missed.
See #2650
|
| [6276]
|
johnjamesjacoby
|
Tools: Use new `bbp_get_tools_admin_pages()` function when removing mock admin-pages.
Fixes bug where third-party tools pages would not get removed.
|
| [6513]
|
johnjamesjacoby
|
Tools: Use escaping gettext functions in admin area Reset Tool.
|
| [6189]
|
johnjamesjacoby
|
Tools: Use `get_results()`, and don't delete usermeta.
(Maybe we should have a separate clean-up tool once it's confirmed to be OK.)
See #2959.
|
| [6181]
|
johnjamesjacoby
|
Tools: Use `explode()` instead of `maybe_unserialize()`.
User-meta values were strings to enable `FIND_IN_SET()` usages.
See #2959.
|
| [6593]
|
johnjamesjacoby
|
Tools: Use `delete_metadata()` to remove favs & subs without a `foreach` loop.
|
| [5899]
|
johnjamesjacoby
|
Tools: Use `_admin_search_query()`. See #2841.
|
| [6175]
|
johnjamesjacoby
|
Tools: Use `$total` count in `bbp_admin_migrate_user_favorites()`.
Also update revision number in function docs.
See #2959.
|
| [6177]
|
johnjamesjacoby
|
Tools: Update tools text to include favorites & subscriptions.
See #2959.
|
| [5963]
|
netweb
|
Tools: Update the `priority` array values of individual repair tools in `bbp_register_default_repair_tools()`
This changeset fixes an issue where the `bbp_admin_repair_topic_meta()` repair tool was not included in the list table.
Props netweb, thebrandonallen.
Fixes #2859.
|
| [6278]
|
johnjamesjacoby
|
Tools: Update some reset text in `bbp_admin_reset_page()`.
|
| [6178]
|
johnjamesjacoby
|
Tools: Update forum/topic/reply admin classes to avoid screens without `post_type` parameters.
Fixes edge-case debug notices when tools pages for third-party plugins are doing advanced things.
See #2959.
|
| [6286]
|
johnjamesjacoby
|
Tools: Update file paths for tools unit tests.
Props thebrandonallen. Fixes #3056.
|
| [5913]
|
netweb
|
Tools: Update `grunt-contrib-cssmin` to v0.13.0
Changelog: https://github.com/gruntjs/grunt-contrib-cssmin/compare/v0.11.0...v0.13.0
Testing `grunt cssmin` and related bbPress Grunt tasks show no issues with `grunt-contrib-cssmin`
Note: Requires `npm install` to update dependencies
See #2738
|
| [6473]
|
johnjamesjacoby
|
Tools: Update `Gruntfile.js` with new admin assets directory.
|
| [6796]
|
johnjamesjacoby
|
Tools: Update Editor Configuration.
This change removes some file-types and stops trimming whitespace from markdown files.
Fixes #3197. Props netweb.
|
| [5885]
|
johnjamesjacoby
|
Tools: Update "Repair Tools" to use a list-table UI:
* Includes helper functions for: search, filtering, and bulk actions
* Improves tool registration by including strings and feedback into an array stored in `bbpress()->admin->tools`
* Introduces "Overhead" property for alerting Key Masters to the performance impact running each tool
* Introduces "Components" properties for identifying which counts what tools are intersecting
* Todo: use a `WP_List_Table` subclass (which bbPress has avoided needing until now)
See #2841.
|
| [6274]
|
johnjamesjacoby
|
Tools: Unify the tab/link experience:
* Introduce function to get tools pages
* Trust capability checks in core WordPress functions, and remove our own bespoke pre-checks
* Add tool-box to `wp-admin/tools.php` linking to tools the user has access to
This change promotes exposure to bbPress's tools pages, and makes adding third-party tools pages easier.
See: #2959.
|
| [5958]
|
netweb
|
Tools: Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds
PHP 7 was released today, congratulations to everyone involved in the release :)
Props netweb.
Fixes #2895.
|
| [5959]
|
netweb
|
Tools: Travis CI: Only test PHP 7 against WordPress 4.3 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7 compatability, which was only added in version 4.3 so lets not let those errors in versions before 4.3 bother us ;)
See #2895.
|
| [6005]
|
netweb
|
Tools: Travis CI The Matrix Reloaded
'''The Architect''': ''The first matrix I designed was quite naturally perfect. It was a work of art. Flawless. Sublime. A triumph only equaled by its monumental failure.''
|
| [6281]
|
johnjamesjacoby
|
Tools: Separate `wp_usermeta` clean-up from database upgrade routines.
Clean-up should be run after upgrades, not during. This way all results can be verified by the admin.
See #3052.
|
| [6091]
|
netweb
|
Tools: Running the "Reset Forums" tool now deletes bbPress' custom post type revisions from the database.
This changeset adds support for deleting forum, topic, and reply post types revisions to `bbp_admin_reset_handler()`.
Fixes #2945.
|
| [6002]
|
netweb
|
Tools: Return unique message strings in `bbp_admin_reset_handler()` when deleting imported users and user meta vs non-imported user meta.
Fixes #2928.
|
| [6277]
|
johnjamesjacoby
|
Tools: Rename page functions with `_page()` suffix.
Previous function names were more ambiguous than intended, and because these functions are only called internally, there is no harm in renaming them.
|