| [5654]
|
netweb
|
Akismet: Pass additional user and post information to Aksimet helping identify suspicious new posts
* `comment_total`: Total user posts via `bbp_get_user_post_count()`
* `comment_last_active_gmt`: Topic last active time via `bbp_get_topic_last_reply_id()`
* `comment_account_registered_gmt`: User registered via `$userdata->user_registered`
Props eoigal. Fixes #2591
|
| [6225]
|
johnjamesjacoby
|
Akismet: Improve translatability of update-history strings.
Fixes #3011. Props SergeyBiryukov.
|
| [6226]
|
johnjamesjacoby
|
Akismet: Improve translatability of "(+ %d hidden)" strings.
Fixes #3009. Props SergeyBiryukov.
|
| [6227]
|
johnjamesjacoby
|
Akismet: Improve pluralization of statistics strings.
Fixes #2960. Props thebrandonallen, netweb.
|
| [5828]
|
johnjamesjacoby
|
Akismet: Clean up potential accidental inline assignment in `BBP_Akismet::check_post()`.
This commit moves a variable assignment out of a comparison to improve code clarity.
|
| [4243]
|
johnjamesjacoby
|
Akismet:
* Set a default message if there is no response from Akismet servers.
* Prevents debug notices and polluted Akismet results in post meta.
|
| [4017]
|
johnjamesjacoby
|
Akismet:
* Run topic and reply edits through Akismet, to thwart editing spam during the edit window.
* Fixes #1860.
|
| [4042]
|
johnjamesjacoby
|
Akismet:
* Pass additional post information on topic/reply edit, to prevent Akismet from nooping it.
* Revert part of r4041; put actions back before bbp_is_error() calls.
* Replace some missing revision numbers.
* Fixes #1869.
|
| [4813]
|
johnjamesjacoby
|
Akismet:
* Introduce and use improved BBP_Akismet::get_user_roles() method.
* Includes proper type-casting, cleaner logic, and allows for easier dynamic role debugging.
|
| [4091]
|
johnjamesjacoby
|
Akismet:
* Check response before assigning value.
* Fix bug with Akismet request faliing.
|
| [3939]
|
johnjamesjacoby
|
Akismet
* Allow $post_data to be manipulated in BBP_Akismet::check_post().
* This opens the door to overriding the Akismet result based on any other criteria later (for third party plugins.)
|
| [6755]
|
johnjamesjacoby
|
Ajax: send a proper `400` response when nothing happens.
This change adds nocache and noindex headers to theme-side AJAX handling, adds support for pre-sanitized `$action` parameters, and checks that the action-hook actually has actions hooked to it before attempting to execute it.
Similar to `admin-ajax.php` a `400` response is now returned when an AJAX request is attempted that does not have a handler.
|
| [6758]
|
johnjamesjacoby
|
Ajax: introduce `bbp_ajax_headers()` abstracted from `bbp_do_ajax()`.
This change makes it possible to send the proper & expected headers in custom theme-side AJAX implementations.
|
| [6581]
|
johnjamesjacoby
|
Ajax: in `bbp_do_ajax()` use `wp_die()` instead of `die()` so any custom handlers are used.
|
| [4511]
|
johnjamesjacoby
|
Ajax:
* Remove call to wpList.process().
* Fixes duplicate ajax requests on topic subscriptions and favorites.
* Props MZAWeb.
* Fixes #1905 for !WordPress 3.4.
|
| [5509]
|
johnjamesjacoby
|
Administrative support for un/approving replies. Props netweb. See #2645.
|
| [5583]
|
johnjamesjacoby
|
Administrative support for for un/approving topics.
Props netweb, thebrandonallen. Fixes #2645.
|
| [7171]
|
johnjamesjacoby
|
Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In trunk for 2.7.0. See #3311.
|
| [7172]
|
johnjamesjacoby
|
Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In branches/2.6 for 2.6.7. Fixes #3311.
|
| [6234]
|
netweb
|
Administration: Second pass updating contributors and props list for 2.6 release.
|
| [6235]
|
netweb
|
Administration: Remove duplicate props entry for 2.6 release.
|
| [6052]
|
netweb
|
Administration: Only display bbPress users role in bbPress' "Forum Role" list
Since WordPress 4.4 users with multiple roles are displayed in WordPress' "Site Role" list, this changeset ensures bbPress' roles are only displayed under the "Forum Role" list and not duplicated in the "Site Role" list of the users list table.
Props johnbillion, tharsheblows for initial patches
Fixes #2874
|
| [6233]
|
netweb
|
Administration: Initial pass updating contributors and props list for 2.6 release.
|
| [6773]
|
johnjamesjacoby
|
Admin: update some inline docs from r6772.
|
| [6775]
|
johnjamesjacoby
|
Admin: update forum/topic/reply toggle notices to use `bbp_admin()->add_notice()`.
This changes the source hooks so notices are created earlier (and not just-in-time as toggles occur.) It also introduces an `esc_notice()` method to restrict the allowed HTML tags in notice messages down to a very finite set (completely avoiding all types of hi-jacks at a lower level.)
|
| [6776]
|
johnjamesjacoby
|
Admin: update `esc_notice()` usage to map `WP_Error` content. See r6775.
|
| [6750]
|
johnjamesjacoby
|
Admin: split reset handler into 2 functions (handler and logic)
This change improves compatibility with future WP CLI initiatives, specifically allowing removing all bbPress data.
Fixes #3173. Props espellcaste.
|
| [6709]
|
johnjamesjacoby
|
Admin: run `admin.css` through `grunt commit` routine.
This adds a missing Webkit CSS shim for how the bbPress logo is vertically aligned in the new database upgrade notice.
|
| [6852]
|
johnjamesjacoby
|
Admin: rearrange admin sub-action registrations.
Also fix a bug causing `custom_menu_order` to not be filtered, resulting in hidden admin menus for some users.
|
| [7261]
|
johnjamesjacoby
|
Admin: prevent broken list-table layouts.
This change adds CSS that targets forum/topic/reply list-table heads & foots.
It allows text – that is both unbreakable & wider than its parent th/td – to truncate with an ellipsis.
This is necessary because the default behavior is to continue to squish text down to an unreadable state, which happens frequently here due to the number of columns in the tables and the amount of content available inside of them to Keymasters & Moderators.
In branches/2.6, for 2.6.10.
|
| [6697]
|
johnjamesjacoby
|
Admin: prefer `implode()` over `join()`.
|
| [6424]
|
johnjamesjacoby
|
Admin: in list-tables, if no parent forum/topic, show `—` instead.
Also make sure a few strings are escaped, and dropdowns are using correct parent text.
|
| [6791]
|
johnjamesjacoby
|
Admin: improve topic/reply row-action UX.
This change includes more improvements to how topics and replies are toggled from an admin area list-table:
* Move "Empty Spam" buttons to their own actions div
* Allow spam/trash/approve/unapprove from any other status, so topics/replies can be more freely moved around
* Add public/non-public functions for replies to match topics
See #1799.
|
| [6790]
|
johnjamesjacoby
|
Admin: improve topic/reply row-action UX.
This change includes a few improvements to how topics and replies are toggled from an admin area list-table:
* Make approve & not-spam links green to match comments UI
* More specifically target admin area links to avoid conflicts with other post types
* Make "Approve" a blanket "publish" action, meaning it will always publish a topic/reply even from spam or trash
* Make sure "Not Spam" will restore to "pending" if it was previously not published
* Bump CSS version
See #1799.
|
| [6730]
|
johnjamesjacoby
|
Admin: fix filter load order for PHP 7.1 compat.
|
| [6772]
|
johnjamesjacoby
|
Admin: enforce row-action order for forums, topics, and replies.
This change introduces a known (and filterable) sort-order to row-action keys, allowing for a more logical flow to better match Posts, Pages, and other WordPress core objects.
With slight variations, the flow is: Edit, Stick(to front), Un/approve, Open/Close, Delete/Trash, Spam, View.
Previous to this change, these `row_actions()` filters were only appending or overwriting keys, which introduced an unnecessary administration variation with no real benefit.
|
| [6603]
|
johnjamesjacoby
|
Admin: buzz & swoop.
|
| [6704]
|
johnjamesjacoby
|
Admin: allow feedback dismissal to be optional in `bbp_admin_tools_feedback()`.
|
| [7258]
|
johnjamesjacoby
|
Admin: add some inputs to too-wide kludge CSS.
This change ensures that various admin-area meta-box inputs render next to their labels instead of below them.
In branches/2.6, for 2.6.10.
|
| [7278]
|
johnjamesjacoby
|
Admin: add post-state support to admin-area list-tables
This change checks posts for shortcode usages and adds "state" labels for them, to help make Forum integration easier to identify from within the list table context (usually Pages, but currently not post-type specific).
It does this by introducing `BBP_Admin::display_post_states()` and hooking it in as a filter to `display_post_states`.
Committer note: `get_page_by_path()` would offer more precision but also be significantly more costly to call here, so instead there is a fuzzy match on `post_name` for the Forum & Topic Archive pages only.
Fixes #3605.
|
| [6705]
|
johnjamesjacoby
|
Admin: add an admin notice if database upgrade was skipped.
This change adds a persistent admin notice (who doesn't love those?) in the event that the forums are part of a large WordPress installation that prevented the automatic database upgrade routine from running.
Two links are provided: one to "Go Upgrade" and another to "Hide Forever". The first will take the user (with adequate capability) to the `Tools > Forums > Upgrade` screen; the second will delete the notice nag key from `wp_options`.
This includes some admin area CSS tweaks, so the asset version gets a bump as well.
|
| [6604]
|
johnjamesjacoby
|
Admin: Use some JavaScript to spruce up the badge-animation.
@todo Update the "What's New" page contents.
|
| [5810]
|
netweb
|
Admin: Updated Topic and Reply contextual help
Props robkk. Fixes #2824
|
| [6397]
|
johnjamesjacoby
|
Admin: Update row action toggle methods to be a bit more flexible.
This should improve support for custom toggle actions in `wp-admin`.
|
| [5884]
|
johnjamesjacoby
|
Admin: Update `h2` to `h1` and remove `icon32` compatibility.
This changeset improves accessibility and brings bbPress's admin area headers up to par with WordPress 4.3.
Fixes #2840. See #WP31650.
|
| [5932]
|
johnjamesjacoby
|
Admin: Swap `%d` for `%s` in `bbp_filter_dashboard_glance_items()`.
This changeset fixes a bug causing numbers to be truncated at the first non-numeric character.
Fixes #2857.
|
| [6271]
|
johnjamesjacoby
|
Admin: Rename list-table file for future autoloading of classes.
|
| [6500]
|
johnjamesjacoby
|
Admin: Rename `upgrades.php` to `upgrade.php` to match the other files.
|
| [6602]
|
johnjamesjacoby
|
Admin: Remove obscure 'About bbPress' admin-bar link.
Nobody ever really used it, and less is more in this case.
|
| [6703]
|
johnjamesjacoby
|
Admin: Remove duplicate dismiss button from `bbp_admin_tools_feedback()`.
|
| [6800]
|
netweb
|
Admin: Remove deprecated `screen_icon()` calls.
See #2538. Fixes #3198. (2.5 branch).
|
| [5809]
|
johnjamesjacoby
|
Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.6.0 (trunk)
|
| [5808]
|
johnjamesjacoby
|
Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.5.8 (2.5 branch)
|
| [5904]
|
johnjamesjacoby
|
Admin: Register color schemes based on bbPress plugin path vs. WordPress source. Fixes #2847.
|
| [6475]
|
johnjamesjacoby
|
Admin: More admin mark-up updates
* Add `hr` after `h1`s on custom screens
* More accurate meta-box wrapper mark-up
|
| [6186]
|
johnjamesjacoby
|
Admin: Implement new loading sequence for major admin components.
* Introduce new `bbp_current_screen` sub-action
* Hook forums/topics/replies into `bbp_current_screen`
* Remove various `bail()` methods, which were fragile and terrible anyways
* Revert r6178, thanks to order-of-operation issues with `get_current_screen()`
* Remove Comments & Discussion metaboxes if `comments` is not explicitly supported
See #2959.
|
| [6263]
|
johnjamesjacoby
|
Admin: Fix restoring/trashing topics & replies.
Fixes #2734. Props tharsheblows, thebrandonallen, netweb.
|
| [6040]
|
netweb
|
Admin: Escape `$file` variable for importer filenames in `bbp_converter_setting_callback_platform()`
Props xknown
Fixes #2792
|
| [5903]
|
johnjamesjacoby
|
Admin: Do not register color schemes when running from source.
This changeset prevents the color picker UI from appearing (and not working) when running WordPress from it's `/src` directory.
See #2847.
|
| [6913]
|
johnjamesjacoby
|
Admin: Correctly register scripts & styles before enqueing them.
This commit moves style/script registration to dedicated admin-area actions, separating them from their relative enqueing actions.
It also deprecates the singular (incorrectly named) "bbp_register_admin_style" action and replaces it with the correctly named plural "bbp_register_admin_styles".
|
| [6474]
|
johnjamesjacoby
|
Admin: Clean-up admin assets according to specifications.
|
| [5851]
|
johnjamesjacoby
|
Admin: Check that the user can view the About page before adding the toolbar item.
This changeset ensures that only capable users will see the link to bbPress's admin-area "About" page.
Props ocean90. Fixes #2836.
|
| [6350]
|
johnjamesjacoby
|
Admin: Avatar margins on user relationship meta-boxes.
|
| [6252]
|
johnjamesjacoby
|
Admin: Alternate row styling for list tables.
* Remove `admin_head` methods in forums/topics/replies classes
* Move styling into `admin.css`
* Bump asset version
|
| [6190]
|
netweb
|
Admin: Add missing `@since` revisions from r6186.
|
| [6187]
|
johnjamesjacoby
|
Admin: Add missing `@param`'s from r6186.
|
| [5850]
|
johnjamesjacoby
|
Admin: Add `hidden_post_status` field back to topic & reply metaboxes, and use `draft` or current post status as value.
This changeset fixes a bug that caused topics & replies to be marked as edited when moderated via `wp-admin`.
Hat-tip tharsheblows. Fixes #2741.
|
| [4079]
|
johnjamesjacoby
|
Admin:
* Additional sanity checks on bail() methods, if get_current_screen() is not set. (2.1 branch)
|
| [4069]
|
johnjamesjacoby
|
Admin:
* Revert r4068, pending a better way to manipulate the menus.
|
| [4068]
|
johnjamesjacoby
|
Admin:
* Remove 'manage_options' cap check from bbp_admin_separateror()
* This is now handled by bbp_admin_menu_order(), and can cause no separator to exist in certain situations.
|
| [3963]
|
johnjamesjacoby
|
Admin:
* Move global declaration beyond cap checks in bbp_admin_separator().
|
| [3916]
|
johnjamesjacoby
|
Admin:
* Mark some methods as static where appropriate in BBP_Admin class.
|
| [4070]
|
johnjamesjacoby
|
Admin:
* Introduce bail() method to forum/topic/reply components.
* Bail out of other methods if post_type doesn't match.
* Fixes issue where meta-box and styling were not always available on all appropriate screens.
* Also reverts some perfomance improvements implimented in r4053.
|
| [4054]
|
johnjamesjacoby
|
Admin:
* Fix inverted $typenow check for replies.
* See r4053.
|
| [3962]
|
johnjamesjacoby
|
Admin:
* Fix duplicate separator when user cannot see forum content.
* Fixes #1848.
|
| [4159]
|
johnjamesjacoby
|
Admin:
* First pass at WordPress core style about and credits UI.
|
| [3897]
|
johnjamesjacoby
|
Admin:
* Allow admin screens to be overridden by switch or capability.
* Always allow for is_super_admin().
* Fixes #1822.
|
| [4077]
|
johnjamesjacoby
|
Admin:
* Additional sanity checks on bail() methods, if get_current_screen() is not set.
|
| [4053]
|
johnjamesjacoby
|
Admin:
* Add nonce checks and additional sanity checks to converter, to prevent it being loaded or accessed outside of the converter screen.
* Use 'load-' actions to conditionally load admin components on their respective screens.
* Remove post_type checks that are no longer needed as a result of conditionally loading each component.
* Use get_current_screen() to fill in any extra post_type checks.
* Sweep through converter, make output more clean, add output method, and store last query in the DB in case of failure.
|
| [3915]
|
johnjamesjacoby
|
Admin:
* Add missing quotes to icon URL css in BBP_Admin::admin_head().
|
| [6601]
|
johnjamesjacoby
|
Admin/Converter: Lazy load admin & converter as needed.
* Move admin class into its own file
* Remove `admin.php`
* Introduce `_setup_` functions to make loading them on the fly easier
* Simplify converter logic for smoother starting/stopping
* Improved UI for timer/status updates
* Remove double-duty variables from `BBP_Converter` and response data
* Switch from text-only response value to JSON object for improved flexibility
This allows the converter to return more data, and makes it easier to work with that data.
Todo:
* Error responses
* Check that starts are bumping correctly inside of steps
* Better utilize JSON responses
|
| [2643]
|
johnjamesjacoby
|
Admin nag notice about theme. Add skeleton for settings page. Move tools menu creation into main admin class.
|
| [2520]
|
johnjamesjacoby
|
Admin area code clean-up
|
| [3998]
|
johnjamesjacoby
|
Admin Settings:
* Turn settings sections into multidimensional array, keyed by ID.
* Allows sections to be filtered, changed, rearranged, etc...
|
| [4002]
|
johnjamesjacoby
|
Admin Settings:
* Move sections and settings into procedural functions in bbp-settings.php.
* Allows filtering of sections and fields without checking for faux-capabilities.
* Enables easier settings section and field manipulations, as well as adding or editing of future settings.
|
| [4348]
|
johnjamesjacoby
|
Admin Settings:
* If a setting is manually overridden, disable it.
* Introduces bbp_maybe_admin_setting_disabled() helper function.
* Update bbp_dropdown with 'disabled' parameter to allow disabling based on option.
|
| [6771]
|
johnjamesjacoby
|
Admin Notices: remove `create_function()` usage from tools feedback.
This change removes the last remaining deprecated function call for full PHP 7.2 support, while also making admin area notices a bit more flexible in the process.
Notices are now stored in an `bbpress()->admin->notices` array, and are output to the page via the `bbp_admin_notices` sub-action. This ensures that they'll only be made visible when bbPress is active, and keeps them contained to places where bbPress is already hooked in.
It was also previously possible for any user to dismiss the database upgrade notice, even if they were not capable of seeing it, so this is now fixed as well.
|
| [4046]
|
johnjamesjacoby
|
Admin Menus:
* Fix issue where bbPress top-level admin-menu positions could conflict with other plugins.
* Set menu_position on post-types to 555555.
* Refactor bbp_admin_menu_order() to reposition all available custom menus above the second separator.
* Fixes #1876.
|
| [3995]
|
johnjamesjacoby
|
Admin Images:
* Revert accidental CSS menu position tweaks.
* See #1839.
|
| [3993]
|
johnjamesjacoby
|
Admin Images:
* Fix background size, so images scale correctly.
* See #1839.
|
| [3994]
|
johnjamesjacoby
|
Admin Images:
* Better align menu icons.
* Add version to images using bbp_get_version()
* See #1839.
|
| [3992]
|
johnjamesjacoby
|
Admin Images
* Update admin CSS to WordPress core standard.
* See #1839.
|
| [3991]
|
johnjamesjacoby
|
Admin Images
* Add 2x support for admin menu icons.
* Props chexee.
* See: #1839.
|
| [4128]
|
johnjamesjacoby
|
Admin Help:
* Repair admin help copy-pasta from r3686.
* For 2.2 branch.
* Props janeforshort.
|
| [4127]
|
johnjamesjacoby
|
Admin Help:
* Repair admin help copy-pasta from r3686.
* For 2.1 branch.
* Props janeforshort.
|
| [2970]
|
johnjamesjacoby
|
Adjustments to login and register forms to improve behavior and functionality.
Various documentation fixes.
Rename _bbp_topic_status meta to _bbp_status, and add migration routine to updater.
Sanity checks on $wp_query in bbp_pre_get_posts.
Fixes #1476, #1493. Props !GautamGupta for original diff.
|
| [2564]
|
johnjamesjacoby
|
Adjustments to get replies running. More to do here.
|
| [2878]
|
johnjamesjacoby
|
Adjustments to bbp-twentyten to use new functions and include updated styling for them.
|
| [2651]
|
johnjamesjacoby
|
Adjustments to admin area CSS for icons32 and WP 3.1
|
| [3297]
|
johnjamesjacoby
|
Adjust topic exists check on topic_attributes_metabox_save() and update inline doc in both topic and reply metabox save functions. See r3295.
|