| [3054]
|
johnjamesjacoby
|
Audit the usage of $wp_query global through out bbPress plugin and use core WP functions where possible instead.
|
| [3651]
|
johnjamesjacoby
|
Audit the bbp-twentyten theme's actions, HTML, and CSS. See #1702.
|
| [4866]
|
johnjamesjacoby
|
Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (trunk)
|
| [4867]
|
johnjamesjacoby
|
Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (2.3 branch)
|
| [4708]
|
johnjamesjacoby
|
Audit form field functions. Cast some $_POST values. Props Maty. (2.2 branch)
|
| [4705]
|
johnjamesjacoby
|
Audit form field functions. Cast some $_POST values. Props Maty.
|
| [6191]
|
johnjamesjacoby
|
Audit direct query and `prepare()` usages, and more tightly adhere to best practices.
* No quotes around directives
* Avoid concatenation, prefer variable parsing in double-quoted strings
* Covers converters, helper functions, and tools
|
| [3478]
|
johnjamesjacoby
|
Audit default usage value of '_bbp_forums_per_page'
|
| [3837]
|
johnjamesjacoby
|
Audit count functions and add number_format_i18n filter to them. See #1810.
|
| [3267]
|
johnjamesjacoby
|
Audit checked() usage. Correct reversed logic, add usage to topic widget, and test all usages to ensure functionality.
|
| [5020]
|
johnjamesjacoby
|
Attributes are optional in the display_topic_form() shortcode. Suppresses debug notice when no attribute is passed, introduced in r5012. See #1649.
|
| [2771]
|
johnjamesjacoby
|
Attempt to sort by menu_order rather than post_title.
|
| [3663]
|
johnjamesjacoby
|
Assorted topic template tag code improvements.
* Pass $topic_id in filters where possible
* Make sure echo functions pass all param's to return functions
* Pretty code tweaks
|
| [3662]
|
johnjamesjacoby
|
Assorted forum template tag code improvements.
* Pass $forum_id in filters where possible
* Make sure echo functions pass all param's to return functions
* Pretty code tweaks
|
| [6608]
|
johnjamesjacoby
|
Assets: Update admin CSS/JS to match lint rules, and update packages.
|
| [6261]
|
johnjamesjacoby
|
Assets: Remove `screen` restriction on default template pack styling.
Improves styling when printing and third-party plugins (like Autoptimize.)
Props thebrandonallen. Fixes #3012.
|
| [6690]
|
johnjamesjacoby
|
Assets: Lint recent CSS & JS changes for password toggle.
This change makes the build process work again. :)
|
| [3455]
|
johnjamesjacoby
|
Ask and ye shall receive. Remove the logged in user avatar from the topic and reply forms in bbp-twentyten. Tweak the textarea's of those forms to fill the width of the bounding fieldsets.
|
| [6738]
|
johnjamesjacoby
|
Args: pass default parameters into filters in `bbp_parse_args()`.
This change allows conditional filtering of parsed arguments based on the arguments originally passed in.
|
| [3203]
|
johnjamesjacoby
|
Apply editable_slug filter on form_options. Introduce bbp_form_option() functions to handle the output. Fixes #1526. Props ramly.
|
| [7220]
|
johnjamesjacoby
|
Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In trunk for 2.7. See #3443.
|
| [7221]
|
johnjamesjacoby
|
Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In branches/2.6 for 2.6.8. Fixes #3443.
|
| [6910]
|
johnjamesjacoby
|
Appearance: Use right-to-left suffix in default template pack.
Fixes #3263. Props GDragoN.
|
| [6818]
|
netweb
|
Appearance - Included Themes: Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:43019
* `_mixins.scss` via WP:changeset:41984
See #2583.
|
| [6214]
|
netweb
|
Appearance - Included Themes: Update admin base SCSS styles:
* Updated via upstream WordPress `_admin.scss` file via WP:changeset:38602, WP:changeset:38638, WP:changeset:38660, WP:changeset:39141, and WP:changeset:39249
See #2583
|
| [6741]
|
johnjamesjacoby
|
Anonymous: remove escaped placeholders from `$where` clause of duplicate check.
This change fixes a bug for versions of WordPress 4.8.3 and higher, that was causing the anonymous email comparison to use the placeholder text instead of the raw email address, but only when an email address contained a `%` character.
Also use the correct return variant, and make sure the output is escaped.
|
| [6740]
|
johnjamesjacoby
|
Anonymous: remove `sanitize_comment_cookies()` call.
This was causing repeated comment cookie sanitization on each subsequent page load.
|
| [6917]
|
johnjamesjacoby
|
Anonymous: delete meta key if value is empty.
This commit ensures that editing a non-anonymous topic via WordPress Admin does not erroneously add empty anonymous author keys to post meta.
|
| [6742]
|
johnjamesjacoby
|
Anonymous: cleanup from r6741.
|
| [6400]
|
johnjamesjacoby
|
Anonymous: Improve `$anonymous_data` implementation:
* Always treat it as an array, handling for `false` values was never used
* Introduce `_sanitize_` and `_update_` partner functions for the existing `_filter_` function
* Ensure that cookies and meta-data values are stripped of invalid characters in the same way that anonymous comments are, to prevent inconsistencies between anonymous forum and commenter cookie data
* Update surrounding documentation blocks
* Prefer strict type-casting and `is_array()` comparisons
|
| [6838]
|
johnjamesjacoby
|
Anonymous: Don't use `esc_html__()` in combination with HTML tags.
Props wpdennis. Fixes #3210.
|
| [6399]
|
johnjamesjacoby
|
Anonymous: Clean-up `bbp_set_current_anonymous_user_data()`:
* Make sure cookies are secure when SSL
* Only call `time()` once to avoid potential delays
* Cast cookie lifetime to `int` after filtering
* Inline docs
|
| [6737]
|
johnjamesjacoby
|
Anonymous Users: improve styling for anonymous topic/reply author boxes.
This change wraps anonymous author data in `span` elements where `a` elements would normally be used for registered users, and tweaks the default template-pack CSS to accomodate these new elements.
|
| [5231]
|
nacin
|
Ancient bbPress: Adjust error reporting to cope with PHP 5.4.
|
| [3579]
|
johnjamesjacoby
|
Always set defaults in bbp_theme_compat_reset_post().
|
| [5802]
|
johnjamesjacoby
|
Always predefine `$args` as an array, for code consistency across all components.
|
| [5358]
|
johnjamesjacoby
|
Alphabetize grunt packages and update keywords in `package.json`.
|
| [3856]
|
johnjamesjacoby
|
Allow user favorites and subscriptions to work per site on multisite installations. Props isaacchapman. Fixes #1818.
|
| [4935]
|
johnjamesjacoby
|
Allow topics to replace the forum archive:
* Add condition to bbp_parse_args() and add a specific query variable early, and use this variable in bbp_is_forum_archive().
* Add condition to display_forum_archive() shortcode, to output topics if set.
* Add forum archive check to bbp_has_topics(), to ensure pagination links are correct.
* See #1500.
|
| [5310]
|
johnjamesjacoby
|
Allow topic-tag descriptions to be edited theme-side. Props netweb. Fixes #1613.
|
| [5012]
|
johnjamesjacoby
|
Allow topic form shortcode to accept a forum_id attribute. Props netweb, GautamGupta. Fixes #1649.
|
| [3507]
|
johnjamesjacoby
|
Allow theme compatibility to be extended more completely. Move contents of bbp-twenty-ten's functions.php into a class, which extends the new BBP_Theme_Compat class.
|
| [4971]
|
johnjamesjacoby
|
Allow the search feature to be toggled on and off. Introduces new setting and supporting function to get and override the option easily in third party plugins. Fixes #2342.
|
| [4632]
|
johnjamesjacoby
|
Allow tabbing into and out of TinyMCE. Fixes #1917.
|
| [3215]
|
johnjamesjacoby
|
Allow site options to pass a default value if none exists.
|
| [4961]
|
johnjamesjacoby
|
Allow registering of settings that don't need callbacks or titles. See #2340.
|
| [3387]
|
johnjamesjacoby
|
Allow previously set $redirect_to override in bbp_logout_url(). Fixes #1580.
|
| [4934]
|
johnjamesjacoby
|
Allow partial global/local .mo file loading in bbPress::load_textdomain(). Props strangerstudios.
|
| [4701]
|
johnjamesjacoby
|
Allow moderation and blacklist to be bypassed based on function parameters. Props tlovett1. Fixes #2154.
|
| [3371]
|
johnjamesjacoby
|
Allow manually setting the offset and number of topics to retrieve. Props boonebgorges.
|
| [3222]
|
johnjamesjacoby
|
Allow just-in-time manipulation of topic and reply data before creating or editing them. See #1477.
|
| [3066]
|
johnjamesjacoby
|
Allow just-in-time filtering of forums/topics/replies queries
|
| [3621]
|
johnjamesjacoby
|
Allow forum/topic/reply row classes to be filtered. Fixes #1664.
|
| [3188]
|
johnjamesjacoby
|
Allow existing pages to override forum and topic archive slugs.
|
| [3451]
|
johnjamesjacoby
|
Allow default options to be overloaded from within the $bbp->options array ala bbPress 1.x.
|
| [3450]
|
johnjamesjacoby
|
Allow custom redirects in login, register, and lost pass forms.
|
| [5313]
|
johnjamesjacoby
|
Allow closed topics to be split and merged into. Props netweb. Fixes #1714.
|
| [2784]
|
johnjamesjacoby
|
Allow capable users to mark topics as sticky/super sticky on creation/edit. Props !GautamGupta via Google Code-in
|
| [2691]
|
johnjamesjacoby
|
Allow capable admins to view other users' topic subscriptions.
|
| [3270]
|
johnjamesjacoby
|
Allow breadcrumb separator to be translated. Remove spaces from separator and use str_pad instead.
|
| [4951]
|
johnjamesjacoby
|
Allow both get and post requests in bbp_is_ajax().
|
| [3798]
|
johnjamesjacoby
|
Allow bbp_create_initial_content() to be filtered or provided an array of defaults.
|
| [4790]
|
johnjamesjacoby
|
Allow additional post-type CSS classes to be passed as a second parameter. Fixes #2242.
|
| [3674]
|
johnjamesjacoby
|
Allow additional anonymous data to be automatically saved on reply and topic update any prevent any possible debug notices with missing core values in the process.
|
| [6728]
|
johnjamesjacoby
|
Allow a custom redirect destination in the reply form.
(Specifically for shortcode or third-party plugin usage.)
See r3450.
|
| [5493]
|
johnjamesjacoby
|
Allow `class` attribute for `pre` tags in `bbp_kses_allowed_tags()`. Props netweb. Fixes #2657.
|
| [3251]
|
johnjamesjacoby
|
Allow WordPress pages to overload forum and topic archive pages.
Introduce bbp_reset_all_filters() and bbp_restore_all_filters() functions to handle specific bypassing of the_content filter for theme compat. Introduce bbp_is_topic_archive() and bbp_is_forum_archive() functions to help with bypassing archive pages.
|
| [3221]
|
johnjamesjacoby
|
Allow Topic Form shortcode to work on pages or any other single template. Fixes #1535.
|
| [3402]
|
johnjamesjacoby
|
Allow BuddyPress profile URLs to override bbPress profile URLs in an inexpensive way.
|
| [3369]
|
johnjamesjacoby
|
Allow Akismet global key to be set. (trunk)
|
| [5162]
|
johnjamesjacoby
|
Allow 'bbp_has_search_results' filter to still run even if no search terms were passed. This brings it inline with other component queries. Fixes #2356.
|
| [3068]
|
johnjamesjacoby
|
Allow $none_found custom message in bbp_get_dropdown()
|
| [5693]
|
johnjamesjacoby
|
All: ensure all URLs are escaped part 2 (2.5 branch)
|
| [5691]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (trunk) and cleanup some phpdoc
Also introduce `bbp_dropdown` class for dropdowns.
|
| [5692]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (2.5 branch)
|
| [5676]
|
johnjamesjacoby
|
All: Update default values for `$args` parameters from empty strings to empty arrays.
This is a micro-optimization to avoid unnecessary calls to `wp_parse_str()` inside `bbp_parse_args()`.
|
| [3463]
|
johnjamesjacoby
|
Align the topic edit input fields with their labels. Rename duplicate tag-name form field to tag-existing-name. Fixes #1612.
|
| [3340]
|
johnjamesjacoby
|
Alas, poor mdawaffe! I knew him, 1.0...
|
| [7197]
|
johnjamesjacoby
|
Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In trunk for 2.7.0. See #2853.
|
| [7198]
|
johnjamesjacoby
|
Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In branches/2.6 for 2.6.7. Fixes #2853.
|
| [6867]
|
johnjamesjacoby
|
Akismet: send sanitized string values for referer and user-agent.
Avoids issues with huge/invalid strings. and ensures that `_wp_http_referer` is used.
|
| [7156]
|
johnjamesjacoby
|
Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In trunk, for 2.7. Fixes #3400.
Props cfinke.
|
| [7155]
|
johnjamesjacoby
|
Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In branches/2.6, for 2.6.6. See #3400.
Props cfinke.
|
| [7196]
|
johnjamesjacoby
|
Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In trunk for 2.7.0. See #3410.
|
| [7195]
|
johnjamesjacoby
|
Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In branches/2.6 for 2.6.7. See #3410.
|
| [7204]
|
johnjamesjacoby
|
Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3395.
|
| [7203]
|
johnjamesjacoby
|
Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3395.
|
| [5933]
|
johnjamesjacoby
|
Akismet: include title with content. Props cfinke. Fixes #2858.
|
| [7226]
|
johnjamesjacoby
|
Akismet: improvements to clean-up routines, based on user feedback.
* Use correct `ID` column for the `posts` database table
* Use correct `post_id` column for the `postmeta` database table
* Reduce row limit to `1000` from `100000` to avoid lengthy table locks in active forums
* Remove usage of constant, that may be phased out eventually
* Update related code docs
* Introduce helper methods for applying dynamically named filters
In trunk for 2.7. See #3395.
|
| [7227]
|
johnjamesjacoby
|
Akismet: improvements to clean-up routines, based on user feedback.
* Use correct `ID` column for the `posts` database table
* Use correct `post_id` column for the `postmeta` database table
* Reduce row limit to `1000` from `100000` to avoid lengthy table locks in active forums
* Remove usage of constant, that may be phased out eventually
* Update related code docs
* Introduce helper methods for applying dynamically named filters
In branches/2.6 for 2.6.9. Fixes #3395.
|
| [7206]
|
johnjamesjacoby
|
Akismet: hook clean-up methods from r7204 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In trunk, for 2.7.0.
See #3395.
|
| [7205]
|
johnjamesjacoby
|
Akismet: hook clean-up methods from r7203 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In branches/2.6, for 2.6.7.
See #3395.
|
| [7129]
|
johnjamesjacoby
|
Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In trunk, for 2.7.
Props procifer.
See #3368.
|
| [7128]
|
johnjamesjacoby
|
Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In branches/2.6, for 2.6.6.
Props procifer.
See #3368.
|
| [6874]
|
johnjamesjacoby
|
Akismet: allow "trusted" users to bypass spam `post_status` enforcement.
* Adds `bbp_bypass_check_for_spam` filter ahead of the HTTP request
* Adds `bbp_bypass_spam_enforcement` filter ahead of `post_status` switch
* Adds `current_user_can( 'moderate' )` check to bypass spam enforcement
* Adds `parse_response()` method to `BBP_Akismet` class for future abstraction
This allows for 2 different ways to short-circuit Akismet:
* Before the HTTP request happens
* After the HTTP request, but before the status change
bbPress will now trust users that pass the `moderator` capability check (including per-forum moderators) even if Akismet thinks the content is spammy. The Akismet history will still reflect the catch; the status will just not be enforced.
This addresses issues we've seen on WordPress.org, BuddyPress.org, and bbPress.org, where trusted moderator posts would be caught in the spam queue, even when they have privileges to enter the queue and unspam their own posts.
Fixes #2917. Props tharsheblows for the original patch!
|
| [7126]
|
johnjamesjacoby
|
Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In trunk, for 2.7.
Props Otto42.
See #2853.
|
| [7127]
|
johnjamesjacoby
|
Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In branches/2.6, for 2.6.6.
Props Otto42.
See #2853.
|
| [7252]
|
johnjamesjacoby
|
Akismet: add class definition for $last_post.
This change improves compatibility with newer PHP versions (8.0 and above) that prefer for all class variables to be predefined.
In branches/2.6, for 2.6.10.
|
| [7193]
|
johnjamesjacoby
|
Akismet: Remove "publish" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In trunk for 2.7.0. See #3410.
|
| [7194]
|
johnjamesjacoby
|
Akismet: Remove "publish" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In branches/2.6 for 2.6.7. Fixes #3410.
|