[6000]
|
netweb
|
Build Tools: Revert [5999] `grunt-legacy-util` update, from 0.2.0 to 1.0.0
This changeset reverts the above change as I missed the `1.0.0` recommended [https://github.com/gruntjs/grunt-legacy-util/blob/master/README.md change] to use `require('child_process').spawn` over `grunt.util.spawn`. Per NodeJS docs [https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options here] and [https://nodejs.org/dist/latest-v4.x/docs/api/child_process.html#child_process_child_process_spawn_command_args_options here] for NodeJS versions 5.x and 4.x respectively this needs some more testing and changes to the Grunt phpunit task and multi task.
Another option per [https://github.com/gruntjs/grunt-legacy-util/issues/10 grunt-legacy-util #10] is to switch to [https://www.npmjs.com/package/cross-spawn-async cross-spawn-async]
Both above options will require *nix and Windows testing.
''6000 is the natural number following 5999 and preceding 6001.''
See #2918
|
[5987]
|
netweb
|
Build Tools: Revert Travis CI TRAVIS_NODE_VERSION environment variable changes from r5984/r5985, installing NodeJS 4.x.x via NVM is sufficient per r5986.
Fixes #2920.
|
[6799]
|
netweb
|
Build Tools: Replace Browserslist configuration in `Gruntfile.js` with `@wordpress/browserslist-config`
This change simplifies bbPress' Browserslist configuration maintainence by depending on WordPress' shared Browserslist configuration package:
* https://github.com/WordPress/packages/tree/master/packages/browserslist-config
* https://github.com/WordPress/packages/
|
[5983]
|
netweb
|
Build Tools: Renamed `grunt-rtlcss` option `options.config` to RTLCSS v2.x `options.opts` option
See #2918
|
[6201]
|
netweb
|
Build Tools: Remove unsupported WordPress versions from Travis CI build job matrix.
This changeset removes all WordPress versions previous to 4.7 as this is now bbPress' minimum required version.
|
[6405]
|
netweb
|
Build Tools: Remove HHVM from the test infrastructure on Travis.
Fixes #3104.
|
[6267]
|
netweb
|
Build Tools: NPM modules in `package.json` should only use semantic versioning `~` ''minor'' versions, rather than `^` ''major'' versions.
This changeset will help avoid the pitfalls of upstream NPM modules breaking our build due to a release of a new major version for which bbPress has not yet tested against.
|
[6625]
|
netweb
|
Build Tools: Move PHP 5.2 and 5.3 Travis CI jobs from the `php` section to the `matrix` section.
This changeset is a follow up to [6624] where the "build matrix" was broken, my bad.
See #3127.
|
[6075]
|
netweb
|
Build Tools: More targeted cleanup for multisite unit tests.
This changeset is a subset of buddypress:changeset:9980 and removes a previous heavy-handed workaround for deleting the first multisite user. This also resolves a fatal error `Object does not implement ArrayAccess` when running the tests on HHVM.
See #2962, #2981
|
[5986]
|
netweb
|
Build Tools: Install NodeJS 4.x.x using NVM in Travis CI
See #2920
|
[5619]
|
netweb
|
Build Tools: Include PHP-7 "nightly" builds with failures allowed in Travis-CI
|
[7050]
|
netweb
|
Build Tools: Improve PHPCS setup.
Props jrf.
See #3294.
For trunk.
|
[6404]
|
netweb
|
Build Tools: Fix copy pasta of `;` instead of `,` added in [6403].
WordPress Coding Standards requires one variable declaration.
See #2924.
|
[6654]
|
netweb
|
Build Tools: Fix copy pasta added in [6652]
|
[6076]
|
netweb
|
Build Tools: Fix `BBP_UnitTestCase::go_to()` for `WP_Network`.
This changeset is via buddypress:changeset:10125
Props boonebgorges.
Fixes #2981
|
[6656]
|
netweb
|
Build Tools: Exclude Travis CI PHP 7.2 builds for WP 4.7 & 4.8, PHP 7.2 compat will WP 4.9.
|
[6946]
|
netweb
|
Build Tools: Disable PHPUnit Speed Tester
|
[5985]
|
netweb
|
Build Tools: Define TRAVIS_NODE_VERSION as a global variable for Travis CI
See #2920
|
[6652]
|
netweb
|
Build Tools: Check for existence `xdebug.ini` using `phpenv` for Travis CI
|
[6962]
|
netweb
|
Build Tools: Cache `node_modules` folder in Travis CI
Fixes #2885.
|
[6548]
|
netweb
|
Build Tools: Bump slow tests threshold for multisite to 250 for now, and we can continue to bring this value down as test performance is improved.
|
[6462]
|
netweb
|
Build Tools: Build Tools: Update `grunt-contrib-clean` from 1.0.0 to 1.1.0
* https://github.com/gruntjs/grunt-contrib-clean/compare/v1.0.0...v1.1.0
This changeset reverts the incorrect change in [6461] to `grunt-contrib-copy` instead of `grunt-contrib-clean`
Antiprops netweb.
|
[7039]
|
netweb
|
Build Tools: Add project root `composer.json` file.
This commit adds the following Composer package developer dependencies:
• `phpcompatibility/phpcompatibility-wp`
• `wp-coding-standards/wpcs`
• `dealerdirect/phpcodesniffer-composer-installer`
This also adds two composer scripts:
• `composer lint` to "lint" the PHP files using PHPCS
• `composer format` to "format" the PHP files using PHPCBF
Props jrf.
See #3294.
|
[6494]
|
netweb
|
Build Tools: Add npm `package-lock.json` for npm v5.x
This changeset adds support for npm 5 which include significant performance improvements, these are primarily due updated caching, offline caching and the addition of a `package-lock.json` to leverage the new caching.
To install and use npm 5 with your existing install of Node.js 6 or 7 run `npm i npm@5 -g`. Node.js 8 support will be added in a follow up ticket.
Installing npm modules for bbPress is now ~6x faster with npm 5 🏎
Fixes #3113.
|
[5984]
|
netweb
|
Build Tools: Add minimum NodeJS 4.2.x LTS version
This changeset sets the minimum required NodeJS version supported. This is required as various NPM modules now require a minimum version greater than the default v0.10.x currently in use.
See #2920.
|
[6651]
|
netweb
|
Build Tools: Add debug echo for `TRAVIS_PHP_VERSION`
|
[6840]
|
netweb
|
Build Tools: Add a `.npmrc` file, and move `node-sass` to `devDependencies`
The `.npmrc` file configures NPM to save exact versions
|
[6131]
|
netweb
|
Build Tools: Add WordPress 4.7 to Travis CI build matrix
|
[6081]
|
netweb
|
Build Tools: Add WordPress 4.6 to Travis CI build matrix
|
[6003]
|
netweb
|
Build Tools: Add WordPress 4.5 to Travis CI build matrix
|
[5961]
|
netweb
|
Build Tools: Add WordPress 4.4 to the Travis CI build matrix
|
[6203]
|
netweb
|
Build Tools: Add Travis CI cache for installed apt packages.
See #2980.
|
[7006]
|
netweb
|
Build Tools: Add PHPCS with custom bbPress ruleset
- This changeset adds an initial bbPress PHPCS ruleset
- Future iteration of the rules in the ruleset can follow later
- To run the PHPCS check run `grunt phpcs
Fixes #3294.
|
[6637]
|
netweb
|
Build Tools: Add PHP 7.2 to Travis CI.
Fixes #3136.
|
[6132]
|
netweb
|
Build Tools: Add PHP 7.1 to the Travis CI job matrix and remove from `allow_failures` list
|
[6073]
|
netweb
|
Build Tools: Add PHP 7.1 to Travis CI and "allow to fail"
This changeset adds explict PHP 7.1 for testing bbPress, see also #WP37625
See #2980.
|
[5996]
|
netweb
|
Build Tools: Add NPM package `postcss-scss` for styelelint SCSS compatibility
This changeset fixes an idiosyncratic NPM v3.x issue with "flat" folders and sharing dependencies that is not an issue when using NPM v2
See #2924
|
[6655]
|
netweb
|
Build Tools: Add Composer packages to Travis CI cache
|
[5994]
|
netweb
|
Build Tools: Add Autoprefixer for adding CSS vendor prefixes
This changeset adds a new Grunt task `grunt postcss:core` that runs Autoprefixer on CSS & SCSS files to add or remove any vendor prefixes required by browsers.
Browsers supported are the same as WordPress currently supports which are:
* Android >= 2.1
* Chrome >= 21
* Edge >= 12
* Explorer >= 7
* Firefox >= 17
* Opera >= 12.1
* Safari >= 6.0.
Vendor prefixes are are also added for `templates/default/css/bbpress.css` as this is the only file that requires them at this time.
Fixes #2923.
|
[5995]
|
netweb
|
Build Tools: Add @stylelint for linting CSS to adhere to WordPress CSS Coding Standards
This changeset adds a new Grunt task `grunt postcss:lint` that runs stylelint on CSS & SCSS files to ensure bbPress' CSS adheres to WordPress CSS Coding Standards.
8 months in the making and is maintained by yours truly @netweb, with stylelint I'm learning JavaScript deeply.
See also:
* http://stylelint.io/
* https://github.com/stylelint/stylelint
* https://github.com/ntwb/stylelint-config-wordpress
* https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/
Hat-tip: David Clark and Richard Hallows for the ongoing help and support.
Props netweb.
Fixes #2924.
|
[6845]
|
johnjamesjacoby
|
BuddyPress: use `$reply_id` instead of `$topic_id` so `bbp_get_reply_url()` works correctly.
This change ensures that notification links go directly to the reply, not the topic, and not a 404.
Fixes #3213. See #3214.
|
[6804]
|
johnjamesjacoby
|
BuddyPress: updates to member profile URL filters:
* Introduce methods for known user profile pages
* Update public filter methods to use a private method
This change uses new intercept hooks to make sure bbPress profile URLs are turned into BuddyPress ones instead.
See #3814.
|
[6815]
|
johnjamesjacoby
|
BuddyPress: tweak notifications item IDs to provide a bit more context.
This change also fixes a bug with hierarchical reply notifications.
Props jpolakovic. Fixes #2834.
|
[6981]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.7, trunk.
|
[6982]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.6.2, branches/2.6.
|
[7187]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In trunk for 2.7.0. See #3367.
|
[7188]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In branches/2.6 for 2.6.7. Fixes #3367.
|
[6810]
|
johnjamesjacoby
|
BuddyPress: prefer `empty()` check on `disable_blogforum_replies` setting.
This fixes a bug causing some activity to not appear in relative activity streams.
Fixes #3180.
|
[6807]
|
johnjamesjacoby
|
BuddyPress: more efficient includes method.
Props r-a-y. Fixes #3193.
|
[6710]
|
johnjamesjacoby
|
BuddyPress: improve targeting of single forum/topic filters.
This change simplifies the logic used when attaching-to and checking-for the current BuddyPress Group Forum & Topic pages, by conditionally filtering behind a singular `bp_is_group()` check.
Fixes #3165. Props thebrandonallen.
|
[7060]
|
johnjamesjacoby
|
BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.7, trunk
|
[7059]
|
johnjamesjacoby
|
BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.6.14, branches/2.6
|
[7057]
|
johnjamesjacoby
|
BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.7, trunk.
|
[7058]
|
johnjamesjacoby
|
BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.6.14, branches/2.6
|
[6805]
|
johnjamesjacoby
|
BuddyPress: clean up new `get_profile_url()` method.
See r6804.
|
[7183]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In trunk for 2.7.0. See #3341.
Props konnektiv.
|
[7184]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In branches/2.6 for 2.6.7. Fixes #3341.
Props konnektiv.
|
[6808]
|
johnjamesjacoby
|
BuddyPress: add more `fully_loaded()` methods to component classes.
This will allow an entry point for plugins to alter these classes how they see fit.
Fixes #3192.
|
[6285]
|
johnjamesjacoby
|
BuddyPress: Use correct hook type for `bp_modify_page_title` filter.
Props thebrandonallen. Fixes #3057.
|
[5653]
|
netweb
|
BuddyPress: Use `bbp_is_favorites_active()` and `bbp_is_subscriptions_active()` respectively to check if bbPress' favorites and/or subscriptions are enabled before displaying menu items in BuddyPress member profiles.
Props tharsheblows. Fixes #2594
|
[5822]
|
johnjamesjacoby
|
BuddyPress: Use `bbp_get_paged_slug()` instead of `$wp_rewrite->pagination_base` directly.
|
[6368]
|
johnjamesjacoby
|
BuddyPress: Update inline doc for group-forum filter. See #2974.
|
[6262]
|
johnjamesjacoby
|
BuddyPress: Update `bbp_format_buddypress_notifications()` with new parameters.
* Prefer `$component_action_name` over less reliable `$content`
* Parameters match BuddyPress 2.6.0 and higher signature
* Mild function clean-up
Fixes #3036.
|
[6391]
|
johnjamesjacoby
|
BuddyPress: Switch activity action back to `$this->component` and skip groups tests.
Proprs thebrandonallen. Fixes #3089.
|
[6485]
|
johnjamesjacoby
|
BuddyPress: Root group forum updates
* Include ability to create a new group root forum if none exists
* Update group-forum setting verbiage to accommodate above
* When a forum is deleted, check if it's the group root, and delete the setting accordingly
* Introduce `bbp_maybe_delete_group_forum_root()` and `bbp_maybe_create_group_forum_root()` functions to carry out the above functionalities
|
[6550]
|
johnjamesjacoby
|
BuddyPress: Remove favs & subs from correct `bbp_get_request` action.
|
[5906]
|
johnjamesjacoby
|
BuddyPress: Remove `@todo`s that are todone or todon'ts.
|
[6229]
|
johnjamesjacoby
|
BuddyPress: Prevent reading/publishing if group member is banned.
Fixes #2905. Props thebrandonallen, r-a-y.
|
[6674]
|
johnjamesjacoby
|
BuddyPress: Prefer `bbp_redirect()` in `bbp_maybe_create_group_forum_root()`
This change uses the new internal function as it's intended, and removes an additional `die;` usage.
Trunk, for 2.6.
|
[5848]
|
johnjamesjacoby
|
BuddyPress: Pass the currently logged in user ID when creating toolbar links. See #2713.
|
[6488]
|
johnjamesjacoby
|
BuddyPress: Only wrap titles in `h2` tags if they are not empty.
Allows easier overriding if titles are not desired at all.
See #3105.
|
[6392]
|
johnjamesjacoby
|
BuddyPress: Missed the skipping of groups tests. Proprs thebrandonallen. Fixes #3089.
|
[7108]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In trunk, for 2.7.0.
Fixes #3378.
|
[7109]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In branches/2.6, for 2.6.6.
Fixes #3213.
|
[5905]
|
johnjamesjacoby
|
BuddyPress: Introduce `BBP_Forums_Group_Extension::update_group_forum_visibility()` to keep group forum visibility in alignment with BuddyPress Group visibility.
This changeset ensures that when a BuddyPress Group's visibility changes, it's bbPress forum visibility changes along with it. This avoids a UX issue where Group visibility and Forum visibility could become misaligned when updating a Group.
Props boonebgorges. Fixes #2599.
|
[6240]
|
johnjamesjacoby
|
BuddyPress: In `functions.php`, prefer `bp_loggedin_user_id()` over `get_current_user_id()`.
This allows BuddyPress filters & functionality to drive the decision making process (rather than WordPress proper) to improve integration with third-party BuddyPress plugins & themes that may rely on BuddyPress in these instances.
|
[6367]
|
johnjamesjacoby
|
BuddyPress: Filter `bbp_is_single_forum` for group forums.
Props r-a-y. Fixes #2727. See #2974.
|
[6538]
|
johnjamesjacoby
|
BuddyPress: Favorites & Subscriptions AJAX improvements
* Pass a data attribute along with links
* Sanitize `action` key when passed into AJAX action hook
* Send a `200` response code
This commit allows favorite & subscription links to work with AJAX in BuddyPress group forums pages.
Props r-a-y. Fixes #3114
|
[6372]
|
johnjamesjacoby
|
BuddyPress: Dynamic activity for topics & replies, part 2.
* Filters for activity action functions
* Tests for the new activity filters
Props thebrandonallen. See #2794.
|
[6370]
|
johnjamesjacoby
|
BuddyPress: Dynamic activity for topics & replies, part 1.
* Functions for activity action filters
Props thebrandonallen. See #2794.
|
[6696]
|
johnjamesjacoby
|
BuddyPress: Do not record edit activity if revisions are off.
This change will prevent edits to topics & replies from creating new Activity Stream items, by obeying both the global setting and the post-type-supports properties of topics & replies. It also prevents activity stream items from being created when reply positions are recalculated on the fly.
|
[5846]
|
johnjamesjacoby
|
BuddyPress: Do not filter profile URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress was network activated and bbPress was active on the non-root blog.
Props imath. See #2713.
|
[5847]
|
johnjamesjacoby
|
BuddyPress: Do not filter admin toolbar URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress is network activated and bbPress is active on the non-root blog.
Props imath. Fixes #2713.
|
[6541]
|
johnjamesjacoby
|
BuddyPress: Continuation of r6538.
* Prefer data attributes
* Stop passing around localized nonces
Props r-a-y. Fixes #3114.
|
[5857]
|
johnjamesjacoby
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y. Fixes #2690.
|
[6492]
|
netweb
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y.
Fixes #2690.
Merges [5857] to the 2.5 branch.
|
[6383]
|
johnjamesjacoby
|
BuddyPress: Bail if in a feed.
Props r-a-y, netweb. Fixes #2745.
|
[6220]
|
johnjamesjacoby
|
BuddyPress: Additional conditionals for group forum topic checks.
Fixes #2974. Props r-a-y.
|
[5849]
|
johnjamesjacoby
|
BuddyPress: Add all topic statuses to `bbp_filter_modify_page_title()`.
This changeset fixes a bug that only allowed published topics to be queried in group forums.
Props netweb. Fixes #2699.
|
[6836]
|
netweb
|
BuddyPress: Add a `for` attribute to the new forum form label improving accessibility
Props mercime.
Fixes #3208.
|
[4266]
|
johnjamesjacoby
|
BuddyPress:
* Remove advanced group forum admin UI; go with feature parity of existing bbPress 1.1 installations for a v1.
* Remove support for multiple forums/groups combinations. Assume the first item in the array is the only one.
* Adds some canonical redirection to group forum content.
* Maps forum content links to group forums when needed.
* Add support for editing of topics and replies within group forums.
* Some more to do here, but closing in on completeness.
* Huge props jmdodd,
* Fixes #1906.
* See #1669.
|
[4213]
|
johnjamesjacoby
|
BuddyPress:
* Clean up logic in strip_mentions_on_edit() method.
|
[3909]
|
johnjamesjacoby
|
BuddyPress:
* Change BBP_Forums_Groups_Component methods to public.
* These should be allowed to be protected by BuddyPress core later.
|
[3908]
|
johnjamesjacoby
|
BuddyPress:
* Change BBP_Forums_Component methods to public.
* These should probably be made protected at some point.
|
[4523]
|
johnjamesjacoby
|
BuddyPress:
* Add reply move support for BuddyPress group forums.
* See #1900, fixes #2064.
|
[4435]
|
johnjamesjacoby
|
BuddyPress/Capabilities:
* Add supporting methods for handling group forum topic moderator functionality.
* Uses map_meta_cap filter to allow group moderators and admins to perform their duties.
* Also allows regular group members to view private/hidden forums if they are a group member.
* Fixes #2033.
|
[3799]
|
johnjamesjacoby
|
BuddyPress group forums:
* Fix new reply and topic redirects
* Remove first group forum topic and reply in lieu of more customization
* See #1669
* Fixes #1776
* Fixes #1778
* Fixes #1777
* Props boonebgorges
|
[4405]
|
johnjamesjacoby
|
BuddyPress Repair:
* Repair forum group ID meta so relationship is fully mapped.
* Update feedback message to include group and forum counts.
* Props jmdodd.
* Fixes #2025.
|
[7210]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3417.
|
[7209]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3417.
|