| [5474]
|
johnjamesjacoby
|
Correct inline doc in `bbp_forum_get_subforums()`.
|
| [2475]
|
chrishajer
|
Correct function name and add information to cookies for anonymous posting. Fixes #1311. Props !GautamGupta
|
| [4794]
|
johnjamesjacoby
|
Correct file description in content-statistics.php. Props alexvorn2. Fixes #2247.
|
| [3616]
|
johnjamesjacoby
|
Correct core languages path in bbp-languages/index.php
|
| [4801]
|
johnjamesjacoby
|
Correct closing HTML tag helper doc in content-single-topic-lead.php Props netweb. Fixes #2252.
|
| [2797]
|
johnjamesjacoby
|
Correct cap on Add User admin menu, and add cap check to submenus. Fixes #1368
|
| [5410]
|
johnjamesjacoby
|
Correct `bbp_stuck_topic` phpdoc. See #2494.
|
| [2554]
|
johnjamesjacoby
|
Correct @since's
|
| [2738]
|
johnjamesjacoby
|
Correct @since docs
|
| [4802]
|
johnjamesjacoby
|
Correct /users/template-tags.php inline doc typo. Props netweb. Fixes #2251.
|
| [7281]
|
johnjamesjacoby
|
Core: small updates to bbPress()->data
This change tweaks the code commentary a bit, and adds a default value of an empty array.
This is largely for the sake of code cleanliness, but also removes the potential for debug notices or errors inside of the magic methods from `data` not being initialized as an array when they are first called.
|
| [7282]
|
johnjamesjacoby
|
Core: remove reference to bbPress::setup_globals()
This method was removed long ago, and replaced by the `bbp_setup_globals` sub-action.
|
| [6039]
|
johnjamesjacoby
|
Core: pass the original text into `bbp_make_clickable` filter.
|
| [6183]
|
johnjamesjacoby
|
Core: Upgrade routine for favorites & subscriptions in 2.6.0.
* Use the new upgrade tools
* Bump the DB version to `260`
* Improve inline docs in upgrade tool functions
See #2959.
|
| [5944]
|
netweb
|
Core: Support for `WP_Hook` in `bbp_get_template_stack()`
The proposed `WP_Hook` #WP17817 breaks backward compatibility for plugins that
attempt to manipulate `$wp_filter` in certain ways. For bbPress, it means
that we cannot directly modify the callbacks that are currently registered as
an array at `$wp_filter[ $tag ]`, in `bbp_get_template_stack()`. Instead, when
`WP_Hook` is not available, we assign the callbacks to a variable (leveraging
`WP_Hook`'s `ArrayAccess`) and manipulate the variable.
Props jbrinley. Fixes #2871
|
| [6058]
|
johnjamesjacoby
|
Core: Revert accidental removal of r6054 from r6056.
|
| [5735]
|
johnjamesjacoby
|
Core: Return the filtered results of ID's in core `_update_` functions.
This helps with various type-casting improvements going into #2801.
|
| [5945]
|
netweb
|
Core: Restore empty `$wp_filter[ $tag ]` check and update PHPDoc in `bbp_get_template_stack()`
See #2871
|
| [6531]
|
johnjamesjacoby
|
Core: Register, then enqueue, both scripts and styles.
This commit makes sure that theme compatibility styles & scripts are properly registered & enqueued.
Props r-a-y. Fixes #3115.
|
| [6353]
|
johnjamesjacoby
|
Core: General core function clean-up.
Mostly odds & ends, formatting, type-casting, etc...
|
| [5733]
|
johnjamesjacoby
|
Core: Force-clear post caches on several common moderation actions.
Fixes inconsistencies around cached objects related to counts, which are currently stored in metadata.
Props thebrandonallen, netweb. See #2801.
|
| [5736]
|
johnjamesjacoby
|
Core: Correct phpdoc to `_update_` functions. Also introduce `bbp_update_reply_to_id()` to help with saving of hierarchical reply metadata. (Will be used in a future commit.)
|
| [6329]
|
johnjamesjacoby
|
Core: Allow custom post authors for initial content (forum/topic/reply).
|
| [6672]
|
johnjamesjacoby
|
Core: Add `source` parameter to API registrations.
This change makes it easier to target bbPress-specific post types & statuses, and taxonomies. `source` may not be the final key, but thankfully all of these APIs accept additional keys, and if support is added to core eventually, we can easily migrate over to it without problems.
Trunk, for 2.6. See: https://core.trac.wordpress.org/ticket/41739
|
| [3899]
|
johnjamesjacoby
|
Core:
* Add new bbp-core-functions.php file to bbp-includes.
* Move functions out of bbp-common-functions.php and into bbp-core-functions.php and bbp-topic-template.php.
* Paves way for bbPress function map API.
|
| [4209]
|
johnjamesjacoby
|
Core Functions:
* Simplify logic in bbp_has_errors().
|
| [2470]
|
johnjamesjacoby
|
Copy paste owns me.
|
| [4201]
|
johnjamesjacoby
|
Copy /branches/plugin/ to /trunk/
|
| [6476]
|
johnjamesjacoby
|
Converters: Port r5332 to 2.5 branch.
See #2558, #3112.
|
| [7015]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.7, trunk.
|
| [7014]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.6.3, branches/2.6.
|
| [6449]
|
johnjamesjacoby
|
Converters: Fix formatting on several converter methods.
|
| [6293]
|
netweb
|
Converters: Fix PHPDoc indentation in `Invision.php`
|
| [4102]
|
johnjamesjacoby
|
Converters:
* Revert whitespace changes in r4101.
* See #1886.
* Antiprops netweb.
|
| [4101]
|
johnjamesjacoby
|
Converters:
* Classes are case sensitive when being loaded by the main converter.
* Fixes #1886.
* Props netweb.
|
| [4119]
|
johnjamesjacoby
|
Converters:
* Classes are case sensitive when being loaded by the main converter.
* Fixes #1886.
* For 2.1 branch.
* Props netweb.
|
| [6665]
|
johnjamesjacoby
|
Converter: use `esc_like()` to avoid debug notice when cleaning users.
This change runs the `_bbp_` `meta_key` prefix through `esc_like()`, ensuring that the subsequent `prepare()` call has a value passed into it.
Trunk, for 2.6.
|
| [6809]
|
johnjamesjacoby
|
Converter: update phpBB importer to use `user_form_salt`.
Props jrf. Fixes #3192.
|
| [6671]
|
johnjamesjacoby
|
Converter: softer verbiage on the importer buttons.
This changes "Stop" to "Pause" and "Continue" to "Resume". This more accurately represents the actions these buttons perform, while also inspiring a bit more confidence that the converter can be halted and resumed at anytime.
Trunk, for 2.6.
|
| [6820]
|
johnjamesjacoby
|
Converter: remove `safe_mode` check from `BBP_Converter::maybe_set_memory()`.
This was deprecated in PHP 5.3.0 and removed in 5.4.0. Instead, this change employs the following:
* Moves keys and values into a filterable array
* Looks for disabled functions and avoids them
* Adds error control operators as needed
|
| [7244]
|
johnjamesjacoby
|
Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In trunk, for 2.7.0.
Props sirlouen. Fixes #3419.
|
| [7243]
|
johnjamesjacoby
|
Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In branches/2.6, for 2.6.10.
Props sirlouen. Fixes #3419.
|
| [7256]
|
johnjamesjacoby
|
Converter: remove `__destruct()` registration
This change removes the need for `wpdb` extensions (like in the Converter) to register their own shutdown methods.
This is necessary because the `__destruct()` method was removed in the parent `wpdb` class, so attempting to add it in the subclass will generate PHP errors.
See #WP21402.
Fixes #3508.
Props GDragoN, dd32.
In branches/2.6, for 2.6.10.
|
| [6785]
|
johnjamesjacoby
|
Converter: remove `WP_SETUP_CONFIG` constant setting from converter process.
This introduces a helper database class to avoid directly connecting to the external database. Instead, we'll attempt to control that connection, and provide feedback to the user in the event a connection cannot be made. The `WP_SETUP_CONFIG` was causing calls to the options API to fail, resulting in broken calculations and invalid offsets.
This commit includes some general load order clean-up, which also fixes a regression causing fatal errors when attempting to upgrade converted user passwords from the old platform. It also fixes the condition where boundaries being converted would display beyond their maximums.
Fixes #3191.
|
| [6666]
|
johnjamesjacoby
|
Converter: reduce `meta_key` and `meta_value` length to `75`.
This change lowers the maximum allowed string length from `191` (which was used based on what's in WordPress core.) After further review, `75` is a reasonable maximum to try for now, though it could likely be tuned further if needed.
Trunk, for 2.6. Fixes #3145.
|
| [6681]
|
johnjamesjacoby
|
Converter: progress bars and percentages.
This change incorporates 2 horizontal bars in the importer header area. One indicates how far the current step has progressed, and the other indicates total progress. Pretty sweet.
Trunk, for 2.6.
|
| [6670]
|
johnjamesjacoby
|
Converter: more OOP, specifically for the BBCode parser.
This change introduces a `bbcode_parser_properties` array to the base converter, allowing custom BBCode parser properties to be passed into the parent method via the child, minimizing the amount of code in each individual forum converter.
Trunk, for 2.6.
|
| [6832]
|
johnjamesjacoby
|
Converter: make a few `private` properties `protected` so subclasses can reach them.
This change fixes a bug causing the e107v1 converter to fail.
Props wpdennis. Fixes #3207.
|
| [7245]
|
johnjamesjacoby
|
Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In trunk, for 2.7.0.
See #3419.
|
| [7246]
|
johnjamesjacoby
|
Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In branches/2.6, for 2.6.10.
See #3419.
|
| [6663]
|
johnjamesjacoby
|
Converter: ensure UI state variables are correctly localized.
This change combines the new UI state variables into an array, so they retain their type-casting through the localization API. It also inverts the logic in 1 comparison to make sure the correct user feedback is displayed in its intended location.
Trunk, for 2.6. Props jrf. Fixes #3146.
|
| [6661]
|
johnjamesjacoby
|
Converter: bind number-of-rows attribute to between 1 and 5000.
This change adds validation to ensure no unexpected number of database rows are queried.
Trunk, for 2.6. Props jrf. See #3148.
|
| [6662]
|
johnjamesjacoby
|
Converter: bind number-of-rows attribute to between 1 and 5000.
This change adds validation to ensure no unexpected number of database rows are queried, and also back-ports sanitization to database connection values from trunk.
2.5 branch, for 2.5.14. Props jrf. Fixes #3148.
|
| [6763]
|
johnjamesjacoby
|
Converter: add inline documentation for `wp_insert_user()`.
This change adds an inline reminder about what `wp_insert_user()` does internally, so our future selves know at a glance why else a user might be skipped.
|
| [6788]
|
johnjamesjacoby
|
Converter: add filter to `bbp_new_converter()`.
This change makes it possible to include a custom converter class for the platform being converted from, especially useful if you've changed password storage schemas or want to handle data migration in a way that is specific to your needs.
See #3191.
|
| [6490]
|
johnjamesjacoby
|
Converter: Use the port number in the server address if available.
Fixes #3022.
|
| [6633]
|
johnjamesjacoby
|
Converter: Use error control operator on `Internal_UpdateParamsForMissingEndTag()`
Avoids polluting the php error logs if position is not byref.
|
| [6639]
|
johnjamesjacoby
|
Converter: Use `false` as the default value for some options.
This ensures that `default_option_` values are still overloadable when converting.
|
| [6678]
|
johnjamesjacoby
|
Converter: Update the options labels and descriptions.
This change should bring increased clarity to what the converter options are for.
Trunk, for 2.6.
|
| [6491]
|
johnjamesjacoby
|
Converter: Update some strings for improved clarity.
When a conversion is stopped, and later resumed, make sure the steps and verbiage are clear.
Also switch from "Completed" to "Finished" since it's likely some repair steps are still necessary, and the conversion isn't technically "complete" until those are done too.
|
| [6636]
|
johnjamesjacoby
|
Converter: Update `bbp_converter_status()` to use current step.
When actually converting data, this step is only bumped when moving between major events, not minors.
|
| [6834]
|
johnjamesjacoby
|
Converter: UX improvements to import experience:
* Move Monitor to upper-right
* Move actions into Monitor
* Make database fields read-only when importer is running
* Add a spinner
See #3207 for inspiration.
|
| [6634]
|
johnjamesjacoby
|
Converter: Tweak description of `restart` setting to better hint at what it does.
|
| [6472]
|
johnjamesjacoby
|
Converter: Styling updates
* Move all admin CSS & JS into `/admin/assets/`
* Introduce `converter.js` and refactor code out of `admin_head()` method
* Move converter styling into `common.css`
* Update some surrounding styling, verbiage, and mark-up to better handle errors and user feedback
|
| [6471]
|
johnjamesjacoby
|
Converter: Styling updates
* Move all admin CSS & JS into `/admin/assets/`
* Introduce `converter.js` and refactor code out of `admin_head()` method
* Move converter styling into `common.css`
* Update some surrounding styling, verbiage, and mark-up to better handle errors and user feedback
|
| [6129]
|
johnjamesjacoby
|
Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (Trunk, for 2.6)
|
| [6130]
|
johnjamesjacoby
|
Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (2.5 branch, for 2.5.12)
|
| [6833]
|
johnjamesjacoby
|
Converter: Remove unused argument in `clean()` method usage.
See #3207.
|
| [6716]
|
johnjamesjacoby
|
Converter: Remove duplicate `class` attribute on DB password field.
|
| [6447]
|
johnjamesjacoby
|
Converter: Refresh to registered settings
* `ksort()` the Platform list, and exclude "Example" since it's not usable
* Turn some `text` fields into `number` fields, with reasonable boundaries
* Add `code` classes to database fields
* Update some labels & descriptions
Fixes #3095.
|
| [6514]
|
johnjamesjacoby
|
Converter: Port changes proposed for 2.7 in for 2.6:
* Add a timer UI to show the count down until the next step
* Move converter settings into the normal options & settings arrays
* Update fields, sections, & pages as needed
* Update `converter.js` version to use `bbp_get_version()`
* Make connection & options persistent across requests whenever possible, and trust the settings if settings change
* Split steps up into private methods, out of the massive `do_steps()` method
|
| [6456]
|
johnjamesjacoby
|
Converter: Multiple converter improvements
* Move classes into their own files
* Move `converter.php` into `/admin/tools/`
* Escape output of translated strings where possible
* Introduce `bbp_converter_db_connection_failed` error handler, in the event the origin database connection cannot be established
* Sets `WP_SETUP_CONFIG` constant to `true` to control `$wpdb->db_connect()` bail from using `db-error.php`
* Use `sanitize_text_field()` on database connection values
* Invisibly default to `DB_` constants if database connection values are empty
* introduce `convert_users` class parameter to limit direct touches to `$_POST` value
* Smarter defaults for converter options
|
| [6459]
|
johnjamesjacoby
|
Converter: More stylistic improvements
* Use "Import Monitor" metabox vs. old ugly plain yellow `div`
* Improve messaging around existing/incomplete import status/query/steps
* `17` total steps is kind-of a bad guess, but better than nothing
* Likely more can be done here in 2.7 as this matures in the public eye
|
| [6457]
|
johnjamesjacoby
|
Converter: Make sure the sync-table has a chance to be made on first run when not cleaning.
Also default `$start` values to `1` in the event some empty value is erroneously passed through.
|
| [6640]
|
johnjamesjacoby
|
Converter: Make it all work again!
* Send a response when a step is complete (to trigger the subsequent step)
* Remove `min` class variable, and use `start` everywhere instead
* Move giant step switch into a `steps` array instead (a lot more can be done here later)
* Break apart a few private methods to make the call stack easier to follow
* Store the `platform` for use in inherited objects later
This commit makes the converter work again, tested against a few large database dumps from several platforms to confirm.
|
| [6638]
|
johnjamesjacoby
|
Converter: Introduce `update_query()` method, to help with updating the last query option.
This abstracts the `update_option()` approach for future scrutiny.
|
| [6448]
|
johnjamesjacoby
|
Converter: Introduce `bbp_get_converters()` to DRY the directory crawling code.
Also allows converters to be filtered, should someone want to include their own in a plugin.
See #3095.
|
| [6458]
|
johnjamesjacoby
|
Converter: Improve error responses and UX when converter halts.
|
| [6679]
|
johnjamesjacoby
|
Converter: Improve `clean` logic when checking for deleted activity.
This change fixes a condition where meta-data is out-of-sync with posts or users, resulting in a false assignment of `true` when there actually is no data to delete, and no data has been deleted. Now when this happens, the converter will proceed as intended.
Trunk, for 2.6.
|
| [6195]
|
netweb
|
Converter: Give `!` usages some breathing room.
|
| [6650]
|
SergeyBiryukov
|
Converter: Fix typo and improve wording of Database Settings section labels.
Props jrf.
Fixes #3143.
|
| [6635]
|
johnjamesjacoby
|
Converter: Don't use `delete_option()` on converter options.
Default option filters are breaking `update_option()` return values when options do not exist, so remove this optimization and save it for when a conversion is completed.
This needs more looking into.
|
| [6599]
|
johnjamesjacoby
|
Converter: Default values to `0` so converter starts correctly.
|
| [6184]
|
johnjamesjacoby
|
Converter: Convert favorites & subscriptions to `postmeta` vs. `usermeta`.
* Update table names
* Support for comma-separated string values
* Use strict comparisons where it makes sense to
See #2959, #2668.
|
| [6460]
|
johnjamesjacoby
|
Converter: Code improvements
* Add "Skip" text for steps that are being skipped
* Allow bypassing of importer halting on error
* Update a few strings
* Break some code from `process_callback()` method out into separate private methods
|
| [6632]
|
johnjamesjacoby
|
Converter: Clean user cache when converting a user's password field.
This makes sure the user object is pristine on the subsequent request to it, fixing possible race conditions with authentication errors.
|
| [6658]
|
SergeyBiryukov
|
Converter: Clarify `status_counting` label in Import Monitor.
Props jrf.
Fixes #3147.
|
| [6789]
|
johnjamesjacoby
|
Converter: Call `bbp_setup_converter()` inside of `bbp_user_maybe_convert_pass()`.
This change makes sure the admin-area converter files are included and instantiated from anywhere a user might be logging in from. This fixes a potential fatal error when trying to convert user passwords from old platforms to WordPress after a successful forum conversion has completed.
Fixes #3191.
|
| [6677]
|
johnjamesjacoby
|
Converter: Add toggle to show/hide the database password contents.
This change provides a relatively sane middle-ground for insecure content warnings in the converter, by providing a button to toggle the `password` field back and forth to a `text` field. Ideally, in the future, there will be a legitimate way to do this.
Trunk, for 2.6. See #3153.
|
| [6631]
|
johnjamesjacoby
|
Converter: Add missing `_bbp_converter_convert_users` option key.
Prevents debug notices when also converting user accounts from other platforms.
|
| [6600]
|
johnjamesjacoby
|
Converter: Add `halt` setting for stopping the importer when an error occurs.
Next: implement in Converter.
|
| [6669]
|
johnjamesjacoby
|
Converter: use WordPress smiley URL & path in default `callback_html()` method.
This change makes sure that smiley paths and URLs are correctly converted inside of post content areas. Previous to this, the default `smiley/img.gif` path would be used, resulting in broken smiley images, even after conversion.
Trunk, for 2.6.
|
| [3863]
|
johnjamesjacoby
|
Converter:
* Whitespace fixes to bbPress1 converter
* Fix incorrect fieldname
* See #1820
|
| [4008]
|
johnjamesjacoby
|
Converter:
* Use type "password" on DB password input field.
* Fixes #1858.
|
| [4161]
|
johnjamesjacoby
|
Converter:
* Use sanitize_title() instead of sanitize_title_with_slashes().
* Fix issue with character encoding.
* Fixes #1929 for 2.2 branch.
|
| [4160]
|
johnjamesjacoby
|
Converter:
* Use sanitize_title() instead of sanitize_title_with_slashes().
* Fix issue with character encoding.
* Fixes #1929 for 2.1 branch.
|
| [3874]
|
johnjamesjacoby
|
Converter:
* Use $_POST rows in process_callback() method so math matches
* See #1820
|
| [4055]
|
johnjamesjacoby
|
Converter:
* Update verbiage of clean and restart checkboxes.
* Audit usage of sync_table(), and make sure table is created correctly.
* When deleting posts, check correct array items.
|
| [3876]
|
johnjamesjacoby
|
Converter:
* Tweaks to converter process
* Rename "Recount" to "Repair" and point everything to it as needed
* Add two new repair tools to recalculate the forum ID and topic ID for each post, based on the post_parent values
* See #1820
|
| [4089]
|
johnjamesjacoby
|
Converter:
* Tweak bbp_user_maybe_convert_password() with correct meta key.
* Include missing BBP_Admin() class
* Fixes #1886 (2.2 branch).
* Props netweb, xiosen.
|