| [4322]
|
johnjamesjacoby
|
Pagination:
* Fix bug where topics started, favorites, and subscriptions pagination would link to the root of a users profile.\
* Fixes incorrect filters on topics and replies URL's.
|
| [5515]
|
netweb
|
PHPDdoc corrections for topic and reply pending status approve and unapprove functions. See #2645
|
| [7254]
|
johnjamesjacoby
|
PHPCS: correct return var types in Revisions functions
This change fixes PHPCS/Intelephense warnings.
In branches/2.6, for 2.6.10.
|
| [7046]
|
netweb
|
PHPCS: Use Parenthesis when instantiating a new object.
Props jrf.
See #3294.
For trunk.
|
| [7047]
|
netweb
|
PHPCS: Use Parenthesis when instantiating a new object.
Props jrf.
See #3294.
For branches/2.6.
|
| [7048]
|
netweb
|
PHPCS: Pinking shears.
Props jrf.
See #3294.
For trunk.
|
| [7049]
|
netweb
|
PHPCS: Pinking shears.
Props jrf.
See #3294.
For branches/2.6.
|
| [7253]
|
johnjamesjacoby
|
PHP8: define dependency injected components in BBP_Admin
This change prevents debug warnings in modern versions of PHP (8.0 and higher).
In branches/2.6, for 2.6.10.
|
| [7287]
|
dd32
|
PHP8 compatibility: array_keys() only supports arrays, not null.
|
| [3829]
|
johnjamesjacoby
|
PHP5'ize bbp-core-classes.php.
|
| [7112]
|
xknown
|
PHP 7.4 compat: Replace the deprecated each call
|
| [7113]
|
xknown
|
PHP 7.4 Compat: remove deprecated functions.
|
| [7110]
|
xknown
|
PHP 7.4 Compat: Use square brackets and remove create_function calls.
|
| [7116]
|
xknown
|
PHP 7.4 Compat: Replace the deprecated create_function calls with anonymous functions.
|
| [7111]
|
xknown
|
PHP 7.4 Compat: Remove the create_function calls.
They are deprecated, and they seem to be removed in PHP 8.0.
|
| [7114]
|
xknown
|
PHP 7.4 Compat: Remove deprecated functions.
|
| [7115]
|
xknown
|
PHP 7.4 Compat: Don't use curly braces for array/string access
|
| [5089]
|
johnjamesjacoby
|
PHP 5.4+ E_STRICT improvement to BuddyPress Groups display_forums() method. See #BP5108.
|
| [5048]
|
johnjamesjacoby
|
PHP 5.4 compat and related sanity checks and clean-up. Props boonebgorges. Fixes #2731.
|
| [6451]
|
johnjamesjacoby
|
Où mettre!
|
| [3429]
|
johnjamesjacoby
|
Override canonical redirect when editing topics and replies. Fixes #1594.
|
| [4872]
|
johnjamesjacoby
|
Overload the code tag in the fancy editor, and use backticks instead. Props mzaweb. (trunk)
|
| [4871]
|
johnjamesjacoby
|
Overload the code tag in the fancy editor, and use backticks instead. Props mzaweb. (2.3 branch)
|
| [2496]
|
johnjamesjacoby
|
Output value, not array
|
| [6694]
|
johnjamesjacoby
|
Options: set default database version to `0`.
This change avoids race conditions with the updater when no version exists in the database. This would cause the database version to not be bumped, resulting in rewrite rules being needlessly flushed on each visit to `wp-admin`.
(Also tweak some nearby array values to make them easier to read.)
|
| [6695]
|
johnjamesjacoby
|
Options: break `Features` out from `Settings` section.
This change makes it easier to discern which options are features, and which are settings for those features.
Also updates the inline descriptions for several array items.
|
| [6762]
|
johnjamesjacoby
|
Options: allow default option cache strategy to be filtered, without causing an intercept.
This change brings filter behavior back that was unintentionally removed in r6751.
|
| [6761]
|
johnjamesjacoby
|
Options: Use new `$intercept` value in place of old `$strategy` value.
This change fixes an undefined variable debug notice introduced in r6751.
|
| [6078]
|
netweb
|
Options: Set the default value of `bbp_get_user_slug()` to `users`
This changeset updates the default single user slug from `user` to `users`. The `bbp_get_default_options()` function defines the default as `users` and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug `user` rather than `users`.
Props ocean90.
Fixes #2983
|
| [6072]
|
netweb
|
Options: Fix `bbp_show_on_root()` copy pasta PHPDoc description
|
| [4208]
|
johnjamesjacoby
|
Options:
* Wrap some options loops in array_keys() to prevent making unnecessary $value variables.
|
| [4193]
|
johnjamesjacoby
|
Options:
* Visually section off user slugs in bp_get_options().
|
| [3949]
|
johnjamesjacoby
|
Options:
* Pinking shears on bbp_get_default_options().
* Remove db_version duplicate description.
|
| [3476]
|
johnjamesjacoby
|
Only use at_name filters when BuddyPress activity component is active.
|
| [2616]
|
johnjamesjacoby
|
Only show topic admin links if user has caps
|
| [6095]
|
johnjamesjacoby
|
Only show reply-to drop-down when editing an existing reply.
|
| [4960]
|
johnjamesjacoby
|
Only show allowed tags when not using the fancy editor or user does not have unfiltered_html cap. Also remove function_exists() check for wp_editor().
|
| [4681]
|
johnjamesjacoby
|
Only show BuddyPress Group settings section when viewing bbPress settings for a BuddyPress root blog. Note that using bp_is_root_blog() includes support for BuddyPress's Multiblog mode.
|
| [4880]
|
johnjamesjacoby
|
Only remove filters if bbp_use_wp_editor() is true. See #2317. (trunk)
|
| [4879]
|
johnjamesjacoby
|
Only remove filters if bbp_use_wp_editor() is true. See #2317. (2.3 branch)
|
| [3381]
|
johnjamesjacoby
|
Only overload global access caps if user does not have existing caps.
|
| [5132]
|
johnjamesjacoby
|
Only filter the `bbpress` textdomain with the `bbpress_locale` filter.
Clean up surrounding phpdoc.
|
| [3930]
|
johnjamesjacoby
|
Only filter shortcode queries if query is not already set. Also, use correct filter names.
|
| [3806]
|
johnjamesjacoby
|
Only exclude private/hidden forum content in feeds when not viewing a single forum. Fixes #1782.
|
| [3849]
|
johnjamesjacoby
|
Only enqueue parent theme CSS if parent theme is twentyten.
|
| [3597]
|
johnjamesjacoby
|
Only bail if forums are installed correctly.
|
| [3879]
|
johnjamesjacoby
|
Only apply borders to top of elements in theme compat, for consistency sake.
|
| [3880]
|
johnjamesjacoby
|
Only allow users that can edit other users to change a users role.
|
| [3881]
|
johnjamesjacoby
|
Only allow users that can edit other users to change a users role, and do not allow them to change their own role.
|
| [5081]
|
johnjamesjacoby
|
Only allow topics to have an archive when the forums archive is showing forums (not topics). Fixes SEO concern where it was possible to have duplicate forum-archives at two different URL's.
|
| [5510]
|
johnjamesjacoby
|
Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.
This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270.
|
| [5467]
|
johnjamesjacoby
|
Only add the `s` argument to queries if `rs` or `ts` are set in their respective topics & replies queries.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804].
|
| [5468]
|
johnjamesjacoby
|
Only add the `s` argument to global forum search queries if search-terms exist.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804].
|
| [4723]
|
johnjamesjacoby
|
On single forum view, do not check for forum count when trying to query sub forums. Fixes #2085.
|
| [3447]
|
johnjamesjacoby
|
Obey the blacklisted keys in discussion settings when creating or editing topics or replies. Introduces bbp_check_for_blacklist() function in bbp-common-functions.php, and bbp_current_user_ua() in bbp-user-functions.php.
|
| [3858]
|
johnjamesjacoby
|
Number format fixes:
* Introduce bbp_number_format_i18n
* Clean up number format filters
* Allow empty $number values to be passed safely
|
| [4258]
|
johnjamesjacoby
|
Number Formatting:
* Introduce $integer parameter to template-tags to switch filter for integer usage.
* Use absint() where appropriate when getting counts.
* Smarter int type casting.
* Fixes bug where calculations were being done against formatted strings.
* Fixes #1974.
|
| [4739]
|
johnjamesjacoby
|
Now that mentions are in bbPress core, remove the extra mention code in the BuddyPress activity extension. Fixes #2185.
|
| [3996]
|
johnjamesjacoby
|
Notifications (1.1 branch):
* Check post_status before notifying subscribers, in bb_notify_subscribers().
* Fixes #1479.
* Props jkudish.
|
| [7185]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In trunk for 2.7.0. See #3414.
Props dilipbheda, isabel104.
|
| [7186]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In branches/2.6 for 2.6.7. Fixes #3414.
Props dilipbheda, isabel104.
|
| [4991]
|
johnjamesjacoby
|
Normalize topic and reply admin method names. Some of them were still prefixed from back when all admin methods were in 1 mega-class.
|
| [3233]
|
johnjamesjacoby
|
Normalize the user template files. Add wrapper around user.php template content.
|
| [2863]
|
johnjamesjacoby
|
Normalize tag management files. Use bb_die() where applicable. Swap out destroy_tag verbiage to comply with boolean delete_term results.
|
| [4733]
|
johnjamesjacoby
|
Normalize svn props for .php files, and add missing index.php to /includes/search/ directory.
|
| [5399]
|
johnjamesjacoby
|
Normalize metabox UI across Forums, Topics, & Replies. Hat-tip netweb. Fixes #2463.
|
| [5060]
|
johnjamesjacoby
|
Normalize forum, topic, and reply dropdown form fields and associated functions. Includes several new functions with _get_ equivalents to replace incorrectly named _select() functions.
First pass at adding custom topic status handling. Props jkudish. See #2187.
Also replaces $wpdb->update() calls with wp_update_post() in associated functions. Fixes #2351.
|
| [2810]
|
johnjamesjacoby
|
Normalize bbp-twentyten theme files. Introduce bbp_tab_index functions for forms. Rename some page- files to action- since they are not page templates. Introduce bbp_login and bbp_register place-holders in bbp-twentyten theme.
|
| [2812]
|
johnjamesjacoby
|
Normalize bbp-includes directory. Mostly documentation fixes. Introduce bbp-shortcodes placeholder.
|
| [3312]
|
johnjamesjacoby
|
Normalize archive pages and include content-archive template parts for topics and forums.
|
| [2905]
|
johnjamesjacoby
|
Normalize all post_meta values by removing the _forum, _topic, and _reply prefixes off of them where appropriate. There is no point in having them be unique to the post type as it only duplicates the code needed to perform requests. Future trimming to follow.
Introduce bbp-update.php file, which is used to update existing installations to the new meta_key names from this revision.
|
| [5403]
|
johnjamesjacoby
|
Normalize Favorite and Subscribe links for Forums and Topics so they are visually linear to the breadcrumb. Hat-tip netweb. Fixes #2575.
|
| [4024]
|
johnjamesjacoby
|
Nonces:
* Use bbp_verify_nonce_request() to prevent the awkward wp_die() experience in forums.
* Add nonce checks to subscriptions and favorites.
* More aggressive returns on edit/new forum/topic/reply nonce and capability checks. Prevents surplus processing when we already know nothing more should happen.
* Bail early if bbp_has_errors() rather than wrapping around it.
* Fixes #1863.
|
| [4023]
|
johnjamesjacoby
|
Nonces:
* Introduce bbp_verify_nonce_request() to check nonces on theme-side requests.
* See #1863.
|
| [6012]
|
johnjamesjacoby
|
Nonce functions are part of the `common` component.
|
| [4050]
|
johnjamesjacoby
|
Non Scriptio Continua.
|
| [2845]
|
johnjamesjacoby
|
No follow on all user links, and follow up with stripslashes for good measure.
|
| [4672]
|
johnjamesjacoby
|
Nicename Usage:
* Introduce template tags for getting and displaying a user nicenames. Helpful for themes that want easier access to @mentions data.
* Improve mention filters to use 'slug' instead of 'login.' Fixes possible mismatches when login and nicename are different.
|
| [3746]
|
johnjamesjacoby
|
Next pass at BuddyPress Group Fourms integration:
* Filter forms to prevent fields from appearing
* Output new field data where needed on above forms
* Better integration with group create and edit screens
* Tweak forum/group ID functions to return arrays when needed
* Flesh out display_forums() method
* See #1669
|
| [5043]
|
johnjamesjacoby
|
New approach to content replacement for theme compatability. Rather than juggle the post global and post content around in two procedures, set post_content via bbp_theme_compat_reset_post().
This reduces some complexity, avoids nested shortcodes, and fixes shortcode and the_content filter conflicts. See #2343.
|
| [3936]
|
johnjamesjacoby
|
Narrow the scope of .bbp-topic-permalink styling in bbp-theme-compat.
|
| [2523]
|
johnjamesjacoby
|
Mute the wphead border just a bit
|
| [5385]
|
netweb
|
Multiple strings in .editorconfig sections should be wrapped in curly brackets
Props treyhunner. Fixes #2614
|
| [2471]
|
chrishajer
|
Multiple fixes for email subscriptions. Note the template changes in kakumei. Probably fixes #1268. Big props to dimadin and !GautamGupta
|
| [4784]
|
johnjamesjacoby
|
Multibyte support for excerpts and breadcrumbs. Hat-tip alex-ye. Fixes #2232.
|
| [4933]
|
johnjamesjacoby
|
Move user base setting into new Users section. Tweak some verbiage to be more succinct. See #1500.
|
| [3653]
|
johnjamesjacoby
|
Move trash status background color to wrapper div.
|
| [3190]
|
johnjamesjacoby
|
Move theme compatibility code out of bbp-general-template.php and into bbp-core-compatibility.php.
Swap out require_once() usages for require() through out project where appropriate.
|
| [3734]
|
johnjamesjacoby
|
Move theme compat template files out of bbp-themes and into bbp-theme-compat folder. This avoids confusion with complete bundled theme also acting as the fallback.
|
| [3065]
|
johnjamesjacoby
|
Move theme compat message into dashboard widget
|
| [3345]
|
johnjamesjacoby
|
Move the topic tag form template part out of bbp_has_topics() check, and rely normal 404 handling if tag does not exist.
|
| [2692]
|
johnjamesjacoby
|
Move special query_vars into dedicated functions
|
| [3143]
|
johnjamesjacoby
|
Move shortcodes into object variable, and add php5 constructor. This allows bbPress plugins to filter existing shortcodes, and/or add new ones.
|
| [4593]
|
johnjamesjacoby
|
Move root template check to below reset_post blocks. Fixes incorrect 404 and corrects header statuses when using root templates. See #1478.
|
| [2952]
|
johnjamesjacoby
|
Move revision log updaters from -template files to -function files with other updaters. Update phpDoc in functions that previously ran sanity updates if fields did not exist. Mark @todo's in places where sanity meta updates still exist, and mark for investigation for eventual removal.
|
| [3713]
|
johnjamesjacoby
|
Move return values into variables for easier debugging in bbp-user-template.php.
|
| [4782]
|
johnjamesjacoby
|
Move new topic sticky-check after 'bbp_new_topic' action, to ensure forum ID meta is saved via bbp_update_topic(). Also move sticky-check in edit-topic handler, so correct forum ID is used when moving a sticky topic. Props imath. Fixes #2230.
|
| [2599]
|
johnjamesjacoby
|
Move loader functions out of needless class, and whitespace fixes.
|
| [3284]
|
johnjamesjacoby
|
Move loader functions into bbp-core-hooks. Add bbp_new_site action, which is used to create roles, caps, and options when a new site is created on a multisite installation. Remove is_site_admin() check from bbp_allowed_themes() to ensure bbp-twentyten is available for all sites.
|
| [3728]
|
johnjamesjacoby
|
Move is_super_admin() checks to allow return values to be filtered in bbp-user-template.php.
|