| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [6621]
|
johnjamesjacoby
|
Replies: Normalize `bbp_has_replies()` default search with `bbp_has_topics()`.
This brings parity to how these two functions handle default search parameters.
|
| [6396]
|
johnjamesjacoby
|
Replies: Invert the `$show_none` comparison, to fix the default drop-down text.
Props SergeyBiryukov. Fixes #2617.
|
| [5889]
|
netweb
|
Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
|
| [5880]
|
netweb
|
Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5924]
|
netweb
|
Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
|
| [7293]
|
johnjamesjacoby
|
Replies: Fix a bug that causes replies to not appear in some topics.
In WordPress 6.8, `WP_Query` now enforces a consistent alphabetical order for array values. This change breaks the `_bbp_has_replies_where()` function, which previously relied on a strict comparison against `post_type`.
See: https://core.trac.wordpress.org/ticket/59516
This commit replaces the strict comparison with an `array_diff()` check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to `$query->get()`.
Props vortfu, arl1nd.
Committed to trunk for 2.7.
Fixes #3631.
|
| [7292]
|
johnjamesjacoby
|
Replies: Fix a bug that causes replies to not appear in some topics.
In WordPress 6.8, `WP_Query` now enforces a consistent alphabetical order for array values. This change breaks the `_bbp_has_replies_where()` function, which previously relied on a strict comparison against `post_type`.
See: https://core.trac.wordpress.org/ticket/59516
This commit replaces the strict comparison with an `array_diff()` check to account for the new behavior. It also optimizes the surrounding logic to minimize repeated calls to `$query->get()`.
Props @vortfu.
Committed to the 2.6 branch for 2.6.13.
See #3631.
|
| [6037]
|
netweb
|
Replies: Fix `@param` PHPDoc in `bbp_insert_topic_update_counts()`
See #1799
|
| [6317]
|
johnjamesjacoby
|
Replies: Ensure hierarchical replies are correctly wrapped & concatenated into their output buffers in the correct order.
This updates the walker class to not immediately echo it's contents, and wraps it in an `ul` element.
Fixes #2757. See #2830.
|
| [6553]
|
johnjamesjacoby
|
Replies: Do not update term cache in `bbp_has_replies()`.
This change removes 2 unnecessary database queries from single topic pages. In situations where the leading topic is gathered as part of the `bbp_has_replies()` loop, this still functions as anticipated, and the original topic loop query will handle updating the term cache appropriately.
|
| [7096]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In trunk, for 2.7.0.
Fixes #3376.
|
| [7095]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In branches/2.6, for 2.6.6.
See #3376.
|
| [5894]
|
netweb
|
Replies: Clarify inline doc surrounding `bbp_show_lead_topic()` in `bbp_get_reply_position()`
This changest clarify's the docs on how `bbp_show_lead_topic()` affects a reply's menu order in a topics reply loop and determining the correct pagination of reply URL's.
Includes unit tests for `bbp_reply_position()` and `bbp_get_reply_url()`
Fixes #2845
|
| [6316]
|
johnjamesjacoby
|
Replies: Check for reply hierarchy before assuming topic-title in reply-to.
Fixes a bug causing malformed output when creating a reply via `wp-admin`.
Props tharsheblows . Fixes #2617. See #2844.
|
| [7158]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In trunk, for 2.7. Fixes #3309.
Props dd32, man4toman.
|
| [7157]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In branches/2.6, for 2.6.6. See #3309.
Props dd32, man4toman.
|
| [6363]
|
netweb
|
Replies: Allow `pending` replies to be edited on the front end.
This changeset in `bbp_get_reply_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending replies always have ugly permalinks.
Props SergeyBiryukov.
Fixes #3054.
|
| [6546]
|
johnjamesjacoby
|
Replies: Add `single_row()` method to replies list table when editing a topic.
This lets us use `get_post_class()` on the table rows, so statuses like `pending` or `spam` can be properly in the list for users who have the capability to see them.
See #2587.
|
| [6388]
|
johnjamesjacoby
|
Replies: Add `role="button"` to reply-to links.
Also normalize surrounding "Reply" text escaping.
Fixes #3092. Props alexstine.
|
| [6245]
|
johnjamesjacoby
|
Replies: Add `@since` and link to ticket from r6244.
See #3039.
|
| [4529]
|
johnjamesjacoby
|
Replies:
* When editing a reply, do not append "Reply To:"
* Hat-tip netweb.
* Fixes #2066 (trunk)
|
| [4530]
|
johnjamesjacoby
|
Replies:
* When editing a reply, do not append "Reply To:"
* Hat-tip netweb.
* Fixes #2066 (2.2 branch)
|
| [3999]
|
johnjamesjacoby
|
Replies:
* Update bbp_get_reply_position_raw() to protect against debug notices from a totally missing reply position.
|
| [4063]
|
johnjamesjacoby
|
Replies:
* Missed a 'wp_posts' reference in _bbp_has_replies_where().
* See: #1885.
|
| [4162]
|
johnjamesjacoby
|
Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.2 branch.
|
| [4163]
|
johnjamesjacoby
|
Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.1 branch.
|
| [4062]
|
johnjamesjacoby
|
Replies:
* Add table prefix to _bbp_has_replies_where().
* See: #1885.
|
| [4522]
|
johnjamesjacoby
|
Replies:
* Add ability to move a reply into a new topic, or into an existing topic.
* Includes new template part, new extra page template, and functions for handling the data move and template output.
* Props jmdodd.
* Fixes #1900.
|
| [5349]
|
netweb
|
Replies now use the reply ID for the the post name/slug via r5117.
bbPress' importers should also reflect that change with the removal of 'Reply Title' (post_title), 'Reply Slug' (post_name) and `callback_reply_title` from all importers. Props netweb. Fixes #2585
|
| [5119]
|
johnjamesjacoby
|
Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.5)
|
| [5118]
|
johnjamesjacoby
|
Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.4.1)
|
| [3010]
|
johnjamesjacoby
|
Replace underscores in admin dashboard widget ID with hyphens. Move clearing br outside of update_plugins cap check to prevent display issues for normal users.
|
| [4974]
|
johnjamesjacoby
|
Replace the_content() with bbp_forum_content() where appropriate. Fixes recursion issues introduced in r4792, as part of http://buddypress.trac.wordpress.org/ticket/5021
|
| [4783]
|
johnjamesjacoby
|
Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.
|
| [4369]
|
johnjamesjacoby
|
Replace instances of 'bbPress' string output with 'Forums' in admin settings.
|
| [3116]
|
johnjamesjacoby
|
Replace incorrect query args ('post_author' with correct 'author'.) Fixes #1511. Props cnorris23.
|
| [3627]
|
johnjamesjacoby
|
Replace get_class() calls with is_a() where applicable.
|
| [4996]
|
johnjamesjacoby
|
Replace generic stdClass usages with correct object types.
Fixes debug notices with bbp_get_displayed_user_field() when requesting non-existing fields or when there is no displayed user, by allowing the magic __get() methods of the WP_User class to bail if the field is not set.
Also prevents similar issues with main query loops. Fixes #2359.
|
| [6958]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa.
|
| [6959]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa (for trunk)
|
| [4581]
|
jmdodd
|
Replace esc_attr() with urlencode() when adding search terms query args.
* Fixes #2110.
|
| [2596]
|
johnjamesjacoby
|
Replace constants with $bbp global. Rename 'post type' references to 'content type.' Various human readability fixes.
|
| [4833]
|
johnjamesjacoby
|
Replace body class 'bbPress' with 'bbpress' -- CSS classes are case insensitive, but we should stick to common conventions to avoid confusion. Props ethitter/boonebgorges.
|
| [5356]
|
johnjamesjacoby
|
Replace `function_exists()` checks with `is_callable()` in template stack functions. Props boonebgorges. See: http://buddypress.trac.wordpress.org/ticket/5671
|
| [2557]
|
johnjamesjacoby
|
Replace 'topic_reply' references with 'reply' (this includes the post_type ID)
|
| [3475]
|
johnjamesjacoby
|
Replace 'bp_forums_strip_mentions_on_post_edit' filters with custom class method to prevent load order issues with BuddyPress forums component.
|
| [2648]
|
johnjamesjacoby
|
Replace $_GET['post_type'] references with $typenow global in admin. Props nacin
|
| [6495]
|
johnjamesjacoby
|
Repairs: Prefer `empty()` over `! isset()` in `bbp_admin_repair_group_forum_relationship()`
The `meta_value` key will always be set, because of the way the forum query is written.
See #2829.
|
| [6428]
|
johnjamesjacoby
|
Repair: In `bbp_repair_forum_visibility()`, don't bail if an error occurs.
Instead, skip the erroneous results and update the valid ones.
|
| [6933]
|
johnjamesjacoby
|
Repair Tools: rename forum reply hidden count function, and fix default sort order.
This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
|
| [7134]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In trunk, for 2.7.
See #3310.
|
| [7135]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In branches/2.6, for 2.6.6.
See #3310.
|
| [4740]
|
johnjamesjacoby
|
Reorder topic and reply content code filters to fix entity issue inside code blocks.
|
| [2858]
|
johnjamesjacoby
|
Rename topic_id, forum_id, and reply_id global vars to _post_type to more accurately describe what they are. Include template functions to retrieve those values, and use them through-out the project. Normalize component updater functions and remove surplus calculations from them. Temporarily unhook filters from split/join/deletion actions until new routines can be created to handle forum and topic recounts.
|
| [2935]
|
johnjamesjacoby
|
Rename the 'ignore_sticky_topics' flag to 'show_stickies' and reverse logic to default to true instead of false. This is more natural behavior in the logic that we are turning something off with the word 'false' rather than ignoring stickies with the word 'true'
|
| [2704]
|
johnjamesjacoby
|
Rename sticky option keys
|
| [2558]
|
johnjamesjacoby
|
Rename single topic_reply template file to match new post_type ID
|
| [3376]
|
johnjamesjacoby
|
Rename remaining functions prefixed with an underscore.
|
| [2626]
|
johnjamesjacoby
|
Rename private functions and fix themes url.
|
| [5071]
|
johnjamesjacoby
|
Rename link class to match function and output, and remove some duplicate escapings. See #2090.
|
| [3223]
|
johnjamesjacoby
|
Rename just-in-time filters for editing topics and replies. Copy pasta. See r3222.
|
| [2485]
|
johnjamesjacoby
|
Rename files and directories from bb- to bbp-. Add topics loop functions. Fix forum/topic post row columns. Add functions and filters files.
|
| [3726]
|
johnjamesjacoby
|
Rename bbp_reset_post_data() to bbp_theme_compat_reset_post_data() to properly separate it from other functions.
|
| [4808]
|
johnjamesjacoby
|
Rename bbp_pre_get_posts_exclude_forums() to bbp_pre_get_posts_normalize_forum_visibility(), to better describe what it does.
bbp_pre_get_posts_normalize_forum_visibility() is a dual purpose function, responsible for normalizing the post_status and post_parent scopes of bbPress related forum queries, against the current users capabilities. This means it must include forums for capable users, and exclude them for incapable users.
See #2221.
|
| [2494]
|
PeteMall
|
Rename bbp_get_topic_forum_ID to bbp_get_topic_forum_id for consistency.
|
| [2722]
|
johnjamesjacoby
|
Rename bbp_get_modified_date function to bbp_convert_date since we no longer use the modified_date for freshness.
|
| [2602]
|
johnjamesjacoby
|
Rename bbp-templatetags to bbp-template
|
| [2753]
|
johnjamesjacoby
|
Rename bbp-filters.php to bbp-hooks.php, and move a majority of actions/filters into it. Introduce ability to edit topics/posts from front-end of theme, and consequently introduce page-bbp_edit.php. Also includes various phpDoc clean-up. Props !GautamGupta via Google Code-in
|
| [6508]
|
johnjamesjacoby
|
Rename `base_dir` to `basepath` for consistency.
|
| [3049]
|
johnjamesjacoby
|
Rename _unset_queries to _unset_globals in BPP_Shortcodes, and ensure shortcodes that use custom queries are unset before and after they run.
|
| [5065]
|
johnjamesjacoby
|
Rename Walker class parameters to prevent PHP5.4 E_STRICT warnings.
|
| [5323]
|
netweb
|
Rename PHPUnit config file from phpunit.xml to phpunit.xml.dist
* PHPUnit supports config files with both these names, but will use phpunit.xml over the .dist version.
* Renaming our file lets users add/edit their own phpunit.xml without editing a bbPress core file.
* Hattip djpaul via [BuddyPress:r8098]
* Props netweb. See #2542
|
| [5045]
|
johnjamesjacoby
|
Rename 'template-tags' files to 'template' to match core conventions. Also rename BuddyPress Groups extension from 'group' to 'groups'.
|
| [3283]
|
johnjamesjacoby
|
Rename 'general' component and related files to 'common'
|
| [2977]
|
johnjamesjacoby
|
Rename $wp_query param in bbp_pre_get_posts to $posts_query to avoid conflict with $wp_query global.
Use $posts_query->get() in place of get_query_arg() to prevent errors in rare cases where $wp_query global is not set.
Fixes #1493 again.
|
| [3302]
|
johnjamesjacoby
|
Rename "no" template parts to "feedback" and add new "Already Logged In" feedback part.
Add login, register, and lost password shortcodes.
Rename single tag shortcode to prevent conflict with all-tags shortcode.
|
| [2982]
|
johnjamesjacoby
|
Rename "#reply" ID to "#post' for easy backwards compatibility with stand-alone permalinks.
|
| [3819]
|
johnjamesjacoby
|
Remove whitespace before get_header() calls in bbp-theme-compat root files.
|
| [3393]
|
johnjamesjacoby
|
Remove unused user-posts.php template file from bbp-twentyten.
|
| [3310]
|
johnjamesjacoby
|
Remove unused bbp_new_forum_admin_handler() function, and move $parent_id check into metabox_save(). Fixes #1555. Props DJPaul for original catch.
|
| [3211]
|
johnjamesjacoby
|
Remove unused archive slugs from bbp_add_options()
|
| [3296]
|
johnjamesjacoby
|
Remove unused admin topic save handler function. See r3295
|
| [5255]
|
johnjamesjacoby
|
Remove unused admin area binary assets, including about page badges, top level menu icons, and retired icon32's. This is all handled by Dashicons going forward. Fixes #2513.
|
| [3555]
|
johnjamesjacoby
|
Remove unused $is_edit param in anonymous user data function, and clean up some whitespace.
|
| [3593]
|
johnjamesjacoby
|
Remove unused $bp global in bbp_filter_user_id()
|
| [4799]
|
johnjamesjacoby
|
Remove unnecessary capability check for post-status trash fix. Props alex-ye. Fixes #2255.
|
| [2647]
|
johnjamesjacoby
|
Remove typo from r2646 props nacin
|
| [3039]
|
johnjamesjacoby
|
Remove tr:hover styling from moderation links as it doesn't play nicely with all themes in compatability mode.
|
| [3749]
|
johnjamesjacoby
|
Remove topic_ prefix from topics admin methods.
|
| [2995]
|
johnjamesjacoby
|
Remove thumbnail and excerpt from custom post type supports arrays, and add revisions to forums. Topic/reply thumbnails and excerpts will make great plugins for themes that support this in the future.
|
| [5172]
|
johnjamesjacoby
|
Remove theme-compat `head_scripts` and move JS into separate files for each condition. Fixes #2454.
|
| [3783]
|
johnjamesjacoby
|
Remove theme setup action from bbp-core-actions.php, as it's now in the bbPress class.
* Tweak inline doc for bbp_load_theme_functions action
* Trust bbp_setup_theme_compat() to set the theme compat regardless of what's there
* See #1766
|
| [3072]
|
johnjamesjacoby
|
Remove the tr:hover style as it conflicts with certain themes and theme compatibility.
|
| [5307]
|
johnjamesjacoby
|
Remove the now-empty `includes/admin/images` directory. Props netweb. See #2542.
|
| [4848]
|
johnjamesjacoby
|
Remove the global cache group, and update existing cache group keys to be more descriptive. Fixes issues with cached queries stomping each other on multisite installations. Fixes #2294.
|
| [3301]
|
johnjamesjacoby
|
Remove the create topic form from view shortcodes.
|
| [3596]
|
johnjamesjacoby
|
Remove the PHP4 constructor helper in main bbPress class. (2.1)
|
| [5364]
|
johnjamesjacoby
|
Remove text-zoom override from default responsive theme-compat styling (themes should have this covered.)
|