| [5617]
|
netweb
|
Restore PHP 5.2 to Travis CI
* Travis restored PHP 5.2 support late last week.
Fixes #2753
|
| [5013]
|
johnjamesjacoby
|
Responsive styling to default templates. Huge props mercime. Fixes #1933.
|
| [3083]
|
johnjamesjacoby
|
Resort rules in bbPress::generate_rewrite_rules()
|
| [2818]
|
johnjamesjacoby
|
Resetting EOL style to native through-out plugin branch.
|
| [6759]
|
johnjamesjacoby
|
Reset: DRY out the `bbp_admin_reset_database()` logic.
This change introduces a helper function for running queries and producing user feedback based on those results. It also introduces a `Skipped` result if the query is invalid or empty. Ultimately, this results in fewer repeated lines of code, fewer reused local variables, and an easier to understand code flow.
An old, leftover routine for removing `forum-mod` taxonomy terms was also removed, as that approach was abandoned during the 2.6 development cycle but was missed when other refactoring was done.
|
| [3087]
|
johnjamesjacoby
|
Reset the post data in the _unset_globals() shortcode function
|
| [3394]
|
johnjamesjacoby
|
Reset the post data at the end of each have_posts loop.
|
| [3089]
|
johnjamesjacoby
|
Reset the img.avatar float to none for theme compat
|
| [7017]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.7, trunk.
|
| [7016]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.6.3, branches/2.6.
|
| [4656]
|
johnjamesjacoby
|
Reprioritize revision log appending filters to 99, to avoid possibly escaping the full HTML output. Fixes #2131.
|
| [4748]
|
johnjamesjacoby
|
Reprioritize autoembeds to before make_clickable(), to fix broken autoembeds. Fixes #2192.
|
| [4277]
|
johnjamesjacoby
|
Reply Titles:
* Attribute 'maxlength' not allowed on hidden fields.
* See #1996.
|
| [3938]
|
johnjamesjacoby
|
Reply Position:
* Fix issue with new reply_position logic when posting a rew reply.
* Bump the position by one if lead topic is in the replies loop.
* Fixes #1841.
|
| [3940]
|
johnjamesjacoby
|
Reply Position/URL:
* Updates to bbp_get_reply_url() to simplify some logic.
* Move $wp_rewrite global to only where it's needed.
* Move reply position bump to bbp_get_reply_position().
* Fixes #1842. Props WCMKE.
|
| [3941]
|
johnjamesjacoby
|
Reply Position/URL:
* Always cast the return value of bbp_get_reply_position() as an integer.
* See #1842.
|
| [3934]
|
johnjamesjacoby
|
Reply Position Improvements:
* Add _update_ and _raw functions for reply positioning.
* Use these functions through-out the codebase as needed.
* Maintains the existing bbp_get_reply_position() behavior, so it's backwards compatible.
* Fixes #1840.
|
| [3274]
|
johnjamesjacoby
|
Reply "View" action link should link to reply URL and not the permalink for the reply, since not all themes will support single reply views. Unset the "View" link if user is viewing trash and does not have proper caps.
|
| [6826]
|
johnjamesjacoby
|
Replies: use existing `reply_to` value if none is passed.
This change fixes a bug that would cause the reply hierarchy to be broken when non-moderator users would edit their existing replies within the allotted editing period.
Props wpdennis. Fixes #3205.
|
| [7241]
|
johnjamesjacoby
|
Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In trunk, for 2.7.0.
Props mdjwel via GitHub pull request.
|
| [7242]
|
johnjamesjacoby
|
Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In branches/2.6, for 2.6.10.
Props mdjwel via GitHub pull request.
|
| [6096]
|
johnjamesjacoby
|
Replies: use `appendChild` vs. `insertBefore` for inline JS replies.
Fixes #2971. Props r-a-y.
|
| [7141]
|
johnjamesjacoby
|
Replies: remove unintended duplicate array_filter() call from r7140.
|
| [7130]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In trunk, for 2.7.
See #3385.
|
| [7131]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In branches/2.6, for 2.6.6.
See #3385.
|
| [7142]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In trunk, for 2.7. Fixes #3409.
|
| [7140]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In branches/2.6, for 2.6.6. See #3409.
|
| [6717]
|
johnjamesjacoby
|
Replies: performance optimization to `bbp_update_reply_position()`.
This change uses `wpdb::update()` instead of `wp_update_post()` and juggles the `bbp_clean_post_cache()` filter, retaining object caches of related posts and queries, and also removes other unintended `edit_post` action interference.
Fixes #3169.
|
| [6706]
|
johnjamesjacoby
|
Replies: introduce `bbp_get_public_reply_statuses()` to speed-up reply queries.
This change removes the `closed` post status from several reply-only queries, ensuring that query indexes are used effectively. It also brings parity to the Replies component that exists in both Forums & Topics.
|
| [6427]
|
johnjamesjacoby
|
Replies: fix incorrect inline doc in `bbp_current_user_can_access_create_reply_form()`.
|
| [7173]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In trunk for 2.7.0. See #3327.
Props mjonesnerdery.
|
| [7174]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In branches/2.6 for 2.6.7. Fixes #3327.
Props mjonesnerdery.
|
| [7148]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In trunk, for 2.7. Fixes #3385.
|
| [7147]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In branches/2.6, for 2.6.6. See #3385.
|
| [5859]
|
johnjamesjacoby
|
Replies: fallback on `post_parent` in `bbp_update_reply_walker()`.
This changeset fixes a bug where topic reply counts were not updated when replies were permanently deleted, causing hidden reply counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [6964]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.7, trunk.
|
| [6965]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.6.2, branches/2.6.
|
| [7010]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.7, trunk.
|
| [7011]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6.
|
| [7179]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In trunk for 2.7.0. See #3386.
|
| [7180]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In branches/2.6 for 2.6.7. Fixes #3386.
|
| [7177]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In trunk for 2.7.0. See #3366.
Props immeet94.
|
| [7178]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In branches/2.6 for 2.6.7. See #3366.
Props immeet94.
|
| [6721]
|
johnjamesjacoby
|
Replies: Update tests for `test_bbp_get_reply_position()`.
This change makes sure that updating a reply position to zero is still possible, also ensuring that tests continue to pass as expected.
|
| [6246]
|
johnjamesjacoby
|
Replies: Update `bbp_thread_replies()` to skip user profile pages.
* Move from core/options to replies/functions, since this isn't directly an option
* Add `! bbp_is_single_user_replies()` check to force `false` if so
* Update threaded replies pagination to re-include verbiage.
Fixes #3002.
|
| [6980]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk.
|
| [6979]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6.
|
| [7138]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In trunk, for 2.7. See #3379.
|
| [7139]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In branches/2.6, for 2.6.6. See #3379.
|
| [5891]
|
netweb
|
Replies: Remove previous `menu_order` default from `bbp_insert_reply()` missed in r5889
Antiprops netweb. See #2843.
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [6621]
|
johnjamesjacoby
|
Replies: Normalize `bbp_has_replies()` default search with `bbp_has_topics()`.
This brings parity to how these two functions handle default search parameters.
|
| [6396]
|
johnjamesjacoby
|
Replies: Invert the `$show_none` comparison, to fix the default drop-down text.
Props SergeyBiryukov. Fixes #2617.
|
| [5889]
|
netweb
|
Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
|
| [5880]
|
netweb
|
Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5924]
|
netweb
|
Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
|
| [6037]
|
netweb
|
Replies: Fix `@param` PHPDoc in `bbp_insert_topic_update_counts()`
See #1799
|
| [6317]
|
johnjamesjacoby
|
Replies: Ensure hierarchical replies are correctly wrapped & concatenated into their output buffers in the correct order.
This updates the walker class to not immediately echo it's contents, and wraps it in an `ul` element.
Fixes #2757. See #2830.
|
| [6553]
|
johnjamesjacoby
|
Replies: Do not update term cache in `bbp_has_replies()`.
This change removes 2 unnecessary database queries from single topic pages. In situations where the leading topic is gathered as part of the `bbp_has_replies()` loop, this still functions as anticipated, and the original topic loop query will handle updating the term cache appropriately.
|
| [7096]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In trunk, for 2.7.0.
Fixes #3376.
|
| [7095]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In branches/2.6, for 2.6.6.
See #3376.
|
| [5894]
|
netweb
|
Replies: Clarify inline doc surrounding `bbp_show_lead_topic()` in `bbp_get_reply_position()`
This changest clarify's the docs on how `bbp_show_lead_topic()` affects a reply's menu order in a topics reply loop and determining the correct pagination of reply URL's.
Includes unit tests for `bbp_reply_position()` and `bbp_get_reply_url()`
Fixes #2845
|
| [6316]
|
johnjamesjacoby
|
Replies: Check for reply hierarchy before assuming topic-title in reply-to.
Fixes a bug causing malformed output when creating a reply via `wp-admin`.
Props tharsheblows . Fixes #2617. See #2844.
|
| [7158]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In trunk, for 2.7. Fixes #3309.
Props dd32, man4toman.
|
| [7157]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In branches/2.6, for 2.6.6. See #3309.
Props dd32, man4toman.
|
| [6363]
|
netweb
|
Replies: Allow `pending` replies to be edited on the front end.
This changeset in `bbp_get_reply_edit_url()` switches from detecting pretty permalinks using `bbp_use_pretty_urls()` to detect the query string for `?` instead, this is due to pending replies always have ugly permalinks.
Props SergeyBiryukov.
Fixes #3054.
|
| [6546]
|
johnjamesjacoby
|
Replies: Add `single_row()` method to replies list table when editing a topic.
This lets us use `get_post_class()` on the table rows, so statuses like `pending` or `spam` can be properly in the list for users who have the capability to see them.
See #2587.
|
| [6388]
|
johnjamesjacoby
|
Replies: Add `role="button"` to reply-to links.
Also normalize surrounding "Reply" text escaping.
Fixes #3092. Props alexstine.
|
| [6245]
|
johnjamesjacoby
|
Replies: Add `@since` and link to ticket from r6244.
See #3039.
|
| [4529]
|
johnjamesjacoby
|
Replies:
* When editing a reply, do not append "Reply To:"
* Hat-tip netweb.
* Fixes #2066 (trunk)
|
| [4530]
|
johnjamesjacoby
|
Replies:
* When editing a reply, do not append "Reply To:"
* Hat-tip netweb.
* Fixes #2066 (2.2 branch)
|
| [3999]
|
johnjamesjacoby
|
Replies:
* Update bbp_get_reply_position_raw() to protect against debug notices from a totally missing reply position.
|
| [4063]
|
johnjamesjacoby
|
Replies:
* Missed a 'wp_posts' reference in _bbp_has_replies_where().
* See: #1885.
|
| [4162]
|
johnjamesjacoby
|
Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.2 branch.
|
| [4163]
|
johnjamesjacoby
|
Replies:
* Do not force single topic query to use specific indexes if also doing a meta query.
* Fixes #1938 for 2.1 branch.
|
| [4062]
|
johnjamesjacoby
|
Replies:
* Add table prefix to _bbp_has_replies_where().
* See: #1885.
|
| [4522]
|
johnjamesjacoby
|
Replies:
* Add ability to move a reply into a new topic, or into an existing topic.
* Includes new template part, new extra page template, and functions for handling the data move and template output.
* Props jmdodd.
* Fixes #1900.
|
| [5349]
|
netweb
|
Replies now use the reply ID for the the post name/slug via r5117.
bbPress' importers should also reflect that change with the removal of 'Reply Title' (post_title), 'Reply Slug' (post_name) and `callback_reply_title` from all importers. Props netweb. Fixes #2585
|
| [5119]
|
johnjamesjacoby
|
Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.5)
|
| [5118]
|
johnjamesjacoby
|
Replace user_trailingslashit() with trailingslashit() in bbp_get_search_results_url(). Fixes issues with search results pages missing a slash when the permalink structure does not include a trailing slash by default. Fixes #2441. (2.4.1)
|
| [3010]
|
johnjamesjacoby
|
Replace underscores in admin dashboard widget ID with hyphens. Move clearing br outside of update_plugins cap check to prevent display issues for normal users.
|
| [4974]
|
johnjamesjacoby
|
Replace the_content() with bbp_forum_content() where appropriate. Fixes recursion issues introduced in r4792, as part of http://buddypress.trac.wordpress.org/ticket/5021
|
| [4783]
|
johnjamesjacoby
|
Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.
|
| [4369]
|
johnjamesjacoby
|
Replace instances of 'bbPress' string output with 'Forums' in admin settings.
|
| [3116]
|
johnjamesjacoby
|
Replace incorrect query args ('post_author' with correct 'author'.) Fixes #1511. Props cnorris23.
|
| [3627]
|
johnjamesjacoby
|
Replace get_class() calls with is_a() where applicable.
|
| [4996]
|
johnjamesjacoby
|
Replace generic stdClass usages with correct object types.
Fixes debug notices with bbp_get_displayed_user_field() when requesting non-existing fields or when there is no displayed user, by allowing the magic __get() methods of the WP_User class to bail if the field is not set.
Also prevents similar issues with main query loops. Fixes #2359.
|
| [6958]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa.
|
| [6959]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa (for trunk)
|
| [4581]
|
jmdodd
|
Replace esc_attr() with urlencode() when adding search terms query args.
* Fixes #2110.
|
| [2596]
|
johnjamesjacoby
|
Replace constants with $bbp global. Rename 'post type' references to 'content type.' Various human readability fixes.
|
| [4833]
|
johnjamesjacoby
|
Replace body class 'bbPress' with 'bbpress' -- CSS classes are case insensitive, but we should stick to common conventions to avoid confusion. Props ethitter/boonebgorges.
|
| [5356]
|
johnjamesjacoby
|
Replace `function_exists()` checks with `is_callable()` in template stack functions. Props boonebgorges. See: http://buddypress.trac.wordpress.org/ticket/5671
|
| [2557]
|
johnjamesjacoby
|
Replace 'topic_reply' references with 'reply' (this includes the post_type ID)
|
| [3475]
|
johnjamesjacoby
|
Replace 'bp_forums_strip_mentions_on_post_edit' filters with custom class method to prevent load order issues with BuddyPress forums component.
|
| [2648]
|
johnjamesjacoby
|
Replace $_GET['post_type'] references with $typenow global in admin. Props nacin
|
| [6495]
|
johnjamesjacoby
|
Repairs: Prefer `empty()` over `! isset()` in `bbp_admin_repair_group_forum_relationship()`
The `meta_value` key will always be set, because of the way the forum query is written.
See #2829.
|
| [6428]
|
johnjamesjacoby
|
Repair: In `bbp_repair_forum_visibility()`, don't bail if an error occurs.
Instead, skip the erroneous results and update the valid ones.
|
| [6933]
|
johnjamesjacoby
|
Repair Tools: rename forum reply hidden count function, and fix default sort order.
This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
|