| [6027]
|
johnjamesjacoby
|
Statuses, Types, Visibilities: `bbp_get_topic_types()` usages were missed in r6026.
See #2954.
|
| [6026]
|
johnjamesjacoby
|
Statuses, Types, Visibilities: Pass the forum, topic, or reply ID into helper functions.
These ID's pass additional context into respective filters, useful for fine-grained control over UI elements.
This commit normalizes the way these functions work across all of bbPress where applicable, by ensuring all similar functions accept an ID and assume `0` by default. Note that there are currently 2 locations where no ID exists to pass context into, which is by design.
Fixes #2954.
|
| [6786]
|
johnjamesjacoby
|
Stats: Whitespace adjustments to some statistics functions.
See #3196.
|
| [7236]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In trunk for 2.7.0. Fixes #3428.
|
| [7237]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In branches/2.6 for 2.6.10. Fixes #3428.
|
| [6542]
|
johnjamesjacoby
|
Statistics: Improvements to "At a Glance" integration.
* Prefer `bbp_get_total_users()` over `count_users()` to speed up loading
* Don't include empty array values
* Don't link to areas the current user cannot access
* Skip if current user cannot at least spectate (blocked or no access)
Fixes #2770.
|
| [6543]
|
johnjamesjacoby
|
Statistics: Define the `$statistics` array.
This change prevents debug notices, particularly in higher PHP versions (+7.0)
See #2770.
|
| [4510]
|
johnjamesjacoby
|
Statistics:
* Add widget and shortcode for forum statistics.
* Props MZAWeb.
* Fixes #2052.
|
| [5951]
|
netweb
|
Standardize `@since` PHPDoc tags style and format
* e.g. `@since 2.6.0 bbPress (r5951) YOLO`
* See http://phpdoc.org/docs/latest/references/phpdoc/tags/since.html
This changeset updates the style and formatting of all of our `@since` instances for compatibility with phpDocumentor 2 and WP-Parser as we move toward implementing the bbPress developer code reference.
Props thebrandonallen
Fixes #2879
|
| [4176]
|
johnjamesjacoby
|
Stand tall, little T.
|
| [3106]
|
johnjamesjacoby
|
Split user template files up into parts for shortcode usage.
|
| [5406]
|
johnjamesjacoby
|
Split secondary topic spam/trash/unspam/untrash actions into separate functions to be used during topic status transition. See #2494.
|
| [3755]
|
johnjamesjacoby
|
Split bbp-core-hooks.php into two files:
* bbp-core-actions.php
* bbp-core-filters.php
* Update bbpress.php to load new files
* Update phpdoc
|
| [3095]
|
johnjamesjacoby
|
Split bbp-admin.php up into smaller, more manageable parts for forums, topics, replies, users, and metaboxes. Add checks for ABSPATH to each file so that they cannot be accessed outside of WordPress. Adjust the location of the admin menu separator based on use caps and visible menus.
|
| [2790]
|
johnjamesjacoby
|
Split apart bbp-functions.php into smaller, more manageable files. Also fix missing global on subscription removal. Props !GautamGupta via Google Code-in
|
| [3811]
|
johnjamesjacoby
|
Split admin tools Recount into two functions to handle form submission without duplicate admin notices. Fixes #1788.
|
| [4968]
|
johnjamesjacoby
|
Split "Main" settings up into "User" and "Features" - also tweak fancy editor verbiage to add more context.
|
| [3252]
|
johnjamesjacoby
|
Spit shine the breadcrumb code to play nicely with root forum archive pages.
|
| [4093]
|
johnjamesjacoby
|
Spelling:
* 'i' before 'e', unless you are me.
* I cannot spell, which gives users a headache.
* For 2.2.
|
| [4092]
|
johnjamesjacoby
|
Spelling:
* 'i' before 'e', unless you are me.
* I cannot spell, which gives users a headache.
* For 2.1.1.
|
| [5518]
|
netweb
|
Spelling typo in `bbp_toggle_reply_handler()`, in between words we use spaces.
|
| [4048]
|
johnjamesjacoby
|
Spelling Police:
* First pass.
* Fixes #1881, #1880.
* Props netweb.
|
| [2865]
|
johnjamesjacoby
|
Speeling fixes
|
| [3444]
|
johnjamesjacoby
|
Speeling and phpdoc fixes. Fixes #1602. Props cnorris23.
|
| [3933]
|
johnjamesjacoby
|
Space.
|
| [3790]
|
johnjamesjacoby
|
Sort forum ID's based on last active time when querying subforum ID's.
* Prevents last active meta data from becoming poisoned when recounting
* See #1534
* Props GargajCNS for initial patch
|
| [2772]
|
johnjamesjacoby
|
Sort by menu_order on forums widget
|
| [2883]
|
johnjamesjacoby
|
Some adjustments to bbp-topic-template.php. Allow capable users to view trashed or private topics on request. Use new author_link function in topic revisions. Do not return a no-break space in bbp_get_topic_admin_links.
|
| [5514]
|
netweb
|
So `.gitignore` is whitespace sensitive. If you include trailing whitespace, git won't recognize your files.
|
| [5908]
|
johnjamesjacoby
|
Sniffer: Whitespace around variables in arrays.
|
| [5286]
|
johnjamesjacoby
|
Smarter build/src toggling for the stub plugin. See #2542.
|
| [5394]
|
johnjamesjacoby
|
Smarter ancestor detection in `BBP_Walker_Reply_Dropdown`. See #2617.
|
| [2681]
|
johnjamesjacoby
|
Smart redirect on new reply in the event new reply creates new topic page
|
| [6967]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.7, trunk.
|
| [6966]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.6.2, branches/2.6.
|
| [2467]
|
johnjamesjacoby
|
Slug fixes
|
| [5512]
|
johnjamesjacoby
|
Slightly refactor `bbp_format_buddypress_notifications()`:
* Return original `$action` if not `bbp_new_reply`.
* Reduce indentation to accommodate new `$action` check.
This fixes a bug where checking for new reply notifications could cause future notification filter checks to fail.
Props Faison. Fixes #2665.
|
| [3649]
|
johnjamesjacoby
|
Slight performance improvements to author display_name. See #1704.
|
| [2469]
|
johnjamesjacoby
|
Singular/plural filter fixes (see r2468)
|
| [3161]
|
johnjamesjacoby
|
Singular/Plural fixes on forum and topic descriptions. Fixes #1515. Props !GautamGupta.
|
| [2468]
|
johnjamesjacoby
|
Singular slugs and add reply slug
|
| [4216]
|
johnjamesjacoby
|
Single topics:
* Force is_home to false in bbp_has_replies()
* Maybe set is_single to true if viewing a single topic.
* Fixes bug where WP_Query::parse_query() incorrectly assumes is_home() when multiple post_types are queried.
* Fixes #1947.
|
| [4999]
|
johnjamesjacoby
|
Since search requests get existing data, and do not post new data, revert part of r4997 and switch request method back to "get".
Add hidden 'action' field to form-search.php template-part, and move 'bbp_search_results_redirect' action from 'bbp_post_request' to 'bbp_get_request'.
Fixes issue with request not redirecting properly, and uses more accurate form method. See #2337.
|
| [5513]
|
johnjamesjacoby
|
Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.
|
| [4226]
|
johnjamesjacoby
|
Simplify password reset hint text.
|
| [2595]
|
johnjamesjacoby
|
Simplify load sequence.
|
| [4615]
|
johnjamesjacoby
|
Simplify favorites link logic and output, to match subscriptions link functionality. Fixes #2118.
|
| [5151]
|
netweb
|
SimplePress Importer Improvements. Props netweb. Fixes #2194
* Add reply slug field mapping
* Add custom regex for non-break spaces in HTML
|
| [5547]
|
netweb
|
SimplePress 5:
* Fix regression introduced in r5349 where topics were imported a second time as part of the reply section import.
* Fix reply parent forum ID mini cache callback to use `callback_forumid`
* Add topic author IP address to topics import section
|
| [5466]
|
johnjamesjacoby
|
Simpify `ABSPATH` checks to pass coding standard sniffers that look for brackets on comparisons.
|
| [7086]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In trunk, for 2.7.0.
See #3157.
|
| [7087]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In branches/2.6, for 2.6.5.
See #3157.
|
| [2888]
|
johnjamesjacoby
|
Show the forum of super sticky topics when outside of the forum the sticky belongs in.
|
| [3231]
|
johnjamesjacoby
|
Show hidden forums in the admin all list.
|
| [2484]
|
PeteMall
|
Show forum title, description and topic count on forums admin page.
|
| [5956]
|
netweb
|
Shortcodes: Remove superfluous `@param` PHPDoc instances from various shortcode functions
Props casiepa.
|
| [5957]
|
netweb
|
Shortcodes: Fix `@return` type shring/string typo in `display_stats()`
|
| [4212]
|
johnjamesjacoby
|
Shortcodes:
* Move shortcode registration into bbPress class to mirror other internal dependencies.
* Introduce bbp_register_shortcode() function, hooked to 'bbp_register'
|
| [4296]
|
johnjamesjacoby
|
Shortcodes:
* Fix incorrect post_type reference in widgets inline doc.
* Fixes #2007.
|
| [4295]
|
johnjamesjacoby
|
Shortcodes:
* Fix incorrect post_type reference in shortcodes inline doc.
* Fixes #2003.
|
| [4586]
|
jmdodd
|
Shortcode iteration for search introduced in #1575.
* Fix bbp-search shortcode.
* Introduce bbp-search-form shortcode.
* Fixes #2107.
|
| [5069]
|
johnjamesjacoby
|
Shift output escaping around in admin links to allow for filtering and passing additional HTML into them. Hat tip mourdak. Fixes #2090.
|
| [6125]
|
johnjamesjacoby
|
Shh... I meant `bbp_translate_user_role()`.
See r6121.
|
| [3445]
|
johnjamesjacoby
|
She seems to have an invisible touch, yeah. Fixes #1603. Props cnorris23.
|
| [3452]
|
johnjamesjacoby
|
Setup option filters earlier on bbp_init so plugins don't need to worry about load order. See r3451.
|
| [3779]
|
johnjamesjacoby
|
Setup default theme compatibility in bbPress::setup_theme()
* Sets early on bbp_setup_theme so functions and files can be included
* Still allows plugins to override earlier
* See #1766
|
| [6954]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.7, trunk.
|
| [6955]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6.
|
| [6420]
|
johnjamesjacoby
|
Settings: remove directory path from option text.
|
| [6483]
|
johnjamesjacoby
|
Settings: cast `map_meta_caps` return value to an array.
|
| [6564]
|
johnjamesjacoby
|
Settings: Use `$this->minimum_capability` in options page filter method.
This change keeps the filter inline with the mapped meta caps, should the minimum capability be renamed or changed.
|
| [6444]
|
johnjamesjacoby
|
Settings: Update `int` handling of `bbp_past_edit_lock()`.
|
| [6443]
|
johnjamesjacoby
|
Settings: Update Engagements setting description to better match others.
|
| [7088]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In trunk, for 2.7.0.
|
| [7089]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In branches/2.6, for 2.6.5.
|
| [6419]
|
johnjamesjacoby
|
Settings: General improvements:
* Use escaped equivalent for gettext output
* Update settings-integration away from `bool` to allow future flexibility
* Stash settings fields in a static variable to speed up registration
|
| [6070]
|
netweb
|
Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
|
| [6435]
|
johnjamesjacoby
|
Settings: Add a note to the `_bbp_show_on_root` setting if a forum archive template is found in the template stack.
Fixes confusion that would arise when using the `archive-forum.php` found in the `/extras/` directory.
Fixes #3081.
|
| [6442]
|
johnjamesjacoby
|
Settings: Add `_allow_` settings for editing & flooding, and revise the verbiage.
This allows for flood checking & editing to be:
* Completely disabled
* Overridden via filters
* Editing allowed forever
* A bit more descriptive with additional context provided
|
| [4065]
|
johnjamesjacoby
|
Settings:
* Use isset() instead of !empty() in bbp_pre_get_option()
* Fix issue where settings would not properly override, due to get_option()'s pre filter looking for false, and not null.
|
| [4067]
|
johnjamesjacoby
|
Settings:
* Use integers in bbp_get_default_options() and friends, to avoid boolean conflict in get_option().
* See r4065.
|
| [4019]
|
johnjamesjacoby
|
Settings:
* Use esc_sql to sanitize _bbp_theme_package_id setting.
* Fixes #1862.
* Hat tip michelwppi.
|
| [4020]
|
johnjamesjacoby
|
Settings:
* Use esc_sql to sanitize __bbp_topic_archive_slug setting.
|
| [4057]
|
johnjamesjacoby
|
Settings:
* Use 'number' input type where appropriate.
|
| [4234]
|
johnjamesjacoby
|
Settings:
* Tweak verbiage to make it more clean what each setting does.
* Fixes confusion with "Global Access" and how it works.
* Fixes #1904.
|
| [4058]
|
johnjamesjacoby
|
Settings:
* Smarter boundaries on new 'number' input types.
* See r4057.
|
| [4235]
|
johnjamesjacoby
|
Settings:
* Simplify role translation in bbp_admin_setting_callback_global_access().
* Prevents repeatedly reassigning new value to existing $default_role variable.
* See: r4234.
|
| [4100]
|
johnjamesjacoby
|
Settings:
* Remove redundant "Allow" verbiage.
* Fix punctuation.
|
| [4016]
|
johnjamesjacoby
|
Settings:
* Remove duplicate 'page' array item from fields, and use 'page' from section parent.
* See #1862.
|
| [4018]
|
johnjamesjacoby
|
Settings:
* Register settings to page, not section ID.
* Fixes bug causing settings not save.
* Fixes #1862.
|
| [4315]
|
johnjamesjacoby
|
Settings:
* Hide theme compat package selection setting if only 1 package is registered.
|
| [3586]
|
johnjamesjacoby
|
Settings, functions, CSS, and template-tags necessary to use wp_editor() function, introduced in WordPress 3.3. See #1673.
|
| [2490]
|
PeteMall
|
Set width for new columns and consolidate row_action functions.
|
| [4817]
|
johnjamesjacoby
|
Set the super_sticky text to an empty string rather than unset it, since it's currently expected to exist, and empty values will be filtered out anyways.
|
| [3362]
|
johnjamesjacoby
|
Set the post_type to topic in bbp_pre_get_posts() when viewing a topic tag. Fixes issue where topics of tag were not visible in some installations. Fixes #1547. Props cnorris23.
|
| [7021]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7020]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [2938]
|
johnjamesjacoby
|
Set query names on forums and replies widgets to prevent conflicts with user profile pages.
|
| [3405]
|
johnjamesjacoby
|
Set overflow to auto on .bbp-topic-content and .bbp-reply-content.
|
| [5066]
|
johnjamesjacoby
|
Set max-width on .form-allowed-tags to 100%. Improves theme compat, and fixes issues with allowed tags breaking theme output. Props kobenland.
|