| [5584]
|
netweb
|
Switch to container-based infrastructure on Travis CI.
The container-based infrastructure has more memory and more cores. It also is designed to startup faster. We give up the ability to use sudo, but we aren't using that right now so we should be good.
Props tw2113, netweb
Fixes #2736
|
| [5055]
|
johnjamesjacoby
|
Switch some wp_insert_post() usages to wp_update_post(). Use bbp_get_forum(), bbp_get_topic(), and bbp_get_reply() where appropriate, and use objects instead of arrays to avoid escaping issues with wp_update_post().
|
| [2882]
|
johnjamesjacoby
|
Switch position of template_notices in user-edit.php in bbp-twentyten theme
|
| [3088]
|
johnjamesjacoby
|
Switch meta font size from em to px for theme compat
|
| [5047]
|
johnjamesjacoby
|
Switch main bbPress singleton pointer from a private static to a local static inside the instance() method, preventing recursive $instance references. Fixes #2370.
|
| [2661]
|
johnjamesjacoby
|
Switch destination links
|
| [3173]
|
johnjamesjacoby
|
Switch bbp_template_include action into a filter, and move it down into the filters section of bbp-core-hooks.php. Also add more verbose descriptions to bbp_template_include and bbp_request_feed_trap filters. Fixes #1524. Props greenshady.
|
| [2901]
|
johnjamesjacoby
|
Switch bbp_get_breadcrumb to use get_post_ancestors() potentially saving a few queries in certain situations.
|
| [3120]
|
johnjamesjacoby
|
Switch author IP address from anonymous only to a meta value on every topic and reply. Includes additional template tags, theme compat adjustments, and admin meta box adjustments. Fixes #1505.
|
| [3533]
|
johnjamesjacoby
|
Switch BackPress external from 1.1 branch to 1.1 tag
|
| [2924]
|
johnjamesjacoby
|
Switch $topic_id to $forum_id in bbp_update_reply_forum_id()
|
| [2873]
|
johnjamesjacoby
|
Swap voices and replies columns in loop-bbp_topics.php. Add more fancy author links with avatars and names, and use new bbp_author_link function
|
| [3576]
|
johnjamesjacoby
|
Swap out @public's for @var's in bbpress.php. Props duck_.
|
| [2521]
|
johnjamesjacoby
|
Surprise! bbPress colors in your WordPress admin! (traditional wp-content dir required for now...)
|
| [3001]
|
johnjamesjacoby
|
Suppress super stickies from no-replies template page.
|
| [2634]
|
johnjamesjacoby
|
Support for pretty pagination links
|
| [4525]
|
johnjamesjacoby
|
Supplemental update to bbp_trash_forum_topics(). See #2059.
|
| [4717]
|
johnjamesjacoby
|
Supplemental removal of group forum capability mapping after group forum is displayed. See #2140.
|
| [6575]
|
johnjamesjacoby
|
Super Moderators: prefer `edit_user` with an ID over `edit_users` without one.
This change makes sure we know exactly which user ID the user is trying to edit. In cases where there is no ID available, we'll try to guess at the displayed user ID, and if that's empty too, we'll do nothing.
This allows the "User Role" template part to load properly for Super Moderators.
|
| [6572]
|
johnjamesjacoby
|
Super Moderators: First pass at mapping the meta-capabilities.
This change hooks-up the ability for moderators to edit other users if the super moderator ability is allowed. <3
|
| [6574]
|
johnjamesjacoby
|
Super Moderators: Compare the user ID to `$args[0]` instead.
This change makes sure the proper user IDs are compared, and also prevents super moderators from editing Keymasters (demotions can't come from users with a less capable role than their own.)
|
| [7070]
|
johnjamesjacoby
|
Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.7, trunk.
|
| [7071]
|
johnjamesjacoby
|
Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.6.15, branches/2.6.
|
| [4260]
|
johnjamesjacoby
|
Suggest:
* First pass at adding autocomplete to forum and topic ID's.
* Adds ajax.php to bbp-includes/admin/.
* Updates metabox inputs back to type 'text'.
* @todo phpdoc and inline doc, and nonce checks.
* See #1901.
|
| [4261]
|
johnjamesjacoby
|
Suggest:
* Combine admin/ajax.php into admin/admin.php.
* Tweak metabox output and CSS.
* Adds phpdoc and inline doc.
* Fixes #1901
|
| [4359]
|
johnjamesjacoby
|
Suggest:
* Add hidden and private status's to forum suggestions.
* Sanity checks on suggestion results and improve readability.
* Refixes #1901.
|
| [7249]
|
johnjamesjacoby
|
Subscriptions: use topic title in Subject, instead of site name.
This change adds helpful context to email subjects and eliminates duplication between From & Subject mail headers.
Props dd32.
In trunk, for 2.7.0.
Fixes #3446.
|
| [7250]
|
johnjamesjacoby
|
Subscriptions: use topic title in Subject, instead of site name.
This change adds helpful context to email subjects and eliminates duplication between From & Subject mail headers.
Props dd32.
In branches/2.6, for 2.6.10.
Fixes #3446.
|
| [6830]
|
johnjamesjacoby
|
Subscriptions: simplify edit logic for getting `checked()` value.
Props wpdennis. See #3206.
|
| [6880]
|
johnjamesjacoby
|
Subscriptions: replace hard-coded, single-use strings with `no-forums` template part.
|
| [6811]
|
johnjamesjacoby
|
Subscriptions: prevent admin area topic updates from unsubscribing users.
Fixes #3185.
|
| [6916]
|
johnjamesjacoby
|
Subscriptions: pass additional IDs into user ID filters.
This commit adds forum, topic, and reply IDs to the filters commonly used to filter the user IDs that emails are being sent to, providing a quick opportunity to peek at them easily and make decisions based on what they are at the time.
Fixes #3249. Props satollo.
|
| [6904]
|
johnjamesjacoby
|
Subscriptions: ensure special characters in author names are encoded properly.
This commit copies the approach used on the content, and applies `wp_specialchars_decode()` and `strip_tags()` to author names in subscription emails.
(HTML tags are not usually allowed in usernames, but we strip them anyways in the event a filter allowed them. Better to keep emails legible than include unintended tags?)
Fixes #3256.
|
| [6898]
|
johnjamesjacoby
|
Subscriptions: do not send subscription emails during WordPress imports.
This change adds checks to the `WP_IMPORTING` global constant inside of forum & topic subscription notification functions, to prevent sending emails during the import process.
Because hooks still fire during imports, this sanity check avoids a potentially hugely annoying situation for users during forum migrations by any import tool that obeys the use of this core constant.
Fixes #3248. Props danielbachhuber.
|
| [6985]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.7, trunk.
|
| [6984]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.6.3, branches/2.6.
|
| [6918]
|
johnjamesjacoby
|
Subscriptions: clean up code comparisons and documentation.
This commit adds some inline documentation to provide a bit more clarity around what subnscriptions checks and actions are being taken, and adds parenthesis to nested comparisons to improve code readability.
See #3235.
|
| [6829]
|
johnjamesjacoby
|
Subscriptions: cast function results to `(int)` so strict comparisons pass.
This change fixes a bug where subscription checkboxes and UI elements could show/use incorrect values.
Props wpdennis. Fixes #3206.
|
| [6614]
|
johnjamesjacoby
|
Subscriptions: Use `bbp_remove_all_filters()` with restore option.
This change uses the bbPress version of `remove_all_filters()` which allows those filters to be restored. We need to restore filters after emails are sent so that template titles & content render correctly within their respective templates.
See #6613.
|
| [6232]
|
netweb
|
Subscriptions: Update the forum and topic subscriptions 2.6 database update routine.
Previously in r6193 the topic subscription update tool was renamed from `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()` to facilitate the addition of the forum subscription update tool `bbp_admin_upgrade_user_forum_subscriptions()`.
This changeset updates the `bbp_version_updater()` 2.6 database update to run both the above upgrade tools.
Props barry.hughes.
Fixes 3038.
+ bbp_admin_upgrade_user_forum_subscriptions();
|
| [6034]
|
netweb
|
Subscriptions: Update `bbp_new_reply` action to to use `bbp_notify_topic_subscribers` over deprecated `bbp_notify_subscribers`.
Previously in [5643] this was added to the 2.5 branch but was overlooked for `/trunk`, this changeset fixes that.
Props thebrandonallen
Fixes #2946, see also #2618
|
| [6613]
|
johnjamesjacoby
|
Subscriptions: Strip & decode email titles.
Props thebrandonallen. Fixes #2865.
|
| [6445]
|
johnjamesjacoby
|
Subscriptions: Remove `array_filter( array_map() )` bit from `$user_ids`.
This now is handled upstream inside of `bbp_get_forum_subscribers()` and friends.
|
| [6725]
|
johnjamesjacoby
|
Subscriptions: Introduce `bbp_get_email_addresses_from_user_ids()` to chunk `get_users()` calls.
This changes the strategy used when querying for subscribed users so that not of them are queried at the same time, which could cause timeouts or out-of-memory issues when there are many users subscribed to a forum or topic.
By default, users are now queried in `100` user increments, and each 100 user chunk of email addresses gets merged into 1 large array and returned. The `100` default also has a filter, so it's somewhat configurable. Duplicate email addresses are strictly avoided, and user ID filters were moved to after the current user ID is removed from the array, which allows for third party plugins to add them back in if they'd like to include them.
See #3068.
|
| [6616]
|
johnjamesjacoby
|
Subscriptions: Include `closed` status in subscription triggers.
This change allows activity in closed topics to trigger subscription emails. It also fully implements `bbp_get_subscribers()` completing the deprecation of topic/forum specific handlers.
Fixes #2729.
|
| [6264]
|
johnjamesjacoby
|
Subscriptions: Do not send emails when `$user_ids` is empty.
Also reorder some logic to optimize the users loop.
Fixes #2863. Props thebrandonallen.
|
| [6886]
|
johnjamesjacoby
|
Subscriptions: Do not add or remove subscriptions when editing via WordPress admin.
This change passes the current post ID through to `bbp_is_user_subscribed()`, ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status.
Fixes #3235.
|
| [6727]
|
johnjamesjacoby
|
Subscriptions: Avoid empty `include` statement in `bbp_get_email_addresses_from_user_ids()` call.
This change ensures that if no user IDs are gathered as part of the limited chunk, the loop will continue and avoid a costly `get_users()` call.
See r6725.
|
| [4268]
|
johnjamesjacoby
|
Subscriptions:
* Allow for custom headers in subscription emails.
* Fixes #1992.
* Props gawain.
|
| [4543]
|
johnjamesjacoby
|
Subscriptions/Favorites:
* Improvements to AJAX handling.
* Introduces bbp_ajax_response() function in common/functions.php, to handle JSON output.
* Adds AJAX failure responses.
* Props MZAWeb.
* Fixes #1905.
|
| [5259]
|
johnjamesjacoby
|
Subscriptions clean-up, from r5258. Props netweb. See #2162. (2.5 branch)
|
| [5650]
|
netweb
|
Subscriptions are both forums and topics, remove "Topic" from single slug setting description.
Props netweb. Fixes #2709
|
| [6941]
|
johnjamesjacoby
|
Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.7, trunk.
|
| [6942]
|
johnjamesjacoby
|
Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.6.1, branches/2.6.
|
| [6757]
|
johnjamesjacoby
|
Sub-actions: bail on completely invalid/empty get/post requests.
This change ensures that non-empty actions (sanitized via `sanitize_key()`) will not make their way into the get/post request actions.
This is in addition to similar checks added to AJAX requests in r6755.
|
| [6479]
|
johnjamesjacoby
|
Sub-actions: Cast a few return values and add `@return` phpdoc.
|
| [7080]
|
johnjamesjacoby
|
Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In trunk, for 2.7.0.)
Fixes #3373.
|
| [7081]
|
johnjamesjacoby
|
Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In branches/2.6, for 2.6.5.)
Fixes #3373.
|
| [6873]
|
netweb
|
Styling: Use double quotes
Fixes #3228.
Props jrf.
|
| [6912]
|
netweb
|
Styling: Updade styles and stylelint config per latest coding standards
|
| [6883]
|
johnjamesjacoby
|
Styling: Remove unused `row-actions` CSS.
This used to be necessary for BuddyPress theme compatibility, but is no longer.
See #3238, for trunk (2.6)
|
| [6590]
|
johnjamesjacoby
|
Styling: No text shadow on editor buttons.
|
| [6598]
|
johnjamesjacoby
|
Styling: No border on forums links.
An increasing number of themes are putting borders on links by default to simulate an underline, which causes every link in the forums to be styled in unanticipated ways.
This changeset ensures that links in the entry-content section in forums do not have faux-underlines or excessive attention drawn to them.
|
| [6605]
|
johnjamesjacoby
|
Styling: More aggressively remove borders on anchor elements.
Some themes very stubbornly insist on having shadows & lines around them.
|
| [6527]
|
johnjamesjacoby
|
Styling: Improve theme compatibility of avatars & content areas in default themes.
This makes sure that avatars in forum & topic descriptions are always horizontally centered, are not accidentally turned into block-elements by parent-theme `img` styling, and that content areas always occupy the full width of their parent element.
|
| [6587]
|
johnjamesjacoby
|
Styling: Flatten the editor buttons, and force fieldset legend width & border.
This improves default theme compatibility.
|
| [6588]
|
johnjamesjacoby
|
Styling: Clean-up default styling to pass style linting rules.
|
| [6589]
|
johnjamesjacoby
|
Styling: Bump assets version & remove prefixes from default.css.
Prefixes are put back during build.
|
| [6743]
|
johnjamesjacoby
|
Styling tweaks for improved Twenty Seventeen theme support.
|
| [6255]
|
johnjamesjacoby
|
StyleLint: Prefer shorthand CSS Colors.
|
| [6735]
|
johnjamesjacoby
|
Strings: remove escaped single quotes from profile/website link attributes.
Also normalize the approach used in these 3 similar functions.
|
| [5868]
|
johnjamesjacoby
|
Strings: prefer `—` over parenthesis when wrapping "No" style results.
This changeset normalizes the strings used to pick the parent of a forum, topic, and reply. The `—` may be changed later to improve localization, but for now this provides a good balance of visual separation and familiar UX.
|
| [7037]
|
johnjamesjacoby
|
Strings: improve consistency of "ERROR" messaging.
This commit moves a few colons from within their respective `<strong>` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.7, trunk.
|
| [7036]
|
johnjamesjacoby
|
Strings: improve consistency of "ERROR" messaging.
This commit moves a few colons from within their respective `<strong>` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.6.4, branches2.6.
|
| [6047]
|
netweb
|
Strings: Switch from "Freshness" to "Last Post" in the admin screens.
This changeset follows on from [5867] where these couple of strings were missed in the original commit.
Props Robkk, thebrandonallen
Fixes #2031
|
| [5867]
|
johnjamesjacoby
|
Strings: Switch from "Freshness" to "Last Post" in the `default` theme-compatibility templates.
This changeset updates the column header text used to describe the last activity of a forum/category or topic in bbPress's `default` theme-compatibility (which includes details beyond just the timestamp) making "Last Post" more contextually accurate compared to "Freshness" which still makes sense within the dashboard (which currently only shows the timestamp.)
Fixes #2031.
|
| [6199]
|
johnjamesjacoby
|
Strings: Add `view_items` text for forums, topics, replies, and topic-tags.
This adds support for a label that is new to WordPress 4.7.
|
| [4286]
|
johnjamesjacoby
|
Strings:
* Fix "forum" references that should be "topic."
* Fixes #2004.
|
| [4287]
|
johnjamesjacoby
|
Strings:
* Add tips for topic stickiness in admin.
* Props netweb.
* See #2004.
|
| [5073]
|
johnjamesjacoby
|
String match 'to front' from changes to #2090.
|
| [3375]
|
johnjamesjacoby
|
String consistency. Fixes #1584. Props ramiy.
|
| [6140]
|
johnjamesjacoby
|
Stop shouting at everyone!
|
| [3153]
|
johnjamesjacoby
|
Stop including the old updater script, in preparation for file removal before adding into WP extend.
|
| [2819]
|
johnjamesjacoby
|
Stop XMLRPC from complaining when bbPress is activated. Remove needless isset() checks in bbp_get_user_id(). Fixes #1458
|
| [2825]
|
johnjamesjacoby
|
Sticky styling is not just for the front page.
|
| [6915]
|
johnjamesjacoby
|
Stickies: make sure unapproved topics are unstuck also.
This commit removes a hard coded call to `bbp_unstick_topic()` and hooks into the neighboring `bbp_stick_topic` action, while also hooking into the `bbp_unapprove_topic` action.
A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code.
Fixes #3246.
|
| [6401]
|
johnjamesjacoby
|
Stickies: Update forum/topic meta early in `bbp_update_topic()`
* Makes meta-data available earlier for downstream functions
* Removes ineffective assumption of forum-topic-id when empty
This fixes a situation where trying to stick a new topic to a forum would look for the `_bbp_forum_id` meta-data before it was updated.
Fixes #3103.
|
| [6402]
|
johnjamesjacoby
|
Stickies: Improved algorithm for merging stickies to queried posts
* Separate into overloadable function
* Tighter, less wasteful loops through existing query
* Improved sort-ordering of topics by their most recent post activity
* Also separate pagination base URL into new function, out of `bbp_has_topics()`
|
| [4443]
|
johnjamesjacoby
|
Stickies:
* Prevent revisions from being saved as stickies when editing in wp-admin.
* Also cleans up existing stickies when adding a new sticky topic.
* Fixes #2034 (trunk)
|
| [4444]
|
johnjamesjacoby
|
Stickies:
* Prevent revisions from being saved as stickies when editing in wp-admin.
* Also cleans up existing stickies when adding a new sticky topic.
* Fixes #2034 (2.2 branch)
|
| [4125]
|
johnjamesjacoby
|
Stickies:
* Make sure stickies always appear according to freshness date.
* For 2.2.
|
| [4126]
|
johnjamesjacoby
|
Stickies:
* Make sure stickies always appear according to freshness date.
* For 2.1 branch.
|
| [6922]
|
johnjamesjacoby
|
Statuses: normalize status related functions across post types.
This commit adds 2 missing functions for forum statuses, and relocates all of them to the correct functions.php files for their post types.
|
| [6547]
|
johnjamesjacoby
|
Statuses: Update `Closed` status arguments in `register_post_status()` call.
This makes sure posts with a closed status appear in the status and all listings.
|
| [6027]
|
johnjamesjacoby
|
Statuses, Types, Visibilities: `bbp_get_topic_types()` usages were missed in r6026.
See #2954.
|
| [6026]
|
johnjamesjacoby
|
Statuses, Types, Visibilities: Pass the forum, topic, or reply ID into helper functions.
These ID's pass additional context into respective filters, useful for fine-grained control over UI elements.
This commit normalizes the way these functions work across all of bbPress where applicable, by ensuring all similar functions accept an ID and assume `0` by default. Note that there are currently 2 locations where no ID exists to pass context into, which is by design.
Fixes #2954.
|
| [6786]
|
johnjamesjacoby
|
Stats: Whitespace adjustments to some statistics functions.
See #3196.
|
| [7236]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In trunk for 2.7.0. Fixes #3428.
|
| [7237]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In branches/2.6 for 2.6.10. Fixes #3428.
|
| [6542]
|
johnjamesjacoby
|
Statistics: Improvements to "At a Glance" integration.
* Prefer `bbp_get_total_users()` over `count_users()` to speed up loading
* Don't include empty array values
* Don't link to areas the current user cannot access
* Skip if current user cannot at least spectate (blocked or no access)
Fixes #2770.
|