| [5708]
|
johnjamesjacoby
|
Tests: Fix more of the tests. See r5703.
|
| [5929]
|
netweb
|
Tests: Fix incorrect reply post date time assertion in `test_bbp_get_topic_last_active_time()`
|
| [5934]
|
netweb
|
Tests: Fix incorrect assertion type in `test_bbp_forum_query_topic_ids()` and `test_bbp_forum_query_subforum_ids()`, also now includes topic meta for topics in `test_bbp_forum_query_topic_ids()()`
|
| [5710]
|
netweb
|
Tests: Fix forums functions tests:
* Fix `test_bbp_bump_forum_topic_count_hidden` per r5709
* Replace some debug comments in `test_bbp_update_forum_topic_count`
|
| [5777]
|
netweb
|
Tests: Fix failing test `test_bbp_update_forum_topic_count()`
Props thebrandonallen. See #2801
|
| [5955]
|
netweb
|
Tests: Fix failing `BBP_Tests_Topics_Functions_Update_Topic_Last_Thing` tests
* Pass the active id as the 2nd parameter to `bbp_update_topic_last_active_id()` in `test_bbp_update_topic_last_active_id()`
* Pass the reply id as the 2nd parameter to `bbp_update_topic_last_reply_id()` in `test_bbp_update_topic_last_reply_id()`
This fixes the current two failing unit tests by passing what should be optional paremeters to their respceptive functions.
See #1799, [5954]
|
| [5756]
|
netweb
|
Tests: Fix duplicate `@group` annotation for topic tags template function tests
|
| [5715]
|
netweb
|
Tests: Fix copy pasta in forums count functions tests:
* `test_bbp_update_forum_topic_count_hidden()`
* `test_bbp_update_forum_reply_count()`
|
| [5968]
|
netweb
|
Tests: Fix copy pasta class name in `@covers` annotation in `test_bbp_admin_repair_forum_topic_count()`
|
| [5706]
|
johnjamesjacoby
|
Tests: Fix all of the tests but 2, which are todo's. See r5703.
|
| [5925]
|
netweb
|
Tests: Ensure bbPress' custom post types posts are created with a unique GUID.
Props tharsheblows, netweb. Fixes #2844, see also #WP5305 / wp:changeset:33630.
|
| [5914]
|
netweb
|
Tests: Don't use hardcoded `example.org` domain is test assertions.
This changeset allows the default domain used in tests to be overridden using `WP_TESTS_DOMAIN` in `wp-tests-config.php`
|
| [5713]
|
netweb
|
Tests: Core Update initial pass unit tests for /includes/core/update.php
|
| [5873]
|
netweb
|
Tests: Complete topic template tests in `BBP_Tests_Topics_Template_Get_Topic_Last_Thing`
|
| [5679]
|
netweb
|
Tests: Code formatting improvements to `BBP_UnitTestCase`
* Remove whitespace surrounding array keys
* Remove whitespace in cast statements
* Whitespace beside `!` operators
* Yoda conditions
|
| [5701]
|
netweb
|
Tests: Author unit tests for `/includes/forums/template.php`
|
| [5779]
|
netweb
|
Tests: Adds forum, topic and reply insert function tests:
* `test_bbp_insert_forum()` for `bbp_insert_forum()`
* `test_bbp_insert_topic()` for `bbp_insert_topic()`
* `test_bbp_insert_reply()` for `bbp_insert_reply()`
Props netweb. Fixes #2805
|
| [5769]
|
netweb
|
Tests: Added integer differential bump count assertions to `test_bbp_bump_topic_reply_count()` and `test_bbp_bump_topic_reply_count_hidden()` tests
Props thebrandonallen. See #2801
|
| [6084]
|
netweb
|
Tests: Add user email, URL, IP, moderator, keymaster `bbp_check_for_moderation()` and `bbp_check_for_blacklist()` tests
|
| [5870]
|
netweb
|
Tests: Add topic voice count test `test_bbp_get_topic_voice_count_with_pending_reply()`.
This test tests the voice count of a topic to ensure replies with post status `pending` are not included in the voice count until approved.
See #meta1140
|
| [5931]
|
netweb
|
Tests: Add topic and topic reply spam/unspam tests `test_bbp_spam_topic()`, `test_bbp_spam_topic_replies()`, `test_bbp_unspam_topic()`, and `test_bbp_unspam_topic_replies()`
Props netweb. See #2494.
|
| [5785]
|
netweb
|
Tests: Add test `test_bbp_update_topic_forum_id()` for `bbp_update_topic_forum_id()`
|
| [6009]
|
netweb
|
Tests: Add recount forum topics repair tool test `test_bbp_admin_repair_forum_topic_count()`
|
| [6007]
|
netweb
|
Tests: Add recount forum replies repair tool test `test_bbp_admin_repair_forum_reply_count()`
|
| [5746]
|
netweb
|
Tests: Add post type object and hierarchical test assertions for forum, topic and reply post types.
|
| [5773]
|
netweb
|
Tests: Add post meta test assertions to `test_bbp_create_initial_content()`, see #2805
|
| [5871]
|
netweb
|
Tests: Add forum last active id test `test_bbp_get_forum_last_active_id_with_pending_reply()`.
This test tests the forums last active id to ensure replies with post status `pending` are not used as the forums last active id until the reply is approved.
See #meta1140
|
| [6194]
|
netweb
|
Tests: Add favorite, topic subscriptions, and forum subscription upgrade tool tests.
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_favorites`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_topic_subscriptions`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_forum_subscriptions`
See #2959.
|
| [5687]
|
netweb
|
Tests: Add factory support for parsing meta arguments from forum, topic, and reply `::create_object` factories in `BBP_UnitTestCase` testcases.
|
| [5831]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_topic_voice_count()` for `bbp_admin_repair_topic_voice_count()`
Props netweb. See #2533
|
| [5782]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_forum_meta()` for `bbp_admin_repair_forum_meta()`
Props netweb. See #2669
|
| [5965]
|
netweb
|
Tests: Add a parent forum category for each test in `::BBP_Tests_Forums_Template_Forum_Last_Thing`
This changeset adds a parent category forum for each forum test to ensure hierarchal forum assertions are tested with parent/child forum relationships for the `bbp_get_forum_last_*()` template functions.
|
| [5878]
|
netweb
|
Tests: Add `test_bbp_get_topic_favorite_link()` topic templates test
|
| [6048]
|
netweb
|
Tests: Add `test_bbp_get_do_not_reply_address()` common functions reply email address test
Props thebrandonallen
Fixes #2822
|
| [6077]
|
netweb
|
Tests: Add `test_bbp_forum_query_last_reply_id()`
See #2972
|
| [5915]
|
netweb
|
Tests: Add `test_bbp_delete_topic_replies()` topics function test
|
| [5877]
|
netweb
|
Tests: Add `test_bbp_approve_reply()` and `test_bbp_unapprove_reply()` reply functions tests
|
| [6010]
|
netweb
|
Tests: Add `SpeedTrapListener` to `phpunit/includes` and add the config node to `phpunit.xml.dist`.
This changeset via wp:changeset:35214 adds a PHPUnit TestListener that exposes the slowest running tests by outputting results to the console.
|
| [6022]
|
netweb
|
Tests: Add `@covers` annotations to `BBP_Tests_Common_Functions_Make_Clickable` tests
|
| [6379]
|
johnjamesjacoby
|
Tests: Add XSS tests for topic titles.
These are in addition to post-title tests already present in WordPress core, for cases where theme-side, user-generated content is more likely to be targeted by less-trustworthy users than Editors or Administrators.
|
| [5677]
|
netweb
|
Tests: Add PHPUnit factory's for topics and replies:
* New class `BBP_UnitTest_Factory_For_Topic` for creating topics in PHPUnit tests
* New class `BBP_UnitTest_Factory_For_Reply` for creating replies in PHPUnit tests
|
| [2707]
|
johnjamesjacoby
|
Test shorter topic-tag slug 'tag' for conflicts with WordPress core.
|
| [5837]
|
johnjamesjacoby
|
Terms: Update functions for getting terms & term names to be more flexible & reusable by other functions. See #459.
|
| [5616]
|
netweb
|
Temporarily (I hope) remove PHP 5.2 from tests being run on travis-ci
Travis-ci has disabled PHP 5.2. This has happened before when 5.2 didn't compile and then was restored when that was fixed.
See upstream issues:
* #WP31244
* https://github.com/travis-ci/travis-ci/issues/3152
* https://github.com/WP-API/WP-API/issues/846
See #2753
|
| [6795]
|
johnjamesjacoby
|
Templates: revert r6641 due to reports of styling breakage.
This reverts back to the 2.5-type behavior of always making sure bbPress styling & scripts are available on all theme-side pages.
We will revisit this enhancement again in a future release.
See #3138. Props robin-w.
|
| [7259]
|
johnjamesjacoby
|
Templates: remove duplicate div from `content-archive-topic.php`.
This change removes an unnecessary `bbp_allow_search()` call – as well as an extra `div.bbp-search-form` – from the Topic Archive template part.
Fixes #3486.
Props naxoc, arafatjamil01.
In branches/2.6, for 2.6.10.
|
| [6409]
|
johnjamesjacoby
|
Templates: remove box-shadow styling on avatars and links.
Improves styling with Twenty Seventeen theme.
|
| [6806]
|
johnjamesjacoby
|
Templates: remove `action` attribute from several forms.
This improves support for third-party implementations (shortcodes, BuddyPress, etc...) because template parts can be called from anywhere.
Fixes #3030.
|
| [7260]
|
johnjamesjacoby
|
Templates: correct escaping on allowed HTML Tags form template parts.
This change introduces a new template-part file: `form-allowed-tags.php` and uses it inside of the Forum, Topic, and Reply form template-parts.
Additionally, the output is now properly escaped, which prevents unintentional escaping of the `<attr>` tag inside of the string.
Fixes #3492.
Props naxoc.
In branches/2.6, for 2.6.10.
|
| [6865]
|
johnjamesjacoby
|
Templates: call `bbp_get_post_types()` when parsing query args and setting template args.
Fixes #3221. Props scmsteve.
|
| [7066]
|
johnjamesjacoby
|
Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.7, trunk.
|
| [7067]
|
johnjamesjacoby
|
Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.6.15, branches/2.6.
|
| [7069]
|
johnjamesjacoby
|
Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.7, trunk.
|
| [7068]
|
johnjamesjacoby
|
Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.6.15, branches/2.6.
|
| [6452]
|
johnjamesjacoby
|
Templates: Replace `the_permalink()` calls with more specific template tags.
Resolves issue where BuddyPress group forums would collide with literal page IDs when not using theme-compat.
Fixes #3030.
|
| [5689]
|
johnjamesjacoby
|
Templates: Micro-optimizations:
* Remove trailing `?>` tag in some template parts
* Remove preceding `?> <?php` in some template parts, after phpdoc header
* Remove whitespace where superfluous
* Reduce number of indentations in some template parts
|
| [6343]
|
johnjamesjacoby
|
Templates: Localize topic ID and forum ID.
|
| [5688]
|
johnjamesjacoby
|
Templates: Escape all gettext output in `default` template parts. See #1999.
|
| [6622]
|
johnjamesjacoby
|
Templates: Add form template parts for searching specifically for topics & replies.
These have been in-use on BuddyPress.org/bbPress.org for years, and will be useful in user-profiles soon.
Also use `bbp_search_terms()` in `form-search.php` now that it's properly escaping output.
|
| [5854]
|
johnjamesjacoby
|
Templates: Add before & after hooks to user templates parts.
This changeset makes it easier to add custom text & HTML before & after user details.
Props netweb. Fixes #2537.
|
| [6258]
|
johnjamesjacoby
|
Templates: Add `ABSPATH` checks to default template parts.
This helps avoid leaking error messages on certain server configurations, and ensures that if these individual PHP files are somehow accessed directly (without first loading WordPress) nothing unexpected will happen.
See r5465.
|
| [4424]
|
johnjamesjacoby
|
Templates:
* Remove 'bbp-' prefix from default templates directory name.
* Update paths where appropriate.
|
| [6683]
|
johnjamesjacoby
|
Template: rework post class assignments.
This change avoids multiple reassignments to the same `$classes` variable name, and instead tries to name variables logically and merge them together when necessary. The performance difference is nil, as 'array_merge()` will perform similarly to how each array was reshaped when new classes would be added, but the human difference is only positive, from having clearer and easier to understand logic.
|
| [6682]
|
johnjamesjacoby
|
Template: adjust escaping of pagination count strings.
This change fixes a regression (in trunk only) that caused the filtered results of pagination counts to always be late escaped, but the intention was really only to escape the output of `_n()` which does not have an escaped equivalent function in the Gettext API.
I also tweaked the logic in `bbp_get_topic_pagination_count()` to not bail early. This brings it inline with `bbp_get_forum_pagination_count()` and allows the filter to run even when the text string is empty. Flexibility is the goal, so skipping the filter was also unintentional, and is now fixed.
Fixes #3162.
|
| [6822]
|
johnjamesjacoby
|
Template: add `is_multisite()` check to `bbp_is_site_public()`.
This change avoids a potential fatal error if this core function is used directly.
|
| [6486]
|
johnjamesjacoby
|
Template: Pass original `$args` array into `bbp_get_dropdown` filter.
Also update some inline docs & code formatting.
|
| [3979]
|
johnjamesjacoby
|
Template Tags:
* Introduce functions for getting the forums and topics archive URL's.
* Use functions where appropriate.
|
| [3980]
|
johnjamesjacoby
|
Template Tags:
* Clean up function order and phpdoc from r3979.
|
| [4325]
|
johnjamesjacoby
|
Template Tags:
* Check for edit when calling _is_ single forum/topic/reply.
* See #1968.
|
| [6615]
|
johnjamesjacoby
|
Template Packs: In default theme, only enqueue `editor.js` when `in_bbpress()`.
This results in 1 fewer external asset being enqueued on non-bbPress pages.
Fixes #2930.
|
| [6778]
|
johnjamesjacoby
|
Template Notices: unbreak these.
This change adjusts the `bbp_template_notices` action hooks and priority to ensure user, login, and topic notices continue to appear. It also removes the unstyled and unique `updated` class on one of them, which Twenty Seventeen uses as a way to hide elements.
|
| [4232]
|
johnjamesjacoby
|
Template Locator:
* Move parent/child/fallback out of loop
* Fix parent/child loader issue, where child theme templates still loaded the parent.
* Updates made to bbp_locate_template() only.
* Regression from earlier 2.2 changes.
|
| [4284]
|
johnjamesjacoby
|
Template Locations:
* Revert part of r4283.
* Keep filter on bbp_get_template_part, remove from bbp_locate_template.
* Refixes #1994.
|
| [4283]
|
johnjamesjacoby
|
Template Locations:
* Revert part of r4264.
* Fix regression where bbPress was pulling in files from unexpected locations.
* Fixes #1994.
|
| [3922]
|
johnjamesjacoby
|
Template Loader:
* Add missing single and archive functions.
* Add checks for these templates to loader filter.
|
| [2464]
|
johnjamesjacoby
|
Tap tap tap... Is this thing on?
|
| [2964]
|
johnjamesjacoby
|
Take extra precautions to ensure admin menus are positions directly above 'Appearance' and set the menu_position of each post_type
|
| [7162]
|
johnjamesjacoby
|
Tagging 2.6.6.
|
| [6230]
|
johnjamesjacoby
|
Tag bbPress 2.6-beta-1.
|
| [6023]
|
johnjamesjacoby
|
Tag bbPress 2.5.9.
|
| [6126]
|
johnjamesjacoby
|
Tag bbPress 2.5.11.
|
| [6066]
|
johnjamesjacoby
|
Tag bbPress 2.5.10.
|
| [4379]
|
johnjamesjacoby
|
Tag bbPress 2.1.3.
|
| [3958]
|
johnjamesjacoby
|
Tag bbPress 2.0.3.
|
| [3604]
|
johnjamesjacoby
|
Tag bbPress 2.0.1
|
| [3538]
|
johnjamesjacoby
|
Tag bbPress 2.0
|
| [6169]
|
johnjamesjacoby
|
Tag bbPress 1.2.1 which adds some basic PHP7 compatibility. See #3033
|
| [4521]
|
johnjamesjacoby
|
Tag bbPress 1.2.
* Fixes #1857.
|
| [3525]
|
johnjamesjacoby
|
Tag bbPress 1.1.
|
| [3523]
|
johnjamesjacoby
|
Tag bbPress 1.0.4.
|
| [2930]
|
johnjamesjacoby
|
Tag bbPress 1.0.3 from 1.0 branch
|
| [3518]
|
johnjamesjacoby
|
Tag bbPress 0.9.0.7.
|
| [7229]
|
johnjamesjacoby
|
Tag 2.6.9.
|
| [7223]
|
johnjamesjacoby
|
Tag 2.6.8.
|
| [7218]
|
johnjamesjacoby
|
Tag 2.6.7.
|
| [7091]
|
johnjamesjacoby
|
Tag 2.6.5.
|
| [7063]
|
johnjamesjacoby
|
Tag 2.6.4 from 2.6 branch.
|
| [7019]
|
johnjamesjacoby
|
Tag 2.6.3.
|
| [6983]
|
johnjamesjacoby
|
Tag 2.6.2.
|
| [7339]
|
johnjamesjacoby
|
Tag 2.6.14.
|