| [6217]
|
netweb
|
Unit Tests: Don't run BuddyPress PHPUnit tests on PHP 5.2.x
Previously r6204 attempted to skip BuddyPress tests if the PHP version was less than 5.3.0, this didn't work as intended as BuddyPress was still being loaded, the change would have only skipped tests rather than completely excluding the BuddyPress PHPUnit test suite from running on PHP versions less than 5.3.0.
This changeset reverts r6204 and separates the `grunt test` tasks into individual WordPress and BuddyPress PHPUnit Grunt tasks, this gives us the ability to explicitly exclude BuddyPress PHPUnit test suite from running on PHP 5.2.
See also https://bpdevel.wordpress.com/2016/07/21/php-5-2-bp-2-8-and-php-support-guidelines/
Fixes #3037.
|
| [6214]
|
netweb
|
Appearance - Included Themes: Update admin base SCSS styles:
* Updated via upstream WordPress `_admin.scss` file via WP:changeset:38602, WP:changeset:38638, WP:changeset:38660, WP:changeset:39141, and WP:changeset:39249
See #2583
|
| [6211]
|
netweb
|
Fix s/convertion/conversion typo in changelog introduced in r4422 (2.5 branch)
|
| [6210]
|
netweb
|
Fix s/convertion/conversion typo in changelog introduced in r6127
|
| [6204]
|
netweb
|
Unit Tests: Don't run BuddyPress PHPUnit tests on versions less than PHP 5.3.0
BuddyPress 2.8 has dropped support for PHP 5.2.x, this changeset updates the BuddyPress PHPUnit configuration to only run the tests on PHP versions greater than `5.3.0`
See also https://bpdevel.wordpress.com/2016/07/21/php-5-2-bp-2-8-and-php-support-guidelines/
Fixes #3037.
|
| [6203]
|
netweb
|
Build Tools: Add Travis CI cache for installed apt packages.
See #2980.
|
| [6202]
|
netweb
|
Accessibility: Bump headings for BuddyPress group forums.
Props mercime.
Fixes #2968.
|
| [6201]
|
netweb
|
Build Tools: Remove unsupported WordPress versions from Travis CI build job matrix.
This changeset removes all WordPress versions previous to 4.7 as this is now bbPress' minimum required version.
|
| [6200]
|
netweb
|
Metaboxes: Update `@since` revisions for functions introduced in r6197.
See #2959.
|
| [6195]
|
netweb
|
Converter: Give `!` usages some breathing room.
|
| [6194]
|
netweb
|
Tests: Add favorite, topic subscriptions, and forum subscription upgrade tool tests.
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_favorites`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_topic_subscriptions`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_forum_subscriptions`
See #2959.
|
| [6193]
|
netweb
|
Tools: Add an upgrade tool for forum subscriptions.
* Adds `bbp_admin_upgrade_user_forum_subscriptions()`
* Renames `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()`
* Updated inline docs
Previously in r6174 upgrade tools were added for favorites and subscriptions, support for migrating forums subscriptions meta `_bbp_forum_subscriptions` wasn't included, rather than adding extra overhead to the existing topic subscriptions upgrade tool another upgrade tool was added for forum subscriptions.
See #2959.
|
| [6190]
|
netweb
|
Admin: Add missing `@since` revisions from r6186.
|
| [6179]
|
netweb
|
Build Tools: `.jshintrc` is a JSON file, indentation should use spaces, not tabs, and lastly have `.editorconfig` treat `jshintrc` as a JSON file.
|
| [6146]
|
netweb
|
Moderation: Add some missing PHPDoc `@since` revisions
See #3032.
|
| [6145]
|
netweb
|
Build Tools: Travis CI: Only test PHP 7.1 against WordPress 4.7 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7.1 compatability, which was only added in version 4.7.
|
| [6132]
|
netweb
|
Build Tools: Add PHP 7.1 to the Travis CI job matrix and remove from `allow_failures` list
|
| [6131]
|
netweb
|
Build Tools: Add WordPress 4.7 to Travis CI build matrix
|
| [6117]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify`.
Update uglify-js to v2.7.0. `screwIE8` is enabled by default.
See https://github.com/gruntjs/grunt-contrib-uglify/compare/v1.0.2...v2.0.0
|
| [6115]
|
netweb
|
Indentation fixes, tabs, not spaces.
|
| [6114]
|
netweb
|
Users: Include users closed topic counts in `bbp_get_user_topic_count_raw()`
This changeset works around an issue where the lack of custom post statuses support upstream in #WP12706 prevents us from including users closed topics counts in a users raw topic count. See also #meta1870
Props netweb.
Fixes #2978.
|
| [6113]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
Fixes #2987.
|
| [6112]
|
netweb
|
Theme Compatibility: Parameter `$in_footer` in `bbp_enqueue_script()` should be boolean.
This changeset updates copy-pasta introduced in [5181], `bbp_enqueue_script()` is a wrapper for `wp_enqueue_script()`, `$in_footer` boolean parameter introduced in wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior.
Props thebrandonallen.
Fixes #3013.
|
| [6111]
|
netweb
|
Users: Update PHPDoc's for user functions and capabilities.
See #2959.
|
| [6110]
|
netweb
|
Tests: Use `assertEqualSets()` instead of `assertEquals()` in favorites and subscriptions tests.
This changeset improves array comparisons where arrays may not be in the same order.
See #2959.
|
| [6104]
|
netweb
|
Build Tools: Update `autoprefixer` to v6.5.1
See https://github.com/postcss/autoprefixer/compare/6.3.3...6.5.1
|
| [6103]
|
netweb
|
Build Tools: Update `grunt-check-dependencies` to v1.0.0
See https://github.com/mgol/grunt-check-dependencies/compare/0.12.0...1.0.0
|
| [6102]
|
netweb
|
General - Administration: Add i18n text domain missed in [6101]
See #2246.
|
| [6101]
|
netweb
|
General - Administration: Introduce bulk actions to spam and unspam topics and replies in wp-admin
This Friday #yolo changeset comes care of the upcoming WordPress 4.7 release via #WP16031 / wp:changeset:38647
Props jmdodd.
See #2246.
|
| [6100]
|
netweb
|
Build Tools: Switch stylelint Grunt task from `grunt postcss:lint` to `grunt stylelint`
This changeset switches the stylelint task from using the `grunt-postcss` to `grunt-stylelint` NPM module. This new Grunt module supports stylelint's native formatters and allows for improved task error reporting. This change also splits the CSS and SCSS lint tasks in preparation for a future `stylelint-config-wordpress` SCSS update.
See also: https://github.com/wikimedia/grunt-stylelint
Props netweb.
See #2924.
|
| [6099]
|
netweb
|
Topics: Revert [6098]
This doesn't work, on many levels, when testing a patch make sure the patch your testing matches the same site you're testing with.
Antiprops netweb.
See #2587.
|
| [6098]
|
netweb
|
Topics: Call `bbp_move_topic_handler()` when moving a topic to a new forum in the back end.
This changeset ensures that both the source and destination forums meta is updated when a topic is moved.
Fixes #2587.
|
| [6093]
|
netweb
|
Build Tools: Update stylelint to v7.2.0 and bump `.stylelintrc` to `stylelint-config-wordpress` v9.0.0
|
| [6092]
|
netweb
|
Bump alpha version in bbpress.php to latest revision.
|
| [6091]
|
netweb
|
Tools: Running the "Reset Forums" tool now deletes bbPress' custom post type revisions from the database.
This changeset adds support for deleting forum, topic, and reply post types revisions to `bbp_admin_reset_handler()`.
Fixes #2945.
|
| [6090]
|
netweb
|
Tests: Remove the "reply only" test from `test_bbp_update_topic_last_active_id()`
This changeset reverts a test added in r6088 that passed only the reply id to `bbp_update_topic_last_active_id()`, the test passed locally but failed on every Travis CI job except HHVM. Further investigation is required, but not today.
|
| [6089]
|
netweb
|
Locale - i18n/l10n: Differentiate the noun and verb "Reply" string.
"Reply" can be used as both a verb and a noun, this changeset adds this context to instances of the "Reply" string thus allowing the different contexts to be translated accurately.
Props ocean90.
Fixes #2977.
|
| [6088]
|
netweb
|
Tests: Improve `test_bbp_update_topic_last_active_id()` tests.
This changeset adds a passing reply id only test for `bbp_update_topic_last_active_id()`
|
| [6086]
|
netweb
|
Topics: `@uses` not `@yses` PHPDoc in `bbp_update_topic()`
|
| [6085]
|
netweb
|
Moderation: Include topic and reply post content with and without HTML in `moderation_keys` and `blacklist_keys` checks.
This changeset ensures users cannot bypass the moderation word checks by wrapping parts of the word or term in HTML, e.g. `bannedword` could previously be bypassed using `<em>banned</em>word`
Fixes #2986.
|
| [6084]
|
netweb
|
Tests: Add user email, URL, IP, moderator, keymaster `bbp_check_for_moderation()` and `bbp_check_for_blacklist()` tests
|
| [6083]
|
netweb
|
Tests: Initial `bbp_check_for_blacklist()` tests
|
| [6082]
|
netweb
|
Tests: Initial `bbp_check_for_moderation()` tests
|
| [6081]
|
netweb
|
Build Tools: Add WordPress 4.6 to Travis CI build matrix
|
| [6080]
|
netweb
|
Tests: Following r6078 update tests in `::BBP_Tests_Users_Template_User` to use single user slug `users`
See #2983
|
| [6079]
|
netweb
|
Rewrite Rules: Update search permastruct in `bbPress::add_permastructs()` to `$search_id`
This changeset fixes copy pasta introduced in r4930, and updates the search rewrite to use the `$search_id` and not the `$user_id` as the permalink structure name.
Props offereins.
Fixes #2984.
|
| [6078]
|
netweb
|
Options: Set the default value of `bbp_get_user_slug()` to `users`
This changeset updates the default single user slug from `user` to `users`. The `bbp_get_default_options()` function defines the default as `users` and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug `user` rather than `users`.
Props ocean90.
Fixes #2983
|
| [6077]
|
netweb
|
Tests: Add `test_bbp_forum_query_last_reply_id()`
See #2972
|
| [6076]
|
netweb
|
Build Tools: Fix `BBP_UnitTestCase::go_to()` for `WP_Network`.
This changeset is via buddypress:changeset:10125
Props boonebgorges.
Fixes #2981
|
| [6075]
|
netweb
|
Build Tools: More targeted cleanup for multisite unit tests.
This changeset is a subset of buddypress:changeset:9980 and removes a previous heavy-handed workaround for deleting the first multisite user. This also resolves a fatal error `Object does not implement ArrayAccess` when running the tests on HHVM.
See #2962, #2981
|
| [6074]
|
netweb
|
Build Tools: Upgrade to the latest HHVM version with Travis CI using Ubuntu Trusty
Fixes #2980.
|
| [6073]
|
netweb
|
Build Tools: Add PHP 7.1 to Travis CI and "allow to fail"
This changeset adds explict PHP 7.1 for testing bbPress, see also #WP37625
See #2980.
|
| [6072]
|
netweb
|
Options: Fix `bbp_show_on_root()` copy pasta PHPDoc description
|
| [6071]
|
netweb
|
Tests: Update forum/topic/reply post type assertions for the `WP_Post_Type` class introduced in WordPress 4.6
Fixes #2962.
|
| [6070]
|
netweb
|
Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
|
| [6069]
|
netweb
|
Fix Subscriptions slug setting field PHPDoc block copy pasta
|
| [6061]
|
netweb
|
General - Administration: Update "change forum role" dropdown
This changeset resolves an issue introduced in WordPress 4.4 ( [WP:changeset:34636] / #WP27743 ) which caused bbPress "change forum role" dropdown to only work using the "bottom" user list table dropdown, for WordPress versions < 4.6 the "change forum role" dropdown is now only shown at the "top" of the user list table.
This changeset also adds a new parameter `$which` to `user_role_bulk_dropdown()` which was added in WordPress 4.6 ( [WP:changeset:37422] / #WP35307 ) to pass the location of the extra table nav markup for the "top" or "bottom" "change role" dropdown, and in turn fixes bbPress' "change forum role" dropdown to once again work at the "top" and "bottom" of the user list table.
Props ocean90.
Fixes #2906.
|
| [6060]
|
netweb
|
Tools - Unit Tests: Use `get_sites()` for muiltisite PHPUnit testcase in `BBP_UnitTestCase::tearDown`
WordPress 4.6 deprecated `wp_get_sites()`, switch to the replacement `get_sites()` via #WP36994 / [wp:changeset:37653]
Fixes #2962.
|
| [6059]
|
netweb
|
API Feeds: RSS `<pubDate>` element in `bbp_display_topics_feed_rss2()` shouldn't be translated.
This changeset brings this RSS `<pubDate>` element inline with other instances in bbPress feeds.
Props thebrandonallen.
Fixes 2961.
|
| [6055]
|
netweb
|
General - Administration: Add pending status topic and reply statistics to `bbp_get_statistics()`
Following the introduction of "pending" status topics and replies in bbPress 2.6, `bbp_get_statistics()` now includes these count statistics in the hidden topic and reply statistics.
Fixes #2958.
|
| [6054]
|
netweb
|
Cache: Allow a second parameter to be passed to `bbp_clean_post_cache()`
Following [5774] WP's `clean_post_cache` hook can pass both post ID and the post object, this changeset allows that second parmeter to be passed to `bbp_clean_post_cache()` and updates our `add_action` call to send both parameters.
Props thebrandonallen.
Fixes #2813.
|
| [6053]
|
netweb
|
Tests: Introduce tests for the cache functions.
Props thebrandonallen.
See #2813
|
| [6052]
|
netweb
|
Administration: Only display bbPress users role in bbPress' "Forum Role" list
Since WordPress 4.4 users with multiple roles are displayed in WordPress' "Site Role" list, this changeset ensures bbPress' roles are only displayed under the "Forum Role" list and not duplicated in the "Site Role" list of the users list table.
Props johnbillion, tharsheblows for initial patches
Fixes #2874
|
| [6051]
|
netweb
|
Introduce `bbp_get_major_wp_version()` function to help checking against WordPress versions
See #2874
|
| [6050]
|
netweb
|
Moderation: Add new `bbp_moderation_keys` and `bbp_blacklist_keys` filters
This changeset allows external plugins to filter the list of moderation and blacklist keyword terms, IP, URLs, words, etc.
Also cleans up `bbp_check_for_moderation()` to bails early if there are no moderation keys inline with `bbp_check_for_blacklist()`
Props thebrandonallen, satollo.
Fixes #2861.
|
| [6049]
|
netweb
|
Build Tools: Update `grunt-patch-wordpress` to 0.4.0
This update adds two main features for your WordPress development happiness.
1) GitHub URL support. You can now use `grunt patch:https://github.com/bbpress/bbPress/pull/3` with any copy of bbPress on GitHub. No longer will you need to download the patch manually.
2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. `grunt upload_patch:20000` will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug committers). You still need to manually add the `has patch` keyword.
Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.3.0...0.4.0
Props jorbin, ericlewis, michaelbeil, netweb
|
| [6048]
|
netweb
|
Tests: Add `test_bbp_get_do_not_reply_address()` common functions reply email address test
Props thebrandonallen
Fixes #2822
|
| [6047]
|
netweb
|
Strings: Switch from "Freshness" to "Last Post" in the admin screens.
This changeset follows on from [5867] where these couple of strings were missed in the original commit.
Props Robkk, thebrandonallen
Fixes #2031
|
| [6046]
|
netweb
|
General: Add debug trace to `bbp_setup_current_user()` notice.
Previously, the `bbp_setup_current_user was called incorrectly` notice would not output any useful info for developers.
This commit adds a debug trace so developers are able to determine
whereabouts in the codebase this notice is originating from.
Props r-a-y
Fixes #2932
|
| [6045]
|
netweb
|
i18n: Avoid using HTML tags in translation strings (includes/admin/replies.php)
Props ramiy, thebrandonallen
Fixes #2912
|
| [6044]
|
netweb
|
i18n: Avoid using HTML tags in translation strings (includes/admin/topics.php)
Props ramiy, thebrandonallen
Fixes #2911
|
| [6043]
|
netweb
|
i18n: Avoid using HTML tags in translation strings (includes/admin/forums.php)
Props ramiy, thebrandonallen
Fixes #2910
|
| [6042]
|
netweb
|
i18n: Avoid using HTML tags in translation strings
Props ramiy, thebrandonallen
Fixes #2881
|
| [6041]
|
netweb
|
Importers: In `BBP_Converter_Base::convert_table()` method use `isset()` rather than `! is_null`
Props Offereins
Fixes #2733
|
| [6040]
|
netweb
|
Admin: Escape `$file` variable for importer filenames in `bbp_converter_setting_callback_platform()`
Props xknown
Fixes #2792
|
| [6038]
|
netweb
|
Widgets: Use `$this->get_field_id()` in `BBP_Topics_Widget::form()` method to correctly create the widget id form attribute
Props alex-ye
Fixes #2758
|
| [6037]
|
netweb
|
Replies: Fix `@param` PHPDoc in `bbp_insert_topic_update_counts()`
See #1799
|
| [6036]
|
netweb
|
General Performance: Introduce increase/decrease helper count functions
Previously when a new topic or reply was created, a bunch of queries to recalculate the topic and reply counts for topics and forums were ran. Now these have been replaced with more efficient increase/decrease helper functions to get the current value and just "bump" the count based on the action (new topic-reply/split-topic/move-topic/spam-trash-topic/etc...)
Props thebrandonallen, tharsheblows, netweb
See #1799
|
| [6035]
|
netweb
|
Build Tools: Update `stylelint` to v6.5.1 and bump `.stylelintrc` to `stylelint-config-wordpress` v7.1.1
See #2924
|
| [6034]
|
netweb
|
Subscriptions: Update `bbp_new_reply` action to to use `bbp_notify_topic_subscribers` over deprecated `bbp_notify_subscribers`.
Previously in [5643] this was added to the 2.5 branch but was overlooked for `/trunk`, this changeset fixes that.
Props thebrandonallen
Fixes #2946, see also #2618
|
| [6031]
|
netweb
|
Tests: In PHPUnit bootstrap check if the `BP_TESTS_DIR` constant is first defined before attempting to load BuddyPress PHPunit `testcase.php`
|
| [6030]
|
netweb
|
Tests: Following [6010] Add SpeedTrapListener to `buddypress.xml` and `multisite.xml` PHPUnit configuration files
|
| [6029]
|
netweb
|
Build Tools: Update `grunt-sass` to v1.2.0 with `node-sass` > v3.7.x support
See https://github.com/sindresorhus/grunt-sass/compare/v1.1.0...v1.2.0
|
| [6028]
|
netweb
|
Build Tools: Update stylelint to 6.4.2
See #2924
|
| [6025]
|
netweb
|
Build Tools: Set a whitelist for PHPUnit code coverage
This chageset adds a PHPUnit whitelist of files for use with code coverage tests analsyis tools.
Hat tip jorbin.
Fixes #2953.
|
| [6022]
|
netweb
|
Tests: Add `@covers` annotations to `BBP_Tests_Common_Functions_Make_Clickable` tests
|
| [6021]
|
netweb
|
API - Feeds: Use `feed_content_type( 'rss2' )` for RSS feeds.
This changeset updates the RSS 2 native mime type `application/rss+xml`, previously `rss-http` used `text/xml` which was removed from WordPress in [WP36230] and [WP32468].
(2.5 branch)
Props thebrandonallen.
Fixes #2901.
|
| [6020]
|
netweb
|
Forums: Overzealous type coercion caused `bbp_forum_query_last_reply_id()` to skip the database query in every instance (since 0 is never === false). As such, the resetting of `_bbp_last_reply_id` got short-circuted in some cases.
This fix is for the 2.5 branch, `/trunk` fixed this inadvertantly in [5954]
Props boonebgorges, mauteri.
Fixes #2414.
|
| [6011]
|
netweb
|
Tests: Improve test performance by reducing the number of topics and replies created in `test_bbp_forum_trashed_untrashed_topic_counts()` and `test_bbp_forum_spammed_unspammed_topic_counts()` tests
|
| [6010]
|
netweb
|
Tests: Add `SpeedTrapListener` to `phpunit/includes` and add the config node to `phpunit.xml.dist`.
This changeset via wp:changeset:35214 adds a PHPUnit TestListener that exposes the slowest running tests by outputting results to the console.
|
| [6009]
|
netweb
|
Tests: Add recount forum topics repair tool test `test_bbp_admin_repair_forum_topic_count()`
|
| [6008]
|
netweb
|
Tests: Update inline docs in `test_bbp_admin_repair_forum_reply_count()` from [6007]
|
| [6007]
|
netweb
|
Tests: Add recount forum replies repair tool test `test_bbp_admin_repair_forum_reply_count()`
|
| [6006]
|
netweb
|
Tests: Include forum category tests in `bbp_*_forum_*_count()` template functions.
This changeset improves forum template count tests adding category total topic and total reply counts which are calculated differently to forum topic and reply counts.
See #1799
|
| [6005]
|
netweb
|
Tools: Travis CI The Matrix Reloaded
'''The Architect''': ''The first matrix I designed was quite naturally perfect. It was a work of art. Flawless. Sublime. A triumph only equaled by its monumental failure.''
|
| [6004]
|
netweb
|
Tests: Include forum category and forum category meta in `test_bbp_insert_forum()`
This changeset improves `bbp_insert_forum()` testing using hierarchical category/forum (parent/child) forums post and post meta integrity.
|
| [6003]
|
netweb
|
Build Tools: Add WordPress 4.5 to Travis CI build matrix
|
| [6002]
|
netweb
|
Tools: Return unique message strings in `bbp_admin_reset_handler()` when deleting imported users and user meta vs non-imported user meta.
Fixes #2928.
|
| [6001]
|
netweb
|
API - Importers: Xenforo:
* Adds support for "soft deleted" topics and replies imported as "pending" status
* Add support for YouTube, Vimeo, and Daily Motion BBCode conversion
* Add quotes BBCode conversion
Fixes #2927
|
| [6000]
|
netweb
|
Build Tools: Revert [5999] `grunt-legacy-util` update, from 0.2.0 to 1.0.0
This changeset reverts the above change as I missed the `1.0.0` recommended [https://github.com/gruntjs/grunt-legacy-util/blob/master/README.md change] to use `require('child_process').spawn` over `grunt.util.spawn`. Per NodeJS docs [https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options here] and [https://nodejs.org/dist/latest-v4.x/docs/api/child_process.html#child_process_child_process_spawn_command_args_options here] for NodeJS versions 5.x and 4.x respectively this needs some more testing and changes to the Grunt phpunit task and multi task.
Another option per [https://github.com/gruntjs/grunt-legacy-util/issues/10 grunt-legacy-util #10] is to switch to [https://www.npmjs.com/package/cross-spawn-async cross-spawn-async]
Both above options will require *nix and Windows testing.
''6000 is the natural number following 5999 and preceding 6001.''
See #2918
|
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
