| [6987]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
For 2.6.3, branches/2.6.
|
| [6986]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
|
| [6985]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.7, trunk.
|
| [6984]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.6.3, branches/2.6.
|
| [6983]
|
johnjamesjacoby
|
Tag 2.6.2.
|
| [6982]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.6.2, branches/2.6.
|
| [6981]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.7, trunk.
|
| [6980]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk.
|
| [6979]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6.
|
| [6978]
|
johnjamesjacoby
|
Bump versions to 2.6.2.
|
| [6975]
|
johnjamesjacoby
|
Capabilities: break instead of return.
This commit ensures that the relative _meta_caps filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return $caps without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.7, trunk.
|
| [6974]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
| [6973]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
| [6972]
|
johnjamesjacoby
|
Capabilities: break instead of return;
This commit ensures that the relative `_meta_caps` filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return `$caps` without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.6.2.
|
| [6971]
|
johnjamesjacoby
|
Docs: add note to `bbp_get_excluded_forum_ids()` about per-forum moderators.
|
| [6970]
|
johnjamesjacoby
|
Add a new line where there should be one.
|
| [6969]
|
johnjamesjacoby
|
Default Styling: Optionally support an RTL variant of bbpress.css.
This commit allows for either/or `bbpress.css` or `bbpress-rtl.css` to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.
This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.
Props scmsteve for persistence. Fixes #3218. For 2.6.2, branches/2.6.
|
| [6968]
|
johnjamesjacoby
|
Default Styling: Optionally support an RTL variant of bbpress.css.
This commit allows for either/or `bbpress.css` or `bbpress-rtl.css` to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.
This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.
Props scmsteve for persistence. Fixes #3218. For 2.7, trunk.
|
| [6967]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.7, trunk.
|
| [6966]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.6.2, branches/2.6.
|
| [6965]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.6.2, branches/2.6.
|
| [6964]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.7, trunk.
|
| [6961]
|
johnjamesjacoby
|
Reduce number of tags in readme.txt.
|
| [6960]
|
johnjamesjacoby
|
Reduce number of tags in readme.txt.
|
| [6959]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa (for trunk)
|
| [6958]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa.
|
| [6957]
|
johnjamesjacoby
|
Tag 2.6.1.
|
| [6956]
|
johnjamesjacoby
|
Theme Compat: Fix CSS overlapping border-radius from r6951.
Also bump package-lock.json.
|
| [6955]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6.
|
| [6954]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.7, trunk.
|
| [6953]
|
johnjamesjacoby
|
Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.7, trunk.
|
| [6952]
|
johnjamesjacoby
|
Theme Compat: resolve a number of issues brought up after 2.6 was released.
This commit does the following:
* Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty
* Restores text-underline styling for topic & reply content for Twenty Seventeen
* Removes text-underline for revisions
* Fixes padding & margins on small screens across all themes
See #3281. For 2.7, trunk.
|
| [6951]
|
johnjamesjacoby
|
Theme Compat: resolve a number of issues brought up after 2.6 was released.
This commit does the following:
* Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty
* Restores text-underline styling for topic & reply content for Twenty Seventeen
* Removes text-underline for revisions
* Fixes padding & margins on small screens across all themes
See #3281. For 2.6.1, branches/2.6.
|
| [6950]
|
johnjamesjacoby
|
Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.6.1, branches/2.6
|
| [6949]
|
johnjamesjacoby
|
Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.6.1, branches/2.6.
|
| [6948]
|
johnjamesjacoby
|
Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.7, trunk.
|
| [6944]
|
johnjamesjacoby
|
Bump trunk to 2.7.0-alpha-1.
|
| [6943]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.1.
|
| [6942]
|
johnjamesjacoby
|
Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.6.1, branches/2.6.
|
| [6941]
|
johnjamesjacoby
|
Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.7, trunk.
|
| [6940]
|
johnjamesjacoby
|
Tag 2.6.0.
|
| [6939]
|
johnjamesjacoby
|
Create 2.6 branch (from trunk)
|
| [6938]
|
johnjamesjacoby
|
Bump everything, including the version (to 2.6.0!)
|
| [6937]
|
johnjamesjacoby
|
Fix Sergey's avatar. <3
|
| [6936]
|
johnjamesjacoby
|
Retro TV styling for contributor avatars. 📺
|
| [6935]
|
johnjamesjacoby
|
Tools: reduce the number of calls to `bbp_is_large_install()`.
This commit refactors the update code to only call `bbp_is_large_install()` once, a function which ironically enough is costly to call on very large installations, so calling it 3 times defeats the purpose, but calling it one time is the minimum requirement to defer upgrades & repairs for keymaster interaction.
See #3052.
|
| [6934]
|
johnjamesjacoby
|
Tools: allow repairs to also be pending.
This commit makes Repairs work like Upgrades, allowing for repair tools to also be pending. It adds a $type parameter to a few functions to allow grouping or separating, depending on the count context.
See #3052.
|
| [6933]
|
johnjamesjacoby
|
Repair Tools: rename forum reply hidden count function, and fix default sort order.
This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
|
| [6932]
|
johnjamesjacoby
|
Accessibility: improve contrast of admin/moderation links.
This commit darkens the text used by the links in topics & replies, making them easier to see.
Fixes #3003. Props mercime, thebrandonallen.
|
| [6931]
|
johnjamesjacoby
|
Topics/Replies: improved support for replies without topics.
This commit removes an assumptive call to `bbp_get_topic()` and avoids a debug notice when a reply is orphaned.
See #3226.
|
| [6930]
|
johnjamesjacoby
|
Topic Views: pass view ID into body class.
This commit does a quick audit of Topic View API functions, and ensures their return values are as documented. This allows for safely adding the Topic View ID as a class to the body element of the page when viewing a single Topic View.
Fixes #3278. Props Clorith.
|
| [6929]
|
johnjamesjacoby
|
Importer: remove byref usade in parser.php.
This commit removes an old byref in the bbCode parser. It wasn't really necessary, and was causing problems with certain PHP versions.
Fixes #3257. Props webmaigcz.
|
| [6928]
|
johnjamesjacoby
|
Importer: make inside meta-box contents a bit more squared.
This change fixes a padding issue with the inner meta-box content, causing there to be more space on the bottom than on the top.
|
| [6927]
|
johnjamesjacoby
|
Tools: wrap routine descriptions in a description paragraph tag.
This commit ensures that the descriptive text used to highlight what a specific tool does does not blend in with the title above it.
Fixes #3277. Props JarretC.
|
| [6926]
|
johnjamesjacoby
|
Upgrades: Link to pending upgrades, if there are any.
This commit modifies the "Upgrade Forums" page by adding Statuses to filter by, specifically for pending upgrades. This allows bbPress to link directly to the upgrades that need doing, rather than the generic page itself.
Along with this commit are accompanying styling tweaks and helper functions to make this functionality possible.
Fixes #3244.
|
| [6925]
|
johnjamesjacoby
|
Tools: Make a few columns sortable.
This commit adds a small UX improvement to the Repair and Upgrade tools pages, allowing for these lengthy lists to be sorted.
See #3244.
|
| [6924]
|
johnjamesjacoby
|
Docs: add missing project names after recently added @since's.
|
| [6923]
|
johnjamesjacoby
|
Counts (meta-data): full audit of forum/topic/reply, public/non-public counts.
This commit is the result of a full count audit, exposing multiple inconsistencies and voids in relation to how public and non-public counts are (re)calculated.
For instance, hidden forum replies are not counted at all, until now. By introducing a new Repair tool, hidden forum reply counts are now counted.
In addition, there were multiple bugs with topic & reply moderation, where the act of approving or unapproving topics or replies would cause the numbers to be inaccurate, or where topics & replies being caught in moderation were still increasing public counts.
It was also possible to, as a Key Master, publicly reply to unapproved topics, which was a completely unanticipated side-effect of allowing Key Masters to do pretty much anything. Going forward, the default reply status is the topic status, but is still beholden to all existing moderation settings and user role capabilities. This results in a more sane user experience, and prevents the unusual circumstance of there being "0 topics and 30 replies" in public-facing forums.
Certain count increase/decrease actions have been reprioritized to avoid collisions and race conditions, proving once again that ya gotta get up to get down.
See #2838. Fixes #1799.
|
| [6922]
|
johnjamesjacoby
|
Statuses: normalize status related functions across post types.
This commit adds 2 missing functions for forum statuses, and relocates all of them to the correct functions.php files for their post types.
|
| [6921]
|
johnjamesjacoby
|
Moderation: make sure pending topics (for moderation reasons) are accessible to authors.
This commit updates the logic inside of the topic & reply map-meta-cap implementations, restricting edit-lock checks to actual "Edit" screens, and using the "edit_others_posts" capability in non-"Edit" screens, ensuring that both scenarios are covered.
It also adds an explicit condition for Pending Topics to both the Topic Description and Topic Notices, alerting users as to why they are seeing what they are seeing.
Fixes #3253 (again!) See also #3164 for other related discussion & details.
|
| [6920]
|
johnjamesjacoby
|
Edit Locking: Remove redundant $minutes check in `bbp_past_edit_lock()`.
This commit is just a small bit of cleanup from researching #3164.
See #3222.
|
| [6919]
|
johnjamesjacoby
|
Emails: chunk notification emails into 40 Bcc'd recipients.
This commit introduces the `bbp_mail` subfilter, used to target bbPress specific emails in conjunction with `bbp_get_email_header()` to help identify emails that came specifically from bbPress actions.
The purpose of this change is to help forum owners avoid their outbound emails being marked as spam, due to the high number of users that can be subscribed to any given forum or topic.
This change (combined with r6725) goes a long way towards improving the success of subscription emails reaching their intended recipients.
Fixes #3260. Props danielbachhuber.
|
| [6918]
|
johnjamesjacoby
|
Subscriptions: clean up code comparisons and documentation.
This commit adds some inline documentation to provide a bit more clarity around what subnscriptions checks and actions are being taken, and adds parenthesis to nested comparisons to improve code readability.
See #3235.
|
| [6917]
|
johnjamesjacoby
|
Anonymous: delete meta key if value is empty.
This commit ensures that editing a non-anonymous topic via WordPress Admin does not erroneously add empty anonymous author keys to post meta.
|
| [6916]
|
johnjamesjacoby
|
Subscriptions: pass additional IDs into user ID filters.
This commit adds forum, topic, and reply IDs to the filters commonly used to filter the user IDs that emails are being sent to, providing a quick opportunity to peek at them easily and make decisions based on what they are at the time.
Fixes #3249. Props satollo.
|
| [6915]
|
johnjamesjacoby
|
Stickies: make sure unapproved topics are unstuck also.
This commit removes a hard coded call to `bbp_unstick_topic()` and hooks into the neighboring `bbp_stick_topic` action, while also hooking into the `bbp_unapprove_topic` action.
A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code.
Fixes #3246.
|
| [6914]
|
johnjamesjacoby
|
Engagements: always show user avatars in subscription/favorite metaboxes.
This commit introduces a helper function (to reduce code duplication) responsible for looping through queried users and outputting avatars and profile links.
A developers note is included in the function docs discouraging third-party plugin developers from using it, as future iterations of bbPress may modify its output without notice.
Fixes #3272.
|
| [6913]
|
johnjamesjacoby
|
Admin: Correctly register scripts & styles before enqueing them.
This commit moves style/script registration to dedicated admin-area actions, separating them from their relative enqueing actions.
It also deprecates the singular (incorrectly named) "bbp_register_admin_style" action and replaces it with the correctly named plural "bbp_register_admin_styles".
|
| [6911]
|
johnjamesjacoby
|
Bump dev dependencies.
|
| [6910]
|
johnjamesjacoby
|
Appearance: Use right-to-left suffix in default template pack.
Fixes #3263. Props GDragoN.
|
| [6909]
|
johnjamesjacoby
|
Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`.
This commit allows the freshness repair tool to correctly query for the maximum topic ID.
Fixes #3261.
Props GDragoN.
For 2.5.x.
|
| [6908]
|
johnjamesjacoby
|
Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`.
This commit allows the freshness repair tool to correctly query for the maximum topic ID.
Fixes #3261.
Props GDragoN.
For 2.6 (trunk.)
|
| [6906]
|
johnjamesjacoby
|
Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`.
This commit allows the favorites repair tool to correctly query for chunked results.
Fixes #3259.
Props GDragoN.
For 2.5.x.
|
| [6905]
|
johnjamesjacoby
|
Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`.
This commit allows the favorites repair tool to correctly query for chunked results.
See #3259.
Props GDragoN.
For 2.6/trunk.
|
| [6904]
|
johnjamesjacoby
|
Subscriptions: ensure special characters in author names are encoded properly.
This commit copies the approach used on the content, and applies `wp_specialchars_decode()` and `strip_tags()` to author names in subscription emails.
(HTML tags are not usually allowed in usernames, but we strip them anyways in the event a filter allowed them. Better to keep emails legible than include unintended tags?)
Fixes #3256.
|
| [6903]
|
johnjamesjacoby
|
Search: add support for `fs` query-arg to search forums list:
* Introduces `bbp_sanitize_search_request()` to encapsulate duplicate code across forums/topics/replies
* Introduces `bbp_get_search_type_ids()` to stub out future enhancements (tags, users, etc...)
* Use these new functions where intended
* Update `bbp_get_search_terms()` to loop through known search-type IDs
This commit also fixes debug notices that would happen when these query arguments were not explicitly strings.
Fixes #3245.
|
| [6902]
|
johnjamesjacoby
|
Locale: update post type labels to include recent additions to WordPress.
This commit adds several new label keys to the arrays for the Forum/Topic/Reply post types. It also removes some duplicated keys that have slipped in over time.
Props GDragoN. Fixes #3250.
|
| [6901]
|
johnjamesjacoby
|
Upgrades: add `empty()` checks to untrusted variable values to avoid debug notices.
This change ensures that menu manipulations are not attempted via admin-area requests where they are not necessary (AJAX, shortinit, etc...) and fixes debug notices under those circumstances.
|
| [6898]
|
johnjamesjacoby
|
Subscriptions: do not send subscription emails during WordPress imports.
This change adds checks to the `WP_IMPORTING` global constant inside of forum & topic subscription notification functions, to prevent sending emails during the import process.
Because hooks still fire during imports, this sanity check avoids a potentially hugely annoying situation for users during forum migrations by any import tool that obeys the use of this core constant.
Fixes #3248. Props danielbachhuber.
|
| [6897]
|
johnjamesjacoby
|
Upgrades: append upgrade count to "Tools" if there are pending upgrades
* Add function and method to tweak the `$menu` global
* Add styling for count in `nav-tab-wrapper` UI
This change adds a `span.awaiting-mod` wrapper around the pending upgrade count in a few strategic locations around the WordPress Admin UI.
See #3244.
|
| [6896]
|
johnjamesjacoby
|
Upgrades: change skipped upgrades to pending upgrade
* Add functions for managing pending upgrades
* Use IDs instead of strings for active tools tab
* Add classes and `hr` for related H1's
* Update registered option key name
* Add skipped upgrades to pending upgrades array
* Add `span` to allowed tags in notices
These changes are necessary to bring adimn pages up to speed with WordPress Admin UI mark-up, in relation to the database upgrade notice.
See #3244.
|
| [6895]
|
johnjamesjacoby
|
Upgrades: add "Version" column to upgrades list table.
See #3244.
|
| [6894]
|
johnjamesjacoby
|
Upgrades: add support for "Version" filter & links in list table.
* Adds functions for outputting in a table row and select dropdown
* Adds a function to allow special translating of version numbers
* Adds numerous improvements for PHP 7.3 compat
* Adds escaping and formatting in several places where it was previously omitted
* Adds `—` to empty columns
* Adds functions for getting the current page ID
See #3244.
|
| [6893]
|
johnjamesjacoby
|
Upgrades: add column width styling to tools list tables.
This ensures that columns are usually wide enough to fit their anticipated contents.
See #3244.
|
| [6892]
|
johnjamesjacoby
|
Upgrades: add `version` and update strings to repair tools.
This change adds a version property to the relevant upgrades, and removes some redundant information from each description.
See #3244.
|
| [6891]
|
johnjamesjacoby
|
Upgrades: remove duplicate `wp_cache_flush()` call.
From `bbp_admin_repair_reply_menu_order()`, since repair tools flush the caches anyways, this is not necessary here.
Found during work on #3244.
|
| [6890]
|
johnjamesjacoby
|
Upgrades: add support for `version` key in repair tool registration.
This will get used by individual tools, to provide a UI for routines that need to be run between version upgrades.
See #3244.
|
| [6889]
|
johnjamesjacoby
|
Rewrites: use `property_exists()` on `$wp_rewrite` global touches.
This makes sure that bbPress defaults are preferred, and avoids fatal errors if class properties are unset.
Also relocate `bbp_use_pretty_urls()` to better group it together with other `bbp_rewrite()` wrappers.
|
| [6888]
|
johnjamesjacoby
|
Parser: revert error control operator change from r6887.
See also r6633 for original change.
|
| [6887]
|
johnjamesjacoby
|
Parser: Fix PHP 7.3 warning ("continue" in "switch" is equal to "break")
Fixes #3242.
|
| [6886]
|
johnjamesjacoby
|
Subscriptions: Do not add or remove subscriptions when editing via WordPress admin.
This change passes the current post ID through to `bbp_is_user_subscribed()`, ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status.
Fixes #3235.
|
| [6885]
|
johnjamesjacoby
|
Formatting: update `bbp_make_clickable()` to better handle spaces in `href` attributes.
This change updates the included regular expression to avoid returning broken (or at least unexpected) HTML and allows spaces in `href` attributes to be encoded as expected.
Props dd32. Fixes #3237.
|
| [6884]
|
johnjamesjacoby
|
Topic Tags: remove extraneous `span` tag from topic-tag titles when theme-compat is employed.
This change removes a `span` tag that was originally required before support for topic-tag-edit templates was added.
Props mechter. Fixes #3236.
|
| [6883]
|
johnjamesjacoby
|
Styling: Remove unused `row-actions` CSS.
This used to be necessary for BuddyPress theme compatibility, but is no longer.
See #3238, for trunk (2.6)
|
| [6882]
|
johnjamesjacoby
|
Tools: update npm package dependencies.
|
| [6881]
|
johnjamesjacoby
|
Titles: add comment about `8bit` mode usage of `mb_strlen()` to provide extra context.
(After looking at this again, I wasn't confident it was correct. It seems to be, given how it's being used.)
See #3189.
|
| [6880]
|
johnjamesjacoby
|
Subscriptions: replace hard-coded, single-use strings with `no-forums` template part.
|
| [6879]
|
johnjamesjacoby
|
Tag 2.6 RC 7.
|
| [6878]
|
johnjamesjacoby
|
Bump trunk to 2.6-rc7.
|
| [6877]
|
johnjamesjacoby
|
Engagements: demystify strategy sanitization.
This change ensures that invalid/unavailable strategies are never used, and also allows for custom strategies to exist (custom table, etc...) without requiring strategy registration.
See #3211.
|