| [7022]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.4-alpha-1.
|
| [7021]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7020]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7019]
|
johnjamesjacoby
|
Tag 2.6.3.
|
| [7018]
|
johnjamesjacoby
|
Remove alpha designation from 2.6 branch, for 2.6.3.
|
| [7017]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.7, trunk.
|
| [7016]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.6.3, branches/2.6.
|
| [7015]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.7, trunk.
|
| [7014]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.6.3, branches/2.6.
|
| [7013]
|
johnjamesjacoby
|
Engagements: stop shouting.
This commit removes the last remaining exclamation mark from some engagements feedback.
Props casiepa. Fixes #3293. For 2.7, trunk.
|
| [7012]
|
johnjamesjacoby
|
Engagements: stop shouting.
This commit removes the last remaining exclamation mark from some engagements feedback.
Props casiepa. Fixes #3293. For 2.6.3, branches/2.6.
|
| [7011]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6.
|
| [7010]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.7, trunk.
|
| [7009]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.7, trunk.
|
| [7008]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.6.3, branches/2.6.
|
| [7005]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
Revert r7002 and use a different syntax to avoid debug notices.
|
| [7004]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
Revert r7003 and use a different syntax to avoid debug notices.
|
| [7003]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
|
| [7002]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
|
| [7001]
|
johnjamesjacoby
|
Theme Compat: Revert `sans-serif` override from r6986.
This commit fixes a regression causing theme styling to to be applied, while also overriding some styling that was intentional.
|
| [7000]
|
johnjamesjacoby
|
Theme Compat: Revert `sans-serif` override from r6987.
This commit fixes a regression causing theme styling to to be applied, while also overriding some styling that was intentional.
|
| [6999]
|
johnjamesjacoby
|
Theme Compat: Don't override elements that are explicitly using `.dashicons`.
This commit prevents styling conflicts with third party plugins that are using Dashicons in elements.
See r6986.
|
| [6998]
|
johnjamesjacoby
|
Theme Compat: Don't override elements that are explicitly using `.dashicons`.
This commit prevents styling conflicts with third party plugins that are using Dashicons in elements.
See r6987.
|
| [6997]
|
johnjamesjacoby
|
Theme Compat: Add back original `ul` styling.
This commit fixes an unintentional styling change. The original rule should not have been removed.
See r6986.
|
| [6996]
|
johnjamesjacoby
|
Theme Compat: Add back original `ul` styling.
This commit fixes an unintentional styling change. The original rule should not have been removed.
See r6987.
|
| [6995]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.3-alpha.
|
| [6994]
|
johnjamesjacoby
|
Bump packages.
|
| [6993]
|
johnjamesjacoby
|
Engagements: add caching to User strategy, for 2.5 compatibility.
This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).
Props johnjamesjacoby, netweb. Fixes #3292. For 2.7, trunk.
|
| [6992]
|
johnjamesjacoby
|
Engagements: add caching to User strategy, for 2.5 compatibility.
This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).
Props johnjamesjacoby, netweb. Fixes #3292. For 2.6.3, branches/2.6.
|
| [6991]
|
johnjamesjacoby
|
Locale: use correct singular versions, and format numeric results.
This commit fixes 2 typos causing plural versions of strings to appear where singulars should, and also makes sure that related numeric upgrade routine results are formatted.
Props webaware. Fixes #3290. For 2.6.3, branches/2.6.
|
| [6990]
|
johnjamesjacoby
|
Locale: use correct singular versions, and format numeric results.
This commit fixes 2 typos causing plural versions of strings to appear where singulars should, and also makes sure that related numeric upgrade routine results are formatted.
Props webaware. Fixes #3290. For 2.7, trunk.
|
| [6989]
|
johnjamesjacoby
|
Locale: fix an encoding typo.
This commit fixes a hard-to-see character encoding bug causing a right-quote to be incomplete in an admin-area Help Tab.
Props casiepa. Fixes #3291. For 2.7, trunk.
|
| [6988]
|
johnjamesjacoby
|
Locale: fix an encoding typo.
This commit fixes a hard-to-see character encoding bug causing a right-quote to be incomplete in an admin-area Help Tab.
Props casiepa. Fixes #3291. For 2.6.3, branches/2.6.
|
| [6987]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
For 2.6.3, branches/2.6.
|
| [6986]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
|
| [6985]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.7, trunk.
|
| [6984]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.6.3, branches/2.6.
|
| [6983]
|
johnjamesjacoby
|
Tag 2.6.2.
|
| [6982]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.6.2, branches/2.6.
|
| [6981]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.7, trunk.
|
| [6980]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk.
|
| [6979]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6.
|
| [6978]
|
johnjamesjacoby
|
Bump versions to 2.6.2.
|
| [6975]
|
johnjamesjacoby
|
Capabilities: break instead of return.
This commit ensures that the relative _meta_caps filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return $caps without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.7, trunk.
|
| [6974]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
| [6973]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
| [6972]
|
johnjamesjacoby
|
Capabilities: break instead of return;
This commit ensures that the relative `_meta_caps` filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return `$caps` without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.6.2.
|
| [6971]
|
johnjamesjacoby
|
Docs: add note to `bbp_get_excluded_forum_ids()` about per-forum moderators.
|
| [6970]
|
johnjamesjacoby
|
Add a new line where there should be one.
|
| [6969]
|
johnjamesjacoby
|
Default Styling: Optionally support an RTL variant of bbpress.css.
This commit allows for either/or `bbpress.css` or `bbpress-rtl.css` to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.
This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.
Props scmsteve for persistence. Fixes #3218. For 2.6.2, branches/2.6.
|
| [6968]
|
johnjamesjacoby
|
Default Styling: Optionally support an RTL variant of bbpress.css.
This commit allows for either/or `bbpress.css` or `bbpress-rtl.css` to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.
This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.
Props scmsteve for persistence. Fixes #3218. For 2.7, trunk.
|
| [6967]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.7, trunk.
|
| [6966]
|
johnjamesjacoby
|
Slugs: add support for configuring the "Edit" slug.
This commit adds supporting functions and UI for allowing the `edit` slug to be modified. This omission was originally intentional, as the rewrite rules and pretty permalink support were not fully implemented. Now that they are in 2.6, there is no reason not to allow this slug to be modified.
Related changes include swapping out the new slug setting for the rewrite ID in a few places, and removing a single hardcoded reference to `'edit'` that was also overlooked.
Props espellcaste for noticing. Fixes #3285. For 2.6.2, branches/2.6.
|
| [6965]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.6.2, branches/2.6.
|
| [6964]
|
johnjamesjacoby
|
Replies: ensure visual editor works correctly with hierarchical replies.
This commit updates reply.js in the default theme to include a bit of element juggling that prevents TinyMCE from freezing up when it is relocated on the page.
Before this commit, clicking "Reply" while having the Visual Editor enabled would cause it to not be able to be typed inside of. Now, when clicking commit, TinyMCE is correctly reinvoked in its new location, and the page will expediently scroll to that new position, fixing a related UX bug where it was possible for the reply form to get lost inside of deep hierarchies.
Props chherbst. Fixes #2646. For 2.7, trunk.
|
| [6961]
|
johnjamesjacoby
|
Reduce number of tags in readme.txt.
|
| [6960]
|
johnjamesjacoby
|
Reduce number of tags in readme.txt.
|
| [6959]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa (for trunk)
|
| [6958]
|
johnjamesjacoby
|
Replace extensive changelog with a single link to the Codex.
Props casiepa.
|
| [6957]
|
johnjamesjacoby
|
Tag 2.6.1.
|
| [6956]
|
johnjamesjacoby
|
Theme Compat: Fix CSS overlapping border-radius from r6951.
Also bump package-lock.json.
|
| [6955]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6.
|
| [6954]
|
johnjamesjacoby
|
Settings: revert accidental string change from r6485.
Fixes #3279. Props SergeyBiryukov. For 2.7, trunk.
|
| [6953]
|
johnjamesjacoby
|
Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.7, trunk.
|
| [6952]
|
johnjamesjacoby
|
Theme Compat: resolve a number of issues brought up after 2.6 was released.
This commit does the following:
* Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty
* Restores text-underline styling for topic & reply content for Twenty Seventeen
* Removes text-underline for revisions
* Fixes padding & margins on small screens across all themes
See #3281. For 2.7, trunk.
|
| [6951]
|
johnjamesjacoby
|
Theme Compat: resolve a number of issues brought up after 2.6 was released.
This commit does the following:
* Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty
* Restores text-underline styling for topic & reply content for Twenty Seventeen
* Removes text-underline for revisions
* Fixes padding & margins on small screens across all themes
See #3281. For 2.6.1, branches/2.6.
|
| [6950]
|
johnjamesjacoby
|
Author Links: remove default non-breaking space.
This commit fixes an inconsistency with author links, causing whitespace in some places but not others.
See #3281. For 2.6.1, branches/2.6
|
| [6949]
|
johnjamesjacoby
|
Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.6.1, branches/2.6.
|
| [6948]
|
johnjamesjacoby
|
Meta Registration: add `auth_callback` to count meta arguments.
This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens.
Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side.
This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data.
It also adds more verbose inline documentation to each argument, for improved clarity and future reference.
Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.7, trunk.
|
| [6944]
|
johnjamesjacoby
|
Bump trunk to 2.7.0-alpha-1.
|
| [6943]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.1.
|
| [6942]
|
johnjamesjacoby
|
Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.6.1, branches/2.6.
|
| [6941]
|
johnjamesjacoby
|
Subforums: use the default forum ID when listing subforums.
This commit fixes a regression causing subforums not be listed in forum indexes.
Fixes #3232. Props scmsteve. For 2.7, trunk.
|
| [6940]
|
johnjamesjacoby
|
Tag 2.6.0.
|
| [6939]
|
johnjamesjacoby
|
Create 2.6 branch (from trunk)
|
| [6938]
|
johnjamesjacoby
|
Bump everything, including the version (to 2.6.0!)
|
| [6937]
|
johnjamesjacoby
|
Fix Sergey's avatar. <3
|
| [6936]
|
johnjamesjacoby
|
Retro TV styling for contributor avatars. 📺
|
| [6935]
|
johnjamesjacoby
|
Tools: reduce the number of calls to `bbp_is_large_install()`.
This commit refactors the update code to only call `bbp_is_large_install()` once, a function which ironically enough is costly to call on very large installations, so calling it 3 times defeats the purpose, but calling it one time is the minimum requirement to defer upgrades & repairs for keymaster interaction.
See #3052.
|
| [6934]
|
johnjamesjacoby
|
Tools: allow repairs to also be pending.
This commit makes Repairs work like Upgrades, allowing for repair tools to also be pending. It adds a $type parameter to a few functions to allow grouping or separating, depending on the count context.
See #3052.
|
| [6933]
|
johnjamesjacoby
|
Repair Tools: rename forum reply hidden count function, and fix default sort order.
This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
|
| [6932]
|
johnjamesjacoby
|
Accessibility: improve contrast of admin/moderation links.
This commit darkens the text used by the links in topics & replies, making them easier to see.
Fixes #3003. Props mercime, thebrandonallen.
|
| [6931]
|
johnjamesjacoby
|
Topics/Replies: improved support for replies without topics.
This commit removes an assumptive call to `bbp_get_topic()` and avoids a debug notice when a reply is orphaned.
See #3226.
|
| [6930]
|
johnjamesjacoby
|
Topic Views: pass view ID into body class.
This commit does a quick audit of Topic View API functions, and ensures their return values are as documented. This allows for safely adding the Topic View ID as a class to the body element of the page when viewing a single Topic View.
Fixes #3278. Props Clorith.
|
| [6929]
|
johnjamesjacoby
|
Importer: remove byref usade in parser.php.
This commit removes an old byref in the bbCode parser. It wasn't really necessary, and was causing problems with certain PHP versions.
Fixes #3257. Props webmaigcz.
|
| [6928]
|
johnjamesjacoby
|
Importer: make inside meta-box contents a bit more squared.
This change fixes a padding issue with the inner meta-box content, causing there to be more space on the bottom than on the top.
|
| [6927]
|
johnjamesjacoby
|
Tools: wrap routine descriptions in a description paragraph tag.
This commit ensures that the descriptive text used to highlight what a specific tool does does not blend in with the title above it.
Fixes #3277. Props JarretC.
|
| [6926]
|
johnjamesjacoby
|
Upgrades: Link to pending upgrades, if there are any.
This commit modifies the "Upgrade Forums" page by adding Statuses to filter by, specifically for pending upgrades. This allows bbPress to link directly to the upgrades that need doing, rather than the generic page itself.
Along with this commit are accompanying styling tweaks and helper functions to make this functionality possible.
Fixes #3244.
|
| [6925]
|
johnjamesjacoby
|
Tools: Make a few columns sortable.
This commit adds a small UX improvement to the Repair and Upgrade tools pages, allowing for these lengthy lists to be sorted.
See #3244.
|
| [6924]
|
johnjamesjacoby
|
Docs: add missing project names after recently added @since's.
|
| [6923]
|
johnjamesjacoby
|
Counts (meta-data): full audit of forum/topic/reply, public/non-public counts.
This commit is the result of a full count audit, exposing multiple inconsistencies and voids in relation to how public and non-public counts are (re)calculated.
For instance, hidden forum replies are not counted at all, until now. By introducing a new Repair tool, hidden forum reply counts are now counted.
In addition, there were multiple bugs with topic & reply moderation, where the act of approving or unapproving topics or replies would cause the numbers to be inaccurate, or where topics & replies being caught in moderation were still increasing public counts.
It was also possible to, as a Key Master, publicly reply to unapproved topics, which was a completely unanticipated side-effect of allowing Key Masters to do pretty much anything. Going forward, the default reply status is the topic status, but is still beholden to all existing moderation settings and user role capabilities. This results in a more sane user experience, and prevents the unusual circumstance of there being "0 topics and 30 replies" in public-facing forums.
Certain count increase/decrease actions have been reprioritized to avoid collisions and race conditions, proving once again that ya gotta get up to get down.
See #2838. Fixes #1799.
|
| [6922]
|
johnjamesjacoby
|
Statuses: normalize status related functions across post types.
This commit adds 2 missing functions for forum statuses, and relocates all of them to the correct functions.php files for their post types.
|
| [6921]
|
johnjamesjacoby
|
Moderation: make sure pending topics (for moderation reasons) are accessible to authors.
This commit updates the logic inside of the topic & reply map-meta-cap implementations, restricting edit-lock checks to actual "Edit" screens, and using the "edit_others_posts" capability in non-"Edit" screens, ensuring that both scenarios are covered.
It also adds an explicit condition for Pending Topics to both the Topic Description and Topic Notices, alerting users as to why they are seeing what they are seeing.
Fixes #3253 (again!) See also #3164 for other related discussion & details.
|
| [6920]
|
johnjamesjacoby
|
Edit Locking: Remove redundant $minutes check in `bbp_past_edit_lock()`.
This commit is just a small bit of cleanup from researching #3164.
See #3222.
|
| [6919]
|
johnjamesjacoby
|
Emails: chunk notification emails into 40 Bcc'd recipients.
This commit introduces the `bbp_mail` subfilter, used to target bbPress specific emails in conjunction with `bbp_get_email_header()` to help identify emails that came specifically from bbPress actions.
The purpose of this change is to help forum owners avoid their outbound emails being marked as spam, due to the high number of users that can be subscribed to any given forum or topic.
This change (combined with r6725) goes a long way towards improving the success of subscription emails reaching their intended recipients.
Fixes #3260. Props danielbachhuber.
|
| [6918]
|
johnjamesjacoby
|
Subscriptions: clean up code comparisons and documentation.
This commit adds some inline documentation to provide a bit more clarity around what subnscriptions checks and actions are being taken, and adds parenthesis to nested comparisons to improve code readability.
See #3235.
|
| [6917]
|
johnjamesjacoby
|
Anonymous: delete meta key if value is empty.
This commit ensures that editing a non-anonymous topic via WordPress Admin does not erroneously add empty anonymous author keys to post meta.
|
| [6916]
|
johnjamesjacoby
|
Subscriptions: pass additional IDs into user ID filters.
This commit adds forum, topic, and reply IDs to the filters commonly used to filter the user IDs that emails are being sent to, providing a quick opportunity to peek at them easily and make decisions based on what they are at the time.
Fixes #3249. Props satollo.
|
| [6915]
|
johnjamesjacoby
|
Stickies: make sure unapproved topics are unstuck also.
This commit removes a hard coded call to `bbp_unstick_topic()` and hooks into the neighboring `bbp_stick_topic` action, while also hooking into the `bbp_unapprove_topic` action.
A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code.
Fixes #3246.
|
| [6914]
|
johnjamesjacoby
|
Engagements: always show user avatars in subscription/favorite metaboxes.
This commit introduces a helper function (to reduce code duplication) responsible for looping through queried users and outputting avatars and profile links.
A developers note is included in the function docs discouraging third-party plugin developers from using it, as future iterations of bbPress may modify its output without notice.
Fixes #3272.
|