| [7215]
|
johnjamesjacoby
|
Bump to 2.7.0-alpha-2.
|
| [7214]
|
johnjamesjacoby
|
Users: add some error checking to `get_userdata()` calls in profile link functions.
This change ensures that when attempting to link to user profiles when the `display_name` is the inner HTML of the link, that the "Anonymous" alternate is used whenever the user cannot be found.
It also bails early – returning `false` – if the user account simply does not exist, consistent with upstream calls to `bbp_get_user_id()`. (Functions calling these functions have a responsibility to appropriately handle boolean return values.)
In trunk, for 2.7.
Fixes #3440.
|
| [7213]
|
johnjamesjacoby
|
Users: add some error checking to `get_userdata()` calls in profile link functions.
This change ensures that when attempting to link to user profiles when the `display_name` is the inner HTML of the link, that the "Anonymous" alternate is used whenever the user cannot be found.
It also bails early – returning `false` – if the user account simply does not exist, consistent with upstream calls to `bbp_get_user_id()`. (Functions calling these functions have a responsibility to appropriately handle boolean return values.)
In branches/2.6, for 2.6.7.
See #3440.
|
| [7212]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In trunk, for 2.7.
Fixes #3438.
|
| [7211]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In branches/2.6, for 2.6.7.
See #3438.
|
| [7210]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3417.
|
| [7209]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3417.
|
| [7208]
|
johnjamesjacoby
|
Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In branches/2.6, for 2.6.7.
Fixes #3418.
|
| [7207]
|
johnjamesjacoby
|
Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In trunk, for 2.7.0.
See #3418.
|
| [7206]
|
johnjamesjacoby
|
Akismet: hook clean-up methods from r7204 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In trunk, for 2.7.0.
See #3395.
|
| [7205]
|
johnjamesjacoby
|
Akismet: hook clean-up methods from r7203 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In branches/2.6, for 2.6.7.
See #3395.
|
| [7204]
|
johnjamesjacoby
|
Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3395.
|
| [7203]
|
johnjamesjacoby
|
Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3395.
|
| [7202]
|
johnjamesjacoby
|
Readme: Bump "tested up to" to 5.8.
|
| [7201]
|
johnjamesjacoby
|
Readme: Bump "tested up to" to 5.8.
|
| [7200]
|
johnjamesjacoby
|
Build: bump npm dependencies.
|
| [7199]
|
johnjamesjacoby
|
Build: bump npm dependencies.
|
| [7198]
|
johnjamesjacoby
|
Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In branches/2.6 for 2.6.7. Fixes #2853.
|
| [7197]
|
johnjamesjacoby
|
Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In trunk for 2.7.0. See #2853.
|
| [7196]
|
johnjamesjacoby
|
Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In trunk for 2.7.0. See #3410.
|
| [7195]
|
johnjamesjacoby
|
Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In branches/2.6 for 2.6.7. See #3410.
|
| [7194]
|
johnjamesjacoby
|
Akismet: Remove "publish" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In branches/2.6 for 2.6.7. Fixes #3410.
|
| [7193]
|
johnjamesjacoby
|
Akismet: Remove "publish" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In trunk for 2.7.0. See #3410.
|
| [7192]
|
johnjamesjacoby
|
Post Statuses: Audit forum/topic/reply, new/edit handlers.
This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.
It also adds a capability check to the `bbp_topic_status` condition, so that it is not engaged when the UI was not exposed in the posted form.
Props dd32.
In branches/2.6 for 2.6.7. Fixes #3420.
|
| [7191]
|
johnjamesjacoby
|
Post Statuses: Audit forum/topic/reply, new/edit handlers.
This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.
It also adds a capability check to the `bbp_topic_status` condition, so that it is not engaged when the UI was not exposed in the posted form.
Props dd32.
In trunk for 2.7.0. See #3420.
|
| [7190]
|
johnjamesjacoby
|
Users: Improve UX of form-user-passwords.php template part.
This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.
It also includes the following related improvements:
* Introduce `bbp_doing_script_debug()` and `bbp_doing_autosave()` helpers, and use them where needed
* Introduce `bbp_asset_version()` and `bbp_get_asset_version()` to bust asset cache when debugging
* Update `forum-user-passwords.php` template part to swap out body class and add missing element ID
* Update password form styling in `bbpress.css` default theme compat CSS
In trunk for 2.7.0. Fixes #3421.
|
| [7189]
|
johnjamesjacoby
|
Users: Improve UX of form-user-passwords.php template part.
This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.
It also includes the following related improvements:
* Introduce `bbp_doing_script_debug()` and `bbp_doing_autosave()` helpers, and use them where needed
* Introduce `bbp_asset_version()` and `bbp_get_asset_version()` to bust asset cache when debugging
* Update `forum-user-passwords.php` template part to swap out body class and add missing element ID
* Update password form styling in `bbpress.css` default theme compat CSS
In branches/2.6 for 2.6.7. See #3421.
|
| [7188]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In branches/2.6 for 2.6.7. Fixes #3367.
|
| [7187]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In trunk for 2.7.0. See #3367.
|
| [7186]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In branches/2.6 for 2.6.7. Fixes #3414.
Props dilipbheda, isabel104.
|
| [7185]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In trunk for 2.7.0. See #3414.
Props dilipbheda, isabel104.
|
| [7184]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In branches/2.6 for 2.6.7. Fixes #3341.
Props konnektiv.
|
| [7183]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In trunk for 2.7.0. See #3341.
Props konnektiv.
|
| [7182]
|
johnjamesjacoby
|
Profiles: fix incorrect target for "locale" label.
This commit fixes a copy & paste error, where the "locale" label was targeting the "url" input instead of the language select.
In branches/2.6 for 2.6.7. Fixes #3387.
|
| [7181]
|
johnjamesjacoby
|
Profiles: fix incorrect target for "locale" label.
This commit fixes a copy & paste error, where the "locale" label was targeting the "url" input instead of the language select.
In trunk for 2.7.0. See #3387.
|
| [7180]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In branches/2.6 for 2.6.7. Fixes #3386.
|
| [7179]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In trunk for 2.7.0. See #3386.
|
| [7178]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In branches/2.6 for 2.6.7. See #3366.
Props immeet94.
|
| [7177]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In trunk for 2.7.0. See #3366.
Props immeet94.
|
| [7176]
|
johnjamesjacoby
|
Theme Compatibility: improve handling of shortcodes in some template functions.
This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages.
In branches/2.6 for 2.6.7. Fixes #3358.
|
| [7175]
|
johnjamesjacoby
|
Theme Compatibility: improve handling of shortcodes in some template functions.
This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages.
In trunk for 2.7.0. See #3358.
|
| [7174]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In branches/2.6 for 2.6.7. Fixes #3327.
Props mjonesnerdery.
|
| [7173]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In trunk for 2.7.0. See #3327.
Props mjonesnerdery.
|
| [7172]
|
johnjamesjacoby
|
Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In branches/2.6 for 2.6.7. Fixes #3311.
|
| [7171]
|
johnjamesjacoby
|
Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In trunk for 2.7.0. See #3311.
|
| [7170]
|
johnjamesjacoby
|
Docs: correct "arrap" to "array".
In trunk for 2.7.0. See #3389.
|
| [7169]
|
johnjamesjacoby
|
Docs: correct "arrap" to "array".
In branches/2.6 for 2.6.6. See #3389.
|
| [7168]
|
johnjamesjacoby
|
Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`.
This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes.
In branches/2.6 for 2.6.6. Fixes #3415.
Props lyndseyh.
|
| [7167]
|
johnjamesjacoby
|
Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`.
This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes.
In trunk for 2.7.0. See #3415.
Props lyndseyh.
|
| [7166]
|
johnjamesjacoby
|
Updates: clean-up & normalize topic & reply update functions.
This commit is non-functional, but rearranges some code so that _update_ functions are more predictable and easier to work with in the future.
See #3389.
|
| [7165]
|
johnjamesjacoby
|
Ignore pnpm-lock.yaml in Subversion. See r7164.
|
| [7164]
|
johnjamesjacoby
|
Ignore pnpm-lock.yaml.
pnpm is an optional alternative to npm, allowing for global sharing of dependencies, which is particularly useful for WordPress plugins.
|
| [7163]
|
johnjamesjacoby
|
Bump stable tag to 2.6.6 in trunk.
|
| [7162]
|
johnjamesjacoby
|
Tagging 2.6.6.
|
| [7161]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.6.
|
| [7160]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In trunk, for 2.7. Fixes #3398.
|
| [7159]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In branches/2.6, for 2.6.6. See #3398.
|
| [7158]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In trunk, for 2.7. Fixes #3309.
Props dd32, man4toman.
|
| [7157]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In branches/2.6, for 2.6.6. See #3309.
Props dd32, man4toman.
|
| [7156]
|
johnjamesjacoby
|
Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In trunk, for 2.7. Fixes #3400.
Props cfinke.
|
| [7155]
|
johnjamesjacoby
|
Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In branches/2.6, for 2.6.6. See #3400.
Props cfinke.
|
| [7154]
|
johnjamesjacoby
|
Topics: fix not being able to unsticky in certain circumstances.
This commit adds a `bbp_unstick_topic()` call inside of `bbp_update_topic()` where it has been missing since forever.
In trunk, for 2.7. Fixes #3396.
|
| [7153]
|
johnjamesjacoby
|
Topics: fix not being able to unsticky in certain circumstances.
This commit adds a `bbp_unstick_topic()` call inside of `bbp_update_topic()` where it has been missing since forever.
In branches/2.6, for 2.6.6. See #3396.
|
| [7152]
|
johnjamesjacoby
|
Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`.
This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges.
In trunk, for 2.7. Fixes #3405.
Props muratgu.
|
| [7151]
|
johnjamesjacoby
|
Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`.
This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges.
In branches/2.6, for 2.6.6. Fixes #3405.
Props muratgu.
|
| [7150]
|
johnjamesjacoby
|
Meta: always query meta_value by string, not by integer.
This commit swaps "%d" for "%s" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In trunk, for 2.7. Fixes #3408.
|
| [7149]
|
johnjamesjacoby
|
Meta: always query meta_value by string, not by integer.
This commit swaps "%d" for "%s" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In branches/2.6, for 2.6.6. See #3408.
|
| [7148]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In trunk, for 2.7. Fixes #3385.
|
| [7147]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In branches/2.6, for 2.6.6. See #3385.
|
| [7146]
|
johnjamesjacoby
|
Users: update HTML class of user-profile.php template part.
This commit fixes a duplicated class in the user profile output, from `bbp-user-topic-count` to `bbp-user-last-activity`.
In trunk, for 2.7. Fixes #3394.
Props netweb.
|
| [7145]
|
johnjamesjacoby
|
Users: update HTML class of user-profile.php template part.
This commit fixes a duplicated class in the user profile output, from `bbp-user-topic-count` to `bbp-user-last-activity`.
In branches/2.6, for 2.6.6. See #3394.
Props netweb.
|
| [7144]
|
johnjamesjacoby
|
Users: avoid PHP notice (warning in PHP8) when getting a user nicename.
This commit improves the internal logic of `bbp_get_user_nicename()` to handle a missing or invalid user object, defaulting to an empty string in that specific instance.
In trunk, for 2.7. Fixes #3402.
Props dd32.
|
| [7143]
|
johnjamesjacoby
|
Users: avoid PHP notice (warning in PHP8) when getting a user nicename.
This commit improves the internal logic of `bbp_get_user_nicename()` to handle a missing or invalid user object, defaulting to an empty string in that specific instance.
In branches/2.6, for 2.6.6. See #3402.
Props dd32.
|
| [7142]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In trunk, for 2.7. Fixes #3409.
|
| [7141]
|
johnjamesjacoby
|
Replies: remove unintended duplicate array_filter() call from r7140.
|
| [7140]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In branches/2.6, for 2.6.6. See #3409.
|
| [7139]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In branches/2.6, for 2.6.6. See #3379.
|
| [7138]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In trunk, for 2.7. See #3379.
|
| [7137]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In trunk, for 2.7.
|
| [7136]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In branches/2.6, for 2.6.6.
|
| [7135]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In branches/2.6, for 2.6.6.
See #3310.
|
| [7134]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In trunk, for 2.7.
See #3310.
|
| [7133]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7132]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7131]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In branches/2.6, for 2.6.6.
See #3385.
|
| [7130]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In trunk, for 2.7.
See #3385.
|
| [7129]
|
johnjamesjacoby
|
Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In trunk, for 2.7.
Props procifer.
See #3368.
|
| [7128]
|
johnjamesjacoby
|
Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In branches/2.6, for 2.6.6.
Props procifer.
See #3368.
|
| [7127]
|
johnjamesjacoby
|
Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In branches/2.6, for 2.6.6.
Props Otto42.
See #2853.
|
| [7126]
|
johnjamesjacoby
|
Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In trunk, for 2.7.
Props Otto42.
See #2853.
|
| [7125]
|
johnjamesjacoby
|
Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In trunk, for 2.7.
See #3384.
|
| [7124]
|
johnjamesjacoby
|
Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In branches/2.6, for 2.6.6.
See #3384.
|
| [7123]
|
johnjamesjacoby
|
Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In branches/2.6, for 2.6.6.
Props SergeyBiryukov.
See #3133.
|
| [7122]
|
johnjamesjacoby
|
Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In trunk, for 2.7.
Props SergeyBiryukov.
See #3133.
|
| [7121]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In trunk, for 2.7.
Props peterkueger.
Fixes #3390.
|
| [7120]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In branches/2.6, for 2.6.6.
Props peterkueger.
|
| [7109]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In branches/2.6, for 2.6.6.
Fixes #3213.
|
| [7108]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In trunk, for 2.7.0.
Fixes #3378.
|
| [7105]
|
johnjamesjacoby
|
Users: Correctly calculate offset in User Profile > Last Activity.
Previous to this, Last Activity was being saved with `time()` but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.
Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.
In trunk, for 2.7.0.
Fixes #3378.
|
| [7104]
|
johnjamesjacoby
|
Users: Correctly calculate offset in User Profile > Last Activity.
Previous to this, Last Activity was being saved with `time()` but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.
Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.
In branches/2.6, for 2.6.6.
See #3378.
|