| [7263]
|
johnjamesjacoby
|
Tools/Repair: audit post statuses in repair queries.
This change ensures that all of the relevant repair tools are including the expected public post statuses for their related post types.
These changes specifically address possibly missing Closed Topics in the repair tools, while also ensuring that anything filtering the results of the `_public_statuses()` functions to add their own custom statuses (I.E. archives on WordPress.org) are taken into consideration.
Fixes #3591.
Props GDragoN.
In branches/2.6, for 2.6.10.
|
| [7262]
|
johnjamesjacoby
|
Search: prevent hidden forums from appearing in results.
This change includes the following changes:
* Removes `readable` perm check from `bbp_has_search_results()` and replaces it with public topic statuses by default, while conditionally adding private & hidden statuses if user is capable
* Tweaks the logic inside of `bbp_pre_get_posts_normalize_forum_visibility()` to always handle both of its internal conditions (forum query, or any query that includes forums/topics/replies connected via meta data)
* Tweaks output of `content-search.php` template part to not show the "Oh bother" error when visiting a search page for the first time
* Adds a string `feedback-no-search.php` template part to address both "no results" and "no terms" conditions
These changes address some faulty search logic that was allowing hidden forums to appear in global search results to users who should not have been able to see them, while also improving the search page experience itself.
Fixes #3473.
Props wpsolr, robin-w.
In branches/2.6, for 2.6.10.
|
| [7261]
|
johnjamesjacoby
|
Admin: prevent broken list-table layouts.
This change adds CSS that targets forum/topic/reply list-table heads & foots.
It allows text – that is both unbreakable & wider than its parent th/td – to truncate with an ellipsis.
This is necessary because the default behavior is to continue to squish text down to an unreadable state, which happens frequently here due to the number of columns in the tables and the amount of content available inside of them to Keymasters & Moderators.
In branches/2.6, for 2.6.10.
|
| [7260]
|
johnjamesjacoby
|
Templates: correct escaping on allowed HTML Tags form template parts.
This change introduces a new template-part file: `form-allowed-tags.php` and uses it inside of the Forum, Topic, and Reply form template-parts.
Additionally, the output is now properly escaped, which prevents unintentional escaping of the `<attr>` tag inside of the string.
Fixes #3492.
Props naxoc.
In branches/2.6, for 2.6.10.
|
| [7259]
|
johnjamesjacoby
|
Templates: remove duplicate div from `content-archive-topic.php`.
This change removes an unnecessary `bbp_allow_search()` call – as well as an extra `div.bbp-search-form` – from the Topic Archive template part.
Fixes #3486.
Props naxoc, arafatjamil01.
In branches/2.6, for 2.6.10.
|
| [7258]
|
johnjamesjacoby
|
Admin: add some inputs to too-wide kludge CSS.
This change ensures that various admin-area meta-box inputs render next to their labels instead of below them.
In branches/2.6, for 2.6.10.
|
| [7257]
|
johnjamesjacoby
|
Roles: prevent notices when calling `bbp_add_forums_roles()`
This change adds sanity checks around the `$wp_roles` parameter of the `bbp_add_forums_roles()` function.
It will now attempt to initialize the `WP_Roles` class just-in-time, but only if not already doing the `wp_roles_init` action (to prevent recursion).
If after all of that `$wp_roles` is still not what it needs to be, this function will now silently bail instead of proceeding (to prevent debug notices & errors).
Fixes #3493.
Props naxoc.
In branches/2.6, for 2.6.10.
|
| [7256]
|
johnjamesjacoby
|
Converter: remove `__destruct()` registration
This change removes the need for `wpdb` extensions (like in the Converter) to register their own shutdown methods.
This is necessary because the `__destruct()` method was removed in the parent `wpdb` class, so attempting to add it in the subclass will generate PHP errors.
See #WP21402.
Fixes #3508.
Props GDragoN, dd32.
In branches/2.6, for 2.6.10.
|
| [7255]
|
johnjamesjacoby
|
Topic/Reply: improvements to status updates.
This change includes 2 fixes:
* Prefer `$topic_id` over `$topic->ID`, and use it (instead of `$forum_id`) when checking for moderation capability
* Add missing logic in `bbp_edit_reply_handler()` that was preventing statuses from saving as intended
See #2644.
In branches/2.6, for 2.6.10.
|
| [7254]
|
johnjamesjacoby
|
PHPCS: correct return var types in Revisions functions
This change fixes PHPCS/Intelephense warnings.
In branches/2.6, for 2.6.10.
|
| [7253]
|
johnjamesjacoby
|
PHP8: define dependency injected components in BBP_Admin
This change prevents debug warnings in modern versions of PHP (8.0 and higher).
In branches/2.6, for 2.6.10.
|
| [7252]
|
johnjamesjacoby
|
Akismet: add class definition for $last_post.
This change improves compatibility with newer PHP versions (8.0 and above) that prefer for all class variables to be predefined.
In branches/2.6, for 2.6.10.
|
| [7251]
|
johnjamesjacoby
|
Common Functions: fix dashboard errors from undefined variables.
Introduced in r7237, in `bbp_get_statistics()`.
This corrects an unintended regression that was causing replies not to be counted correctly.
In branches/2.6, for 2.6.10.
|
| [7250]
|
johnjamesjacoby
|
Subscriptions: use topic title in Subject, instead of site name.
This change adds helpful context to email subjects and eliminates duplication between From & Subject mail headers.
Props dd32.
In branches/2.6, for 2.6.10.
Fixes #3446.
|
| [7249]
|
johnjamesjacoby
|
Subscriptions: use topic title in Subject, instead of site name.
This change adds helpful context to email subjects and eliminates duplication between From & Subject mail headers.
Props dd32.
In trunk, for 2.7.0.
Fixes #3446.
|
| [7248]
|
johnjamesjacoby
|
URLs: fix incorrect links for certain topic statuses.
This change prefers `bbp_is_topic_public()` over `! bbp_is_topic_pending()` to determine whether or not certain reply & topic URLs should be "pretty".
Props dd32.
In trunk, for 2.7.0.
Fixes #3424.
|
| [7247]
|
johnjamesjacoby
|
URLs: fix incorrect links for certain topic statuses.
This change prefers `bbp_is_topic_public()` over `! bbp_is_topic_pending()` to determine whether or not certain reply & topic URLs should be "pretty".
Props dd32.
In branches/2.6, for 2.6.10.
Fixes #3424.
|
| [7246]
|
johnjamesjacoby
|
Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In branches/2.6, for 2.6.10.
See #3419.
|
| [7245]
|
johnjamesjacoby
|
Converter: improvements to `bbp_user_maybe_convert_pass()`:
* Unslash 'log' posted value
* Trim 'pwd' posted value
* Bail early if either are empty
* Use `get_user_by()` and `get_user_meta()` instead of direct MySQL query
* Bail if user/meta are not found
* Bail if converter not string or not found
This change ensures that users who sign in via either their username or email are converted. Before this change, signing in via email would not trigger a conversion.
In trunk, for 2.7.0.
See #3419.
|
| [7244]
|
johnjamesjacoby
|
Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In trunk, for 2.7.0.
Props sirlouen. Fixes #3419.
|
| [7243]
|
johnjamesjacoby
|
Converter: remove `_bbp_class` key on successful authentication.
This change cleans up the usermeta key that is used to determine if the relative user has a password from a converted platform that still needs to be rehashed.
Cleaning this up fixes a bug that would cause recurrent conversions from some platforms.
In branches/2.6, for 2.6.10.
Props sirlouen. Fixes #3419.
|
| [7242]
|
johnjamesjacoby
|
Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In branches/2.6, for 2.6.10.
Props mdjwel via GitHub pull request.
|
| [7241]
|
johnjamesjacoby
|
Replies: use correct wrapper element in `bbp_list_replies()`.
This change ensures that the proper `div/ol/ul` wrapper is applied (via the `style` parameter argument) to the walked replies hierarchy, and avoids the potential for generating invalid HTML mark-up.
In trunk, for 2.7.0.
Props mdjwel via GitHub pull request.
|
| [7240]
|
johnjamesjacoby
|
Docs: remove some PHP docs that don't make sense.
For 2.7.
|
| [7239]
|
johnjamesjacoby
|
Docs: remove some PHP docs that don't make sense.
For 2.7.
|
| [7238]
|
johnjamesjacoby
|
Docs: remove some PHP docs that don't make sense.
For 2.6.10.
|
| [7237]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In branches/2.6 for 2.6.10. Fixes #3428.
|
| [7236]
|
johnjamesjacoby
|
Statistics: numerous code improvements:
* Prevent PHP warnings/notices when passing specific arguments and when viewed as a user with specific capabilities
* Rename "trashed" & "spammed" keys to "trash" & "spam" respectively, to better match their status IDs
* Refactor `bbp_get_statistics()` to be simpler internally – includes fully updated docs
* Add unofficial support for "hidden" topic & reply statuses in statistics
* Add `bbp-stats` class to default template part to make it easier to target with custom styling
These changes together vastly improve the experience of using the `bbp-stats` shortcode.
Props createquest, hasanuzzamanshamim, robin-w.
In trunk for 2.7.0. Fixes #3428.
|
| [7235]
|
johnjamesjacoby
|
Moderation: use the correct `post_status` when untrashing a topic/reply.
This change fixes a bug/regression (since WordPress 5.6.0) that was causing untrashed topics & replies to use an unintended `post_status` value.
It fixes it by adding a new function ('bbp_fix_untrash_post_status()') and hooking it to the `wp_untrash_post_status` filter in WordPress, and overriding the results as needed.
Props r-a-y.
In trunk for 2.7.0. Fixes #3433.
|
| [7234]
|
johnjamesjacoby
|
Moderation: use the correct `post_status` when untrashing a topic/reply.
This change fixes a bug/regression (since WordPress 5.6.0) that was causing untrashed topics & replies to use an unintended `post_status` value.
It fixes it by adding a new function ('bbp_fix_untrash_post_status()') and hooking it to the `wp_untrash_post_status` filter in WordPress, and overriding the results as needed.
Props r-a-y.
In branches/2.6 for 2.6.10. Fixes #3433.
|
| [7233]
|
johnjamesjacoby
|
Headers: update plugin headers, in branches/2.6 for 2.6.10.
|
| [7232]
|
johnjamesjacoby
|
Headers: update plugin headers, in trunk for 2.7.0.
|
| [7231]
|
johnjamesjacoby
|
Theme Compat: improve "no-js" body class swapping.
This change introduces a new helper function (`bbp_swap_no_js_body_class()`) which is used to output the `<script>` tag that was previously inside of the single template part that needed it.
It also adds a prefix (`bbp`) to those "no-js" body classes, with the intention of avoiding conflicts with other plugins & themes that may also be using the `no-js` body class for their own purposes.
Props dd32, r-a-y.
In trunk for 2.7.0. Fixes #3445.
|
| [7230]
|
johnjamesjacoby
|
Theme Compat: improve "no-js" body class swapping.
This change introduces a new helper function (`bbp_swap_no_js_body_class()`) which is used to output the `<script>` tag that was previously inside of the single template part that needed it.
It also adds a prefix (`bbp`) to those "no-js" body classes, with the intention of avoiding conflicts with other plugins & themes that may also be using the `no-js` body class for their own purposes.
Props dd32, r-a-y.
In branches/2.6 for 2.6.10. Fixes #3445.
|
| [7229]
|
johnjamesjacoby
|
Tag 2.6.9.
|
| [7228]
|
johnjamesjacoby
|
Bump versions to 2.6.9.
|
| [7227]
|
johnjamesjacoby
|
Akismet: improvements to clean-up routines, based on user feedback.
* Use correct `ID` column for the `posts` database table
* Use correct `post_id` column for the `postmeta` database table
* Reduce row limit to `1000` from `100000` to avoid lengthy table locks in active forums
* Remove usage of constant, that may be phased out eventually
* Update related code docs
* Introduce helper methods for applying dynamically named filters
In branches/2.6 for 2.6.9. Fixes #3395.
|
| [7226]
|
johnjamesjacoby
|
Akismet: improvements to clean-up routines, based on user feedback.
* Use correct `ID` column for the `posts` database table
* Use correct `post_id` column for the `postmeta` database table
* Reduce row limit to `1000` from `100000` to avoid lengthy table locks in active forums
* Remove usage of constant, that may be phased out eventually
* Update related code docs
* Introduce helper methods for applying dynamically named filters
In trunk for 2.7. See #3395.
|
| [7225]
|
johnjamesjacoby
|
Bump build packages.
|
| [7224]
|
johnjamesjacoby
|
Bump stable tag to 2.6.8.
|
| [7223]
|
johnjamesjacoby
|
Tag 2.6.8.
|
| [7222]
|
johnjamesjacoby
|
Bump branches/2.6 to 2.6.8.
|
| [7221]
|
johnjamesjacoby
|
Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In branches/2.6 for 2.6.8. Fixes #3443.
|
| [7220]
|
johnjamesjacoby
|
Appearance: only add `no-js` body class on bbPress pages.
This change addresses a regression introduced in r7190, causing the `bbpress` body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.
This commit makes sure that the `bbpress` body class is only added when intended, and moves the `no-js` body class into the same conditional check.
In trunk for 2.7. See #3443.
|
| [7219]
|
johnjamesjacoby
|
Readme: Bump stable tag, and add missing header meta.
(Also updates build tool dependencies.)
|
| [7218]
|
johnjamesjacoby
|
Tag 2.6.7.
|
| [7217]
|
johnjamesjacoby
|
Bump to 2.6.7.
(Reorders to package.json to be a bit easier for humans to modify.)
|
| [7216]
|
johnjamesjacoby
|
Tools: bring .gitignore up to speed.
This change merges similar ignore patterns from BuddyPress and WordPress.
|
| [7215]
|
johnjamesjacoby
|
Bump to 2.7.0-alpha-2.
|
| [7214]
|
johnjamesjacoby
|
Users: add some error checking to `get_userdata()` calls in profile link functions.
This change ensures that when attempting to link to user profiles when the `display_name` is the inner HTML of the link, that the "Anonymous" alternate is used whenever the user cannot be found.
It also bails early – returning `false` – if the user account simply does not exist, consistent with upstream calls to `bbp_get_user_id()`. (Functions calling these functions have a responsibility to appropriately handle boolean return values.)
In trunk, for 2.7.
Fixes #3440.
|
| [7213]
|
johnjamesjacoby
|
Users: add some error checking to `get_userdata()` calls in profile link functions.
This change ensures that when attempting to link to user profiles when the `display_name` is the inner HTML of the link, that the "Anonymous" alternate is used whenever the user cannot be found.
It also bails early – returning `false` – if the user account simply does not exist, consistent with upstream calls to `bbp_get_user_id()`. (Functions calling these functions have a responsibility to appropriately handle boolean return values.)
In branches/2.6, for 2.6.7.
See #3440.
|
| [7212]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In trunk, for 2.7.
Fixes #3438.
|
| [7211]
|
johnjamesjacoby
|
Topic Views: do not sanitize `$view` parameter of `bbp_get_view_id()`.
(Removes the call to `sanitize_key()` inside of `bbp_get_view_id()`.)
This change ensures that when checking for a registered view, the literal value is used for comparisons and not the sanitized version of it. This matches the behavior of other `_get_*_id()` functions, and also fixes a bug causing these invalid view IDs not to 404 as intended.
Props johnjamesjacoby, dd32.
In branches/2.6, for 2.6.7.
See #3438.
|
| [7210]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3417.
|
| [7209]
|
johnjamesjacoby
|
BuddyPress Groups: sync forum Title, Description, and Slug to Group.
This change ensures that when editing an existing group with a forum, its stays up-to-date with its parent group.
Props johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3417.
|
| [7208]
|
johnjamesjacoby
|
Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In branches/2.6, for 2.6.7.
Fixes #3418.
|
| [7207]
|
johnjamesjacoby
|
Content: add `post_parent` to forum & topic duplicate checks.
This change limits the scope of "duplicate content" to its parent context, meaning that replies must be to the same topic, topics must be in the same forum, and forums must be in the same sub-forum (or root) to be considered a duplicate.
This better implements the spirit of this feature which is to prevent accidental/unintended duplicates, and is not intended to simply prevent globally similar content by the same author.
Props r-a-y, johnjamesjacoby.
In trunk, for 2.7.0.
See #3418.
|
| [7206]
|
johnjamesjacoby
|
Akismet: hook clean-up methods from r7204 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In trunk, for 2.7.0.
See #3395.
|
| [7205]
|
johnjamesjacoby
|
Akismet: hook clean-up methods from r7203 into WP Cron.
This change takes stephdau's advice and schedules a daily cron on the `akismet_scheduled_delete` event (but only when actually adding to the Akismet post histories, to try to narrow the scope slightly).
In branches/2.6, for 2.6.7.
See #3395.
|
| [7204]
|
johnjamesjacoby
|
Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In trunk, for 2.7.0.
Fixes #3395.
|
| [7203]
|
johnjamesjacoby
|
Akismet: introduce a few clean-up action hook methods.
* `delete_old_spam()` - deletes old spam topics & replies from the queue after 15 days.
* `delete_old_spam_meta()` - deletes `_bbp_akismet_as_submitted` entries after 15 days.
* `delete_orphaned_spam_meta()` - deletes post meta that no longer have corresponding posts in the database.
Props stephdau, johnjamesjacoby.
In branches/2.6, for 2.6.7.
See #3395.
|
| [7202]
|
johnjamesjacoby
|
Readme: Bump "tested up to" to 5.8.
|
| [7201]
|
johnjamesjacoby
|
Readme: Bump "tested up to" to 5.8.
|
| [7200]
|
johnjamesjacoby
|
Build: bump npm dependencies.
|
| [7199]
|
johnjamesjacoby
|
Build: bump npm dependencies.
|
| [7198]
|
johnjamesjacoby
|
Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In branches/2.6 for 2.6.7. Fixes #2853.
|
| [7197]
|
johnjamesjacoby
|
Akismet: trust `x-akismet-pro-tip` response header.
This commit discards forums, topics, and replies that Akismet is 100% sure are spammy.
The redirection experience is intentionally nondescript at this time.
In trunk for 2.7.0. See #2853.
|
| [7196]
|
johnjamesjacoby
|
Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In trunk for 2.7.0. See #3410.
|
| [7195]
|
johnjamesjacoby
|
Akismet: port SSL support from Akismet plugin.
This commit ensures that installations using SSL will send remote requests to `https://` instead of `http://` including retries and graceful degradation to `http://` if necessary.
It also cleans up some related header & response logic to make it easier to understand.
In branches/2.6 for 2.6.7. See #3410.
|
| [7194]
|
johnjamesjacoby
|
Akismet: Remove "publish" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In branches/2.6 for 2.6.7. Fixes #3410.
|
| [7193]
|
johnjamesjacoby
|
Akismet: Remove "publish" status restriction in check_post().
This commit ensures that posts of any status are sent to Akismet, even if they had previously been published and are now being edited. The intent of this change is to remove a restriction without changing the behavior from a user's perspective.
Also fixes a typo and an incorrectly typed return value.
Props procifer, douglsmith.
In trunk for 2.7.0. See #3410.
|
| [7192]
|
johnjamesjacoby
|
Post Statuses: Audit forum/topic/reply, new/edit handlers.
This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.
It also adds a capability check to the `bbp_topic_status` condition, so that it is not engaged when the UI was not exposed in the posted form.
Props dd32.
In branches/2.6 for 2.6.7. Fixes #3420.
|
| [7191]
|
johnjamesjacoby
|
Post Statuses: Audit forum/topic/reply, new/edit handlers.
This change normalizes the approaches between post types and actions, to ensure predictable behavior and avoid PHP notices from undefined status variables in certain situations.
It also adds a capability check to the `bbp_topic_status` condition, so that it is not engaged when the UI was not exposed in the posted form.
Props dd32.
In trunk for 2.7.0. See #3420.
|
| [7190]
|
johnjamesjacoby
|
Users: Improve UX of form-user-passwords.php template part.
This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.
It also includes the following related improvements:
* Introduce `bbp_doing_script_debug()` and `bbp_doing_autosave()` helpers, and use them where needed
* Introduce `bbp_asset_version()` and `bbp_get_asset_version()` to bust asset cache when debugging
* Update `forum-user-passwords.php` template part to swap out body class and add missing element ID
* Update password form styling in `bbpress.css` default theme compat CSS
In trunk for 2.7.0. Fixes #3421.
|
| [7189]
|
johnjamesjacoby
|
Users: Improve UX of form-user-passwords.php template part.
This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.
It also includes the following related improvements:
* Introduce `bbp_doing_script_debug()` and `bbp_doing_autosave()` helpers, and use them where needed
* Introduce `bbp_asset_version()` and `bbp_get_asset_version()` to bust asset cache when debugging
* Update `forum-user-passwords.php` template part to swap out body class and add missing element ID
* Update password form styling in `bbpress.css` default theme compat CSS
In branches/2.6 for 2.6.7. See #3421.
|
| [7188]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In branches/2.6 for 2.6.7. Fixes #3367.
|
| [7187]
|
johnjamesjacoby
|
BuddyPress: prevent possible duplicate "Topics" & "Replies" activity filters.
This commit removes legacy shims (for filters like `bp_activity_filter_options`) and instead trusts that `bp_activity_set_action()` will be obeyed when outputting filter select HTML elements. These shims were necessary in older versions of BuddyPress and no longer are.
In trunk for 2.7.0. See #3367.
|
| [7186]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In branches/2.6 for 2.6.7. Fixes #3414.
Props dilipbheda, isabel104.
|
| [7185]
|
johnjamesjacoby
|
Notices: correct string type checking of "loggedout" $_GET parameter.
This commit stops checking for a boolean and starts checking for a string, allowing for the "You are now logged out." notice to correctly appear as intended.
In trunk for 2.7.0. See #3414.
Props dilipbheda, isabel104.
|
| [7184]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In branches/2.6 for 2.6.7. Fixes #3341.
Props konnektiv.
|
| [7183]
|
johnjamesjacoby
|
BuddyPress: add topic ID to `bbp_new_reply` notification type.
This commit adds more context to otherwise vague topic reply notifications, and also more accurately marks notifications as read when clicking on the adminbar menu to view them.
In trunk for 2.7.0. See #3341.
Props konnektiv.
|
| [7182]
|
johnjamesjacoby
|
Profiles: fix incorrect target for "locale" label.
This commit fixes a copy & paste error, where the "locale" label was targeting the "url" input instead of the language select.
In branches/2.6 for 2.6.7. Fixes #3387.
|
| [7181]
|
johnjamesjacoby
|
Profiles: fix incorrect target for "locale" label.
This commit fixes a copy & paste error, where the "locale" label was targeting the "url" input instead of the language select.
In trunk for 2.7.0. See #3387.
|
| [7180]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In branches/2.6 for 2.6.7. Fixes #3386.
|
| [7179]
|
johnjamesjacoby
|
Replies: allow zero value `bbp_get_form_option()`.
This commit specifically re-allows for infinite editing of topics and replies to work as intended. Previous to this, it was impossible to retrieve a "0" value, even though the setting description claims that it is possible and it would be saved correctly in the database.
In trunk for 2.7.0. See #3386.
|
| [7178]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In branches/2.6 for 2.6.7. See #3366.
Props immeet94.
|
| [7177]
|
johnjamesjacoby
|
Replies: add missing period at the end of error string in `bbp_move_reply_handler()`.
In trunk for 2.7.0. See #3366.
Props immeet94.
|
| [7176]
|
johnjamesjacoby
|
Theme Compatibility: improve handling of shortcodes in some template functions.
This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages.
In branches/2.6 for 2.6.7. Fixes #3358.
|
| [7175]
|
johnjamesjacoby
|
Theme Compatibility: improve handling of shortcodes in some template functions.
This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages.
In trunk for 2.7.0. See #3358.
|
| [7174]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In branches/2.6 for 2.6.7. Fixes #3327.
Props mjonesnerdery.
|
| [7173]
|
johnjamesjacoby
|
Replies: fix hierarchical replies not scrolling to the new form location when admin toolbar is hidden.
This commit checks that the `adminbar` variable is not empty before also making sure that it is not `undefined`, as it's possible for it to also simply be null when the toolbar is hidden.
In trunk for 2.7.0. See #3327.
Props mjonesnerdery.
|
| [7172]
|
johnjamesjacoby
|
Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In branches/2.6 for 2.6.7. Fixes #3311.
|
| [7171]
|
johnjamesjacoby
|
Administration: allow post types to support `custom-fields`.
This commit fixes a regression in 2.6.x by removing the `#the-list` identifier from the Replies list-table inside of Topic Edit meta-box (phew!) which was causing a duplicate ID collision with the Custom Fields list-table, resulting in the JavaScript for managing them to no longer function.
It subsequently removes all references to `#the-list` in CSS to completely avoid using this ID for anything, and uses `tbody` instead for the same effect but with reduced priority (which is a good thing here).
In trunk for 2.7.0. See #3311.
|
| [7170]
|
johnjamesjacoby
|
Docs: correct "arrap" to "array".
In trunk for 2.7.0. See #3389.
|
| [7169]
|
johnjamesjacoby
|
Docs: correct "arrap" to "array".
In branches/2.6 for 2.6.6. See #3389.
|
| [7168]
|
johnjamesjacoby
|
Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`.
This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes.
In branches/2.6 for 2.6.6. Fixes #3415.
Props lyndseyh.
|
| [7167]
|
johnjamesjacoby
|
Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`.
This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes.
In trunk for 2.7.0. See #3415.
Props lyndseyh.
|
| [7166]
|
johnjamesjacoby
|
Updates: clean-up & normalize topic & reply update functions.
This commit is non-functional, but rearranges some code so that _update_ functions are more predictable and easier to work with in the future.
See #3389.
|
| [7165]
|
johnjamesjacoby
|
Ignore pnpm-lock.yaml in Subversion. See r7164.
|
| [7164]
|
johnjamesjacoby
|
Ignore pnpm-lock.yaml.
pnpm is an optional alternative to npm, allowing for global sharing of dependencies, which is particularly useful for WordPress plugins.
|