| [4867]
|
johnjamesjacoby
|
Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (2.3 branch)
|
| [4866]
|
johnjamesjacoby
|
Audit procedure for posting pre-formatted code in topics and replies:
* Invert code-trick & code-trick-reverse filters to happen pre-save and on output.
* Use esc_html() filter rather than esc_textarea() for textarea output when editing content, to prevent double escaping after above code-trick-reversal.
* Introduce bbp_rel_nofollow() and callback, to handle this on output rather than input, to prevent mucking up preformatted code, and replace wp_rel_nofollow() usages with this.
* Disable visual-editor by default. It's causing code formatting issues when switching between editor types (enable at your own risk in a plugin for now.)
* Fixes #1967 (trunk)
|
| [4865]
|
johnjamesjacoby
|
Use correct filter names in bbp_is_user_deleted() and bbp_is_user_spammer(). Props alex-ye. Antiprops johnjamesjacoby. (2.3 branch)
|
| [4864]
|
johnjamesjacoby
|
Use correct filter names in bbp_is_user_deleted() and bbp_is_user_spammer(). Props alex-ye. Antiprops johnjamesjacoby. (trunk)
|
| [4863]
|
johnjamesjacoby
|
Use correct cache group in bbp_clean_post_cache(). Props wpdennis. Fixes #2312 (trunk)
|
| [4862]
|
johnjamesjacoby
|
Use correct cache group in bbp_clean_post_cache(). Props wpdennis. Fixes #2312 (2.3 branch)
|
| [4861]
|
johnjamesjacoby
|
Add ethitter to credits screen. (2.3 branch)
|
| [4860]
|
johnjamesjacoby
|
Make sure moderators have the 'view_trash' capability. Fixes bug where moderators would hit a 404 after trashing a topic. Fixes #2307 (2.3 branch)
|
| [4859]
|
johnjamesjacoby
|
Make sure moderators have the 'view_trash' capability. Fixes bug where moderators would hit a 404 after trashing a topic. Fixes #2307 (trunk)
|
| [4858]
|
johnjamesjacoby
|
Improve CSS for pre/code blocks, to allow code to scroll horizontally within a pre tag; includes minification. (trunk)
|
| [4857]
|
johnjamesjacoby
|
Minify default CSS files (2.3 branch)
|
| [4856]
|
johnjamesjacoby
|
Improve CSS for pre/code blocks, to allow code to scroll horizontally within a pre tag.
|
| [4855]
|
johnjamesjacoby
|
Bump 2.3 branch version to 2.3.1-bleeding.
|
| [4854]
|
johnjamesjacoby
|
Update admin credits section (2.3 branch)
|
| [4853]
|
johnjamesjacoby
|
Update admin credits section (trunk)
|
| [4852]
|
johnjamesjacoby
|
Bump trunk to 2.4-bleeding.
|
| [4851]
|
johnjamesjacoby
|
Tag 2.3.
|
| [4850]
|
johnjamesjacoby
|
Create 2.3 branch.
|
| [4849]
|
johnjamesjacoby
|
Bump trunk to 2.3.
|
| [4848]
|
johnjamesjacoby
|
Remove the global cache group, and update existing cache group keys to be more descriptive. Fixes issues with cached queries stomping each other on multisite installations. Fixes #2294.
|
| [4847]
|
johnjamesjacoby
|
In bbp_check_for_duplicate(), run wp_unslash() or stripslashes_deep() on the entire $r array. Remove unslashing on results of get_meta_sql() to allow any previously slashed values to remain slashed. See #2185.
|
| [4846]
|
johnjamesjacoby
|
Do a reverse unslashing juke-move when checking topics and replies for duplicates. Even though wp_magic_quotes() may have slashed some things for us, this allows us to properly prepare the query and it's parts with accurately unslashed data. This is mostly to compensate for plugins that may intercept globals or filter query parameters on the fly (like BuddyPress @ mentions.)
See #2185, [WP23973]
|
| [4845]
|
johnjamesjacoby
|
Fix bug in bbp_get_topic_excerpt() that was causing it to always fail. Reverse the parameters of get_post_field() to be in the correct order. See #2300.
|
| [4844]
|
johnjamesjacoby
|
Fix bug in bbp_get_reply_excerpt() that was causing it to always fail. Reverse the parameters of get_post_field() to be in the correct order. Props paulgibbs. Fixes #2300.
|
| [4843]
|
johnjamesjacoby
|
Don't allow replies to closed topics, unless user can moderate. Props mzaweb. Fixes #2281.
|
| [4842]
|
johnjamesjacoby
|
Do not show topic tags in navigation menus.
|
| [4841]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [4840]
|
johnjamesjacoby
|
Update some usages of bbp_get_user_id() to fallback to displayed user, if available. Props alex-ye. Fixes #2285.
|
| [4839]
|
johnjamesjacoby
|
Use feed_content_type() in feeds. See #2292.
|
| [4838]
|
johnjamesjacoby
|
Update bbp_request_feed_trap() to accept more query variables; fixes issues with non-pretty permalinks. Props alex-ye. Fixes #2296.
|
| [4837]
|
johnjamesjacoby
|
Remove 'bbp_filter_kses' filter instead of 'wp_filter_kses' - Fixes unfiltered HTML issues introduced with bbp_filter_kses(). Props alex-ye. Fixes #2290.
|
| [4836]
|
johnjamesjacoby
|
phpdoc normalizing and speeling corrections. Props djpaul, netweb. Fixes #2286, #2288.
|
| [4835]
|
johnjamesjacoby
|
Add BBP_Admin::show_separator variable, rather than doing repeated capability checks. Block access to admin areas for users without moderator capability. Until now, only the UI was hidden, but the URL was still accessible unless a third party plugin was used.
|
| [4834]
|
johnjamesjacoby
|
Fix bug in bbp_get_single_topic_description() causing some conditions to never be executed. Use bbp_get_topic_last_reply_id() instead of bbp_get_topic_last_active_id() since the $topic_id is used as the last active ID if no replies exist. Fixes #2289.
|
| [4833]
|
johnjamesjacoby
|
Replace body class 'bbPress' with 'bbpress' -- CSS classes are case insensitive, but we should stick to common conventions to avoid confusion. Props ethitter/boonebgorges.
|
| [4832]
|
johnjamesjacoby
|
Do not prepare() query in bbp_check_for_duplicate() -- 'post_content' is already slashed/escaped in wp_magic_quotes(). Refixes #2185 for trunk/2.3.
|
| [4831]
|
johnjamesjacoby
|
In bbp_get_user_id(), do not fallback to 'bbp_user_id' query variable, to prevent accidentally confusing a Guest (anonymous) user with the displayed user, in situations where empty bbp_get_user_id() checks are made. Fixes #2284.
|
| [4830]
|
johnjamesjacoby
|
Remove outdated bbp_get_user_id() phpdoc references. See #2284.
|
| [4829]
|
johnjamesjacoby
|
Bump bbpress.pot to match RC1, since our potbot has gone rogue again.
|
| [4828]
|
johnjamesjacoby
|
Bump readme.txt and add missing revision to bbPress class.
|
| [4827]
|
johnjamesjacoby
|
Fix bbp_forum_row_actions() phpdoc description. Props netweb. Fixes #2282.
|
| [4826]
|
johnjamesjacoby
|
Move 'bbp_template_redirect' action to priority 8, giving bbPress precedence over network activated plugins hooked to 'template_redirect' at priority 10 (like BuddyPress). Fixes #2225.
|
| [4825]
|
johnjamesjacoby
|
Ensure textarea content shows correct return $_POST value by adding stripslashes() to bbp_get_form_*_content() functions.
|
| [4824]
|
johnjamesjacoby
|
s/wordpress/WordPress. Props fanquake. Fixes #2265.
|
| [4823]
|
johnjamesjacoby
|
Update label for attribute and HTML in form-topic.php. Props netweb. Fixes #2272.
|
| [4822]
|
johnjamesjacoby
|
Update file phpdoc for single-user.php extra template. Props netweb. Fixes #2276.
|
| [4821]
|
johnjamesjacoby
|
Typo. See #2277.
|
| [4820]
|
johnjamesjacoby
|
Introduce 'bbp_locate_template' action to bbp_locate_template(), with inline documentation for intended usage. Fixes #2277.
|
| [4819]
|
johnjamesjacoby
|
bbp_add_error() phpdoc updates. Props netweb. Fixes #2271.
|
| [4818]
|
johnjamesjacoby
|
Improve logic in topics loop, so that super-stickies are always above forum-stickies. Props alex-ye. Fixes #2260.
|
| [4817]
|
johnjamesjacoby
|
Set the super_sticky text to an empty string rather than unset it, since it's currently expected to exist, and empty values will be filtered out anyways.
|
| [4816]
|
johnjamesjacoby
|
In bbp_move_topic_handler(), when moving a topic from one forum to another, recalculate sticky topics for each forum, and update them accordingly. Also modify the logic used to update ancestor forums, to avoid running update routine multiple times on the same forum. Props alex-ye. Fixes #2259.
|
| [4815]
|
johnjamesjacoby
|
BuddyPress Group Forum Enhancements:
* When deleting a Group, also remove the forum connection. Fixes #2261.
* When disabling a Group's Forum, also remove the forum connection. Fixes #2262.
* Allow editing of a Group's Forum via the Group Admin UI. Fixes #2263.
* Props imath.
|
| [4814]
|
johnjamesjacoby
|
Tweak author link functions to only perform 1 anonymous check. Also, only use author link functions in widgets when show_user is on. Props GargajCNS.
|
| [4813]
|
johnjamesjacoby
|
Akismet:
* Introduce and use improved BBP_Akismet::get_user_roles() method.
* Includes proper type-casting, cleaner logic, and allows for easier dynamic role debugging.
|
| [4812]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [4811]
|
johnjamesjacoby
|
Bump trunk to 2.3 RC 1.
|
| [4810]
|
johnjamesjacoby
|
When unspamming a topic or reply, check for empty prespam status, and default to public. Fixes #2243.
|
| [4809]
|
johnjamesjacoby
|
Hide super sticky related output from group forums. Props imath. Fixes #2227.
|
| [4808]
|
johnjamesjacoby
|
Rename bbp_pre_get_posts_exclude_forums() to bbp_pre_get_posts_normalize_forum_visibility(), to better describe what it does.
bbp_pre_get_posts_normalize_forum_visibility() is a dual purpose function, responsible for normalizing the post_status and post_parent scopes of bbPress related forum queries, against the current users capabilities. This means it must include forums for capable users, and exclude them for incapable users.
See #2221.
|
| [4807]
|
johnjamesjacoby
|
In bbp_pre_get_posts_exclude_forums(), switch logic to remove statuses from existing queries rather than recalculating them completely. Hat tip alex-ye. Fixes #2221.
|
| [4806]
|
johnjamesjacoby
|
Audit up widget code:
* Add missing UI for some options.
* Introduce methods for parsing widget arguments.
* General code clean up.
* Props alex-ye.
* Fixes #2250.
|
| [4805]
|
johnjamesjacoby
|
Remove meta query check from _bbp_has_replies_where(), add some brackets to improve readability. Addresses regression introduced in r4795. See #2221
|
| [4804]
|
johnjamesjacoby
|
Remove outdated bbp_is_query_name() phpdoc references.
|
| [4803]
|
johnjamesjacoby
|
Add topic-view for popular topics, and use it in page-forum-statistics.php rather than hardcoded query.
|
| [4802]
|
johnjamesjacoby
|
Correct /users/template-tags.php inline doc typo. Props netweb. Fixes #2251.
|
| [4801]
|
johnjamesjacoby
|
Correct closing HTML tag helper doc in content-single-topic-lead.php Props netweb. Fixes #2252.
|
| [4800]
|
johnjamesjacoby
|
Add phpdoc file description block to form-user-roles.php. Props netweb. Fixes #2253.
|
| [4799]
|
johnjamesjacoby
|
Remove unnecessary capability check for post-status trash fix. Props alex-ye. Fixes #2255.
|
| [4798]
|
johnjamesjacoby
|
Fix typo in reply nonce error message. Props loki_racer. Fixes #2257.
|
| [4797]
|
johnjamesjacoby
|
Use correct $_user_id variable in user_can() check in bbp_is_user_keymaster(). Props imath. Fixes #2256.
|
| [4796]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [4795]
|
johnjamesjacoby
|
When searching forums, do not include posts that are outside of the logged in user's visibility scope. Also add some inline clarification to _bbp_has_replies_where() to help explain what some conditions are for. Hat tip alex-ye. Fixes #2221.
|
| [4794]
|
johnjamesjacoby
|
Correct file description in content-statistics.php. Props alexvorn2. Fixes #2247.
|
| [4793]
|
johnjamesjacoby
|
Introduce bbp_get_dynamic_role_name() to handle getting a translated role name from the dynamic roles array. Use this to return a more accurate display role in bbp_get_user_display_role(). Hat tip alex-ye. Fixes #2248.
|
| [4792]
|
johnjamesjacoby
|
Fix reversed post request check. See r4791.
|
| [4791]
|
johnjamesjacoby
|
Introduce helper functions for determining the REQUEST_METHOD, and replace occurrences with these new functions. Cleans up inconsistent handling of requests through-out the project.
|
| [4790]
|
johnjamesjacoby
|
Allow additional post-type CSS classes to be passed as a second parameter. Fixes #2242.
|
| [4789]
|
johnjamesjacoby
|
Pass complete content into activity stream items. Create excerpt on output rather than input. Fixes #2237.
|
| [4788]
|
johnjamesjacoby
|
Update bbp_get_forum_last_topic_title() to return an empty string if forum has no topics. Fixes #2238.
|
| [4787]
|
johnjamesjacoby
|
In breadcrumb, skip crumb if parent is empty or an error.
|
| [4786]
|
johnjamesjacoby
|
Merge topic/reply author with attributes metabox save action. Fixes bug causing freshness time to be incorrectly updated from within the dashboard. Props alex-ye. Fixes #2229.
|
| [4785]
|
johnjamesjacoby
|
Typo in inline docs. See #2232.
|
| [4784]
|
johnjamesjacoby
|
Multibyte support for excerpts and breadcrumbs. Hat-tip alex-ye. Fixes #2232.
|
| [4783]
|
johnjamesjacoby
|
Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.
|
| [4782]
|
johnjamesjacoby
|
Move new topic sticky-check after 'bbp_new_topic' action, to ensure forum ID meta is saved via bbp_update_topic(). Also move sticky-check in edit-topic handler, so correct forum ID is used when moving a sticky topic. Props imath. Fixes #2230.
|
| [4781]
|
johnjamesjacoby
|
Translate get_post_time() when used without humanization. Props alex-ye. Fixes #2222.
|
| [4780]
|
johnjamesjacoby
|
Revert WordPress 3.6 slash-compat. See r4771, #WP21767.
|
| [4779]
|
johnjamesjacoby
|
Tweak action order for early !WordPress 3.6 stripslashes support.
|
| [4778]
|
johnjamesjacoby
|
In topic new/edit handlers, don't check unnecessary error conditions. Props alex-ye. Fixes #2220.
|
| [4777]
|
johnjamesjacoby
|
Ensure network admins can always view group forum forms. Props thebrandonallen. Fixes #2214.
|
| [4776]
|
johnjamesjacoby
|
Use correct array key in BBP_Forums_Group_Extension::display_forums(). Props thebrandonallen. Fixes #2215.
|
| [4775]
|
johnjamesjacoby
|
Pass $r instead of $args in ending filters. Ensures correct array of arguments is available to filters. These were skipped as part of #2056. Props alex-ye. Fixes #2218.
|
| [4774]
|
johnjamesjacoby
|
Add Search title to current_text in bbp_get_breadcrumb(). Props alex-ye. Fixes #2218.
|
| [4773]
|
johnjamesjacoby
|
Move bbp_add_forums_roles() to 'bbp_after_setup_theme' action. Fixes issues with role names not being translated in some areas. Fixes #2219.
|
| [4772]
|
johnjamesjacoby
|
Load bbp_login_notices() on 'bbp_head' so text is properly translated. Props alex-ye. Fixes #2217.
|
| [4771]
|
johnjamesjacoby
|
Preliminary support for WordPress 3.6 slash approach. (For easier on-going development.)
|
| [4770]
|
johnjamesjacoby
|
Bail out of converter if there is no request method. Fixes #2113.
|
| [4769]
|
johnjamesjacoby
|
BuddyPress Groups:
* Simplify group forum display logic.
* Use bbp_has_ functions to preload posts. Reduces overhead of calling get_posts() and then creating new WP_Query() object later.
* Use bbPress's front-end nonce verification logic to avoid wp_die'ing theme-side.
* When editing a BuddyPress group's forum settings, allow network administrators to modify the group connection.
* Fixes #2201, #2202.
|
| [4768]
|
johnjamesjacoby
|
Use esc_attr_e() in form-search.php. Props paulgibbs. Fixes #2212.
|