| [5691]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (trunk) and cleanup some phpdoc
Also introduce `bbp_dropdown` class for dropdowns.
|
| [5689]
|
johnjamesjacoby
|
Templates: Micro-optimizations:
* Remove trailing `?>` tag in some template parts
* Remove preceding `?> <?php` in some template parts, after phpdoc header
* Remove whitespace where superfluous
* Reduce number of indentations in some template parts
|
| [5688]
|
johnjamesjacoby
|
Templates: Escape all gettext output in `default` template parts. See #1999.
|
| [5685]
|
johnjamesjacoby
|
Common: Login actions:
* Extract functionality from `bbp_wp_login_action()` into a getter: `bbp_get_wp_login_action()`
* Update arguments in`bbp_get_wp_login_action()` to include optional `url` override
* Pass original `$args` into login action filter
* Also improve support for empty separator in breadcrumbs
|
| [5684]
|
johnjamesjacoby
|
General: Use `sanitize_text_field()` in lieu of old-bbPress style pre-escaping technique.
|
| [5683]
|
johnjamesjacoby
|
Forums: Audit `template.php`:
* General code formatting improvements
* Pass `$args` into more filters
* Escape more gettext output
* Un-nest a few complex-looking lines
|
| [5682]
|
johnjamesjacoby
|
Topics: Move `is_sticky` functions to above open/closed functions
|
| [5681]
|
johnjamesjacoby
|
Topics: Use `sanitize_key()` on `select_id` in dropdown helpers.
|
| [5680]
|
johnjamesjacoby
|
Topics: Audit `template.php`:
* Add filters to `is_sticky` functions
* Pass `$args` into more filters
* Escape more gettext output
* Fix a few `bbp_parse_args` filter names copied from forums component
* Un-nest a few complex-looking lines
|
| [5676]
|
johnjamesjacoby
|
All: Update default values for `$args` parameters from empty strings to empty arrays.
This is a micro-optimization to avoid unnecessary calls to `wp_parse_str()` inside `bbp_parse_args()`.
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [5674]
|
johnjamesjacoby
|
Topics: Normalize admin links:
* Remove superfluous `(int)` type cast
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
|
| [5666]
|
johnjamesjacoby
|
Users: Add missing textdomains to new strings. See #2780.
|
| [5665]
|
johnjamesjacoby
|
Users: Update filter name in `bbp_edit_user_email_send_notification()` to be a bit more clear. See #2780.
|
| [5664]
|
johnjamesjacoby
|
Users: Clean up email message string replacements in `bbp_edit_user_email_send_notification()`. See #2780.
|
| [5663]
|
johnjamesjacoby
|
Users: Email address change improvements:
* Introduce function for handling sending notification email
* Clean up code required to update, save, confirm, & dismiss pending email address changes
* Fixes bug in previous implementation making it impossible to interact with pending email address changes on multisite installations
Fixes #2780.
|
| [5662]
|
johnjamesjacoby
|
Users: Extract `$_GET` conditions out of `bbp_edit_user_handler()` and into their own function, hooked to `bbp_get_request` action.
This fixes functionality that was only half ported from `edit_user()` & WordPress multisite which allows a user to confirm or dismiss pending email address changes to their account from within their bbPress profile edit page.
See #2780.
|
| [5661]
|
johnjamesjacoby
|
Users: Introduce `bbp_notice_edit_user_email_change()` to notify user of a pending email address change to their account. See #2780.
|
| [5660]
|
johnjamesjacoby
|
Users: Remove pending email change markup from `form-user-edit.php`. See #2780.
|
| [5659]
|
johnjamesjacoby
|
API: Add more context to`bbp_redirect()` documentation. See #2778.
|
| [5658]
|
johnjamesjacoby
|
API: Introduce `bbp_redirect()`
* Wraps `wp_safe_redirect()` & `exit()` calls
* Prevents errors from potentially empty `wp_get_referrer()` results
* Replace `wp_safe_redirect()` usages with `bbp_redirect()`
Fixes #2778.
|
| [5657]
|
johnjamesjacoby
|
Users: Update `bbp_check_user_edit()`:
* Update `@uses` in docblock
* Add filters to allow overriding result & redirect_to URL
* Bail instead of indent
* Move `bbp_get_displayed_user_id()` into reusable variable
Fixes #2777.
|
| [5647]
|
johnjamesjacoby
|
Tag 2.5.6 (from 2.5 branch)
|
| [5646]
|
johnjamesjacoby
|
Update `bbpress.pot` (2.5 branch)
|
| [5645]
|
johnjamesjacoby
|
Include `2.5.6` changelog entry in `readme.txt`. (trunk)
|
| [5644]
|
johnjamesjacoby
|
Bump 2.5 branch version to `2.5.6`. Include `2.5.6` changelog entry in `readme.txt`.
|
| [5643]
|
johnjamesjacoby
|
Backport `do_not_reply` email address code from trunk to 2.5 branch (for what will be 2.5.6.) See #2618, r5642.
|
| [5642]
|
johnjamesjacoby
|
Update `bbp_get_do_not_reply_address()` to use `$_SERVER['SERVER_NAME']` over `get_home_url()` to improve compatibility with mapped domains and more complex installations. See #2618 (trunk)
|
| [5641]
|
johnjamesjacoby
|
Code Improvement:
* Add `$Id$` Subversion keyword property to `/src/bbpress.php`.
* Hat tip netweb. See #1851.
|
| [5638]
|
johnjamesjacoby
|
Bye. Props djpaul. See #2771 (2.5 branch)
|
| [5637]
|
johnjamesjacoby
|
Update any relevant hardcoded links to https.
|
| [5636]
|
johnjamesjacoby
|
Bye. Props djpaul. See #2771 (trunk)
|
| [5633]
|
johnjamesjacoby
|
Update readme.txt for 2.5.5.
|
| [5632]
|
johnjamesjacoby
|
Update `bbpress.pot` for 2.5.5 release. (2.5 branch)
|
| [5631]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.5.
|
| [5630]
|
johnjamesjacoby
|
Add capability checks to admin-area ajax methods, and port nonce checks & js from trunk. Props jdgrimes. (2.5 branch)
|
| [5629]
|
johnjamesjacoby
|
Add nonce to bulk-user dropdown. Props jdgrimes. (2.5 branch)
|
| [5628]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (2.5 branch)
|
| [5627]
|
johnjamesjacoby
|
Add capability checks to admin-area ajax methods. Props jdgrimes. (trunk)
|
| [5626]
|
johnjamesjacoby
|
Add nonce to bulk-user dropdown. Props jdgrimes. (trunk)
|
| [5625]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (trunk)
|
| [5624]
|
johnjamesjacoby
|
Update NPM Grunt packages:
* Replace "Community" with "Contributors"
* Remove `grunt-banner` as it is no longer used
* `grunt-cssjanus` v0.2.3
* `grunt-sass` v018.0
See #2766.
|
| [5618]
|
johnjamesjacoby
|
Update `bbp_setup_current_user()` to avoid output in WordPress Customizer. Fixes #2309. See #WP24169.
|
| [5614]
|
johnjamesjacoby
|
Bring `Gruntfile.js` tasks up to speed with BuddyPress.
|
| [5613]
|
johnjamesjacoby
|
In `bbp_notify_forum_subscribers()` remove incorrect array assignment. Fixes bug where `$headers` would be a multidimensional array, causing `wp_mail()` to complain.
|
| [5612]
|
johnjamesjacoby
|
Update readme.txt:
* Modernize verbiage
* Split up `Installation` section for clarity
* Switch links to use `example.com`
* Update tested version to 4.1
* Fix speeling errors
|
| [5611]
|
johnjamesjacoby
|
Check for `IXR_Value` class before including BackPress's version.
Avoids collisions when deeply integrated with WordPress.
For 1.1 & 1.2 branches.
|
| [5610]
|
johnjamesjacoby
|
Port PHPUnit testing setup from BuddyPress. More to clean up here later.
Also adds 1 test to check for `bbpress()` function availability.
See #2542.
|
| [5609]
|
johnjamesjacoby
|
In `bbp_current_author_ip()` check `$_SERVER['REMOTE_ADDR']` before attempting to parse it.
If it is empty (more likely for unit tests, but could be other oddities) we set it to '0.0.0.0' to do two things:
* Indicate to keymasters that something is amiss
* Allow `bbp_current_author_ip()` to proceed normally for the end-user
Fixes #2750.
|
| [5608]
|
johnjamesjacoby
|
Prevent notices and warnings when template stack is empty. Fixes #2749.
|
| [5607]
|
johnjamesjacoby
|
In `bbp_version_updater()` only run update routines if a previous installation exists to update. Fixes #2748.
|
| [5606]
|
johnjamesjacoby
|
Fix notice in bozo plugin. For 1.2 branch. See r5598.
|
| [5605]
|
johnjamesjacoby
|
Avoid notices in bbPress's Akismet plugin. For 1.2 branch. See r5597.
|
| [5604]
|
johnjamesjacoby
|
`Call bb_get_user()` from `bb_get_user_by_nicename()`. For 1.2 branch. See r5595.
|
| [5603]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.2 branch)
|
| [5602]
|
johnjamesjacoby
|
Revert accidental line-change from r5601, #2747.
|
| [5601]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.1 branch)
|
| [5596]
|
johnjamesjacoby
|
Check that `user_url` exists before attempting to allow it in max-links.
|
| [5594]
|
johnjamesjacoby
|
s/POST/GET/ from r5587. See #2742.
|
| [5593]
|
johnjamesjacoby
|
Cast value as `(int)` in `bbp_get_form_forum_parent()`, ensuring it is numerical for the remaining call stack. See #2742.
|
| [5592]
|
johnjamesjacoby
|
Use `sanitize_key()` in `forums/template.php` to ensure values are within expected boundaries. See #2742.
|
| [5591]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_profile_update_role()` to ensure role value is within expected boundaries. See #2742.
|
| [5590]
|
johnjamesjacoby
|
Use `sanitize_user()` in `bbp_user_maybe_convert_pass()` to ensure user login is within expected boundaries. See #2742.
|
| [5589]
|
johnjamesjacoby
|
Use `sanitize_key()` in `topics/functions.php` to ensure values are within expected boundaries. See #2742.
|
| [5588]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_get_form_reply_status_dropdown()` to ensure value is within expected boundaries. See #2742.
|
| [5587]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_post_request()` and `bbp_get_request()`, improving the predictability of possible actions. See #2742.
|
| [5583]
|
johnjamesjacoby
|
Administrative support for for un/approving topics.
Props netweb, thebrandonallen. Fixes #2645.
|
| [5567]
|
johnjamesjacoby
|
Bump alpha version in bbpress.php to latest revision.
|
| [5566]
|
johnjamesjacoby
|
Add nonce checks to admin area topic & author suggest usages.
|
| [5565]
|
johnjamesjacoby
|
Add `'suggest'` to `replies` script prerequisites.
|
| [5564]
|
johnjamesjacoby
|
Add `'suggest'` to `common` script prerequisites.
|
| [5563]
|
johnjamesjacoby
|
Convert template notices from paragraph tags to unordered lists.
Improves accessibility by hinting there may be several notices on the page.
Props Karl Groves, netweb. FIxes #2637.
|
| [5562]
|
johnjamesjacoby
|
Missed removing a tabindex usage. See #2714.
|
| [5561]
|
johnjamesjacoby
|
Deprecate `tabindex` functions and their usages. Props joedolson. Fixes #2714.
|
| [5560]
|
johnjamesjacoby
|
Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.
|
| [5559]
|
johnjamesjacoby
|
Update to newer slashing functions, as our minimum requirement is WordPress 3.6.
Also add filters to topic-title & topic-tags form fields. See #2719.
|
| [5558]
|
johnjamesjacoby
|
Improve form field output sanitization when posting theme-side forum/topic/reply content. Thanks planetzuda. See #2719.
|
| [5553]
|
johnjamesjacoby
|
Add support for `ins` HTML tag, to supplement existing `del` tag support. Props danielbachhuber.
|
| [5534]
|
johnjamesjacoby
|
Better ABSPATH check in `bbpress.php` stub loader.
|
| [5513]
|
johnjamesjacoby
|
Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.
|
| [5512]
|
johnjamesjacoby
|
Slightly refactor `bbp_format_buddypress_notifications()`:
* Return original `$action` if not `bbp_new_reply`.
* Reduce indentation to accommodate new `$action` check.
This fixes a bug where checking for new reply notifications could cause future notification filter checks to fail.
Props Faison. Fixes #2665.
|
| [5511]
|
johnjamesjacoby
|
In our BuddyPress Groups `display_forums` method, `break` out of switch statement rather than `return`. This prevents malformed markup caused by not allowing the method to continue on. Hat-tip boonebgorges, netweb. Fixes #2595.
|
| [5510]
|
johnjamesjacoby
|
Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.
This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270.
|
| [5509]
|
johnjamesjacoby
|
Administrative support for un/approving replies. Props netweb. See #2645.
|
| [5508]
|
johnjamesjacoby
|
Add default theme compat styling for pending topics and replies. Props netweb. See #2645.
|
| [5507]
|
johnjamesjacoby
|
Preliminary template support for un/approving replies. Props netweb. See #2645.
|
| [5506]
|
johnjamesjacoby
|
Preliminary function support for un/approving replies. Props netweb. See #2645.
|
| [5505]
|
johnjamesjacoby
|
Add pending status to search results for capable users wishing to view all results. Props netweb. See #2645.
|
| [5504]
|
johnjamesjacoby
|
Preliminary template support for un/approving topics. Props netweb. See #2645.
|
| [5503]
|
johnjamesjacoby
|
Preliminary function support for un/approving topics. Props netweb. See #2645.
|
| [5502]
|
johnjamesjacoby
|
Add pending topics to forum hidden topic counts. Props netweb. See #2645.
|
| [5501]
|
johnjamesjacoby
|
Update phpdoc blocks in forum template functions. Props netweb. See #2645.
|
| [5500]
|
johnjamesjacoby
|
Clean up core `actions.php`. Props netweb. See #2645.
|
| [5499]
|
johnjamesjacoby
|
Enable forum status and visibility functions to check ancestry by extracting existing logic into new helper functions. Props alex-ye, netweb. Fixes #2303.
|
| [5498]
|
johnjamesjacoby
|
Update widget description in `BBP_Topics_Widget` to include topic newness. Props netweb. Fixes #2531.
|
| [5497]
|
johnjamesjacoby
|
Improve ID and classification in `form-topic.php` when forum is closed or user cannot create new topics. Props netweb. Fixes #2574.
|
| [5496]
|
johnjamesjacoby
|
Embetter Orwellian Newspeak used to describe sticky topics in `admin/topics.php`. Props netweb. Fixes #2622.
|
| [5495]
|
johnjamesjacoby
|
Add reply status section to `form-reply.php`. Props netweb. Fixes #2644.
|
| [5494]
|
johnjamesjacoby
|
Tweak `bbp-author-ip` styling, removing the font family and ensuring long IP addresses break correctly. Props netweb. Fixes #2675.
|
| [5493]
|
johnjamesjacoby
|
Allow `class` attribute for `pre` tags in `bbp_kses_allowed_tags()`. Props netweb. Fixes #2657.
|