| [5609]
|
johnjamesjacoby
|
In `bbp_current_author_ip()` check `$_SERVER['REMOTE_ADDR']` before attempting to parse it.
If it is empty (more likely for unit tests, but could be other oddities) we set it to '0.0.0.0' to do two things:
* Indicate to keymasters that something is amiss
* Allow `bbp_current_author_ip()` to proceed normally for the end-user
Fixes #2750.
|
| [5608]
|
johnjamesjacoby
|
Prevent notices and warnings when template stack is empty. Fixes #2749.
|
| [5607]
|
johnjamesjacoby
|
In `bbp_version_updater()` only run update routines if a previous installation exists to update. Fixes #2748.
|
| [5606]
|
johnjamesjacoby
|
Fix notice in bozo plugin. For 1.2 branch. See r5598.
|
| [5605]
|
johnjamesjacoby
|
Avoid notices in bbPress's Akismet plugin. For 1.2 branch. See r5597.
|
| [5604]
|
johnjamesjacoby
|
`Call bb_get_user()` from `bb_get_user_by_nicename()`. For 1.2 branch. See r5595.
|
| [5603]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.2 branch)
|
| [5602]
|
johnjamesjacoby
|
Revert accidental line-change from r5601, #2747.
|
| [5601]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.1 branch)
|
| [5596]
|
johnjamesjacoby
|
Check that `user_url` exists before attempting to allow it in max-links.
|
| [5594]
|
johnjamesjacoby
|
s/POST/GET/ from r5587. See #2742.
|
| [5593]
|
johnjamesjacoby
|
Cast value as `(int)` in `bbp_get_form_forum_parent()`, ensuring it is numerical for the remaining call stack. See #2742.
|
| [5592]
|
johnjamesjacoby
|
Use `sanitize_key()` in `forums/template.php` to ensure values are within expected boundaries. See #2742.
|
| [5591]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_profile_update_role()` to ensure role value is within expected boundaries. See #2742.
|
| [5590]
|
johnjamesjacoby
|
Use `sanitize_user()` in `bbp_user_maybe_convert_pass()` to ensure user login is within expected boundaries. See #2742.
|
| [5589]
|
johnjamesjacoby
|
Use `sanitize_key()` in `topics/functions.php` to ensure values are within expected boundaries. See #2742.
|
| [5588]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_get_form_reply_status_dropdown()` to ensure value is within expected boundaries. See #2742.
|
| [5587]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_post_request()` and `bbp_get_request()`, improving the predictability of possible actions. See #2742.
|
| [5583]
|
johnjamesjacoby
|
Administrative support for for un/approving topics.
Props netweb, thebrandonallen. Fixes #2645.
|
| [5567]
|
johnjamesjacoby
|
Bump alpha version in bbpress.php to latest revision.
|
| [5566]
|
johnjamesjacoby
|
Add nonce checks to admin area topic & author suggest usages.
|
| [5565]
|
johnjamesjacoby
|
Add `'suggest'` to `replies` script prerequisites.
|
| [5564]
|
johnjamesjacoby
|
Add `'suggest'` to `common` script prerequisites.
|
| [5563]
|
johnjamesjacoby
|
Convert template notices from paragraph tags to unordered lists.
Improves accessibility by hinting there may be several notices on the page.
Props Karl Groves, netweb. FIxes #2637.
|
| [5562]
|
johnjamesjacoby
|
Missed removing a tabindex usage. See #2714.
|
| [5561]
|
johnjamesjacoby
|
Deprecate `tabindex` functions and their usages. Props joedolson. Fixes #2714.
|
| [5560]
|
johnjamesjacoby
|
Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.
|
| [5559]
|
johnjamesjacoby
|
Update to newer slashing functions, as our minimum requirement is WordPress 3.6.
Also add filters to topic-title & topic-tags form fields. See #2719.
|
| [5558]
|
johnjamesjacoby
|
Improve form field output sanitization when posting theme-side forum/topic/reply content. Thanks planetzuda. See #2719.
|
| [5553]
|
johnjamesjacoby
|
Add support for `ins` HTML tag, to supplement existing `del` tag support. Props danielbachhuber.
|
| [5534]
|
johnjamesjacoby
|
Better ABSPATH check in `bbpress.php` stub loader.
|
| [5513]
|
johnjamesjacoby
|
Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.
|
| [5512]
|
johnjamesjacoby
|
Slightly refactor `bbp_format_buddypress_notifications()`:
* Return original `$action` if not `bbp_new_reply`.
* Reduce indentation to accommodate new `$action` check.
This fixes a bug where checking for new reply notifications could cause future notification filter checks to fail.
Props Faison. Fixes #2665.
|
| [5511]
|
johnjamesjacoby
|
In our BuddyPress Groups `display_forums` method, `break` out of switch statement rather than `return`. This prevents malformed markup caused by not allowing the method to continue on. Hat-tip boonebgorges, netweb. Fixes #2595.
|
| [5510]
|
johnjamesjacoby
|
Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.
This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270.
|
| [5509]
|
johnjamesjacoby
|
Administrative support for un/approving replies. Props netweb. See #2645.
|
| [5508]
|
johnjamesjacoby
|
Add default theme compat styling for pending topics and replies. Props netweb. See #2645.
|
| [5507]
|
johnjamesjacoby
|
Preliminary template support for un/approving replies. Props netweb. See #2645.
|
| [5506]
|
johnjamesjacoby
|
Preliminary function support for un/approving replies. Props netweb. See #2645.
|
| [5505]
|
johnjamesjacoby
|
Add pending status to search results for capable users wishing to view all results. Props netweb. See #2645.
|
| [5504]
|
johnjamesjacoby
|
Preliminary template support for un/approving topics. Props netweb. See #2645.
|
| [5503]
|
johnjamesjacoby
|
Preliminary function support for un/approving topics. Props netweb. See #2645.
|
| [5502]
|
johnjamesjacoby
|
Add pending topics to forum hidden topic counts. Props netweb. See #2645.
|
| [5501]
|
johnjamesjacoby
|
Update phpdoc blocks in forum template functions. Props netweb. See #2645.
|
| [5500]
|
johnjamesjacoby
|
Clean up core `actions.php`. Props netweb. See #2645.
|
| [5499]
|
johnjamesjacoby
|
Enable forum status and visibility functions to check ancestry by extracting existing logic into new helper functions. Props alex-ye, netweb. Fixes #2303.
|
| [5498]
|
johnjamesjacoby
|
Update widget description in `BBP_Topics_Widget` to include topic newness. Props netweb. Fixes #2531.
|
| [5497]
|
johnjamesjacoby
|
Improve ID and classification in `form-topic.php` when forum is closed or user cannot create new topics. Props netweb. Fixes #2574.
|
| [5496]
|
johnjamesjacoby
|
Embetter Orwellian Newspeak used to describe sticky topics in `admin/topics.php`. Props netweb. Fixes #2622.
|
| [5495]
|
johnjamesjacoby
|
Add reply status section to `form-reply.php`. Props netweb. Fixes #2644.
|
| [5494]
|
johnjamesjacoby
|
Tweak `bbp-author-ip` styling, removing the font family and ensuring long IP addresses break correctly. Props netweb. Fixes #2675.
|
| [5493]
|
johnjamesjacoby
|
Allow `class` attribute for `pre` tags in `bbp_kses_allowed_tags()`. Props netweb. Fixes #2657.
|
| [5492]
|
johnjamesjacoby
|
Missed a 'Reply To' reply title update. See r5490.
|
| [5491]
|
johnjamesjacoby
|
In `bbp_split_topic_handler()` remove `$reply_position` cheater code, and rely on `bbp_update_reply_position()` to recalculate the correct position in the hierarchy after `wp_update_post()` has finished. Props netweb. Fixes #2624.
|
| [5490]
|
johnjamesjacoby
|
Remove remaining 'Reply To' references in reply `post_title`'s.
(Now that posts can have empty titles, this is no longer necessary. It also yielded undesired single reply slugs, though they are only exposed to moderators and keymasters.)
Hat tip netweb.
|
| [5489]
|
johnjamesjacoby
|
In `bbp_merge_topic_handler()` delete last and count metas, and update the reply position after call to `wp_update_post()`. Fixes bug where merging two topics with odd timestamps could result in orphaned or incorrect meta data and hierarchy positioning. Props netweb. Fixes #2528.
|
| [5488]
|
johnjamesjacoby
|
Change behavior of `bbp_check_for_moderation()` so empty `moderation_keys` no longer skips `max_links` check. Props netweb. See #2546.
|
| [5487]
|
johnjamesjacoby
|
Dedicated filters to allow manipulating of users who will receive subscription emails. Hat tip roysmyth. Fixes #2627.
|
| [5486]
|
johnjamesjacoby
|
Pass `$topic_id` and `$forum_id` to relevant favorites and subscriptions filters. Hat tip DJPaul. Fixes #2651.
|
| [5485]
|
johnjamesjacoby
|
Add brackets to comparison in `bbp_is_single_forum()`.
|
| [5478]
|
johnjamesjacoby
|
In the `form-topic.php` template part, check for 'bbp_get_forum_title()` before outputting an empty title. Props jreeve. Fixes #2625.
|
| [5477]
|
johnjamesjacoby
|
In `bbp_has_topics()` bring back `$default_topic_search` variable to prevent debug notices.
|
| [5476]
|
johnjamesjacoby
|
In `_bbp_has_replies_where()` remove the `post__not_in` check and add extra search/replace arguments for more complex queries. Improves support for popular privacy plugins that frequently use `post__not_in`. Props mikelopez. Fixes #2609.
|
| [5475]
|
johnjamesjacoby
|
Use `exclude` instead of post__not_in, in `bbp_get_forums_for_current_user()`.
|
| [5474]
|
johnjamesjacoby
|
Correct inline doc in `bbp_forum_get_subforums()`.
|
| [5473]
|
johnjamesjacoby
|
In `bbp_admin_repair_forum_topic_count()` include hidden topics in repair tool. Props thebrandonallen. Fixes #2680.
|
| [5472]
|
johnjamesjacoby
|
Use `wp_get_user_contact_methods()` in `bbp_get_user_contact_methods()`. See #2570.
|
| [5471]
|
johnjamesjacoby
|
Use "Unfavorite" in `bbp_get_user_favorites_link()`. Fixes #2604.
|
| [5470]
|
johnjamesjacoby
|
In `bbp_theme_compat_reset_post()` also set `is_singular` to value of `is_single`. Improves query compatibility with themes and other plugins. Props Mat Lipe. Fixes #2545.
|
| [5469]
|
johnjamesjacoby
|
Whitespace and brackets in main `bbPress` class.
|
| [5468]
|
johnjamesjacoby
|
Only add the `s` argument to global forum search queries if search-terms exist.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804].
|
| [5467]
|
johnjamesjacoby
|
Only add the `s` argument to queries if `rs` or `ts` are set in their respective topics & replies queries.
See #2607, #WP11330, [WP28623] [WP28612], [WP28804].
|
| [5466]
|
johnjamesjacoby
|
Simpify `ABSPATH` checks to pass coding standard sniffers that look for brackets on comparisons.
|
| [5465]
|
johnjamesjacoby
|
In `bbp_do_ajax()` use `get_option( 'html_type' )`.
|
| [5462]
|
johnjamesjacoby
|
Use the correct `EMPTY_TRASH_DAYS` const.
|
| [5445]
|
johnjamesjacoby
|
Add missing brackets to core functions.
|
| [5444]
|
johnjamesjacoby
|
Breathing room for `!` usages in Search component.
|
| [5443]
|
johnjamesjacoby
|
Breathing room for `!` usages in Topics component.
|
| [5442]
|
johnjamesjacoby
|
Breathing room for `!` usages in Users component.
|
| [5441]
|
johnjamesjacoby
|
Bracketize extensions, and missed a spot in the admin.
|
| [5440]
|
johnjamesjacoby
|
Brackets and code formatting improvements to admin component.
|
| [5439]
|
johnjamesjacoby
|
Remove rogue semicolon.
|
| [5438]
|
johnjamesjacoby
|
Bracketize core component.
|
| [5437]
|
johnjamesjacoby
|
Bracketize common component.
|
| [5436]
|
johnjamesjacoby
|
Bracketize users component.
|
| [5435]
|
johnjamesjacoby
|
Bracketize forums component.
|
| [5434]
|
johnjamesjacoby
|
Phpdoc corrections to topic dropdown functions.
|
| [5433]
|
johnjamesjacoby
|
Bracketize search component.
|
| [5432]
|
johnjamesjacoby
|
Bracketize topics component.
|
| [5431]
|
johnjamesjacoby
|
Bracketize replies component.
|
| [5423]
|
johnjamesjacoby
|
Add object references to `bbpress()` and `bbPress` document blocks.
|
| [5420]
|
johnjamesjacoby
|
Update a few documentation blocks in `common/functions.php` that had missing or incorrect references.
|
| [5417]
|
johnjamesjacoby
|
Add default value for `$user_id` to prevent debug notice when sending subscription notifications. Props mordauk. Fixes #2620.
|
| [5413]
|
johnjamesjacoby
|
Deprecate `bbp_notify_subscribers()` for new `bbp_notify_topic_subscribers()` function, to better match `bbp_notify_forum_subscribers()` introduced in 2.5.
|
| [5412]
|
johnjamesjacoby
|
Add some missing brackets. See #2494.
|
| [5411]
|
johnjamesjacoby
|
Delete trashed and spam topic-meta when performing untrash or unspam actions. Hat tip netweb. See #2494.
|
| [5410]
|
johnjamesjacoby
|
Correct `bbp_stuck_topic` phpdoc. See #2494.
|
| [5409]
|
johnjamesjacoby
|
Introduce `bbp_get_do_not_reply_address()` function, and use in subscription notification functions. Also add filters to make changing these values easier for advanced setups. Fixes #2618.
|
| [5408]
|
johnjamesjacoby
|
Abstract new topic-transition reply helper-functions onto action hooks for easier testing and replacement/extension by third party plugins. See #2494.
|
| [5407]
|
johnjamesjacoby
|
Add phpdoc to `bbp_trash_topic_replies()` from r5406. See #2494.
|