| [6081]
|
netweb
|
Build Tools: Add WordPress 4.6 to Travis CI build matrix
|
| [6080]
|
netweb
|
Tests: Following r6078 update tests in `::BBP_Tests_Users_Template_User` to use single user slug `users`
See #2983
|
| [6079]
|
netweb
|
Rewrite Rules: Update search permastruct in `bbPress::add_permastructs()` to `$search_id`
This changeset fixes copy pasta introduced in r4930, and updates the search rewrite to use the `$search_id` and not the `$user_id` as the permalink structure name.
Props offereins.
Fixes #2984.
|
| [6078]
|
netweb
|
Options: Set the default value of `bbp_get_user_slug()` to `users`
This changeset updates the default single user slug from `user` to `users`. The `bbp_get_default_options()` function defines the default as `users` and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug `user` rather than `users`.
Props ocean90.
Fixes #2983
|
| [6077]
|
netweb
|
Tests: Add `test_bbp_forum_query_last_reply_id()`
See #2972
|
| [6076]
|
netweb
|
Build Tools: Fix `BBP_UnitTestCase::go_to()` for `WP_Network`.
This changeset is via buddypress:changeset:10125
Props boonebgorges.
Fixes #2981
|
| [6075]
|
netweb
|
Build Tools: More targeted cleanup for multisite unit tests.
This changeset is a subset of buddypress:changeset:9980 and removes a previous heavy-handed workaround for deleting the first multisite user. This also resolves a fatal error `Object does not implement ArrayAccess` when running the tests on HHVM.
See #2962, #2981
|
| [6074]
|
netweb
|
Build Tools: Upgrade to the latest HHVM version with Travis CI using Ubuntu Trusty
Fixes #2980.
|
| [6073]
|
netweb
|
Build Tools: Add PHP 7.1 to Travis CI and "allow to fail"
This changeset adds explict PHP 7.1 for testing bbPress, see also #WP37625
See #2980.
|
| [6072]
|
netweb
|
Options: Fix `bbp_show_on_root()` copy pasta PHPDoc description
|
| [6071]
|
netweb
|
Tests: Update forum/topic/reply post type assertions for the `WP_Post_Type` class introduced in WordPress 4.6
Fixes #2962.
|
| [6070]
|
netweb
|
Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
|
| [6069]
|
netweb
|
Fix Subscriptions slug setting field PHPDoc block copy pasta
|
| [6061]
|
netweb
|
General - Administration: Update "change forum role" dropdown
This changeset resolves an issue introduced in WordPress 4.4 ( [WP:changeset:34636] / #WP27743 ) which caused bbPress "change forum role" dropdown to only work using the "bottom" user list table dropdown, for WordPress versions < 4.6 the "change forum role" dropdown is now only shown at the "top" of the user list table.
This changeset also adds a new parameter `$which` to `user_role_bulk_dropdown()` which was added in WordPress 4.6 ( [WP:changeset:37422] / #WP35307 ) to pass the location of the extra table nav markup for the "top" or "bottom" "change role" dropdown, and in turn fixes bbPress' "change forum role" dropdown to once again work at the "top" and "bottom" of the user list table.
Props ocean90.
Fixes #2906.
|
| [6060]
|
netweb
|
Tools - Unit Tests: Use `get_sites()` for muiltisite PHPUnit testcase in `BBP_UnitTestCase::tearDown`
WordPress 4.6 deprecated `wp_get_sites()`, switch to the replacement `get_sites()` via #WP36994 / [wp:changeset:37653]
Fixes #2962.
|
| [6059]
|
netweb
|
API Feeds: RSS `<pubDate>` element in `bbp_display_topics_feed_rss2()` shouldn't be translated.
This changeset brings this RSS `<pubDate>` element inline with other instances in bbPress feeds.
Props thebrandonallen.
Fixes 2961.
|
| [6055]
|
netweb
|
General - Administration: Add pending status topic and reply statistics to `bbp_get_statistics()`
Following the introduction of "pending" status topics and replies in bbPress 2.6, `bbp_get_statistics()` now includes these count statistics in the hidden topic and reply statistics.
Fixes #2958.
|
| [6054]
|
netweb
|
Cache: Allow a second parameter to be passed to `bbp_clean_post_cache()`
Following [5774] WP's `clean_post_cache` hook can pass both post ID and the post object, this changeset allows that second parmeter to be passed to `bbp_clean_post_cache()` and updates our `add_action` call to send both parameters.
Props thebrandonallen.
Fixes #2813.
|
| [6053]
|
netweb
|
Tests: Introduce tests for the cache functions.
Props thebrandonallen.
See #2813
|
| [6052]
|
netweb
|
Administration: Only display bbPress users role in bbPress' "Forum Role" list
Since WordPress 4.4 users with multiple roles are displayed in WordPress' "Site Role" list, this changeset ensures bbPress' roles are only displayed under the "Forum Role" list and not duplicated in the "Site Role" list of the users list table.
Props johnbillion, tharsheblows for initial patches
Fixes #2874
|
| [6051]
|
netweb
|
Introduce `bbp_get_major_wp_version()` function to help checking against WordPress versions
See #2874
|
| [6050]
|
netweb
|
Moderation: Add new `bbp_moderation_keys` and `bbp_blacklist_keys` filters
This changeset allows external plugins to filter the list of moderation and blacklist keyword terms, IP, URLs, words, etc.
Also cleans up `bbp_check_for_moderation()` to bails early if there are no moderation keys inline with `bbp_check_for_blacklist()`
Props thebrandonallen, satollo.
Fixes #2861.
|
| [6049]
|
netweb
|
Build Tools: Update `grunt-patch-wordpress` to 0.4.0
This update adds two main features for your WordPress development happiness.
1) GitHub URL support. You can now use `grunt patch:https://github.com/bbpress/bbPress/pull/3` with any copy of bbPress on GitHub. No longer will you need to download the patch manually.
2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. `grunt upload_patch:20000` will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug committers). You still need to manually add the `has patch` keyword.
Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.3.0...0.4.0
Props jorbin, ericlewis, michaelbeil, netweb
|
| [6048]
|
netweb
|
Tests: Add `test_bbp_get_do_not_reply_address()` common functions reply email address test
Props thebrandonallen
Fixes #2822
|
| [6047]
|
netweb
|
Strings: Switch from "Freshness" to "Last Post" in the admin screens.
This changeset follows on from [5867] where these couple of strings were missed in the original commit.
Props Robkk, thebrandonallen
Fixes #2031
|
| [6046]
|
netweb
|
General: Add debug trace to `bbp_setup_current_user()` notice.
Previously, the `bbp_setup_current_user was called incorrectly` notice would not output any useful info for developers.
This commit adds a debug trace so developers are able to determine
whereabouts in the codebase this notice is originating from.
Props r-a-y
Fixes #2932
|
| [6045]
|
netweb
|
i18n: Avoid using HTML tags in translation strings (includes/admin/replies.php)
Props ramiy, thebrandonallen
Fixes #2912
|
| [6044]
|
netweb
|
i18n: Avoid using HTML tags in translation strings (includes/admin/topics.php)
Props ramiy, thebrandonallen
Fixes #2911
|
| [6043]
|
netweb
|
i18n: Avoid using HTML tags in translation strings (includes/admin/forums.php)
Props ramiy, thebrandonallen
Fixes #2910
|
| [6042]
|
netweb
|
i18n: Avoid using HTML tags in translation strings
Props ramiy, thebrandonallen
Fixes #2881
|
| [6041]
|
netweb
|
Importers: In `BBP_Converter_Base::convert_table()` method use `isset()` rather than `! is_null`
Props Offereins
Fixes #2733
|
| [6040]
|
netweb
|
Admin: Escape `$file` variable for importer filenames in `bbp_converter_setting_callback_platform()`
Props xknown
Fixes #2792
|
| [6038]
|
netweb
|
Widgets: Use `$this->get_field_id()` in `BBP_Topics_Widget::form()` method to correctly create the widget id form attribute
Props alex-ye
Fixes #2758
|
| [6037]
|
netweb
|
Replies: Fix `@param` PHPDoc in `bbp_insert_topic_update_counts()`
See #1799
|
| [6036]
|
netweb
|
General Performance: Introduce increase/decrease helper count functions
Previously when a new topic or reply was created, a bunch of queries to recalculate the topic and reply counts for topics and forums were ran. Now these have been replaced with more efficient increase/decrease helper functions to get the current value and just "bump" the count based on the action (new topic-reply/split-topic/move-topic/spam-trash-topic/etc...)
Props thebrandonallen, tharsheblows, netweb
See #1799
|
| [6035]
|
netweb
|
Build Tools: Update `stylelint` to v6.5.1 and bump `.stylelintrc` to `stylelint-config-wordpress` v7.1.1
See #2924
|
| [6034]
|
netweb
|
Subscriptions: Update `bbp_new_reply` action to to use `bbp_notify_topic_subscribers` over deprecated `bbp_notify_subscribers`.
Previously in [5643] this was added to the 2.5 branch but was overlooked for `/trunk`, this changeset fixes that.
Props thebrandonallen
Fixes #2946, see also #2618
|
| [6031]
|
netweb
|
Tests: In PHPUnit bootstrap check if the `BP_TESTS_DIR` constant is first defined before attempting to load BuddyPress PHPunit `testcase.php`
|
| [6030]
|
netweb
|
Tests: Following [6010] Add SpeedTrapListener to `buddypress.xml` and `multisite.xml` PHPUnit configuration files
|
| [6029]
|
netweb
|
Build Tools: Update `grunt-sass` to v1.2.0 with `node-sass` > v3.7.x support
See https://github.com/sindresorhus/grunt-sass/compare/v1.1.0...v1.2.0
|
| [6028]
|
netweb
|
Build Tools: Update stylelint to 6.4.2
See #2924
|
| [6025]
|
netweb
|
Build Tools: Set a whitelist for PHPUnit code coverage
This chageset adds a PHPUnit whitelist of files for use with code coverage tests analsyis tools.
Hat tip jorbin.
Fixes #2953.
|
| [6022]
|
netweb
|
Tests: Add `@covers` annotations to `BBP_Tests_Common_Functions_Make_Clickable` tests
|
| [6021]
|
netweb
|
API - Feeds: Use `feed_content_type( 'rss2' )` for RSS feeds.
This changeset updates the RSS 2 native mime type `application/rss+xml`, previously `rss-http` used `text/xml` which was removed from WordPress in [WP36230] and [WP32468].
(2.5 branch)
Props thebrandonallen.
Fixes #2901.
|
| [6020]
|
netweb
|
Forums: Overzealous type coercion caused `bbp_forum_query_last_reply_id()` to skip the database query in every instance (since 0 is never === false). As such, the resetting of `_bbp_last_reply_id` got short-circuted in some cases.
This fix is for the 2.5 branch, `/trunk` fixed this inadvertantly in [5954]
Props boonebgorges, mauteri.
Fixes #2414.
|
| [6011]
|
netweb
|
Tests: Improve test performance by reducing the number of topics and replies created in `test_bbp_forum_trashed_untrashed_topic_counts()` and `test_bbp_forum_spammed_unspammed_topic_counts()` tests
|
| [6010]
|
netweb
|
Tests: Add `SpeedTrapListener` to `phpunit/includes` and add the config node to `phpunit.xml.dist`.
This changeset via wp:changeset:35214 adds a PHPUnit TestListener that exposes the slowest running tests by outputting results to the console.
|
| [6009]
|
netweb
|
Tests: Add recount forum topics repair tool test `test_bbp_admin_repair_forum_topic_count()`
|
| [6008]
|
netweb
|
Tests: Update inline docs in `test_bbp_admin_repair_forum_reply_count()` from [6007]
|
| [6007]
|
netweb
|
Tests: Add recount forum replies repair tool test `test_bbp_admin_repair_forum_reply_count()`
|
| [6006]
|
netweb
|
Tests: Include forum category tests in `bbp_*_forum_*_count()` template functions.
This changeset improves forum template count tests adding category total topic and total reply counts which are calculated differently to forum topic and reply counts.
See #1799
|
| [6005]
|
netweb
|
Tools: Travis CI The Matrix Reloaded
'''The Architect''': ''The first matrix I designed was quite naturally perfect. It was a work of art. Flawless. Sublime. A triumph only equaled by its monumental failure.''
|
| [6004]
|
netweb
|
Tests: Include forum category and forum category meta in `test_bbp_insert_forum()`
This changeset improves `bbp_insert_forum()` testing using hierarchical category/forum (parent/child) forums post and post meta integrity.
|
| [6003]
|
netweb
|
Build Tools: Add WordPress 4.5 to Travis CI build matrix
|
| [6002]
|
netweb
|
Tools: Return unique message strings in `bbp_admin_reset_handler()` when deleting imported users and user meta vs non-imported user meta.
Fixes #2928.
|
| [6001]
|
netweb
|
API - Importers: Xenforo:
* Adds support for "soft deleted" topics and replies imported as "pending" status
* Add support for YouTube, Vimeo, and Daily Motion BBCode conversion
* Add quotes BBCode conversion
Fixes #2927
|
| [6000]
|
netweb
|
Build Tools: Revert [5999] `grunt-legacy-util` update, from 0.2.0 to 1.0.0
This changeset reverts the above change as I missed the `1.0.0` recommended [https://github.com/gruntjs/grunt-legacy-util/blob/master/README.md change] to use `require('child_process').spawn` over `grunt.util.spawn`. Per NodeJS docs [https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options here] and [https://nodejs.org/dist/latest-v4.x/docs/api/child_process.html#child_process_child_process_spawn_command_args_options here] for NodeJS versions 5.x and 4.x respectively this needs some more testing and changes to the Grunt phpunit task and multi task.
Another option per [https://github.com/gruntjs/grunt-legacy-util/issues/10 grunt-legacy-util #10] is to switch to [https://www.npmjs.com/package/cross-spawn-async cross-spawn-async]
Both above options will require *nix and Windows testing.
''6000 is the natural number following 5999 and preceding 6001.''
See #2918
|
| [5999]
|
netweb
|
Build Tools: Update `grunt-legacy-util` from 0.2.0 to 1.0.0
See also: https://github.com/gruntjs/grunt-legacy-util/compare/v0.2.0...v1.0.0
See #2918
|
| [5998]
|
netweb
|
Build Tools: Update styelelint to `5.3.0`
See #2924
|
| [5997]
|
netweb
|
Tests: Forum meta keys created with our Factory::create methods should not be prefixed with `_bbp_`
Props thebrandonallen.
Fixes 2926.
|
| [5996]
|
netweb
|
Build Tools: Add NPM package `postcss-scss` for styelelint SCSS compatibility
This changeset fixes an idiosyncratic NPM v3.x issue with "flat" folders and sharing dependencies that is not an issue when using NPM v2
See #2924
|
| [5995]
|
netweb
|
Build Tools: Add @stylelint for linting CSS to adhere to WordPress CSS Coding Standards
This changeset adds a new Grunt task `grunt postcss:lint` that runs stylelint on CSS & SCSS files to ensure bbPress' CSS adheres to WordPress CSS Coding Standards.
8 months in the making and is maintained by yours truly @netweb, with stylelint I'm learning JavaScript deeply.
See also:
* http://stylelint.io/
* https://github.com/stylelint/stylelint
* https://github.com/ntwb/stylelint-config-wordpress
* https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/
Hat-tip: David Clark and Richard Hallows for the ongoing help and support.
Props netweb.
Fixes #2924.
|
| [5994]
|
netweb
|
Build Tools: Add Autoprefixer for adding CSS vendor prefixes
This changeset adds a new Grunt task `grunt postcss:core` that runs Autoprefixer on CSS & SCSS files to add or remove any vendor prefixes required by browsers.
Browsers supported are the same as WordPress currently supports which are:
* Android >= 2.1
* Chrome >= 21
* Edge >= 12
* Explorer >= 7
* Firefox >= 17
* Opera >= 12.1
* Safari >= 6.0.
Vendor prefixes are are also added for `templates/default/css/bbpress.css` as this is the only file that requires them at this time.
Fixes #2923.
|
| [5993]
|
netweb
|
Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:34976, WP:changeset:35265, WP:changeset:36532, and WP:changeset:36619
* `_mixins.scss` via WP:changeset:34948
See #2583
|
| [5992]
|
netweb
|
Build Tools: Update grunt-contrib-watch from 0.6.1 to 1.0.0
See #2918
|
| [5991]
|
netweb
|
Bump minimum WordPress requirement to 4.0.
Fixes #2902.
|
| [5990]
|
netweb
|
bbPress: Bumb readme.txt tested-up-to tags to 4.5.
|
| [5989]
|
netweb
|
Importers: Add support for anonymous topic and reply import support in XenForo (XenForo.php) importer
This changeset adds support for importing topics and replies where the original XenForo author was deleted, this keeps the original author name as the now topic or reply anonymous author name.
Props netweb.
Fixes #2922, See aslo #2347.
|
| [5988]
|
netweb
|
Tools: Use updated meta key `_bbp_old_user_id` to determine imported users in `bbp_admin_reset_handler()`
This changeset updates the meta key used to determine an imported user for handling the deletion of imported users in the reset forums tool, this should have originally been included in r5530 but was missed.
See #2650
|
| [5987]
|
netweb
|
Build Tools: Revert Travis CI TRAVIS_NODE_VERSION environment variable changes from r5984/r5985, installing NodeJS 4.x.x via NVM is sufficient per r5986.
Fixes #2920.
|
| [5986]
|
netweb
|
Build Tools: Install NodeJS 4.x.x using NVM in Travis CI
See #2920
|
| [5985]
|
netweb
|
Build Tools: Define TRAVIS_NODE_VERSION as a global variable for Travis CI
See #2920
|
| [5984]
|
netweb
|
Build Tools: Add minimum NodeJS 4.2.x LTS version
This changeset sets the minimum required NodeJS version supported. This is required as various NPM modules now require a minimum version greater than the default v0.10.x currently in use.
See #2920.
|
| [5983]
|
netweb
|
Build Tools: Renamed `grunt-rtlcss` option `options.config` to RTLCSS v2.x `options.opts` option
See #2918
|
| [5982]
|
netweb
|
Build Tools: Update `grunt-rtlcss` from `1.6.0` to `2.0.1`
Fixes #2918
|
| [5981]
|
netweb
|
Build Tools: Update `grunt-sass` from `1.0.0` to `1.1.0`
See #2918
|
| [5980]
|
netweb
|
Build Tools: Update `matchdep` from `0.3.0` to `1.0.1`
See #2918
|
| [5979]
|
netweb
|
Build Tools: Update `grunt-check-dependencies` from `0.11.2` to `0.12.0`
See #2918
|
| [5978]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify` from `0.9.2` to `1.0.0`
See #2918
|
| [5977]
|
netweb
|
Build Tools: Update `grunt-contrib-jshint` from `0.11.2` to `1.0.0`
See #2918
|
| [5976]
|
netweb
|
Build Tools: Update `grunt-contrib-copy` from `0.8.0` to `1.0.0`
This changeset fixes the "my bad" r5975 commit where the version was accidentally committed as `0.1.0` instead of `1.0.0`
See #2918
|
| [5975]
|
netweb
|
Build Tools: Update `grunt-contrib-copy` from `0.8.0` to `1.0.0`
See #2918
|
| [5974]
|
netweb
|
Build Tools: Update `grunt-contrib-cssmin` from `0.6.0` to `1.0.0`
See #2918
|
| [5973]
|
netweb
|
Build Tools: Update `grunt-contrib-cssmin` from `0.13.0` to `1.0.0`
See #2918
|
| [5972]
|
netweb
|
Use HTTPS for w.org links
|
| [5971]
|
netweb
|
Users: The `user.js` file should have a blank newline at the end of file
Fixes #2907.
|
| [5970]
|
netweb
|
bbPress: Bumb readme.txt tested-up-to tags to 4.4.
|
| [5969]
|
netweb
|
API - Feeds: Use `feed_content_type( 'rss2' )` for RSS feeds.
This changeset updates the RSS 2 native mime type `application/rss+xml`, previously `rss-http` used `text/xml` which was removed from WordPress in [WP36230] and [WP32468].
Props thebrandonallen.
Fixes #2901.
|
| [5968]
|
netweb
|
Tests: Fix copy pasta class name in `@covers` annotation in `test_bbp_admin_repair_forum_topic_count()`
|
| [5967]
|
netweb
|
Tests: Use a category forum as the parent forum in `test_bbp_create_initial_content()` and add test assertions for this parent category forum.
|
| [5966]
|
netweb
|
Tests: Include missing forum meta from category forums added in r5965
|
| [5965]
|
netweb
|
Tests: Add a parent forum category for each test in `::BBP_Tests_Forums_Template_Forum_Last_Thing`
This changeset adds a parent category forum for each forum test to ensure hierarchal forum assertions are tested with parent/child forum relationships for the `bbp_get_forum_last_*()` template functions.
|
| [5964]
|
netweb
|
Tools: Add the `grunt-check-dependencies` npm module.
This changeset adds the Grunt task `checkDependencies` via https://www.npmjs.com/package/grunt-check-dependencies to check the currently npm installed modules against the required modules semantic version listed in `package.json`, if the check fails a prompt to update installed npm modules is displayed and is required before other Grunt tasks can be run.
Run `npm install` after updating your repo to install the module and task.
Props netweb.
Fixes #2893.
|
| [5963]
|
netweb
|
Tools: Update the `priority` array values of individual repair tools in `bbp_register_default_repair_tools()`
This changeset fixes an issue where the `bbp_admin_repair_topic_meta()` repair tool was not included in the list table.
Props netweb, thebrandonallen.
Fixes #2859.
|
| [5962]
|
netweb
|
Tests: Improved private and hidden status forum permalink tests in `test_bbp_get_forum_permalink()`
This changeset improves `test_bbp_get_forum_permalink()` tests by adding assertions for `private` and
`hidden` posts statuses with hierarchal nested forum URL's using `bbp_get_forum_permalink()`.
This regression was introduced with WordPress 4.4 in [wordpress:changeset:34001]
See: #WP35804
|
| [5961]
|
netweb
|
Build Tools: Add WordPress 4.4 to the Travis CI build matrix
|
| [5960]
|
netweb
|
Tools: Include `forum-mod` taxonomy code in `bbp_admin_reset_handler()`
This changeset adds support for deleting the forum moderator taxonomy when running the bbPress "Reset Forums" tool.
Props netweb.
Fixes #2898.
|
| [5959]
|
netweb
|
Tools: Travis CI: Only test PHP 7 against WordPress 4.3 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7 compatability, which was only added in version 4.3 so lets not let those errors in versions before 4.3 bother us ;)
See #2895.
|
| [5958]
|
netweb
|
Tools: Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds
PHP 7 was released today, congratulations to everyone involved in the release :)
Props netweb.
Fixes #2895.
|
| [5957]
|
netweb
|
Shortcodes: Fix `@return` type shring/string typo in `display_stats()`
|