| [5391]
|
johnjamesjacoby
|
Pass `$reply_id` into calls to `bbp_validate_reply_to()` and remove `reply_query` references in `BBP_Walker_Reply_Dropdown`. Fixes invalid `bbp_reply_id` value output in `form-reply.php`. See #2617.
|
| [5390]
|
johnjamesjacoby
|
Introduce `bbp_get_reply_ancestors()` function to help with reply hierarchy dropdown. Also conveniently wraps logic incase we ever move to a real hierarchical post type. See #2617.
|
| [5389]
|
johnjamesjacoby
|
Introduce `BBP_Walker_Reply_Dropdown` to help with reply hierarchy dropdown. Also update other Walker class extensions and associated documentation to be a bit more accurate and reliable. See #2617.
|
| [5388]
|
johnjamesjacoby
|
Tweak `bbp_get_dropdown()` to allow an array of custom posts to be used. See #2617.
|
| [5387]
|
johnjamesjacoby
|
Tweak `bbp_get_dropdown()` to allow an array of custom posts to be used. See #2617.
|
| [5384]
|
johnjamesjacoby
|
Update `grunt-wp-i18n` to 0.4.5. Fixes calls to `date()` for local installations without timezone identifiers.
|
| [5382]
|
johnjamesjacoby
|
Tag 2.5.4.
|
| [5381]
|
johnjamesjacoby
|
Bump remaining 2.5.3 references in 2.5 branch.
|
| [5380]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.4.
|
| [5379]
|
johnjamesjacoby
|
Bump stable tag and add 2.5.4 section to `readme.txt` (trunk)
|
| [5378]
|
johnjamesjacoby
|
Introduce `bbp_validate_reply_to()` function, used to:
* Validate a parent reply is actually a reply post_type.
* A reply is not accidentally assigning itself as its own parent.
* An integer is returned.
Fixes hiesenbug where calls to `bbp_get_reply_id()` were unexpectedly and occasionally returning the current reply ID rather than 0.
See #2588. (trunk)
|
| [5377]
|
johnjamesjacoby
|
Introduce `bbp_validate_reply_to()` function, used to:
* Validate a parent reply is actually a reply post_type.
* A reply is not accidentally assigning itself as its own parent.
* An integer is returned.
Fixes hiesenbug where calls to `bbp_get_reply_id()` were unexpectedly and occasionally returning the current reply ID rather than 0.
See #2588. (2.5 branch)
|
| [5376]
|
johnjamesjacoby
|
Clean up `bbp_get_reply_to()` to improve code readability. (2.5 branch)
|
| [5375]
|
johnjamesjacoby
|
Update reply position repair tool to delete invalid `_bbp_reply_to` fields, and tweak name and description. Props netweb. See #2588. (trunk)
|
| [5374]
|
johnjamesjacoby
|
Update reply position repair tool to delete invalid `_bbp_reply_to` fields, and tweak name and description. Props netweb. See #2588. (2.5 branch)
|
| [5373]
|
johnjamesjacoby
|
Remove extraneous validation in `bbp_get_form_reply_to()`. Fixes bug causing `_bbp_reply_to` field to be incorrectly set as the current `$reply_id` when editing a reply with no reply_to, which can lead to hierarchy issues. See #2586, #2588. (2.5 branch)
|
| [5372]
|
johnjamesjacoby
|
Remove extraneous validation in `bbp_get_form_reply_to()`. Fixes bug causing `_bbp_reply_to` field to be incorrectly set as the current `$reply_id` when editing a reply with no reply_to, which can lead to hierarchy issues. See #2586, #2588. (trunk)
|
| [5371]
|
johnjamesjacoby
|
Indentation clean-up and assignment clarifycation in `bbp_get_reply_to()`. See #2588.
|
| [5370]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_displayed_user_field()` function to handle the sanitizing of displayed user data, and add it to the `bbp_get_displayed_user_field` filter. Props mazengamal. See #2610 (2.5 branch).
|
| [5369]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_displayed_user_field()` function to handle the sanitizing of displayed user data, and add it to the `bbp_get_displayed_user_field` filter. Props mazengamal. See #2610 (trunk).
|
| [5368]
|
johnjamesjacoby
|
Update to tools:
* Update topic & reply count repair tools to only delete the appropriate meta keys from the appropriate parents.
* Include new reply hierarchy repair tool, to fix a possibly poisoned reply hierarchy.
Props netweb. See #2586 (trunk)
|
| [5367]
|
johnjamesjacoby
|
Update to tools:
* Update topic & reply count repair tools to only delete the appropriate meta keys from the appropriate parents.
* Include new reply hierarchy repair tool, to fix a possibly poisoned reply hierarchy.
Props netweb. See #2586 (2.5 branch)
|
| [5366]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_slug()` function for sanitizing permalink slugs, and use it as the callback for any slug settings. Props mazengamal. See #2496 (2.5 branch).
|
| [5365]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_slug()` function for sanitizing permalink slugs, and use it as the callback for any slug settings. Props mazengamal. See #2496 (trunk).
|
| [5364]
|
johnjamesjacoby
|
Remove text-zoom override from default responsive theme-compat styling (themes should have this covered.)
|
| [5363]
|
johnjamesjacoby
|
Whitespace cleanup to `Gruntfile.js`.
|
| [5361]
|
johnjamesjacoby
|
Missed a spot.
|
| [5360]
|
johnjamesjacoby
|
Revert indentation change in r5357. Props netweb. See: http://yaml.org/spec/1.2/spec.html#id2777534
|
| [5359]
|
johnjamesjacoby
|
Re-alphabetize grunt packages and update keywords in `package.json`.
|
| [5358]
|
johnjamesjacoby
|
Alphabetize grunt packages and update keywords in `package.json`.
|
| [5357]
|
johnjamesjacoby
|
Indent with tabs in `package.json`
|
| [5356]
|
johnjamesjacoby
|
Replace `function_exists()` checks with `is_callable()` in template stack functions. Props boonebgorges. See: http://buddypress.trac.wordpress.org/ticket/5671
|
| [5355]
|
johnjamesjacoby
|
In template stack functions, wrap `function_exists()` checks with `is_array()` check. Allows class methods to be used as template stack locations. See: https://buddypress.trac.wordpress.org/ticket/5671
|
| [5351]
|
johnjamesjacoby
|
Use correct `word-wrap` CSS property in `templates/default/bbpress.css`. Fixes problem with long author-names not wrapping correctly.
|
| [5345]
|
johnjamesjacoby
|
Add license definition to plugin headers.
|
| [5341]
|
johnjamesjacoby
|
Bump tested-up-to version to 3.9. (2.5 branch)
|
| [5340]
|
johnjamesjacoby
|
Bump tested-up-to version to 3.9. (trunk)
|
| [5338]
|
johnjamesjacoby
|
When calculating a new reply position, ensure we are using raw, unformatted integers. Fixes bug where formatted numeric strings (I.E. with commas; eg: 1,532) were being passed to the `menu_order` property, causing broken pagination on topics with over 1k replies. Fixes #2556.
|
| [5337]
|
johnjamesjacoby
|
Add `overflow-x: auto` styling to `code` and `pre` tags, to allow very long single lines of code to wrap without breaking outside of the bounding box.
|
| [5335]
|
johnjamesjacoby
|
More specific CSS selector on closed topics to only target lists of topics, not single topic views. See r2962.
|
| [5334]
|
johnjamesjacoby
|
Improve output of `grunt jshint` task. See #2578.
|
| [5331]
|
johnjamesjacoby
|
Fix incorrect phpdoc in users functions.
|
| [5330]
|
johnjamesjacoby
|
Remove stray semi-colon.
|
| [5329]
|
johnjamesjacoby
|
Add `separate_items_with_commas` string in `bbp_get_topic_tag_tax_labels()`.
|
| [5325]
|
johnjamesjacoby
|
Use `basename` instead of `file` in plugin action links. Props DJPaul. Fixes #2567.
|
| [5324]
|
johnjamesjacoby
|
Add missing `forum.js`. Props SGr33n. Fixes #2568.
|
| [5322]
|
johnjamesjacoby
|
Add `NUMERIC` type hinting to view queries. Props netweb. Fixes #2554.
|
| [5321]
|
johnjamesjacoby
|
Remove `akismet_microtime()` usage as it's been removed from Akismet's development branch.
|
| [5320]
|
johnjamesjacoby
|
Remove `akismet_test_mode()` usage as it's been removed from Akismet's development branch.
|
| [5318]
|
johnjamesjacoby
|
Add screenshots to `readme.txt`. Props netweb. See #2555.
|
| [5317]
|
johnjamesjacoby
|
Don't allow `build` or `src` in `basename` in `bbPress:setup_globals()`. Fixes problems with activation hooks. Fixes #2559. Props DJPaul.
|
| [5316]
|
johnjamesjacoby
|
Fix basename filter in `bbPress:setup_globals()`. Props DJPaul.
|
| [5315]
|
johnjamesjacoby
|
Set `is_tax` to true when calling `bbp_theme_compaty_reset_post()` when viewing/editing a topic-tag. Fixes #2444.
|
| [5314]
|
johnjamesjacoby
|
Add contextual help for admin Tools. Props netweb. Fixes #1920.
|
| [5313]
|
johnjamesjacoby
|
Allow closed topics to be split and merged into. Props netweb. Fixes #1714.
|
| [5312]
|
johnjamesjacoby
|
Use 'array_diff()` rather than `array_intersect()` in `bbp_pre_get_posts_normalize_forum_visibility()` to allow custom `post_type` queries (that still include forums/topics/replies) to pass through without hidden/private forum `meta_data` assistance. Fixes #2471.
|
| [5311]
|
johnjamesjacoby
|
Use correct uppercase type hinting for forum meta queries.
|
| [5310]
|
johnjamesjacoby
|
Allow topic-tag descriptions to be edited theme-side. Props netweb. Fixes #1613.
|
| [5309]
|
johnjamesjacoby
|
Introduce topic & reply counts for users:
* New functions for updating user options.
* New action hooks for bumping existing counts on CRUD actions.
* Uses existing `_raw` functions when no counts are previously found to incrementally update missing meta values.
* Tool for updating topic & reply counts already exists.
* Props netweb, MZAWeb, anointed.
* Fixes #1694.
|
| [5308]
|
johnjamesjacoby
|
Don't copy Sass files (or any other excluded files) into `/build` directory. Props netweb. See #2542.
|
| [5307]
|
johnjamesjacoby
|
Remove the now-empty `includes/admin/images` directory. Props netweb. See #2542.
|
| [5304]
|
johnjamesjacoby
|
Use correct filter name in `bbp_get_forum_slug()`. Props netweb. Fixes #2525.
|
| [5303]
|
johnjamesjacoby
|
Add actions before & after register template part fieldset fields. Fixes #2534.
|
| [5302]
|
johnjamesjacoby
|
Add `meta_type` to extra page template: `page-topics-no-replies.php`. See #2554.
|
| [5301]
|
johnjamesjacoby
|
Add `meta_type` hinting to `bbp_move_reply_handler()`. See #2554.
|
| [5300]
|
johnjamesjacoby
|
Add `meta_type` hinting to admin queries. See #2554.
|
| [5299]
|
johnjamesjacoby
|
Add `meta_type` hinting to `bbp_update_forum_last_topic_id()`. See #2554.
|
| [5298]
|
johnjamesjacoby
|
Add `meta_type` hinting to topics queries. See #2554.
|
| [5297]
|
johnjamesjacoby
|
Add `meta_type` hinting to widget queries. See #2554.
|
| [5293]
|
johnjamesjacoby
|
More Grunt updates:
* Add `_n_noop` to `grunt-pot` keyword check
* Remove grunt task `test` as PHPUnit tests are covered by grunt task `phpunit`
* Add grunt task `jstest` to run javascript tasks
* Add `grunt-checktextdomain` to `package.json` to check for missing or incorrect text-domain in gettext functions. See https://www.npmjs.org/package/grunt-checktextdomain
* Adds grunt task `checktextdomain` to `grunt build-release`
* Checks for the following keywords: `__:1,2d`, `_e:1,2d`, `_x:1,2c,3d`, `_n:1,2,4d`, `_ex:1,2c,3d`, `_nx:1,2,4c,5d`, `esc_attr__:1,2d`, `esc_attr_e:1,2d`, `esc_attr_x:1,2c,3d`, `esc_html__:1,2d`, `esc_html_e:1,2d`, `esc_html_x:1,2c,3d`, `_n_noop:1,2,3d`, `_nx_noop:1,2,3c,4d`
* Props netweb. See #2542.
|
| [5292]
|
johnjamesjacoby
|
Remove `colors-fresh` dependency for admin color schemes. !WordPress 3.9's CSS cleanup initiatives have rendered this code unnecessary. Hat tip helen.
|
| [5290]
|
johnjamesjacoby
|
Experiment with `grunt-pot`:
* Add `grunt-pot` to `package.json`
* Adds grunt task `pot` to `grunt build` and `grunt build-release`
* Creates `bbpress.pot` in `/build` & removes `bbpress.pot` from `/src`
* Checks for the following keywords: `__`, `_e`, `_x`, `_n`, `_ex`, `_nx`, `esc_attr__`, `esc_attr_e`, `esc_attr_x`, `esc_html__`, `esc_html_e`, `esc_html_x`, `_nx_noop`
* Props netweb. See #2542.
|
| [5289]
|
johnjamesjacoby
|
More grunt updates:
* Add RTL, minified and `SCRIPT_DEBUG` support for bbPress admin CSS.
* Add RTL, minified and `SCRIPT_DEBUG` support for bbPress default theme-compat CSS.
* RTL bbPress CSS is now compiled with cssjanus. (`bbpress-rtl.css` file removed)
* Props netweb. See #2542.
|
| [5288]
|
johnjamesjacoby
|
Add XML output logging for PHPUnit tests. Props netweb. See #2542.
|
| [5287]
|
johnjamesjacoby
|
Fixes PHPUnit Multisite tests and sets up grunt build-realease to run all PHPUnit tests when building release package (Single & Multisite.) Props netweb. See #2542.
|
| [5286]
|
johnjamesjacoby
|
Smarter build/src toggling for the stub plugin. See #2542.
|
| [5285]
|
johnjamesjacoby
|
More Grunt improvements:
* Fixes CSS & JS admin folder path for `BBP_RTL_CSS`, `BBP_LTR_CSS` & `BBP_JS` in Gruntfile.js
* Removes Mint & Evergreen CSS (including RTL) to use Mint & Evergreen SCSS
* Adds `_admin.scss`, `_mixins.scss`, `_variables.scss` via ([https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/colors /trunk/src/wp-admin/css/colors]) to build our Mint & Evergreen admin themes
* Adds `/includes/admin/styles/evergreen/colors.scss` & `/includes/admin/styles/mint/colors.scss` via [https://github.com/ryelle/admin-color-schemes/tree/2288dcd5b57c9a9045de62d1cfa72722d5163cfc 2288dcd5b5 MP6 GitHub Repo Changset]
* Adds support in Gruntfile.js to build minified and RTL Mint & Evergreen CSS
* Adds `grunt-sass` `~0.10.0` to `package.json` to build Mint & Evergreen CSS from SCSS source
* Reinstates minified and `SCRIPT_DEBUG` support for minified Mint & Evergreen CSS
* Adds minified and `SCRIPT_DEBUG` support for admin javascript & frontend javascript
Props netweb. See #2542.
|
| [5283]
|
johnjamesjacoby
|
In `bbp_locate_template()` check for `WP_USE_THEMES` before calling `load_template()` to avoid warnings when running phpunit tests. See #2542.
|
| [5282]
|
johnjamesjacoby
|
Add `build` directory to `svn:ignore`. Props netweb. See #2542.
|
| [5281]
|
johnjamesjacoby
|
Update inline doc in `.gitignore`. See #2542.
|
| [5280]
|
johnjamesjacoby
|
Update phpunit testcases directory path in `phpunit.xml`. See #2542.
|
| [5279]
|
johnjamesjacoby
|
Update bootstrap path in `bootstrap.php` for phpunit testing. See #2542.
|
| [5276]
|
johnjamesjacoby
|
Remove duplicate testcases directory from previous merge. See #2542.
|
| [5275]
|
johnjamesjacoby
|
Put back root files from previous reorg revert. See #2542.
|
| [5274]
|
johnjamesjacoby
|
Move `includes` and `templates` back into `/src` directory. See #2452.
|
| [5273]
|
johnjamesjacoby
|
Revert r5270, r5271. Let's try to get our history back. Antiprops johnjamesjacoby.
|
| [5272]
|
johnjamesjacoby
|
Don't ignore Travis or JSHint configuration files, and add them to root. See #2542.
|
| [5271]
|
johnjamesjacoby
|
Gruntify bbPress trunk (part 2):
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542.
|
| [5270]
|
johnjamesjacoby
|
Gruntify bbPress trunk:
* Move bbPress core files into `/src`
* Move tests into `/tests/phpunit/`
* Move `phpunit.xml` into trunk root
* Introduce Grunt and Travis configuration files
* Introduce stub `bbpress.php` to help activate bbPress for existing trunk checkouts
* See #2542.
|
| [5269]
|
johnjamesjacoby
|
Improve naming of new "At a Glance" metabox filter, and lower priority to increase odds of hugging more closely to WordPress core items. See #2544.
|
| [5268]
|
johnjamesjacoby
|
Deprecate dashboard metabox, and append forum statistics to existing "At a Glance" metabox instead. Fixes #2544.
|
| [5267]
|
johnjamesjacoby
|
Fix relative path to unit test bootstrap. See #2542.
|
| [5266]
|
johnjamesjacoby
|
First pass at unit test suite. Props netweb. See #2542.
|
| [5264]
|
johnjamesjacoby
|
Fix `@since` PHPDoc for Drupal7 converter. Props netweb. Fixes #2521. (trunk)
|
| [5263]
|
johnjamesjacoby
|
Fix `@since` PHPDoc for Drupal7 converter. Props netweb. Fixes #2521. (2.5 branch)
|
| [5262]
|
johnjamesjacoby
|
Use `content_url()` rather than `WP_CONTENT_URL` for style and script enqueue functions, fixing insecure content warnings when using SSL theme-side. Props tonyrix. Fixes #2518. (2.5 branch)
|
| [5261]
|
johnjamesjacoby
|
Use `content_url()` rather than `WP_CONTENT_URL` for style and script enqueue functions, fixing insecure content warnings when using SSL theme-side. Props tonyrix. Fixes #2518. (trunk)
|
| [5260]
|
johnjamesjacoby
|
Refactor subscription notifications functions to send 1 email with all subscribers BCC'd rather than 1 email per subscriber. This speeds up posting significantly in forums or topics where there are any number of subscribers, particularly on configurations with slow email servers or when using external email services.
(Subscription notifications could be improved further in a future iteration by moving the actual sending into a `wp_cron` process, but this improvement is easy and significant enough where it will be sufficient for the widest audience.)
Hat tip netweb, rossagrant. Fixes #2162. (trunk)
|
| [5259]
|
johnjamesjacoby
|
Subscriptions clean-up, from r5258. Props netweb. See #2162. (2.5 branch)
|
| [5258]
|
johnjamesjacoby
|
Refactor subscription notifications functions to send 1 email with all subscribers BCC'd rather than 1 email per subscriber. This speeds up posting significantly in forums or topics where there are any number of subscribers, particularly on configurations with slow email servers or when using external email services.
(Subscription notifications could be improved further in a future iteration by moving the actual sending into a `wp_cron` process, but this improvement is easy and significant enough where it will be sufficient for the widest audience.)
Hat tip netweb, rossagrant. Fixes #2162.
|