| [5771]
|
johnjamesjacoby
|
Set `svn-autoprops`.
This was introduced in Subversion 1.8 specifically to allow common properties for all present and future files in the project, and avoids setting individual properties on most files and prevents errors from skipping properties when new files are introduced.
Hat-tip DJPaul. See r5770, #2802.
|
| [5770]
|
johnjamesjacoby
|
Tidy up SVN properties.
* This first steps removes `svn:eol-style`, `svn:executable`, `svn:mime-type` on all files.
* The `svn:ignore` and `svn:global-ignores` properties have been tidied up to match WordPress core.
* A subsequent commit will re-instate `svn:mime-type` via `svn:auto-props`.
Hat-tip DJPaul. See #2802.
|
| [5739]
|
johnjamesjacoby
|
Common: Improve type-casting return values in query functions.
Props thebrandonallen, netweb. See #2801.
|
| [5738]
|
johnjamesjacoby
|
Topics: Improve type-casting in topic functions.
Props thebrandonallen, netweb. See #2801.
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5736]
|
johnjamesjacoby
|
Core: Correct phpdoc to `_update_` functions. Also introduce `bbp_update_reply_to_id()` to help with saving of hierarchical reply metadata. (Will be used in a future commit.)
|
| [5735]
|
johnjamesjacoby
|
Core: Return the filtered results of ID's in core `_update_` functions.
This helps with various type-casting improvements going into #2801.
|
| [5734]
|
johnjamesjacoby
|
Forums: Type-cast improvements to `bbp_forum_query_last_reply_id()`.
Fixes bug where strict `false` comparison would cache cache condition to never occur.
Props thebrandonallen, netweb. See #2801.
|
| [5733]
|
johnjamesjacoby
|
Core: Force-clear post caches on several common moderation actions.
Fixes inconsistencies around cached objects related to counts, which are currently stored in metadata.
Props thebrandonallen, netweb. See #2801.
|
| [5732]
|
johnjamesjacoby
|
Bumps: Normalize type-casting in bump functions.
Props thebrandonallen, netweb. See #2801.
|
| [5731]
|
johnjamesjacoby
|
Forums: Normalize type-casting in some count functions. More to do here.
Props thebrandonallen, netweb. See #2801.
|
| [5730]
|
johnjamesjacoby
|
Common: Additional type-casting in query functions.
Ensures direct query results return a consistent, testable value.
Props thebrandonallen, netweb. See #2801.
|
| [5729]
|
johnjamesjacoby
|
Topics: In `bbp_move_topic_handler()`, clean both old and new forum caches before updating forum hierarchies.
Fixes issue where moving a topic would result in incorrect counts for both forums, due to out-of-date cache values.
Props thebrandonallen. Fixes #2322.
|
| [5711]
|
johnjamesjacoby
|
Common: Use `esc_url()` in `bbp_redirect_to_field()` and late escape for clarity.
|
| [5709]
|
johnjamesjacoby
|
Topics: Filter `bbp_get_forum_topic_count_hidden` to format the output, to match other count functions.
|
| [5708]
|
johnjamesjacoby
|
Tests: Fix more of the tests. See r5703.
|
| [5706]
|
johnjamesjacoby
|
Tests: Fix all of the tests but 2, which are todo's. See r5703.
|
| [5705]
|
johnjamesjacoby
|
Topics: Check for correct `$integer` request value, so the correct filter is applied. Fixes #2791.
|
| [5698]
|
johnjamesjacoby
|
Update `get` version of `wp_login_action`.
|
| [5697]
|
johnjamesjacoby
|
Tag 2.5.7 from 2.5 branch.
|
| [5696]
|
johnjamesjacoby
|
Include `2.5.7` in `readme.txt` changelog (for trunk) and bump stable tag
|
| [5695]
|
johnjamesjacoby
|
Update `bbpress.pot` in 2.5 branch.
|
| [5694]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.7
|
| [5693]
|
johnjamesjacoby
|
All: ensure all URLs are escaped part 2 (2.5 branch)
|
| [5692]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (2.5 branch)
|
| [5691]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (trunk) and cleanup some phpdoc
Also introduce `bbp_dropdown` class for dropdowns.
|
| [5689]
|
johnjamesjacoby
|
Templates: Micro-optimizations:
* Remove trailing `?>` tag in some template parts
* Remove preceding `?> <?php` in some template parts, after phpdoc header
* Remove whitespace where superfluous
* Reduce number of indentations in some template parts
|
| [5688]
|
johnjamesjacoby
|
Templates: Escape all gettext output in `default` template parts. See #1999.
|
| [5685]
|
johnjamesjacoby
|
Common: Login actions:
* Extract functionality from `bbp_wp_login_action()` into a getter: `bbp_get_wp_login_action()`
* Update arguments in`bbp_get_wp_login_action()` to include optional `url` override
* Pass original `$args` into login action filter
* Also improve support for empty separator in breadcrumbs
|
| [5684]
|
johnjamesjacoby
|
General: Use `sanitize_text_field()` in lieu of old-bbPress style pre-escaping technique.
|
| [5683]
|
johnjamesjacoby
|
Forums: Audit `template.php`:
* General code formatting improvements
* Pass `$args` into more filters
* Escape more gettext output
* Un-nest a few complex-looking lines
|
| [5682]
|
johnjamesjacoby
|
Topics: Move `is_sticky` functions to above open/closed functions
|
| [5681]
|
johnjamesjacoby
|
Topics: Use `sanitize_key()` on `select_id` in dropdown helpers.
|
| [5680]
|
johnjamesjacoby
|
Topics: Audit `template.php`:
* Add filters to `is_sticky` functions
* Pass `$args` into more filters
* Escape more gettext output
* Fix a few `bbp_parse_args` filter names copied from forums component
* Un-nest a few complex-looking lines
|
| [5676]
|
johnjamesjacoby
|
All: Update default values for `$args` parameters from empty strings to empty arrays.
This is a micro-optimization to avoid unnecessary calls to `wp_parse_str()` inside `bbp_parse_args()`.
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [5674]
|
johnjamesjacoby
|
Topics: Normalize admin links:
* Remove superfluous `(int)` type cast
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
|
| [5666]
|
johnjamesjacoby
|
Users: Add missing textdomains to new strings. See #2780.
|
| [5665]
|
johnjamesjacoby
|
Users: Update filter name in `bbp_edit_user_email_send_notification()` to be a bit more clear. See #2780.
|
| [5664]
|
johnjamesjacoby
|
Users: Clean up email message string replacements in `bbp_edit_user_email_send_notification()`. See #2780.
|
| [5663]
|
johnjamesjacoby
|
Users: Email address change improvements:
* Introduce function for handling sending notification email
* Clean up code required to update, save, confirm, & dismiss pending email address changes
* Fixes bug in previous implementation making it impossible to interact with pending email address changes on multisite installations
Fixes #2780.
|
| [5662]
|
johnjamesjacoby
|
Users: Extract `$_GET` conditions out of `bbp_edit_user_handler()` and into their own function, hooked to `bbp_get_request` action.
This fixes functionality that was only half ported from `edit_user()` & WordPress multisite which allows a user to confirm or dismiss pending email address changes to their account from within their bbPress profile edit page.
See #2780.
|
| [5661]
|
johnjamesjacoby
|
Users: Introduce `bbp_notice_edit_user_email_change()` to notify user of a pending email address change to their account. See #2780.
|
| [5660]
|
johnjamesjacoby
|
Users: Remove pending email change markup from `form-user-edit.php`. See #2780.
|
| [5659]
|
johnjamesjacoby
|
API: Add more context to`bbp_redirect()` documentation. See #2778.
|
| [5658]
|
johnjamesjacoby
|
API: Introduce `bbp_redirect()`
* Wraps `wp_safe_redirect()` & `exit()` calls
* Prevents errors from potentially empty `wp_get_referrer()` results
* Replace `wp_safe_redirect()` usages with `bbp_redirect()`
Fixes #2778.
|
| [5657]
|
johnjamesjacoby
|
Users: Update `bbp_check_user_edit()`:
* Update `@uses` in docblock
* Add filters to allow overriding result & redirect_to URL
* Bail instead of indent
* Move `bbp_get_displayed_user_id()` into reusable variable
Fixes #2777.
|
| [5647]
|
johnjamesjacoby
|
Tag 2.5.6 (from 2.5 branch)
|
| [5646]
|
johnjamesjacoby
|
Update `bbpress.pot` (2.5 branch)
|
| [5645]
|
johnjamesjacoby
|
Include `2.5.6` changelog entry in `readme.txt`. (trunk)
|
| [5644]
|
johnjamesjacoby
|
Bump 2.5 branch version to `2.5.6`. Include `2.5.6` changelog entry in `readme.txt`.
|
| [5643]
|
johnjamesjacoby
|
Backport `do_not_reply` email address code from trunk to 2.5 branch (for what will be 2.5.6.) See #2618, r5642.
|
| [5642]
|
johnjamesjacoby
|
Update `bbp_get_do_not_reply_address()` to use `$_SERVER['SERVER_NAME']` over `get_home_url()` to improve compatibility with mapped domains and more complex installations. See #2618 (trunk)
|
| [5641]
|
johnjamesjacoby
|
Code Improvement:
* Add `$Id$` Subversion keyword property to `/src/bbpress.php`.
* Hat tip netweb. See #1851.
|
| [5638]
|
johnjamesjacoby
|
Bye. Props djpaul. See #2771 (2.5 branch)
|
| [5637]
|
johnjamesjacoby
|
Update any relevant hardcoded links to https.
|
| [5636]
|
johnjamesjacoby
|
Bye. Props djpaul. See #2771 (trunk)
|
| [5633]
|
johnjamesjacoby
|
Update readme.txt for 2.5.5.
|
| [5632]
|
johnjamesjacoby
|
Update `bbpress.pot` for 2.5.5 release. (2.5 branch)
|
| [5631]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.5.
|
| [5630]
|
johnjamesjacoby
|
Add capability checks to admin-area ajax methods, and port nonce checks & js from trunk. Props jdgrimes. (2.5 branch)
|
| [5629]
|
johnjamesjacoby
|
Add nonce to bulk-user dropdown. Props jdgrimes. (2.5 branch)
|
| [5628]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (2.5 branch)
|
| [5627]
|
johnjamesjacoby
|
Add capability checks to admin-area ajax methods. Props jdgrimes. (trunk)
|
| [5626]
|
johnjamesjacoby
|
Add nonce to bulk-user dropdown. Props jdgrimes. (trunk)
|
| [5625]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (trunk)
|
| [5624]
|
johnjamesjacoby
|
Update NPM Grunt packages:
* Replace "Community" with "Contributors"
* Remove `grunt-banner` as it is no longer used
* `grunt-cssjanus` v0.2.3
* `grunt-sass` v018.0
See #2766.
|
| [5618]
|
johnjamesjacoby
|
Update `bbp_setup_current_user()` to avoid output in WordPress Customizer. Fixes #2309. See #WP24169.
|
| [5614]
|
johnjamesjacoby
|
Bring `Gruntfile.js` tasks up to speed with BuddyPress.
|
| [5613]
|
johnjamesjacoby
|
In `bbp_notify_forum_subscribers()` remove incorrect array assignment. Fixes bug where `$headers` would be a multidimensional array, causing `wp_mail()` to complain.
|
| [5612]
|
johnjamesjacoby
|
Update readme.txt:
* Modernize verbiage
* Split up `Installation` section for clarity
* Switch links to use `example.com`
* Update tested version to 4.1
* Fix speeling errors
|
| [5611]
|
johnjamesjacoby
|
Check for `IXR_Value` class before including BackPress's version.
Avoids collisions when deeply integrated with WordPress.
For 1.1 & 1.2 branches.
|
| [5610]
|
johnjamesjacoby
|
Port PHPUnit testing setup from BuddyPress. More to clean up here later.
Also adds 1 test to check for `bbpress()` function availability.
See #2542.
|
| [5609]
|
johnjamesjacoby
|
In `bbp_current_author_ip()` check `$_SERVER['REMOTE_ADDR']` before attempting to parse it.
If it is empty (more likely for unit tests, but could be other oddities) we set it to '0.0.0.0' to do two things:
* Indicate to keymasters that something is amiss
* Allow `bbp_current_author_ip()` to proceed normally for the end-user
Fixes #2750.
|
| [5608]
|
johnjamesjacoby
|
Prevent notices and warnings when template stack is empty. Fixes #2749.
|
| [5607]
|
johnjamesjacoby
|
In `bbp_version_updater()` only run update routines if a previous installation exists to update. Fixes #2748.
|
| [5606]
|
johnjamesjacoby
|
Fix notice in bozo plugin. For 1.2 branch. See r5598.
|
| [5605]
|
johnjamesjacoby
|
Avoid notices in bbPress's Akismet plugin. For 1.2 branch. See r5597.
|
| [5604]
|
johnjamesjacoby
|
`Call bb_get_user()` from `bb_get_user_by_nicename()`. For 1.2 branch. See r5595.
|
| [5603]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.2 branch)
|
| [5602]
|
johnjamesjacoby
|
Revert accidental line-change from r5601, #2747.
|
| [5601]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.1 branch)
|
| [5596]
|
johnjamesjacoby
|
Check that `user_url` exists before attempting to allow it in max-links.
|
| [5594]
|
johnjamesjacoby
|
s/POST/GET/ from r5587. See #2742.
|
| [5593]
|
johnjamesjacoby
|
Cast value as `(int)` in `bbp_get_form_forum_parent()`, ensuring it is numerical for the remaining call stack. See #2742.
|
| [5592]
|
johnjamesjacoby
|
Use `sanitize_key()` in `forums/template.php` to ensure values are within expected boundaries. See #2742.
|
| [5591]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_profile_update_role()` to ensure role value is within expected boundaries. See #2742.
|
| [5590]
|
johnjamesjacoby
|
Use `sanitize_user()` in `bbp_user_maybe_convert_pass()` to ensure user login is within expected boundaries. See #2742.
|
| [5589]
|
johnjamesjacoby
|
Use `sanitize_key()` in `topics/functions.php` to ensure values are within expected boundaries. See #2742.
|
| [5588]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_get_form_reply_status_dropdown()` to ensure value is within expected boundaries. See #2742.
|
| [5587]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_post_request()` and `bbp_get_request()`, improving the predictability of possible actions. See #2742.
|
| [5583]
|
johnjamesjacoby
|
Administrative support for for un/approving topics.
Props netweb, thebrandonallen. Fixes #2645.
|
| [5567]
|
johnjamesjacoby
|
Bump alpha version in bbpress.php to latest revision.
|
| [5566]
|
johnjamesjacoby
|
Add nonce checks to admin area topic & author suggest usages.
|
| [5565]
|
johnjamesjacoby
|
Add `'suggest'` to `replies` script prerequisites.
|
| [5564]
|
johnjamesjacoby
|
Add `'suggest'` to `common` script prerequisites.
|
| [5563]
|
johnjamesjacoby
|
Convert template notices from paragraph tags to unordered lists.
Improves accessibility by hinting there may be several notices on the page.
Props Karl Groves, netweb. FIxes #2637.
|
| [5562]
|
johnjamesjacoby
|
Missed removing a tabindex usage. See #2714.
|
| [5561]
|
johnjamesjacoby
|
Deprecate `tabindex` functions and their usages. Props joedolson. Fixes #2714.
|
| [5560]
|
johnjamesjacoby
|
Match up arguments with parent class method to avoid notices. Props boonebgorges. Fixes #2718.
|