| [7088]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In trunk, for 2.7.0.
|
| [7087]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In branches/2.6, for 2.6.5.
See #3157.
|
| [7086]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In trunk, for 2.7.0.
See #3157.
|
| [7085]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In branches/2.6, for 2.6.5.
See #3374.
|
| [7084]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In trunk, for 2.7.0.
See #3374.
|
| [7083]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In trunk, for 2.7.0.
See #3371.
|
| [7082]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In 2.6 branch, for 2.6.5.
See #3371.
|
| [7081]
|
johnjamesjacoby
|
Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In branches/2.6, for 2.6.5.)
Fixes #3373.
|
| [7080]
|
johnjamesjacoby
|
Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In trunk, for 2.7.0.)
Fixes #3373.
|
| [7079]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7078]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7077]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
Fixes #3357. 2.6 branch, for 2.6.5.
|
| [7076]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
See #3357. Trunk, for 2.7.0.
|
| [7075]
|
johnjamesjacoby
|
Dependencies: routine updating of node dependency tree.
|
| [7074]
|
johnjamesjacoby
|
Dependencies: routine updating of node dependency tree.
|
| [7073]
|
johnjamesjacoby
|
Theme Compat: conditionally unhook adjacent posts.
This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value.
Props r-a-y. For 2.6.15, branches/2.6.
|
| [7072]
|
johnjamesjacoby
|
Theme Compat: conditionally unhook adjacent posts.
This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value.
Props r-a-y. For 2.6.15, branches/2.6.
|
| [7071]
|
johnjamesjacoby
|
Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.6.15, branches/2.6.
|
| [7070]
|
johnjamesjacoby
|
Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.7, trunk.
|
| [7069]
|
johnjamesjacoby
|
Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.7, trunk.
|
| [7068]
|
johnjamesjacoby
|
Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.6.15, branches/2.6.
|
| [7067]
|
johnjamesjacoby
|
Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.6.15, branches/2.6.
|
| [7066]
|
johnjamesjacoby
|
Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.7, trunk.
|
| [7065]
|
johnjamesjacoby
|
Bump stable tag in trunk 2.6.4, and also update an node dependency.
|
| [7064]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.5-alpha-1.
|
| [7063]
|
johnjamesjacoby
|
Tag 2.6.4 from 2.6 branch.
|
| [7062]
|
johnjamesjacoby
|
Bump /src/bbpress.php plugin header to 2.6.4.
|
| [7061]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.4.
|
| [7060]
|
johnjamesjacoby
|
BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.7, trunk
|
| [7059]
|
johnjamesjacoby
|
BuddyPress: explicitly validate IDs when editing Group forum topics & replies.
This commit adds methods to validate that the forum IDs and reply-to IDs for topics & replies are within the accepted ranges for the specific Group Forum they are being edited inside of.
In addition, the `moderate_forum` mapped meta capability is removed, and the broader `moderate` capability will continue to cover its use case. This capability was not intended to be used directly, and doing so incorrectly would trigger unintended and infinite recursion.
For 2.6.14, branches/2.6
|
| [7058]
|
johnjamesjacoby
|
BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.6.14, branches/2.6
|
| [7057]
|
johnjamesjacoby
|
BuddyPress: explicitly query for Group forum IDs, for topic parent dropdown.
This commit fixes an ambiguity regarding which forum IDs should/may appear when editing a Forum Topic inside a Group Forum. By being explicit here, a possible bug can be avoided where incorrect forum IDs could be listed.
Props imath. For 2.7, trunk.
|
| [7055]
|
johnjamesjacoby
|
General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.7, trunk.
|
| [7054]
|
johnjamesjacoby
|
General: add support for `include` attribute in `bbp_dropdown()`.
Props imath. For 2.6.4, branches/2.6.
|
| [7053]
|
johnjamesjacoby
|
General: fix a few typos.
Props ankitmaru, mukesh27. Fixes #3312, #3313, #3315. For 2.7, trunk.
|
| [7052]
|
johnjamesjacoby
|
Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.6.4, branches/2.6.
|
| [7051]
|
johnjamesjacoby
|
Forums: Code improvement to `bbp_list_forums()`.
This commit loosens the comparison on the `echo` array parameter into an `empty()` check, which will silence any debug notices that may happen if `bbp_after_list_forums_parse_args` is filtered to remove it.
Props Toengel. Fixes #3314. For 2.7, trunk.
|
| [7037]
|
johnjamesjacoby
|
Strings: improve consistency of "ERROR" messaging.
This commit moves a few colons from within their respective `<strong>` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.7, trunk.
|
| [7036]
|
johnjamesjacoby
|
Strings: improve consistency of "ERROR" messaging.
This commit moves a few colons from within their respective `<strong>` tag to outside of them, making them consistent with a few dozen other usages.
Props casiepa. Fixes #3302. For 2.6.4, branches2.6.
|
| [7035]
|
johnjamesjacoby
|
Bump package version.
|
| [7034]
|
johnjamesjacoby
|
Make CSS linter happy again.
|
| [7033]
|
johnjamesjacoby
|
Make CSS linter happy again.
|
| [7032]
|
johnjamesjacoby
|
Users: move `_new_email` from options to usermeta.
This commit brings bbPress up-to-date with how WordPress tracks changes to email addresses. It includes a small bit of styling to add emphasis to the email address inside the standard notice wrapper.
See #3306. For 2.7, trunk.
|
| [7031]
|
johnjamesjacoby
|
Users: move `_new_email` from options to usermeta.
This commit brings bbPress up-to-date with how WordPress tracks changes to email addresses. It includes a small bit of styling to add emphasis to the email address inside the standard notice wrapper.
See #3306. For 2.6.4, branches/2.6.
|
| [7030]
|
johnjamesjacoby
|
Users: ensure topic & reply counts and last posted time are updated when user is spammed & hammed.
This commit ensures that these user meta values are correct when a user is marked (or unmarked) as a spammer. In addition, the newer topic status function is used to ensure that Closed topics are included.
See #3305. For 2.6.4, branches/2.6.
|
| [7029]
|
johnjamesjacoby
|
Users: ensure topic & reply counts and last posted time are updated when user is spammed & hammed.
This commit ensures that these user meta values are correct when a user is marked (or unmarked) as a spammer. In addition, the newer topic status function is used to ensure that Closed topics are included.
See #3305. For 2.7, trunk.
|
| [7028]
|
johnjamesjacoby
|
Users: register the `_bbp_last_posted` meta key.
This commit ensures that the meta key used to check if a user needs to be slowed down is registered.
See #3305. For 2.7, trunk.
|
| [7027]
|
johnjamesjacoby
|
Users: register the `_bbp_last_posted` meta key.
This commit ensures that the meta key used to check if a user needs to be slowed down is registered.
See #3305. For 2.6.4, branches/2.6.
|
| [7026]
|
johnjamesjacoby
|
Engagements: update cache groups in User strategy.
This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.
See #3292. For 2.6.4, branches/2.6.
|
| [7025]
|
johnjamesjacoby
|
Engagements: update cache groups in User strategy.
This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.
See #3292. For 2.7, trunk.
|
| [7024]
|
johnjamesjacoby
|
Engagements: fix bugs with caching implementation in User strategy.
This commit adds the `$object_id` to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit `true` comparisons because internal calls to `update_meta()` up the stack may return an integer.
See #3292. For 2.7, trunk.
|
| [7023]
|
johnjamesjacoby
|
Engagements: fix bugs with caching implementation in User strategy.
This commit adds the `$object_id` to the end of the cache key, to avoid collisions with other IDs. It also loosens 2 explicit `true` comparisons because internal calls to `update_meta()` up the stack may return an integer.
See #3292. For 2.6.4, branches/2.6.
|
| [7022]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.4-alpha-1.
|
| [7021]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7020]
|
johnjamesjacoby
|
Set stable tag in readme.txt to 2.6.3.
|
| [7019]
|
johnjamesjacoby
|
Tag 2.6.3.
|
| [7018]
|
johnjamesjacoby
|
Remove alpha designation from 2.6 branch, for 2.6.3.
|
| [7017]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.7, trunk.
|
| [7016]
|
johnjamesjacoby
|
Requirements: bump PHP version to 5.6.20.
This commit adds support for the "Requires PHP" readme tag, and also bumps the version for Composer.
Props jrf. Fixes #3298. For 2.6.3, branches/2.6.
|
| [7015]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.7, trunk.
|
| [7014]
|
johnjamesjacoby
|
Converters: PHP7.4 code compatibility.
This commit uses the correct array syntax in the Invision converter, to avoid fatal erroring in PHP7.4+.
Props jrf. Fixes #3299. For 2.6.3, branches/2.6.
|
| [7013]
|
johnjamesjacoby
|
Engagements: stop shouting.
This commit removes the last remaining exclamation mark from some engagements feedback.
Props casiepa. Fixes #3293. For 2.7, trunk.
|
| [7012]
|
johnjamesjacoby
|
Engagements: stop shouting.
This commit removes the last remaining exclamation mark from some engagements feedback.
Props casiepa. Fixes #3293. For 2.6.3, branches/2.6.
|
| [7011]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6.
|
| [7010]
|
johnjamesjacoby
|
Replies: avoid stomping `t` in Reply JavaScript.
This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.
Props Kipperlenny. Fixes #3301. For 2.7, trunk.
|
| [7009]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.7, trunk.
|
| [7008]
|
johnjamesjacoby
|
Forums: revert the accidental reversal of the forums widget results order.
This commit makes sure that forums results are displayed in the expected ascending order, fixing a copy/paste regression introduced in 2.6.0.
Props netweb. Fixes #3295. See r6506. For 2.6.3, branches/2.6.
|
| [7005]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
Revert r7002 and use a different syntax to avoid debug notices.
|
| [7004]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
Revert r7003 and use a different syntax to avoid debug notices.
|
| [7003]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
|
| [7002]
|
johnjamesjacoby
|
Engagements: explicitly query for `-1` posts if no objects are known to exist.
This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.
|
| [7001]
|
johnjamesjacoby
|
Theme Compat: Revert `sans-serif` override from r6986.
This commit fixes a regression causing theme styling to to be applied, while also overriding some styling that was intentional.
|
| [7000]
|
johnjamesjacoby
|
Theme Compat: Revert `sans-serif` override from r6987.
This commit fixes a regression causing theme styling to to be applied, while also overriding some styling that was intentional.
|
| [6999]
|
johnjamesjacoby
|
Theme Compat: Don't override elements that are explicitly using `.dashicons`.
This commit prevents styling conflicts with third party plugins that are using Dashicons in elements.
See r6986.
|
| [6998]
|
johnjamesjacoby
|
Theme Compat: Don't override elements that are explicitly using `.dashicons`.
This commit prevents styling conflicts with third party plugins that are using Dashicons in elements.
See r6987.
|
| [6997]
|
johnjamesjacoby
|
Theme Compat: Add back original `ul` styling.
This commit fixes an unintentional styling change. The original rule should not have been removed.
See r6986.
|
| [6996]
|
johnjamesjacoby
|
Theme Compat: Add back original `ul` styling.
This commit fixes an unintentional styling change. The original rule should not have been removed.
See r6987.
|
| [6995]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.3-alpha.
|
| [6994]
|
johnjamesjacoby
|
Bump packages.
|
| [6993]
|
johnjamesjacoby
|
Engagements: add caching to User strategy, for 2.5 compatibility.
This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).
Props johnjamesjacoby, netweb. Fixes #3292. For 2.7, trunk.
|
| [6992]
|
johnjamesjacoby
|
Engagements: add caching to User strategy, for 2.5 compatibility.
This commit re-adds query caching for `FIND_IN_SET` queries, fixing long pageloads on sites with large amounts of usermeta that are unable to run the 2.6 database upgrade routine(s).
Props johnjamesjacoby, netweb. Fixes #3292. For 2.6.3, branches/2.6.
|
| [6991]
|
johnjamesjacoby
|
Locale: use correct singular versions, and format numeric results.
This commit fixes 2 typos causing plural versions of strings to appear where singulars should, and also makes sure that related numeric upgrade routine results are formatted.
Props webaware. Fixes #3290. For 2.6.3, branches/2.6.
|
| [6990]
|
johnjamesjacoby
|
Locale: use correct singular versions, and format numeric results.
This commit fixes 2 typos causing plural versions of strings to appear where singulars should, and also makes sure that related numeric upgrade routine results are formatted.
Props webaware. Fixes #3290. For 2.7, trunk.
|
| [6989]
|
johnjamesjacoby
|
Locale: fix an encoding typo.
This commit fixes a hard-to-see character encoding bug causing a right-quote to be incomplete in an admin-area Help Tab.
Props casiepa. Fixes #3291. For 2.7, trunk.
|
| [6988]
|
johnjamesjacoby
|
Locale: fix an encoding typo.
This commit fixes a hard-to-see character encoding bug causing a right-quote to be incomplete in an admin-area Help Tab.
Props casiepa. Fixes #3291. For 2.6.3, branches/2.6.
|
| [6987]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
For 2.6.3, branches/2.6.
|
| [6986]
|
johnjamesjacoby
|
Theme Compat: more styling tweaks to default theme.
This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers.
It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements.
Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
|
| [6985]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.7, trunk.
|
| [6984]
|
johnjamesjacoby
|
Subscriptions: correct a typo when a failure occurs.
Props webaware. Fixes #3289. For 2.6.3, branches/2.6.
|
| [6983]
|
johnjamesjacoby
|
Tag 2.6.2.
|
| [6982]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.6.2, branches/2.6.
|
| [6981]
|
johnjamesjacoby
|
BuddyPress: return the original content on non-reply actions.
This commit fixes a regression causing BuddyPress notifications to be broken in #3036.
Props tw2113. Fixes #3287. For 2.7, trunk.
|
| [6980]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.7, trunk.
|
| [6979]
|
johnjamesjacoby
|
Replies: Tell jshint to ignore some internals in scrollToForm() function.
This commit silences some noise from our Grunt processes.
For 2.6.2, branches 2.6.
|
| [6978]
|
johnjamesjacoby
|
Bump versions to 2.6.2.
|
| [6975]
|
johnjamesjacoby
|
Capabilities: break instead of return.
This commit ensures that the relative _meta_caps filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return $caps without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.7, trunk.
|
| [6974]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
| [6973]
|
johnjamesjacoby
|
Moderation: flip strict condition in `bbp_check_for_blacklist()`.
This commit fixes a bug causing old calls to `bbp_check_for_blacklist()` to use the incorrect discussion setting values.
|
| [6972]
|
johnjamesjacoby
|
Capabilities: break instead of return;
This commit ensures that the relative `_meta_caps` filters continue to be executed within their expected contexts.
Previous to this change, certain mapped capability checks would bail out early and return `$caps` without the ability to filter the results.
With this change, mapped capabilities can now be filtered more logically and inline with the rest of the surrounding logic.
For 2.6.2.
|
| [6971]
|
johnjamesjacoby
|
Docs: add note to `bbp_get_excluded_forum_ids()` about per-forum moderators.
|