| [7364]
|
johnjamesjacoby
|
Component - Users: Support `wp_is_valid_utf8()` for UTF-8 display names.
This commit adds support for a new function, introduced in WordPress 6.9, to work around UTF-8 deprecations in PHP8.4.
In trunk, for 2.7.
See #2141.
|
| [7365]
|
johnjamesjacoby
|
Tools - Unit Tests: Fix some failing tests.
This commit tweaks the expected values of some tests so that they pass as intended, mostly surrounding int/string type numerics and total/single counts.
|
| [7366]
|
johnjamesjacoby
|
Tools - Unit Tests: prevent double-spaces in span attributes.
This commit prevents the `<span>` that wraps author link parts from having 2 spaces immediately after the opening tag.
|
| [7367]
|
johnjamesjacoby
|
Tools - Unit Tests: plan for `seems_utf8()` to be deprecated.
This commit updates 3 author-link unit tests to avoid WordPress Deprecation notices.
See #3657.
|
| [7368]
|
johnjamesjacoby
|
Tools - Unit Tests: allow mentions after '[' and '(' chars.
This commit fixes the suite of user-mentions unit tests, so that they no longer require an empty "class" attribute, and also so that mentions inside of common wrappers (`()`, `[]` ) are allowed.
See #3657.
|
| [7369]
|
johnjamesjacoby
|
Tools - Unit Tests: update `bbp_get_forum_permalink()` to better support hierarchical URIs.
This commit ensures that the `test_bbp_get_forum_permalink()` test passes, and that hierarchical Forum post-type links are correctly formatted when using unpretty/plain permalinks.
See #3657.
|
| [7370]
|
johnjamesjacoby
|
Tools - Unit Tests: update `test_bbp_spam_topic()` with more accurate before/after tests.
This commit ensures that the `test_bbp_spam_topic()` tests pass, and that the various counts, and last IDs and times before & after spamming a topic, are operating as intended.
See #3657.
|
| [7371]
|
johnjamesjacoby
|
Tools - Code Improvement: bump PHP & WP versions.
This change bumps the requirements for WordPress to 6.0 and PHP to 7.2, including inside of the PHPCS matrix.
|
| [7372]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed` sniff.
This change replaces inline tabs with spaces from a bunch of files where they have crept in over the years.
|
| [7373]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `Universal.WhiteSpace.PrecisionAlignment.Found` sniff.
This change removes any precision alignment that used spaces instead of tabs.
|
| [7374]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring `WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine` sniff.
This commit ensures that all arrays with multiple keys & values are not on single lines.
|
| [7375]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring some MySQL prepare sniffs.
This commit ensures that all SQL is correctly prepared, and that specific queries are tagged to be ignored by PHPCS due to them not using the literal `$wpdb` global as required by the sniffs.
See #3658.
|
| [7376]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring more PHPCS sniffs.
* Universal.WhiteSpace.CommaSpacing.TooMuchSpaceAfter
* WordPress.Arrays.ArrayIndentation.ItemNotAligned
* WordPress.Arrays.ArrayIndentation.MultiLineArrayItemNotAligned
* WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys
* WordPress.Arrays.ArrayKeySpacingRestrictions.SpacesAroundArrayKeys
* WordPress.Arrays.MultipleStatementAlignment.MultilineItemSpaceBeforeDoubleArrow
* WordPress.Arrays.MultipleStatementAlignment.SpaceBeforeDoubleArrow
This commit includes code formatting changes to pass the above PHPCS checks.
See #3658.
|
| [7377]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring more PHPCS sniffs.
* WordPress.WP.AlternativeFunctions.rand_mt_rand
This commit prefers `wp_rand()` over `mt_rand()` in the Akismet extension.
See #3658.
|
| [7378]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring these PHPCS sniffs:
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
* Generic.CodeAnalysis.EmptyStatement.DetectedElseif
* Generic.CodeAnalysis.EmptyStatement.DetectedIf
* Generic.CodeAnalysis.UselessOverridingMethod.Found
* Generic.ControlStructures.InlineControlStructure.NotAllowed
* Generic.Files.LineEndings.InvalidEOLChar
* Generic.Formatting.DisallowMultipleStatements.SameLine
* Generic.Formatting.SpaceAfterCast.TooMuchSpace
* Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace
* Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerMultiLine
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine
* NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
* NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLineCloserSameLine
* PEAR.Functions.FunctionCallSignature.CloseBracketLine
* PEAR.Functions.FunctionCallSignature.EmptyLine
* PEAR.Functions.FunctionCallSignature.Indent
* PEAR.Functions.FunctionCallSignature.MultipleArguments
* PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
* PHPCompatibility.Syntax.RemovedCurlyBraceArrayAccess.Found
* PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
* PSR2.Classes.PropertyDeclaration.ScopeMissing
* PSR2.Classes.PropertyDeclaration.Underscore
* PSR2.Classes.PropertyDeclaration.VarUsed
* PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
* PSR2.ControlStructures.SwitchDeclaration.BreakIndent
* PSR2.Methods.MethodDeclaration.Underscore
* Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace
* Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterOpen
* Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose
* Squiz.Functions.MultiLineFunctionDeclaration.ContentAfterBrace
* Squiz.PHP.DisallowSizeFunctionsInLoops.Found
* Squiz.Scope.MethodScope.Missing
* Squiz.WhiteSpace.SuperfluousWhitespace.EndLine
* Universal.NamingConventions.NoReservedKeywordParameterNames.arrayFound
* Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
* Universal.NamingConventions.NoReservedKeywordParameterNames.parentFound
* Universal.Operators.DisallowStandalonePostIncrementDecrement.PostDecrementFound
* Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
* Universal.Operators.StrictComparisons.LooseEqual
* Universal.Operators.StrictComparisons.LooseNotEqual
* WordPress.Arrays.ArrayKeySpacingRestrictions.TooMuchSpaceAfterKey
* WordPress.DateTime.CurrentTimeTimestamp.Requested
* WordPress.DateTime.RestrictedFunctions.date_date
* WordPress.Files.FileName.NotHyphenatedLowercase
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
* WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
* WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
* WordPress.PHP.IniSet.Risky
* WordPress.PHP.PregQuoteDelimiter.Missing
* WordPress.PHP.StrictInArray.MissingTrueStrict
* WordPress.WP.AlternativeFunctions.parse_url_parse_url
* WordPress.WP.AlternativeFunctions.rand_mt_rand
* WordPress.WP.AlternativeFunctions.strip_tags_strip_tag
* WordPress.WP.AlternativeFunctions.strip_tags_strip_tags
* WordPress.WP.Capabilities.Unknown
* WordPress.WP.DeprecatedParameters.Get_termsParam2Found
* WordPress.WP.DeprecatedParameters.Wp_count_termsParam2Found
* WordPress.WP.DiscouragedFunctions.query_posts_query_posts
* WordPress.WP.DiscouragedFunctions.wp_reset_query_wp_reset_query
* WordPress.WP.EnqueuedResourceParameters.NotInFooter
* WordPress.WP.GlobalVariablesOverride.Prohibited
* WordPress.WP.I18n.LowLevelTranslationFunction
This commit includes code formatting changes for the above sniffs.
See #3658.
|
| [7379]
|
johnjamesjacoby
|
Tools - Code Improvement: stop ignoring these PHPCS sniffs:
* PEAR.Files.IncludingFile.UseRequire
* PSR2.ControlStructures.SwitchDeclaration.BodyOnNextLineDEFAULT
* PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
* Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
* Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
* Squiz.PHP.EmbeddedPhp.MultipleStatements
* Squiz.PHP.NonExecutableCode.Unreachable
* Universal.Arrays.DuplicateArrayKey.Found
* Universal.ControlStructures.DisallowLonelyIf.Found
* WordPress.PHP.NoSilencedErrors.Discouraged
This commit includes code formatting changes for the above sniffs.
See #3658.
|
| [7380]
|
johnjamesjacoby
|
Tools - Code Improvement: docs & code formatting improvements.
Props johnjamesjacoby, noruzzaman.
Fixes #3659.
|
| [7381]
|
johnjamesjacoby
|
Tools - Code Improvement: un-indent last remaining `_get_` functions.
|
| [7382]
|
johnjamesjacoby
|
General - Administration: add "loaded" hooks to admin classes.
This change allows third-party plugins access to various class objects after they are loaded, specifically their `$this` references in their related `setup_actions()` methods.
In trunk, for 2.7.
Fixes #3660.
|
| [7383]
|
johnjamesjacoby
|
API - Blocks: Introduce support for Gutenberg blocks.
This commit includes:
* `bbp_register_blocks` sub-action
* `common/blocks.php` to register all of the blocks via PHP
* `common/blocks` directory that includes a subdirectory for each `block.json` file
* `admin/assets/js/blocks.js` to add block previews & preliminary support for some controls
* `admin/assets/css/blocks.css` to help block previews look modern & clean
Fixes #3403.
In trunk, for 2.7.
Props georgestephanis, adamsilverstein, SirLouen, johnjamesjacoby.
|
| [7384]
|
johnjamesjacoby
|
API - Blocks: Improve block previews
This commit attempts to improve the look of form elements & template notices in block previews.
See #3403.
In trunk, for 2.7.
|
| [7385]
|
johnjamesjacoby
|
Common Functions: avoid PHP warnings in logout URL.
This commit checks that server globals are not empty before attempting to concatenate them into a redirection destination.
See https://bbpress.org/forums/topic/assistance-with-various-php-errors-please/
In trunk, for 2.7.
|
| [7386]
|
johnjamesjacoby
|
Admin - Metaboxes: Enshorten metabox titles.
This commit ensures that metabox titles do not break onto 2 lines of text now that `show_in_rest` is true and the new editor UI is being used.
See #3603.
In trunk, for 2.7.
|
| [7387]
|
johnjamesjacoby
|
API - Blocks: add support for Post and Page post types.
This commit ensures that both of the primary post types supported by WordPress core are explicitly supported by all blocks in their `block.json` files.
See #3403.
In trunk, for 2.7.
|
| [7388]
|
johnjamesjacoby
|
API - Blocks: fix supported post types.
This commit reverts most of r7387 for a simpler approach.
See #3403.
In trunk, for 2.7.
|
| [7389]
|
johnjamesjacoby
|
API - Blocks: Do not use the block editor for bbPress post types.
This commit ensures that the legacy (non-block, meta-box based) new/edit post GUI is still used, even though `show_in_rest` is set to `true` for the forum/topic/reply post types, by introducing a new function on top of the core `use_block_editor_for_post_type` filter.
This prevents admin-area edits from saving block-based content when it is not yet properly handled or supported for the 2.7.0 release, even though blocks are (via the shortcodes & theme compatibility APIs).
See #3403.
In trunk, for 2.7.
|
| [7390]
|
johnjamesjacoby
|
Common - Code Improvement: remove HTML4 `type` attribute on `<script>` tag.
This changes `bbp_swap_no_js_body_class()` so the `script` tag it outputs no longer includes a `type="text/javascript" attribute.`
See #wp59883.
In trunk, for 2.7.
|
| [7391]
|
johnjamesjacoby
|
Common - Code Improvement: Fix a missing `@since` tag.
Props manhphuc.
See: https://github.com/bbpress/bbPress/pull/38
In trunk, for 2.7.
|
| [7392]
|
johnjamesjacoby
|
Common - Code Improvement: Correct some missing/inaccurate `@return` tags.
Props manhphuc.
See: https://github.com/bbpress/bbPress/pull/39
In trunk, for 2.7.
|
| [7393]
|
johnjamesjacoby
|
Common - Formatting: Properly fallback the UTF8/mb display name formatter.
This change prevents deprecation notices when more modern UTF8 handling is available, preventing unnecessarily falling back to `seems_utf8()`.
Follow-up to r7364.
See #2141.
In trunk, for 2.7.
|
| [7394]
|
johnjamesjacoby
|
Core - Theme Compat: add Block Theme support.
This commit includes the following changes:
* Deprecates `bbp_get_theme_compat_templates()` for a singular version
* Introduces `bbp_get_theme_canvas_template()` to retrieve a filtered path to `theme-canvas.php`
* Introduces `bbp_get_template_include_templates()` to retrieve a filtered array of checker & getter functions
* Simplifies `bbp_template_include_theme_supports()` into a foreach loop
* Simplifies `bbp_is_template_included()` usage inside of `bbp_template_include_theme_compat()` by removing the later check now that `404`'s are handled elsewhere
Props mikachan, robin-w, arafatjamil01, johnjamesjacoby.
Fixes #3487.
In trunk, for 2.7.
|
| [7395]
|
johnjamesjacoby
|
Tools: Remove JSValidate and use ESLint.
Also update CSS & JS assets based on new tooling.
Includes some improvements to admin area styling, specifically block previews.
In trunk, for 2.7.
|
| [7396]
|
johnjamesjacoby
|
Tools: PHPCS improvements from recent commits.
In trunk, for 2.7.
|