| [7064]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.5-alpha-1.
|
| [7065]
|
johnjamesjacoby
|
Bump stable tag in trunk 2.6.4, and also update an node dependency.
|
| [7066]
|
johnjamesjacoby
|
Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.7, trunk.
|
| [7067]
|
johnjamesjacoby
|
Templates: avoid possible fatal error in `is_bbpress()`.
This commit confirms that the `$wp_query` global has been invoked before attempting to make comparisons against it. It also uses `_doing_it_wrong()` to alert developers to what is going on.
Props r-a-y. Fixes #3334. For 2.6.15, branches/2.6.
|
| [7068]
|
johnjamesjacoby
|
Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.6.15, branches/2.6.
|
| [7069]
|
johnjamesjacoby
|
Templates: avoid `$wp_query` global touches.
This commit replaces direct `$wp_query` touches with calls to `bbp_get_wp_query()` which is designed for this purpose. Combined with the filter inside of `bbp_get_global_object()` this enables originally intended flexibility inside of the template stack.
See #3334. For 2.7, trunk.
|
| [7070]
|
johnjamesjacoby
|
Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.7, trunk.
|
| [7071]
|
johnjamesjacoby
|
Suggestions: various performance improvements & user request checks.
This commit adds a number of code changes surrounding admin-area topic & user suggestions:
* Limits to 10 results by default
* Prevents superfluous count queries, and taxonomy & meta prefetching
* Fixes several UX bugs with suggesting users, specifically around single-digit user IDs and miscellaneous allowed characters
* Fixes an unintended behavior that allowed non-super moderators to search for users by email address (props mirror12k)
* Fixes incorrect `wp_die()` contents when no results were available, causing a `0` to be displayed instead of nothing
* Adds documentation where it was previously lacking
* Adds a small bit of user input sanitization & trimming, since these methods are already being scrutinized
For 2.6.15, branches/2.6.
|
| [7072]
|
johnjamesjacoby
|
Theme Compat: conditionally unhook adjacent posts.
This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value.
Props r-a-y. For 2.6.15, branches/2.6.
|
| [7073]
|
johnjamesjacoby
|
Theme Compat: conditionally unhook adjacent posts.
This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value.
Props r-a-y. For 2.6.15, branches/2.6.
|
| [7074]
|
johnjamesjacoby
|
Dependencies: routine updating of node dependency tree.
|
| [7075]
|
johnjamesjacoby
|
Dependencies: routine updating of node dependency tree.
|
| [7076]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
See #3357. Trunk, for 2.7.0.
|
| [7077]
|
johnjamesjacoby
|
Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`.
This commit ensures that search terms appear correctly inside of template output, without additional slashes.
It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency.
Props dd32, johnjamesjacoby.
Fixes #3357. 2.6 branch, for 2.6.5.
|
| [7078]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7079]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7080]
|
johnjamesjacoby
|
Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In trunk, for 2.7.0.)
Fixes #3373.
|
| [7081]
|
johnjamesjacoby
|
Sub-Actions: add `is_string() checks to `bbp_get/post_request()` functions.
This commit prevents possible PHP warnings when `action` global variables are sent over as an array using the `[]` URI syntax, which is not supported.
Props dd32.
(In branches/2.6, for 2.6.5.)
Fixes #3373.
|
| [7082]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In 2.6 branch, for 2.6.5.
See #3371.
|
| [7083]
|
johnjamesjacoby
|
Formatting: tweak regular expression for @ mentions.
This commit fixes a bug causing usernames to be made clickable even after they were already made clickable previously by the email address filter.
In trunk, for 2.7.0.
See #3371.
|
| [7084]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In trunk, for 2.7.0.
See #3374.
|
| [7085]
|
johnjamesjacoby
|
Forums: Escape forum descriptions in admin-area list tables.
This commit ensures that HTML is not rendered where it is not intended to be, most important to users having the `unfiltered_html` capability.
Props binit.
In branches/2.6, for 2.6.5.
See #3374.
|
| [7086]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In trunk, for 2.7.0.
See #3157.
|
| [7087]
|
johnjamesjacoby
|
Signups: Ensure that the dynamic role exists before setting it.
This commit introduces several new helper functions for validating Forum roles before saving & assigning them to new user accounts.
It also adds relevant capability checks to prevent unauthorized users from performing role assignments.
In branches/2.6, for 2.6.5.
See #3157.
|
| [7088]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In trunk, for 2.7.0.
|
| [7089]
|
johnjamesjacoby
|
Settings: Only allow users with the `edit_users` capability to toggle the Super Moderators option.
This commit also rearranges some settings for improved UX, and adds descriptive text to the "Super Moderators" and "Forum Moderators" settings for improved clarity.
This commit addresses a responsibly disclosed security concern, and does not have a public issue in Trac.
In branches/2.6, for 2.6.5.
|
| [7090]
|
johnjamesjacoby
|
Bump 2.6 branch versions to 2.6.5.
|
| [7091]
|
johnjamesjacoby
|
Tag 2.6.5.
|
| [7092]
|
johnjamesjacoby
|
Update plugin headers in trunk to include newest supported keys.
Adds "Requires PHP" and "Requires at least" using versions from 2.6.5 (for now.)
Props spacedmonkey.
|
| [7093]
|
johnjamesjacoby
|
Readme: Bump stable tag and group "Requires" headers together.
In trunk, for 2.7.0.
|
| [7094]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.6-alpha-1.
Includes readme.txt updates merged from trunk in r7093.
|
| [7095]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In branches/2.6, for 2.6.6.
See #3376.
|
| [7096]
|
johnjamesjacoby
|
Replies: Correct inverted logic in bbp_update_reply_walker().
This commit fixes a bug causing Forum Category metadata to not be updated when publishing a reply.
Props vbadham.
In trunk, for 2.7.0.
Fixes #3376.
|
| [7097]
|
johnjamesjacoby
|
Accessibility: Text Changes: Use sentence case for the word "Error" in various error messages, instead of all caps.
Using all caps should be avoided for better readability, and because screen readers may pronounce all-caps words as abbreviations.
Related to [WP47156], #WP47656, #WP43037, #WP42945.
Props casiepa, man4toman, mmeet94, SergeyBiryukov, afercia, ryokuhi, sabernhardt, garrett-eclipse.
In branches/2.6, for 2.6.6.
See #3333, #3377.
|
| [7098]
|
johnjamesjacoby
|
Accessibility: Text Changes: Use sentence case for the word "Error" in various error messages, instead of all caps.
Using all caps should be avoided for better readability, and because screen readers may pronounce all-caps words as abbreviations.
Related to [WP47156], #WP47656, #WP43037, #WP42945.
Props casiepa, man4toman, mmeet94, SergeyBiryukov, afercia, ryokuhi, sabernhardt, garrett-eclipse.
In trunk, for 2.7.0.
Fixes #3333, #3377.
|
| [7099]
|
johnjamesjacoby
|
Theme Compatibility: Avoid compatibility issues between MySQL versions.
This commit introduces a new function - `bbp_get_empty_datetime()` - which returns a valid, filterable, "empty" MySQL formatted datetime value.
This new function is used inside the theme compatibility API to ensure that global `WP_Post` datetime values are not "0" to better support MySQL 8 and higher, which is dropping support for `NO_ZERO_DATES`.
Props GDragoN.
In trunk, for 2.7.0.
See #3354.
|
| [7100]
|
johnjamesjacoby
|
Theme Compatibility: Avoid compatibility issues between MySQL versions.
This commit introduces a new function - `bbp_get_empty_datetime()` - which returns a valid, filterable, "empty" MySQL formatted datetime value.
This new function is used inside the theme compatibility API to ensure that global `WP_Post` datetime values are not "0" to better support MySQL 8 and higher, which is dropping support for `NO_ZERO_DATES`.
Props GDragoN.
In branches/2.6, for 2.6.6.
Fixes #3354.
|
| [7101]
|
johnjamesjacoby
|
Warnings: Prevent PHP warnings in Multisite Dashboards.
This commit wraps `bbp_current_screen` hooks around an `is_blog_admin()` call, to explicitly target the intended admin-area Site Dashboard.
This avoids some warnings from functions not existing, as a result of how `BBP_Admin` is currently invoked (on `bbp_init` for converting passwords.)
In branches/2.6, for 2.6.6.
|
| [7102]
|
johnjamesjacoby
|
Warnings: Prevent PHP warnings in Multisite Dashboards.
This commit wraps `bbp_current_screen` hooks around an `is_blog_admin()` call, to explicitly target the intended admin-area Site Dashboard.
This avoids some warnings from functions not existing, as a result of how `BBP_Admin` is currently invoked (on `bbp_init` for converting passwords.)
In trunk, for 2.7.0.
|
| [7103]
|
johnjamesjacoby
|
Bump out-of-date dependencies.
|
| [7104]
|
johnjamesjacoby
|
Users: Correctly calculate offset in User Profile > Last Activity.
Previous to this, Last Activity was being saved with `time()` but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.
Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.
In branches/2.6, for 2.6.6.
See #3378.
|
| [7105]
|
johnjamesjacoby
|
Users: Correctly calculate offset in User Profile > Last Activity.
Previous to this, Last Activity was being saved with `time()` but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.
Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.
In trunk, for 2.7.0.
Fixes #3378.
|
| [7106]
|
netweb
|
Build Tools: Update PHPCS
|
| [7107]
|
netweb
|
Build Tools: Update Node.js and npm required versions
|
| [7108]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In trunk, for 2.7.0.
Fixes #3378.
|
| [7109]
|
johnjamesjacoby
|
BuddyPress: Mark all replies when marking topic notifications as read.
This commit fixes a regression - introduced in r6845 - that was causing marking topic notifications as read to fail. It fixes it by looping through all replies to a topic and attempting to mark them all individually. It is not a particularly optimized approach, but it does resolve the regression in such a way that accounts for both topic IDs and reply IDs.
In branches/2.6, for 2.6.6.
Fixes #3213.
|
| [7110]
|
xknown
|
PHP 7.4 Compat: Use square brackets and remove create_function calls.
|
| [7111]
|
xknown
|
PHP 7.4 Compat: Remove the create_function calls.
They are deprecated, and they seem to be removed in PHP 8.0.
|
| [7112]
|
xknown
|
PHP 7.4 compat: Replace the deprecated each call
|
| [7113]
|
xknown
|
PHP 7.4 Compat: remove deprecated functions.
|
| [7114]
|
xknown
|
PHP 7.4 Compat: Remove deprecated functions.
|
| [7115]
|
xknown
|
PHP 7.4 Compat: Don't use curly braces for array/string access
|
| [7116]
|
xknown
|
PHP 7.4 Compat: Replace the deprecated create_function calls with anonymous functions.
|
| [7117]
|
xknown
|
Update _wp_filter_build_unique_id to handle anonymous functions.
This is based on https://core.trac.wordpress.org/browser/trunk/src/wp-includes/plugin.php?rev=38282
Props dd32
|
| [7118]
|
xknown
|
Fix PHP warnings.
|
| [7119]
|
xknown
|
Sync the _wp_filter_build_unique_id function to rWP38282
|
| [7120]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In branches/2.6, for 2.6.6.
Props peterkueger.
|
| [7121]
|
johnjamesjacoby
|
Formatting: remove extra double quote in `bbp_make_mentions_clickable_callback()`.
In trunk, for 2.7.
Props peterkueger.
Fixes #3390.
|
| [7122]
|
johnjamesjacoby
|
Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In trunk, for 2.7.
Props SergeyBiryukov.
See #3133.
|
| [7123]
|
johnjamesjacoby
|
Moderation: when approving topics & replies, manually set post_date_gmt.
This commit is necessary to prevent `wp_update_post()` from marking these posts as having been published immediately, instead of their original post_date.
In branches/2.6, for 2.6.6.
Props SergeyBiryukov.
See #3133.
|
| [7124]
|
johnjamesjacoby
|
Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In branches/2.6, for 2.6.6.
See #3384.
|
| [7125]
|
johnjamesjacoby
|
Content: add support for `wp_filter_content_tags()` in WordPress 5.5.
This commit removes some deprecated function notices, while also adding ongoing support for filtered content tags.
In trunk, for 2.7.
See #3384.
|
| [7126]
|
johnjamesjacoby
|
Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In trunk, for 2.7.
Props Otto42.
See #2853.
|
| [7127]
|
johnjamesjacoby
|
Akismet: add support for request headers.
This commit stops discarding the header information coming back from Akismet, and instead allows it to be filtered as needed.
In branches/2.6, for 2.6.6.
Props Otto42.
See #2853.
|
| [7128]
|
johnjamesjacoby
|
Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In branches/2.6, for 2.6.6.
Props procifer.
See #3368.
|
| [7129]
|
johnjamesjacoby
|
Akismet: fix spam check not sending author info for logged in users
This commit uses `bbp_has_errors()` to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).
This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.
In trunk, for 2.7.
Props procifer.
See #3368.
|
| [7130]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In trunk, for 2.7.
See #3385.
|
| [7131]
|
johnjamesjacoby
|
Replies: remove post-form check from `bbp_get_form_reply_to()`.
This commit reinstates the reply-to hierarchy when used inside of a non-POST request, namely via theme-side GET requests where JavaScript may not be relied upon.
In branches/2.6, for 2.6.6.
See #3385.
|
| [7132]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7133]
|
johnjamesjacoby
|
Update node dependencies.
|
| [7134]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In trunk, for 2.7.
See #3310.
|
| [7135]
|
johnjamesjacoby
|
Repair Tools: rebuild forum forum IDs.
This commit adds back the `_bbp_forum_id` meta data for Forums that was previously deleted inside the `bbp_admin_repair_forum_meta()` repair function.
Props ikovalyov.
In branches/2.6, for 2.6.6.
See #3310.
|
| [7136]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In branches/2.6, for 2.6.6.
|
| [7137]
|
johnjamesjacoby
|
Topics: Use global update functions for Forum & Topic IDs.
This commit cleans up an oversight where `update_post_meta()` was being called directly rather than their abstractions.
In trunk, for 2.7.
|
| [7138]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In trunk, for 2.7. See #3379.
|
| [7139]
|
johnjamesjacoby
|
Replies: Set a default topic ID in bbp_get_reply_url().
This commit prevents a PHP notice when calling this function on an oddly formed reply ID.
In branches/2.6, for 2.6.6. See #3379.
|
| [7140]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In branches/2.6, for 2.6.6. See #3409.
|
| [7141]
|
johnjamesjacoby
|
Replies: remove unintended duplicate array_filter() call from r7140.
|
| [7142]
|
johnjamesjacoby
|
Replies: prevent adding empty values to pre-spam & pre-trash meta data.
This commit filters empty values from meta data before saving them, as well as removing a simple type-cast and replacing it with a more intentional is_array() check. This new approach works because get_post_meta() will call maybe_unserialize() and always return an array if it exists, or return an empty string if it does not. If it's not an array, we know it should be an empty one.
In trunk, for 2.7. Fixes #3409.
|
| [7143]
|
johnjamesjacoby
|
Users: avoid PHP notice (warning in PHP8) when getting a user nicename.
This commit improves the internal logic of `bbp_get_user_nicename()` to handle a missing or invalid user object, defaulting to an empty string in that specific instance.
In branches/2.6, for 2.6.6. See #3402.
Props dd32.
|
| [7144]
|
johnjamesjacoby
|
Users: avoid PHP notice (warning in PHP8) when getting a user nicename.
This commit improves the internal logic of `bbp_get_user_nicename()` to handle a missing or invalid user object, defaulting to an empty string in that specific instance.
In trunk, for 2.7. Fixes #3402.
Props dd32.
|
| [7145]
|
johnjamesjacoby
|
Users: update HTML class of user-profile.php template part.
This commit fixes a duplicated class in the user profile output, from `bbp-user-topic-count` to `bbp-user-last-activity`.
In branches/2.6, for 2.6.6. See #3394.
Props netweb.
|
| [7146]
|
johnjamesjacoby
|
Users: update HTML class of user-profile.php template part.
This commit fixes a duplicated class in the user profile output, from `bbp-user-topic-count` to `bbp-user-last-activity`.
In trunk, for 2.7. Fixes #3394.
Props netweb.
|
| [7147]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In branches/2.6, for 2.6.6. See #3385.
|
| [7148]
|
johnjamesjacoby
|
Replies: fix clicking "Reply" link from the lead topic.
This commit adjusts reply.js and bbp_get_topic_reply_link() so clicking "Reply" from the lead topic now behaves similarly to clicking "Reply" from a reply. This includes support for hierarchical replies being on or off.
In trunk, for 2.7. Fixes #3385.
|
| [7149]
|
johnjamesjacoby
|
Meta: always query meta_value by string, not by integer.
This commit swaps "%d" for "%s" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In branches/2.6, for 2.6.6. See #3408.
|
| [7150]
|
johnjamesjacoby
|
Meta: always query meta_value by string, not by integer.
This commit swaps "%d" for "%s" when querying by `meta_value`, even with numeric values. This allows for custom index alterations to perform as intended, and also more closely follows how WordPress core itself operates.
In trunk, for 2.7. Fixes #3408.
|
| [7151]
|
johnjamesjacoby
|
Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`.
This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges.
In branches/2.6, for 2.6.6. Fixes #3405.
Props muratgu.
|
| [7152]
|
johnjamesjacoby
|
Emails: correct logic in `bbp_get_email_addresses_from_user_ids()`.
This commit makes sure that the query offset (for looping through user IDs) does not unintentionally skip over any IDs in the allowed ranges.
In trunk, for 2.7. Fixes #3405.
Props muratgu.
|
| [7153]
|
johnjamesjacoby
|
Topics: fix not being able to unsticky in certain circumstances.
This commit adds a `bbp_unstick_topic()` call inside of `bbp_update_topic()` where it has been missing since forever.
In branches/2.6, for 2.6.6. See #3396.
|
| [7154]
|
johnjamesjacoby
|
Topics: fix not being able to unsticky in certain circumstances.
This commit adds a `bbp_unstick_topic()` call inside of `bbp_update_topic()` where it has been missing since forever.
In trunk, for 2.7. Fixes #3396.
|
| [7155]
|
johnjamesjacoby
|
Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In branches/2.6, for 2.6.6. See #3400.
Props cfinke.
|
| [7156]
|
johnjamesjacoby
|
Akismet: prefer the GMT datetime.
This commit swaps out `comment_date` for `comment_date_gmt` for improved accuracy.
In trunk, for 2.7. Fixes #3400.
Props cfinke.
|
| [7157]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In branches/2.6, for 2.6.6. See #3309.
Props dd32, man4toman.
|
| [7158]
|
johnjamesjacoby
|
Replies: Allow moderators to reply to pending topics.
This commit adds a check inside of `bbp_current_user_can_access_create_reply_form()` for the `edit_topic` capability, and if the user is capable will now allow them to access that form.
This will come in particularly handy for forum moderators who want to reply to topics before they are approved, or to provide a reason to the original poster why a topic will not be approved but without making it public.
In trunk, for 2.7. Fixes #3309.
Props dd32, man4toman.
|
| [7159]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In branches/2.6, for 2.6.6. See #3398.
|
| [7160]
|
johnjamesjacoby
|
Formatting: fix output of bbp_get_time_since() in some languages.
This commit changes how the "right now" fallback is calculated to avoid trimming and type-casting a translated string value, by checking the two count values (I.E. 1 year, 1 day) for emptiness - "0, 0" will now correctly fallback to "right now".
In trunk, for 2.7. Fixes #3398.
|
| [7161]
|
johnjamesjacoby
|
Bump 2.6 branch to 2.6.6.
|
| [7162]
|
johnjamesjacoby
|
Tagging 2.6.6.
|
| [7163]
|
johnjamesjacoby
|
Bump stable tag to 2.6.6 in trunk.
|