| [6164]
|
xknown
|
Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
|
| [6165]
|
xknown
|
Branch 1.2: Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument.
- Add also PHP 5.x style constructors.
See #3033
|
| [6166]
|
xknown
|
Fix PHP7 parse error.
The result of `new` can't be longer assigned by reference.
See #3033
|
| [6167]
|
xknown
|
Branch 1.2: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6168]
|
xknown
|
Update the backpress svn external to http://backpress.svn.wordpress.org/tags/backpress-1.2.1-bbpress/
See #3033
|
| [6169]
|
johnjamesjacoby
|
Tag bbPress 1.2.1 which adds some basic PHP7 compatibility. See #3033
|
| [6170]
|
xknown
|
branch 0.9: Silence signature mismatch notices.
In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict
See #3033
|
| [6171]
|
xknown
|
branch 0.9: Silence signature mismatch notices.
In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict
See #3033
|
| [6172]
|
johnjamesjacoby
|
Extend: Fix a typo in docs.
|
| [6173]
|
johnjamesjacoby
|
Tools: Add classes & data attributes to improve responsiveness.
|
| [6174]
|
johnjamesjacoby
|
Tools: First pass at upgrade tools for favorites & subscriptions.
* Registers 2 new repair tools
* Includes basic looping patterns for user-meta to post-meta
Needs testing and scrutiny.
See #2959.
|
| [6175]
|
johnjamesjacoby
|
Tools: Use `$total` count in `bbp_admin_migrate_user_favorites()`.
Also update revision number in function docs.
See #2959.
|
| [6176]
|
johnjamesjacoby
|
Tools: Massize clean-up
* Add missing function documentation blocks
* Rename `_migrate_` function to `_upgrade_`
* More typo fixes
* Make `overhead` values clickable in list table rows
* Refactor `overhead` to work more like `components`, using keys instead of literal strings
See #2959.
|
| [6177]
|
johnjamesjacoby
|
Tools: Update tools text to include favorites & subscriptions.
See #2959.
|
| [6178]
|
johnjamesjacoby
|
Tools: Update forum/topic/reply admin classes to avoid screens without `post_type` parameters.
Fixes edge-case debug notices when tools pages for third-party plugins are doing advanced things.
See #2959.
|
| [6179]
|
netweb
|
Build Tools: `.jshintrc` is a JSON file, indentation should use spaces, not tabs, and lastly have `.editorconfig` treat `jshintrc` as a JSON file.
|
| [6180]
|
johnjamesjacoby
|
Extend: Consolidate some BuddyPress hooks to the top of each file.
|
| [6181]
|
johnjamesjacoby
|
Tools: Use `explode()` instead of `maybe_unserialize()`.
User-meta values were strings to enable `FIND_IN_SET()` usages.
See #2959.
|
| [6182]
|
johnjamesjacoby
|
Tools: Explicitly pass `false` into `add_post_meta()`'s `$unique` parameter.
Though it's the default, we can't make any mistake that meta-key's to be non-unique for this to function correctly.
See #2959.
|
| [6183]
|
johnjamesjacoby
|
Core: Upgrade routine for favorites & subscriptions in 2.6.0.
* Use the new upgrade tools
* Bump the DB version to `260`
* Improve inline docs in upgrade tool functions
See #2959.
|
| [6184]
|
johnjamesjacoby
|
Converter: Convert favorites & subscriptions to `postmeta` vs. `usermeta`.
* Update table names
* Support for comma-separated string values
* Use strict comparisons where it makes sense to
See #2959, #2668.
|
| [6185]
|
johnjamesjacoby
|
Labels: Prefer "Add New" over "New Thing".
|
| [6186]
|
johnjamesjacoby
|
Admin: Implement new loading sequence for major admin components.
* Introduce new `bbp_current_screen` sub-action
* Hook forums/topics/replies into `bbp_current_screen`
* Remove various `bail()` methods, which were fragile and terrible anyways
* Revert r6178, thanks to order-of-operation issues with `get_current_screen()`
* Remove Comments & Discussion metaboxes if `comments` is not explicitly supported
See #2959.
|
| [6187]
|
johnjamesjacoby
|
Admin: Add missing `@param`'s from r6186.
|
| [6188]
|
johnjamesjacoby
|
Tools: Avoid duplicate entries for favorites & subscriptions.
This fixes a bug in the 2.6.0 upgrade routine where running the tool multiple times could add duplicate metadata.
See #2959.
|
| [6189]
|
johnjamesjacoby
|
Tools: Use `get_results()`, and don't delete usermeta.
(Maybe we should have a separate clean-up tool once it's confirmed to be OK.)
See #2959.
|
| [6190]
|
netweb
|
Admin: Add missing `@since` revisions from r6186.
|
| [6191]
|
johnjamesjacoby
|
Audit direct query and `prepare()` usages, and more tightly adhere to best practices.
* No quotes around directives
* Avoid concatenation, prefer variable parsing in double-quoted strings
* Covers converters, helper functions, and tools
|
| [6192]
|
johnjamesjacoby
|
Fix formatting of query in `bbp_get_user_closed_topic_count()`, introduced in r6191.
|
| [6193]
|
netweb
|
Tools: Add an upgrade tool for forum subscriptions.
* Adds `bbp_admin_upgrade_user_forum_subscriptions()`
* Renames `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()`
* Updated inline docs
Previously in r6174 upgrade tools were added for favorites and subscriptions, support for migrating forums subscriptions meta `_bbp_forum_subscriptions` wasn't included, rather than adding extra overhead to the existing topic subscriptions upgrade tool another upgrade tool was added for forum subscriptions.
See #2959.
|
| [6194]
|
netweb
|
Tests: Add favorite, topic subscriptions, and forum subscription upgrade tool tests.
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_favorites`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_topic_subscriptions`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_forum_subscriptions`
See #2959.
|
| [6195]
|
netweb
|
Converter: Give `!` usages some breathing room.
|
| [6196]
|
johnjamesjacoby
|
Breathing room for all `!is_` usages.
|
| [6197]
|
johnjamesjacoby
|
Metaboxes: Add metaboxes for viewing favorites & subscriptions of topics & replies.
* New functions for outputting avatars of users who have favved or subbed
* Use the `$post` parameter that's passed in, rather than using `get_the_ID()` again
* Use `require_once` as a language construct vs. `include_once()` as a function
* Pass `$post` object through to metabox subsequent filters vs just the ID
See #2959.
|
| [6198]
|
johnjamesjacoby
|
Users: Use existing WordPress core functions where possible.
* `get_users()` for per-forum moderator setting & getting
* `count_user_posts()` for raw topic & reply counts
* General code clean-up around these parts
|
| [6199]
|
johnjamesjacoby
|
Strings: Add `view_items` text for forums, topics, replies, and topic-tags.
This adds support for a label that is new to WordPress 4.7.
|
| [6200]
|
netweb
|
Metaboxes: Update `@since` revisions for functions introduced in r6197.
See #2959.
|
| [6201]
|
netweb
|
Build Tools: Remove unsupported WordPress versions from Travis CI build job matrix.
This changeset removes all WordPress versions previous to 4.7 as this is now bbPress' minimum required version.
|
| [6202]
|
netweb
|
Accessibility: Bump headings for BuddyPress group forums.
Props mercime.
Fixes #2968.
|
| [6203]
|
netweb
|
Build Tools: Add Travis CI cache for installed apt packages.
See #2980.
|
| [6204]
|
netweb
|
Unit Tests: Don't run BuddyPress PHPUnit tests on versions less than PHP 5.3.0
BuddyPress 2.8 has dropped support for PHP 5.2.x, this changeset updates the BuddyPress PHPUnit configuration to only run the tests on PHP versions greater than `5.3.0`
See also https://bpdevel.wordpress.com/2016/07/21/php-5-2-bp-2-8-and-php-support-guidelines/
Fixes #3037.
|
| [6205]
|
xknown
|
branch 1.1: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6206]
|
xknown
|
branch 0.9: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6207]
|
xknown
|
branch 1.2: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6208]
|
xknown
|
branch 1.1: Avoid infinite recursion loop when creating a new WP_User instance.
See #3303
|
| [6209]
|
xknown
|
branch 1.2: Fix infinite loop when create a new WP_User instance.
See #3033
|
| [6210]
|
netweb
|
Fix s/convertion/conversion typo in changelog introduced in r6127
|
| [6211]
|
netweb
|
Fix s/convertion/conversion typo in changelog introduced in r4422 (2.5 branch)
|
| [6212]
|
johnjamesjacoby
|
Parser: PHP 7.1 compatibility fixes to `parser.php`
Props xknown. Fixes #2973. See #2987.
|
| [6213]
|
johnjamesjacoby
|
Bump trunk to 2.6 Beta 1.
|
| [6214]
|
netweb
|
Appearance - Included Themes: Update admin base SCSS styles:
* Updated via upstream WordPress `_admin.scss` file via WP:changeset:38602, WP:changeset:38638, WP:changeset:38660, WP:changeset:39141, and WP:changeset:39249
See #2583
|
| [6215]
|
johnjamesjacoby
|
Tools: Order fav/sub upgrade by `user_id`.
This makes it easier to `LIMIT` later if you need to manually chunk this. See #2959.
|
| [6216]
|
johnjamesjacoby
|
Users: Add `nopaging` to `WP_Query` usages.
Fixes bug with favs/subs being limited to 10 results by default. See #2959.
|
| [6217]
|
netweb
|
Unit Tests: Don't run BuddyPress PHPUnit tests on PHP 5.2.x
Previously r6204 attempted to skip BuddyPress tests if the PHP version was less than 5.3.0, this didn't work as intended as BuddyPress was still being loaded, the change would have only skipped tests rather than completely excluding the BuddyPress PHPUnit test suite from running on PHP versions less than 5.3.0.
This changeset reverts r6204 and separates the `grunt test` tasks into individual WordPress and BuddyPress PHPUnit Grunt tasks, this gives us the ability to explicitly exclude BuddyPress PHPUnit test suite from running on PHP 5.2.
See also https://bpdevel.wordpress.com/2016/07/21/php-5-2-bp-2-8-and-php-support-guidelines/
Fixes #3037.
|
| [6218]
|
johnjamesjacoby
|
Users: Remove `post__in` queries from favs/subs template loops.
This is only recently possible thanks to `postmeta` storage, and should result in a not-insignificant performance boost for those user profile pages.
See #2959.
|
| [6219]
|
johnjamesjacoby
|
Queries: Use `no_found_rows` where relevant.
This prevents `SQL_CALC_FOUND_ROWS` usages in places where it is not used.
Fixes #2972.
|
| [6220]
|
johnjamesjacoby
|
BuddyPress: Additional conditionals for group forum topic checks.
Fixes #2974. Props r-a-y.
|
| [6221]
|
johnjamesjacoby
|
Moderators: Update `bbp_get_moderator_forum_ids()` to use same approach as favs/subs.
See #459, #2959, #2972.
|
| [6222]
|
netweb
|
Build Tools: Update Grunt and companion packages to the latest version.
This changeset updates `grunt`, `grunt-exec`, and `grunt-legacy-utils` to the latest version.
Run `npm install` in your terminal to install the updates above.
|
| [6223]
|
johnjamesjacoby
|
Moderators: Allow moderators to see topic/reply author IP addresses.
Fixes #2975.
|
| [6224]
|
johnjamesjacoby
|
Feeds: Avoid duplicate site name in replies feed title.
Fixes #2998. Props SergeyBiryukov.
|
| [6225]
|
johnjamesjacoby
|
Akismet: Improve translatability of update-history strings.
Fixes #3011. Props SergeyBiryukov.
|
| [6226]
|
johnjamesjacoby
|
Akismet: Improve translatability of "(+ %d hidden)" strings.
Fixes #3009. Props SergeyBiryukov.
|
| [6227]
|
johnjamesjacoby
|
Akismet: Improve pluralization of statistics strings.
Fixes #2960. Props thebrandonallen, netweb.
|
| [6228]
|
johnjamesjacoby
|
Pagination: Use `preg_replace` to find & remove `page=1` query arguments.
Fixes #2702. Props thebrandonallen, tharsheblows.
|
| [6229]
|
johnjamesjacoby
|
BuddyPress: Prevent reading/publishing if group member is banned.
Fixes #2905. Props thebrandonallen, r-a-y.
|
| [6230]
|
johnjamesjacoby
|
Tag bbPress 2.6-beta-1.
|
| [6231]
|
netweb
|
Tests: Rely on WP Core's version of `go_to()`.
Our version of `go_to()`, inherited from BuddyPress was very messy, and since it was copied a few years ago, it has been refactored in WordPress. We can remove this duplication which makes for a cleaner method, and rely on the upstream version.
This also helps avoid false positives in tools that check for use of deprecated WordPress functions.
There was a conditional block in the old go_to() that was for compatibility with WordPress <3.9.
See also: buddypress:changeset:11254
Fixes #3015.
Props DJPaul, netweb.
|
| [6232]
|
netweb
|
Subscriptions: Update the forum and topic subscriptions 2.6 database update routine.
Previously in r6193 the topic subscription update tool was renamed from `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()` to facilitate the addition of the forum subscription update tool `bbp_admin_upgrade_user_forum_subscriptions()`.
This changeset updates the `bbp_version_updater()` 2.6 database update to run both the above upgrade tools.
Props barry.hughes.
Fixes 3038.
+ bbp_admin_upgrade_user_forum_subscriptions();
|
| [6233]
|
netweb
|
Administration: Initial pass updating contributors and props list for 2.6 release.
|
| [6234]
|
netweb
|
Administration: Second pass updating contributors and props list for 2.6 release.
|
| [6235]
|
netweb
|
Administration: Remove duplicate props entry for 2.6 release.
|
| [6236]
|
netweb
|
Build Tools: Update PostCSS Autoprefixer from v6.5.1 to v6.6.1
* See https://github.com/postcss/autoprefixer/compare/6.5.1...6.6.1
|
| [6237]
|
netweb
|
Build Tools: Update PostCSS SCSS from v0.3.0 to v0.4.0
* See https://github.com/postcss/postcss-scss/compare/0.3.0...0.4.0
|
| [6238]
|
netweb
|
Build Tools: Update `grunt-contrib-jshint` from v1.0.0 to v1.1.0
* See https://github.com/gruntjs/grunt-contrib-jshint/compare/v1.0.0...v1.1.0
|
| [6239]
|
netweb
|
Build Tools: Update `grunt-sass` from v1.2.0 to v2.0.0
* See https://github.com/sindresorhus/grunt-sass/compare/v1.2.0...v2.0.0
* Bumps `node-sass` from v3.7.0 to v4.0.0
* See https://github.com/sass/node-sass/compare/v3.7.0...v4.0.0
|
| [6240]
|
johnjamesjacoby
|
BuddyPress: In `functions.php`, prefer `bp_loggedin_user_id()` over `get_current_user_id()`.
This allows BuddyPress filters & functionality to drive the decision making process (rather than WordPress proper) to improve integration with third-party BuddyPress plugins & themes that may rely on BuddyPress in these instances.
|
| [6241]
|
johnjamesjacoby
|
Users: more `bbp_get_current_user_id()` usages, and docs to explain why it's not used in some places.
|
| [6242]
|
johnjamesjacoby
|
Upgrade: Do not automatically run the upgrade routine on large installations with many users.
This is basically a no-brainer, and exactly what we've gone through across all of the WordPress.org network already.
See #2959.
|
| [6243]
|
johnjamesjacoby
|
Upgrade: Introduce `bbp_is_large_install()` to abstract `wp_is_large_network()` which is a multisite-only function.
See #2959.
|
| [6244]
|
netweb
|
Topics: Fix misspelled `bbp_get_topic_last_reply_*` filters.
* Update `bbp_get_topic_last_reply_title()` to use `bbp_get_topic_last_reply_title`
* Includes a fallback for any plugins or themes that use `bbp_get_topic_last_topic_title`
* Fix PHPDocs `@uses` PHPDocs for `bbp_get_topic_last_reply_permalink` and `bbp_get_topic_last_reply_url`
Props SergeyBiryukov.
Fixes #3039.
|
| [6245]
|
johnjamesjacoby
|
Replies: Add `@since` and link to ticket from r6244.
See #3039.
|
| [6246]
|
johnjamesjacoby
|
Replies: Update `bbp_thread_replies()` to skip user profile pages.
* Move from core/options to replies/functions, since this isn't directly an option
* Add `! bbp_is_single_user_replies()` check to force `false` if so
* Update threaded replies pagination to re-include verbiage.
Fixes #3002.
|
| [6247]
|
johnjamesjacoby
|
Fix pagination typo.
|
| [6248]
|
johnjamesjacoby
|
Forms: Audit & normalize form-field sanitization.
* Make sure they all work the same
* Use filters in `core/filters.php` where appropriate
* Add `absint` filters for numeric values
* Add filters for per-forum moderator text field
* Remove any accidental duplicate escaping
|
| [6249]
|
johnjamesjacoby
|
Fix typos in more documentation.
|
| [6250]
|
johnjamesjacoby
|
Breathing room for `!class_exists()` checks, and bump to 2.6-beta-2.
|
| [6251]
|
johnjamesjacoby
|
Tag 2.6-beta-2.
|
| [6252]
|
johnjamesjacoby
|
Admin: Alternate row styling for list tables.
* Remove `admin_head` methods in forums/topics/replies classes
* Move styling into `admin.css`
* Bump asset version
|
| [6253]
|
johnjamesjacoby
|
Theme Compat: Improved Twenty Seventeen support:
* Add supplemental `bbpress-wrapper` class to `#bbpress-forums` div elements
* Remove box-shadow styling form bbPress's `entry-content` section links
* Provides middle-of-the-road targeting of bbPress template content, for complex styling relationships where ID's may be too powerful and classes may not have existed previously
|
| [6254]
|
johnjamesjacoby
|
Topic Tags: Introduce `bbp_update_topic_tag_count()` and include public/closed statuses in counts.
Fixes #3043.
|
| [6255]
|
johnjamesjacoby
|
StyleLint: Prefer shorthand CSS Colors.
|
| [6256]
|
johnjamesjacoby
|
Tools: Add tool to recount topics in each topic-tag.
* Add callback function for the recount itself
* Add translation for component list
* Update a few tool titles to better represent what they do
* Update tool-orders to fit new tool in the middle
See #3043.
|
| [6257]
|
johnjamesjacoby
|
Tools: Correct revision for topic-tag recount tool. See #3043.
|
| [6258]
|
johnjamesjacoby
|
Templates: Add `ABSPATH` checks to default template parts.
This helps avoid leaking error messages on certain server configurations, and ensures that if these individual PHP files are somehow accessed directly (without first loading WordPress) nothing unexpected will happen.
See r5465.
|
| [6259]
|
xknown
|
Fix infinite loop on xmlrpc.
|
| [6260]
|
xknown
|
branch 1.2: Fix infinite loop in `xmlrpc.php`
|
| [6261]
|
johnjamesjacoby
|
Assets: Remove `screen` restriction on default template pack styling.
Improves styling when printing and third-party plugins (like Autoptimize.)
Props thebrandonallen. Fixes #3012.
|
| [6262]
|
johnjamesjacoby
|
BuddyPress: Update `bbp_format_buddypress_notifications()` with new parameters.
* Prefer `$component_action_name` over less reliable `$content`
* Parameters match BuddyPress 2.6.0 and higher signature
* Mild function clean-up
Fixes #3036.
|
| [6263]
|
johnjamesjacoby
|
Admin: Fix restoring/trashing topics & replies.
Fixes #2734. Props tharsheblows, thebrandonallen, netweb.
|