| [6064]
|
johnjamesjacoby
|
Bump bbPress 2.5 branch version to 2.5.10.
|
| [6065]
|
johnjamesjacoby
|
Bump `bbpress.pot` in 2.5 branch.
|
| [6066]
|
johnjamesjacoby
|
Tag bbPress 2.5.10.
|
| [6067]
|
johnjamesjacoby
|
Bump stable tag to 2.5.10.
|
| [6068]
|
johnjamesjacoby
|
Use `length-zero-no-unit` over `number-zero-length-no-unit` in `.stylelintrc`.
Deprecated in 7.0 of stylelint.
|
| [6069]
|
netweb
|
Fix Subscriptions slug setting field PHPDoc block copy pasta
|
| [6070]
|
netweb
|
Settings: Fix `_bbp_user_favs_slug` copy pasta `bbp_form_slug_conflict_check()` slug check in `bbp_admin_setting_callback_user_favs_slug()`
|
| [6071]
|
netweb
|
Tests: Update forum/topic/reply post type assertions for the `WP_Post_Type` class introduced in WordPress 4.6
Fixes #2962.
|
| [6072]
|
netweb
|
Options: Fix `bbp_show_on_root()` copy pasta PHPDoc description
|
| [6073]
|
netweb
|
Build Tools: Add PHP 7.1 to Travis CI and "allow to fail"
This changeset adds explict PHP 7.1 for testing bbPress, see also #WP37625
See #2980.
|
| [6074]
|
netweb
|
Build Tools: Upgrade to the latest HHVM version with Travis CI using Ubuntu Trusty
Fixes #2980.
|
| [6075]
|
netweb
|
Build Tools: More targeted cleanup for multisite unit tests.
This changeset is a subset of buddypress:changeset:9980 and removes a previous heavy-handed workaround for deleting the first multisite user. This also resolves a fatal error `Object does not implement ArrayAccess` when running the tests on HHVM.
See #2962, #2981
|
| [6076]
|
netweb
|
Build Tools: Fix `BBP_UnitTestCase::go_to()` for `WP_Network`.
This changeset is via buddypress:changeset:10125
Props boonebgorges.
Fixes #2981
|
| [6077]
|
netweb
|
Tests: Add `test_bbp_forum_query_last_reply_id()`
See #2972
|
| [6078]
|
netweb
|
Options: Set the default value of `bbp_get_user_slug()` to `users`
This changeset updates the default single user slug from `user` to `users`. The `bbp_get_default_options()` function defines the default as `users` and this is used when installing and activating bbPress. This fixes a scenario where bbPress options have not been saved which would cause the single user slug to use the unexpected slug `user` rather than `users`.
Props ocean90.
Fixes #2983
|
| [6079]
|
netweb
|
Rewrite Rules: Update search permastruct in `bbPress::add_permastructs()` to `$search_id`
This changeset fixes copy pasta introduced in r4930, and updates the search rewrite to use the `$search_id` and not the `$user_id` as the permalink structure name.
Props offereins.
Fixes #2984.
|
| [6080]
|
netweb
|
Tests: Following r6078 update tests in `::BBP_Tests_Users_Template_User` to use single user slug `users`
See #2983
|
| [6081]
|
netweb
|
Build Tools: Add WordPress 4.6 to Travis CI build matrix
|
| [6082]
|
netweb
|
Tests: Initial `bbp_check_for_moderation()` tests
|
| [6083]
|
netweb
|
Tests: Initial `bbp_check_for_blacklist()` tests
|
| [6084]
|
netweb
|
Tests: Add user email, URL, IP, moderator, keymaster `bbp_check_for_moderation()` and `bbp_check_for_blacklist()` tests
|
| [6085]
|
netweb
|
Moderation: Include topic and reply post content with and without HTML in `moderation_keys` and `blacklist_keys` checks.
This changeset ensures users cannot bypass the moderation word checks by wrapping parts of the word or term in HTML, e.g. `bannedword` could previously be bypassed using `<em>banned</em>word`
Fixes #2986.
|
| [6086]
|
netweb
|
Topics: `@uses` not `@yses` PHPDoc in `bbp_update_topic()`
|
| [6087]
|
johnjamesjacoby
|
Moderation: Skip moderator query if per-forum moderation is not enabled.
Props jmdodd. Fixes #2988.
|
| [6088]
|
netweb
|
Tests: Improve `test_bbp_update_topic_last_active_id()` tests.
This changeset adds a passing reply id only test for `bbp_update_topic_last_active_id()`
|
| [6089]
|
netweb
|
Locale - i18n/l10n: Differentiate the noun and verb "Reply" string.
"Reply" can be used as both a verb and a noun, this changeset adds this context to instances of the "Reply" string thus allowing the different contexts to be translated accurately.
Props ocean90.
Fixes #2977.
|
| [6090]
|
netweb
|
Tests: Remove the "reply only" test from `test_bbp_update_topic_last_active_id()`
This changeset reverts a test added in r6088 that passed only the reply id to `bbp_update_topic_last_active_id()`, the test passed locally but failed on every Travis CI job except HHVM. Further investigation is required, but not today.
|
| [6091]
|
netweb
|
Tools: Running the "Reset Forums" tool now deletes bbPress' custom post type revisions from the database.
This changeset adds support for deleting forum, topic, and reply post types revisions to `bbp_admin_reset_handler()`.
Fixes #2945.
|
| [6092]
|
netweb
|
Bump alpha version in bbpress.php to latest revision.
|
| [6093]
|
netweb
|
Build Tools: Update stylelint to v7.2.0 and bump `.stylelintrc` to `stylelint-config-wordpress` v9.0.0
|
| [6094]
|
johnjamesjacoby
|
Format `bbp_get_reply_title()` like `bbp_get_topic_title()`.
|
| [6095]
|
johnjamesjacoby
|
Only show reply-to drop-down when editing an existing reply.
|
| [6096]
|
johnjamesjacoby
|
Replies: use `appendChild` vs. `insertBefore` for inline JS replies.
Fixes #2971. Props r-a-y.
|
| [6097]
|
johnjamesjacoby
|
Common: Improve title output strings for friendlier i18n.
Props @SergeyBiryukov. Fixes #2852.
|
| [6098]
|
netweb
|
Topics: Call `bbp_move_topic_handler()` when moving a topic to a new forum in the back end.
This changeset ensures that both the source and destination forums meta is updated when a topic is moved.
Fixes #2587.
|
| [6099]
|
netweb
|
Topics: Revert [6098]
This doesn't work, on many levels, when testing a patch make sure the patch your testing matches the same site you're testing with.
Antiprops netweb.
See #2587.
|
| [6100]
|
netweb
|
Build Tools: Switch stylelint Grunt task from `grunt postcss:lint` to `grunt stylelint`
This changeset switches the stylelint task from using the `grunt-postcss` to `grunt-stylelint` NPM module. This new Grunt module supports stylelint's native formatters and allows for improved task error reporting. This change also splits the CSS and SCSS lint tasks in preparation for a future `stylelint-config-wordpress` SCSS update.
See also: https://github.com/wikimedia/grunt-stylelint
Props netweb.
See #2924.
|
| [6101]
|
netweb
|
General - Administration: Introduce bulk actions to spam and unspam topics and replies in wp-admin
This Friday #yolo changeset comes care of the upcoming WordPress 4.7 release via #WP16031 / wp:changeset:38647
Props jmdodd.
See #2246.
|
| [6102]
|
netweb
|
General - Administration: Add i18n text domain missed in [6101]
See #2246.
|
| [6103]
|
netweb
|
Build Tools: Update `grunt-check-dependencies` to v1.0.0
See https://github.com/mgol/grunt-check-dependencies/compare/0.12.0...1.0.0
|
| [6104]
|
netweb
|
Build Tools: Update `autoprefixer` to v6.5.1
See https://github.com/postcss/autoprefixer/compare/6.3.3...6.5.1
|
| [6105]
|
johnjamesjacoby
|
User: Remove `_doing_it_wrong()` notice from `bbp_setup_current_user()`.
The current user is always bootstrapped early in WordPress 4.7, so this notice is no longer valid.
An update for bootstrapping dynamic roles is imminent.
See #2309.
|
| [6106]
|
johnjamesjacoby
|
Roles: Introduce `bbp_roles_init` subaction, and use this for future dynamic roles initialization.
See: #2452;
|
| [6107]
|
johnjamesjacoby
|
Roles: Modify `bbp_add_forums_roles()` to accept a `WP_Roles` object as a parameter.
This allows dynamic roles to be initialized on each call to `wp_roles_init` (for WordPress 4.7) rather than relying on the guesswork of blog-switching, option-sniffing, or user init'ing (none of which have ever been good indicators of roles being initialized.)
See: #2452.
|
| [6108]
|
johnjamesjacoby
|
Roles: Improve performance of `bbp_get_dynamic_roles()` with a local static variable.
Previously, it rebuilt the multidimensional array of role keys & strings each time it was called, which may be several depending on the page being loaded.
See: #2452.
|
| [6109]
|
johnjamesjacoby
|
Favorites/Subscriptions/Moderators: Introduce metadata API for linking multiple users to multiple forums/topics.
Previous to this, connections were stored in `usermeta`. We knew this would not scale, but bbPress 1 had a friendlier database schema & we expected WordPress's taxonomy/relationship roadmap would be farther along by now.
By storing user ID's in `postmeta` instead, we gain an ability to query for connections from both directions without custom MySQL, while also leveraging persistent caching in a more sane way.
This commit includes several new helper functions for low-level relationship management, as well as modifications to existing functions to allow them to continue to work as they always have.
See: #2959.
|
| [6110]
|
netweb
|
Tests: Use `assertEqualSets()` instead of `assertEquals()` in favorites and subscriptions tests.
This changeset improves array comparisons where arrays may not be in the same order.
See #2959.
|
| [6111]
|
netweb
|
Users: Update PHPDoc's for user functions and capabilities.
See #2959.
|
| [6112]
|
netweb
|
Theme Compatibility: Parameter `$in_footer` in `bbp_enqueue_script()` should be boolean.
This changeset updates copy-pasta introduced in [5181], `bbp_enqueue_script()` is a wrapper for `wp_enqueue_script()`, `$in_footer` boolean parameter introduced in wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior.
Props thebrandonallen.
Fixes #3013.
|
| [6113]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
Fixes #2987.
|
| [6114]
|
netweb
|
Users: Include users closed topic counts in `bbp_get_user_topic_count_raw()`
This changeset works around an issue where the lack of custom post statuses support upstream in #WP12706 prevents us from including users closed topics counts in a users raw topic count. See also #meta1870
Props netweb.
Fixes #2978.
|
| [6115]
|
netweb
|
Indentation fixes, tabs, not spaces.
|
| [6116]
|
johnjamesjacoby
|
Roles: Remove overzealous usages of `bbp_add_forums_roles()`.
Now that the `wp_roles_init` action exists, we can rely on bbPress roles being registered an available, and no longer need to re-reinitalize them before trying to interact with them.
See: #2959.
|
| [6117]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify`.
Update uglify-js to v2.7.0. `screwIE8` is enabled by default.
See https://github.com/gruntjs/grunt-contrib-uglify/compare/v1.0.2...v2.0.0
|
| [6118]
|
johnjamesjacoby
|
Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate "role names" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `roles` variable to main bbPress class, and store loaded roles there
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. For trunk (2.6)
|
| [6119]
|
johnjamesjacoby
|
Theme Compat: Support `WP_Hook` class in 2.5 branch.
See #2871, r5945.
|
| [6120]
|
johnjamesjacoby
|
Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate "role names" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. 2.5 branch (for 2.5.11)
|
| [6121]
|
johnjamesjacoby
|
Reference correct hook name in docs. Props netweb. See r5945.
|
| [6122]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.11.
Also add changelog to readme.txt.
|
| [6123]
|
johnjamesjacoby
|
Update `bbpress.pot` for 2.5 branch (for 2.5.11)
|
| [6124]
|
johnjamesjacoby
|
Use new `bbp_translate_role_name()` function in `bbp_get_dynamic_role_name()`. For 2.5 branch (2.5.11)
|
| [6125]
|
johnjamesjacoby
|
Shh... I meant `bbp_translate_user_role()`.
See r6121.
|
| [6126]
|
johnjamesjacoby
|
Tag bbPress 2.5.11.
|
| [6127]
|
johnjamesjacoby
|
Update trunk readme.txt for 2.5.11 release.
|
| [6128]
|
johnjamesjacoby
|
Whitespace for "Screenshots" section of readme.txt.
|
| [6129]
|
johnjamesjacoby
|
Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (Trunk, for 2.6)
|
| [6130]
|
johnjamesjacoby
|
Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (2.5 branch, for 2.5.12)
|
| [6131]
|
netweb
|
Build Tools: Add WordPress 4.7 to Travis CI build matrix
|
| [6132]
|
netweb
|
Build Tools: Add PHP 7.1 to the Travis CI job matrix and remove from `allow_failures` list
|
| [6133]
|
johnjamesjacoby
|
Moderation: First pass at improved reply toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums & Topics @todo)
|
| [6134]
|
johnjamesjacoby
|
Moderation: Rename function to `bbp_get_reply_toggles()` to better match existing naming scheme.
See #3032.
|
| [6135]
|
johnjamesjacoby
|
Tools: Fix undeclared variables and incorrect variable types, for improved PHP 7.1 compatibility.
This will quiet down most of our continuous integration noise.
Props hellofromTonya. Fixes #3031.
|
| [6136]
|
johnjamesjacoby
|
Moderation: Move `sub_action` query var into a passable argument, so all actions can have reliable sub-action usage.
See #3032.
|
| [6137]
|
johnjamesjacoby
|
Moderation: Pass `$reply_id` into `bbp_get_reply_toggles()` so the exacty reply ID can be referenced directly at the time of the filter.
See #3032.
|
| [6138]
|
johnjamesjacoby
|
Moderation: Add error message if reply could not be found or no longer exists.
See #3032.
|
| [6139]
|
johnjamesjacoby
|
Moderation: /s/exists/missing
See #3032.
|
| [6140]
|
johnjamesjacoby
|
Stop shouting at everyone!
|
| [6141]
|
johnjamesjacoby
|
Even less shouting, plus a grammar sweep.
* Remove contractions
* Update weird sounding English phrases (like "the permissions" to "permission")
* Simplify some phrases to be less wordy
* Update "permission" error codes to all use "permission" instead of also "permissions"
* Add comma to "Oh bother!". See: https://www.youtube.com/watch?v=Fhl4oKvxphs
|
| [6142]
|
johnjamesjacoby
|
Moderation: First pass at improved topic toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums @todo)
|
| [6143]
|
johnjamesjacoby
|
Topics: Break apart some lengthy inline conditions. See #3032.
|
| [6144]
|
johnjamesjacoby
|
Whitespace removal.
|
| [6145]
|
netweb
|
Build Tools: Travis CI: Only test PHP 7.1 against WordPress 4.7 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7.1 compatability, which was only added in version 4.7.
|
| [6146]
|
netweb
|
Moderation: Add some missing PHPDoc `@since` revisions
See #3032.
|
| [6147]
|
johnjamesjacoby
|
Roles: Port `bbp_roles_init()` from trunk to 2.5 branch. See: #3028.
|
| [6148]
|
johnjamesjacoby
|
Bump to 2.5.12.
|
| [6149]
|
johnjamesjacoby
|
bbPress 2.5.12 requires WordPress 4.7, as will bbPress 2.6 and higher.
|
| [6150]
|
johnjamesjacoby
|
Tag 2.5.12.
|
| [6151]
|
johnjamesjacoby
|
Update trunk readme.txt with updated version & changelog for 2.5.12.
|
| [6152]
|
xknown
|
Fix parse errors in PHP 7
The result of `new` can't be longer assigned by reference.
|
| [6153]
|
xknown
|
Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
|
| [6154]
|
xknown
|
Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code is compatible with older PHP versions.
- Add also PHP 5.x style constructors.
See #3033
|
| [6155]
|
xknown
|
Fix PHP7 parse error.
The result of `new` can't be longer assigned by reference.
See #3033
|
| [6156]
|
xknown
|
Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6157]
|
xknown
|
Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
|
| [6158]
|
xknown
|
Branch 0.9: use a more recent version of add_query_arg which reduces the use of `func_get_arg`.
See #3033
|
| [6159]
|
xknown
|
Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6160]
|
xknown
|
Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()` and PHP 5.x constructors.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
- Add PHP 5.x style constructors.
- Use `preg_match` instead of `eregi`
See #3033
|
| [6161]
|
xknown
|
Branch 0.9: Use `preg_match` instead of `ereg`
See #3033
|
| [6162]
|
xknown
|
Branch 0.9: Remove all the expressions that use the `preg_replace` function with the `e` modifier.
The `e`(val) modifier is not longer supported in PHP7, use `preg_replace_callback` instead.
See #3033
|
| [6163]
|
xknown
|
Branch 1.2: Fix parse errors in PHP 7
The result of new can't be longer assigned by reference.
See #3033
|