| [5764]
|
netweb
|
Tests: Tests: Skeleton test placeholders for topics topic functions
|
| [5765]
|
netweb
|
Tests: Rename forums forum functions test file name
|
| [5766]
|
netweb
|
Tests: Improved performance and use `bbp_clean_post_cache()` in topics template counts function tests
Props thebrandonallen. See #2081
|
| [5767]
|
netweb
|
Tests: Improved performance of forum component count template function tests
Props thebrandonallen. See #2801
|
| [5768]
|
netweb
|
Topics: Correct PHPDoc in `bbp_bump_topic_reply_count()` and `bbp_bump_topic_reply_count_hidden()` functions
|
| [5769]
|
netweb
|
Tests: Added integer differential bump count assertions to `test_bbp_bump_topic_reply_count()` and `test_bbp_bump_topic_reply_count_hidden()` tests
Props thebrandonallen. See #2801
|
| [5770]
|
johnjamesjacoby
|
Tidy up SVN properties.
* This first steps removes `svn:eol-style`, `svn:executable`, `svn:mime-type` on all files.
* The `svn:ignore` and `svn:global-ignores` properties have been tidied up to match WordPress core.
* A subsequent commit will re-instate `svn:mime-type` via `svn:auto-props`.
Hat-tip DJPaul. See #2802.
|
| [5771]
|
johnjamesjacoby
|
Set `svn-autoprops`.
This was introduced in Subversion 1.8 specifically to allow common properties for all present and future files in the project, and avoids setting individual properties on most files and prevents errors from skipping properties when new files are introduced.
Hat-tip DJPaul. See r5770, #2802.
|
| [5772]
|
johnjamesjacoby
|
Add `.htaccess`, `.DS_Store`, and `.gitignore` to `.gitignore`, taking influence from WordPress core.
Hat-tip netweb. See #2802.
|
| [5773]
|
netweb
|
Tests: Add post meta test assertions to `test_bbp_create_initial_content()`, see #2805
|
| [5774]
|
johnjamesjacoby
|
Cache: Much more sane cache invalidation.
This change improves hierarchical forum/topic/reply cache invalidations by not requiring each call to be strategically placed between actions to avoid race conditions.
Props thebrandonallen. Fixes #2800.
|
| [5775]
|
johnjamesjacoby
|
Inserts: When inserting a forum/topic/reply, immediately update the new object so hierarchy is refreshed.
This commit addresses the last active post ID being incorrect after inserting topics and replies to a forum, and fixes a failing test (in `BBP_Tests_Core_Update::test_bbp_create_initial_content`).
See #2805.
|
| [5776]
|
netweb
|
Topics: Pass correct array value `post_author` to `bbp_update_topic()` in `bbp_insert_topic()` added in r5775
See #2805
|
| [5777]
|
netweb
|
Tests: Fix failing test `test_bbp_update_forum_topic_count()`
Props thebrandonallen. See #2801
|
| [5778]
|
netweb
|
Topics: When moving a topic update the topics post parent in `bbp_move_topic_handler()`, includes unit test `test_bbp_move_topic_handler()`
Props netweb. See #2322
|
| [5779]
|
netweb
|
Tests: Adds forum, topic and reply insert function tests:
* `test_bbp_insert_forum()` for `bbp_insert_forum()`
* `test_bbp_insert_topic()` for `bbp_insert_topic()`
* `test_bbp_insert_reply()` for `bbp_insert_reply()`
Props netweb. Fixes #2805
|
| [5780]
|
netweb
|
Tests: Updated topic component count functions tests
Props thebrandonallen, netweb. See #2801
|
| [5781]
|
netweb
|
Tests: Spam and Unspam reply function tests:
* `test_bbp_spam_reply()` for `bbp_spam_reply()`
* `test_bbp_unspam_reply()` for `bbp_unspam_reply()`
|
| [5782]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_forum_meta()` for `bbp_admin_repair_forum_meta()`
Props netweb. See #2669
|
| [5783]
|
netweb
|
Tools: Forums should not include forum meta key `_bbp_forum_id`, forums with this meta key were due to either:
1) Incorrectly added by the `bbp_admin_repair_forum_meta()` repair tool
2) Incorrectly added by an old version of one of the included bbPress importers, these were fixed in r5526
Props netweb. Fixes #2669
|
| [5784]
|
netweb
|
Tests: Tests for the reply status template functions.
|
| [5785]
|
netweb
|
Tests: Add test `test_bbp_update_topic_forum_id()` for `bbp_update_topic_forum_id()`
|
| [5786]
|
netweb
|
Tests: Tests for the `bbp_get_forum_last_*()` template functions.
|
| [5787]
|
netweb
|
Tests: Test `test_bbp_get_all_child_ids()` for `bbp_get_all_child_ids()`
Props thebrandonallen, netweb. See #2810, #2801
|
| [5788]
|
netweb
|
Common: Include `bbp_get_pending_status_id()` post status for topic and reply post type cases in `bbp_get_all_child_ids()` and PHPDoc fixes including addition of missing `@since` revision
Props netweb. Fixes #2810
|
| [5789]
|
netweb
|
Tests: Remove erroneous assertion in `test_bbp_get_all_child_ids()`
|
| [5790]
|
netweb
|
Common: Updated PHPDocs for `bbp_get_public_child_ids()`
|
| [5791]
|
netweb
|
Tests: Tests for the common component query functions
* `public function test_bbp_get_public_child_ids()` for `bbp_get_public_child_ids()`
* `public function test_bbp_get_public_child_count()` for `bbp_get_public_child_count()`
Props thebrandonallen, netweb. See #2801
|
| [5792]
|
netweb
|
Tests: Updated forum component count functions tests
Props thebrandonallen, netweb. See #2801
|
| [5793]
|
netweb
|
Add `autocomplete="off"` to password field on login widget, user login form, and converter form.
Props pareshradadiya. Fixes #2772
|
| [5794]
|
netweb
|
Tests: Remove instances of `bbp_clean_post_cache()` no longer required in topic template counts tests
Props thebrandonallen. Fixes #2812
|
| [5795]
|
netweb
|
Importers: Update phpbB importer to support phpBB 3.1.x database schema changes
* Note: Importing from phpBB 3.0.x is no longer supported, please update to phpBB 3.1.x before importing
Props netweb. Fixes #2716
|
| [5796]
|
netweb
|
phpBB importer: Include Subscribed Forums, Subscribed Topics and Favourite Topics
Props netweb. See #2668
|
| [5797]
|
netweb
|
phpBB importer: Updated AIM, YIM, and Jabber user meta key prefixes
Props netweb. See #2815
|
| [5798]
|
netweb
|
phpBB Importer: Missed forum total topic and total reply count schema change
See #2716
|
| [5799]
|
netweb
|
Example importer: Change AIM, YIM, and Jabber profile fields to generic examples with meta key prefixes
Props netweb. See #2815
|
| [5800]
|
netweb
|
Importers: Updated AIM, YIM, and Jabber user meta key prefixes importer user profile fields for AEF, FluxBB, Kunena3, MyBB, PunBB, SMF, XMB, vBulletin and vBulletin3 importers
Props netweb. Fixes #2815
|
| [5801]
|
netweb
|
Tests: Update `test_bbp_create_initial_content()` to not use hard coded forum, topic and reply id's.
|
| [5802]
|
johnjamesjacoby
|
Always predefine `$args` as an array, for code consistency across all components.
|
| [5803]
|
netweb
|
Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:31747, WP:changeset:31952, and WP:changeset:32075
* `_variables.scss` via WP:changeset:32051
See #2583
|
| [5804]
|
netweb
|
Update Grunt dependencies in package.json:
* `grunt-checktextdomain` major version update (Improved task error handing)
* `grunt-contrib-jshint` patch version update
* `grunt-contrib-uglify` minor version update (causes some changes to minified JS)
* `grunt-sass` major version update ( underlying libsass update )
* `grunt-wp-i18n` patch version update
Fixes #2821
|
| [5805]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.6 (trunk)
|
| [5806]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.5.8 (2.5 branch)
|
| [5807]
|
johnjamesjacoby
|
BuddyPress Groups: Backport r5560 to 2.5 branch (for 2.5.8) for improved PHP5 compatibility and to avoid a debug notice.
Props boonebgorges.
|
| [5808]
|
johnjamesjacoby
|
Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.5.8 (2.5 branch)
|
| [5809]
|
johnjamesjacoby
|
Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.6.0 (trunk)
|
| [5810]
|
netweb
|
Admin: Updated Topic and Reply contextual help
Props robkk. Fixes #2824
|
| [5811]
|
netweb
|
Topics: Fix `bbp_get_topic_post_date()` default GMT date format copy pasta introduced in r4647, includes unit tests.
Props tobyhawkins. Fixes #2697
|
| [5812]
|
netweb
|
Tests: Tests for the common component common functions
Props netweb
|
| [5813]
|
johnjamesjacoby
|
Users: Remove `is_email()` check from user query parsing.
This commit removes the ability to load a user profile via their email address. This feature (added in r2917) was a convenience mechanism to make finding a user within the forums with a known address easier, but times have changed and we now consider this to be a privacy concern by default.
Note: this will break backwards-compatibility for installations that may have used this unpublicized (and regrettably unwise) feature.
See #2828. Hat-tip netweb. For 2.6 (trunk)
|
| [5814]
|
johnjamesjacoby
|
Users: Remove `is_email()` check from user query parsing.
This commit removes the ability to load a user profile via their email address. This feature (added in r2917) was a convenience mechanism to make finding a user within the forums with a known address easier, but times have changed and we now consider this to be a privacy concern by default.
Note: this will break backwards-compatibility for installations that may have used this unpublicized (and regrettably unwise) feature.
Fixes #2828. Hat-tip netweb. For 2.5.8 (2.5 branch)
|
| [5815]
|
johnjamesjacoby
|
Users: Use `bbp_get_user_profile_url()` to avoid code duplication.
This commit removes duplicated code used to build user profile URLs & eliminates several superfluous string replacements. It works with pretty & unpretty permalinks, and plays nicely with the BuddyPress extension for linking to a member's forum sections.
Fixes #2831.
|
| [5816]
|
netweb
|
Bump 2.5 branch to 2.5.8.
|
| [5817]
|
netweb
|
Update bbpress.pot in 2.5 branch.
|
| [5818]
|
netweb
|
Create tag 2.5.8.
|
| [5819]
|
netweb
|
Include 2.5.8 in readme.txt changelog (for trunk) and bump stable tag
|
| [5820]
|
johnjamesjacoby
|
Queries: Remove `post_parent__in` query-parameter filter.
This commit removes the `bbp_query_post_parent__in()` filter that was introduced in r2996, and uses WordPress core's built in query parameters introduced in #WP11056.
Fixes #2832.
|
| [5821]
|
johnjamesjacoby
|
Make a statement without saying a word. (!)
|
| [5822]
|
johnjamesjacoby
|
BuddyPress: Use `bbp_get_paged_slug()` instead of `$wp_rewrite->pagination_base` directly.
|
| [5823]
|
johnjamesjacoby
|
Introduce `core/abstraction.php` to provide a layer of protection against touching common WordPress global variables directly.
This commit introduces a few new helper functions to protect sensitive global variables, and also introduces the ability to filter and override them explicitly within the scope of the bbPress plugin. These functions will be used in place of existing global touches in future commits.
See #2786.
|
| [5824]
|
johnjamesjacoby
|
Remove incorrect `@global` tag in `BBP_Akismet::submit_post()`.
|
| [5825]
|
johnjamesjacoby
|
Update incorrect phpdoc block in `bbp_update_reply_position()`.
|
| [5826]
|
johnjamesjacoby
|
Introduce `bbp_get_global_object()` to help with verifying & retrieving global variables before interacting with them. See #2786.
|
| [5827]
|
johnjamesjacoby
|
Abstraction: Use `bbp_db()`, `bbp_rewrite()` & friends, introduced in r5823 & r5826.
This commit improves the stability of bbPress in the WordPress environment by reducing global variable exposure. It also comes with minimal opcode improvements in some circumstances where `$GLOBALS` is preferred over defining via `global` statements.
Some additional surrounding cleanup directly related to functions & methods being altered is also being performed here.
Fixes #2786.
|
| [5828]
|
johnjamesjacoby
|
Akismet: Clean up potential accidental inline assignment in `BBP_Akismet::check_post()`.
This commit moves a variable assignment out of a comparison to improve code clarity.
|
| [5829]
|
johnjamesjacoby
|
I think this building should be condemned. There's serious metal fatigue in all the load-bearing members, the wiring is substandard, it's completely inadequate for our power needs, and the neighborhood is like a demilitarized zone.
|
| [5830]
|
netweb
|
Bump tested-up-to version to 4.2. (trunk)
|
| [5831]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_topic_voice_count()` for `bbp_admin_repair_topic_voice_count()`
Props netweb. See #2533
|
| [5832]
|
johnjamesjacoby
|
Add future support for forum/topic/reply dashicon column headers to `admin.css`.
|
| [5833]
|
johnjamesjacoby
|
Add ability to use icons as column headers ala Comment bubbles (off by default.)
|
| [5834]
|
johnjamesjacoby
|
Moderators: First pass at per-forum moderators.
This commit introduces a powerful feature commonly found in other popular forum software that has been on our wishlist for nearly 9 years. It includes the following changes:
* Custom `forum-mod` taxonomy for assigning user nicenames to forum IDs
* Associated functions for defining capabilities, labels, etc...
* New capability filters for ensuring forum moderators have the ability to moderate forums even without the `moderator` role assignment
* New option for toggling the entire feature on/off (on by default)
Props jmdodd, netweb. See #459.
|
| [5835]
|
johnjamesjacoby
|
Moderators: Introduce `none` argument for topic-tags & forum-mods list functions.
This change allows for passing text or HTML to output if no taxonomy terms are found, and uses this new functionality in `wp-admin` to show per-forum moderators in the list-table column, also reducing code duplication.
See #459.
|
| [5836]
|
johnjamesjacoby
|
Moderators: Add forum moderators field to `form-forum.php` template part. See #459.
|
| [5837]
|
johnjamesjacoby
|
Terms: Update functions for getting terms & term names to be more flexible & reusable by other functions. See #459.
|
| [5838]
|
johnjamesjacoby
|
Moderators: Introduce functions for theme-side setting & getting of forum mods for `form-forum.php`. See #459.
|
| [5839]
|
johnjamesjacoby
|
Moderators: Rename `bbp_get_forum_mod_ids()` to `bbp_get_forum_moderator_ids()` to better match unabbreviated forum equivalent. Also update phpdoc & refactor some logic to use cached functions. See #459.
|
| [5840]
|
johnjamesjacoby
|
In `BBP_Akismet::filter_post_terms()` use `bbp_get_topic_tag_names()` to use cached function instead of querying for object terms.
|
| [5841]
|
johnjamesjacoby
|
Moderation: Fix some copy-pasta and make sure form terms are formatted correctly. See #459.
|
| [5842]
|
johnjamesjacoby
|
IDs: Some reply functions still default to their topics if no replies are present. This functionality has slowly been removed over time and built into respective functions. In this changeset, we remove those leftover assignments and update a few phpdoc descriptions as needed.
Hat-tip netweb. See #2806.
|
| [5843]
|
johnjamesjacoby
|
Installation: When creating initial content, use the same `current_time( 'mysql' )` for all new posts.
This changeset prevents the related unit test from incorrectly failing by ensuring that no initial content is created 1 second after any other.
|
| [5844]
|
johnjamesjacoby
|
Add unit test for last topic & reply ID's for topics & forums. Fixes #2806. Props netweb.
|
| [5845]
|
johnjamesjacoby
|
Widgets: Add class to forum widget to indicate if item in list is the current forum being viewed.
Props dimitrov.adrian, netweb. Fixes #2536.
|
| [5846]
|
johnjamesjacoby
|
BuddyPress: Do not filter profile URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress was network activated and bbPress was active on the non-root blog.
Props imath. See #2713.
|
| [5847]
|
johnjamesjacoby
|
BuddyPress: Do not filter admin toolbar URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress is network activated and bbPress is active on the non-root blog.
Props imath. Fixes #2713.
|
| [5848]
|
johnjamesjacoby
|
BuddyPress: Pass the currently logged in user ID when creating toolbar links. See #2713.
|
| [5849]
|
johnjamesjacoby
|
BuddyPress: Add all topic statuses to `bbp_filter_modify_page_title()`.
This changeset fixes a bug that only allowed published topics to be queried in group forums.
Props netweb. Fixes #2699.
|
| [5850]
|
johnjamesjacoby
|
Admin: Add `hidden_post_status` field back to topic & reply metaboxes, and use `draft` or current post status as value.
This changeset fixes a bug that caused topics & replies to be marked as edited when moderated via `wp-admin`.
Hat-tip tharsheblows. Fixes #2741.
|
| [5851]
|
johnjamesjacoby
|
Admin: Check that the user can view the About page before adding the toolbar item.
This changeset ensures that only capable users will see the link to bbPress's admin-area "About" page.
Props ocean90. Fixes #2836.
|
| [5852]
|
johnjamesjacoby
|
Capabilities: add `delete_posts` mappings to `delete` topic & reply checks.
This changeset ensures that capable users can delete their own topics & replies, when these capabilities are explicitly allowed already.
Props netweb, gusrb84. Fixes #2685.
|
| [5853]
|
johnjamesjacoby
|
Moderation: reduce moderation restriction from `keep-gate` to `moderate` in `bbp_check_for_moderation()`.
This changeset ensures that moderators are able to bypass the forum moderation, seeing as how they can self-approve topics & replies anyways.
Props netweb. Fixes #2726.
|
| [5854]
|
johnjamesjacoby
|
Templates: Add before & after hooks to user templates parts.
This changeset makes it easier to add custom text & HTML before & after user details.
Props netweb. Fixes #2537.
|
| [5855]
|
johnjamesjacoby
|
Forums: Fix copy-pasta filter names.
This changeset corrects filters used in 2 `apply_filters()` calls to properly match their function names.
Props netweb. Fixes #2688.
|
| [5856]
|
johnjamesjacoby
|
Forums: Introduce `bbp_update_forum_visibility` action in `bbp_save_forum_extras()`
This changeset provides custom visibilites with an execution point to perform their own actions.
Fixes #2740.
|
| [5857]
|
johnjamesjacoby
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y. Fixes #2690.
|
| [5858]
|
johnjamesjacoby
|
Queries: Clean up post status concatenation in 2 queries.
This changeset moves array of "hidden" type post-statuses into their own variable to better match existing usages.
Fixes #2826.
|
| [5859]
|
johnjamesjacoby
|
Replies: fallback on `post_parent` in `bbp_update_reply_walker()`.
This changeset fixes a bug where topic reply counts were not updated when replies were permanently deleted, causing hidden reply counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [5860]
|
johnjamesjacoby
|
Topics: fallback on `post_parent` in `bbp_update_topic_walker()`.
This changeset fixes a bug where forum topic counts were not updated when topics were permanently deleted, causing hidden topic counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [5861]
|
netweb
|
Tests: Remove unused test assertion `test_bbp_get_forum_last_reply_id()`
|
| [5862]
|
netweb
|
Moderators: Add missing @since PHPDoc missed in `bbp_map_forum_mod_meta_caps()` via r5834
|
| [5863]
|
netweb
|
Tests: When creating posts that use date/time assertions use a concise post date/time.
This changeset prevents the related unit test from incorrectly failing by ensuring that no content is created 1 second after any other.
|