| [5664]
|
johnjamesjacoby
|
Users: Clean up email message string replacements in `bbp_edit_user_email_send_notification()`. See #2780.
|
| [5665]
|
johnjamesjacoby
|
Users: Update filter name in `bbp_edit_user_email_send_notification()` to be a bit more clear. See #2780.
|
| [5666]
|
johnjamesjacoby
|
Users: Add missing textdomains to new strings. See #2780.
|
| [5667]
|
netweb
|
Topics: Update `bbp_open_topic()` and `bbp_close_topic()` `@uses` documentation missed in r5656
See #2653
|
| [5668]
|
netweb
|
Tools: Introduce "Repair closed topics tool" `bbp_admin_repair_closed_topics()`
See #2653
|
| [5669]
|
netweb
|
Topics: Fix missing meta data during new closed topic creation
* In `bbp_new_topic_handler()` check if the post status is `closed` and close using `bbp_close_topic()`
* In `bbp_close_topic()` allow topics to be properly closed if `_bbp_status` is missing from topic meta
Props netweb. Fixes #2653
|
| [5670]
|
netweb
|
Fix i18n `_n()` plurals placeholders missed in r5668 in `bbp_admin_repair_closed_topics()`
|
| [5671]
|
netweb
|
Remove `BBP_UnitTestCase::knownBBPBug` PHPUnit tests support for bbPress unclosed Trac tickets.
See #WP30284 and #BuddyPress6223
|
| [5672]
|
netweb
|
Exclude BuddyPress tests when running `phpunit`
BuddyPress unit testing will conflict with stand alone bbPress user testing, when BuddyPress is active the core members component cannot be deactivated thus testing users with BuddyPress at `/member/username` vs bbPress only `/user/username` and custom rewrites `/custom-user-slug/username` will cause conflicts in user PHPUnit tests.
A new Grunt sub task `grunt phpunit:buddypress` has been added to test BuddyPress integration with bbPress without compromising bbPress standalone PHPUnit testing.
Props netweb. See #2782
|
| [5673]
|
netweb
|
Add support for BuddyPress PHPUnit test integration
* Bootstrap and load `/src/bbpress.php` when loading the test environment
* Detect and load BuddyPress when running the BuddyPress PHPUnit tests
* Setup `BP_UnitTest_Factory` in `BBP_UnitTestCase` during new BuddyPress PHPUnit test integration
* Bootstrap and load new factory class `BBP_UnitTest_Factory_For_Forum` for creating forums
Props boonebgorges. See #2782
|
| [5674]
|
johnjamesjacoby
|
Topics: Normalize admin links:
* Remove superfluous `(int)` type cast
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [5676]
|
johnjamesjacoby
|
All: Update default values for `$args` parameters from empty strings to empty arrays.
This is a micro-optimization to avoid unnecessary calls to `wp_parse_str()` inside `bbp_parse_args()`.
|
| [5677]
|
netweb
|
Tests: Add PHPUnit factory's for topics and replies:
* New class `BBP_UnitTest_Factory_For_Topic` for creating topics in PHPUnit tests
* New class `BBP_UnitTest_Factory_For_Reply` for creating replies in PHPUnit tests
|
| [5678]
|
netweb
|
Tests: Remove `bbp_create_initial_content()` from `tests/phpunit/includes/install.php`
* WordPress' test suite resets post and taxonomy content between each test via `WP_UnitTestCase::setUp`
|
| [5679]
|
netweb
|
Tests: Code formatting improvements to `BBP_UnitTestCase`
* Remove whitespace surrounding array keys
* Remove whitespace in cast statements
* Whitespace beside `!` operators
* Yoda conditions
|
| [5680]
|
johnjamesjacoby
|
Topics: Audit `template.php`:
* Add filters to `is_sticky` functions
* Pass `$args` into more filters
* Escape more gettext output
* Fix a few `bbp_parse_args` filter names copied from forums component
* Un-nest a few complex-looking lines
|
| [5681]
|
johnjamesjacoby
|
Topics: Use `sanitize_key()` on `select_id` in dropdown helpers.
|
| [5682]
|
johnjamesjacoby
|
Topics: Move `is_sticky` functions to above open/closed functions
|
| [5683]
|
johnjamesjacoby
|
Forums: Audit `template.php`:
* General code formatting improvements
* Pass `$args` into more filters
* Escape more gettext output
* Un-nest a few complex-looking lines
|
| [5684]
|
johnjamesjacoby
|
General: Use `sanitize_text_field()` in lieu of old-bbPress style pre-escaping technique.
|
| [5685]
|
johnjamesjacoby
|
Common: Login actions:
* Extract functionality from `bbp_wp_login_action()` into a getter: `bbp_get_wp_login_action()`
* Update arguments in`bbp_get_wp_login_action()` to include optional `url` override
* Pass original `$args` into login action filter
* Also improve support for empty separator in breadcrumbs
|
| [5686]
|
netweb
|
Fix missing @since revision in `bbp_is_forum_visibility()`
|
| [5687]
|
netweb
|
Tests: Add factory support for parsing meta arguments from forum, topic, and reply `::create_object` factories in `BBP_UnitTestCase` testcases.
|
| [5688]
|
johnjamesjacoby
|
Templates: Escape all gettext output in `default` template parts. See #1999.
|
| [5689]
|
johnjamesjacoby
|
Templates: Micro-optimizations:
* Remove trailing `?>` tag in some template parts
* Remove preceding `?> <?php` in some template parts, after phpdoc header
* Remove whitespace where superfluous
* Reduce number of indentations in some template parts
|
| [5690]
|
netweb
|
SVN: Remove invalid SVN property `sv:eol-style` from image files in `/branches/2.0` and `/tags/2.0.x`
|
| [5691]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (trunk) and cleanup some phpdoc
Also introduce `bbp_dropdown` class for dropdowns.
|
| [5692]
|
johnjamesjacoby
|
All: ensure all URLs are escaped (2.5 branch)
|
| [5693]
|
johnjamesjacoby
|
All: ensure all URLs are escaped part 2 (2.5 branch)
|
| [5694]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.7
|
| [5695]
|
johnjamesjacoby
|
Update `bbpress.pot` in 2.5 branch.
|
| [5696]
|
johnjamesjacoby
|
Include `2.5.7` in `readme.txt` changelog (for trunk) and bump stable tag
|
| [5697]
|
johnjamesjacoby
|
Tag 2.5.7 from 2.5 branch.
|
| [5698]
|
johnjamesjacoby
|
Update `get` version of `wp_login_action`.
|
| [5699]
|
netweb
|
Tests: Travis CI Improvements
* Brings `.travis.yml` configuration up to speed with BuddyPress'
* Preliminary support for side-by-side BuddyPress testing integration
Props netweb. See #2782
|
| [5700]
|
netweb
|
Tests: Initial unit tests for `/includes/forums/template.php`
|
| [5701]
|
netweb
|
Tests: Author unit tests for `/includes/forums/template.php`
|
| [5702]
|
netweb
|
Tests: Forum unit tests for `/includes/forums/template.php`
|
| [5703]
|
netweb
|
Tests: Initial unit tests for users component
* User counts functions `/includes/users/functions.php` and `/includes/users/options.php`
* User favorites skeleton tests placeholder functions
* User subscriptions skeleton tests placeholder functions
* User counts template functions `/includes/users/template.php`
|
| [5704]
|
netweb
|
Tests: SVN rename `/tests/phpunit/testcases/user` to `/tests/phpunit/testcase/users` to match `/src` folder naming structure
|
| [5705]
|
johnjamesjacoby
|
Topics: Check for correct `$integer` request value, so the correct filter is applied. Fixes #2791.
|
| [5706]
|
johnjamesjacoby
|
Tests: Fix all of the tests but 2, which are todo's. See r5703.
|
| [5707]
|
netweb
|
Tests: Forum counts and query functions `/includes/forums/functions.php`
|
| [5708]
|
johnjamesjacoby
|
Tests: Fix more of the tests. See r5703.
|
| [5709]
|
johnjamesjacoby
|
Topics: Filter `bbp_get_forum_topic_count_hidden` to format the output, to match other count functions.
|
| [5710]
|
netweb
|
Tests: Fix forums functions tests:
* Fix `test_bbp_bump_forum_topic_count_hidden` per r5709
* Replace some debug comments in `test_bbp_update_forum_topic_count`
|
| [5711]
|
johnjamesjacoby
|
Common: Use `esc_url()` in `bbp_redirect_to_field()` and late escape for clarity.
|
| [5712]
|
netweb
|
Install/Update: Don't add reply titles in sample forum content `bbp_create_initial_content()`, reply title requirements were removed in r5177.
Props netweb. Fixes #2795
|
| [5713]
|
netweb
|
Tests: Core Update initial pass unit tests for /includes/core/update.php
|
| [5714]
|
netweb
|
Topics: Filter `bbp_get_topic_reply_count_hidden` to format the output, to match other count functions.
|
| [5715]
|
netweb
|
Tests: Fix copy pasta in forums count functions tests:
* `test_bbp_update_forum_topic_count_hidden()`
* `test_bbp_update_forum_reply_count()`
|
| [5716]
|
netweb
|
Tests: Tests for the topic component count functions `/includes/topics/template.php`
|
| [5717]
|
netweb
|
Tests: Tests for the topic component count template functions `/includes/topics/template.php`
|
| [5718]
|
netweb
|
Add missing @since phpdoc to `bbp_get_public_child_count()` and `bbp_get_public_child_ids()` functions
|
| [5719]
|
netweb
|
Tests: Remove copy pasta parameters to fix topic count tests
* Manually flush the cache, our setup/teardown needs more work here.
Props thebrandonallen. Fixes #2796
|
| [5720]
|
netweb
|
Tests: Skip feed URL tests in multisite for now, we need a more robust permalink test setup first.
|
| [5721]
|
netweb
|
Tests: Forum template tests:
* Skip forum URL tests in multisite for now, we need a more robust permalink test setup first.
* Remove a couple of poorly architected tests so our tests pass
|
| [5722]
|
netweb
|
Tests: Topic and Reply post type template function unit tests
|
| [5723]
|
netweb
|
Tests: Topic and Reply authors template function unit tests
|
| [5724]
|
netweb
|
Tests: Topic and Reply forms template function unit tests
|
| [5725]
|
netweb
|
Tests: Topic and Reply loop template function unit tests
|
| [5726]
|
netweb
|
Tests: Topic and Reply revisions template function unit tests
|
| [5727]
|
netweb
|
Add `bbp_rel_nofollow` and `wp_unslash` filters to `bbp_get_topic_reply_link` and `bbp_get_reply_to_link` topic reply links.
Props netweb. Fixes #2515
|
| [5728]
|
netweb
|
Fix copy pasta placeholder argument in `loop-single-topic.php` template
Props netweb. Fixes #2799
|
| [5729]
|
johnjamesjacoby
|
Topics: In `bbp_move_topic_handler()`, clean both old and new forum caches before updating forum hierarchies.
Fixes issue where moving a topic would result in incorrect counts for both forums, due to out-of-date cache values.
Props thebrandonallen. Fixes #2322.
|
| [5730]
|
johnjamesjacoby
|
Common: Additional type-casting in query functions.
Ensures direct query results return a consistent, testable value.
Props thebrandonallen, netweb. See #2801.
|
| [5731]
|
johnjamesjacoby
|
Forums: Normalize type-casting in some count functions. More to do here.
Props thebrandonallen, netweb. See #2801.
|
| [5732]
|
johnjamesjacoby
|
Bumps: Normalize type-casting in bump functions.
Props thebrandonallen, netweb. See #2801.
|
| [5733]
|
johnjamesjacoby
|
Core: Force-clear post caches on several common moderation actions.
Fixes inconsistencies around cached objects related to counts, which are currently stored in metadata.
Props thebrandonallen, netweb. See #2801.
|
| [5734]
|
johnjamesjacoby
|
Forums: Type-cast improvements to `bbp_forum_query_last_reply_id()`.
Fixes bug where strict `false` comparison would cache cache condition to never occur.
Props thebrandonallen, netweb. See #2801.
|
| [5735]
|
johnjamesjacoby
|
Core: Return the filtered results of ID's in core `_update_` functions.
This helps with various type-casting improvements going into #2801.
|
| [5736]
|
johnjamesjacoby
|
Core: Correct phpdoc to `_update_` functions. Also introduce `bbp_update_reply_to_id()` to help with saving of hierarchical reply metadata. (Will be used in a future commit.)
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5738]
|
johnjamesjacoby
|
Topics: Improve type-casting in topic functions.
Props thebrandonallen, netweb. See #2801.
|
| [5739]
|
johnjamesjacoby
|
Common: Improve type-casting return values in query functions.
Props thebrandonallen, netweb. See #2801.
|
| [5740]
|
netweb
|
Tests: Test an array of posts not the total post counts:
* Test the forum's topic ids in `test_bbp_forum_query_topic_ids()`
* Test the forum's subforum ids in `test_bbp_forum_query_subforum_ids()`
Props thebrandonallen, netweb. See #2801
|
| [5741]
|
netweb
|
Tests: Improved performance of user component count function tests, now 33⅓% faster
Props thebrandonallen. See #2081
|
| [5742]
|
netweb
|
Tests: Skeleton test placeholders for forum visibility functions.
|
| [5743]
|
netweb
|
Tests: Skeleton test placeholders for forum statuses and types functions
|
| [5744]
|
netweb
|
Tests: Tests: Skeleton test placeholders for forums forum functions
|
| [5745]
|
netweb
|
Tests: Skeleton test placeholders for forum update last functions
|
| [5746]
|
netweb
|
Tests: Add post type object and hierarchical test assertions for forum, topic and reply post types.
|
| [5747]
|
netweb
|
Tests: Rename user favorites test class, favorites ends in a single `s`
|
| [5748]
|
netweb
|
Tests: Skeleton test placeholders for user component functions.
|
| [5749]
|
netweb
|
Tests: Skeleton test placeholders for topic status template functions.
|
| [5750]
|
netweb
|
Tests: Skeleton test placeholders for topic tag template functions.
|
| [5751]
|
netweb
|
Tests: Skeleton test placeholders for topic get last template functions
|
| [5752]
|
netweb
|
Tests: Skeleton test placeholders for topic link template functions
|
| [5753]
|
netweb
|
Tests: Skeleton test placeholders for topic template functions
|
| [5754]
|
netweb
|
Tests: Skeleton test placeholders for search functions and template functions
|
| [5755]
|
netweb
|
Tests: Remove incorrect class prefix from `@covers` annotations in user functions tests
|
| [5756]
|
netweb
|
Tests: Fix duplicate `@group` annotation for topic tags template function tests
|
| [5757]
|
netweb
|
Tests: Skeleton test placeholders for topic tag functions.
|
| [5758]
|
netweb
|
Tests: Skeleton test placeholders for reply link template functions
|
| [5759]
|
netweb
|
Tests: Skeleton test placeholders for reply template functions
|
| [5760]
|
netweb
|
Tests: Skeleton test placeholders for topic update last functions
|
| [5761]
|
netweb
|
Tests: Skeleton test placeholders for topic status functions.
|
| [5762]
|
netweb
|
Tests: Skeleton test placeholders for reply status functions.
|
| [5763]
|
netweb
|
Tests: Tests: Skeleton test placeholders for replies reply functions
|