| [4964]
|
johnjamesjacoby
|
In bbp_update_reply_to(), allow $reply_to to be 0 and delete if it's being set to empty. See #2340.
|
| [4965]
|
johnjamesjacoby
|
In bbp_update_reply_to(), allow $reply_to to be 0 and delete if it's being set to empty. See #2340.
|
| [4966]
|
johnjamesjacoby
|
Add topic reply link template functions. See #2340.
|
| [4967]
|
johnjamesjacoby
|
Consolidate global-access and default role into 1 line-item in forum settings.
|
| [4968]
|
johnjamesjacoby
|
Split "Main" settings up into "User" and "Features" - also tweak fancy editor verbiage to add more context.
|
| [4969]
|
johnjamesjacoby
|
Pluralize user settings ID to match existing naming conventions.
|
| [4970]
|
johnjamesjacoby
|
Topic and reply admin links don't work correctly from search results pages yet, so remove the output and logic from default template parts.
|
| [4971]
|
johnjamesjacoby
|
Allow the search feature to be toggled on and off. Introduces new setting and supporting function to get and override the option easily in third party plugins. Fixes #2342.
|
| [4972]
|
johnjamesjacoby
|
Tweak theme compatibility to hook to loop_start and loop_end, to maximize compatibility with third party plugins and existing WordPress themes. Props r-a-y for the proof of concept with BuddyPress.
|
| [4973]
|
johnjamesjacoby
|
Add bbp_is_single_topic() check to topic pagination count, before using threaded count output. Fixes issue where threaded output would incorrectly appear on user profile replies. See #2340.
|
| [4974]
|
johnjamesjacoby
|
Replace the_content() with bbp_forum_content() where appropriate. Fixes recursion issues introduced in r4792, as part of http://buddypress.trac.wordpress.org/ticket/5021
|
| [4975]
|
johnjamesjacoby
|
Theme Compatibility improvements:
* Introduce helper functions to set and check a located root template, to aid in turning off theme-compat.
* Introduce bbp_do_theme_compat() which checks if we're in the main loop, and the $post global has been primed with theme-compat dummy data.
* Use WP_Post in bbp_theme_compat_reset_post(), and clean up this function a bit.
* Set theme_compat active to false after bbp_replace_the_content() has started, to avoid recursing through nested 'the_content' filter usages.
* Refactor output buffering used in bbp_replace_the_content() to clean up shortcode usages.
* See #2343.
|
| [4976]
|
johnjamesjacoby
|
Try theme compat without adding and removing all of the filters from the_content. Now that theme compatibility has matured, this may not be necessary anymore. See #2343.
|
| [4977]
|
johnjamesjacoby
|
Remove esc_attr() from bbp_get_displayed_user_field(), and practice late escaping where appropriate instead. See #4959.
|
| [4978]
|
johnjamesjacoby
|
Use the forum content in search results, and not the_excerpt() to avoid recursed calls to 'the_content'. See #2343.
|
| [4979]
|
johnjamesjacoby
|
Add $filter parameter and supporting phpdoc to bbp_displayed_user_field() && bbp_get_displayed_user_field() to allow more accurate sanitization of displayed user field values. Remove superfluous isset() check. Use 'edit' parameter in form-user-edit.php. See #1999.
|
| [4980]
|
johnjamesjacoby
|
Revert accidental test field change from r4979. See #1999.
|
| [4981]
|
johnjamesjacoby
|
Use raw user-data values in bbp_edit_user_handler(). See #1999.
|
| [4982]
|
johnjamesjacoby
|
Remove duplicate escaping from user-details.php, now that fields are automatically sanitized for display. See #1999.
|
| [4983]
|
johnjamesjacoby
|
Clean up bbp_get_displayed_user_field(). See #1999.
|
| [4984]
|
johnjamesjacoby
|
Fix incorrect filter name in bbp_get_user_profile_edit_link().
|
| [4985]
|
johnjamesjacoby
|
Remove capability pre-check from admin links functions. Remove duplicate trash-removal logic that's done inside the respective trash-link generating functions. Fixes inconsistent nested capability checks within admin link functions. See #2348.
|
| [4986]
|
johnjamesjacoby
|
When posting long single lines of code (meaning pre tags are not used to aid in formatting) they will break onto several lines if they are longer than the container element allows.
This changeset tweaks the CSS to allow code tags to scroll, and limit the width to 95%. Fixes #2350.
|
| [4987]
|
johnjamesjacoby
|
When super sticky topics exist in private or hidden forums, they currently always appear in topic-index listings, even when the current user cannot access them.
This changeset adds 'post_parent__not_in' to the super-sticky post query parameters, to exclude topics that are within private/hidden forums the current user cannot access. Fixes #2173.
|
| [4988]
|
johnjamesjacoby
|
Move $postarr arrays into their respective calls to wp_update_post().
|
| [4989]
|
johnjamesjacoby
|
Practice late escaping in bbp_get_dropdown() to make it more clear that attributes are escaped.
|
| [4990]
|
johnjamesjacoby
|
In the _insert_ and _handler_ functions, do some one-time-use variable clean-up, and add some brackets for improved readability.
|
| [4991]
|
johnjamesjacoby
|
Normalize topic and reply admin method names. Some of them were still prefixed from back when all admin methods were in 1 mega-class.
|
| [4992]
|
johnjamesjacoby
|
Use wp_update_post() in bbp_update_reply_position(), instead of $wpdb->update(). Ensures that post caches are cleared when manually updating a reply position via its menu_order property. See #2351.
|
| [4993]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-4993.
|
| [4994]
|
johnjamesjacoby
|
Use bbPress functions for getting the reply and topic author ID instead of using get_the_author_meta( 'ID' ). Allows for strict comparisons and uses bbPress's filters for the related functions.
|
| [4995]
|
johnjamesjacoby
|
Use strict comparisons where possible (excluding the converter code, as it needs dedicated testing.) See #2358.
|
| [4996]
|
johnjamesjacoby
|
Replace generic stdClass usages with correct object types.
Fixes debug notices with bbp_get_displayed_user_field() when requesting non-existing fields or when there is no displayed user, by allowing the magic __get() methods of the WP_User class to bail if the field is not set.
Also prevents similar issues with main query loops. Fixes #2359.
|
| [4997]
|
johnjamesjacoby
|
Make search results page use pretty permalinks if they are enabled:
* Change search form method from "get" to "post"
* Move 'bbp_search_request_redirect' action to 'bbp_post_request' to avoid recursion.
* Tweak bbp_search_request_redirect() to check for pretty permalinks, and remove now superfluous recursion checks.
* See #2337.
|
| [4998]
|
johnjamesjacoby
|
Introduce bbp_find_mentions_pattern() function to make it easier to change the pattern to match usernames against. Helpful for non-latin characters. Also add additional filter to bbp_find_mentions() to allow for late filtering of results. Props aliso. Fixes #2226.
|
| [4999]
|
johnjamesjacoby
|
Since search requests get existing data, and do not post new data, revert part of r4997 and switch request method back to "get".
Add hidden 'action' field to form-search.php template-part, and move 'bbp_search_results_redirect' action from 'bbp_post_request' to 'bbp_get_request'.
Fixes issue with request not redirecting properly, and uses more accurate form method. See #2337.
|
| [5000]
|
johnjamesjacoby
|
Revert part of r4995 that introduced strict comparisons in bbp_get_time_since() against return values of floor(), which returns a float. See #2358.
|
| [5001]
|
johnjamesjacoby
|
For inline code blocks in topics and replies, ensure they are vertically positioned in the middle of their respective lines of text. Fixes issue where code snippets were top-aligned based on paragraph line-height. See #2350.
|
| [5002]
|
johnjamesjacoby
|
Constans album spatium. Consistent whitespace handling of foreach usages.
|
| [5003]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-5003.
|
| [5004]
|
johnjamesjacoby
|
Use the correct filter ID string in bbp_get_forum_pagination_count(). Props mrcl. Fixes #2362.
|
| [5005]
|
johnjamesjacoby
|
Use the correct array index string in bbp_get_breadcrumb() ( 'current_text' VS 'pre_current_text' ). Props mrcl. Fixes #2361.
|
| [5006]
|
johnjamesjacoby
|
Make sure that topics and replies in private/hidden forums are excluded from the "insert links" dialogue window. Hat tip jaredatch. See #2334.
|
| [5007]
|
johnjamesjacoby
|
Additional CSS resets to improve theme compatibility for search and list items. Props jaredatch. Fixes #2283.
|
| [5008]
|
bumpbot
|
Compress scripts/styles: 2.4-alpha-5008.
|
| [5009]
|
johnjamesjacoby
|
Introduce additional forum/topic ID validation when posting new topics and replies. Prevents empty/negative/non-existent post_parent. Fixes #2363.
|
| [5010]
|
johnjamesjacoby
|
In bbp_get_dropdown(), remove the hard-coded post_status checker, and trust bbp_pre_get_posts_normalize_forum_visibility() to do its job. We still pass 'post_status' as null, so that get_posts() gets passed the results of bbp_parse_args(). Also, remove 'sort_column' array key from when this used get_pages(), and rely on 'orderby' for get_posts() instead.
In bbp_pre_get_posts_normalize_forum_visibility(), remove empties and duplicates from the $post_stati array.
Fixes #2354.
|
| [5011]
|
johnjamesjacoby
|
When saving a user's profile, their 'admin_bar_front' setting is accidentally wiped out by edit_user(), because the form field does not exist in bbPress's template parts.
In bbp_edit_user_handler(), check if the user has this setting; if so, add it to the $_POST superglobal to allow edit_user() to function normally.
Fixes #2364. Props imath.
|
| [5012]
|
johnjamesjacoby
|
Allow topic form shortcode to accept a forum_id attribute. Props netweb, GautamGupta. Fixes #1649.
|
| [5013]
|
johnjamesjacoby
|
Responsive styling to default templates. Huge props mercime. Fixes #1933.
|
| [5014]
|
johnjamesjacoby
|
Clean-up to Example.php converter. Props netweb. Fixes #2134.
|
| [5015]
|
johnjamesjacoby
|
Add user Suggest support for post author overrides for topics and replies. Props alex-ye. Fixes #2224.
|
| [5016]
|
johnjamesjacoby
|
Clean-up admin ajax JS for Suggest methods. Fixes #2224.
|
| [5017]
|
johnjamesjacoby
|
Introduce bbp_repair_forum_visibility() and use it:
* when creating a new BuddyPress Group Forum
* in the bbp_admin_repair_forum_visibility() tool
Fixes issues with new group forums not bumping the private/hidden forum ID's. Props r-a-y. Fixes #2349.
|
| [5018]
|
johnjamesjacoby
|
Improve the flexibility of bbp_title() by allowing all data to be filtered. Props alex-ye. Fixes #1764.
|
| [5019]
|
johnjamesjacoby
|
In bbp_new_topic_handler() and bbp_edit_topic_handler(), restrict sticky topic actions to users with 'moderate' capability. Fixes #2366.
|
| [5020]
|
johnjamesjacoby
|
Attributes are optional in the display_topic_form() shortcode. Suppresses debug notice when no attribute is passed, introduced in r5012. See #1649.
|
| [5021]
|
johnjamesjacoby
|
Use string values when comparing against super globals. Regression introduced in r4995. See #2358.
|
| [5022]
|
johnjamesjacoby
|
Use strict comparisons in bbp_toggle_topic_handler(). See #2358.
|
| [5023]
|
johnjamesjacoby
|
Add dynamic actions to bbp_get_request() and bbp_post_request(). We'll likely move to using them in 2.5.
|
| [5024]
|
johnjamesjacoby
|
Check the action in bbp_search_results_redirect(), and bail early if it's not a search request. Fixes regression causing topic merge/split/move actions to redirect to search page introduced in r4928.
|
| [5025]
|
johnjamesjacoby
|
Bump trunk to bbPress 2.4 beta 1.
|
| [5026]
|
bumpbot
|
Compress scripts/styles: 2.4-beta1-5026.
|
| [5027]
|
johnjamesjacoby
|
Introduce group_settings_hidden_field() method to prevent the settings page from accidentally disabling the group forum. Props r-a-y. Fixes #2339.
|
| [5028]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [5029]
|
johnjamesjacoby
|
In bbp_verify_nonce_request(), add support for local installations that include a port in home_url(). Fixes #2196.
|
| [5030]
|
johnjamesjacoby
|
Remove hard-coded negative capabilities from bbp_get_caps_for_role() for all roles expect 'Blocked'. Prevents over-aggressively and explicitly disallowing role based capabilities, and allows role manager plugins to more effectively manipulate bbPress user capabilities.
Fixes bug where negative user capabilities could not be overridden if negative caps were saved to all_caps array. See #1939.
|
| [5031]
|
johnjamesjacoby
|
More improvements to responsive CSS. Props mercime. Fixes #1933.
|
| [5032]
|
johnjamesjacoby
|
Clearing CSS hack. Fixes content display issues related to hierarchical replies. Props mordauk. Fixes #2345.
|
| [5033]
|
bumpbot
|
Compress scripts/styles: 2.4-beta1-5033.
|
| [5034]
|
johnjamesjacoby
|
Do not echo _get_ functions. Output clean-up for future work on #2367.
|
| [5035]
|
johnjamesjacoby
|
When editing a user and looping through their contact methods, pass the correct 'edit' context into bbp_displayed_user_field().
|
| [5036]
|
johnjamesjacoby
|
When splitting a topic, correctly update the 'menu_order' property of the new topic post.
* Replace instances of 'post_position' with 'menu_order'
* Make sure 'menu_order' is 0
Props lakrisgubben. Fixes #2295.
|
| [5037]
|
johnjamesjacoby
|
For all template functions that output URL's, always echo an escaped value using esc_url(). See #2367.
|
| [5038]
|
johnjamesjacoby
|
When posting to a BuddyPress Group Forum, update the group's last_activity. Props r-a-y. Fixes #2368.
|
| [5039]
|
johnjamesjacoby
|
Update tags and installation section of readme.txt.
|
| [5040]
|
johnjamesjacoby
|
More esc_url() improvements, and practice late-escaping where we were otherwise passing around escaped URL variables. See #2367.
|
| [5041]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [5042]
|
johnjamesjacoby
|
Prevent nested shortcodes if used inside bbPress post_content. Reverts r4976. See #2343.
|
| [5043]
|
johnjamesjacoby
|
New approach to content replacement for theme compatability. Rather than juggle the post global and post content around in two procedures, set post_content via bbp_theme_compat_reset_post().
This reduces some complexity, avoids nested shortcodes, and fixes shortcode and the_content filter conflicts. See #2343.
|
| [5044]
|
johnjamesjacoby
|
Invert the explicit tinymce comparison in bbp_get_the_content() to look for !== false instead of === true. Fixes bug causing textarea output to be incorrectly escaped when using a custom tinymce stylesheet. Fixes #2369.
|
| [5045]
|
johnjamesjacoby
|
Rename 'template-tags' files to 'template' to match core conventions. Also rename BuddyPress Groups extension from 'group' to 'groups'.
|
| [5046]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [5047]
|
johnjamesjacoby
|
Switch main bbPress singleton pointer from a private static to a local static inside the instance() method, preventing recursive $instance references. Fixes #2370.
|
| [5048]
|
johnjamesjacoby
|
PHP 5.4 compat and related sanity checks and clean-up. Props boonebgorges. Fixes #2731.
|
| [5049]
|
johnjamesjacoby
|
Remove out of date wp_referer_field() phpdoc references.
|
| [5050]
|
johnjamesjacoby
|
v1 of Akismet history metabox UI. Fixes #1616.
|
| [5051]
|
johnjamesjacoby
|
Update bbp_time_since() to allow for GMT comparisons. Update Akismet to use bbp_time_since(). See #1616.
|
| [5052]
|
johnjamesjacoby
|
Bump bbpress.pot.
|
| [5053]
|
johnjamesjacoby
|
Fix PHP 5.4 by reference E_STRICT warning in bbp_get_user_role(). See #2372.
|
| [5054]
|
johnjamesjacoby
|
Fallback to 'title' sorting in bbp_list_forums() for subforum sorting. Hat tip mordauk. Fixes #2373.
|
| [5055]
|
johnjamesjacoby
|
Switch some wp_insert_post() usages to wp_update_post(). Use bbp_get_forum(), bbp_get_topic(), and bbp_get_reply() where appropriate, and use objects instead of arrays to avoid escaping issues with wp_update_post().
|
| [5056]
|
johnjamesjacoby
|
Remove byref usage in BuddyPress Groups admin box method.
|
| [5057]
|
johnjamesjacoby
|
De-deprecate bbp_remove_roles() so database role removal is still supported.
|
| [5058]
|
johnjamesjacoby
|
Fallback to title sorting in bbp_has_forums() if no menu_order is present. Props netweb. Fixes #2373.
|
| [5059]
|
johnjamesjacoby
|
If pre-option exists for threaded replies depth, make sure it's correctly disabled.
|
| [5060]
|
johnjamesjacoby
|
Normalize forum, topic, and reply dropdown form fields and associated functions. Includes several new functions with _get_ equivalents to replace incorrectly named _select() functions.
First pass at adding custom topic status handling. Props jkudish. See #2187.
Also replaces $wpdb->update() calls with wp_update_post() in associated functions. Fixes #2351.
|
| [5061]
|
johnjamesjacoby
|
Revert accidental removal of threaded replies dropdown pre-option disabled check from r5060.
|
| [5062]
|
johnjamesjacoby
|
Revert accidental change to bbp_remove_roles() from r5060.
|
| [5063]
|
johnjamesjacoby
|
Revert accidental change to forum query 'orderby' args from r5060.
|