| [6496]
|
johnjamesjacoby
|
Tools: Change BuddyPress group forum repair into an upgrade routine.
This is only intended as a migration path from bbPress 1.x to 2.x, not to be rerun multiple times to force-recount the meta values & private/hidden options.
See #2829.
|
| [6495]
|
johnjamesjacoby
|
Repairs: Prefer `empty()` over `! isset()` in `bbp_admin_repair_group_forum_relationship()`
The `meta_value` key will always be set, because of the way the forum query is written.
See #2829.
|
| [6494]
|
netweb
|
Build Tools: Add npm `package-lock.json` for npm v5.x
This changeset adds support for npm 5 which include significant performance improvements, these are primarily due updated caching, offline caching and the addition of a `package-lock.json` to leverage the new caching.
To install and use npm 5 with your existing install of Node.js 6 or 7 run `npm i npm@5 -g`. Node.js 8 support will be added in a follow up ticket.
Installing npm modules for bbPress is now ~6x faster with npm 5 🏎
Fixes #3113.
|
| [6493]
|
johnjamesjacoby
|
Favorites/Subscriptions improvements:
* Remove superfluous checks against current current user fav/sub status
* Always return `$success`
* Prefer `bbp_get_` functions over generic `intval()` to validate `$_GET` ID's
|
| [6492]
|
netweb
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y.
Fixes #2690.
Merges [5857] to the 2.5 branch.
|
| [6491]
|
johnjamesjacoby
|
Converter: Update some strings for improved clarity.
When a conversion is stopped, and later resumed, make sure the steps and verbiage are clear.
Also switch from "Completed" to "Finished" since it's likely some repair steps are still necessary, and the conversion isn't technically "complete" until those are done too.
|
| [6490]
|
johnjamesjacoby
|
Converter: Use the port number in the server address if available.
Fixes #3022.
|
| [6489]
|
johnjamesjacoby
|
Languages: Introduce UI for updating account language.
Includes helper functions for theme-side user editing, to wrap around `wp_dropdown_languages()`.
Fixes #3010.
|
| [6488]
|
johnjamesjacoby
|
BuddyPress: Only wrap titles in `h2` tags if they are not empty.
Allows easier overriding if titles are not desired at all.
See #3105.
|
| [6487]
|
johnjamesjacoby
|
Filters: Pass original `$args` array into various filters.
These were all unintentionally omitted when these filters were introduced.
|
| [6486]
|
johnjamesjacoby
|
Template: Pass original `$args` array into `bbp_get_dropdown` filter.
Also update some inline docs & code formatting.
|
| [6485]
|
johnjamesjacoby
|
BuddyPress: Root group forum updates
* Include ability to create a new group root forum if none exists
* Update group-forum setting verbiage to accommodate above
* When a forum is deleted, check if it's the group root, and delete the setting accordingly
* Introduce `bbp_maybe_delete_group_forum_root()` and `bbp_maybe_create_group_forum_root()` functions to carry out the above functionalities
|
| [6484]
|
johnjamesjacoby
|
Filters: cast return values & update phpdoc.
|
| [6483]
|
johnjamesjacoby
|
Settings: cast `map_meta_caps` return value to an array.
|
| [6482]
|
johnjamesjacoby
|
Fix typo in phpdoc.
|
| [6481]
|
johnjamesjacoby
|
Tools: Introduce `bbp_get_unique_array_values()` helper function.
Use this when parsing private/hidden forum IDs for saving.
|
| [6480]
|
johnjamesjacoby
|
Forums: be strict in `array_search()` calls.
|
| [6479]
|
johnjamesjacoby
|
Sub-actions: Cast a few return values and add `@return` phpdoc.
|
| [6478]
|
johnjamesjacoby
|
Forums: Add forum-type & status to allowed meta keys.
|
| [6477]
|
johnjamesjacoby
|
Inserts: Only prefix meta keys if not already prefixed when inserting forum/topic/reply.
|
| [6476]
|
johnjamesjacoby
|
Converters: Port r5332 to 2.5 branch.
See #2558, #3112.
|
| [6475]
|
johnjamesjacoby
|
Admin: More admin mark-up updates
* Add `hr` after `h1`s on custom screens
* More accurate meta-box wrapper mark-up
|
| [6474]
|
johnjamesjacoby
|
Admin: Clean-up admin assets according to specifications.
|
| [6473]
|
johnjamesjacoby
|
Tools: Update `Gruntfile.js` with new admin assets directory.
|
| [6472]
|
johnjamesjacoby
|
Converter: Styling updates
* Move all admin CSS & JS into `/admin/assets/`
* Introduce `converter.js` and refactor code out of `admin_head()` method
* Move converter styling into `common.css`
* Update some surrounding styling, verbiage, and mark-up to better handle errors and user feedback
|
| [6471]
|
johnjamesjacoby
|
Converter: Styling updates
* Move all admin CSS & JS into `/admin/assets/`
* Introduce `converter.js` and refactor code out of `admin_head()` method
* Move converter styling into `common.css`
* Update some surrounding styling, verbiage, and mark-up to better handle errors and user feedback
|
| [6470]
|
netweb
|
Build Tools: Update `package.json` to define a minimum Node.js version `6.9.1`
This changeset updates the recommended Node.js version to the latest 6.x.x Node.js LTS version. The Node.js 4.x.x LTS branch is now in maintenance mode and brings bbPress' build tool version requirements in line with WordPress' and the broader WordPress plugin community.
|
| [6469]
|
netweb
|
Build Tools: Update `grunt-wp-i18n` from 0.5.4 to 1.0.0
* See https://github.com/cedaro/grunt-wp-i18n/compare/v0.5.4...v1.0.0
|
| [6468]
|
netweb
|
Build Tools: Update `grunt-contrib-cssmin` from 1.0.0 to 2.2.0
* See https://github.com/gruntjs/grunt-contrib-cssmin/compare/v1.0.0...v2.2.0
* Updates `clean-css` to v4.1.1
|
| [6467]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify` from 2.0.0 to 3.0.1
* See https://github.com/gruntjs/grunt-contrib-uglify/compare/v2.0.0...v3.0.1
* Bumps `uglify-js` to 3.0.4
|
| [6466]
|
netweb
|
Build Tools: Update `autoprefixer` from 6.7.1 to 7.1.1
• https://github.com/postcss/autoprefixer/compare/6.7.1...7.1.1
|
| [6465]
|
netweb
|
Build Tools: Update `grunt-stylelint` from 0.7.0 to 0.8.0
• See https://github.com/wikimedia/grunt-stylelint/compare/v0.7.0...v0.8.0
|
| [6464]
|
netweb
|
Build Tools: Update `grunt-exec` from 1.0.1 to 2.0.0
* See https://github.com/jharding/grunt-exec/compare/v1.0.1...e1ef5d9
|
| [6463]
|
netweb
|
Build Tools: Update `postcss-scss` from 0.4.0 to 1.0.0
* See https://github.com/postcss/postcss-scss/compare/0.4.0...1.0.0
|
| [6462]
|
netweb
|
Build Tools: Build Tools: Update `grunt-contrib-clean` from 1.0.0 to 1.1.0
* https://github.com/gruntjs/grunt-contrib-clean/compare/v1.0.0...v1.1.0
This changeset reverts the incorrect change in [6461] to `grunt-contrib-copy` instead of `grunt-contrib-clean`
Antiprops netweb.
|
| [6461]
|
netweb
|
Build Tools: Update `grunt-contrib-copy` from 1.0.0 to 1.1.0
* https://github.com/gruntjs/grunt-contrib-clean/compare/v1.0.0...v1.1.0
|
| [6460]
|
johnjamesjacoby
|
Converter: Code improvements
* Add "Skip" text for steps that are being skipped
* Allow bypassing of importer halting on error
* Update a few strings
* Break some code from `process_callback()` method out into separate private methods
|
| [6459]
|
johnjamesjacoby
|
Converter: More stylistic improvements
* Use "Import Monitor" metabox vs. old ugly plain yellow `div`
* Improve messaging around existing/incomplete import status/query/steps
* `17` total steps is kind-of a bad guess, but better than nothing
* Likely more can be done here in 2.7 as this matures in the public eye
|
| [6458]
|
johnjamesjacoby
|
Converter: Improve error responses and UX when converter halts.
|
| [6457]
|
johnjamesjacoby
|
Converter: Make sure the sync-table has a chance to be made on first run when not cleaning.
Also default `$start` values to `1` in the event some empty value is erroneously passed through.
|
| [6456]
|
johnjamesjacoby
|
Converter: Multiple converter improvements
* Move classes into their own files
* Move `converter.php` into `/admin/tools/`
* Escape output of translated strings where possible
* Introduce `bbp_converter_db_connection_failed` error handler, in the event the origin database connection cannot be established
* Sets `WP_SETUP_CONFIG` constant to `true` to control `$wpdb->db_connect()` bail from using `db-error.php`
* Use `sanitize_text_field()` on database connection values
* Invisibly default to `DB_` constants if database connection values are empty
* introduce `convert_users` class parameter to limit direct touches to `$_POST` value
* Smarter defaults for converter options
|
| [6455]
|
johnjamesjacoby
|
Moderators: Prefer `sanitize_title` over `trim`. See #3097.
|
| [6454]
|
johnjamesjacoby
|
Moderators: Trim usernames after they're exploded.
Resolves an issue where spaces in the comma separated usernames field would result in skipping that user.
Fixes #3097.
|
| [6453]
|
johnjamesjacoby
|
Topic Tags: set `is_archive` to `true` when viewing a topic tag archive.
Fixes #3071.
|
| [6452]
|
johnjamesjacoby
|
Templates: Replace `the_permalink()` calls with more specific template tags.
Resolves issue where BuddyPress group forums would collide with literal page IDs when not using theme-compat.
Fixes #3030.
|
| [6451]
|
johnjamesjacoby
|
Où mettre!
|
| [6450]
|
johnjamesjacoby
|
Topic Tags: When deleting a topic tag, redirect to the forum root.
`home_url()` was a bit too jarring; no one expects to get kicked out of the forums entirely.
|
| [6449]
|
johnjamesjacoby
|
Converters: Fix formatting on several converter methods.
|
| [6448]
|
johnjamesjacoby
|
Converter: Introduce `bbp_get_converters()` to DRY the directory crawling code.
Also allows converters to be filtered, should someone want to include their own in a plugin.
See #3095.
|
| [6447]
|
johnjamesjacoby
|
Converter: Refresh to registered settings
* `ksort()` the Platform list, and exclude "Example" since it's not usable
* Turn some `text` fields into `number` fields, with reasonable boundaries
* Add `code` classes to database fields
* Update some labels & descriptions
Fixes #3095.
|
| [6446]
|
johnjamesjacoby
|
Engagements: Performance optimizations to `bbp_update_topic_voice_count()`.
* Use a `UNION` query strategy (only on the `wp_posts` table)
* Compare old count to new count before deleting & updating engagements
Fixes #3083. Props januzi_pl.
|
| [6445]
|
johnjamesjacoby
|
Subscriptions: Remove `array_filter( array_map() )` bit from `$user_ids`.
This now is handled upstream inside of `bbp_get_forum_subscribers()` and friends.
|
| [6444]
|
johnjamesjacoby
|
Settings: Update `int` handling of `bbp_past_edit_lock()`.
|
| [6443]
|
johnjamesjacoby
|
Settings: Update Engagements setting description to better match others.
|
| [6442]
|
johnjamesjacoby
|
Settings: Add `_allow_` settings for editing & flooding, and revise the verbiage.
This allows for flood checking & editing to be:
* Completely disabled
* Overridden via filters
* Editing allowed forever
* A bit more descriptive with additional context provided
|
| [6441]
|
johnjamesjacoby
|
Help: Update help text, and include a bit about the "Theme Packages" section.
|
| [6440]
|
johnjamesjacoby
|
Common: introduce `bbp_has_shortcode()` to check if some text contains a bbPress shortcode.
If a shortcode was found in the global post content, a few extra things will happen:
* The `bbp-shortcode` class is added to the `body` tag
* `is_bbpress()` will now return `true`, to help enqueue additional styles & scripts on those pages in themes that want to support bbPress natively
Fixes #2996.
|
| [6439]
|
johnjamesjacoby
|
Engagements: Remove `bbp_get_topic()` checks from engagements.
See #3083.
|
| [6438]
|
johnjamesjacoby
|
Tools: Add `//Filter & return` note for future discovery of missing filter documentation.
Also adjust some type-casting on filtered results.
|
| [6437]
|
johnjamesjacoby
|
General: Tidying from looking into #2876.
|
| [6436]
|
johnjamesjacoby
|
Tests: update `test_bbp_get_topic_last_reply_permalink()` to use `bbp_get_forum_last_topic_permalink()`.
|
| [6435]
|
johnjamesjacoby
|
Settings: Add a note to the `_bbp_show_on_root` setting if a forum archive template is found in the template stack.
Fixes confusion that would arise when using the `archive-forum.php` found in the `/extras/` directory.
Fixes #3081.
|
| [6434]
|
johnjamesjacoby
|
Queries: Update `orderby` clauses of last-id queries to ensure more accurate results, specifically for imported forums and posts where IDs and `post_date` columns might be inverted.
Also update a few tests to be less cranky with exact array results.
Props thebrandonallen. Fixes #3108.
|
| [6433]
|
johnjamesjacoby
|
Forms: Introduce `bbp_tab_index_attribute()` helpers to handle `tabindex` attribute output.
Note that these functions are used but normally their output is suppressed, because overriding the browser's natural `tabindex` order is impolite, and may introduce more issues than it actually fixes.
(Also includes some surrounding code clean-up.)
|
| [6432]
|
johnjamesjacoby
|
Trash: Introduce `bbp_get_trash_days()` helper function.
This will allow the trashability of an object type to be short-circuited, around the `EMPTY_TRASH_DAYS` constant.
|
| [6431]
|
johnjamesjacoby
|
Users: Connect `bbp_allow_forums_of_user` filter to `bbp_get_excluded_forum_ids` filter.
This prevents excluding private or hidden forums that the currently logged in user can explicitly moderate.
Fixes #2593.
|
| [6430]
|
johnjamesjacoby
|
Remove more debug cruft.
|
| [6429]
|
johnjamesjacoby
|
Remove debug cruft.
|
| [6428]
|
johnjamesjacoby
|
Repair: In `bbp_repair_forum_visibility()`, don't bail if an error occurs.
Instead, skip the erroneous results and update the valid ones.
|
| [6427]
|
johnjamesjacoby
|
Replies: fix incorrect inline doc in `bbp_current_user_can_access_create_reply_form()`.
|
| [6426]
|
johnjamesjacoby
|
Users: Introduce `bbp_get_excluded_forum_ids()`.
This function will be used in places where private & hidden forum IDs are combined to determine which forums should be excluded from specific queries.
See #2593.
|
| [6425]
|
johnjamesjacoby
|
Users: Introduce `bbp_allow_forums_of_user()`.
This filter-only function will be used to remove private & hidden forums from being excluded in queries, for users who are explicitly allowed forums that they would not otherwise be able to access.
See #2593.
|
| [6424]
|
johnjamesjacoby
|
Admin: in list-tables, if no parent forum/topic, show `—` instead.
Also make sure a few strings are escaped, and dropdowns are using correct parent text.
|
| [6423]
|
netweb
|
Tests: Improve `test_bbp_get_forum_last_reply_id()` test performance.
No need to query for the last reply ID as we already knew what to expect.t.
See #3108.
Props thebrandonallen.
|
| [6422]
|
johnjamesjacoby
|
Users: move user relationships functions into `engagements.php`.
|
| [6421]
|
johnjamesjacoby
|
Users: move Engagements API into its own `engagements.php` file.
`/users/functions.php` is getting a bit gnarly.
|
| [6420]
|
johnjamesjacoby
|
Settings: remove directory path from option text.
|
| [6419]
|
johnjamesjacoby
|
Settings: General improvements:
* Use escaped equivalent for gettext output
* Update settings-integration away from `bool` to allow future flexibility
* Stash settings fields in a static variable to speed up registration
|
| [6418]
|
netweb
|
Parser: PHP 7.1 compatibility fixes to `parser.php`
Props xknown.
See #2973, #2987.
Merges [6212] to the 2.5 branch.
|
| [6417]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
See #2987.
Merges [6113] to the 2.5 branch.
|
| [6416]
|
netweb
|
Trash: Cast _pre_ post-meta values to an array.
Prevents notices & warnings in the event 0 or 1 replies exist.
Props SergeyBiryukov.
See #3053.
Merges [6360] to the 2.5 branch.
|
| [6415]
|
johnjamesjacoby
|
`in_array()`: be strict whenever possible.
Use `wp_parse_id_list()` on certain array values to ensure proper results.
|
| [6414]
|
johnjamesjacoby
|
Forums: Audit private/hidden forum ID exclusion:
* improve performance of `bbp_exclude_forum_ids()`
* Use `bbp_exclude_forum_ids()` where duplicate code existed
* Make sure `$forum_ids` are passed into `bbp_exclude_forum_ids` filter
* Prefer arrays over imploded strings (also with post statuses)
|
| [6413]
|
johnjamesjacoby
|
Users: Admin sub-headings are now `h2` tags.
|
| [6412]
|
johnjamesjacoby
|
Tag 2.5.13.
|
| [6411]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.13.
|
| [6410]
|
johnjamesjacoby
|
Queries: Deprecate `bbp_query_post_parent__in()` in the 2.5 branch.
4.7 is the minimum WordPress version, so we can support `post_parent__not_in` directly.
See #2832.
|
| [6409]
|
johnjamesjacoby
|
Templates: remove box-shadow styling on avatars and links.
Improves styling with Twenty Seventeen theme.
|
| [6408]
|
netweb
|
Build Tools: Update stylelint to `11.0.0` and use unitless values for `line-height`
This changeset updates stylelint to the latest version and removes `%` and `em` from `line-height` values per the WordPress CSS coding standards.
Fixes #3106.
|
| [6407]
|
johnjamesjacoby
|
Moderators: Another performance optimization in `bbp_is_user_forum_moderator()`.
Use `bbp_is_object_of_user()` directly, and clean-up local variable reassignments.
|
| [6406]
|
johnjamesjacoby
|
Moderators: Performance optimization in `bbp_is_user_forum_moderator()`.
Rather than query for all forums a user can moderate, query for the users that can moderate the forum. This data is likely already hot in the meta-data cache from forums being loaded previously, and eliminates the need to query for forum IDs that are unrelated to the one being checked.
|
| [6405]
|
netweb
|
Build Tools: Remove HHVM from the test infrastructure on Travis.
Fixes #3104.
|
| [6404]
|
netweb
|
Build Tools: Fix copy pasta of `;` instead of `,` added in [6403].
WordPress Coding Standards requires one variable declaration.
See #2924.
|
| [6403]
|
netweb
|
Build Tools: Update stylelint
* Update `stylelint` to v7.10.1
* Update `grunt-stylelint` to v0.7.0
* Switch from `.stylelintrc` format to stylelint shared config `stylelint-config-wordpress`
* Add SCSS linting support that's now included in `stylelint-config-wordpress`
See #2924.
|
| [6402]
|
johnjamesjacoby
|
Stickies: Improved algorithm for merging stickies to queried posts
* Separate into overloadable function
* Tighter, less wasteful loops through existing query
* Improved sort-ordering of topics by their most recent post activity
* Also separate pagination base URL into new function, out of `bbp_has_topics()`
|
| [6401]
|
johnjamesjacoby
|
Stickies: Update forum/topic meta early in `bbp_update_topic()`
* Makes meta-data available earlier for downstream functions
* Removes ineffective assumption of forum-topic-id when empty
This fixes a situation where trying to stick a new topic to a forum would look for the `_bbp_forum_id` meta-data before it was updated.
Fixes #3103.
|
| [6400]
|
johnjamesjacoby
|
Anonymous: Improve `$anonymous_data` implementation:
* Always treat it as an array, handling for `false` values was never used
* Introduce `_sanitize_` and `_update_` partner functions for the existing `_filter_` function
* Ensure that cookies and meta-data values are stripped of invalid characters in the same way that anonymous comments are, to prevent inconsistencies between anonymous forum and commenter cookie data
* Update surrounding documentation blocks
* Prefer strict type-casting and `is_array()` comparisons
|
| [6399]
|
johnjamesjacoby
|
Anonymous: Clean-up `bbp_set_current_anonymous_user_data()`:
* Make sure cookies are secure when SSL
* Only call `time()` once to avoid potential delays
* Cast cookie lifetime to `int` after filtering
* Inline docs
|
| [6398]
|
johnjamesjacoby
|
Parenthesis clean-up.
|
| [6397]
|
johnjamesjacoby
|
Admin: Update row action toggle methods to be a bit more flexible.
This should improve support for custom toggle actions in `wp-admin`.
|