| [5409]
|
johnjamesjacoby
|
Introduce `bbp_get_do_not_reply_address()` function, and use in subscription notification functions. Also add filters to make changing these values easier for advanced setups. Fixes #2618.
|
| [5408]
|
johnjamesjacoby
|
Abstract new topic-transition reply helper-functions onto action hooks for easier testing and replacement/extension by third party plugins. See #2494.
|
| [5407]
|
johnjamesjacoby
|
Add phpdoc to `bbp_trash_topic_replies()` from r5406. See #2494.
|
| [5406]
|
johnjamesjacoby
|
Split secondary topic spam/trash/unspam/untrash actions into separate functions to be used during topic status transition. See #2494.
|
| [5405]
|
johnjamesjacoby
|
When topics are marked as spam, remove them from all favorites, subscriptions, and unstick them.
Fixes cases where spammed topic ID's are left behind in various meta values. Fixes #2621.
|
| [5404]
|
johnjamesjacoby
|
Correctly compare source & destination topic `post_date` values in `bbp_merge_topic_handler()`. Fixes issue where incorrect post would be updated when merging older topics into newer ones.
Also update the reply position for all newly relocated replies. Hat-tip netweb. Fixes #2528.
|
| [5403]
|
johnjamesjacoby
|
Normalize Favorite and Subscribe links for Forums and Topics so they are visually linear to the breadcrumb. Hat-tip netweb. Fixes #2575.
|
| [5402]
|
johnjamesjacoby
|
Travis Updates:
* Switch to a 'shallow' Git clone of the official WordPress Git repo for faster WordPress upstream checkout.
* The addition of the fast_finish: true flag in the build matrix will mark the build passed or errored as soon as a single build job has failed. Previously the build status was not reported until ALL tests had completed regardless of status.
* Moves the 'build configuration' to before_install allowing non-bbPress test configuration to report as errored (MySQL database creation, and WordPress Git checkout etc). When a failure occurs in this section the build is marked as errored which is a more accurate description in that the environment we are setting up has failed and not the actual bbPress tests we are testing.
* Introduces PHP 5.6 and HHVM testing into the build matrix, both of these are allowed to fail in that they will not be included in the overall build job failed, errored, or passed build status. This allows bbPress testing to play nice with these alpha/beta version of PHP/HHVM until stable and officially released.
Props netweb. See #2542.
|
| [5401]
|
johnjamesjacoby
|
De-deprecate `bbp_remove_roles()` and use it in: `bbp_admin_reset_handler()`, bbp_do_uninstall()`, and `bbp_version_updater()`. Fixes bug where old bbPress role data could still exist in `wp_user_roles`. See #2065. Fixes #2580.
|
| [5400]
|
johnjamesjacoby
|
Fix references to topics in phpdoc for reply status dropdown functions. See #2463.
|
| [5399]
|
johnjamesjacoby
|
Normalize metabox UI across Forums, Topics, & Replies. Hat-tip netweb. Fixes #2463.
|
| [5398]
|
johnjamesjacoby
|
Update admin area reply-to to use `bbp_reply_to_dropdown()`. Fixes #2617.
|
| [5397]
|
johnjamesjacoby
|
If a reply is a reply to another reply, display the parent reply information in the form legend with the topic title. Props netweb. Fixes #2509.
|
| [5396]
|
johnjamesjacoby
|
Add editable reply-to field in `form-reply.php` for moderators when editing replies. See #2617.
|
| [5395]
|
johnjamesjacoby
|
Reduce unnecessary complexity and flexibility in `bbp_get_reply_to_dropdown()`. Since this is a purpose built form field, explicit filtering of arguments is not necessary. See #2617.
|
| [5394]
|
johnjamesjacoby
|
Smarter ancestor detection in `BBP_Walker_Reply_Dropdown`. See #2617.
|
| [5393]
|
johnjamesjacoby
|
Prevent empty array value in `bbp_get_reply_ancestors()`. See #2617.
|
| [5392]
|
johnjamesjacoby
|
Force integer value in `bbp_has_topics()` for reply position. Fixes bug when there are more than 1,000 replies. Props DrPepper75. Fixes #2615.
|
| [5391]
|
johnjamesjacoby
|
Pass `$reply_id` into calls to `bbp_validate_reply_to()` and remove `reply_query` references in `BBP_Walker_Reply_Dropdown`. Fixes invalid `bbp_reply_id` value output in `form-reply.php`. See #2617.
|
| [5390]
|
johnjamesjacoby
|
Introduce `bbp_get_reply_ancestors()` function to help with reply hierarchy dropdown. Also conveniently wraps logic incase we ever move to a real hierarchical post type. See #2617.
|
| [5389]
|
johnjamesjacoby
|
Introduce `BBP_Walker_Reply_Dropdown` to help with reply hierarchy dropdown. Also update other Walker class extensions and associated documentation to be a bit more accurate and reliable. See #2617.
|
| [5388]
|
johnjamesjacoby
|
Tweak `bbp_get_dropdown()` to allow an array of custom posts to be used. See #2617.
|
| [5387]
|
johnjamesjacoby
|
Tweak `bbp_get_dropdown()` to allow an array of custom posts to be used. See #2617.
|
| [5386]
|
netweb
|
Update grunt-sass to v0.12.1 to 0.13.1 http://npmjs.org/package/grunt-sass
See #2542
|
| [5385]
|
netweb
|
Multiple strings in .editorconfig sections should be wrapped in curly brackets
Props treyhunner. Fixes #2614
|
| [5384]
|
johnjamesjacoby
|
Update `grunt-wp-i18n` to 0.4.5. Fixes calls to `date()` for local installations without timezone identifiers.
|
| [5383]
|
netweb
|
Fix .editorconfig file, file should be a file not a diff.
Props thebrandonallen. Fixes #2612
|
| [5382]
|
johnjamesjacoby
|
Tag 2.5.4.
|
| [5381]
|
johnjamesjacoby
|
Bump remaining 2.5.3 references in 2.5 branch.
|
| [5380]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.4.
|
| [5379]
|
johnjamesjacoby
|
Bump stable tag and add 2.5.4 section to `readme.txt` (trunk)
|
| [5378]
|
johnjamesjacoby
|
Introduce `bbp_validate_reply_to()` function, used to:
* Validate a parent reply is actually a reply post_type.
* A reply is not accidentally assigning itself as its own parent.
* An integer is returned.
Fixes hiesenbug where calls to `bbp_get_reply_id()` were unexpectedly and occasionally returning the current reply ID rather than 0.
See #2588. (trunk)
|
| [5377]
|
johnjamesjacoby
|
Introduce `bbp_validate_reply_to()` function, used to:
* Validate a parent reply is actually a reply post_type.
* A reply is not accidentally assigning itself as its own parent.
* An integer is returned.
Fixes hiesenbug where calls to `bbp_get_reply_id()` were unexpectedly and occasionally returning the current reply ID rather than 0.
See #2588. (2.5 branch)
|
| [5376]
|
johnjamesjacoby
|
Clean up `bbp_get_reply_to()` to improve code readability. (2.5 branch)
|
| [5375]
|
johnjamesjacoby
|
Update reply position repair tool to delete invalid `_bbp_reply_to` fields, and tweak name and description. Props netweb. See #2588. (trunk)
|
| [5374]
|
johnjamesjacoby
|
Update reply position repair tool to delete invalid `_bbp_reply_to` fields, and tweak name and description. Props netweb. See #2588. (2.5 branch)
|
| [5373]
|
johnjamesjacoby
|
Remove extraneous validation in `bbp_get_form_reply_to()`. Fixes bug causing `_bbp_reply_to` field to be incorrectly set as the current `$reply_id` when editing a reply with no reply_to, which can lead to hierarchy issues. See #2586, #2588. (2.5 branch)
|
| [5372]
|
johnjamesjacoby
|
Remove extraneous validation in `bbp_get_form_reply_to()`. Fixes bug causing `_bbp_reply_to` field to be incorrectly set as the current `$reply_id` when editing a reply with no reply_to, which can lead to hierarchy issues. See #2586, #2588. (trunk)
|
| [5371]
|
johnjamesjacoby
|
Indentation clean-up and assignment clarifycation in `bbp_get_reply_to()`. See #2588.
|
| [5370]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_displayed_user_field()` function to handle the sanitizing of displayed user data, and add it to the `bbp_get_displayed_user_field` filter. Props mazengamal. See #2610 (2.5 branch).
|
| [5369]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_displayed_user_field()` function to handle the sanitizing of displayed user data, and add it to the `bbp_get_displayed_user_field` filter. Props mazengamal. See #2610 (trunk).
|
| [5368]
|
johnjamesjacoby
|
Update to tools:
* Update topic & reply count repair tools to only delete the appropriate meta keys from the appropriate parents.
* Include new reply hierarchy repair tool, to fix a possibly poisoned reply hierarchy.
Props netweb. See #2586 (trunk)
|
| [5367]
|
johnjamesjacoby
|
Update to tools:
* Update topic & reply count repair tools to only delete the appropriate meta keys from the appropriate parents.
* Include new reply hierarchy repair tool, to fix a possibly poisoned reply hierarchy.
Props netweb. See #2586 (2.5 branch)
|
| [5366]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_slug()` function for sanitizing permalink slugs, and use it as the callback for any slug settings. Props mazengamal. See #2496 (2.5 branch).
|
| [5365]
|
johnjamesjacoby
|
Introduce `bbp_sanitize_slug()` function for sanitizing permalink slugs, and use it as the callback for any slug settings. Props mazengamal. See #2496 (trunk).
|
| [5364]
|
johnjamesjacoby
|
Remove text-zoom override from default responsive theme-compat styling (themes should have this covered.)
|
| [5363]
|
johnjamesjacoby
|
Whitespace cleanup to `Gruntfile.js`.
|
| [5362]
|
netweb
|
Add .editorconfig file, see http://editorconfig.org/.
"EditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs."
Props netweb. Fixes #2598
|
| [5361]
|
johnjamesjacoby
|
Missed a spot.
|
| [5360]
|
johnjamesjacoby
|
Revert indentation change in r5357. Props netweb. See: http://yaml.org/spec/1.2/spec.html#id2777534
|
| [5359]
|
johnjamesjacoby
|
Re-alphabetize grunt packages and update keywords in `package.json`.
|
| [5358]
|
johnjamesjacoby
|
Alphabetize grunt packages and update keywords in `package.json`.
|
| [5357]
|
johnjamesjacoby
|
Indent with tabs in `package.json`
|
| [5356]
|
johnjamesjacoby
|
Replace `function_exists()` checks with `is_callable()` in template stack functions. Props boonebgorges. See: http://buddypress.trac.wordpress.org/ticket/5671
|
| [5355]
|
johnjamesjacoby
|
In template stack functions, wrap `function_exists()` checks with `is_array()` check. Allows class methods to be used as template stack locations. See: https://buddypress.trac.wordpress.org/ticket/5671
|
| [5354]
|
netweb
|
Improved topic merge verbiage in `form-topic-merge.php` template.
Props gautamgupta. Fixes #2539
|
| [5353]
|
netweb
|
Fix @since PHPDoc for `toggle_forum` and `toggle_forum_notice` in /includes/admin/forums.php
|
| [5352]
|
netweb
|
Introduce e107 v1.x importer
Props netweb. Fixes #2421
|
| [5351]
|
johnjamesjacoby
|
Use correct `word-wrap` CSS property in `templates/default/bbpress.css`. Fixes problem with long author-names not wrapping correctly.
|
| [5350]
|
netweb
|
Add support to vBulletin importer for 'YouTube Share' BBCode
Props netweb. Fixes #2601
|
| [5349]
|
netweb
|
Replies now use the reply ID for the the post name/slug via r5117.
bbPress' importers should also reflect that change with the removal of 'Reply Title' (post_title), 'Reply Slug' (post_name) and `callback_reply_title` from all importers. Props netweb. Fixes #2585
|
| [5348]
|
netweb
|
Update `grunt-wp-i18n` to `0.4.4`
Changelog via https://github.com/blazersix/grunt-wp-i18n/blob/develop/README.md
* Added the potComments option to change the copyright message.
* bbPress: Not implementing this at this stage as the current copyright header text is sufficient
* Added the updateTimestamp option to prevent the POT-Creation-Header from being updated if there aren't any other changes in the POT file.
* bbPress: Not implementing this at this stage as the default is `true` and that is fine
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542
|
| [5347]
|
netweb
|
Update `grunt` to `0.4.5` now that depreciated Grunt.util.* API is addressed via 2576
* Upstream changelog https://github.com/gruntjs/grunt/blob/v0.4.5/CHANGELOG
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542
|
| [5346]
|
netweb
|
Grunt is deprecating the Grunt.Util.* api, adding `grunt-legacy-util` will allow us to continue using `grunt.util.spawn` to spawn the multiple `phpunit` Grunt tasks.
* Adds `grunt-legacy-util` to `package.json`
* Requires fresh `npm install` to update dependencies
* Props netweb. Fixes #2576
|
| [5345]
|
johnjamesjacoby
|
Add license definition to plugin headers.
|
| [5344]
|
netweb
|
More Grunt updates
* Adds `uglify:dynamic` to `grunt uglify` so that `grunt watch` -> `watch:js` tasks can dynamicly minify Javascript files with the `grunt watch` task.
* Improved inline documentation for grunt jshint task.
* Props netweb. See #2542
|
| [5343]
|
netweb
|
Updated base admin styles SCSS
* Color scheme support for widget choosers via WP:changeset:28122
* 'About Page' updated styles via WP:changeset:28127
Fixes #2583
|
| [5342]
|
netweb
|
Use correct PHPUnit configuration file `phpunit.xml.dist` for Grunt task `grunt phpunit`
* Props netweb. See #2542
|
| [5341]
|
johnjamesjacoby
|
Bump tested-up-to version to 3.9. (2.5 branch)
|
| [5340]
|
johnjamesjacoby
|
Bump tested-up-to version to 3.9. (trunk)
|
| [5339]
|
netweb
|
Bump NPM package versions in `package.json`
"grunt-contrib-jshint": "~0.9.2 -> "~0.10.0" http://npmjs.org/package/grunt-contrib-jshint
"grunt-sass": "~0.12.0" -> "~0.12.1" http://npmjs.org/package/grunt-sass
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542
|
| [5338]
|
johnjamesjacoby
|
When calculating a new reply position, ensure we are using raw, unformatted integers. Fixes bug where formatted numeric strings (I.E. with commas; eg: 1,532) were being passed to the `menu_order` property, causing broken pagination on topics with over 1k replies. Fixes #2556.
|
| [5337]
|
johnjamesjacoby
|
Add `overflow-x: auto` styling to `code` and `pre` tags, to allow very long single lines of code to wrap without breaking outside of the bounding box.
|
| [5336]
|
netweb
|
In `.jshintrc` ignore undefined variables so `grunt jshint` task completes without error.
(reference variables created by WordPress dependencies or API's)
* Props netweb. Fixes #2578
|
| [5335]
|
johnjamesjacoby
|
More specific CSS selector on closed topics to only target lists of topics, not single topic views. See r2962.
|
| [5334]
|
johnjamesjacoby
|
Improve output of `grunt jshint` task. See #2578.
|
| [5333]
|
netweb
|
More grunt updates:
* Include bbPress version via `package.json` in the 'banner' of minified CSS & JS files
* Include current date and time (UTC) in the 'banner' of minified CSS & JS files
* Props netweb. See #2542
|
| [5332]
|
netweb
|
SMF Importer BBCode regex expressions
* Fix copy pasta `<br>`/`<tt>` regex
* Add non-break space ` ` to space ` ` rexex
Props mspecht. Fixes @2558
|
| [5331]
|
johnjamesjacoby
|
Fix incorrect phpdoc in users functions.
|
| [5330]
|
johnjamesjacoby
|
Remove stray semi-colon.
|
| [5329]
|
johnjamesjacoby
|
Add `separate_items_with_commas` string in `bbp_get_topic_tag_tax_labels()`.
|
| [5328]
|
netweb
|
Bump NPM package versions in `package.json`
"grunt-contrib-cssmin": "~0.7.0" -> "~0.9.0" http://npmjs.org/package/grunt-contrib-cssmin
"grunt-contrib-uglify": "~0.3.0" -> "~0.4.0" http://npmjs.org/package/grunt-contrib-uglify
"grunt-contrib-watch": "~0.5.3" -> "~0.6.1" http://npmjs.org/package/grunt-contrib-watch
"grunt-contrib-jshint": "~0.8.0" -> "~0.9.2" http://npmjs.org/package/grunt-contrib-jshint
"grunt-sass": "~0.10.0" -> "~0.12.0" http://npmjs.org/package/grunt-sass
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542
|
| [5327]
|
netweb
|
Bump NPM package versions in `package.json`
* `grunt-wp-i18n` to v0.4.3 https://www.npmjs.org/package/grunt-wp-i18n
* Fixes numerous PHP error notices
* Add's support for custom headers in bbpress.pot
* ['report-msgid-bugs-to'] = 'https://bbpress.trac.wordpress.org';;
* ['last-translator'] = 'JOHN JAMES JACOBY <jjj@bbpress.org>';
* ['language-team'] = 'ENGLISH <jjj@bbpress.org>';
* Requires `npm install` to update packages and dependencies
* Props netweb. See #2542
|
| [5326]
|
netweb
|
More grunt updates:
* Add `grunt-patch-wordpress` to `package.json`
* Adds grunt task `grunt patch` to `grunt build` and `grunt build-release`
* Requires fresh `npm install` to update dependencies
* Full instructions https://github.com/aaronjorbin/grunt-patch-wordpress#patching-from-the-command-line
* Props jorbin. See #2542
|
| [5325]
|
johnjamesjacoby
|
Use `basename` instead of `file` in plugin action links. Props DJPaul. Fixes #2567.
|
| [5324]
|
johnjamesjacoby
|
Add missing `forum.js`. Props SGr33n. Fixes #2568.
|
| [5323]
|
netweb
|
Rename PHPUnit config file from phpunit.xml to phpunit.xml.dist
* PHPUnit supports config files with both these names, but will use phpunit.xml over the .dist version.
* Renaming our file lets users add/edit their own phpunit.xml without editing a bbPress core file.
* Hattip djpaul via [BuddyPress:r8098]
* Props netweb. See #2542
|
| [5322]
|
johnjamesjacoby
|
Add `NUMERIC` type hinting to view queries. Props netweb. Fixes #2554.
|
| [5321]
|
johnjamesjacoby
|
Remove `akismet_microtime()` usage as it's been removed from Akismet's development branch.
|
| [5320]
|
johnjamesjacoby
|
Remove `akismet_test_mode()` usage as it's been removed from Akismet's development branch.
|
| [5319]
|
netweb
|
Fix duplicate action name in form-forum.php. Props netweb. Fixes #2560
|
| [5318]
|
johnjamesjacoby
|
Add screenshots to `readme.txt`. Props netweb. See #2555.
|
| [5317]
|
johnjamesjacoby
|
Don't allow `build` or `src` in `basename` in `bbPress:setup_globals()`. Fixes problems with activation hooks. Fixes #2559. Props DJPaul.
|
| [5316]
|
johnjamesjacoby
|
Fix basename filter in `bbPress:setup_globals()`. Props DJPaul.
|
| [5315]
|
johnjamesjacoby
|
Set `is_tax` to true when calling `bbp_theme_compaty_reset_post()` when viewing/editing a topic-tag. Fixes #2444.
|
| [5314]
|
johnjamesjacoby
|
Add contextual help for admin Tools. Props netweb. Fixes #1920.
|
| [5313]
|
johnjamesjacoby
|
Allow closed topics to be split and merged into. Props netweb. Fixes #1714.
|
| [5312]
|
johnjamesjacoby
|
Use 'array_diff()` rather than `array_intersect()` in `bbp_pre_get_posts_normalize_forum_visibility()` to allow custom `post_type` queries (that still include forums/topics/replies) to pass through without hidden/private forum `meta_data` assistance. Fixes #2471.
|
| [5311]
|
johnjamesjacoby
|
Use correct uppercase type hinting for forum meta queries.
|
| [5310]
|
johnjamesjacoby
|
Allow topic-tag descriptions to be edited theme-side. Props netweb. Fixes #1613.
|