| [5681]
|
johnjamesjacoby
|
Topics: Use `sanitize_key()` on `select_id` in dropdown helpers.
|
| [5680]
|
johnjamesjacoby
|
Topics: Audit `template.php`:
* Add filters to `is_sticky` functions
* Pass `$args` into more filters
* Escape more gettext output
* Fix a few `bbp_parse_args` filter names copied from forums component
* Un-nest a few complex-looking lines
|
| [5679]
|
netweb
|
Tests: Code formatting improvements to `BBP_UnitTestCase`
* Remove whitespace surrounding array keys
* Remove whitespace in cast statements
* Whitespace beside `!` operators
* Yoda conditions
|
| [5678]
|
netweb
|
Tests: Remove `bbp_create_initial_content()` from `tests/phpunit/includes/install.php`
* WordPress' test suite resets post and taxonomy content between each test via `WP_UnitTestCase::setUp`
|
| [5677]
|
netweb
|
Tests: Add PHPUnit factory's for topics and replies:
* New class `BBP_UnitTest_Factory_For_Topic` for creating topics in PHPUnit tests
* New class `BBP_UnitTest_Factory_For_Reply` for creating replies in PHPUnit tests
|
| [5676]
|
johnjamesjacoby
|
All: Update default values for `$args` parameters from empty strings to empty arrays.
This is a micro-optimization to avoid unnecessary calls to `wp_parse_str()` inside `bbp_parse_args()`.
|
| [5675]
|
johnjamesjacoby
|
Replies: Normalize admin links:
* Remove superfluous `(int)` type casts
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
* Whitespace beside `!` operators
|
| [5674]
|
johnjamesjacoby
|
Topics: Normalize admin links:
* Remove superfluous `(int)` type cast
* Pass `$args` into filters
* Use `bbp_get_edit_rewrite_id()` where applicable
|
| [5673]
|
netweb
|
Add support for BuddyPress PHPUnit test integration
* Bootstrap and load `/src/bbpress.php` when loading the test environment
* Detect and load BuddyPress when running the BuddyPress PHPUnit tests
* Setup `BP_UnitTest_Factory` in `BBP_UnitTestCase` during new BuddyPress PHPUnit test integration
* Bootstrap and load new factory class `BBP_UnitTest_Factory_For_Forum` for creating forums
Props boonebgorges. See #2782
|
| [5672]
|
netweb
|
Exclude BuddyPress tests when running `phpunit`
BuddyPress unit testing will conflict with stand alone bbPress user testing, when BuddyPress is active the core members component cannot be deactivated thus testing users with BuddyPress at `/member/username` vs bbPress only `/user/username` and custom rewrites `/custom-user-slug/username` will cause conflicts in user PHPUnit tests.
A new Grunt sub task `grunt phpunit:buddypress` has been added to test BuddyPress integration with bbPress without compromising bbPress standalone PHPUnit testing.
Props netweb. See #2782
|
| [5671]
|
netweb
|
Remove `BBP_UnitTestCase::knownBBPBug` PHPUnit tests support for bbPress unclosed Trac tickets.
See #WP30284 and #BuddyPress6223
|
| [5670]
|
netweb
|
Fix i18n `_n()` plurals placeholders missed in r5668 in `bbp_admin_repair_closed_topics()`
|
| [5669]
|
netweb
|
Topics: Fix missing meta data during new closed topic creation
* In `bbp_new_topic_handler()` check if the post status is `closed` and close using `bbp_close_topic()`
* In `bbp_close_topic()` allow topics to be properly closed if `_bbp_status` is missing from topic meta
Props netweb. Fixes #2653
|
| [5668]
|
netweb
|
Tools: Introduce "Repair closed topics tool" `bbp_admin_repair_closed_topics()`
See #2653
|
| [5667]
|
netweb
|
Topics: Update `bbp_open_topic()` and `bbp_close_topic()` `@uses` documentation missed in r5656
See #2653
|
| [5666]
|
johnjamesjacoby
|
Users: Add missing textdomains to new strings. See #2780.
|
| [5665]
|
johnjamesjacoby
|
Users: Update filter name in `bbp_edit_user_email_send_notification()` to be a bit more clear. See #2780.
|
| [5664]
|
johnjamesjacoby
|
Users: Clean up email message string replacements in `bbp_edit_user_email_send_notification()`. See #2780.
|
| [5663]
|
johnjamesjacoby
|
Users: Email address change improvements:
* Introduce function for handling sending notification email
* Clean up code required to update, save, confirm, & dismiss pending email address changes
* Fixes bug in previous implementation making it impossible to interact with pending email address changes on multisite installations
Fixes #2780.
|
| [5662]
|
johnjamesjacoby
|
Users: Extract `$_GET` conditions out of `bbp_edit_user_handler()` and into their own function, hooked to `bbp_get_request` action.
This fixes functionality that was only half ported from `edit_user()` & WordPress multisite which allows a user to confirm or dismiss pending email address changes to their account from within their bbPress profile edit page.
See #2780.
|
| [5661]
|
johnjamesjacoby
|
Users: Introduce `bbp_notice_edit_user_email_change()` to notify user of a pending email address change to their account. See #2780.
|
| [5660]
|
johnjamesjacoby
|
Users: Remove pending email change markup from `form-user-edit.php`. See #2780.
|
| [5659]
|
johnjamesjacoby
|
API: Add more context to`bbp_redirect()` documentation. See #2778.
|
| [5658]
|
johnjamesjacoby
|
API: Introduce `bbp_redirect()`
* Wraps `wp_safe_redirect()` & `exit()` calls
* Prevents errors from potentially empty `wp_get_referrer()` results
* Replace `wp_safe_redirect()` usages with `bbp_redirect()`
Fixes #2778.
|
| [5657]
|
johnjamesjacoby
|
Users: Update `bbp_check_user_edit()`:
* Update `@uses` in docblock
* Add filters to allow overriding result & redirect_to URL
* Bail instead of indent
* Move `bbp_get_displayed_user_id()` into reusable variable
Fixes #2777.
|
| [5656]
|
netweb
|
Don't create post revisions when opening topics in `bbp_open_topic()` or closing topics in `bbp_close_topic()` as post content does not change.
Props netweb. See #2653
|
| [5655]
|
netweb
|
Forums: Fix missing meta data during new forum creation
* Call `bbp_open_forum()` if the forum is "open" to add the forum `_bbp_status` = `open` meta
* Call `bbp_normalize_forum()` if the forum is a "forum" to add the forum `_bbp_forum_type` = `forum` meta
Props netweb. Fixes #2647
|
| [5654]
|
netweb
|
Akismet: Pass additional user and post information to Aksimet helping identify suspicious new posts
* `comment_total`: Total user posts via `bbp_get_user_post_count()`
* `comment_last_active_gmt`: Topic last active time via `bbp_get_topic_last_reply_id()`
* `comment_account_registered_gmt`: User registered via `$userdata->user_registered`
Props eoigal. Fixes #2591
|
| [5653]
|
netweb
|
BuddyPress: Use `bbp_is_favorites_active()` and `bbp_is_subscriptions_active()` respectively to check if bbPress' favorites and/or subscriptions are enabled before displaying menu items in BuddyPress member profiles.
Props tharsheblows. Fixes #2594
|
| [5652]
|
netweb
|
CSS: Include relevant topic and search CSS classes alongside existing reply responsive media queries for mobile search results.
Props netweb. Fixes #2486
|
| [5651]
|
netweb
|
Don't create post revisions when updating replies menu order in `bbp_update_reply_position()` as there's no post content changed.
Props netweb. Fixes #2656
|
| [5650]
|
netweb
|
Subscriptions are both forums and topics, remove "Topic" from single slug setting description.
Props netweb. Fixes #2709
|
| [5649]
|
netweb
|
Bring Gruntfile.js tasks up to speed with BuddyPress
* Adds a `src` target for `jsvalidate` to validate JavaScript files in the `/src` folder
* WordPress JavaScript coding standards improvements
* See also r5614
Props netweb. Fixes #2766
|
| [5648]
|
netweb
|
Update NPM Grunt package: grunt-sass v0.18.1
|
| [5647]
|
johnjamesjacoby
|
Tag 2.5.6 (from 2.5 branch)
|
| [5646]
|
johnjamesjacoby
|
Update `bbpress.pot` (2.5 branch)
|
| [5645]
|
johnjamesjacoby
|
Include `2.5.6` changelog entry in `readme.txt`. (trunk)
|
| [5644]
|
johnjamesjacoby
|
Bump 2.5 branch version to `2.5.6`. Include `2.5.6` changelog entry in `readme.txt`.
|
| [5643]
|
johnjamesjacoby
|
Backport `do_not_reply` email address code from trunk to 2.5 branch (for what will be 2.5.6.) See #2618, r5642.
|
| [5642]
|
johnjamesjacoby
|
Update `bbp_get_do_not_reply_address()` to use `$_SERVER['SERVER_NAME']` over `get_home_url()` to improve compatibility with mapped domains and more complex installations. See #2618 (trunk)
|
| [5641]
|
johnjamesjacoby
|
Code Improvement:
* Add `$Id$` Subversion keyword property to `/src/bbpress.php`.
* Hat tip netweb. See #1851.
|
| [5640]
|
netweb
|
Use `preg_replace` over incorrect `ltrim` usage in `bbp_get_do_not_reply_address()` causing undeliverable or invalid subscription emails in certain situations because the "from" address was incorrect.
Props DJPaul. See #2618 (trunk)
|
| [5639]
|
netweb
|
Use `preg_replace` over incorrect `ltrim` usage in `bbp_get_do_not_reply_address()` causing undeliverable or invalid subscription emails in certain situations because the "from" address was incorrect.
Props DJPaul. See #2618 (2.5 Branch)
|
| [5638]
|
johnjamesjacoby
|
Bye. Props djpaul. See #2771 (2.5 branch)
|
| [5637]
|
johnjamesjacoby
|
Update any relevant hardcoded links to https.
|
| [5636]
|
johnjamesjacoby
|
Bye. Props djpaul. See #2771 (trunk)
|
| [5635]
|
netweb
|
Updated `_admin.scss` via WP:changeset:31648 for `grunt-sass` v0.18.0 compatibility via r5624 See #2583
|
| [5634]
|
netweb
|
Tag 2.5.5.
|
| [5633]
|
johnjamesjacoby
|
Update readme.txt for 2.5.5.
|
| [5632]
|
johnjamesjacoby
|
Update `bbpress.pot` for 2.5.5 release. (2.5 branch)
|
| [5631]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.5.
|
| [5630]
|
johnjamesjacoby
|
Add capability checks to admin-area ajax methods, and port nonce checks & js from trunk. Props jdgrimes. (2.5 branch)
|
| [5629]
|
johnjamesjacoby
|
Add nonce to bulk-user dropdown. Props jdgrimes. (2.5 branch)
|
| [5628]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (2.5 branch)
|
| [5627]
|
johnjamesjacoby
|
Add capability checks to admin-area ajax methods. Props jdgrimes. (trunk)
|
| [5626]
|
johnjamesjacoby
|
Add nonce to bulk-user dropdown. Props jdgrimes. (trunk)
|
| [5625]
|
johnjamesjacoby
|
Use `hash_equals()` when comparing email hash to submission link. Props jdgrimes. (trunk)
|
| [5624]
|
johnjamesjacoby
|
Update NPM Grunt packages:
* Replace "Community" with "Contributors"
* Remove `grunt-banner` as it is no longer used
* `grunt-cssjanus` v0.2.3
* `grunt-sass` v018.0
See #2766.
|
| [5623]
|
netweb
|
Update NPM Grunt packages:
* `grunt-contrib-copy` v0.8.0
* `grunt-contrib-uglify` v~0.8.0
* `grunt-contrib-jshint` v~0.11.0
* `grunt-wp-i18n` v~0.5.0
Fixes #2766
Each of these packages updates results in no change to the `/build` folder via `grunt build` or `/src` folder.
|
| [5622]
|
netweb
|
Remove `onevar` from `.jshintrc`, as of JSHint v2.5 `onevar` is no longer an option.
See #2746
|
| [5621]
|
netweb
|
Update grunt-patch-wordpress to 0.3.0
* Via #WP31466 / [wp:changeset:31557]
* This new update includes the following changes:
* the tools directory can now be patched along with a handful of other root level files that were failing
* If patching fails and issues a prompt, you can now interact with the prompt
* we only save the watch file to your directory if you pass the --debug flag
* we default to selecting the newest patch rather then the oldest patch
* Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.2.1...0.3.0
Props ocean90 netweb kadamwhite aaronjorbin. Fixes #2765
|
| [5620]
|
netweb
|
Updated `_admin.scss` via WP:changeset:31564. See #2583
|
| [5619]
|
netweb
|
Build Tools: Include PHP-7 "nightly" builds with failures allowed in Travis-CI
|
| [5618]
|
johnjamesjacoby
|
Update `bbp_setup_current_user()` to avoid output in WordPress Customizer. Fixes #2309. See #WP24169.
|
| [5617]
|
netweb
|
Restore PHP 5.2 to Travis CI
* Travis restored PHP 5.2 support late last week.
Fixes #2753
|
| [5616]
|
netweb
|
Temporarily (I hope) remove PHP 5.2 from tests being run on travis-ci
Travis-ci has disabled PHP 5.2. This has happened before when 5.2 didn't compile and then was restored when that was fixed.
See upstream issues:
* #WP31244
* https://github.com/travis-ci/travis-ci/issues/3152
* https://github.com/WP-API/WP-API/issues/846
See #2753
|
| [5615]
|
nacin
|
bbPress 1.x: Use the same user cache group names as WordPress.
See also https://backpress.trac.wordpress.org/changeset/360.
|
| [5614]
|
johnjamesjacoby
|
Bring `Gruntfile.js` tasks up to speed with BuddyPress.
|
| [5613]
|
johnjamesjacoby
|
In `bbp_notify_forum_subscribers()` remove incorrect array assignment. Fixes bug where `$headers` would be a multidimensional array, causing `wp_mail()` to complain.
|
| [5612]
|
johnjamesjacoby
|
Update readme.txt:
* Modernize verbiage
* Split up `Installation` section for clarity
* Switch links to use `example.com`
* Update tested version to 4.1
* Fix speeling errors
|
| [5611]
|
johnjamesjacoby
|
Check for `IXR_Value` class before including BackPress's version.
Avoids collisions when deeply integrated with WordPress.
For 1.1 & 1.2 branches.
|
| [5610]
|
johnjamesjacoby
|
Port PHPUnit testing setup from BuddyPress. More to clean up here later.
Also adds 1 test to check for `bbpress()` function availability.
See #2542.
|
| [5609]
|
johnjamesjacoby
|
In `bbp_current_author_ip()` check `$_SERVER['REMOTE_ADDR']` before attempting to parse it.
If it is empty (more likely for unit tests, but could be other oddities) we set it to '0.0.0.0' to do two things:
* Indicate to keymasters that something is amiss
* Allow `bbp_current_author_ip()` to proceed normally for the end-user
Fixes #2750.
|
| [5608]
|
johnjamesjacoby
|
Prevent notices and warnings when template stack is empty. Fixes #2749.
|
| [5607]
|
johnjamesjacoby
|
In `bbp_version_updater()` only run update routines if a previous installation exists to update. Fixes #2748.
|
| [5606]
|
johnjamesjacoby
|
Fix notice in bozo plugin. For 1.2 branch. See r5598.
|
| [5605]
|
johnjamesjacoby
|
Avoid notices in bbPress's Akismet plugin. For 1.2 branch. See r5597.
|
| [5604]
|
johnjamesjacoby
|
`Call bb_get_user()` from `bb_get_user_by_nicename()`. For 1.2 branch. See r5595.
|
| [5603]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.2 branch)
|
| [5602]
|
johnjamesjacoby
|
Revert accidental line-change from r5601, #2747.
|
| [5601]
|
johnjamesjacoby
|
Avoid more notices when an object property is accessed while not existing in Bozo plugin. Props stephdau. Fixes #2747 (1.1 branch)
|
| [5600]
|
netweb
|
Remove `trailing` option from `.jshintrc`, as of JSHint v2.5 `trailing` is no longer an option.
See https://github.com/jshint/jshint/pull/1554
Fixes #2746
|
| [5599]
|
netweb
|
Include WordPress v4.1 in Travis CI tests
|
| [5598]
|
nacin
|
Fix notice in bozo plugin.
|
| [5597]
|
nacin
|
Avoid notices in bbPress Akismet plugin-like hack thing.
|
| [5596]
|
johnjamesjacoby
|
Check that `user_url` exists before attempting to allow it in max-links.
|
| [5595]
|
nacin
|
bbPress 1.x: Call bb_get_user() from bb_get_user_by_nicename().
This ensures that this gem runs from bb_get_user() on profile pages: "Re calculate the user's meta in case we're pulling from a value cached on another site". So far, we know this has manifested itself as causing incorrect pagination for activity on profile pages, based on which site did the initial caching.
In an ideal world, these "short" keys would use a magic getter on BP_User, but user objects in bbPress 1.x are mostly stdClass objects in practice. Fun times.
|
| [5594]
|
johnjamesjacoby
|
s/POST/GET/ from r5587. See #2742.
|
| [5593]
|
johnjamesjacoby
|
Cast value as `(int)` in `bbp_get_form_forum_parent()`, ensuring it is numerical for the remaining call stack. See #2742.
|
| [5592]
|
johnjamesjacoby
|
Use `sanitize_key()` in `forums/template.php` to ensure values are within expected boundaries. See #2742.
|
| [5591]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_profile_update_role()` to ensure role value is within expected boundaries. See #2742.
|
| [5590]
|
johnjamesjacoby
|
Use `sanitize_user()` in `bbp_user_maybe_convert_pass()` to ensure user login is within expected boundaries. See #2742.
|
| [5589]
|
johnjamesjacoby
|
Use `sanitize_key()` in `topics/functions.php` to ensure values are within expected boundaries. See #2742.
|
| [5588]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_get_form_reply_status_dropdown()` to ensure value is within expected boundaries. See #2742.
|
| [5587]
|
johnjamesjacoby
|
Use `sanitize_key()` in `bbp_post_request()` and `bbp_get_request()`, improving the predictability of possible actions. See #2742.
|
| [5586]
|
netweb
|
Add `grunt-banner` to replace deprecated banners in `cssmin`
|
| [5585]
|
netweb
|
|
| [5584]
|
netweb
|
Switch to container-based infrastructure on Travis CI.
The container-based infrastructure has more memory and more cores. It also is designed to startup faster. We give up the ability to use sudo, but we aren't using that right now so we should be good.
Props tw2113, netweb
Fixes #2736
|
| [5583]
|
johnjamesjacoby
|
Administrative support for for un/approving topics.
Props netweb, thebrandonallen. Fixes #2645.
|
| [5582]
|
netweb
|
Updated `_admin.scss` via WP:changeset:30531. See #2583
|