| [5806]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.5.8 (2.5 branch)
|
| [5805]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.6 (trunk)
|
| [5804]
|
netweb
|
Update Grunt dependencies in package.json:
* `grunt-checktextdomain` major version update (Improved task error handing)
* `grunt-contrib-jshint` patch version update
* `grunt-contrib-uglify` minor version update (causes some changes to minified JS)
* `grunt-sass` major version update ( underlying libsass update )
* `grunt-wp-i18n` patch version update
Fixes #2821
|
| [5803]
|
netweb
|
Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:31747, WP:changeset:31952, and WP:changeset:32075
* `_variables.scss` via WP:changeset:32051
See #2583
|
| [5802]
|
johnjamesjacoby
|
Always predefine `$args` as an array, for code consistency across all components.
|
| [5801]
|
netweb
|
Tests: Update `test_bbp_create_initial_content()` to not use hard coded forum, topic and reply id's.
|
| [5800]
|
netweb
|
Importers: Updated AIM, YIM, and Jabber user meta key prefixes importer user profile fields for AEF, FluxBB, Kunena3, MyBB, PunBB, SMF, XMB, vBulletin and vBulletin3 importers
Props netweb. Fixes #2815
|
| [5799]
|
netweb
|
Example importer: Change AIM, YIM, and Jabber profile fields to generic examples with meta key prefixes
Props netweb. See #2815
|
| [5798]
|
netweb
|
phpBB Importer: Missed forum total topic and total reply count schema change
See #2716
|
| [5797]
|
netweb
|
phpBB importer: Updated AIM, YIM, and Jabber user meta key prefixes
Props netweb. See #2815
|
| [5796]
|
netweb
|
phpBB importer: Include Subscribed Forums, Subscribed Topics and Favourite Topics
Props netweb. See #2668
|
| [5795]
|
netweb
|
Importers: Update phpbB importer to support phpBB 3.1.x database schema changes
* Note: Importing from phpBB 3.0.x is no longer supported, please update to phpBB 3.1.x before importing
Props netweb. Fixes #2716
|
| [5794]
|
netweb
|
Tests: Remove instances of `bbp_clean_post_cache()` no longer required in topic template counts tests
Props thebrandonallen. Fixes #2812
|
| [5793]
|
netweb
|
Add `autocomplete="off"` to password field on login widget, user login form, and converter form.
Props pareshradadiya. Fixes #2772
|
| [5792]
|
netweb
|
Tests: Updated forum component count functions tests
Props thebrandonallen, netweb. See #2801
|
| [5791]
|
netweb
|
Tests: Tests for the common component query functions
* `public function test_bbp_get_public_child_ids()` for `bbp_get_public_child_ids()`
* `public function test_bbp_get_public_child_count()` for `bbp_get_public_child_count()`
Props thebrandonallen, netweb. See #2801
|
| [5790]
|
netweb
|
Common: Updated PHPDocs for `bbp_get_public_child_ids()`
|
| [5789]
|
netweb
|
Tests: Remove erroneous assertion in `test_bbp_get_all_child_ids()`
|
| [5788]
|
netweb
|
Common: Include `bbp_get_pending_status_id()` post status for topic and reply post type cases in `bbp_get_all_child_ids()` and PHPDoc fixes including addition of missing `@since` revision
Props netweb. Fixes #2810
|
| [5787]
|
netweb
|
Tests: Test `test_bbp_get_all_child_ids()` for `bbp_get_all_child_ids()`
Props thebrandonallen, netweb. See #2810, #2801
|
| [5786]
|
netweb
|
Tests: Tests for the `bbp_get_forum_last_*()` template functions.
|
| [5785]
|
netweb
|
Tests: Add test `test_bbp_update_topic_forum_id()` for `bbp_update_topic_forum_id()`
|
| [5784]
|
netweb
|
Tests: Tests for the reply status template functions.
|
| [5783]
|
netweb
|
Tools: Forums should not include forum meta key `_bbp_forum_id`, forums with this meta key were due to either:
1) Incorrectly added by the `bbp_admin_repair_forum_meta()` repair tool
2) Incorrectly added by an old version of one of the included bbPress importers, these were fixed in r5526
Props netweb. Fixes #2669
|
| [5782]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_forum_meta()` for `bbp_admin_repair_forum_meta()`
Props netweb. See #2669
|
| [5781]
|
netweb
|
Tests: Spam and Unspam reply function tests:
* `test_bbp_spam_reply()` for `bbp_spam_reply()`
* `test_bbp_unspam_reply()` for `bbp_unspam_reply()`
|
| [5780]
|
netweb
|
Tests: Updated topic component count functions tests
Props thebrandonallen, netweb. See #2801
|
| [5779]
|
netweb
|
Tests: Adds forum, topic and reply insert function tests:
* `test_bbp_insert_forum()` for `bbp_insert_forum()`
* `test_bbp_insert_topic()` for `bbp_insert_topic()`
* `test_bbp_insert_reply()` for `bbp_insert_reply()`
Props netweb. Fixes #2805
|
| [5778]
|
netweb
|
Topics: When moving a topic update the topics post parent in `bbp_move_topic_handler()`, includes unit test `test_bbp_move_topic_handler()`
Props netweb. See #2322
|
| [5777]
|
netweb
|
Tests: Fix failing test `test_bbp_update_forum_topic_count()`
Props thebrandonallen. See #2801
|
| [5776]
|
netweb
|
Topics: Pass correct array value `post_author` to `bbp_update_topic()` in `bbp_insert_topic()` added in r5775
See #2805
|
| [5775]
|
johnjamesjacoby
|
Inserts: When inserting a forum/topic/reply, immediately update the new object so hierarchy is refreshed.
This commit addresses the last active post ID being incorrect after inserting topics and replies to a forum, and fixes a failing test (in `BBP_Tests_Core_Update::test_bbp_create_initial_content`).
See #2805.
|
| [5774]
|
johnjamesjacoby
|
Cache: Much more sane cache invalidation.
This change improves hierarchical forum/topic/reply cache invalidations by not requiring each call to be strategically placed between actions to avoid race conditions.
Props thebrandonallen. Fixes #2800.
|
| [5773]
|
netweb
|
Tests: Add post meta test assertions to `test_bbp_create_initial_content()`, see #2805
|
| [5772]
|
johnjamesjacoby
|
Add `.htaccess`, `.DS_Store`, and `.gitignore` to `.gitignore`, taking influence from WordPress core.
Hat-tip netweb. See #2802.
|
| [5771]
|
johnjamesjacoby
|
Set `svn-autoprops`.
This was introduced in Subversion 1.8 specifically to allow common properties for all present and future files in the project, and avoids setting individual properties on most files and prevents errors from skipping properties when new files are introduced.
Hat-tip DJPaul. See r5770, #2802.
|
| [5770]
|
johnjamesjacoby
|
Tidy up SVN properties.
* This first steps removes `svn:eol-style`, `svn:executable`, `svn:mime-type` on all files.
* The `svn:ignore` and `svn:global-ignores` properties have been tidied up to match WordPress core.
* A subsequent commit will re-instate `svn:mime-type` via `svn:auto-props`.
Hat-tip DJPaul. See #2802.
|
| [5769]
|
netweb
|
Tests: Added integer differential bump count assertions to `test_bbp_bump_topic_reply_count()` and `test_bbp_bump_topic_reply_count_hidden()` tests
Props thebrandonallen. See #2801
|
| [5768]
|
netweb
|
Topics: Correct PHPDoc in `bbp_bump_topic_reply_count()` and `bbp_bump_topic_reply_count_hidden()` functions
|
| [5767]
|
netweb
|
Tests: Improved performance of forum component count template function tests
Props thebrandonallen. See #2801
|
| [5766]
|
netweb
|
Tests: Improved performance and use `bbp_clean_post_cache()` in topics template counts function tests
Props thebrandonallen. See #2081
|
| [5765]
|
netweb
|
Tests: Rename forums forum functions test file name
|
| [5764]
|
netweb
|
Tests: Tests: Skeleton test placeholders for topics topic functions
|
| [5763]
|
netweb
|
Tests: Tests: Skeleton test placeholders for replies reply functions
|
| [5762]
|
netweb
|
Tests: Skeleton test placeholders for reply status functions.
|
| [5761]
|
netweb
|
Tests: Skeleton test placeholders for topic status functions.
|
| [5760]
|
netweb
|
Tests: Skeleton test placeholders for topic update last functions
|
| [5759]
|
netweb
|
Tests: Skeleton test placeholders for reply template functions
|
| [5758]
|
netweb
|
Tests: Skeleton test placeholders for reply link template functions
|
| [5757]
|
netweb
|
Tests: Skeleton test placeholders for topic tag functions.
|
| [5756]
|
netweb
|
Tests: Fix duplicate `@group` annotation for topic tags template function tests
|
| [5755]
|
netweb
|
Tests: Remove incorrect class prefix from `@covers` annotations in user functions tests
|
| [5754]
|
netweb
|
Tests: Skeleton test placeholders for search functions and template functions
|
| [5753]
|
netweb
|
Tests: Skeleton test placeholders for topic template functions
|
| [5752]
|
netweb
|
Tests: Skeleton test placeholders for topic link template functions
|
| [5751]
|
netweb
|
Tests: Skeleton test placeholders for topic get last template functions
|
| [5750]
|
netweb
|
Tests: Skeleton test placeholders for topic tag template functions.
|
| [5749]
|
netweb
|
Tests: Skeleton test placeholders for topic status template functions.
|
| [5748]
|
netweb
|
Tests: Skeleton test placeholders for user component functions.
|
| [5747]
|
netweb
|
Tests: Rename user favorites test class, favorites ends in a single `s`
|
| [5746]
|
netweb
|
Tests: Add post type object and hierarchical test assertions for forum, topic and reply post types.
|
| [5745]
|
netweb
|
Tests: Skeleton test placeholders for forum update last functions
|
| [5744]
|
netweb
|
Tests: Tests: Skeleton test placeholders for forums forum functions
|
| [5743]
|
netweb
|
Tests: Skeleton test placeholders for forum statuses and types functions
|
| [5742]
|
netweb
|
Tests: Skeleton test placeholders for forum visibility functions.
|
| [5741]
|
netweb
|
Tests: Improved performance of user component count function tests, now 33⅓% faster
Props thebrandonallen. See #2081
|
| [5740]
|
netweb
|
Tests: Test an array of posts not the total post counts:
* Test the forum's topic ids in `test_bbp_forum_query_topic_ids()`
* Test the forum's subforum ids in `test_bbp_forum_query_subforum_ids()`
Props thebrandonallen, netweb. See #2801
|
| [5739]
|
johnjamesjacoby
|
Common: Improve type-casting return values in query functions.
Props thebrandonallen, netweb. See #2801.
|
| [5738]
|
johnjamesjacoby
|
Topics: Improve type-casting in topic functions.
Props thebrandonallen, netweb. See #2801.
|
| [5737]
|
johnjamesjacoby
|
Replies: Improve type-casting in reply functions. Also use newly created `bbp_update_reply_to_id()` function in `bbp_update_reply_to()`.
Props thebrandonallen, netweb. See #2801.
|
| [5736]
|
johnjamesjacoby
|
Core: Correct phpdoc to `_update_` functions. Also introduce `bbp_update_reply_to_id()` to help with saving of hierarchical reply metadata. (Will be used in a future commit.)
|
| [5735]
|
johnjamesjacoby
|
Core: Return the filtered results of ID's in core `_update_` functions.
This helps with various type-casting improvements going into #2801.
|
| [5734]
|
johnjamesjacoby
|
Forums: Type-cast improvements to `bbp_forum_query_last_reply_id()`.
Fixes bug where strict `false` comparison would cache cache condition to never occur.
Props thebrandonallen, netweb. See #2801.
|
| [5733]
|
johnjamesjacoby
|
Core: Force-clear post caches on several common moderation actions.
Fixes inconsistencies around cached objects related to counts, which are currently stored in metadata.
Props thebrandonallen, netweb. See #2801.
|
| [5732]
|
johnjamesjacoby
|
Bumps: Normalize type-casting in bump functions.
Props thebrandonallen, netweb. See #2801.
|
| [5731]
|
johnjamesjacoby
|
Forums: Normalize type-casting in some count functions. More to do here.
Props thebrandonallen, netweb. See #2801.
|
| [5730]
|
johnjamesjacoby
|
Common: Additional type-casting in query functions.
Ensures direct query results return a consistent, testable value.
Props thebrandonallen, netweb. See #2801.
|
| [5729]
|
johnjamesjacoby
|
Topics: In `bbp_move_topic_handler()`, clean both old and new forum caches before updating forum hierarchies.
Fixes issue where moving a topic would result in incorrect counts for both forums, due to out-of-date cache values.
Props thebrandonallen. Fixes #2322.
|
| [5728]
|
netweb
|
Fix copy pasta placeholder argument in `loop-single-topic.php` template
Props netweb. Fixes #2799
|
| [5727]
|
netweb
|
Add `bbp_rel_nofollow` and `wp_unslash` filters to `bbp_get_topic_reply_link` and `bbp_get_reply_to_link` topic reply links.
Props netweb. Fixes #2515
|
| [5726]
|
netweb
|
Tests: Topic and Reply revisions template function unit tests
|
| [5725]
|
netweb
|
Tests: Topic and Reply loop template function unit tests
|
| [5724]
|
netweb
|
Tests: Topic and Reply forms template function unit tests
|
| [5723]
|
netweb
|
Tests: Topic and Reply authors template function unit tests
|
| [5722]
|
netweb
|
Tests: Topic and Reply post type template function unit tests
|
| [5721]
|
netweb
|
Tests: Forum template tests:
* Skip forum URL tests in multisite for now, we need a more robust permalink test setup first.
* Remove a couple of poorly architected tests so our tests pass
|
| [5720]
|
netweb
|
Tests: Skip feed URL tests in multisite for now, we need a more robust permalink test setup first.
|
| [5719]
|
netweb
|
Tests: Remove copy pasta parameters to fix topic count tests
* Manually flush the cache, our setup/teardown needs more work here.
Props thebrandonallen. Fixes #2796
|
| [5718]
|
netweb
|
Add missing @since phpdoc to `bbp_get_public_child_count()` and `bbp_get_public_child_ids()` functions
|
| [5717]
|
netweb
|
Tests: Tests for the topic component count template functions `/includes/topics/template.php`
|
| [5716]
|
netweb
|
Tests: Tests for the topic component count functions `/includes/topics/template.php`
|
| [5715]
|
netweb
|
Tests: Fix copy pasta in forums count functions tests:
* `test_bbp_update_forum_topic_count_hidden()`
* `test_bbp_update_forum_reply_count()`
|
| [5714]
|
netweb
|
Topics: Filter `bbp_get_topic_reply_count_hidden` to format the output, to match other count functions.
|
| [5713]
|
netweb
|
Tests: Core Update initial pass unit tests for /includes/core/update.php
|
| [5712]
|
netweb
|
Install/Update: Don't add reply titles in sample forum content `bbp_create_initial_content()`, reply title requirements were removed in r5177.
Props netweb. Fixes #2795
|
| [5711]
|
johnjamesjacoby
|
Common: Use `esc_url()` in `bbp_redirect_to_field()` and late escape for clarity.
|
| [5710]
|
netweb
|
Tests: Fix forums functions tests:
* Fix `test_bbp_bump_forum_topic_count_hidden` per r5709
* Replace some debug comments in `test_bbp_update_forum_topic_count`
|
| [5709]
|
johnjamesjacoby
|
Topics: Filter `bbp_get_forum_topic_count_hidden` to format the output, to match other count functions.
|
| [5708]
|
johnjamesjacoby
|
Tests: Fix more of the tests. See r5703.
|
| [5707]
|
netweb
|
Tests: Forum counts and query functions `/includes/forums/functions.php`
|